[jira] [Commented] (GEODE-735) OffHeapHelper needs unit test

2016-01-28 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122685#comment-15122685
 ] 

ASF subversion and git services commented on GEODE-735:
---

Commit 46eaaa9b10fe11101c8f7e0c8cb601d43789ceca in incubator-geode's branch 
refs/heads/feature/GEODE-831 from [~khowe]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=46eaaa9 ]

GEODE-735: create unit test for OffHeapHelper

This closes #79


> OffHeapHelper needs unit test
> -
>
> Key: GEODE-735
> URL: https://issues.apache.org/jira/browse/GEODE-735
> Project: Geode
>  Issue Type: Sub-task
>  Components: offheap
>Reporter: Kenneth Howe
>Assignee: Kenneth Howe
> Fix For: 1.0.0-incubating.M2
>
>
> OffHeapHelper currently has 30% test coverage and there are no unit tests



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEODE-735) OffHeapHelper needs unit test

2016-01-28 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122178#comment-15122178
 ] 

ASF subversion and git services commented on GEODE-735:
---

Commit 46eaaa9b10fe11101c8f7e0c8cb601d43789ceca in incubator-geode's branch 
refs/heads/develop from [~khowe]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=46eaaa9 ]

GEODE-735: create unit test for OffHeapHelper

This closes #79


> OffHeapHelper needs unit test
> -
>
> Key: GEODE-735
> URL: https://issues.apache.org/jira/browse/GEODE-735
> Project: Geode
>  Issue Type: Sub-task
>  Components: offheap
>Reporter: Kenneth Howe
>Assignee: Kenneth Howe
>
> OffHeapHelper currently has 30% test coverage and there are no unit tests



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEODE-735) OffHeapHelper needs unit test

2016-01-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122180#comment-15122180
 ] 

ASF GitHub Bot commented on GEODE-735:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/79


> OffHeapHelper needs unit test
> -
>
> Key: GEODE-735
> URL: https://issues.apache.org/jira/browse/GEODE-735
> Project: Geode
>  Issue Type: Sub-task
>  Components: offheap
>Reporter: Kenneth Howe
>Assignee: Kenneth Howe
>
> OffHeapHelper currently has 30% test coverage and there are no unit tests



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEODE-735) OffHeapHelper needs unit test

2016-01-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122094#comment-15122094
 ] 

ASF GitHub Bot commented on GEODE-735:
--

Github user dschneider-pivotal commented on the pull request:

https://github.com/apache/incubator-geode/pull/79#issuecomment-176335606
  
I reviewed the test and it looks good. I'll pull it in.



> OffHeapHelper needs unit test
> -
>
> Key: GEODE-735
> URL: https://issues.apache.org/jira/browse/GEODE-735
> Project: Geode
>  Issue Type: Sub-task
>  Components: offheap
>Reporter: Kenneth Howe
>Assignee: Kenneth Howe
>
> OffHeapHelper currently has 30% test coverage and there are no unit tests



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEODE-735) OffHeapHelper needs unit test

2016-01-26 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118257#comment-15118257
 ] 

ASF GitHub Bot commented on GEODE-735:
--

GitHub user pdxrunner opened a pull request:

https://github.com/apache/incubator-geode/pull/79

GEODE-735: Create JUnit tests for OffHeapHelper

Added OffHeapHelperJUnitTest class

Pre-checkin run - 2 failures, both previously reported and not related to 
OffHeap

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pdxrunner/incubator-geode feature/GEODE-735

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #79


commit a65e8f9198d3e1de4205730e51a724d7b4f7c452
Author: Ken Howe 
Date:   2016-01-26T22:37:18Z

GEODE-735: Create JUnit tests for 
com.gemstone.gemfire.internal.offHeap.OffHeapHelper class




> OffHeapHelper needs unit test
> -
>
> Key: GEODE-735
> URL: https://issues.apache.org/jira/browse/GEODE-735
> Project: Geode
>  Issue Type: Sub-task
>  Components: offheap
>Reporter: Kenneth Howe
>Assignee: Kenneth Howe
>
> OffHeapHelper currently has 30% test coverage and there are no unit tests



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)