[jira] [Commented] (GEODE-953) SerializableExternalResource and SerializableRuleChain should extend rather than borrow JUnit code
[
https://issues.apache.org/jira/browse/GEODE-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172946#comment-15172946
]
ASF subversion and git services commented on GEODE-953:
---
Commit b4ed2aa5087fab377ce5d2bd55350fd5b42a54a4 in incubator-geode's branch
refs/heads/feature/GEODE-949-2 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=b4ed2aa ]
GEODE-953: Fix missing junit category
> SerializableExternalResource and SerializableRuleChain should extend rather
> than borrow JUnit code
> --
>
> Key: GEODE-953
> URL: https://issues.apache.org/jira/browse/GEODE-953
> Project: Geode
> Issue Type: Bug
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> The override hooks that JUnit Rules provide allows a "before()" method to
> throw any Throwable (including checked exceptions), but does not allow an
> "after()" method to throw checked exceptions. See below:
> {noformat}
> protected void before() throws Throwable {
> protected void after() {
> {noformat}
> The currently committed versions of SerializableExternalResource and
> SerializableRuleChain borrow code from JUnit instead of extending JUnit
> classes to allow changing the after() to have a throws clause:
> {noformat}
> protected void after() {
> {noformat}
> If we choose to follow the JUnit best practice of having after() not perform
> any verifications (or otherwise be a very safe call that cannot throw checked
> exceptions), then we can change these classes to extend the JUnit classes
> instead of borrowing any code from JUnit.
> The Transaction and Off-Heap dunit tests should be changed to NOT perform any
> assertions during tearDown()/after(). There may be additional DUnit and JUnit
> tests that also need to change to bring them into line with the best practice
> Checked exceptions can also be wrapped in an Error or RuntimeException so
> this "limitation" could theoretically be worked around if necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-953) SerializableExternalResource and SerializableRuleChain should extend rather than borrow JUnit code
[
https://issues.apache.org/jira/browse/GEODE-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172945#comment-15172945
]
ASF subversion and git services commented on GEODE-953:
---
Commit 5342935d301a4026b289637885e9236414feeb78 in incubator-geode's branch
refs/heads/feature/GEODE-949-2 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=5342935 ]
GEODE-953: Cleanup geode-junit
* cleanup geode-junit usage of JUnit Rules to ensure JUnit code is always
extended rather than copied
* change CRLF to LF
* remove @author tags
* fix all javadocs
* fix formatting
* add new tests
* remove ExpectedTimeout and ExpectedTimeoutTest (they were dupes of
ExpectedTimeoutRule and ExpectedTimeoutRuleTest)
* use serialization by reflection for serializable subclasses of JUnit rules
that lack sufficient ability to subclass
* repackage rule tests to same package as rules
* repackage serializable rules into serializable sub-package
> SerializableExternalResource and SerializableRuleChain should extend rather
> than borrow JUnit code
> --
>
> Key: GEODE-953
> URL: https://issues.apache.org/jira/browse/GEODE-953
> Project: Geode
> Issue Type: Bug
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> The override hooks that JUnit Rules provide allows a "before()" method to
> throw any Throwable (including checked exceptions), but does not allow an
> "after()" method to throw checked exceptions. See below:
> {noformat}
> protected void before() throws Throwable {
> protected void after() {
> {noformat}
> The currently committed versions of SerializableExternalResource and
> SerializableRuleChain borrow code from JUnit instead of extending JUnit
> classes to allow changing the after() to have a throws clause:
> {noformat}
> protected void after() {
> {noformat}
> If we choose to follow the JUnit best practice of having after() not perform
> any verifications (or otherwise be a very safe call that cannot throw checked
> exceptions), then we can change these classes to extend the JUnit classes
> instead of borrowing any code from JUnit.
> The Transaction and Off-Heap dunit tests should be changed to NOT perform any
> assertions during tearDown()/after(). There may be additional DUnit and JUnit
> tests that also need to change to bring them into line with the best practice
> Checked exceptions can also be wrapped in an Error or RuntimeException so
> this "limitation" could theoretically be worked around if necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-953) SerializableExternalResource and SerializableRuleChain should extend rather than borrow JUnit code
[
https://issues.apache.org/jira/browse/GEODE-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172790#comment-15172790
]
ASF subversion and git services commented on GEODE-953:
---
Commit b4ed2aa5087fab377ce5d2bd55350fd5b42a54a4 in incubator-geode's branch
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=b4ed2aa ]
GEODE-953: Fix missing junit category
> SerializableExternalResource and SerializableRuleChain should extend rather
> than borrow JUnit code
> --
>
> Key: GEODE-953
> URL: https://issues.apache.org/jira/browse/GEODE-953
> Project: Geode
> Issue Type: Bug
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> The override hooks that JUnit Rules provide allows a "before()" method to
> throw any Throwable (including checked exceptions), but does not allow an
> "after()" method to throw checked exceptions. See below:
> {noformat}
> protected void before() throws Throwable {
> protected void after() {
> {noformat}
> The currently committed versions of SerializableExternalResource and
> SerializableRuleChain borrow code from JUnit instead of extending JUnit
> classes to allow changing the after() to have a throws clause:
> {noformat}
> protected void after() {
> {noformat}
> If we choose to follow the JUnit best practice of having after() not perform
> any verifications (or otherwise be a very safe call that cannot throw checked
> exceptions), then we can change these classes to extend the JUnit classes
> instead of borrowing any code from JUnit.
> The Transaction and Off-Heap dunit tests should be changed to NOT perform any
> assertions during tearDown()/after(). There may be additional DUnit and JUnit
> tests that also need to change to bring them into line with the best practice
> Checked exceptions can also be wrapped in an Error or RuntimeException so
> this "limitation" could theoretically be worked around if necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-953) SerializableExternalResource and SerializableRuleChain should extend rather than borrow JUnit code
[
https://issues.apache.org/jira/browse/GEODE-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172668#comment-15172668
]
ASF subversion and git services commented on GEODE-953:
---
Commit 5342935d301a4026b289637885e9236414feeb78 in incubator-geode's branch
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=5342935 ]
GEODE-953: Cleanup geode-junit
* cleanup geode-junit usage of JUnit Rules to ensure JUnit code is always
extended rather than copied
* change CRLF to LF
* remove @author tags
* fix all javadocs
* fix formatting
* add new tests
* remove ExpectedTimeout and ExpectedTimeoutTest (they were dupes of
ExpectedTimeoutRule and ExpectedTimeoutRuleTest)
* use serialization by reflection for serializable subclasses of JUnit rules
that lack sufficient ability to subclass
* repackage rule tests to same package as rules
* repackage serializable rules into serializable sub-package
> SerializableExternalResource and SerializableRuleChain should extend rather
> than borrow JUnit code
> --
>
> Key: GEODE-953
> URL: https://issues.apache.org/jira/browse/GEODE-953
> Project: Geode
> Issue Type: Bug
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> The override hooks that JUnit Rules provide allows a "before()" method to
> throw any Throwable (including checked exceptions), but does not allow an
> "after()" method to throw checked exceptions. See below:
> {noformat}
> protected void before() throws Throwable {
> protected void after() {
> {noformat}
> The currently committed versions of SerializableExternalResource and
> SerializableRuleChain borrow code from JUnit instead of extending JUnit
> classes to allow changing the after() to have a throws clause:
> {noformat}
> protected void after() {
> {noformat}
> If we choose to follow the JUnit best practice of having after() not perform
> any verifications (or otherwise be a very safe call that cannot throw checked
> exceptions), then we can change these classes to extend the JUnit classes
> instead of borrowing any code from JUnit.
> The Transaction and Off-Heap dunit tests should be changed to NOT perform any
> assertions during tearDown()/after(). There may be additional DUnit and JUnit
> tests that also need to change to bring them into line with the best practice
> Checked exceptions can also be wrapped in an Error or RuntimeException so
> this "limitation" could theoretically be worked around if necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-953) SerializableExternalResource and SerializableRuleChain should extend rather than borrow JUnit code
[
https://issues.apache.org/jira/browse/GEODE-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172585#comment-15172585
]
ASF subversion and git services commented on GEODE-953:
---
Commit b35ebd60da0a5021d63d3a65db4adfe3c2b206d4 in incubator-geode's branch
refs/heads/feature/GEODE-953 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=b35ebd6 ]
Merge remote-tracking branch 'origin/develop' into feature/GEODE-953
> SerializableExternalResource and SerializableRuleChain should extend rather
> than borrow JUnit code
> --
>
> Key: GEODE-953
> URL: https://issues.apache.org/jira/browse/GEODE-953
> Project: Geode
> Issue Type: Bug
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> The override hooks that JUnit Rules provide allows a "before()" method to
> throw any Throwable (including checked exceptions), but does not allow an
> "after()" method to throw checked exceptions. See below:
> {noformat}
> protected void before() throws Throwable {
> protected void after() {
> {noformat}
> The currently committed versions of SerializableExternalResource and
> SerializableRuleChain borrow code from JUnit instead of extending JUnit
> classes to allow changing the after() to have a throws clause:
> {noformat}
> protected void after() {
> {noformat}
> If we choose to follow the JUnit best practice of having after() not perform
> any verifications (or otherwise be a very safe call that cannot throw checked
> exceptions), then we can change these classes to extend the JUnit classes
> instead of borrowing any code from JUnit.
> The Transaction and Off-Heap dunit tests should be changed to NOT perform any
> assertions during tearDown()/after(). There may be additional DUnit and JUnit
> tests that also need to change to bring them into line with the best practice
> Checked exceptions can also be wrapped in an Error or RuntimeException so
> this "limitation" could theoretically be worked around if necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-953) SerializableExternalResource and SerializableRuleChain should extend rather than borrow JUnit code
[
https://issues.apache.org/jira/browse/GEODE-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172588#comment-15172588
]
ASF subversion and git services commented on GEODE-953:
---
Commit 9a6d17b39c63b34aa8ae49e46e996fc55d676760 in incubator-geode's branch
refs/heads/feature/GEODE-953 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=9a6d17b ]
Merge remote-tracking branch 'origin/develop' into feature/GEODE-953
> SerializableExternalResource and SerializableRuleChain should extend rather
> than borrow JUnit code
> --
>
> Key: GEODE-953
> URL: https://issues.apache.org/jira/browse/GEODE-953
> Project: Geode
> Issue Type: Bug
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> The override hooks that JUnit Rules provide allows a "before()" method to
> throw any Throwable (including checked exceptions), but does not allow an
> "after()" method to throw checked exceptions. See below:
> {noformat}
> protected void before() throws Throwable {
> protected void after() {
> {noformat}
> The currently committed versions of SerializableExternalResource and
> SerializableRuleChain borrow code from JUnit instead of extending JUnit
> classes to allow changing the after() to have a throws clause:
> {noformat}
> protected void after() {
> {noformat}
> If we choose to follow the JUnit best practice of having after() not perform
> any verifications (or otherwise be a very safe call that cannot throw checked
> exceptions), then we can change these classes to extend the JUnit classes
> instead of borrowing any code from JUnit.
> The Transaction and Off-Heap dunit tests should be changed to NOT perform any
> assertions during tearDown()/after(). There may be additional DUnit and JUnit
> tests that also need to change to bring them into line with the best practice
> Checked exceptions can also be wrapped in an Error or RuntimeException so
> this "limitation" could theoretically be worked around if necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-953) SerializableExternalResource and SerializableRuleChain should extend rather than borrow JUnit code
[
https://issues.apache.org/jira/browse/GEODE-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169486#comment-15169486
]
ASF subversion and git services commented on GEODE-953:
---
Commit ed5394e35de8f5b4fd59759ec9f2e9f806ba0688 in incubator-geode's branch
refs/heads/feature/GEODE-953 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=ed5394e ]
Merge remote-tracking branch 'origin/develop' into feature/GEODE-953
> SerializableExternalResource and SerializableRuleChain should extend rather
> than borrow JUnit code
> --
>
> Key: GEODE-953
> URL: https://issues.apache.org/jira/browse/GEODE-953
> Project: Geode
> Issue Type: Bug
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> The override hooks that JUnit Rules provide allows a "before()" method to
> throw any Throwable (including checked exceptions), but does not allow an
> "after()" method to throw checked exceptions. See below:
> {noformat}
> protected void before() throws Throwable {
> protected void after() {
> {noformat}
> The currently committed versions of SerializableExternalResource and
> SerializableRuleChain borrow code from JUnit instead of extending JUnit
> classes to allow changing the after() to have a throws clause:
> {noformat}
> protected void after() {
> {noformat}
> If we choose to follow the JUnit best practice of having after() not perform
> any verifications (or otherwise be a very safe call that cannot throw checked
> exceptions), then we can change these classes to extend the JUnit classes
> instead of borrowing any code from JUnit.
> The Transaction and Off-Heap dunit tests should be changed to NOT perform any
> assertions during tearDown()/after(). There may be additional DUnit and JUnit
> tests that also need to change to bring them into line with the best practice
> Checked exceptions can also be wrapped in an Error or RuntimeException so
> this "limitation" could theoretically be worked around if necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-953) SerializableExternalResource and SerializableRuleChain should extend rather than borrow JUnit code
[
https://issues.apache.org/jira/browse/GEODE-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169489#comment-15169489
]
ASF subversion and git services commented on GEODE-953:
---
Commit eb20383a50b9d447577da344046a138e9c21eff6 in incubator-geode's branch
refs/heads/feature/GEODE-953 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=eb20383 ]
Merge remote-tracking branch 'origin/develop' into feature/GEODE-953
> SerializableExternalResource and SerializableRuleChain should extend rather
> than borrow JUnit code
> --
>
> Key: GEODE-953
> URL: https://issues.apache.org/jira/browse/GEODE-953
> Project: Geode
> Issue Type: Bug
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> The override hooks that JUnit Rules provide allows a "before()" method to
> throw any Throwable (including checked exceptions), but does not allow an
> "after()" method to throw checked exceptions. See below:
> {noformat}
> protected void before() throws Throwable {
> protected void after() {
> {noformat}
> The currently committed versions of SerializableExternalResource and
> SerializableRuleChain borrow code from JUnit instead of extending JUnit
> classes to allow changing the after() to have a throws clause:
> {noformat}
> protected void after() {
> {noformat}
> If we choose to follow the JUnit best practice of having after() not perform
> any verifications (or otherwise be a very safe call that cannot throw checked
> exceptions), then we can change these classes to extend the JUnit classes
> instead of borrowing any code from JUnit.
> The Transaction and Off-Heap dunit tests should be changed to NOT perform any
> assertions during tearDown()/after(). There may be additional DUnit and JUnit
> tests that also need to change to bring them into line with the best practice
> Checked exceptions can also be wrapped in an Error or RuntimeException so
> this "limitation" could theoretically be worked around if necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-953) SerializableExternalResource and SerializableRuleChain should extend rather than borrow JUnit code
[
https://issues.apache.org/jira/browse/GEODE-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15168230#comment-15168230
]
ASF subversion and git services commented on GEODE-953:
---
Commit 247b7a8b307232c118e38f6369e6720cbc112da8 in incubator-geode's branch
refs/heads/feature/GEODE-953 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=247b7a8 ]
Merge remote-tracking branch 'origin/develop' into feature/GEODE-953
> SerializableExternalResource and SerializableRuleChain should extend rather
> than borrow JUnit code
> --
>
> Key: GEODE-953
> URL: https://issues.apache.org/jira/browse/GEODE-953
> Project: Geode
> Issue Type: Bug
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> The override hooks that JUnit Rules provide allows a "before()" method to
> throw any Throwable (including checked exceptions), but does not allow an
> "after()" method to throw checked exceptions. See below:
> {noformat}
> protected void before() throws Throwable {
> protected void after() {
> {noformat}
> The currently committed versions of SerializableExternalResource and
> SerializableRuleChain borrow code from JUnit instead of extending JUnit
> classes to allow changing the after() to have a throws clause:
> {noformat}
> protected void after() {
> {noformat}
> If we choose to follow the JUnit best practice of having after() not perform
> any verifications (or otherwise be a very safe call that cannot throw checked
> exceptions), then we can change these classes to extend the JUnit classes
> instead of borrowing any code from JUnit.
> The Transaction and Off-Heap dunit tests should be changed to NOT perform any
> assertions during tearDown()/after(). There may be additional DUnit and JUnit
> tests that also need to change to bring them into line with the best practice
> Checked exceptions can also be wrapped in an Error or RuntimeException so
> this "limitation" could theoretically be worked around if necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-953) SerializableExternalResource and SerializableRuleChain should extend rather than borrow JUnit code
[
https://issues.apache.org/jira/browse/GEODE-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167919#comment-15167919
]
ASF subversion and git services commented on GEODE-953:
---
Commit 6ff2011327155a7d68821e8909b3383006ece1e8 in incubator-geode's branch
refs/heads/feature/GEODE-953 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=6ff2011 ]
Merge remote-tracking branch 'origin/develop' into feature/GEODE-953
> SerializableExternalResource and SerializableRuleChain should extend rather
> than borrow JUnit code
> --
>
> Key: GEODE-953
> URL: https://issues.apache.org/jira/browse/GEODE-953
> Project: Geode
> Issue Type: Bug
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> The override hooks that JUnit Rules provide allows a "before()" method to
> throw any Throwable (including checked exceptions), but does not allow an
> "after()" method to throw checked exceptions. See below:
> {noformat}
> protected void before() throws Throwable {
> protected void after() {
> {noformat}
> The currently committed versions of SerializableExternalResource and
> SerializableRuleChain borrow code from JUnit instead of extending JUnit
> classes to allow changing the after() to have a throws clause:
> {noformat}
> protected void after() {
> {noformat}
> If we choose to follow the JUnit best practice of having after() not perform
> any verifications (or otherwise be a very safe call that cannot throw checked
> exceptions), then we can change these classes to extend the JUnit classes
> instead of borrowing any code from JUnit.
> The Transaction and Off-Heap dunit tests should be changed to NOT perform any
> assertions during tearDown()/after(). There may be additional DUnit and JUnit
> tests that also need to change to bring them into line with the best practice
> Checked exceptions can also be wrapped in an Error or RuntimeException so
> this "limitation" could theoretically be worked around if necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-953) SerializableExternalResource and SerializableRuleChain should extend rather than borrow JUnit code
[
https://issues.apache.org/jira/browse/GEODE-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163891#comment-15163891
]
ASF subversion and git services commented on GEODE-953:
---
Commit d93a2aacb8a66db9dfeddb961a7434a67152b3fd in incubator-geode's branch
refs/heads/feature/GEODE-953 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=d93a2aa ]
Merge remote-tracking branch 'origin/develop' into feature/GEODE-953
> SerializableExternalResource and SerializableRuleChain should extend rather
> than borrow JUnit code
> --
>
> Key: GEODE-953
> URL: https://issues.apache.org/jira/browse/GEODE-953
> Project: Geode
> Issue Type: Bug
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> The override hooks that JUnit Rules provide allows a "before()" method to
> throw any Throwable (including checked exceptions), but does not allow an
> "after()" method to throw checked exceptions. See below:
> {noformat}
> protected void before() throws Throwable {
> protected void after() {
> {noformat}
> The currently committed versions of SerializableExternalResource and
> SerializableRuleChain borrow code from JUnit instead of extending JUnit
> classes to allow changing the after() to have a throws clause:
> {noformat}
> protected void after() {
> {noformat}
> If we choose to follow the JUnit best practice of having after() not perform
> any verifications (or otherwise be a very safe call that cannot throw checked
> exceptions), then we can change these classes to extend the JUnit classes
> instead of borrowing any code from JUnit.
> The Transaction and Off-Heap dunit tests should be changed to NOT perform any
> assertions during tearDown()/after(). There may be additional DUnit and JUnit
> tests that also need to change to bring them into line with the best practice
> Checked exceptions can also be wrapped in an Error or RuntimeException so
> this "limitation" could theoretically be worked around if necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-953) SerializableExternalResource and SerializableRuleChain should extend rather than borrow JUnit code
[
https://issues.apache.org/jira/browse/GEODE-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159583#comment-15159583
]
ASF subversion and git services commented on GEODE-953:
---
Commit 504a222f3629e1c4439039e2c78106ead4395abe in incubator-geode's branch
refs/heads/feature/GEODE-953 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=504a222 ]
Merge remote-tracking branch 'origin/develop' into feature/GEODE-953
> SerializableExternalResource and SerializableRuleChain should extend rather
> than borrow JUnit code
> --
>
> Key: GEODE-953
> URL: https://issues.apache.org/jira/browse/GEODE-953
> Project: Geode
> Issue Type: Bug
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> The override hooks that JUnit Rules provide allows a "before()" method to
> throw any Throwable (including checked exceptions), but does not allow an
> "after()" method to throw checked exceptions. See below:
> {noformat}
> protected void before() throws Throwable {
> protected void after() {
> {noformat}
> The currently committed versions of SerializableExternalResource and
> SerializableRuleChain borrow code from JUnit instead of extending JUnit
> classes to allow changing the after() to have a throws clause:
> {noformat}
> protected void after() {
> {noformat}
> If we choose to follow the JUnit best practice of having after() not perform
> any verifications (or otherwise be a very safe call that cannot throw checked
> exceptions), then we can change these classes to extend the JUnit classes
> instead of borrowing any code from JUnit.
> The Transaction and Off-Heap dunit tests should be changed to NOT perform any
> assertions during tearDown()/after(). There may be additional DUnit and JUnit
> tests that also need to change to bring them into line with the best practice
> Checked exceptions can also be wrapped in an Error or RuntimeException so
> this "limitation" could theoretically be worked around if necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
