[jira] [Commented] (HAWQ-1147) Analyze will ERROR after register multiple parquet data files to a parquet table while enable debug and cassert in hawq configure

2016-11-06 Thread Xiang Sheng (JIRA)

[ 
https://issues.apache.org/jira/browse/HAWQ-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15642823#comment-15642823
 ] 

Xiang Sheng commented on HAWQ-1147:
---

RCA : 
If we enable caasert in the hawq configure, it would open the assert checking.  
When we create an empty table and register a paq data file to the table, since 
register cannot get the tupcount of the original table in this register usage 
currently, so the data file doesn't contains the tupcount info. It uses -1  as 
default. 
When doing analyse at this time, it would fail since there is a assert(tupcount 
> -1), so analyze will error. 
If hawq register can read the tupcount from the paq file, then the tupcount  
will greater than -1.

> Analyze will ERROR after register multiple parquet data files to a parquet 
> table while enable debug and cassert in hawq configure
> -
>
> Key: HAWQ-1147
> URL: https://issues.apache.org/jira/browse/HAWQ-1147
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.0.1.0-incubating
>Reporter: Xiang Sheng
>Assignee: Lei Chang
> Fix For: 2.0.1.0-incubating
>
>
> Enable debug and cassert in hawq configure, analyze will report Unexpected 
> internal error after register multiple parquet data files to the table. 
> reproduce steps:
> reproduce steps: 
> 1.  ./configure --enable-debug  --enable-cassert
> 2.  make -j8
> 3.  make install
> 4.  hawq init cluster -a
> 5.  hadoop fs -mkdir hdfs://localhost:8020/hawq_register_test
> 6.  hadoop fs -put 
> $hawq_home/src/test/feature/ManagementTool/test_hawq_register_hawq.paq 
> hdfs://localhost:8020/hawq_register_test/hawq1.paq
> 7.  create table t (i int) with (appendonly=true, orientation=parquet);
> 8.  hawq register -d postgres -f 
> hdfs://localhost:8020/hawq_register_test/hawq1.paq  t
> 9.  
> postgres=#  select oid from pg_class where relname = 't';
> oid
>+--+
>  24586
> (1 row)
> postgres=# select * from pg_aoseg.pg_paqseg_24586;
>  segno | eof | tupcount | eofuncompressed
> ---+-+--+-
>  1 | 657 |   -1 |  -1
> (1 rows)
> postgres=#analyze t;
> FATAL:  Unexpected internal error (analyze.c:1718)
> DETAIL:  FailedAssertion("!(relTuples > -1.0)", File: "analyze.c", Line: 1718)
> HINT:  Process 43356 will wait for gp_debug_linger=120 seconds before 
> termination.
> Note that its locks and other resources will not be released until then.
> server closed the connection unexpectedly
>   This probably means the server terminated abnormally
>   before or while processing the request.
> The connection to the server was lost. Attempting reset: Succeeded



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HAWQ-1038) Missing BPCHAR in Data Type

2016-11-06 Thread Ming LI (JIRA)

[ 
https://issues.apache.org/jira/browse/HAWQ-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643015#comment-15643015
 ] 

Ming LI commented on HAWQ-1038:
---

Some points may need your concern:
1) HAWQ basing on PostgreSQL 8.2.15, most of the types are inherited from it, 
except array. You don't need to compare with PostgreSQL9.5, because we don't 
merge postgresql code changes.
2) All types below you listed in google docs are internal types, below is some 
types I know:
name: type for specific db object name, which is char (63)
int2vector: array of int2, used in system tables
tid: tuple ID
xid: transaction ID
cid: command ID
oidvector: array of oids
bpchar: blank-padded string, fixed storage length
You can see the description in below source code:
https://github.com/apache/incubator-hawq/blob/master/src/include/catalog/pg_type.h
So I don't think we need to change the doc at present without supporting any 
more types for user.

> Missing BPCHAR in Data Type
> ---
>
> Key: HAWQ-1038
> URL: https://issues.apache.org/jira/browse/HAWQ-1038
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Goden Yao
>Assignee: David Yozie
> Fix For: backlog
>
>
> referring to 3rd party site:
> http://hdb.docs.pivotal.io/20/reference/catalog/pg_type.html 
> and 
> http://hdb.docs.pivotal.io/20/reference/HAWQDataTypes.html
> It's quite out of date if you check source code:
> https://github.com/apache/incubator-hawq/blob/master/src/interfaces/ecpg/ecpglib/pg_type.h
> {code}
> ...
> #define BPCHAROID 1042
> ...
> {code}
> We at least miss BPCHAR in the type table, maybe more.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (HAWQ-1038) Missing BPCHAR in Data Type

2016-11-06 Thread Ming LI (JIRA)

 [ 
https://issues.apache.org/jira/browse/HAWQ-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ming LI resolved HAWQ-1038.
---
Resolution: Won't Fix

> Missing BPCHAR in Data Type
> ---
>
> Key: HAWQ-1038
> URL: https://issues.apache.org/jira/browse/HAWQ-1038
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Goden Yao
>Assignee: David Yozie
> Fix For: backlog
>
>
> referring to 3rd party site:
> http://hdb.docs.pivotal.io/20/reference/catalog/pg_type.html 
> and 
> http://hdb.docs.pivotal.io/20/reference/HAWQDataTypes.html
> It's quite out of date if you check source code:
> https://github.com/apache/incubator-hawq/blob/master/src/interfaces/ecpg/ecpglib/pg_type.h
> {code}
> ...
> #define BPCHAROID 1042
> ...
> {code}
> We at least miss BPCHAR in the type table, maybe more.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HAWQ-968) Incorrect free in url_close

2016-11-06 Thread hongwu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HAWQ-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

hongwu updated HAWQ-968:

Description: There is potential double free risk in 
url_fclose(https://github.com/apache/incubator-hawq/blob/master/src/backend/access/external/url.c#L1161)
 of url.c.  (was: There is potential double free risk in url_close of url.c)

> Incorrect free in url_close
> ---
>
> Key: HAWQ-968
> URL: https://issues.apache.org/jira/browse/HAWQ-968
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: External Tables
>Affects Versions: backlog
>Reporter: hongwu
>Assignee: hongwu
> Fix For: backlog
>
>
> There is potential double free risk in 
> url_fclose(https://github.com/apache/incubator-hawq/blob/master/src/backend/access/external/url.c#L1161)
>  of url.c.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HAWQ-968) Incorrect free in url_fclose

2016-11-06 Thread Ming LI (JIRA)

 [ 
https://issues.apache.org/jira/browse/HAWQ-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ming LI updated HAWQ-968:
-
Summary: Incorrect free in url_fclose  (was: Incorrect free in url_close)

> Incorrect free in url_fclose
> 
>
> Key: HAWQ-968
> URL: https://issues.apache.org/jira/browse/HAWQ-968
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: External Tables
>Affects Versions: backlog
>Reporter: hongwu
>Assignee: hongwu
> Fix For: backlog
>
>
> There is potential double free risk in 
> url_fclose(https://github.com/apache/incubator-hawq/blob/master/src/backend/access/external/url.c#L1161)
>  of url.c.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HAWQ-968) Incorrect free in url_fclose

2016-11-06 Thread hongwu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HAWQ-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

hongwu updated HAWQ-968:

Priority: Minor  (was: Major)

> Incorrect free in url_fclose
> 
>
> Key: HAWQ-968
> URL: https://issues.apache.org/jira/browse/HAWQ-968
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: External Tables
>Affects Versions: backlog
>Reporter: hongwu
>Assignee: hongwu
>Priority: Minor
> Fix For: backlog
>
>
> There is potential double free risk in 
> url_fclose(https://github.com/apache/incubator-hawq/blob/master/src/backend/access/external/url.c#L1161)
>  of url.c.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)