[GitHub] incubator-hawq pull request #1254: HAWQ-1373 - Added feature to reload GUC v...
Github user outofmem0ry commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1254#discussion_r125390001 --- Diff: src/test/feature/ManagementTool/test_hawq_reload.cpp --- @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include +#include +#include "lib/command.h" +#include "lib/sql_util.h" +#include "lib/string_util.h" +#include "lib/hawq_config.h" +#include "test_hawq_reload.h" + +#include "gtest/gtest.h" + +using std::string; +using hawq::test::SQLUtility; +using hawq::test::Command; + +/* +Test case for hawq reload . This test changes the value of GUC +log_min_messages to debug. Reloads the cluster and verifies if the change +was reloaded successfully. After the test it resets the valueof GUC to --- End diff -- Thank you for pointing it out, will correct it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1254: HAWQ-1373 - Added feature to reload GUC v...
Github user outofmem0ry commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1254#discussion_r125389996
--- Diff: tools/bin/hawq ---
@@ -120,6 +120,23 @@ def main():
if second_arg not in cluster_type_list:
print STOP_HELP
sys.exit(1)
+# Prints deprecation warning when using old syntax "hawq stop
-u" to reload GUC
+if len(sub_args.split("-")) > 1:
+if "-u" in sub_args or "--reload" in sub_args or "u" in
sub_args.split("-")[1]:
+deprecationMessage = """
+hawq stop -u is being deprecated and replaced by
'hawq reload '
--- End diff --
@radarwave - I deliberately kept the messages printing different so that it
is noticeable to the user, as it is a deprecation warning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1254: HAWQ-1373 - Added feature to reload GUC v...
Github user radarwave commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1254#discussion_r125388848 --- Diff: src/test/feature/ManagementTool/test_hawq_reload.cpp --- @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include +#include +#include "lib/command.h" +#include "lib/sql_util.h" +#include "lib/string_util.h" +#include "lib/hawq_config.h" +#include "test_hawq_reload.h" + +#include "gtest/gtest.h" + +using std::string; +using hawq::test::SQLUtility; +using hawq::test::Command; + +/* +Test case for hawq reload . This test changes the value of GUC +log_min_messages to debug. Reloads the cluster and verifies if the change +was reloaded successfully. After the test it resets the valueof GUC to --- End diff -- Typo 'valueof'. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1262: HAWQ-1493. Integrate Ranger lookup JAAS configur...
Github user linwen commented on the issue: https://github.com/apache/incubator-hawq/pull/1262 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1254: HAWQ-1373 - Added feature to reload GUC v...
Github user radarwave commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1254#discussion_r125376981
--- Diff: tools/bin/hawq ---
@@ -120,6 +120,23 @@ def main():
if second_arg not in cluster_type_list:
print STOP_HELP
sys.exit(1)
+# Prints deprecation warning when using old syntax "hawq stop
-u" to reload GUC
+if len(sub_args.split("-")) > 1:
+if "-u" in sub_args or "--reload" in sub_args or "u" in
sub_args.split("-")[1]:
+deprecationMessage = """
+hawq stop -u is being deprecated and replaced by
'hawq reload '
--- End diff --
This deprecation message is not align with other messages.
Run 'hawq stop cluster -u' then you can see.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 @radarwave committed the final changes, doc changes pending. Will submit a PR in docs repo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (HAWQ-1495) TestRowTypes.BasicTest fails due to wrong answer file
[
https://issues.apache.org/jira/browse/HAWQ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072982#comment-16072982
]
Shubham Sharma commented on HAWQ-1495:
--
In *src/test/feature/query/sql/rowtypes.sql* the value inserted into the table
is `"insert into people values ('(Joe,Blow)', '1984-01-10');"`, where date is
in the format - `1984-01-10`. But in
`*src/test/feature/query/ans/rowtypes.ans*`, whenever doing a "select * from
people" the answer is stored as `01-10-1984`. This causes the test to fail.
Corrected the date format and test executes successfully.
Submitted [pull request|https://github.com/apache/incubator-hawq/pull/1263] to
address this issue.
> TestRowTypes.BasicTest fails due to wrong answer file
> -
>
> Key: HAWQ-1495
> URL: https://issues.apache.org/jira/browse/HAWQ-1495
> Project: Apache HAWQ
> Issue Type: Bug
> Components: Tests
>Reporter: Shubham Sharma
>Assignee: Jiali Yao
>
> While running feature test TestRowTypes, it fails with following error
> {code}
> [gpadmin@centos7-namenode feature]$ ./feature-test
> --gtest_filter="TestRowTypes*"
> Note: Google Test filter = TestRowTypes*
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from TestRowTypes
> [ RUN ] TestRowTypes.BasicTest
> COPY tenk1 FROM '/data/hawq/src/test/feature/query/data/tenk.data'
> lib/sql_util.cpp:197: Failure
> Value of: is_sql_ans_diff
> Actual: true
> Expected: false
> lib/sql_util.cpp:203: Failure
> Value of: true
> Actual: true
> Expected: false
> [ FAILED ] TestRowTypes.BasicTest (9493 ms)
> [--] 1 test from TestRowTypes (9493 ms total)
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (9493 ms total)
> [ PASSED ] 0 tests.
> [ FAILED ] 1 test, listed below:
> [ FAILED ] TestRowTypes.BasicTest
> 1 FAILED TEST
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] incubator-hawq pull request #1263: HAWQ-1495 Corrected answer file to match ...
GitHub user outofmem0ry opened a pull request:
https://github.com/apache/incubator-hawq/pull/1263
HAWQ-1495 Corrected answer file to match insert statement
In `src/test/feature/query/sql/rowtypes.sql` the value inserted into the
table is `"insert into people values ('(Joe,Blow)', '1984-01-10');"`, where
date is in the format - `1984-01-10`. But in
`src/test/feature/query/ans/rowtypes.ans`, whenever doing a "select * from
people" the answer is stored as `01-10-1984`. This causes the test to fail.
Corrected the date format and test executes successfully.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/outofmem0ry/incubator-hawq
feature/TestRowTypes-HAWQ-1495
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1263.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1263
commit 3a6d182462ac237883b8f5702dc74ea212dcfc07
Author: Shubham Sharma
Date: 2017-07-03T23:40:19Z
HAWQ-1495 Corrected answer file to match insert statements
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Created] (HAWQ-1495) TestRowTypes.BasicTest fails due to wrong answer file
Shubham Sharma created HAWQ-1495:
Summary: TestRowTypes.BasicTest fails due to wrong answer file
Key: HAWQ-1495
URL: https://issues.apache.org/jira/browse/HAWQ-1495
Project: Apache HAWQ
Issue Type: Bug
Components: Tests
Reporter: Shubham Sharma
Assignee: Jiali Yao
While running feature test TestRowTypes, it fails with following error
{code}
[gpadmin@centos7-namenode feature]$ ./feature-test
--gtest_filter="TestRowTypes*"
Note: Google Test filter = TestRowTypes*
[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from TestRowTypes
[ RUN ] TestRowTypes.BasicTest
COPY tenk1 FROM '/data/hawq/src/test/feature/query/data/tenk.data'
lib/sql_util.cpp:197: Failure
Value of: is_sql_ans_diff
Actual: true
Expected: false
lib/sql_util.cpp:203: Failure
Value of: true
Actual: true
Expected: false
[ FAILED ] TestRowTypes.BasicTest (9493 ms)
[--] 1 test from TestRowTypes (9493 ms total)
[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (9493 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] TestRowTypes.BasicTest
1 FAILED TEST
{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HAWQ-1483) cache lookup failure
[
https://issues.apache.org/jira/browse/HAWQ-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072149#comment-16072149
]
Radar Lei commented on HAWQ-1483:
-
Verified this issue still exist on HAWQ 2.2.0.0-incubating version.
> cache lookup failure
>
>
> Key: HAWQ-1483
> URL: https://issues.apache.org/jira/browse/HAWQ-1483
> Project: Apache HAWQ
> Issue Type: Bug
>Reporter: Rahul Iyer
>Assignee: Radar Lei
>
> I'm getting a failure when performing a distinct count with another immutable
> aggregate. We found this issue when running MADlib on HAWQ 2.0.0. Please find
> below a simple repro.
> Setup:
> {code}
> CREATE TABLE example_data(
> id SERIAL,
> outlook text,
> temperature float8,
> humidity float8,
> windy text,
> class text) ;
> COPY example_data (outlook, temperature, humidity, windy, class) FROM stdin
> DELIMITER ',' NULL '?' ;
> sunny, 85, 85, false, Don't Play
> sunny, 80, 90, true, Don't Play
> overcast, 83, 78, false, Play
> rain, 70, 96, false, Play
> rain, 68, 80, false, Play
> rain, 65, 70, true, Don't Play
> overcast, 64, 65, true, Play
> sunny, 72, 95, false, Don't Play
> sunny, 69, 70, false, Play
> rain, 75, 80, false, Play
> sunny, 75, 70, true, Play
> overcast, 72, 90, true, Play
> overcast, 81, 75, false, Play
> rain, 71, 80, true, Don't Play
> \.
> create function grt_sfunc(agg_state point, el float8)
> returns point
> immutable
> language plpgsql
> as $$
> declare
> greatest_sum float8;
> current_sum float8;
> begin
> current_sum := agg_state[0] + el;
> if agg_state[1] < current_sum then
> greatest_sum := current_sum;
> else
> greatest_sum := agg_state[1];
> end if;
> return point(current_sum, greatest_sum);
> end;
> $$;
> create function grt_finalfunc(agg_state point)
> returns float8
> immutable
> strict
> language plpgsql
> as $$
> begin
> return agg_state[1];
> end;
> $$;
> create aggregate greatest_running_total (float8)
> (
> sfunc = grt_sfunc,
> stype = point,
> finalfunc = grt_finalfunc
> );
> {code}
> Error:
> {code}
> select count(distinct outlook), greatest_running_total(humidity::integer)
> from example_data;
> {code}
> {code}
> ERROR: cache lookup failed for function 0 (fmgr.c:223)
> {code}
> Execution goes through if I remove the {{distinct}} or if I add another
> column for the {{count(distinct)}}.
> {code:sql}
> select count(distinct outlook) as c1, count(distinct windy) as c2,
> greatest_running_total(humidity) from example_data;
> {code}
> {code}
> c1 | c2 | greatest_running_total
> ++
> 3 | 2 |
> (1 row)
> {code}
> {code:sql}
> select count(outlook) as c1, greatest_running_total(humidity) from
> example_data;
> {code}
> {code}
> count | greatest_running_total
> ---+
> 14 |
> (1 row)
> {code}
> It's an older build - I don't have the resources at present to test this on
> the latest HAWQ.
> {code}
> select version();
>
> version
> ---
> PostgreSQL 8.2.15 (Greenplum Database 4.2.0 build 1) (HAWQ 2.0.0.0 build
> 22126) on x86_64-unknown-linux-gnu, compiled by GCC gcc (GCC) 4.4.2 compiled
> on Apr 25 2016 09:52:54
> (1 row)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HAWQ-1494) The bug can appear every time when I execute a specific sql: Unexpect internal error (setref.c:298), server closed the connection unexpectedly
[
https://issues.apache.org/jira/browse/HAWQ-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
fangpei updated HAWQ-1494:
--
Description:
When I execute a specific sql, a serious bug can happen every time. (Hawq
version is 2.2.0.0)
BUG information:
FATAL: Unexpect internal error (setref.c:298)
DETAIL: AssertImply failed("!(!var->varattno >= 0) || (var->varattno <=
list_length(colNames) + list_length(rte- >pseudocols)))", File: "setrefs.c",
Line: 298)
HINT: Process 239600 will wait for gp_debug_linger=120 seconds before
termination.
Note that its locks and other resources will not be released until then.
server closed the connection unexpectedly
This probably means the server terminated abnormally
before or while processing the request.
The connection to the server was lost. Attemping reset: Succeeded.
I use GDB to debug, the GDB information is the same every time. The information
is:
Loaded symbols for /lib64/libnss_files.so.2
0x0032dd40eb5c in recv 0 from /lib64/libpthread.so.0
(gdb) b setrefs.c:298
Breakpoint 1 at 0x846063: file setrefs.c, line 298.
(gdb) c
Continuing.
Breakpoint 1, set_plan_references_output_asserts (glob=0x7fe96fbccab0,
plan=0x7fe8e930adb8) at setrefs.c:298
298 set ref s .c:没有那个文件或目录.
(gdb) c 1923
Will ignore next 1922 crossings of breakpoint 1. Continuing.
Breakpoint 1, set_plan_references_output_asserts (glob=0x7fe96fbccab0,
plan=0x7fe869c70340) at setrefs.c:298
298 in setrefs.c
(gdb) p list_length(allVars)
$1 = 1422
(gdb) p var->varno
$2 = 65001
(gdb) p list_length(glob->finalrtable)
$3 = 66515
(gdb) p var->varattno
$4 = 31
(gdb) p list_length(colNames)
$5 = 30
(gdb) p list_length(rte->pseudocols)
$6 = 0
the SQL sentence is long, Occupies the entire screen, total 45 lines. the SQL
sentence contain "nested select", many "union all", "where", "or", "and", and
also have "group by" and "having".
I try to "explain this SQL" to get the execution plan, but it report the same
error, and then can not get the execution plan.
I also try to "set optimizer=off" and retry the SQL sentence, but the same
error happen, and "show optimizer" the optimizer is "on" (automatically set
"on").
was:
When I execute a specific sql, a serious bug can happen every time. (Hawq
version is 2.2.0.0)
BUG information:
FATAL: Unexpect internal error (setref.c:298)
DETAIL: AssertImply failed("!(!var->varattno >= 0) || (var->varattno <=
list_length(colNames) + list_length(rte- >pseudocols)))", File: "setrefs.c",
Line: 298)
HINT: Process 239600 will wait for gp_debug_linger=120 seconds before
termination.
Note that its locks and other resources will not be released until then.
server closed the connection unexpectedly
This probably means the server terminated abnormally
before or while processing the request.
The connection to the server was lost. Attemping reset: Succeeded.
I use GDB to debug, the GDB information is the same every time. The information
is:
Loaded symbols for /lib64/libnss_files.so.2
0x0032dd40eb5c in recv 0 from /lib64/libpthread.so.0
(gdb) b setrefs.c:298
Breakpoint 1 at 0x846063: file setrefs.c, line 298.
(gdb) c
Continuing.
Breakpoint 1, set_plan_references_output_asserts (glob=0x7fe96fbccab0,
plan=0x7fe8e930adb8) at setrefs.c:298
298 set ref s .c:没有那个文件或目录.
(gdb) c 1923
Will ignore next 1922 crossings of breakpoint 1. Continuing.
Breakpoint 1, set_plan_referencesj〇utput_asserts (glob=0x7fe96fbccab0,
plan=0x7fe869c70340) at setrefs.c:298
298 in setrefs.c
(gdb) p list_length(allVars)
$1 = 1422
(gdb) p var->varno
$2 = 65001
(gdb) p list_length(glob->finalrtable)
$3 = 66515
(gdb) p var->varattno
$4 = 31
(gdb) p list_length(colNames)
$5 = 30
(gdb) p list_length(rte->pseudocols)
$6 = 0
the SQL sentence is long, Occupies the entire screen, total 45 lines. the SQL
sentence contain "nested select", many "union all", "where", "or", "and", and
also have "group by" and "having".
I try to "explain this SQL" to get the execution plan, but it report the same
error, and then can not get the execution plan.
I also try to "set optimizer=off" and retry the SQL sentence, but the same
error happen, and "show optimizer" the optimizer is "on" (automatically set
"on").
> The bug can appear every time when I execute a specific sql: Unexpect
> internal error (setref.c:298), server closed the connection unexpectedly
> ---
>
> Key: HAWQ-1494
> URL: https://issues.apache.org/jira/browse/HAWQ-1494
> Project: Apache HAWQ
> Issue Type: Bug
> Components: Core
>Reporter: fangpei
>Assignee: Radar Lei
> Fix For: 2.2.0.0-incubating
>
>
> When I execute a specific sql, a serious bug can happen every time. (Hawq
> version is 2.2.0.0)
> BUG
