[GitHub] incubator-hawq pull request #1301: Re-added pxf profile default to rpm and t...

2017-10-12 Thread shivzone 
Github user shivzone commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1301#discussion_r144450132
  
--- Diff: pxf/build.gradle ---
@@ -310,6 +315,7 @@ project('pxf-service') {
 
 project.distTar {
 from('src/main/resources/pxf-profiles.xml') { into 'conf' }
+from('src/main/resources/pxf-profiles-default.xml') { into 'conf' }
--- End diff --

@lavjain pxf-profiles.xml is better to be empty to prevent users from 
incorrectly updating the default entires in it. This is similar to the 
separation we have between pxf-private.classpath from pxf-public.classpath.
@lavjain @sansanichfb  does that mean we don't need pxf-profiles.default ?


---

[GitHub] incubator-hawq issue #1301: Re-added pxf profile default to rpm and tar task...

2017-10-12 Thread shivzone 
Github user shivzone commented on the issue:

https://github.com/apache/incubator-hawq/pull/1301
  
@lavjain pxf-profiles.xml is better to be empty to prevent users from 
incorrectly updating the default entires in it. This is similar to the 
separation we have between pxf-private.classpath from pxf-public.classpath.
@lavjain @sansanichfb  does that mean we don't need pxf-profiles.default ?


---

[GitHub] incubator-hawq pull request #1301: Re-added pxf profile default to rpm and t...

2017-10-12 Thread lavjain 
Github user lavjain commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1301#discussion_r144388153
  
--- Diff: pxf/build.gradle ---
@@ -310,6 +315,7 @@ project('pxf-service') {
 
 project.distTar {
 from('src/main/resources/pxf-profiles.xml') { into 'conf' }
+from('src/main/resources/pxf-profiles-default.xml') { into 'conf' }
--- End diff --

@sansanichfb just verified in the code that we are loading both profiles.


---

[GitHub] incubator-hawq pull request #1301: Re-added pxf profile default to rpm and t...

2017-10-12 Thread lavjain 
Github user lavjain commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1301#discussion_r144386624
  
--- Diff: pxf/build.gradle ---
@@ -310,6 +315,7 @@ project('pxf-service') {
 
 project.distTar {
 from('src/main/resources/pxf-profiles.xml') { into 'conf' }
+from('src/main/resources/pxf-profiles-default.xml') { into 'conf' }
--- End diff --

I still do not understand why pxf-profile.xml needs to be empty but that is 
a product question for @kongyew


---

[GitHub] incubator-hawq pull request #1301: Re-added pxf profile default to rpm and t...

2017-10-12 Thread shivzone 
Github user shivzone commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1301#discussion_r144384241
  
--- Diff: pxf/build.gradle ---
@@ -310,6 +315,7 @@ project('pxf-service') {
 
 project.distTar {
 from('src/main/resources/pxf-profiles.xml') { into 'conf' }
+from('src/main/resources/pxf-profiles-default.xml') { into 'conf' }
--- End diff --

Automation test failure is a different issue and that needs to be addressed 
separately out of this PR. This would not be an end user issue.
The automation test assumes pxf-profile.xml has all the profiles in it 
which is not really the case anymore. The tests need to addressed separately.



---

[GitHub] incubator-hawq pull request #1301: Re-added pxf profile default to rpm and t...

2017-10-12 Thread lavjain 
Github user lavjain commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1301#discussion_r144383457
  
--- Diff: pxf/build.gradle ---
@@ -310,6 +315,7 @@ project('pxf-service') {
 
 project.distTar {
 from('src/main/resources/pxf-profiles.xml') { into 'conf' }
+from('src/main/resources/pxf-profiles-default.xml') { into 'conf' }
--- End diff --

Then why did it fail for pxf-automation on HAWQ?


---

[GitHub] incubator-hawq pull request #1301: Re-added pxf profile default to rpm and t...

2017-10-12 Thread shivzone 
Github user shivzone commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1301#discussion_r144383133
  
--- Diff: pxf/build.gradle ---
@@ -310,6 +315,7 @@ project('pxf-service') {
 
 project.distTar {
 from('src/main/resources/pxf-profiles.xml') { into 'conf' }
+from('src/main/resources/pxf-profiles-default.xml') { into 'conf' }
--- End diff --

Not really. The purpose of pxf-profile-default.xml is to have all the 
default profiles. The users need to only add custom profiels to 
pxf-profile.xml. The PXF application loads both the xml files during startup.


---

[GitHub] incubator-hawq pull request #1301: Re-added pxf profile default to rpm and t...

2017-10-12 Thread lavjain 
Github user lavjain commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1301#discussion_r144382742
  
--- Diff: pxf/build.gradle ---
@@ -310,6 +315,7 @@ project('pxf-service') {
 
 project.distTar {
 from('src/main/resources/pxf-profiles.xml') { into 'conf' }
+from('src/main/resources/pxf-profiles-default.xml') { into 'conf' }
--- End diff --

So, people would have to manually copy it then?


---

[GitHub] incubator-hawq pull request #1301: Re-added pxf profile default to rpm and t...

2017-10-12 Thread shivzone 
Github user shivzone commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1301#discussion_r144382134
  
--- Diff: pxf/build.gradle ---
@@ -310,6 +315,7 @@ project('pxf-service') {
 
 project.distTar {
 from('src/main/resources/pxf-profiles.xml') { into 'conf' }
+from('src/main/resources/pxf-profiles-default.xml') { into 'conf' }
--- End diff --

For the product's perspective why is that needed ?


---

[GitHub] incubator-hawq pull request #1301: Re-added pxf profile default to rpm and t...

2017-10-12 Thread shivzone 
GitHub user shivzone opened a pull request:

https://github.com/apache/incubator-hawq/pull/1301

Re-added pxf profile default to rpm and tar tasks

The tar and the rpm targets were missing pxf-profiles-default.xml.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shivzone/incubator-hawq HAWQ-1538

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1301.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1301


commit c1f4b29adc0f4bcc9bb77dfe65d046c8c8f41517
Author: shivzone 
Date:   2017-10-12T18:39:20Z

Re-added pxf profile default to rpm and tar tasks




---

[jira] [Assigned] (HAWQ-1538) Install internal profiles definition file in conf directory

2017-10-12 Thread Shivram Mani (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HAWQ-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shivram Mani reassigned HAWQ-1538:
--

Assignee: Shivram Mani  (was: Ed Espino)

> Install internal profiles definition file in conf directory
> ---
>
> Key: HAWQ-1538
> URL: https://issues.apache.org/jira/browse/HAWQ-1538
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: PXF
>Reporter: Oleksandr Diachenko
>Assignee: Shivram Mani
> Fix For: 2.3.0.0-incubating
>
>
> As I user who installs PXF under some directory I want to have an empty file 
> installed under conf, which I can edit when I want to define my custom 
> profiles.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HAWQ-1480) Packing a core file in hawq

2017-10-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/HAWQ-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202295#comment-16202295
 ] 

ASF GitHub Bot commented on HAWQ-1480:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-hawq-docs/pull/123


> Packing a core file in hawq
> ---
>
> Key: HAWQ-1480
> URL: https://issues.apache.org/jira/browse/HAWQ-1480
> Project: Apache HAWQ
>  Issue Type: Improvement
>  Components: Command Line Tools
>Reporter: Shubham Sharma
>Assignee: Radar Lei
> Fix For: 2.3.0.0-incubating
>
>
> Currently there is no way to packing a core file with its context – 
> executable, application and system shared libraries in hawq. This information 
> can be later unpacked on another system and helps in debugging. It is a 
> useful feature to quickly gather all the data needed from a crash/core 
> generated on the system to analyze it later.
> Another open source project, greenplum, uses a script 
> [https://github.com/greenplum-db/gpdb/blob/master/gpMgmt/sbin/packcore] to 
> collect this information. Tested this script against Hawq's installation and 
> it collects the required information needed for debug.
> Can this be merged into Hawq, if yes, I can submit a pull request and test it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HAWQ-1480) Packing a core file in hawq

2017-10-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/HAWQ-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202267#comment-16202267
 ] 

ASF GitHub Bot commented on HAWQ-1480:
--

Github user dyozie commented on a diff in the pull request:

https://github.com/apache/incubator-hawq-docs/pull/123#discussion_r144348667
  
--- Diff: book/master_middleman/source/subnavs/apache-hawq-nav.erb ---
@@ -117,6 +117,9 @@
   
 HAWQ 
Administrative Log Files
   
+  
+HAWQ packcore 
utility
--- End diff --

Thanks @outofmem0ry - merging this in now.


> Packing a core file in hawq
> ---
>
> Key: HAWQ-1480
> URL: https://issues.apache.org/jira/browse/HAWQ-1480
> Project: Apache HAWQ
>  Issue Type: Improvement
>  Components: Command Line Tools
>Reporter: Shubham Sharma
>Assignee: Radar Lei
> Fix For: 2.3.0.0-incubating
>
>
> Currently there is no way to packing a core file with its context – 
> executable, application and system shared libraries in hawq. This information 
> can be later unpacked on another system and helps in debugging. It is a 
> useful feature to quickly gather all the data needed from a crash/core 
> generated on the system to analyze it later.
> Another open source project, greenplum, uses a script 
> [https://github.com/greenplum-db/gpdb/blob/master/gpMgmt/sbin/packcore] to 
> collect this information. Tested this script against Hawq's installation and 
> it collects the required information needed for debug.
> Can this be merged into Hawq, if yes, I can submit a pull request and test it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HAWQ-1480) Packing a core file in hawq

2017-10-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/HAWQ-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201502#comment-16201502
 ] 

ASF GitHub Bot commented on HAWQ-1480:
--

Github user outofmem0ry commented on a diff in the pull request:

https://github.com/apache/incubator-hawq-docs/pull/123#discussion_r144200526
  
--- Diff: book/master_middleman/source/subnavs/apache-hawq-nav.erb ---
@@ -117,6 +117,9 @@
   
 HAWQ 
Administrative Log Files
   
+  
+HAWQ packcore 
utility
--- End diff --

@lisakowen changed the heading format to make it similar to naming 
convention of other headings.


> Packing a core file in hawq
> ---
>
> Key: HAWQ-1480
> URL: https://issues.apache.org/jira/browse/HAWQ-1480
> Project: Apache HAWQ
>  Issue Type: Improvement
>  Components: Command Line Tools
>Reporter: Shubham Sharma
>Assignee: Radar Lei
> Fix For: 2.3.0.0-incubating
>
>
> Currently there is no way to packing a core file with its context – 
> executable, application and system shared libraries in hawq. This information 
> can be later unpacked on another system and helps in debugging. It is a 
> useful feature to quickly gather all the data needed from a crash/core 
> generated on the system to analyze it later.
> Another open source project, greenplum, uses a script 
> [https://github.com/greenplum-db/gpdb/blob/master/gpMgmt/sbin/packcore] to 
> collect this information. Tested this script against Hawq's installation and 
> it collects the required information needed for debug.
> Can this be merged into Hawq, if yes, I can submit a pull request and test it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)