[GitHub] incubator-hawq pull request #1308: HAWQ-1530. Illegally killing a JDBC selec...

[kuien]

Github user kuien commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1308#discussion_r149592641
  
--- Diff: src/backend/cdb/dispatcher.c ---
@@ -1414,9 +1415,12 @@ dispatch_cleanup(DispatchData *data)
if (dispatcher_is_state_error(data))
--- End diff --

May we check the status of 'proc_exit_inprogress' earlier and simpler? That 
is:
```
if (proc_exit_inprogress)
return;
```


---

[GitHub] incubator-hawq issue #1308: HAWQ-1530. Illegally killing a JDBC select query...

[amyrazz44]

Github user amyrazz44 commented on the issue:

https://github.com/apache/incubator-hawq/pull/1308
  
LGTM +1


---

[GitHub] incubator-hawq pull request #1296: HAWQ-1496. Add DISCLAIMER, LICENSE and NO...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1296


---

[jira] [Resolved] (HAWQ-1496) Deliver LICENSE, NOTICE and DISCLAIMER in main PXF RPM

[Ed Espino (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ed Espino resolved HAWQ-1496.
-
Resolution: Fixed

Merged into master.

> Deliver LICENSE, NOTICE and DISCLAIMER in main PXF RPM
> --
>
> Key: HAWQ-1496
> URL: https://issues.apache.org/jira/browse/HAWQ-1496
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build, PXF
>Reporter: Ed Espino
>Assignee: Vineet Goel
> Fix For: 2.3.0.0-incubating
>
>
> Deliver LICENSE, NOTICE and DISCLAIMER in main PXF RPM in which all others 
> are dependent. Currently, they are delivered in all supplied PXF jar files. 
> This was identified during IPMC voting process for the 2.2.0.0 convenience 
> binary release artifacts 
> (https://lists.apache.org/thread.html/35f0f37fb96ad88b1b7cee286640a94894a5b6956b9ae41a7d554ed6@%3Cgeneral.incubator.apache.org%3E)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-hawq issue #1308: HAWQ-1530. Illegally killing a JDBC select query...

[linwen]

Github user linwen commented on the issue:

https://github.com/apache/incubator-hawq/pull/1308
  
+1 


---

[jira] [Commented] (HAWQ-1530) Illegally killing a JDBC select query causes locking problems

[Grant Krieger (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243416#comment-16243416
 ] 

Grant Krieger commented on HAWQ-1530:
-

Thanks for the help. If there is anything I can assist with from a testing 
perspective please advise

> Illegally killing a JDBC select query causes locking problems
> -
>
> Key: HAWQ-1530
> URL: https://issues.apache.org/jira/browse/HAWQ-1530
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Transaction
>Reporter: Grant Krieger
>Assignee: Yi Jin
> Fix For: 2.3.0.0-incubating
>
>
> Hi,
> When you perform a long running select statement on 2 hawq tables (join) from 
> JDBC and illegally kill the JDBC client (CTRL ALT DEL) before completion of 
> the query the 2 tables remained locked even when the query completes on the 
> server. 
> The lock is visible via PG_locks. One cannot kill the query via SELECT 
> pg_terminate_backend(393937). The only way to get rid of it is to kill -9 
> from linux or restart hawq but this can kill other things as well.
> The JDBC client I am using is Aqua Data Studio.
> I can provide exact steps to reproduce if required
> Thank you
> Grant 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-hawq pull request #1309: HAWQ-1545. Fix pxf-private.classpath file...

[lavjain]

GitHub user lavjain opened a pull request:

https://github.com/apache/incubator-hawq/pull/1309

HAWQ-1545. Fix pxf-private.classpath file for Cloudera tarball distro



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lavjain/incubator-hawq HAWQ-1545

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1309.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1309


commit e091d789e34c4694eaa6a752563836cae3bfd28b
Author: lavjain 
Date:   2017-11-08T00:22:34Z

HAWQ-1545. Fix pxf-private.classpath file for Cloudera tarball distro




---

[GitHub] incubator-hawq pull request #1308: HAWQ-1530. Illegally killing a JDBC selec...

[jiny2]

Github user jiny2 closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1308


---

[GitHub] incubator-hawq issue #1308: HAWQ-1530. Illegally killing a JDBC select query...

[radarwave]

Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1308
  
+1


---

[jira] [Assigned] (HAWQ-1545) pxf-private.classpath file for TARs refers to generic jackson libraries

[Lav Jain (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lav Jain reassigned HAWQ-1545:
--

Assignee: Lav Jain  (was: Ed Espino)

> pxf-private.classpath file for TARs refers to generic jackson libraries
> ---
>
> Key: HAWQ-1545
> URL: https://issues.apache.org/jira/browse/HAWQ-1545
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: PXF
>Reporter: Lav Jain
>Assignee: Lav Jain
>
> JSON profile requires Jackson libraries version 1.9 (and above). The 
> unit-tests and automation tests fail with Jackson 1.8.8, which seems to be 
> the default for Cloudera tarball based distribution.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HAWQ-1545) pxf-private.classpath file for TARs refers to generic jackson libraries

[Lav Jain (JIRA)]

Lav Jain created HAWQ-1545:
--

 Summary: pxf-private.classpath file for TARs refers to generic 
jackson libraries
 Key: HAWQ-1545
 URL: https://issues.apache.org/jira/browse/HAWQ-1545
 Project: Apache HAWQ
  Issue Type: Bug
  Components: PXF
Reporter: Lav Jain
Assignee: Ed Espino


JSON profile requires Jackson libraries version 1.9 (and above). The unit-tests 
and automation tests fail with Jackson 1.8.8, which seems to be the default for 
Cloudera tarball based distribution.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-hawq issue #1296: HAWQ-1496. Add DISCLAIMER, LICENSE and NOTICE fi...

[edespino]

Github user edespino commented on the issue:

https://github.com/apache/incubator-hawq/pull/1296
  
Thanks @denalex for the review! I have fixed the typo.


---

[jira] [Commented] (HAWQ-1530) Illegally killing a JDBC select query causes locking problems

[Yi Jin (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242854#comment-16242854
 ] 

Yi Jin commented on HAWQ-1530:
--

I created one PR for this bug, 
https://github.com/apache/incubator-hawq/pull/1308

Please have a check

> Illegally killing a JDBC select query causes locking problems
> -
>
> Key: HAWQ-1530
> URL: https://issues.apache.org/jira/browse/HAWQ-1530
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Transaction
>Reporter: Grant Krieger
>Assignee: Yi Jin
> Fix For: 2.3.0.0-incubating
>
>
> Hi,
> When you perform a long running select statement on 2 hawq tables (join) from 
> JDBC and illegally kill the JDBC client (CTRL ALT DEL) before completion of 
> the query the 2 tables remained locked even when the query completes on the 
> server. 
> The lock is visible via PG_locks. One cannot kill the query via SELECT 
> pg_terminate_backend(393937). The only way to get rid of it is to kill -9 
> from linux or restart hawq but this can kill other things as well.
> The JDBC client I am using is Aqua Data Studio.
> I can provide exact steps to reproduce if required
> Thank you
> Grant 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-hawq issue #1308: HAWQ-1530. Illegally killing a JDBC select query...

[jiny2]

Github user jiny2 commented on the issue:

https://github.com/apache/incubator-hawq/pull/1308
  
@kuien please check this fix


---

[GitHub] incubator-hawq pull request #1308: HAWQ-1530. Illegally killing a JDBC selec...

[jiny2]

GitHub user jiny2 opened a pull request:

https://github.com/apache/incubator-hawq/pull/1308

HAWQ-1530. Illegally killing a JDBC select query causes locking problems

This bug root cause maybe twice FATAL error throwing, I cannot exactly 
reproduce it according to this issue's comment, just based on my understanding 
and previous bug fix experiences. We cannot allow a FATAL throwed again when 
anohter FATAL causes process into exit phase.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jiny2/incubator-hawq HAWQ-1530

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1308.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1308


commit 7a103541d11cebd3872dc1b7108ab636f7f53ddf
Author: Yi 
Date:   2017-11-07T20:47:02Z

HAWQ-1530. Illegally killing a JDBC select query causes locking problems




---

[jira] [Updated] (HAWQ-1530) Illegally killing a JDBC select query causes locking problems

[Yi Jin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yi Jin updated HAWQ-1530:
-
Fix Version/s: 2.3.0.0-incubating

> Illegally killing a JDBC select query causes locking problems
> -
>
> Key: HAWQ-1530
> URL: https://issues.apache.org/jira/browse/HAWQ-1530
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Transaction
>Reporter: Grant Krieger
>Assignee: Yi Jin
> Fix For: 2.3.0.0-incubating
>
>
> Hi,
> When you perform a long running select statement on 2 hawq tables (join) from 
> JDBC and illegally kill the JDBC client (CTRL ALT DEL) before completion of 
> the query the 2 tables remained locked even when the query completes on the 
> server. 
> The lock is visible via PG_locks. One cannot kill the query via SELECT 
> pg_terminate_backend(393937). The only way to get rid of it is to kill -9 
> from linux or restart hawq but this can kill other things as well.
> The JDBC client I am using is Aqua Data Studio.
> I can provide exact steps to reproduce if required
> Thank you
> Grant 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-hawq issue #1308: HAWQ-1530. Illegally killing a JDBC select query...

[jiny2]

Github user jiny2 commented on the issue:

https://github.com/apache/incubator-hawq/pull/1308
  
@radarwave @linwen @changleicn please review and comment


---

[jira] [Assigned] (HAWQ-1530) Illegally killing a JDBC select query causes locking problems

[Radar Lei (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radar Lei reassigned HAWQ-1530:
---

Assignee: Yi Jin  (was: Radar Lei)

> Illegally killing a JDBC select query causes locking problems
> -
>
> Key: HAWQ-1530
> URL: https://issues.apache.org/jira/browse/HAWQ-1530
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Transaction
>Reporter: Grant Krieger
>Assignee: Yi Jin
>
> Hi,
> When you perform a long running select statement on 2 hawq tables (join) from 
> JDBC and illegally kill the JDBC client (CTRL ALT DEL) before completion of 
> the query the 2 tables remained locked even when the query completes on the 
> server. 
> The lock is visible via PG_locks. One cannot kill the query via SELECT 
> pg_terminate_backend(393937). The only way to get rid of it is to kill -9 
> from linux or restart hawq but this can kill other things as well.
> The JDBC client I am using is Aqua Data Studio.
> I can provide exact steps to reproduce if required
> Thank you
> Grant 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HAWQ-1530) Illegally killing a JDBC select query causes locking problems

[Yi Jin (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241780#comment-16241780
 ] 

Yi Jin commented on HAWQ-1530:
--

I will provide a fix very soon which possibly fix this issue .

> Illegally killing a JDBC select query causes locking problems
> -
>
> Key: HAWQ-1530
> URL: https://issues.apache.org/jira/browse/HAWQ-1530
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Transaction
>Reporter: Grant Krieger
>Assignee: Radar Lei
>
> Hi,
> When you perform a long running select statement on 2 hawq tables (join) from 
> JDBC and illegally kill the JDBC client (CTRL ALT DEL) before completion of 
> the query the 2 tables remained locked even when the query completes on the 
> server. 
> The lock is visible via PG_locks. One cannot kill the query via SELECT 
> pg_terminate_backend(393937). The only way to get rid of it is to kill -9 
> from linux or restart hawq but this can kill other things as well.
> The JDBC client I am using is Aqua Data Studio.
> I can provide exact steps to reproduce if required
> Thank you
> Grant 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)