[GitHub] incubator-hawq pull request #1390: HAWQ-1650. Fix compilation issue in Java ...

2018-08-13 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1390


---

[GitHub] incubator-hawq pull request #1390: HAWQ-1650. Fix compilation issue in Java ...

2018-08-13 Thread frankgh 
GitHub user frankgh opened a pull request:

https://github.com/apache/incubator-hawq/pull/1390

HAWQ-1650. Fix compilation issue in Java 7

Fixes compilation issue in Java 7 for SecureHDFSTest

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/frankgh/incubator-hawq HAWQ-1650

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1390.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1390


commit 9f33d8dd0c97d06a5e2fcb555b73fd83281c1494
Author: Francisco Guerrero 
Date:   2018-08-13T21:43:06Z

HAWQ-1650. Fix compilation issue in Java 7




---

[jira] [Created] (HAWQ-1650) PXF fails to compile on Java 7

2018-08-13 Thread Francisco Guerrero (JIRA) 
Francisco Guerrero created HAWQ-1650:


 Summary: PXF fails to compile on Java 7
 Key: HAWQ-1650
 URL: https://issues.apache.org/jira/browse/HAWQ-1650
 Project: Apache HAWQ
  Issue Type: Bug
  Components: PXF
Reporter: Francisco Guerrero
Assignee: Ed Espino


> Task :pxf-service:compileTestJava FAILED
[ 
|https://ud.ci.gpdb.pivotal.io/teams/main/pipelines/gpdb_pxf_master/jobs/compile_pxf/builds/13#L5b6c87d4:58]
/tmp/build/04bb138f/pxf_src/pxf/pxf-service/src/test/java/org/apache/hawq/pxf/service/utilities/SecuredHDFSTest.java:55:
 error: no suitable method found for addToken(Object)
[ 
|https://ud.ci.gpdb.pivotal.io/teams/main/pipelines/gpdb_pxf_master/jobs/compile_pxf/builds/13#L5b6c87d4:59]
 verify(ugi, never()).addToken(any());
[ 
|https://ud.ci.gpdb.pivotal.io/teams/main/pipelines/gpdb_pxf_master/jobs/compile_pxf/builds/13#L5b6c87d4:60]
 ^
[ 
|https://ud.ci.gpdb.pivotal.io/teams/main/pipelines/gpdb_pxf_master/jobs/compile_pxf/builds/13#L5b6c87d4:61]
 method UserGroupInformation.addToken(Text,Token) is 
not applicable
[ 
|https://ud.ci.gpdb.pivotal.io/teams/main/pipelines/gpdb_pxf_master/jobs/compile_pxf/builds/13#L5b6c87d4:62]
 (actual and formal argument lists differ in length)
[ 
|https://ud.ci.gpdb.pivotal.io/teams/main/pipelines/gpdb_pxf_master/jobs/compile_pxf/builds/13#L5b6c87d4:63]
 method UserGroupInformation.addToken(Token) is not 
applicable
[ 
|https://ud.ci.gpdb.pivotal.io/teams/main/pipelines/gpdb_pxf_master/jobs/compile_pxf/builds/13#L5b6c87d4:64]
 (actual argument Object cannot be converted to Token by method invocation conversion)
[ 
|https://ud.ci.gpdb.pivotal.io/teams/main/pipelines/gpdb_pxf_master/jobs/compile_pxf/builds/13#L5b6c87d4:65]
1 error
 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] incubator-hawq pull request #1389: Run gradle build in parallel

2018-08-13 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1389


---

[GitHub] incubator-hawq pull request #1389: Run gradle build in parallel

2018-08-13 Thread frankgh 
GitHub user frankgh opened a pull request:

https://github.com/apache/incubator-hawq/pull/1389

Run gradle build in parallel

Improve PXF compilation time by running gradle in parallel and using gradle 
daemon

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/frankgh/incubator-hawq HAWQ-1649

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1389.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1389


commit 2c4af56f407fb65eb7bdc7b690984907c0d2c36b
Author: Francisco Guerrero 
Date:   2018-08-13T18:45:14Z

Add parallel true and daemon to gradle properties




---

[jira] [Created] (HAWQ-1649) Improve compilation time for PXF by running gradle in parallel

2018-08-13 Thread Francisco Guerrero (JIRA) 
Francisco Guerrero created HAWQ-1649:


 Summary: Improve compilation time for PXF by running gradle in 
parallel
 Key: HAWQ-1649
 URL: https://issues.apache.org/jira/browse/HAWQ-1649
 Project: Apache HAWQ
  Issue Type: Improvement
  Components: PXF
Reporter: Francisco Guerrero
Assignee: Ed Espino


Improve PXF compilation time by running gradle in parallel and using gradle 
daemon



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] incubator-hawq issue #1384: HAWQ-1628. Add HDFS protocol for external storag...

2018-08-13 Thread ztao1987 
Github user ztao1987 commented on the issue:

https://github.com/apache/incubator-hawq/pull/1384
  
+1


---

[GitHub] incubator-hawq pull request #1388: Fix doc and makefile issue for hawq docke...

2018-08-13 Thread ginobiliwang 
GitHub user ginobiliwang opened a pull request:

https://github.com/apache/incubator-hawq/pull/1388

Fix doc and makefile issue for hawq docker

make pull command will fail without remote docker registry, so add local 
docker registry operations.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ginobiliwang/incubator-hawq 
fix-doc-and-makefile-issue-for-hawq-docker

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1388.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1388


commit 6ed93ebf1abf877547376d895966cf9066c21d03
Author: Fenggang 
Date:   2018-08-13T07:00:50Z

fix doc and makefile issue for hawq-docker

commit fb6e78ae3f83fac6bd2ff8b81be25856d8e791ec
Author: Fenggang 
Date:   2018-08-13T07:10:17Z

fix doc and makefile issue for hawq-docker v0.2




---

[GitHub] incubator-hawq issue #1384: HAWQ-1628. Add HDFS protocol for external storag...

2018-08-13 Thread stanlyxiang 
Github user stanlyxiang commented on the issue:

https://github.com/apache/incubator-hawq/pull/1384
  
 Though some similar problems(indent, format, free Uri, etc) were not 
pointed out, pls go through the code and fix all similar problems above. 


---

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-13 Thread stanlyxiang 
Github user stanlyxiang commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1384#discussion_r209506292
  
--- Diff: contrib/exthdfs/exthdfs.c ---
@@ -0,0 +1,469 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include "postgres.h"
+
+#include "common.h"
+#include "access/extprotocol.h"
+#include "cdb/cdbdatalocality.h"
+#include "storage/fd.h"
+#include "storage/filesystem.h"
+#include "utils/uri.h"
+
+
+
+
+PG_MODULE_MAGIC;
+
+PG_FUNCTION_INFO_V1(hdfsprotocol_blocklocation);
+PG_FUNCTION_INFO_V1(hdfsprotocol_validate);
+
+Datum hdfsprotocol_blocklocation(PG_FUNCTION_ARGS);
+Datum hdfsprotocol_validate(PG_FUNCTION_ARGS);
+
+Datum hdfsprotocol_blocklocation(PG_FUNCTION_ARGS)
+{
+
+   // Build the result instance
+   int nsize = 0;
+   int numOfBlock = 0;
+   ExtProtocolBlockLocationData *bldata =
+   palloc0(sizeof(ExtProtocolBlockLocationData));
+   if (bldata == NULL)
+   {
+   elog(ERROR, "hdfsprotocol_blocklocation : "
+"cannot allocate due to no memory");
+   }
+   bldata->type = T_ExtProtocolBlockLocationData;
+   fcinfo->resultinfo = bldata;
+
+   ExtProtocolValidatorData *pvalidator_data = (ExtProtocolValidatorData *)
+   
(fcinfo->context);
+
+
+// Parse URI of the first location, we expect all locations uses the 
same
+// name node server. This is checked in validation function.
+
+   char *first_uri_str = (char 
*)strVal(lfirst(list_head(pvalidator_data->url_list)));
+   Uri *uri = ParseExternalTableUri(first_uri_str);
+
+   elog(DEBUG3, "hdfsprotocol_blocklocation : "
+"extracted HDFS name node address %s:%d",
+uri->hostname, uri->port);
+
+   // Create file system instance
+   hdfsFS fs = hdfsConnect(uri->hostname, uri->port);
+   if (fs == NULL)
+   {
+   elog(ERROR, "hdfsprotocol_blocklocation : "
+   "failed to create HDFS instance to 
connect to %s:%d",
+   uri->hostname, uri->port);
+   }
+
+   // Clean up uri instance as we don't need it any longer
+   pfree(uri);
--- End diff --

please use "FreeExternalTableUri" to all Uri


---

[GitHub] incubator-hawq issue #1384: HAWQ-1628. Add HDFS protocol for external storag...

2018-08-13 Thread changleicn 
Github user changleicn commented on the issue:

https://github.com/apache/incubator-hawq/pull/1384
  
+1


---

[GitHub] incubator-hawq issue #1384: HAWQ-1628. Add HDFS protocol for external storag...

2018-08-13 Thread huor 
Github user huor commented on the issue:

https://github.com/apache/incubator-hawq/pull/1384
  
LGTM, +1


---