[GitHub] incubator-hawq pull request #779: HAWQ-779. PXF Fix filter test failures
Github user GodenYao commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/779#discussion_r69990137 --- Diff: src/backend/access/external/test/pxffilters_test.c --- @@ -42,6 +42,7 @@ test__supported_filter_type(void **state) CHAROID, BYTEAOID, BOOLOID, +DATEOID, --- End diff -- indention --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #779: HAWQ-779. PXF Fix filter test failures
Github user GodenYao commented on the issue: https://github.com/apache/incubator-hawq/pull/779 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #779: HAWQ-779. PXF Fix filter test failures
Github user GodenYao commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/779#discussion_r69995640 --- Diff: src/backend/access/external/test/pxffilters_test.c --- @@ -61,7 +62,7 @@ test__supported_filter_type(void **state) /* go over pxf_supported_types array */ int nargs = sizeof(pxf_supported_types) / sizeof(Oid); - assert_int_equal(nargs, 12); + assert_int_equal(nargs, 13); --- End diff -- Good idea ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #790: HAWQ-919. add missing ASF license header
GitHub user GodenYao opened a pull request: https://github.com/apache/incubator-hawq/pull/790 HAWQ-919. add missing ASF license header You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-hawq HAWQ-919 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/790.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #790 commit fa88c325d030039fa74daee100381c0b6d07b3a0 Author: Goden Yao Date: 2016-07-12T19:10:27Z add missing ASF license header --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #790: HAWQ-919. add missing ASF license header
Github user GodenYao closed the pull request at: https://github.com/apache/incubator-hawq/pull/790 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #803: HAWQ-932. Added pxf service address to curl resol...
Github user GodenYao commented on the issue: https://github.com/apache/incubator-hawq/pull/803 churl_init_upload and churl_init_download only has 1 tag difference ( context->upload = true vs. false) probably worth refactoring to a single function and invoked by these 2, which will make it semantic readable as well as easy to maintain --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #811: GPSQL-3288: Set dummy workfile pointer to NULL af...
Github user GodenYao commented on the issue: https://github.com/apache/incubator-hawq/pull/811 even this is an internal customer JIRA, we should still file Apache JIRA so the repro steps and RCA are available to public. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #821: HAWQ-931. ORC optimized profile for PPD/CP
Github user GodenYao commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/821#discussion_r72674878 --- Diff: pxf/gradle.properties --- @@ -23,4 +23,5 @@ hiveVersion=1.2.1 hbaseVersionJar=1.1.2 hbaseVersionRPM=1.1.2 tomcatVersion=7.0.62 -pxfProtocolVersion=v14 \ No newline at end of file +pxfProtocolVersion=v14 +orcVersion=1.1.1 --- End diff -- if we still use hive apis, why do we need orcVersion? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #848: HAWQ-1006. Fix RPM compliance in Redhat Satellite...
Github user GodenYao commented on the issue: https://github.com/apache/incubator-hawq/pull/848 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #853: HAWQ-967. Extend Projection info to include filte...
Github user GodenYao commented on the issue: https://github.com/apache/incubator-hawq/pull/853 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #854: HAWQ-997. HAWQ doesn't send PXF data type with pr...
Github user GodenYao commented on the issue: https://github.com/apache/incubator-hawq/pull/854 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...
Github user GodenYao commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/837#discussion_r76469613
--- Diff:
pxf/pxf-hbase/src/main/java/org/apache/hawq/pxf/plugins/hbase/HBaseFilterBuilder.java
---
@@ -165,6 +165,14 @@ private Filter
handleSimpleOperations(FilterParser.Operation opId,
ByteArrayComparable comparator =
getComparator(hbaseColumn.columnTypeCode(),
constant.constant());
+if(operatorsMap.get(opId) == null){
+//HBase not support HDOP_LIKE, use 'NOT NULL' Comarator
--- End diff --
comparator
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...
Github user GodenYao commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/873#discussion_r77071575
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
---
@@ -256,4 +257,68 @@ private static boolean verifyIntegerModifiers(String[]
modifiers) {
throw new RuntimeException("Failed connecting to Hive
MetaStore service: " + cause.getMessage(), cause);
}
}
+
+
+/**
+ * Converts HAWQ type to hive type. The supported mappings are:
+ * {@code BOOLEAN -> boolean}
+ * {@code SMALLINT -> smallint (tinyint is converted to
smallint)}
+ * {@code BIGINT -> bigint}
+ * {@code TIMESTAMP -> timestamp}
+ * {@code NUMERIC -> decimal}
+ * {@code BYTEA -> binary}
+ * {@code INTERGER -> int}
+ * {@code TEXT -> string}
+ * {@code REAL -> float}
+ * {@code FLOAT8 -> double}
+ *
+ * All other types (both in HAWQ and in HIVE) are not supported.
+ *
+ * @param type HAWQ data type
+ * @param name field name
+ * @return Hive type
+ * @throws UnsupportedTypeException if type is not supported
+ */
+public static String toCompatibleHiveType(DataType type) {
+
+EnumHiveToHawqType hiveToHawqType =
EnumHiveToHawqType.getCompatibleHawqToHiveType(type);
+return hiveToHawqType.getTypeName();
+}
+
+
+
+public static void validateTypeCompatible(DataType hawqDataType,
Integer[] hawqTypeMods, String hiveType, String hawqColumnName) {
+
+EnumHiveToHawqType hiveToHawqType =
EnumHiveToHawqType.getHiveToHawqType(hiveType);
+EnumHawqType expectedHawqType = hiveToHawqType.getHawqType();
+
+if (!expectedHawqType.getDataType().equals(hawqDataType)) {
+throw new UnsupportedTypeException("Invalid definition for
column " + hawqColumnName
++ ": expected HAWQ type " +
expectedHawqType.getDataType() +
+", actual HAWQ type " + hawqDataType);
+}
+
+if ((hawqTypeMods == null || hawqTypeMods.length == 0) &&
expectedHawqType.isMandatoryModifiers())
+throw new UnsupportedTypeException("Invalid definition for
column " + hawqColumnName + ": modifiers are mandatory for type " +
expectedHawqType.getTypeName());
+
--- End diff --
In the case of Hive: Char(xxx) with a fixed length to HAWQ: Char , length
omitted, default to 1, we should give user information about the length from
Hive: Char(xxx), so they can modify the table definition.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...
Github user GodenYao commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/873#discussion_r77076673
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
---
@@ -256,4 +257,68 @@ private static boolean verifyIntegerModifiers(String[]
modifiers) {
throw new RuntimeException("Failed connecting to Hive
MetaStore service: " + cause.getMessage(), cause);
}
}
+
+
+/**
+ * Converts HAWQ type to hive type. The supported mappings are:
+ * {@code BOOLEAN -> boolean}
+ * {@code SMALLINT -> smallint (tinyint is converted to
smallint)}
+ * {@code BIGINT -> bigint}
+ * {@code TIMESTAMP -> timestamp}
+ * {@code NUMERIC -> decimal}
+ * {@code BYTEA -> binary}
+ * {@code INTERGER -> int}
+ * {@code TEXT -> string}
+ * {@code REAL -> float}
+ * {@code FLOAT8 -> double}
+ *
--- End diff --
based on the logic we also support:
`
case VARCHAR:
+case BPCHAR:
+case CHAR:
`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...
Github user GodenYao commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/873#discussion_r77076942
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
---
@@ -256,4 +257,68 @@ private static boolean verifyIntegerModifiers(String[]
modifiers) {
throw new RuntimeException("Failed connecting to Hive
MetaStore service: " + cause.getMessage(), cause);
}
}
+
+
+/**
+ * Converts HAWQ type to hive type. The supported mappings are:
+ * {@code BOOLEAN -> boolean}
+ * {@code SMALLINT -> smallint (tinyint is converted to
smallint)}
+ * {@code BIGINT -> bigint}
+ * {@code TIMESTAMP -> timestamp}
+ * {@code NUMERIC -> decimal}
+ * {@code BYTEA -> binary}
+ * {@code INTERGER -> int}
+ * {@code TEXT -> string}
+ * {@code REAL -> float}
+ * {@code FLOAT8 -> double}
+ *
+ * All other types (both in HAWQ and in HIVE) are not supported.
+ *
+ * @param type HAWQ data type
+ * @param name field name
+ * @return Hive type
+ * @throws UnsupportedTypeException if type is not supported
+ */
+public static String toCompatibleHiveType(DataType type) {
+
+EnumHiveToHawqType hiveToHawqType =
EnumHiveToHawqType.getCompatibleHawqToHiveType(type);
+return hiveToHawqType.getTypeName();
+}
+
+
+
+public static void validateTypeCompatible(DataType hawqDataType,
Integer[] hawqTypeMods, String hiveType, String hawqColumnName) {
+
+EnumHiveToHawqType hiveToHawqType =
EnumHiveToHawqType.getHiveToHawqType(hiveType);
+EnumHawqType expectedHawqType = hiveToHawqType.getHawqType();
+
+if (!expectedHawqType.getDataType().equals(hawqDataType)) {
+throw new UnsupportedTypeException("Invalid definition for
column " + hawqColumnName
++ ": expected HAWQ type " +
expectedHawqType.getDataType() +
+", actual HAWQ type " + hawqDataType);
+}
+
+if ((hawqTypeMods == null || hawqTypeMods.length == 0) &&
expectedHawqType.isMandatoryModifiers())
+throw new UnsupportedTypeException("Invalid definition for
column " + hawqColumnName + ": modifiers are mandatory for type " +
expectedHawqType.getTypeName());
+
+switch (hawqDataType) {
+case NUMERIC:
+case VARCHAR:
+case BPCHAR:
+case CHAR:
+if (hawqTypeMods != null && hawqTypeMods.length > 0) {
+Integer[] hiveTypeModifiers = EnumHiveToHawqType
+.extractModifiers(hiveType);
+for (int i = 0; i < hiveTypeModifiers.length; i++) {
+if (hawqTypeMods[i] < hiveTypeModifiers[i])
+throw new UnsupportedTypeException(
+"Invalid definition for column " +
hawqColumnName
++ ": modifiers are not
compatible, "
++
Arrays.toString(hiveTypeModifiers) + ", "
++
Arrays.toString(hawqTypeMods));
--- End diff --
same as above comment, should tell user the length for modifier , for
numeric, it needs to be exactly match I suppose? for VARCHAR, BPCHAR and CHAR,
if modifier exists on HAWQ side, it needs to be >= Hive same type modifier.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...
Github user GodenYao commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/873#discussion_r77077634
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/EnumHiveToHawqType.java
---
@@ -110,4 +122,68 @@ public static EnumHiveToHawqType
getHiveToHawqType(String hiveType) {
+ hiveType + " to HAWQ's type");
}
+
+/**
+ *
+ * @param dataType Hawq data type
+ * @return compatible Hive type to given Hawq type, if there are more
than one compatible types, it returns one with bigger size
+ * @throws UnsupportedTypeException if there is no corresponding Hive
type for given Hawq type
+ */
+public static EnumHiveToHawqType getCompatibleHawqToHiveType(DataType
dataType) {
+
+SortedSet types = new
TreeSet(
+new Comparator() {
+public int compare(EnumHiveToHawqType a,
+EnumHiveToHawqType b) {
+return Byte.compare(a.getSize(), b.getSize());
+}
+});
+
+for (EnumHiveToHawqType t : values()) {
+if (t.getHawqType().getDataType().equals(dataType)) {
+types.add(t);
+}
+}
+
+if (types.size() == 0)
+throw new UnsupportedTypeException("Unable to find compatible
Hive type for given HAWQ's type: " + dataType);
+
--- End diff --
the error message should be reversed:
> Unable to find compatible **HAWQ** type for given **Hive**'s type
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...
Github user GodenYao commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/873#discussion_r77079334
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/EnumHiveToHawqType.java
---
@@ -29,8 +35,8 @@
*/
public enum EnumHiveToHawqType {
-TinyintType("tinyint", EnumHawqType.Int2Type),
-SmallintType("smallint", EnumHawqType.Int2Type),
+TinyintType("tinyint", EnumHawqType.Int2Type, (byte) 1),
+SmallintType("smallint", EnumHawqType.Int2Type, (byte) 2),
--- End diff --
maybe some comments about adding the byte 1/2 here to differentiate the 2
types on hawq side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...
Github user GodenYao commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/873#discussion_r77084340
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
---
@@ -256,4 +257,68 @@ private static boolean verifyIntegerModifiers(String[]
modifiers) {
throw new RuntimeException("Failed connecting to Hive
MetaStore service: " + cause.getMessage(), cause);
}
}
+
+
+/**
+ * Converts HAWQ type to hive type. The supported mappings are:
+ * {@code BOOLEAN -> boolean}
+ * {@code SMALLINT -> smallint (tinyint is converted to
smallint)}
+ * {@code BIGINT -> bigint}
+ * {@code TIMESTAMP -> timestamp}
+ * {@code NUMERIC -> decimal}
+ * {@code BYTEA -> binary}
+ * {@code INTERGER -> int}
+ * {@code TEXT -> string}
+ * {@code REAL -> float}
+ * {@code FLOAT8 -> double}
+ *
+ * All other types (both in HAWQ and in HIVE) are not supported.
+ *
+ * @param type HAWQ data type
+ * @param name field name
+ * @return Hive type
+ * @throws UnsupportedTypeException if type is not supported
+ */
+public static String toCompatibleHiveType(DataType type) {
+
+EnumHiveToHawqType hiveToHawqType =
EnumHiveToHawqType.getCompatibleHawqToHiveType(type);
+return hiveToHawqType.getTypeName();
+}
+
+
+
+public static void validateTypeCompatible(DataType hawqDataType,
Integer[] hawqTypeMods, String hiveType, String hawqColumnName) {
+
+EnumHiveToHawqType hiveToHawqType =
EnumHiveToHawqType.getHiveToHawqType(hiveType);
+EnumHawqType expectedHawqType = hiveToHawqType.getHawqType();
+
+if (!expectedHawqType.getDataType().equals(hawqDataType)) {
+throw new UnsupportedTypeException("Invalid definition for
column " + hawqColumnName
++ ": expected HAWQ type " +
expectedHawqType.getDataType() +
+", actual HAWQ type " + hawqDataType);
+}
+
+if ((hawqTypeMods == null || hawqTypeMods.length == 0) &&
expectedHawqType.isMandatoryModifiers())
+throw new UnsupportedTypeException("Invalid definition for
column " + hawqColumnName + ": modifiers are mandatory for type " +
expectedHawqType.getTypeName());
+
--- End diff --
Another thing:
```
CharType("char", EnumHawqType.BpcharType, "[(,)]"),
```
according to the code above, we convert Hive: char to HAWQ: Bpchar type. In
that case, why do we need to check modifier as HAWQ: char (xxx) won't be
compared, it's different oid of HAWQ: Bpchar
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...
Github user GodenYao commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/873#discussion_r77085040
--- Diff:
pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/utilities/EnumHawqType.java
---
@@ -43,37 +45,40 @@ public void serialize(EnumHawqType value, JsonGenerator
generator,
*/
@JsonSerialize(using = EnumHawqTypeSerializer.class)
public enum EnumHawqType {
-Int2Type("int2"),
-Int4Type("int4"),
-Int8Type("int8"),
-Float4Type("float4"),
-Float8Type("float8"),
-TextType("text"),
-VarcharType("varchar", (byte) 1, true),
-ByteaType("bytea"),
-DateType("date"),
-TimestampType("timestamp"),
-BoolType("bool"),
-NumericType("numeric", (byte) 2, true),
-BpcharType("bpchar", (byte) 1, true);
+Int2Type("int2", DataType.SMALLINT),
+Int4Type("int4", DataType.INTEGER),
+Int8Type("int8", DataType.BIGINT),
+Float4Type("float4", DataType.REAL),
+Float8Type("float8", DataType.FLOAT8),
+TextType("text", DataType.TEXT),
+VarcharType("varchar", DataType.VARCHAR, (byte) 1, false),
+ByteaType("bytea", DataType.BYTEA),
+DateType("date", DataType.DATE),
+TimestampType("timestamp", DataType.TIMESTAMP),
+BoolType("bool", DataType.BOOLEAN),
+NumericType("numeric", DataType.NUMERIC, (byte) 2, false),
+BpcharType("bpchar", DataType.BPCHAR, (byte) 1, false),
+//modifier is mandatory for this type because by default it's 1
+CharType("char", DataType.CHAR, (byte) 1, true);
--- End diff --
this type is not used in hivetohawq conversion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...
Github user GodenYao commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/873#discussion_r77103957
--- Diff:
pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/utilities/EnumHawqType.java
---
@@ -43,37 +45,40 @@ public void serialize(EnumHawqType value, JsonGenerator
generator,
*/
@JsonSerialize(using = EnumHawqTypeSerializer.class)
public enum EnumHawqType {
-Int2Type("int2"),
-Int4Type("int4"),
-Int8Type("int8"),
-Float4Type("float4"),
-Float8Type("float8"),
-TextType("text"),
-VarcharType("varchar", (byte) 1, true),
-ByteaType("bytea"),
-DateType("date"),
-TimestampType("timestamp"),
-BoolType("bool"),
-NumericType("numeric", (byte) 2, true),
-BpcharType("bpchar", (byte) 1, true);
+Int2Type("int2", DataType.SMALLINT),
+Int4Type("int4", DataType.INTEGER),
+Int8Type("int8", DataType.BIGINT),
+Float4Type("float4", DataType.REAL),
+Float8Type("float8", DataType.FLOAT8),
+TextType("text", DataType.TEXT),
+VarcharType("varchar", DataType.VARCHAR, (byte) 1, false),
+ByteaType("bytea", DataType.BYTEA),
+DateType("date", DataType.DATE),
+TimestampType("timestamp", DataType.TIMESTAMP),
+BoolType("bool", DataType.BOOLEAN),
+NumericType("numeric", DataType.NUMERIC, (byte) 2, false),
+BpcharType("bpchar", DataType.BPCHAR, (byte) 1, false),
--- End diff --
yes, if omitting the modifier, bpchar will be dynamic length
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #837: HAWQ-779 support pxf filter pushdwon at the 'CREA...
Github user GodenYao commented on the issue: https://github.com/apache/incubator-hawq/pull/837 merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #:
Github user GodenYao commented on the pull request: https://github.com/apache/incubator-hawq/commit/9b7f90b744850ff83769c3a46e6d4daeb109cc68#commitcomment-19184677 why change the folder path? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #965: HAWQ-1057. Skip SARG_PUSHDOWN parameter if any of...
Github user GodenYao commented on the issue: https://github.com/apache/incubator-hawq/pull/965 +1 ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #738: Hawq 743
Github user GodenYao commented on the issue: https://github.com/apache/incubator-hawq/pull/738 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
