[GitHub] incubator-hawq issue #1336: HAWQ-1514. TDE feature makes libhdfs3 require op...

2018-02-01 Thread jinyismilodon
Github user jinyismilodon commented on the issue:

https://github.com/apache/incubator-hawq/pull/1336
  
+1 LGTM, thanks!


---


[GitHub] incubator-hawq issue #1310: HAWQ-1548 Correct ambiguous message while loggin...

2017-11-13 Thread jinyismilodon
Github user jinyismilodon commented on the issue:

https://github.com/apache/incubator-hawq/pull/1310
  
@outofmem0ry Per my design, the first log is to output dynamic total YARN 
cluster capacity change, not per node value, that log is output only when total 
YARN capacity changes.

The second log is output only when available YARN capacity for HAWQ 
changes, not for per node. 

So basically, we cannot say that is for per node. 


---


[GitHub] incubator-hawq issue #1243: HAWQ-1458. Fix share input scan bug for writer p...

2017-08-21 Thread jinyismilodon
Github user jinyismilodon commented on the issue:

https://github.com/apache/incubator-hawq/pull/1243
  
+1 LGTM This is a good sample fix for future potential inter-process 
failure detection. Thx.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1279: HAWQ-1310. Reformat resource_negotiator().

2017-08-14 Thread jinyismilodon
Github user jinyismilodon commented on the issue:

https://github.com/apache/incubator-hawq/pull/1279
  
This has been delivered last week per my understanding, please close it 
@amyrazz44 . Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1275: HAWQ-1333. Change access mode of source files fo...

2017-08-10 Thread jinyismilodon
Github user jinyismilodon commented on the issue:

https://github.com/apache/incubator-hawq/pull/1275
  
Good job, please have pr delivered asap. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1051: HAWQ-1214. Remove resource_parameters

2016-12-14 Thread jinyismilodon
Github user jinyismilodon commented on the issue:

https://github.com/apache/incubator-hawq/pull/1051
  
+1 

One trivial comment about output int64 or unsigned int64 data, I think it 
is better to use INT64_FORMAT and UINT64_FORMAT instead of %lld. Though this is 
not actually involved in your fix. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #776: HAWQ-891. Fix functiontest build error

2016-07-05 Thread jinyismilodon
Github user jinyismilodon commented on the issue:

https://github.com/apache/incubator-hawq/pull/776
  
+1 LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #710: HAWQ-715. fix libyarn HA configuration bug

2016-06-14 Thread jinyismilodon
Github user jinyismilodon commented on the issue:

https://github.com/apache/incubator-hawq/pull/710
  
LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---