[GitHub] incubator-hawq issue #1384: HAWQ-1628. Add HDFS protocol for external storag...

2018-08-15 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1384
  
Do you have --enable-cassert enabled? e.g. 
./configure --enable-debug --enable-cassert
I got such kind of errors:
`make[3]: Entering directory 
`/tmp/build/78017950/hdb_apache/src/backend/executor'
gcc -O0 -std=gnu99  -Wall -Wmissing-prototypes -Wpointer-arith  
-Wendif-labels -Wformat-security -fno-strict-aliasing -fwrapv 
-fno-aggressive-loop-optimizations -g -ggdb 
-I/usr/local/curl-7.50.3-bin/include -I/usr/include/libxml2 
-I../../../src/backend/gp_libpq_fe -I../../../src/include -D_GNU_SOURCE  
-I/home/build/hdb_apache/depends/libhdfs3/build/install/home/build/hawq_install/include
 
-I/home/build/hdb_apache/depends/libyarn/build/install/home/build/hawq_install/include
  -c -o execAmi.o execAmi.c
PYTHONPATH=/usr/lib64 /bin/python ./catcoregen.py catcoretable.c 
/home/build/hdb_apache/tools/bin/gppylib/data/2.3.json
gcc -O0 -std=gnu99  -Wall -Wmissing-prototypes -Wpointer-arith  
-Wendif-labels -Wformat-security -fno-strict-aliasing -fwrapv 
-fno-aggressive-loop-optimizations -g -ggdb 
-I/usr/local/curl-7.50.3-bin/include -I/usr/include/libxml2 
-I../../../../src/include -D_GNU_SOURCE  
-I/home/build/hdb_apache/depends/libhdfs3/build/install/home/build/hawq_install/include
 
-I/home/build/hdb_apache/depends/libyarn/build/install/home/build/hawq_install/include
  -c -o gistutil.o gistutil.c
analyze.c: In function ‘do_parse_analyze’:
analyze.c:583:20: warning: variable ‘n’ set but not used 
[-Wunused-but-set-variable]
AlterTableStmt *n;
^
In file included from analyze.c:45:0:
analyze.c: In function ‘transformCreateStmt’:
analyze.c:2095:13: error: ‘CreateStmt’ has no member named 
‘constraints’
  Assert(stmt->constraints == NIL);
 ^
../../../src/include/postgres.h:462:28: note: in definition of macro 
‘Trap’
   if ((assert_enabled) && (condition)) \
^
analyze.c:2095:2: note: in expansion of macro ‘Assert’
  Assert(stmt->constraints == NIL);
  ^
analyze.c: At top level:
analyze.c::34: warning: no previous prototype for 
‘MatchExternalRelationFormatterOption’ [-Wmissing-prototypes]
 enum PreDefinedFormatterOptionID MatchExternalRelationFormatterOption(
  ^
analyze.c: In function ‘recognizeExternalRelationFormatterOptions’:
analyze.c:2371:11: warning: passing argument 2 of ‘makeDefElem’ from 
incompatible pointer type [enabled by default]
   makeDefElem("reject_limit", makeInteger(errDesc->rejectlimit)));
   ^
In file included from analyze.c:75:0:
../../../src/include/nodes/makefuncs.h:68:17: note: expected ‘struct Node 
*’ but argument is of type ‘struct Value *’
 extern DefElem *makeDefElem(char *name, Node *arg);`


---


[GitHub] incubator-hawq issue #1384: HAWQ-1628. Add HDFS protocol for external storag...

2018-08-15 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1384
  
@oushu1wangziming1 What platform are you using? I got the issue on Linux. 
Or if it requires any new dependencies? Thanks.


---


[GitHub] incubator-hawq issue #1384: HAWQ-1628. Add HDFS protocol for external storag...

2018-08-14 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1384
  
First I see there are compile issue in dbg mode, and I see unittest 
failures. Please help to verify.

And please add Jira number to to commit message. Thanks.



---


[GitHub] incubator-hawq issue #1387: HAWQ-1647. Update HAWQ version from 2.3.0.0 to 2...

2018-08-09 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1387
  
The Jenkins test seems have git clone issue, travis test passed. 

@edespino @jiny2 @huor @interma Please help to review, thanks.


---


[GitHub] incubator-hawq pull request #1387: HAWQ-1647. Update HAWQ version from 2.3.0...

2018-08-08 Thread radarwave
GitHub user radarwave opened a pull request:

https://github.com/apache/incubator-hawq/pull/1387

HAWQ-1647. Update HAWQ version from 2.3.0.0 to 2.4.0.0



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/radarwave/incubator-hawq HAWQ-1647

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1387.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1387


commit 9800d3b8bd5806c759b7be62fc618d1ceaa99bec
Author: rlei 
Date:   2018-08-07T09:43:23Z

HAWQ-1647. Update HAWQ version from 2.3.0.0 to 2.4.0.0




---


[GitHub] incubator-hawq-site issue #17: HAWQ-1638. Add how to verify downloaded files...

2018-07-10 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq-site/pull/17
  
Add @dyozie 


---


[GitHub] incubator-hawq-site pull request #17: HAWQ-1638. Add how to verify downloade...

2018-07-10 Thread radarwave
GitHub user radarwave opened a pull request:

https://github.com/apache/incubator-hawq-site/pull/17

HAWQ-1638. Add how to verify downloaded files section, removed md5 keys.

Added a section about how to verify downloaded files.

Removed MD5 references.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/radarwave/incubator-hawq-site HAWQ-1638

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq-site/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17


commit fff3da1168b91ceec758dbfe6b1e0f8e6ae6fb4b
Author: rlei 
Date:   2018-07-10T10:05:01Z

HAWQ-1638. Add how to verify downloaded files section, removed md5 keys.




---


[GitHub] incubator-hawq-site issue #16: HAWQ-1638. Correct typo and use full name for...

2018-07-09 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq-site/pull/16
  
Download links fix will be update later.

@changleicn  @edespino @jiny2 
Would you help to review? Thanks.


---


[GitHub] incubator-hawq-site pull request #16: HAWQ-1638. Correct typo and use full n...

2018-07-09 Thread radarwave
GitHub user radarwave opened a pull request:

https://github.com/apache/incubator-hawq-site/pull/16

HAWQ-1638. Correct typo and use full name for ASF products 

Correct typo for madlib and use full name for ASF products with the 
first/main references.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/radarwave/incubator-hawq-site HAWQ-1638

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq-site/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #16


commit c6a20e535d9a36d39977269b00b2e6cea05687f8
Author: rlei 
Date:   2018-07-09T09:52:04Z

HAWQ-1638. Correct typo and use full name for ASF products with the 
first/main references.




---


[GitHub] incubator-hawq issue #1375: 2.2.0.0 incubating

2018-07-08 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1375
  
@pengbinbin1 Is this PR created by accident? If true, please help to close 
it. Thanks.


---


[GitHub] incubator-hawq issue #1373: HAWQ-1618. Segment panic at workfile_mgr_close_f...

2018-06-04 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1373
  
+1


---


[GitHub] incubator-hawq issue #1370: HAWQ-1508 fix travis broken

2018-05-30 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1370
  
+1


---


[GitHub] incubator-hawq issue #1315: HAWQ-1556. enable ALTER SCHEMA RENAME/OWNER

2018-05-09 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1315
  
Seems alter schema is disabled with intentional.

Anyone knows the background why we disabled it?


---


[GitHub] incubator-hawq issue #1359: HAWQ-1609. Update regression test configuration

2018-05-04 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1359
  
LGTM.


---


[GitHub] incubator-hawq issue #1355: HAWQ-1606. Fix "make unittest-check" error and s...

2018-04-17 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1355
  
+1


---


[GitHub] incubator-hawq issue #1344: PXF Ignite plugin

2018-03-16 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1344
  
@kapustor To get this PR merged, we need this PR have two '+1' from the 
reviewer, and you need to create corresponding jira and include the jira number 
in the title of the PR. You can refer to other PRs. Thanks.


---


[GitHub] incubator-hawq issue #1341: HAWQ-1583 Add vectorized executor extension and ...

2018-02-10 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1341
  
Thanks @weinan003 . Great to see the first PR for vectorized execution, 
pease check below comments:
1. I guess GNC should be GUC?
2. Please add Jira number to each commits.



---


[GitHub] incubator-hawq issue #1338: HAWQ-1586. Update version from 2.2.0.0 to 2.3.0....

2018-02-07 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1338
  
Thanks @jiny2 Great to see HAWQ version upgraded to 2.3.0.0.
+1


---


[GitHub] incubator-hawq issue #1287: HAWQ-1527 Enabled partition filtering for integr...

2018-02-05 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1287
  
@outofmem0ry  The PR is merged, please close this PR. Thanks.


---


[GitHub] incubator-hawq issue #1336: HAWQ-1514. TDE feature makes libhdfs3 require op...

2018-01-31 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1336
  
LGTM
+1


---


[GitHub] incubator-hawq issue #1336: HAWQ-1514. TDE feature makes libhdfs3 require op...

2018-01-31 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1336
  
Thanks @weinan003 help handle the openssl version issue. I think we should 
modify configure.in then generate configure.


---


[GitHub] incubator-hawq issue #1334: Don't ignore exceptions during bridge.endIterati...

2018-01-30 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1334
  
Any Jira number for this PR and commit? Thanks.


---


[GitHub] incubator-hawq issue #1329: HAWQ-1579. fix logging issue with null Metadata

2018-01-30 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1329
  
@deem0n Thanks for the contribution, please help to close this PR since 
it's already been merged. 


---


[GitHub] incubator-hawq issue #1287: HAWQ-1527 Enabled partition filtering for integr...

2018-01-28 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1287
  
There are already two approved reviews. I will merge this PR soon.


---


[GitHub] incubator-hawq issue #1329: HAWQ-1579. fix logging issue with null Metadata

2018-01-16 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1329
  
Thanks @deem0n , please add 'HAWQ-1579' to the front of commit message 
title as well.



---


[GitHub] incubator-hawq issue #1329: fix logging issue with null Metadata

2018-01-14 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1329
  
@deem0n We need a jira number for each commit, please create a jira or add 
the existing jira information? Thanks.
See: https://issues.apache.org/jira/projects/HAWQ


---


[GitHub] incubator-hawq issue #1328: HAWQ-1578. Regression Test (Feature->Ranger)Fail...

2018-01-08 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1328
  
+1


---


[GitHub] incubator-hawq issue #1325: HAWQ-1125. Running pl/python related feature_tes...

2018-01-02 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1325
  
Merged, please close this PR. Thanks.


---


[GitHub] incubator-hawq issue #1324: HAWQ-1573. Clear debug_query_string in proc_exit...

2018-01-02 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1324
  
Merged, please close this PR. Thanks.


---


[GitHub] incubator-hawq issue #1325: HAWQ-1125. Running pl/python related feature_tes...

2018-01-02 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1325
  
+1


---


[GitHub] incubator-hawq issue #1323: HAWQ-1572 Fix travis ci build failure. Thrift/Bo...

2017-12-14 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1323
  
+1

As Travis used thrift 0.10 in the past, let's fix CI first, we will check 
thrift version later.


---


[GitHub] incubator-hawq issue #1318: HAWQ-1560. Changed log level to DEBUG1 for data ...

2017-12-13 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1318
  
@kroberts7 Thanks for your contribution. 

Now the fix is merged to master, please close this PR. Thanks.


---


[GitHub] incubator-hawq issue #1313: HAWQ-1553 Add option to hawq extract to specify ...

2017-12-07 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1313
  
Already merged, please close this PR. Thanks.


---


[GitHub] incubator-hawq issue #1312: HAWQ-1368 Add option to hawq register to specify...

2017-12-07 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1312
  
Already merged, please close this PR. Thanks.


---


[GitHub] incubator-hawq issue #1292: HAWQ-1532. recognize timezone 'CST' correctly in...

2017-12-07 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1292
  
Already merged, please close this PR. Thanks.


---


[GitHub] incubator-hawq issue #1317: HAWQ-1559 - Fix travis ci build failure due to m...

2017-11-30 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1317
  
LGTM

+1


---


[GitHub] incubator-hawq issue #1292: HAWQ-1532. recognize timezone 'CST' correctly in...

2017-11-30 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1292
  
@kuien This PR passed all the tests in my environment.

+1


---


[GitHub] incubator-hawq issue #1292: HAWQ-1532. recognize timezone 'CST' correctly in...

2017-11-30 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1292
  
Thanks @kuien .

I will test your PR in my environment since you are seeing some environment 
issues in HAWQ-1558.


---


[GitHub] incubator-hawq-site issue #14: HAWQ-1554. Add registered trademark symbol (�...

2017-11-27 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq-site/pull/14
  
LGTM +1


---


[GitHub] incubator-hawq issue #1313: HAWQ-1553 Add option to hawq extract to specify ...

2017-11-21 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1313
  
+1


---


[GitHub] incubator-hawq issue #1312: HAWQ-1368 Add option to hawq register to specify...

2017-11-21 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1312
  
LGTM.

+1


---


[GitHub] incubator-hawq issue #1292: HAWQ-1532. recognize timezone 'CST' correctly in...

2017-11-14 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1292
  
@kuien Do you need any help to go through the test processes?

I think at least we need this PR pass the current feature tests, then you 
can decide if a new test is needed for this commit.


---


[GitHub] incubator-hawq issue #1311: HAWQ-1549 Fix standby resync when using -M smart...

2017-11-13 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1311
  
LGTM +1


---


[GitHub] incubator-hawq issue #1307: HAWQ-1544. prompt file count doesn't match hash ...

2017-11-13 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1307
  
+1


---


[GitHub] incubator-hawq issue #1308: HAWQ-1530. Illegally killing a JDBC select query...

2017-11-07 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1308
  
+1


---


[GitHub] incubator-hawq issue #1296: HAWQ-1496. Add DISCLAIMER, LICENSE and NOTICE fi...

2017-11-06 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1296
  
Thanks @edespino 

So I'm good with it. +1


---


[GitHub] incubator-hawq issue #1292: HAWQ-1532. recognize timezone 'CST' correctly in...

2017-10-22 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1292
  
@kuien 
Please refer to the README of feature test to add your test:
https://github.com/apache/incubator-hawq/tree/master/src/test/feature

And you can run all the feature tests as @xunzhang mentioned above. Thanks.


---


[GitHub] incubator-hawq issue #1292: HAWQ-1532. recognize timezone 'CST' correctly in...

2017-10-19 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1292
  
@kuien Have you ran and passed HAWQ feature tests for this fix? Thanks.


---


[GitHub] incubator-hawq issue #1296: HAWQ-1496. Add DISCLAIMER, LICENSE and NOTICE fi...

2017-10-09 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1296
  
Seems this is only for pxf main rpm, how about the other rpms related to 
pxf?
pxf-hbase
pxf-hdfs
pxf-hive
pxf-jdbc
pxf-json
pxf-service


---


[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...

2017-09-05 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1263
  
@outofmem0ry There is no jira number in your commit, I have add it and 
merged this commit.  Please close this PR. Thanks.


---


[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...

2017-09-04 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1263
  
@outofmem0ry Please squash your commits and rewrite the commit messages as 
now the answer file is not changed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1267: HAWQ-1504 - Fixed namenode hang during docker co...

2017-09-04 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1267
  
@outofmem0ry Code merged, please close this PR. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1285: HAWQ-1520. Create filespace should also skip hdf...

2017-09-04 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1285
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1284: HAWQ-1524 - Fix travis ci build failure caused a...

2017-08-31 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1284
  
+1
Thanks @outofmem0ry for your activated contribution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1267: HAWQ-1504 - Fixed namenode hang during docker co...

2017-08-31 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1267
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1282: HAWQ-1520. gpcheckhdfs should skip hdfs trash di...

2017-08-30 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1282
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1275: HAWQ-1333. Change access mode of source files fo...

2017-08-08 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1275
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...

2017-08-02 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1263
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1271: HAWQ-1508. Fix travis broken caused by libssl pa...

2017-07-27 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1271
  
Travis have been broken for days, thanks @interma to bring it back.

+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1270: HAWQ-1507. Fix unittest-check fail on SuSE

2017-07-27 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1270
  
LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1268: HAWQ-1273 - Removed incorrect references from gp...

2017-07-18 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1268
  
Thanks @outofmem0ry 
The commit is merged, please close this PR. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1268: HAWQ-1273 - Removed incorrect references from gp...

2017-07-17 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1268
  
Thanks @outofmem0ry to fix this.

LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1227: HAWQ-1448. Fixed postmaster process hung at recv...

2017-07-11 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1227
  
When master is down,  it's no matter to stop segment in 'smart' or 'fast' 
mode. And I see this fix only affect 'hawq stop cluster', which means master is 
already down before stoping segments. So I think this fix is good enough to me.

+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

2017-07-11 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1254
  
Thanks for @outofmem0ry 's contribution, I have squashed and merged this 
commit. Please close this PR.

Welcome to do more contributions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

2017-07-08 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1254
  
LGTM  +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1264: HAWQ-1499. Update README.md Travis CI status to ...

2017-07-06 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1264
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #1254: HAWQ-1373 - Added feature to reload GUC v...

2017-07-03 Thread radarwave
Github user radarwave commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1254#discussion_r125388848
  
--- Diff: src/test/feature/ManagementTool/test_hawq_reload.cpp ---
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include 
+#include 
+#include "lib/command.h"
+#include "lib/sql_util.h"
+#include "lib/string_util.h"
+#include "lib/hawq_config.h"
+#include "test_hawq_reload.h"
+
+#include "gtest/gtest.h"
+
+using std::string;
+using hawq::test::SQLUtility;
+using hawq::test::Command;
+
+/*
+Test case for hawq reload . This test changes the value of GUC 
+log_min_messages to debug. Reloads the cluster and verifies if the change
+was reloaded successfully. After the test it resets the valueof GUC to 
--- End diff --

Typo 'valueof'.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #1254: HAWQ-1373 - Added feature to reload GUC v...

2017-07-03 Thread radarwave
Github user radarwave commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1254#discussion_r125376981
  
--- Diff: tools/bin/hawq ---
@@ -120,6 +120,23 @@ def main():
 if second_arg not in cluster_type_list:
 print STOP_HELP
 sys.exit(1)
+# Prints deprecation warning when using old syntax "hawq stop 
 -u" to reload GUC
+if len(sub_args.split("-")) > 1:
+if "-u" in sub_args or "--reload" in sub_args or "u" in 
sub_args.split("-")[1]:
+deprecationMessage = """
+hawq stop  -u is being deprecated and replaced by 
'hawq reload '
--- End diff --

This deprecation message is not align with other messages.
Run 'hawq stop cluster -u' then you can see.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

2017-06-22 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1254
  
@outofmem0ry 
Please check the cases in below folder as example:
incubator-hawq/src/test/feature/ManagementTool


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1258: HAWQ-1458. The maximum value of guc share_input_...

2017-06-22 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1258
  
LGTM. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1257: HAWQ-1487. Fix hang process due to deadlock when...

2017-06-19 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1257
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

2017-06-14 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1254
  
Thanks @outofmem0ry to contribute this, please check below comments.
1. I think we should keep the legacy command to do reload in case it's hard 
coded in some user cases, print a deprecated message should be fine.
2. Make sure all the related help messages and documents are updated.
3. Chose a proper name for this option before user start to use it, 
'reload' or 'reload-config'  or something else?
4. Add test for this option.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1252: HAWQ-1481. Rework Maven "3" major version check.

2017-06-06 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1252
  
LGTM. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...

2017-06-02 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1246
  
LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1247: HAWQ-1478. Enable hawq build on suse11

2017-06-01 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1247
  
LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1230: HAWQ-1453. Fixed relation_close() error at analy...

2017-05-05 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1230
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #1211: HAWQ-1425. Print error message if ssh con...

2017-04-07 Thread radarwave
Github user radarwave commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1211#discussion_r110341344
  
--- Diff: tools/bin/hawqpylib/hawqlib.py ---
@@ -203,6 +203,13 @@ def check_hostname_equal(remote_host, user = ""):
 cmd = "hostname"
 result_local, local_hostname, stderr_remote  = local_ssh_output(cmd)
 result_remote, remote_hostname, stderr_remote = remote_ssh_output(cmd, 
remote_host, user)
+if result_remote != 0:
+print "Execute command '%s' failed with return code %d on %s." % 
(cmd, result_remote, remote_host)
+print "Either ssh connection fails or command exits with error. 
Details:"
+print stderr_remote
+print "For ssh connection issue, please make sure passwordless ssh 
is enabled or check remote host."
--- End diff --

Although a simple command, it's possible the remote OS have some issue can 
cause failures. So not only the ssh connection error.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #1211: HAWQ-1425. Print error message if ssh con...

2017-04-07 Thread radarwave
Github user radarwave commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1211#discussion_r110324197
  
--- Diff: tools/bin/hawqpylib/hawqlib.py ---
@@ -203,6 +203,13 @@ def check_hostname_equal(remote_host, user = ""):
 cmd = "hostname"
 result_local, local_hostname, stderr_remote  = local_ssh_output(cmd)
 result_remote, remote_hostname, stderr_remote = remote_ssh_output(cmd, 
remote_host, user)
+if result_remote != 0:
+print stderr_remote
+print "Execute remote command failed on %s." % remote_host
--- End diff --

For Q1, added command line and error code in the error message.
For Q2, there are enough error information inside stderr_remote. User can 
read and know what's happening.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #1211: HAWQ-1425. Print error message if ssh con...

2017-04-07 Thread radarwave
Github user radarwave commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1211#discussion_r110322606
  
--- Diff: tools/bin/hawqpylib/hawqlib.py ---
@@ -203,6 +203,17 @@ def check_hostname_equal(remote_host, user = ""):
 cmd = "hostname"
 result_local, local_hostname, stderr_remote  = local_ssh_output(cmd)
 result_remote, remote_hostname, stderr_remote = remote_ssh_output(cmd, 
remote_host, user)
+# SSH return 255 error code when having connection issues, otherwise 
return code is in [0, 255).
+if result_remote == 255:
+print "Create ssh connection to %s failed." % remote_host
+print "Please check the ssh connection and make sure passwordless 
ssh enabled."
+sys.exit(result_remote)
+elif result_remote > 0:
+print "Execute remote command failed."
+sys.exit(result_remote)
+else:
+pass
+
--- End diff --

Thanks @paul-guo- , print error message is good idea. Fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1203: HAWQ-1420: Enable build of Ranger plugin open so...

2017-03-31 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1203
  
LGTM. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1208: HAWQ-1421. PXF rpm updates to make it oss friend...

2017-03-31 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1208
  
Thanks @shivzone .The virtual packages works to me.

+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1208: HAWQ-1421. PXF rpm updates to make it oss friend...

2017-03-31 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1208
  
sudo yum list installed | grep hadoop
hadoop-conf-pseudo.noarch2.7.3.2.5.0.0-1245.el6 @HDP-2.5.0.0
hadoop_2_5_0_0_1245.x86_64   2.7.3.2.5.0.0-1245.el6 @HDP-2.5.0.0
hadoop_2_5_0_0_1245-conf-pseudo.x86_64
hadoop_2_5_0_0_1245-hdfs.x86_64  2.7.3.2.5.0.0-1245.el6 @HDP-2.5.0.0
hadoop_2_5_0_0_1245-hdfs-datanode.x86_64
hadoop_2_5_0_0_1245-hdfs-namenode.x86_64
hadoop_2_5_0_0_1245-hdfs-secondarynamenode.x86_64
hadoop_2_5_0_0_1245-mapreduce.x86_64
hadoop_2_5_0_0_1245-mapreduce-historyserver.x86_64
hadoop_2_5_0_0_1245-yarn.x86_64  2.7.3.2.5.0.0-1245.el6 @HDP-2.5.0.0
hadoop_2_5_0_0_1245-yarn-nodemanager.x86_64
hadoop_2_5_0_0_1245-yarn-resourcemanager.x86_64

rpm -qR hadoop-hdfs.noarch
package hadoop-hdfs.noarch is not installed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1208: HAWQ-1421. PXF rpm updates to make it oss friend...

2017-03-30 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1208
  
After set "export HD=hdp", the rpm package names changed back with the 
version string "3_2_1_0". Maybe this is expected. But then I still seeing it 
requires Apache Hadoop. See:

`rpm -ivh pxf-service_3_2_1_0-3.2.1.0-1.el6.noarch.rpm
error: Failed dependencies:
hadoop >= 2.7.1 is needed by pxf-service_3_2_1_0-0:3.2.1.0-1.el6.noarch
hadoop-hdfs >= 2.7.1 is needed by 
pxf-service_3_2_1_0-0:3.2.1.0-1.el6.noarch`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1203: Enable build of Ranger plugin open source RPM

2017-03-29 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1203
  
Now the rpm name is: hawq-ranger-plugin-2.2.0.0-1.el7.centos.noarch.rpm

How about we remove the string 'centos' since there is already a 'el7' 
string there?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1203: Enable build of Ranger plugin open source RPM

2017-03-29 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1203
  
Now hawq ranger plugin rpm is in different directory, we should update the  
tarball script 'contrib/hawq-package/make_rpm_tarball.sh' with the new copy 
directory:

-cp 
${SRC_TOP_DIR}/ranger-plugin/target/rpm/hawq-ranger-plugin_*/RPMS/noarch/hawq-ranger-plugin*.rpm
 ${RPM_PKG_DIR}/
+cp 
${SRC_TOP_DIR}/ranger-plugin/target/rpm/hawq-ranger-plugin*/RPMS/noarch/hawq-ranger-plugin*.rpm
 ${RPM_PKG_DIR}/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #1203: Enable build of Ranger plugin open source...

2017-03-29 Thread radarwave
Github user radarwave commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1203#discussion_r108702120
  
--- Diff: ranger-plugin/pom.xml ---
@@ -38,6 +38,9 @@
 1
 9.1-901-1.jdbc4
 UTF-8
+_${hawq.name.version}
+hawq_${hawq.name.version}
+
/usr/local/hawq${build.suffix}/ranger
--- End diff --

Apache HAWQ will default get installed into /usr/local/apache-hawq.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #1207: HAWQ-326. Fix specified HAWQ_RELEASE_VERS...

2017-03-28 Thread radarwave
Github user radarwave commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1207#discussion_r108593718
  
--- Diff: contrib/hawq-package/build_hawq_rpm.sh ---
@@ -71,8 +76,14 @@ rpmbuild --define "_topdir ${RPM_TOP_DIR}" \
  -bb SPECS/hawq.spec
 if [ $? != 0 ]; then
 echo "Build HAWQ rpm package failed, exit..."
-exit 0
+exit 1
 fi
 
 set +x
 popd > /dev/null
+
+echo 
"="
+echo "Build HAWQ rpm package successfully."
--- End diff --

Good point! Fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #1207: HAWQ-326. Fix specified HAWQ_RELEASE_VERS...

2017-03-28 Thread radarwave
GitHub user radarwave opened a pull request:

https://github.com/apache/incubator-hawq/pull/1207

HAWQ-326. Fix specified HAWQ_RELEASE_VERSION for rpm build.

This fix included:
  1) Fixed HAWQ_RELEASE_VERSION for rpm tarball.
  2) Make sure distclean delete all the rpm artifacts.
  3) Added some log output.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/radarwave/incubator-hawq rpmfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1207.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1207


commit a8680673ea03a400fdf0653570fd83f358fc
Author: rlei <r...@pivotal.io>
Date:   2017-03-28T14:19:29Z

HAWQ-326. Fix specified HAWQ_RELEASE_VERSION for rpm build.

This fix included:
  1) Fixed HAWQ_RELEASE_VERSION for rpm tarball.
  2) Make sure distclean delete all the rpm artifacts.
  3) Added some log output.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #1203: Enable build of Ranger plugin open source...

2017-03-28 Thread radarwave
Github user radarwave commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1203#discussion_r108583106
  
--- Diff: ranger-plugin/pom.xml ---
@@ -38,6 +38,9 @@
 1
 9.1-901-1.jdbc4
 UTF-8
+_${hawq.name.version}
+hawq_${hawq.name.version}
--- End diff --

hawq.dep.name should be something like 'apache-hawq'.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1203: Enable build of Ranger plugin open source RPM

2017-03-28 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1203
  
@ljainpivotalio So we need another jira to fix the dependence issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1203: Enable build of Ranger plugin open source RPM

2017-03-28 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1203
  
Does this fixed below issue? Apache hawq rpm name should be 'apache-hawq', 
not 'hawq_2_2_0_0'.

rpm -ivh hawq-ranger-plugin_2_2_0_0-2.2.0.0-1.el7.centos.noarch.rpm
error: Failed dependencies:
hawq_2_2_0_0 >= 2.2.0.0 is needed by 
hawq-ranger-plugin_2_2_0_0-2.2.0.0-1.el7.centos.noarch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #1195: HAWQ-326. Support RPM package for Apache ...

2017-03-28 Thread radarwave
Github user radarwave closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1195


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #1177: HAWQ-326. Support RPM package for Apache ...

2017-03-28 Thread radarwave
Github user radarwave closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1177


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1195: HAWQ-326. Support RPM package for Apache HAWQ.

2017-03-28 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1195
  
Made some changes base on @paul-guo- 's comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1177: HAWQ-326. Support RPM package for Apache HAWQ.

2017-03-27 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1177
  
This PR is for build HAWQ rpm from binary tarball, since now we chose using 
source tarball to build rpm packages, so open another PR for the review.

New PR link is:
https://github.com/apache/incubator-hawq/pull/1195

Will close this PR if no further comments. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1195: HAWQ-326. Support RPM package for Apache HAWQ.

2017-03-27 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1195
  
@shivzone @denalex @huor @paul-guo- @edespino 

Please help to review, including PXF/Ranger-plugin changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq pull request #1195: HAWQ-326. Support RPM package for Apache ...

2017-03-27 Thread radarwave
GitHub user radarwave opened a pull request:

https://github.com/apache/incubator-hawq/pull/1195

HAWQ-326. Support RPM package for Apache HAWQ.

1. Add a RPM spec file to support building HAWQ rpm package from source 
code tarball.
2. Add 'make rpm' command to build HAWQ/PXF/Ranger-plugin rpm packages and 
make into a binary tarball from source code tarball.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/radarwave/incubator-hawq rpm-tarball

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1195


commit 7826a5ff525cb0cf2cfcd201c608d9d215734a37
Author: rlei <r...@pivotal.io>
Date:   2017-03-17T02:36:01Z

HAWQ-326. Support RPM package for Apache HAWQ.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1193: HAWQ-1406. Update hawq version in pom.xml for ha...

2017-03-27 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1193
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1188: HAWQ-1406. Update HAWQ product version strings f...

2017-03-27 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1188
  
LGTM  +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1188: HAWQ-1406. Update HAWQ product version strings f...

2017-03-24 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1188
  
May need to add one more file:
tools/bin/gppylib/data/2.2.json (can copy from 
tools/bin/gppylib/data/2.1.json)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


  1   2   >