[GitHub] incubator-hawq pull request #1259: HAWQ-1489. Add LICENSE, DISCLAIMER and NO...
Github user rvs commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1259#discussion_r123663702 --- Diff: pxf/resources/META-INF/LICENSE --- @@ -0,0 +1,380 @@ + Apache License + Version 2.0, January 2004 +http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + "Work" shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + "Contribution" shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally + submitted to Licensor for inclusion in the Work by the copyright owner + or by an individual or Legal Entity authorized to submit on behalf of + the copyright owner. For the purposes of this definition, "submitted" + means any form of electronic, verbal, or written communication sent + to the Licensor or its representatives, including but not limited to + communication on electronic mailing lists, source code control systems, + and issue tracking systems that are managed by, or on behalf of, the + Licensor for the purpose of discussing and improving the Work, but + excluding communication that is conspicuously marked or otherwise + designated in writing by the copyright owner as "Not a Contribution." + + "Contributor" shall mean Licensor and any individual or Legal Entity + on behalf of whom a Contribution has been received by Licensor and + subsequently incorporated within the Work. + + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + copyright license to reproduce, prepare Derivative Works of, + publicly display, publicly perform, sublicense, and distribute the + Work and such Derivative Works in Source or Object form. + + 3. Grant of Patent License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + (except as stated in this section) patent license to make, have made, + use, offer to sell, sell, import,
[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...
Github user rvs commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...
Github user rvs commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 I guess my point is -- this still doesn't address the Java side of things. Do you plan to do it in a separate PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...
Github user rvs commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 @huor I'm a bit confused -- it appears that both LICENSE and NOTICE files you added are copies of what already exists in the repo. For the binary distribution we need a much more expanded set (as per your Google doc spreadsheet) right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #993: HAWQ-1134. Add Bigtop layout specific pxf-...
GitHub user rvs opened a pull request: https://github.com/apache/incubator-hawq/pull/993 HAWQ-1134. Add Bigtop layout specific pxf-private classpath You can merge this pull request into a Git repository by running: $ git pull https://github.com/rvs/incubator-hawq HAWQ-1134 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/993.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #993 commit ad8f4e52f7993ca6091457ea51b6f91278364545 Author: Roman Shaposhnik <r...@apache.org> Date: 2016-11-01T23:03:49Z HAWQ-1134. Add Bigtop layout specific pxf-private classpath --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...
Github user rvs commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/788#discussion_r70544736 --- Diff: pom.xml --- @@ -112,6 +130,10 @@ however it is tricky to maintain headers in them --> depends/libyarn/test/data/* + + depends/libhdfs3/test/data/* + depends/libhdfs3/debian/** --- End diff -- a small nit: please fix a spurious whitespace --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...
Github user rvs commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/788#discussion_r70544691 --- Diff: pom.xml --- @@ -37,14 +37,32 @@ tools/bin/src/stream/* - + + tools/bin/pythonSrc/PyGreSQL-4.0/** + tools/bin/pythonSrc/PSI-0.3b2_gp/** + tools/bin/pythonSrc/lockfile-0.9.1/** + + tools/bin/pythonSrc/pychecker-0.8.18/** + tools/bin/pythonSrc/unittest2-0.5.1/** + + tools/bin/pythonSrc/pycrypto-2.0.1/** + + tools/bin/ext/** + + + depends/thirdparty/thrift/** + + + depends/thirdparty/googletest/** depends/libyarn/CMake/FindBoost.cmake depends/libyarn/CMake/FindGSasl.cmake depends/libyarn/CMake/FindKERBEROS.cmake + depends/libyarn/CMake/FindGoogleTest.cmake --- End diff -- Where did this file come from? If you wrote it, please add AL header to it. If not -- indicate where it came from. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...
Github user rvs commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/788#discussion_r70544706 --- Diff: pom.xml --- @@ -37,14 +37,32 @@ tools/bin/src/stream/* - + + tools/bin/pythonSrc/PyGreSQL-4.0/** + tools/bin/pythonSrc/PSI-0.3b2_gp/** + tools/bin/pythonSrc/lockfile-0.9.1/** + + tools/bin/pythonSrc/pychecker-0.8.18/** + tools/bin/pythonSrc/unittest2-0.5.1/** + + tools/bin/pythonSrc/pycrypto-2.0.1/** + + tools/bin/ext/** + + + depends/thirdparty/thrift/** + + + depends/thirdparty/googletest/** depends/libyarn/CMake/FindBoost.cmake depends/libyarn/CMake/FindGSasl.cmake depends/libyarn/CMake/FindKERBEROS.cmake + depends/libyarn/CMake/FindGoogleTest.cmake depends/libhdfs3/CMake/FindBoost.cmake + depends/libhdfs3/CMake/FindGoogleTest.cmake --- End diff -- Where did this file come from? If you wrote it, please add AL header to it. If not -- indicate where it came from. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...
Github user rvs commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/788#discussion_r70544564 --- Diff: pom.xml --- @@ -37,14 +37,32 @@ tools/bin/src/stream/* - + + tools/bin/pythonSrc/PyGreSQL-4.0/** + tools/bin/pythonSrc/PSI-0.3b2_gp/** + tools/bin/pythonSrc/lockfile-0.9.1/** + + tools/bin/pythonSrc/pychecker-0.8.18/** + tools/bin/pythonSrc/unittest2-0.5.1/** + + tools/bin/pythonSrc/pycrypto-2.0.1/** + + tools/bin/ext/** + + + depends/thirdparty/thrift/** --- End diff -- What exactly is RAT complaining about? For ASF code this should not be a problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...
Github user rvs commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/788#discussion_r70544439 --- Diff: pom.xml --- @@ -37,14 +37,32 @@ tools/bin/src/stream/* - + + tools/bin/pythonSrc/PyGreSQL-4.0/** + tools/bin/pythonSrc/PSI-0.3b2_gp/** + tools/bin/pythonSrc/lockfile-0.9.1/** + + tools/bin/pythonSrc/pychecker-0.8.18/** + tools/bin/pythonSrc/unittest2-0.5.1/** + --- End diff -- I am not sure this is ASF compatible since this code basically has no OSI-approved license attached to it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...
Github user rvs commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/788#discussion_r70544327 --- Diff: pom.xml --- @@ -37,14 +37,32 @@ tools/bin/src/stream/* - + + tools/bin/pythonSrc/PyGreSQL-4.0/** + tools/bin/pythonSrc/PSI-0.3b2_gp/** + tools/bin/pythonSrc/lockfile-0.9.1/** + + tools/bin/pythonSrc/pychecker-0.8.18/** + tools/bin/pythonSrc/unittest2-0.5.1/** --- End diff -- unittest2-0.5.1/PKG-INFO says License is unknown. Please provide support for your claim that this is a BSD licensed code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...
Github user rvs commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/788#discussion_r70544369 --- Diff: pom.xml --- @@ -37,14 +37,32 @@ tools/bin/src/stream/* - + + tools/bin/pythonSrc/PyGreSQL-4.0/** + tools/bin/pythonSrc/PSI-0.3b2_gp/** + tools/bin/pythonSrc/lockfile-0.9.1/** + + tools/bin/pythonSrc/pychecker-0.8.18/** + tools/bin/pythonSrc/unittest2-0.5.1/** + + tools/bin/pythonSrc/pycrypto-2.0.1/** --- End diff -- At this point the agreement is that we're not distributing crypto code with HAWQ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #737: HAWQ-849. Remove apache orc codebase from hawq
Github user rvs commented on the issue: https://github.com/apache/incubator-hawq/pull/737 @xunzhang happy to help and thanks for the patience! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #701: HAWQ 795,796,797
Github user rvs commented on the issue: https://github.com/apache/incubator-hawq/pull/701 This is a discussion that belongs on the mailing list. Please do follow up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #701: HAWQ 795,796,797
Github user rvs commented on the issue: https://github.com/apache/incubator-hawq/pull/701 Where was it communicated? I saw no email exchange on the dev@hawq mailing list. Also, please follow with tour comments on the dev@hawq mailing list thread that I started. It would be much easier to have a more involved discussion there rather than on a JIRA. I do have a lot of concerns about your approach and I'm still -1 until we clarify some of the issues involved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #701: HAWQ 795,796,797
Github user rvs commented on the issue: https://github.com/apache/incubator-hawq/pull/701 As it appears to be a complete fork of the ORC codebase (do correct me if I'm wrong). I'm very much -1 on this. Please see the email thread on dev@hawq because I think we may need to back it out of master and come up with a better approach. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
