[GitHub] incubator-hawq issue #1198: HAWQ-1417. Fixed crash when ANALYZE after COPY b...
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1198 +1 for the fix as the mock of the verification is not feasible --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1198: HAWQ-1417. Fixed crash when ANALYZE after COPY b...
Github user liming01 commented on the issue: https://github.com/apache/incubator-hawq/pull/1198 After investigation, it seems we can not use cmock to reproduce HAWQ-1417. The reason is: we need to mock all functions called in these functions, and also we need make one relation with catalog in memory, and data on disk. I looked into some unit tests exists in backend, all tests are testing simple logic, and calling some independent modules, so the functions need to be mocked is very limited. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1198: HAWQ-1417. Fixed crash when ANALYZE after COPY b...
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1198 @liming01, the mock file for analyze is generated. The way to add mock is at: https://github.com/apache/incubator-hawq/blob/master/src/test/unit/README.txt. Please take a look and see if it is good to leverage mock for your fix. The mock test is covered in hawq ci. You can do that in local environment also: cd src/backend; make unittest-check If it is hard to reproduce the issue with sql, I think mock is an option we can try. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1198: HAWQ-1417. Fixed crash when ANALYZE after COPY b...
Github user liming01 commented on the issue: https://github.com/apache/incubator-hawq/pull/1198 (1) no file in master branch: src/test/unit/mock/backend/commands/analyze_mock.c (2) Do we run CI on these mock test now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1198: HAWQ-1417. Fixed crash when ANALYZE after COPY b...
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1198 The fix looks good. Is it possible to add unit test for it in src/test/unit/mock/backend/commands/analyze_mock.c? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1198: HAWQ-1417. Fixed crash when ANALYZE after COPY b...
Github user wengyanqing commented on the issue: https://github.com/apache/incubator-hawq/pull/1198 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
