[GitHub] incubator-hawq issue #1227: HAWQ-1448. Fixed postmaster process hung at recv...

2017-07-11 Thread wengyanqing
Github user wengyanqing commented on the issue:

https://github.com/apache/incubator-hawq/pull/1227
  
Agree with Radar's comment. LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1227: HAWQ-1448. Fixed postmaster process hung at recv...

2017-07-11 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1227
  
When master is down,  it's no matter to stop segment in 'smart' or 'fast' 
mode. And I see this fix only affect 'hawq stop cluster', which means master is 
already down before stoping segments. So I think this fix is good enough to me.

+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1227: HAWQ-1448. Fixed postmaster process hung at recv...

2017-06-28 Thread liming01
Github user liming01 commented on the issue:

https://github.com/apache/incubator-hawq/pull/1227
  
@edespino,  if we can find all hung root cause when hawq stop and fix them, 
then we don't need this PR. 

However from a long time investigate, these problems still cannot been 
fixed. So I suggest to apply this PR. This PR can fix all hung problems when 
hawq stop, (if still hung in some cases, we should check not disable interrupt 
processing during the hung function called).

Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1227: HAWQ-1448. Fixed postmaster process hung at recv...

2017-06-07 Thread edespino
Github user edespino commented on the issue:

https://github.com/apache/incubator-hawq/pull/1227
  
@liming01 - What is the status of this PR?  It's been idle for over a month.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1227: HAWQ-1448. Fixed postmaster process hung at recv...

2017-05-03 Thread paul-guo-
Github user paul-guo- commented on the issue:

https://github.com/apache/incubator-hawq/pull/1227
  
Normally stopped master should not lead to recv() hang on segments since 
recv() will return 0 if the tcp connection (libpq) is closed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---