[GitHub] incubator-hawq issue #788: HAWQ-915. RAT is failing on the latest master

2016-07-12 Thread changleicn
Github user changleicn commented on the issue:

https://github.com/apache/incubator-hawq/pull/788
  
@rvs to review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #788: HAWQ-915. RAT is failing on the latest master

2016-07-13 Thread paul-guo-
Github user paul-guo- commented on the issue:

https://github.com/apache/incubator-hawq/pull/788
  
Thanks @rvs , I've made a lot of further changes.

Removed some deleted files in pom.xml
Added header info into more files after discussing with related developers.
Classified and double-confirmed licenses for opensource python modules 
under tools/bin.

Just one thing, pygresql is said to be Python Software Foundation License 
(https://pypi.python.org/pypi/PyGreSQL/4.0) (Note Python license is deprecated 
one according to 
https://en.wikipedia.org/wiki/Python_Software_Foundation_License, so Python 
license != Python Software Foundation License) but the code & doc 
(docs/readme.txt & pgmodule.c) shows it is with postgresql license. I'm really 
confused. Fortunately it seems that both licenses are friendly to ASF license.

I'm classifying pygresql as Python Software Foundation License in this 
patch, since this is not a big issue. We could keep the issue open and make the 
change if necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #788: HAWQ-915. RAT is failing on the latest master

2016-07-13 Thread paul-guo-
Github user paul-guo- commented on the issue:

https://github.com/apache/incubator-hawq/pull/788
  
@radarwave Could you please take a look at the patch also?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #788: HAWQ-915. RAT is failing on the latest master

2016-07-13 Thread rvs
Github user rvs commented on the issue:

https://github.com/apache/incubator-hawq/pull/788
  
@paul-guo- great sleuthing! The patch looks good to me now. Can you please 
commit?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #788: HAWQ-915. RAT is failing on the latest master

2016-07-13 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/788
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---