[GitHub] incubator-hawq issue #789: HAWQ-918. Fix memtuple forming bug when null-save...

2016-07-12 Thread huor
Github user huor commented on the issue:

https://github.com/apache/incubator-hawq/pull/789
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #789: HAWQ-918. Fix memtuple forming bug when null-save...

2016-07-12 Thread linwen
Github user linwen commented on the issue:

https://github.com/apache/incubator-hawq/pull/789
  
The reason is
test cases for aggregates haven't been moved to new feature test framework 
yet.
So I add this test case in old installcheck.
And all the test cases for aggregates will be moved together within a new 
jira. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #789: HAWQ-918. Fix memtuple forming bug when null-save...

2016-07-12 Thread changleicn
Github user changleicn commented on the issue:

https://github.com/apache/incubator-hawq/pull/789
  
why do we still add the old installcheck tests? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #789: HAWQ-918. Fix memtuple forming bug when null-save...

2016-07-12 Thread armenatzoglou
Github user armenatzoglou commented on the issue:

https://github.com/apache/incubator-hawq/pull/789
  
LGTM. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #789: HAWQ-918. Fix memtuple forming bug when null-save...

2016-07-12 Thread xunzhang
Github user xunzhang commented on the issue:

https://github.com/apache/incubator-hawq/pull/789
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---