[GitHub] incubator-hawq issue #806: HAWQ-938. Remove ivy.xml in gpopt and read orca v...

2016-08-01 Thread hsyuan
Github user hsyuan commented on the issue:

https://github.com/apache/incubator-hawq/pull/806
  
pushed to master:

https://github.com/apache/incubator-hawq/commit/78c2766578102501e67c133df942fc6355d56c8e


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #806: HAWQ-938. Remove ivy.xml in gpopt and read orca v...

2016-07-20 Thread hsyuan
Github user hsyuan commented on the issue:

https://github.com/apache/incubator-hawq/pull/806
  
Thanks, will take care of it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #806: HAWQ-938. Remove ivy.xml in gpopt and read orca v...

2016-07-20 Thread paul-guo-
Github user paul-guo- commented on the issue:

https://github.com/apache/incubator-hawq/pull/806
  
+1

By the way, I just noticed the following code in gpopt.mk

UNAME = $(shell uname)
UNAME_P = $(shell uname -p)
UNAME_M = $(shell uname -m)
ARCH_OS = GPOS_$(UNAME)
ARCH_CPU = GPOS_$(UNAME_P)

ifeq (Darwin, $(UNAME))
LDSFX = dylib
else
LDSFX = so
endif

Please use  DLSUFFIX and PORTNAME which are defined in src/Makefile.global
(and its including makefiles),
and are generated with the configure command. This is another issue, you
could make the change in the future.

2016-07-21 9:21 GMT+08:00 Lei Chang :

> @paul-guo-  to review.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #806: HAWQ-938. Remove ivy.xml in gpopt and read orca v...

2016-07-20 Thread changleicn
Github user changleicn commented on the issue:

https://github.com/apache/incubator-hawq/pull/806
  
@paul-guo- to review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #806: HAWQ-938. Remove ivy.xml in gpopt and read orca v...

2016-07-20 Thread hsyuan
Github user hsyuan commented on the issue:

https://github.com/apache/incubator-hawq/pull/806
  
@changleicn @yaoj2 @wengyanqing 
Please take a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---