[GitHub] incubator-hawq issue #808: HAWQ-944. Implement new pg_ltoa function as per p...
Github user paul-guo- commented on the issue: https://github.com/apache/incubator-hawq/pull/808 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #808: HAWQ-944. Implement new pg_ltoa function as per p...
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/808 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #808: HAWQ-944. Implement new pg_ltoa function as per p...
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/808 @huor @paul-guo- Can you look at this PR when you get a chance. I need one more +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #808: HAWQ-944. Implement new pg_ltoa function as per p...
Github user edespino commented on the issue: https://github.com/apache/incubator-hawq/pull/808 @kavinderd - Any progress on this issue? It is currently in a conflict situation as reported in the PR checks "This branch has conflicts that must be resolved". There doesn't appear to be any progress on the corresponding Jira as well (HAWQ-944) since last summer (July 2016). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #808: HAWQ-944. Implement new pg_ltoa function as per p...
Github user paul-guo- commented on the issue: https://github.com/apache/incubator-hawq/pull/808 It looks like pg_ltoa() does not work for the corner case: integer 0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #808: HAWQ-944. Implement new pg_ltoa function as per p...
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/808 Added `INT32_CHAR_SIZE` to `configure.in` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #808: HAWQ-944. Implement new pg_ltoa function as per p...
Github user shivzone commented on the issue: https://github.com/apache/incubator-hawq/pull/808 I don't see INT32_CHAR_SIZE defined anywhere --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #808: HAWQ-944. Implement new pg_ltoa function as per p...
Github user paul-guo- commented on the issue: https://github.com/apache/incubator-hawq/pull/808 I suspect pg_ltoa() will be faster if it fills the characters one by one in descending order, instead of current solution: filling in ascending order and then swapping. Given the code comes from pg, I'd give a +1 at first. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #808: HAWQ-944. Implement new pg_ltoa function as per p...
Github user shivzone commented on the issue: https://github.com/apache/incubator-hawq/pull/808 I would prefer if we have a general util function that determines precisely the number of bytes to "stringify" the given data type (int16 or int32) as a character array --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #808: HAWQ-944. Implement new pg_ltoa function as per p...
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/808 @xunzhang No rush, take your time --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #808: HAWQ-944. Implement new pg_ltoa function as per p...
Github user xunzhang commented on the issue: https://github.com/apache/incubator-hawq/pull/808 @kavinderd I will review this next Monday, sorry for the latency. If it is a hurry, you could at somebody else to review. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #808: HAWQ-944. Implement new pg_ltoa function as per p...
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/808 @paul-guo- @xunzhang Please review, I think I covered all invocations of the two functions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
