[GitHub] incubator-hawq pull request #1198: HAWQ-1417. Fixed crash when ANALYZE after...

[liming01]

Github user liming01 closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1198


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1198: HAWQ-1417. Fixed crash when ANALYZE after...

[huor]

Github user huor commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1198#discussion_r108427680
  
--- Diff: src/backend/commands/analyze.c ---
@@ -476,6 +477,11 @@ void analyzeStmt(VacuumStmt *stmt, List *relids, int 
preferred_seg_num)
MemoryContextSwitchTo(analyzeStatementContext);
}
 
+   // Create a resource owner to keep track of our resources even not in 
trasaction block
--- End diff --

Use /* */ to keep it consistent


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1198: HAWQ-1417. Fixed crash when ANALYZE after...

[liming01]

GitHub user liming01 opened a pull request:

https://github.com/apache/incubator-hawq/pull/1198

HAWQ-1417. Fixed crash when ANALYZE after COPY because of invalid res…

…ource owner

The root cause is:  when ANALYZE is running, it will commit previous 
transaction, and begin one transaction for each relation to process analyze. 
However some code added before begining transactions, which means in this time, 
no transaction, and no resource owner either.

The solution is to: create one resource owner for analyzeStmt(), and delete 
it after processing it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/liming01/incubator-hawq 
mli/crash_analyze_resowner

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1198.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1198


commit 5affd9e5ab63f60ba6e09c2fd0c90f5351f2d5b0
Author: Ming LI 
Date:   2017-03-28T07:52:02Z

HAWQ-1417. Fixed crash when ANALYZE after COPY because of invalid resource 
owner




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---