[GitHub] incubator-hawq pull request #1208: HAWQ-1421. PXF rpm updates to make it oss...

[sansanichfb]

Github user sansanichfb commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1208#discussion_r109062506
  
--- Diff: pxf/build.gradle ---
@@ -41,17 +41,22 @@ buildscript {
 }   
 }
 
-// Hadoop distribution (can be phd or hdp) - needed to set correct 
classpaths
+// Hadoop distribution (can be hdp or null which would default to apache) 
- needed to set correct classpaths
 // can be set with -Dhd=
-def hddist = System.properties['hd'] ?: 'hdp';
-if (hddist != 'phd' && hddist != 'hdp') {
+def hddist = System.properties['hd'] ?: '';
--- End diff --

As long as we don't have default value, shouldn't it be just: def hddist = 
System.properties['hd']?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1208: HAWQ-1421. PXF rpm updates to make it oss...

[shivzone]

GitHub user shivzone opened a pull request:

https://github.com/apache/incubator-hawq/pull/1208

HAWQ-1421. PXF rpm updates to make it oss friendly



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/incubator-hawq HAWQ-1421

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1208.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1208


commit e0102a821204c72c8f4cfe99562b8d27fb4cf967
Author: shivzone 
Date:   2017-03-30T01:15:37Z

HAWQ-1421. PXF rpm updates to make it oss friendly




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---