[jira] [Commented] (HAWQ-672) Add python module pygresql back into hawq workspace

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270023#comment-15270023
 ] 

ASF GitHub Bot commented on HAWQ-672:
-

Github user yaoj2 commented on the pull request:

https://github.com/apache/incubator-hawq/pull/606#issuecomment-216724478
  
＋1


> Add python module pygresql back into hawq workspace
> ---
>
> Key: HAWQ-672
> URL: https://issues.apache.org/jira/browse/HAWQ-672
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Lei Chang
>
> HAWQ-271 (Remove external python modules) removed a lot of external python 
> modules besides pygresql. Now to install pygresql, we have to hack a bit as  
> https://cwiki.apache.org/confluence/display/HAWQ/Build+and+Install said, i.e. 
> install postgresql package at first and then remove it after installing 
> pygresql, else pip will report error like "pg_config: command not found". 
> Since installing postgresql is a bit painful and the workaround seems to be 
> ugly, we could revert the code change for pygresql for HAWQ-271. That is to 
> say, users do not need to install pygresql themselves. Note that we did some 
> hack to upstream pygresql.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-672) Add python module pygresql back into hawq workspace

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270021#comment-15270021
 ] 

ASF GitHub Bot commented on HAWQ-672:
-

Github user radarwave commented on the pull request:

https://github.com/apache/incubator-hawq/pull/606#issuecomment-216724353
  
Looks good to me. +1


> Add python module pygresql back into hawq workspace
> ---
>
> Key: HAWQ-672
> URL: https://issues.apache.org/jira/browse/HAWQ-672
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Lei Chang
>
> HAWQ-271 (Remove external python modules) removed a lot of external python 
> modules besides pygresql. Now to install pygresql, we have to hack a bit as  
> https://cwiki.apache.org/confluence/display/HAWQ/Build+and+Install said, i.e. 
> install postgresql package at first and then remove it after installing 
> pygresql, else pip will report error like "pg_config: command not found". 
> Since installing postgresql is a bit painful and the workaround seems to be 
> ugly, we could revert the code change for pygresql for HAWQ-271. That is to 
> say, users do not need to install pygresql themselves. Note that we did some 
> hack to upstream pygresql.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-672) Add python module pygresql back into hawq workspace

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240536#comment-15240536
 ] 

ASF GitHub Bot commented on HAWQ-672:
-

Github user radarwave commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/606#discussion_r59660199
  
--- Diff: tools/bin/ext/__init__.py ---
@@ -0,0 +1,306 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+# 
+#   http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from error import *
+
+from tokens import *
+from events import *
+from nodes import *
+
+from loader import *
+from dumper import *
+
+try:
+from cyaml import *
--- End diff --

We would better remove the codes not related to pygresql in this 
'__init__.py' file.


> Add python module pygresql back into hawq workspace
> ---
>
> Key: HAWQ-672
> URL: https://issues.apache.org/jira/browse/HAWQ-672
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Lei Chang
>
> HAWQ-271 (Remove external python modules) removed a lot of external python 
> modules besides pygresql. Now to install pygresql, we have to hack a bit as  
> https://cwiki.apache.org/confluence/display/HAWQ/Build+and+Install said, i.e. 
> install postgresql package at first and then remove it after installing 
> pygresql, else pip will report error like "pg_config: command not found". 
> Since installing postgresql is a bit painful and the workaround seems to be 
> ugly, we could revert the code change for pygresql for HAWQ-271. That is to 
> say, users do not need to install pygresql themselves. Note that we did some 
> hack to upstream pygresql.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-672) Add python module pygresql back into hawq workspace

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240535#comment-15240535
 ] 

ASF GitHub Bot commented on HAWQ-672:
-

Github user radarwave commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/606#discussion_r59660154
  
--- Diff: tools/bin/generate-greenplum-path.sh ---
@@ -90,16 +90,9 @@ EOF
 fi
 
 #setup PYTHONPATH
-# OSX does NOT need pygresql/ path
-if [ "${PLAT}" = "Darwin" ] ; then
-cat < Add python module pygresql back into hawq workspace
> ---
>
> Key: HAWQ-672
> URL: https://issues.apache.org/jira/browse/HAWQ-672
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Lei Chang
>
> HAWQ-271 (Remove external python modules) removed a lot of external python 
> modules besides pygresql. Now to install pygresql, we have to hack a bit as  
> https://cwiki.apache.org/confluence/display/HAWQ/Build+and+Install said, i.e. 
> install postgresql package at first and then remove it after installing 
> pygresql, else pip will report error like "pg_config: command not found". 
> Since installing postgresql is a bit painful and the workaround seems to be 
> ugly, we could revert the code change for pygresql for HAWQ-271. That is to 
> say, users do not need to install pygresql themselves. Note that we did some 
> hack to upstream pygresql.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-672) Add python module pygresql back into hawq workspace

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240515#comment-15240515
 ] 

ASF GitHub Bot commented on HAWQ-672:
-

GitHub user paul-guo- opened a pull request:

https://github.com/apache/incubator-hawq/pull/606

HAWQ-672. Add python module pygresql back into hawq workspace

In this patch, all of the new added files come from the workspace after 
reverting HAWQ-271. Other changes mostly follow the original patch for 
HAWQ-271. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paul-guo-/incubator-hawq master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/606.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #606


commit 90816ddb5535bda8c0f24464dc86e2e5dd79389b
Author: Paul Guo 
Date:   2016-04-14T03:02:54Z

HAWQ-672. Add python module pygresql back into hawq workspace




> Add python module pygresql back into hawq workspace
> ---
>
> Key: HAWQ-672
> URL: https://issues.apache.org/jira/browse/HAWQ-672
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Lei Chang
>
> HAWQ-271 (Remove external python modules) removed a lot of external python 
> modules besides pygresql. Now to install pygresql, we have to hack a bit as  
> https://cwiki.apache.org/confluence/display/HAWQ/Build+and+Install said, i.e. 
> install postgresql package at first and then remove it after installing 
> pygresql, else pip will report error like "pg_config: command not found". 
> Since installing postgresql is a bit painful and the workaround seems to be 
> ugly, we could revert the code change for pygresql for HAWQ-271. That is to 
> say, users do not need to install pygresql themselves. Note that we did some 
> hack to upstream pygresql.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)