[jira] [Commented] (HAWQ-819) Wrong timestamp file path for Makefile target pg_prepare
[ https://issues.apache.org/jira/browse/HAWQ-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331278#comment-15331278 ] ASF GitHub Bot commented on HAWQ-819: - GitHub user paul-guo- opened a pull request: https://github.com/apache/incubator-hawq/pull/716 HAWQ-819. Wrong timestamp file path for Makefile target pg_prepare You can merge this pull request into a Git repository by running: $ git pull https://github.com/paul-guo-/incubator-hawq master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/716.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #716 commit 125beaecf2c2fabb326eebfe3d3095b05b5b5aed Author: Paul Guo Date: 2016-06-15T07:06:48Z HAWQ-819. Wrong timestamp file path for Makefile target pg_prepare > Wrong timestamp file path for Makefile target pg_prepare > > > Key: HAWQ-819 > URL: https://issues.apache.org/jira/browse/HAWQ-819 > Project: Apache HAWQ > Issue Type: Bug > Components: Build >Reporter: Paul Guo >Assignee: Lei Chang > > This is a tiny bug. > diff --git a/src/Makefile.global.in b/src/Makefile.global.in > index 988c922..1afbc16 100644 > --- a/src/Makefile.global.in > +++ b/src/Makefile.global.in > @@ -694,7 +694,7 @@ endif # enable_nls > pg_prepare: > ifneq "$(findstring yes, $(with_pgcrypto))" "" > - if [ ! -e $(abs_top_builddir)/pg_prepare_timestamp ]; then \ > + if [ ! -e $(abs_top_builddir)/depends/thirdparty/pg_prepare_timestamp ]; > then \ > cd $(abs_top_srcdir); \ > git submodule update --init depends/thirdparty/postgres && \ > touch $(abs_top_builddir)/depends/thirdparty/pg_prepare_timestamp; \ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-819) Wrong timestamp file path for Makefile target pg_prepare
[ https://issues.apache.org/jira/browse/HAWQ-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331318#comment-15331318 ] ASF GitHub Bot commented on HAWQ-819: - Github user zhangh43 commented on the issue: https://github.com/apache/incubator-hawq/pull/716 +1 > Wrong timestamp file path for Makefile target pg_prepare > > > Key: HAWQ-819 > URL: https://issues.apache.org/jira/browse/HAWQ-819 > Project: Apache HAWQ > Issue Type: Bug > Components: Build >Reporter: Paul Guo >Assignee: Lei Chang > > This is a tiny bug. > diff --git a/src/Makefile.global.in b/src/Makefile.global.in > index 988c922..1afbc16 100644 > --- a/src/Makefile.global.in > +++ b/src/Makefile.global.in > @@ -694,7 +694,7 @@ endif # enable_nls > pg_prepare: > ifneq "$(findstring yes, $(with_pgcrypto))" "" > - if [ ! -e $(abs_top_builddir)/pg_prepare_timestamp ]; then \ > + if [ ! -e $(abs_top_builddir)/depends/thirdparty/pg_prepare_timestamp ]; > then \ > cd $(abs_top_srcdir); \ > git submodule update --init depends/thirdparty/postgres && \ > touch $(abs_top_builddir)/depends/thirdparty/pg_prepare_timestamp; \ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-819) Wrong timestamp file path for Makefile target pg_prepare
[ https://issues.apache.org/jira/browse/HAWQ-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15332971#comment-15332971 ] ASF GitHub Bot commented on HAWQ-819: - Github user paul-guo- closed the pull request at: https://github.com/apache/incubator-hawq/pull/716 > Wrong timestamp file path for Makefile target pg_prepare > > > Key: HAWQ-819 > URL: https://issues.apache.org/jira/browse/HAWQ-819 > Project: Apache HAWQ > Issue Type: Bug > Components: Build >Reporter: Paul Guo >Assignee: Paul Guo > Fix For: 2.0.0-beta-incubating > > > This is a tiny bug. > diff --git a/src/Makefile.global.in b/src/Makefile.global.in > index 988c922..1afbc16 100644 > --- a/src/Makefile.global.in > +++ b/src/Makefile.global.in > @@ -694,7 +694,7 @@ endif # enable_nls > pg_prepare: > ifneq "$(findstring yes, $(with_pgcrypto))" "" > - if [ ! -e $(abs_top_builddir)/pg_prepare_timestamp ]; then \ > + if [ ! -e $(abs_top_builddir)/depends/thirdparty/pg_prepare_timestamp ]; > then \ > cd $(abs_top_srcdir); \ > git submodule update --init depends/thirdparty/postgres && \ > touch $(abs_top_builddir)/depends/thirdparty/pg_prepare_timestamp; \ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-819) Wrong timestamp file path for Makefile target pg_prepare
[ https://issues.apache.org/jira/browse/HAWQ-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15332970#comment-15332970 ] ASF GitHub Bot commented on HAWQ-819: - Github user paul-guo- commented on the issue: https://github.com/apache/incubator-hawq/pull/716 Merged. > Wrong timestamp file path for Makefile target pg_prepare > > > Key: HAWQ-819 > URL: https://issues.apache.org/jira/browse/HAWQ-819 > Project: Apache HAWQ > Issue Type: Bug > Components: Build >Reporter: Paul Guo >Assignee: Paul Guo > Fix For: 2.0.0-beta-incubating > > > This is a tiny bug. > diff --git a/src/Makefile.global.in b/src/Makefile.global.in > index 988c922..1afbc16 100644 > --- a/src/Makefile.global.in > +++ b/src/Makefile.global.in > @@ -694,7 +694,7 @@ endif # enable_nls > pg_prepare: > ifneq "$(findstring yes, $(with_pgcrypto))" "" > - if [ ! -e $(abs_top_builddir)/pg_prepare_timestamp ]; then \ > + if [ ! -e $(abs_top_builddir)/depends/thirdparty/pg_prepare_timestamp ]; > then \ > cd $(abs_top_srcdir); \ > git submodule update --init depends/thirdparty/postgres && \ > touch $(abs_top_builddir)/depends/thirdparty/pg_prepare_timestamp; \ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
