[jira] [Commented] (HAWQ-877) Need to stop building when building error occurs in gpfdist directory
[ https://issues.apache.org/jira/browse/HAWQ-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360750#comment-15360750 ] ASF GitHub Bot commented on HAWQ-877: - Github user liming01 closed the pull request at: https://github.com/apache/incubator-hawq/pull/757 > Need to stop building when building error occurs in gpfdist directory > - > > Key: HAWQ-877 > URL: https://issues.apache.org/jira/browse/HAWQ-877 > Project: Apache HAWQ > Issue Type: Bug > Components: Build >Reporter: Ming LI >Assignee: Lei Chang > > When building gpfdist report error "'openssl/ssl.h' file not found", it > doesn't stop building, so the last error we can see it not the right root > error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-877) Need to stop building when building error occurs in gpfdist directory
[ https://issues.apache.org/jira/browse/HAWQ-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354384#comment-15354384 ] ASF GitHub Bot commented on HAWQ-877: - Github user paul-guo- commented on the issue: https://github.com/apache/incubator-hawq/pull/757 +1 > Need to stop building when building error occurs in gpfdist directory > - > > Key: HAWQ-877 > URL: https://issues.apache.org/jira/browse/HAWQ-877 > Project: Apache HAWQ > Issue Type: Bug > Components: Build >Reporter: Ming LI >Assignee: Lei Chang > > When building gpfdist report error "'openssl/ssl.h' file not found", it > doesn't stop building, so the last error we can see it not the right root > error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-877) Need to stop building when building error occurs in gpfdist directory
[
https://issues.apache.org/jira/browse/HAWQ-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352779#comment-15352779
]
ASF GitHub Bot commented on HAWQ-877:
-
Github user liming01 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/757#discussion_r68733952
--- Diff: src/bin/gpfdist/Makefile ---
@@ -60,9 +60,11 @@ mkgpfdist: mkdir
for file in $(GPFDISTFILES); do \
( $(CC) $(INCLUDES) $(CFLAGS) $(LIBS) -c $(code_dir)$${file}); \
--- End diff --
Get it. But I have no test env for retest this write, I will keep it
unchanged because the previous writing was already verified.
> Need to stop building when building error occurs in gpfdist directory
> -
>
> Key: HAWQ-877
> URL: https://issues.apache.org/jira/browse/HAWQ-877
> Project: Apache HAWQ
> Issue Type: Bug
> Components: Build
>Reporter: Ming LI
>Assignee: Lei Chang
>
> When building gpfdist report error "'openssl/ssl.h' file not found", it
> doesn't stop building, so the last error we can see it not the right root
> error.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HAWQ-877) Need to stop building when building error occurs in gpfdist directory
[
https://issues.apache.org/jira/browse/HAWQ-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352759#comment-15352759
]
ASF GitHub Bot commented on HAWQ-877:
-
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/757#discussion_r68732483
--- Diff: src/bin/gpfdist/Makefile ---
@@ -60,9 +60,11 @@ mkgpfdist: mkdir
for file in $(GPFDISTFILES); do \
( $(CC) $(INCLUDES) $(CFLAGS) $(LIBS) -c $(code_dir)$${file}); \
--- End diff --
Following way is cleaner.
$cmd || exit 1
> Need to stop building when building error occurs in gpfdist directory
> -
>
> Key: HAWQ-877
> URL: https://issues.apache.org/jira/browse/HAWQ-877
> Project: Apache HAWQ
> Issue Type: Bug
> Components: Build
>Reporter: Ming LI
>Assignee: Lei Chang
>
> When building gpfdist report error "'openssl/ssl.h' file not found", it
> doesn't stop building, so the last error we can see it not the right root
> error.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HAWQ-877) Need to stop building when building error occurs in gpfdist directory
[
https://issues.apache.org/jira/browse/HAWQ-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352761#comment-15352761
]
ASF GitHub Bot commented on HAWQ-877:
-
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/757#discussion_r68732512
--- Diff: src/bin/gpfdist/Makefile ---
@@ -60,9 +60,11 @@ mkgpfdist: mkdir
for file in $(GPFDISTFILES); do \
( $(CC) $(INCLUDES) $(CFLAGS) $(LIBS) -c $(code_dir)$${file}); \
+ if [[ $$? -ne 0 ]]; then exit 1; fi \
done
# link
$(CC) $(CFLAGS) -o $(code_dir)gpfdist $(OBJS) $(LIBS)
+ if [[ $$? -ne 0 ]]; then exit 1; fi
--- End diff --
This line code change is not necessary.
> Need to stop building when building error occurs in gpfdist directory
> -
>
> Key: HAWQ-877
> URL: https://issues.apache.org/jira/browse/HAWQ-877
> Project: Apache HAWQ
> Issue Type: Bug
> Components: Build
>Reporter: Ming LI
>Assignee: Lei Chang
>
> When building gpfdist report error "'openssl/ssl.h' file not found", it
> doesn't stop building, so the last error we can see it not the right root
> error.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HAWQ-877) Need to stop building when building error occurs in gpfdist directory
[
https://issues.apache.org/jira/browse/HAWQ-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352668#comment-15352668
]
ASF GitHub Bot commented on HAWQ-877:
-
Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/757#discussion_r68725485
--- Diff: src/bin/gpfdist/Makefile ---
@@ -60,9 +60,11 @@ mkgpfdist: mkdir
for file in $(GPFDISTFILES); do \
( $(CC) $(INCLUDES) $(CFLAGS) $(LIBS) -c $(code_dir)$${file}); \
+ if [[ $$? -ne 0 ]]; then exit 1; fi \
--- End diff --
indent?
> Need to stop building when building error occurs in gpfdist directory
> -
>
> Key: HAWQ-877
> URL: https://issues.apache.org/jira/browse/HAWQ-877
> Project: Apache HAWQ
> Issue Type: Bug
> Components: Build
>Reporter: Ming LI
>Assignee: Lei Chang
>
> When building gpfdist report error "'openssl/ssl.h' file not found", it
> doesn't stop building, so the last error we can see it not the right root
> error.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
