[jira] [Updated] (HBASE-6378) the javadoc of setEnabledTable maybe not describe accurately
[
https://issues.apache.org/jira/browse/HBASE-6378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhou wenjian updated HBASE-6378:
Attachment: HBASE-6378.patch
> the javadoc of setEnabledTable maybe not describe accurately
> --
>
> Key: HBASE-6378
> URL: https://issues.apache.org/jira/browse/HBASE-6378
> Project: HBase
> Issue Type: Bug
> Components: master
>Affects Versions: 0.94.0
>Reporter: zhou wenjian
> Fix For: 0.94.2
>
> Attachments: 6378.patch, HBASE-6378.patch
>
>
> /**
>* Sets the ENABLED state in the cache and deletes the zookeeper node. Fails
>* silently if the node is not in enabled in zookeeper
>*
>* @param tableName
>* @throws KeeperException
>*/
> public void setEnabledTable(final String tableName) throws KeeperException {
> setTableState(tableName, TableState.ENABLED);
> }
> When setEnabledTable occours ,It will update the cache and the zookeeper
> node,rather than to delete the zk node.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6272) In-memory region state is inconsistent
[ https://issues.apache.org/jira/browse/HBASE-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414767#comment-13414767 ] Zhihong Ted Yu commented on HBASE-6272: --- Please consider the scenario described in HBASE-6060 Thanks > In-memory region state is inconsistent > -- > > Key: HBASE-6272 > URL: https://issues.apache.org/jira/browse/HBASE-6272 > Project: HBase > Issue Type: Bug >Reporter: Jimmy Xiang >Assignee: Jimmy Xiang > > AssignmentManger stores region state related information in several places: > regionsInTransition, regions (region info to server name map), and servers > (server name to region info set map). However the access to these places is > not coordinated properly. It leads to inconsistent in-memory region state > information. Sometimes, some region could even be offline, and not in > transition. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6055) Snapshots in HBase 0.96
[ https://issues.apache.org/jira/browse/HBASE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414766#comment-13414766 ] Jonathan Hsieh commented on HBASE-6055: --- @Ted -- FYI, I keep 5 screens open each on a different one. Then I can flip between them quick and comment on each. > Snapshots in HBase 0.96 > --- > > Key: HBASE-6055 > URL: https://issues.apache.org/jira/browse/HBASE-6055 > Project: HBase > Issue Type: New Feature > Components: client, master, regionserver, zookeeper >Reporter: Jesse Yates >Assignee: Jesse Yates > Fix For: 0.96.0 > > Attachments: Snapshots in HBase.docx > > > Continuation of HBASE-50 for the current trunk. Since the implementation has > drastically changed, opening as a new ticket. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6272) In-memory region state is inconsistent
[ https://issues.apache.org/jira/browse/HBASE-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414737#comment-13414737 ] Jimmy Xiang commented on HBASE-6272: @Ted, I was shutting down region servers, master, restarting them, while keeping moving regions around. Any other mean things I should do to it? > In-memory region state is inconsistent > -- > > Key: HBASE-6272 > URL: https://issues.apache.org/jira/browse/HBASE-6272 > Project: HBase > Issue Type: Bug >Reporter: Jimmy Xiang >Assignee: Jimmy Xiang > > AssignmentManger stores region state related information in several places: > regionsInTransition, regions (region info to server name map), and servers > (server name to region info set map). However the access to these places is > not coordinated properly. It leads to inconsistent in-memory region state > information. Sometimes, some region could even be offline, and not in > transition. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4072) Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from the classpath
[
https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414732#comment-13414732
]
Harsh J commented on HBASE-4072:
{quote}
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}
I assembled a package, ran a single node cluster with hbase-site.xml configured
and a zoo.cfg on the conf/ directory, pointing to a non-existent server. It
seemed to start, which probably meant it picked up the hbase-site.xml and
ignored zoo.cfg as my patch intends to. But I can add some tests, ideas?
bq. -1 javac. The applied patch generated 5 javac compiler warnings (more than
the trunk's current 4 warnings).
The additional javac warning is cause of the newly deprecated method being used
(in the fallback method). I could suppress it, but dunno if thats good to do
(we should be removing usage of that method by the next release after the one
this goes into).
bq. -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9)
warnings.
In the report, none of the classes I've touched here seem to be reported.
{quote}
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestSplitLogWorker
{quote}
The failing test passes for me on both trunk and with patch applied:
{code}
Running org.apache.hadoop.hbase.regionserver.TestSplitLogWorker
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.11 sec
{code}
> Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from
> the classpath
> ---
>
> Key: HBASE-4072
> URL: https://issues.apache.org/jira/browse/HBASE-4072
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.90.0
>Reporter: stack
>Assignee: Harsh J
> Attachments: HBASE-4072.patch
>
>
> This issue was found by Lars:
> http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml
> Lets fix the inconsistency found and fix the places where we use non-zk
> attribute name for a zk attribute in hbase (There's only a few places that I
> remember -- maximum client connections is one IIRC)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4072) Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from the classpath
[ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414725#comment-13414725 ] Hadoop QA commented on HBASE-4072: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12536563/HBASE-4072.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestSplitLogWorker Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2389//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2389//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2389//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2389//console This message is automatically generated. > Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from > the classpath > --- > > Key: HBASE-4072 > URL: https://issues.apache.org/jira/browse/HBASE-4072 > Project: HBase > Issue Type: Bug >Affects Versions: 0.90.0 >Reporter: stack >Assignee: Harsh J > Attachments: HBASE-4072.patch > > > This issue was found by Lars: > http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml > Lets fix the inconsistency found and fix the places where we use non-zk > attribute name for a zk attribute in hbase (There's only a few places that I > remember -- maximum client connections is one IIRC) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4072) Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from the classpath
[ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J updated HBASE-4072: --- Affects Version/s: 0.90.0 Release Note: The Apache ZooKeeper config file zoo.cfg will no longer be read when instantiating a HBaseConfiguration object, as it causes various inconsistency issues. Instead, users have to specify all HBase-relevant ZooKeeper properties in the hbase-site.xml using the various "hbase.zookeeper" prefixed properties. For example, specify "hbase.zookeeper.quorum" to provide a ZK quorum server list. To enable zoo.cfg reading, for which support may be removed in a future release, set the property "hbase.config.read.zookeeper.config" to true in the hbase-site.xml at the client/server. Hadoop Flags: Incompatible change Status: Patch Available (was: Open) > Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from > the classpath > --- > > Key: HBASE-4072 > URL: https://issues.apache.org/jira/browse/HBASE-4072 > Project: HBase > Issue Type: Bug >Affects Versions: 0.90.0 >Reporter: stack >Assignee: Harsh J > Attachments: HBASE-4072.patch > > > This issue was found by Lars: > http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml > Lets fix the inconsistency found and fix the places where we use non-zk > attribute name for a zk attribute in hbase (There's only a few places that I > remember -- maximum client connections is one IIRC) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4072) Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from the classpath
[ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J updated HBASE-4072: --- Attachment: HBASE-4072.patch Patch that does the following: # Deprecates the ZKConfig#parseZooCfg method. # Adds a new property that toggles zoo.cfg parsing. Property is named "hbase.config.read.zookeeper.config", and is false by default (i.e. we will no longer read zoo.cfg unless this has been manually enabled) # Miscellaneous doc and log improvements in the same files to reflect this change. > Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from > the classpath > --- > > Key: HBASE-4072 > URL: https://issues.apache.org/jira/browse/HBASE-4072 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: Harsh J > Attachments: HBASE-4072.patch > > > This issue was found by Lars: > http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml > Lets fix the inconsistency found and fix the places where we use non-zk > attribute name for a zk attribute in hbase (There's only a few places that I > remember -- maximum client connections is one IIRC) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4072) Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from the classpath
[ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J updated HBASE-4072: --- Summary: Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from the classpath (was: zoo.cfg inconsistently used and sometimes we use non-zk names for zk attributes) Retitling to reflect current approach. > Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from > the classpath > --- > > Key: HBASE-4072 > URL: https://issues.apache.org/jira/browse/HBASE-4072 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: Harsh J > > This issue was found by Lars: > http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml > Lets fix the inconsistency found and fix the places where we use non-zk > attribute name for a zk attribute in hbase (There's only a few places that I > remember -- maximum client connections is one IIRC) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6272) In-memory region state is inconsistent
[ https://issues.apache.org/jira/browse/HBASE-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414690#comment-13414690 ] Zhihong Ted Yu commented on HBASE-6272: --- @Jimmy: Can you clarify whether the test on trunk was performed in a live cluster ? > In-memory region state is inconsistent > -- > > Key: HBASE-6272 > URL: https://issues.apache.org/jira/browse/HBASE-6272 > Project: HBase > Issue Type: Bug >Reporter: Jimmy Xiang >Assignee: Jimmy Xiang > > AssignmentManger stores region state related information in several places: > regionsInTransition, regions (region info to server name map), and servers > (server name to region info set map). However the access to these places is > not coordinated properly. It leads to inconsistent in-memory region state > information. Sometimes, some region could even be offline, and not in > transition. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6055) Snapshots in HBase 0.96
[
https://issues.apache.org/jira/browse/HBASE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414689#comment-13414689
]
Zhihong Ted Yu commented on HBASE-6055:
---
Flipping through 5 pages on review board is slow. So I am putting down some
notes here.
For HStore.java:
The license header doesn't look like the standard format.
Please add audience and stability annotations to this new interface.
{code}
+ FileStatus[] getStoreFiles() throws IOException;
+
+ List getStorefiles();
{code}
Why do we need two methods which are spelled almost the same, yet returning
different types ? When refactoring, we should make the code cleaner.
There're many methods which don't have javadoc. Please add javadoc for them.
{code}
+ public HStore getDelgate() {
{code}
Correct spelling for the above method.
> Snapshots in HBase 0.96
> ---
>
> Key: HBASE-6055
> URL: https://issues.apache.org/jira/browse/HBASE-6055
> Project: HBase
> Issue Type: New Feature
> Components: client, master, regionserver, zookeeper
>Reporter: Jesse Yates
>Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: Snapshots in HBase.docx
>
>
> Continuation of HBASE-50 for the current trunk. Since the implementation has
> drastically changed, opening as a new ticket.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6272) In-memory region state is inconsistent
[ https://issues.apache.org/jira/browse/HBASE-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414673#comment-13414673 ] Jimmy Xiang commented on HBASE-6272: That's a good question. I am testing it on trunk now, so far so good. As to 0.92 and 0.94, if the patch applies clean, I will just do some unit tests. Otherwise, I will file a separate jira, do backport, and test it on a corresponding live cluster. > In-memory region state is inconsistent > -- > > Key: HBASE-6272 > URL: https://issues.apache.org/jira/browse/HBASE-6272 > Project: HBase > Issue Type: Bug >Reporter: Jimmy Xiang >Assignee: Jimmy Xiang > > AssignmentManger stores region state related information in several places: > regionsInTransition, regions (region info to server name map), and servers > (server name to region info set map). However the access to these places is > not coordinated properly. It leads to inconsistent in-memory region state > information. Sometimes, some region could even be offline, and not in > transition. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6230) [brainstorm] "Restore" snapshots for HBase 0.96
[ https://issues.apache.org/jira/browse/HBASE-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Bertozzi updated HBASE-6230: --- Attachment: SnapshotRestore-v0.pdf Attached a document on how the Restore/Rollback work and an initial draft of the restore code https://reviews.apache.org/r/5963/ > [brainstorm] "Restore" snapshots for HBase 0.96 > --- > > Key: HBASE-6230 > URL: https://issues.apache.org/jira/browse/HBASE-6230 > Project: HBase > Issue Type: Brainstorming >Reporter: Jesse Yates >Assignee: Matteo Bertozzi > Attachments: SnapshotRestore-v0.pdf > > > Discussion ticket around the definitions/expectations of different parts of > snapshot restoration. This is complementary, but separate from the _how_ of > taking a snapshot of a table. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
