[jira] [Updated] (HBASE-8667) Master and Regionserver not able to communicate if both bound to different network interfaces on the same machine.
[
https://issues.apache.org/jira/browse/HBASE-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
rajeshbabu updated HBASE-8667:
--
Attachment: HBASE-8667_trunk.patch
bq. Can we fix this so client has same home as the RS rpcserver?
Initially I have tried this approach only. Attaching the same patch. I have
tested the patch in cluster by configuring different ip's for master and
regionserver and also with localhost in some tests.
> Master and Regionserver not able to communicate if both bound to different
> network interfaces on the same machine.
> --
>
> Key: HBASE-8667
> URL: https://issues.apache.org/jira/browse/HBASE-8667
> Project: HBase
> Issue Type: Bug
> Components: IPC/RPC
>Reporter: rajeshbabu
> Fix For: 0.98.0, 0.95.2, 0.94.9
>
> Attachments: HBASE-8667_trunk.patch, HBASE-8667_Trunk.patch,
> HBASE-8667_Trunk-V2.patch
>
>
> While testing HBASE-8640 fix found that master and regionserver running on
> different interfaces are not communicating properly.
> I have two interfaces 1) lo 2) eth0 in my machine and default hostname
> interface is lo.
> I have configured master ipc address to ip of eth0 interface.
> Started master and regionserver on the same machine.
> 1) master rpc server bound to eth0 and RS rpc server bound to lo
> 2) Since rpc client is not binding to any ip address, when RS is reporting RS
> startup its getting registered with eth0 ip address(but actually it should
> register localhost)
> Here are RS logs:
> {code}
> 2013-05-31 06:05:28,608 WARN [regionserver60020]
> org.apache.hadoop.hbase.regionserver.HRegionServer: reportForDuty failed;
> sleeping and then retrying.
> 2013-05-31 06:05:31,609 INFO [regionserver60020]
> org.apache.hadoop.hbase.regionserver.HRegionServer: Attempting connect to
> Master server at 192.168.0.100,6,1369960497008
> 2013-05-31 06:05:31,609 INFO [regionserver60020]
> org.apache.hadoop.hbase.regionserver.HRegionServer: Telling master at
> 192.168.0.100,6,1369960497008 that we are up with port=60020,
> startcode=1369960502544
> 2013-05-31 06:05:31,618 DEBUG [regionserver60020]
> org.apache.hadoop.hbase.regionserver.HRegionServer: Config from master:
> hbase.rootdir=hdfs://localhost:2851/hbase
> 2013-05-31 06:05:31,618 DEBUG [regionserver60020]
> org.apache.hadoop.hbase.regionserver.HRegionServer: Config from master:
> fs.default.name=hdfs://localhost:2851
> 2013-05-31 06:05:31,618 INFO [regionserver60020]
> org.apache.hadoop.hbase.regionserver.HRegionServer: Master passed us a
> different hostname to use; was=localhost, but now=192.168.0.100
> {code}
> Here are master logs:
> {code}
> 2013-05-31 06:05:31,615 INFO [IPC Server handler 9 on 6]
> org.apache.hadoop.hbase.master.ServerManager: Registering
> server=192.168.0.100,60020,1369960502544
> {code}
> Since master has wrong rpc server address of RS, META is not getting assigned.
> {code}
> 2013-05-31 06:05:34,362 DEBUG [master-192.168.0.100,6,1369960497008]
> org.apache.hadoop.hbase.master.AssignmentManager: No previous transition plan
> was found (or we are ignoring an existing plan) for .META.,,1.1028785192 so
> generated a random one; hri=.META.,,1.1028785192, src=,
> dest=192.168.0.100,60020,1369960502544; 1 (online=1, available=1) available
> servers, forceNewPlan=false
> -
> org.apache.hadoop.hbase.master.AssignmentManager: Failed assignment of
> .META.,,1.1028785192 to 192.168.0.100,60020,1369960502544, trying to assign
> elsewhere instead; try=1 of 10
> java.net.ConnectException: Connection refused
> at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
> at
> sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:592)
> at
> org.apache.hadoop.net.SocketIOWithTimeout.connect(SocketIOWithTimeout.java:206)
> at org.apache.hadoop.net.NetUtils.connect(NetUtils.java:511)
> at org.apache.hadoop.net.NetUtils.connect(NetUtils.java:481)
> at
> org.apache.hadoop.hbase.ipc.RpcClient$Connection.setupConnection(RpcClient.java:549)
> at
> org.apache.hadoop.hbase.ipc.RpcClient$Connection.setupIOstreams(RpcClient.java:813)
> at
> org.apache.hadoop.hbase.ipc.RpcClient.getConnection(RpcClient.java:1422)
> at org.apache.hadoop.hbase.ipc.RpcClient.call(RpcClient.java:1315)
> at
> org.apache.hadoop.hbase.ipc.RpcClient.callBlockingMethod(RpcClient.java:1532)
> at
> org.apache.hadoop.hbase.ipc.RpcClient$BlockingRpcChannelImplementation.callBlockingMethod(RpcClient.java:1587)
> at
> org.apache.hadoop.hbase.protobuf.generated.AdminProtos$AdminService$BlockingStub.openRegion(AdminProtos.java:15039)
> at
> org.apache.hadoop.hbase.master.ServerManager.sendRegionOpen(ServerManager.java:627)
[jira] [Updated] (HBASE-8667) Master and Regionserver not able to communicate if both bound to different network interfaces on the same machine.
[
https://issues.apache.org/jira/browse/HBASE-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
rajeshbabu updated HBASE-8667:
--
Status: Patch Available (was: Open)
> Master and Regionserver not able to communicate if both bound to different
> network interfaces on the same machine.
> --
>
> Key: HBASE-8667
> URL: https://issues.apache.org/jira/browse/HBASE-8667
> Project: HBase
> Issue Type: Bug
> Components: IPC/RPC
>Reporter: rajeshbabu
> Fix For: 0.98.0, 0.95.2, 0.94.9
>
> Attachments: HBASE-8667_trunk.patch, HBASE-8667_Trunk.patch,
> HBASE-8667_Trunk-V2.patch
>
>
> While testing HBASE-8640 fix found that master and regionserver running on
> different interfaces are not communicating properly.
> I have two interfaces 1) lo 2) eth0 in my machine and default hostname
> interface is lo.
> I have configured master ipc address to ip of eth0 interface.
> Started master and regionserver on the same machine.
> 1) master rpc server bound to eth0 and RS rpc server bound to lo
> 2) Since rpc client is not binding to any ip address, when RS is reporting RS
> startup its getting registered with eth0 ip address(but actually it should
> register localhost)
> Here are RS logs:
> {code}
> 2013-05-31 06:05:28,608 WARN [regionserver60020]
> org.apache.hadoop.hbase.regionserver.HRegionServer: reportForDuty failed;
> sleeping and then retrying.
> 2013-05-31 06:05:31,609 INFO [regionserver60020]
> org.apache.hadoop.hbase.regionserver.HRegionServer: Attempting connect to
> Master server at 192.168.0.100,6,1369960497008
> 2013-05-31 06:05:31,609 INFO [regionserver60020]
> org.apache.hadoop.hbase.regionserver.HRegionServer: Telling master at
> 192.168.0.100,6,1369960497008 that we are up with port=60020,
> startcode=1369960502544
> 2013-05-31 06:05:31,618 DEBUG [regionserver60020]
> org.apache.hadoop.hbase.regionserver.HRegionServer: Config from master:
> hbase.rootdir=hdfs://localhost:2851/hbase
> 2013-05-31 06:05:31,618 DEBUG [regionserver60020]
> org.apache.hadoop.hbase.regionserver.HRegionServer: Config from master:
> fs.default.name=hdfs://localhost:2851
> 2013-05-31 06:05:31,618 INFO [regionserver60020]
> org.apache.hadoop.hbase.regionserver.HRegionServer: Master passed us a
> different hostname to use; was=localhost, but now=192.168.0.100
> {code}
> Here are master logs:
> {code}
> 2013-05-31 06:05:31,615 INFO [IPC Server handler 9 on 6]
> org.apache.hadoop.hbase.master.ServerManager: Registering
> server=192.168.0.100,60020,1369960502544
> {code}
> Since master has wrong rpc server address of RS, META is not getting assigned.
> {code}
> 2013-05-31 06:05:34,362 DEBUG [master-192.168.0.100,6,1369960497008]
> org.apache.hadoop.hbase.master.AssignmentManager: No previous transition plan
> was found (or we are ignoring an existing plan) for .META.,,1.1028785192 so
> generated a random one; hri=.META.,,1.1028785192, src=,
> dest=192.168.0.100,60020,1369960502544; 1 (online=1, available=1) available
> servers, forceNewPlan=false
> -
> org.apache.hadoop.hbase.master.AssignmentManager: Failed assignment of
> .META.,,1.1028785192 to 192.168.0.100,60020,1369960502544, trying to assign
> elsewhere instead; try=1 of 10
> java.net.ConnectException: Connection refused
> at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
> at
> sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:592)
> at
> org.apache.hadoop.net.SocketIOWithTimeout.connect(SocketIOWithTimeout.java:206)
> at org.apache.hadoop.net.NetUtils.connect(NetUtils.java:511)
> at org.apache.hadoop.net.NetUtils.connect(NetUtils.java:481)
> at
> org.apache.hadoop.hbase.ipc.RpcClient$Connection.setupConnection(RpcClient.java:549)
> at
> org.apache.hadoop.hbase.ipc.RpcClient$Connection.setupIOstreams(RpcClient.java:813)
> at
> org.apache.hadoop.hbase.ipc.RpcClient.getConnection(RpcClient.java:1422)
> at org.apache.hadoop.hbase.ipc.RpcClient.call(RpcClient.java:1315)
> at
> org.apache.hadoop.hbase.ipc.RpcClient.callBlockingMethod(RpcClient.java:1532)
> at
> org.apache.hadoop.hbase.ipc.RpcClient$BlockingRpcChannelImplementation.callBlockingMethod(RpcClient.java:1587)
> at
> org.apache.hadoop.hbase.protobuf.generated.AdminProtos$AdminService$BlockingStub.openRegion(AdminProtos.java:15039)
> at
> org.apache.hadoop.hbase.master.ServerManager.sendRegionOpen(ServerManager.java:627)
> at
> org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentManager.java:1826)
> at
> org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentManager.java:1453)
> at
> org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentMa
[jira] [Updated] (HBASE-8667) Master and Regionserver not able to communicate if both bound to different network interfaces on the same machine.
[
https://issues.apache.org/jira/browse/HBASE-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
rajeshbabu updated HBASE-8667:
--
Status: Open (was: Patch Available)
> Master and Regionserver not able to communicate if both bound to different
> network interfaces on the same machine.
> --
>
> Key: HBASE-8667
> URL: https://issues.apache.org/jira/browse/HBASE-8667
> Project: HBase
> Issue Type: Bug
> Components: IPC/RPC
>Reporter: rajeshbabu
> Fix For: 0.98.0, 0.95.2, 0.94.9
>
> Attachments: HBASE-8667_trunk.patch, HBASE-8667_Trunk.patch,
> HBASE-8667_Trunk-V2.patch
>
>
> While testing HBASE-8640 fix found that master and regionserver running on
> different interfaces are not communicating properly.
> I have two interfaces 1) lo 2) eth0 in my machine and default hostname
> interface is lo.
> I have configured master ipc address to ip of eth0 interface.
> Started master and regionserver on the same machine.
> 1) master rpc server bound to eth0 and RS rpc server bound to lo
> 2) Since rpc client is not binding to any ip address, when RS is reporting RS
> startup its getting registered with eth0 ip address(but actually it should
> register localhost)
> Here are RS logs:
> {code}
> 2013-05-31 06:05:28,608 WARN [regionserver60020]
> org.apache.hadoop.hbase.regionserver.HRegionServer: reportForDuty failed;
> sleeping and then retrying.
> 2013-05-31 06:05:31,609 INFO [regionserver60020]
> org.apache.hadoop.hbase.regionserver.HRegionServer: Attempting connect to
> Master server at 192.168.0.100,6,1369960497008
> 2013-05-31 06:05:31,609 INFO [regionserver60020]
> org.apache.hadoop.hbase.regionserver.HRegionServer: Telling master at
> 192.168.0.100,6,1369960497008 that we are up with port=60020,
> startcode=1369960502544
> 2013-05-31 06:05:31,618 DEBUG [regionserver60020]
> org.apache.hadoop.hbase.regionserver.HRegionServer: Config from master:
> hbase.rootdir=hdfs://localhost:2851/hbase
> 2013-05-31 06:05:31,618 DEBUG [regionserver60020]
> org.apache.hadoop.hbase.regionserver.HRegionServer: Config from master:
> fs.default.name=hdfs://localhost:2851
> 2013-05-31 06:05:31,618 INFO [regionserver60020]
> org.apache.hadoop.hbase.regionserver.HRegionServer: Master passed us a
> different hostname to use; was=localhost, but now=192.168.0.100
> {code}
> Here are master logs:
> {code}
> 2013-05-31 06:05:31,615 INFO [IPC Server handler 9 on 6]
> org.apache.hadoop.hbase.master.ServerManager: Registering
> server=192.168.0.100,60020,1369960502544
> {code}
> Since master has wrong rpc server address of RS, META is not getting assigned.
> {code}
> 2013-05-31 06:05:34,362 DEBUG [master-192.168.0.100,6,1369960497008]
> org.apache.hadoop.hbase.master.AssignmentManager: No previous transition plan
> was found (or we are ignoring an existing plan) for .META.,,1.1028785192 so
> generated a random one; hri=.META.,,1.1028785192, src=,
> dest=192.168.0.100,60020,1369960502544; 1 (online=1, available=1) available
> servers, forceNewPlan=false
> -
> org.apache.hadoop.hbase.master.AssignmentManager: Failed assignment of
> .META.,,1.1028785192 to 192.168.0.100,60020,1369960502544, trying to assign
> elsewhere instead; try=1 of 10
> java.net.ConnectException: Connection refused
> at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
> at
> sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:592)
> at
> org.apache.hadoop.net.SocketIOWithTimeout.connect(SocketIOWithTimeout.java:206)
> at org.apache.hadoop.net.NetUtils.connect(NetUtils.java:511)
> at org.apache.hadoop.net.NetUtils.connect(NetUtils.java:481)
> at
> org.apache.hadoop.hbase.ipc.RpcClient$Connection.setupConnection(RpcClient.java:549)
> at
> org.apache.hadoop.hbase.ipc.RpcClient$Connection.setupIOstreams(RpcClient.java:813)
> at
> org.apache.hadoop.hbase.ipc.RpcClient.getConnection(RpcClient.java:1422)
> at org.apache.hadoop.hbase.ipc.RpcClient.call(RpcClient.java:1315)
> at
> org.apache.hadoop.hbase.ipc.RpcClient.callBlockingMethod(RpcClient.java:1532)
> at
> org.apache.hadoop.hbase.ipc.RpcClient$BlockingRpcChannelImplementation.callBlockingMethod(RpcClient.java:1587)
> at
> org.apache.hadoop.hbase.protobuf.generated.AdminProtos$AdminService$BlockingStub.openRegion(AdminProtos.java:15039)
> at
> org.apache.hadoop.hbase.master.ServerManager.sendRegionOpen(ServerManager.java:627)
> at
> org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentManager.java:1826)
> at
> org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentManager.java:1453)
> at
> org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentMa
[jira] [Created] (HBASE-8742) HTableDescriptor Properties not preserved when cloning
Micah Whitacre created HBASE-8742: - Summary: HTableDescriptor Properties not preserved when cloning Key: HBASE-8742 URL: https://issues.apache.org/jira/browse/HBASE-8742 Project: HBase Issue Type: Bug Components: snapshots Affects Versions: 0.94.6.1 Reporter: Micah Whitacre Priority: Minor When cloning a snapshot to a new table the values[1] set on the original HTableDescriptor are not preserved. This is because the values are not pulled off and set in the RestoreSnapshotHelper.cloneTableSchema(..)[2] method. This affects a number of things such as custom properties but also for configured coprocessors for the table. [1] - http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/HTableDescriptor.html#setValue(byte[], byte[]) [2] - https://github.com/apache/hbase/blob/0.94.6.1/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java#L582 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8691) High-Throughput Streaming Scan API
[ https://issues.apache.org/jira/browse/HBASE-8691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682705#comment-13682705 ] Sandy Pratt commented on HBASE-8691: I noticed when doing some more testing that I'm returning only a partial Result in the stream case, but the full Result in the control cases. That means the stream result doesn't have to transfer the rowkey (x3) and a couple of timestamps. When I correct the test to return the full Result, using DataOutputBuffer/DataInputBuffer to serialize and deserialize, the stream case is about 2x faster than the RPC cases (rather than 4x faster). I think it's still worth looking at for a 2x speedup. Unfortunately, I can't figure out how to make Hive work with an event driven interface. Since my customers use Hive primarily, I might have to put this on the back burner for now. I hope somebody finds it useful. > High-Throughput Streaming Scan API > -- > > Key: HBASE-8691 > URL: https://issues.apache.org/jira/browse/HBASE-8691 > Project: HBase > Issue Type: Improvement > Components: Scanners >Affects Versions: 0.95.0 >Reporter: Sandy Pratt > Labels: perfomance, scan > Attachments: HRegionServlet.java, README.txt, RecordReceiver.java, > ScannerTest.java, StreamHRegionServer.java, StreamReceiverDirect.java, > StreamServletDirect.java > > > I've done some working testing various ways to refactor and optimize Scans in > HBase, and have found that performance can be dramatically increased by the > addition of a streaming scan API. The attached code constitutes a proof of > concept that shows performance increases of almost 4x in some workloads. > I'd appreciate testing, replication, and comments. If the approach seems > viable, I think such an API should be built into some future version of HBase. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-8651) Result of integer multiplication cast to long in HRegionFileSystem#sleepBeforeRetry()
[
https://issues.apache.org/jira/browse/HBASE-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-8651:
--
Fix Version/s: 0.98.0
Status: Patch Available (was: Open)
> Result of integer multiplication cast to long in
> HRegionFileSystem#sleepBeforeRetry()
> -
>
> Key: HBASE-8651
> URL: https://issues.apache.org/jira/browse/HBASE-8651
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: samar
>Priority: Minor
> Fix For: 0.98.0
>
> Attachments: HBASE-8651.patch
>
>
> {code}
> Threads.sleep(baseSleepBeforeRetries * sleepMultiplier);
> {code}
> Both baseSleepBeforeRetries and sleepMultiplier are integers. Without proper
> casting, their product may be negative.
> Here is an example:
> {code}
> static int i = Integer.MAX_VALUE-1;
> static long j = i * 2;
> {code}
> value of j above is -4 while 4294967292 was the expected value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gustavo Anatoly reassigned HBASE-7462: -- Assignee: Gustavo Anatoly > TestDrainingServer is an integration test. It should be a unit test instead > --- > > Key: HBASE-7462 > URL: https://issues.apache.org/jira/browse/HBASE-7462 > Project: HBase > Issue Type: Wish > Components: test >Affects Versions: 0.95.2 >Reporter: Nicolas Liochon >Assignee: Gustavo Anatoly >Priority: Trivial > Labels: noob > Attachments: HBASE-7462-v1.patch > > > TestDrainingServer tests the function that allows to say that a regionserver > should not get new regions. > As it is written today, it's an integration test: it starts & stops a cluster. > The test would be more efficient if it would just check that the > AssignmentManager does not use the drained region server; whatever the > circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[
https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682067#comment-13682067
]
Hadoop QA commented on HBASE-7462:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12587514/HBASE-7462-v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6025//console
This message is automatically generated.
> TestDrainingServer is an integration test. It should be a unit test instead
> ---
>
> Key: HBASE-7462
> URL: https://issues.apache.org/jira/browse/HBASE-7462
> Project: HBase
> Issue Type: Wish
> Components: test
>Affects Versions: 0.95.2
>Reporter: Nicolas Liochon
>Priority: Trivial
> Labels: noob
> Attachments: HBASE-7462-v1.patch
>
>
> TestDrainingServer tests the function that allows to say that a regionserver
> should not get new regions.
> As it is written today, it's an integration test: it starts & stops a cluster.
> The test would be more efficient if it would just check that the
> AssignmentManager does not use the drained region server; whatever the
> circumstances (bulk assign or not for example).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-8651) Result of integer multiplication cast to long in HRegionFileSystem#sleepBeforeRetry()
[
https://issues.apache.org/jira/browse/HBASE-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
samar updated HBASE-8651:
-
Attachment: HBASE-8651.patch
> Result of integer multiplication cast to long in
> HRegionFileSystem#sleepBeforeRetry()
> -
>
> Key: HBASE-8651
> URL: https://issues.apache.org/jira/browse/HBASE-8651
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: samar
>Priority: Minor
> Attachments: HBASE-8651.patch
>
>
> {code}
> Threads.sleep(baseSleepBeforeRetries * sleepMultiplier);
> {code}
> Both baseSleepBeforeRetries and sleepMultiplier are integers. Without proper
> casting, their product may be negative.
> Here is an example:
> {code}
> static int i = Integer.MAX_VALUE-1;
> static long j = i * 2;
> {code}
> value of j above is -4 while 4294967292 was the expected value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-8651) Result of integer multiplication cast to long in HRegionFileSystem#sleepBeforeRetry()
[
https://issues.apache.org/jira/browse/HBASE-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
samar reassigned HBASE-8651:
Assignee: samar
> Result of integer multiplication cast to long in
> HRegionFileSystem#sleepBeforeRetry()
> -
>
> Key: HBASE-8651
> URL: https://issues.apache.org/jira/browse/HBASE-8651
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: samar
>Priority: Minor
>
> {code}
> Threads.sleep(baseSleepBeforeRetries * sleepMultiplier);
> {code}
> Both baseSleepBeforeRetries and sleepMultiplier are integers. Without proper
> casting, their product may be negative.
> Here is an example:
> {code}
> static int i = Integer.MAX_VALUE-1;
> static long j = i * 2;
> {code}
> value of j above is -4 while 4294967292 was the expected value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4360) Maintain information on the time a RS went dead
[ https://issues.apache.org/jira/browse/HBASE-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681977#comment-13681977 ] samar commented on HBASE-4360: -- [~nkeywal] point 1) yes i agree will make the changes point 2)Yes probably something like ServerStats or ServerInfo will make sense , if we stick to adding the new field in current ServerName The easier approach(with less changes) would be add a function like getDeathTime in DeadServer which would get the time from the map. But I prefer if we added deathtime to server. which now represents a dead server. and make necessary changes to the DeadServer class . like we replace the map now with a set and make necessary suggestions. The changes will be little more than now. > Maintain information on the time a RS went dead > --- > > Key: HBASE-4360 > URL: https://issues.apache.org/jira/browse/HBASE-4360 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.94.0 >Reporter: Harsh J >Priority: Minor > Attachments: HBASE-4360_1.patch, HBASE-4360_2.patch, > master-status1.png > > > Just something that'd be generally helpful, is to maintain DeadServer info > with the last timestamp when it was determined as dead. > Makes it easier to hunt the logs, and I don't think its much too expensive to > maintain (one additional update per dead determination). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
