[jira] [Commented] (HBASE-10258) [0.94] Fix JDK 7 related test failures.
[ https://issues.apache.org/jira/browse/HBASE-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859406#comment-13859406 ] Nicolas Liochon commented on HBASE-10258: - Using junit 4.11 for the 0.94 is likely the simplest option. 0.96 uses the default junit order. When I did the upgrade, I had to change some tests, they are listed here: HBASE-7574 [0.94] Fix JDK 7 related test failures. --- Key: HBASE-10258 URL: https://issues.apache.org/jira/browse/HBASE-10258 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Starting with these: org.apache.hadoop.hbase.mapreduce.TestCopyTable.testCopyTable org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster.testShouldFailSplitIfZNodeDoesNotExistDueToPrevRollBack org.apache.hadoop.hbase.regionserver.TestStore.testDeleteExpiredStoreFiles org.apache.hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient.testRestoreSnapshotOfCloned org.apache.hadoop.hbase.util.TestEnvironmentEdgeManager.testManageSingleton -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (HBASE-10261) HMaster can not connect to HRegionServer
johnaz1 created HBASE-10261: --- Summary: HMaster can not connect to HRegionServer Key: HBASE-10261 URL: https://issues.apache.org/jira/browse/HBASE-10261 Project: HBase Issue Type: Bug Affects Versions: 0.96.1.1 Reporter: johnaz1 Fix For: 0.96.1.1 I can start hbase in my hadoop-2.2.0 cluster -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10259) [0.94] Upgrade JUnit to 4.11
[ https://issues.apache.org/jira/browse/HBASE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859409#comment-13859409 ] Nicolas Liochon commented on HBASE-10259: - bq. can you check to see if the custom part of the older junit is in the newer junit? It's the case. [0.94] Upgrade JUnit to 4.11 Key: HBASE-10259 URL: https://issues.apache.org/jira/browse/HBASE-10259 Project: HBase Issue Type: Sub-task Reporter: Lars Hofhansl Fix For: 0.94.16 Attachments: 10259-v2.txt, 10259-v3.txt, 10259.txt Right now we're using a custom version it seems: 4.10-HBASE\-1. Let's upgrade that to 4.11. See parent for rationale. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10259) [0.94] Upgrade JUnit to 4.11
[ https://issues.apache.org/jira/browse/HBASE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859407#comment-13859407 ] Liang Xie commented on HBASE-10259: --- After a quick search, an feasible method in pig project is adding a new OrderedJUnit4Runner class, TestOrder annotation, this is the final patch: https://issues.apache.org/jira/secure/attachment/12547496/PIG-2908-trunk-1.patch If we don't want to introduce much code on it, maybe we can just rename the test method to let the lexicographic order same with the order in test source file ? [0.94] Upgrade JUnit to 4.11 Key: HBASE-10259 URL: https://issues.apache.org/jira/browse/HBASE-10259 Project: HBase Issue Type: Sub-task Reporter: Lars Hofhansl Fix For: 0.94.16 Attachments: 10259-v2.txt, 10259-v3.txt, 10259.txt Right now we're using a custom version it seems: 4.10-HBASE\-1. Let's upgrade that to 4.11. See parent for rationale. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10261) HMaster can not connect to HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] johnaz1 updated HBASE-10261: Attachment: errorlog.jpg HMaster can not connect to HRegionServer Key: HBASE-10261 URL: https://issues.apache.org/jira/browse/HBASE-10261 Project: HBase Issue Type: Bug Components: IPC/RPC Affects Versions: 0.96.1.1 Reporter: johnaz1 Fix For: 0.96.1.1 Attachments: errorlog.jpg I can start hbase in my hadoop-2.2.0 cluster -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10261) HMaster can not connect to HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] johnaz1 updated HBASE-10261: Component/s: IPC/RPC Environment: Centos hadoop2.2.0 protocbuf 2.5.0 HMaster can not connect to HRegionServer Key: HBASE-10261 URL: https://issues.apache.org/jira/browse/HBASE-10261 Project: HBase Issue Type: Bug Components: IPC/RPC Affects Versions: 0.96.1.1 Environment: Centos hadoop2.2.0 protocbuf 2.5.0 Reporter: johnaz1 Fix For: 0.96.1.1 Attachments: errorlog.jpg I can start hbase in my hadoop-2.2.0 cluster -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10259) [0.94] Upgrade JUnit to 4.11
[ https://issues.apache.org/jira/browse/HBASE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859408#comment-13859408 ] Nicolas Liochon commented on HBASE-10259: - HBASE-7574 lists the ones that were solved in .96 Note that @FixMethodOrder(MethodSorters.NAME_ASCENDING) does not mean the same ordering as in JDK 1.6 with junit 4.10., it's just a different ordering. [0.94] Upgrade JUnit to 4.11 Key: HBASE-10259 URL: https://issues.apache.org/jira/browse/HBASE-10259 Project: HBase Issue Type: Sub-task Reporter: Lars Hofhansl Fix For: 0.94.16 Attachments: 10259-v2.txt, 10259-v3.txt, 10259.txt Right now we're using a custom version it seems: 4.10-HBASE\-1. Let's upgrade that to 4.11. See parent for rationale. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10249) Intermittent TestReplicationSyncUpTool failure
[ https://issues.apache.org/jira/browse/HBASE-10249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859410#comment-13859410 ] Hudson commented on HBASE-10249: SUCCESS: Integrated in HBase-TRUNK #4772 (See [https://builds.apache.org/job/HBase-TRUNK/4772/]) HBASE-10249 Intermittent TestReplicationSyncUpTool failure (tedyu: rev 1554367) * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSyncUpTool.java Intermittent TestReplicationSyncUpTool failure -- Key: HBASE-10249 URL: https://issues.apache.org/jira/browse/HBASE-10249 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Demai Ni Fix For: 0.98.0, 0.94.16, 0.96.2, 0.99.0 Attachments: HBASE-10249-trunk-v0.patch New issue to keep track of this. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (HBASE-10262) provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL
Feng Honghua created HBASE-10262: Summary: provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL Key: HBASE-10262 URL: https://issues.apache.org/jira/browse/HBASE-10262 Project: HBase Issue Type: Improvement Reporter: Feng Honghua Assignee: Feng Honghua currently checkAndPut/checkAndDelete provided by HTable doesn't support full CompareOp other than CompareOp.EQUAL, which limits user/client from doing more flexible checkAndPut/checkAndDelete operation. this improvement fixes this limit by exposing additional checkAndPut/checkAndDelete API with full CompareOp support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10262) provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL
[ https://issues.apache.org/jira/browse/HBASE-10262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Honghua updated HBASE-10262: - Attachment: HBASE-10262-trunk_v0.patch patch attached provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL --- Key: HBASE-10262 URL: https://issues.apache.org/jira/browse/HBASE-10262 Project: HBase Issue Type: Improvement Reporter: Feng Honghua Assignee: Feng Honghua Attachments: HBASE-10262-trunk_v0.patch currently checkAndPut/checkAndDelete provided by HTable doesn't support full CompareOp other than CompareOp.EQUAL, which limits user/client from doing more flexible checkAndPut/checkAndDelete operation. this improvement fixes this limit by exposing additional checkAndPut/checkAndDelete API with full CompareOp support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10261) HMaster can not connect to HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859429#comment-13859429 ] johnaz1 commented on HBASE-10261: - Can somebody help me??? Thanks HMaster can not connect to HRegionServer Key: HBASE-10261 URL: https://issues.apache.org/jira/browse/HBASE-10261 Project: HBase Issue Type: Bug Components: IPC/RPC Affects Versions: 0.96.1.1 Environment: Centos hadoop2.2.0 protocbuf 2.5.0 Reporter: johnaz1 Fix For: 0.96.1.1 Attachments: errorlog.jpg I can start hbase in my hadoop-2.2.0 cluster -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10262) provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL
[ https://issues.apache.org/jira/browse/HBASE-10262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-10262: --- Status: Patch Available (was: Open) provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL --- Key: HBASE-10262 URL: https://issues.apache.org/jira/browse/HBASE-10262 Project: HBase Issue Type: Improvement Reporter: Feng Honghua Assignee: Feng Honghua Attachments: HBASE-10262-trunk_v0.patch currently checkAndPut/checkAndDelete provided by HTable doesn't support full CompareOp other than CompareOp.EQUAL, which limits user/client from doing more flexible checkAndPut/checkAndDelete operation. this improvement fixes this limit by exposing additional checkAndPut/checkAndDelete API with full CompareOp support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10249) Intermittent TestReplicationSyncUpTool failure
[ https://issues.apache.org/jira/browse/HBASE-10249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859459#comment-13859459 ] Hudson commented on HBASE-10249: FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #30 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/30/]) HBASE-10249 Intermittent TestReplicationSyncUpTool failure (tedyu: rev 1554367) * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSyncUpTool.java Intermittent TestReplicationSyncUpTool failure -- Key: HBASE-10249 URL: https://issues.apache.org/jira/browse/HBASE-10249 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Demai Ni Fix For: 0.98.0, 0.94.16, 0.96.2, 0.99.0 Attachments: HBASE-10249-trunk-v0.patch New issue to keep track of this. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10213) Add read log size per second metrics for replication source
[ https://issues.apache.org/jira/browse/HBASE-10213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859458#comment-13859458 ] Hudson commented on HBASE-10213: FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #30 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/30/]) Amend HBASE-10213. Spelling fix for method o.a.h.h.replication.regionserver.MetricsSource#incrLogReadInBytes (apurtell: rev 1554361) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSource.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java HBASE-10213 Add read log size per second metrics for replication source (tedyu: rev 1554347) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSource.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java Add read log size per second metrics for replication source --- Key: HBASE-10213 URL: https://issues.apache.org/jira/browse/HBASE-10213 Project: HBase Issue Type: Improvement Components: metrics, Replication Affects Versions: 0.94.14 Reporter: cuijianwei Assignee: cuijianwei Priority: Minor Fix For: 0.98.0, 0.99.0 Attachments: 10213-trunk-addendum-1.patch, HBASE-10213-0.94-v1.patch, HBASE-10213-0.94-v2.patch, HBASE-10213-trunk-v1.patch The current metrics of replication source contain logEditsReadRate, shippedBatchesRate, etc, which could indicate how fast the data replicated to peer cluster to some extent. However, it is not clear enough to know how many bytes replicating to peer cluster from these metrics. In production environment, it may be important to know the size of replicating data per second because the services may be affected if the network become busy. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10263) make LruBlockCache single/multi/in-memory ratio user-configurable and provide preemptive mode for in-memory type block
[ https://issues.apache.org/jira/browse/HBASE-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Honghua updated HBASE-10263: - Attachment: HBASE-10263-trunk_v0.patch patch attached make LruBlockCache single/multi/in-memory ratio user-configurable and provide preemptive mode for in-memory type block -- Key: HBASE-10263 URL: https://issues.apache.org/jira/browse/HBASE-10263 Project: HBase Issue Type: Improvement Reporter: Feng Honghua Assignee: Feng Honghua Attachments: HBASE-10263-trunk_v0.patch currently the single/multi/in-memory ratio in LruBlockCache is hardcoded 1:2:1, which can lead to somewhat counter-intuition behavior for some user scenario where in-memory table's read performance is much worse than ordinary table when two tables' data size is almost equal and larger than regionserver's cache size (we ever did some such experiment and verified that in-memory table random read performance is two times worse than ordinary table). this patch fixes above issue and provides: 1. make single/multi/in-memory ratio user-configurable 2. provide a configurable switch which can make in-memory block preemptive, by preemptive means when this switch is on in-memory block can kick out any ordinary block to make room until no ordinary block, when this switch is off (by default) the behavior is the same as previous, using single/multi/in-memory ratio to determine evicting. by default, above two changes are both off and the behavior keeps the same as before applying this patch. it's client/user's choice to determine whether or which behavior to use by enabling one of these two enhancements. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (HBASE-10263) make LruBlockCache single/multi/in-memory ratio user-configurable and provide preemptive mode for in-memory type block
Feng Honghua created HBASE-10263: Summary: make LruBlockCache single/multi/in-memory ratio user-configurable and provide preemptive mode for in-memory type block Key: HBASE-10263 URL: https://issues.apache.org/jira/browse/HBASE-10263 Project: HBase Issue Type: Improvement Reporter: Feng Honghua Assignee: Feng Honghua Attachments: HBASE-10263-trunk_v0.patch currently the single/multi/in-memory ratio in LruBlockCache is hardcoded 1:2:1, which can lead to somewhat counter-intuition behavior for some user scenario where in-memory table's read performance is much worse than ordinary table when two tables' data size is almost equal and larger than regionserver's cache size (we ever did some such experiment and verified that in-memory table random read performance is two times worse than ordinary table). this patch fixes above issue and provides: 1. make single/multi/in-memory ratio user-configurable 2. provide a configurable switch which can make in-memory block preemptive, by preemptive means when this switch is on in-memory block can kick out any ordinary block to make room until no ordinary block, when this switch is off (by default) the behavior is the same as previous, using single/multi/in-memory ratio to determine evicting. by default, above two changes are both off and the behavior keeps the same as before applying this patch. it's client/user's choice to determine whether or which behavior to use by enabling one of these two enhancements. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10262) provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL
[ https://issues.apache.org/jira/browse/HBASE-10262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859470#comment-13859470 ] Feng Honghua commented on HBASE-10262: -- thank [~yuzhih...@gmail.com] and ping [~apurtell] :-) provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL --- Key: HBASE-10262 URL: https://issues.apache.org/jira/browse/HBASE-10262 Project: HBase Issue Type: Improvement Reporter: Feng Honghua Assignee: Feng Honghua Attachments: HBASE-10262-trunk_v0.patch currently checkAndPut/checkAndDelete provided by HTable doesn't support full CompareOp other than CompareOp.EQUAL, which limits user/client from doing more flexible checkAndPut/checkAndDelete operation. this improvement fixes this limit by exposing additional checkAndPut/checkAndDelete API with full CompareOp support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10262) provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL
[
https://issues.apache.org/jira/browse/HBASE-10262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859483#comment-13859483
]
Hadoop QA commented on HBASE-10262:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12620924/HBASE-10262-trunk_v0.patch
against trunk revision .
ATTACHMENT ID: 12620924
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
org.apache.hadoop.hbase.util.TestHBaseFsck
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.TestAcidGuarantees.testGetAtomicity(TestAcidGuarantees.java:331)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8309//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8309//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8309//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8309//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8309//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8309//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8309//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8309//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8309//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8309//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8309//console
This message is automatically generated.
provide user/client checkAndPut/checkAndDelete API with full CompareOp rather
than only CompareOp.EQUAL
---
Key: HBASE-10262
URL: https://issues.apache.org/jira/browse/HBASE-10262
Project: HBase
Issue Type: Improvement
Reporter: Feng Honghua
Assignee: Feng Honghua
Attachments: HBASE-10262-trunk_v0.patch
currently checkAndPut/checkAndDelete provided by HTable doesn't support full
CompareOp other than CompareOp.EQUAL, which limits user/client from doing
more flexible checkAndPut/checkAndDelete operation. this improvement fixes
this limit by exposing additional checkAndPut/checkAndDelete API with full
CompareOp support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Updated] (HBASE-10263) make LruBlockCache single/multi/in-memory ratio user-configurable and provide preemptive mode for in-memory type block
[ https://issues.apache.org/jira/browse/HBASE-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-10263: --- Status: Patch Available (was: Open) make LruBlockCache single/multi/in-memory ratio user-configurable and provide preemptive mode for in-memory type block -- Key: HBASE-10263 URL: https://issues.apache.org/jira/browse/HBASE-10263 Project: HBase Issue Type: Improvement Reporter: Feng Honghua Assignee: Feng Honghua Attachments: HBASE-10263-trunk_v0.patch currently the single/multi/in-memory ratio in LruBlockCache is hardcoded 1:2:1, which can lead to somewhat counter-intuition behavior for some user scenario where in-memory table's read performance is much worse than ordinary table when two tables' data size is almost equal and larger than regionserver's cache size (we ever did some such experiment and verified that in-memory table random read performance is two times worse than ordinary table). this patch fixes above issue and provides: 1. make single/multi/in-memory ratio user-configurable 2. provide a configurable switch which can make in-memory block preemptive, by preemptive means when this switch is on in-memory block can kick out any ordinary block to make room until no ordinary block, when this switch is off (by default) the behavior is the same as previous, using single/multi/in-memory ratio to determine evicting. by default, above two changes are both off and the behavior keeps the same as before applying this patch. it's client/user's choice to determine whether or which behavior to use by enabling one of these two enhancements. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10261) HMaster can not connect to HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859495#comment-13859495 ] Liang Xie commented on HBASE-10261: --- please don't create a jira to ask question. the preferred way is post to u...@hbase.apache.org list. thanks! and it would be better if your provide more detail conf( at first glance, it seems the master addr was not resolved successful.) HMaster can not connect to HRegionServer Key: HBASE-10261 URL: https://issues.apache.org/jira/browse/HBASE-10261 Project: HBase Issue Type: Bug Components: IPC/RPC Affects Versions: 0.96.1.1 Environment: Centos hadoop2.2.0 protocbuf 2.5.0 Reporter: johnaz1 Fix For: 0.96.1.1 Attachments: errorlog.jpg I can start hbase in my hadoop-2.2.0 cluster -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10262) provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL
[ https://issues.apache.org/jira/browse/HBASE-10262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859512#comment-13859512 ] Anoop Sam John commented on HBASE-10262: Duplicates HBASE-5923? provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL --- Key: HBASE-10262 URL: https://issues.apache.org/jira/browse/HBASE-10262 Project: HBase Issue Type: Improvement Reporter: Feng Honghua Assignee: Feng Honghua Attachments: HBASE-10262-trunk_v0.patch currently checkAndPut/checkAndDelete provided by HTable doesn't support full CompareOp other than CompareOp.EQUAL, which limits user/client from doing more flexible checkAndPut/checkAndDelete operation. this improvement fixes this limit by exposing additional checkAndPut/checkAndDelete API with full CompareOp support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10262) provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL
[ https://issues.apache.org/jira/browse/HBASE-10262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859523#comment-13859523 ] Feng Honghua commented on HBASE-10262: -- [~anoop.hbase] Thanks for reminder. Yes, it duplicates [HBASE-5923|https://issues.apache.org/jira/browse/HBASE-5923] by its purpose. After going through the discussion, my understanding is it can't be achieved gracefully since it also exposes pb type CompareType to client (according to [~lhofhansl]'s patch and [~stack]'s suggestion). Seems it's feasible to using CompareFilter.CompareOp as the HTable/HTableInterface interface argument and mapping it to pb CompareType just before making the request, as my patch does. Would [~lhofhansl] and [~stack] check/review the patch to determine if it looks good enough to go in the trunk? According unit-tests in TestFromClientSide are also provided. Thanks. provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL --- Key: HBASE-10262 URL: https://issues.apache.org/jira/browse/HBASE-10262 Project: HBase Issue Type: Improvement Reporter: Feng Honghua Assignee: Feng Honghua Attachments: HBASE-10262-trunk_v0.patch currently checkAndPut/checkAndDelete provided by HTable doesn't support full CompareOp other than CompareOp.EQUAL, which limits user/client from doing more flexible checkAndPut/checkAndDelete operation. this improvement fixes this limit by exposing additional checkAndPut/checkAndDelete API with full CompareOp support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10262) provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL
[ https://issues.apache.org/jira/browse/HBASE-10262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859524#comment-13859524 ] Feng Honghua commented on HBASE-10262: -- all unit tests passed in my local machine, including the above 3 failed cases. wondering... provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL --- Key: HBASE-10262 URL: https://issues.apache.org/jira/browse/HBASE-10262 Project: HBase Issue Type: Improvement Reporter: Feng Honghua Assignee: Feng Honghua Attachments: HBASE-10262-trunk_v0.patch currently checkAndPut/checkAndDelete provided by HTable doesn't support full CompareOp other than CompareOp.EQUAL, which limits user/client from doing more flexible checkAndPut/checkAndDelete operation. this improvement fixes this limit by exposing additional checkAndPut/checkAndDelete API with full CompareOp support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10263) make LruBlockCache single/multi/in-memory ratio user-configurable and provide preemptive mode for in-memory type block
[
https://issues.apache.org/jira/browse/HBASE-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859527#comment-13859527
]
Hadoop QA commented on HBASE-10263:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12620929/HBASE-10263-trunk_v0.patch
against trunk revision .
ATTACHMENT ID: 12620929
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestSplitLogManager
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8310//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8310//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8310//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8310//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8310//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8310//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8310//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8310//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8310//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8310//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8310//console
This message is automatically generated.
make LruBlockCache single/multi/in-memory ratio user-configurable and provide
preemptive mode for in-memory type block
--
Key: HBASE-10263
URL: https://issues.apache.org/jira/browse/HBASE-10263
Project: HBase
Issue Type: Improvement
Reporter: Feng Honghua
Assignee: Feng Honghua
Attachments: HBASE-10263-trunk_v0.patch
currently the single/multi/in-memory ratio in LruBlockCache is hardcoded
1:2:1, which can lead to somewhat counter-intuition behavior for some user
scenario where in-memory table's read performance is much worse than ordinary
table when two tables' data size is almost equal and larger than
regionserver's cache size (we ever did some such experiment and verified that
in-memory table random read performance is two times worse than ordinary
table).
this patch fixes above issue and provides:
1. make single/multi/in-memory ratio user-configurable
2. provide a configurable switch which can make in-memory block preemptive,
by preemptive means when this switch is on in-memory block can kick out any
ordinary block to make room until no ordinary block, when this switch is off
(by default) the behavior is the same as previous, using
single/multi/in-memory ratio to determine evicting.
by default, above two changes are both off and the behavior keeps the same as
before applying this patch. it's client/user's choice to determine whether or
which behavior to use by enabling one of these two enhancements.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Updated] (HBASE-9203) Secondary index support through coprocessors
[ https://issues.apache.org/jira/browse/HBASE-9203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] rajeshbabu updated HBASE-9203: -- Attachment: SecondaryIndex Design_Updated.pdf updated specifying index details part as for the latest patch. Secondary index support through coprocessors Key: HBASE-9203 URL: https://issues.apache.org/jira/browse/HBASE-9203 Project: HBase Issue Type: New Feature Reporter: rajeshbabu Assignee: rajeshbabu Attachments: SecondaryIndex Design.pdf, SecondaryIndex Design_Updated.pdf We have been working on implementing secondary index in HBase and open sourced on hbase 0.94.8 version. The project is available on github. https://github.com/Huawei-Hadoop/hindex This Jira is to support secondary index on trunk(0.98). Following features will be supported. - multiple indexes on table, - multi column index, - index based on part of a column value, - equals and range condition scans using index, and - bulk loading data to indexed table (Indexing done with bulk load) Most of the kernel changes needed for secondary index is available in trunk. Very minimal changes needed for it. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10259) [0.94] Upgrade JUnit to 4.11
[ https://issues.apache.org/jira/browse/HBASE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859605#comment-13859605 ] Lars Hofhansl commented on HBASE-10259: --- bq. Note that @FixMethodOrder(MethodSorters.NAME_ASCENDING) does not mean the same ordering as in JDK 1.6 with junit 4.10., it's just a different ordering. Yep, it just happens so that most of the test pass when I annotate it that way :) I'll check out HBASE-7574. If that is all good I'll also switch jenkins for 0.94 to JDK7. [0.94] Upgrade JUnit to 4.11 Key: HBASE-10259 URL: https://issues.apache.org/jira/browse/HBASE-10259 Project: HBase Issue Type: Sub-task Reporter: Lars Hofhansl Fix For: 0.94.16 Attachments: 10259-v2.txt, 10259-v3.txt, 10259.txt Right now we're using a custom version it seems: 4.10-HBASE\-1. Let's upgrade that to 4.11. See parent for rationale. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10259) [0.94] Upgrade JUnit to 4.11
[ https://issues.apache.org/jira/browse/HBASE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859607#comment-13859607 ] Lars Hofhansl commented on HBASE-10259: --- I fixed TestZookeeper in a similar way. Will take the fix from TestAdmin. [0.94] Upgrade JUnit to 4.11 Key: HBASE-10259 URL: https://issues.apache.org/jira/browse/HBASE-10259 Project: HBase Issue Type: Sub-task Reporter: Lars Hofhansl Fix For: 0.94.16 Attachments: 10259-v2.txt, 10259-v3.txt, 10259.txt Right now we're using a custom version it seems: 4.10-HBASE\-1. Let's upgrade that to 4.11. See parent for rationale. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10259) [0.94] Upgrade JUnit to 4.11
[ https://issues.apache.org/jira/browse/HBASE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859608#comment-13859608 ] Lars Hofhansl commented on HBASE-10259: --- bq. maybe we can just rename the test method to let the lexicographic order same with the order in test source file Was thinking about a quick hack like this as well. It's kinda lame, though :) [0.94] Upgrade JUnit to 4.11 Key: HBASE-10259 URL: https://issues.apache.org/jira/browse/HBASE-10259 Project: HBase Issue Type: Sub-task Reporter: Lars Hofhansl Fix For: 0.94.16 Attachments: 10259-v2.txt, 10259-v3.txt, 10259.txt Right now we're using a custom version it seems: 4.10-HBASE\-1. Let's upgrade that to 4.11. See parent for rationale. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10262) provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL
[ https://issues.apache.org/jira/browse/HBASE-10262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859621#comment-13859621 ] Lars Hofhansl commented on HBASE-10262: --- Please see (long'ish) discussion on HBASE-5923. If we allow control of the compareOp we need to allow for different comparators as well (for LESS, etc) Or we can punt on that and just force binary comparator as we do not for EQUAL provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL --- Key: HBASE-10262 URL: https://issues.apache.org/jira/browse/HBASE-10262 Project: HBase Issue Type: Improvement Reporter: Feng Honghua Assignee: Feng Honghua Attachments: HBASE-10262-trunk_v0.patch currently checkAndPut/checkAndDelete provided by HTable doesn't support full CompareOp other than CompareOp.EQUAL, which limits user/client from doing more flexible checkAndPut/checkAndDelete operation. this improvement fixes this limit by exposing additional checkAndPut/checkAndDelete API with full CompareOp support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10259) [0.94] Upgrade JUnit to 4.11
[ https://issues.apache.org/jira/browse/HBASE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-10259: -- Attachment: 10259-v4.txt Fixes all tests, I think (will confirm). TestZookeeper and TestAdmin are actually fixed, the others just fix the test order. [0.94] Upgrade JUnit to 4.11 Key: HBASE-10259 URL: https://issues.apache.org/jira/browse/HBASE-10259 Project: HBase Issue Type: Sub-task Reporter: Lars Hofhansl Fix For: 0.94.16 Attachments: 10259-v2.txt, 10259-v3.txt, 10259-v4.txt, 10259.txt Right now we're using a custom version it seems: 4.10-HBASE\-1. Let's upgrade that to 4.11. See parent for rationale. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10260) Canary Doesn't pick up Configuration properly.
[ https://issues.apache.org/jira/browse/HBASE-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-10260: -- Attachment: HBASE-10260-0.patch Add HBaseConfiguration to the the ToolRunner Canary Doesn't pick up Configuration properly. -- Key: HBASE-10260 URL: https://issues.apache.org/jira/browse/HBASE-10260 Project: HBase Issue Type: Bug Components: util Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-10260-0.patch hbase-site.xml isn't picked up correctly when running the canary. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10260) Canary Doesn't pick up Configuration properly.
[ https://issues.apache.org/jira/browse/HBASE-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-10260: -- Status: Patch Available (was: Open) Canary Doesn't pick up Configuration properly. -- Key: HBASE-10260 URL: https://issues.apache.org/jira/browse/HBASE-10260 Project: HBase Issue Type: Bug Components: util Affects Versions: 0.96.1.1, 0.98.0, 0.99.0 Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-10260-0.patch hbase-site.xml isn't picked up correctly when running the canary. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10261) HMaster can not connect to HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859635#comment-13859635 ] Lars Hofhansl commented on HBASE-10261: --- As for this problem, did you recompile HBase against Hadoop 2.2? HMaster can not connect to HRegionServer Key: HBASE-10261 URL: https://issues.apache.org/jira/browse/HBASE-10261 Project: HBase Issue Type: Bug Components: IPC/RPC Affects Versions: 0.96.1.1 Environment: Centos hadoop2.2.0 protocbuf 2.5.0 Reporter: johnaz1 Fix For: 0.96.1.1 Attachments: errorlog.jpg I can start hbase in my hadoop-2.2.0 cluster -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Resolved] (HBASE-10261) HMaster can not connect to HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl resolved HBASE-10261. --- Resolution: Invalid Yeah, please ask on the mailing lists. You'll get more people to look at it that way, and other folks can benefit from the more public discussion as well. I am closing this issue. HMaster can not connect to HRegionServer Key: HBASE-10261 URL: https://issues.apache.org/jira/browse/HBASE-10261 Project: HBase Issue Type: Bug Components: IPC/RPC Affects Versions: 0.96.1.1 Environment: Centos hadoop2.2.0 protocbuf 2.5.0 Reporter: johnaz1 Fix For: 0.96.1.1 Attachments: errorlog.jpg I can start hbase in my hadoop-2.2.0 cluster -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10260) Canary Doesn't pick up Configuration properly.
[ https://issues.apache.org/jira/browse/HBASE-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859638#comment-13859638 ] stack commented on HBASE-10260: --- +1 Canary Doesn't pick up Configuration properly. -- Key: HBASE-10260 URL: https://issues.apache.org/jira/browse/HBASE-10260 Project: HBase Issue Type: Bug Components: util Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-10260-0.patch hbase-site.xml isn't picked up correctly when running the canary. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Comment Edited] (HBASE-10259) [0.94] Upgrade JUnit to 4.11
[ https://issues.apache.org/jira/browse/HBASE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859655#comment-13859655 ] Lars Hofhansl edited comment on HBASE-10259 at 12/31/13 8:11 PM: - Down to one test failire (with JDK7) https://builds.apache.org/job/hbase-junit-4.11/5/ TestMultiParallel#testFlushCommitsNoAbort (that might be a transient problem, though) was (Author: lhofhansl): Does to one test failire (with JDK7) https://builds.apache.org/job/hbase-junit-4.11/5/ TestMultiParallel#testFlushCommitsNoAbort (that might be a transient problem, though) [0.94] Upgrade JUnit to 4.11 Key: HBASE-10259 URL: https://issues.apache.org/jira/browse/HBASE-10259 Project: HBase Issue Type: Sub-task Reporter: Lars Hofhansl Fix For: 0.94.16 Attachments: 10259-v2.txt, 10259-v3.txt, 10259-v4.txt, 10259.txt Right now we're using a custom version it seems: 4.10-HBASE\-1. Let's upgrade that to 4.11. See parent for rationale. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10259) [0.94] Upgrade JUnit to 4.11
[ https://issues.apache.org/jira/browse/HBASE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859655#comment-13859655 ] Lars Hofhansl commented on HBASE-10259: --- Does to one test failire (with JDK7) https://builds.apache.org/job/hbase-junit-4.11/5/ TestMultiParallel#testFlushCommitsNoAbort (that might be a transient problem, though) [0.94] Upgrade JUnit to 4.11 Key: HBASE-10259 URL: https://issues.apache.org/jira/browse/HBASE-10259 Project: HBase Issue Type: Sub-task Reporter: Lars Hofhansl Fix For: 0.94.16 Attachments: 10259-v2.txt, 10259-v3.txt, 10259-v4.txt, 10259.txt Right now we're using a custom version it seems: 4.10-HBASE\-1. Let's upgrade that to 4.11. See parent for rationale. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10260) Canary Doesn't pick up Configuration properly.
[
https://issues.apache.org/jira/browse/HBASE-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859680#comment-13859680
]
Hadoop QA commented on HBASE-10260:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12620971/HBASE-10260-0.patch
against trunk revision .
ATTACHMENT ID: 12620971
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.client.TestAdmin.testCreateTableWithRegions(TestAdmin.java:622)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8311//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8311//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8311//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8311//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8311//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8311//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8311//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8311//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8311//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8311//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8311//console
This message is automatically generated.
Canary Doesn't pick up Configuration properly.
--
Key: HBASE-10260
URL: https://issues.apache.org/jira/browse/HBASE-10260
Project: HBase
Issue Type: Bug
Components: util
Affects Versions: 0.98.0, 0.99.0, 0.96.1.1
Reporter: Elliott Clark
Assignee: Elliott Clark
Attachments: HBASE-10260-0.patch
hbase-site.xml isn't picked up correctly when running the canary.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10262) provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL
[ https://issues.apache.org/jira/browse/HBASE-10262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859689#comment-13859689 ] Andrew Purtell commented on HBASE-10262: Rather than start a new discussion here, especially because it skips relevant information on the other issue, let's close this as duplicate and continue on HBASE-5923 provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL --- Key: HBASE-10262 URL: https://issues.apache.org/jira/browse/HBASE-10262 Project: HBase Issue Type: Improvement Reporter: Feng Honghua Assignee: Feng Honghua Attachments: HBASE-10262-trunk_v0.patch currently checkAndPut/checkAndDelete provided by HTable doesn't support full CompareOp other than CompareOp.EQUAL, which limits user/client from doing more flexible checkAndPut/checkAndDelete operation. this improvement fixes this limit by exposing additional checkAndPut/checkAndDelete API with full CompareOp support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10260) Canary Doesn't pick up Configuration properly.
[ https://issues.apache.org/jira/browse/HBASE-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859711#comment-13859711 ] Elliott Clark commented on HBASE-10260: --- TestAdmin passes locally 3 times in a row and I dont think there's any way this is related. Canary Doesn't pick up Configuration properly. -- Key: HBASE-10260 URL: https://issues.apache.org/jira/browse/HBASE-10260 Project: HBase Issue Type: Bug Components: util Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-10260-0.patch hbase-site.xml isn't picked up correctly when running the canary. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10262) provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL
[ https://issues.apache.org/jira/browse/HBASE-10262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-10262: -- Resolution: Duplicate Status: Resolved (was: Patch Available) Agreed. Closed as DUP. provide user/client checkAndPut/checkAndDelete API with full CompareOp rather than only CompareOp.EQUAL --- Key: HBASE-10262 URL: https://issues.apache.org/jira/browse/HBASE-10262 Project: HBase Issue Type: Improvement Reporter: Feng Honghua Assignee: Feng Honghua Attachments: HBASE-10262-trunk_v0.patch currently checkAndPut/checkAndDelete provided by HTable doesn't support full CompareOp other than CompareOp.EQUAL, which limits user/client from doing more flexible checkAndPut/checkAndDelete operation. this improvement fixes this limit by exposing additional checkAndPut/checkAndDelete API with full CompareOp support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10260) Canary Doesn't pick up Configuration properly.
[ https://issues.apache.org/jira/browse/HBASE-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-10260: -- Fix Version/s: 0.99.0 0.96.2 0.98.0 Canary Doesn't pick up Configuration properly. -- Key: HBASE-10260 URL: https://issues.apache.org/jira/browse/HBASE-10260 Project: HBase Issue Type: Bug Components: util Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.98.0, 0.96.2, 0.99.0 Attachments: HBASE-10260-0.patch hbase-site.xml isn't picked up correctly when running the canary. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10260) Canary Doesn't pick up Configuration properly.
[ https://issues.apache.org/jira/browse/HBASE-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-10260: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Canary Doesn't pick up Configuration properly. -- Key: HBASE-10260 URL: https://issues.apache.org/jira/browse/HBASE-10260 Project: HBase Issue Type: Bug Components: util Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.98.0, 0.96.2, 0.99.0 Attachments: HBASE-10260-0.patch hbase-site.xml isn't picked up correctly when running the canary. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-5923) Cleanup checkAndXXX logic
[
https://issues.apache.org/jira/browse/HBASE-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859713#comment-13859713
]
Lars Hofhansl commented on HBASE-5923:
--
So to reiterate the problem... If we allow LESS/GREATER, etc, we should also be
able to control the comparator used. If we wanted to simplify this is a bit, we
can also punt on that part for now and always use BinaryComparator for now.
Cleanup checkAndXXX logic
-
Key: HBASE-5923
URL: https://issues.apache.org/jira/browse/HBASE-5923
Project: HBase
Issue Type: Improvement
Components: Client, regionserver
Reporter: Lars Hofhansl
Labels: noob
Attachments: 5923-0.94.txt, 5923-trunk.txt
1. the checkAnd{Put|Delete} method that takes a CompareOP is not exposed via
HTable[Interface].
2. there is unnecessary duplicate code in the check{Put|Delete} code in
HRegionServer.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-8912) [0.94] AssignmentManager throws IllegalStateException from PENDING_OPEN to OFFLINE
[
https://issues.apache.org/jira/browse/HBASE-8912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859724#comment-13859724
]
Lars Hofhansl commented on HBASE-8912:
--
There layers of races here it seems.
With my fix not to abort the master a RegionServer can now get a new request
to open a region while is it attempting to transition the current attempt in
FAILE_OPEN in ZK. It then ignores that concurrent open request, and thus the
region will forever be stuck in PENDING_OPEN (unless the timeout manager kicks
in of course). The only reason that did not happen before was that the master
would just abort before it can reassign the region a second time.
When I fix that (by taking the region out of RITs before the znode is
transitioned) there is an NPE when trying to remove the HRI from the RITs
(which was hidden by missing the concurrent assign request before).
Terrible. I hope this is better in trunk after the AM rewrite. But since this
issue stems from backported code, I doubt it.
[0.94] AssignmentManager throws IllegalStateException from PENDING_OPEN to
OFFLINE
--
Key: HBASE-8912
URL: https://issues.apache.org/jira/browse/HBASE-8912
Project: HBase
Issue Type: Bug
Reporter: Enis Soztutar
Priority: Critical
Fix For: 0.94.16
Attachments: 8912-0.94-alt2.txt, 8912-0.94.txt, HBase-0.94 #1036 test
- testRetrying [Jenkins].html, log.txt,
org.apache.hadoop.hbase.catalog.TestMetaReaderEditor-output.txt
AM throws this exception which subsequently causes the master to abort:
{code}
java.lang.IllegalStateException: Unexpected state :
testRetrying,jjj,1372891751115.9b828792311001062a5ff4b1038fe33b.
state=PENDING_OPEN, ts=1372891751912,
server=hemera.apache.org,39064,1372891746132 .. Cannot transit it to OFFLINE.
at
org.apache.hadoop.hbase.master.AssignmentManager.setOfflineInZooKeeper(AssignmentManager.java:1879)
at
org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentManager.java:1688)
at
org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentManager.java:1424)
at
org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentManager.java:1399)
at
org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentManager.java:1394)
at
org.apache.hadoop.hbase.master.handler.ClosedRegionHandler.process(ClosedRegionHandler.java:105)
at
org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:175)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
at java.lang.Thread.run(Thread.java:662)
{code}
This exception trace is from the failing test TestMetaReaderEditor which is
failing pretty frequently, but looking at the test code, I think this is not
a test-only issue, but affects the main code path.
https://builds.apache.org/job/HBase-0.94/1036/testReport/junit/org.apache.hadoop.hbase.catalog/TestMetaReaderEditor/testRetrying/
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-8912) [0.94] AssignmentManager throws IllegalStateException from PENDING_OPEN to OFFLINE
[
https://issues.apache.org/jira/browse/HBASE-8912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859746#comment-13859746
]
Lars Hofhansl commented on HBASE-8912:
--
OK... The problem was that HRegionServer.removeFromRegionsInTransition does not
deal with the case when the region is not in regionsInTransitionInRS (it
returns boolean, but the result of the remove(...) is a Boolean, which could be
null).
With that I have good behavior in all cases - that I can reproduce - now. As in
0.94.5 the Master/RS continue to attempt to reassign the region (which always
fails in my case because I do not have snappy). So far it did that 1000's of
times and did not fail. If anything we might want to rate limit attempts to
assign the *same* region over and over again.
Will post a patch once SVN is back up.
[0.94] AssignmentManager throws IllegalStateException from PENDING_OPEN to
OFFLINE
--
Key: HBASE-8912
URL: https://issues.apache.org/jira/browse/HBASE-8912
Project: HBase
Issue Type: Bug
Reporter: Enis Soztutar
Priority: Critical
Fix For: 0.94.16
Attachments: 8912-0.94-alt2.txt, 8912-0.94.txt, HBase-0.94 #1036 test
- testRetrying [Jenkins].html, log.txt,
org.apache.hadoop.hbase.catalog.TestMetaReaderEditor-output.txt
AM throws this exception which subsequently causes the master to abort:
{code}
java.lang.IllegalStateException: Unexpected state :
testRetrying,jjj,1372891751115.9b828792311001062a5ff4b1038fe33b.
state=PENDING_OPEN, ts=1372891751912,
server=hemera.apache.org,39064,1372891746132 .. Cannot transit it to OFFLINE.
at
org.apache.hadoop.hbase.master.AssignmentManager.setOfflineInZooKeeper(AssignmentManager.java:1879)
at
org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentManager.java:1688)
at
org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentManager.java:1424)
at
org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentManager.java:1399)
at
org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentManager.java:1394)
at
org.apache.hadoop.hbase.master.handler.ClosedRegionHandler.process(ClosedRegionHandler.java:105)
at
org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:175)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
at java.lang.Thread.run(Thread.java:662)
{code}
This exception trace is from the failing test TestMetaReaderEditor which is
failing pretty frequently, but looking at the test code, I think this is not
a test-only issue, but affects the main code path.
https://builds.apache.org/job/HBase-0.94/1036/testReport/junit/org.apache.hadoop.hbase.catalog/TestMetaReaderEditor/testRetrying/
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Updated] (HBASE-8912) [0.94] AssignmentManager throws IllegalStateException from PENDING_OPEN to OFFLINE
[
https://issues.apache.org/jira/browse/HBASE-8912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lars Hofhansl updated HBASE-8912:
-
Attachment: 8912-fix-race.txt
8912-fix-race fixes all the races I could detect (from looking at the code and
running real tests).
This should be good to commit.
[0.94] AssignmentManager throws IllegalStateException from PENDING_OPEN to
OFFLINE
--
Key: HBASE-8912
URL: https://issues.apache.org/jira/browse/HBASE-8912
Project: HBase
Issue Type: Bug
Reporter: Enis Soztutar
Priority: Critical
Fix For: 0.94.16
Attachments: 8912-0.94-alt2.txt, 8912-0.94.txt, 8912-fix-race.txt,
HBase-0.94 #1036 test - testRetrying [Jenkins].html, log.txt,
org.apache.hadoop.hbase.catalog.TestMetaReaderEditor-output.txt
AM throws this exception which subsequently causes the master to abort:
{code}
java.lang.IllegalStateException: Unexpected state :
testRetrying,jjj,1372891751115.9b828792311001062a5ff4b1038fe33b.
state=PENDING_OPEN, ts=1372891751912,
server=hemera.apache.org,39064,1372891746132 .. Cannot transit it to OFFLINE.
at
org.apache.hadoop.hbase.master.AssignmentManager.setOfflineInZooKeeper(AssignmentManager.java:1879)
at
org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentManager.java:1688)
at
org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentManager.java:1424)
at
org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentManager.java:1399)
at
org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentManager.java:1394)
at
org.apache.hadoop.hbase.master.handler.ClosedRegionHandler.process(ClosedRegionHandler.java:105)
at
org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:175)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
at java.lang.Thread.run(Thread.java:662)
{code}
This exception trace is from the failing test TestMetaReaderEditor which is
failing pretty frequently, but looking at the test code, I think this is not
a test-only issue, but affects the main code path.
https://builds.apache.org/job/HBase-0.94/1036/testReport/junit/org.apache.hadoop.hbase.catalog/TestMetaReaderEditor/testRetrying/
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10260) Canary Doesn't pick up Configuration properly.
[ https://issues.apache.org/jira/browse/HBASE-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859789#comment-13859789 ] Hudson commented on HBASE-10260: SUCCESS: Integrated in HBase-TRUNK #4775 (See [https://builds.apache.org/job/HBase-TRUNK/4775/]) HBASE-10260 Canary Doesn't pick up Configuration properly. (eclark: rev 1554570) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java Canary Doesn't pick up Configuration properly. -- Key: HBASE-10260 URL: https://issues.apache.org/jira/browse/HBASE-10260 Project: HBase Issue Type: Bug Components: util Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.98.0, 0.96.2, 0.99.0 Attachments: HBASE-10260-0.patch hbase-site.xml isn't picked up correctly when running the canary. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10260) Canary Doesn't pick up Configuration properly.
[ https://issues.apache.org/jira/browse/HBASE-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859791#comment-13859791 ] Hudson commented on HBASE-10260: SUCCESS: Integrated in hbase-0.96 #246 (See [https://builds.apache.org/job/hbase-0.96/246/]) HBASE-10260 Canary Doesn't pick up Configuration properly. (eclark: rev 1554572) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java Canary Doesn't pick up Configuration properly. -- Key: HBASE-10260 URL: https://issues.apache.org/jira/browse/HBASE-10260 Project: HBase Issue Type: Bug Components: util Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.98.0, 0.96.2, 0.99.0 Attachments: HBASE-10260-0.patch hbase-site.xml isn't picked up correctly when running the canary. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10260) Canary Doesn't pick up Configuration properly.
[ https://issues.apache.org/jira/browse/HBASE-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859807#comment-13859807 ] Hudson commented on HBASE-10260: FAILURE: Integrated in hbase-0.96-hadoop2 #166 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/166/]) HBASE-10260 Canary Doesn't pick up Configuration properly. (eclark: rev 1554572) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java Canary Doesn't pick up Configuration properly. -- Key: HBASE-10260 URL: https://issues.apache.org/jira/browse/HBASE-10260 Project: HBase Issue Type: Bug Components: util Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.98.0, 0.96.2, 0.99.0 Attachments: HBASE-10260-0.patch hbase-site.xml isn't picked up correctly when running the canary. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10260) Canary Doesn't pick up Configuration properly.
[ https://issues.apache.org/jira/browse/HBASE-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859804#comment-13859804 ] Hudson commented on HBASE-10260: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #44 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/44/]) HBASE-10260 Canary Doesn't pick up Configuration properly. (eclark: rev 1554571) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java Canary Doesn't pick up Configuration properly. -- Key: HBASE-10260 URL: https://issues.apache.org/jira/browse/HBASE-10260 Project: HBase Issue Type: Bug Components: util Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.98.0, 0.96.2, 0.99.0 Attachments: HBASE-10260-0.patch hbase-site.xml isn't picked up correctly when running the canary. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859808#comment-13859808
]
Hudson commented on HBASE-7226:
---
FAILURE: Integrated in hbase-0.96-hadoop2 #166 (See
[https://builds.apache.org/job/hbase-0.96-hadoop2/166/])
HBASE-7226 HRegion.checkAndMutate uses incorrect comparison result for , =,
and = (tedyu: rev 1553712)
*
/hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
*
/hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.98.0, 0.94.16, 0.96.2, 0.99.0
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10213) Add read log size per second metrics for replication source
[ https://issues.apache.org/jira/browse/HBASE-10213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859805#comment-13859805 ] Hudson commented on HBASE-10213: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #44 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/44/]) HBASE-10213. Add read log size per second metrics for replication source (cuijianwei) (apurtell: rev 1554359) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSource.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java Add read log size per second metrics for replication source --- Key: HBASE-10213 URL: https://issues.apache.org/jira/browse/HBASE-10213 Project: HBase Issue Type: Improvement Components: metrics, Replication Affects Versions: 0.94.14 Reporter: cuijianwei Assignee: cuijianwei Priority: Minor Fix For: 0.98.0, 0.99.0 Attachments: 10213-trunk-addendum-1.patch, HBASE-10213-0.94-v1.patch, HBASE-10213-0.94-v2.patch, HBASE-10213-trunk-v1.patch The current metrics of replication source contain logEditsReadRate, shippedBatchesRate, etc, which could indicate how fast the data replicated to peer cluster to some extent. However, it is not clear enough to know how many bytes replicating to peer cluster from these metrics. In production environment, it may be important to know the size of replicating data per second because the services may be affected if the network become busy. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10260) Canary Doesn't pick up Configuration properly.
[ https://issues.apache.org/jira/browse/HBASE-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859810#comment-13859810 ] Hudson commented on HBASE-10260: SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #32 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/32/]) HBASE-10260 Canary Doesn't pick up Configuration properly. (eclark: rev 1554570) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java Canary Doesn't pick up Configuration properly. -- Key: HBASE-10260 URL: https://issues.apache.org/jira/browse/HBASE-10260 Project: HBase Issue Type: Bug Components: util Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.98.0, 0.96.2, 0.99.0 Attachments: HBASE-10260-0.patch hbase-site.xml isn't picked up correctly when running the canary. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10259) [0.94] Upgrade JUnit to 4.11
[ https://issues.apache.org/jira/browse/HBASE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859812#comment-13859812 ] Lars Hofhansl commented on HBASE-10259: --- Got a successful run with JDK7: https://builds.apache.org/job/hbase-junit-4.11/7/ [0.94] Upgrade JUnit to 4.11 Key: HBASE-10259 URL: https://issues.apache.org/jira/browse/HBASE-10259 Project: HBase Issue Type: Sub-task Reporter: Lars Hofhansl Fix For: 0.94.16 Attachments: 10259-v2.txt, 10259-v3.txt, 10259-v4.txt, 10259.txt Right now we're using a custom version it seems: 4.10-HBASE\-1. Let's upgrade that to 4.11. See parent for rationale. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10260) Canary Doesn't pick up Configuration properly.
[ https://issues.apache.org/jira/browse/HBASE-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859813#comment-13859813 ] Hudson commented on HBASE-10260: FAILURE: Integrated in HBase-0.98 #47 (See [https://builds.apache.org/job/HBase-0.98/47/]) HBASE-10260 Canary Doesn't pick up Configuration properly. (eclark: rev 1554571) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java Canary Doesn't pick up Configuration properly. -- Key: HBASE-10260 URL: https://issues.apache.org/jira/browse/HBASE-10260 Project: HBase Issue Type: Bug Components: util Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.98.0, 0.96.2, 0.99.0 Attachments: HBASE-10260-0.patch hbase-site.xml isn't picked up correctly when running the canary. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10259) [0.94] Upgrade JUnit to 4.11
[ https://issues.apache.org/jira/browse/HBASE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859815#comment-13859815 ] Liang Xie commented on HBASE-10259: --- cl:) [0.94] Upgrade JUnit to 4.11 Key: HBASE-10259 URL: https://issues.apache.org/jira/browse/HBASE-10259 Project: HBase Issue Type: Sub-task Reporter: Lars Hofhansl Fix For: 0.94.16 Attachments: 10259-v2.txt, 10259-v3.txt, 10259-v4.txt, 10259.txt Right now we're using a custom version it seems: 4.10-HBASE\-1. Let's upgrade that to 4.11. See parent for rationale. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-6104) Require EXEC permission to call coprocessor endpoints
[ https://issues.apache.org/jira/browse/HBASE-6104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859814#comment-13859814 ] James Taylor commented on HBASE-6104: - Does this effect only end point coprocessors? If so, we have two end point coprocessors: 1) For issuing DDL statements. Probably not a bad idea to have to require an extra grant for a user to do this. The only exception might be still allowing users to create a tenant-specific table for a multi-tenant base table. 2) For sending region server level cache information, as there's no good way to do this from a region observer coprocessor (see https://issues.apache.org/jira/browse/HBASE-9291). This is used for both joins (for broadcasting the hash join cache to each region server) plus for secondary indexing (to pass along the index metadata for index row building, so we don't have to attach this information to every single Put/Delete). Requiring additional security to be able to do joins and/or use secondary indexing is not good. How about a fix for HBASE-9291 so that we could tack along attributes to go with the mutation on a per region server basis, [~andrew.purt...@gmail.com]? Require EXEC permission to call coprocessor endpoints - Key: HBASE-6104 URL: https://issues.apache.org/jira/browse/HBASE-6104 Project: HBase Issue Type: New Feature Components: Coprocessors, security Reporter: Gary Helmling Assignee: Andrew Purtell Fix For: 0.99.0 Attachments: 6104-addendum-1.patch, 6104-revert.patch, 6104.patch, 6104.patch, 6104.patch, 6104.patch, 6104.patch, 6104.patch The EXEC action currently exists as only a placeholder in access control. It should really be used to enforce access to coprocessor endpoint RPC calls, which are currently unrestricted. How the ACLs to support this would be modeled deserves some discussion: * Should access be scoped to a specific table and CoprocessorProtocol extension? * Should it be possible to grant access to a CoprocessorProtocol implementation globally (regardless of table)? * Are per-method restrictions necessary? * Should we expose hooks available to endpoint implementors so that they could additionally apply their own permission checks? Some CP endpoints may want to require READ permissions, others may want to enforce WRITE, or READ + WRITE. To apply these kinds of checks we would also have to extend the RegionObserver interface to provide hooks wrapping HRegion.exec(). -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10256) Handling of value argument being null for checkAndDelete
[ https://issues.apache.org/jira/browse/HBASE-10256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859816#comment-13859816 ] James Taylor commented on HBASE-10256: -- Another deficiency of this API - there's no way to specify the TimeRange that is used for the Get. Any operation that does a Get underneath (checkAndDelete, checkAndPut, Increment, IncrementColumnValue), should allow for a TimeRange to be passed through (Increment already supports this). Handling of value argument being null for checkAndDelete Key: HBASE-10256 URL: https://issues.apache.org/jira/browse/HBASE-10256 Project: HBase Issue Type: Improvement Reporter: James Taylor IMO, it would be more useful if when a null is supplied as the value for checkAndDelete, that it add the Delete marker if the row exists rather than if it doesn't exist (i.e. the opposite of checkAndPut). I think the most common use case for checkAndDelete is to delete a row if it exists and tell me that you deleted it. With the current implementation, it adds a Delete marker only if the row does not exist when you supply a null value which IMO is not very useful. My workaround is to add another known KeyValue to my row with a fixed value and then call checkAndDelete passing in this known value. Also, FWIW, if an empty byte array is passed through (a valid value), it treats it the same as if null was passed through, which is another separate bug. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10256) Handling of value argument being null for checkAndDelete
[ https://issues.apache.org/jira/browse/HBASE-10256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859818#comment-13859818 ] Lars Hofhansl commented on HBASE-10256: --- Maybe the right solution is to just hand over a Get request. That can be setup with timerange, Filter, etc. If the Get returns anything update that row otherwise don't. (And now I'm on my way to a new year's party :) ) Handling of value argument being null for checkAndDelete Key: HBASE-10256 URL: https://issues.apache.org/jira/browse/HBASE-10256 Project: HBase Issue Type: Improvement Reporter: James Taylor IMO, it would be more useful if when a null is supplied as the value for checkAndDelete, that it add the Delete marker if the row exists rather than if it doesn't exist (i.e. the opposite of checkAndPut). I think the most common use case for checkAndDelete is to delete a row if it exists and tell me that you deleted it. With the current implementation, it adds a Delete marker only if the row does not exist when you supply a null value which IMO is not very useful. My workaround is to add another known KeyValue to my row with a fixed value and then call checkAndDelete passing in this known value. Also, FWIW, if an empty byte array is passed through (a valid value), it treats it the same as if null was passed through, which is another separate bug. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (HBASE-10264) [MapReduce]: CompactionTool in mapred mode is missing classes in its classpath
Aleksandr Shulman created HBASE-10264:
-
Summary: [MapReduce]: CompactionTool in mapred mode is missing
classes in its classpath
Key: HBASE-10264
URL: https://issues.apache.org/jira/browse/HBASE-10264
Project: HBase
Issue Type: Bug
Components: Compaction, mapreduce
Affects Versions: 0.98.0, 0.99.0
Reporter: Aleksandr Shulman
Assignee: Himanshu Vashishtha
Calling o.a.h.h.regionserver.CompactionTool fails due to classpath-related
issues in both MRv1 and MRv2.
{code}hbase org.apache.hadoop.hbase.regionserver.CompactionTool -mapred -major
hdfs://`hostname`:8020/hbase/data/default/orig_1388179858868{code}
Results:
{code}2013-12-27 13:31:49,478 INFO [main] mapreduce.Job: Task Id :
attempt_1388179525649_0011_m_00_2, Status : FAILED
Error: java.lang.ClassNotFoundException:
org.apache.hadoop.hbase.TableInfoMissingException
at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at
org.apache.hadoop.hbase.regionserver.CompactionTool$CompactionWorker.compact(CompactionTool.java:115)
at
org.apache.hadoop.hbase.regionserver.CompactionTool$CompactionMapper.map(CompactionTool.java:231)
at
org.apache.hadoop.hbase.regionserver.CompactionTool$CompactionMapper.map(CompactionTool.java:207)
at org.apache.hadoop.mapreduce.Mapper.run(Mapper.java:145)
at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:764)
at org.apache.hadoop.mapred.MapTask.run(MapTask.java:340)
at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:165)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:415)
at
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1499)
at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:160){code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10256) Handling of value argument being null for checkAndDelete
[ https://issues.apache.org/jira/browse/HBASE-10256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859845#comment-13859845 ] James Taylor commented on HBASE-10256: -- One other change that would be useful. Instead of returning a boolean return a Long with null meaning that check failed and otherwise the Long represents the timestamp of the Delete (or Put). This conveys more information, as Phoenix caches based on the timestamp of the mutation. If we can get the actual timestamp (in the case where HConstants.LATEST_TIMESTAMP was used in the Delete/Put), then knowing the server timestamp is useful information. Without this, an extra round trip ends up being required later. FWIW, I've been able to work around all these issues with region observers which is really nice. It's just more work than it needs to be, though. Plus I'm not sure perf-wise if my Get/Put in the region observer will perform as well as the other methods (I suspect it's probably equivalent, though). Happy New Years! Handling of value argument being null for checkAndDelete Key: HBASE-10256 URL: https://issues.apache.org/jira/browse/HBASE-10256 Project: HBase Issue Type: Improvement Reporter: James Taylor IMO, it would be more useful if when a null is supplied as the value for checkAndDelete, that it add the Delete marker if the row exists rather than if it doesn't exist (i.e. the opposite of checkAndPut). I think the most common use case for checkAndDelete is to delete a row if it exists and tell me that you deleted it. With the current implementation, it adds a Delete marker only if the row does not exist when you supply a null value which IMO is not very useful. My workaround is to add another known KeyValue to my row with a fixed value and then call checkAndDelete passing in this known value. Also, FWIW, if an empty byte array is passed through (a valid value), it treats it the same as if null was passed through, which is another separate bug. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
