[jira] [Updated] (HBASE-5923) Cleanup checkAndXXX logic
[ https://issues.apache.org/jira/browse/HBASE-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-5923: -- Status: Patch Available (was: Open) Cleanup checkAndXXX logic - Key: HBASE-5923 URL: https://issues.apache.org/jira/browse/HBASE-5923 Project: HBase Issue Type: Improvement Components: Client, regionserver Reporter: Lars Hofhansl Labels: noob Attachments: 5923-0.94.txt, 5923-trunk.txt, HBASE-10262-trunk_v0.patch 1. the checkAnd{Put|Delete} method that takes a CompareOP is not exposed via HTable[Interface]. 2. there is unnecessary duplicate code in the check{Put|Delete} code in HRegionServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9941) The context ClassLoader isn't set while calling into a coprocessor
[ https://issues.apache.org/jira/browse/HBASE-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862256#comment-13862256 ] Hudson commented on HBASE-9941: --- FAILURE: Integrated in HBase-TRUNK #4788 (See [https://builds.apache.org/job/HBase-TRUNK/4788/]) HBASE-9941. The context ClassLoader isn't set while calling into a coprocessor (apurtell: rev 1555328) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/CoprocessorEnvironment.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java The context ClassLoader isn't set while calling into a coprocessor -- Key: HBASE-9941 URL: https://issues.apache.org/jira/browse/HBASE-9941 Project: HBase Issue Type: Sub-task Components: Coprocessors Affects Versions: 0.96.0 Reporter: Benoit Sigoure Assignee: Andrew Purtell Fix For: 0.98.0, 0.99.0 Attachments: 9941.patch, 9941.patch, 9941.patch, 9941.patch, 9941.patch Whenever one of the methods of a coprocessor is invoked, the context {{ClassLoader}} isn't set to be the {{CoprocessorClassLoader}}. It's only set properly when calling the coprocessor's {{start}} method. This means that if the coprocessor code attempts to load classes using the context {{ClassLoader}}, it will fail to find the classes it's looking for. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9941) The context ClassLoader isn't set while calling into a coprocessor
[ https://issues.apache.org/jira/browse/HBASE-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862258#comment-13862258 ] Hudson commented on HBASE-9941: --- SUCCESS: Integrated in HBase-0.98 #57 (See [https://builds.apache.org/job/HBase-0.98/57/]) HBASE-9941. The context ClassLoader isn't set while calling into a coprocessor (apurtell: rev 1555329) * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/CoprocessorEnvironment.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java The context ClassLoader isn't set while calling into a coprocessor -- Key: HBASE-9941 URL: https://issues.apache.org/jira/browse/HBASE-9941 Project: HBase Issue Type: Sub-task Components: Coprocessors Affects Versions: 0.96.0 Reporter: Benoit Sigoure Assignee: Andrew Purtell Fix For: 0.98.0, 0.99.0 Attachments: 9941.patch, 9941.patch, 9941.patch, 9941.patch, 9941.patch Whenever one of the methods of a coprocessor is invoked, the context {{ClassLoader}} isn't set to be the {{CoprocessorClassLoader}}. It's only set properly when calling the coprocessor's {{start}} method. This means that if the coprocessor code attempts to load classes using the context {{ClassLoader}}, it will fail to find the classes it's looking for. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9941) The context ClassLoader isn't set while calling into a coprocessor
[ https://issues.apache.org/jira/browse/HBASE-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862266#comment-13862266 ] Hudson commented on HBASE-9941: --- SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #53 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/53/]) HBASE-9941. The context ClassLoader isn't set while calling into a coprocessor (apurtell: rev 1555329) * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/CoprocessorEnvironment.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java The context ClassLoader isn't set while calling into a coprocessor -- Key: HBASE-9941 URL: https://issues.apache.org/jira/browse/HBASE-9941 Project: HBase Issue Type: Sub-task Components: Coprocessors Affects Versions: 0.96.0 Reporter: Benoit Sigoure Assignee: Andrew Purtell Fix For: 0.98.0, 0.99.0 Attachments: 9941.patch, 9941.patch, 9941.patch, 9941.patch, 9941.patch Whenever one of the methods of a coprocessor is invoked, the context {{ClassLoader}} isn't set to be the {{CoprocessorClassLoader}}. It's only set properly when calling the coprocessor's {{start}} method. This means that if the coprocessor code attempts to load classes using the context {{ClassLoader}}, it will fail to find the classes it's looking for. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-5923) Cleanup checkAndXXX logic
[ https://issues.apache.org/jira/browse/HBASE-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862276#comment-13862276 ] Hadoop QA commented on HBASE-5923: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12621027/HBASE-10262-trunk_v0.patch against trunk revision . ATTACHMENT ID: 12621027 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop 1.1 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:red}-1 release audit{color}. The applied patch generated 4 release audit warnings (more than the trunk's current 0 warnings). {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 site{color}. The patch appears to cause mvn site goal to fail. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8340//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8340//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8340//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8340//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8340//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8340//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8340//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8340//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8340//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8340//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8340//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8340//console This message is automatically generated. Cleanup checkAndXXX logic - Key: HBASE-5923 URL: https://issues.apache.org/jira/browse/HBASE-5923 Project: HBase Issue Type: Improvement Components: Client, regionserver Reporter: Lars Hofhansl Labels: noob Attachments: 5923-0.94.txt, 5923-trunk.txt, HBASE-10262-trunk_v0.patch 1. the checkAnd{Put|Delete} method that takes a CompareOP is not exposed via HTable[Interface]. 2. there is unnecessary duplicate code in the check{Put|Delete} code in HRegionServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10272) Cluster becomes nonoperational if the node hosting the active Master AND ROOT/META table goes offline
[ https://issues.apache.org/jira/browse/HBASE-10272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862286#comment-13862286 ] Hudson commented on HBASE-10272: SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #41 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/41/]) HBASE-10272 Cluster becomes nonoperational if the node hosting the active Master AND ROOT/META table goes offline (Tedyu: rev 1555312) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java Cluster becomes nonoperational if the node hosting the active Master AND ROOT/META table goes offline - Key: HBASE-10272 URL: https://issues.apache.org/jira/browse/HBASE-10272 Project: HBase Issue Type: Bug Components: IPC/RPC Affects Versions: 0.96.1, 0.94.15 Reporter: Aditya Kishore Assignee: Aditya Kishore Priority: Critical Fix For: 0.98.0, 0.99.0 Attachments: HBASE-10272.patch, HBASE-10272_0.94.patch Since HBASE-6364, HBase client caches a connection failure to a server and any subsequent attempt to connect to the server throws a {{FailedServerException}} Now if a node which hosted the active Master AND ROOT/META table goes offline, the newly anointed Master's initial attempt to connect to the dead region server will fail with {{NoRouteToHostException}} which it handles but since on second attempt crashes with {{FailedServerException}} Here is the log from one such occurance {noformat} 2013-11-20 10:58:00,161 FATAL org.apache.hadoop.hbase.master.HMaster: Master server abort: loaded coprocessors are: [] 2013-11-20 10:58:00,161 FATAL org.apache.hadoop.hbase.master.HMaster: Unhandled exception. Starting shutdown. org.apache.hadoop.hbase.ipc.HBaseClient$FailedServerException: This server is in the failed servers list: xxx02/192.168.1.102:60020 at org.apache.hadoop.hbase.ipc.HBaseClient$Connection.setupIOstreams(HBaseClient.java:425) at org.apache.hadoop.hbase.ipc.HBaseClient.getConnection(HBaseClient.java:1124) at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:974) at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:86) at $Proxy9.getProtocolVersion(Unknown Source) at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:138) at org.apache.hadoop.hbase.ipc.HBaseRPC.waitForProxy(HBaseRPC.java:208) at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getHRegionConnection(HConnectionManager.java:1335) at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getHRegionConnection(HConnectionManager.java:1294) at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getHRegionConnection(HConnectionManager.java:1281) at org.apache.hadoop.hbase.catalog.CatalogTracker.getCachedConnection(CatalogTracker.java:506) at org.apache.hadoop.hbase.catalog.CatalogTracker.getMetaServerConnection(CatalogTracker.java:383) at org.apache.hadoop.hbase.catalog.CatalogTracker.waitForMeta(CatalogTracker.java:445) at org.apache.hadoop.hbase.catalog.CatalogTracker.waitForMetaServerConnection(CatalogTracker.java:464) at org.apache.hadoop.hbase.catalog.CatalogTracker.verifyMetaRegionLocation(CatalogTracker.java:624) at org.apache.hadoop.hbase.master.HMaster.assignRootAndMeta(HMaster.java:684) at org.apache.hadoop.hbase.master.HMaster.finishInitialization(HMaster.java:560) at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:376) at java.lang.Thread.run(Thread.java:662) 2013-11-20 10:58:00,162 INFO org.apache.hadoop.hbase.master.HMaster: Aborting 2013-11-20 10:58:00,162 INFO org.apache.hadoop.ipc.HBaseServer: Stopping server on 6 {noformat} Each of the backup master will crash with same error and restarting them will have the same effect. Once this happens, the cluster will remain in-operational until the node with region server is brought online (or the Zookeeper node containing the root region server and/or META entry from the ROOT table is deleted). -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9977) Define C interface of HBase Client Asynchronous APIs
[ https://issues.apache.org/jira/browse/HBASE-9977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862285#comment-13862285 ] Hudson commented on HBASE-9977: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #41 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/41/]) HBASE-9977 Define C interface of HBase Client Asynchronous APIs (eclark: rev 1555272) * /hbase/trunk/hbase-native-client * /hbase/trunk/hbase-native-client/.gitignore * /hbase/trunk/hbase-native-client/CMakeLists.txt * /hbase/trunk/hbase-native-client/README.md * /hbase/trunk/hbase-native-client/bin * /hbase/trunk/hbase-native-client/bin/build-all.sh * /hbase/trunk/hbase-native-client/bin/build-thirdparty.sh * /hbase/trunk/hbase-native-client/bin/download-thirdparty.sh * /hbase/trunk/hbase-native-client/bin/hbase-client-env.sh * /hbase/trunk/hbase-native-client/cmake_modules * /hbase/trunk/hbase-native-client/cmake_modules/FindGTest.cmake * /hbase/trunk/hbase-native-client/cmake_modules/FindLibEv.cmake * /hbase/trunk/hbase-native-client/src * /hbase/trunk/hbase-native-client/src/async * /hbase/trunk/hbase-native-client/src/async/CMakeLists.txt * /hbase/trunk/hbase-native-client/src/async/get-test.cc * /hbase/trunk/hbase-native-client/src/async/hbase_admin.cc * /hbase/trunk/hbase-native-client/src/async/hbase_admin.h * /hbase/trunk/hbase-native-client/src/async/hbase_client.cc * /hbase/trunk/hbase-native-client/src/async/hbase_client.h * /hbase/trunk/hbase-native-client/src/async/hbase_connection.cc * /hbase/trunk/hbase-native-client/src/async/hbase_connection.h * /hbase/trunk/hbase-native-client/src/async/hbase_errno.h * /hbase/trunk/hbase-native-client/src/async/hbase_get.cc * /hbase/trunk/hbase-native-client/src/async/hbase_get.h * /hbase/trunk/hbase-native-client/src/async/hbase_mutations.cc * /hbase/trunk/hbase-native-client/src/async/hbase_mutations.h * /hbase/trunk/hbase-native-client/src/async/hbase_result.cc * /hbase/trunk/hbase-native-client/src/async/hbase_result.h * /hbase/trunk/hbase-native-client/src/async/hbase_scanner.cc * /hbase/trunk/hbase-native-client/src/async/hbase_scanner.h * /hbase/trunk/hbase-native-client/src/async/mutations-test.cc * /hbase/trunk/hbase-native-client/src/core * /hbase/trunk/hbase-native-client/src/core/CMakeLists.txt * /hbase/trunk/hbase-native-client/src/core/admin.cc * /hbase/trunk/hbase-native-client/src/core/admin.h * /hbase/trunk/hbase-native-client/src/core/client.cc * /hbase/trunk/hbase-native-client/src/core/client.h * /hbase/trunk/hbase-native-client/src/core/connection.cc * /hbase/trunk/hbase-native-client/src/core/connection.h * /hbase/trunk/hbase-native-client/src/core/connection_attr.h * /hbase/trunk/hbase-native-client/src/core/delete.cc * /hbase/trunk/hbase-native-client/src/core/delete.h * /hbase/trunk/hbase-native-client/src/core/get.cc * /hbase/trunk/hbase-native-client/src/core/get.h * /hbase/trunk/hbase-native-client/src/core/hbase_connection_attr.cc * /hbase/trunk/hbase-native-client/src/core/hbase_connection_attr.h * /hbase/trunk/hbase-native-client/src/core/hbase_macros.h * /hbase/trunk/hbase-native-client/src/core/hbase_types.h * /hbase/trunk/hbase-native-client/src/core/mutation.cc * /hbase/trunk/hbase-native-client/src/core/mutation.h * /hbase/trunk/hbase-native-client/src/core/put.cc * /hbase/trunk/hbase-native-client/src/core/put.h * /hbase/trunk/hbase-native-client/src/core/scanner.cc * /hbase/trunk/hbase-native-client/src/core/scanner.h * /hbase/trunk/hbase-native-client/src/rpc * /hbase/trunk/hbase-native-client/src/rpc/CMakeLists.txt * /hbase/trunk/hbase-native-client/src/sync * /hbase/trunk/hbase-native-client/src/sync/CMakeLists.txt * /hbase/trunk/hbase-native-client/src/sync/hbase_admin.cc * /hbase/trunk/hbase-native-client/src/sync/hbase_admin.h * /hbase/trunk/hbase-native-client/src/sync/hbase_connection.cc * /hbase/trunk/hbase-native-client/src/sync/hbase_connection.h Define C interface of HBase Client Asynchronous APIs Key: HBASE-9977 URL: https://issues.apache.org/jira/browse/HBASE-9977 Project: HBase Issue Type: Sub-task Components: Client Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.99.0 Attachments: HBASE-9977-0.patch, HBASE-9977-1.patch, HBASE-9977-2.patch, HBASE-9977-3.patch, HBASE-9977-4.patch, HBASE-9977-5.patch -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9941) The context ClassLoader isn't set while calling into a coprocessor
[ https://issues.apache.org/jira/browse/HBASE-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862288#comment-13862288 ] Hudson commented on HBASE-9941: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #41 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/41/]) HBASE-9941. The context ClassLoader isn't set while calling into a coprocessor (apurtell: rev 1555328) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/CoprocessorEnvironment.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java The context ClassLoader isn't set while calling into a coprocessor -- Key: HBASE-9941 URL: https://issues.apache.org/jira/browse/HBASE-9941 Project: HBase Issue Type: Sub-task Components: Coprocessors Affects Versions: 0.96.0 Reporter: Benoit Sigoure Assignee: Andrew Purtell Fix For: 0.98.0, 0.99.0 Attachments: 9941.patch, 9941.patch, 9941.patch, 9941.patch, 9941.patch Whenever one of the methods of a coprocessor is invoked, the context {{ClassLoader}} isn't set to be the {{CoprocessorClassLoader}}. It's only set properly when calling the coprocessor's {{start}} method. This means that if the coprocessor code attempts to load classes using the context {{ClassLoader}}, it will fail to find the classes it's looking for. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10210) during master startup, RS can be you-are-dead-ed by master in error
[ https://issues.apache.org/jira/browse/HBASE-10210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862287#comment-13862287 ] Hudson commented on HBASE-10210: SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #41 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/41/]) HBASE-10210 during master startup, RS can be you-are-dead-ed by master in error (sershe: rev 1555275) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManagerOnCluster.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java during master startup, RS can be you-are-dead-ed by master in error --- Key: HBASE-10210 URL: https://issues.apache.org/jira/browse/HBASE-10210 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.1, 0.99.0, 0.96.1.1 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.98.0, 0.99.0 Attachments: HBASE-10210.01.patch, HBASE-10210.02.patch, HBASE-10210.03.patch, HBASE-10210.04.patch, HBASE-10210.05.patch, HBASE-10210.patch Not sure of the root cause yet, I am at how did this ever work stage. We see this problem in 0.96.1, but didn't in 0.96.0 + some patches. It looks like RS information arriving from 2 sources - ZK and server itself, can conflict. Master doesn't handle such cases (timestamp match), and anyway technically timestamps can collide for two separate servers. So, master YouAreDead-s the already-recorded reporting RS, and adds it too. Then it discovers that the new server has died with fatal error! Note the threads. Addition is called from master initialization and from RPC. {noformat} 2013-12-19 11:16:45,290 INFO [master:h2-ubuntu12-sec-1387431063-hbase-10:6] master.ServerManager: Finished waiting for region servers count to settle; checked in 2, slept for 18262 ms, expecting minimum of 1, maximum of 2147483647, master is running. 2013-12-19 11:16:45,290 INFO [master:h2-ubuntu12-sec-1387431063-hbase-10:6] master.ServerManager: Registering server=h2-ubuntu12-sec-1387431063-hbase-8.cs1cloud.internal,60020,1387451803800 2013-12-19 11:16:45,290 INFO [master:h2-ubuntu12-sec-1387431063-hbase-10:6] master.HMaster: Registered server found up in zk but who has not yet reported in: h2-ubuntu12-sec-1387431063-hbase-8.cs1cloud.internal,60020,1387451803800 2013-12-19 11:16:45,380 INFO [RpcServer.handler=4,port=6] master.ServerManager: Triggering server recovery; existingServer h2-ubuntu12-sec-1387431063-hbase-8.cs1cloud.internal,60020,1387451803800 looks stale, new server:h2-ubuntu12-sec-1387431063-hbase-8.cs1cloud.internal,60020,1387451803800 2013-12-19 11:16:45,380 INFO [RpcServer.handler=4,port=6] master.ServerManager: Master doesn't enable ServerShutdownHandler during initialization, delay expiring server h2-ubuntu12-sec-1387431063-hbase-8.cs1cloud.internal,60020,1387451803800 ... 2013-12-19 11:16:46,925 ERROR [RpcServer.handler=7,port=6] master.HMaster: Region server h2-ubuntu12-sec-1387431063-hbase-8.cs1cloud.internal,60020,1387451803800 reported a fatal error: ABORTING region server h2-ubuntu12-sec-1387431063-hbase-8.cs1cloud.internal,60020,1387451803800: org.apache.hadoop.hbase.YouAreDeadException: Server REPORT rejected; currently processing h2-ubuntu12-sec-1387431063-hbase-8.cs1cloud.internal,60020,1387451803800 as dead server {noformat} Presumably some of the recent ZK listener related changes b -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-5923) Cleanup checkAndXXX logic
[ https://issues.apache.org/jira/browse/HBASE-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862315#comment-13862315 ] Ted Yu commented on HBASE-5923: --- Ran the failed test locally and it passed. Release audit was not caused by this patch. Integrated to trunk. Cleanup checkAndXXX logic - Key: HBASE-5923 URL: https://issues.apache.org/jira/browse/HBASE-5923 Project: HBase Issue Type: Improvement Components: Client, regionserver Reporter: Lars Hofhansl Labels: noob Attachments: 5923-0.94.txt, 5923-trunk.txt, HBASE-10262-trunk_v0.patch 1. the checkAnd{Put|Delete} method that takes a CompareOP is not exposed via HTable[Interface]. 2. there is unnecessary duplicate code in the check{Put|Delete} code in HRegionServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-5923) Cleanup checkAndXXX logic
[ https://issues.apache.org/jira/browse/HBASE-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-5923: -- Fix Version/s: 0.99.0 Assignee: Feng Honghua Hadoop Flags: Reviewed Cleanup checkAndXXX logic - Key: HBASE-5923 URL: https://issues.apache.org/jira/browse/HBASE-5923 Project: HBase Issue Type: Improvement Components: Client, regionserver Reporter: Lars Hofhansl Assignee: Feng Honghua Labels: noob Fix For: 0.99.0 Attachments: 5923-0.94.txt, 5923-trunk.txt, HBASE-10262-trunk_v0.patch 1. the checkAnd{Put|Delete} method that takes a CompareOP is not exposed via HTable[Interface]. 2. there is unnecessary duplicate code in the check{Put|Delete} code in HRegionServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-5923) Cleanup checkAndXXX logic
[ https://issues.apache.org/jira/browse/HBASE-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862353#comment-13862353 ] Hudson commented on HBASE-5923: --- SUCCESS: Integrated in HBase-TRUNK #4790 (See [https://builds.apache.org/job/HBase-TRUNK/4790/]) HBASE-5923 Cleanup checkAndXXX logic (Tedyu: rev 1555351) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java Cleanup checkAndXXX logic - Key: HBASE-5923 URL: https://issues.apache.org/jira/browse/HBASE-5923 Project: HBase Issue Type: Improvement Components: Client, regionserver Reporter: Lars Hofhansl Assignee: Feng Honghua Labels: noob Fix For: 0.99.0 Attachments: 5923-0.94.txt, 5923-trunk.txt, HBASE-10262-trunk_v0.patch 1. the checkAnd{Put|Delete} method that takes a CompareOP is not exposed via HTable[Interface]. 2. there is unnecessary duplicate code in the check{Put|Delete} code in HRegionServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-5923) Cleanup checkAndXXX logic
[ https://issues.apache.org/jira/browse/HBASE-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862397#comment-13862397 ] Hudson commented on HBASE-5923: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #42 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/42/]) HBASE-5923 Cleanup checkAndXXX logic (Tedyu: rev 1555351) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java Cleanup checkAndXXX logic - Key: HBASE-5923 URL: https://issues.apache.org/jira/browse/HBASE-5923 Project: HBase Issue Type: Improvement Components: Client, regionserver Reporter: Lars Hofhansl Assignee: Feng Honghua Labels: noob Fix For: 0.99.0 Attachments: 5923-0.94.txt, 5923-trunk.txt, HBASE-10262-trunk_v0.patch 1. the checkAnd{Put|Delete} method that takes a CompareOP is not exposed via HTable[Interface]. 2. there is unnecessary duplicate code in the check{Put|Delete} code in HRegionServer. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10268) [JDK6] TestSplitLogWorker occasionally fails
[ https://issues.apache.org/jira/browse/HBASE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862407#comment-13862407 ] Andrew Purtell commented on HBASE-10268: The order of test file executions differ a bit by filesystem and kernel version - this is due to how readdir() works. The test doesn't fail on its own. I may have a system 'uniquely' suited to reproducing this. What about this test would be sensitive to another hanging around for a bit? [JDK6] TestSplitLogWorker occasionally fails Key: HBASE-10268 URL: https://issues.apache.org/jira/browse/HBASE-10268 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.99.0 Environment: 64-bit JDK 6 (Java(TM) SE Runtime Environment (build 1.6.0_43-b01) HotSpot(TM) 64-Bit Server VM (build 20.14-b01, mixed mode)) on Ubuntu 12 Reporter: Andrew Purtell Fix For: 0.98.0, 0.99.0 TestSplitLogWorker failed in 10% of 50 runs of the 0.98 branch test suite, but only when using JDK 6 on Ubuntu 12. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (HBASE-10281) TestMultiParallel.testFlushCommitsNoAbort fails frequently in 0.94
Lars Hofhansl created HBASE-10281: - Summary: TestMultiParallel.testFlushCommitsNoAbort fails frequently in 0.94 Key: HBASE-10281 URL: https://issues.apache.org/jira/browse/HBASE-10281 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Here's a run (with JDK7, but I've seen it with 0.96 as well). https://builds.apache.org/job/HBase-0.94-JDK7/17/testReport/junit/org.apache.hadoop.hbase.client/TestMultiParallel/testFlushCommitsNoAbort/ {code} Error Message Count of regions=10 Stacktrace java.lang.AssertionError: Count of regions=10 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.assertTrue(Assert.java:41) at org.apache.hadoop.hbase.client.TestMultiParallel.doTestFlushCommits(TestMultiParallel.java:289) at org.apache.hadoop.hbase.client.TestMultiParallel.testFlushCommitsNoAbort(TestMultiParallel.java:222) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74) {code} This might be a side-effect of: HBASE-10259 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10281) TestMultiParallel.testFlushCommitsNoAbort fails frequently in 0.94
[ https://issues.apache.org/jira/browse/HBASE-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-10281: -- Description: Here's a run (with JDK7, but I've seen it with 0.96 as well). https://builds.apache.org/job/HBase-0.94-JDK7/17/testReport/junit/org.apache.hadoop.hbase.client/TestMultiParallel/testFlushCommitsNoAbort/ {code} Error Message Count of regions=10 Stacktrace java.lang.AssertionError: Count of regions=10 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.assertTrue(Assert.java:41) at org.apache.hadoop.hbase.client.TestMultiParallel.doTestFlushCommits(TestMultiParallel.java:289) at org.apache.hadoop.hbase.client.TestMultiParallel.testFlushCommitsNoAbort(TestMultiParallel.java:222) ... {code} This might be a side-effect of: HBASE-10259 was: Here's a run (with JDK7, but I've seen it with 0.96 as well). https://builds.apache.org/job/HBase-0.94-JDK7/17/testReport/junit/org.apache.hadoop.hbase.client/TestMultiParallel/testFlushCommitsNoAbort/ {code} Error Message Count of regions=10 Stacktrace java.lang.AssertionError: Count of regions=10 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.assertTrue(Assert.java:41) at org.apache.hadoop.hbase.client.TestMultiParallel.doTestFlushCommits(TestMultiParallel.java:289) at org.apache.hadoop.hbase.client.TestMultiParallel.testFlushCommitsNoAbort(TestMultiParallel.java:222) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74) {code} This might be a side-effect of: HBASE-10259 TestMultiParallel.testFlushCommitsNoAbort fails frequently in 0.94 -- Key: HBASE-10281 URL: https://issues.apache.org/jira/browse/HBASE-10281 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Here's a run (with JDK7, but I've seen it with 0.96 as well). https://builds.apache.org/job/HBase-0.94-JDK7/17/testReport/junit/org.apache.hadoop.hbase.client/TestMultiParallel/testFlushCommitsNoAbort/ {code} Error Message Count of regions=10 Stacktrace java.lang.AssertionError: Count of regions=10 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.assertTrue(Assert.java:41) at org.apache.hadoop.hbase.client.TestMultiParallel.doTestFlushCommits(TestMultiParallel.java:289) at org.apache.hadoop.hbase.client.TestMultiParallel.testFlushCommitsNoAbort(TestMultiParallel.java:222) ... {code} This might be a side-effect of: HBASE-10259 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Assigned] (HBASE-10274) MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers
[ https://issues.apache.org/jira/browse/HBASE-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chendihao reassigned HBASE-10274: - Assignee: chendihao MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers --- Key: HBASE-10274 URL: https://issues.apache.org/jira/browse/HBASE-10274 Project: HBase Issue Type: Bug Affects Versions: 0.94.3 Reporter: chendihao Assignee: chendihao Priority: Minor HBASE-6820 points out the problem but not fix completely. killCurrentActiveZooKeeperServer() and killOneBackupZooKeeperServer() will shutdown the ZooKeeperServer and need to close ZKDatabase as well. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10274) MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers
[ https://issues.apache.org/jira/browse/HBASE-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chendihao updated HBASE-10274: -- Status: Patch Available (was: Open) MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers --- Key: HBASE-10274 URL: https://issues.apache.org/jira/browse/HBASE-10274 Project: HBase Issue Type: Bug Affects Versions: 0.94.3 Reporter: chendihao Assignee: chendihao Priority: Minor HBASE-6820 points out the problem but not fix completely. killCurrentActiveZooKeeperServer() and killOneBackupZooKeeperServer() will shutdown the ZooKeeperServer and need to close ZKDatabase as well. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10274) MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers
[ https://issues.apache.org/jira/browse/HBASE-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chendihao updated HBASE-10274: -- Attachment: HBASE-10274-0.94-v1.patch patch for 0.94 MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers --- Key: HBASE-10274 URL: https://issues.apache.org/jira/browse/HBASE-10274 Project: HBase Issue Type: Bug Affects Versions: 0.94.3 Reporter: chendihao Assignee: chendihao Priority: Minor Attachments: HBASE-10274-0.94-v1.patch, HBASE-10274-truck-v1.patch HBASE-6820 points out the problem but not fix completely. killCurrentActiveZooKeeperServer() and killOneBackupZooKeeperServer() will shutdown the ZooKeeperServer and need to close ZKDatabase as well. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10274) MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers
[ https://issues.apache.org/jira/browse/HBASE-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chendihao updated HBASE-10274: -- Attachment: HBASE-10274-truck-v1.patch patch for trunk MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers --- Key: HBASE-10274 URL: https://issues.apache.org/jira/browse/HBASE-10274 Project: HBase Issue Type: Bug Affects Versions: 0.94.3 Reporter: chendihao Assignee: chendihao Priority: Minor Attachments: HBASE-10274-0.94-v1.patch, HBASE-10274-truck-v1.patch HBASE-6820 points out the problem but not fix completely. killCurrentActiveZooKeeperServer() and killOneBackupZooKeeperServer() will shutdown the ZooKeeperServer and need to close ZKDatabase as well. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10274) MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers
[ https://issues.apache.org/jira/browse/HBASE-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862501#comment-13862501 ] chendihao commented on HBASE-10274: --- BTW, the patch of HBASE-6820 is not committed in 0.94. Can you confirm this? [~enis] MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers --- Key: HBASE-10274 URL: https://issues.apache.org/jira/browse/HBASE-10274 Project: HBase Issue Type: Bug Affects Versions: 0.94.3 Reporter: chendihao Assignee: chendihao Priority: Minor Attachments: HBASE-10274-0.94-v1.patch, HBASE-10274-truck-v1.patch HBASE-6820 points out the problem but not fix completely. killCurrentActiveZooKeeperServer() and killOneBackupZooKeeperServer() will shutdown the ZooKeeperServer and need to close ZKDatabase as well. -- This message was sent by Atlassian JIRA (v6.1.5#6160)