[jira] [Commented] (HBASE-11650) Write hbase.id to a temporary location and move into place
[ https://issues.apache.org/jira/browse/HBASE-11650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083360#comment-14083360 ] Hudson commented on HBASE-11650: FAILURE: Integrated in HBase-TRUNK #5364 (See [https://builds.apache.org/job/HBase-TRUNK/5364/]) HBASE-11650 Write hbase.id to a temporary location and move into place (apurtell: rev 543c64d2e9d2fc608ef65cafd485a910d4b8d480) * hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java > Write hbase.id to a temporary location and move into place > -- > > Key: HBASE-11650 > URL: https://issues.apache.org/jira/browse/HBASE-11650 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: HBASE-11650.patch > > > We should write hbase.id to a temporary location and move it into place. Will > avoid potential race issues between create and write. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083361#comment-14083361 ] Hudson commented on HBASE-11640: FAILURE: Integrated in HBase-TRUNK #5364 (See [https://builds.apache.org/job/HBase-TRUNK/5364/]) HBASE-11640 Add syntax highlighting support to HBase Ref Guide programlistings ADDENDUM (stack: rev db15d6e6a7d8c0448c7791a634ce2b97806a4bb8) * pom.xml > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch, Screen > Shot 2014-08-02 at 9.19.24 am.png > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11632) Region split needs to clear force split flag at the end of SplitRequest run
[
https://issues.apache.org/jira/browse/HBASE-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083359#comment-14083359
]
Hudson commented on HBASE-11632:
FAILURE: Integrated in HBase-TRUNK #5364 (See
[https://builds.apache.org/job/HBase-TRUNK/5364/])
HBASE-11632 Region split needs to clear force split flag at the end of
SplitRequest run (Jerry He) (tedyu: rev
eb79a4358029653817ddf8bee0dde392c3368ecb)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> Region split needs to clear force split flag at the end of SplitRequest run
> ---
>
> Key: HBASE-11632
> URL: https://issues.apache.org/jira/browse/HBASE-11632
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.99.0, 0.98.4
>Reporter: Jerry He
>Assignee: Jerry He
>Priority: Minor
> Fix For: 0.99.0, 0.98.5, 2.0.0
>
> Attachments: HBASE-11632-master-v2.patch, HBASE-11632-master.patch,
> HBASE-11632-v2-0.98.patch
>
>
> force split flag is used when a user requests region split and specifies a
> split key.
> {code}
> region.forceSplit(splitPoint);
> {code}
> We need to clear force split flag at the end of SplitRequest run. If the
> region split is successful, this parent region will go away and there is no
> need to clear this flag. But we will have problem when the split is not
> successful or rejected. Here is the case:
> 1. User requested region split at rownkey-n.
> 2. We set forceSplit in the region with rownkey-n.
> 3. The split request got rejected because the region had references.
> 4. After a while, there was a system request split for the same region.
> 5. The region would use forceSplit and rownkey-n to split. What should have
> happened is that the region split is done based on system split policy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11650) Write hbase.id to a temporary location and move into place
[ https://issues.apache.org/jira/browse/HBASE-11650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083353#comment-14083353 ] Hudson commented on HBASE-11650: SUCCESS: Integrated in HBase-0.98 #433 (See [https://builds.apache.org/job/HBase-0.98/433/]) HBASE-11650 Write hbase.id to a temporary location and move into place (apurtell: rev 43ab9979a5f496b2a1d9132d14bbadff7dd950a0) * hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java > Write hbase.id to a temporary location and move into place > -- > > Key: HBASE-11650 > URL: https://issues.apache.org/jira/browse/HBASE-11650 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: HBASE-11650.patch > > > We should write hbase.id to a temporary location and move it into place. Will > avoid potential race issues between create and write. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11651) Add conf which disables MetaMigrationConvertingToPB check (for experts only)
[ https://issues.apache.org/jira/browse/HBASE-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083354#comment-14083354 ] Hudson commented on HBASE-11651: SUCCESS: Integrated in HBase-0.98 #433 (See [https://builds.apache.org/job/HBase-0.98/433/]) HBASE-11651 Add conf which disables MetaMigrationConvertingToPB check (for experts only) (stack: rev dfef20ed4f0b327673538d76eb3cb2fd79cb4a7d) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java > Add conf which disables MetaMigrationConvertingToPB check (for experts only) > > > Key: HBASE-11651 > URL: https://issues.apache.org/jira/browse/HBASE-11651 > Project: HBase > Issue Type: Sub-task > Components: master >Reporter: stack >Assignee: stack > Fix For: 0.99.0, 0.98.5 > > Attachments: 11651.txt > > > Up in parent issue, Virag wants to avoid expensive scan on startup. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (HBASE-11641) TestDistributedLogSplitting.testMasterStartsUpWithLogSplittingWork fails frequently
[ https://issues.apache.org/jira/browse/HBASE-11641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl resolved HBASE-11641. --- Resolution: Later > TestDistributedLogSplitting.testMasterStartsUpWithLogSplittingWork fails > frequently > --- > > Key: HBASE-11641 > URL: https://issues.apache.org/jira/browse/HBASE-11641 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl > Attachments: 11641-logs.txt > > > 3 out of last four run of my RC jenkins build failed in this test. > Might be related to HBASE-11041 too. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11641) TestDistributedLogSplitting.testMasterStartsUpWithLogSplittingWork fails frequently
[ https://issues.apache.org/jira/browse/HBASE-11641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083336#comment-14083336 ] Lars Hofhansl commented on HBASE-11641: --- Let's see if HBASE-11652 fixes this. > TestDistributedLogSplitting.testMasterStartsUpWithLogSplittingWork fails > frequently > --- > > Key: HBASE-11641 > URL: https://issues.apache.org/jira/browse/HBASE-11641 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl > Attachments: 11641-logs.txt > > > 3 out of last four run of my RC jenkins build failed in this test. > Might be related to HBASE-11041 too. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (HBASE-11652) Port HBASE-3270 and HBASE-11650 to 0.94 - create cluster id and version file in a tmp location and move it into place
[ https://issues.apache.org/jira/browse/HBASE-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl resolved HBASE-11652. --- Resolution: Fixed Hadoop Flags: Reviewed Committed. Thanks for taking a look. > Port HBASE-3270 and HBASE-11650 to 0.94 - create cluster id and version file > in a tmp location and move it into place > - > > Key: HBASE-11652 > URL: https://issues.apache.org/jira/browse/HBASE-11652 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl >Priority: Minor > Fix For: 0.94.23 > > Attachments: 11652.txt > > > See HBASE-3270 and HBASE-11650 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11651) Add conf which disables MetaMigrationConvertingToPB check (for experts only)
[ https://issues.apache.org/jira/browse/HBASE-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083328#comment-14083328 ] Hudson commented on HBASE-11651: FAILURE: Integrated in HBase-1.0 #82 (See [https://builds.apache.org/job/HBase-1.0/82/]) HBASE-11651 Add conf which disables MetaMigrationConvertingToPB check (for experts only) (stack: rev 4d272fa5ee6c18e0be62b3b0e8adbfa7ddc9c210) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java > Add conf which disables MetaMigrationConvertingToPB check (for experts only) > > > Key: HBASE-11651 > URL: https://issues.apache.org/jira/browse/HBASE-11651 > Project: HBase > Issue Type: Sub-task > Components: master >Reporter: stack >Assignee: stack > Fix For: 0.99.0, 0.98.5 > > Attachments: 11651.txt > > > Up in parent issue, Virag wants to avoid expensive scan on startup. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11632) Region split needs to clear force split flag at the end of SplitRequest run
[
https://issues.apache.org/jira/browse/HBASE-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083326#comment-14083326
]
Hudson commented on HBASE-11632:
FAILURE: Integrated in HBase-1.0 #82 (See
[https://builds.apache.org/job/HBase-1.0/82/])
HBASE-11632 Region split needs to clear force split flag at the end of
SplitRequest run (Jerry He) (tedyu: rev
9db8ecba746498573e9885d86f8be6bbdb77f78a)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
> Region split needs to clear force split flag at the end of SplitRequest run
> ---
>
> Key: HBASE-11632
> URL: https://issues.apache.org/jira/browse/HBASE-11632
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.99.0, 0.98.4
>Reporter: Jerry He
>Assignee: Jerry He
>Priority: Minor
> Fix For: 0.99.0, 0.98.5, 2.0.0
>
> Attachments: HBASE-11632-master-v2.patch, HBASE-11632-master.patch,
> HBASE-11632-v2-0.98.patch
>
>
> force split flag is used when a user requests region split and specifies a
> split key.
> {code}
> region.forceSplit(splitPoint);
> {code}
> We need to clear force split flag at the end of SplitRequest run. If the
> region split is successful, this parent region will go away and there is no
> need to clear this flag. But we will have problem when the split is not
> successful or rejected. Here is the case:
> 1. User requested region split at rownkey-n.
> 2. We set forceSplit in the region with rownkey-n.
> 3. The split request got rejected because the region had references.
> 4. After a while, there was a system request split for the same region.
> 5. The region would use forceSplit and rownkey-n to split. What should have
> happened is that the region split is done based on system split policy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11650) Write hbase.id to a temporary location and move into place
[ https://issues.apache.org/jira/browse/HBASE-11650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083327#comment-14083327 ] Hudson commented on HBASE-11650: FAILURE: Integrated in HBase-1.0 #82 (See [https://builds.apache.org/job/HBase-1.0/82/]) HBASE-11650 Write hbase.id to a temporary location and move into place (apurtell: rev ec5a859b92f2f7177801f7b686759362172dc6c3) * hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java > Write hbase.id to a temporary location and move into place > -- > > Key: HBASE-11650 > URL: https://issues.apache.org/jira/browse/HBASE-11650 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: HBASE-11650.patch > > > We should write hbase.id to a temporary location and move it into place. Will > avoid potential race issues between create and write. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083321#comment-14083321 ] Hudson commented on HBASE-11516: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #408 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/408/]) HBASE-11516 Track time spent in executing coprocessors in each region - addendum for hadoop-1 (tedyu: rev e02698c52dcfc7f9a2a7c41b9294a138c31ebc5c) * hbase-hadoop1-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java > Track time spent in executing coprocessors in each region. > -- > > Key: HBASE-11516 > URL: https://issues.apache.org/jira/browse/HBASE-11516 > Project: HBase > Issue Type: Improvement > Components: Coprocessors >Affects Versions: 0.98.4 >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: 11516-0.98.addendum, HBASE-11516.patch, > HBASE-11516_v2.patch, HBASE-11516_v3.patch, HBASE-11516_v4.patch, > HBASE-11516_v4_master.patch, HBASE-11516_v5.patch, region_server_webui.png, > rs_web_ui_v2.png, rs_web_ui_v5.png > > > Currently, the time spent in executing coprocessors is not yet being tracked. > This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11651) Add conf which disables MetaMigrationConvertingToPB check (for experts only)
[ https://issues.apache.org/jira/browse/HBASE-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083323#comment-14083323 ] Hudson commented on HBASE-11651: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #408 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/408/]) HBASE-11651 Add conf which disables MetaMigrationConvertingToPB check (for experts only) (stack: rev dfef20ed4f0b327673538d76eb3cb2fd79cb4a7d) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java > Add conf which disables MetaMigrationConvertingToPB check (for experts only) > > > Key: HBASE-11651 > URL: https://issues.apache.org/jira/browse/HBASE-11651 > Project: HBase > Issue Type: Sub-task > Components: master >Reporter: stack >Assignee: stack > Fix For: 0.99.0, 0.98.5 > > Attachments: 11651.txt > > > Up in parent issue, Virag wants to avoid expensive scan on startup. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11650) Write hbase.id to a temporary location and move into place
[ https://issues.apache.org/jira/browse/HBASE-11650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083320#comment-14083320 ] Hudson commented on HBASE-11650: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #408 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/408/]) HBASE-11650 Write hbase.id to a temporary location and move into place (apurtell: rev 43ab9979a5f496b2a1d9132d14bbadff7dd950a0) * hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java > Write hbase.id to a temporary location and move into place > -- > > Key: HBASE-11650 > URL: https://issues.apache.org/jira/browse/HBASE-11650 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: HBASE-11650.patch > > > We should write hbase.id to a temporary location and move it into place. Will > avoid potential race issues between create and write. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11653) RegionObserver coprocessor cannot override KeyValue values in prePut()
[
https://issues.apache.org/jira/browse/HBASE-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083318#comment-14083318
]
Gary Helmling commented on HBASE-11653:
---
I've attached a proposed simple fix for {{internalPut()}}. Since all the
remaining usage of {{HRegion.put(Put)}} seems to be for testing, another option
would be to remove {{internalPut()}} and switch to using {{batchMutate()}} for
the single put case.
> RegionObserver coprocessor cannot override KeyValue values in prePut()
> --
>
> Key: HBASE-11653
> URL: https://issues.apache.org/jira/browse/HBASE-11653
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
>Affects Versions: 0.94.21
>Reporter: Gary Helmling
>Assignee: Gary Helmling
>Priority: Minor
> Attachments: HBASE-11653_0.94.patch
>
>
> Due to a bug in {{HRegion.internalPut()}}, any modifications that a
> {{RegionObserver}} makes to a Put's family map in the {{prePut()}} hook are
> lost.
> This prevents coprocessors from modifying the values written by a {{Put}}.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-11653) RegionObserver coprocessor cannot override KeyValue values in prePut()
[
https://issues.apache.org/jira/browse/HBASE-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Helmling updated HBASE-11653:
--
Attachment: HBASE-11653_0.94.patch
Attaching a patch with a trivial fix for HRegion.internalPut(), plus a test
case to exercise the error.
> RegionObserver coprocessor cannot override KeyValue values in prePut()
> --
>
> Key: HBASE-11653
> URL: https://issues.apache.org/jira/browse/HBASE-11653
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
>Affects Versions: 0.94.21
>Reporter: Gary Helmling
>Assignee: Gary Helmling
>Priority: Minor
> Attachments: HBASE-11653_0.94.patch
>
>
> Due to a bug in {{HRegion.internalPut()}}, any modifications that a
> {{RegionObserver}} makes to a Put's family map in the {{prePut()}} hook are
> lost.
> This prevents coprocessors from modifying the values written by a {{Put}}.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-11653) RegionObserver coprocessor cannot override KeyValue values in prePut()
[
https://issues.apache.org/jira/browse/HBASE-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Helmling updated HBASE-11653:
--
Status: Patch Available (was: Open)
> RegionObserver coprocessor cannot override KeyValue values in prePut()
> --
>
> Key: HBASE-11653
> URL: https://issues.apache.org/jira/browse/HBASE-11653
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
>Affects Versions: 0.94.21
>Reporter: Gary Helmling
>Assignee: Gary Helmling
>Priority: Minor
> Attachments: HBASE-11653_0.94.patch
>
>
> Due to a bug in {{HRegion.internalPut()}}, any modifications that a
> {{RegionObserver}} makes to a Put's family map in the {{prePut()}} hook are
> lost.
> This prevents coprocessors from modifying the values written by a {{Put}}.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[
https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083297#comment-14083297
]
Anoop Sam John commented on HBASE-11438:
{quote}
Use this if any of the unicode characters are to be used
+ * as visibility expressions and characters like '"','\','&','|','!' etc
{quote}
Use this if unicode characters to be used in expression or special characters
like '(', ')', '"','\','&','|','!'.
Same update at quote(byte[] auth) also.
Visibility label validation logic has to include the logic of skipping the
valid char check when the chars are enclosed wih quotes (?) Do we use this
validation for labels during addLabel() , during Mutation writes and for labels
in Authorizations?
Missing a test case where addLabel and then the Mutation write with labels
having special boolean operators with a label itself. - Single label A
& (B | C)
{code}
+case DOUBLE_QUOTES:
+ int labelOffset = ++index;
+ // We have to rewrite the expression within double quotes as incase
of expressions
+ // with escape characters we may have to avoid them as the original
expression did
+ // not have them
+ List list = new ArrayList();
+ while (index < endPos && !endDoubleQuotesFound(exp[index])) {
+if (exp[index] == '\\') {
+ index++;
+ if (exp[index] != '\\' && exp[index] != '"')
+throw new ParseException("invalid escaping with quotes " +
expS + " at column : "
++ index);
+}
+list.add(exp[index]);
+index++;
}
{code}
Why to have a List of Bytes and then do array convert and then String creation?
Instead just track the begin and end offset and finally create the String
using this 2 offset.
{code}
-if (VisibilityLabelsValidator.isValidLabel(label)) {
- if (this.visibilityManager.getLabelOrdinal(labelStr) > 0) {
-RegionActionResult.Builder failureResultBuilder =
RegionActionResult.newBuilder();
-failureResultBuilder.setException(ResponseConverter
-.buildException(new LabelAlreadyExistsException("Label '" +
labelStr
-+ "' already exists")));
-response.addResult(failureResultBuilder.build());
- } else {
-Put p = new Put(Bytes.toBytes(ordinalCounter));
-p.addImmutable(
-LABELS_TABLE_FAMILY, LABEL_QUALIFIER, label,
LABELS_TABLE_TAGS);
-if (LOG.isDebugEnabled()) {
- LOG.debug("Adding the label "+labelStr);
-}
-puts.add(p);
-ordinalCounter++;
-response.addResult(successResult);
- }
-} else {
+if (this.visibilityManager.getLabelOrdinal(labelStr) > 0) {
RegionActionResult.Builder failureResultBuilder =
RegionActionResult.newBuilder();
failureResultBuilder.setException(ResponseConverter
- .buildException(new InvalidLabelException("Invalid visibility
label '" + labelStr
- + "'")));
+ .buildException(new LabelAlreadyExistsException("Label '" +
labelStr
+ + "' already exists")));
response.addResult(failureResultBuilder.build());
{code}
Where else do we do this validation then?
> [Visibility Controller] Support UTF8 character as Visibility Labels
> ---
>
> Key: HBASE-11438
> URL: https://issues.apache.org/jira/browse/HBASE-11438
> Project: HBase
> Issue Type: Improvement
> Components: security
>Affects Versions: 0.98.4
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.98.5
>
> Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch,
> HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch,
> HBASE-11438_v6.patch, HBASE-11438_v7.patch
>
>
> This would be an action item that we would be addressing so that the
> visibility labels could have UTF8 characters in them. Also allow the user to
> use a client supplied API that allows to specify the visibility labels inside
> double quotes such that UTF8 characters and cases like &, |, ! and double
> quotes itself could be specified with proper escape sequence. Accumulo too
> provides one such API in the client side.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11599) BloomFilterFactory.IO_STOREFILE_DELETEFAMILY_BLOOM_ENABLED is never used
[ https://issues.apache.org/jira/browse/HBASE-11599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083291#comment-14083291 ] Ranjana Rajendran commented on HBASE-11599: --- IO_STOREFILE_DELETEFAMILY_BLOOM_ENABLED is set to the string "io.storefile.delete.family.bloom.enabled". I do not see any place that the value of this variable is set to false. Yet, there is a function isDeleteFamilyBloomEnabled(Configuration conf) which checks the value of this variable to be true. This function is called at one place to decide to log a debug message and return from a function without continuing. > BloomFilterFactory.IO_STOREFILE_DELETEFAMILY_BLOOM_ENABLED is never used > > > Key: HBASE-11599 > URL: https://issues.apache.org/jira/browse/HBASE-11599 > Project: HBase > Issue Type: Bug >Affects Versions: 1.0.0, 0.94.21, 0.98.4, 2.0.0 >Reporter: Jean-Marc Spaggiari >Priority: Minor > Labels: newbie > > BloomFilterFactory.IO_STOREFILE_DELETEFAMILY_BLOOM_ENABLED is not used > anywhere. I think we should clean it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083274#comment-14083274 ] Anoop Sam John commented on HBASE-11438: Sure. Started reading the patch. Will report back comments, if any, by today > [Visibility Controller] Support UTF8 character as Visibility Labels > --- > > Key: HBASE-11438 > URL: https://issues.apache.org/jira/browse/HBASE-11438 > Project: HBase > Issue Type: Improvement > Components: security >Affects Versions: 0.98.4 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.98.5 > > Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, > HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, > HBASE-11438_v6.patch, HBASE-11438_v7.patch > > > This would be an action item that we would be addressing so that the > visibility labels could have UTF8 characters in them. Also allow the user to > use a client supplied API that allows to specify the visibility labels inside > double quotes such that UTF8 characters and cases like &, |, ! and double > quotes itself could be specified with proper escape sequence. Accumulo too > provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083272#comment-14083272 ] Hudson commented on HBASE-11516: SUCCESS: Integrated in HBase-0.98 #432 (See [https://builds.apache.org/job/HBase-0.98/432/]) HBASE-11516 Track time spent in executing coprocessors in each region - addendum for hadoop-1 (tedyu: rev e02698c52dcfc7f9a2a7c41b9294a138c31ebc5c) * hbase-hadoop1-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java > Track time spent in executing coprocessors in each region. > -- > > Key: HBASE-11516 > URL: https://issues.apache.org/jira/browse/HBASE-11516 > Project: HBase > Issue Type: Improvement > Components: Coprocessors >Affects Versions: 0.98.4 >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: 11516-0.98.addendum, HBASE-11516.patch, > HBASE-11516_v2.patch, HBASE-11516_v3.patch, HBASE-11516_v4.patch, > HBASE-11516_v4_master.patch, HBASE-11516_v5.patch, region_server_webui.png, > rs_web_ui_v2.png, rs_web_ui_v5.png > > > Currently, the time spent in executing coprocessors is not yet being tracked. > This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11632) Region split needs to clear force split flag at the end of SplitRequest run
[
https://issues.apache.org/jira/browse/HBASE-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083271#comment-14083271
]
Hudson commented on HBASE-11632:
SUCCESS: Integrated in HBase-0.98 #432 (See
[https://builds.apache.org/job/HBase-0.98/432/])
HBASE-11632 Region split needs to clear force split flag at the end of
SplitRequest run (Jerry He) (tedyu: rev
f2fef2d39a8c69c56ed4ca9c0a52b86d7eb2d03a)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
> Region split needs to clear force split flag at the end of SplitRequest run
> ---
>
> Key: HBASE-11632
> URL: https://issues.apache.org/jira/browse/HBASE-11632
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.99.0, 0.98.4
>Reporter: Jerry He
>Assignee: Jerry He
>Priority: Minor
> Fix For: 0.99.0, 0.98.5, 2.0.0
>
> Attachments: HBASE-11632-master-v2.patch, HBASE-11632-master.patch,
> HBASE-11632-v2-0.98.patch
>
>
> force split flag is used when a user requests region split and specifies a
> split key.
> {code}
> region.forceSplit(splitPoint);
> {code}
> We need to clear force split flag at the end of SplitRequest run. If the
> region split is successful, this parent region will go away and there is no
> need to clear this flag. But we will have problem when the split is not
> successful or rejected. Here is the case:
> 1. User requested region split at rownkey-n.
> 2. We set forceSplit in the region with rownkey-n.
> 3. The split request got rejected because the region had references.
> 4. After a while, there was a system request split for the same region.
> 5. The region would use forceSplit and rownkey-n to split. What should have
> happened is that the region split is done based on system split policy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11331) [blockcache] lazy block decompression
[ https://issues.apache.org/jira/browse/HBASE-11331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083268#comment-14083268 ] Nick Dimiduk commented on HBASE-11331: -- Looks like the lack of compressor reuse is a known issue, somewhere between HBASE-5881, HBASE-7435, and HADOOP-9171. > [blockcache] lazy block decompression > - > > Key: HBASE-11331 > URL: https://issues.apache.org/jira/browse/HBASE-11331 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk > Attachments: HBASE-11331.00.patch, HBASE-11331.01.patch, > HBASE-11331.02.patch, HBASE-11331LazyBlockDecompressperfcompare.pdf > > > Maintaining data in its compressed form in the block cache will greatly > increase our effective blockcache size and should show a meaning improvement > in cache hit rates in well designed applications. The idea here is to lazily > decompress/decrypt blocks when they're consumed, rather than as soon as > they're pulled off of disk. > This is related to but less invasive than HBASE-8894. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-11653) RegionObserver coprocessor cannot override KeyValue values in prePut()
[
https://issues.apache.org/jira/browse/HBASE-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Helmling updated HBASE-11653:
--
Priority: Minor (was: Critical)
Since this only applies to {{HRegion.internalPut()}}, which is not triggered by
normal client actions (they instead go through {{HRegion.put(Put[])}} which
calls {{batchMutate()}}, this is only a minor issue.
> RegionObserver coprocessor cannot override KeyValue values in prePut()
> --
>
> Key: HBASE-11653
> URL: https://issues.apache.org/jira/browse/HBASE-11653
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
>Affects Versions: 0.94.21
>Reporter: Gary Helmling
>Assignee: Gary Helmling
>Priority: Minor
>
> Due to a bug in {{HRegion.internalPut()}}, any modifications that a
> {{RegionObserver}} makes to a Put's family map in the {{prePut()}} hook are
> lost.
> This prevents coprocessors from modifying the values written by a {{Put}}.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11650) Write hbase.id to a temporary location and move into place
[
https://issues.apache.org/jira/browse/HBASE-11650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083260#comment-14083260
]
Hadoop QA commented on HBASE-11650:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12659272/HBASE-11650.patch
against trunk revision .
ATTACHMENT ID: 12659272
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestPerTableCFReplication
org.apache.hadoop.hbase.client.TestReplicasClient
org.apache.hadoop.hbase.master.TestRestartCluster
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
org.apache.hadoop.hbase.TestRegionRebalancing
org.apache.hadoop.hbase.regionserver.TestRegionReplicas
org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas
org.apache.hadoop.hbase.TestIOFencing
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10270//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10270//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10270//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10270//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10270//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10270//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10270//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10270//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10270//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10270//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10270//console
This message is automatically generated.
> Write hbase.id to a temporary location and move into place
> --
>
> Key: HBASE-11650
> URL: https://issues.apache.org/jira/browse/HBASE-11650
> Project: HBase
> Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 0.99.0, 0.98.5, 2.0.0
>
> Attachments: HBASE-11650.patch
>
>
> We should write hbase.id to a temporary location and move it into place. Will
> avoid potential race issues between create and write.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[
https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083255#comment-14083255
]
Hadoop QA commented on HBASE-11640:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12659271/HBASE-11640_pom.patch
against trunk revision .
ATTACHMENT ID: 12659271
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation patch that doesn't require tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10271//console
This message is automatically generated.
> Add syntax highlighting support to HBase Ref Guide programlistings
> --
>
> Key: HBASE-11640
> URL: https://issues.apache.org/jira/browse/HBASE-11640
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Misty Stanley-Jones
>Assignee: Misty Stanley-Jones
> Fix For: 2.0.0
>
> Attachments: HBASE-11640-add_highlighting_support.patch,
> HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch, Screen
> Shot 2014-08-02 at 9.19.24 am.png
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-9741) Remove hbase.regions.slop from hbase-default.xml
[ https://issues.apache.org/jira/browse/HBASE-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ranjana Rajendran updated HBASE-9741: - Attachment: HBASE-9741-v3.patch The parameter hbase.regions.slop is being used in several places. If the default value of this parameter is not set, it is set to a specific value in those functions. Removing the default value for this parameter however does not seem meaningful. HConstants.java sets the string LOAD_BALANCER_SLOP_KEY to "hbase.regions.slop" as a final value. This patch modifies all the calls to get the value of hbase.regions.slop to use HConstants. LOAD_BALANCER_SLOP_KEY. > Remove hbase.regions.slop from hbase-default.xml > > > Key: HBASE-9741 > URL: https://issues.apache.org/jira/browse/HBASE-9741 > Project: HBase > Issue Type: Bug >Reporter: Elliott Clark > Labels: noob > Attachments: HBASE-9741-v0.patch, HBASE-9741-v1.patch, > HBASE-9741-v3.patch > > > Different balancers have different slop default values. We should remove > hbase.regions.slop from hbase-default.xml -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (HBASE-11653) RegionObserver coprocessor cannot override KeyValue values in prePut()
Gary Helmling created HBASE-11653:
-
Summary: RegionObserver coprocessor cannot override KeyValue
values in prePut()
Key: HBASE-11653
URL: https://issues.apache.org/jira/browse/HBASE-11653
Project: HBase
Issue Type: Bug
Components: Coprocessors
Affects Versions: 0.94.21
Reporter: Gary Helmling
Assignee: Gary Helmling
Priority: Critical
Due to a bug in {{HRegion.internalPut()}}, any modifications that a
{{RegionObserver}} makes to a Put's family map in the {{prePut()}} hook are
lost.
This prevents coprocessors from modifying the values written by a {{Put}}.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-11331) [blockcache] lazy block decompression
[
https://issues.apache.org/jira/browse/HBASE-11331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-11331:
-
Attachment: HBASE-11331.02.patch
Thanks [~stack]. v02 addresses the exception you see here. It also:
- makes the feature configurable. enable with
{{hbase.block.data.cachecompressed=true}}
- only retains data blocks in their "packed" format in memory. Everything else
*should* be cached decompressed.
One observation: when running the RS with a compression-enabled table, I see a
lot of log messages says "got brand-new decompressor". I don't see any messages
saying "got recycled compressor" (i've enabled debug logging for
org.apache.hadoop.io.compress). I think we're not returning the objects to the
pool. Running this small PE workload results in ~1600 said log lines. Run the
same workload with hbase.block.data.cachecompressed=true, I see ~10k, so this
will have a significant impact on the performance of this feature. Will
investigate further.
> [blockcache] lazy block decompression
> -
>
> Key: HBASE-11331
> URL: https://issues.apache.org/jira/browse/HBASE-11331
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Attachments: HBASE-11331.00.patch, HBASE-11331.01.patch,
> HBASE-11331.02.patch, HBASE-11331LazyBlockDecompressperfcompare.pdf
>
>
> Maintaining data in its compressed form in the block cache will greatly
> increase our effective blockcache size and should show a meaning improvement
> in cache hit rates in well designed applications. The idea here is to lazily
> decompress/decrypt blocks when they're consumed, rather than as soon as
> they're pulled off of disk.
> This is related to but less invasive than HBASE-8894.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11653) RegionObserver coprocessor cannot override KeyValue values in prePut()
[
https://issues.apache.org/jira/browse/HBASE-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083241#comment-14083241
]
Gary Helmling commented on HBASE-11653:
---
This is only present in 0.94, since 0.96+ have refactored the put() path to go
through doBatchMutate().
> RegionObserver coprocessor cannot override KeyValue values in prePut()
> --
>
> Key: HBASE-11653
> URL: https://issues.apache.org/jira/browse/HBASE-11653
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
>Affects Versions: 0.94.21
>Reporter: Gary Helmling
>Assignee: Gary Helmling
>Priority: Critical
>
> Due to a bug in {{HRegion.internalPut()}}, any modifications that a
> {{RegionObserver}} makes to a Put's family map in the {{prePut()}} hook are
> lost.
> This prevents coprocessors from modifying the values written by a {{Put}}.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11384) [Visibility Controller]Check for users covering authorizations for every mutation
[ https://issues.apache.org/jira/browse/HBASE-11384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083235#comment-14083235 ] Hudson commented on HBASE-11384: FAILURE: Integrated in HBase-TRUNK #5363 (See [https://builds.apache.org/job/HBase-TRUNK/5363/]) HBASE-11384 - [Visibility Controller]Check for users covering (ramkrishna: rev 4fd3b110f3d35dfd093d3d02ae77699b7c0447f4) * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsManager.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java * hbase-common/src/main/resources/hbase-default.xml * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java HBASE-11384 - [Visibility Controller]Check for users covering (ramkrishna: rev 04e06645acb14335ac9ae03aabebc286565c6f52) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityWithCheckAuths.java > [Visibility Controller]Check for users covering authorizations for every > mutation > - > > Key: HBASE-11384 > URL: https://issues.apache.org/jira/browse/HBASE-11384 > Project: HBase > Issue Type: Sub-task >Affects Versions: 0.98.3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0, 1.0.0, 0.98.5 > > Attachments: HBASE-11384.patch, HBASE-11384_1.patch, > HBASE-11384_2.patch, HBASE-11384_3.patch, HBASE-11384_4.patch, > HBASE-11384_6.patch, HBASE-11384_7.patch, HBASE-11384_8-0.98.patch, > HBASE-11384_8.patch > > > As part of discussions, it is better that every mutation either Put/Delete > with Visibility expressions should validate if the expression has labels for > which the user has authorization. If not fail the mutation. > Suppose User A is assoicated with A,B and C. The put has a visibility > expression A&D. Then fail the mutation as D is not associated with User A. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-11650) Write hbase.id to a temporary location and move into place
[ https://issues.apache.org/jira/browse/HBASE-11650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-11650: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Committed to 0.98+ > Write hbase.id to a temporary location and move into place > -- > > Key: HBASE-11650 > URL: https://issues.apache.org/jira/browse/HBASE-11650 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: HBASE-11650.patch > > > We should write hbase.id to a temporary location and move it into place. Will > avoid potential race issues between create and write. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11652) Port HBASE-3270 and HBASE-11650 to 0.94 - create cluster id and version file in a tmp location and move it into place
[ https://issues.apache.org/jira/browse/HBASE-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083230#comment-14083230 ] Andrew Purtell commented on HBASE-11652: +1 > Port HBASE-3270 and HBASE-11650 to 0.94 - create cluster id and version file > in a tmp location and move it into place > - > > Key: HBASE-11652 > URL: https://issues.apache.org/jira/browse/HBASE-11652 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl >Priority: Minor > Fix For: 0.94.23 > > Attachments: 11652.txt > > > See HBASE-3270 and HBASE-11650 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11651) Add conf which disables MetaMigrationConvertingToPB check (for experts only)
[ https://issues.apache.org/jira/browse/HBASE-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083221#comment-14083221 ] Mikhail Antonov commented on HBASE-11651: - [~stack] thanks for clarification! You're saying "going away in 2.0" - you mean, the original patch which removes the conversion would be suitable after 1.0 it out of the doors? > Add conf which disables MetaMigrationConvertingToPB check (for experts only) > > > Key: HBASE-11651 > URL: https://issues.apache.org/jira/browse/HBASE-11651 > Project: HBase > Issue Type: Sub-task > Components: master >Reporter: stack >Assignee: stack > Fix For: 0.99.0, 0.98.5 > > Attachments: 11651.txt > > > Up in parent issue, Virag wants to avoid expensive scan on startup. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11652) Port HBASE-3270 and HBASE-11650 to 0.94 - create cluster id and version file in a tmp location and move it into place
[ https://issues.apache.org/jira/browse/HBASE-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083222#comment-14083222 ] stack commented on HBASE-11652: --- lgtm > Port HBASE-3270 and HBASE-11650 to 0.94 - create cluster id and version file > in a tmp location and move it into place > - > > Key: HBASE-11652 > URL: https://issues.apache.org/jira/browse/HBASE-11652 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl >Priority: Minor > Fix For: 0.94.23 > > Attachments: 11652.txt > > > See HBASE-3270 and HBASE-11650 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11384) [Visibility Controller]Check for users covering authorizations for every mutation
[ https://issues.apache.org/jira/browse/HBASE-11384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083218#comment-14083218 ] Hudson commented on HBASE-11384: SUCCESS: Integrated in HBase-1.0 #81 (See [https://builds.apache.org/job/HBase-1.0/81/]) HBASE-11384 - [Visibility Controller]Check for users covering (ramkrishna: rev bf87170f50947ee1c28411f38f6c9810bb34aedf) * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityWithCheckAuths.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java * hbase-common/src/main/resources/hbase-default.xml > [Visibility Controller]Check for users covering authorizations for every > mutation > - > > Key: HBASE-11384 > URL: https://issues.apache.org/jira/browse/HBASE-11384 > Project: HBase > Issue Type: Sub-task >Affects Versions: 0.98.3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0, 1.0.0, 0.98.5 > > Attachments: HBASE-11384.patch, HBASE-11384_1.patch, > HBASE-11384_2.patch, HBASE-11384_3.patch, HBASE-11384_4.patch, > HBASE-11384_6.patch, HBASE-11384_7.patch, HBASE-11384_8-0.98.patch, > HBASE-11384_8.patch > > > As part of discussions, it is better that every mutation either Put/Delete > with Visibility expressions should validate if the expression has labels for > which the user has authorization. If not fail the mutation. > Suppose User A is assoicated with A,B and C. The put has a visibility > expression A&D. Then fail the mutation as D is not associated with User A. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11631) Wait a little till server is online in assigning meta
[ https://issues.apache.org/jira/browse/HBASE-11631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083217#comment-14083217 ] Hudson commented on HBASE-11631: SUCCESS: Integrated in HBase-1.0 #81 (See [https://builds.apache.org/job/HBase-1.0/81/]) HBASE-11631 Wait a little till server is online in assigning meta (jxiang: rev 7b3d0add6067dc935684e9a9c47a8fca8eb1c23d) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java > Wait a little till server is online in assigning meta > - > > Key: HBASE-11631 > URL: https://issues.apache.org/jira/browse/HBASE-11631 > Project: HBase > Issue Type: Improvement >Reporter: Jimmy Xiang >Assignee: Jimmy Xiang >Priority: Minor > Fix For: 1.0.0, 2.0.0 > > Attachments: hbase-11631.patch > > > In assigning the meta to a regionserver not the master, the regionserver > could have not processed the reportForDuty response yet. This happens a lot > in unit tests. It's better to wait a little bit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11652) Port HBASE-3270 and HBASE-11650 to 0.94 - create cluster id and version file in a tmp location and move it into place
[ https://issues.apache.org/jira/browse/HBASE-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083208#comment-14083208 ] Lars Hofhansl commented on HBASE-11652: --- [~apurtell], [~stack], FYI. > Port HBASE-3270 and HBASE-11650 to 0.94 - create cluster id and version file > in a tmp location and move it into place > - > > Key: HBASE-11652 > URL: https://issues.apache.org/jira/browse/HBASE-11652 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl >Priority: Minor > Fix For: 0.94.23 > > Attachments: 11652.txt > > > See HBASE-3270 and HBASE-11650 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-11652) Port HBASE-3270 and HBASE-11650 to 0.94 - create cluster id and version file in a tmp location and move it into place
[ https://issues.apache.org/jira/browse/HBASE-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-11652: -- Attachment: 11652.txt Simple patch. Going to commit unless there are objections. > Port HBASE-3270 and HBASE-11650 to 0.94 - create cluster id and version file > in a tmp location and move it into place > - > > Key: HBASE-11652 > URL: https://issues.apache.org/jira/browse/HBASE-11652 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl >Priority: Minor > Fix For: 0.94.23 > > Attachments: 11652.txt > > > See HBASE-3270 and HBASE-11650 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (HBASE-11651) Add conf which disables MetaMigrationConvertingToPB check (for experts only)
[ https://issues.apache.org/jira/browse/HBASE-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-11651. --- Resolution: Fixed Fix Version/s: 0.98.5 Assignee: stack Release Note: Set hbase.MetaMigrationConvertingToPB to false to avoid scan of META on startup. Useful if you know your meta has already been migrated and if your meta is very large. Hadoop Flags: Reviewed Applied to 0.98 branch and to branch-1. Not to master since this is going away in 2.0 > Add conf which disables MetaMigrationConvertingToPB check (for experts only) > > > Key: HBASE-11651 > URL: https://issues.apache.org/jira/browse/HBASE-11651 > Project: HBase > Issue Type: Sub-task > Components: master >Reporter: stack >Assignee: stack > Fix For: 0.99.0, 0.98.5 > > Attachments: 11651.txt > > > Up in parent issue, Virag wants to avoid expensive scan on startup. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-11652) Port HBASE-3270 and HBASE-11650 to 0.94 - create cluster id and version file in a tmp location and move it into place
[ https://issues.apache.org/jira/browse/HBASE-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-11652: -- Priority: Minor (was: Major) > Port HBASE-3270 and HBASE-11650 to 0.94 - create cluster id and version file > in a tmp location and move it into place > - > > Key: HBASE-11652 > URL: https://issues.apache.org/jira/browse/HBASE-11652 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Priority: Minor > Fix For: 0.94.23 > > > See HBASE-3270 and HBASE-11650 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (HBASE-11652) Port HBASE-3270 and HBASE-11650 to 0.94 - create cluster id and version file in a tmp location and move it into place
[ https://issues.apache.org/jira/browse/HBASE-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl reassigned HBASE-11652: - Assignee: Lars Hofhansl > Port HBASE-3270 and HBASE-11650 to 0.94 - create cluster id and version file > in a tmp location and move it into place > - > > Key: HBASE-11652 > URL: https://issues.apache.org/jira/browse/HBASE-11652 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl >Priority: Minor > Fix For: 0.94.23 > > > See HBASE-3270 and HBASE-11650 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11650) Write hbase.id to a temporary location and move into place
[ https://issues.apache.org/jira/browse/HBASE-11650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083201#comment-14083201 ] Lars Hofhansl commented on HBASE-11650: --- Good to go :) > Write hbase.id to a temporary location and move into place > -- > > Key: HBASE-11650 > URL: https://issues.apache.org/jira/browse/HBASE-11650 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: HBASE-11650.patch > > > We should write hbase.id to a temporary location and move it into place. Will > avoid potential race issues between create and write. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11650) Write hbase.id to a temporary location and move into place
[ https://issues.apache.org/jira/browse/HBASE-11650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083194#comment-14083194 ] Andrew Purtell commented on HBASE-11650: bq. would new Path(new Path(x,y),z) be cleaner that new Path(x, y+FILE_SEP+z)? Probably but this the same as previous change. I have a +1 so will commit this. Shout if you want different. > Write hbase.id to a temporary location and move into place > -- > > Key: HBASE-11650 > URL: https://issues.apache.org/jira/browse/HBASE-11650 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: HBASE-11650.patch > > > We should write hbase.id to a temporary location and move it into place. Will > avoid potential race issues between create and write. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11650) Write hbase.id to a temporary location and move into place
[
https://issues.apache.org/jira/browse/HBASE-11650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083191#comment-14083191
]
Lars Hofhansl commented on HBASE-11650:
---
would {{new Path(new Path(x,y),z)}} be cleaner that {{new Path(x,
y+FILE_SEP+z)}}?
> Write hbase.id to a temporary location and move into place
> --
>
> Key: HBASE-11650
> URL: https://issues.apache.org/jira/browse/HBASE-11650
> Project: HBase
> Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 0.99.0, 0.98.5, 2.0.0
>
> Attachments: HBASE-11650.patch
>
>
> We should write hbase.id to a temporary location and move it into place. Will
> avoid potential race issues between create and write.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-11652) Port HBASE-3270 and HBASE-11650 to 0.94 - create cluster id and version file in a tmp location and move it into place
[ https://issues.apache.org/jira/browse/HBASE-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-11652: -- Description: See HBASE-3270 and HBASE-11650 > Port HBASE-3270 and HBASE-11650 to 0.94 - create cluster id and version file > in a tmp location and move it into place > - > > Key: HBASE-11652 > URL: https://issues.apache.org/jira/browse/HBASE-11652 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl > Fix For: 0.94.23 > > > See HBASE-3270 and HBASE-11650 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11651) Add conf which disables MetaMigrationConvertingToPB check (for experts only)
[ https://issues.apache.org/jira/browse/HBASE-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083186#comment-14083186 ] stack commented on HBASE-11651: --- [~mantonov] Yes. I was thinking it a hack for folks like [~virag] who have massive meta regions and who know what they are doing -- i.e. that their meta has been migrated and they don't need to recheck. If others turn out to need it, I'll do something prettier. > Add conf which disables MetaMigrationConvertingToPB check (for experts only) > > > Key: HBASE-11651 > URL: https://issues.apache.org/jira/browse/HBASE-11651 > Project: HBase > Issue Type: Sub-task > Components: master >Reporter: stack > Fix For: 0.99.0 > > Attachments: 11651.txt > > > Up in parent issue, Virag wants to avoid expensive scan on startup. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (HBASE-11652) Port HBASE-3270 and HBASE-11650 to 0.94 - create cluster id and version file in a tmp location and move it into place
Lars Hofhansl created HBASE-11652: - Summary: Port HBASE-3270 and HBASE-11650 to 0.94 - create cluster id and version file in a tmp location and move it into place Key: HBASE-11652 URL: https://issues.apache.org/jira/browse/HBASE-11652 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Fix For: 0.94.23 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083185#comment-14083185 ] Andrew Purtell commented on HBASE-11516: +1 on addendum Oh hadoop1... > Track time spent in executing coprocessors in each region. > -- > > Key: HBASE-11516 > URL: https://issues.apache.org/jira/browse/HBASE-11516 > Project: HBase > Issue Type: Improvement > Components: Coprocessors >Affects Versions: 0.98.4 >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: 11516-0.98.addendum, HBASE-11516.patch, > HBASE-11516_v2.patch, HBASE-11516_v3.patch, HBASE-11516_v4.patch, > HBASE-11516_v4_master.patch, HBASE-11516_v5.patch, region_server_webui.png, > rs_web_ui_v2.png, rs_web_ui_v5.png > > > Currently, the time spent in executing coprocessors is not yet being tracked. > This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083184#comment-14083184 ] Srikanth Srungarapu commented on HBASE-11516: - [~andrew.purt...@gmail.com] Sorry for the confusion over microseconds being represented as msec. Thanks for putting up the addendum patch and pushing this. [~tedyu] +1 on the addendum and thanks for putting it up. Unfortunately, this change which is in HBASE-11516_v5.patch got dropped in HBASE-11516_v4_master.patch > Track time spent in executing coprocessors in each region. > -- > > Key: HBASE-11516 > URL: https://issues.apache.org/jira/browse/HBASE-11516 > Project: HBase > Issue Type: Improvement > Components: Coprocessors >Affects Versions: 0.98.4 >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: 11516-0.98.addendum, HBASE-11516.patch, > HBASE-11516_v2.patch, HBASE-11516_v3.patch, HBASE-11516_v4.patch, > HBASE-11516_v4_master.patch, HBASE-11516_v5.patch, region_server_webui.png, > rs_web_ui_v2.png, rs_web_ui_v5.png > > > Currently, the time spent in executing coprocessors is not yet being tracked. > This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11384) [Visibility Controller]Check for users covering authorizations for every mutation
[ https://issues.apache.org/jira/browse/HBASE-11384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083176#comment-14083176 ] Hudson commented on HBASE-11384: SUCCESS: Integrated in HBase-0.98 #431 (See [https://builds.apache.org/job/HBase-0.98/431/]) HBASE-11384 - [Visibility Controller]Check for users covering (ramkrishna: rev cc7eb46ee453ba0d09650b72ce830a475c25f82d) * hbase-common/src/main/resources/hbase-default.xml * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityWithCheckAuths.java > [Visibility Controller]Check for users covering authorizations for every > mutation > - > > Key: HBASE-11384 > URL: https://issues.apache.org/jira/browse/HBASE-11384 > Project: HBase > Issue Type: Sub-task >Affects Versions: 0.98.3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0, 1.0.0, 0.98.5 > > Attachments: HBASE-11384.patch, HBASE-11384_1.patch, > HBASE-11384_2.patch, HBASE-11384_3.patch, HBASE-11384_4.patch, > HBASE-11384_6.patch, HBASE-11384_7.patch, HBASE-11384_8-0.98.patch, > HBASE-11384_8.patch > > > As part of discussions, it is better that every mutation either Put/Delete > with Visibility expressions should validate if the expression has labels for > which the user has authorization. If not fail the mutation. > Suppose User A is assoicated with A,B and C. The put has a visibility > expression A&D. Then fail the mutation as D is not associated with User A. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083177#comment-14083177 ] stack commented on HBASE-11640: --- Yes. I have that over here. Its beautiful. Thanks [~misty] > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch, Screen > Shot 2014-08-02 at 9.19.24 am.png > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11635) Deprecate TableMapReduceUtil.setScannerCaching
[ https://issues.apache.org/jira/browse/HBASE-11635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083172#comment-14083172 ] Nick Dimiduk commented on HBASE-11635: -- The config is only used by TableMapReduceUtil.setScannerCaching; not used at all by the version based on the scanner, right? We should get rid of the config at the same time we get ride of TableMapReduceUtil.setScannerCaching so that only the serialized Scan object is used. Since we have master branch at 2.0.0-SNAPSHOT, you can provide the patches for 0.98 and branch-1 that deprecate the method and warn on config access, and a patch for master that removes "hbase.client.scanner.caching" and TableMapReduceUtil.setScannerCaching -- both on this ticket. No need to open separate JIRA for deprecation and removal. If you choose to do that, update the title accordingly. > Deprecate TableMapReduceUtil.setScannerCaching > -- > > Key: HBASE-11635 > URL: https://issues.apache.org/jira/browse/HBASE-11635 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Affects Versions: 1.0.0, 0.98.4, 2.0.0 >Reporter: Ishan Chhabra >Assignee: Ishan Chhabra > > See discussion in HBASE-11558. > Currently there are 2 ways to specify scanner caching when invoking a MR job > using TableMapReduceUtil. > 1. By setting the caching on the Scan Object. > 2. By setting the "hbase.client.scanner.caching" config using > TableMapReduceUtil.setScannerCaching. > This JIRA attempts to deprecate the latter. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Misty Stanley-Jones updated HBASE-11640: Attachment: Screen Shot 2014-08-02 at 9.19.24 am.png > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch, Screen > Shot 2014-08-02 at 9.19.24 am.png > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083163#comment-14083163 ] Misty Stanley-Jones commented on HBASE-11640: - For instance, I see in file:///Users/misty/git/hbase/target/docbkx/book.html#appendix_contributing_to_documentation (fix up the URL for your own system of course) in listing A.7, the elements in the XML are blue and attributes are orange. I just verified it against master (I see you pushed the changes ) > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10674) HBCK should be updated to do replica related checks
[
https://issues.apache.org/jira/browse/HBASE-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083161#comment-14083161
]
Alex Newman commented on HBASE-10674:
-
Oooh one other thing
in HBaseFsck.java
/**
* Puts the specified HRegionInfo into META.
*/
public static void fixMetaHoleOnline(Configuration conf,
HRegionInfo hri) throws IOException {
HTable meta = new HTable(conf, TableName.META_TABLE_NAME);
MetaTableAccessor.addRegionToMeta(meta, hri);
meta.close();
}
no longer seems to be used
> HBCK should be updated to do replica related checks
> ---
>
> Key: HBASE-10674
> URL: https://issues.apache.org/jira/browse/HBASE-10674
> Project: HBase
> Issue Type: Sub-task
>Reporter: Devaraj Das
>Assignee: Devaraj Das
> Attachments: 10674-1.2.txt, 10674-1.txt
>
>
> HBCK should be updated to have a check for whether the replicas are assigned
> to the right machines (default and non-default replicas ideally should not be
> in the same server if there is more than one server in the cluster and such
> scenarios). [~jmhsieh] suggested this in HBASE-10362.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (HBASE-5244) Add a test for a row with 1M (10M? 100M) columns and see how we do with it
[ https://issues.apache.org/jira/browse/HBASE-5244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Newman reassigned HBASE-5244: -- Assignee: (was: Alex Newman) > Add a test for a row with 1M (10M? 100M) columns and see how we do with it > -- > > Key: HBASE-5244 > URL: https://issues.apache.org/jira/browse/HBASE-5244 > Project: HBase > Issue Type: Task >Reporter: stack > Attachments: HBASE-5244-v1.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083159#comment-14083159 ] stack commented on HBASE-11640: --- Hmm... still don't see it. Paste an example so I know what I am looking for? > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-11516: --- Attachment: 11516-0.98.addendum Addendum which fixes build on hadoop-1 > Track time spent in executing coprocessors in each region. > -- > > Key: HBASE-11516 > URL: https://issues.apache.org/jira/browse/HBASE-11516 > Project: HBase > Issue Type: Improvement > Components: Coprocessors >Affects Versions: 0.98.4 >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: 11516-0.98.addendum, HBASE-11516.patch, > HBASE-11516_v2.patch, HBASE-11516_v3.patch, HBASE-11516_v4.patch, > HBASE-11516_v4_master.patch, HBASE-11516_v5.patch, region_server_webui.png, > rs_web_ui_v2.png, rs_web_ui_v5.png > > > Currently, the time spent in executing coprocessors is not yet being tracked. > This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11650) Write hbase.id to a temporary location and move into place
[ https://issues.apache.org/jira/browse/HBASE-11650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083152#comment-14083152 ] stack commented on HBASE-11650: --- +1 > Write hbase.id to a temporary location and move into place > -- > > Key: HBASE-11650 > URL: https://issues.apache.org/jira/browse/HBASE-11650 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: HBASE-11650.patch > > > We should write hbase.id to a temporary location and move it into place. Will > avoid potential race issues between create and write. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083146#comment-14083146 ] stack commented on HBASE-11640: --- [~misty] your best bet is blame me. That is best place to start... > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083143#comment-14083143 ] Misty Stanley-Jones commented on HBASE-11640: - Odd, it was in the original patch -- I just checked it. Can you let me know what I should have done better on this one, [~stack]? > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083144#comment-14083144 ] stack commented on HBASE-11640: --- I applied the addendum. It was probably my fault the pom changes didn't go in. Let me see if I see the diff now. > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Misty Stanley-Jones updated HBASE-11640: Status: Patch Available (was: Reopened) > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-11650) Write hbase.id to a temporary location and move into place
[ https://issues.apache.org/jira/browse/HBASE-11650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-11650: --- Status: Patch Available (was: Open) > Write hbase.id to a temporary location and move into place > -- > > Key: HBASE-11650 > URL: https://issues.apache.org/jira/browse/HBASE-11650 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: HBASE-11650.patch > > > We should write hbase.id to a temporary location and move it into place. Will > avoid potential race issues between create and write. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Reopened] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Misty Stanley-Jones reopened HBASE-11640: - > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-11650) Write hbase.id to a temporary location and move into place
[ https://issues.apache.org/jira/browse/HBASE-11650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-11650: --- Attachment: HBASE-11650.patch Attaching patch. All tests pass using 0.98. > Write hbase.id to a temporary location and move into place > -- > > Key: HBASE-11650 > URL: https://issues.apache.org/jira/browse/HBASE-11650 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: HBASE-11650.patch > > > We should write hbase.id to a temporary location and move it into place. Will > avoid potential race issues between create and write. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Misty Stanley-Jones updated HBASE-11640: Attachment: HBASE-11640_pom.patch > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11651) Add conf which disables MetaMigrationConvertingToPB check (for experts only)
[ https://issues.apache.org/jira/browse/HBASE-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083134#comment-14083134 ] Mikhail Antonov commented on HBASE-11651: - [~stack] so this property isn't mentioned in HConstants or in hbase-default.xml, just "top secret property" you need to know about to use? > Add conf which disables MetaMigrationConvertingToPB check (for experts only) > > > Key: HBASE-11651 > URL: https://issues.apache.org/jira/browse/HBASE-11651 > Project: HBase > Issue Type: Sub-task > Components: master >Reporter: stack > Fix For: 0.99.0 > > Attachments: 11651.txt > > > Up in parent issue, Virag wants to avoid expensive scan on startup. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083135#comment-14083135 ] Misty Stanley-Jones commented on HBASE-11640: - Somehow my changes to the POM itself didn't make it in. That was supposed to be the point of my first patch but I must have done soemthing wrong. Let me add an addendum. > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11651) Add conf which disables MetaMigrationConvertingToPB check (for experts only)
[ https://issues.apache.org/jira/browse/HBASE-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083129#comment-14083129 ] Virag Kothari commented on HBASE-11651: --- Looks good. Thanks! > Add conf which disables MetaMigrationConvertingToPB check (for experts only) > > > Key: HBASE-11651 > URL: https://issues.apache.org/jira/browse/HBASE-11651 > Project: HBase > Issue Type: Sub-task > Components: master >Reporter: stack > Fix For: 0.99.0 > > Attachments: 11651.txt > > > Up in parent issue, Virag wants to avoid expensive scan on startup. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-11651) Add conf which disables MetaMigrationConvertingToPB check (for experts only)
[ https://issues.apache.org/jira/browse/HBASE-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-11651: -- Attachment: 11651.txt How is this [~virag]? If good by you I'll commit to 0.98. > Add conf which disables MetaMigrationConvertingToPB check (for experts only) > > > Key: HBASE-11651 > URL: https://issues.apache.org/jira/browse/HBASE-11651 > Project: HBase > Issue Type: Sub-task > Components: master >Reporter: stack > Fix For: 0.99.0 > > Attachments: 11651.txt > > > Up in parent issue, Virag wants to avoid expensive scan on startup. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10674) HBCK should be updated to do replica related checks
[ https://issues.apache.org/jira/browse/HBASE-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083128#comment-14083128 ] Alex Newman commented on HBASE-10674: - Agreed, my vote does't count but +1 > HBCK should be updated to do replica related checks > --- > > Key: HBASE-10674 > URL: https://issues.apache.org/jira/browse/HBASE-10674 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Devaraj Das > Attachments: 10674-1.2.txt, 10674-1.txt > > > HBCK should be updated to have a check for whether the replicas are assigned > to the right machines (default and non-default replicas ideally should not be > in the same server if there is more than one server in the cluster and such > scenarios). [~jmhsieh] suggested this in HBASE-10362. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (HBASE-11651) Add conf which disables MetaMigrationConvertingToPB check (for experts only)
stack created HBASE-11651: - Summary: Add conf which disables MetaMigrationConvertingToPB check (for experts only) Key: HBASE-11651 URL: https://issues.apache.org/jira/browse/HBASE-11651 Project: HBase Issue Type: Sub-task Reporter: stack Attachments: 11651.txt Up in parent issue, Virag wants to avoid expensive scan on startup. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083124#comment-14083124 ] Misty Stanley-Jones commented on HBASE-11640: - Let me see if I can figure out why it isn't working for you. > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10674) HBCK should be updated to do replica related checks
[
https://issues.apache.org/jira/browse/HBASE-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083105#comment-14083105
]
Nick Dimiduk commented on HBASE-10674:
--
{noformat}
+Result r = meta.get(get);
+RegionLocations rl = MetaTableAccessor.getRegionLocations(r);
+if (rl == null) return;
{noformat}
Should this be an error instead of silently returning?
{noformat}
+ for (HRegionLocation h : rl.getRegionLocations()) {
+if (h == null || h.getRegionInfo() == null) {
+ continue;
+}
{noformat}
And this should be an error as well, especially if h.getRegionInfo() is null?
Nice tests. Just when I was thinking "what about this case?" I find a test for
it.
Questions aside, LGTM, +1.
> HBCK should be updated to do replica related checks
> ---
>
> Key: HBASE-10674
> URL: https://issues.apache.org/jira/browse/HBASE-10674
> Project: HBase
> Issue Type: Sub-task
>Reporter: Devaraj Das
>Assignee: Devaraj Das
> Attachments: 10674-1.2.txt, 10674-1.txt
>
>
> HBCK should be updated to have a check for whether the replicas are assigned
> to the right machines (default and non-default replicas ideally should not be
> in the same server if there is more than one server in the cluster and such
> scenarios). [~jmhsieh] suggested this in HBASE-10362.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11632) Region split needs to clear force split flag at the end of SplitRequest run
[
https://issues.apache.org/jira/browse/HBASE-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083101#comment-14083101
]
Hudson commented on HBASE-11632:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #407 (See
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/407/])
HBASE-11632 Region split needs to clear force split flag at the end of
SplitRequest run (Jerry He) (tedyu: rev
f2fef2d39a8c69c56ed4ca9c0a52b86d7eb2d03a)
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java
> Region split needs to clear force split flag at the end of SplitRequest run
> ---
>
> Key: HBASE-11632
> URL: https://issues.apache.org/jira/browse/HBASE-11632
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.99.0, 0.98.4
>Reporter: Jerry He
>Assignee: Jerry He
>Priority: Minor
> Fix For: 0.99.0, 0.98.5, 2.0.0
>
> Attachments: HBASE-11632-master-v2.patch, HBASE-11632-master.patch,
> HBASE-11632-v2-0.98.patch
>
>
> force split flag is used when a user requests region split and specifies a
> split key.
> {code}
> region.forceSplit(splitPoint);
> {code}
> We need to clear force split flag at the end of SplitRequest run. If the
> region split is successful, this parent region will go away and there is no
> need to clear this flag. But we will have problem when the split is not
> successful or rejected. Here is the case:
> 1. User requested region split at rownkey-n.
> 2. We set forceSplit in the region with rownkey-n.
> 3. The split request got rejected because the region had references.
> 4. After a while, there was a system request split for the same region.
> 5. The region would use forceSplit and rownkey-n to split. What should have
> happened is that the region split is done based on system split policy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11384) [Visibility Controller]Check for users covering authorizations for every mutation
[ https://issues.apache.org/jira/browse/HBASE-11384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083102#comment-14083102 ] Hudson commented on HBASE-11384: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #407 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/407/]) HBASE-11384 - [Visibility Controller]Check for users covering (ramkrishna: rev cc7eb46ee453ba0d09650b72ce830a475c25f82d) * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsManager.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityWithCheckAuths.java * hbase-common/src/main/resources/hbase-default.xml * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java > [Visibility Controller]Check for users covering authorizations for every > mutation > - > > Key: HBASE-11384 > URL: https://issues.apache.org/jira/browse/HBASE-11384 > Project: HBase > Issue Type: Sub-task >Affects Versions: 0.98.3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0, 1.0.0, 0.98.5 > > Attachments: HBASE-11384.patch, HBASE-11384_1.patch, > HBASE-11384_2.patch, HBASE-11384_3.patch, HBASE-11384_4.patch, > HBASE-11384_6.patch, HBASE-11384_7.patch, HBASE-11384_8-0.98.patch, > HBASE-11384_8.patch > > > As part of discussions, it is better that every mutation either Put/Delete > with Visibility expressions should validate if the expression has labels for > which the user has authorization. If not fail the mutation. > Suppose User A is assoicated with A,B and C. The put has a visibility > expression A&D. Then fail the mutation as D is not associated with User A. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-4593) Design and document the official procedure for posting patches, commits, commit messages, etc. to smooth process and make integration with tools easier
[ https://issues.apache.org/jira/browse/HBASE-4593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083100#comment-14083100 ] Alex Newman commented on HBASE-4593: Maybe this is the wrong time to suggest it. But i feel like we have a ton of nits in HBase. Perhaps now we could enshrine a policy to avoid this. Like whenever you touch a file, you post a separate patch where you handle weird formatting nits, spelling errors, etc. That way no one has to really review it carefully (as it is just autodetected nits), and the two patches can go in together. > Design and document the official procedure for posting patches, commits, > commit messages, etc. to smooth process and make integration with tools easier > --- > > Key: HBASE-4593 > URL: https://issues.apache.org/jira/browse/HBASE-4593 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Jonathan Gray >Assignee: Misty Stanley-Jones > > I have been building a tool (currently called reposync) to help me keep the > internal FB hbase-92-based branch up-to-date with the public branches. > Various inconsistencies in our process has made it difficult to automate a > lot of this stuff. > I'd like to work with everyone to come up with the official best practices > and stick to it. > I welcome all suggestions. Among some of the things I'd like to nail down: > - Commit message format > - Best practice and commit message format for multiple commits > - Multiple commits per jira vs. jira per commit, what are the exceptions and > when > - Affects vs. Fix versions > - Potential usage of [tags] in commit messages for things like book, scripts, > shell... maybe even whatever is in the components field? > - Increased usage of JIRA tags or labels to mark exactly which repos a JIRA > has been committed to (potentially even internal repos? ways for a tool to > keep track in JIRA?) > We also need to be more strict about some things if we want to follow Apache > guidelines. For example, all final versions of a patch must be attached to > JIRA so that the author properly assigns it to Apache. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11068) Update code to use Admin factory method instead of constructor
[
https://issues.apache.org/jira/browse/HBASE-11068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083099#comment-14083099
]
stack commented on HBASE-11068:
---
Tried TestMasterOperationsForRegionReplicas locally and it passes. Will commit
in next day or so unless objection.
> Update code to use Admin factory method instead of constructor
> --
>
> Key: HBASE-11068
> URL: https://issues.apache.org/jira/browse/HBASE-11068
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 0.99.0
>Reporter: Carter
>Assignee: Carter
> Fix For: 0.99.0
>
> Attachments: HBASE_11068-branch-1-v2.patch, HBASE_11068.patch
>
>
> Where feasible, the code should be updated to use the HConnection factory
> method for the admin interface. For instance, the following:
> {code:java}
> HBaseAdmin admin = new HBaseAdmin(conf);
> {code}
> would be changed to:
> {code:java}
> Admin admin = HConnectionManager.createConnection(conf).getAdmin();
> {code}
> This would also require updates to admin calls that refer to a tablename as
> byte[] or String.
> {code:java}
> admin.enableTable("mytable");
> {code}
> would change to:
> {code:java}
> admin.enableTable(TableName.valueOf("mytable"));
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11068) Update code to use Admin factory method instead of constructor
[
https://issues.apache.org/jira/browse/HBASE-11068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083093#comment-14083093
]
stack commented on HBASE-11068:
---
Patch looks good to me.
I ran the patch locally and got similar set of failures:
Results :
testRetainAssignmentOnRestart(org.apache.hadoop.hbase.master.TestRestartCluster):
expected:<172.16.1.127:572[46]> but was:<172.16.1.127:572[39]>
testFencingAroundCompactionAfterWALSync(org.apache.hadoop.hbase.TestIOFencing):
Timed out waiting for the region to flush
testRebalanceOnRegionServerNumberChange[1](org.apache.hadoop.hbase.TestRegionRebalancing):
After 5 attempts, region assignments were not balanced.
Tests in error:
org.apache.hadoop.hbase.client.TestReplicasClient: KeeperErrorCode = NoNode
for /hbase/region-in-transition/1588230740
testMasterOpsWhileSplitting(org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction):
Failed to report opened region to master:
TestSplit,lll,1406927556923.e5d051a237ee9d5837baca3565f474d3.
org.apache.hadoop.hbase.regionserver.TestRegionReplicas: KeeperErrorCode =
NoNode for /hbase/region-in-transition/1588230740
Tests run: 2064, Failures: 4, Errors: 3, Skipped: 19
Difference is hadoopqa failed TestMasterOperationsForRegionReplicas and my
local testing failed TestRegionRebalancing which seems to be failing a bunch of
late. Passes if I rerun it w/ this patch.
> Update code to use Admin factory method instead of constructor
> --
>
> Key: HBASE-11068
> URL: https://issues.apache.org/jira/browse/HBASE-11068
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 0.99.0
>Reporter: Carter
>Assignee: Carter
> Fix For: 0.99.0
>
> Attachments: HBASE_11068-branch-1-v2.patch, HBASE_11068.patch
>
>
> Where feasible, the code should be updated to use the HConnection factory
> method for the admin interface. For instance, the following:
> {code:java}
> HBaseAdmin admin = new HBaseAdmin(conf);
> {code}
> would be changed to:
> {code:java}
> Admin admin = HConnectionManager.createConnection(conf).getAdmin();
> {code}
> This would also require updates to admin calls that refer to a tablename as
> byte[] or String.
> {code:java}
> admin.enableTable("mytable");
> {code}
> would change to:
> {code:java}
> admin.enableTable(TableName.valueOf("mytable"));
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10674) HBCK should be updated to do replica related checks
[
https://issues.apache.org/jira/browse/HBASE-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083069#comment-14083069
]
Alex Newman commented on HBASE-10674:
-
Also I noticed A commented out line in HBaseFsck
@@ -3514,6 +3517,7 @@ public class HBaseFsck extends Configured {
// check to see if the existence of this region matches the region in M
for (HRegionInfo r:regions) {
HbckInfo hbi = hbck.getOrCreateInfo(r.getEncodedName());
//if (!RegionReplicaUtil.isDefaultReplica(r)) hbi.setSkipChecks(true)
hbi.addServer(r, rsinfo);
}
> HBCK should be updated to do replica related checks
> ---
>
> Key: HBASE-10674
> URL: https://issues.apache.org/jira/browse/HBASE-10674
> Project: HBase
> Issue Type: Sub-task
>Reporter: Devaraj Das
>Assignee: Devaraj Das
> Attachments: 10674-1.2.txt, 10674-1.txt
>
>
> HBCK should be updated to have a check for whether the replicas are assigned
> to the right machines (default and non-default replicas ideally should not be
> in the same server if there is more than one server in the cluster and such
> scenarios). [~jmhsieh] suggested this in HBASE-10362.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Comment Edited] (HBASE-11632) Region split needs to clear force split flag at the end of SplitRequest run
[
https://issues.apache.org/jira/browse/HBASE-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083059#comment-14083059
]
Ted Yu edited comment on HBASE-11632 at 8/1/14 10:22 PM:
-
Integrated to 3 branches.
Thanks for the patch, Jerry.
Thanks for the review, Stack and Andrew.
was (Author: yuzhih...@gmail.com):
Integrated to 3 branches.
Thanks for the patch, Jerry.
Thanks for the review, Stack.
> Region split needs to clear force split flag at the end of SplitRequest run
> ---
>
> Key: HBASE-11632
> URL: https://issues.apache.org/jira/browse/HBASE-11632
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.99.0, 0.98.4
>Reporter: Jerry He
>Assignee: Jerry He
>Priority: Minor
> Fix For: 0.99.0, 0.98.5, 2.0.0
>
> Attachments: HBASE-11632-master-v2.patch, HBASE-11632-master.patch,
> HBASE-11632-v2-0.98.patch
>
>
> force split flag is used when a user requests region split and specifies a
> split key.
> {code}
> region.forceSplit(splitPoint);
> {code}
> We need to clear force split flag at the end of SplitRequest run. If the
> region split is successful, this parent region will go away and there is no
> need to clear this flag. But we will have problem when the split is not
> successful or rejected. Here is the case:
> 1. User requested region split at rownkey-n.
> 2. We set forceSplit in the region with rownkey-n.
> 3. The split request got rejected because the region had references.
> 4. After a while, there was a system request split for the same region.
> 5. The region would use forceSplit and rownkey-n to split. What should have
> happened is that the region split is done based on system split policy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10674) HBCK should be updated to do replica related checks
[
https://issues.apache.org/jira/browse/HBASE-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083061#comment-14083061
]
Alex Newman commented on HBASE-10674:
-
OK I have no commit bit, that being said.
What's going on here, can we make it into a function? This has gotten pretty
hairy
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
@@ -2949,6 +2949,7 @@ public class HBaseFsck extends Configured {
} else {
m = new MetaEntry(hri, sn, ts, null, null);
}
HbckInfo previous = regionInfoMap.get(hri.getEncodedName());
if (previous == null) {
regionInfoMap.put(hri.getEncodedName(), new HbckInfo(m));
/TODO What does first online hri mean? Maybe a javadoc?
return FSUtils.getTableName(tableDir);
} else {
// return the info from the first online hri
for (OnlineEntry e : deployedEntries) {
return e.hri.getTable();
}
This is weirdly formatted. Maybe run an autoformat
++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.ja
@@ -186,12 +186,14 @@ public class HBaseFsckRepair {
* Puts the specified HRegionInfo into META with replica related columns
*/
public static void fixMetaHoleOnlineAndAddReplicas(Configuration conf,
- HRegionInfo hri, Collection servers, int numReplicas) throws
> HBCK should be updated to do replica related checks
> ---
>
> Key: HBASE-10674
> URL: https://issues.apache.org/jira/browse/HBASE-10674
> Project: HBase
> Issue Type: Sub-task
>Reporter: Devaraj Das
>Assignee: Devaraj Das
> Attachments: 10674-1.2.txt, 10674-1.txt
>
>
> HBCK should be updated to have a check for whether the replicas are assigned
> to the right machines (default and non-default replicas ideally should not be
> in the same server if there is more than one server in the cluster and such
> scenarios). [~jmhsieh] suggested this in HBASE-10362.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10674) HBCK should be updated to do replica related checks
[
https://issues.apache.org/jira/browse/HBASE-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083066#comment-14083066
]
Alex Newman commented on HBASE-10674:
-
Woops accidently hit add
if (numReplicas > 1) {
Random r = new Random();
Shouldn't this be?
- ServerName[] serversArr = servers.toArray(new ServerName[0]);
+ ServerName[] serversArr = servers.toArray(new ServerName[servers.size()])
You have a spare todo around
a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
@@ -301,6 +301,7 @@ public class TestHBaseFsck {
* @param metaRow if true remove region's row from META
* @param hdfs if true remove region's dir in HDFS
* @param regionInfoOnly if true remove a region dir's .regioninfo file
* @param replicaId TODO
*/
private void deleteRegion(Configuration conf, final HTableDescriptor htd,
> HBCK should be updated to do replica related checks
> ---
>
> Key: HBASE-10674
> URL: https://issues.apache.org/jira/browse/HBASE-10674
> Project: HBase
> Issue Type: Sub-task
>Reporter: Devaraj Das
>Assignee: Devaraj Das
> Attachments: 10674-1.2.txt, 10674-1.txt
>
>
> HBCK should be updated to have a check for whether the replicas are assigned
> to the right machines (default and non-default replicas ideally should not be
> in the same server if there is more than one server in the cluster and such
> scenarios). [~jmhsieh] suggested this in HBASE-10362.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-11632) Region split needs to clear force split flag at the end of SplitRequest run
[
https://issues.apache.org/jira/browse/HBASE-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-11632:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
Integrated to 3 branches.
Thanks for the patch, Jerry.
Thanks for the review, Stack.
> Region split needs to clear force split flag at the end of SplitRequest run
> ---
>
> Key: HBASE-11632
> URL: https://issues.apache.org/jira/browse/HBASE-11632
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.99.0, 0.98.4
>Reporter: Jerry He
>Assignee: Jerry He
>Priority: Minor
> Fix For: 0.99.0, 0.98.5, 2.0.0
>
> Attachments: HBASE-11632-master-v2.patch, HBASE-11632-master.patch,
> HBASE-11632-v2-0.98.patch
>
>
> force split flag is used when a user requests region split and specifies a
> split key.
> {code}
> region.forceSplit(splitPoint);
> {code}
> We need to clear force split flag at the end of SplitRequest run. If the
> region split is successful, this parent region will go away and there is no
> need to clear this flag. But we will have problem when the split is not
> successful or rejected. Here is the case:
> 1. User requested region split at rownkey-n.
> 2. We set forceSplit in the region with rownkey-n.
> 3. The split request got rejected because the region had references.
> 4. After a while, there was a system request split for the same region.
> 5. The region would use forceSplit and rownkey-n to split. What should have
> happened is that the region split is done based on system split policy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-11632) Region split needs to clear force split flag at the end of SplitRequest run
[
https://issues.apache.org/jira/browse/HBASE-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jerry He updated HBASE-11632:
-
Attachment: HBASE-11632-v2-0.98.patch
> Region split needs to clear force split flag at the end of SplitRequest run
> ---
>
> Key: HBASE-11632
> URL: https://issues.apache.org/jira/browse/HBASE-11632
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.99.0, 0.98.4
>Reporter: Jerry He
>Assignee: Jerry He
>Priority: Minor
> Fix For: 0.99.0, 0.98.5, 2.0.0
>
> Attachments: HBASE-11632-master-v2.patch, HBASE-11632-master.patch,
> HBASE-11632-v2-0.98.patch
>
>
> force split flag is used when a user requests region split and specifies a
> split key.
> {code}
> region.forceSplit(splitPoint);
> {code}
> We need to clear force split flag at the end of SplitRequest run. If the
> region split is successful, this parent region will go away and there is no
> need to clear this flag. But we will have problem when the split is not
> successful or rejected. Here is the case:
> 1. User requested region split at rownkey-n.
> 2. We set forceSplit in the region with rownkey-n.
> 3. The split request got rejected because the region had references.
> 4. After a while, there was a system request split for the same region.
> 5. The region would use forceSplit and rownkey-n to split. What should have
> happened is that the region split is done based on system split policy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11649) Add shortcut commands to bin/hbase for test tools
[ https://issues.apache.org/jira/browse/HBASE-11649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083008#comment-14083008 ] Hudson commented on HBASE-11649: FAILURE: Integrated in HBase-TRUNK #5362 (See [https://builds.apache.org/job/HBase-TRUNK/5362/]) HBASE-11649 Add shortcut commands to bin/hbase for test tools (apurtell: rev c6d07f881ff8a6fa706030495d29057ffdb4efb6) * bin/hbase > Add shortcut commands to bin/hbase for test tools > - > > Key: HBASE-11649 > URL: https://issues.apache.org/jira/browse/HBASE-11649 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Trivial > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: HBASE-11649.patch > > > We should have shortcuts and HBASE_OPTS mixin support for > PerformanceEvaluation and LoadTestTool in bin/hbase. Some developer carpal > tunnel syndrome risk reduction. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11631) Wait a little till server is online in assigning meta
[ https://issues.apache.org/jira/browse/HBASE-11631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083009#comment-14083009 ] Hudson commented on HBASE-11631: FAILURE: Integrated in HBase-TRUNK #5362 (See [https://builds.apache.org/job/HBase-TRUNK/5362/]) HBASE-11631 Wait a little till server is online in assigning meta (jxiang: rev 111636c0e7dcfa0727887a6084c44348ce34c2fc) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java > Wait a little till server is online in assigning meta > - > > Key: HBASE-11631 > URL: https://issues.apache.org/jira/browse/HBASE-11631 > Project: HBase > Issue Type: Improvement >Reporter: Jimmy Xiang >Assignee: Jimmy Xiang >Priority: Minor > Fix For: 1.0.0, 2.0.0 > > Attachments: hbase-11631.patch > > > In assigning the meta to a regionserver not the master, the regionserver > could have not processed the reportForDuty response yet. This happens a lot > in unit tests. It's better to wait a little bit. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10834) Better error messaging on issuing grant commands in non-authz mode
[
https://issues.apache.org/jira/browse/HBASE-10834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083001#comment-14083001
]
Jimmy Xiang commented on HBASE-10834:
-
It seems there is an extra "end". Do you need a "\" to combine the two lines?
> Better error messaging on issuing grant commands in non-authz mode
> --
>
> Key: HBASE-10834
> URL: https://issues.apache.org/jira/browse/HBASE-10834
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 0.94.17
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
>Priority: Trivial
> Attachments: HBASE-10834.patch, HBASE-10834_v2.patch,
> HBASE-10834_v3.patch
>
>
> Running the below sequence of steps should give a better error messaging
> rather than "table not found" error.
> {code}
> hbase(main):009:0> grant "test", "RWCXA"
> ERROR: Unknown table _acl_!
> Here is some help for this command:
> Grant users specific rights.
> Syntax : grant [ [ [ qualifier>]]
> permissions is either zero or more letters from the set "RWXCA".
> READ('R'), WRITE('W'), EXEC('X'), CREATE('C'), ADMIN('A')
> For example:
> hbase> grant 'bobsmith', 'RWXCA'
> hbase> grant 'bobsmith', 'RW', 't1', 'f1', 'col1'
> {code}
> Instead of ERROR: Unknown table _acl_!, hbase should give out a warning like
> "Command not supported in non-authz mode(as acl table is only created if
> authz is turned on)"
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-4593) Design and document the official procedure for posting patches, commits, commit messages, etc. to smooth process and make integration with tools easier
[ https://issues.apache.org/jira/browse/HBASE-4593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082999#comment-14082999 ] Nick Dimiduk commented on HBASE-4593: - I should add, re: commit message title. There is some convention around additional '.' or ':' used by other Hadoop projects, but we HBase appear to have not picked up the habit. > Design and document the official procedure for posting patches, commits, > commit messages, etc. to smooth process and make integration with tools easier > --- > > Key: HBASE-4593 > URL: https://issues.apache.org/jira/browse/HBASE-4593 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Jonathan Gray >Assignee: Misty Stanley-Jones > > I have been building a tool (currently called reposync) to help me keep the > internal FB hbase-92-based branch up-to-date with the public branches. > Various inconsistencies in our process has made it difficult to automate a > lot of this stuff. > I'd like to work with everyone to come up with the official best practices > and stick to it. > I welcome all suggestions. Among some of the things I'd like to nail down: > - Commit message format > - Best practice and commit message format for multiple commits > - Multiple commits per jira vs. jira per commit, what are the exceptions and > when > - Affects vs. Fix versions > - Potential usage of [tags] in commit messages for things like book, scripts, > shell... maybe even whatever is in the components field? > - Increased usage of JIRA tags or labels to mark exactly which repos a JIRA > has been committed to (potentially even internal repos? ways for a tool to > keep track in JIRA?) > We also need to be more strict about some things if we want to follow Apache > guidelines. For example, all final versions of a patch must be attached to > JIRA so that the author properly assigns it to Apache. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-4593) Design and document the official procedure for posting patches, commits, commit messages, etc. to smooth process and make integration with tools easier
[
https://issues.apache.org/jira/browse/HBASE-4593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082997#comment-14082997
]
Nick Dimiduk commented on HBASE-4593:
-
bq. Save your changes to a patch: git diff --no-prefix origin/master >
HBASE-.patch
I work off of local feature branches, thus I use {{git format-patch HEAD~1}} to
generate my patches. This is how my commit messages come along for the ride.
Buildbot appears to have no issue with this formatting.
Title of commit message by convention is something along the lines of
{noformat}
()
{noformat}
> Design and document the official procedure for posting patches, commits,
> commit messages, etc. to smooth process and make integration with tools easier
> ---
>
> Key: HBASE-4593
> URL: https://issues.apache.org/jira/browse/HBASE-4593
> Project: HBase
> Issue Type: Task
> Components: documentation
>Reporter: Jonathan Gray
>Assignee: Misty Stanley-Jones
>
> I have been building a tool (currently called reposync) to help me keep the
> internal FB hbase-92-based branch up-to-date with the public branches.
> Various inconsistencies in our process has made it difficult to automate a
> lot of this stuff.
> I'd like to work with everyone to come up with the official best practices
> and stick to it.
> I welcome all suggestions. Among some of the things I'd like to nail down:
> - Commit message format
> - Best practice and commit message format for multiple commits
> - Multiple commits per jira vs. jira per commit, what are the exceptions and
> when
> - Affects vs. Fix versions
> - Potential usage of [tags] in commit messages for things like book, scripts,
> shell... maybe even whatever is in the components field?
> - Increased usage of JIRA tags or labels to mark exactly which repos a JIRA
> has been committed to (potentially even internal repos? ways for a tool to
> keep track in JIRA?)
> We also need to be more strict about some things if we want to follow Apache
> guidelines. For example, all final versions of a patch must be attached to
> JIRA so that the author properly assigns it to Apache.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11068) Update code to use Admin factory method instead of constructor
[
https://issues.apache.org/jira/browse/HBASE-11068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082993#comment-14082993
]
Hadoop QA commented on HBASE-11068:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12659233/HBASE_11068-branch-1-v2.patch
against trunk revision .
ATTACHMENT ID: 12659233
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 297
new or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+final TableName tableName =
TableName.valueOf("testCreateTableCalledTwiceAndFirstOneInProgress");
+TEST_UTIL.getHBaseAdmin().cloneSnapshot(table+"_snapshot"+i,
TableName.valueOf(table+"_clone"+i));
+ private static int insertData(TableName tableName, String column, double
prob) throws IOException {
+HConnection unmanagedConnection =
HConnectionManager.createConnection(TEST_UTIL.getConfiguration());
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestRestartCluster
org.apache.hadoop.hbase.regionserver.TestRegionReplicas
org.apache.hadoop.hbase.TestIOFencing
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
org.apache.hadoop.hbase.client.TestReplicasClient
org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10268//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10268//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10268//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10268//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10268//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10268//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10268//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10268//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10268//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10268//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10268//console
This message is automatically generated.
> Update code to use Admin factory method instead of constructor
> --
>
> Key: HBASE-11068
> URL: https://issues.apache.org/jira/browse/HBASE-11068
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 0.99.0
>Reporter: Carter
>Assignee: Carter
> Fix For: 0.99.0
>
> Attachments: HBASE_11068-branch-1-v2.patch, HBASE_11068.patch
>
>
> Where feasible, the code should be updated to use the HConnection factory
> method for the admin interface. For instance, the following:
> {code:java}
> HBaseAdmin admin = new HBaseAdmin(conf);
> {code}
> would be changed to:
> {code:java}
> Admin admin = HConnectionManager.createConnection(conf).getAdmin();
> {code}
> This would also require updates to admin calls that refer to a tablename as
> byte[] or String.
> {code:java}
> admin.enableTable("mytable");
> {code}
> would change to:
> {code:java}
> admin.enableTable(TableName.valueOf("mytable"));
> {code}
--
This message was sen
[jira] [Updated] (HBASE-10378) Divide HLog interface into User and Implementor specific interfaces
[ https://issues.apache.org/jira/browse/HBASE-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-10378: Assignee: Sean Busbey Status: Open (was: Patch Available) > Divide HLog interface into User and Implementor specific interfaces > --- > > Key: HBASE-10378 > URL: https://issues.apache.org/jira/browse/HBASE-10378 > Project: HBase > Issue Type: Sub-task > Components: wal >Reporter: Himanshu Vashishtha >Assignee: Sean Busbey > Attachments: 10378-1.patch, 10378-2.patch > > > HBASE-5937 introduces the HLog interface as a first step to support multiple > WAL implementations. This interface is a good start, but has some > limitations/drawbacks in its current state, such as: > 1) There is no clear distinction b/w User and Implementor APIs, and it > provides APIs both for WAL users (append, sync, etc) and also WAL > implementors (Reader/Writer interfaces, etc). There are APIs which are very > much implementation specific (getFileNum, etc) and a user such as a > RegionServer shouldn't know about it. > 2) There are about 14 methods in FSHLog which are not present in HLog > interface but are used at several places in the unit test code. These tests > typecast HLog to FSHLog, which makes it very difficult to test multiple WAL > implementations without doing some ugly checks. > I'd like to propose some changes in HLog interface that would ease the multi > WAL story: > 1) Have two interfaces WAL and WALService. WAL provides APIs for > implementors. WALService provides APIs for users (such as RegionServer). > 2) A skeleton implementation of the above two interface as the base class for > other WAL implementations (AbstractWAL). It provides required fields for all > subclasses (fs, conf, log dir, etc). Make a minimal set of test only methods > and add this set in AbstractWAL. > 3) HLogFactory returns a WALService reference when creating a WAL instance; > if a user need to access impl specific APIs (there are unit tests which get > WAL from a HRegionServer and then call impl specific APIs), use AbstractWAL > type casting, > 4) Make TestHLog abstract and let all implementors provide their respective > test class which extends TestHLog (TestFSHLog, for example). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (HBASE-11627) RegionSplitter's rollingSplit terminated with "/ by zero", and the _balancedSplit file was not deleted properly
[
https://issues.apache.org/jira/browse/HBASE-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey reassigned HBASE-11627:
---
Assignee: Sean Busbey
> RegionSplitter's rollingSplit terminated with "/ by zero", and the
> _balancedSplit file was not deleted properly
> ---
>
> Key: HBASE-11627
> URL: https://issues.apache.org/jira/browse/HBASE-11627
> Project: HBase
> Issue Type: Bug
> Components: Admin, util
>Affects Versions: 0.96.2, 0.98.1
> Environment: CentOS release 6.4 (Final) x86_64 &&
> hbase-0.98.1-cdh5.1.0
>Reporter: louis hust
>Assignee: Sean Busbey
>Priority: Critical
> Labels: newbie
> Fix For: 0.96.2, 0.98.1
>
> Attachments: HBASE_11627-v2.patch, HBASE_11627-v3.patch,
> HBASE_11627-v4.patch, HBASE_11627.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> First create a table
> {quote}
> > create 't1', 'f1'
> {quote}
> Then split the table with util:
> {quote}
> > bin/hbase org.apache.hadoop.hbase.util.RegionSplitter -r -o 2 t1
> > UniformSplit
> {quote}
> *Finally get the following error :*
> {quote}
> 12/11/08 19:21:12 DEBUG util.RegionSplitter: All regions have been
> successfully split!
> 12/11/08 19:21:12 DEBUG util.RegionSplitter: TOTAL TIME = 30sec
> 12/11/08 19:21:12 DEBUG util.RegionSplitter: Splits = 0
> Exception in thread "main" java.lang.ArithmeticException: / by zero
> at
> org.apache.hadoop.hbase.util.RegionSplitter.rollingSplit(RegionSplitter.java:576)
> at
> org.apache.hadoop.hbase.util.RegionSplitter.main(RegionSplitter.java:349)
> {quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-11627) RegionSplitter's rollingSplit terminated with "/ by zero", and the _balancedSplit file was not deleted properly
[
https://issues.apache.org/jira/browse/HBASE-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-11627:
Attachment: HBASE_11627-v4.patch
reattaching v2 patch as v4 (no changes) because QA bot never took a look at it.
> RegionSplitter's rollingSplit terminated with "/ by zero", and the
> _balancedSplit file was not deleted properly
> ---
>
> Key: HBASE-11627
> URL: https://issues.apache.org/jira/browse/HBASE-11627
> Project: HBase
> Issue Type: Bug
> Components: Admin, util
>Affects Versions: 0.96.2, 0.98.1
> Environment: CentOS release 6.4 (Final) x86_64 &&
> hbase-0.98.1-cdh5.1.0
>Reporter: louis hust
>Assignee: Sean Busbey
>Priority: Critical
> Labels: newbie
> Fix For: 0.96.2, 0.98.1
>
> Attachments: HBASE_11627-v2.patch, HBASE_11627-v3.patch,
> HBASE_11627-v4.patch, HBASE_11627.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> First create a table
> {quote}
> > create 't1', 'f1'
> {quote}
> Then split the table with util:
> {quote}
> > bin/hbase org.apache.hadoop.hbase.util.RegionSplitter -r -o 2 t1
> > UniformSplit
> {quote}
> *Finally get the following error :*
> {quote}
> 12/11/08 19:21:12 DEBUG util.RegionSplitter: All regions have been
> successfully split!
> 12/11/08 19:21:12 DEBUG util.RegionSplitter: TOTAL TIME = 30sec
> 12/11/08 19:21:12 DEBUG util.RegionSplitter: Splits = 0
> Exception in thread "main" java.lang.ArithmeticException: / by zero
> at
> org.apache.hadoop.hbase.util.RegionSplitter.rollingSplit(RegionSplitter.java:576)
> at
> org.apache.hadoop.hbase.util.RegionSplitter.main(RegionSplitter.java:349)
> {quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-11627) RegionSplitter's rollingSplit terminated with "/ by zero", and the _balancedSplit file was not deleted properly
[
https://issues.apache.org/jira/browse/HBASE-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-11627:
Status: Open (was: Patch Available)
> RegionSplitter's rollingSplit terminated with "/ by zero", and the
> _balancedSplit file was not deleted properly
> ---
>
> Key: HBASE-11627
> URL: https://issues.apache.org/jira/browse/HBASE-11627
> Project: HBase
> Issue Type: Bug
> Components: Admin, util
>Affects Versions: 0.98.1, 0.96.2
> Environment: CentOS release 6.4 (Final) x86_64 &&
> hbase-0.98.1-cdh5.1.0
>Reporter: louis hust
>Assignee: Sean Busbey
>Priority: Critical
> Labels: newbie
> Fix For: 0.98.1, 0.96.2
>
> Attachments: HBASE_11627-v2.patch, HBASE_11627-v3.patch,
> HBASE_11627-v4.patch, HBASE_11627.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> First create a table
> {quote}
> > create 't1', 'f1'
> {quote}
> Then split the table with util:
> {quote}
> > bin/hbase org.apache.hadoop.hbase.util.RegionSplitter -r -o 2 t1
> > UniformSplit
> {quote}
> *Finally get the following error :*
> {quote}
> 12/11/08 19:21:12 DEBUG util.RegionSplitter: All regions have been
> successfully split!
> 12/11/08 19:21:12 DEBUG util.RegionSplitter: TOTAL TIME = 30sec
> 12/11/08 19:21:12 DEBUG util.RegionSplitter: Splits = 0
> Exception in thread "main" java.lang.ArithmeticException: / by zero
> at
> org.apache.hadoop.hbase.util.RegionSplitter.rollingSplit(RegionSplitter.java:576)
> at
> org.apache.hadoop.hbase.util.RegionSplitter.main(RegionSplitter.java:349)
> {quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-11627) RegionSplitter's rollingSplit terminated with "/ by zero", and the _balancedSplit file was not deleted properly
[
https://issues.apache.org/jira/browse/HBASE-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-11627:
Status: Patch Available (was: Open)
> RegionSplitter's rollingSplit terminated with "/ by zero", and the
> _balancedSplit file was not deleted properly
> ---
>
> Key: HBASE-11627
> URL: https://issues.apache.org/jira/browse/HBASE-11627
> Project: HBase
> Issue Type: Bug
> Components: Admin, util
>Affects Versions: 0.98.1, 0.96.2
> Environment: CentOS release 6.4 (Final) x86_64 &&
> hbase-0.98.1-cdh5.1.0
>Reporter: louis hust
>Assignee: Sean Busbey
>Priority: Critical
> Labels: newbie
> Fix For: 0.98.1, 0.96.2
>
> Attachments: HBASE_11627-v2.patch, HBASE_11627-v3.patch,
> HBASE_11627-v4.patch, HBASE_11627.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> First create a table
> {quote}
> > create 't1', 'f1'
> {quote}
> Then split the table with util:
> {quote}
> > bin/hbase org.apache.hadoop.hbase.util.RegionSplitter -r -o 2 t1
> > UniformSplit
> {quote}
> *Finally get the following error :*
> {quote}
> 12/11/08 19:21:12 DEBUG util.RegionSplitter: All regions have been
> successfully split!
> 12/11/08 19:21:12 DEBUG util.RegionSplitter: TOTAL TIME = 30sec
> 12/11/08 19:21:12 DEBUG util.RegionSplitter: Splits = 0
> Exception in thread "main" java.lang.ArithmeticException: / by zero
> at
> org.apache.hadoop.hbase.util.RegionSplitter.rollingSplit(RegionSplitter.java:576)
> at
> org.apache.hadoop.hbase.util.RegionSplitter.main(RegionSplitter.java:349)
> {quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11649) Add shortcut commands to bin/hbase for test tools
[ https://issues.apache.org/jira/browse/HBASE-11649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082968#comment-14082968 ] Hudson commented on HBASE-11649: SUCCESS: Integrated in HBase-0.98 #430 (See [https://builds.apache.org/job/HBase-0.98/430/]) HBASE-11649 Add shortcut commands to bin/hbase for test tools (apurtell: rev 0e32f563ada05063258339dea2331c0c0b877b31) * bin/hbase > Add shortcut commands to bin/hbase for test tools > - > > Key: HBASE-11649 > URL: https://issues.apache.org/jira/browse/HBASE-11649 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Trivial > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: HBASE-11649.patch > > > We should have shortcuts and HBASE_OPTS mixin support for > PerformanceEvaluation and LoadTestTool in bin/hbase. Some developer carpal > tunnel syndrome risk reduction. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10834) Better error messaging on issuing grant commands in non-authz mode
[
https://issues.apache.org/jira/browse/HBASE-10834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082966#comment-14082966
]
Srikanth Srungarapu commented on HBASE-10834:
-
Yes, this is only for 0.94 as this check is already enforced in 0.98. Please
find more details about the patch below:
* Copied the
https://github.com/apache/hbase/blob/0.98/hbase-shell/src/main/ruby/hbase/security.rb#L202
(0.98 branch) and incorporated it into 0.94 branch.
* All it does is ask the server if the _acl_ table exists. If the server
responds no such table exists, it throws an error saying authorization is
turned off.
> Better error messaging on issuing grant commands in non-authz mode
> --
>
> Key: HBASE-10834
> URL: https://issues.apache.org/jira/browse/HBASE-10834
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 0.94.17
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
>Priority: Trivial
> Attachments: HBASE-10834.patch, HBASE-10834_v2.patch,
> HBASE-10834_v3.patch
>
>
> Running the below sequence of steps should give a better error messaging
> rather than "table not found" error.
> {code}
> hbase(main):009:0> grant "test", "RWCXA"
> ERROR: Unknown table _acl_!
> Here is some help for this command:
> Grant users specific rights.
> Syntax : grant [ [ [ qualifier>]]
> permissions is either zero or more letters from the set "RWXCA".
> READ('R'), WRITE('W'), EXEC('X'), CREATE('C'), ADMIN('A')
> For example:
> hbase> grant 'bobsmith', 'RWXCA'
> hbase> grant 'bobsmith', 'RW', 't1', 'f1', 'col1'
> {code}
> Instead of ERROR: Unknown table _acl_!, hbase should give out a warning like
> "Command not supported in non-authz mode(as acl table is only created if
> authz is turned on)"
--
This message was sent by Atlassian JIRA
(v6.2#6252)
