[jira] [Created] (HBASE-12298) Support DBB usage in PrefixTree
Anoop Sam John created HBASE-12298: -- Summary: Support DBB usage in PrefixTree Key: HBASE-12298 URL: https://issues.apache.org/jira/browse/HBASE-12298 Project: HBase Issue Type: Sub-task Reporter: Anoop Sam John Assignee: ramkrishna.s.vasudevan -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-12297) Support DBB usage in Bloom and HFileIndex area
Anoop Sam John created HBASE-12297: -- Summary: Support DBB usage in Bloom and HFileIndex area Key: HBASE-12297 URL: https://issues.apache.org/jira/browse/HBASE-12297 Project: HBase Issue Type: Sub-task Reporter: Anoop Sam John Assignee: Anoop Sam John -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HBASE-12295) Prevent block eviction under us if reads are in progress from the BBs
[ https://issues.apache.org/jira/browse/HBASE-12295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan reassigned HBASE-12295: -- Assignee: ramkrishna.s.vasudevan > Prevent block eviction under us if reads are in progress from the BBs > - > > Key: HBASE-12295 > URL: https://issues.apache.org/jira/browse/HBASE-12295 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Scanners >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0 > > > While we try to serve the reads from the BBs directly from the block cache, > we need to ensure that the blocks does not get evicted under us while > reading. This JIRA is to discuss and implement a strategy for the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-12296) Filters should work with BBs
ramkrishna.s.vasudevan created HBASE-12296: -- Summary: Filters should work with BBs Key: HBASE-12296 URL: https://issues.apache.org/jira/browse/HBASE-12296 Project: HBase Issue Type: Sub-task Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0 Filters may require API changes to work with BBs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-12295) Prevent block eviction under us if reads are in progress from the BBs
ramkrishna.s.vasudevan created HBASE-12295: -- Summary: Prevent block eviction under us if reads are in progress from the BBs Key: HBASE-12295 URL: https://issues.apache.org/jira/browse/HBASE-12295 Project: HBase Issue Type: Sub-task Reporter: ramkrishna.s.vasudevan Fix For: 2.0.0 While we try to serve the reads from the BBs directly from the block cache, we need to ensure that the blocks does not get evicted under us while reading. This JIRA is to discuss and implement a strategy for the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12294) Can't build the docs after the hbase-checkstyle module was added
[
https://issues.apache.org/jira/browse/HBASE-12294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176558#comment-14176558
]
Misty Stanley-Jones commented on HBASE-12294:
-
Yes, using this command:
{code}
mvn -e clean package javadoc:aggregate site site:stage -DskipTests
{code}
> Can't build the docs after the hbase-checkstyle module was added
>
>
> Key: HBASE-12294
> URL: https://issues.apache.org/jira/browse/HBASE-12294
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Misty Stanley-Jones
>Priority: Critical
> Attachments: HBASE-12294.patch
>
>
> Since the 15th, I have not been able to build the docs. I get these errors:
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.3:stage (default-cli) on project
> hbase-checkstyle: Missing distribution management in project HBase -
> Checkstyle (org.apache.hbase:hbase-checkstyle:2.0.0-SNAPSHOT) -> [Help 1]
> {code}
> {code}
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-site-plugin:3.3:stage (default-cli) on
> project hbase-checkstyle: Missing distribution management in project HBase -
> Checkstyle (org.apache.hbase:hbase-checkstyle:2.0.0-SNAPSHOT)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:108)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:76)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:116)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:361)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Missing
> distribution management in project HBase - Checkstyle
> (org.apache.hbase:hbase-checkstyle:2.0.0-SNAPSHOT)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.getSite(AbstractDeployMojo.java:762)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.getDeployModuleDirectory(AbstractDeployMojo.java:249)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.deploy(AbstractDeployMojo.java:320)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.deployTo(AbstractDeployMojo.java:281)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.execute(AbstractDeployMojo.java:163)
> at org.apache.maven.plugins.site.SiteStageMojo.execute(SiteStageMojo.java:75)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:133)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> ... 19 more
> {code}
> I'm able to resolve it by adding the attached patch to the POM. [~eclark], is
> there a specific reason you didn't use inheritance in the checkstyles module?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12267) Replace HTable constructor in mapreduce.* classes with ConnectionFactory
[
https://issues.apache.org/jira/browse/HBASE-12267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176555#comment-14176555
]
Hadoop QA commented on HBASE-12267:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12675759/HBASE-12267_v3.patch
against trunk revision .
ATTACHMENT ID: 12675759
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:red}-1 javac{color}. The patch appears to cause mvn compile goal to
fail.
Compilation errors resume:
[ERROR] COMPILATION ERROR :
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java:[651,8]
error: constructor RegionServerCallable in class RegionServerCallable
cannot be applied to given types;
[ERROR] reason: actual argument Connection cannot be converted to HConnection
by method invocation conversion
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile)
on project hbase-server: Compilation failure: Compilation failure:
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java:[651,8]
error: constructor RegionServerCallable in class RegionServerCallable
cannot be applied to given types;
[ERROR] reason: actual argument Connection cannot be converted to HConnection
by method invocation conversion
[ERROR] where T is a type-variable:
[ERROR] T extends Object declared in class RegionServerCallable
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java:[651,66]
error: constructor RegionServerCallable in class RegionServerCallable
cannot be applied to given types;
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn -rf :hbase-server
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11401//console
This message is automatically generated.
> Replace HTable constructor in mapreduce.* classes with ConnectionFactory
> -
>
> Key: HBASE-12267
> URL: https://issues.apache.org/jira/browse/HBASE-12267
> Project: HBase
> Issue Type: Bug
>Reporter: Solomon Duskis
>Assignee: Solomon Duskis
> Fix For: 2.0.0, 0.99.2
>
> Attachments: HBASE-12267.patch, HBASE-12267_v2.patch,
> HBASE-12267_v3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12267) Replace HTable constructor in mapreduce.* classes with ConnectionFactory
[ https://issues.apache.org/jira/browse/HBASE-12267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Solomon Duskis updated HBASE-12267: --- Attachment: HBASE-12267_v3.patch Fixed the failing test. > Replace HTable constructor in mapreduce.* classes with ConnectionFactory > - > > Key: HBASE-12267 > URL: https://issues.apache.org/jira/browse/HBASE-12267 > Project: HBase > Issue Type: Bug >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12267.patch, HBASE-12267_v2.patch, > HBASE-12267_v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10201) Port 'Make flush decisions per column family' to trunk
[ https://issues.apache.org/jira/browse/HBASE-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176543#comment-14176543 ] zhangduo commented on HBASE-10201: -- sorry, should be [~stack] > Port 'Make flush decisions per column family' to trunk > -- > > Key: HBASE-10201 > URL: https://issues.apache.org/jira/browse/HBASE-10201 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu > Attachments: 3149-trunk-v1.txt, HBASE-10201-0.98.patch, > HBASE-10201-0.98_1.patch, HBASE-10201-0.98_2.patch > > > Currently the flush decision is made using the aggregate size of all column > families. When large and small column families co-exist, this causes many > small flushes of the smaller CF. We need to make per-CF flush decisions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12249) Script to help you adhere to the patch-naming guidelines
[
https://issues.apache.org/jira/browse/HBASE-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176541#comment-14176541
]
Hadoop QA commented on HBASE-12249:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12675751/HBASE-12249-v2.patch
against trunk revision .
ATTACHMENT ID: 12675751
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation patch that doesn't require tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11400//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11400//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11400//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11400//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11400//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11400//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11400//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11400//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11400//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11400//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11400//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11400//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11400//console
This message is automatically generated.
> Script to help you adhere to the patch-naming guidelines
>
>
> Key: HBASE-12249
> URL: https://issues.apache.org/jira/browse/HBASE-12249
> Project: HBase
> Issue Type: Improvement
> Components: documentation, scripts
>Reporter: Misty Stanley-Jones
>Assignee: Misty Stanley-Jones
>Priority: Minor
> Attachments: HBASE-12249-v1.patch, HBASE-12249-v2.patch,
> HBASE-12249.patch
>
>
> I wrote a script to help me name patches correctly, and it may be helpful to
> others. You use it from the branch where you are working, and it looks in
> your patches directory to see if other versions of the patch exist, and
> appends -v if so. If you specify -a, it creates an addendum patch,
> by appending -v-addendum.
> In summary, it makes patches named like:
> HBASE-.patch
> HBASE--vY.patch
> HBASE--addendum.patch
> HBASE--vY-addendum.patch
> The patch uses git format-patch if you have only one local commit, otherwise
> lets you rebase or use git diff. It does not use --no-prefix.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12294) Can't build the docs after the hbase-checkstyle module was added
[
https://issues.apache.org/jira/browse/HBASE-12294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176542#comment-14176542
]
Elliott Clark commented on HBASE-12294:
---
-1
Can't have a parent for checkstyle. The site builds just fine for the hadoop
qa bot. Are you using package before site ?
> Can't build the docs after the hbase-checkstyle module was added
>
>
> Key: HBASE-12294
> URL: https://issues.apache.org/jira/browse/HBASE-12294
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Misty Stanley-Jones
>Priority: Critical
> Attachments: HBASE-12294.patch
>
>
> Since the 15th, I have not been able to build the docs. I get these errors:
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.3:stage (default-cli) on project
> hbase-checkstyle: Missing distribution management in project HBase -
> Checkstyle (org.apache.hbase:hbase-checkstyle:2.0.0-SNAPSHOT) -> [Help 1]
> {code}
> {code}
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-site-plugin:3.3:stage (default-cli) on
> project hbase-checkstyle: Missing distribution management in project HBase -
> Checkstyle (org.apache.hbase:hbase-checkstyle:2.0.0-SNAPSHOT)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:108)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:76)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:116)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:361)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Missing
> distribution management in project HBase - Checkstyle
> (org.apache.hbase:hbase-checkstyle:2.0.0-SNAPSHOT)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.getSite(AbstractDeployMojo.java:762)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.getDeployModuleDirectory(AbstractDeployMojo.java:249)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.deploy(AbstractDeployMojo.java:320)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.deployTo(AbstractDeployMojo.java:281)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.execute(AbstractDeployMojo.java:163)
> at org.apache.maven.plugins.site.SiteStageMojo.execute(SiteStageMojo.java:75)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:133)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> ... 19 more
> {code}
> I'm able to resolve it by adding the attached patch to the POM. [~eclark], is
> there a specific reason you didn't use inheritance in the checkstyles module?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-10201) Port 'Make flush decisions per column family' to trunk
[ https://issues.apache.org/jira/browse/HBASE-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176532#comment-14176532 ] zhangduo commented on HBASE-10201: -- [~saint@gmail.com], [~eclark], [~eclark] excuse me, I am currently working on porting HBASE-3149. I ported it to 0.98 and collected some stats. The result was posted above. I need some help to know whether it is worth to solve "many flushes of small CFs" by this approach, and also some comments of the patch itself. Thanks very much. > Port 'Make flush decisions per column family' to trunk > -- > > Key: HBASE-10201 > URL: https://issues.apache.org/jira/browse/HBASE-10201 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu > Attachments: 3149-trunk-v1.txt, HBASE-10201-0.98.patch, > HBASE-10201-0.98_1.patch, HBASE-10201-0.98_2.patch > > > Currently the flush decision is made using the aggregate size of all column > families. When large and small column families co-exist, this causes many > small flushes of the smaller CF. We need to make per-CF flush decisions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12294) Can't build the docs after the hbase-checkstyle module was added
[
https://issues.apache.org/jira/browse/HBASE-12294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176508#comment-14176508
]
Hadoop QA commented on HBASE-12294:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12675748/HBASE-12294.patch
against trunk revision .
ATTACHMENT ID: 12675748
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:red}-1 release audit{color}. The applied patch generated 2 release
audit warnings (more than the trunk's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11399//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11399//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11399//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11399//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11399//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11399//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11399//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11399//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11399//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11399//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11399//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11399//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11399//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11399//console
This message is automatically generated.
> Can't build the docs after the hbase-checkstyle module was added
>
>
> Key: HBASE-12294
> URL: https://issues.apache.org/jira/browse/HBASE-12294
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Misty Stanley-Jones
>Priority: Critical
> Attachments: HBASE-12294.patch
>
>
> Since the 15th, I have not been able to build the docs. I get these errors:
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.3:stage (default-cli) on project
> hbase-checkstyle: Missing distribution management in project HBase -
> Checkstyle (org.apache.hbase:hbase-checkstyle:2.0.0-SNAPSHOT) -> [Help 1]
> {code}
> {code}
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-site-plugin:3.3:stage (default-cli) on
> project hbase-checkstyle: Missing distribution management in project HBase -
> Checkstyle (org.apache.hbase:hbase-checkstyle:2.0.0-SNAPSHOT)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecu
[jira] [Updated] (HBASE-12249) Script to help you adhere to the patch-naming guidelines
[ https://issues.apache.org/jira/browse/HBASE-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Misty Stanley-Jones updated HBASE-12249: Attachment: HBASE-12249-v2.patch This patch includes some style improvements, checks to see if your local directory is dirty (has uncommitted changes), and accepts a patch directory as an argument (-d ). If you don't specify a directory, it falls back to ~patches. It also creates the patch directory if necessary. If accepted, I'll update the necessary docs on commit. [~dimaspivak] and others feedback appreciated. > Script to help you adhere to the patch-naming guidelines > > > Key: HBASE-12249 > URL: https://issues.apache.org/jira/browse/HBASE-12249 > Project: HBase > Issue Type: Improvement > Components: documentation, scripts >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones >Priority: Minor > Attachments: HBASE-12249-v1.patch, HBASE-12249-v2.patch, > HBASE-12249.patch > > > I wrote a script to help me name patches correctly, and it may be helpful to > others. You use it from the branch where you are working, and it looks in > your patches directory to see if other versions of the patch exist, and > appends -v if so. If you specify -a, it creates an addendum patch, > by appending -v-addendum. > In summary, it makes patches named like: > HBASE-.patch > HBASE--vY.patch > HBASE--addendum.patch > HBASE--vY-addendum.patch > The patch uses git format-patch if you have only one local commit, otherwise > lets you rebase or use git diff. It does not use --no-prefix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12294) Can't build the docs after the hbase-checkstyle module was added
[
https://issues.apache.org/jira/browse/HBASE-12294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Misty Stanley-Jones updated HBASE-12294:
Status: Patch Available (was: Open)
> Can't build the docs after the hbase-checkstyle module was added
>
>
> Key: HBASE-12294
> URL: https://issues.apache.org/jira/browse/HBASE-12294
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Misty Stanley-Jones
>Priority: Critical
> Attachments: HBASE-12294.patch
>
>
> Since the 15th, I have not been able to build the docs. I get these errors:
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.3:stage (default-cli) on project
> hbase-checkstyle: Missing distribution management in project HBase -
> Checkstyle (org.apache.hbase:hbase-checkstyle:2.0.0-SNAPSHOT) -> [Help 1]
> {code}
> {code}
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-site-plugin:3.3:stage (default-cli) on
> project hbase-checkstyle: Missing distribution management in project HBase -
> Checkstyle (org.apache.hbase:hbase-checkstyle:2.0.0-SNAPSHOT)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:108)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:76)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:116)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:361)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Missing
> distribution management in project HBase - Checkstyle
> (org.apache.hbase:hbase-checkstyle:2.0.0-SNAPSHOT)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.getSite(AbstractDeployMojo.java:762)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.getDeployModuleDirectory(AbstractDeployMojo.java:249)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.deploy(AbstractDeployMojo.java:320)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.deployTo(AbstractDeployMojo.java:281)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.execute(AbstractDeployMojo.java:163)
> at org.apache.maven.plugins.site.SiteStageMojo.execute(SiteStageMojo.java:75)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:133)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> ... 19 more
> {code}
> I'm able to resolve it by adding the attached patch to the POM. [~eclark], is
> there a specific reason you didn't use inheritance in the checkstyles module?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12294) Can't build the docs after the hbase-checkstyle module was added
[
https://issues.apache.org/jira/browse/HBASE-12294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Misty Stanley-Jones updated HBASE-12294:
Attachment: HBASE-12294.patch
> Can't build the docs after the hbase-checkstyle module was added
>
>
> Key: HBASE-12294
> URL: https://issues.apache.org/jira/browse/HBASE-12294
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Misty Stanley-Jones
>Priority: Critical
> Attachments: HBASE-12294.patch
>
>
> Since the 15th, I have not been able to build the docs. I get these errors:
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.3:stage (default-cli) on project
> hbase-checkstyle: Missing distribution management in project HBase -
> Checkstyle (org.apache.hbase:hbase-checkstyle:2.0.0-SNAPSHOT) -> [Help 1]
> {code}
> {code}
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-site-plugin:3.3:stage (default-cli) on
> project hbase-checkstyle: Missing distribution management in project HBase -
> Checkstyle (org.apache.hbase:hbase-checkstyle:2.0.0-SNAPSHOT)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:108)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:76)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:116)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:361)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Missing
> distribution management in project HBase - Checkstyle
> (org.apache.hbase:hbase-checkstyle:2.0.0-SNAPSHOT)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.getSite(AbstractDeployMojo.java:762)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.getDeployModuleDirectory(AbstractDeployMojo.java:249)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.deploy(AbstractDeployMojo.java:320)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.deployTo(AbstractDeployMojo.java:281)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.execute(AbstractDeployMojo.java:163)
> at org.apache.maven.plugins.site.SiteStageMojo.execute(SiteStageMojo.java:75)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:133)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> ... 19 more
> {code}
> I'm able to resolve it by adding the attached patch to the POM. [~eclark], is
> there a specific reason you didn't use inheritance in the checkstyles module?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-12294) Can't build the docs after the hbase-checkstyle module was added
Misty Stanley-Jones created HBASE-12294:
---
Summary: Can't build the docs after the hbase-checkstyle module
was added
Key: HBASE-12294
URL: https://issues.apache.org/jira/browse/HBASE-12294
Project: HBase
Issue Type: Bug
Components: build
Reporter: Misty Stanley-Jones
Priority: Critical
Since the 15th, I have not been able to build the docs. I get these errors:
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.3:stage (default-cli) on project
hbase-checkstyle: Missing distribution management in project HBase - Checkstyle
(org.apache.hbase:hbase-checkstyle:2.0.0-SNAPSHOT) -> [Help 1]
{code}
{code}
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.3:stage (default-cli) on project
hbase-checkstyle: Missing distribution management in project HBase - Checkstyle
(org.apache.hbase:hbase-checkstyle:2.0.0-SNAPSHOT)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:108)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:76)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:116)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:361)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: Missing distribution
management in project HBase - Checkstyle
(org.apache.hbase:hbase-checkstyle:2.0.0-SNAPSHOT)
at
org.apache.maven.plugins.site.AbstractDeployMojo.getSite(AbstractDeployMojo.java:762)
at
org.apache.maven.plugins.site.AbstractDeployMojo.getDeployModuleDirectory(AbstractDeployMojo.java:249)
at
org.apache.maven.plugins.site.AbstractDeployMojo.deploy(AbstractDeployMojo.java:320)
at
org.apache.maven.plugins.site.AbstractDeployMojo.deployTo(AbstractDeployMojo.java:281)
at
org.apache.maven.plugins.site.AbstractDeployMojo.execute(AbstractDeployMojo.java:163)
at org.apache.maven.plugins.site.SiteStageMojo.execute(SiteStageMojo.java:75)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:133)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
... 19 more
{code}
I'm able to resolve it by adding the attached patch to the POM. [~eclark], is
there a specific reason you didn't use inheritance in the checkstyles module?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (HBASE-11912) Catch some bad practices at compile time with error-prone
[ https://issues.apache.org/jira/browse/HBASE-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176448#comment-14176448 ] Andrew Purtell edited comment on HBASE-11912 at 10/19/14 9:58 PM: -- Here's an updated patch that works with latest master. Unfortunately we must avoid using error-prone, on a per-module basis, on the default-compile or default-testCompile compiler execution (or both) where there are generated protobuf sources. This is because generated protobuf code trips an error-prone ERROR rule and directives for the Maven compiler plugin, from version 2.2 and higher will not prevent compilation of classes within source directories _that are needed for successful compilation_ even if they have been excluded. We use error-prone + javac to compile module main and test sources in two different phases, except: - hbase-annotations: No executable code here - hbase-assembly: No code here - hbase-checkstyle: No code here - hbase-native-client: No java code here - hbase-protocol: Generated protobuf code trips error-prone ERROR rule - hbase-rest: Generated protobuf code trips error-prone ERROR rule - hbase-server: Main sources only. We exclude test code because generated protobuf code trips error-prone ERROR rule I think is as good as we can do until we switch to a custom version of error-prone, which is the plan I think, since error-prone adds only marginal value beyond FindBugs and Checkstyle unless we pursuing development of additional plugins that flag new anti-patterns we agree are as such. was (Author: apurtell): Here's an updated patch that works with latest master. Unfortunately we must avoid using error-prone, on a per-module basis, on the default-compile or default-testCompile compiler execution (or both) where there are generated protobuf sources. This is because generated protobuf code trips an error-prone ERROR rule and directives for the Maven compiler plugin, from version 2.2 and higher will not prevent compilation of classes within source directories _that are needed for successful compilation_ even if they have been excluded. We use error-prone + javac to compile module main and test sources in two different phases, except: - hbase-annotations: No code here - hbase-assembly: No code here - hbase-checkstyle: No code here - hbase-native-client: No java code here - hbase-protocol: Generated protobuf code trips error-prone ERROR rule - hbase-rest: Generated protobuf code trips error-prone ERROR rule - hbase-server: Main sources only. We exclude test code because generated protobuf code trips error-prone ERROR rule I think is as good as we can do until we switch to a custom version of error-prone, which is the plan I think, since error-prone adds only marginal value beyond FindBugs and Checkstyle unless we pursuing development of additional plugins that flag new anti-patterns we agree are as such. > Catch some bad practices at compile time with error-prone > - > > Key: HBASE-11912 > URL: https://issues.apache.org/jira/browse/HBASE-11912 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell > Attachments: HBASE-11912.patch, HBASE-11912.patch, HBASE-11912.patch > > > Google's error-prone (https://code.google.com/p/error-prone/) wraps javac > with some additional static analysis that will generate additional warnings > or errors at compile time if certain bug patterns > (https://code.google.com/p/error-prone/wiki/BugPatterns) are detected. What's > nice about this approach, as opposed to findbugs, is the compile time > detection and erroring out prevent the detected problems from getting into > the codebase up front. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-11912) Catch some bad practices at compile time with error-prone
[ https://issues.apache.org/jira/browse/HBASE-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-11912: --- Attachment: HBASE-11912.patch Here's an updated patch that works with latest master. Unfortunately we must avoid using error-prone, on a per-module basis, on the default-compile or default-testCompile compiler execution (or both) where there are generated protobuf sources. This is because generated protobuf code trips an error-prone ERROR rule and directives for the Maven compiler plugin, from version 2.2 and higher will not prevent compilation of classes within source directories _that are needed for successful compilation_ even if they have been excluded. We use error-prone + javac to compile module main and test sources in two different phases, except: - hbase-annotations: No code here - hbase-assembly: No code here - hbase-checkstyle: No code here - hbase-native-client: No java code here - hbase-protocol: Generated protobuf code trips error-prone ERROR rule - hbase-rest: Generated protobuf code trips error-prone ERROR rule - hbase-server: Main sources only. We exclude test code because generated protobuf code trips error-prone ERROR rule I think is as good as we can do until we switch to a custom version of error-prone, which is the plan I think, since error-prone adds only marginal value beyond FindBugs and Checkstyle unless we pursuing development of additional plugins that flag new anti-patterns we agree are as such. > Catch some bad practices at compile time with error-prone > - > > Key: HBASE-11912 > URL: https://issues.apache.org/jira/browse/HBASE-11912 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell > Attachments: HBASE-11912.patch, HBASE-11912.patch, HBASE-11912.patch > > > Google's error-prone (https://code.google.com/p/error-prone/) wraps javac > with some additional static analysis that will generate additional warnings > or errors at compile time if certain bug patterns > (https://code.google.com/p/error-prone/wiki/BugPatterns) are detected. What's > nice about this approach, as opposed to findbugs, is the compile time > detection and erroring out prevent the detected problems from getting into > the codebase up front. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12293) Tests are logging too much
[ https://issues.apache.org/jira/browse/HBASE-12293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176423#comment-14176423 ] Elliott Clark commented on HBASE-12293: --- The easiest thing would be to change the log4j properties on tests to warn: https://github.com/apache/hbase/blob/master/hbase-server/src/test/resources/log4j.properties#L59 Then it's just a matter of looking for the few tests that change things to be Trace and removing those lines. > Tests are logging too much > -- > > Key: HBASE-12293 > URL: https://issues.apache.org/jira/browse/HBASE-12293 > Project: HBase > Issue Type: Bug > Components: test >Reporter: Dima Spivak >Assignee: Dima Spivak >Priority: Minor > > In trying to solve HBASE-12285, it was pointed out that tests are writing too > much to output again. At best, this is a sloppy practice and, at worst, it > leaves us open to builds breaking when our test tools can't handle the flood. > If [~nkeywal] would be willing give me a little bit of mentoring on how he > dealt with this problem a few years back, I'd be happy to add it to my plate. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12292) Add test that verifies newly added region server is assigned regions by load balancer
[ https://issues.apache.org/jira/browse/HBASE-12292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176422#comment-14176422 ] Ted Yu commented on HBASE-12292: Note: in the test, hbase.balancer.period is set very short. In production, such setting is not realistic. This means that there may be at most hbase.balancer.period gap between a server is added and when it is assigned region(s). > Add test that verifies newly added region server is assigned regions by load > balancer > - > > Key: HBASE-12292 > URL: https://issues.apache.org/jira/browse/HBASE-12292 > Project: HBase > Issue Type: Test >Affects Versions: 0.98.7 >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 12292-test-0.98.txt > > > Here is a unit test (based on 0.98) that verifies newly started region server > is assigned regions: > A region server is brought down in the cluster. > A new server is started. > After balancer chore runs, the new region server is assigned regions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HBASE-12292) Add test that verifies newly added region server is assigned regions by load balancer
[
https://issues.apache.org/jira/browse/HBASE-12292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176381#comment-14176381
]
Ted Yu edited comment on HBASE-12292 at 10/19/14 8:55 PM:
--
Test which passes on 0.98
was (Author: yuzhih...@gmail.com):
Test which currently fails:
Sample of tail of test output:
{code}
2014-10-19 11:38:02,496 INFO [Thread-63]
master.TestRegionBalanceAfterRSRestart(191): In 280 iteration
2014-10-19 11:38:05,527 INFO [Thread-63]
master.TestRegionBalanceAfterRSRestart(191): In 290 iteration
2014-10-19 11:38:08,561 INFO [Thread-63]
master.TestRegionBalanceAfterRSRestart(191): In 300 iteration
{code}
> Add test that verifies newly added region server is assigned regions by load
> balancer
> -
>
> Key: HBASE-12292
> URL: https://issues.apache.org/jira/browse/HBASE-12292
> Project: HBase
> Issue Type: Test
>Affects Versions: 0.98.7
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 12292-test-0.98.txt
>
>
> Here is a unit test (based on 0.98) that verifies newly started region server
> is assigned regions:
> A region server is brought down in the cluster.
> A new server is started.
> After balancer chore runs, the new region server is assigned regions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12292) Add test that verifies newly added region server is assigned regions by load balancer
[ https://issues.apache.org/jira/browse/HBASE-12292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-12292: --- Attachment: (was: 12292-test-0.98.txt) > Add test that verifies newly added region server is assigned regions by load > balancer > - > > Key: HBASE-12292 > URL: https://issues.apache.org/jira/browse/HBASE-12292 > Project: HBase > Issue Type: Test >Affects Versions: 0.98.7 >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 12292-test-0.98.txt > > > Here is a unit test (based on 0.98) that verifies newly started region server > is assigned regions: > A region server is brought down in the cluster. > A new server is started. > After balancer chore runs, the new region server is assigned regions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12292) Add test that verifies newly added region server is assigned regions by load balancer
[ https://issues.apache.org/jira/browse/HBASE-12292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-12292: --- Attachment: 12292-test-0.98.txt > Add test that verifies newly added region server is assigned regions by load > balancer > - > > Key: HBASE-12292 > URL: https://issues.apache.org/jira/browse/HBASE-12292 > Project: HBase > Issue Type: Test >Affects Versions: 0.98.7 >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 12292-test-0.98.txt > > > Here is a unit test (based on 0.98) that verifies newly started region server > is assigned regions: > A region server is brought down in the cluster. > A new server is started. > After balancer chore runs, the new region server is assigned regions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12292) Add test that verifies newly added region server is assigned regions by load balancer
[ https://issues.apache.org/jira/browse/HBASE-12292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-12292: --- Description: Here is a unit test (based on 0.98) that verifies newly started region server is assigned regions: A region server is brought down in the cluster. A new server is started. After balancer chore runs, the new region server is assigned regions. was: I observed this during cluster testing. Here is a unit test (based on 0.98) showing the issue: A region server is brought down in the cluster. A new server is started. After many iterations of balancer chore runs, the new region server is still not assigned any region. Priority: Minor (was: Major) Issue Type: Test (was: Bug) > Add test that verifies newly added region server is assigned regions by load > balancer > - > > Key: HBASE-12292 > URL: https://issues.apache.org/jira/browse/HBASE-12292 > Project: HBase > Issue Type: Test >Affects Versions: 0.98.7 >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 12292-test-0.98.txt > > > Here is a unit test (based on 0.98) that verifies newly started region server > is assigned regions: > A region server is brought down in the cluster. > A new server is started. > After balancer chore runs, the new region server is assigned regions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12292) Add test that verifies newly added region server is assigned regions by load balancer
[ https://issues.apache.org/jira/browse/HBASE-12292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-12292: --- Summary: Add test that verifies newly added region server is assigned regions by load balancer (was: Newly added region server is not assigned regions by load balancer) > Add test that verifies newly added region server is assigned regions by load > balancer > - > > Key: HBASE-12292 > URL: https://issues.apache.org/jira/browse/HBASE-12292 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.7 >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 12292-test-0.98.txt > > > I observed this during cluster testing. > Here is a unit test (based on 0.98) showing the issue: > A region server is brought down in the cluster. > A new server is started. > After many iterations of balancer chore runs, the new region server is still > not assigned any region. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-12293) Tests are logging too much
Dima Spivak created HBASE-12293: --- Summary: Tests are logging too much Key: HBASE-12293 URL: https://issues.apache.org/jira/browse/HBASE-12293 Project: HBase Issue Type: Bug Components: test Reporter: Dima Spivak Assignee: Dima Spivak Priority: Minor In trying to solve HBASE-12285, it was pointed out that tests are writing too much to output again. At best, this is a sloppy practice and, at worst, it leaves us open to builds breaking when our test tools can't handle the flood. If [~nkeywal] would be willing give me a little bit of mentoring on how he dealt with this problem a few years back, I'd be happy to add it to my plate. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12285) Builds are failing, possibly because of SUREFIRE-1091
[ https://issues.apache.org/jira/browse/HBASE-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176407#comment-14176407 ] Dima Spivak commented on HBASE-12285: - [It is also on trunk|https://github.com/apache/hbase/commit/018bbc09931d45afa349a76fcc72283013e1d3a2], but as [~nkeywal] pointed out, it may not be failing there if that test output is a bit less verbose. I'll file a separate issue to address the log too much phenomenon, but we may want to back out HBASE-4955 temporarily to get the build on branch-1 to stop failing. > Builds are failing, possibly because of SUREFIRE-1091 > - > > Key: HBASE-12285 > URL: https://issues.apache.org/jira/browse/HBASE-12285 > Project: HBase > Issue Type: Bug >Affects Versions: 1.0.0 >Reporter: Dima Spivak >Assignee: Dima Spivak >Priority: Blocker > > Our branch-1 builds on builds.apache.org have been failing in recent days > after we switched over to an official version of Surefire a few days back > (HBASE-4955). The version we're using, 2.17, is hit by a bug > ([SUREFIRE-1091|https://jira.codehaus.org/browse/SUREFIRE-1091]) that results > in an IOException, which looks like what we're seeing on Jenkins. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12278) Race condition in TestSecureLoadIncrementalHFilesSplitRecovery
[ https://issues.apache.org/jira/browse/HBASE-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176398#comment-14176398 ] Dima Spivak commented on HBASE-12278: - Can't we all just get along? :) My two cents, since I'm sorry to say that my day's delay in posting a patch apparently caused this conflict: I'm totally fine with someone solving a problem that I noticed but didn't fix (just a week back, Stack fixed HBASE-12212 for me because I wasn't familiar with what needed to be done). That said, I can understand frustration when an established member of the community jumps in on an issue that a new contributor has put effort toward solving; it definitely has the potential to chill contributions. Personally, I'm less concerned about getting credit for a patch than about having my test rig stable, but if I were just starting out on this project, I could see what happened here as evidence that HBase developers compete to get patches up first instead of cooperating. This all goes out the door, of course, if someone had filed an unassigned critical blocker that I assigned myself to before taking my sweet time to fix, but [~yuzhih...@gmail.com], you yourself made a point for me to re-prioritize a nearly-identical fix (HBASE-12229) as minor, so I was frankly a little taken aback by how important you thought it was to get this patch up before I had the chance to. Lost in all of this is that TestSecureLoadIncrementalHFilesSplitRecovery (jeez, what a mouthful) still has a race condition. Can someone please push the fix so that we can have a big group hug and go fix other flakey tests? :) > Race condition in TestSecureLoadIncrementalHFilesSplitRecovery > -- > > Key: HBASE-12278 > URL: https://issues.apache.org/jira/browse/HBASE-12278 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 1.0.0 >Reporter: Dima Spivak >Assignee: Dima Spivak >Priority: Minor > Attachments: 12278-v1.txt, 12278-v2.txt > > > I sometimes get #testGroupOrSplitWhenRegionHoleExistsInMeta to error out on > me because of a TableNotFoundException. Fix is pretty simple and will involve > a little bit of test refactoring to get rid of some duplicate behavior that's > done better in HBaseTestingUtility anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12287) Add retry runners to the most commonly failing tests
[ https://issues.apache.org/jira/browse/HBASE-12287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176395#comment-14176395 ] Alex Newman commented on HBASE-12287: - i think it's a short term solution. I'm also tracking the long term of the goal of cleaning test interference and generally making them run faster. — Sent from Mailbox on a small glass box On Sun, Oct 19, 2014 at 12:06 PM, Dima Spivak (JIRA) > Add retry runners to the most commonly failing tests > > > Key: HBASE-12287 > URL: https://issues.apache.org/jira/browse/HBASE-12287 > Project: HBase > Issue Type: Sub-task >Reporter: Alex Newman >Assignee: Alex Newman > Attachments: HBASE-12287.patch > > > Many of our tests have nondeterministic behavior due to inter-test > interference. Usually restarting the test is enough to verify whether it is > test interference or a broken test. Lets use a retry runner which runs the > aftertest->before test and reruns the tests 10 times. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12287) Add retry runners to the most commonly failing tests
[ https://issues.apache.org/jira/browse/HBASE-12287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176389#comment-14176389 ] Dima Spivak commented on HBASE-12287: - I love anything that gets test runs to go green, but is this the best approach when the real problem is "tests have nondeterministic behavior due to inter-test interference"? > Add retry runners to the most commonly failing tests > > > Key: HBASE-12287 > URL: https://issues.apache.org/jira/browse/HBASE-12287 > Project: HBase > Issue Type: Sub-task >Reporter: Alex Newman >Assignee: Alex Newman > Attachments: HBASE-12287.patch > > > Many of our tests have nondeterministic behavior due to inter-test > interference. Usually restarting the test is enough to verify whether it is > test interference or a broken test. Lets use a retry runner which runs the > aftertest->before test and reruns the tests 10 times. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12292) Newly added region server is not assigned regions by load balancer
[
https://issues.apache.org/jira/browse/HBASE-12292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-12292:
---
Attachment: 12292-test-0.98.txt
Test which currently fails:
Sample of tail of test output:
{code}
2014-10-19 11:38:02,496 INFO [Thread-63]
master.TestRegionBalanceAfterRSRestart(191): In 280 iteration
2014-10-19 11:38:05,527 INFO [Thread-63]
master.TestRegionBalanceAfterRSRestart(191): In 290 iteration
2014-10-19 11:38:08,561 INFO [Thread-63]
master.TestRegionBalanceAfterRSRestart(191): In 300 iteration
{code}
> Newly added region server is not assigned regions by load balancer
> --
>
> Key: HBASE-12292
> URL: https://issues.apache.org/jira/browse/HBASE-12292
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.98.7
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 12292-test-0.98.txt
>
>
> I observed this during cluster testing.
> Here is a unit test (based on 0.98) showing the issue:
> A region server is brought down in the cluster.
> A new server is started.
> After many iterations of balancer chore runs, the new region server is still
> not assigned any region.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-12292) Newly added region server is not assigned regions by load balancer
Ted Yu created HBASE-12292: -- Summary: Newly added region server is not assigned regions by load balancer Key: HBASE-12292 URL: https://issues.apache.org/jira/browse/HBASE-12292 Project: HBase Issue Type: Bug Affects Versions: 0.98.7 Reporter: Ted Yu Assignee: Ted Yu I observed this during cluster testing. Here is a unit test (based on 0.98) showing the issue: A region server is brought down in the cluster. A new server is started. After many iterations of balancer chore runs, the new region server is still not assigned any region. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-4755) HBase based block placement in DFS
[ https://issues.apache.org/jira/browse/HBASE-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jianshi Huang updated HBASE-4755: - Description: The feature as is only useful for HBase clusters that care about data locality on regionservers, but this feature can also enable a lot of nice features down the road. The basic idea is as follows: instead of letting HDFS determine where to replicate data (r=3) by place blocks on various regions, it is better to let HBase do so by providing hints to HDFS through the DFS client. That way instead of replicating data at a blocks level, we can replicate data at a per-region level (each region owned by a promary, a secondary and a tertiary regionserver). This is better for 2 things: - Can make region failover faster on clusters which benefit from data affinity - On large clusters with random block placement policy, this helps reduce the probability of data loss The algo is as follows: - Each region in META will have 3 columns which are the preferred regionservers for that region (primary, secondary and tertiary) - Preferred assignment can be controlled by a config knob - Upon cluster start, HMaster will enter a mapping from each region to 3 regionservers (random hash, could use current locality, etc) - The load balancer would assign out regions preferring region assignments to primary over secondary over tertiary over any other node - Periodically (say weekly, configurable) the HMaster would run a locality checked and make sure the map it has for region to regionservers is optimal. Down the road, this can be enhanced to control region placement in the following cases: - Mixed hardware SKU where some regionservers can hold fewer regions - Load balancing across tables where we dont want multiple regions of a table to get assigned to the same regionservers - Multi-tenancy, where we can restrict the assignment of the regions of some table to a subset of regionservers, so an abusive app cannot take down the whole HBase cluster. was: The feature as is only useful for HBase clusters that care about data locality on regionservers, but this feature can also enable a lot of nice features down the road. The basic idea is as follows: instead of letting HDFS determine where to replicate data (r=3) by place blocks on various regions, it is better to let HBase do so by providing hints to HDFS through the DFS client. That way instead of replicating data at a blocks level, we can replicate data at a per-region level (each region owned by a promary, a secondary and a tertiary regionserver). This is better for 2 things: - Can make region failover faster on clusters which benefit from data affinity - On large clusters with random block placement policy, this helps reduce the probability of data loss The algo is as follows: - Each region in META will have 3 columns which are the preferred regionservers for that region (primary, secondary and tertiary) - Preferred assignment can be controlled by a config knob - Upon cluster start, HMaster will enter a mapping from each region to 3 regionservers (random hash, could use current locality, etc) - The load balancer would assign out regions preferring region assignments to primary over secondary over tertiary over any other node - Periodically (say weekly, configurable) the HMaster would run a locality checked and make sure the map it has for region to regionservers is optimal. Down the road, this can be enhanced to control region placement in the following cases: - Mixed hardware SKU where some regionservers can hold fewer regions - Load balancing across tables where we dont want multiple regions of a table to get assigned to the same regionservers - Multi-tenancy, where we can restrict the assignment of the regions of some table to a subset of regionservers, so an abusive app cannot take down the whole HBase cluster. > HBase based block placement in DFS > -- > > Key: HBASE-4755 > URL: https://issues.apache.org/jira/browse/HBASE-4755 > Project: HBase > Issue Type: New Feature >Affects Versions: 0.94.0 >Reporter: Karthik Ranganathan >Assignee: Christopher Gist >Priority: Critical > Attachments: 4755-wip-1.patch, hbase-4755-notes.txt > > > The feature as is only useful for HBase clusters that care about data > locality on regionservers, but this feature can also enable a lot of nice > features down the road. > The basic idea is as follows: instead of letting HDFS determine where to > replicate data (r=3) by place blocks on various regions, it is better to let > HBase do so by providing hints to HDFS through the DFS client. That way > instead of replicating data at a blocks level, we can replicate data at a > per-region level (each region owned by a promary, a secondary and a tertiary > regionserver
[jira] [Created] (HBASE-12291) Create Read only buffers where ever possible
ramkrishna.s.vasudevan created HBASE-12291: -- Summary: Create Read only buffers where ever possible Key: HBASE-12291 URL: https://issues.apache.org/jira/browse/HBASE-12291 Project: HBase Issue Type: Sub-task Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan This issue is to see if we can really create a Read only buffer in the read path. Later can see if this needs to be BR or our own BB impl. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12202) Support DirectByteBuffer usage in HFileBlock
[ https://issues.apache.org/jira/browse/HBASE-12202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176356#comment-14176356 ] ramkrishna.s.vasudevan commented on HBASE-12202: Ya good with the patch. And surely a later clean up for getting Read only BB. BB already has the facility to create actual read only buffer. We can do that in the clean up. > Support DirectByteBuffer usage in HFileBlock > > > Key: HBASE-12202 > URL: https://issues.apache.org/jira/browse/HBASE-12202 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Scanners >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12202.patch, HBASE-12202_V2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-12290) Column trackers and delete trackers should deal with BBs
ramkrishna.s.vasudevan created HBASE-12290: -- Summary: Column trackers and delete trackers should deal with BBs Key: HBASE-12290 URL: https://issues.apache.org/jira/browse/HBASE-12290 Project: HBase Issue Type: Sub-task Affects Versions: 0.99.1 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0, 0.99.2 All the trackers should deal with BBs if we need E2E BB usage in the read path. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11912) Catch some bad practices at compile time with error-prone
[ https://issues.apache.org/jira/browse/HBASE-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176348#comment-14176348 ] Andrew Purtell commented on HBASE-11912: The previous version of this patch put all of the build plugin configuration in the root pom. I'm working on one that splits configuration between the root and the module POMs. Looks to be working better. Let me tinker around with it and post a new patch here shortly. > Catch some bad practices at compile time with error-prone > - > > Key: HBASE-11912 > URL: https://issues.apache.org/jira/browse/HBASE-11912 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell > Attachments: HBASE-11912.patch, HBASE-11912.patch > > > Google's error-prone (https://code.google.com/p/error-prone/) wraps javac > with some additional static analysis that will generate additional warnings > or errors at compile time if certain bug patterns > (https://code.google.com/p/error-prone/wiki/BugPatterns) are detected. What's > nice about this approach, as opposed to findbugs, is the compile time > detection and erroring out prevent the detected problems from getting into > the codebase up front. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12288) Support DirectByteBuffer usage in DataBlock Encoding area
[
https://issues.apache.org/jira/browse/HBASE-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176333#comment-14176333
]
Hadoop QA commented on HBASE-12288:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12675722/HBASE-12288.patch
against trunk revision .
ATTACHMENT ID: 12675722
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestRestartCluster
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11398//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11398//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11398//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11398//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11398//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11398//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11398//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11398//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11398//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11398//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11398//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11398//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11398//console
This message is automatically generated.
> Support DirectByteBuffer usage in DataBlock Encoding area
> -
>
> Key: HBASE-12288
> URL: https://issues.apache.org/jira/browse/HBASE-12288
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
> Attachments: HBASE-12288.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12288) Support DirectByteBuffer usage in DataBlock Encoding area
[ https://issues.apache.org/jira/browse/HBASE-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-12288: --- Status: Patch Available (was: Open) > Support DirectByteBuffer usage in DataBlock Encoding area > - > > Key: HBASE-12288 > URL: https://issues.apache.org/jira/browse/HBASE-12288 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Scanners >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Attachments: HBASE-12288.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12202) Support DirectByteBuffer usage in HFileBlock
[ https://issues.apache.org/jira/browse/HBASE-12202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176319#comment-14176319 ] Anoop Sam John commented on HBASE-12202: Ping [~enis] for branch-1 > Support DirectByteBuffer usage in HFileBlock > > > Key: HBASE-12202 > URL: https://issues.apache.org/jira/browse/HBASE-12202 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Scanners >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12202.patch, HBASE-12202_V2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12288) Support DirectByteBuffer usage in DataBlock Encoding area
[ https://issues.apache.org/jira/browse/HBASE-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-12288: --- Attachment: HBASE-12288.patch > Support DirectByteBuffer usage in DataBlock Encoding area > - > > Key: HBASE-12288 > URL: https://issues.apache.org/jira/browse/HBASE-12288 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Scanners >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Attachments: HBASE-12288.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-12289) Avoid onheap buffer copying at RPCServer#serResponse
Anoop Sam John created HBASE-12289: -- Summary: Avoid onheap buffer copying at RPCServer#serResponse Key: HBASE-12289 URL: https://issues.apache.org/jira/browse/HBASE-12289 Project: HBase Issue Type: Sub-task Reporter: Anoop Sam John Assignee: Anoop Sam John We would like to see DBB end-to-end in read path until we write to socket. IPCUtil#buildCellBlock doing a buffer creation and then write the data at once. This jira aims at checking how we can avoid this also. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-12288) Support DirectByteBuffer usage in DataBlock Encoding area
Anoop Sam John created HBASE-12288: -- Summary: Support DirectByteBuffer usage in DataBlock Encoding area Key: HBASE-12288 URL: https://issues.apache.org/jira/browse/HBASE-12288 Project: HBase Issue Type: Sub-task Reporter: Anoop Sam John Assignee: Anoop Sam John -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[ https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176289#comment-14176289 ] Hudson commented on HBASE-12161: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #581 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/581/]) HBASE-12161 Add support for grant/revoke on namespaces in AccessControlClient (Srikanth Srungarapu) (matteo.bertozzi: rev 2383c293b0fff1b881f99b107fc48a1cd387fdf9) * hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedListWithVisibility.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/SecureTestUtil.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java > Add support for grant/revoke on namespaces in AccessControlClient > - > > Key: HBASE-12161 > URL: https://issues.apache.org/jira/browse/HBASE-12161 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 0.98.8, 0.99.2 > > Attachments: HBASE-12161_0.98.patch, HBASE-12161_98_v5.patch, > HBASE-12161_master.patch, HBASE-12161_master_v2.patch, > HBASE-12161_master_v4.patch, HBASE-12161_master_v5.patch, HBASE-12161_v3.patch > > > As per the description. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[ https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176278#comment-14176278 ] Hudson commented on HBASE-12161: FAILURE: Integrated in HBase-0.98 #611 (See [https://builds.apache.org/job/HBase-0.98/611/]) HBASE-12161 Add support for grant/revoke on namespaces in AccessControlClient (Srikanth Srungarapu) (matteo.bertozzi: rev 2383c293b0fff1b881f99b107fc48a1cd387fdf9) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/SecureTestUtil.java * hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedListWithVisibility.java > Add support for grant/revoke on namespaces in AccessControlClient > - > > Key: HBASE-12161 > URL: https://issues.apache.org/jira/browse/HBASE-12161 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 0.98.8, 0.99.2 > > Attachments: HBASE-12161_0.98.patch, HBASE-12161_98_v5.patch, > HBASE-12161_master.patch, HBASE-12161_master_v2.patch, > HBASE-12161_master_v4.patch, HBASE-12161_master_v5.patch, HBASE-12161_v3.patch > > > As per the description. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[ https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Bertozzi updated HBASE-12161: Fix Version/s: 0.98.8 > Add support for grant/revoke on namespaces in AccessControlClient > - > > Key: HBASE-12161 > URL: https://issues.apache.org/jira/browse/HBASE-12161 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 0.98.8, 0.99.2 > > Attachments: HBASE-12161_0.98.patch, HBASE-12161_98_v5.patch, > HBASE-12161_master.patch, HBASE-12161_master_v2.patch, > HBASE-12161_master_v4.patch, HBASE-12161_master_v5.patch, HBASE-12161_v3.patch > > > As per the description. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[ https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176255#comment-14176255 ] Matteo Bertozzi commented on HBASE-12161: - thanks for the patch, committed to 98 too > Add support for grant/revoke on namespaces in AccessControlClient > - > > Key: HBASE-12161 > URL: https://issues.apache.org/jira/browse/HBASE-12161 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 0.98.8, 0.99.2 > > Attachments: HBASE-12161_0.98.patch, HBASE-12161_98_v5.patch, > HBASE-12161_master.patch, HBASE-12161_master_v2.patch, > HBASE-12161_master_v4.patch, HBASE-12161_master_v5.patch, HBASE-12161_v3.patch > > > As per the description. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[ https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-12161: Attachment: HBASE-12161_98_v5.patch Attaching the patch for 0.98 branch. > Add support for grant/revoke on namespaces in AccessControlClient > - > > Key: HBASE-12161 > URL: https://issues.apache.org/jira/browse/HBASE-12161 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12161_0.98.patch, HBASE-12161_98_v5.patch, > HBASE-12161_master.patch, HBASE-12161_master_v2.patch, > HBASE-12161_master_v4.patch, HBASE-12161_master_v5.patch, HBASE-12161_v3.patch > > > As per the description. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12287) Add retry runners to the most commonly failing tests
[
https://issues.apache.org/jira/browse/HBASE-12287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176237#comment-14176237
]
Hadoop QA commented on HBASE-12287:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12675715/HBASE-12287.patch
against trunk revision .
ATTACHMENT ID: 12675715
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 44 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11397//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11397//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11397//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11397//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11397//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11397//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11397//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11397//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11397//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11397//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11397//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11397//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11397//console
This message is automatically generated.
> Add retry runners to the most commonly failing tests
>
>
> Key: HBASE-12287
> URL: https://issues.apache.org/jira/browse/HBASE-12287
> Project: HBase
> Issue Type: Sub-task
>Reporter: Alex Newman
>Assignee: Alex Newman
> Attachments: HBASE-12287.patch
>
>
> Many of our tests have nondeterministic behavior due to inter-test
> interference. Usually restarting the test is enough to verify whether it is
> test interference or a broken test. Lets use a retry runner which runs the
> aftertest->before test and reruns the tests 10 times.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
