[jira] [Updated] (HBASE-12581) TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 addendum)
[ https://issues.apache.org/jira/browse/HBASE-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-12581: -- Status: Patch Available (was: Reopened) > TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 > addendum) > --- > > Key: HBASE-12581 > URL: https://issues.apache.org/jira/browse/HBASE-12581 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: stack > Fix For: 2.0.0, 0.99.2 > > Attachments: 12581.addendum.txt, 12581.txt > > > TestCellACLWithMultipleVersions failed after HBASE-12404 went in (though it > passed twice on hadoopqa!). Fails locally too. Here, make a Connection when > we go to check perms. That seems to fix it. Going to commit since patch is > just more of hbase-12404... this is in essence and addendum. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12583) Allow creating reference files even the split row not lies in the storefile range if required
[
https://issues.apache.org/jira/browse/HBASE-12583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225858#comment-14225858
]
stack commented on HBASE-12583:
---
[~rajesh23] At first blush, we cannot support custom half-store readers and the
writing of reference files outside of a region's key range. These are
internals only hbase should know of. If others are dropping references and
alien storefiles, we'll never be able to change how our internals work. This
is for the secondary index with the companion regions? Can this be done at a
higher level, at the CP level?
> Allow creating reference files even the split row not lies in the storefile
> range if required
> -
>
> Key: HBASE-12583
> URL: https://issues.apache.org/jira/browse/HBASE-12583
> Project: HBase
> Issue Type: Improvement
>Reporter: rajeshbabu
>Assignee: rajeshbabu
> Labels: Phoenix
> Fix For: 2.0.0, 0.98.9, 0.99.2
>
>
> Currently in HRegionFileSystem#splitStoreFile we are not creating reference
> files if the split row not lies in the storefile range that means one of the
> child region doesn't have any data.
> {code}
>// Check whether the split row lies in the range of the store file
> // If it is outside the range, return directly.
> if (top) {
> //check if larger than last key.
> KeyValue splitKey = KeyValueUtil.createFirstOnRow(splitRow);
> byte[] lastKey = f.createReader().getLastKey();
> // If lastKey is null means storefile is empty.
> if (lastKey == null) return null;
> if (f.getReader().getComparator().compareFlatKey(splitKey.getBuffer(),
> splitKey.getKeyOffset(), splitKey.getKeyLength(), lastKey, 0,
> lastKey.length) > 0) {
> return null;
> }
> } else {
> //check if smaller than first key
> KeyValue splitKey = KeyValueUtil.createLastOnRow(splitRow);
> byte[] firstKey = f.createReader().getFirstKey();
> // If firstKey is null means storefile is empty.
> if (firstKey == null) return null;
> if (f.getReader().getComparator().compareFlatKey(splitKey.getBuffer(),
> splitKey.getKeyOffset(), splitKey.getKeyLength(), firstKey, 0,
> firstKey.length) < 0) {
> return null;
> }
> }
> {code}
> In some cases when split row should be compared with part of rowkey(in
> composite rowkey) mainly for secondary index tables we need to create
> reference files even when split row not lies in the storefile range so that
> they can be rewritten to it's child regions by some custom half store file
> reader which compare the part of row key with split row.
> The check of comparing split row with storefile range and returning directly
> can be avoided by having special boolean attribute in table descriptor when
> it set to true. Or else we can have coprocessor hooks so that in the hooks we
> can create the references and bypass.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12558) TestHCM.testClusterStatus Unexpected exception, expected but was
[
https://issues.apache.org/jira/browse/HBASE-12558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225852#comment-14225852
]
Hudson commented on HBASE-12558:
SUCCESS: Integrated in HBase-TRUNK #5819 (See
[https://builds.apache.org/job/HBase-TRUNK/5819/])
HBASE-12558 TestHCM.testClusterStatus Unexpected exception,
expected but
was -- ADDED DEBUG (stack: rev
8b8f2026bda6a329d6d82376dbb884c8f183a967)
*
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/SnapshotTestingUtils.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableOutputFormat.java
*
hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedListWithVisibility.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClusterStatusListener.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java
*
hbase-it/src/test/java/org/apache/hadoop/hbase/trace/IntegrationTestSendTraceRequests.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
*
hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/PerformanceEvaluation.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestHTableWrapper.java
*
hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
*
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationChangingPeerRegionservers.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/master/ClusterStatusPublisher.java
*
hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestLoadAndVerify.java
> TestHCM.testClusterStatus Unexpected exception,
> expected
> but was
> -
>
> Key: HBASE-12558
> URL: https://issues.apache.org/jira/browse/HBASE-12558
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: stack
>Assignee: stack
>Priority: Critical
> Fix For: 2.0.0, 0.99.2
>
> Attachments: 12558-master.patch
>
>
> Happens for me reliably on mac os x. I looked at fixing it. The listener is
> not noticing the publish for whatever reason. Thats where I stopped.
> {code}
> java.lang.Exception: Unexpected exception,
> expected
> but was
> at junit.framework.Assert.fail(Assert.java:57)
> at org.apache.hadoop.hbase.Waiter.waitFor(Waiter.java:193)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.waitFor(HBaseTestingUtility.java:3537)
> at
> org.apache.hadoop.hbase.client.TestHCM.testClusterStatus(TestHCM.java:273)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-12583) Allow creating reference files even the split row not lies in the storefile range if required
rajeshbabu created HBASE-12583:
--
Summary: Allow creating reference files even the split row not
lies in the storefile range if required
Key: HBASE-12583
URL: https://issues.apache.org/jira/browse/HBASE-12583
Project: HBase
Issue Type: Improvement
Reporter: rajeshbabu
Assignee: rajeshbabu
Fix For: 2.0.0, 0.98.9, 0.99.2
Currently in HRegionFileSystem#splitStoreFile we are not creating reference
files if the split row not lies in the storefile range that means one of the
child region doesn't have any data.
{code}
// Check whether the split row lies in the range of the store file
// If it is outside the range, return directly.
if (top) {
//check if larger than last key.
KeyValue splitKey = KeyValueUtil.createFirstOnRow(splitRow);
byte[] lastKey = f.createReader().getLastKey();
// If lastKey is null means storefile is empty.
if (lastKey == null) return null;
if (f.getReader().getComparator().compareFlatKey(splitKey.getBuffer(),
splitKey.getKeyOffset(), splitKey.getKeyLength(), lastKey, 0,
lastKey.length) > 0) {
return null;
}
} else {
//check if smaller than first key
KeyValue splitKey = KeyValueUtil.createLastOnRow(splitRow);
byte[] firstKey = f.createReader().getFirstKey();
// If firstKey is null means storefile is empty.
if (firstKey == null) return null;
if (f.getReader().getComparator().compareFlatKey(splitKey.getBuffer(),
splitKey.getKeyOffset(), splitKey.getKeyLength(), firstKey, 0,
firstKey.length) < 0) {
return null;
}
}
{code}
In some cases when split row should be compared with part of rowkey(in
composite rowkey) mainly for secondary index tables we need to create reference
files even when split row not lies in the storefile range so that they can be
rewritten to it's child regions by some custom half store file reader which
compare the part of row key with split row.
The check of comparing split row with storefile range and returning directly
can be avoided by having special boolean attribute in table descriptor when it
set to true. Or else we can have coprocessor hooks so that in the hooks we can
create the references and bypass.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12581) TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 addendum)
[ https://issues.apache.org/jira/browse/HBASE-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-12581: -- Attachment: 12581.addendum.txt Lets see what hadoopqa says about this. > TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 > addendum) > --- > > Key: HBASE-12581 > URL: https://issues.apache.org/jira/browse/HBASE-12581 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: stack > Fix For: 2.0.0, 0.99.2 > > Attachments: 12581.addendum.txt, 12581.txt > > > TestCellACLWithMultipleVersions failed after HBASE-12404 went in (though it > passed twice on hadoopqa!). Fails locally too. Here, make a Connection when > we go to check perms. That seems to fix it. Going to commit since patch is > just more of hbase-12404... this is in essence and addendum. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12581) TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 addendum)
[ https://issues.apache.org/jira/browse/HBASE-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225776#comment-14225776 ] stack commented on HBASE-12581: --- Reopened. The patch didn't pass up on jenkins build (passed on my machine). Lets see how this one does. Passes locally. > TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 > addendum) > --- > > Key: HBASE-12581 > URL: https://issues.apache.org/jira/browse/HBASE-12581 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: stack > Fix For: 2.0.0, 0.99.2 > > Attachments: 12581.txt > > > TestCellACLWithMultipleVersions failed after HBASE-12404 went in (though it > passed twice on hadoopqa!). Fails locally too. Here, make a Connection when > we go to check perms. That seems to fix it. Going to commit since patch is > just more of hbase-12404... this is in essence and addendum. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (HBASE-12581) TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 addendum)
[ https://issues.apache.org/jira/browse/HBASE-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack reopened HBASE-12581: --- > TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 > addendum) > --- > > Key: HBASE-12581 > URL: https://issues.apache.org/jira/browse/HBASE-12581 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: stack > Fix For: 2.0.0, 0.99.2 > > Attachments: 12581.txt > > > TestCellACLWithMultipleVersions failed after HBASE-12404 went in (though it > passed twice on hadoopqa!). Fails locally too. Here, make a Connection when > we go to check perms. That seems to fix it. Going to commit since patch is > just more of hbase-12404... this is in essence and addendum. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12558) TestHCM.testClusterStatus Unexpected exception, expected but was
[
https://issues.apache.org/jira/browse/HBASE-12558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225769#comment-14225769
]
stack commented on HBASE-12558:
---
Applied the patch to master [~tianq] Lets see what happens.
> TestHCM.testClusterStatus Unexpected exception,
> expected
> but was
> -
>
> Key: HBASE-12558
> URL: https://issues.apache.org/jira/browse/HBASE-12558
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: stack
>Assignee: stack
>Priority: Critical
> Fix For: 2.0.0, 0.99.2
>
> Attachments: 12558-master.patch
>
>
> Happens for me reliably on mac os x. I looked at fixing it. The listener is
> not noticing the publish for whatever reason. Thats where I stopped.
> {code}
> java.lang.Exception: Unexpected exception,
> expected
> but was
> at junit.framework.Assert.fail(Assert.java:57)
> at org.apache.hadoop.hbase.Waiter.waitFor(Waiter.java:193)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.waitFor(HBaseTestingUtility.java:3537)
> at
> org.apache.hadoop.hbase.client.TestHCM.testClusterStatus(TestHCM.java:273)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12559) Provide LoadBalancer with online configuration capability
[
https://issues.apache.org/jira/browse/HBASE-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225765#comment-14225765
]
Hadoop QA commented on HBASE-12559:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683750/12559-v4.txt
against master branch at commit 24f19328eb4a756b95cb0ab13d089479afc7626d.
ATTACHMENT ID: 12683750
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 8 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3781 checkstyle errors (more than the master's current 3779 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ * rpc
UpdateMasterConfiguration(.UpdateMasterConfigurationRequest) returns
(.UpdateMasterConfigurationResponse);
+ * rpc UpdateMasterConfiguration(.UpdateMasterConfigurationRequest)
returns (.UpdateMasterConfigurationResponse);
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11839//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11839//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11839//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11839//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11839//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11839//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11839//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11839//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11839//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11839//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11839//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11839//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11839//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11839//console
This message is automatically generated.
> Provide LoadBalancer with online configuration capability
> -
>
> Key: HBASE-12559
> URL: https://issues.apache.org/jira/browse/HBASE-12559
> Project: HBase
> Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0
>
> Attachments: 12559-v1.txt, 12559-v2.txt, 12559-v3.txt, 12559-v4.txt
>
>
> StochasticLoadBalancer has many knobs which user can adjust.
> It would increase productivity by allowing StochasticLoadBalancer to accept
> online configuration changes.
> LoadBalancer already implements setConf(Configuration) method which reloads
> relevant configuration parameters.
> We need to add updateMasterConfiguration() method to Admin which invokes the
> setConf() method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12558) TestHCM.testClusterStatus Unexpected exception, expected but was
[
https://issues.apache.org/jira/browse/HBASE-12558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Qiang Tian updated HBASE-12558:
---
Attachment: 12558-master.patch
As you mentioned, in good case the listener receives the notification and write
"There is a new dead server" in log.
2 possible cases for bad run:
1)the publisher does not collect data (looks not possible, just in case. log a
debug message for it)
2)the publisher fail to send to client..(things handled by netty, add the same
change to listener code..)
let's see what will happen..
> TestHCM.testClusterStatus Unexpected exception,
> expected
> but was
> -
>
> Key: HBASE-12558
> URL: https://issues.apache.org/jira/browse/HBASE-12558
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: stack
>Assignee: stack
>Priority: Critical
> Fix For: 2.0.0, 0.99.2
>
> Attachments: 12558-master.patch
>
>
> Happens for me reliably on mac os x. I looked at fixing it. The listener is
> not noticing the publish for whatever reason. Thats where I stopped.
> {code}
> java.lang.Exception: Unexpected exception,
> expected
> but was
> at junit.framework.Assert.fail(Assert.java:57)
> at org.apache.hadoop.hbase.Waiter.waitFor(Waiter.java:193)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.waitFor(HBaseTestingUtility.java:3537)
> at
> org.apache.hadoop.hbase.client.TestHCM.testClusterStatus(TestHCM.java:273)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12072) We are doing 35 x 35 retries for master operations
[
https://issues.apache.org/jira/browse/HBASE-12072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225676#comment-14225676
]
Hadoop QA commented on HBASE-12072:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683733/hbase-12072_v3.patch
against master branch at commit 24f19328eb4a756b95cb0ab13d089479afc7626d.
ATTACHMENT ID: 12683733
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 18 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3780 checkstyle errors (more than the master's current 3779 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 2 zombie test(s):
at
org.apache.bookkeeper.test.BookKeeperClusterTestCase$2.run(BookKeeperClusterTestCase.java:316)
at
org.apache.bookkeeper.test.BookKeeperClusterTestCase$2.run(BookKeeperClusterTestCase.java:316)
at
org.apache.bookkeeper.client.SlowBookieTest.testManyBookieFailureWithSlowBookies(SlowBookieTest.java:185)
at
org.apache.hadoop.hbase.backup.TestHFileArchiving.testRemovesRegionDirOnArchive(TestHFileArchiving.java:130)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11837//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11837//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11837//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11837//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11837//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11837//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11837//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11837//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11837//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11837//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11837//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11837//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11837//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11837//console
This message is automatically generated.
> We are doing 35 x 35 retries for master operations
> --
>
> Key: HBASE-12072
> URL: https://issues.apache.org/jira/browse/HBASE-12072
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.98.6
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: 2.0.0, 0.99.2
>
> Attachments: 12072-v1.txt, 12072-v2.txt, hbase-12072_v1.patch,
> hbase-12072_v2.patch, hbase-12072_v2.patch, hbase-12072_v3.patch
>
>
> For master requests, there are two retry mechanisms in effect. The first one
> is from HBaseAdmin.executeCallable()
> {code}
> private V executeCallable(MasterCallable callable) throws
> IOException {
> RpcRetryingCaller caller = rpcCallerFactory.newCaller();
> try
[jira] [Updated] (HBASE-12559) Provide LoadBalancer with online configuration capability
[ https://issues.apache.org/jira/browse/HBASE-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-12559: --- Attachment: (was: 12559-v4.txt) > Provide LoadBalancer with online configuration capability > - > > Key: HBASE-12559 > URL: https://issues.apache.org/jira/browse/HBASE-12559 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 2.0.0 > > Attachments: 12559-v1.txt, 12559-v2.txt, 12559-v3.txt, 12559-v4.txt > > > StochasticLoadBalancer has many knobs which user can adjust. > It would increase productivity by allowing StochasticLoadBalancer to accept > online configuration changes. > LoadBalancer already implements setConf(Configuration) method which reloads > relevant configuration parameters. > We need to add updateMasterConfiguration() method to Admin which invokes the > setConf() method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12559) Provide LoadBalancer with online configuration capability
[ https://issues.apache.org/jira/browse/HBASE-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-12559: --- Attachment: 12559-v4.txt > Provide LoadBalancer with online configuration capability > - > > Key: HBASE-12559 > URL: https://issues.apache.org/jira/browse/HBASE-12559 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 2.0.0 > > Attachments: 12559-v1.txt, 12559-v2.txt, 12559-v3.txt, 12559-v4.txt > > > StochasticLoadBalancer has many knobs which user can adjust. > It would increase productivity by allowing StochasticLoadBalancer to accept > online configuration changes. > LoadBalancer already implements setConf(Configuration) method which reloads > relevant configuration parameters. > We need to add updateMasterConfiguration() method to Admin which invokes the > setConf() method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12518) Task 4 polish. Remove CM#{get,delete}Connection
[
https://issues.apache.org/jira/browse/HBASE-12518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225648#comment-14225648
]
Hadoop QA commented on HBASE-12518:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683725/12518.txt
against master branch at commit 24f19328eb4a756b95cb0ab13d089479afc7626d.
ATTACHMENT ID: 12683725
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 24 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3781 checkstyle errors (more than the master's current 3779 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11836//console
This message is automatically generated.
> Task 4 polish. Remove CM#{get,delete}Connection
> ---
>
> Key: HBASE-12518
> URL: https://issues.apache.org/jira/browse/HBASE-12518
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Affects Versions: 2.0.0, 0.99.2
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0, 0.99.2
>
> Attachments: 12518.txt
>
>
> HBASE-12471 purged get/delete Connection from under src/main/java. Lets
> finish it up by doing same over in src/test since not that many places left.
> Depends on HBASE-12404 going in first so can clean out references in
> templates:
> {code}
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> ConnectionManager.deleteConnection(connectionKey, true);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> public static void deleteConnection(Configuration conf) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(new HConnectionKey(conf), false);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(connection, true);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
>
[jira] [Created] (HBASE-12582) Port HBASE-10881 'Support reverse scan in thrift2' to 0.98
Ted Yu created HBASE-12582: -- Summary: Port HBASE-10881 'Support reverse scan in thrift2' to 0.98 Key: HBASE-12582 URL: https://issues.apache.org/jira/browse/HBASE-12582 Project: HBase Issue Type: Improvement Reporter: Ted Yu Reverse scan is supported in thrift / thrift2. This JIRA is to backport reverse scan in thrift to 0.98 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12559) Provide LoadBalancer with online configuration capability
[ https://issues.apache.org/jira/browse/HBASE-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225617#comment-14225617 ] Ted Yu commented on HBASE-12559: [~eclark]: See if patch v4 addresses your comment. > Provide LoadBalancer with online configuration capability > - > > Key: HBASE-12559 > URL: https://issues.apache.org/jira/browse/HBASE-12559 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 2.0.0 > > Attachments: 12559-v1.txt, 12559-v2.txt, 12559-v3.txt, 12559-v4.txt > > > StochasticLoadBalancer has many knobs which user can adjust. > It would increase productivity by allowing StochasticLoadBalancer to accept > online configuration changes. > LoadBalancer already implements setConf(Configuration) method which reloads > relevant configuration parameters. > We need to add updateMasterConfiguration() method to Admin which invokes the > setConf() method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12559) Provide LoadBalancer with online configuration capability
[ https://issues.apache.org/jira/browse/HBASE-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-12559: --- Attachment: 12559-v4.txt Patch v4 restores hbase-site.xml after test completes. > Provide LoadBalancer with online configuration capability > - > > Key: HBASE-12559 > URL: https://issues.apache.org/jira/browse/HBASE-12559 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 2.0.0 > > Attachments: 12559-v1.txt, 12559-v2.txt, 12559-v3.txt, 12559-v4.txt > > > StochasticLoadBalancer has many knobs which user can adjust. > It would increase productivity by allowing StochasticLoadBalancer to accept > online configuration changes. > LoadBalancer already implements setConf(Configuration) method which reloads > relevant configuration parameters. > We need to add updateMasterConfiguration() method to Admin which invokes the > setConf() method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12546) Validate schema options that require server side class availability
[ https://issues.apache.org/jira/browse/HBASE-12546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225610#comment-14225610 ] Jiajia Li commented on HBASE-12546: --- hi, Andy,[~apurtell], I found the jira, https://issues.apache.org/jira/browse/HBASE-12573(Backport HBASE-10591 Sanity check table configuration in createTable)，is this what want to do? > Validate schema options that require server side class availability > --- > > Key: HBASE-12546 > URL: https://issues.apache.org/jira/browse/HBASE-12546 > Project: HBase > Issue Type: Bug >Reporter: Andrew Purtell >Assignee: Jiajia Li > Fix For: 2.0.0, 0.98.9, 0.99.2 > > > When processing table create and modification requests we should check the > supplied schema options for settings that require mentioned classes to be > available from the regionserver classpath (split policies, etc.). If we can't > find the class on the classpath when processing the admin request RPC, fail > the operation immediately and return an exception rather than allow problems > later, such as aborts. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11462) MetaTableAccessor shouldn't use ZooKeeeper
[ https://issues.apache.org/jira/browse/HBASE-11462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225609#comment-14225609 ] Enis Soztutar commented on HBASE-11462: --- This looks ok for backport. It seems strange to have if meta do this else do this all over the place instead of a better abstraction (a region locator impl for meta and one for regular regions), but we can fix that in another issue. > MetaTableAccessor shouldn't use ZooKeeeper > -- > > Key: HBASE-11462 > URL: https://issues.apache.org/jira/browse/HBASE-11462 > Project: HBase > Issue Type: Improvement > Components: Client, Zookeeper >Affects Versions: 2.0.0 >Reporter: Mikhail Antonov >Assignee: ryan rawson > Fix For: 2.0.0 > > Attachments: HBASE-11462.v4.patch, HBASE-11462.v4.patch, > HBASE-11462.v4.patch > > > After committing patch for HBASE-4495, there's an further improvement which > can be made (discussed originally on review board to that jira). > We have MetaTableAccessor and MetaTableLocator classes. First one is used to > access information stored in hbase:meta table. Second one is used to deal > with ZooKeeper state to find out region server hosting hbase:meta, wait for > it to become available and so on. > MetaTableAccessor, in turn, should only operate on the meta table content, so > shouldn't need ZK. The only reason why MetaTableAccessor is using ZK - when > callers request assignment information, they can request location of meta > table itself, which we can't read from meta, so in that case > MetaTableAccessor relays the call to MetaTableLocator. May be the solution > here is to declare that clients of MetaTableAccessor shall not use it to work > with meta table itself (not it's content). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12581) TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 addendum)
[ https://issues.apache.org/jira/browse/HBASE-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225601#comment-14225601 ] Hudson commented on HBASE-12581: FAILURE: Integrated in HBase-TRUNK #5818 (See [https://builds.apache.org/job/HBase-TRUNK/5818/]) HBASE-12581 TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 addendum) (stack: rev 24f19328eb4a756b95cb0ab13d089479afc7626d) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestCellACLWithMultipleVersions.java > TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 > addendum) > --- > > Key: HBASE-12581 > URL: https://issues.apache.org/jira/browse/HBASE-12581 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: stack > Fix For: 2.0.0, 0.99.2 > > Attachments: 12581.txt > > > TestCellACLWithMultipleVersions failed after HBASE-12404 went in (though it > passed twice on hadoopqa!). Fails locally too. Here, make a Connection when > we go to check perms. That seems to fix it. Going to commit since patch is > just more of hbase-12404... this is in essence and addendum. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12404) Task 5 from parent: Replace internal HTable constructor use with HConnection#getTable (0.98, 0.99)
[ https://issues.apache.org/jira/browse/HBASE-12404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225600#comment-14225600 ] Hudson commented on HBASE-12404: FAILURE: Integrated in HBase-TRUNK #5818 (See [https://builds.apache.org/job/HBase-TRUNK/5818/]) HBASE-12581 TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 addendum) (stack: rev 24f19328eb4a756b95cb0ab13d089479afc7626d) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestCellACLWithMultipleVersions.java > Task 5 from parent: Replace internal HTable constructor use with > HConnection#getTable (0.98, 0.99) > -- > > Key: HBASE-12404 > URL: https://issues.apache.org/jira/browse/HBASE-12404 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack > Fix For: 2.0.0, 0.99.2 > > Attachments: > 0001-HBASE-12404-Task-5-from-parent-Replace-internal-HTab.patch, 12404.txt, > 12404.v16.txt, 12404.v16.txt, 12404.v17.txt, 12404v10.txt, 12404v11.txt, > 12404v12.txt, 12404v12.txt, 12404v13.txt, 12404v13.txt, 12404v14.txt, > 12404v15.txt, 12404v18.txt, 12404v19.txt, 12404v19.txt, 12404v2.txt, > 12404v20.txt, 12404v20.txt, 12404v3.txt, 12404v5.txt, 12404v6.txt, > 12404v7.txt, 12404v9.txt > > > Do the step 5. from the [~ndimiduk] list in parent issue. Go through src > code and change all new HTable to instead be connection.getTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12580) Zookeeper instantiated even though we might not need it in the shell
[ https://issues.apache.org/jira/browse/HBASE-12580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225599#comment-14225599 ] Enis Soztutar commented on HBASE-12580: --- +1. > Zookeeper instantiated even though we might not need it in the shell > > > Key: HBASE-12580 > URL: https://issues.apache.org/jira/browse/HBASE-12580 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.8 >Reporter: Alex Newman >Assignee: Alex Newman > Attachments: HBASE-12580.patch > > > I wrote an alternative registry and connection manager which does not use > zookeeper. However the shell still wants to connect to zookeeper NO MATTER > WHAT. I can see it for supporting zk_dump but, for some reason even though > the shell commands succeed, I get errors scrolling about why it can't attach > to zookeeper -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12573) Backport HBASE-10591 Sanity check table configuration in createTable
[ https://issues.apache.org/jira/browse/HBASE-12573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225598#comment-14225598 ] Enis Soztutar commented on HBASE-12573: --- Let me know what checks we want to keep, and what to remove. > Backport HBASE-10591 Sanity check table configuration in createTable > > > Key: HBASE-12573 > URL: https://issues.apache.org/jira/browse/HBASE-12573 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 0.98.9 > > Attachments: hbase-10591_v5-0.98.patch > > > In parent jira, it seems that we will be better off backporting HBASE-10591. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12072) We are doing 35 x 35 retries for master operations
[
https://issues.apache.org/jira/browse/HBASE-12072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Enis Soztutar updated HBASE-12072:
--
Attachment: hbase-12072_v3.patch
Rebased patch. Lets see hadoopqa.
> We are doing 35 x 35 retries for master operations
> --
>
> Key: HBASE-12072
> URL: https://issues.apache.org/jira/browse/HBASE-12072
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.98.6
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: 2.0.0, 0.99.2
>
> Attachments: 12072-v1.txt, 12072-v2.txt, hbase-12072_v1.patch,
> hbase-12072_v2.patch, hbase-12072_v2.patch, hbase-12072_v3.patch
>
>
> For master requests, there are two retry mechanisms in effect. The first one
> is from HBaseAdmin.executeCallable()
> {code}
> private V executeCallable(MasterCallable callable) throws
> IOException {
> RpcRetryingCaller caller = rpcCallerFactory.newCaller();
> try {
> return caller.callWithRetries(callable);
> } finally {
> callable.close();
> }
> }
> {code}
> And inside, the other one is from StubMaker.makeStub():
> {code}
> /**
>* Create a stub against the master. Retry if necessary.
>* @return A stub to do intf against the master
>* @throws MasterNotRunningException
>*/
> @edu.umd.cs.findbugs.annotations.SuppressWarnings
> (value="SWL_SLEEP_WITH_LOCK_HELD")
> Object makeStub() throws MasterNotRunningException {
> {code}
> The tests will just hang for 10 min * 35 ~= 6hours.
> {code}
> 2014-09-23 16:19:05,151 INFO [main]
> client.ConnectionManager$HConnectionImplementation: getMaster attempt 1 of 35
> failed; retrying after sleep of 100, exception=java.io.IOException: Can't get
> master address from ZooKeeper; znode data == null
> 2014-09-23 16:19:05,253 INFO [main]
> client.ConnectionManager$HConnectionImplementation: getMaster attempt 2 of 35
> failed; retrying after sleep of 200, exception=java.io.IOException: Can't get
> master address from ZooKeeper; znode data == null
> 2014-09-23 16:19:05,456 INFO [main]
> client.ConnectionManager$HConnectionImplementation: getMaster attempt 3 of 35
> failed; retrying after sleep of 300, exception=java.io.IOException: Can't get
> master address from ZooKeeper; znode data == null
> 2014-09-23 16:19:05,759 INFO [main]
> client.ConnectionManager$HConnectionImplementation: getMaster attempt 4 of 35
> failed; retrying after sleep of 500, exception=java.io.IOException: Can't get
> master address from ZooKeeper; znode data == null
> 2014-09-23 16:19:06,262 INFO [main]
> client.ConnectionManager$HConnectionImplementation: getMaster attempt 5 of 35
> failed; retrying after sleep of 1008, exception=java.io.IOException: Can't
> get master address from ZooKeeper; znode data == null
> 2014-09-23 16:19:07,273 INFO [main]
> client.ConnectionManager$HConnectionImplementation: getMaster attempt 6 of 35
> failed; retrying after sleep of 2011, exception=java.io.IOException: Can't
> get master address from ZooKeeper; znode data == null
> 2014-09-23 16:19:09,286 INFO [main]
> client.ConnectionManager$HConnectionImplementation: getMaster attempt 7 of 35
> failed; retrying after sleep of 4012, exception=java.io.IOException: Can't
> get master address from ZooKeeper; znode data == null
> 2014-09-23 16:19:13,303 INFO [main]
> client.ConnectionManager$HConnectionImplementation: getMaster attempt 8 of 35
> failed; retrying after sleep of 10033, exception=java.io.IOException: Can't
> get master address from ZooKeeper; znode data == null
> 2014-09-23 16:19:23,343 INFO [main]
> client.ConnectionManager$HConnectionImplementation: getMaster attempt 9 of 35
> failed; retrying after sleep of 10089, exception=java.io.IOException: Can't
> get master address from ZooKeeper; znode data == null
> 2014-09-23 16:19:33,439 INFO [main]
> client.ConnectionManager$HConnectionImplementation: getMaster attempt 10 of
> 35 failed; retrying after sleep of 10027, exception=java.io.IOException:
> Can't get master address from ZooKeeper; znode data == null
> 2014-09-23 16:19:43,473 INFO [main]
> client.ConnectionManager$HConnectionImplementation: getMaster attempt 11 of
> 35 failed; retrying after sleep of 10004, exception=java.io.IOException:
> Can't get master address from ZooKeeper; znode data == null
> 2014-09-23 16:19:53,485 INFO [main]
> client.ConnectionManager$HConnectionImplementation: getMaster attempt 12 of
> 35 failed; retrying after sleep of 20160, exception=java.io.IOException:
> Can't get master address from ZooKeeper; znode data == null
> 2014-09-23 16:20:13,656 INFO [main]
> client.ConnectionManager$HConnectionImplementation: getMaster attempt 13 of
> 35 failed; retrying after sleep of 20006, exception=java.io.IOException:
> Can't get master addres
[jira] [Commented] (HBASE-12570) Missing/invalid split policy class name brings down your HBase cluster
[ https://issues.apache.org/jira/browse/HBASE-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225581#comment-14225581 ] Enis Soztutar commented on HBASE-12570: --- The full backport patch is in HBASE-12573. Let me take out some stuff, and re-upload a patch. > Missing/invalid split policy class name brings down your HBase cluster > -- > > Key: HBASE-12570 > URL: https://issues.apache.org/jira/browse/HBASE-12570 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > > See PHOENIX-1473. If a split policy class cannot be resolved, then your HBase > cluster will be brought down as each region server that successively attempts > to open the region will not find the class and will bring itself down. > One idea to prevent this would be to fail the CREATE TABLE or ALTER TABLE > admin call if the split policy class cannot be found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12404) Task 5 from parent: Replace internal HTable constructor use with HConnection#getTable (0.98, 0.99)
[ https://issues.apache.org/jira/browse/HBASE-12404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225576#comment-14225576 ] Hudson commented on HBASE-12404: FAILURE: Integrated in HBase-1.0 #504 (See [https://builds.apache.org/job/HBase-1.0/504/]) HBASE-12581 TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 addendum) (stack: rev c9376e6d375a9e4729deec0dd518bdf62b2d1a62) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestCellACLWithMultipleVersions.java > Task 5 from parent: Replace internal HTable constructor use with > HConnection#getTable (0.98, 0.99) > -- > > Key: HBASE-12404 > URL: https://issues.apache.org/jira/browse/HBASE-12404 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack > Fix For: 2.0.0, 0.99.2 > > Attachments: > 0001-HBASE-12404-Task-5-from-parent-Replace-internal-HTab.patch, 12404.txt, > 12404.v16.txt, 12404.v16.txt, 12404.v17.txt, 12404v10.txt, 12404v11.txt, > 12404v12.txt, 12404v12.txt, 12404v13.txt, 12404v13.txt, 12404v14.txt, > 12404v15.txt, 12404v18.txt, 12404v19.txt, 12404v19.txt, 12404v2.txt, > 12404v20.txt, 12404v20.txt, 12404v3.txt, 12404v5.txt, 12404v6.txt, > 12404v7.txt, 12404v9.txt > > > Do the step 5. from the [~ndimiduk] list in parent issue. Go through src > code and change all new HTable to instead be connection.getTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12581) TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 addendum)
[ https://issues.apache.org/jira/browse/HBASE-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225577#comment-14225577 ] Hudson commented on HBASE-12581: FAILURE: Integrated in HBase-1.0 #504 (See [https://builds.apache.org/job/HBase-1.0/504/]) HBASE-12581 TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 addendum) (stack: rev c9376e6d375a9e4729deec0dd518bdf62b2d1a62) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestCellACLWithMultipleVersions.java > TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 > addendum) > --- > > Key: HBASE-12581 > URL: https://issues.apache.org/jira/browse/HBASE-12581 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: stack > Fix For: 2.0.0, 0.99.2 > > Attachments: 12581.txt > > > TestCellACLWithMultipleVersions failed after HBASE-12404 went in (though it > passed twice on hadoopqa!). Fails locally too. Here, make a Connection when > we go to check perms. That seems to fix it. Going to commit since patch is > just more of hbase-12404... this is in essence and addendum. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12580) Zookeeper instantiated even though we might not need it in the shell
[
https://issues.apache.org/jira/browse/HBASE-12580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225573#comment-14225573
]
Hadoop QA commented on HBASE-12580:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683694/HBASE-12580.patch
against master branch at commit e6b4300756b7f09a31ba35cb3baf41d294ed6e14.
ATTACHMENT ID: 12683694
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11835//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11835//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11835//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11835//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11835//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11835//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11835//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11835//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11835//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11835//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11835//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11835//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11835//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11835//console
This message is automatically generated.
> Zookeeper instantiated even though we might not need it in the shell
>
>
> Key: HBASE-12580
> URL: https://issues.apache.org/jira/browse/HBASE-12580
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.98.8
>Reporter: Alex Newman
>Assignee: Alex Newman
> Attachments: HBASE-12580.patch
>
>
> I wrote an alternative registry and connection manager which does not use
> zookeeper. However the shell still wants to connect to zookeeper NO MATTER
> WHAT. I can see it for supporting zk_dump but, for some reason even though
> the shell commands succeed, I get errors scrolling about why it can't attach
> to zookeeper
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12518) Task 4 polish. Remove CM#{get,delete}Connection
[
https://issues.apache.org/jira/browse/HBASE-12518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-12518:
--
Attachment: 12518.txt
Remove deleteConnections from tests and from web ui. Only places with
deleteConnection are tests (now deprecated) that test deleteConnection works
and their definitions in HCM and CM.
> Task 4 polish. Remove CM#{get,delete}Connection
> ---
>
> Key: HBASE-12518
> URL: https://issues.apache.org/jira/browse/HBASE-12518
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Affects Versions: 2.0.0, 0.99.2
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0, 0.99.2
>
> Attachments: 12518.txt
>
>
> HBASE-12471 purged get/delete Connection from under src/main/java. Lets
> finish it up by doing same over in src/test since not that many places left.
> Depends on HBASE-12404 going in first so can clean out references in
> templates:
> {code}
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> ConnectionManager.deleteConnection(connectionKey, true);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> public static void deleteConnection(Configuration conf) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(new HConnectionKey(conf), false);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(connection, true);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(connectionKey, staleConnection);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> private static void deleteConnection(HConnection connection, boolean
> staleConnection) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(e.getKey(), staleConnection);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> private static void deleteConnection(HConnectionKey connectionKey, boolean
> staleConnection) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> ConnectionManager.deleteConnection(this, false);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> * Currently, clients cleanup by calling {@link
> #deleteConnection(Configuration)}. This will
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> * HConnectionManager.deleteConnection(conf, true);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> public static void deleteConnection(Configuration conf) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> ConnectionManager.deleteConnection(conf);
> ./hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon:
>HConnectionManager.deleteConnection(admin.getConfiguration());
> ./hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp:HConnectionManager.deleteConnection(hbadmin.getConfiguration());
> ./hbase-server/src/main/resources/hbase-webapps/master/table.jsp:HConnectionManager.deleteConnection(hbadmin.getConfiguration());
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
>* {@link HConnectionManager#deleteConnection(Configuration)} else it
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
>* {@link HConnectionManager#deleteConnection(Configuration)} else it
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
>* {@link HConnectionManager#deleteConnection(Configuration)}
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
>* {@link HConnectionManager#deleteConnection(Configuration)} else it
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java:
> HConnectionManager.deleteConnection(newConfig);
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java:
> HConnectionManager.deleteConnection(newConfig2);
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHBaseAdminNoCluster.java.orig:
> if (connection !=
> null)HConnectionManager.deleteConnection(configuration);
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java:
>HConnectionManager.deleteConnection(c.getConfiguration());
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java:
>
> HConnectionManager.deleteConnection(this.connection.getConfiguration());
> ./hbase-server
[jira] [Updated] (HBASE-12518) Task 4 polish. Remove CM#{get,delete}Connection
[
https://issues.apache.org/jira/browse/HBASE-12518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-12518:
--
Affects Version/s: 0.99.2
2.0.0
Status: Patch Available (was: Open)
Try hadoopqa
> Task 4 polish. Remove CM#{get,delete}Connection
> ---
>
> Key: HBASE-12518
> URL: https://issues.apache.org/jira/browse/HBASE-12518
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Affects Versions: 2.0.0, 0.99.2
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0, 0.99.2
>
> Attachments: 12518.txt
>
>
> HBASE-12471 purged get/delete Connection from under src/main/java. Lets
> finish it up by doing same over in src/test since not that many places left.
> Depends on HBASE-12404 going in first so can clean out references in
> templates:
> {code}
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> ConnectionManager.deleteConnection(connectionKey, true);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> public static void deleteConnection(Configuration conf) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(new HConnectionKey(conf), false);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(connection, true);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(connectionKey, staleConnection);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> private static void deleteConnection(HConnection connection, boolean
> staleConnection) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(e.getKey(), staleConnection);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> private static void deleteConnection(HConnectionKey connectionKey, boolean
> staleConnection) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> ConnectionManager.deleteConnection(this, false);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> * Currently, clients cleanup by calling {@link
> #deleteConnection(Configuration)}. This will
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> * HConnectionManager.deleteConnection(conf, true);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> public static void deleteConnection(Configuration conf) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> ConnectionManager.deleteConnection(conf);
> ./hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon:
>HConnectionManager.deleteConnection(admin.getConfiguration());
> ./hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp:HConnectionManager.deleteConnection(hbadmin.getConfiguration());
> ./hbase-server/src/main/resources/hbase-webapps/master/table.jsp:HConnectionManager.deleteConnection(hbadmin.getConfiguration());
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
>* {@link HConnectionManager#deleteConnection(Configuration)} else it
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
>* {@link HConnectionManager#deleteConnection(Configuration)} else it
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
>* {@link HConnectionManager#deleteConnection(Configuration)}
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
>* {@link HConnectionManager#deleteConnection(Configuration)} else it
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java:
> HConnectionManager.deleteConnection(newConfig);
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java:
> HConnectionManager.deleteConnection(newConfig2);
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHBaseAdminNoCluster.java.orig:
> if (connection !=
> null)HConnectionManager.deleteConnection(configuration);
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java:
>HConnectionManager.deleteConnection(c.getConfiguration());
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java:
>
> HConnectionManager.deleteConnection(this.connection.getConfiguration());
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaTableAccessorNoCluster.java:
> HConn
[jira] [Commented] (HBASE-12570) Missing/invalid split policy class name brings down your HBase cluster
[ https://issues.apache.org/jira/browse/HBASE-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225547#comment-14225547 ] Lars Hofhansl commented on HBASE-12570: --- bq. Or just address the specific problem described in this issue +1 on that. We can take it piecemeal. > Missing/invalid split policy class name brings down your HBase cluster > -- > > Key: HBASE-12570 > URL: https://issues.apache.org/jira/browse/HBASE-12570 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > > See PHOENIX-1473. If a split policy class cannot be resolved, then your HBase > cluster will be brought down as each region server that successively attempts > to open the region will not find the class and will bring itself down. > One idea to prevent this would be to fail the CREATE TABLE or ALTER TABLE > admin call if the split policy class cannot be found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12518) Task 4 polish. Remove CM#{get,delete}Connection
[
https://issues.apache.org/jira/browse/HBASE-12518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-12518:
--
Summary: Task 4 polish. Remove CM#{get,delete}Connection (was: Task 4.
Remove CM#{get,delete}Connection)
> Task 4 polish. Remove CM#{get,delete}Connection
> ---
>
> Key: HBASE-12518
> URL: https://issues.apache.org/jira/browse/HBASE-12518
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0, 0.99.2
>
>
> HBASE-12471 purged get/delete Connection from under src/main/java. Lets
> finish it up by doing same over in src/test since not that many places left.
> Depends on HBASE-12404 going in first so can clean out references in
> templates:
> {code}
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> ConnectionManager.deleteConnection(connectionKey, true);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> public static void deleteConnection(Configuration conf) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(new HConnectionKey(conf), false);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(connection, true);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(connectionKey, staleConnection);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> private static void deleteConnection(HConnection connection, boolean
> staleConnection) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(e.getKey(), staleConnection);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> private static void deleteConnection(HConnectionKey connectionKey, boolean
> staleConnection) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> ConnectionManager.deleteConnection(this, false);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> * Currently, clients cleanup by calling {@link
> #deleteConnection(Configuration)}. This will
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> * HConnectionManager.deleteConnection(conf, true);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> public static void deleteConnection(Configuration conf) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> ConnectionManager.deleteConnection(conf);
> ./hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon:
>HConnectionManager.deleteConnection(admin.getConfiguration());
> ./hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp:HConnectionManager.deleteConnection(hbadmin.getConfiguration());
> ./hbase-server/src/main/resources/hbase-webapps/master/table.jsp:HConnectionManager.deleteConnection(hbadmin.getConfiguration());
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
>* {@link HConnectionManager#deleteConnection(Configuration)} else it
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
>* {@link HConnectionManager#deleteConnection(Configuration)} else it
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
>* {@link HConnectionManager#deleteConnection(Configuration)}
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
>* {@link HConnectionManager#deleteConnection(Configuration)} else it
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java:
> HConnectionManager.deleteConnection(newConfig);
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java:
> HConnectionManager.deleteConnection(newConfig2);
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHBaseAdminNoCluster.java.orig:
> if (connection !=
> null)HConnectionManager.deleteConnection(configuration);
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java:
>HConnectionManager.deleteConnection(c.getConfiguration());
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java:
>
> HConnectionManager.deleteConnection(this.connection.getConfiguration());
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaTableAccessorNoCluster.java:
> HConnectionManager.deleteConnection(UTIL.getConfiguration());
> ./hbase-server/src/test/jav
[jira] [Reopened] (HBASE-11462) MetaTableAccessor shouldn't use ZooKeeeper
[ https://issues.apache.org/jira/browse/HBASE-11462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Newman reopened HBASE-11462: - Any reason this can't be back ported to 1.0? > MetaTableAccessor shouldn't use ZooKeeeper > -- > > Key: HBASE-11462 > URL: https://issues.apache.org/jira/browse/HBASE-11462 > Project: HBase > Issue Type: Improvement > Components: Client, Zookeeper >Affects Versions: 2.0.0 >Reporter: Mikhail Antonov >Assignee: ryan rawson > Fix For: 2.0.0 > > Attachments: HBASE-11462.v4.patch, HBASE-11462.v4.patch, > HBASE-11462.v4.patch > > > After committing patch for HBASE-4495, there's an further improvement which > can be made (discussed originally on review board to that jira). > We have MetaTableAccessor and MetaTableLocator classes. First one is used to > access information stored in hbase:meta table. Second one is used to deal > with ZooKeeper state to find out region server hosting hbase:meta, wait for > it to become available and so on. > MetaTableAccessor, in turn, should only operate on the meta table content, so > shouldn't need ZK. The only reason why MetaTableAccessor is using ZK - when > callers request assignment information, they can request location of meta > table itself, which we can't read from meta, so in that case > MetaTableAccessor relays the call to MetaTableLocator. May be the solution > here is to declare that clients of MetaTableAccessor shall not use it to work > with meta table itself (not it's content). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12518) Task 4. Remove CM#{get,delete}Connection
[
https://issues.apache.org/jira/browse/HBASE-12518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-12518:
--
Summary: Task 4. Remove CM#{get,delete}Connection (was: Task 4. Remove
CM#{get,delete}Connection from src/test)
> Task 4. Remove CM#{get,delete}Connection
>
>
> Key: HBASE-12518
> URL: https://issues.apache.org/jira/browse/HBASE-12518
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0, 0.99.2
>
>
> HBASE-12471 purged get/delete Connection from under src/main/java. Lets
> finish it up by doing same over in src/test since not that many places left.
> Depends on HBASE-12404 going in first so can clean out references in
> templates:
> {code}
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> ConnectionManager.deleteConnection(connectionKey, true);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> public static void deleteConnection(Configuration conf) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(new HConnectionKey(conf), false);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(connection, true);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(connectionKey, staleConnection);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> private static void deleteConnection(HConnection connection, boolean
> staleConnection) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> deleteConnection(e.getKey(), staleConnection);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> private static void deleteConnection(HConnectionKey connectionKey, boolean
> staleConnection) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java:
> ConnectionManager.deleteConnection(this, false);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> * Currently, clients cleanup by calling {@link
> #deleteConnection(Configuration)}. This will
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> * HConnectionManager.deleteConnection(conf, true);
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> public static void deleteConnection(Configuration conf) {
> ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:
> ConnectionManager.deleteConnection(conf);
> ./hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon:
>HConnectionManager.deleteConnection(admin.getConfiguration());
> ./hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp:HConnectionManager.deleteConnection(hbadmin.getConfiguration());
> ./hbase-server/src/main/resources/hbase-webapps/master/table.jsp:HConnectionManager.deleteConnection(hbadmin.getConfiguration());
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
>* {@link HConnectionManager#deleteConnection(Configuration)} else it
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
>* {@link HConnectionManager#deleteConnection(Configuration)} else it
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
>* {@link HConnectionManager#deleteConnection(Configuration)}
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java:
>* {@link HConnectionManager#deleteConnection(Configuration)} else it
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java:
> HConnectionManager.deleteConnection(newConfig);
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java:
> HConnectionManager.deleteConnection(newConfig2);
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHBaseAdminNoCluster.java.orig:
> if (connection !=
> null)HConnectionManager.deleteConnection(configuration);
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java:
>HConnectionManager.deleteConnection(c.getConfiguration());
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java:
>
> HConnectionManager.deleteConnection(this.connection.getConfiguration());
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaTableAccessorNoCluster.java:
> HConnectionManager.deleteConnection(UTIL.getConfiguration());
> ./hbase-server/src/test/java/org/a
[jira] [Commented] (HBASE-12338) Client side scanning prefetching.
[ https://issues.apache.org/jira/browse/HBASE-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225513#comment-14225513 ] Yi Deng commented on HBASE-12338: - [~stack] yes, it has been updated to Phabricator. > Client side scanning prefetching. > - > > Key: HBASE-12338 > URL: https://issues.apache.org/jira/browse/HBASE-12338 > Project: HBase > Issue Type: Sub-task > Components: Client >Affects Versions: 1.0.0, 2.0.0, 0.98.6.1 >Reporter: Yi Deng >Assignee: Yi Deng > Labels: prefetch, results, scanner > Attachments: > 0001-Add-ScanPrefetcher-for-client-side-scanning-prefetch.patch, > 0001-ScanPrefetcher.patch, > 2.0-0001-Add-ScanPrefetcher-for-client-side-scanning-prefetch.patch, > 2.0-0002-Add-ScanPrefetcher-for-client-side-scanning-prefetch.patch, > 2.0-0003-Add-ScanPrefetcher-for-client-side-scanning-prefetch.patch > > > Since server side prefetching was not proved to be a good way to prefetch, we > need to do it on client side. > This is a wrapper class that takes any instance of `ResultScanner` as the > underneath scanning component. The class will schedule the scanning in a > background thread. There is a buffering queue storing prefetched results, > whose's length is configurable. The prefetcher will release the thread if the > queue is full and wait for results to be consumed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12338) Client side scanning prefetching.
[ https://issues.apache.org/jira/browse/HBASE-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Deng updated HBASE-12338: Release Note: ScanPrefetcher wraps a ClientScanner and make fetching on background. Specially useful for cases with slow speed of consuming scanned data. > Client side scanning prefetching. > - > > Key: HBASE-12338 > URL: https://issues.apache.org/jira/browse/HBASE-12338 > Project: HBase > Issue Type: Sub-task > Components: Client >Affects Versions: 1.0.0, 2.0.0, 0.98.6.1 >Reporter: Yi Deng >Assignee: Yi Deng > Labels: prefetch, results, scanner > Attachments: > 0001-Add-ScanPrefetcher-for-client-side-scanning-prefetch.patch, > 0001-ScanPrefetcher.patch, > 2.0-0001-Add-ScanPrefetcher-for-client-side-scanning-prefetch.patch, > 2.0-0002-Add-ScanPrefetcher-for-client-side-scanning-prefetch.patch, > 2.0-0003-Add-ScanPrefetcher-for-client-side-scanning-prefetch.patch > > > Since server side prefetching was not proved to be a good way to prefetch, we > need to do it on client side. > This is a wrapper class that takes any instance of `ResultScanner` as the > underneath scanning component. The class will schedule the scanning in a > background thread. There is a buffering queue storing prefetched results, > whose's length is configurable. The prefetcher will release the thread if the > queue is full and wait for results to be consumed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12581) TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 addendum)
[ https://issues.apache.org/jira/browse/HBASE-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-12581: -- Attachment: 12581.txt What I applied to branch-1+ > TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 > addendum) > --- > > Key: HBASE-12581 > URL: https://issues.apache.org/jira/browse/HBASE-12581 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: stack > Fix For: 2.0.0, 0.99.2 > > Attachments: 12581.txt > > > TestCellACLWithMultipleVersions failed after HBASE-12404 went in (though it > passed twice on hadoopqa!). Fails locally too. Here, make a Connection when > we go to check perms. That seems to fix it. Going to commit since patch is > just more of hbase-12404... this is in essence and addendum. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12568) Adopt Semantic Versioning and document it in the book
[ https://issues.apache.org/jira/browse/HBASE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225482#comment-14225482 ] Andrew Purtell commented on HBASE-12568: +1 > Adopt Semantic Versioning and document it in the book > - > > Key: HBASE-12568 > URL: https://issues.apache.org/jira/browse/HBASE-12568 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar > Fix For: 0.99.2 > > > See > http://search-hadoop.com/m/DHED4LFNzP/semantic+versioning&subj=Re+HBase+Semantic+Versioning > We should put that in the book. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (HBASE-12581) TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 addendum)
[ https://issues.apache.org/jira/browse/HBASE-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-12581. --- Resolution: Fixed Pushed to branch-1+ > TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 > addendum) > --- > > Key: HBASE-12581 > URL: https://issues.apache.org/jira/browse/HBASE-12581 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: stack > Fix For: 2.0.0, 0.99.2 > > Attachments: 12581.txt > > > TestCellACLWithMultipleVersions failed after HBASE-12404 went in (though it > passed twice on hadoopqa!). Fails locally too. Here, make a Connection when > we go to check perms. That seems to fix it. Going to commit since patch is > just more of hbase-12404... this is in essence and addendum. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (HBASE-12571) hbase shell hung when enable table after rebooting base
[ https://issues.apache.org/jira/browse/HBASE-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell resolved HBASE-12571. Resolution: Invalid Please mail u...@hbase.apache.org for help with user issues. > hbase shell hung when enable table after rebooting base > --- > > Key: HBASE-12571 > URL: https://issues.apache.org/jira/browse/HBASE-12571 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.99.1 > Environment: 0.99.1 with hadoop 2.5.2 on CentOS 6.5 64bit >Reporter: Xiaobogu > > you can follow these steps to repeat the bug: > hbase shell > create 'test', 'cf' > disable 'test' > reboot hbase > hbase shell > enable 'test' -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-12581) TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 addendum)
stack created HBASE-12581: - Summary: TestCellACLWithMultipleVersions failing since task 5 HBASE-12404 (HBASE-12404 addendum) Key: HBASE-12581 URL: https://issues.apache.org/jira/browse/HBASE-12581 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: stack Fix For: 2.0.0, 0.99.2 TestCellACLWithMultipleVersions failed after HBASE-12404 went in (though it passed twice on hadoopqa!). Fails locally too. Here, make a Connection when we go to check perms. That seems to fix it. Going to commit since patch is just more of hbase-12404... this is in essence and addendum. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10881) Support reverse scan in thrift2
[ https://issues.apache.org/jira/browse/HBASE-10881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225472#comment-14225472 ] Andrew Purtell commented on HBASE-10881: +1 > Support reverse scan in thrift2 > --- > > Key: HBASE-10881 > URL: https://issues.apache.org/jira/browse/HBASE-10881 > Project: HBase > Issue Type: New Feature > Components: Thrift >Affects Versions: 0.99.0 >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Fix For: 0.99.0 > > Attachments: HBASE-10881-trunk-v1.diff, HBASE-10881-trunk-v2.diff > > > Support reverse scan in thrift2. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12573) Backport HBASE-10591 Sanity check table configuration in createTable
[ https://issues.apache.org/jira/browse/HBASE-12573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225469#comment-14225469 ] Andrew Purtell commented on HBASE-12573: Can we put this up on RB for line-by-line discussion (if any)? > Backport HBASE-10591 Sanity check table configuration in createTable > > > Key: HBASE-12573 > URL: https://issues.apache.org/jira/browse/HBASE-12573 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 0.98.9 > > Attachments: hbase-10591_v5-0.98.patch > > > In parent jira, it seems that we will be better off backporting HBASE-10591. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12570) Missing/invalid split policy class name brings down your HBase cluster
[ https://issues.apache.org/jira/browse/HBASE-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225456#comment-14225456 ] Andrew Purtell commented on HBASE-12570: I agree backporting sanity checks but disabled by default wouldn't be useful. Do we need all of them though? We could start with a full backport patch and remove items that we think might cause issues. Or just address the specific problem described in this issue (missing class in table config shouldn't take down the whole regionserver). Either works for me. > Missing/invalid split policy class name brings down your HBase cluster > -- > > Key: HBASE-12570 > URL: https://issues.apache.org/jira/browse/HBASE-12570 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > > See PHOENIX-1473. If a split policy class cannot be resolved, then your HBase > cluster will be brought down as each region server that successively attempts > to open the region will not find the class and will bring itself down. > One idea to prevent this would be to fail the CREATE TABLE or ALTER TABLE > admin call if the split policy class cannot be found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12580) Zookeeper instantiated even though we might not need it in the shell
[ https://issues.apache.org/jira/browse/HBASE-12580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225425#comment-14225425 ] stack commented on HBASE-12580: --- Seems fine. Waiting on hadoopqa > Zookeeper instantiated even though we might not need it in the shell > > > Key: HBASE-12580 > URL: https://issues.apache.org/jira/browse/HBASE-12580 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.8 >Reporter: Alex Newman >Assignee: Alex Newman > Attachments: HBASE-12580.patch > > > I wrote an alternative registry and connection manager which does not use > zookeeper. However the shell still wants to connect to zookeeper NO MATTER > WHAT. I can see it for supporting zk_dump but, for some reason even though > the shell commands succeed, I get errors scrolling about why it can't attach > to zookeeper -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12128) Cache configuration and RpcController selection for Table in Connection
[ https://issues.apache.org/jira/browse/HBASE-12128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225408#comment-14225408 ] Hudson commented on HBASE-12128: FAILURE: Integrated in HBase-1.0 #503 (See [https://builds.apache.org/job/HBase-1.0/503/]) HBASE-12128 Cache configuration and RpcController selection for Table in Connection (enis: rev b9dfcd01b8248cecdd8fc06632c738fe863af823) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableConfiguration.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java > Cache configuration and RpcController selection for Table in Connection > --- > > Key: HBASE-12128 > URL: https://issues.apache.org/jira/browse/HBASE-12128 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.0.0, 2.0.0 >Reporter: Andrew Purtell >Assignee: Stephen Yuan Jiang > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12128.v1-1.0.patch, HBASE-12128.v1-2.0.patch, > HBASE-12128.v2-2.0.patch > > Original Estimate: 120h > Time Spent: 72h > Remaining Estimate: 48h > > Creating Table instances should be lightweight. Apps that manage their own > Connections are expected to create Tables on demand for each interaction. > However we look up values from Hadoop Configuration when constructing Table > objects for storing to some of its fields. Configuration is a heavyweight > registry that does a lot of string operations and regex matching. Method > calls into Configuration account for 48.25% of CPU time when creating the > HTable object in 0.98. Another ~48% of CPU is spent constructing the desired > RpcController object via reflection in 0.98. Together this can account for > ~20% of total on-CPU time of the client. See parent issue for more detail. > We are using Connection like a factory for Table. We should cache > configuration for Table in Connection. We should also create by reflection > once and cache the desired RpcController object, and clone it for new Tables. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12580) Zookeeper instantiated even though we might not need it in the shell
[ https://issues.apache.org/jira/browse/HBASE-12580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225405#comment-14225405 ] Alex Newman commented on HBASE-12580: - The patch is against apache/0.98 > Zookeeper instantiated even though we might not need it in the shell > > > Key: HBASE-12580 > URL: https://issues.apache.org/jira/browse/HBASE-12580 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.8 >Reporter: Alex Newman >Assignee: Alex Newman > Attachments: HBASE-12580.patch > > > I wrote an alternative registry and connection manager which does not use > zookeeper. However the shell still wants to connect to zookeeper NO MATTER > WHAT. I can see it for supporting zk_dump but, for some reason even though > the shell commands succeed, I get errors scrolling about why it can't attach > to zookeeper -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12580) Zookeeper instantiated even though we might not need it in the shell
[ https://issues.apache.org/jira/browse/HBASE-12580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Newman updated HBASE-12580: Status: Patch Available (was: Open) > Zookeeper instantiated even though we might not need it in the shell > > > Key: HBASE-12580 > URL: https://issues.apache.org/jira/browse/HBASE-12580 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.8 >Reporter: Alex Newman >Assignee: Alex Newman > Attachments: HBASE-12580.patch > > > I wrote an alternative registry and connection manager which does not use > zookeeper. However the shell still wants to connect to zookeeper NO MATTER > WHAT. I can see it for supporting zk_dump but, for some reason even though > the shell commands succeed, I get errors scrolling about why it can't attach > to zookeeper -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12580) Zookeeper instantiated even though we might not need it in the shell
[ https://issues.apache.org/jira/browse/HBASE-12580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Newman updated HBASE-12580: Attachment: HBASE-12580.patch Checkout this super simple patch which solves the problem. It leads to a different problem that if a user runs zk_dump on a cluster with no zk they get an error. Arguably that's fine. > Zookeeper instantiated even though we might not need it in the shell > > > Key: HBASE-12580 > URL: https://issues.apache.org/jira/browse/HBASE-12580 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.8 >Reporter: Alex Newman >Assignee: Alex Newman > Attachments: HBASE-12580.patch > > > I wrote an alternative registry and connection manager which does not use > zookeeper. However the shell still wants to connect to zookeeper NO MATTER > WHAT. I can see it for supporting zk_dump but, for some reason even though > the shell commands succeed, I get errors scrolling about why it can't attach > to zookeeper -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12580) Zookeeper instantiated even though we might not need it in the shell
[ https://issues.apache.org/jira/browse/HBASE-12580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225401#comment-14225401 ] Alex Newman commented on HBASE-12580: - Got it. > Zookeeper instantiated even though we might not need it in the shell > > > Key: HBASE-12580 > URL: https://issues.apache.org/jira/browse/HBASE-12580 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.8 >Reporter: Alex Newman >Assignee: Alex Newman > > I wrote an alternative registry and connection manager which does not use > zookeeper. However the shell still wants to connect to zookeeper NO MATTER > WHAT. I can see it for supporting zk_dump but, for some reason even though > the shell commands succeed, I get errors scrolling about why it can't attach > to zookeeper -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12580) Zookeeper instantiated even though we might not need it in the shell
[ https://issues.apache.org/jira/browse/HBASE-12580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225392#comment-14225392 ] Alex Newman commented on HBASE-12580: - Much like how the catalog tracker also directly ignores it. > Zookeeper instantiated even though we might not need it in the shell > > > Key: HBASE-12580 > URL: https://issues.apache.org/jira/browse/HBASE-12580 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.8 >Reporter: Alex Newman >Assignee: Alex Newman > > I wrote an alternative registry and connection manager which does not use > zookeeper. However the shell still wants to connect to zookeeper NO MATTER > WHAT. I can see it for supporting zk_dump but, for some reason even though > the shell commands succeed, I get errors scrolling about why it can't attach > to zookeeper -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12580) Zookeeper instantiated even though we might not need it in the shell
[ https://issues.apache.org/jira/browse/HBASE-12580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225394#comment-14225394 ] stack commented on HBASE-12580: --- Yeah, as you said. It needs to be taught about the Registry > Zookeeper instantiated even though we might not need it in the shell > > > Key: HBASE-12580 > URL: https://issues.apache.org/jira/browse/HBASE-12580 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.8 >Reporter: Alex Newman >Assignee: Alex Newman > > I wrote an alternative registry and connection manager which does not use > zookeeper. However the shell still wants to connect to zookeeper NO MATTER > WHAT. I can see it for supporting zk_dump but, for some reason even though > the shell commands succeed, I get errors scrolling about why it can't attach > to zookeeper -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12580) Zookeeper instantiated even though we might not need it in the shell
[ https://issues.apache.org/jira/browse/HBASE-12580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225391#comment-14225391 ] Alex Newman commented on HBASE-12580: - I did create a custom registry. I'd like to point out the code above directly instantiates a zookeeper watcher, even though it may never use it. > Zookeeper instantiated even though we might not need it in the shell > > > Key: HBASE-12580 > URL: https://issues.apache.org/jira/browse/HBASE-12580 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.8 >Reporter: Alex Newman >Assignee: Alex Newman > > I wrote an alternative registry and connection manager which does not use > zookeeper. However the shell still wants to connect to zookeeper NO MATTER > WHAT. I can see it for supporting zk_dump but, for some reason even though > the shell commands succeed, I get errors scrolling about why it can't attach > to zookeeper -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12580) Zookeeper instantiated even though we might not need it in the shell
[ https://issues.apache.org/jira/browse/HBASE-12580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225383#comment-14225383 ] stack commented on HBASE-12580: --- Did you use http://hbase.apache.org/xref/org/apache/hadoop/hbase/client/Registry.html... Yeah, have the shell use the Interface? > Zookeeper instantiated even though we might not need it in the shell > > > Key: HBASE-12580 > URL: https://issues.apache.org/jira/browse/HBASE-12580 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.8 >Reporter: Alex Newman >Assignee: Alex Newman > > I wrote an alternative registry and connection manager which does not use > zookeeper. However the shell still wants to connect to zookeeper NO MATTER > WHAT. I can see it for supporting zk_dump but, for some reason even though > the shell commands succeed, I get errors scrolling about why it can't attach > to zookeeper -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12493) User class should provide a way to re-use existing token
[ https://issues.apache.org/jira/browse/HBASE-12493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225372#comment-14225372 ] Gary Helmling commented on HBASE-12493: --- Looking at this issue in more detail, there are a few things wrong with our current means of obtaining authentication tokens: * The User class winds up initiating RPCs, which it really shouldn't * There's no way to do normal connection management for the connections/resources used by those RPCs * The TokenProvider coprocessor setup on the server-side is wasteful I've linked to a couple of issues I've created for the related problems. For this issue, though, we can still address the problem without changing the User API: # Make both User and TokenUtil classes public # Move TokenUtil from hbase-server to hbase-client (which seems a more natural place for it) # Add a method to TokenUtil to fetch a token for the given user if it is not already present in the user credentials # Deprecate the User.obtainAuthTokenForJob() methods in favor of the TokenUtil.obtainTokenForJob() equivalents Then, at some point in the future, we can remove the User.obtainAuthTokenForJob() methods entirely. > User class should provide a way to re-use existing token > > > Key: HBASE-12493 > URL: https://issues.apache.org/jira/browse/HBASE-12493 > Project: HBase > Issue Type: Task >Reporter: Brock Noland > > In HIVE-8874 we had to re-use HBase classes market private to re-use using > tokens. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12580) Zookeeper instantiated even though we might not need it in the shell
[ https://issues.apache.org/jira/browse/HBASE-12580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Newman updated HBASE-12580: Affects Version/s: 0.98.8 > Zookeeper instantiated even though we might not need it in the shell > > > Key: HBASE-12580 > URL: https://issues.apache.org/jira/browse/HBASE-12580 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.8 >Reporter: Alex Newman >Assignee: Alex Newman > > I wrote an alternative registry and connection manager which does not use > zookeeper. However the shell still wants to connect to zookeeper NO MATTER > WHAT. I can see it for supporting zk_dump but, for some reason even though > the shell commands succeed, I get errors scrolling about why it can't attach > to zookeeper -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12580) Zookeeper instantiated even though we might not need it in the shell
[ https://issues.apache.org/jira/browse/HBASE-12580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Newman updated HBASE-12580: Description: I wrote an alternative registry and connection manager which does not use zookeeper. However the shell still wants to connect to zookeeper NO MATTER WHAT. I can see it for supporting zk_dump but, for some reason even though the shell commands succeed, I get errors scrolling about why it can't attach to zookeeper > Zookeeper instantiated even though we might not need it in the shell > > > Key: HBASE-12580 > URL: https://issues.apache.org/jira/browse/HBASE-12580 > Project: HBase > Issue Type: Bug >Reporter: Alex Newman >Assignee: Alex Newman > > I wrote an alternative registry and connection manager which does not use > zookeeper. However the shell still wants to connect to zookeeper NO MATTER > WHAT. I can see it for supporting zk_dump but, for some reason even though > the shell commands succeed, I get errors scrolling about why it can't attach > to zookeeper -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HBASE-12580) Zookeeper instantiated even though we might not need it in the shell
[ https://issues.apache.org/jira/browse/HBASE-12580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Newman reassigned HBASE-12580: --- Assignee: Alex Newman > Zookeeper instantiated even though we might not need it in the shell > > > Key: HBASE-12580 > URL: https://issues.apache.org/jira/browse/HBASE-12580 > Project: HBase > Issue Type: Bug >Reporter: Alex Newman >Assignee: Alex Newman > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12580) Zookeeper instantiated even though we might not need it in the shell
[ https://issues.apache.org/jira/browse/HBASE-12580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225361#comment-14225361 ] Alex Newman commented on HBASE-12580: - This seems to be the offender. Why do we need our own watcher? def initialize(configuration, formatter) @admin = org.apache.hadoop.hbase.client.HBaseAdmin.new(configuration) connection = @admin.getConnection() @conf = configuration @zk_wrapper = org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.new(configuration, "admin", nil) zk = @zk_wrapper.getRecoverableZooKeeper().getZooKeeper() @zk_main = org.apache.zookeeper.ZooKeeperMain.new(zk) @formatter = formatter end > Zookeeper instantiated even though we might not need it in the shell > > > Key: HBASE-12580 > URL: https://issues.apache.org/jira/browse/HBASE-12580 > Project: HBase > Issue Type: Bug >Reporter: Alex Newman > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12580) Zookeeper instantiated even though we might not need it in the shell
[ https://issues.apache.org/jira/browse/HBASE-12580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Newman updated HBASE-12580: I wrote an alternative registry and connection manager which does not use zookeeper. However the shell still wants to connect to zookeeper NO MATTER WHAT. I can see it for supporting zk_dump but, for some reason even though the shell commands succeed, I get errors scrolling about why it can't attach to zookeeper > Zookeeper instantiated even though we might not need it in the shell > > > Key: HBASE-12580 > URL: https://issues.apache.org/jira/browse/HBASE-12580 > Project: HBase > Issue Type: Bug >Reporter: Alex Newman > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-12580) Zookeeper instantiated even though we might not need it in the shell
Alex Newman created HBASE-12580: --- Summary: Zookeeper instantiated even though we might not need it in the shell Key: HBASE-12580 URL: https://issues.apache.org/jira/browse/HBASE-12580 Project: HBase Issue Type: Bug Reporter: Alex Newman -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12493) User class should provide a way to re-use existing token
[ https://issues.apache.org/jira/browse/HBASE-12493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225353#comment-14225353 ] Gary Helmling commented on HBASE-12493: --- Linking to additional refactorings inspired by this issue. > User class should provide a way to re-use existing token > > > Key: HBASE-12493 > URL: https://issues.apache.org/jira/browse/HBASE-12493 > Project: HBase > Issue Type: Task >Reporter: Brock Noland > > In HIVE-8874 we had to re-use HBase classes market private to re-use using > tokens. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-12579) Move obtainAuthTokenForJob() methods out of User
Gary Helmling created HBASE-12579:
-
Summary: Move obtainAuthTokenForJob() methods out of User
Key: HBASE-12579
URL: https://issues.apache.org/jira/browse/HBASE-12579
Project: HBase
Issue Type: Improvement
Components: security
Reporter: Gary Helmling
The {{User}} class currently contains some utility methods to obtain HBase
authentication tokens for the given user. However, these methods initiate an
RPC to the {{TokenProvider}} coprocessor endpoint, an action which should not
be part of the User class' responsibilities.
This leads to a couple of problems:
# The way the methods are currently structured, it is impossible to integrate
them with normal connection management for the cluster (the TokenUtil class
constructs its own HTable instance internally).
# The User class is logically part of the hbase-common module, but uses the
TokenUtil class (part of hbase-server, though it should probably be moved to
hbase-client) through reflection, leading to a hidden dependency.
The {{obtainAuthTokenForJob()}} methods should be deprecated and the process of
obtaining authentication tokens should be moved to use the normal connection
lifecycle.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-12578) Change TokenProvider to a SingletonCoprocessorService
Gary Helmling created HBASE-12578:
-
Summary: Change TokenProvider to a SingletonCoprocessorService
Key: HBASE-12578
URL: https://issues.apache.org/jira/browse/HBASE-12578
Project: HBase
Issue Type: Improvement
Components: security
Reporter: Gary Helmling
The {{TokenProvider}} coprocessor service, which is responsible for issuing
HBase delegation tokens, currently runs a region endpoint. In the security
documentation, we recommend configuring this coprocessor for all table regions,
however, we only ever address delegation token requests to the META region.
When {{TokenProvider}} was first added, region coprocessors were the only way
of adding endpoints. But, since then, we've added support for endpoints for
regionserver and master coprocessors. This makes loading {{TokenProvider}} on
all table regions unnecessarily wasteful.
We can reduce the overhead for {{TokenProvider}} and greatly improve it's
scalability by doing the following:
# Convert {{TokenProvider}} to a {{SingletonCoprocessorService}} that is
configured to run on all regionservers. This will ensure a single instance per
regionserver instead of one per region.
# Direct delegation token requests to a random running regionserver so that we
don't hotspot any single instance with requests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12404) Task 5 from parent: Replace internal HTable constructor use with HConnection#getTable (0.98, 0.99)
[ https://issues.apache.org/jira/browse/HBASE-12404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225338#comment-14225338 ] Enis Soztutar commented on HBASE-12404: --- Great. Thanks for the monumental effort Stack. > Task 5 from parent: Replace internal HTable constructor use with > HConnection#getTable (0.98, 0.99) > -- > > Key: HBASE-12404 > URL: https://issues.apache.org/jira/browse/HBASE-12404 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack > Fix For: 2.0.0, 0.99.2 > > Attachments: > 0001-HBASE-12404-Task-5-from-parent-Replace-internal-HTab.patch, 12404.txt, > 12404.v16.txt, 12404.v16.txt, 12404.v17.txt, 12404v10.txt, 12404v11.txt, > 12404v12.txt, 12404v12.txt, 12404v13.txt, 12404v13.txt, 12404v14.txt, > 12404v15.txt, 12404v18.txt, 12404v19.txt, 12404v19.txt, 12404v2.txt, > 12404v20.txt, 12404v20.txt, 12404v3.txt, 12404v5.txt, 12404v6.txt, > 12404v7.txt, 12404v9.txt > > > Do the step 5. from the [~ndimiduk] list in parent issue. Go through src > code and change all new HTable to instead be connection.getTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (HBASE-11130) Add support for Master endpoint coprocessors
[ https://issues.apache.org/jira/browse/HBASE-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Helmling resolved HBASE-11130. --- Resolution: Duplicate This was already done long ago. > Add support for Master endpoint coprocessors > > > Key: HBASE-11130 > URL: https://issues.apache.org/jira/browse/HBASE-11130 > Project: HBase > Issue Type: New Feature > Components: Coprocessors, master >Reporter: Gary Helmling > > Currently master coprocessors can only function as observers. However, it > would be useful in some cases, especially with "system" tables moving to be > served by the master, for master coprocessors to be able to function as > endpoints. These coprocessors would then have access to master facilities to > be able to perform custom cluster coordination tasks, for example. > One example application of this would be for security grant and revoke > commands, where a master coprocessor could make use of the procedure > mechanism to ensure that all regionservers acknowledge an update before > returning success to the client. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12514) Cleanup HFileOutputFormat legacy code
[
https://issues.apache.org/jira/browse/HBASE-12514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225278#comment-14225278
]
Hadoop QA commented on HBASE-12514:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683639/12514v2.txt
against master branch at commit e6b4300756b7f09a31ba35cb3baf41d294ed6e14.
ATTACHMENT ID: 12683639
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3780 checkstyle errors (more than the master's current 3779 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11834//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11834//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11834//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11834//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11834//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11834//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11834//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11834//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11834//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11834//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11834//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11834//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11834//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11834//console
This message is automatically generated.
> Cleanup HFileOutputFormat legacy code
> -
>
> Key: HBASE-12514
> URL: https://issues.apache.org/jira/browse/HBASE-12514
> Project: HBase
> Issue Type: Bug
>Reporter: Solomon Duskis
>Assignee: Solomon Duskis
> Fix For: 2.0.0, 0.99.2
>
> Attachments: 12514v2.txt, HBASE-12514 (1).patch, HBASE-12514.patch,
> HBASE-12514.patch, HBASE-12514.patch
>
>
> HFileOutputFormat methods route to their HFileOutputFormat2 counterparts.
> Replace all calls to HFileOutputFormat with HFileOutputFormat2 equivalents.
> In the spirit of cleanup, add @Override annotations and helper methods that
> do not require the use of deprecated classes such as HTable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12128) Cache configuration and RpcController selection for Table in Connection
[ https://issues.apache.org/jira/browse/HBASE-12128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-12128: -- Resolution: Fixed Fix Version/s: (was: 1.0.0) 0.99.2 Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) I've pushed this to branch-1+. Forgot to quote you [~syuanjiang] as the author in the commit msg, sorry about that. Anyway thanks for the patch, and thanks for reviews. > Cache configuration and RpcController selection for Table in Connection > --- > > Key: HBASE-12128 > URL: https://issues.apache.org/jira/browse/HBASE-12128 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.0.0, 2.0.0 >Reporter: Andrew Purtell >Assignee: Stephen Yuan Jiang > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12128.v1-1.0.patch, HBASE-12128.v1-2.0.patch, > HBASE-12128.v2-2.0.patch > > Original Estimate: 120h > Time Spent: 72h > Remaining Estimate: 48h > > Creating Table instances should be lightweight. Apps that manage their own > Connections are expected to create Tables on demand for each interaction. > However we look up values from Hadoop Configuration when constructing Table > objects for storing to some of its fields. Configuration is a heavyweight > registry that does a lot of string operations and regex matching. Method > calls into Configuration account for 48.25% of CPU time when creating the > HTable object in 0.98. Another ~48% of CPU is spent constructing the desired > RpcController object via reflection in 0.98. Together this can account for > ~20% of total on-CPU time of the client. See parent issue for more detail. > We are using Connection like a factory for Table. We should cache > configuration for Table in Connection. We should also create by reflection > once and cache the desired RpcController object, and clone it for new Tables. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12404) Task 5 from parent: Replace internal HTable constructor use with HConnection#getTable (0.98, 0.99)
[ https://issues.apache.org/jira/browse/HBASE-12404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225258#comment-14225258 ] Hudson commented on HBASE-12404: FAILURE: Integrated in HBase-1.0 #502 (See [https://builds.apache.org/job/HBase-1.0/502/]) HBASE-12404 Task 5 from parent: Replace internal HTable constructor use with (stack: rev c0cdaf8400831bada22558febbab9681f606e26c) * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClockSkewDetection.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodeLoadBalancer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestPerTableCFReplication.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManagerOnCluster.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionMergeTransaction.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/HRegionPartitioner.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/package-info.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/TruncateTableHandler.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/package-info.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/MetaServerShutdownHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestHFileLinkCleaner.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStateZKImpl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionAdapter.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildOverlap.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaMigrationConvertingToPB.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestLogsCleaner.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java * hbase-server/src/test/java/org/apache/hadoop/hbase/MetaMockingUtil.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodeAssignmentHelper.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java * hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/flush/MasterFlushTableProcedureManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/MockServer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/HRegionPartitioner.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/MockRegionServerServices.java * hbase-server/src/main/java/org/apache/hadoop/hbase/Server.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java * hbase-
[jira] [Commented] (HBASE-12576) Add metrics for rolling the HLog if there are too few DN's in the write pipeline
[
https://issues.apache.org/jira/browse/HBASE-12576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225257#comment-14225257
]
Hadoop QA commented on HBASE-12576:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683638/HBASE-12576-v1.patch
against master branch at commit e6b4300756b7f09a31ba35cb3baf41d294ed6e14.
ATTACHMENT ID: 12683638
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestHCM
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11833//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11833//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11833//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11833//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11833//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11833//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11833//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11833//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11833//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11833//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11833//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11833//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11833//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11833//console
This message is automatically generated.
> Add metrics for rolling the HLog if there are too few DN's in the write
> pipeline
>
>
> Key: HBASE-12576
> URL: https://issues.apache.org/jira/browse/HBASE-12576
> Project: HBase
> Issue Type: Bug
> Components: metrics, wal
>Reporter: Elliott Clark
>Assignee: Elliott Clark
> Fix For: 2.0.0, 0.99.2
>
> Attachments: HBASE-12576-v1.patch, HBASE-12576.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12570) Missing/invalid split policy class name brings down your HBase cluster
[ https://issues.apache.org/jira/browse/HBASE-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225240#comment-14225240 ] Enis Soztutar commented on HBASE-12570: --- bq. I'd be in favor of backporting HBASE-10591 to 0.98. Might lead to surprises, though. That is why I did not propose that back when I originally did the patch. There is a way to disable this with a config option. Porting the patch with this disabled does not make a lot of sense though. We can either bite the bullet, or not do it in 0.98. I think [~apurtell] can make the call. > Missing/invalid split policy class name brings down your HBase cluster > -- > > Key: HBASE-12570 > URL: https://issues.apache.org/jira/browse/HBASE-12570 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > > See PHOENIX-1473. If a split policy class cannot be resolved, then your HBase > cluster will be brought down as each region server that successively attempts > to open the region will not find the class and will bring itself down. > One idea to prevent this would be to fail the CREATE TABLE or ALTER TABLE > admin call if the split policy class cannot be found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12576) Add metrics for rolling the HLog if there are too few DN's in the write pipeline
[ https://issues.apache.org/jira/browse/HBASE-12576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225189#comment-14225189 ] Sean Busbey commented on HBASE-12576: - Ah. that makes sense. Using a mock MetricsWALSource in that test would handle testing everything outside of the compat layers without being too painful AFAICT. > Add metrics for rolling the HLog if there are too few DN's in the write > pipeline > > > Key: HBASE-12576 > URL: https://issues.apache.org/jira/browse/HBASE-12576 > Project: HBase > Issue Type: Bug > Components: metrics, wal >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12576-v1.patch, HBASE-12576.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12576) Add metrics for rolling the HLog if there are too few DN's in the write pipeline
[ https://issues.apache.org/jira/browse/HBASE-12576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225169#comment-14225169 ] Elliott Clark commented on HBASE-12576: --- Yes there still needs to be a test and to actually wire it up. I was just parking it here until I could get a good way to test this well. > Add metrics for rolling the HLog if there are too few DN's in the write > pipeline > > > Key: HBASE-12576 > URL: https://issues.apache.org/jira/browse/HBASE-12576 > Project: HBase > Issue Type: Bug > Components: metrics, wal >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12576-v1.patch, HBASE-12576.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12400) Fix refguide so it does connection#getTable rather than new HTable everywhere.
[ https://issues.apache.org/jira/browse/HBASE-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225168#comment-14225168 ] stack commented on HBASE-12400: --- [~syuanjiang] Are you working on this? Otherwise, I can put up a patch. Or if you want, I can put up a start patch to illustrate and you can take it from there? > Fix refguide so it does connection#getTable rather than new HTable everywhere. > -- > > Key: HBASE-12400 > URL: https://issues.apache.org/jira/browse/HBASE-12400 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: stack >Assignee: Stephen Yuan Jiang > Fix For: 2.0.0, 0.99.2 > > > The refguide has bits of code in it. The code does 'new HTable' to get a > table instance. Rather, it should be promoting the new style where we get a > Connection and then do a getTable on it. Ditto for references to 'new > HBaseAdmin'. See ConnectionFactory for new style. See also > package-info.java in Client for updated example. > Misty, if you are game for this one, I can help w/ how it should look. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12400) Fix refguide so it does connection#getTable rather than new HTable everywhere.
[ https://issues.apache.org/jira/browse/HBASE-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-12400: -- Fix Version/s: 2.0.0 > Fix refguide so it does connection#getTable rather than new HTable everywhere. > -- > > Key: HBASE-12400 > URL: https://issues.apache.org/jira/browse/HBASE-12400 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: stack >Assignee: Stephen Yuan Jiang > Fix For: 2.0.0, 0.99.2 > > > The refguide has bits of code in it. The code does 'new HTable' to get a > table instance. Rather, it should be promoting the new style where we get a > Connection and then do a getTable on it. Ditto for references to 'new > HBaseAdmin'. See ConnectionFactory for new style. See also > package-info.java in Client for updated example. > Misty, if you are game for this one, I can help w/ how it should look. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12404) Task 5 from parent: Replace internal HTable constructor use with HConnection#getTable (0.98, 0.99)
[ https://issues.apache.org/jira/browse/HBASE-12404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-12404: -- Resolution: Fixed Fix Version/s: 2.0.0 Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Committed to master. Took a bunch of shoe-horning to get it into branch-1 -- not a cherry-pick -- but it took eventually and seems to build fine. Will keep an eye on it. > Task 5 from parent: Replace internal HTable constructor use with > HConnection#getTable (0.98, 0.99) > -- > > Key: HBASE-12404 > URL: https://issues.apache.org/jira/browse/HBASE-12404 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack > Fix For: 2.0.0, 0.99.2 > > Attachments: > 0001-HBASE-12404-Task-5-from-parent-Replace-internal-HTab.patch, 12404.txt, > 12404.v16.txt, 12404.v16.txt, 12404.v17.txt, 12404v10.txt, 12404v11.txt, > 12404v12.txt, 12404v12.txt, 12404v13.txt, 12404v13.txt, 12404v14.txt, > 12404v15.txt, 12404v18.txt, 12404v19.txt, 12404v19.txt, 12404v2.txt, > 12404v20.txt, 12404v20.txt, 12404v3.txt, 12404v5.txt, 12404v6.txt, > 12404v7.txt, 12404v9.txt > > > Do the step 5. from the [~ndimiduk] list in parent issue. Go through src > code and change all new HTable to instead be connection.getTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (HBASE-12476) HydraBase Consensus Protocol
[ https://issues.apache.org/jira/browse/HBASE-12476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark resolved HBASE-12476. --- Resolution: Fixed Hadoop Flags: Reviewed Pushed to feature branch. Small tweak to the pom file to get everything wired up. > HydraBase Consensus Protocol > > > Key: HBASE-12476 > URL: https://issues.apache.org/jira/browse/HBASE-12476 > Project: HBase > Issue Type: Sub-task > Components: Consensus, wal >Reporter: Gaurav Menghani >Assignee: Gaurav Menghani > Attachments: 0001-HydraBase-consensus-protocol.patch, > 0002-HydraBase-consensus-protocol.patch > > > This is the first patch for the HydraBase consensus protocol implemented > according to the Raft consensus protocol > (https://ramcloud.stanford.edu/raft.pdf), as advertised in (HBASE-12259) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12333) Add Integration Test Runner which is more friendly
[
https://issues.apache.org/jira/browse/HBASE-12333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225156#comment-14225156
]
Hadoop QA commented on HBASE-12333:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683619/HBASE-12333-v2.patch
against master branch at commit e6b4300756b7f09a31ba35cb3baf41d294ed6e14.
ATTACHMENT ID: 12683619
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 13 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11830//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11830//artifact/patchprocess/patchReleaseAuditWarnings.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11830//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11830//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11830//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11830//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11830//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11830//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11830//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11830//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11830//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11830//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11830//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11830//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11830//console
This message is automatically generated.
> Add Integration Test Runner which is more friendly
> --
>
> Key: HBASE-12333
> URL: https://issues.apache.org/jira/browse/HBASE-12333
> Project: HBase
> Issue Type: New Feature
> Components: test
>Affects Versions: 2.0.0
>Reporter: Manukranth Kolloju
>Assignee: Manukranth Kolloju
> Fix For: 2.0.0
>
> Attachments:
> 0001-HBASE-12333-Add-Integration-Test-Runner-which-is-mor.patch,
> HBASE-12333-v2.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> This Jira is intended to add a Driver class which would run a list of
> Integration tests on an actual hbase cluster. And generate a machine readable
> results file in JSON and put it on HDFS. The idea is to make it easy to run
> driver class using a long list of appropriate command line params and wait
> for the JSON file on the HDFS. This will help in plugging into external
> automation and makes it easier to maintain Continuous Integration Scripts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12576) Add metrics for rolling the HLog if there are too few DN's in the write pipeline
[ https://issues.apache.org/jira/browse/HBASE-12576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225153#comment-14225153 ] Sean Busbey commented on HBASE-12576: - Can we expand o.a.h.h.regionserver.wal.TestLogRolling#testLogRollOnDatanodeDeath to include checking for this metric? Right now it relies on breaking the API so it can parse timestamps out of file names (which also then relies on our clocks not being super terrible). > Add metrics for rolling the HLog if there are too few DN's in the write > pipeline > > > Key: HBASE-12576 > URL: https://issues.apache.org/jira/browse/HBASE-12576 > Project: HBase > Issue Type: Bug > Components: metrics, wal >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12576-v1.patch, HBASE-12576.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12576) Add metrics for rolling the HLog if there are too few DN's in the write pipeline
[ https://issues.apache.org/jira/browse/HBASE-12576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225145#comment-14225145 ] Sean Busbey commented on HBASE-12576: - Shouldn't there be a change to o.a.h.h.regionserver.wal.MetricsWAL? > Add metrics for rolling the HLog if there are too few DN's in the write > pipeline > > > Key: HBASE-12576 > URL: https://issues.apache.org/jira/browse/HBASE-12576 > Project: HBase > Issue Type: Bug > Components: metrics, wal >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12576-v1.patch, HBASE-12576.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12476) HydraBase Consensus Protocol
[ https://issues.apache.org/jira/browse/HBASE-12476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225144#comment-14225144 ] stack commented on HBASE-12476: --- +1 on creating feature branch > HydraBase Consensus Protocol > > > Key: HBASE-12476 > URL: https://issues.apache.org/jira/browse/HBASE-12476 > Project: HBase > Issue Type: Sub-task > Components: Consensus, wal >Reporter: Gaurav Menghani >Assignee: Gaurav Menghani > Attachments: 0001-HydraBase-consensus-protocol.patch, > 0002-HydraBase-consensus-protocol.patch > > > This is the first patch for the HydraBase consensus protocol implemented > according to the Raft consensus protocol > (https://ramcloud.stanford.edu/raft.pdf), as advertised in (HBASE-12259) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12476) HydraBase Consensus Protocol
[ https://issues.apache.org/jira/browse/HBASE-12476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225141#comment-14225141 ] Elliott Clark commented on HBASE-12476: --- I'm +1 on committing this to a feature branch. I'll take the kick from stack as the same. Pushing this to HBASE-12259 > HydraBase Consensus Protocol > > > Key: HBASE-12476 > URL: https://issues.apache.org/jira/browse/HBASE-12476 > Project: HBase > Issue Type: Sub-task > Components: Consensus, wal >Reporter: Gaurav Menghani >Assignee: Gaurav Menghani > Attachments: 0001-HydraBase-consensus-protocol.patch, > 0002-HydraBase-consensus-protocol.patch > > > This is the first patch for the HydraBase consensus protocol implemented > according to the Raft consensus protocol > (https://ramcloud.stanford.edu/raft.pdf), as advertised in (HBASE-12259) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225138#comment-14225138 ] stack commented on HBASE-12490: --- [~sduskis] Looks like you need to rebase? > Replace uses of setAutoFlush(boolean, boolean) > -- > > Key: HBASE-12490 > URL: https://issues.apache.org/jira/browse/HBASE-12490 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 0.99.2 >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Attachments: HBASE-12490.patch, HBASE-12490B.patch, > HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch > > > The various uses of setAutoFlush() seem to need some tlc. There's a note in > HTableInterface: "@deprecated in 0.99 since setting clearBufferOnFail is > deprecated. Use setAutoFlushTo(boolean) instead." It would be ideal to > change all internal uses of setAutoFlush(boolean, boolean) to use > setAutoFlushTo, if possible. > HTable.setAutoFlush(boolean, boolean) is used in a handful of places. > setAutoFlush(false, false) has the same results as > HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the > same affect as Table.setAutoFlushTo(false), assuming > HTable.setAutoFlush(false) was not called previously (by default, the second > parameter, clearBufferOnFail, is true and should remain true according to the > comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12338) Client side scanning prefetching.
[ https://issues.apache.org/jira/browse/HBASE-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225129#comment-14225129 ] stack commented on HBASE-12338: --- Numbers are nice improvement. Has patch been updated on phabricator? Needs release note on how and why you'd use it. Thanks [~daviddengcn] > Client side scanning prefetching. > - > > Key: HBASE-12338 > URL: https://issues.apache.org/jira/browse/HBASE-12338 > Project: HBase > Issue Type: Sub-task > Components: Client >Affects Versions: 1.0.0, 2.0.0, 0.98.6.1 >Reporter: Yi Deng >Assignee: Yi Deng > Labels: prefetch, results, scanner > Attachments: > 0001-Add-ScanPrefetcher-for-client-side-scanning-prefetch.patch, > 0001-ScanPrefetcher.patch, > 2.0-0001-Add-ScanPrefetcher-for-client-side-scanning-prefetch.patch, > 2.0-0002-Add-ScanPrefetcher-for-client-side-scanning-prefetch.patch, > 2.0-0003-Add-ScanPrefetcher-for-client-side-scanning-prefetch.patch > > > Since server side prefetching was not proved to be a good way to prefetch, we > need to do it on client side. > This is a wrapper class that takes any instance of `ResultScanner` as the > underneath scanning component. The class will schedule the scanning in a > background thread. There is a buffering queue storing prefetched results, > whose's length is configurable. The prefetcher will release the thread if the > queue is full and wait for results to be consumed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12476) HydraBase Consensus Protocol
[ https://issues.apache.org/jira/browse/HBASE-12476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaurav Menghani updated HBASE-12476: Attachment: 0002-HydraBase-consensus-protocol.patch Final patch of the squashed commits after addressing Ted's comments. > HydraBase Consensus Protocol > > > Key: HBASE-12476 > URL: https://issues.apache.org/jira/browse/HBASE-12476 > Project: HBase > Issue Type: Sub-task > Components: Consensus, wal >Reporter: Gaurav Menghani >Assignee: Gaurav Menghani > Attachments: 0001-HydraBase-consensus-protocol.patch, > 0002-HydraBase-consensus-protocol.patch > > > This is the first patch for the HydraBase consensus protocol implemented > according to the Raft consensus protocol > (https://ramcloud.stanford.edu/raft.pdf), as advertised in (HBASE-12259) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12514) Cleanup HFileOutputFormat legacy code
[ https://issues.apache.org/jira/browse/HBASE-12514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-12514: -- Attachment: 12514v2.txt Rebase of [~sduskis]'s patch. > Cleanup HFileOutputFormat legacy code > - > > Key: HBASE-12514 > URL: https://issues.apache.org/jira/browse/HBASE-12514 > Project: HBase > Issue Type: Bug >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 2.0.0, 0.99.2 > > Attachments: 12514v2.txt, HBASE-12514 (1).patch, HBASE-12514.patch, > HBASE-12514.patch, HBASE-12514.patch > > > HFileOutputFormat methods route to their HFileOutputFormat2 counterparts. > Replace all calls to HFileOutputFormat with HFileOutputFormat2 equivalents. > In the spirit of cleanup, add @Override annotations and helper methods that > do not require the use of deprecated classes such as HTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12559) Provide LoadBalancer with online configuration capability
[
https://issues.apache.org/jira/browse/HBASE-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225122#comment-14225122
]
Hadoop QA commented on HBASE-12559:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683611/12559-v3.txt
against master branch at commit e6b4300756b7f09a31ba35cb3baf41d294ed6e14.
ATTACHMENT ID: 12683611
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3781 checkstyle errors (more than the master's current 3779 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ * rpc
UpdateMasterConfiguration(.UpdateMasterConfigurationRequest) returns
(.UpdateMasterConfigurationResponse);
+ * rpc UpdateMasterConfiguration(.UpdateMasterConfigurationRequest)
returns (.UpdateMasterConfigurationResponse);
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestNamespace
org.apache.hadoop.hbase.client.TestScannerTimeout
org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient
org.apache.hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient
org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook
org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions
org.apache.hadoop.hbase.coprocessor.TestMasterObserver
org.apache.hadoop.hbase.TestMultiVersions
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint
org.apache.hadoop.hbase.coprocessor.TestDoubleColumnInterpreter
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove
org.apache.hadoop.hbase.coprocessor.TestWALObserver
org.apache.hadoop.hbase.client.TestTableSnapshotScanner
org.apache.hadoop.hbase.constraint.TestConstraint
org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithRemove
org.apache.hadoop.hbase.TestZooKeeper
org.apache.hadoop.hbase.coprocessor.TestHTableWrapper
org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint
org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint
org.apache.hadoop.hbase.client.TestHTableMultiplexer
org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient
org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot
org.apache.hadoop.hbase.coprocessor.TestRegionServerObserver
org.apache.hadoop.hbase.coprocessor.TestClassLoading
org.apache.hadoop.hbase.client.TestReplicaWithCluster
org.apache.hadoop.hbase.coprocessor.TestOpenTableInCoprocessor
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
org.apache.hadoop.hbase.client.TestSnapshotMetadata
org.apache.hadoop.hbase.snapshot.TestExportSnapshot
org.apache.hadoop.hbase.client.TestReplicasClient
org.apache.hadoop.hbase.TestJMXListener
org.apache.hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint
org.apache.hadoop.hbase.TestHColumnDescriptorDefaultVersions
org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache
org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface
org.apache.hadoop.hbase.client.TestFromClientSide3
org.apache.hadoop.hbase.TestIOFencing
org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithAbort
org.apache.hadoop.hbase.coprocessor.TestCoprocessorStop
org.apache.hadoop.hbase.coprocessor.TestAggregateProtocol
Test results:
http
[jira] [Updated] (HBASE-12576) Add metrics for rolling the HLog if there are too few DN's in the write pipeline
[ https://issues.apache.org/jira/browse/HBASE-12576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-12576: -- Attachment: HBASE-12576-v1.patch Whoops missed adding some files. > Add metrics for rolling the HLog if there are too few DN's in the write > pipeline > > > Key: HBASE-12576 > URL: https://issues.apache.org/jira/browse/HBASE-12576 > Project: HBase > Issue Type: Bug > Components: metrics, wal >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12576-v1.patch, HBASE-12576.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12514) Cleanup HFileOutputFormat legacy code
[ https://issues.apache.org/jira/browse/HBASE-12514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225110#comment-14225110 ] Solomon Duskis commented on HBASE-12514: This is strange. I got the same problem on another patch. I'd guess this is a problem with the build process rather than my patches. > Cleanup HFileOutputFormat legacy code > - > > Key: HBASE-12514 > URL: https://issues.apache.org/jira/browse/HBASE-12514 > Project: HBase > Issue Type: Bug >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12514 (1).patch, HBASE-12514.patch, > HBASE-12514.patch, HBASE-12514.patch > > > HFileOutputFormat methods route to their HFileOutputFormat2 counterparts. > Replace all calls to HFileOutputFormat with HFileOutputFormat2 equivalents. > In the spirit of cleanup, add @Override annotations and helper methods that > do not require the use of deprecated classes such as HTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12338) Client side scanning prefetching.
[ https://issues.apache.org/jira/browse/HBASE-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225109#comment-14225109 ] Yi Deng commented on HBASE-12338: - [~stack], I've made the benchmarking. Anything that prevents this patch to be reviewed? > Client side scanning prefetching. > - > > Key: HBASE-12338 > URL: https://issues.apache.org/jira/browse/HBASE-12338 > Project: HBase > Issue Type: Sub-task > Components: Client >Affects Versions: 1.0.0, 2.0.0, 0.98.6.1 >Reporter: Yi Deng >Assignee: Yi Deng > Labels: prefetch, results, scanner > Attachments: > 0001-Add-ScanPrefetcher-for-client-side-scanning-prefetch.patch, > 0001-ScanPrefetcher.patch, > 2.0-0001-Add-ScanPrefetcher-for-client-side-scanning-prefetch.patch, > 2.0-0002-Add-ScanPrefetcher-for-client-side-scanning-prefetch.patch, > 2.0-0003-Add-ScanPrefetcher-for-client-side-scanning-prefetch.patch > > > Since server side prefetching was not proved to be a good way to prefetch, we > need to do it on client side. > This is a wrapper class that takes any instance of `ResultScanner` as the > underneath scanning component. The class will schedule the scanning in a > background thread. There is a buffering queue storing prefetched results, > whose's length is configurable. The prefetcher will release the thread if the > queue is full and wait for results to be consumed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12576) Add metrics for rolling the HLog if there are too few DN's in the write pipeline
[
https://issues.apache.org/jira/browse/HBASE-12576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225104#comment-14225104
]
Hadoop QA commented on HBASE-12576:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683634/HBASE-12576.patch
against master branch at commit e6b4300756b7f09a31ba35cb3baf41d294ed6e14.
ATTACHMENT ID: 12683634
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color}. The patch appears to cause mvn compile goal to
fail.
Compilation errors resume:
[ERROR] COMPILATION ERROR :
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LogRoller.java:[65,9]
method does not override or implement a method from a supertype
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/DisabledWALProvider.java:[113,19]
method logRollRequested in interface
org.apache.hadoop.hbase.regionserver.wal.WALActionsListener cannot be applied
to given types;
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on
project hbase-server: Compilation failure: Compilation failure:
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LogRoller.java:[65,9]
method does not override or implement a method from a supertype
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/DisabledWALProvider.java:[113,19]
method logRollRequested in interface
org.apache.hadoop.hbase.regionserver.wal.WALActionsListener cannot be applied
to given types;
[ERROR] required: boolean
[ERROR] found: no arguments
[ERROR] reason: actual and formal argument lists differ in length
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn -rf :hbase-server
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11832//console
This message is automatically generated.
> Add metrics for rolling the HLog if there are too few DN's in the write
> pipeline
>
>
> Key: HBASE-12576
> URL: https://issues.apache.org/jira/browse/HBASE-12576
> Project: HBase
> Issue Type: Bug
> Components: metrics, wal
>Reporter: Elliott Clark
>Assignee: Elliott Clark
> Fix For: 2.0.0, 0.99.2
>
> Attachments: HBASE-12576.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12576) Add metrics for rolling the HLog if there are too few DN's in the write pipeline
[ https://issues.apache.org/jira/browse/HBASE-12576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-12576: -- Fix Version/s: 0.99.2 2.0.0 Status: Patch Available (was: Open) > Add metrics for rolling the HLog if there are too few DN's in the write > pipeline > > > Key: HBASE-12576 > URL: https://issues.apache.org/jira/browse/HBASE-12576 > Project: HBase > Issue Type: Bug > Components: metrics, wal >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12576.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12576) Add metrics for rolling the HLog if there are too few DN's in the write pipeline
[ https://issues.apache.org/jira/browse/HBASE-12576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-12576: -- Attachment: HBASE-12576.patch > Add metrics for rolling the HLog if there are too few DN's in the write > pipeline > > > Key: HBASE-12576 > URL: https://issues.apache.org/jira/browse/HBASE-12576 > Project: HBase > Issue Type: Bug > Components: metrics, wal >Reporter: Elliott Clark >Assignee: Elliott Clark > Attachments: HBASE-12576.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12514) Cleanup HFileOutputFormat legacy code
[
https://issues.apache.org/jira/browse/HBASE-12514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225089#comment-14225089
]
Hadoop QA commented on HBASE-12514:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683632/HBASE-12514.patch
against master branch at commit e6b4300756b7f09a31ba35cb3baf41d294ed6e14.
ATTACHMENT ID: 12683632
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11831//console
This message is automatically generated.
> Cleanup HFileOutputFormat legacy code
> -
>
> Key: HBASE-12514
> URL: https://issues.apache.org/jira/browse/HBASE-12514
> Project: HBase
> Issue Type: Bug
>Reporter: Solomon Duskis
>Assignee: Solomon Duskis
> Fix For: 2.0.0, 0.99.2
>
> Attachments: HBASE-12514 (1).patch, HBASE-12514.patch,
> HBASE-12514.patch, HBASE-12514.patch
>
>
> HFileOutputFormat methods route to their HFileOutputFormat2 counterparts.
> Replace all calls to HFileOutputFormat with HFileOutputFormat2 equivalents.
> In the spirit of cleanup, add @Override annotations and helper methods that
> do not require the use of deprecated classes such as HTable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12514) Cleanup HFileOutputFormat legacy code
[ https://issues.apache.org/jira/browse/HBASE-12514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Solomon Duskis updated HBASE-12514: --- Attachment: HBASE-12514.patch Trying again, since I can't replicate the test failures locally. > Cleanup HFileOutputFormat legacy code > - > > Key: HBASE-12514 > URL: https://issues.apache.org/jira/browse/HBASE-12514 > Project: HBase > Issue Type: Bug >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-12514 (1).patch, HBASE-12514.patch, > HBASE-12514.patch, HBASE-12514.patch > > > HFileOutputFormat methods route to their HFileOutputFormat2 counterparts. > Replace all calls to HFileOutputFormat with HFileOutputFormat2 equivalents. > In the spirit of cleanup, add @Override annotations and helper methods that > do not require the use of deprecated classes such as HTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
[ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225046#comment-14225046 ] Solomon Duskis commented on HBASE-12490: On a different note... Why is the patch process failing? I'm not sure what I did wrong. > Replace uses of setAutoFlush(boolean, boolean) > -- > > Key: HBASE-12490 > URL: https://issues.apache.org/jira/browse/HBASE-12490 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 0.99.2 >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Attachments: HBASE-12490.patch, HBASE-12490B.patch, > HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch > > > The various uses of setAutoFlush() seem to need some tlc. There's a note in > HTableInterface: "@deprecated in 0.99 since setting clearBufferOnFail is > deprecated. Use setAutoFlushTo(boolean) instead." It would be ideal to > change all internal uses of setAutoFlush(boolean, boolean) to use > setAutoFlushTo, if possible. > HTable.setAutoFlush(boolean, boolean) is used in a handful of places. > setAutoFlush(false, false) has the same results as > HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false, true) has the > same affect as Table.setAutoFlushTo(false), assuming > HTable.setAutoFlush(false) was not called previously (by default, the second > parameter, clearBufferOnFail, is true and should remain true according to the > comments). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12573) Backport HBASE-10591 Sanity check table configuration in createTable
[
https://issues.apache.org/jira/browse/HBASE-12573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Enis Soztutar updated HBASE-12573:
--
Attachment: hbase-10591_v5-0.98.patch
Here is 0.98 patch that applies cleanly.
I've ran
{code}
HW10676:hbase-0.98$ mvn test -Dtest=TestZooKeeper,TestFromClientSide*,TestAdmin*
{code}
but not the rest of the tests.
> Backport HBASE-10591 Sanity check table configuration in createTable
>
>
> Key: HBASE-12573
> URL: https://issues.apache.org/jira/browse/HBASE-12573
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: 0.98.9
>
> Attachments: hbase-10591_v5-0.98.patch
>
>
> In parent jira, it seems that we will be better off backporting HBASE-10591.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12577) Disable distributed log replay by default
[ https://issues.apache.org/jira/browse/HBASE-12577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225023#comment-14225023 ] Sean Busbey commented on HBASE-12577: - +1, though I'd rather see the non-rolling-upgrade barrier move to 2.0. > Disable distributed log replay by default > - > > Key: HBASE-12577 > URL: https://issues.apache.org/jira/browse/HBASE-12577 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Jeffrey Zhong >Priority: Critical > Fix For: 0.99.2 > > > Distributed log replay is an awesome feature, but due of HBASE-11094, the > rolling upgrade story from 0.98 is hard to explain / enforce. > The fix for HBASE-11094 only went into 0.98.4, meaning rolling upgrades from > 0.98.4- might lose data during the upgrade. > I feel no matter how much documentation / warning we do, we cannot prevent > users from doing rolling upgrades from 0.98.4- to 1.0. And we do not want to > inconvenience the user by requiring a two step rolling upgrade. > Thus I think we should disable dist log replay for 1.0, and re-enable it > again for 1.1 (if rolling upgrade from 0.98 is not supported). > ie. undo: HBASE-10888 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-12577) Disable distributed log replay by default
Enis Soztutar created HBASE-12577: - Summary: Disable distributed log replay by default Key: HBASE-12577 URL: https://issues.apache.org/jira/browse/HBASE-12577 Project: HBase Issue Type: Sub-task Reporter: Enis Soztutar Assignee: Jeffrey Zhong Priority: Critical Fix For: 0.99.2 Distributed log replay is an awesome feature, but due of HBASE-11094, the rolling upgrade story from 0.98 is hard to explain / enforce. The fix for HBASE-11094 only went into 0.98.4, meaning rolling upgrades from 0.98.4- might lose data during the upgrade. I feel no matter how much documentation / warning we do, we cannot prevent users from doing rolling upgrades from 0.98.4- to 1.0. And we do not want to inconvenience the user by requiring a two step rolling upgrade. Thus I think we should disable dist log replay for 1.0, and re-enable it again for 1.1 (if rolling upgrade from 0.98 is not supported). ie. undo: HBASE-10888 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12491) TableMapReduceUtil.findContainingJar() NPE
[ https://issues.apache.org/jira/browse/HBASE-12491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225012#comment-14225012 ] Solomon Duskis commented on HBASE-12491: Can this change be applied to branch-1 as well? > TableMapReduceUtil.findContainingJar() NPE > -- > > Key: HBASE-12491 > URL: https://issues.apache.org/jira/browse/HBASE-12491 > Project: HBase > Issue Type: Bug > Components: mapreduce >Affects Versions: 2.0.0, 0.99.2 >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 2.0.0, 0.94.25, 0.98.9, 0.99.2 > > Attachments: HBASE-12491.patch, HBASE-12491.patch > > > Adding a bootclasspath library causes an NPE when running hbase map reduce > jobs in TableMapReduceUtil.findContainingJar(). Classes in the library added > to the bootclasspath get a null classpathLoader. Check for a null loader in > TableMapReduceUtil.findContainingJar(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
