date:20141209

[jira] [Assigned] (HBASE-12568) Adopt Semantic Versioning and document it in the book

2014-12-09 Thread Enis Soztutar (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Enis Soztutar reassigned HBASE-12568:
-

Assignee: Enis Soztutar

 Adopt Semantic Versioning and document it in the book
 -

 Key: HBASE-12568
 URL: https://issues.apache.org/jira/browse/HBASE-12568
 Project: HBase
  Issue Type: Sub-task
Reporter: Enis Soztutar
Assignee: Enis Soztutar
 Fix For: 1.0.0


 See 
 http://search-hadoop.com/m/DHED4LFNzP/semantic+versioningsubj=Re+HBase+Semantic+Versioning
 We should put that in the book.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12564) consolidate the getTableDescriptors() semantic

2014-12-09 Thread Matteo Bertozzi (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-12564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239109#comment-14239109
 ] 

Matteo Bertozzi commented on HBASE-12564:
-

{quote}We need the String and Pattern permutations? (Especially when Pattern 
gets turned into a String down in pb util for shipping to master){quote}
yeah, the String version calls Pattern.compile() to validate the regex. so it 
will be nice to keep it

 consolidate the getTableDescriptors() semantic
 --

 Key: HBASE-12564
 URL: https://issues.apache.org/jira/browse/HBASE-12564
 Project: HBase
  Issue Type: Bug
  Components: Client, master
Affects Versions: 2.0.0
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
 Fix For: 2.0.0

 Attachments: HBASE-12564-v0.patch, HBASE-12564-v1.patch, 
 HBASE-12564-v2.patch


 Master getTableDescriptors() which is called by Admin.listTables() has a 
 couple of different behaviors depending on how it is called. 
 after HBASE-12073 with the AccessController enabled, we now get a global 
 admin required if listTables() is called without a regex otherwise we return 
 only the table that the user can see (we show only the tables that the user 
 have access to, which means or the user is a global admin or it has a 
 table-level create/admin). We probably should have the second behavior even 
 without regex, since I should able to see my own tables. 
 getTableDescriptors() is returning only non system tables. Tools like 
 user_permission that are doing for each listTable(): userPerm(table) are 
 losing the system tables, so stuff like user_permission 'hbase:acls' will not 
 result any result.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-11979) Compaction progress reporting is wrong

2014-12-09 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-11979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239124#comment-14239124
]

Hadoop QA commented on HBASE-11979:
---

{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685945/HBASE-11979.v0.patch
against master branch at commit b4371252fe71db938b37b7bc6391d0fb87466b36.
ATTACHMENT ID: 12685945

{color:green}+1 @author{color}. The patch does not contain any @author
tags.

{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.

{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.

{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.

{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors

{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.

{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).

{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100

{color:green}+1 site{color}. The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}. The patch passed unit tests in .

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12010//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12010//artifact/patchprocess/patchReleaseAuditWarnings.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12010//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12010//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12010//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12010//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12010//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12010//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12010//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12010//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12010//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12010//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12010//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12010//artifact/patchprocess/checkstyle-aggregate.html

Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12010//console

This message is automatically generated.

Compaction progress reporting is wrong
--

Key: HBASE-11979
URL: https://issues.apache.org/jira/browse/HBASE-11979
Project: HBase
Issue Type: Bug
Reporter: Andrew Purtell
Assignee: Esteban Gutierrez
Priority: Minor
Fix For: 1.0.0, 2.0.0, 0.98.9

Attachments: HBASE-11979.v0.patch

This is a long standing problem and previously could be observed in
regionserver metrics, but, we recently added logging for long running
compactions, and this has exposed the issue in a new way, e.g.
{noformat}
2014-09-15 14:20:59,450 DEBUG
[regionserver8120-largeCompactions-1410813534627]
compactions.Compactor: Compaction progress: 22683625/6808179 (333.18%),
rate=162.08 kB/sec
{noformat}
The 'rate' reported in such logging is consistent and what we were really
after, but the progress indication is clearly broken and should be fixed.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12653) Move TestRegionServerOnlineConfigChange TestConfigurationManager to Junit4 tests

2014-12-09 Thread Ashish Singhi (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239130#comment-14239130
 ] 

Ashish Singhi commented on HBASE-12653:
---

-1's not related to patch.

 Move TestRegionServerOnlineConfigChange  TestConfigurationManager to Junit4 
 tests
 --

 Key: HBASE-12653
 URL: https://issues.apache.org/jira/browse/HBASE-12653
 Project: HBase
  Issue Type: Improvement
  Components: test
Affects Versions: 2.0.0, 0.99.2
Reporter: Ashish Singhi
Assignee: Ashish Singhi
Priority: Minor
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12653.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-11677) Make Logger instance modifiers consistent

2014-12-09 Thread Usha Kuchibhotla (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Usha Kuchibhotla updated HBASE-11677:
-
Attachment: HBASE-11677.2.patch

 Make Logger instance modifiers consistent
 -

 Key: HBASE-11677
 URL: https://issues.apache.org/jira/browse/HBASE-11677
 Project: HBase
  Issue Type: Task
Reporter: Sean Busbey
Priority: Minor
  Labels: beginner, sonar
 Attachments: HBASE-11677.2.patch, HBASE-11677.patch


 We have some instances of Logger that are missing one of being private, 
 static, and final.
 ex from HealthChecker.java, missing final
 {code}
 private static Log LOG = LogFactory.getLog(HealthChecker.class);
 {code}
 * Clean up where possible by making {{private static final}}
 * If we can't, add a non-javadoc note about why
 One way to look for problematic instances is to grep for initial assignment 
 for the commonly used LOG member, e.g.
 * missing final: {{grep -r LOG = * | grep -v final}}
 * missing static: {{grep -r LOG = * | grep -v static}}
 * missing private: {{grep -r LOG = * | grep -v private}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-11677) Make Logger instance modifiers consistent

2014-12-09 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239146#comment-14239146
 ] 

Hadoop QA commented on HBASE-11677:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12685971/HBASE-11677.2.patch
  against master branch at commit b4371252fe71db938b37b7bc6391d0fb87466b36.
  ATTACHMENT ID: 12685971

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 511 
new or modified tests.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12013//console

This message is automatically generated.

 Make Logger instance modifiers consistent
 -

 Key: HBASE-11677
 URL: https://issues.apache.org/jira/browse/HBASE-11677
 Project: HBase
  Issue Type: Task
Reporter: Sean Busbey
Priority: Minor
  Labels: beginner, sonar
 Attachments: HBASE-11677.2.patch, HBASE-11677.patch


 We have some instances of Logger that are missing one of being private, 
 static, and final.
 ex from HealthChecker.java, missing final
 {code}
 private static Log LOG = LogFactory.getLog(HealthChecker.class);
 {code}
 * Clean up where possible by making {{private static final}}
 * If we can't, add a non-javadoc note about why
 One way to look for problematic instances is to grep for initial assignment 
 for the commonly used LOG member, e.g.
 * missing final: {{grep -r LOG = * | grep -v final}}
 * missing static: {{grep -r LOG = * | grep -v static}}
 * missing private: {{grep -r LOG = * | grep -v private}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12655) WALPerformanceEvaluation miscalculates append/sync statistics for multiple regions

2014-12-09 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-12655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239157#comment-14239157
]

Hadoop QA commented on HBASE-12655:
---

{color:red}-1 overall{color}. Here are the results of testing the latest
attachment

http://issues.apache.org/jira/secure/attachment/12685952/HBASE-12655.1.patch.txt
against master branch at commit b4371252fe71db938b37b7bc6391d0fb87466b36.
ATTACHMENT ID: 12685952

{color:green}+1 @author{color}. The patch does not contain any @author
tags.

{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.