[jira] [Commented] (HBASE-14490) [RpcServer] reuse request read buffer
[
https://issues.apache.org/jira/browse/HBASE-14490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966840#comment-14966840
]
Zephyr Guo commented on HBASE-14490:
I know you doubling idea.If we use Pool, we hope fewer number of buffer service
more {{Connection}}.If Pool can't reduce amount of buffer dynamically, it will
increase to N ("N" is number of Connection ).In that case, there is no
different between Pool and non-pool.I'm thinking about Pool that can control
the number of buffer and each size of buffer.
{quote}
The last patch is based on the assumption that the size of coming data would be
almost same, but it seems not to be true
{quote}
It maintain average size.It expect hitting 50% req.
> [RpcServer] reuse request read buffer
> -
>
> Key: HBASE-14490
> URL: https://issues.apache.org/jira/browse/HBASE-14490
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
>Affects Versions: 2.0.0, 1.0.2
>Reporter: Zephyr Guo
>Assignee: Zephyr Guo
> Labels: performance
> Fix For: 2.0.0, 1.0.2
>
> Attachments: ByteBufferPool.java, HBASE-14490-v1.patch,
> HBASE-14490-v10.patch, HBASE-14490-v11.patch, HBASE-14490-v2.patch,
> HBASE-14490-v3.patch, HBASE-14490-v4.patch, HBASE-14490-v5.patch,
> HBASE-14490-v6.patch, HBASE-14490-v7.patch, HBASE-14490-v8.patch,
> HBASE-14490-v9.patch
>
>
> Reuse buffer to read request.It's not necessary to every request free
> buffer.The idea of optimization is to reduce the times that allocate
> ByteBuffer.
> *Modification*
> 1. {{saslReadAndProcess}} ,{{processOneRpc}}, {{processUnwrappedData}},
> {{processConnectionHeader}} accept a ByteBuffer instead of byte[].They can
> move {{ByteBuffer.position}} correctly when we have read the data.
> 2. {{processUnwrappedData}} no longer use any extra memory.
> 3. Maintaining a reused ByteBuffer in each {{Connection}}.
> a) Size is dynamic to fit specific client.
> b) If size deviate far from average size, we replace a new one.
> c) Using a SoftReference to reference the buffer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
[
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966863#comment-14966863
]
Ted Yu commented on HBASE-14655:
{code}
Fetching https://builds.apache.org/job/PreCommit-HBASE-Build/16133/console
Printing hanging tests
Hanging test : org.apache.hadoop.hbase.TestIOFencing
Printing Failing tests
{code}
I don't think hanging TestIOFencing is related to the change in my patch.
> Narrow the scope of doAs() calls to region observer notifications for
> compaction
>
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling
> doAs() for compaction related region observer notifications should be
> narrowed.
> User object is passed from CompactSplitThread down to the methods where
> region observer notifications are made.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14671) Remove deprecated HBaseTestCase/Put/Delete apis from TestGetClosestAtOrBefore
[ https://issues.apache.org/jira/browse/HBASE-14671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968546#comment-14968546 ] stack commented on HBASE-14671: --- Go for it > Remove deprecated HBaseTestCase/Put/Delete apis from TestGetClosestAtOrBefore > - > > Key: HBASE-14671 > URL: https://issues.apache.org/jira/browse/HBASE-14671 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14671.patch > > > converting from long deprecated apis to modern apis. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
[ https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-14655: --- Status: Open (was: Patch Available) > Narrow the scope of doAs() calls to region observer notifications for > compaction > > > Key: HBASE-14655 > URL: https://issues.apache.org/jira/browse/HBASE-14655 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, > 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, > 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, > 14655-v6.txt, 14655-v7.txt > > > As what has been done in HBASE-14631 and HBASE-14605, the scope of calling > doAs() for compaction related region observer notifications should be > narrowed. > User object is passed from CompactSplitThread down to the methods where > region observer notifications are made. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
[ https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-14655: --- Attachment: 14655-v8.txt > Narrow the scope of doAs() calls to region observer notifications for > compaction > > > Key: HBASE-14655 > URL: https://issues.apache.org/jira/browse/HBASE-14655 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, > 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, > 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, > 14655-v6.txt, 14655-v7.txt, 14655-v8.txt > > > As what has been done in HBASE-14631 and HBASE-14605, the scope of calling > doAs() for compaction related region observer notifications should be > narrowed. > User object is passed from CompactSplitThread down to the methods where > region observer notifications are made. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14663) HStore::close does not honor config hbase.rs.evictblocksonclose
[
https://issues.apache.org/jira/browse/HBASE-14663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968598#comment-14968598
]
Hudson commented on HBASE-14663:
FAILURE: Integrated in HBase-1.0 #1094 (See
[https://builds.apache.org/job/HBase-1.0/1094/])
HBASE-14663 HStore::close does not honor config (stack: rev
252b641e2f0f51b4fa0a2329870a984fe7ce45ac)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
> HStore::close does not honor config hbase.rs.evictblocksonclose
> ---
>
> Key: HBASE-14663
> URL: https://issues.apache.org/jira/browse/HBASE-14663
> Project: HBase
> Issue Type: Bug
> Components: BlockCache, regionserver
>Affects Versions: 1.0.0
>Reporter: Randy Fox
>Assignee: Vladimir Rodionov
>Priority: Minor
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3
>
> Attachments: HBASE-14663-v1.patch
>
>
> I noticed moving regions was slow and due to the wait for the bucket cache to
> clear. I tried setting hbase.rs.evictblocksonclose and it did not help.
> I see the HStore::close method has evictonclose hard coded to true instead of
> letting the config dictate:
> // close each store file in parallel
> CompletionService completionService =
>new ExecutorCompletionService(storeFileCloserThreadPool);
> for (final StoreFile f : result) {
>completionService.submit(new Callable() {
> @Override
> public Void call() throws IOException {
>f.closeReader(true);
>return null;
> }
>});
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14670) Remove deprecated HBaseTestCase from TestBlocksRead
[ https://issues.apache.org/jira/browse/HBASE-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14670: --- Attachment: hbase-14670-v2.patch v2 is a fixup. > Remove deprecated HBaseTestCase from TestBlocksRead > > > Key: HBASE-14670 > URL: https://issues.apache.org/jira/browse/HBASE-14670 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14670-v2.patch, hbase-14670.patch > > > removing dependency on long deprecated apis -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
[ https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968494#comment-14968494 ] Jerry He commented on HBASE-14655: -- bq. Since stripe compaction is of limited use, I suggest tackling it in separate JIRA. Okay. +1 The test failure does not seem to be related. Let us know if it is. > Narrow the scope of doAs() calls to region observer notifications for > compaction > > > Key: HBASE-14655 > URL: https://issues.apache.org/jira/browse/HBASE-14655 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, > 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-v1.txt, 14655-v2.txt, > 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt > > > As what has been done in HBASE-14631 and HBASE-14605, the scope of calling > doAs() for compaction related region observer notifications should be > narrowed. > User object is passed from CompactSplitThread down to the methods where > region observer notifications are made. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
[ https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-14655: --- Attachment: 14655-branch-1-v7.txt > Narrow the scope of doAs() calls to region observer notifications for > compaction > > > Key: HBASE-14655 > URL: https://issues.apache.org/jira/browse/HBASE-14655 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, > 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-v1.txt, 14655-v2.txt, > 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt > > > As what has been done in HBASE-14631 and HBASE-14605, the scope of calling > doAs() for compaction related region observer notifications should be > narrowed. > User object is passed from CompactSplitThread down to the methods where > region observer notifications are made. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
[ https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968206#comment-14968206 ] Ted Yu edited comment on HBASE-14655 at 10/22/15 4:28 AM: -- Thanks for the review, Jerry. Patch v6 addresses #2 by adding @Deprecated For #1, the code path for stripe compaction is quite involved. Since stripe compaction is of limited use, I suggest tackling it in separate JIRA. was (Author: yuzhih...@gmail.com): Thanks for the review, Jerry. Patch v6 addresses #1 by adding @Deprecated For #2, the code path for stripe compaction is quite involved. Since stripe compaction is of limited use, I suggest tackling it in separate JIRA. > Narrow the scope of doAs() calls to region observer notifications for > compaction > > > Key: HBASE-14655 > URL: https://issues.apache.org/jira/browse/HBASE-14655 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, > 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, > 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, > 14655-v6.txt, 14655-v7.txt > > > As what has been done in HBASE-14631 and HBASE-14605, the scope of calling > doAs() for compaction related region observer notifications should be > narrowed. > User object is passed from CompactSplitThread down to the methods where > region observer notifications are made. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14666) Remove deprecated HBaseTestingUtility#deleteTable methods
[ https://issues.apache.org/jira/browse/HBASE-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968524#comment-14968524 ] Apekshit Sharma commented on HBASE-14666: - +1 > Remove deprecated HBaseTestingUtility#deleteTable methods > - > > Key: HBASE-14666 > URL: https://issues.apache.org/jira/browse/HBASE-14666 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14666.patch > > > HBase has had the TableName APIs since 0.96 and our test code doesn't have > privacy/stability markers so we should be able to remove the deprecated > methods in 2.0.0. > deleteTable has some separate unit test related cleanup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14665) Remove deprecated HBaseTestingUtility#createTable methods
[ https://issues.apache.org/jira/browse/HBASE-14665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968525#comment-14968525 ] Jonathan Hsieh commented on HBASE-14665: Looks like stack +1ed this also so I'm going to go ahead and commit. > Remove deprecated HBaseTestingUtility#createTable methods > - > > Key: HBASE-14665 > URL: https://issues.apache.org/jira/browse/HBASE-14665 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14665.patch > > > HBase has had the TableName APIs since 0.96 and our test code doesn't have > privacy/stability markers so we should be able to remove the deprecated > methods in 2.0.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
[ https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968529#comment-14968529 ] stack commented on HBASE-14655: --- Our patch builds have effectively stabilized. Suggest retry the patch. Seems like a checkstyle issue still. > Narrow the scope of doAs() calls to region observer notifications for > compaction > > > Key: HBASE-14655 > URL: https://issues.apache.org/jira/browse/HBASE-14655 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, > 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, > 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, > 14655-v6.txt, 14655-v7.txt > > > As what has been done in HBASE-14631 and HBASE-14605, the scope of calling > doAs() for compaction related region observer notifications should be > narrowed. > User object is passed from CompactSplitThread down to the methods where > region observer notifications are made. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14662) Fix NPE in HFileOutputFormat2
[
https://issues.apache.org/jira/browse/HBASE-14662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-14662:
--
Resolution: Fixed
Assignee: Heng Chen
Hadoop Flags: Reviewed
Fix Version/s: 1.3.0
2.0.0
Status: Resolved (was: Patch Available)
Pushed to branch-1 and to master (doesn't seem to go back any further). Nice
fix [~chenheng] Agree with your reasoning. Thanks.
> Fix NPE in HFileOutputFormat2
> -
>
> Key: HBASE-14662
> URL: https://issues.apache.org/jira/browse/HBASE-14662
> Project: HBase
> Issue Type: Sub-task
>Reporter: Heng Chen
>Assignee: Heng Chen
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14662.patch
>
>
> When i dig in HBASE-14659, i run testWritingPEData. There are a lot of NPE
> thrown and testcase run a long time.
> The reason is that, in {{HFileOutputFormat2}}
> {code}
> HRegionLocation loc = null;
> String tableName = conf.get(OUTPUT_TABLE_NAME_CONF_KEY);
> try (Connection connection =
> ConnectionFactory.createConnection(conf);
>RegionLocator locator =
>
> connection.getRegionLocator(TableName.valueOf(tableName))) {
> loc = locator.getRegionLocation(rowKey);
> } catch (Throwable e) {
> LOG.warn("there's something wrong when locating rowkey: " +
> Bytes.toString(rowKey), e);
> loc = null;
> }
> {code}
> Because we did not set {{OUTPUT_TABLE_NAME_CONF_KEY}}, So tableName is null,
> So NPE thrown.
> And connection will be created which RegionLocator use to find region
> location. Because zk is not start in this testcase, So it will retry many
> times.
> But all this actions are not required, we can skip create connection by
> check whether tableName is null
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14669) remove unused import and fix javadoc
[ https://issues.apache.org/jira/browse/HBASE-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968541#comment-14968541 ] stack commented on HBASE-14669: --- +1 137k is a record. Good one. > remove unused import and fix javadoc > > > Key: HBASE-14669 > URL: https://issues.apache.org/jira/browse/HBASE-14669 > Project: HBase > Issue Type: Improvement >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Trivial > Attachments: HBASE-14669-v0.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14659) Fix flakey TestHFileOutputFormat
[ https://issues.apache.org/jira/browse/HBASE-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968539#comment-14968539 ] stack commented on HBASE-14659: --- bq. Could all tests run MR without MiniMapReduceCluster? It seems to be much faster. This is a radical suggestion. I think it a good one. We don't need to 'test' clustered MR especially in a unit test. Suggest bringing it up on dev list as a discussion point [~chenheng] > Fix flakey TestHFileOutputFormat > > > Key: HBASE-14659 > URL: https://issues.apache.org/jira/browse/HBASE-14659 > Project: HBase > Issue Type: Bug >Reporter: Heng Chen > > As i said in HBASE-14654 > This testcase was hanged twice recently. > the two QA information: > https://builds.apache.org/job/PreCommit-HBASE-Build/16118/console > https://builds.apache.org/job/PreCommit-HBASE-Build/16117/console > I notice that the two QA running simultaneously on same machine H0. > I doubt If there are some common resources the two QA conflicts. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14659) Fix flakey TestHFileOutputFormat
[ https://issues.apache.org/jira/browse/HBASE-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968567#comment-14968567 ] Heng Chen commented on HBASE-14659: --- Thanks [~stack]. I have send mail to d...@hbase.apache.org > Fix flakey TestHFileOutputFormat > > > Key: HBASE-14659 > URL: https://issues.apache.org/jira/browse/HBASE-14659 > Project: HBase > Issue Type: Bug >Reporter: Heng Chen > > As i said in HBASE-14654 > This testcase was hanged twice recently. > the two QA information: > https://builds.apache.org/job/PreCommit-HBASE-Build/16118/console > https://builds.apache.org/job/PreCommit-HBASE-Build/16117/console > I notice that the two QA running simultaneously on same machine H0. > I doubt If there are some common resources the two QA conflicts. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14652) Improve / update publish-website script in dev-support
[ https://issues.apache.org/jira/browse/HBASE-14652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968593#comment-14968593 ] Misty Stanley-Jones commented on HBASE-14652: - I've been using this for a couple days and it seems fine. Resolving. > Improve / update publish-website script in dev-support > -- > > Key: HBASE-14652 > URL: https://issues.apache.org/jira/browse/HBASE-14652 > Project: HBase > Issue Type: Task > Components: scripts >Affects Versions: 2.0.0 >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-14652.patch > > > Since I wrote the script some parts of the build process have changed. Need > to update it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (HBASE-14652) Improve / update publish-website script in dev-support
[ https://issues.apache.org/jira/browse/HBASE-14652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Misty Stanley-Jones resolved HBASE-14652. - Resolution: Fixed > Improve / update publish-website script in dev-support > -- > > Key: HBASE-14652 > URL: https://issues.apache.org/jira/browse/HBASE-14652 > Project: HBase > Issue Type: Task > Components: scripts >Affects Versions: 2.0.0 >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-14652.patch > > > Since I wrote the script some parts of the build process have changed. Need > to update it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
[ https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-14655: --- Attachment: (was: 14655-v8.txt) > Narrow the scope of doAs() calls to region observer notifications for > compaction > > > Key: HBASE-14655 > URL: https://issues.apache.org/jira/browse/HBASE-14655 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, > 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, > 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, > 14655-v6.txt, 14655-v7.txt > > > As what has been done in HBASE-14631 and HBASE-14605, the scope of calling > doAs() for compaction related region observer notifications should be > narrowed. > User object is passed from CompactSplitThread down to the methods where > region observer notifications are made. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14603) Lots of work on the POM to enhance Javadocs, Xrefs
[ https://issues.apache.org/jira/browse/HBASE-14603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Misty Stanley-Jones updated HBASE-14603: Status: Open (was: Patch Available) > Lots of work on the POM to enhance Javadocs, Xrefs > -- > > Key: HBASE-14603 > URL: https://issues.apache.org/jira/browse/HBASE-14603 > Project: HBase > Issue Type: Bug > Components: documentation >Affects Versions: 2.0.0 >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-14603-v2.patch, HBASE-14603-v3.patch, > HBASE-14603-v4.patch, HBASE-14603-v5.patch, HBASE-14603-v6.patch, > HBASE-14603-v7.patch, HBASE-14603.patch > > > If we disable the timestamps (which are in HTML comments), then every Javadoc > file won't show up as different every time we rebuild the site. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14603) Lots of work on the POM to enhance Javadocs, Xrefs
[ https://issues.apache.org/jira/browse/HBASE-14603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Misty Stanley-Jones updated HBASE-14603: Status: Patch Available (was: Open) > Lots of work on the POM to enhance Javadocs, Xrefs > -- > > Key: HBASE-14603 > URL: https://issues.apache.org/jira/browse/HBASE-14603 > Project: HBase > Issue Type: Bug > Components: documentation >Affects Versions: 2.0.0 >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-14603-v2.patch, HBASE-14603-v3.patch, > HBASE-14603-v4.patch, HBASE-14603-v5.patch, HBASE-14603-v6.patch, > HBASE-14603-v7.patch, HBASE-14603.patch > > > If we disable the timestamps (which are in HTML comments), then every Javadoc > file won't show up as different every time we rebuild the site. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14326) HBase book: fix definition of max min size to compact
[
https://issues.apache.org/jira/browse/HBASE-14326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Misty Stanley-Jones updated HBASE-14326:
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Pushed to master. Thanks stack!
> HBase book: fix definition of max min size to compact
> -
>
> Key: HBASE-14326
> URL: https://issues.apache.org/jira/browse/HBASE-14326
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Vladimir Rodionov
>Assignee: Misty Stanley-Jones
> Fix For: 2.0.0
>
> Attachments: HBASE-14326.patch
>
>
> I think we need to change wording/definition of these config parameters in
> HBase book, they are misleading:
> {quote}
> hbase.hstore.compaction.min.size
> Description
> A StoreFile smaller than this size will always be eligible for minor
> compaction. HFiles this size or larger are evaluated by
> hbase.hstore.compaction.ratio to determine if they are eligible. Because this
> limit represents the "automatic include"limit for all StoreFiles smaller than
> this value, this value may need to be reduced in write-heavy environments
> where many StoreFiles in the 1-2 MB range are being flushed, because every
> StoreFile will be targeted for compaction and the resulting StoreFiles may
> still be under the minimum size and require further compaction. If this
> parameter is lowered, the ratio check is triggered more quickly. This
> addressed some issues seen in earlier versions of HBase but changing this
> parameter is no longer necessary in most situations. Default: 128 MB
> expressed in bytes.
> Default
> 134217728
> hbase.hstore.compaction.max.size
> Description
> A StoreFile larger than this size will be excluded from compaction. The
> effect of raising hbase.hstore.compaction.max.size is fewer, larger
> StoreFiles that do not get compacted often. If you feel that compaction is
> happening too often without much benefit, you can try raising this value.
> Default: the value of LONG.MAX_VALUE, expressed in bytes.
> hbase.hstore.compaction.ratio
> Description
> For minor compaction, this ratio is used to determine whether a given
> StoreFile which is larger than hbase.hstore.compaction.min.size is eligible
> for compaction. Its effect is to limit compaction of large StoreFiles. The
> value of hbase.hstore.compaction.ratio is expressed as a floating-point
> decimal. A large ratio, such as 10, will produce a single giant StoreFile.
> Conversely, a low value, such as .25, will produce behavior similar to the
> BigTable compaction algorithm, producing four StoreFiles. A moderate value of
> between 1.0 and 1.4 is recommended. When tuning this value, you are balancing
> write costs with read costs. Raising the value (to something like 1.4) will
> have more write costs, because you will compact larger StoreFiles. However,
> during reads, HBase will need to seek through fewer StoreFiles to accomplish
> the read. Consider this approach if you cannot take advantage of Bloom
> filters. Otherwise, you can lower this value to something like 1.0 to reduce
> the background cost of writes, and use Bloom filters to control the number of
> StoreFiles touched during reads. For most cases, the default value is
> appropriate.
> Default
> 1.2F
> {quote}
> For details, see HBASE-14263.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
[ https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-14655: --- Attachment: 14655-v8.txt Patch v8 fulfills the passing of User object through stripe compaction code path. > Narrow the scope of doAs() calls to region observer notifications for > compaction > > > Key: HBASE-14655 > URL: https://issues.apache.org/jira/browse/HBASE-14655 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, > 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, > 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, > 14655-v6.txt, 14655-v7.txt, 14655-v8.txt > > > As what has been done in HBASE-14631 and HBASE-14605, the scope of calling > doAs() for compaction related region observer notifications should be > narrowed. > User object is passed from CompactSplitThread down to the methods where > region observer notifications are made. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
[ https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-14655: --- Status: Patch Available (was: Open) > Narrow the scope of doAs() calls to region observer notifications for > compaction > > > Key: HBASE-14655 > URL: https://issues.apache.org/jira/browse/HBASE-14655 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, > 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, > 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, > 14655-v6.txt, 14655-v7.txt, 14655-v8.txt > > > As what has been done in HBASE-14631 and HBASE-14605, the scope of calling > doAs() for compaction related region observer notifications should be > narrowed. > User object is passed from CompactSplitThread down to the methods where > region observer notifications are made. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
[ https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968533#comment-14968533 ] stack commented on HBASE-14655: --- bq. Since stripe compaction is of limited use, I suggest tackling it in separate JIRA. Don't we have enough issues on doAs already? Why not address them all in the one patch. Then we could look for duplicated code or if there was commonage for the fix between the fix in three (and now four) localities? > Narrow the scope of doAs() calls to region observer notifications for > compaction > > > Key: HBASE-14655 > URL: https://issues.apache.org/jira/browse/HBASE-14655 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, > 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, > 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, > 14655-v6.txt, 14655-v7.txt > > > As what has been done in HBASE-14631 and HBASE-14605, the scope of calling > doAs() for compaction related region observer notifications should be > narrowed. > User object is passed from CompactSplitThread down to the methods where > region observer notifications are made. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14603) Lots of work on the POM to enhance Javadocs, Xrefs
[ https://issues.apache.org/jira/browse/HBASE-14603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Misty Stanley-Jones updated HBASE-14603: Attachment: HBASE-14603-v7.patch Lots of work on the POM to enhance Javadocs, Xrefs * We now have apidocs, devapidocs, testapidocs, and testdevapidocs * When using reportSets, the Javadoc plugin ignores the plugin configuration, so I propagated it to the individual reportSet configuration blocks. * I was able to remove some of the logic that moved / copied things around in post-site. * We now have xref and xref-test (these are superfluous but something needs them so I left them) * Added source to Javadocs -- you can click a method or property to browse its source. More user-friendly than xref maybe. * You can now get the whole site to build by doing 'mvn clean site site:stage' and it takes about 10 minutes. > Lots of work on the POM to enhance Javadocs, Xrefs > -- > > Key: HBASE-14603 > URL: https://issues.apache.org/jira/browse/HBASE-14603 > Project: HBase > Issue Type: Bug > Components: documentation >Affects Versions: 2.0.0 >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-14603-v2.patch, HBASE-14603-v3.patch, > HBASE-14603-v4.patch, HBASE-14603-v5.patch, HBASE-14603-v6.patch, > HBASE-14603-v7.patch, HBASE-14603.patch > > > If we disable the timestamps (which are in HTML comments), then every Javadoc > file won't show up as different every time we rebuild the site. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14603) Lots of work on the POM to enhance Javadocs, Xrefs
[ https://issues.apache.org/jira/browse/HBASE-14603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Misty Stanley-Jones updated HBASE-14603: Summary: Lots of work on the POM to enhance Javadocs, Xrefs (was: Disable timestamping of generated Javadocs so they are not all modified by each build) > Lots of work on the POM to enhance Javadocs, Xrefs > -- > > Key: HBASE-14603 > URL: https://issues.apache.org/jira/browse/HBASE-14603 > Project: HBase > Issue Type: Bug > Components: documentation >Affects Versions: 2.0.0 >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-14603-v2.patch, HBASE-14603-v3.patch, > HBASE-14603-v4.patch, HBASE-14603-v5.patch, HBASE-14603-v6.patch, > HBASE-14603.patch > > > If we disable the timestamps (which are in HTML comments), then every Javadoc > file won't show up as different every time we rebuild the site. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14668) Remove deprecated HBaseTestCase dependency from TestHFile
[ https://issues.apache.org/jira/browse/HBASE-14668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14668: --- Attachment: hbase-14668-v2.patch v2 is what I committed > Remove deprecated HBaseTestCase dependency from TestHFile > - > > Key: HBASE-14668 > URL: https://issues.apache.org/jira/browse/HBASE-14668 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14668-v2.patch, hbase-14668.patch > > > Remove dependency on long deprecated HBaseTestCase (0.90). modified > references to tfiles which haven't been part of any modern hbase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14668) Remove deprecated HBaseTestCase dependency from TestHFile
[ https://issues.apache.org/jira/browse/HBASE-14668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14668: --- Hadoop Flags: Reviewed > Remove deprecated HBaseTestCase dependency from TestHFile > - > > Key: HBASE-14668 > URL: https://issues.apache.org/jira/browse/HBASE-14668 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14668-v2.patch, hbase-14668.patch > > > Remove dependency on long deprecated HBaseTestCase (0.90). modified > references to tfiles which haven't been part of any modern hbase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
[ https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968518#comment-14968518 ] Ted Yu commented on HBASE-14655: Checked https://builds.apache.org/job/PreCommit-HBASE-Build/16161//testReport/org.apache.hadoop.hbase.regionserver/TestHRegionOnCluster/testDataCorrectnessReplayingRecoveredEdits/ There was no compaction involved in the above test. I ran TestHRegionOnCluster locally with patch and it passed. > Narrow the scope of doAs() calls to region observer notifications for > compaction > > > Key: HBASE-14655 > URL: https://issues.apache.org/jira/browse/HBASE-14655 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt, > 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-v1.txt, 14655-v2.txt, > 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt > > > As what has been done in HBASE-14631 and HBASE-14605, the scope of calling > doAs() for compaction related region observer notifications should be > narrowed. > User object is passed from CompactSplitThread down to the methods where > region observer notifications are made. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14665) Remove deprecated HBaseTestingUtility#createTable methods
[ https://issues.apache.org/jira/browse/HBASE-14665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968506#comment-14968506 ] Apekshit Sharma commented on HBASE-14665: - The methods being removed here were marked deprecated in HBASE-13893 and will be released in 2.0.0. Since the class is marked public and evolving, we should keep the methods around at least till 2.1 to meet the stability guidelines. However I personally feel that given we moved to TableName api in 0.96, we should be fine to remove it, and in fact should do it. > Remove deprecated HBaseTestingUtility#createTable methods > - > > Key: HBASE-14665 > URL: https://issues.apache.org/jira/browse/HBASE-14665 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14665.patch > > > HBase has had the TableName APIs since 0.96 and our test code doesn't have > privacy/stability markers so we should be able to remove the deprecated > methods in 2.0.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14672) Excise deprecated Delete#delete* apis
[ https://issues.apache.org/jira/browse/HBASE-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968504#comment-14968504 ] Jonathan Hsieh commented on HBASE-14672: This patch depends on HBASE-14671. Will kick bot again after that patch makes it in. > Excise deprecated Delete#delete* apis > - > > Key: HBASE-14672 > URL: https://issues.apache.org/jira/browse/HBASE-14672 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14672.patch > > > Delete#delete* apis were replaced with Delete#add* apis. This converts all > instances of it and removes Delete#delete* apis. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14668) Remove deprecated HBaseTestCase dependency from TestHFile
[ https://issues.apache.org/jira/browse/HBASE-14668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14668: --- Resolution: Fixed Status: Resolved (was: Patch Available) thanks for the review stack. committed. > Remove deprecated HBaseTestCase dependency from TestHFile > - > > Key: HBASE-14668 > URL: https://issues.apache.org/jira/browse/HBASE-14668 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14668.patch > > > Remove dependency on long deprecated HBaseTestCase (0.90). modified > references to tfiles which haven't been part of any modern hbase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14665) Remove deprecated HBaseTestingUtility#createTable methods
[ https://issues.apache.org/jira/browse/HBASE-14665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14665: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) > Remove deprecated HBaseTestingUtility#createTable methods > - > > Key: HBASE-14665 > URL: https://issues.apache.org/jira/browse/HBASE-14665 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14665.patch > > > HBase has had the TableName APIs since 0.96 and our test code doesn't have > privacy/stability markers so we should be able to remove the deprecated > methods in 2.0.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14666) Remove deprecated HBaseTestingUtility#deleteTable methods
[ https://issues.apache.org/jira/browse/HBASE-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968536#comment-14968536 ] Jonathan Hsieh commented on HBASE-14666: Thanks for taking a look matteo. committing. > Remove deprecated HBaseTestingUtility#deleteTable methods > - > > Key: HBASE-14666 > URL: https://issues.apache.org/jira/browse/HBASE-14666 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14666.patch > > > HBase has had the TableName APIs since 0.96 and our test code doesn't have > privacy/stability markers so we should be able to remove the deprecated > methods in 2.0.0. > deleteTable has some separate unit test related cleanup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HBASE-14673) Remove duplicated code between IntegrationTestBigLinkedList and IntegrationTestLoadAndVerify
[ https://issues.apache.org/jira/browse/HBASE-14673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968537#comment-14968537 ] stack edited comment on HBASE-14673 at 10/22/15 4:36 AM: - +1 was (Author: stack): +` > Remove duplicated code between IntegrationTestBigLinkedList and > IntegrationTestLoadAndVerify > > > Key: HBASE-14673 > URL: https://issues.apache.org/jira/browse/HBASE-14673 > Project: HBase > Issue Type: Improvement >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Trivial > Attachments: HBASE-14673-v0.patch > > > IntegrationTestBigLinkedList and IntegrationTestLoadAndVerify have some > classes and methods duplicated -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14673) Remove duplicated code between IntegrationTestBigLinkedList and IntegrationTestLoadAndVerify
[ https://issues.apache.org/jira/browse/HBASE-14673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968537#comment-14968537 ] stack commented on HBASE-14673: --- +` > Remove duplicated code between IntegrationTestBigLinkedList and > IntegrationTestLoadAndVerify > > > Key: HBASE-14673 > URL: https://issues.apache.org/jira/browse/HBASE-14673 > Project: HBase > Issue Type: Improvement >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Trivial > Attachments: HBASE-14673-v0.patch > > > IntegrationTestBigLinkedList and IntegrationTestLoadAndVerify have some > classes and methods duplicated -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14672) Excise deprecated Delete#delete* apis
[ https://issues.apache.org/jira/browse/HBASE-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14672: --- Status: Patch Available (was: Open) > Excise deprecated Delete#delete* apis > - > > Key: HBASE-14672 > URL: https://issues.apache.org/jira/browse/HBASE-14672 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14672.patch > > > Delete#delete* apis were replaced with Delete#add* apis. This converts all > instances of it and removes Delete#delete* apis. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14624) BucketCache.freeBlock is too expensive
[
https://issues.apache.org/jira/browse/HBASE-14624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968599#comment-14968599
]
chunhui shen commented on HBASE-14624:
--
What 's the size of region ?
You could set EVICT_BLOCKS_ON_CLOSE to false, thus freeBlocks won't be called
when moving region.
About code improvement：
final class BucketSizeInfo {
private List bucketList, freeBuckets, completelyFreeBuckets;
The above Lists shoule be changed as HashSet to improve performance, since
contains and removes operation is expensive for List
> BucketCache.freeBlock is too expensive
> --
>
> Key: HBASE-14624
> URL: https://issues.apache.org/jira/browse/HBASE-14624
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache
>Affects Versions: 1.0.0
>Reporter: Randy Fox
>
> Moving regions is unacceptably slow when using bucket cache, as it takes too
> long to free all the blocks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14257) Periodic flusher only handles hbase:meta, not other system tables
[
https://issues.apache.org/jira/browse/HBASE-14257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967332#comment-14967332
]
Hadoop QA commented on HBASE-14257:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12767775/HBASE-14257.patch
against master branch at commit 6e3b7af0efced7351163a5011a44bfc18851fce0.
ATTACHMENT ID: 12767775
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16142//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16142//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16142//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16142//console
This message is automatically generated.
> Periodic flusher only handles hbase:meta, not other system tables
> -
>
> Key: HBASE-14257
> URL: https://issues.apache.org/jira/browse/HBASE-14257
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 2.0.0, 1.2.0
>Reporter: Lars George
>Assignee: Abhishek Singh Chouhan
> Labels: beginner
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14257.patch, HBASE-14257.patch
>
>
> In {{HRegion.shouldFlush}} we have
> {code}
> long modifiedFlushCheckInterval = flushCheckInterval;
> if (getRegionInfo().isMetaRegion() &&
> getRegionInfo().getReplicaId() == HRegionInfo.DEFAULT_REPLICA_ID) {
> modifiedFlushCheckInterval = META_CACHE_FLUSH_INTERVAL;
> }
> {code}
> That method is called by the {{PeriodicMemstoreFlusher}} thread, and prefers
> the {{hbase:meta}} only for faster flushing. It should be doing the same for
> other system tables. I suggest to use {{HRI.isSystemTable()}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14582) Regionserver status webpage bucketcache list can become huge
[ https://issues.apache.org/jira/browse/HBASE-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967397#comment-14967397 ] James Hartshorn commented on HBASE-14582: - I've tested this patch and are quite pleased with it. Region server status pages load instantly and browser memory usage is completely reasonable (8MB when I checked). Thank you very much. > Regionserver status webpage bucketcache list can become huge > > > Key: HBASE-14582 > URL: https://issues.apache.org/jira/browse/HBASE-14582 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: James Hartshorn >Assignee: stack > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: 14582.txt, Screen Shot 2015-10-09 at 8.00.37 PM.png, > Screen Shot 2015-10-09 at 8.00.37 PM.png > > > The regionserver status page, such as http://127.0.0.1:60030/rs-status always > downloads information about every bucket in the cache. In some cases this > can be hundreds of thousands of buckets, causing megabytes of info to need to > be downloaded and significant browser instability and memory usage: > wc -l HBase-Region-Server-hb22.html > 2010116 HBase-Region-Server-hb22.html > ls -lah HBase-Region-Server-hb22.html > 32M Oct 6 19:23 HBase-Region-Server-hb22.html > Firefox "about:memory": > 1,330.18 MB (48.22%) -- top(http://hb22:60030/rs-status#bc_l2, id=2010) > 1,329.61 MB (48.20%) -- active/window(http://hb22:60030/rs-status#bc_l2) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14661) RegionServer link is not opening, in HBase Table page.
[
https://issues.apache.org/jira/browse/HBASE-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967447#comment-14967447
]
stack commented on HBASE-14661:
---
Do you have a patch [~sreenivasulureddy]? What version of hbase is this in?
Thanks.
> RegionServer link is not opening, in HBase Table page.
> --
>
> Key: HBASE-14661
> URL: https://issues.apache.org/jira/browse/HBASE-14661
> Project: HBase
> Issue Type: Bug
> Components: UI
>Affects Versions: 2.0.0, 1.0.2
>Reporter: Y. SREENIVASULU REDDY
>Assignee: Y. SREENIVASULU REDDY
>Priority: Minor
>
> In HBase table page Regionserver link is not opening the regionserver UI.
> currently the url is
> {code}
> String url = "//" + addr.getHostname() + ":" +
> master.getRegionServerInfoPort(addr) + "/";
> {code}
> change in table.jsp file should be
> {code}
> String url = "//" + addr.getHostname() + ":" +
> master.getRegionServerInfoPort(addr) + "/rs-status";
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14660) AssertionError found when using offheap BucketCache with assertion enabled
[
https://issues.apache.org/jira/browse/HBASE-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967427#comment-14967427
]
stack commented on HBASE-14660:
---
Patch looks good. [~anoop.hbase] just added a method for this check,
this.curBlock.getMemoryType() == MemoryType.SHARED, isShared or something on
curBlock. Use it on commit?
> AssertionError found when using offheap BucketCache with assertion enabled
> --
>
> Key: HBASE-14660
> URL: https://issues.apache.org/jira/browse/HBASE-14660
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Yu Li
>Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-14660.patch, HBASE-14660_1.patch
>
>
> During perf verification of HBASE-14463, found offheap BucketCache not
> working with assertion enabled in hbase-env.sh:
> {noformat}
> export HBASE_OPTS="-ea -XX:+HeapDumpOnOutOfMemoryError
> -XX:+UseConcMarkSweepGC"
> {noformat}
> And the error when running PE tool is like:
> {noformat}
> 15/10/21 16:06:34 INFO client.AsyncProcess: #10, table=TestTable,
> attempt=10/21 failed=20ops, last exception: java.io.IOException:
> java.io.IOException
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2181)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:106)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
> at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
> at java.lang.Thread.run(Thread.java:744)
> Caused by: java.lang.AssertionError
> at
> org.apache.hadoop.hbase.OffheapKeyValue.(OffheapKeyValue.java:52)
> at
> org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl$ShareableMemoryOffheapKeyValue.(HFileReaderImpl.java:1003)
> at
> org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.getCell(HFileReaderImpl.java:949)
> at
> org.apache.hadoop.hbase.regionserver.StoreFileScanner.reseek(StoreFileScanner.java:201)
> at
> org.apache.hadoop.hbase.regionserver.NonLazyKeyValueScanner.doRealSeek(NonLazyKeyValueScanner.java:55)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.generalizedSeek(KeyValueHeap.java:323)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.requestSeek(KeyValueHeap.java:279)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.reseek(StoreScanner.java:825)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.seekAsDirection(StoreScanner.java:813)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:641)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:153)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:5649)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:5795)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:5568)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.next(HRegion.java:5544)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.next(HRegion.java:5530)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2044)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:663)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2156)
> {noformat}
> [~ram_krish] and [~anoop.hbase], mind to take a look?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14662) Fix NPE in HFileOutputFormat2
[
https://issues.apache.org/jira/browse/HBASE-14662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967405#comment-14967405
]
stack commented on HBASE-14662:
---
That is a nice find. Are there times when table can be legitimately null?
> Fix NPE in HFileOutputFormat2
> -
>
> Key: HBASE-14662
> URL: https://issues.apache.org/jira/browse/HBASE-14662
> Project: HBase
> Issue Type: Sub-task
>Reporter: Heng Chen
> Attachments: HBASE-14662.patch
>
>
> When i dig in HBASE-14659, i run testWritingPEData. There are a lot of NPE
> thrown and testcase run a long time.
> The reason is that, in {{HFileOutputFormat2}}
> {code}
> HRegionLocation loc = null;
> String tableName = conf.get(OUTPUT_TABLE_NAME_CONF_KEY);
> try (Connection connection =
> ConnectionFactory.createConnection(conf);
>RegionLocator locator =
>
> connection.getRegionLocator(TableName.valueOf(tableName))) {
> loc = locator.getRegionLocation(rowKey);
> } catch (Throwable e) {
> LOG.warn("there's something wrong when locating rowkey: " +
> Bytes.toString(rowKey), e);
> loc = null;
> }
> {code}
> Because we did not set {{OUTPUT_TABLE_NAME_CONF_KEY}}, So tableName is null,
> So NPE thrown.
> And connection will be created which RegionLocator use to find region
> location. Because zk is not start in this testcase, So it will retry many
> times.
> But all this actions are not required, we can skip create connection by
> check whether tableName is null
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14427) Fix 'should' assertions in TestFastFail
[ https://issues.apache.org/jira/browse/HBASE-14427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-14427: -- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.0.0 Status: Resolved (was: Patch Available) Very nice. Makes sense. Thank you for the fix. I applied to master-only for now (am trying to stabilize the tests so am wary about reenabling stuff that was once failing/flakey). Thank you for the patch [~abhishek.chouhan] > Fix 'should' assertions in TestFastFail > --- > > Key: HBASE-14427 > URL: https://issues.apache.org/jira/browse/HBASE-14427 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: Abhishek Singh Chouhan >Priority: Minor > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14427.patch > > > Over in HBASE-14421, TestFastFail has been failing assertions that talk of > events that 'should' be happening. Fix. For now HBASE-14421 has disabled the > 'should' assertions. They seem fine on apache jenkins build but fail fairly > reliably for me on alternate HW. > To address, get familiar with the test. Change the commented out asserts to > be yes/no instead of a 'likely' (On a cursory scan, it is possible that a > test run may not involve preemption and it is these runs that are throwing > asserts). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
[ https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-14655: --- Attachment: (was: 14655-v5.txt) > Narrow the scope of doAs() calls to region observer notifications for > compaction > > > Key: HBASE-14655 > URL: https://issues.apache.org/jira/browse/HBASE-14655 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, > 14655-v5.txt > > > As what has been done in HBASE-14631 and HBASE-14605, the scope of calling > doAs() for compaction related region observer notifications should be > narrowed. > User object is passed from CompactSplitThread down to the methods where > region observer notifications are made. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
[ https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-14655: --- Attachment: 14655-v5.txt > Narrow the scope of doAs() calls to region observer notifications for > compaction > > > Key: HBASE-14655 > URL: https://issues.apache.org/jira/browse/HBASE-14655 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, > 14655-v5.txt > > > As what has been done in HBASE-14631 and HBASE-14605, the scope of calling > doAs() for compaction related region observer notifications should be > narrowed. > User object is passed from CompactSplitThread down to the methods where > region observer notifications are made. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14425) In Secure Zookeeper cluster superuser will not have sufficient permission if multiple values are configured in "hbase.superuser"
[
https://issues.apache.org/jira/browse/HBASE-14425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967342#comment-14967342
]
Hadoop QA commented on HBASE-14425:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12767772/HBASE-14425-V2.patch
against master branch at commit 6e3b7af0efced7351163a5011a44bfc18851fce0.
ATTACHMENT ID: 12767772
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 9 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16141//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16141//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16141//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16141//console
This message is automatically generated.
> In Secure Zookeeper cluster superuser will not have sufficient permission if
> multiple values are configured in "hbase.superuser"
>
>
> Key: HBASE-14425
> URL: https://issues.apache.org/jira/browse/HBASE-14425
> Project: HBase
> Issue Type: Bug
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
> Fix For: 2.0.0
>
> Attachments: HBASE-14425-V2.patch, HBASE-14425-V2.patch,
> HBASE-14425.patch
>
>
> During master intialization we are setting ACLs for the znodes.
> In ZKUtil.createACL(ZooKeeperWatcher zkw, String node, boolean
> isSecureZooKeeper),
> {code}
> String superUser = zkw.getConfiguration().get("hbase.superuser");
> ArrayList acls = new ArrayList();
> // add permission to hbase supper user
> if (superUser != null) {
> acls.add(new ACL(Perms.ALL, new Id("auth", superUser)));
> }
> {code}
> Here we are directly setting "hbase.superuser" value to Znode which will
> cause an issue when multiple values are configured. In "hbase.superuser"
> multiple superusers and supergroups can be configured separated by comma. We
> need to iterate them and set ACL.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14427) Fix 'should' assertions in TestFastFail
[ https://issues.apache.org/jira/browse/HBASE-14427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-14427: -- Assignee: Abhishek Singh Chouhan > Fix 'should' assertions in TestFastFail > --- > > Key: HBASE-14427 > URL: https://issues.apache.org/jira/browse/HBASE-14427 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: Abhishek Singh Chouhan >Priority: Minor > Labels: beginner > Attachments: HBASE-14427.patch > > > Over in HBASE-14421, TestFastFail has been failing assertions that talk of > events that 'should' be happening. Fix. For now HBASE-14421 has disabled the > 'should' assertions. They seem fine on apache jenkins build but fail fairly > reliably for me on alternate HW. > To address, get familiar with the test. Change the commented out asserts to > be yes/no instead of a 'likely' (On a cursory scan, it is possible that a > test run may not involve preemption and it is these runs that are throwing > asserts). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14662) Fix NPE in HFileOutputFormat2
[
https://issues.apache.org/jira/browse/HBASE-14662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967463#comment-14967463
]
stack commented on HBASE-14662:
---
In other words, if no table, does it make sense that the creation of a record
writer should succeed? Thanks [~chenheng]
> Fix NPE in HFileOutputFormat2
> -
>
> Key: HBASE-14662
> URL: https://issues.apache.org/jira/browse/HBASE-14662
> Project: HBase
> Issue Type: Sub-task
>Reporter: Heng Chen
> Attachments: HBASE-14662.patch
>
>
> When i dig in HBASE-14659, i run testWritingPEData. There are a lot of NPE
> thrown and testcase run a long time.
> The reason is that, in {{HFileOutputFormat2}}
> {code}
> HRegionLocation loc = null;
> String tableName = conf.get(OUTPUT_TABLE_NAME_CONF_KEY);
> try (Connection connection =
> ConnectionFactory.createConnection(conf);
>RegionLocator locator =
>
> connection.getRegionLocator(TableName.valueOf(tableName))) {
> loc = locator.getRegionLocation(rowKey);
> } catch (Throwable e) {
> LOG.warn("there's something wrong when locating rowkey: " +
> Bytes.toString(rowKey), e);
> loc = null;
> }
> {code}
> Because we did not set {{OUTPUT_TABLE_NAME_CONF_KEY}}, So tableName is null,
> So NPE thrown.
> And connection will be created which RegionLocator use to find region
> location. Because zk is not start in this testcase, So it will retry many
> times.
> But all this actions are not required, we can skip create connection by
> check whether tableName is null
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14582) Regionserver status webpage bucketcache list can become huge
[ https://issues.apache.org/jira/browse/HBASE-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967417#comment-14967417 ] stack commented on HBASE-14582: --- [~jhartshorn] Thanks for reporting the issue. > Regionserver status webpage bucketcache list can become huge > > > Key: HBASE-14582 > URL: https://issues.apache.org/jira/browse/HBASE-14582 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: James Hartshorn >Assignee: stack > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: 14582.txt, Screen Shot 2015-10-09 at 8.00.37 PM.png, > Screen Shot 2015-10-09 at 8.00.37 PM.png > > > The regionserver status page, such as http://127.0.0.1:60030/rs-status always > downloads information about every bucket in the cache. In some cases this > can be hundreds of thousands of buckets, causing megabytes of info to need to > be downloaded and significant browser instability and memory usage: > wc -l HBase-Region-Server-hb22.html > 2010116 HBase-Region-Server-hb22.html > ls -lah HBase-Region-Server-hb22.html > 32M Oct 6 19:23 HBase-Region-Server-hb22.html > Firefox "about:memory": > 1,330.18 MB (48.22%) -- top(http://hb22:60030/rs-status#bc_l2, id=2010) > 1,329.61 MB (48.20%) -- active/window(http://hb22:60030/rs-status#bc_l2) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13538) Procedure v2 - client add/delete/modify column family sync (incompatible with branch-1.x)
[ https://issues.apache.org/jira/browse/HBASE-13538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Singhi updated HBASE-13538: -- Fix Version/s: 2.0.0 Status: Patch Available (was: Open) Please review. > Procedure v2 - client add/delete/modify column family sync (incompatible with > branch-1.x) > - > > Key: HBASE-13538 > URL: https://issues.apache.org/jira/browse/HBASE-13538 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.0.0 >Reporter: Srikanth Srungarapu >Assignee: Ashish Singhi > Fix For: 2.0.0 > > Attachments: HBASE-13538.patch > > > Client side part of HBASE-13209. > It uses the new procedure code to be know when the procedure is completed, > and have a proper sync/async behavior on add/modify/delete column family. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13538) Procedure v2 - client add/delete/modify column family sync (incompatible with branch-1.x)
[ https://issues.apache.org/jira/browse/HBASE-13538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Singhi updated HBASE-13538: -- Attachment: HBASE-13538.patch > Procedure v2 - client add/delete/modify column family sync (incompatible with > branch-1.x) > - > > Key: HBASE-13538 > URL: https://issues.apache.org/jira/browse/HBASE-13538 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.0.0 >Reporter: Srikanth Srungarapu >Assignee: Ashish Singhi > Fix For: 2.0.0 > > Attachments: HBASE-13538.patch > > > Client side part of HBASE-13209. > It uses the new procedure code to be know when the procedure is completed, > and have a proper sync/async behavior on add/modify/delete column family. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14388) Compaction improvements: Avoid flush storms by jittering flush interval and max log files
[ https://issues.apache.org/jira/browse/HBASE-14388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967546#comment-14967546 ] stack commented on HBASE-14388: --- Do we have evidence of how this improves compaction or of how it prevents flush storms? Thanks. > Compaction improvements: Avoid flush storms by jittering flush interval and > max log files > -- > > Key: HBASE-14388 > URL: https://issues.apache.org/jira/browse/HBASE-14388 > Project: HBase > Issue Type: Improvement >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Fix For: 2.0.0 > > Attachments: HBASE-14388-v1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14635) Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent
[ https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967586#comment-14967586 ] stack commented on HBASE-14635: --- See up in https://issues.apache.org/jira/browse/HBASE-14585 where [~eclark] trips over same issue. > Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent > -- > > Key: HBASE-14635 > URL: https://issues.apache.org/jira/browse/HBASE-14635 > Project: HBase > Issue Type: Sub-task > Components: test >Reporter: stack > Fix For: 2.0.0, 1.2.0, 1.3.0 > > > Was disabled in the parent issue because flakey. This issue is about > reenabling it after figuring why its flakey. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14387) Compaction improvements: Maximum off-peak compaction size
[ https://issues.apache.org/jira/browse/HBASE-14387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov updated HBASE-14387: -- Status: Open (was: Patch Available) > Compaction improvements: Maximum off-peak compaction size > - > > Key: HBASE-14387 > URL: https://issues.apache.org/jira/browse/HBASE-14387 > Project: HBase > Issue Type: Improvement >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Fix For: 2.0.0 > > Attachments: HBASE-14387-v1.patch, HBASE-14387-v2.patch, > HBASE-14387-v3.patch > > > Make max compaction size for peak and off peak separate config options. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14387) Compaction improvements: Maximum off-peak compaction size
[ https://issues.apache.org/jira/browse/HBASE-14387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov updated HBASE-14387: -- Attachment: HBASE-14387-v3.patch Patch v3. minor formatting issue. > Compaction improvements: Maximum off-peak compaction size > - > > Key: HBASE-14387 > URL: https://issues.apache.org/jira/browse/HBASE-14387 > Project: HBase > Issue Type: Improvement >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Fix For: 2.0.0 > > Attachments: HBASE-14387-v1.patch, HBASE-14387-v2.patch, > HBASE-14387-v3.patch > > > Make max compaction size for peak and off peak separate config options. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-14663) HStore::close does not honor config hbase.rs.evictblocksonclose
Randy Fox created HBASE-14663:
-
Summary: HStore::close does not honor config
hbase.rs.evictblocksonclose
Key: HBASE-14663
URL: https://issues.apache.org/jira/browse/HBASE-14663
Project: HBase
Issue Type: Bug
Components: BlockCache, regionserver
Affects Versions: 1.0.0
Reporter: Randy Fox
Priority: Minor
I noticed moving regions was slow and due to the wait for the bucket cache to
clear. I tried setting hbase.rs.evictblocksonclose and it did not help.
I see the HStore::close method has evictonclose hard coded to true instead of
letting the config dictate:
// close each store file in parallel
CompletionService completionService =
new ExecutorCompletionService(storeFileCloserThreadPool);
for (final StoreFile f : result) {
completionService.submit(new Callable() {
@Override
public Void call() throws IOException {
f.closeReader(true);
return null;
}
});
}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14388) Compaction improvements: Avoid flush storms by jittering flush interval and max log files
[
https://issues.apache.org/jira/browse/HBASE-14388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967553#comment-14967553
]
Vladimir Rodionov commented on HBASE-14388:
---
{quote}
Do we have evidence of how this improves compaction or of how it prevents flush
storms?
{quote}
Only theoretical ones. I will be doing test runs.
> Compaction improvements: Avoid flush storms by jittering flush interval and
> max log files
> --
>
> Key: HBASE-14388
> URL: https://issues.apache.org/jira/browse/HBASE-14388
> Project: HBase
> Issue Type: Improvement
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
> Attachments: HBASE-14388-v1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
[
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968509#comment-14968509
]
Hadoop QA commented on HBASE-14655:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12767940/14655-branch-1.0-v6.txt
against branch-1.0 branch at commit b3afdb8de1a9fa88c553159b2d2d2aa96902a345.
ATTACHMENT ID: 12767940
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3767 checkstyle errors (more than the master's current 3765 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16161//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16161//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16161//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16161//console
This message is automatically generated.
> Narrow the scope of doAs() calls to region observer notifications for
> compaction
>
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-branch-1-v5.txt, 14655-branch-1-v6.txt,
> 14655-branch-1-v7.txt, 14655-branch-1.0-v6.txt, 14655-v1.txt, 14655-v2.txt,
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling
> doAs() for compaction related region observer notifications should be
> narrowed.
> User object is passed from CompactSplitThread down to the methods where
> region observer notifications are made.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14671) Remove deprecated HBaseTestCase/Put/Delete apis from TestGetClosestAtOrBefore
[ https://issues.apache.org/jira/browse/HBASE-14671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14671: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) thanks for the review stack, committed. > Remove deprecated HBaseTestCase/Put/Delete apis from TestGetClosestAtOrBefore > - > > Key: HBASE-14671 > URL: https://issues.apache.org/jira/browse/HBASE-14671 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14671.patch > > > converting from long deprecated apis to modern apis. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14672) Excise deprecated Delete#delete* apis
[ https://issues.apache.org/jira/browse/HBASE-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14672: --- Status: Open (was: Patch Available) > Excise deprecated Delete#delete* apis > - > > Key: HBASE-14672 > URL: https://issues.apache.org/jira/browse/HBASE-14672 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14672.patch > > > Delete#delete* apis were replaced with Delete#add* apis. This converts all > instances of it and removes Delete#delete* apis. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14427) Fix 'should' assertions in TestFastFail
[ https://issues.apache.org/jira/browse/HBASE-14427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967731#comment-14967731 ] Hudson commented on HBASE-14427: SUCCESS: Integrated in HBase-TRUNK #6935 (See [https://builds.apache.org/job/HBase-TRUNK/6935/]) HBASE-14427 Fix 'should' assertions in TestFastFail (Abhishek Singh (stack: rev b3afdb8de1a9fa88c553159b2d2d2aa96902a345) * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java > Fix 'should' assertions in TestFastFail > --- > > Key: HBASE-14427 > URL: https://issues.apache.org/jira/browse/HBASE-14427 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: Abhishek Singh Chouhan >Priority: Minor > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14427.patch > > > Over in HBASE-14421, TestFastFail has been failing assertions that talk of > events that 'should' be happening. Fix. For now HBASE-14421 has disabled the > 'should' assertions. They seem fine on apache jenkins build but fail fairly > reliably for me on alternate HW. > To address, get familiar with the test. Change the commented out asserts to > be yes/no instead of a 'likely' (On a cursory scan, it is possible that a > test run may not involve preemption and it is these runs that are throwing > asserts). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-14665) Remove deprecated HBaseTestingUtility#createTable methods
Jonathan Hsieh created HBASE-14665: -- Summary: Remove deprecated HBaseTestingUtility#createTable methods Key: HBASE-14665 URL: https://issues.apache.org/jira/browse/HBASE-14665 Project: HBase Issue Type: Improvement Components: test Affects Versions: 2.0.0 Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Fix For: 2.0.0 HBase has had the TableName APIs since 0.96, and our test code doesn't have privacy/stability markers so we should be able to remove the deprecated methods in 2.0.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
[ https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-14655: --- Attachment: 14655-branch-1-v5.txt > Narrow the scope of doAs() calls to region observer notifications for > compaction > > > Key: HBASE-14655 > URL: https://issues.apache.org/jira/browse/HBASE-14655 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 14655-branch-1-v5.txt, 14655-v1.txt, 14655-v2.txt, > 14655-v3.txt, 14655-v4.txt, 14655-v5.txt > > > As what has been done in HBASE-14631 and HBASE-14605, the scope of calling > doAs() for compaction related region observer notifications should be > narrowed. > User object is passed from CompactSplitThread down to the methods where > region observer notifications are made. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
[
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967708#comment-14967708
]
Hadoop QA commented on HBASE-14655:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12767798/14655-v5.txt
against master branch at commit 6e3b7af0efced7351163a5011a44bfc18851fce0.
ATTACHMENT ID: 12767798
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16144//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16144//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16144//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16144//console
This message is automatically generated.
> Narrow the scope of doAs() calls to region observer notifications for
> compaction
>
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt,
> 14655-v5.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling
> doAs() for compaction related region observer notifications should be
> narrowed.
> User object is passed from CompactSplitThread down to the methods where
> region observer notifications are made.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14666) Remove deprecated HBaseTestingUttility#deleteTable methods
[ https://issues.apache.org/jira/browse/HBASE-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14666: --- Attachment: hbase-14666.patch > Remove deprecated HBaseTestingUttility#deleteTable methods > -- > > Key: HBASE-14666 > URL: https://issues.apache.org/jira/browse/HBASE-14666 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14666.patch > > > HBase has had the TableName APIs since 0.96, and our test code doesn't have > privacy/stability markers so we should be able to remove the deprecated > methods in 2.0.0. > deleteTable has some separate unit test related cleanup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14665) Remove deprecated HBaseTestingUtility#createTable methods
[ https://issues.apache.org/jira/browse/HBASE-14665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14665: --- Status: Patch Available (was: In Progress) > Remove deprecated HBaseTestingUtility#createTable methods > - > > Key: HBASE-14665 > URL: https://issues.apache.org/jira/browse/HBASE-14665 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14665.patch > > > HBase has had the TableName APIs since 0.96, and our test code doesn't have > privacy/stability markers so we should be able to remove the deprecated > methods in 2.0.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work started] (HBASE-14665) Remove deprecated HBaseTestingUtility#createTable methods
[ https://issues.apache.org/jira/browse/HBASE-14665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-14665 started by Jonathan Hsieh. -- > Remove deprecated HBaseTestingUtility#createTable methods > - > > Key: HBASE-14665 > URL: https://issues.apache.org/jira/browse/HBASE-14665 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14665.patch > > > HBase has had the TableName APIs since 0.96, and our test code doesn't have > privacy/stability markers so we should be able to remove the deprecated > methods in 2.0.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14666) Remove deprecated HBaseTestingUtility#deleteTable methods
[ https://issues.apache.org/jira/browse/HBASE-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14666: --- Description: HBase has had the TableName APIs since 0.96 and our test code doesn't have privacy/stability markers so we should be able to remove the deprecated methods in 2.0.0. deleteTable has some separate unit test related cleanup. was: HBase has had the TableName APIs since 0.96, and our test code doesn't have privacy/stability markers so we should be able to remove the deprecated methods in 2.0.0. deleteTable has some separate unit test related cleanup. > Remove deprecated HBaseTestingUtility#deleteTable methods > - > > Key: HBASE-14666 > URL: https://issues.apache.org/jira/browse/HBASE-14666 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14666.patch > > > HBase has had the TableName APIs since 0.96 and our test code doesn't have > privacy/stability markers so we should be able to remove the deprecated > methods in 2.0.0. > deleteTable has some separate unit test related cleanup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14665) Remove deprecated HBaseTestingUtility#createTable methods
[ https://issues.apache.org/jira/browse/HBASE-14665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967820#comment-14967820 ] Matteo Bertozzi commented on HBASE-14665: - +1 > Remove deprecated HBaseTestingUtility#createTable methods > - > > Key: HBASE-14665 > URL: https://issues.apache.org/jira/browse/HBASE-14665 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14665.patch > > > HBase has had the TableName APIs since 0.96 and our test code doesn't have > privacy/stability markers so we should be able to remove the deprecated > methods in 2.0.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-14664) Master failover issue: Backup master is unable to start if active master is killed and started in short time interval
Samir Ahmic created HBASE-14664:
---
Summary: Master failover issue: Backup master is unable to start
if active master is killed and started in short time interval
Key: HBASE-14664
URL: https://issues.apache.org/jira/browse/HBASE-14664
Project: HBase
Issue Type: Bug
Components: master
Affects Versions: 2.0.0
Reporter: Samir Ahmic
Assignee: Samir Ahmic
Fix For: 2.0.0
I notice this issue while running IntegrationTestDDLMasterFailover, it can be
simply reproduced by executing this on active master (tested on two masters +
3rs cluster setup)
{code}
$ kill -9 master_pid; hbase-daemon.sh start master
{code}
Logs show that new active master is trying to locate hbase:meta table on
restarted active master
{code}
2015-10-21 19:28:20,804 INFO [hnode2:16000.activeMasterManager]
zookeeper.MetaTableLocator: Failed verification of hbase:meta,,1 at
address=hnode1,16000,1445447051681,
exception=org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is
not running yet
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.checkOpen(RSRpcServices.java:1092)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegionInfo(RSRpcServices.java:1330)
at
org.apache.hadoop.hbase.master.MasterRpcServices.getRegionInfo(MasterRpcServices.java:1525)
at
org.apache.hadoop.hbase.protobuf.generated.AdminProtos$AdminService$2.callBlockingMethod(AdminProtos.java:22233)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2136)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:106)
at
org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
at java.lang.Thread.run(Thread.java:745)
2015-10-21 19:28:20,805 INFO [hnode2:16000.activeMasterManager]
master.HMaster: Meta was in transition on hnode1,16000,1445447051681
2015-10-21 19:28:20,805 INFO [hnode2:16000.activeMasterManager]
master.AssignmentManager: Processing {1588230740 state=OPEN, ts=1445448500598,
server=hnode1,16000,1445447051681
{code}
and because of above master is unable to read hbase:meta table:
{code}
2015-10-21 19:28:49,429 INFO [hconnection-0x6e9cebcc-shared--pool6-t1]
client.AsyncProcess: #2, table=hbase:meta, attempt=10/351 failed=1ops, last
exception: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException:
org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running
yet
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.checkOpen(RSRpcServices.java:1092)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2083)
at
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:32462)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2136)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:106)
at
org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
at java.lang.Thread.run(Thread.java:745)
{code}
which cause master is unable to complete start.
I have also notices that in this case value of /hbase/meta-region-server znode
is always pointing on restarted active master (hnode1 in my cluster ).
I was able to workaround this issue by repeating same scenario with following:
{code}
$ kill -9 master_pid; hbase zkcli rmr /hbase/meta-region-server;
hbase-daemon.sh start master
{code}
So issue is probably caused by staled value in /hbase/meta-region-server znode.
I will try to create patch based on above.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14663) HStore::close does not honor config hbase.rs.evictblocksonclose
[
https://issues.apache.org/jira/browse/HBASE-14663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Rodionov updated HBASE-14663:
--
Attachment: HBASE-14663-v1.patch
> HStore::close does not honor config hbase.rs.evictblocksonclose
> ---
>
> Key: HBASE-14663
> URL: https://issues.apache.org/jira/browse/HBASE-14663
> Project: HBase
> Issue Type: Bug
> Components: BlockCache, regionserver
>Affects Versions: 1.0.0
>Reporter: Randy Fox
>Assignee: Vladimir Rodionov
>Priority: Minor
> Attachments: HBASE-14663-v1.patch
>
>
> I noticed moving regions was slow and due to the wait for the bucket cache to
> clear. I tried setting hbase.rs.evictblocksonclose and it did not help.
> I see the HStore::close method has evictonclose hard coded to true instead of
> letting the config dictate:
> // close each store file in parallel
> CompletionService completionService =
>new ExecutorCompletionService(storeFileCloserThreadPool);
> for (final StoreFile f : result) {
>completionService.submit(new Callable() {
> @Override
> public Void call() throws IOException {
>f.closeReader(true);
>return null;
> }
>});
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14663) HStore::close does not honor config hbase.rs.evictblocksonclose
[
https://issues.apache.org/jira/browse/HBASE-14663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Rodionov updated HBASE-14663:
--
Status: Patch Available (was: Open)
> HStore::close does not honor config hbase.rs.evictblocksonclose
> ---
>
> Key: HBASE-14663
> URL: https://issues.apache.org/jira/browse/HBASE-14663
> Project: HBase
> Issue Type: Bug
> Components: BlockCache, regionserver
>Affects Versions: 1.0.0
>Reporter: Randy Fox
>Assignee: Vladimir Rodionov
>Priority: Minor
> Attachments: HBASE-14663-v1.patch
>
>
> I noticed moving regions was slow and due to the wait for the bucket cache to
> clear. I tried setting hbase.rs.evictblocksonclose and it did not help.
> I see the HStore::close method has evictonclose hard coded to true instead of
> letting the config dictate:
> // close each store file in parallel
> CompletionService completionService =
>new ExecutorCompletionService(storeFileCloserThreadPool);
> for (final StoreFile f : result) {
>completionService.submit(new Callable() {
> @Override
> public Void call() throws IOException {
>f.closeReader(true);
>return null;
> }
>});
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14666) Remove deprecated HBaseTestingUtility#deleteTable methods
[ https://issues.apache.org/jira/browse/HBASE-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14666: --- Summary: Remove deprecated HBaseTestingUtility#deleteTable methods (was: Remove deprecated HBaseTestingUttility#deleteTable methods) > Remove deprecated HBaseTestingUtility#deleteTable methods > - > > Key: HBASE-14666 > URL: https://issues.apache.org/jira/browse/HBASE-14666 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14666.patch > > > HBase has had the TableName APIs since 0.96, and our test code doesn't have > privacy/stability markers so we should be able to remove the deprecated > methods in 2.0.0. > deleteTable has some separate unit test related cleanup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14666) Remove deprecated HBaseTestingUttility#deleteTable methods
[ https://issues.apache.org/jira/browse/HBASE-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14666: --- Status: Patch Available (was: Open) > Remove deprecated HBaseTestingUttility#deleteTable methods > -- > > Key: HBASE-14666 > URL: https://issues.apache.org/jira/browse/HBASE-14666 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14666.patch > > > HBase has had the TableName APIs since 0.96, and our test code doesn't have > privacy/stability markers so we should be able to remove the deprecated > methods in 2.0.0. > deleteTable has some separate unit test related cleanup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HBASE-14663) HStore::close does not honor config hbase.rs.evictblocksonclose
[
https://issues.apache.org/jira/browse/HBASE-14663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Rodionov reassigned HBASE-14663:
-
Assignee: Vladimir Rodionov
> HStore::close does not honor config hbase.rs.evictblocksonclose
> ---
>
> Key: HBASE-14663
> URL: https://issues.apache.org/jira/browse/HBASE-14663
> Project: HBase
> Issue Type: Bug
> Components: BlockCache, regionserver
>Affects Versions: 1.0.0
>Reporter: Randy Fox
>Assignee: Vladimir Rodionov
>Priority: Minor
>
> I noticed moving regions was slow and due to the wait for the bucket cache to
> clear. I tried setting hbase.rs.evictblocksonclose and it did not help.
> I see the HStore::close method has evictonclose hard coded to true instead of
> letting the config dictate:
> // close each store file in parallel
> CompletionService completionService =
>new ExecutorCompletionService(storeFileCloserThreadPool);
> for (final StoreFile f : result) {
>completionService.submit(new Callable() {
> @Override
> public Void call() throws IOException {
>f.closeReader(true);
>return null;
> }
>});
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14665) Remove deprecated HBaseTestingUtility#createTable methods
[ https://issues.apache.org/jira/browse/HBASE-14665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14665: --- Attachment: hbase-14665.patch > Remove deprecated HBaseTestingUtility#createTable methods > - > > Key: HBASE-14665 > URL: https://issues.apache.org/jira/browse/HBASE-14665 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14665.patch > > > HBase has had the TableName APIs since 0.96, and our test code doesn't have > privacy/stability markers so we should be able to remove the deprecated > methods in 2.0.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-14666) Remove deprecated HBaseTestingUttility#deleteTable methods
Jonathan Hsieh created HBASE-14666: -- Summary: Remove deprecated HBaseTestingUttility#deleteTable methods Key: HBASE-14666 URL: https://issues.apache.org/jira/browse/HBASE-14666 Project: HBase Issue Type: Improvement Components: test Affects Versions: 2.0.0 Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Fix For: 2.0.0 HBase has had the TableName APIs since 0.96, and our test code doesn't have privacy/stability markers so we should be able to remove the deprecated methods in 2.0.0. deleteTable has some separate unit test related cleanup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14665) Remove deprecated HBaseTestingUtility#createTable methods
[ https://issues.apache.org/jira/browse/HBASE-14665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14665: --- Description: HBase has had the TableName APIs since 0.96 and our test code doesn't have privacy/stability markers so we should be able to remove the deprecated methods in 2.0.0. (was: HBase has had the TableName APIs since 0.96, and our test code doesn't have privacy/stability markers so we should be able to remove the deprecated methods in 2.0.0.) > Remove deprecated HBaseTestingUtility#createTable methods > - > > Key: HBASE-14665 > URL: https://issues.apache.org/jira/browse/HBASE-14665 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14665.patch > > > HBase has had the TableName APIs since 0.96 and our test code doesn't have > privacy/stability markers so we should be able to remove the deprecated > methods in 2.0.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13538) Procedure v2 - client add/delete/modify column family sync (incompatible with branch-1.x)
[ https://issues.apache.org/jira/browse/HBASE-13538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967845#comment-14967845 ] Matteo Bertozzi commented on HBASE-13538: - looks good to me > Procedure v2 - client add/delete/modify column family sync (incompatible with > branch-1.x) > - > > Key: HBASE-13538 > URL: https://issues.apache.org/jira/browse/HBASE-13538 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.0.0 >Reporter: Srikanth Srungarapu >Assignee: Ashish Singhi > Fix For: 2.0.0 > > Attachments: HBASE-13538.patch > > > Client side part of HBASE-13209. > It uses the new procedure code to be know when the procedure is completed, > and have a proper sync/async behavior on add/modify/delete column family. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14667) HBaseFsck constructors has diverged
[ https://issues.apache.org/jira/browse/HBASE-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Bertozzi updated HBASE-14667: Attachment: HBASE-14667-v0.patch > HBaseFsck constructors has diverged > --- > > Key: HBASE-14667 > URL: https://issues.apache.org/jira/browse/HBASE-14667 > Project: HBase > Issue Type: Bug >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Attachments: HBASE-14667-v0.patch > > > copy paste that diverged, we can just call the other constructor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14667) HBaseFsck constructors has diverged
[ https://issues.apache.org/jira/browse/HBASE-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Bertozzi updated HBASE-14667: Status: Patch Available (was: Open) > HBaseFsck constructors has diverged > --- > > Key: HBASE-14667 > URL: https://issues.apache.org/jira/browse/HBASE-14667 > Project: HBase > Issue Type: Bug >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Attachments: HBASE-14667-v0.patch > > > copy paste that diverged, we can just call the other constructor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14667) HBaseFsck constructors have diverged
[ https://issues.apache.org/jira/browse/HBASE-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Bertozzi updated HBASE-14667: Summary: HBaseFsck constructors have diverged (was: HBaseFsck constructors has diverged) > HBaseFsck constructors have diverged > > > Key: HBASE-14667 > URL: https://issues.apache.org/jira/browse/HBASE-14667 > Project: HBase > Issue Type: Bug >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Attachments: HBASE-14667-v0.patch > > > copy paste that diverged, we can just call the other constructor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14668) Remove deprecated HBaseTestCase dependency from TestHFile
[ https://issues.apache.org/jira/browse/HBASE-14668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14668: --- Summary: Remove deprecated HBaseTestCase dependency from TestHFile (was: Remove deprecaetd HBaseTestCase dependency from TestHFile) > Remove deprecated HBaseTestCase dependency from TestHFile > - > > Key: HBASE-14668 > URL: https://issues.apache.org/jira/browse/HBASE-14668 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh > Fix For: 2.0.0 > > > Remove dependency on long deprecated HBaseTestCase (0.90). modified > references to tfiles which haven't been part of any modern hbase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14668) Remove deprecated HBaseTestCase dependency from TestHFile
[ https://issues.apache.org/jira/browse/HBASE-14668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967926#comment-14967926 ] stack commented on HBASE-14668: --- Do you start a mini cluster in this test? Maybe you don't need to shut it down +1 otherwise. Fix above on commit. > Remove deprecated HBaseTestCase dependency from TestHFile > - > > Key: HBASE-14668 > URL: https://issues.apache.org/jira/browse/HBASE-14668 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14668.patch > > > Remove dependency on long deprecated HBaseTestCase (0.90). modified > references to tfiles which haven't been part of any modern hbase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-14668) Remove deprecaetd HBaseTestCase dependency from TestHFile
Jonathan Hsieh created HBASE-14668: -- Summary: Remove deprecaetd HBaseTestCase dependency from TestHFile Key: HBASE-14668 URL: https://issues.apache.org/jira/browse/HBASE-14668 Project: HBase Issue Type: Improvement Components: test Affects Versions: 2.0.0 Reporter: Jonathan Hsieh Fix For: 2.0.0 Remove dependency on long deprecated HBaseTestCase (0.90). modified references to tfiles which haven't been part of any modern hbase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-14667) HBaseFsck constructors has diverged
Matteo Bertozzi created HBASE-14667: --- Summary: HBaseFsck constructors has diverged Key: HBASE-14667 URL: https://issues.apache.org/jira/browse/HBASE-14667 Project: HBase Issue Type: Bug Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Priority: Minor copy paste that diverged, we can just call the other constructor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13538) Procedure v2 - client add/delete/modify column family sync (incompatible with branch-1.x)
[
https://issues.apache.org/jira/browse/HBASE-13538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967896#comment-14967896
]
Hadoop QA commented on HBASE-13538:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12767810/HBASE-13538.patch
against master branch at commit b3afdb8de1a9fa88c553159b2d2d2aa96902a345.
ATTACHMENT ID: 12767810
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16145//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16145//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16145//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16145//console
This message is automatically generated.
> Procedure v2 - client add/delete/modify column family sync (incompatible with
> branch-1.x)
> -
>
> Key: HBASE-13538
> URL: https://issues.apache.org/jira/browse/HBASE-13538
> Project: HBase
> Issue Type: Sub-task
> Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: Srikanth Srungarapu
>Assignee: Ashish Singhi
> Fix For: 2.0.0
>
> Attachments: HBASE-13538.patch
>
>
> Client side part of HBASE-13209.
> It uses the new procedure code to be know when the procedure is completed,
> and have a proper sync/async behavior on add/modify/delete column family.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14666) Remove deprecated HBaseTestingUtility#deleteTable methods
[ https://issues.apache.org/jira/browse/HBASE-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967839#comment-14967839 ] Matteo Bertozzi commented on HBASE-14666: - +1 > Remove deprecated HBaseTestingUtility#deleteTable methods > - > > Key: HBASE-14666 > URL: https://issues.apache.org/jira/browse/HBASE-14666 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14666.patch > > > HBase has had the TableName APIs since 0.96 and our test code doesn't have > privacy/stability markers so we should be able to remove the deprecated > methods in 2.0.0. > deleteTable has some separate unit test related cleanup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14668) Remove deprecated HBaseTestCase dependency from TestHFile
[ https://issues.apache.org/jira/browse/HBASE-14668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14668: --- Assignee: Jonathan Hsieh Status: Patch Available (was: Open) > Remove deprecated HBaseTestCase dependency from TestHFile > - > > Key: HBASE-14668 > URL: https://issues.apache.org/jira/browse/HBASE-14668 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14668.patch > > > Remove dependency on long deprecated HBaseTestCase (0.90). modified > references to tfiles which haven't been part of any modern hbase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14668) Remove deprecated HBaseTestCase dependency from TestHFile
[ https://issues.apache.org/jira/browse/HBASE-14668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14668: --- Attachment: hbase-14668.patch > Remove deprecated HBaseTestCase dependency from TestHFile > - > > Key: HBASE-14668 > URL: https://issues.apache.org/jira/browse/HBASE-14668 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14668.patch > > > Remove dependency on long deprecated HBaseTestCase (0.90). modified > references to tfiles which haven't been part of any modern hbase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14667) HBaseFsck constructors have diverged
[ https://issues.apache.org/jira/browse/HBASE-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967945#comment-14967945 ] Jonathan Hsieh commented on HBASE-14667: +1 > HBaseFsck constructors have diverged > > > Key: HBASE-14667 > URL: https://issues.apache.org/jira/browse/HBASE-14667 > Project: HBase > Issue Type: Bug >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Attachments: HBASE-14667-v0.patch > > > copy paste that diverged, we can just call the other constructor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14387) Compaction improvements: Maximum off-peak compaction size
[
https://issues.apache.org/jira/browse/HBASE-14387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968030#comment-14968030
]
Hadoop QA commented on HBASE-14387:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12767836/HBASE-14387-v3.patch
against master branch at commit b3afdb8de1a9fa88c553159b2d2d2aa96902a345.
ATTACHMENT ID: 12767836
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16146//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16146//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16146//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16146//console
This message is automatically generated.
> Compaction improvements: Maximum off-peak compaction size
> -
>
> Key: HBASE-14387
> URL: https://issues.apache.org/jira/browse/HBASE-14387
> Project: HBase
> Issue Type: Improvement
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
> Attachments: HBASE-14387-v1.patch, HBASE-14387-v2.patch,
> HBASE-14387-v3.patch
>
>
> Make max compaction size for peak and off peak separate config options.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14670) Remove deprecated HBaseTestCase from TestBlocksRead
[ https://issues.apache.org/jira/browse/HBASE-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14670: --- Affects Version/s: 2.0.0 > Remove deprecated HBaseTestCase from TestBlocksRead > > > Key: HBASE-14670 > URL: https://issues.apache.org/jira/browse/HBASE-14670 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh > Fix For: 2.0.0 > > > removing dependency on long deprecated apis -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14670) Remove deprecated HBaseTestCase from TestBlocksRead
[ https://issues.apache.org/jira/browse/HBASE-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14670: --- Fix Version/s: 2.0.0 > Remove deprecated HBaseTestCase from TestBlocksRead > > > Key: HBASE-14670 > URL: https://issues.apache.org/jira/browse/HBASE-14670 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh > Fix For: 2.0.0 > > > removing dependency on long deprecated apis -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14671) Remove deprecated HBaseTestCase/Put/Delete apis from TestGetClosestAtOrBefore
[ https://issues.apache.org/jira/browse/HBASE-14671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-14671: --- Attachment: hbase-14671.patch > Remove deprecated HBaseTestCase/Put/Delete apis from TestGetClosestAtOrBefore > - > > Key: HBASE-14671 > URL: https://issues.apache.org/jira/browse/HBASE-14671 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 2.0.0 >Reporter: Jonathan Hsieh >Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-14671.patch > > > converting from long deprecated apis to modern apis. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14669) remove unused import and fix javadoc
[ https://issues.apache.org/jira/browse/HBASE-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Bertozzi updated HBASE-14669: Status: Patch Available (was: Open) > remove unused import and fix javadoc > > > Key: HBASE-14669 > URL: https://issues.apache.org/jira/browse/HBASE-14669 > Project: HBase > Issue Type: Improvement >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Trivial > Attachments: HBASE-14669-v0.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-14670) Remove deprecated HBaseTestCase from TestBlocksRead
Jonathan Hsieh created HBASE-14670: -- Summary: Remove deprecated HBaseTestCase from TestBlocksRead Key: HBASE-14670 URL: https://issues.apache.org/jira/browse/HBASE-14670 Project: HBase Issue Type: Improvement Reporter: Jonathan Hsieh removing dependency on long deprecated apis -- This message was sent by Atlassian JIRA (v6.3.4#6332)
