[jira] [Commented] (HBASE-15616) CheckAndMutate will encouter NPE if qualifier to check is null
[
https://issues.apache.org/jira/browse/HBASE-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233894#comment-15233894
]
Hadoop QA commented on HBASE-15616:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
22s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 45s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 25s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
25s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
25s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 47s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 30s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
29s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 42s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 42s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 26s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 26s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
22s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
36m 25s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
54s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 30s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 25s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
11s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 57m 3s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12797691/HBASE-15616-v1.patch |
| JIRA Issue | HBASE-15616 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / f7d44e9 |
| Default Java | 1.7.0_79 |
| Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0
/usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 |
| findbugs |
[jira] [Commented] (HBASE-15619) Performance regression observed: Random read(get) performance of branch-1 worse than 0.98
[ https://issues.apache.org/jira/browse/HBASE-15619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233890#comment-15233890 ] stack commented on HBASE-15619: --- Which ycsb client did you run with [~carp84]? hbase98 or hbase10 or did you change the ycsb client with the runs? Thanks. > Performance regression observed: Random read(get) performance of branch-1 > worse than 0.98 > - > > Key: HBASE-15619 > URL: https://issues.apache.org/jira/browse/HBASE-15619 > Project: HBase > Issue Type: Bug >Reporter: Yu Li >Assignee: Yu Li >Priority: Critical > > As titled, I observed the perf regression in the final stress testing before > upgrading our online cluster to 1.x. More details as follows: > 1. HBase version in the comparison test: > * 0.98: based on 0.98.12 with some backports, among which HBASE-11297 is > the most important perf-related one (especially under high stress) > * 1.x: checked 3 releases in total > 1) 1.1.2 with important perf fixes/improvements including HBASE-15031 > and HBASE-14465 (we planed to upgrade to 1.x since Oct. last year, by when > 1.1.2 was the latest stable release in branch-1) > 2) 1.1.4 release > 3) 1.2.1RC1 > 2. Test environment > * YCSB: 0.7.0 with > [YCSB-651|https://github.com/brianfrankcooper/YCSB/pull/651] applied > * Client: 4 physical nodes, each with 8 YCSB instance, each instance with > 100 threads > * Server: 1 Master with 3 RS, each RS with 256 handlers and 64G heap > * Hardware: 64-core CPU, 256GB Mem, 10Gb Net, 1 PCIe-SSD and 11 HDD, same > hardware for client and server > 3. Test cases > * -p fieldcount=1 -p fieldlength=128 -p readproportion=1 > * case #1: read against empty table > * case #2: lrucache 100% hit > * case #3: BLOCKCACHE=>false > 4. Test result > * 1.1.4 and 1.2.1 have a similar perf (less than 2% deviation) as 1.1.2+, so > will only paste comparison data of 0.98.12+ and 1.1.2+ > * per-RS Throughput(ops/s) > ||HBaseVersion||case#1||case#2||case#3|| > |0.98.12+|383562|257493|47594| > |1.1.2+|363050|232757|35872| > * AverageLatency(us) > ||HBaseVersion||case#1||case#2||case#3|| > |0.98.12+|2774|4134|22371| > |1.1.2+|2930|4572|29690| > It seems to me each part on the read path has perf regression: RPCServer for > case#1, lrucache read for case#2, and hfile read for case#3... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15616) CheckAndMutate will encouter NPE if qualifier to check is null
[
https://issues.apache.org/jira/browse/HBASE-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233882#comment-15233882
]
Jianwei Cui commented on HBASE-15616:
-
Thanks for the review [~stack]. The patch could also be applied to branch-1.
> CheckAndMutate will encouter NPE if qualifier to check is null
> --
>
> Key: HBASE-15616
> URL: https://issues.apache.org/jira/browse/HBASE-15616
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
> Attachments: HBASE-15616-v1.patch
>
>
> If qualifier to check is null, the checkAndMutate/checkAndPut/checkAndDelete
> will encounter NPE.
> The test code:
> {code}
> table.checkAndPut(row, family, null, Bytes.toBytes(0), new
> Put(row).addColumn(family, null, Bytes.toBytes(1)));
> {code}
> The exception:
> {code}
> Exception in thread "main"
> org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after
> attempts=3, exceptions:
> Fri Apr 08 15:51:31 CST 2016,
> RpcRetryingCaller{globalStartTime=1460101891615, pause=100, maxAttempts=3},
> java.io.IOException: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> Fri Apr 08 15:51:31 CST 2016,
> RpcRetryingCaller{globalStartTime=1460101891615, pause=100, maxAttempts=3},
> java.io.IOException: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> Fri Apr 08 15:51:32 CST 2016,
> RpcRetryingCaller{globalStartTime=1460101891615, pause=100, maxAttempts=3},
> java.io.IOException: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:120)
> at org.apache.hadoop.hbase.client.HTable.checkAndPut(HTable.java:772)
> at ...
> Caused by: java.io.IOException: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.protobuf.ProtobufUtil.getRemoteException(ProtobufUtil.java:341)
> at org.apache.hadoop.hbase.client.HTable$7.call(HTable.java:768)
> at org.apache.hadoop.hbase.client.HTable$7.call(HTable.java:755)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:99)
> ... 2 more
> Caused by: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:239)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:331)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$BlockingStub.mutate(ClientProtos.java:35252)
> at org.apache.hadoop.hbase.client.HTable$7.call(HTable.java:765)
> ... 4 more
> Caused by: java.lang.NullPointerException
> at com.google.protobuf.LiteralByteString.size(LiteralByteString.java:76)
> at
> com.google.protobuf.CodedOutputStream.computeBytesSizeNoTag(CodedOutputStream.java:767)
> at
> com.google.protobuf.CodedOutputStream.computeBytesSize(CodedOutputStream.java:539)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$Condition.getSerializedSize(ClientProtos.java:7483)
> at
> com.google.protobuf.CodedOutputStream.computeMessageSizeNoTag(CodedOutputStream.java:749)
> at
> com.google.protobuf.CodedOutputStream.computeMessageSize(CodedOutputStream.java:530)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$MutateRequest.getSerializedSize(ClientProtos.java:12431)
> at
> org.apache.hadoop.hbase.ipc.IPCUtil.getTotalSizeWhenWrittenDelimited(IPCUtil.java:311)
> at
> org.apache.hadoop.hbase.ipc.AsyncRpcChannel.writeRequest(AsyncRpcChannel.java:409)
> at
> org.apache.hadoop.hbase.ipc.AsyncRpcChannel.callMethod(AsyncRpcChannel.java:333)
> at
> org.apache.hadoop.hbase.ipc.AsyncRpcClient.call(AsyncRpcClient.java:245)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:226)
> ... 7 more
> {code}
> The reason is {{LiteralByteString.size()}} will throw NPE if wrapped byte
> array is null. It is possible to invoke {{put}} and {{checkAndMutate}} on the
> same column, because null qualifier is allowed for {{Put}}, users may be
> confused if null qualifier is not allowed for {{checkAndMutate}}. We can also
> convert null qualifier to empty byte array for {{checkAndMutate}} in client
> side. Discussions and suggestions are welcomed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15616) CheckAndMutate will encouter NPE if qualifier to check is null
[
https://issues.apache.org/jira/browse/HBASE-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jianwei Cui updated HBASE-15616:
Status: Patch Available (was: In Progress)
> CheckAndMutate will encouter NPE if qualifier to check is null
> --
>
> Key: HBASE-15616
> URL: https://issues.apache.org/jira/browse/HBASE-15616
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
> Attachments: HBASE-15616-v1.patch
>
>
> If qualifier to check is null, the checkAndMutate/checkAndPut/checkAndDelete
> will encounter NPE.
> The test code:
> {code}
> table.checkAndPut(row, family, null, Bytes.toBytes(0), new
> Put(row).addColumn(family, null, Bytes.toBytes(1)));
> {code}
> The exception:
> {code}
> Exception in thread "main"
> org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after
> attempts=3, exceptions:
> Fri Apr 08 15:51:31 CST 2016,
> RpcRetryingCaller{globalStartTime=1460101891615, pause=100, maxAttempts=3},
> java.io.IOException: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> Fri Apr 08 15:51:31 CST 2016,
> RpcRetryingCaller{globalStartTime=1460101891615, pause=100, maxAttempts=3},
> java.io.IOException: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> Fri Apr 08 15:51:32 CST 2016,
> RpcRetryingCaller{globalStartTime=1460101891615, pause=100, maxAttempts=3},
> java.io.IOException: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:120)
> at org.apache.hadoop.hbase.client.HTable.checkAndPut(HTable.java:772)
> at ...
> Caused by: java.io.IOException: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.protobuf.ProtobufUtil.getRemoteException(ProtobufUtil.java:341)
> at org.apache.hadoop.hbase.client.HTable$7.call(HTable.java:768)
> at org.apache.hadoop.hbase.client.HTable$7.call(HTable.java:755)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:99)
> ... 2 more
> Caused by: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:239)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:331)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$BlockingStub.mutate(ClientProtos.java:35252)
> at org.apache.hadoop.hbase.client.HTable$7.call(HTable.java:765)
> ... 4 more
> Caused by: java.lang.NullPointerException
> at com.google.protobuf.LiteralByteString.size(LiteralByteString.java:76)
> at
> com.google.protobuf.CodedOutputStream.computeBytesSizeNoTag(CodedOutputStream.java:767)
> at
> com.google.protobuf.CodedOutputStream.computeBytesSize(CodedOutputStream.java:539)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$Condition.getSerializedSize(ClientProtos.java:7483)
> at
> com.google.protobuf.CodedOutputStream.computeMessageSizeNoTag(CodedOutputStream.java:749)
> at
> com.google.protobuf.CodedOutputStream.computeMessageSize(CodedOutputStream.java:530)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$MutateRequest.getSerializedSize(ClientProtos.java:12431)
> at
> org.apache.hadoop.hbase.ipc.IPCUtil.getTotalSizeWhenWrittenDelimited(IPCUtil.java:311)
> at
> org.apache.hadoop.hbase.ipc.AsyncRpcChannel.writeRequest(AsyncRpcChannel.java:409)
> at
> org.apache.hadoop.hbase.ipc.AsyncRpcChannel.callMethod(AsyncRpcChannel.java:333)
> at
> org.apache.hadoop.hbase.ipc.AsyncRpcClient.call(AsyncRpcClient.java:245)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:226)
> ... 7 more
> {code}
> The reason is {{LiteralByteString.size()}} will throw NPE if wrapped byte
> array is null. It is possible to invoke {{put}} and {{checkAndMutate}} on the
> same column, because null qualifier is allowed for {{Put}}, users may be
> confused if null qualifier is not allowed for {{checkAndMutate}}. We can also
> convert null qualifier to empty byte array for {{checkAndMutate}} in client
> side. Discussions and suggestions are welcomed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work started] (HBASE-15616) CheckAndMutate will encouter NPE if qualifier to check is null
[
https://issues.apache.org/jira/browse/HBASE-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-15616 started by Jianwei Cui.
---
> CheckAndMutate will encouter NPE if qualifier to check is null
> --
>
> Key: HBASE-15616
> URL: https://issues.apache.org/jira/browse/HBASE-15616
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
> Attachments: HBASE-15616-v1.patch
>
>
> If qualifier to check is null, the checkAndMutate/checkAndPut/checkAndDelete
> will encounter NPE.
> The test code:
> {code}
> table.checkAndPut(row, family, null, Bytes.toBytes(0), new
> Put(row).addColumn(family, null, Bytes.toBytes(1)));
> {code}
> The exception:
> {code}
> Exception in thread "main"
> org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after
> attempts=3, exceptions:
> Fri Apr 08 15:51:31 CST 2016,
> RpcRetryingCaller{globalStartTime=1460101891615, pause=100, maxAttempts=3},
> java.io.IOException: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> Fri Apr 08 15:51:31 CST 2016,
> RpcRetryingCaller{globalStartTime=1460101891615, pause=100, maxAttempts=3},
> java.io.IOException: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> Fri Apr 08 15:51:32 CST 2016,
> RpcRetryingCaller{globalStartTime=1460101891615, pause=100, maxAttempts=3},
> java.io.IOException: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:120)
> at org.apache.hadoop.hbase.client.HTable.checkAndPut(HTable.java:772)
> at ...
> Caused by: java.io.IOException: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.protobuf.ProtobufUtil.getRemoteException(ProtobufUtil.java:341)
> at org.apache.hadoop.hbase.client.HTable$7.call(HTable.java:768)
> at org.apache.hadoop.hbase.client.HTable$7.call(HTable.java:755)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:99)
> ... 2 more
> Caused by: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:239)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:331)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$BlockingStub.mutate(ClientProtos.java:35252)
> at org.apache.hadoop.hbase.client.HTable$7.call(HTable.java:765)
> ... 4 more
> Caused by: java.lang.NullPointerException
> at com.google.protobuf.LiteralByteString.size(LiteralByteString.java:76)
> at
> com.google.protobuf.CodedOutputStream.computeBytesSizeNoTag(CodedOutputStream.java:767)
> at
> com.google.protobuf.CodedOutputStream.computeBytesSize(CodedOutputStream.java:539)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$Condition.getSerializedSize(ClientProtos.java:7483)
> at
> com.google.protobuf.CodedOutputStream.computeMessageSizeNoTag(CodedOutputStream.java:749)
> at
> com.google.protobuf.CodedOutputStream.computeMessageSize(CodedOutputStream.java:530)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$MutateRequest.getSerializedSize(ClientProtos.java:12431)
> at
> org.apache.hadoop.hbase.ipc.IPCUtil.getTotalSizeWhenWrittenDelimited(IPCUtil.java:311)
> at
> org.apache.hadoop.hbase.ipc.AsyncRpcChannel.writeRequest(AsyncRpcChannel.java:409)
> at
> org.apache.hadoop.hbase.ipc.AsyncRpcChannel.callMethod(AsyncRpcChannel.java:333)
> at
> org.apache.hadoop.hbase.ipc.AsyncRpcClient.call(AsyncRpcClient.java:245)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:226)
> ... 7 more
> {code}
> The reason is {{LiteralByteString.size()}} will throw NPE if wrapped byte
> array is null. It is possible to invoke {{put}} and {{checkAndMutate}} on the
> same column, because null qualifier is allowed for {{Put}}, users may be
> confused if null qualifier is not allowed for {{checkAndMutate}}. We can also
> convert null qualifier to empty byte array for {{checkAndMutate}} in client
> side. Discussions and suggestions are welcomed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (HBASE-15616) CheckAndMutate will encouter NPE if qualifier to check is null
[
https://issues.apache.org/jira/browse/HBASE-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jianwei Cui reassigned HBASE-15616:
---
Assignee: Jianwei Cui
> CheckAndMutate will encouter NPE if qualifier to check is null
> --
>
> Key: HBASE-15616
> URL: https://issues.apache.org/jira/browse/HBASE-15616
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
> Attachments: HBASE-15616-v1.patch
>
>
> If qualifier to check is null, the checkAndMutate/checkAndPut/checkAndDelete
> will encounter NPE.
> The test code:
> {code}
> table.checkAndPut(row, family, null, Bytes.toBytes(0), new
> Put(row).addColumn(family, null, Bytes.toBytes(1)));
> {code}
> The exception:
> {code}
> Exception in thread "main"
> org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after
> attempts=3, exceptions:
> Fri Apr 08 15:51:31 CST 2016,
> RpcRetryingCaller{globalStartTime=1460101891615, pause=100, maxAttempts=3},
> java.io.IOException: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> Fri Apr 08 15:51:31 CST 2016,
> RpcRetryingCaller{globalStartTime=1460101891615, pause=100, maxAttempts=3},
> java.io.IOException: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> Fri Apr 08 15:51:32 CST 2016,
> RpcRetryingCaller{globalStartTime=1460101891615, pause=100, maxAttempts=3},
> java.io.IOException: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:120)
> at org.apache.hadoop.hbase.client.HTable.checkAndPut(HTable.java:772)
> at ...
> Caused by: java.io.IOException: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.protobuf.ProtobufUtil.getRemoteException(ProtobufUtil.java:341)
> at org.apache.hadoop.hbase.client.HTable$7.call(HTable.java:768)
> at org.apache.hadoop.hbase.client.HTable$7.call(HTable.java:755)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:99)
> ... 2 more
> Caused by: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:239)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:331)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$BlockingStub.mutate(ClientProtos.java:35252)
> at org.apache.hadoop.hbase.client.HTable$7.call(HTable.java:765)
> ... 4 more
> Caused by: java.lang.NullPointerException
> at com.google.protobuf.LiteralByteString.size(LiteralByteString.java:76)
> at
> com.google.protobuf.CodedOutputStream.computeBytesSizeNoTag(CodedOutputStream.java:767)
> at
> com.google.protobuf.CodedOutputStream.computeBytesSize(CodedOutputStream.java:539)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$Condition.getSerializedSize(ClientProtos.java:7483)
> at
> com.google.protobuf.CodedOutputStream.computeMessageSizeNoTag(CodedOutputStream.java:749)
> at
> com.google.protobuf.CodedOutputStream.computeMessageSize(CodedOutputStream.java:530)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$MutateRequest.getSerializedSize(ClientProtos.java:12431)
> at
> org.apache.hadoop.hbase.ipc.IPCUtil.getTotalSizeWhenWrittenDelimited(IPCUtil.java:311)
> at
> org.apache.hadoop.hbase.ipc.AsyncRpcChannel.writeRequest(AsyncRpcChannel.java:409)
> at
> org.apache.hadoop.hbase.ipc.AsyncRpcChannel.callMethod(AsyncRpcChannel.java:333)
> at
> org.apache.hadoop.hbase.ipc.AsyncRpcClient.call(AsyncRpcClient.java:245)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:226)
> ... 7 more
> {code}
> The reason is {{LiteralByteString.size()}} will throw NPE if wrapped byte
> array is null. It is possible to invoke {{put}} and {{checkAndMutate}} on the
> same column, because null qualifier is allowed for {{Put}}, users may be
> confused if null qualifier is not allowed for {{checkAndMutate}}. We can also
> convert null qualifier to empty byte array for {{checkAndMutate}} in client
> side. Discussions and suggestions are welcomed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15623) Update refguide to change hadoop <= 2.3.x from NT to X for hbase-1.2.x
[ https://issues.apache.org/jira/browse/HBASE-15623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233860#comment-15233860 ] Hudson commented on HBASE-15623: FAILURE: Integrated in HBase-Trunk_matrix #835 (See [https://builds.apache.org/job/HBase-Trunk_matrix/835/]) HBASE-15623 Update refguide to change hadoop <= 2.3.x from NT to X for (stack: rev a4dcf51415616772e462091ce93622f070ea8810) * src/main/asciidoc/_chapters/configuration.adoc > Update refguide to change hadoop <= 2.3.x from NT to X for hbase-1.2.x > -- > > Key: HBASE-15623 > URL: https://issues.apache.org/jira/browse/HBASE-15623 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: stack >Assignee: stack > Fix For: 2.0.0 > > Attachments: 15623.patch > > > This issue is about updating our hadoop supported versions grid in the > prerequisites section of refguide. Here is thread proposing this change up on > dev list: http://osdir.com/ml/general/2016-04/msg09194.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15527) Refactor Compactor related classes
[ https://issues.apache.org/jira/browse/HBASE-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233840#comment-15233840 ] Hudson commented on HBASE-15527: SUCCESS: Integrated in HBase-1.3-IT #603 (See [https://builds.apache.org/job/HBase-1.3-IT/603/]) HBASE-15527 Refactor Compactor related classes (zhangduo: rev c9a00ff8fc4e73fa3962b99b2b67225184a6038d) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/AbstractMultiOutputCompactor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DateTieredCompactor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java > Refactor Compactor related classes > -- > > Key: HBASE-15527 > URL: https://issues.apache.org/jira/browse/HBASE-15527 > Project: HBase > Issue Type: Sub-task > Components: Compaction >Affects Versions: 2.0.0, 1.3.0, 0.98.18, 1.4.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0, 1.3.0, 0.98.19, 1.4.0 > > Attachments: HBASE-15527-0.98.patch, HBASE-15527-branch-1.patch, > HBASE-15527-branch-1.v1.patch, HBASE-15527-v1.patch, HBASE-15527.patch > > > DefaultCompactor and MultiOutputCompactor still have a lot of duplicate code > now, need refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HBASE-15618) Abort if security credentials become invalid
[ https://issues.apache.org/jira/browse/HBASE-15618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjeev Lakshmanan reassigned HBASE-15618: -- Assignee: Sanjeev Lakshmanan > Abort if security credentials become invalid > > > Key: HBASE-15618 > URL: https://issues.apache.org/jira/browse/HBASE-15618 > Project: HBase > Issue Type: Bug >Reporter: Andrew Purtell >Assignee: Sanjeev Lakshmanan > > We are investigating a production incident where a bad keytab push seems to > have caused one regionsever, serving hot regions, to lose the ability to > communicate with clients. After the fact we see a steady stream of GSS > initiation failure messages in the logs. The affected regionserver lingered > in an unhealthy state for too long. HBase did not automatically take any > corrective action, like an abort of the affected process, which would have > recovered service without operator intervention. > Consider detecting and aborting if security credentials like the Kerberos > keytab become invalid during runtime. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HBASE-15617) Canary in regionserver mode might not enumerate all regionservers
[ https://issues.apache.org/jira/browse/HBASE-15617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjeev Lakshmanan reassigned HBASE-15617: -- Assignee: Sanjeev Lakshmanan > Canary in regionserver mode might not enumerate all regionservers > - > > Key: HBASE-15617 > URL: https://issues.apache.org/jira/browse/HBASE-15617 > Project: HBase > Issue Type: Bug >Reporter: Andrew Purtell >Assignee: Sanjeev Lakshmanan >Priority: Minor > Labels: beginner > > When running in regionserver mode the Canary is expected to probe for service > health one time per regionserver during a probe interval. > Each time the canary chore fires, we create a RegionServerMonitor, which uses > filterRegionServerByName (via getAllRegionServerByName) to enumerate over all > table descriptors, find the locations for each table, then assemble the list > of regionservers to probe from this result. The list may not contain all live > regionservers, if there is a regionserver up but for some reason not serving > any regions. To ensure we have the complete list of live regionservers I > think it would be better to use Admin#getClusterStatus and enumerate the live > server list returned in the result. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15527) Refactor Compactor related classes
[ https://issues.apache.org/jira/browse/HBASE-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-15527: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed to branch-1.3+ and 0.98. Thanks [~stack] and [~enis] for reviewing. > Refactor Compactor related classes > -- > > Key: HBASE-15527 > URL: https://issues.apache.org/jira/browse/HBASE-15527 > Project: HBase > Issue Type: Sub-task > Components: Compaction >Affects Versions: 2.0.0, 1.3.0, 0.98.18, 1.4.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0, 1.3.0, 0.98.19, 1.4.0 > > Attachments: HBASE-15527-0.98.patch, HBASE-15527-branch-1.patch, > HBASE-15527-branch-1.v1.patch, HBASE-15527-v1.patch, HBASE-15527.patch > > > DefaultCompactor and MultiOutputCompactor still have a lot of duplicate code > now, need refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15577) there need be a mechanism to enable ZK's ACL check when the authentication strategy is simple
[
https://issues.apache.org/jira/browse/HBASE-15577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233806#comment-15233806
]
Heng Chen commented on HBASE-15577:
---
{quote}
if the node is below, all the client can read the node, but only the
server(Regionserver & Master which has the auth info) can modify it
/hbase
/hbase/meta-region-server
/hbase/master
/hbase/hbaseid
/hbase/rs
/hbase/table
/hbase/table/$tableName
otherwise, only the server can read and modify the node, the Client can't see
them
{quote}
There are some nodes we need to modify and read in client side, for example,
/hbase/replication, /hbase/swithes. How to deal with this nodes?
> there need be a mechanism to enable ZK's ACL check when the authentication
> strategy is simple
> -
>
> Key: HBASE-15577
> URL: https://issues.apache.org/jira/browse/HBASE-15577
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.1.3
>Reporter: chenxu
>Assignee: chenxu
> Attachments: HBASE-15577-02.patch, HBASE-15577-03.patch,
> HBASE-15577.patch, zk-set-acl.patch
>
>
> if the hbase.security.authentication is set to simple, the ZKUtil.createACL
> just return Ids.OPEN_ACL_UNSAFE, means that there is no ACL check on the ZK's
> node.
> we can refactoring this to enables the ACL's check function
> manual steps to verify the patch
> *1.set this property in the hbase-site.xml*
> {quote}
>hbase.security.authentication(simple)
>hbase.zookeeper.acl (digest:admin:0DPiKuNIrrVmD8IUCuw1hQxNqZc=:cdrwa)
>hbase.zookeeper.auth(digest:admin)
> {quote}
> the digest can generate by the
> DigestAuthenticationProvider.generateDigest("admin")
> *2.start the cluster*
> *3.verify the zk's node*
> {quote}
>(1)getAcl /hbase, result is:
>'digest,'admin:0DPiKuNIrrVmD8IUCuw1hQxNqZc= : cdrwa
>'world,'anyone: r
>(2)getAcl /hbase/table-lock, result is:
>'digest,'admin:0DPiKuNIrrVmD8IUCuw1hQxNqZc= : cdrwa
> {quote}
> if the node is below, all the client can read the node, but only the
> server(Regionserver & Master which has the auth info) can modify it
> {quote}
> /hbase
> /hbase/meta-region-server
> /hbase/master
> /hbase/hbaseid
> /hbase/rs
> /hbase/table
> /hbase/table/$tableName
> {quote}
> otherwise, only the server can read and modify the node, the Client can't see
> them
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15527) Refactor Compactor related classes
[ https://issues.apache.org/jira/browse/HBASE-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233805#comment-15233805 ] Duo Zhang commented on HBASE-15527: --- The checkstyle issues of branch-1 and 0.98 do not make sense... And I haven't found any findbugs warning related to the 0.98 patch. For the javadoc issues, I have checked the diff of the output with or without patch, no more warnings, both are 100 warnings. Will commit shortly if no objection. Thanks. > Refactor Compactor related classes > -- > > Key: HBASE-15527 > URL: https://issues.apache.org/jira/browse/HBASE-15527 > Project: HBase > Issue Type: Sub-task > Components: Compaction >Affects Versions: 2.0.0, 1.3.0, 0.98.18, 1.4.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0, 1.3.0, 0.98.19, 1.4.0 > > Attachments: HBASE-15527-0.98.patch, HBASE-15527-branch-1.patch, > HBASE-15527-branch-1.v1.patch, HBASE-15527-v1.patch, HBASE-15527.patch > > > DefaultCompactor and MultiOutputCompactor still have a lot of duplicate code > now, need refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-15624) Move master branch/hbase-2.0.0 to jdk-8 only
stack created HBASE-15624: - Summary: Move master branch/hbase-2.0.0 to jdk-8 only Key: HBASE-15624 URL: https://issues.apache.org/jira/browse/HBASE-15624 Project: HBase Issue Type: Bug Reporter: stack Assignee: stack Priority: Blocker Fix For: 2.0.0 Set build and pom target jvm version as jdk8. We chatted about it here: http://osdir.com/ml/general/2016-04/msg09691.html Set it as blocker on 2.0.0. We need to work on YETUS-369 before we can finish up this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15623) Update refguide to change hadoop <= 2.3.x from NT to X for hbase-1.2.x
[ https://issues.apache.org/jira/browse/HBASE-15623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-15623: -- Attachment: 15623.patch What I pushed. > Update refguide to change hadoop <= 2.3.x from NT to X for hbase-1.2.x > -- > > Key: HBASE-15623 > URL: https://issues.apache.org/jira/browse/HBASE-15623 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: stack >Assignee: stack > Fix For: 2.0.0 > > Attachments: 15623.patch > > > This issue is about updating our hadoop supported versions grid in the > prerequisites section of refguide. Here is thread proposing this change up on > dev list: http://osdir.com/ml/general/2016-04/msg09194.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (HBASE-15623) Update refguide to change hadoop <= 2.3.x from NT to X for hbase-1.2.x
[ https://issues.apache.org/jira/browse/HBASE-15623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-15623. --- Resolution: Fixed Fix Version/s: 2.0.0 Pushed to master branch. > Update refguide to change hadoop <= 2.3.x from NT to X for hbase-1.2.x > -- > > Key: HBASE-15623 > URL: https://issues.apache.org/jira/browse/HBASE-15623 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: stack >Assignee: stack > Fix For: 2.0.0 > > > This issue is about updating our hadoop supported versions grid in the > prerequisites section of refguide. Here is thread proposing this change up on > dev list: http://osdir.com/ml/general/2016-04/msg09194.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15623) Update refguide to change hadoop <= 2.3.x from NT to X for hbase-1.2.x
[ https://issues.apache.org/jira/browse/HBASE-15623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-15623: -- Description: This issue is about updating our hadoop supported versions grid in the prerequisites section of refguide. Here is thread proposing this change up on dev list: http://osdir.com/ml/general/2016-04/msg09194.html > Update refguide to change hadoop <= 2.3.x from NT to X for hbase-1.2.x > -- > > Key: HBASE-15623 > URL: https://issues.apache.org/jira/browse/HBASE-15623 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: stack >Assignee: stack > > This issue is about updating our hadoop supported versions grid in the > prerequisites section of refguide. Here is thread proposing this change up on > dev list: http://osdir.com/ml/general/2016-04/msg09194.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15623) Update refguide to change hadoop <= 2.3.x from NT to X for hbase-1.2.x
[ https://issues.apache.org/jira/browse/HBASE-15623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-15623: -- Summary: Update refguide to change hadoop <= 2.3.x from NT to X for hbase-1.2.x (was: Update refguide to change hadoop <= 2.3.x from NT to X ) > Update refguide to change hadoop <= 2.3.x from NT to X for hbase-1.2.x > -- > > Key: HBASE-15623 > URL: https://issues.apache.org/jira/browse/HBASE-15623 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: stack >Assignee: stack > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-15623) Update refguide to change hadoop <= 2.3.x from NT to X
stack created HBASE-15623: - Summary: Update refguide to change hadoop <= 2.3.x from NT to X Key: HBASE-15623 URL: https://issues.apache.org/jira/browse/HBASE-15623 Project: HBase Issue Type: Bug Components: documentation Reporter: stack Assignee: stack -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15619) Performance regression observed: Random read(get) performance of branch-1 worse than 0.98
[ https://issues.apache.org/jira/browse/HBASE-15619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-15619: -- Priority: Critical (was: Major) Marking critical. Let me try and reproduce what you are seeing [~carp84] > Performance regression observed: Random read(get) performance of branch-1 > worse than 0.98 > - > > Key: HBASE-15619 > URL: https://issues.apache.org/jira/browse/HBASE-15619 > Project: HBase > Issue Type: Bug >Reporter: Yu Li >Assignee: Yu Li >Priority: Critical > > As titled, I observed the perf regression in the final stress testing before > upgrading our online cluster to 1.x. More details as follows: > 1. HBase version in the comparison test: > * 0.98: based on 0.98.12 with some backports, among which HBASE-11297 is > the most important perf-related one (especially under high stress) > * 1.x: checked 3 releases in total > 1) 1.1.2 with important perf fixes/improvements including HBASE-15031 > and HBASE-14465 (we planed to upgrade to 1.x since Oct. last year, by when > 1.1.2 was the latest stable release in branch-1) > 2) 1.1.4 release > 3) 1.2.1RC1 > 2. Test environment > * YCSB: 0.7.0 with > [YCSB-651|https://github.com/brianfrankcooper/YCSB/pull/651] applied > * Client: 4 physical nodes, each with 8 YCSB instance, each instance with > 100 threads > * Server: 1 Master with 3 RS, each RS with 256 handlers and 64G heap > * Hardware: 64-core CPU, 256GB Mem, 10Gb Net, 1 PCIe-SSD and 11 HDD, same > hardware for client and server > 3. Test cases > * -p fieldcount=1 -p fieldlength=128 -p readproportion=1 > * case #1: read against empty table > * case #2: lrucache 100% hit > * case #3: BLOCKCACHE=>false > 4. Test result > * 1.1.4 and 1.2.1 have a similar perf (less than 2% deviation) as 1.1.2+, so > will only paste comparison data of 0.98.12+ and 1.1.2+ > * per-RS Throughput(ops/s) > ||HBaseVersion||case#1||case#2||case#3|| > |0.98.12+|383562|257493|47594| > |1.1.2+|363050|232757|35872| > * AverageLatency(us) > ||HBaseVersion||case#1||case#2||case#3|| > |0.98.12+|2774|4134|22371| > |1.1.2+|2930|4572|29690| > It seems to me each part on the read path has perf regression: RPCServer for > case#1, lrucache read for case#2, and hfile read for case#3... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15527) Refactor Compactor related classes
[
https://issues.apache.org/jira/browse/HBASE-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233708#comment-15233708
]
Hadoop QA commented on HBASE-15527:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
14s {color} | {color:green} 0.98 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 29s
{color} | {color:green} 0.98 passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 56s
{color} | {color:green} 0.98 passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s {color} | {color:green} 0.98 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s {color} | {color:green} 0.98 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 8s
{color} | {color:red} hbase-server in 0.98 has 82 extant Findbugs warnings.
{color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m 12s
{color} | {color:red} hbase-server in 0.98 failed with JDK v1.8.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s
{color} | {color:green} 0.98 passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
0s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 25s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 25s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 52s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 29s
{color} | {color:red} hbase-server: patch generated 2 new + 9 unchanged - 3
fixed = 11 total (was 12) {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 54s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
35s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m 10s
{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0. {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 33s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 261m 44s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
28s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 301m 36s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.balancer.TestStochasticLoadBalancer |
| | hadoop.hbase.mapreduce.TestImportExport |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12797871/HBASE-15527-0.98.patch
|
| JIRA Issue | HBASE-15527 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (HBASE-15527) Refactor Compactor related classes
[
https://issues.apache.org/jira/browse/HBASE-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233670#comment-15233670
]
Hadoop QA commented on HBASE-15527:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
1s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
3s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 18s
{color} | {color:green} branch-1 passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 46s
{color} | {color:green} branch-1 passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
44s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s
{color} | {color:green} branch-1 passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s
{color} | {color:green} branch-1 passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
57s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 21s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 21s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 45s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 45s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 26s
{color} | {color:red} hbase-server: patch generated 2 new + 12 unchanged - 4
fixed = 14 total (was 16) {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 33s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
18s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 14s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 7s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 168m 45s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
31s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 206m 39s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestHRegionServerBulkLoad |
| | hadoop.hbase.regionserver.TestHRegion |
| | hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
| Timed out junit tests |
org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot |
| | org.apache.hadoop.hbase.snapshot.TestExportSnapshot |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12797867/HBASE-15527-branch-1.v1.patch
|
| JIRA Issue | HBASE-15527 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf900.gq1.ygridcore.net
[jira] [Updated] (HBASE-15400) Use DateTieredCompactor for Date Tiered Compaction
[ https://issues.apache.org/jira/browse/HBASE-15400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-15400: --- Fix Version/s: 0.98.19 License header of RatioBasedCompactionPolicy was modified in 0.98 patch. I have restored the header to be the same as header used in other source file. > Use DateTieredCompactor for Date Tiered Compaction > -- > > Key: HBASE-15400 > URL: https://issues.apache.org/jira/browse/HBASE-15400 > Project: HBase > Issue Type: Sub-task > Components: Compaction >Reporter: Clara Xiong >Assignee: Clara Xiong > Fix For: 2.0.0, 1.3.0, 0.98.19, 1.4.0 > > Attachments: HBASE-15400-0.98.patch, HBASE-15400-15389-v12.patch, > HBASE-15400-branch-1.patch, HBASE-15400-v1.pa, HBASE-15400-v3-v3.patch, > HBASE-15400-v3-v4.patch, HBASE-15400-v3-v5.patch, HBASE-15400-v3.patch, > HBASE-15400-v6.patch, HBASE-15400-v7.patch, HBASE-15400.patch > > > When we compact, we can output multiple files along the current window > boundaries. There are two use cases: > 1. Major compaction: We want to output date tiered store files with data > older than max age archived in trunks of the window size on the higher tier. > Once a window is old enough, we don't combine the windows to promote to the > next tier any further. So files in these windows retain the same timespan as > they were minor-compacted last time, which is the window size of the highest > tier. Major compaction will touch these files and we want to maintain the > same layout. This way, TTL and archiving will be simpler and more efficient. > 2. Bulk load files and the old file generated by major compaction before > upgrading to DTCP. > Pros: > 1. Restore locality, process versioning, updates and deletes while > maintaining the tiered layout. > 2. The best way to fix a skewed layout. > > This work is based on a prototype of DateTieredCompactor from HBASE-15389 and > focused on the part to meet needs for these two use cases while supporting > others. I have to call out a few design decisions: > 1. We only want to output the files along all windows for major compaction. > And we want to output multiple files older than max age in the trunks of the > maximum tier window size determined by base window size, windows per tier and > max age. > 2. For minor compaction, we don't want to output too many files, which will > remain around because of current restriction of contiguous compaction by seq > id. I will only output two files if all the files in the windows are being > combined, one for the data within window and the other for the out-of-window > tail. If there is any file in the window excluded from compaction, only one > file will be output from compaction. When the windows are promoted, the > situation of out of order data will gradually improve. For the incoming > window, we need to accommodate the case with user-specified future data. > 3. We have to pass the boundaries with the list of store file as a complete > time snapshot instead of two separate calls because window layout is > determined by the time the computation is called. So we will need new type of > compaction request. > 4. Since we will assign the same seq id for all output files, we need to sort > by maxTimestamp subsequently. Right now all compaction policy gets the files > sorted for StoreFileManager which sorts by seq id and other criteria. I will > use this order for DTCP only, to avoid impacting other compaction policies. > 5. We need some cleanup of current design of StoreEngine and CompactionPolicy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15527) Refactor Compactor related classes
[ https://issues.apache.org/jira/browse/HBASE-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-15527: -- Attachment: HBASE-15527-0.98.patch Patch for 0.98. > Refactor Compactor related classes > -- > > Key: HBASE-15527 > URL: https://issues.apache.org/jira/browse/HBASE-15527 > Project: HBase > Issue Type: Sub-task > Components: Compaction >Affects Versions: 2.0.0, 1.3.0, 0.98.18, 1.4.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0, 1.3.0, 0.98.19, 1.4.0 > > Attachments: HBASE-15527-0.98.patch, HBASE-15527-branch-1.patch, > HBASE-15527-branch-1.v1.patch, HBASE-15527-v1.patch, HBASE-15527.patch > > > DefaultCompactor and MultiOutputCompactor still have a lot of duplicate code > now, need refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15527) Refactor Compactor related classes
[ https://issues.apache.org/jira/browse/HBASE-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-15527: -- Attachment: HBASE-15527-branch-1.v1.patch Fix the javadoc issue. > Refactor Compactor related classes > -- > > Key: HBASE-15527 > URL: https://issues.apache.org/jira/browse/HBASE-15527 > Project: HBase > Issue Type: Sub-task > Components: Compaction >Affects Versions: 2.0.0, 1.3.0, 0.98.18, 1.4.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0, 1.3.0, 0.98.19, 1.4.0 > > Attachments: HBASE-15527-branch-1.patch, > HBASE-15527-branch-1.v1.patch, HBASE-15527-v1.patch, HBASE-15527.patch > > > DefaultCompactor and MultiOutputCompactor still have a lot of duplicate code > now, need refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15527) Refactor Compactor related classes
[
https://issues.apache.org/jira/browse/HBASE-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233553#comment-15233553
]
Hadoop QA commented on HBASE-15527:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
30s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 32s
{color} | {color:green} branch-1 passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 59s
{color} | {color:green} branch-1 passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
32s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
30s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 9s
{color} | {color:green} branch-1 passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 1s
{color} | {color:green} branch-1 passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
10s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 32s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 32s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 0s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 0s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 33s
{color} | {color:red} hbase-server: patch generated 2 new + 12 unchanged - 4
fixed = 14 total (was 16) {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
24s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 21s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
12s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 4m 17s
{color} | {color:red} hbase-server-jdk1.8.0 with JDK v1.8.0 generated 1 new + 1
unchanged - 0 fixed = 2 total (was 1) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 5s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 5m 13s
{color} | {color:red} hbase-server-jdk1.7.0_79 with JDK v1.7.0_79 generated 1
new + 1 unchanged - 0 fixed = 2 total (was 1) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 56s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 24m 27s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 63m 17s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.replication.regionserver.TestReplicationThrottler |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12797863/HBASE-15527-branch-1.patch
|
| JIRA Issue |
[jira] [Updated] (HBASE-15527) Refactor Compactor related classes
[ https://issues.apache.org/jira/browse/HBASE-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-15527: -- Attachment: HBASE-15527-branch-1.patch Patch for branch-1. > Refactor Compactor related classes > -- > > Key: HBASE-15527 > URL: https://issues.apache.org/jira/browse/HBASE-15527 > Project: HBase > Issue Type: Sub-task > Components: Compaction >Affects Versions: 2.0.0, 1.3.0, 0.98.18, 1.4.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0, 1.3.0, 0.98.19, 1.4.0 > > Attachments: HBASE-15527-branch-1.patch, HBASE-15527-v1.patch, > HBASE-15527.patch > > > DefaultCompactor and MultiOutputCompactor still have a lot of duplicate code > now, need refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15527) Refactor Compactor related classes
[
https://issues.apache.org/jira/browse/HBASE-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233495#comment-15233495
]
Hadoop QA commented on HBASE-15527:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
45s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 44s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
15s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
52s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
41s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 44s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 44s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 31s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 4m 14s
{color} | {color:red} hbase-server: patch generated 1 new + 10 unchanged - 30
fixed = 11 total (was 40) {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
24m 49s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
10s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 91m 3s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 137m 27s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.security.access.TestNamespaceCommands |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12797853/HBASE-15527-v1.patch |
| JIRA Issue | HBASE-15527 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision |
[jira] [Commented] (HBASE-15507) Online modification of enabled ReplicationPeerConfig
[ https://issues.apache.org/jira/browse/HBASE-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233472#comment-15233472 ] Hudson commented on HBASE-15507: FAILURE: Integrated in HBase-Trunk_matrix #834 (See [https://builds.apache.org/job/HBase-Trunk_matrix/834/]) HBASE-15507 Online modification of enabled ReplicationPeerConfig (tedyu: rev e0f31ba6e68416db359d31eee21750cd7559909f) * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java * hbase-shell/src/main/ruby/hbase/replication_admin.rb * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerConfigListener.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityReplicationEndpoint.java * hbase-shell/src/main/ruby/shell/commands/update_peer_config.rb * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/BaseReplicationEndpoint.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/replication/TestReplicationAdminWithClusters.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java * hbase-shell/src/test/ruby/hbase/replication_admin_test.rb * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeer.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeers.java * hbase-shell/src/main/ruby/shell.rb * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationEndpoint.java * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java > Online modification of enabled ReplicationPeerConfig > > > Key: HBASE-15507 > URL: https://issues.apache.org/jira/browse/HBASE-15507 > Project: HBase > Issue Type: Improvement > Components: Replication >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby > Labels: Replication, shell > Fix For: 2.0.0 > > Attachments: HBASE-15507-v1.patch, HBASE-15507-v2.patch, > HBASE-15507-v3.patch, HBASE-15507.patch > > > It's currently possible to update the table CFs for a replication peer while > it's running, but not the peer configuration or data maps introduced as part > of custom replication endpoints in HBASE-11367. > This means that if you have a custom endpoint that depends on some > configuration parameter, you have to remove the peer and recreate it in order > to change the param. In some use cases that's not possible without risking > data loss. > HBASE-11393, which will consolidate tableCFs in the same znode as the rest of > ReplicationPeerConfig, may help here, but with or without it it still seems > like there needs to be further work to add update config/data API support to > ReplicationAdmin and a callback mechanism to notify the endpoints of config > parameter changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15527) Refactor Compactor related classes
[ https://issues.apache.org/jira/browse/HBASE-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-15527: -- Attachment: HBASE-15527-v1.patch Fix checkstyle issues. > Refactor Compactor related classes > -- > > Key: HBASE-15527 > URL: https://issues.apache.org/jira/browse/HBASE-15527 > Project: HBase > Issue Type: Sub-task > Components: Compaction >Affects Versions: 2.0.0, 1.3.0, 0.98.18, 1.4.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0, 1.3.0, 0.98.19, 1.4.0 > > Attachments: HBASE-15527-v1.patch, HBASE-15527.patch > > > DefaultCompactor and MultiOutputCompactor still have a lot of duplicate code > now, need refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15591) ServerCrashProcedure not yielding
[
https://issues.apache.org/jira/browse/HBASE-15591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233429#comment-15233429
]
Hadoop QA commented on HBASE-15591:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
17s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 38s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
40s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
52s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 34s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
41s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 43s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 43s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 32s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 4m 34s
{color} | {color:red} hbase-server: patch generated 6 new + 108 unchanged - 0
fixed = 114 total (was 108) {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
25m 18s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
11s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 95m 37s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 143m 43s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient |
| | org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12797848/HBASE-15591-master-v3.patch
|
| JIRA Issue | HBASE-15591 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
