[jira] [Commented] (HBASE-15884) NPE in StoreFileScanner#skipKVsNewerThanReadpoint during reverse scan
[
https://issues.apache.org/jira/browse/HBASE-15884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301577#comment-15301577
]
Hudson commented on HBASE-15884:
SUCCESS: Integrated in HBase-1.4 #176 (See
[https://builds.apache.org/job/HBase-1.4/176/])
HBASE-15884 NPE in StoreFileScanner#skipKVsNewerThanReadpoint during (tedyu:
rev a049b5f799daa50bd658c8f11fd18275666e3927)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
> NPE in StoreFileScanner#skipKVsNewerThanReadpoint during reverse scan
> -
>
> Key: HBASE-15884
> URL: https://issues.apache.org/jira/browse/HBASE-15884
> Project: HBase
> Issue Type: Bug
> Components: Scanners
>Affects Versions: 2.0.0, 1.2.1
>Reporter: Sergey Soldatov
>Assignee: Sergey Soldatov
> Attachments: HBASE-15884-1.patch
>
>
> Here is a part of {{skipKVsNewerThanReadpoint}} method:
> {noformat}
> hfs.next();
> setCurrentCell(hfs.getKeyValue());
> if (this.stopSkippingKVsIfNextRow
> && getComparator().compareRows(cur.getRowArray(),
> cur.getRowOffset(),
> cur.getRowLength(), startKV.getRowArray(),
> startKV.getRowOffset(),
> startKV.getRowLength()) > 0) {
> {noformat}
> If hfs has no more KVs, cur will be set to Null and on on the next step will
> throw NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14140) HBase Backup/Restore Phase 3: Enhance HBaseAdmin API to include backup/restore - related API
[ https://issues.apache.org/jira/browse/HBASE-14140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov updated HBASE-14140: -- Attachment: HBASE-14140-v14.patch Final v14? > HBase Backup/Restore Phase 3: Enhance HBaseAdmin API to include > backup/restore - related API > > > Key: HBASE-14140 > URL: https://issues.apache.org/jira/browse/HBASE-14140 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Attachments: HBASE-14140-v1.patch, HBASE-14140-v10.patch, > HBASE-14140-v11.patch, HBASE-14140-v12.patch, HBASE-14140-v13.patch, > HBASE-14140-v14.patch, HBASE-14140-v4.patch, HBASE-14140-v7.patch, > HBASE-14140-v9.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14635) Fix flaky test TestSnapshotCloneIndependence
[
https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matteo Bertozzi updated HBASE-14635:
Resolution: Fixed
Fix Version/s: (was: 1.3.0)
1.4.0
Status: Resolved (was: Patch Available)
> Fix flaky test TestSnapshotCloneIndependence
>
>
> Key: HBASE-14635
> URL: https://issues.apache.org/jira/browse/HBASE-14635
> Project: HBase
> Issue Type: Task
> Components: test
>Reporter: stack
>Assignee: Appy
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-14635-master-v2.patch,
> HBASE-14635-master-v3.patch, HBASE-14635-master-v4.patch,
> HBASE-14635-master.patch
>
>
> So the main bug fix here is that if online is set to false,
> {{createSnapshotAndValidate}} disables the original table. So instead of
> current code doing
> {noformat}
> if (!online) {
> tryDisable(admin, localTableName);
> }
> {noformat}
> we should be doing
> {noformat}
> if (!online) {
> admin.enableTable(originalTableName);
> UTIL.waitTableAvailable(originalTableName);
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14635) Fix flaky test TestSnapshotCloneIndependence
[
https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301505#comment-15301505
]
Matteo Bertozzi commented on HBASE-14635:
-
+1
> Fix flaky test TestSnapshotCloneIndependence
>
>
> Key: HBASE-14635
> URL: https://issues.apache.org/jira/browse/HBASE-14635
> Project: HBase
> Issue Type: Task
> Components: test
>Reporter: stack
>Assignee: Appy
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-14635-master-v2.patch,
> HBASE-14635-master-v3.patch, HBASE-14635-master-v4.patch,
> HBASE-14635-master.patch
>
>
> So the main bug fix here is that if online is set to false,
> {{createSnapshotAndValidate}} disables the original table. So instead of
> current code doing
> {noformat}
> if (!online) {
> tryDisable(admin, localTableName);
> }
> {noformat}
> we should be doing
> {noformat}
> if (!online) {
> admin.enableTable(originalTableName);
> UTIL.waitTableAvailable(originalTableName);
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15471) Add num calls in priority and general queue to RS UI
[ https://issues.apache.org/jira/browse/HBASE-15471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301484#comment-15301484 ] Hudson commented on HBASE-15471: FAILURE: Integrated in HBase-Trunk_matrix #947 (See [https://builds.apache.org/job/HBase-Trunk_matrix/947/]) HBASE-15471 Added in Priority, General, and Replication queue sizes for (elliott: rev b3362ccb0c35a493a8a97fa5593650bb08b736f9) * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon > Add num calls in priority and general queue to RS UI > > > Key: HBASE-15471 > URL: https://issues.apache.org/jira/browse/HBASE-15471 > Project: HBase > Issue Type: Improvement > Components: UI >Affects Versions: 1.2.0 >Reporter: Elliott Clark >Assignee: Joseph > Labels: beginner, easy, noob > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15471.patch, HBASE-15471.patch > > > 1.2 added the queue size. We should add the number of calls in the queue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15881) Allow BZIP2 compression
[
https://issues.apache.org/jira/browse/HBASE-15881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301478#comment-15301478
]
Hadoop QA commented on HBASE-15881:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 0s
{color} | {color:blue} The patch file was not named according to hbase's naming
conventions. Please see
https://yetus.apache.org/documentation/0.2.1/precommit-patchnames for
instructions. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 30s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
49s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 33s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 10s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
10s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
38s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
27s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 24s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 20s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 18s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
34s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 40s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 40s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 16s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 16s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
45s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
12m 8s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.1 2.5.2 2.6.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 20s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 9s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 28s
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 116m 25s
{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
25s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 161m 9s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12805757/15881-0.98.txt |
| JIRA Issue | HBASE-15881 |
| Optional Tests | asflicense javac javadoc
[jira] [Commented] (HBASE-11045) Replace deprecated method FileSystem#createNonRecursive
[ https://issues.apache.org/jira/browse/HBASE-11045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301441#comment-15301441 ] RyanTotti commented on HBASE-11045: --- Does that mean I can only use HDFS for HBase? Are there any other choices Hadoop supported? > Replace deprecated method FileSystem#createNonRecursive > --- > > Key: HBASE-11045 > URL: https://issues.apache.org/jira/browse/HBASE-11045 > Project: HBase > Issue Type: Task >Reporter: Gustavo Anatoly >Assignee: Gustavo Anatoly >Priority: Minor > Fix For: 2.0.0 > > > This change affect directly ProtobufLogWriter#init() associated to > TestHLog#testFailedToCreateHLogIfParentRenamed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14635) Fix flaky test TestSnapshotCloneIndependence
[
https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301434#comment-15301434
]
Hadoop QA commented on HBASE-14635:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
32s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 49s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
1s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
18s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
12s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 30s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 37s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
48s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 53s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 36s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
58s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 9m
56s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
25s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 109m 32s
{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 136m 56s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12806268/HBASE-14635-master-v4.patch
|
| JIRA Issue | HBASE-14635 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/test_framework/yetus-0.2.1/lib/precommit/personality/hbase.sh
|
| git revision | master / b3362cc |
| Default Java | 1.7.0_79 |
| Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0
/usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 |
| findbugs | v3.0.0 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/2015/testReport/ |
| modules | C: hbase-server U:
[jira] [Commented] (HBASE-15837) Memstore size accounting is wrong if postBatchMutate() throws exception
[
https://issues.apache.org/jira/browse/HBASE-15837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301390#comment-15301390
]
Hadoop QA commented on HBASE-15837:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
27s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 46s
{color} | {color:green} branch-1 passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s
{color} | {color:green} branch-1 passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
7s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 6s
{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s
{color} | {color:green} branch-1 passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 37s
{color} | {color:green} branch-1 passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
49s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 46s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 46s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 36s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
9s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 5m
39s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
40s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 41s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 125m 24s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 148m 11s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.coprocessor.TestRowProcessorEndpoint |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12806265/hbase-15837.branch-1.patch
|
| JIRA Issue | HBASE-15837 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf910.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/test_framework/yetus-0.2.1/lib/precommit/personality/hbase.sh
|
| git revision | branch-1 / 2346b5e |
| Default Java | 1.7.0_79 |
| Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0
/usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 |
| findbugs | v3.0.0 |
| unit |
[jira] [Commented] (HBASE-15884) NPE in StoreFileScanner#skipKVsNewerThanReadpoint during reverse scan
[
https://issues.apache.org/jira/browse/HBASE-15884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301389#comment-15301389
]
Hudson commented on HBASE-15884:
SUCCESS: Integrated in HBase-1.3-IT #679 (See
[https://builds.apache.org/job/HBase-1.3-IT/679/])
HBASE-15884 NPE in StoreFileScanner#skipKVsNewerThanReadpoint during (tedyu:
rev f6e145e23d747d42892f24bc7766400a2e852d1b)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
> NPE in StoreFileScanner#skipKVsNewerThanReadpoint during reverse scan
> -
>
> Key: HBASE-15884
> URL: https://issues.apache.org/jira/browse/HBASE-15884
> Project: HBase
> Issue Type: Bug
> Components: Scanners
>Affects Versions: 2.0.0, 1.2.1
>Reporter: Sergey Soldatov
>Assignee: Sergey Soldatov
> Attachments: HBASE-15884-1.patch
>
>
> Here is a part of {{skipKVsNewerThanReadpoint}} method:
> {noformat}
> hfs.next();
> setCurrentCell(hfs.getKeyValue());
> if (this.stopSkippingKVsIfNextRow
> && getComparator().compareRows(cur.getRowArray(),
> cur.getRowOffset(),
> cur.getRowLength(), startKV.getRowArray(),
> startKV.getRowOffset(),
> startKV.getRowLength()) > 0) {
> {noformat}
> If hfs has no more KVs, cur will be set to Null and on on the next step will
> throw NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15471) Add num calls in priority and general queue to RS UI
[ https://issues.apache.org/jira/browse/HBASE-15471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301388#comment-15301388 ] Hudson commented on HBASE-15471: SUCCESS: Integrated in HBase-1.3-IT #679 (See [https://builds.apache.org/job/HBase-1.3-IT/679/]) HBASE-15471 Added in Priority, General, and Replication queue sizes for (elliott: rev b2e8a415887e22decd4191876b34f1875b987776) * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon > Add num calls in priority and general queue to RS UI > > > Key: HBASE-15471 > URL: https://issues.apache.org/jira/browse/HBASE-15471 > Project: HBase > Issue Type: Improvement > Components: UI >Affects Versions: 1.2.0 >Reporter: Elliott Clark >Assignee: Joseph > Labels: beginner, easy, noob > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15471.patch, HBASE-15471.patch > > > 1.2 added the queue size. We should add the number of calls in the queue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15471) Add num calls in priority and general queue to RS UI
[ https://issues.apache.org/jira/browse/HBASE-15471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301328#comment-15301328 ] Hudson commented on HBASE-15471: SUCCESS: Integrated in HBase-1.3 #714 (See [https://builds.apache.org/job/HBase-1.3/714/]) HBASE-15471 Added in Priority, General, and Replication queue sizes for (elliott: rev b2e8a415887e22decd4191876b34f1875b987776) * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon > Add num calls in priority and general queue to RS UI > > > Key: HBASE-15471 > URL: https://issues.apache.org/jira/browse/HBASE-15471 > Project: HBase > Issue Type: Improvement > Components: UI >Affects Versions: 1.2.0 >Reporter: Elliott Clark >Assignee: Joseph > Labels: beginner, easy, noob > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15471.patch, HBASE-15471.patch > > > 1.2 added the queue size. We should add the number of calls in the queue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15471) Add num calls in priority and general queue to RS UI
[ https://issues.apache.org/jira/browse/HBASE-15471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301294#comment-15301294 ] Hudson commented on HBASE-15471: FAILURE: Integrated in HBase-1.4 #175 (See [https://builds.apache.org/job/HBase-1.4/175/]) HBASE-15471 Added in Priority, General, and Replication queue sizes for (elliott: rev 2346b5e2169c802ed77554f4a8a79cd97c07ed3f) * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon > Add num calls in priority and general queue to RS UI > > > Key: HBASE-15471 > URL: https://issues.apache.org/jira/browse/HBASE-15471 > Project: HBase > Issue Type: Improvement > Components: UI >Affects Versions: 1.2.0 >Reporter: Elliott Clark >Assignee: Joseph > Labels: beginner, easy, noob > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15471.patch, HBASE-15471.patch > > > 1.2 added the queue size. We should add the number of calls in the queue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15881) Allow BZIP2 compression
[ https://issues.apache.org/jira/browse/HBASE-15881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301241#comment-15301241 ] Enis Soztutar commented on HBASE-15881: --- +1. > Allow BZIP2 compression > --- > > Key: HBASE-15881 > URL: https://issues.apache.org/jira/browse/HBASE-15881 > Project: HBase > Issue Type: New Feature > Components: HFile >Reporter: Lars Hofhansl > Attachments: 15881-0.98.txt > > > BZIP2 is a very efficient compressor in terms of compression rate. > Compression speed is very slow, de-compression is equivalent or faster than > GZIP. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15881) Allow BZIP2 compression
[ https://issues.apache.org/jira/browse/HBASE-15881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-15881: -- Status: Patch Available (was: Open) > Allow BZIP2 compression > --- > > Key: HBASE-15881 > URL: https://issues.apache.org/jira/browse/HBASE-15881 > Project: HBase > Issue Type: New Feature > Components: HFile >Reporter: Lars Hofhansl > Attachments: 15881-0.98.txt > > > BZIP2 is a very efficient compressor in terms of compression rate. > Compression speed is very slow, de-compression is equivalent or faster than > GZIP. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15880) RpcClientImpl#tracedWriteRequest incorrectly closes HTrace span
[
https://issues.apache.org/jira/browse/HBASE-15880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301217#comment-15301217
]
Hudson commented on HBASE-15880:
FAILURE: Integrated in HBase-1.1-JDK8 #1808 (See
[https://builds.apache.org/job/HBase-1.1-JDK8/1808/])
HBASE-15880 RpcClientImpl#tracedWriteRequest incorrectly closes HTrace
(antonov: rev db7d17c897a064be342751a8f7092fc32cee1048)
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientImpl.java
> RpcClientImpl#tracedWriteRequest incorrectly closes HTrace span
> ---
>
> Key: HBASE-15880
> URL: https://issues.apache.org/jira/browse/HBASE-15880
> Project: HBase
> Issue Type: Bug
> Components: tracing
>Affects Versions: 1.3.0, 1.2.1, 1.1.5
>Reporter: Mikhail Antonov
>Assignee: Mikhail Antonov
> Fix For: 1.3.0, 1.2.2, 1.1.6
>
> Attachments: HBASE-15880-branch-1.3.v1.patch
>
>
> In this method we continue the span and then close it, which causes the
> current span (the one created by client app around HTabl#get() or similar API
> call) to be closed incorrectly.
> {code}
> TraceScope ts = Trace.continueSpan(span);
> try {
> writeRequest(call, priority, span);
> } finally {
> ts.close();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14635) Fix flaky test TestSnapshotCloneIndependence
[
https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Appy updated HBASE-14635:
-
Attachment: HBASE-14635-master-v4.patch
> Fix flaky test TestSnapshotCloneIndependence
>
>
> Key: HBASE-14635
> URL: https://issues.apache.org/jira/browse/HBASE-14635
> Project: HBase
> Issue Type: Task
> Components: test
>Reporter: stack
>Assignee: Appy
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14635-master-v2.patch,
> HBASE-14635-master-v3.patch, HBASE-14635-master-v4.patch,
> HBASE-14635-master.patch
>
>
> So the main bug fix here is that if online is set to false,
> {{createSnapshotAndValidate}} disables the original table. So instead of
> current code doing
> {noformat}
> if (!online) {
> tryDisable(admin, localTableName);
> }
> {noformat}
> we should be doing
> {noformat}
> if (!online) {
> admin.enableTable(originalTableName);
> UTIL.waitTableAvailable(originalTableName);
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (HBASE-11045) Replace deprecated method FileSystem#createNonRecursive
[ https://issues.apache.org/jira/browse/HBASE-11045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar resolved HBASE-11045. --- Resolution: Won't Fix > Replace deprecated method FileSystem#createNonRecursive > --- > > Key: HBASE-11045 > URL: https://issues.apache.org/jira/browse/HBASE-11045 > Project: HBase > Issue Type: Task >Reporter: Gustavo Anatoly >Assignee: Gustavo Anatoly >Priority: Minor > Fix For: 2.0.0 > > > This change affect directly ProtobufLogWriter#init() associated to > TestHLog#testFailedToCreateHLogIfParentRenamed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15610) Remove deprecated HConnection for 2.0 thus removing all PB references for 2.0
[
https://issues.apache.org/jira/browse/HBASE-15610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301203#comment-15301203
]
Hadoop QA commented on HBASE-15610:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 27 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m 51s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
8s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 1s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 5s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
52s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
6s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 19s
{color} | {color:red} branch/hbase-it no findbugs output file
(hbase-it/target/findbugsXml.xml) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 4s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 34s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 1m
25s {color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
21s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 34s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 34s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} scalac {color} | {color:green} 3m 34s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 57s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 57s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} scalac {color} | {color:green} 2m 57s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
53s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
8s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 1s
{color} | {color:red} Patch causes 32 errors with Hadoop v2.4.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m 40s
{color} | {color:red} Patch causes 32 errors with Hadoop v2.5.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m 20s
{color} | {color:red} Patch causes 32 errors with Hadoop v2.6.0. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 15s
{color} | {color:red} patch/hbase-it no findbugs output file
(hbase-it/target/findbugsXml.xml) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 4s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 33s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 1m
24s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 1m
23s {color} | {color:green} the patch passed {color} |
|
[jira] [Updated] (HBASE-15837) Memstore size accounting is wrong if postBatchMutate() throws exception
[ https://issues.apache.org/jira/browse/HBASE-15837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-15837: -- Attachment: hbase-15837.branch-1.patch branch-1 patch. I think we need this backported to all active. > Memstore size accounting is wrong if postBatchMutate() throws exception > --- > > Key: HBASE-15837 > URL: https://issues.apache.org/jira/browse/HBASE-15837 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0, 1.3.0, 1.2.2, 1.1.6 > > Attachments: HBASE-15837.001.patch, hbase-15837-v1.patch, > hbase-15837.branch-1.patch, hbase-memstore-size-accounting.patch > > > Over in PHOENIX-2883, I've been trying to figure out how to track down the > root cause of an issue we were seeing where a negative memstoreSize was > ultimately causing an RS to abort. The tl;dr version is > * Something causes memstoreSize to be negative (not sure what is doing this > yet) > * All subsequent flushes short-circuit and don't run because they think there > is no data to flush > * The region is eventually closed (commonly, for a move). > * A final flush is attempted on each store before closing (which also > short-circuit for the same reason), leaving unflushed data in each store. > * The sanity check that each store's size is zero fails and the RS aborts. > I have a little patch which I think should improve our failure case around > this, preventing the RS abort safely (forcing a flush when memstoreSize is > negative) and logging a calltrace when an update to memstoreSize make it > negative (to find culprits in the future). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15868) Refactor ReplicationQueues.isThisOurZnode() to ReplicationQueues.isThisOurRegionServer
[
https://issues.apache.org/jira/browse/HBASE-15868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301192#comment-15301192
]
Hadoop QA commented on HBASE-15868:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 45s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
29s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 17s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
57s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
27s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
58s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 1s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
5s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 16s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 16s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 50s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
29s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 9m
21s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
36s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 57s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 59s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 117m 12s
{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
27s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 151m 43s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12805090/HBASE-15868.patch |
| JIRA Issue | HBASE-15868 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT
[jira] [Updated] (HBASE-15837) Memstore size accounting is wrong if postBatchMutate() throws exception
[ https://issues.apache.org/jira/browse/HBASE-15837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-15837: -- Fix Version/s: 1.1.6 1.2.2 1.3.0 > Memstore size accounting is wrong if postBatchMutate() throws exception > --- > > Key: HBASE-15837 > URL: https://issues.apache.org/jira/browse/HBASE-15837 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0, 1.3.0, 1.2.2, 1.1.6 > > Attachments: HBASE-15837.001.patch, hbase-15837-v1.patch, > hbase-memstore-size-accounting.patch > > > Over in PHOENIX-2883, I've been trying to figure out how to track down the > root cause of an issue we were seeing where a negative memstoreSize was > ultimately causing an RS to abort. The tl;dr version is > * Something causes memstoreSize to be negative (not sure what is doing this > yet) > * All subsequent flushes short-circuit and don't run because they think there > is no data to flush > * The region is eventually closed (commonly, for a move). > * A final flush is attempted on each store before closing (which also > short-circuit for the same reason), leaving unflushed data in each store. > * The sanity check that each store's size is zero fails and the RS aborts. > I have a little patch which I think should improve our failure case around > this, preventing the RS abort safely (forcing a flush when memstoreSize is > negative) and logging a calltrace when an update to memstoreSize make it > negative (to find culprits in the future). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15698) Increment TimeRange not serialized to server
[
https://issues.apache.org/jira/browse/HBASE-15698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301171#comment-15301171
]
Sean Busbey commented on HBASE-15698:
-
[~sergey.soldatov] on the dev@phoenix list
([ref|https://lists.apache.org/thread.html/Zaptnijtlufsk8p]) says
{quote}
Not sure about the unit test, but the fix that cause our issue is HBASE-15198.
Prior it we had connection with cellBlock false, so protobuf serialized
everything, including timeRange. Now cellBlock is true and
buildNoDataRegionAction is used for the serializing of Increament mutations.
And it doesn't even think about timeRange. If you want to reproduce it with
phoenix, just get the workspace from the git on the commit provided in Jame's
comments, build it with -DskipTests, import into IDE (I would recommend Idea
since it's better handle generated files), place breakpoint in
RequestConverter.buildNoDataRegionAction at Increment i = (Increment) row; Now
run PhoenixTimeQueryIT in the debugger. Several steps and you will see that
builder will be started with empty timeRangeBuilder_
{quote}
> Increment TimeRange not serialized to server
>
>
> Key: HBASE-15698
> URL: https://issues.apache.org/jira/browse/HBASE-15698
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.3.0
>Reporter: James Taylor
>Assignee: Sean Busbey
>Priority: Blocker
> Labels: phoenix
> Fix For: 1.3.0, 1.0.4, 1.2.2, 0.98.20, 1.1.6
>
> Attachments: HBASE-15698.1.patch
>
>
> Before HBase-1.2, the Increment TimeRange set on the client was serialized
> over to the server. As of HBase 1.2, this appears to no longer be true, as my
> preIncrement coprocessor always gets HConstants.LATEST_TIMESTAMP as the value
> of increment.getTimeRange().getMax() regardless of what the client has
> specified.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-10358) Shell changes for setting consistency per request
[
https://issues.apache.org/jira/browse/HBASE-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301169#comment-15301169
]
Enis Soztutar commented on HBASE-10358:
---
For the scan, {{is_stale}} should be computed by the logic "if any row is
stale". The following logic only looks at the last row:
{code}
while iter.hasNext
row = iter.next
key = org.apache.hadoop.hbase.util.Bytes::toStringBinary(row.getRow)
+is_stale = row.isStale
{code}
This should be something like {{is_stale |= row.isStale}}.
Instead of adding stale method to formatter, I think we should add isStale
argument to the footer method. Printing footer should not be a two-step
operation.
> Shell changes for setting consistency per request
> -
>
> Key: HBASE-10358
> URL: https://issues.apache.org/jira/browse/HBASE-10358
> Project: HBase
> Issue Type: New Feature
> Components: shell
>Reporter: Enis Soztutar
>Assignee: yi liang
> Fix For: 2.0.0
>
> Attachments: Screen Shot 2016-04-21 at 3.09.52 PM.png, Screen Shot
> 2016-05-05 at 10.38.27 AM.png, shell.patch, shell_3.patch
>
>
> We can add shell support to set consistency per request.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15880) RpcClientImpl#tracedWriteRequest incorrectly closes HTrace span
[
https://issues.apache.org/jira/browse/HBASE-15880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301162#comment-15301162
]
Hudson commented on HBASE-15880:
FAILURE: Integrated in HBase-1.1-JDK7 #1722 (See
[https://builds.apache.org/job/HBase-1.1-JDK7/1722/])
HBASE-15880 RpcClientImpl#tracedWriteRequest incorrectly closes HTrace
(antonov: rev db7d17c897a064be342751a8f7092fc32cee1048)
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientImpl.java
> RpcClientImpl#tracedWriteRequest incorrectly closes HTrace span
> ---
>
> Key: HBASE-15880
> URL: https://issues.apache.org/jira/browse/HBASE-15880
> Project: HBase
> Issue Type: Bug
> Components: tracing
>Affects Versions: 1.3.0, 1.2.1, 1.1.5
>Reporter: Mikhail Antonov
>Assignee: Mikhail Antonov
> Fix For: 1.3.0, 1.2.2, 1.1.6
>
> Attachments: HBASE-15880-branch-1.3.v1.patch
>
>
> In this method we continue the span and then close it, which causes the
> current span (the one created by client app around HTabl#get() or similar API
> call) to be closed incorrectly.
> {code}
> TraceScope ts = Trace.continueSpan(span);
> try {
> writeRequest(call, priority, span);
> } finally {
> ts.close();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15112) Allow coprocessors to extend 'software attributes' list
[
https://issues.apache.org/jira/browse/HBASE-15112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301157#comment-15301157
]
Nick Dimiduk commented on HBASE-15112:
--
That sounds reasonable.
> Allow coprocessors to extend 'software attributes' list
> ---
>
> Key: HBASE-15112
> URL: https://issues.apache.org/jira/browse/HBASE-15112
> Project: HBase
> Issue Type: Improvement
> Components: Coprocessors
>Reporter: Nick Dimiduk
>
> Over on the {{/master-status}} and {{/rs-status}} pages we have a list of
> release properties, giving details about the cluster deployment. We should
> make this an extension point, allowing coprocessors to register information
> about themselves as well. For example, Phoenix, Trafodion, Tephra, might
> want to advertise installed version and build details as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14635) Fix flaky test TestSnapshotCloneIndependence
[
https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301155#comment-15301155
]
Hadoop QA commented on HBASE-14635:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
12s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 57s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 44s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
9s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
23s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
31s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 40s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 48s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 46s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 58s
{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0. {color}
|
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 58s {color}
| {color:red} hbase-server in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 49s
{color} | {color:red} hbase-server in the patch failed with JDK v1.7.0_79.
{color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 49s {color}
| {color:red} hbase-server in the patch failed with JDK v1.7.0_79. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
12s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 16s
{color} | {color:red} Patch causes 14 errors with Hadoop v2.4.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 29s
{color} | {color:red} Patch causes 14 errors with Hadoop v2.5.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m 53s
{color} | {color:red} Patch causes 14 errors with Hadoop v2.6.0. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 29s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 39s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 48s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 51s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 23m 6s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12806256/HBASE-14635-master-v3.patch
|
| JIRA Issue | HBASE-14635 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux pietas.apache.org 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT
Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Updated] (HBASE-14635) Fix flaky test TestSnapshotCloneIndependence
[
https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Appy updated HBASE-14635:
-
Description:
So the main bug fix here is that if online is set to false,
{{createSnapshotAndValidate}} disables the original table. So instead of
current code doing
{noformat}
if (!online) {
tryDisable(admin, localTableName);
}
{noformat}
we should be doing
{noformat}
if (!online) {
admin.enableTable(originalTableName);
UTIL.waitTableAvailable(originalTableName);
}
{noformat}
was:Was disabled in the parent issue because flakey. This issue is about
reenabling it after figuring why its flakey.
> Fix flaky test TestSnapshotCloneIndependence
>
>
> Key: HBASE-14635
> URL: https://issues.apache.org/jira/browse/HBASE-14635
> Project: HBase
> Issue Type: Task
> Components: test
>Reporter: stack
>Assignee: Appy
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14635-master-v2.patch,
> HBASE-14635-master-v3.patch, HBASE-14635-master.patch
>
>
> So the main bug fix here is that if online is set to false,
> {{createSnapshotAndValidate}} disables the original table. So instead of
> current code doing
> {noformat}
> if (!online) {
> tryDisable(admin, localTableName);
> }
> {noformat}
> we should be doing
> {noformat}
> if (!online) {
> admin.enableTable(originalTableName);
> UTIL.waitTableAvailable(originalTableName);
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14635) Fix flaky test TestSnapshotCloneIndependence
[ https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-14635: - Summary: Fix flaky test TestSnapshotCloneIndependence (was: Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent) > Fix flaky test TestSnapshotCloneIndependence > > > Key: HBASE-14635 > URL: https://issues.apache.org/jira/browse/HBASE-14635 > Project: HBase > Issue Type: Task > Components: test >Reporter: stack >Assignee: Appy > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14635-master-v2.patch, > HBASE-14635-master-v3.patch, HBASE-14635-master.patch > > > Was disabled in the parent issue because flakey. This issue is about > reenabling it after figuring why its flakey. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14635) Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent
[ https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-14635: - Attachment: HBASE-14635-master-v3.patch > Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent > -- > > Key: HBASE-14635 > URL: https://issues.apache.org/jira/browse/HBASE-14635 > Project: HBase > Issue Type: Task > Components: test >Reporter: stack >Assignee: Appy > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14635-master-v2.patch, > HBASE-14635-master-v3.patch, HBASE-14635-master.patch > > > Was disabled in the parent issue because flakey. This issue is about > reenabling it after figuring why its flakey. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15883) Adding WAL files and tracking offsets in HBase.
[ https://issues.apache.org/jira/browse/HBASE-15883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph updated HBASE-15883: --- Attachment: (was: HBASE-15883.patch) > Adding WAL files and tracking offsets in HBase. > > > Key: HBASE-15883 > URL: https://issues.apache.org/jira/browse/HBASE-15883 > Project: HBase > Issue Type: Sub-task > Components: Replication >Reporter: Joseph >Assignee: Joseph > Attachments: HBASE-15883.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15883) Adding WAL files and tracking offsets in HBase.
[ https://issues.apache.org/jira/browse/HBASE-15883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph updated HBASE-15883: --- Attachment: HBASE-15883.patch > Adding WAL files and tracking offsets in HBase. > > > Key: HBASE-15883 > URL: https://issues.apache.org/jira/browse/HBASE-15883 > Project: HBase > Issue Type: Sub-task > Components: Replication >Reporter: Joseph >Assignee: Joseph > Attachments: HBASE-15883.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15883) Adding WAL files and tracking offsets in HBase.
[ https://issues.apache.org/jira/browse/HBASE-15883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph updated HBASE-15883: --- Attachment: HBASE-15883.patch > Adding WAL files and tracking offsets in HBase. > > > Key: HBASE-15883 > URL: https://issues.apache.org/jira/browse/HBASE-15883 > Project: HBase > Issue Type: Sub-task > Components: Replication >Reporter: Joseph >Assignee: Joseph > Attachments: HBASE-15883.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HBASE-15883) Adding WAL files and tracking offsets in HBase.
[ https://issues.apache.org/jira/browse/HBASE-15883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301015#comment-15301015 ] Joseph edited comment on HBASE-15883 at 5/25/16 10:39 PM: -- Oh ok. I posted a version of the patch on https://reviews.apache.org/r/47861/ was (Author: vegetable26): Oh ok, sorry my bad. > Adding WAL files and tracking offsets in HBase. > > > Key: HBASE-15883 > URL: https://issues.apache.org/jira/browse/HBASE-15883 > Project: HBase > Issue Type: Sub-task > Components: Replication >Reporter: Joseph >Assignee: Joseph > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15883) Adding WAL files and tracking offsets in HBase.
[ https://issues.apache.org/jira/browse/HBASE-15883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301015#comment-15301015 ] Joseph commented on HBASE-15883: Oh ok, sorry my bad. > Adding WAL files and tracking offsets in HBase. > > > Key: HBASE-15883 > URL: https://issues.apache.org/jira/browse/HBASE-15883 > Project: HBase > Issue Type: Sub-task > Components: Replication >Reporter: Joseph >Assignee: Joseph > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15868) Refactor ReplicationQueues.isThisOurZnode() to ReplicationQueues.isThisOurRegionServer
[ https://issues.apache.org/jira/browse/HBASE-15868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph updated HBASE-15868: --- Resolution: Invalid Status: Resolved (was: Patch Available) > Refactor ReplicationQueues.isThisOurZnode() to > ReplicationQueues.isThisOurRegionServer > -- > > Key: HBASE-15868 > URL: https://issues.apache.org/jira/browse/HBASE-15868 > Project: HBase > Issue Type: Sub-task > Components: Replication >Reporter: Joseph >Assignee: Joseph >Priority: Minor > Attachments: HBASE-15868.patch > > > Minor refactoring because we want to eventually write non-ZooKeeper dependent > implementations of ReplicationQueues. These implementations will rely on > HBase tables instead of ZooKeeper z-nodes to store replication-rs information -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15883) Adding WAL files and tracking offsets in HBase.
[ https://issues.apache.org/jira/browse/HBASE-15883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300974#comment-15300974 ] Matteo Bertozzi commented on HBASE-15883: - can you post the patch on reviews.apache.org? it's easier to review and make comments > Adding WAL files and tracking offsets in HBase. > > > Key: HBASE-15883 > URL: https://issues.apache.org/jira/browse/HBASE-15883 > Project: HBase > Issue Type: Sub-task > Components: Replication >Reporter: Joseph >Assignee: Joseph > Attachments: HBASE-15883.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15471) Add num calls in priority and general queue to RS UI
[ https://issues.apache.org/jira/browse/HBASE-15471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15471: -- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 1.3.0 2.0.0 Status: Resolved (was: Patch Available) Pushed to branch-1, branch-1.3, and master. Thanks for your first HBase patch! > Add num calls in priority and general queue to RS UI > > > Key: HBASE-15471 > URL: https://issues.apache.org/jira/browse/HBASE-15471 > Project: HBase > Issue Type: Improvement > Components: UI >Affects Versions: 1.2.0 >Reporter: Elliott Clark >Assignee: Joseph > Labels: beginner, easy, noob > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15471.patch, HBASE-15471.patch > > > 1.2 added the queue size. We should add the number of calls in the queue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15883) Adding WAL files and tracking offsets in HBase.
[ https://issues.apache.org/jira/browse/HBASE-15883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph updated HBASE-15883: --- Attachment: (was: HBASE-15883.patch) > Adding WAL files and tracking offsets in HBase. > > > Key: HBASE-15883 > URL: https://issues.apache.org/jira/browse/HBASE-15883 > Project: HBase > Issue Type: Sub-task > Components: Replication >Reporter: Joseph >Assignee: Joseph > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15883) Adding WAL files and tracking offsets in HBase.
[ https://issues.apache.org/jira/browse/HBASE-15883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph updated HBASE-15883: --- Attachment: HBASE-15883.patch > Adding WAL files and tracking offsets in HBase. > > > Key: HBASE-15883 > URL: https://issues.apache.org/jira/browse/HBASE-15883 > Project: HBase > Issue Type: Sub-task > Components: Replication >Reporter: Joseph >Assignee: Joseph > Attachments: HBASE-15883.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15889) String case conversions are locale-sensitive, used without locale
[
https://issues.apache.org/jira/browse/HBASE-15889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300939#comment-15300939
]
Sean Busbey commented on HBASE-15889:
-
excellent! FWIW, our automated precommit check should take care of filtering
out current flakey tests when it checks things.
> String case conversions are locale-sensitive, used without locale
> -
>
> Key: HBASE-15889
> URL: https://issues.apache.org/jira/browse/HBASE-15889
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Sean Mackrory
>Priority: Minor
> Attachments: HBASE-15889-v1.patch
>
>
> Static code analysis is flagging cases of String.toLowerCase and
> String.toUpperCase being used without Locale. From the API reference:
> {quote}
> Note: This method is locale sensitive, and may produce unexpected results if
> used for strings that are intended to be interpreted locale independently.
> Examples are programming language identifiers, protocol keys, and HTML tags.
> For instance, "TITLE".toLowerCase() in a Turkish locale returns "t\u0131tle",
> where '\u0131' is the LATIN SMALL LETTER DOTLESS I character. To obtain
> correct results for locale insensitive strings, use toLowerCase(Locale.ROOT).
> {quote}
> Many uses of these functions do appear to be looking up classes, etc. and not
> dealing with stored data, so I'd think there aren't significant compatibility
> problems here and specifying the locale is indeed the safer way to go.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15890) Allow thrift to set/unset "cacheBlocks" for Scans
[
https://issues.apache.org/jira/browse/HBASE-15890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300908#comment-15300908
]
Hadoop QA commented on HBASE-15890:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
46s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 22s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
15s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 40s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
25s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 25s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 25s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 23s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 23s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 4 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 9m
14s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
31s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 40s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 28s
{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 31s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12806206/HBASE-15890-V0.patch |
| JIRA Issue | HBASE-15890 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/test_framework/yetus-0.2.1/lib/precommit/personality/hbase.sh
|
| git revision | master / fa74bae |
| Default Java | 1.7.0_79 |
| Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0
[jira] [Updated] (HBASE-15868) Refactor ReplicationQueues.isThisOurZnode() to ReplicationQueues.isThisOurRegionServer
[ https://issues.apache.org/jira/browse/HBASE-15868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph updated HBASE-15868: --- Status: Patch Available (was: Open) > Refactor ReplicationQueues.isThisOurZnode() to > ReplicationQueues.isThisOurRegionServer > -- > > Key: HBASE-15868 > URL: https://issues.apache.org/jira/browse/HBASE-15868 > Project: HBase > Issue Type: Sub-task > Components: Replication >Reporter: Joseph >Assignee: Joseph >Priority: Minor > Attachments: HBASE-15868.patch > > > Minor refactoring because we want to eventually write non-ZooKeeper dependent > implementations of ReplicationQueues. These implementations will rely on > HBase tables instead of ZooKeeper z-nodes to store replication-rs information -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15883) Adding WAL files and tracking offsets in HBase.
[ https://issues.apache.org/jira/browse/HBASE-15883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph updated HBASE-15883: --- Attachment: (was: HBASE-15883.patch) > Adding WAL files and tracking offsets in HBase. > > > Key: HBASE-15883 > URL: https://issues.apache.org/jira/browse/HBASE-15883 > Project: HBase > Issue Type: Sub-task > Components: Replication >Reporter: Joseph >Assignee: Joseph > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15890) Allow thrift to set/unset "cacheBlocks" for Scans
[ https://issues.apache.org/jira/browse/HBASE-15890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300875#comment-15300875 ] Ted Yu commented on HBASE-15890: Is it possible to add test for the new flag ? > Allow thrift to set/unset "cacheBlocks" for Scans > - > > Key: HBASE-15890 > URL: https://issues.apache.org/jira/browse/HBASE-15890 > Project: HBase > Issue Type: Improvement > Components: Thrift >Reporter: Ashu Pachauri >Assignee: Ashu Pachauri > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-15890-V0.patch > > > Long running scans going through thrift cache everything to the block cache. > We need the ability to disable caching for scans going through thrift. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HBASE-15890) Allow thrift to set/unset "cacheBlocks" for Scans
[ https://issues.apache.org/jira/browse/HBASE-15890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashu Pachauri reassigned HBASE-15890: - Assignee: Ashu Pachauri > Allow thrift to set/unset "cacheBlocks" for Scans > - > > Key: HBASE-15890 > URL: https://issues.apache.org/jira/browse/HBASE-15890 > Project: HBase > Issue Type: Improvement > Components: Thrift >Reporter: Ashu Pachauri >Assignee: Ashu Pachauri > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-15890-V0.patch > > > Long running scans going through thrift cache everything to the block cache. > We need the ability to disable caching for scans going through thrift. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15890) Allow thrift to set/unset "cacheBlocks" for Scans
[ https://issues.apache.org/jira/browse/HBASE-15890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashu Pachauri updated HBASE-15890: -- Status: Patch Available (was: Open) > Allow thrift to set/unset "cacheBlocks" for Scans > - > > Key: HBASE-15890 > URL: https://issues.apache.org/jira/browse/HBASE-15890 > Project: HBase > Issue Type: Improvement > Components: Thrift >Reporter: Ashu Pachauri >Assignee: Ashu Pachauri > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-15890-V0.patch > > > Long running scans going through thrift cache everything to the block cache. > We need the ability to disable caching for scans going through thrift. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15610) Remove deprecated HConnection for 2.0 thus removing all PB references for 2.0
[ https://issues.apache.org/jira/browse/HBASE-15610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jurriaan Mous updated HBASE-15610: -- Attachment: HBASE-15610.patch I took the liberty to do the work of removing HConnection and all of its usage. Please take a look at some of the methods moved from HConnection to ClusterConnection and the new MultiHConnection implementation > Remove deprecated HConnection for 2.0 thus removing all PB references for 2.0 > - > > Key: HBASE-15610 > URL: https://issues.apache.org/jira/browse/HBASE-15610 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: Jurriaan Mous >Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-15610.patch > > > This is sub-task for HBASE-15174. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15610) Remove deprecated HConnection for 2.0 thus removing all PB references for 2.0
[ https://issues.apache.org/jira/browse/HBASE-15610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jurriaan Mous updated HBASE-15610: -- Status: Patch Available (was: Open) > Remove deprecated HConnection for 2.0 thus removing all PB references for 2.0 > - > > Key: HBASE-15610 > URL: https://issues.apache.org/jira/browse/HBASE-15610 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: Jurriaan Mous >Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-15610.patch > > > This is sub-task for HBASE-15174. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HBASE-15610) Remove deprecated HConnection for 2.0 thus removing all PB references for 2.0
[ https://issues.apache.org/jira/browse/HBASE-15610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jurriaan Mous reassigned HBASE-15610: - Assignee: Jurriaan Mous (was: ramkrishna.s.vasudevan) > Remove deprecated HConnection for 2.0 thus removing all PB references for 2.0 > - > > Key: HBASE-15610 > URL: https://issues.apache.org/jira/browse/HBASE-15610 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: Jurriaan Mous >Priority: Blocker > Fix For: 2.0.0 > > > This is sub-task for HBASE-15174. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15880) RpcClientImpl#tracedWriteRequest incorrectly closes HTrace span
[
https://issues.apache.org/jira/browse/HBASE-15880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300834#comment-15300834
]
Mikhail Antonov commented on HBASE-15880:
-
Pushed to branch-1.1. [~ndimiduk]
> RpcClientImpl#tracedWriteRequest incorrectly closes HTrace span
> ---
>
> Key: HBASE-15880
> URL: https://issues.apache.org/jira/browse/HBASE-15880
> Project: HBase
> Issue Type: Bug
> Components: tracing
>Affects Versions: 1.3.0, 1.2.1, 1.1.5
>Reporter: Mikhail Antonov
>Assignee: Mikhail Antonov
> Fix For: 1.3.0, 1.2.2, 1.1.6
>
> Attachments: HBASE-15880-branch-1.3.v1.patch
>
>
> In this method we continue the span and then close it, which causes the
> current span (the one created by client app around HTabl#get() or similar API
> call) to be closed incorrectly.
> {code}
> TraceScope ts = Trace.continueSpan(span);
> try {
> writeRequest(call, priority, span);
> } finally {
> ts.close();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15890) Allow thrift to set/unset "cacheBlocks" for Scans
[ https://issues.apache.org/jira/browse/HBASE-15890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashu Pachauri updated HBASE-15890: -- Attachment: HBASE-15890-V0.patch > Allow thrift to set/unset "cacheBlocks" for Scans > - > > Key: HBASE-15890 > URL: https://issues.apache.org/jira/browse/HBASE-15890 > Project: HBase > Issue Type: Improvement > Components: Thrift >Reporter: Ashu Pachauri > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-15890-V0.patch > > > Long running scans going through thrift cache everything to the block cache. > We need the ability to disable caching for scans going through thrift. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15889) String case conversions are locale-sensitive, used without locale
[
https://issues.apache.org/jira/browse/HBASE-15889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Mackrory updated HBASE-15889:
--
Attachment: HBASE-15889-v1.patch
Attaching a patch for the ROOT Locale. I had a few of unit tests fail when
running with ENGLISH. Some failed before I made my patch - the other do appear
unrelated. Going to run again (with ROOT) to see if they're transient perhaps...
> String case conversions are locale-sensitive, used without locale
> -
>
> Key: HBASE-15889
> URL: https://issues.apache.org/jira/browse/HBASE-15889
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Sean Mackrory
>Priority: Minor
> Attachments: HBASE-15889-v1.patch
>
>
> Static code analysis is flagging cases of String.toLowerCase and
> String.toUpperCase being used without Locale. From the API reference:
> {quote}
> Note: This method is locale sensitive, and may produce unexpected results if
> used for strings that are intended to be interpreted locale independently.
> Examples are programming language identifiers, protocol keys, and HTML tags.
> For instance, "TITLE".toLowerCase() in a Turkish locale returns "t\u0131tle",
> where '\u0131' is the LATIN SMALL LETTER DOTLESS I character. To obtain
> correct results for locale insensitive strings, use toLowerCase(Locale.ROOT).
> {quote}
> Many uses of these functions do appear to be looking up classes, etc. and not
> dealing with stored data, so I'd think there aren't significant compatibility
> problems here and specifying the locale is indeed the safer way to go.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14140) HBase Backup/Restore Phase 3: Enhance HBaseAdmin API to include backup/restore - related API
[ https://issues.apache.org/jira/browse/HBASE-14140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300768#comment-15300768 ] Ted Yu commented on HBASE-14140: Patch v13 is much better (in terms of test passage). [~enis]: Do you want to take a look as well ? > HBase Backup/Restore Phase 3: Enhance HBaseAdmin API to include > backup/restore - related API > > > Key: HBASE-14140 > URL: https://issues.apache.org/jira/browse/HBASE-14140 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Attachments: HBASE-14140-v1.patch, HBASE-14140-v10.patch, > HBASE-14140-v11.patch, HBASE-14140-v12.patch, HBASE-14140-v13.patch, > HBASE-14140-v4.patch, HBASE-14140-v7.patch, HBASE-14140-v9.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15884) NPE in StoreFileScanner#skipKVsNewerThanReadpoint during reverse scan
[
https://issues.apache.org/jira/browse/HBASE-15884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300742#comment-15300742
]
Hudson commented on HBASE-15884:
FAILURE: Integrated in HBase-Trunk_matrix #946 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/946/])
HBASE-15884 NPE in StoreFileScanner#skipKVsNewerThanReadpoint during (tedyu:
rev fa74baeb409778de71c8a92b115b46dc63f313a0)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
> NPE in StoreFileScanner#skipKVsNewerThanReadpoint during reverse scan
> -
>
> Key: HBASE-15884
> URL: https://issues.apache.org/jira/browse/HBASE-15884
> Project: HBase
> Issue Type: Bug
> Components: Scanners
>Affects Versions: 2.0.0, 1.2.1
>Reporter: Sergey Soldatov
>Assignee: Sergey Soldatov
> Attachments: HBASE-15884-1.patch
>
>
> Here is a part of {{skipKVsNewerThanReadpoint}} method:
> {noformat}
> hfs.next();
> setCurrentCell(hfs.getKeyValue());
> if (this.stopSkippingKVsIfNextRow
> && getComparator().compareRows(cur.getRowArray(),
> cur.getRowOffset(),
> cur.getRowLength(), startKV.getRowArray(),
> startKV.getRowOffset(),
> startKV.getRowLength()) > 0) {
> {noformat}
> If hfs has no more KVs, cur will be set to Null and on on the next step will
> throw NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-15891) Closeable resources potentially not getting closed if exception is thrown
Sean Mackrory created HBASE-15891:
-
Summary: Closeable resources potentially not getting closed if
exception is thrown
Key: HBASE-15891
URL: https://issues.apache.org/jira/browse/HBASE-15891
Project: HBase
Issue Type: Bug
Reporter: Sean Mackrory
Priority: Minor
Static code analysis reports several instances of Closeable resources getting
closed outside of 'finally' blocks - so if an Exception is thrown it may not
get closed.
{code}
ZKUtil.getServerStats
CoprocessorClassLoader.init
LogLevel.process
JarFinder.createJar
RpcClientImpl.setupIOstreams
{code}
Most of these are straightforward. RpcClientImpl wraps the resource potentially
multiple times and the resource needs to remain open after the method returns,
so I intend to not fix that. Really, any use of that class should be wrapped in
a finally and IT should get closed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-15890) Allow thrift to set/unset "cacheBlocks" for Scans
Ashu Pachauri created HBASE-15890: - Summary: Allow thrift to set/unset "cacheBlocks" for Scans Key: HBASE-15890 URL: https://issues.apache.org/jira/browse/HBASE-15890 Project: HBase Issue Type: Improvement Components: Thrift Reporter: Ashu Pachauri Fix For: 2.0.0, 1.3.0 Long running scans going through thrift cache everything to the block cache. We need the ability to disable caching for scans going through thrift. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (HBASE-15855) TestSplitTransactionOnCluster#testFailedSplit may fail due to pending dead server processing
[
https://issues.apache.org/jira/browse/HBASE-15855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu resolved HBASE-15855.
Resolution: Duplicate
Dup of HBASE-14883
> TestSplitTransactionOnCluster#testFailedSplit may fail due to pending dead
> server processing
>
>
> Key: HBASE-15855
> URL: https://issues.apache.org/jira/browse/HBASE-15855
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Fix For: 1.4.0
>
> Attachments: 15855-branch-1.v1.patch, HBASE-15855.branch-1.patch,
> testFailedSplit.err
>
>
> Sometimes TestSplitTransactionOnCluster#testFailedSplit fails with:
> {code}
> java.lang.AssertionError: null
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at
> org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster.testFailedSplit(TestSplitTransactionOnCluster.java:1339)
> {code}
> Here was the reason:
> {code}
> 2016-05-12 14:38:31,022 INFO
> [RS:5;c66-slave-20176e25-5:40721-splits-1463063900610]
> regionserver.SplitRequest(143): Split transaction journal:
> STARTED at 1463063910621
> PREPARED at 1463063910628
> BEFORE_PRE_SPLIT_HOOK at 1463063910628
> AFTER_PRE_SPLIT_HOOK at 1463063910628
> SET_SPLITTING at 1463063910632
> CREATE_SPLIT_DIR at 1463063910743
> CLOSED_PARENT_REGION at 1463063910768
> OFFLINED_PARENT at 1463063910768
> STARTED_REGION_A_CREATION at 1463063910839
> STARTED_REGION_B_CREATION at 1463063910889
> 2016-05-12 14:38:31,023 DEBUG [Thread-1689-EventThread]
> zookeeper.ZooKeeperWatcher(511): hbase-admin-on-hconnection-0x9755dd10x0,
> quorum=localhost:49482, baseZNode=/hbase Received ZooKeeper Event, type=None,
> state=SyncConnected, path=null
> 2016-05-12 14:38:31,025 DEBUG [Thread-1689-EventThread]
> zookeeper.ZooKeeperWatcher(574):
> hbase-admin-on-hconnection-0x9755dd1-0x154a566b247001f connected
> 2016-05-12 14:38:31,052 DEBUG
> [B.defaultRpcServer.handler=3,queue=0,port=54033] master.HMaster(1373): Not
> running balancer because processing dead regionserver(s):
> c66-slave-20176e25-5.novalocal,49562,1463063863793
> 2016-05-12 14:38:31,054 INFO [Thread-1689]
> client.ConnectionManager$HConnectionImplementation(1684): Closing zookeeper
> sessionid=0x154a566b247001c
> {code}
> We should account for dead server processing before making the assertion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14140) HBase Backup/Restore Phase 3: Enhance HBaseAdmin API to include backup/restore - related API
[ https://issues.apache.org/jira/browse/HBASE-14140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov updated HBASE-14140: -- Attachment: HBASE-14140-v13.patch one more fix for UT > HBase Backup/Restore Phase 3: Enhance HBaseAdmin API to include > backup/restore - related API > > > Key: HBASE-14140 > URL: https://issues.apache.org/jira/browse/HBASE-14140 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Attachments: HBASE-14140-v1.patch, HBASE-14140-v10.patch, > HBASE-14140-v11.patch, HBASE-14140-v12.patch, HBASE-14140-v13.patch, > HBASE-14140-v4.patch, HBASE-14140-v7.patch, HBASE-14140-v9.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15880) RpcClientImpl#tracedWriteRequest incorrectly closes HTrace span
[
https://issues.apache.org/jira/browse/HBASE-15880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Antonov updated HBASE-15880:
Affects Version/s: 1.1.5
> RpcClientImpl#tracedWriteRequest incorrectly closes HTrace span
> ---
>
> Key: HBASE-15880
> URL: https://issues.apache.org/jira/browse/HBASE-15880
> Project: HBase
> Issue Type: Bug
> Components: tracing
>Affects Versions: 1.3.0, 1.2.1, 1.1.5
>Reporter: Mikhail Antonov
>Assignee: Mikhail Antonov
> Fix For: 1.3.0, 1.2.2, 1.1.6
>
> Attachments: HBASE-15880-branch-1.3.v1.patch
>
>
> In this method we continue the span and then close it, which causes the
> current span (the one created by client app around HTabl#get() or similar API
> call) to be closed incorrectly.
> {code}
> TraceScope ts = Trace.continueSpan(span);
> try {
> writeRequest(call, priority, span);
> } finally {
> ts.close();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15880) RpcClientImpl#tracedWriteRequest incorrectly closes HTrace span
[
https://issues.apache.org/jira/browse/HBASE-15880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Antonov updated HBASE-15880:
Fix Version/s: 1.1.6
1.2.2
> RpcClientImpl#tracedWriteRequest incorrectly closes HTrace span
> ---
>
> Key: HBASE-15880
> URL: https://issues.apache.org/jira/browse/HBASE-15880
> Project: HBase
> Issue Type: Bug
> Components: tracing
>Affects Versions: 1.3.0, 1.2.1, 1.1.5
>Reporter: Mikhail Antonov
>Assignee: Mikhail Antonov
> Fix For: 1.3.0, 1.2.2, 1.1.6
>
> Attachments: HBASE-15880-branch-1.3.v1.patch
>
>
> In this method we continue the span and then close it, which causes the
> current span (the one created by client app around HTabl#get() or similar API
> call) to be closed incorrectly.
> {code}
> TraceScope ts = Trace.continueSpan(span);
> try {
> writeRequest(call, priority, span);
> } finally {
> ts.close();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15889) String case conversions are locale-sensitive, used without locale
[
https://issues.apache.org/jira/browse/HBASE-15889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300560#comment-15300560
]
Sean Mackrory commented on HBASE-15889:
---
[~busbey] I'd love to - running through unit tests with it right now,
actually...
I actually started using Locale.ENGLISH as that's gotten recommended in several
places as a locale with well-defined / correct behavior in the common charsets
used in programming (e.g.
https://issues.apache.org/jira/browse/FILEUPLOAD-229). But Locale.ROOT sounds
good to me, too, and the docs actually call it out as the neutral locale for
this purpose, so I'm good with that too.
> String case conversions are locale-sensitive, used without locale
> -
>
> Key: HBASE-15889
> URL: https://issues.apache.org/jira/browse/HBASE-15889
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Sean Mackrory
>Priority: Minor
>
> Static code analysis is flagging cases of String.toLowerCase and
> String.toUpperCase being used without Locale. From the API reference:
> {quote}
> Note: This method is locale sensitive, and may produce unexpected results if
> used for strings that are intended to be interpreted locale independently.
> Examples are programming language identifiers, protocol keys, and HTML tags.
> For instance, "TITLE".toLowerCase() in a Turkish locale returns "t\u0131tle",
> where '\u0131' is the LATIN SMALL LETTER DOTLESS I character. To obtain
> correct results for locale insensitive strings, use toLowerCase(Locale.ROOT).
> {quote}
> Many uses of these functions do appear to be looking up classes, etc. and not
> dealing with stored data, so I'd think there aren't significant compatibility
> problems here and specifying the locale is indeed the safer way to go.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15698) Increment TimeRange not serialized to server
[ https://issues.apache.org/jira/browse/HBASE-15698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-15698: Fix Version/s: 1.1.6 1.0.4 > Increment TimeRange not serialized to server > > > Key: HBASE-15698 > URL: https://issues.apache.org/jira/browse/HBASE-15698 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.3.0 >Reporter: James Taylor >Assignee: Sean Busbey >Priority: Blocker > Labels: phoenix > Fix For: 1.3.0, 1.0.4, 1.2.2, 0.98.20, 1.1.6 > > Attachments: HBASE-15698.1.patch > > > Before HBase-1.2, the Increment TimeRange set on the client was serialized > over to the server. As of HBase 1.2, this appears to no longer be true, as my > preIncrement coprocessor always gets HConstants.LATEST_TIMESTAMP as the value > of increment.getTimeRange().getMax() regardless of what the client has > specified. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15698) Increment TimeRange not serialized to server
[ https://issues.apache.org/jira/browse/HBASE-15698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-15698: --- Fix Version/s: 0.98.20 > Increment TimeRange not serialized to server > > > Key: HBASE-15698 > URL: https://issues.apache.org/jira/browse/HBASE-15698 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.3.0 >Reporter: James Taylor >Assignee: Sean Busbey >Priority: Blocker > Labels: phoenix > Fix For: 1.3.0, 1.2.2, 0.98.20 > > Attachments: HBASE-15698.1.patch > > > Before HBase-1.2, the Increment TimeRange set on the client was serialized > over to the server. As of HBase 1.2, this appears to no longer be true, as my > preIncrement coprocessor always gets HConstants.LATEST_TIMESTAMP as the value > of increment.getTimeRange().getMax() regardless of what the client has > specified. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14921) Memory optimizations
[ https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300446#comment-15300446 ] Anastasia Braginsky commented on HBASE-14921: - [~yuzhih...@gmail.com], I'll rebase once I get back to my office. > Memory optimizations > > > Key: HBASE-14921 > URL: https://issues.apache.org/jira/browse/HBASE-14921 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0 >Reporter: Eshcar Hillel >Assignee: Anastasia Braginsky > Attachments: CellBlocksSegmentInMemStore.pdf, > CellBlocksSegmentinthecontextofMemStore(1).pdf, HBASE-14921-V01.patch, > HBASE-14921-V02.patch, HBASE-14921-V03.patch, > IntroductiontoNewFlatandCompactMemStore.pdf > > > Memory optimizations including compressed format representation and offheap > allocations -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15889) String case conversions are locale-sensitive, used without locale
[
https://issues.apache.org/jira/browse/HBASE-15889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300428#comment-15300428
]
Sean Busbey commented on HBASE-15889:
-
anyone have opinions on using something other than Locale.ROOT?
[~mackrorysd], any interest in putting together a patch?
> String case conversions are locale-sensitive, used without locale
> -
>
> Key: HBASE-15889
> URL: https://issues.apache.org/jira/browse/HBASE-15889
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Sean Mackrory
>Priority: Minor
>
> Static code analysis is flagging cases of String.toLowerCase and
> String.toUpperCase being used without Locale. From the API reference:
> {quote}
> Note: This method is locale sensitive, and may produce unexpected results if
> used for strings that are intended to be interpreted locale independently.
> Examples are programming language identifiers, protocol keys, and HTML tags.
> For instance, "TITLE".toLowerCase() in a Turkish locale returns "t\u0131tle",
> where '\u0131' is the LATIN SMALL LETTER DOTLESS I character. To obtain
> correct results for locale insensitive strings, use toLowerCase(Locale.ROOT).
> {quote}
> Many uses of these functions do appear to be looking up classes, etc. and not
> dealing with stored data, so I'd think there aren't significant compatibility
> problems here and specifying the locale is indeed the safer way to go.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15884) NPE in StoreFileScanner#skipKVsNewerThanReadpoint during reverse scan
[
https://issues.apache.org/jira/browse/HBASE-15884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300277#comment-15300277
]
Ted Yu commented on HBASE-15884:
Alright.
+1
> NPE in StoreFileScanner#skipKVsNewerThanReadpoint during reverse scan
> -
>
> Key: HBASE-15884
> URL: https://issues.apache.org/jira/browse/HBASE-15884
> Project: HBase
> Issue Type: Bug
> Components: Scanners
>Affects Versions: 2.0.0, 1.2.1
>Reporter: Sergey Soldatov
>Assignee: Sergey Soldatov
> Attachments: HBASE-15884-1.patch
>
>
> Here is a part of {{skipKVsNewerThanReadpoint}} method:
> {noformat}
> hfs.next();
> setCurrentCell(hfs.getKeyValue());
> if (this.stopSkippingKVsIfNextRow
> && getComparator().compareRows(cur.getRowArray(),
> cur.getRowOffset(),
> cur.getRowLength(), startKV.getRowArray(),
> startKV.getRowOffset(),
> startKV.getRowLength()) > 0) {
> {noformat}
> If hfs has no more KVs, cur will be set to Null and on on the next step will
> throw NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-15889) String case conversions are locale-sensitive, used without locale
Sean Mackrory created HBASE-15889:
-
Summary: String case conversions are locale-sensitive, used
without locale
Key: HBASE-15889
URL: https://issues.apache.org/jira/browse/HBASE-15889
Project: HBase
Issue Type: Bug
Affects Versions: 1.2.0
Reporter: Sean Mackrory
Priority: Minor
Static code analysis is flagging cases of String.toLowerCase and
String.toUpperCase being used without Locale. From the API reference:
{quote}
Note: This method is locale sensitive, and may produce unexpected results if
used for strings that are intended to be interpreted locale independently.
Examples are programming language identifiers, protocol keys, and HTML tags.
For instance, "TITLE".toLowerCase() in a Turkish locale returns "t\u0131tle",
where '\u0131' is the LATIN SMALL LETTER DOTLESS I character. To obtain correct
results for locale insensitive strings, use toLowerCase(Locale.ROOT).
{quote}
Many uses of these functions do appear to be looking up classes, etc. and not
dealing with stored data, so I'd think there aren't significant compatibility
problems here and specifying the locale is indeed the safer way to go.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-15888) Extend HBASE-12769 for bulk load data replication
Ashish Singhi created HBASE-15888: - Summary: Extend HBASE-12769 for bulk load data replication Key: HBASE-15888 URL: https://issues.apache.org/jira/browse/HBASE-15888 Project: HBase Issue Type: Task Components: Replication Affects Versions: 1.3.0 Reporter: Ashish Singhi Assignee: Ashish Singhi Include hfile-refs queue check and fix also in hbck -fixReplication command -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15885) Compute StoreFile HDFS Blocks Distribution when needed
[ https://issues.apache.org/jira/browse/HBASE-15885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299785#comment-15299785 ] Guanghao Zhang commented on HBASE-15885: I thought it just waste some time to getHDFSBlockDistribution when there are multi thread compute HDFS Blocks Distribution simultaneously. It only happens in the first time to compute hdfs blocks distribution. > Compute StoreFile HDFS Blocks Distribution when needed > -- > > Key: HBASE-15885 > URL: https://issues.apache.org/jira/browse/HBASE-15885 > Project: HBase > Issue Type: Improvement > Components: HFile >Affects Versions: 2.0.0 >Reporter: Guanghao Zhang > Attachments: HBASE-15885.patch > > > Now when open a StoreFileReader, it always need to compute HDFS blocks > distribution. But when balance a region, it will increase the region not > serving time. Because it need first close region on rs A, then open it on rs > B. When close region, it first preFlush, then flush the new update to a new > store file. The new store file will first be flushed to tmp directory, then > move it to column family directory. These need open StoreFileReader twice > which means it need compute HDFS blocks distribution twice. When open region > on rs B, it need open StoreFileReader and compute HDFS blocks distribution > too. So when balance a region, it need compute HDFS blocks distribution three > times for per new store file. This will increase the region not serving time > and we don't need compute HDFS blocks distribution when close a region. > The related three methods in HStore. > 1. validateStoreFile(...) > 2. commitFile(...) > 3. openStoreFiles(...) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11045) Replace deprecated method FileSystem#createNonRecursive
[
https://issues.apache.org/jira/browse/HBASE-11045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299781#comment-15299781
]
Steve Loughran commented on HBASE-11045:
BTW, given that HDFS has un-deprecated {{createNonRecursive()}}, what about
closing this as a WONTFIX?
> Replace deprecated method FileSystem#createNonRecursive
> ---
>
> Key: HBASE-11045
> URL: https://issues.apache.org/jira/browse/HBASE-11045
> Project: HBase
> Issue Type: Task
>Reporter: Gustavo Anatoly
>Assignee: Gustavo Anatoly
>Priority: Minor
> Fix For: 2.0.0
>
>
> This change affect directly ProtobufLogWriter#init() associated to
> TestHLog#testFailedToCreateHLogIfParentRenamed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11045) Replace deprecated method FileSystem#createNonRecursive
[ https://issues.apache.org/jira/browse/HBASE-11045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299778#comment-15299778 ] Steve Loughran commented on HBASE-11045: you *cannot* use swift instead of HDFS. It isn't a real filesystem and things will fail dramatically —even if this method was implemented, there are too many other differences. The fact that your attempt is failing this early on, while frustrating, stops you getting deeper into trouble. Sorry. Note that you can't use S3 either, same problem. see: [Object stores vs filesystems](http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/filesystem/introduction.html). > Replace deprecated method FileSystem#createNonRecursive > --- > > Key: HBASE-11045 > URL: https://issues.apache.org/jira/browse/HBASE-11045 > Project: HBase > Issue Type: Task >Reporter: Gustavo Anatoly >Assignee: Gustavo Anatoly >Priority: Minor > Fix For: 2.0.0 > > > This change affect directly ProtobufLogWriter#init() associated to > TestHLog#testFailedToCreateHLogIfParentRenamed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15885) Compute StoreFile HDFS Blocks Distribution when needed
[
https://issues.apache.org/jira/browse/HBASE-15885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299689#comment-15299689
]
Heng Chen commented on HBASE-15885:
---
getHDFSBlockDistribution would be called in compaction. Is there any thread
conflicts problem for {{hdfsBlocksDistribution}}?
> Compute StoreFile HDFS Blocks Distribution when needed
> --
>
> Key: HBASE-15885
> URL: https://issues.apache.org/jira/browse/HBASE-15885
> Project: HBase
> Issue Type: Improvement
> Components: HFile
>Affects Versions: 2.0.0
>Reporter: Guanghao Zhang
> Attachments: HBASE-15885.patch
>
>
> Now when open a StoreFileReader, it always need to compute HDFS blocks
> distribution. But when balance a region, it will increase the region not
> serving time. Because it need first close region on rs A, then open it on rs
> B. When close region, it first preFlush, then flush the new update to a new
> store file. The new store file will first be flushed to tmp directory, then
> move it to column family directory. These need open StoreFileReader twice
> which means it need compute HDFS blocks distribution twice. When open region
> on rs B, it need open StoreFileReader and compute HDFS blocks distribution
> too. So when balance a region, it need compute HDFS blocks distribution three
> times for per new store file. This will increase the region not serving time
> and we don't need compute HDFS blocks distribution when close a region.
> The related three methods in HStore.
> 1. validateStoreFile(...)
> 2. commitFile(...)
> 3. openStoreFiles(...)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11045) Replace deprecated method FileSystem#createNonRecursive
[ https://issues.apache.org/jira/browse/HBASE-11045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299605#comment-15299605 ] RyanTotti commented on HBASE-11045: --- I use Swift instead of HDFS as storage for HBase,HBase RegionServer can not start. HBase use the deprecated method createNonRecursive() in org.apache.hadoop.hbase.regionserver.wal.ProtobufLogWriter.init(). > Replace deprecated method FileSystem#createNonRecursive > --- > > Key: HBASE-11045 > URL: https://issues.apache.org/jira/browse/HBASE-11045 > Project: HBase > Issue Type: Task >Reporter: Gustavo Anatoly >Assignee: Gustavo Anatoly >Priority: Minor > Fix For: 2.0.0 > > > This change affect directly ProtobufLogWriter#init() associated to > TestHLog#testFailedToCreateHLogIfParentRenamed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
