[jira] [Commented] (HBASE-16793) Exclude shaded protobuf files from rat check
[ https://issues.apache.org/jira/browse/HBASE-16793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561442#comment-15561442 ] Duo Zhang commented on HBASE-16793: --- {code:title=hbase-assembly/src/main/assembly/src.xml} org.apache.hbase:hbase-annotations org.apache.hbase:hbase-assembly org.apache.hbase:hbase-checkstyle org.apache.hbase:hbase-client org.apache.hbase:hbase-common org.apache.hbase:hbase-examples org.apache.hbase:hbase-external-blockcache org.apache.hbase:hbase-hadoop2-compat org.apache.hbase:hbase-hadoop-compat org.apache.hbase:hbase-it org.apache.hbase:hbase-prefix-tree org.apache.hbase:hbase-procedure org.apache.hbase:hbase-protocol org.apache.hbase:hbase-rest org.apache.hbase:hbase-resource-bundle org.apache.hbase:hbase-rsgroup org.apache.hbase:hbase-server org.apache.hbase:hbase-shaded org.apache.hbase:hbase-shell org.apache.hbase:hbase-spark org.apache.hbase:hbase-testing-util org.apache.hbase:hbase-thrift {code} This is part of our config file to generate src tarball. > Exclude shaded protobuf files from rat check > > > Key: HBASE-16793 > URL: https://issues.apache.org/jira/browse/HBASE-16793 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-16793.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16793) Exclude shaded protobuf files from rat check
[ https://issues.apache.org/jira/browse/HBASE-16793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561429#comment-15561429 ] Duo Zhang commented on HBASE-16793: --- No, there is no hbase-protocol-shaded directly in the src tarball. > Exclude shaded protobuf files from rat check > > > Key: HBASE-16793 > URL: https://issues.apache.org/jira/browse/HBASE-16793 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-16793.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16748) Release 1.2.4
[ https://issues.apache.org/jira/browse/HBASE-16748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561413#comment-15561413 ] Hudson commented on HBASE-16748: SUCCESS: Integrated in Jenkins build HBase-1.2-JDK7 #42 (See [https://builds.apache.org/job/HBase-1.2-JDK7/42/]) HBASE-16748 update CHANGES.txt for additional changes for RC0. (busbey: rev 04bd0ec8e4cb2f39e5f787126f9b6645dabf27df) * (edit) CHANGES.txt > Release 1.2.4 > - > > Key: HBASE-16748 > URL: https://issues.apache.org/jira/browse/HBASE-16748 > Project: HBase > Issue Type: Task >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 1.2.4 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16793) Exclude shaded protobuf files from rat check
[ https://issues.apache.org/jira/browse/HBASE-16793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561390#comment-15561390 ] Duo Zhang commented on HBASE-16793: --- I do not know. The shaded PB src files are in the git repo. Let me check if we will pack them into the src tarball... > Exclude shaded protobuf files from rat check > > > Key: HBASE-16793 > URL: https://issues.apache.org/jira/browse/HBASE-16793 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-16793.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16793) Exclude shaded protobuf files from rat check
[ https://issues.apache.org/jira/browse/HBASE-16793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561371#comment-15561371 ] Anoop Sam John commented on HBASE-16793: We include the shaded PB src files in our src tar? > Exclude shaded protobuf files from rat check > > > Key: HBASE-16793 > URL: https://issues.apache.org/jira/browse/HBASE-16793 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-16793.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16796) Correct RpcServer responseSize and requestSize to account for cellScanner payload
[ https://issues.apache.org/jira/browse/HBASE-16796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561364#comment-15561364 ] Anoop Sam John commented on HBASE-16796: responseSize not accounting CellScanner, I think I have seen this bug being raised some time back. I was thinking it is resolved by now. Not? Ya we have to correct it. > Correct RpcServer responseSize and requestSize to account for cellScanner > payload > - > > Key: HBASE-16796 > URL: https://issues.apache.org/jira/browse/HBASE-16796 > Project: HBase > Issue Type: Bug >Reporter: Jerry He >Assignee: Jerry He > > The reponseSize and requestSize on the RpcServer don't seem to account for > the cellScanner payload. We should correct them. > The metrics numbers and the logging for reponseTooLarge and TooSlow won't > show up correctly otherwise. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16771) VerifyReplication should increase GOODROWS counter if re-comparison passes
[ https://issues.apache.org/jira/browse/HBASE-16771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561363#comment-15561363 ] Hudson commented on HBASE-16771: FAILURE: Integrated in Jenkins build HBase-1.4 #455 (See [https://builds.apache.org/job/HBase-1.4/455/]) HBASE-16771 VerifyReplication should increase GOODROWS counter if (tedyu: rev 364a57a9500b942163932e2c644c05bff3e55090) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java > VerifyReplication should increase GOODROWS counter if re-comparison passes > -- > > Key: HBASE-16771 > URL: https://issues.apache.org/jira/browse/HBASE-16771 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 2.0.0, 1.4.0 > > Attachments: 16771.v1.txt, 16771.v2.txt, 16771.v3.txt > > > HBASE-16423 added re-comparison feature to reduce false positive rate. > However, before logFailRowAndIncreaseCounter() is called, GOODROWS counter is > not incremented. Neither is GOODROWS incremented when re-comparison passes. > This may produce inconsistent results across multiple runs of the same > verifyrep command. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561351#comment-15561351 ] Phil Yang commented on HBASE-16664: --- upload patch to https://reviews.apache.org/r/52674/ > Timeout logic in AsyncProcess is broken > --- > > Key: HBASE-16664 > URL: https://issues.apache.org/jira/browse/HBASE-16664 > Project: HBase > Issue Type: Bug >Reporter: Phil Yang >Assignee: Phil Yang > Attachments: 1.patch, HBASE-16664-branch-1-v1.patch, > HBASE-16664-v1.patch, HBASE-16664-v2.patch, HBASE-16664-v3.patch, > HBASE-16664-v4.patch, testhcm.patch > > > Have not checked the root cause, but I think timeout of all operations in > AsyncProcess is broken -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16701) TestHRegion and TestHRegionWithInMemoryFlush timing out
[ https://issues.apache.org/jira/browse/HBASE-16701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-16701: Fix Version/s: 1.1.8 1.2.5 1.4.0 1.3.0 2.0.0 > TestHRegion and TestHRegionWithInMemoryFlush timing out > --- > > Key: HBASE-16701 > URL: https://issues.apache.org/jira/browse/HBASE-16701 > Project: HBase > Issue Type: Bug > Components: regionserver, test >Reporter: Appy >Assignee: Sean Busbey > Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.5, 1.1.8 > > Attachments: HBASE-16701.1.patch > > > These two tests are marked LargeTests and thus have a timeout of 10 minutes, > but it's not sufficient since they have like more than 100 testcases. > Ideal fix would be splitting the tests, but that'll be much more involved > effort. > For now, increasing the timeout to 15min. > Current stats: > On apache infra: > TestHRegionWithInMemoryFlush 20.0% (15 / 75) 15 / 12 / 0 > TestHRegion 9.3% (7 / 75) 7 / 5 / 0 > On GCE infra: > TestHRegion 89.7% (87 / 97) 87 / 87 / 0 > TestHRegionWithInMemoryFlush 71.1% (69 / 97) 69 / 69 / 0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16701) TestHRegion and TestHRegionWithInMemoryFlush timing out
[ https://issues.apache.org/jira/browse/HBASE-16701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-16701: Status: In Progress (was: Patch Available) pushed the change. will check out the flakey job later this week. > TestHRegion and TestHRegionWithInMemoryFlush timing out > --- > > Key: HBASE-16701 > URL: https://issues.apache.org/jira/browse/HBASE-16701 > Project: HBase > Issue Type: Bug > Components: regionserver, test >Reporter: Appy >Assignee: Sean Busbey > Attachments: HBASE-16701.1.patch > > > These two tests are marked LargeTests and thus have a timeout of 10 minutes, > but it's not sufficient since they have like more than 100 testcases. > Ideal fix would be splitting the tests, but that'll be much more involved > effort. > For now, increasing the timeout to 15min. > Current stats: > On apache infra: > TestHRegionWithInMemoryFlush 20.0% (15 / 75) 15 / 12 / 0 > TestHRegion 9.3% (7 / 75) 7 / 5 / 0 > On GCE infra: > TestHRegion 89.7% (87 / 97) 87 / 87 / 0 > TestHRegionWithInMemoryFlush 71.1% (69 / 97) 69 / 69 / 0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15109) HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true
[ https://issues.apache.org/jira/browse/HBASE-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561330#comment-15561330 ] Pankaj Kumar commented on HBASE-15109: -- Test case failures are not relevant. Those failed because of "java.lang.OutOfMemoryError: Java heap space". I observed OOM is happening frequently in many QA run. > HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true > -- > > Key: HBASE-15109 > URL: https://issues.apache.org/jira/browse/HBASE-15109 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 2.0.0 >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Critical > Attachments: HBASE-15109-V2.patch, HBASE-15109-branch-1.patch, > HBASE-15109.patch, HBASE-15109.patch > > > HMaster failed to start during installing ShutdownHook when > "fs.hdfs.impl.disable.cache" is set to true. > {noformat} > 2016-10-10 10:33:28,367 FATAL [master/HOST-10-18-106-146/10.18.106.146:16000] > master.HMaster: Unhandled: Failed suppression of fs shutdown hook: > org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@19a003b4 > java.lang.RuntimeException: Failed suppression of fs shutdown hook: > org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@19a003b4 > at > org.apache.hadoop.hbase.regionserver.ShutdownHook.suppressHdfsShutdownHook(ShutdownHook.java:204) > at > org.apache.hadoop.hbase.regionserver.ShutdownHook.install(ShutdownHook.java:84) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:950) > at java.lang.Thread.run(Thread.java:745) > {noformat} > And RegionServer is in blocking state until a master is available, > {noformat} > "regionserver/HOST-10-18-106-146/10.18.106.146:16020" #17 prio=5 os_prio=0 > tid=0x00e4e800 nid=0xdc38 in Object.wait() [0x7f329dac6000] >java.lang.Thread.State: TIMED_WAITING (on object monitor) > at java.lang.Object.wait(Native Method) > at > org.apache.hadoop.hbase.zookeeper.ZooKeeperNodeTracker.blockUntilAvailable(ZooKeeperNodeTracker.java:159) > - locked <0xae25c0c8> (a > org.apache.hadoop.hbase.zookeeper.MasterAddressTracker) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.blockAndCheckIfStopped(HRegionServer.java:870) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.initializeZooKeeper(HRegionServer.java:809) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:783) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:943) > at java.lang.Thread.run(Thread.java:745) > {noformat} > During installation, first time it will try to suppress the HDFS shutdownhook > by removing the hdfsclientfinalizer from HDFS. Since > fs.hdfs.impl.disable.cache is enabled, so removal will be unsuccessful from > HDFS (FS is not cached) and RuntimeException will be thrown with "Failed > suppression of fs shutdown hook" message. > In ShutdownHook, > {code} > if (!fsShutdownHooks.containsKey(hdfsClientFinalizer) && > !ShutdownHookManager.deleteShutdownHook(hdfsClientFinalizer)) { > throw new RuntimeException("Failed suppression of fs shutdown hook: " + > hdfsClientFinalizer); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16748) Release 1.2.4
[ https://issues.apache.org/jira/browse/HBASE-16748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561325#comment-15561325 ] Hudson commented on HBASE-16748: SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #37 (See [https://builds.apache.org/job/HBase-1.2-JDK8/37/]) HBASE-16748 update CHANGES.txt for additional changes for RC0. (busbey: rev 04bd0ec8e4cb2f39e5f787126f9b6645dabf27df) * (edit) CHANGES.txt > Release 1.2.4 > - > > Key: HBASE-16748 > URL: https://issues.apache.org/jira/browse/HBASE-16748 > Project: HBase > Issue Type: Task >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 1.2.4 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15109) HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true
[ https://issues.apache.org/jira/browse/HBASE-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561319#comment-15561319 ] Hadoop QA commented on HBASE-15109: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s {color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 34s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 38s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 51s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 15s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 55s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 30s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 49s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 40s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 40s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 49s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 16s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 28m 50s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 13s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 1s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 82m 18s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 124m 57s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Timed out junit tests | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestMasterProcedureSchedulerConcurrency | | | org.apache.hadoop.hbase.master.procedure.TestMasterProcedureEvents | | | org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure | | | org.apache.hadoop.hbase.master.procedure.TestCloneSnapshotProcedure | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12832399/HBASE-15109-V2.patch | | JIRA Issue | HBASE-15109 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 88a36216dfc4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh | | git revision | master / 8a8c608 | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/3913/artifact/patchprocess/patch-unit-hbase-server.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/3913/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Resul
[jira] [Commented] (HBASE-16744) Procedure V2 - Lock procedures to allow clients to acquire locks on tables/namespaces/regions
[ https://issues.apache.org/jira/browse/HBASE-16744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561296#comment-15561296 ] Hadoop QA commented on HBASE-16744: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m 21s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 4 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 38s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 49s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 5s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 15m 2s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 56s {color} | {color:green} master passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 13s {color} | {color:red} hbase-protocol-shaded in master has 22 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 31s {color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 27s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 7s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m 7s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 7s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 15m 10s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 48s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s {color} | {color:red} The patch has 44 line(s) that end in whitespace. Use git apply --whitespace=fix. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 34m 47s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 2s {color} | {color:red} hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 20s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 31s {color} | {color:green} hbase-protocol-shaded in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 5s {color} | {color:red} hbase-client in the patch failed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 16m 46s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 22s {color} | {color:green} hbase-rsgroup in the patch passed. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 49s {color} | {color:red} The patch generated 140 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 117m 28s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hbase-server | | | Monitor wait() called on a Condition in org.apache.hadoop.hbase.master.LockManager$MasterLock.tryAcquire(long) At LockManager.java:Condition in org.apache.hadoop.hbase.master.LockManager$MasterLock.tryAcquire(long) At LockManager.java:[line 121] | | | Calling wait rather than await in org.apache.hadoop.hbase.master.LockManager$MasterLock.tryAcquire(long) At LockManager.java:in org.apache.hadoop.hbase.master.LockManager$MasterLock.tryAcquire(long) At LockManager.java:[line 121] | | Failed junit tests | hadoop.hbase.TestInterfaceAudienceAnnotations | | | hadoop.hbase.TestCheckTestClasses | \\ \\ || Subsystem || Report/Notes ||
[jira] [Resolved] (HBASE-16718) TestMobFlushSnapshotFromClient,TestFlushSnapshotFromClient, TestRestoreFlushSnapshotFromClient are failing in QA builds
[ https://issues.apache.org/jira/browse/HBASE-16718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingcheng Du resolved HBASE-16718. -- Resolution: Duplicate > TestMobFlushSnapshotFromClient,TestFlushSnapshotFromClient, > TestRestoreFlushSnapshotFromClient are failing in QA builds > --- > > Key: HBASE-16718 > URL: https://issues.apache.org/jira/browse/HBASE-16718 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan > Fix For: 2.0.0 > > > We could see failures in QA builds frequently with the test cases mentioned > in the title of the JIRA. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16666) Add append and remove peer namespaces cmds for replication
[ https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561290#comment-15561290 ] Guanghao Zhang commented on HBASE-1: HBASE-16447 was not merged to branch-1. So this can't merged to branch-1, too. > Add append and remove peer namespaces cmds for replication > -- > > Key: HBASE-1 > URL: https://issues.apache.org/jira/browse/HBASE-1 > Project: HBase > Issue Type: Improvement > Components: Replication >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Minor > Attachments: HBASE-1-v1.patch, HBASE-1-v2.patch, > HBASE-1.patch > > > After HBASE-16447, we support replication by namespaces config in peer. Like > append_peer_tableCFs and remove_peer_tableCFs, I thought we need two new > shell cmd: append_peer_namespaces and remove_peer_namespaces. Then we can > easily change the namespaces config. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16744) Procedure V2 - Lock procedures to allow clients to acquire locks on tables/namespaces/regions
[ https://issues.apache.org/jira/browse/HBASE-16744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561255#comment-15561255 ] Hadoop QA commented on HBASE-16744: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 4 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 16s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 6s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 28s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 14m 2s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 41s {color} | {color:green} master passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 57s {color} | {color:red} hbase-protocol-shaded in master has 22 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 12s {color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 57s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 43s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m 43s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 43s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 14m 35s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 44s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s {color} | {color:red} The patch has 44 line(s) that end in whitespace. Use git apply --whitespace=fix. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 29m 2s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 19s {color} | {color:red} hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 12s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 32s {color} | {color:green} hbase-protocol-shaded in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 4s {color} | {color:red} hbase-client in the patch failed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 15m 34s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 22s {color} | {color:green} hbase-rsgroup in the patch passed. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 40s {color} | {color:red} The patch generated 140 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 101m 26s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hbase-server | | | Monitor wait() called on a Condition in org.apache.hadoop.hbase.master.LockManager$MasterLock.tryAcquire(long) At LockManager.java:Condition in org.apache.hadoop.hbase.master.LockManager$MasterLock.tryAcquire(long) At LockManager.java:[line 121] | | | Calling wait rather than await in org.apache.hadoop.hbase.master.LockManager$MasterLock.tryAcquire(long) At LockManager.java:in org.apache.hadoop.hbase.master.LockManager$MasterLock.tryAcquire(long) At LockManager.java:[line 121] | | Failed junit tests | hadoop.hbase.TestInterfaceAudienceAnnotations | | | hadoop.hbase.TestCheckTestClasses | \\ \\ || Subsystem || Report/Notes |
[jira] [Commented] (HBASE-16771) VerifyReplication should increase GOODROWS counter if re-comparison passes
[ https://issues.apache.org/jira/browse/HBASE-16771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561252#comment-15561252 ] Hadoop QA commented on HBASE-16771: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s {color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 1s {color} | {color:blue} The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.3.0/precommit-patchnames for instructions. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s {color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m 10s {color} | {color:red} root in master failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 43s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 12s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 38s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 43s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 32s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 44s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 12s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 26m 14s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 12s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 49s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 83m 17s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 119m 31s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Timed out junit tests | org.apache.hadoop.hbase.TestMultiVersions | | | org.apache.hadoop.hbase.mob.TestMobDataBlockEncoding | | | org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12832390/16771.v3.txt | | JIRA Issue | HBASE-16771 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 6b286009854b 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 8a8c608 | | Default Java | 1.8.0_101 | | mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/3908/artifact/patchprocess/branch-mvninstall-root.txt | | findbugs | v3.0.0 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/3908/artifact/patchprocess/patch-unit
[jira] [Commented] (HBASE-16666) Add append and remove peer namespaces cmds for replication
[ https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561230#comment-15561230 ] Ted Yu commented on HBASE-1: Mind attaching patch for branch-1 ? Thanks > Add append and remove peer namespaces cmds for replication > -- > > Key: HBASE-1 > URL: https://issues.apache.org/jira/browse/HBASE-1 > Project: HBase > Issue Type: Improvement > Components: Replication >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Minor > Attachments: HBASE-1-v1.patch, HBASE-1-v2.patch, > HBASE-1.patch > > > After HBASE-16447, we support replication by namespaces config in peer. Like > append_peer_tableCFs and remove_peer_tableCFs, I thought we need two new > shell cmd: append_peer_namespaces and remove_peer_namespaces. Then we can > easily change the namespaces config. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16666) Add append and remove peer namespaces cmds for replication
[ https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561208#comment-15561208 ] Hadoop QA commented on HBASE-1: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m 0s {color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 5s {color} | {color:blue} rubocop was not available. {color} | | {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 5s {color} | {color:blue} Ruby-lint was not available. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 31s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 23s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 15s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 17s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 38m 32s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 16s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m 14s {color} | {color:green} hbase-shell in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 11s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 60m 22s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.12.1 Server=1.12.1 Image:yetus/hbase:7bda515 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12832395/HBASE-1-v2.patch | | JIRA Issue | HBASE-1 | | Optional Tests | asflicense javac javadoc unit rubocop ruby_lint | | uname | Linux 0ad5af9815cd 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 8a8c608 | | Default Java | 1.8.0_101 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/3911/testReport/ | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/3911/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Add append and remove peer namespaces cmds for replication > -- > > Key: HBASE-1 > URL: https://issues.apache.org/jira/browse/HBASE-1 > Project: HBase > Issue Type: Improvement > Components: Replication >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Minor > Attachments: HBASE-1-v1.patch, HBASE-1-v2.patch, > HBASE-1.patch > > > After HBASE-16447, we support replication by namespaces config in peer. Like > append_peer_tableCFs and remove_peer_tableCFs, I thought we need two new > shell cmd: append_peer_namespaces and remove_peer_namespaces. Then we can > easily change the namespaces config. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561201#comment-15561201 ] Duo Zhang commented on HBASE-16664: --- Could you please upload the patch to reviewboard? I can not find the context of the timeout change in HTable as it does not show the method name... And consider adding javadoc for public methods such as the methods you added in BufferedMutator. > Timeout logic in AsyncProcess is broken > --- > > Key: HBASE-16664 > URL: https://issues.apache.org/jira/browse/HBASE-16664 > Project: HBase > Issue Type: Bug >Reporter: Phil Yang >Assignee: Phil Yang > Attachments: 1.patch, HBASE-16664-branch-1-v1.patch, > HBASE-16664-v1.patch, HBASE-16664-v2.patch, HBASE-16664-v3.patch, > HBASE-16664-v4.patch, testhcm.patch > > > Have not checked the root cause, but I think timeout of all operations in > AsyncProcess is broken -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561188#comment-15561188 ] Hudson commented on HBASE-16794: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #1758 (See [https://builds.apache.org/job/HBase-Trunk_matrix/1758/]) HBASE-16794 (matteo.bertozzi: rev 8a8c60889cf67b581d7adb4245e0bcc02cdfdc93) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestDispatchMergingRegionsProcedure.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky > - > > Key: HBASE-16794 > URL: https://issues.apache.org/jira/browse/HBASE-16794 > Project: HBase > Issue Type: Test > Components: test >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16794.v0.patch, HBASE-16794.v1.patch > > > The default count of merge thread is 1, so the merge requests submitted by > TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are > too early to check the region states, it will introduce the error. > This patch checks the number of running merge task instead of the regions > state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16762) NullPointerException is thrown when constructing sourceTable in verifyrep
[ https://issues.apache.org/jira/browse/HBASE-16762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16762: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 1.4.0 Status: Resolved (was: Patch Available) Thanks for the review. > NullPointerException is thrown when constructing sourceTable in verifyrep > - > > Key: HBASE-16762 > URL: https://issues.apache.org/jira/browse/HBASE-16762 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.0 > > Attachments: 16762.branch-1.txt > > > Branch-1 patch for HBASE-16423 incorrectly constructed sourceTable, leading > to the following exception: > {code} > 16/10/04 17:00:30 INFO mapreduce.Job: Task Id : > attempt_1473183665588_0082_m_16_1, Status : FAILED > Error: java.lang.NullPointerException > at org.apache.hadoop.hbase.TableName.valueOf(TableName.java:436) > at org.apache.hadoop.hbase.client.HTable.(HTable.java:150) > at > org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication$Verifier.map(VerifyReplication.java:128) > > at > org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication$Verifier.map(VerifyReplication.java:86) > > at org.apache.hadoop.mapreduce.Mapper.run(Mapper.java:146) > at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:787) > {code} > I checked master patch where there is no such bug -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16771) VerifyReplication should increase GOODROWS counter if re-comparison passes
[ https://issues.apache.org/jira/browse/HBASE-16771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16771: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Thanks for the reviews. > VerifyReplication should increase GOODROWS counter if re-comparison passes > -- > > Key: HBASE-16771 > URL: https://issues.apache.org/jira/browse/HBASE-16771 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 2.0.0, 1.4.0 > > Attachments: 16771.v1.txt, 16771.v2.txt, 16771.v3.txt > > > HBASE-16423 added re-comparison feature to reduce false positive rate. > However, before logFailRowAndIncreaseCounter() is called, GOODROWS counter is > not incremented. Neither is GOODROWS incremented when re-comparison passes. > This may produce inconsistent results across multiple runs of the same > verifyrep command. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-15921: -- Attachment: HBASE-15921-v6.patch Add javadoc. > Add first AsyncTable impl and create TableImpl based on it > -- > > Key: HBASE-15921 > URL: https://issues.apache.org/jira/browse/HBASE-15921 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: Jurriaan Mous >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-15921-v2.patch, HBASE-15921-v3.patch, > HBASE-15921-v4.patch, HBASE-15921-v5.patch, HBASE-15921-v6.patch, > HBASE-15921.demo.patch, HBASE-15921.patch, HBASE-15921.v1.patch > > > First we create an AsyncTable interface with implementation without the Scan > functionality. Those will land in a separate patch since they need a refactor > of existing scans. > Also added is a new TableImpl to replace HTable. It uses the AsyncTableImpl > internally and should be a bit faster because it does jump through less hoops > to do ProtoBuf transportation. This way we can run all existing tests on the > AsyncTableImpl to guarantee its quality. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16786) Procedure V2 - Move ZK-lock's uses to Procedure framework locks (LockProcedure)
[ https://issues.apache.org/jira/browse/HBASE-16786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561153#comment-15561153 ] Appy commented on HBASE-16786: -- Uploaded first version of patch. Still need to figure out how to handle mob locks. Mob advertises that it uses zk locks for mutual exclusion between sweep job which won't be possible now if master is down. Also this non-trivial lock operations: https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HMobStore.java#L465 We have two options: 1. keep zk locks: maybe external tools take master lock (if master is available) otherwise, zk lock. When master starts up, it too tries to take zk lock. 2. Get rid of zk locks: If master isn't alive, tools don't work until forced by cmd line option, say "--ignore-locks". [~mbertozzi], how should we do it? > Procedure V2 - Move ZK-lock's uses to Procedure framework locks > (LockProcedure) > --- > > Key: HBASE-16786 > URL: https://issues.apache.org/jira/browse/HBASE-16786 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16786.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16771) VerifyReplication should increase GOODROWS counter if re-comparison passes
[ https://issues.apache.org/jira/browse/HBASE-16771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561132#comment-15561132 ] Jianwei Cui commented on HBASE-16771: - [~tedyu], patch v3 looks good to me, thanks for the fix. > VerifyReplication should increase GOODROWS counter if re-comparison passes > -- > > Key: HBASE-16771 > URL: https://issues.apache.org/jira/browse/HBASE-16771 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 2.0.0, 1.4.0 > > Attachments: 16771.v1.txt, 16771.v2.txt, 16771.v3.txt > > > HBASE-16423 added re-comparison feature to reduce false positive rate. > However, before logFailRowAndIncreaseCounter() is called, GOODROWS counter is > not incremented. Neither is GOODROWS incremented when re-comparison passes. > This may produce inconsistent results across multiple runs of the same > verifyrep command. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15109) HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true
[ https://issues.apache.org/jira/browse/HBASE-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561131#comment-15561131 ] Pankaj Kumar commented on HBASE-15109: -- Have uploaded V2 patch, let QA run again. > HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true > -- > > Key: HBASE-15109 > URL: https://issues.apache.org/jira/browse/HBASE-15109 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 2.0.0 >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Critical > Attachments: HBASE-15109-V2.patch, HBASE-15109-branch-1.patch, > HBASE-15109.patch, HBASE-15109.patch > > > HMaster failed to start during installing ShutdownHook when > "fs.hdfs.impl.disable.cache" is set to true. > {noformat} > 2016-10-10 10:33:28,367 FATAL [master/HOST-10-18-106-146/10.18.106.146:16000] > master.HMaster: Unhandled: Failed suppression of fs shutdown hook: > org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@19a003b4 > java.lang.RuntimeException: Failed suppression of fs shutdown hook: > org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@19a003b4 > at > org.apache.hadoop.hbase.regionserver.ShutdownHook.suppressHdfsShutdownHook(ShutdownHook.java:204) > at > org.apache.hadoop.hbase.regionserver.ShutdownHook.install(ShutdownHook.java:84) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:950) > at java.lang.Thread.run(Thread.java:745) > {noformat} > And RegionServer is in blocking state until a master is available, > {noformat} > "regionserver/HOST-10-18-106-146/10.18.106.146:16020" #17 prio=5 os_prio=0 > tid=0x00e4e800 nid=0xdc38 in Object.wait() [0x7f329dac6000] >java.lang.Thread.State: TIMED_WAITING (on object monitor) > at java.lang.Object.wait(Native Method) > at > org.apache.hadoop.hbase.zookeeper.ZooKeeperNodeTracker.blockUntilAvailable(ZooKeeperNodeTracker.java:159) > - locked <0xae25c0c8> (a > org.apache.hadoop.hbase.zookeeper.MasterAddressTracker) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.blockAndCheckIfStopped(HRegionServer.java:870) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.initializeZooKeeper(HRegionServer.java:809) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:783) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:943) > at java.lang.Thread.run(Thread.java:745) > {noformat} > During installation, first time it will try to suppress the HDFS shutdownhook > by removing the hdfsclientfinalizer from HDFS. Since > fs.hdfs.impl.disable.cache is enabled, so removal will be unsuccessful from > HDFS (FS is not cached) and RuntimeException will be thrown with "Failed > suppression of fs shutdown hook" message. > In ShutdownHook, > {code} > if (!fsShutdownHooks.containsKey(hdfsClientFinalizer) && > !ShutdownHookManager.deleteShutdownHook(hdfsClientFinalizer)) { > throw new RuntimeException("Failed suppression of fs shutdown hook: " + > hdfsClientFinalizer); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15109) HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true
[ https://issues.apache.org/jira/browse/HBASE-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-15109: - Attachment: HBASE-15109-V2.patch > HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true > -- > > Key: HBASE-15109 > URL: https://issues.apache.org/jira/browse/HBASE-15109 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 2.0.0 >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Critical > Attachments: HBASE-15109-V2.patch, HBASE-15109-branch-1.patch, > HBASE-15109.patch, HBASE-15109.patch > > > HMaster failed to start during installing ShutdownHook when > "fs.hdfs.impl.disable.cache" is set to true. > {noformat} > 2016-10-10 10:33:28,367 FATAL [master/HOST-10-18-106-146/10.18.106.146:16000] > master.HMaster: Unhandled: Failed suppression of fs shutdown hook: > org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@19a003b4 > java.lang.RuntimeException: Failed suppression of fs shutdown hook: > org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@19a003b4 > at > org.apache.hadoop.hbase.regionserver.ShutdownHook.suppressHdfsShutdownHook(ShutdownHook.java:204) > at > org.apache.hadoop.hbase.regionserver.ShutdownHook.install(ShutdownHook.java:84) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:950) > at java.lang.Thread.run(Thread.java:745) > {noformat} > And RegionServer is in blocking state until a master is available, > {noformat} > "regionserver/HOST-10-18-106-146/10.18.106.146:16020" #17 prio=5 os_prio=0 > tid=0x00e4e800 nid=0xdc38 in Object.wait() [0x7f329dac6000] >java.lang.Thread.State: TIMED_WAITING (on object monitor) > at java.lang.Object.wait(Native Method) > at > org.apache.hadoop.hbase.zookeeper.ZooKeeperNodeTracker.blockUntilAvailable(ZooKeeperNodeTracker.java:159) > - locked <0xae25c0c8> (a > org.apache.hadoop.hbase.zookeeper.MasterAddressTracker) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.blockAndCheckIfStopped(HRegionServer.java:870) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.initializeZooKeeper(HRegionServer.java:809) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:783) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:943) > at java.lang.Thread.run(Thread.java:745) > {noformat} > During installation, first time it will try to suppress the HDFS shutdownhook > by removing the hdfsclientfinalizer from HDFS. Since > fs.hdfs.impl.disable.cache is enabled, so removal will be unsuccessful from > HDFS (FS is not cached) and RuntimeException will be thrown with "Failed > suppression of fs shutdown hook" message. > In ShutdownHook, > {code} > if (!fsShutdownHooks.containsKey(hdfsClientFinalizer) && > !ShutdownHookManager.deleteShutdownHook(hdfsClientFinalizer)) { > throw new RuntimeException("Failed suppression of fs shutdown hook: " + > hdfsClientFinalizer); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16666) Add append and remove peer namespaces cmds for replication
[ https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561126#comment-15561126 ] Ted Yu commented on HBASE-1: +1 > Add append and remove peer namespaces cmds for replication > -- > > Key: HBASE-1 > URL: https://issues.apache.org/jira/browse/HBASE-1 > Project: HBase > Issue Type: Improvement > Components: Replication >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Minor > Attachments: HBASE-1-v1.patch, HBASE-1-v2.patch, > HBASE-1.patch > > > After HBASE-16447, we support replication by namespaces config in peer. Like > append_peer_tableCFs and remove_peer_tableCFs, I thought we need two new > shell cmd: append_peer_namespaces and remove_peer_namespaces. Then we can > easily change the namespaces config. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16786) Procedure V2 - Move ZK-lock's uses to Procedure framework locks (LockProcedure)
[ https://issues.apache.org/jira/browse/HBASE-16786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-16786: - Attachment: HBASE-16786.master.001.patch > Procedure V2 - Move ZK-lock's uses to Procedure framework locks > (LockProcedure) > --- > > Key: HBASE-16786 > URL: https://issues.apache.org/jira/browse/HBASE-16786 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16786.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16666) Add append and remove peer namespaces cmds for replication
[ https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-1: --- Attachment: HBASE-1-v2.patch Update by review comments. > Add append and remove peer namespaces cmds for replication > -- > > Key: HBASE-1 > URL: https://issues.apache.org/jira/browse/HBASE-1 > Project: HBase > Issue Type: Improvement > Components: Replication >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Minor > Attachments: HBASE-1-v1.patch, HBASE-1-v2.patch, > HBASE-1.patch > > > After HBASE-16447, we support replication by namespaces config in peer. Like > append_peer_tableCFs and remove_peer_tableCFs, I thought we need two new > shell cmd: append_peer_namespaces and remove_peer_namespaces. Then we can > easily change the namespaces config. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16744) Procedure V2 - Lock procedures to allow clients to acquire locks on tables/namespaces/regions
[ https://issues.apache.org/jira/browse/HBASE-16744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-16744: - Attachment: HBASE-16744.master.005.patch > Procedure V2 - Lock procedures to allow clients to acquire locks on > tables/namespaces/regions > - > > Key: HBASE-16744 > URL: https://issues.apache.org/jira/browse/HBASE-16744 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16744.master.001.patch, > HBASE-16744.master.002.patch, HBASE-16744.master.003.patch, > HBASE-16744.master.004.patch, HBASE-16744.master.005.patch > > > Will help us get rid of ZK locks. > Will be useful for external tools like hbck, future backup manager, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15109) HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true
[ https://issues.apache.org/jira/browse/HBASE-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561114#comment-15561114 ] Ted Yu commented on HBASE-15109: I see. Does the patch still apply ? How about the test failures above ? > HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true > -- > > Key: HBASE-15109 > URL: https://issues.apache.org/jira/browse/HBASE-15109 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 2.0.0 >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Critical > Attachments: HBASE-15109-branch-1.patch, HBASE-15109.patch, > HBASE-15109.patch > > > HMaster failed to start during installing ShutdownHook when > "fs.hdfs.impl.disable.cache" is set to true. > {noformat} > 2016-10-10 10:33:28,367 FATAL [master/HOST-10-18-106-146/10.18.106.146:16000] > master.HMaster: Unhandled: Failed suppression of fs shutdown hook: > org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@19a003b4 > java.lang.RuntimeException: Failed suppression of fs shutdown hook: > org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@19a003b4 > at > org.apache.hadoop.hbase.regionserver.ShutdownHook.suppressHdfsShutdownHook(ShutdownHook.java:204) > at > org.apache.hadoop.hbase.regionserver.ShutdownHook.install(ShutdownHook.java:84) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:950) > at java.lang.Thread.run(Thread.java:745) > {noformat} > And RegionServer is in blocking state until a master is available, > {noformat} > "regionserver/HOST-10-18-106-146/10.18.106.146:16020" #17 prio=5 os_prio=0 > tid=0x00e4e800 nid=0xdc38 in Object.wait() [0x7f329dac6000] >java.lang.Thread.State: TIMED_WAITING (on object monitor) > at java.lang.Object.wait(Native Method) > at > org.apache.hadoop.hbase.zookeeper.ZooKeeperNodeTracker.blockUntilAvailable(ZooKeeperNodeTracker.java:159) > - locked <0xae25c0c8> (a > org.apache.hadoop.hbase.zookeeper.MasterAddressTracker) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.blockAndCheckIfStopped(HRegionServer.java:870) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.initializeZooKeeper(HRegionServer.java:809) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:783) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:943) > at java.lang.Thread.run(Thread.java:745) > {noformat} > During installation, first time it will try to suppress the HDFS shutdownhook > by removing the hdfsclientfinalizer from HDFS. Since > fs.hdfs.impl.disable.cache is enabled, so removal will be unsuccessful from > HDFS (FS is not cached) and RuntimeException will be thrown with "Failed > suppression of fs shutdown hook" message. > In ShutdownHook, > {code} > if (!fsShutdownHooks.containsKey(hdfsClientFinalizer) && > !ShutdownHookManager.deleteShutdownHook(hdfsClientFinalizer)) { > throw new RuntimeException("Failed suppression of fs shutdown hook: " + > hdfsClientFinalizer); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HBASE-15109) HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true
[ https://issues.apache.org/jira/browse/HBASE-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561104#comment-15561104 ] Pankaj Kumar edited comment on HBASE-15109 at 10/10/16 3:02 AM: Hi [~tedyu], I checked HDFS code and it is by default false. In FileSystem.java {code} String disableCacheName = String.format("fs.%s.impl.disable.cache", scheme); if (conf.getBoolean(disableCacheName, false)) { return createFileSystem(uri, conf); } {code} Please have a look, It may be one of the use case scenario where client doesn't want to cache the FS. was (Author: pankaj2461): Hi [~tedyu], I checked HDFS code and it is by default false. {code} String disableCacheName = String.format("fs.%s.impl.disable.cache", scheme); if (conf.getBoolean(disableCacheName, false)) { return createFileSystem(uri, conf); } {code} Please have a look, It may be one of the use case scenario where client doesn't want to cache the FS. > HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true > -- > > Key: HBASE-15109 > URL: https://issues.apache.org/jira/browse/HBASE-15109 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 2.0.0 >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Critical > Attachments: HBASE-15109-branch-1.patch, HBASE-15109.patch, > HBASE-15109.patch > > > HMaster failed to start during installing ShutdownHook when > "fs.hdfs.impl.disable.cache" is set to true. > {noformat} > 2016-10-10 10:33:28,367 FATAL [master/HOST-10-18-106-146/10.18.106.146:16000] > master.HMaster: Unhandled: Failed suppression of fs shutdown hook: > org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@19a003b4 > java.lang.RuntimeException: Failed suppression of fs shutdown hook: > org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@19a003b4 > at > org.apache.hadoop.hbase.regionserver.ShutdownHook.suppressHdfsShutdownHook(ShutdownHook.java:204) > at > org.apache.hadoop.hbase.regionserver.ShutdownHook.install(ShutdownHook.java:84) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:950) > at java.lang.Thread.run(Thread.java:745) > {noformat} > And RegionServer is in blocking state until a master is available, > {noformat} > "regionserver/HOST-10-18-106-146/10.18.106.146:16020" #17 prio=5 os_prio=0 > tid=0x00e4e800 nid=0xdc38 in Object.wait() [0x7f329dac6000] >java.lang.Thread.State: TIMED_WAITING (on object monitor) > at java.lang.Object.wait(Native Method) > at > org.apache.hadoop.hbase.zookeeper.ZooKeeperNodeTracker.blockUntilAvailable(ZooKeeperNodeTracker.java:159) > - locked <0xae25c0c8> (a > org.apache.hadoop.hbase.zookeeper.MasterAddressTracker) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.blockAndCheckIfStopped(HRegionServer.java:870) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.initializeZooKeeper(HRegionServer.java:809) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:783) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:943) > at java.lang.Thread.run(Thread.java:745) > {noformat} > During installation, first time it will try to suppress the HDFS shutdownhook > by removing the hdfsclientfinalizer from HDFS. Since > fs.hdfs.impl.disable.cache is enabled, so removal will be unsuccessful from > HDFS (FS is not cached) and RuntimeException will be thrown with "Failed > suppression of fs shutdown hook" message. > In ShutdownHook, > {code} > if (!fsShutdownHooks.containsKey(hdfsClientFinalizer) && > !ShutdownHookManager.deleteShutdownHook(hdfsClientFinalizer)) { > throw new RuntimeException("Failed suppression of fs shutdown hook: " + > hdfsClientFinalizer); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15109) HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true
[ https://issues.apache.org/jira/browse/HBASE-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561104#comment-15561104 ] Pankaj Kumar commented on HBASE-15109: -- Hi [~tedyu], I checked HDFS code and it is by default false. {code} String disableCacheName = String.format("fs.%s.impl.disable.cache", scheme); if (conf.getBoolean(disableCacheName, false)) { return createFileSystem(uri, conf); } {code} Please have a look, It may be one of the use case scenario where client doesn't want to cache the FS. > HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true > -- > > Key: HBASE-15109 > URL: https://issues.apache.org/jira/browse/HBASE-15109 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 2.0.0 >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Critical > Attachments: HBASE-15109-branch-1.patch, HBASE-15109.patch, > HBASE-15109.patch > > > HMaster failed to start during installing ShutdownHook when > "fs.hdfs.impl.disable.cache" is set to true. > {noformat} > 2016-10-10 10:33:28,367 FATAL [master/HOST-10-18-106-146/10.18.106.146:16000] > master.HMaster: Unhandled: Failed suppression of fs shutdown hook: > org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@19a003b4 > java.lang.RuntimeException: Failed suppression of fs shutdown hook: > org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@19a003b4 > at > org.apache.hadoop.hbase.regionserver.ShutdownHook.suppressHdfsShutdownHook(ShutdownHook.java:204) > at > org.apache.hadoop.hbase.regionserver.ShutdownHook.install(ShutdownHook.java:84) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:950) > at java.lang.Thread.run(Thread.java:745) > {noformat} > And RegionServer is in blocking state until a master is available, > {noformat} > "regionserver/HOST-10-18-106-146/10.18.106.146:16020" #17 prio=5 os_prio=0 > tid=0x00e4e800 nid=0xdc38 in Object.wait() [0x7f329dac6000] >java.lang.Thread.State: TIMED_WAITING (on object monitor) > at java.lang.Object.wait(Native Method) > at > org.apache.hadoop.hbase.zookeeper.ZooKeeperNodeTracker.blockUntilAvailable(ZooKeeperNodeTracker.java:159) > - locked <0xae25c0c8> (a > org.apache.hadoop.hbase.zookeeper.MasterAddressTracker) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.blockAndCheckIfStopped(HRegionServer.java:870) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.initializeZooKeeper(HRegionServer.java:809) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:783) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:943) > at java.lang.Thread.run(Thread.java:745) > {noformat} > During installation, first time it will try to suppress the HDFS shutdownhook > by removing the hdfsclientfinalizer from HDFS. Since > fs.hdfs.impl.disable.cache is enabled, so removal will be unsuccessful from > HDFS (FS is not cached) and RuntimeException will be thrown with "Failed > suppression of fs shutdown hook" message. > In ShutdownHook, > {code} > if (!fsShutdownHooks.containsKey(hdfsClientFinalizer) && > !ShutdownHookManager.deleteShutdownHook(hdfsClientFinalizer)) { > throw new RuntimeException("Failed suppression of fs shutdown hook: " + > hdfsClientFinalizer); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15109) HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true
[ https://issues.apache.org/jira/browse/HBASE-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-15109: - Description: HMaster failed to start during installing ShutdownHook when "fs.hdfs.impl.disable.cache" is set to true. {noformat} 2016-10-10 10:33:28,367 FATAL [master/HOST-10-18-106-146/10.18.106.146:16000] master.HMaster: Unhandled: Failed suppression of fs shutdown hook: org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@19a003b4 java.lang.RuntimeException: Failed suppression of fs shutdown hook: org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@19a003b4 at org.apache.hadoop.hbase.regionserver.ShutdownHook.suppressHdfsShutdownHook(ShutdownHook.java:204) at org.apache.hadoop.hbase.regionserver.ShutdownHook.install(ShutdownHook.java:84) at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:950) at java.lang.Thread.run(Thread.java:745) {noformat} And RegionServer is in blocking state until a master is available, {noformat} "regionserver/HOST-10-18-106-146/10.18.106.146:16020" #17 prio=5 os_prio=0 tid=0x00e4e800 nid=0xdc38 in Object.wait() [0x7f329dac6000] java.lang.Thread.State: TIMED_WAITING (on object monitor) at java.lang.Object.wait(Native Method) at org.apache.hadoop.hbase.zookeeper.ZooKeeperNodeTracker.blockUntilAvailable(ZooKeeperNodeTracker.java:159) - locked <0xae25c0c8> (a org.apache.hadoop.hbase.zookeeper.MasterAddressTracker) at org.apache.hadoop.hbase.regionserver.HRegionServer.blockAndCheckIfStopped(HRegionServer.java:870) at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeZooKeeper(HRegionServer.java:809) at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:783) at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:943) at java.lang.Thread.run(Thread.java:745) {noformat} During installation, first time it will try to suppress the HDFS shutdownhook by removing the hdfsclientfinalizer from HDFS. Since fs.hdfs.impl.disable.cache is enabled, so removal will be unsuccessful from HDFS (FS is not cached) and RuntimeException will be thrown with "Failed suppression of fs shutdown hook" message. In ShutdownHook, {code} if (!fsShutdownHooks.containsKey(hdfsClientFinalizer) && !ShutdownHookManager.deleteShutdownHook(hdfsClientFinalizer)) { throw new RuntimeException("Failed suppression of fs shutdown hook: " + hdfsClientFinalizer); } {code} was: Region server failed to start during installing ShutdownHook when "fs.hdfs.impl.disable.cache" is set to true in core-site.xml at HBase side. {code} 2016-01-14 15:30:56,358 | FATAL | regionserver/ds2/192.168.152.230:21302 | ABORTING region server ds2,21302,1452756654352: Unhandled: Failed suppression of fs shutdown hook: org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@571527d6 | org.apache.hadoop.hbase.regionserver.HRegionServer.abort(HRegionServer.java:2054) java.lang.RuntimeException: Failed suppression of fs shutdown hook: org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@571527d6 at org.apache.hadoop.hbase.regionserver.ShutdownHook.suppressHdfsShutdownHook(ShutdownHook.java:204) at org.apache.hadoop.hbase.regionserver.ShutdownHook.install(ShutdownHook.java:84) at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:893) at java.lang.Thread.run(Thread.java:745) {code} During installation, first time it will try to suppress the HDFS shutdownhook by removing the hdfsclientfinalizer from HDFS. Since fs.hdfs.impl.disable.cache is enabled, so removal will be unsuccessful from HDFS (FS is not cached) and RuntimeException will be thrown with "Failed suppression of fs shutdown hook" message. In ShutdownHook, {code} if (!fsShutdownHooks.containsKey(hdfsClientFinalizer) && !ShutdownHookManager.deleteShutdownHook(hdfsClientFinalizer)) { throw new RuntimeException("Failed suppression of fs shutdown hook: " + hdfsClientFinalizer); } {code} > HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true > -- > > Key: HBASE-15109 > URL: https://issues.apache.org/jira/browse/HBASE-15109 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 2.0.0 >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Critical > Attachments: HBASE-15109-branch-1.patch, HBASE-15109.patch, > HBASE-15109.patch > > > HMaster failed to start during installing ShutdownHook when > "fs.hdfs.impl.disable.cache" is set to true. > {noformat} > 2016-10-10 10:33:28,367 FATAL [master/HOST-10-18-106-146/10.18.106.146:16000] > master.HMaster: Unhandled: Failed suppression of fs shutdow
[jira] [Updated] (HBASE-16744) Procedure V2 - Lock procedures to allow clients to acquire locks on tables/namespaces/regions
[ https://issues.apache.org/jira/browse/HBASE-16744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-16744: - Attachment: HBASE-16744.master.004.patch > Procedure V2 - Lock procedures to allow clients to acquire locks on > tables/namespaces/regions > - > > Key: HBASE-16744 > URL: https://issues.apache.org/jira/browse/HBASE-16744 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16744.master.001.patch, > HBASE-16744.master.002.patch, HBASE-16744.master.003.patch, > HBASE-16744.master.004.patch > > > Will help us get rid of ZK locks. > Will be useful for external tools like hbck, future backup manager, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16630) Fragmentation in long running Bucket Cache
[ https://issues.apache.org/jira/browse/HBASE-16630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561095#comment-15561095 ] Ted Yu commented on HBASE-16630: Deepankar: How was the patched version running in your cluster ? Thanks > Fragmentation in long running Bucket Cache > -- > > Key: HBASE-16630 > URL: https://issues.apache.org/jira/browse/HBASE-16630 > Project: HBase > Issue Type: Bug > Components: BucketCache >Affects Versions: 2.0.0, 1.1.6, 1.3.1, 1.2.3 >Reporter: deepankar >Assignee: deepankar > Attachments: 16630-v2-suggest.patch, 16630-v3-suggest.patch, > HBASE-16630-v2.patch, HBASE-16630-v3.patch, HBASE-16630.patch > > > As we are running bucket cache for a long time in our system, we are > observing cases where some nodes after some time does not fully utilize the > bucket cache, in some cases it is even worse in the sense they get stuck at a > value < 0.25 % of the bucket cache (DEFAULT_MEMORY_FACTOR as all our tables > are configured in-memory for simplicity sake). > We took a heap dump and analyzed what is happening and saw that is classic > case of fragmentation, current implementation of BucketCache (mainly > BucketAllocator) relies on the logic that fullyFreeBuckets are available for > switching/adjusting cache usage between different bucketSizes . But once a > compaction / bulkload happens and the blocks are evicted from a bucket size , > these are usually evicted from random places of the buckets of a bucketSize > and thus locking the number of buckets associated with a bucketSize and in > the worst case of the fragmentation we have seen some bucketSizes with > occupancy ratio of < 10 % But they dont have any completelyFreeBuckets to > share with the other bucketSize. > Currently the existing eviction logic helps in the cases where cache used is > more the MEMORY_FACTOR or MULTI_FACTOR and once those evictions are also > done, the eviction (freeSpace function) will not evict anything and the cache > utilization will be stuck at that value without any allocations for other > required sizes. > The fix for this we came up with is simple that we do deFragmentation ( > compaction) of the bucketSize and thus increasing the occupancy ratio and > also freeing up the buckets to be fullyFree, this logic itself is not > complicated as the bucketAllocator takes care of packing the blocks in the > buckets, we need evict and re-allocate the blocks for all the BucketSizes > that dont fit the criteria. > I am attaching an initial patch just to give an idea of what we are thinking > and I'll improve it based on the comments from the community. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15109) HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true
[ https://issues.apache.org/jira/browse/HBASE-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-15109: - Affects Version/s: (was: 1.0.0) 2.0.0 > HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true > -- > > Key: HBASE-15109 > URL: https://issues.apache.org/jira/browse/HBASE-15109 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 2.0.0 >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Critical > Attachments: HBASE-15109-branch-1.patch, HBASE-15109.patch, > HBASE-15109.patch > > > Region server failed to start during installing ShutdownHook when > "fs.hdfs.impl.disable.cache" is set to true in core-site.xml at HBase side. > {code} > 2016-01-14 15:30:56,358 | FATAL | regionserver/ds2/192.168.152.230:21302 | > ABORTING region server ds2,21302,1452756654352: Unhandled: Failed suppression > of fs shutdown hook: > org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@571527d6 | > org.apache.hadoop.hbase.regionserver.HRegionServer.abort(HRegionServer.java:2054) > java.lang.RuntimeException: Failed suppression of fs shutdown hook: > org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@571527d6 > at > org.apache.hadoop.hbase.regionserver.ShutdownHook.suppressHdfsShutdownHook(ShutdownHook.java:204) > at > org.apache.hadoop.hbase.regionserver.ShutdownHook.install(ShutdownHook.java:84) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:893) > at java.lang.Thread.run(Thread.java:745) > {code} > During installation, first time it will try to suppress the HDFS shutdownhook > by removing the hdfsclientfinalizer from HDFS. Since > fs.hdfs.impl.disable.cache is enabled, so removal will be unsuccessful from > HDFS (FS is not cached) and RuntimeException will be thrown with "Failed > suppression of fs shutdown hook" message. > In ShutdownHook, > {code} > if (!fsShutdownHooks.containsKey(hdfsClientFinalizer) && > !ShutdownHookManager.deleteShutdownHook(hdfsClientFinalizer)) { > throw new RuntimeException("Failed suppression of fs shutdown hook: " + > hdfsClientFinalizer); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15109) HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true
[ https://issues.apache.org/jira/browse/HBASE-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-15109: - Summary: HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true (was: Region server failed to start when "fs.hdfs.impl.disable.cache" is set to true) > HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true > -- > > Key: HBASE-15109 > URL: https://issues.apache.org/jira/browse/HBASE-15109 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.0.0 >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Critical > Attachments: HBASE-15109-branch-1.patch, HBASE-15109.patch, > HBASE-15109.patch > > > Region server failed to start during installing ShutdownHook when > "fs.hdfs.impl.disable.cache" is set to true in core-site.xml at HBase side. > {code} > 2016-01-14 15:30:56,358 | FATAL | regionserver/ds2/192.168.152.230:21302 | > ABORTING region server ds2,21302,1452756654352: Unhandled: Failed suppression > of fs shutdown hook: > org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@571527d6 | > org.apache.hadoop.hbase.regionserver.HRegionServer.abort(HRegionServer.java:2054) > java.lang.RuntimeException: Failed suppression of fs shutdown hook: > org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@571527d6 > at > org.apache.hadoop.hbase.regionserver.ShutdownHook.suppressHdfsShutdownHook(ShutdownHook.java:204) > at > org.apache.hadoop.hbase.regionserver.ShutdownHook.install(ShutdownHook.java:84) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:893) > at java.lang.Thread.run(Thread.java:745) > {code} > During installation, first time it will try to suppress the HDFS shutdownhook > by removing the hdfsclientfinalizer from HDFS. Since > fs.hdfs.impl.disable.cache is enabled, so removal will be unsuccessful from > HDFS (FS is not cached) and RuntimeException will be thrown with "Failed > suppression of fs shutdown hook" message. > In ShutdownHook, > {code} > if (!fsShutdownHooks.containsKey(hdfsClientFinalizer) && > !ShutdownHookManager.deleteShutdownHook(hdfsClientFinalizer)) { > throw new RuntimeException("Failed suppression of fs shutdown hook: " + > hdfsClientFinalizer); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16414) Improve performance for RPC encryption with Apache Common Crypto
[ https://issues.apache.org/jira/browse/HBASE-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin Ma updated HBASE-16414: - Attachment: HBASE-16414.007.patch > Improve performance for RPC encryption with Apache Common Crypto > > > Key: HBASE-16414 > URL: https://issues.apache.org/jira/browse/HBASE-16414 > Project: HBase > Issue Type: Improvement > Components: IPC/RPC >Affects Versions: 2.0.0 >Reporter: Colin Ma >Assignee: Colin Ma > Attachments: HBASE-16414.001.patch, HBASE-16414.002.patch, > HBASE-16414.003.patch, HBASE-16414.004.patch, HBASE-16414.005.patch, > HBASE-16414.006.patch, HBASE-16414.007.patch, > HbaseRpcEncryptionWithCrypoto.docx > > > Hbase RPC encryption is enabled by setting “hbase.rpc.protection” to > "privacy". With the token authentication, it utilized DIGEST-MD5 mechanisms > for secure authentication and data protection. For DIGEST-MD5, it uses DES, > 3DES or RC4 to do encryption and it is very slow, especially for Scan. This > will become the bottleneck of the RPC throughput. > Apache Commons Crypto is a cryptographic library optimized with AES-NI. It > provides Java API for both cipher level and Java stream level. Developers can > use it to implement high performance AES encryption/decryption with the > minimum code and effort. Compare with the current implementation of > org.apache.hadoop.hbase.io.crypto.aes.AES, Crypto supports both JCE Cipher > and OpenSSL Cipher which is better performance than JCE Cipher. User can > configure the cipher type and the default is JCE Cipher. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16771) VerifyReplication should increase GOODROWS counter if re-comparison passes
[ https://issues.apache.org/jira/browse/HBASE-16771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16771: --- Fix Version/s: 1.4.0 2.0.0 > VerifyReplication should increase GOODROWS counter if re-comparison passes > -- > > Key: HBASE-16771 > URL: https://issues.apache.org/jira/browse/HBASE-16771 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 2.0.0, 1.4.0 > > Attachments: 16771.v1.txt, 16771.v2.txt, 16771.v3.txt > > > HBASE-16423 added re-comparison feature to reduce false positive rate. > However, before logFailRowAndIncreaseCounter() is called, GOODROWS counter is > not incremented. Neither is GOODROWS incremented when re-comparison passes. > This may produce inconsistent results across multiple runs of the same > verifyrep command. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16771) VerifyReplication should increase GOODROWS counter if re-comparison passes
[ https://issues.apache.org/jira/browse/HBASE-16771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16771: --- Attachment: 16771.v3.txt > VerifyReplication should increase GOODROWS counter if re-comparison passes > -- > > Key: HBASE-16771 > URL: https://issues.apache.org/jira/browse/HBASE-16771 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16771.v1.txt, 16771.v2.txt, 16771.v3.txt > > > HBASE-16423 added re-comparison feature to reduce false positive rate. > However, before logFailRowAndIncreaseCounter() is called, GOODROWS counter is > not incremented. Neither is GOODROWS incremented when re-comparison passes. > This may produce inconsistent results across multiple runs of the same > verifyrep command. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16771) VerifyReplication should increase GOODROWS counter if re-comparison passes
[ https://issues.apache.org/jira/browse/HBASE-16771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561049#comment-15561049 ] Jianwei Cui commented on HBASE-16771: - Patch v2 looks good to me. Btw, in Verifier#map: {code} if (rowCmpRet == 0) { // rowkey is same, need to compare the content of the row try { Result.compareResults(value, currentCompareRowInPeerTable); context.getCounter(Counters.GOODROWS).increment(1); if (verbose) { LOG.info("Good row key: " + delimiter + Bytes.toString(value.getRow()) + delimiter); } } catch (Exception e) { logFailRowAndIncreaseCounter(context, Counters.CONTENT_DIFFERENT_ROWS, value); LOG.error("Exception while comparing row : " + e); // > unnecessary to log an exception } {code} There will be an exception message when the values are different for the same rowkey. It may be a good row when doing re-check, and if not, the {{logFailRowAndIncreaseCounter}} will also log an error message for this row, so it is unnecessary to log an exception here? > VerifyReplication should increase GOODROWS counter if re-comparison passes > -- > > Key: HBASE-16771 > URL: https://issues.apache.org/jira/browse/HBASE-16771 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16771.v1.txt, 16771.v2.txt > > > HBASE-16423 added re-comparison feature to reduce false positive rate. > However, before logFailRowAndIncreaseCounter() is called, GOODROWS counter is > not incremented. Neither is GOODROWS incremented when re-comparison passes. > This may produce inconsistent results across multiple runs of the same > verifyrep command. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16716) OfflineMetaRepair leave empty directory inside /hbase/WALs which remains forever
[ https://issues.apache.org/jira/browse/HBASE-16716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-16716: - Fix Version/s: 2.0.0 Status: Patch Available (was: Open) Simple patch, please review. > OfflineMetaRepair leave empty directory inside /hbase/WALs which remains > forever > > > Key: HBASE-16716 > URL: https://issues.apache.org/jira/browse/HBASE-16716 > Project: HBase > Issue Type: Bug > Components: hbck >Affects Versions: 2.0.0 >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16716.patch > > > OfflineMetaRepair rebuild Meta table, while creating meta region it creates > it's own WAL (inside /hbase/WALs/hbck-meta-recovery-) which wll > be closed and archived after rebuilding Meta. > {noformat} > hbase org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair > >> /hbase/WALs/hbck-meta-recovery- > {noformat} > It doesn't clear the empty dir, empty directory should be removed after > success. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16716) OfflineMetaRepair leave empty directory inside /hbase/WALs which remains forever
[ https://issues.apache.org/jira/browse/HBASE-16716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-16716: - Attachment: HBASE-16716.patch > OfflineMetaRepair leave empty directory inside /hbase/WALs which remains > forever > > > Key: HBASE-16716 > URL: https://issues.apache.org/jira/browse/HBASE-16716 > Project: HBase > Issue Type: Bug > Components: hbck >Affects Versions: 2.0.0 >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Minor > Attachments: HBASE-16716.patch > > > OfflineMetaRepair rebuild Meta table, while creating meta region it creates > it's own WAL (inside /hbase/WALs/hbck-meta-recovery-) which wll > be closed and archived after rebuilding Meta. > {noformat} > hbase org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair > >> /hbase/WALs/hbck-meta-recovery- > {noformat} > It doesn't clear the empty dir, empty directory should be removed after > success. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16762) NullPointerException is thrown when constructing sourceTable in verifyrep
[ https://issues.apache.org/jira/browse/HBASE-16762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561033#comment-15561033 ] Jianwei Cui commented on HBASE-16762: - [~tedyu], patch looks good to me, thanks for the fix. > NullPointerException is thrown when constructing sourceTable in verifyrep > - > > Key: HBASE-16762 > URL: https://issues.apache.org/jira/browse/HBASE-16762 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16762.branch-1.txt > > > Branch-1 patch for HBASE-16423 incorrectly constructed sourceTable, leading > to the following exception: > {code} > 16/10/04 17:00:30 INFO mapreduce.Job: Task Id : > attempt_1473183665588_0082_m_16_1, Status : FAILED > Error: java.lang.NullPointerException > at org.apache.hadoop.hbase.TableName.valueOf(TableName.java:436) > at org.apache.hadoop.hbase.client.HTable.(HTable.java:150) > at > org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication$Verifier.map(VerifyReplication.java:128) > > at > org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication$Verifier.map(VerifyReplication.java:86) > > at org.apache.hadoop.mapreduce.Mapper.run(Mapper.java:146) > at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:787) > {code} > I checked master patch where there is no such bug -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16724) Snapshot owner can't clone
[ https://issues.apache.org/jira/browse/HBASE-16724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561010#comment-15561010 ] Pankaj Kumar commented on HBASE-16724: -- Test case failures are not relevant. Those failed because of "java.lang.OutOfMemoryError: Java heap space". > Snapshot owner can't clone > -- > > Key: HBASE-16724 > URL: https://issues.apache.org/jira/browse/HBASE-16724 > Project: HBase > Issue Type: Bug > Components: snapshots >Affects Versions: 2.0.0 >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar > Attachments: HBASE-16724-V2.patch, HBASE-16724-V3.patch, > HBASE-16724.patch > > > Currently only Global admin has the access of cloning a snapshot. > In AccessController, > {code} > @Override > public void preCloneSnapshot(final > ObserverContext ctx, > final SnapshotDescription snapshot, final HTableDescriptor > hTableDescriptor) > throws IOException { > requirePermission(getActiveUser(ctx), "cloneSnapshot " + > snapshot.getName(), Action.ADMIN); > } > {code} > Snapshot owner should be able to clone it, need to add a check like, > {code} > SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Bertozzi updated HBASE-16794: Resolution: Fixed Status: Resolved (was: Patch Available) > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky > - > > Key: HBASE-16794 > URL: https://issues.apache.org/jira/browse/HBASE-16794 > Project: HBase > Issue Type: Test > Components: test >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16794.v0.patch, HBASE-16794.v1.patch > > > The default count of merge thread is 1, so the merge requests submitted by > TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are > too early to check the region states, it will introduce the error. > This patch checks the number of running merge task instead of the regions > state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560923#comment-15560923 ] Hadoop QA commented on HBASE-16794: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 55s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 45s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 37s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 43s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 33s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 44s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 26m 16s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 12s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 47s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 97m 10s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 135m 14s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.regionserver.TestHRegion | | Timed out junit tests | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12832383/HBASE-16794.v1.patch | | JIRA Issue | HBASE-16794 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 04be3225bd29 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / e06c367 | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/3904/artifact/patchprocess/patch-unit-hbase-server.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/3904/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/3904/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/3904/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently
[jira] [Commented] (HBASE-16757) Integrate functionality currently done up as Coprocessor Endpoints into core.
[ https://issues.apache.org/jira/browse/HBASE-16757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560761#comment-15560761 ] Jerry He commented on HBASE-16757: -- I created two sub-tasks to cover TokenProvider and MultiRowMutation. Apparently AccessController and VisibilityLabels controller need more thinking. > Integrate functionality currently done up as Coprocessor Endpoints into core. > - > > Key: HBASE-16757 > URL: https://issues.apache.org/jira/browse/HBASE-16757 > Project: HBase > Issue Type: Task > Components: Coprocessors >Reporter: stack > > As part of the work over in HBASE-15638, "Shade Protobufs", I could not but > help noticing that of the seven or eight Coprocessor Endpoints bundled with > hbase, half should have been converted to be core long time again. In fact, > some of these core CPEPs are no longer viable as CPEPs, if they ever were, > given how intertwined with core they are. > For example, MultiRowMutation, the nice CPEP that allows us do cross-row > transactions used natively amending hbase:meta, has much of its facility > baked into core without which it could not run. In an exercise, I was able to > convert this one over without having to alter public APIs in Table or Admin. > Auth, as pointed out by [~mbertozzi], is not a Coprocessor Endpoint though it > is cast as one invoked natively by RPC. > VisibilityLabels is a CPEP but core types -- Query and Mutation -- actually > depend on VisibiltyLabel related classes. > SecureBulkLoad is not in any violation being a CPEP provided to add API > ahead-of-time since properly deprecated and already integrated to core but I > mention it here for completeness sake. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-16798) Integrate MultiRowMutation CPEP into HBase core
Jerry He created HBASE-16798: Summary: Integrate MultiRowMutation CPEP into HBase core Key: HBASE-16798 URL: https://issues.apache.org/jira/browse/HBASE-16798 Project: HBase Issue Type: Sub-task Reporter: Jerry He Integrate MultiRowMutation CPEP into HBase core as discussed in the parent task. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-16797) Integrate TokenProvider to HBase core
Jerry He created HBASE-16797: Summary: Integrate TokenProvider to HBase core Key: HBASE-16797 URL: https://issues.apache.org/jira/browse/HBASE-16797 Project: HBase Issue Type: Sub-task Reporter: Jerry He Integrate TokenProvider to HBase core as discussed in the parent task. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-16796) Correct RpcServer responseSize and requestSize to account for cellScanner payload
Jerry He created HBASE-16796: Summary: Correct RpcServer responseSize and requestSize to account for cellScanner payload Key: HBASE-16796 URL: https://issues.apache.org/jira/browse/HBASE-16796 Project: HBase Issue Type: Bug Reporter: Jerry He Assignee: Jerry He The reponseSize and requestSize on the RpcServer don't seem to account for the cellScanner payload. We should correct them. The metrics numbers and the logging for reponseTooLarge and TooSlow won't show up correctly otherwise. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560731#comment-15560731 ] ChiaPing Tsai commented on HBASE-16794: --- v1.patch address [~mbertozzi]'s comment > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky > - > > Key: HBASE-16794 > URL: https://issues.apache.org/jira/browse/HBASE-16794 > Project: HBase > Issue Type: Test > Components: test >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16794.v0.patch, HBASE-16794.v1.patch > > > The default count of merge thread is 1, so the merge requests submitted by > TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are > too early to check the region states, it will introduce the error. > This patch checks the number of running merge task instead of the regions > state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-16794: -- Status: Patch Available (was: Open) > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky > - > > Key: HBASE-16794 > URL: https://issues.apache.org/jira/browse/HBASE-16794 > Project: HBase > Issue Type: Test > Components: test >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16794.v0.patch, HBASE-16794.v1.patch > > > The default count of merge thread is 1, so the merge requests submitted by > TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are > too early to check the region states, it will introduce the error. > This patch checks the number of running merge task instead of the regions > state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-16794: -- Attachment: HBASE-16794.v1.patch > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky > - > > Key: HBASE-16794 > URL: https://issues.apache.org/jira/browse/HBASE-16794 > Project: HBase > Issue Type: Test > Components: test >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16794.v0.patch, HBASE-16794.v1.patch > > > The default count of merge thread is 1, so the merge requests submitted by > TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are > too early to check the region states, it will introduce the error. > This patch checks the number of running merge task instead of the regions > state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-16794: -- Status: Open (was: Patch Available) > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky > - > > Key: HBASE-16794 > URL: https://issues.apache.org/jira/browse/HBASE-16794 > Project: HBase > Issue Type: Test > Components: test >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16794.v0.patch > > > The default count of merge thread is 1, so the merge requests submitted by > TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are > too early to check the region states, it will introduce the error. > This patch checks the number of running merge task instead of the regions > state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15924) Enhance hbase services autorestart capability to hbase-daemon.sh
[ https://issues.apache.org/jira/browse/HBASE-15924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560711#comment-15560711 ] Andrew Purtell commented on HBASE-15924: I got sidetracked by release stuff. I looked at the patch stylistically and will post on that after testing out the feature, planning to try this out on Monday. > Enhance hbase services autorestart capability to hbase-daemon.sh > - > > Key: HBASE-15924 > URL: https://issues.apache.org/jira/browse/HBASE-15924 > Project: HBase > Issue Type: Improvement >Affects Versions: 0.98.19 >Reporter: Loknath Priyatham Teja Singamsetty >Assignee: Loknath Priyatham Teja Singamsetty > Fix For: 0.98.24 > > Attachments: HBASE-15924.master.0001.patch, > HBASE-15924.master.0002.patch, HBASE-15924.master.0003.patch > > > As part of HBASE-5939, the autorestart for hbase services has been added to > deal with scenarios where hbase services (master/regionserver/master-backup) > gets killed or goes down leading to unplanned outages. The changes were made > to hbase-daemon.sh to support autorestart option. > However, the autorestart implementation doesn't work in standalone mode and > other than that have few gaps with the implementation as per release notes of > HBASE-5939. Here is an attempt to re-design and fix the functionality > considering all possible usecases with hbase service operations. > Release Notes of HBASE-5939: > -- > When launched with autorestart, HBase processes will automatically restart if > they are not properly terminated, either by a "stop" command or by a cluster > stop. To ensure that it does not overload the system when the server itself > is corrupted and the process cannot be restarted, the server sleeps for 5 > minutes before restarting if it was already started 5 minutes ago previously. > To use it, launch the process with "bin/start-hbase autorestart". This option > is not fully compatible with the existing "restart" command: if you ask for a > restart on a server launched with autorestart, the server will restart but > the next server instance won't be automatically restarted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560616#comment-15560616 ] Matteo Bertozzi commented on HBASE-16794: - from a second look, can you move the logic in a assertRegionCount(), since every test will benefit from this change > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky > - > > Key: HBASE-16794 > URL: https://issues.apache.org/jira/browse/HBASE-16794 > Project: HBase > Issue Type: Test > Components: test >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16794.v0.patch > > > The default count of merge thread is 1, so the merge requests submitted by > TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are > too early to check the region states, it will introduce the error. > This patch checks the number of running merge task instead of the regions > state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16795) Revisit 'in project Maven repo' checked in as part of HBASE-14785
[ https://issues.apache.org/jira/browse/HBASE-16795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560484#comment-15560484 ] Ted Yu commented on HBASE-16795: [~misty]: What do you think ? > Revisit 'in project Maven repo' checked in as part of HBASE-14785 > - > > Key: HBASE-16795 > URL: https://issues.apache.org/jira/browse/HBASE-16795 > Project: HBase > Issue Type: Bug >Reporter: Andrew Purtell > > I did a naive update of docs on branch-1.1 from master like so: > {noformat} > $ git co master src > ... > {noformat} > and the result failed a RAT check. Looking at rat.txt I noticed we are > including binaries in our source tarball, checked in as part of HBASE-14785. > {noformat} > HBASE-14785 Addendum: Add an in-project Maven repo > src/main/site/resources/css/site.css | 1 - > .../maven-fluido-skin/1.5-HBASE/maven-fluido-skin-1.5-HBASE.jar | Bin 0 -> > 344936 bytes > .../maven-fluido-skin/1.5-HBASE/maven-fluido-skin-1.5-HBASE.pom | 718 > > .../maven/skins/maven-fluido-skin/maven-metadata-local.xml | 12 + > 4 files changed, 730 insertions(+), 1 deletion(-) > {noformat} > I'm not sure why RAT flagged this in that 1.1 build when I see that > previously we have copied back docs from master into the branch. Perhaps > previous copies have been more selective. > This change has been committed for over a year. Let's make sure we have > discussed this and determined it is appropriate. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16731) Inconsistent results from the Get/Scan if we use the empty FilterList
[ https://issues.apache.org/jira/browse/HBASE-16731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-16731: -- Description: RSRpcServices#get() converts the Get to Scan without scan#setLoadColumnFamiliesOnDemand. It causes that the result retrieved from Get and Scan will be different if we use the empty filter. Scan doesn't return any data but Get does. see [HBASE-16729 |https://issues.apache.org/jira/browse/HBASE-16729] Any comments? Thanks. was: RSRpcServices#get() converts the Get to Scan without scan#setLoadColumnFamiliesOnDemand. It causes two disadvantage. 1) The result retrieved from Get and Scan will be different if we use the empty filter. Scan doesn't return any data but Get does. see [HBASE-16729 |https://issues.apache.org/jira/browse/HBASE-16729] 2) unable to read CF data lazily for Get operation. Any comments? Thanks. > Inconsistent results from the Get/Scan if we use the empty FilterList > - > > Key: HBASE-16731 > URL: https://issues.apache.org/jira/browse/HBASE-16731 > Project: HBase > Issue Type: Bug >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16731.v0.patch, HBASE-16731.v1.patch, > HBASE-16731.v2.patch > > > RSRpcServices#get() converts the Get to Scan without > scan#setLoadColumnFamiliesOnDemand. It causes that the result retrieved from > Get and Scan will be different if we use the empty filter. Scan doesn't > return any data but Get does. > see [HBASE-16729 |https://issues.apache.org/jira/browse/HBASE-16729] > Any comments? Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16731) Inconsistent results from the Get/Scan if we use the empty FilterList
[ https://issues.apache.org/jira/browse/HBASE-16731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-16731: -- Summary: Inconsistent results from the Get/Scan if we use the empty FilterList (was: Add Scan#setLoadColumnFamiliesOnDemand method to Get.) > Inconsistent results from the Get/Scan if we use the empty FilterList > - > > Key: HBASE-16731 > URL: https://issues.apache.org/jira/browse/HBASE-16731 > Project: HBase > Issue Type: Bug >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16731.v0.patch, HBASE-16731.v1.patch, > HBASE-16731.v2.patch > > > RSRpcServices#get() converts the Get to Scan without > scan#setLoadColumnFamiliesOnDemand. It causes two disadvantage. > 1) The result retrieved from Get and Scan will be different if we use the > empty filter. Scan doesn't return any data but Get does. > see [HBASE-16729 |https://issues.apache.org/jira/browse/HBASE-16729] > 2) unable to read CF data lazily for Get operation. > Any comments? Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16767) Mob compaction needs to clean up files in /hbase/mobdir/.tmp and /hbase/mobdir/.tmp/.bulkload when running into IO exceptions
[ https://issues.apache.org/jira/browse/HBASE-16767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560360#comment-15560360 ] Ted Yu commented on HBASE-16767: Looks like the commit message didn't include JIRA number. > Mob compaction needs to clean up files in /hbase/mobdir/.tmp and > /hbase/mobdir/.tmp/.bulkload when running into IO exceptions > -- > > Key: HBASE-16767 > URL: https://issues.apache.org/jira/browse/HBASE-16767 > Project: HBase > Issue Type: Bug > Components: mob >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 2.0.0 > > Attachments: HBASE-16767.master.001.patch, > HBASE-16767.master.002.patch, HBASE-16767.master.003.patch, > HBASE-16767.master.004.patch, HBASE-16767.master.004.patch, > HBASE-16767.master.005.patch > > > For the following lines, when it runs into IOException, it does not clean up > the files under /hbase/mobdir/.tmp and /hbase/mobdir/.tmp/.bulkload. > It could be due to creating of new mob file or new reference file under > .bulkload directory fails. Or when mob files from ./tmp to the mob region > directory fails. > https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/compactions/PartitionedMobCompactor.java#L433 > https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/compactions/PartitionedMobCompactor.java#L433 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16773) AccessController should access local region if possible
[ https://issues.apache.org/jira/browse/HBASE-16773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560356#comment-15560356 ] Ted Yu commented on HBASE-16773: The patch only solves the problem when hbase:acl is hosted on one server. If hbase:acl is split and is hosted across several servers, there may still be RPC involving PriorityRpcServer handler thread(s). One approach is to disable splitting of hbase:acl table. [~enis] [~anoop.hbase] What do you think ? > AccessController should access local region if possible > --- > > Key: HBASE-16773 > URL: https://issues.apache.org/jira/browse/HBASE-16773 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 2.0.0, 1.4.0 > > Attachments: 16773.branch-1.txt, 16773.v2.txt, 16773.v3.txt, > 16773.v4.txt, 16773.v5.txt, 16773.v6.txt, 16773.v7.txt > > > We observed the following in the stack trace of region server on a 1.1.2 > cluster: > {code} > "PriorityRpcServer.handler=19,queue=1,port=60200" #225 daemon prio=5 > os_prio=0 tid=0x7fb562296000 nid=0x81c0 runnable [0x7fb509a27000] >java.lang.Thread.State: RUNNABLE > at sun.nio.ch.EPollArrayWrapper.epollWait(Native Method) > at sun.nio.ch.EPollArrayWrapper.poll(EPollArrayWrapper.java:269) > at sun.nio.ch.EPollSelectorImpl.doSelect(EPollSelectorImpl.java:93) > at sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:86) > - locked <0x0003d4dfd770> (a sun.nio.ch.Util$2) > - locked <0x0003d4dfd760> (a java.util.Collections$UnmodifiableSet) > - locked <0x0003d4dfd648> (a sun.nio.ch.EPollSelectorImpl) > at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:97) > at > org.apache.hadoop.net.SocketIOWithTimeout$SelectorPool.select(SocketIOWithTimeout.java:335) > at > org.apache.hadoop.net.SocketIOWithTimeout.doIO(SocketIOWithTimeout.java:157) > at org.apache.hadoop.net.SocketInputStream.read(SocketInputStream.java:161) > at org.apache.hadoop.net.SocketInputStream.read(SocketInputStream.java:131) > at java.io.FilterInputStream.read(FilterInputStream.java:133) > at java.io.BufferedInputStream.fill(BufferedInputStream.java:246) > at java.io.BufferedInputStream.read(BufferedInputStream.java:265) > - locked <0x0003d7dae180> (a java.io.BufferedInputStream) > at java.io.DataInputStream.readInt(DataInputStream.java:387) > at > org.apache.hadoop.hbase.security.HBaseSaslRpcClient.readStatus(HBaseSaslRpcClient.java:151) > at > org.apache.hadoop.hbase.security.HBaseSaslRpcClient.saslConnect(HBaseSaslRpcClient.java:189) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.setupSaslConnection(RpcClientImpl.java:611) > - locked <0x0003d5c7edc0> (a > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.access$600(RpcClientImpl.java:156) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection$2.run(RpcClientImpl.java:737) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection$2.run(RpcClientImpl.java:734) > at java.security.AccessController.doPrivileged(Native Method) > at javax.security.auth.Subject.doAs(Subject.java:422) > at > org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1724) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.setupIOstreams(RpcClientImpl.java:734) > - locked <0x0003d5c7edc0> (a > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.writeRequest(RpcClientImpl.java:887) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.tracedWriteRequest(RpcClientImpl.java:856) > at org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1199) > at > org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:213) > at > org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:287) > at > org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$BlockingStub.get(ClientProtos.java:32627) > at org.apache.hadoop.hbase.client.HTable$3.call(HTable.java:854) > at org.apache.hadoop.hbase.client.HTable$3.call(HTable.java:845) > at > org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:126) > at org.apache.hadoop.hbase.client.HTable.get(HTable.java:862) > at org.apache.hadoop.hbase.client.HTable.get(HTable.java:828) > at > org.apache.hadoop.hbase.security.access.AccessControlLists.getPermissions(AccessControlLists.java:461) > at > org.apache.hadoop.hbase.security.access.AccessController.updateACL(AccessController.java:260) > at > org.apache.hadoop.hbase.security.access.AccessController.postPut(AccessControl
[jira] [Commented] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560335#comment-15560335 ] Hadoop QA commented on HBASE-16794: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 0s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 43s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 38s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 44s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 34s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 44s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 26m 18s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 11s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 48s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 76m 23s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 114m 39s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Timed out junit tests | org.apache.hadoop.hbase.client.TestReplicasClient | | | org.apache.hadoop.hbase.client.TestFromClientSide | | | org.apache.hadoop.hbase.client.TestTableSnapshotScanner | | | org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12832354/HBASE-16794.v0.patch | | JIRA Issue | HBASE-16794 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9bdb32aa970e 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / e06c367 | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/3903/artifact/patchprocess/patch-unit-hbase-server.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/3903/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/3903/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/3903/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This messa
[jira] [Commented] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560314#comment-15560314 ] Hadoop QA commented on HBASE-16794: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 54s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 45s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 40s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 43s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 33s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 44s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 26m 14s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 11s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 48s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 73m 18s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 111m 26s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.regionserver.TestHRegion | | Timed out junit tests | org.apache.hadoop.hbase.mob.TestMobDataBlockEncoding | | | org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12832350/HBASE-16794.v0.patch | | JIRA Issue | HBASE-16794 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9eea3a750b17 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / e06c367 | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/3902/artifact/patchprocess/patch-unit-hbase-server.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/3902/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/3902/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/3902/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > TestDispatchMergingReg
[jira] [Updated] (HBASE-16795) Revisit 'in project Maven repo' checked in as part of HBASE-14785
[ https://issues.apache.org/jira/browse/HBASE-16795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-16795: --- Description: I did a naive update of docs on branch-1.1 from master like so: {noformat} $ git co master src ... {noformat} and the result failed a RAT check. Looking at rat.txt I noticed we are including binaries in our source tarball, checked in as part of HBASE-14785. {noformat} HBASE-14785 Addendum: Add an in-project Maven repo src/main/site/resources/css/site.css | 1 - .../maven-fluido-skin/1.5-HBASE/maven-fluido-skin-1.5-HBASE.jar | Bin 0 -> 344936 bytes .../maven-fluido-skin/1.5-HBASE/maven-fluido-skin-1.5-HBASE.pom | 718 .../maven/skins/maven-fluido-skin/maven-metadata-local.xml | 12 + 4 files changed, 730 insertions(+), 1 deletion(-) {noformat} I'm not sure why RAT flagged this in that 1.1 build when I see that previously we have copied back docs from master into the branch. Perhaps previous copies have been more selective. This change has been committed for over a year. Let's make sure we have discussed this and determined it is appropriate. was: I did a naive update of docs on branch-1.1 from master like so: {noformat} $ git co master src ... {noformat} and the result failed a RAT check. Looking at rat.txt I noticed we are including binaries in our source tarball, checked in as part of HBASE-14785. {noformat} HBASE-14785 Addendum: Add an in-project Maven repo src/main/site/resources/css/site.css | 1 - .../maven-fluido-skin/1.5-HBASE/maven-fluido-skin-1.5-HBASE.jar | Bin 0 -> 344936 bytes .../maven-fluido-skin/1.5-HBASE/maven-fluido-skin-1.5-HBASE.pom | 718 .../maven/skins/maven-fluido-skin/maven-metadata-local.xml | 12 + 4 files changed, 730 insertions(+), 1 deletion(-) {noformat} This was not the cause of the audit check failure. This change has been committed for over a year. Let's make sure we have discussed this and determined it is appropriate. > Revisit 'in project Maven repo' checked in as part of HBASE-14785 > - > > Key: HBASE-16795 > URL: https://issues.apache.org/jira/browse/HBASE-16795 > Project: HBase > Issue Type: Bug >Reporter: Andrew Purtell > > I did a naive update of docs on branch-1.1 from master like so: > {noformat} > $ git co master src > ... > {noformat} > and the result failed a RAT check. Looking at rat.txt I noticed we are > including binaries in our source tarball, checked in as part of HBASE-14785. > {noformat} > HBASE-14785 Addendum: Add an in-project Maven repo > src/main/site/resources/css/site.css | 1 - > .../maven-fluido-skin/1.5-HBASE/maven-fluido-skin-1.5-HBASE.jar | Bin 0 -> > 344936 bytes > .../maven-fluido-skin/1.5-HBASE/maven-fluido-skin-1.5-HBASE.pom | 718 > > .../maven/skins/maven-fluido-skin/maven-metadata-local.xml | 12 + > 4 files changed, 730 insertions(+), 1 deletion(-) > {noformat} > I'm not sure why RAT flagged this in that 1.1 build when I see that > previously we have copied back docs from master into the branch. Perhaps > previous copies have been more selective. > This change has been committed for over a year. Let's make sure we have > discussed this and determined it is appropriate. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-16795) Revisit 'in project Maven repo' checked in as part of HBASE-14785
Andrew Purtell created HBASE-16795: -- Summary: Revisit 'in project Maven repo' checked in as part of HBASE-14785 Key: HBASE-16795 URL: https://issues.apache.org/jira/browse/HBASE-16795 Project: HBase Issue Type: Bug Reporter: Andrew Purtell I did a naive update of docs on branch-1.1 from master like so: {noformat} $ git co master src ... {noformat} and the result failed a RAT check. Looking at rat.txt I noticed we are including binaries in our source tarball, checked in as part of HBASE-14785. {noformat} HBASE-14785 Addendum: Add an in-project Maven repo src/main/site/resources/css/site.css | 1 - .../maven-fluido-skin/1.5-HBASE/maven-fluido-skin-1.5-HBASE.jar | Bin 0 -> 344936 bytes .../maven-fluido-skin/1.5-HBASE/maven-fluido-skin-1.5-HBASE.pom | 718 .../maven/skins/maven-fluido-skin/maven-metadata-local.xml | 12 + 4 files changed, 730 insertions(+), 1 deletion(-) {noformat} This was not the cause of the audit check failure. This change has been committed for over a year. Let's make sure we have discussed this and determined it is appropriate. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560176#comment-15560176 ] Matteo Bertozzi commented on HBASE-16794: - +1 > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky > - > > Key: HBASE-16794 > URL: https://issues.apache.org/jira/browse/HBASE-16794 > Project: HBase > Issue Type: Test > Components: test >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16794.v0.patch > > > The default count of merge thread is 1, so the merge requests submitted by > TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are > too early to check the region states, it will introduce the error. > This patch checks the number of running merge task instead of the regions > state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-16794: -- Status: Patch Available (was: Open) > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky > - > > Key: HBASE-16794 > URL: https://issues.apache.org/jira/browse/HBASE-16794 > Project: HBase > Issue Type: Test > Components: test >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16794.v0.patch > > > The default count of merge thread is 1, so the merge requests submitted by > TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are > too early to check the region states, it will introduce the error. > This patch checks the number of running merge task instead of the regions > state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-16794: -- Attachment: HBASE-16794.v0.patch > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky > - > > Key: HBASE-16794 > URL: https://issues.apache.org/jira/browse/HBASE-16794 > Project: HBase > Issue Type: Test > Components: test >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16794.v0.patch > > > The default count of merge thread is 1, so the merge requests submitted by > TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are > too early to check the region states, it will introduce the error. > This patch checks the number of running merge task instead of the regions > state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-16794: -- Status: Open (was: Patch Available) > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky > - > > Key: HBASE-16794 > URL: https://issues.apache.org/jira/browse/HBASE-16794 > Project: HBase > Issue Type: Test > Components: test >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16794.v0.patch > > > The default count of merge thread is 1, so the merge requests submitted by > TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are > too early to check the region states, it will introduce the error. > This patch checks the number of running merge task instead of the regions > state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-16794: -- Attachment: (was: HBASE-16794.v0.patch) > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky > - > > Key: HBASE-16794 > URL: https://issues.apache.org/jira/browse/HBASE-16794 > Project: HBase > Issue Type: Test > Components: test >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16794.v0.patch > > > The default count of merge thread is 1, so the merge requests submitted by > TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are > too early to check the region states, it will introduce the error. > This patch checks the number of running merge task instead of the regions > state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560162#comment-15560162 ] ChiaPing Tsai commented on HBASE-16794: --- [~mbertozzi] Mind taking a look? Thanks > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky > - > > Key: HBASE-16794 > URL: https://issues.apache.org/jira/browse/HBASE-16794 > Project: HBase > Issue Type: Test > Components: test >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16794.v0.patch > > > The default count of merge thread is 1, so the merge requests submitted by > TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are > too early to check the region states, it will introduce the error. > This patch checks the number of running merge task instead of the regions > state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai reassigned HBASE-16794: - Assignee: ChiaPing Tsai > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky > - > > Key: HBASE-16794 > URL: https://issues.apache.org/jira/browse/HBASE-16794 > Project: HBase > Issue Type: Test > Components: test >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16794.v0.patch > > > The default count of merge thread is 1, so the merge requests submitted by > TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are > too early to check the region states, it will introduce the error. > This patch checks the number of running merge task instead of the regions > state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-16794: -- Status: Patch Available (was: Open) > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky > - > > Key: HBASE-16794 > URL: https://issues.apache.org/jira/browse/HBASE-16794 > Project: HBase > Issue Type: Test > Components: test >Reporter: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16794.v0.patch > > > The default count of merge thread is 1, so the merge requests submitted by > TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are > too early to check the region states, it will introduce the error. > This patch checks the number of running merge task instead of the regions > state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-16794: -- Attachment: HBASE-16794.v0.patch > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky > - > > Key: HBASE-16794 > URL: https://issues.apache.org/jira/browse/HBASE-16794 > Project: HBase > Issue Type: Test > Components: test >Reporter: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16794.v0.patch > > > The default count of merge thread is 1, so the merge requests submitted by > TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are > too early to check the region states, it will introduce the error. > This patch checks the number of running merge task instead of the regions > state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-16794: -- Description: The default count of merge thread is 1, so the merge requests submitted by TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are too early to check the region states, it will introduce the error. This patch checks the number of running merge task instead of the regions state. was: The default count of merge thread is 1, so the merge requests submitted by TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are too early to check the region states, it will introduce the error. This patch checks the number of running merge task instead of the regions states. > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky > - > > Key: HBASE-16794 > URL: https://issues.apache.org/jira/browse/HBASE-16794 > Project: HBase > Issue Type: Test > Components: test >Reporter: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > > The default count of merge thread is 1, so the merge requests submitted by > TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are > too early to check the region states, it will introduce the error. > This patch checks the number of running merge task instead of the regions > state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-16794: -- Component/s: test > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky > - > > Key: HBASE-16794 > URL: https://issues.apache.org/jira/browse/HBASE-16794 > Project: HBase > Issue Type: Test > Components: test >Reporter: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > > The default count of merge thread is 1, so the merge requests submitted by > TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are > too early to check the region states, it will introduce the error. > This patch checks the number of running merge task instead of the regions > states. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
[ https://issues.apache.org/jira/browse/HBASE-16794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-16794: -- Fix Version/s: 2.0.0 > TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky > - > > Key: HBASE-16794 > URL: https://issues.apache.org/jira/browse/HBASE-16794 > Project: HBase > Issue Type: Test > Components: test >Reporter: ChiaPing Tsai >Priority: Minor > Fix For: 2.0.0 > > > The default count of merge thread is 1, so the merge requests submitted by > TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are > too early to check the region states, it will introduce the error. > This patch checks the number of running merge task instead of the regions > states. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-16794) TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
ChiaPing Tsai created HBASE-16794: - Summary: TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky Key: HBASE-16794 URL: https://issues.apache.org/jira/browse/HBASE-16794 Project: HBase Issue Type: Test Reporter: ChiaPing Tsai Priority: Minor The default count of merge thread is 1, so the merge requests submitted by TDMRP#testMergeRegionsConcurrently will be processed sequentially. If we are too early to check the region states, it will introduce the error. This patch checks the number of running merge task instead of the regions states. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (HBASE-16683) Address review comments for mega patch of backup / restore feature
[ https://issues.apache.org/jira/browse/HBASE-16683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved HBASE-16683. Resolution: Fixed Hadoop Flags: Reviewed > Address review comments for mega patch of backup / restore feature > -- > > Key: HBASE-16683 > URL: https://issues.apache.org/jira/browse/HBASE-16683 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Labels: backup > Attachments: 16683.v1.txt > > > There're review comments for the mega patch posted over HBASE-14123. > See https://reviews.apache.org/r/51823/ > This issue is for addressing review comments in HBASE-7912 branch. > Mega patch for master branch would be posted / tested on HBASE-14123. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (HBASE-16685) Revisit execution of SnapshotCopy in MapReduceBackupCopyService
[ https://issues.apache.org/jira/browse/HBASE-16685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved HBASE-16685. Resolution: Not A Problem After code refactoring, this is no longer applicable. > Revisit execution of SnapshotCopy in MapReduceBackupCopyService > --- > > Key: HBASE-16685 > URL: https://issues.apache.org/jira/browse/HBASE-16685 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu > Labels: backup > > During code review of backup / restore, Matteo raised comment on the > following code: > {code} > res = snapshotCp.run(options); > {code} > I think this will be a first time where HBase server has a direct dependency > on a MR job. > also we need to revisit this code to avoid having one handler blocked for N > hours while we are doing a copy. > This issue is to address the above comment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HBASE-16683) Address review comments for mega patch of backup / restore feature
[ https://issues.apache.org/jira/browse/HBASE-16683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reassigned HBASE-16683: -- Assignee: Ted Yu > Address review comments for mega patch of backup / restore feature > -- > > Key: HBASE-16683 > URL: https://issues.apache.org/jira/browse/HBASE-16683 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Labels: backup > Attachments: 16683.v1.txt > > > There're review comments for the mega patch posted over HBASE-14123. > See https://reviews.apache.org/r/51823/ > This issue is for addressing review comments in HBASE-7912 branch. > Mega patch for master branch would be posted / tested on HBASE-14123. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16745) HttpDoAsClient should handle failure in retrieving Subject
[ https://issues.apache.org/jira/browse/HBASE-16745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16745: --- Labels: thrift (was: ) > HttpDoAsClient should handle failure in retrieving Subject > -- > > Key: HBASE-16745 > URL: https://issues.apache.org/jira/browse/HBASE-16745 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Priority: Minor > Labels: thrift > Attachments: 16745.v1.txt > > > {code} > $ hbase org.apache.hadoop.hbase.thrift.HttpDoAsClient localhost 9095 hbase > security=true > Exception in thread "main" java.util.NoSuchElementException > at java.util.LinkedList$ListItr.next(LinkedList.java:890) > at javax.security.auth.Subject$SecureSet$1.next(Subject.java:1056) > at > org.apache.hadoop.hbase.thrift.HttpDoAsClient.main(HttpDoAsClient.java:85) > {code} > When Subject cannot be retrieved (e.g. due to empty ticket cache), we > shouldn't end up with NoSuchElementException. > Better error message should be given. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560011#comment-15560011 ] Hadoop QA commented on HBASE-16664: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 10m 20s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 2 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 16s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 55s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 43s {color} | {color:green} branch-1 passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s {color} | {color:green} branch-1 passed with JDK v1.7.0_80 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 52s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 28s {color} | {color:green} branch-1 passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 54s {color} | {color:red} hbase-server in branch-1 has 1 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s {color} | {color:green} branch-1 passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s {color} | {color:green} branch-1 passed with JDK v1.7.0_80 {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 6s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 43s {color} | {color:green} the patch passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 43s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s {color} | {color:green} the patch passed with JDK v1.7.0_80 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 50s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 51s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 27s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 16m 28s {color} | {color:green} The patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 24s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 19s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s {color} | {color:green} the patch passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 51s {color} | {color:green} the patch passed with JDK v1.7.0_80 {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 50s {color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 77m 13s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 26s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 125m 47s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.master.TestMasterOperationsForRegionReplicas | | | hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat | | Timed out junit tests | org.apache.hadoop.hbase.client.TestReplicasClient
[jira] [Updated] (HBASE-16773) AccessController should access local region if possible
[ https://issues.apache.org/jira/browse/HBASE-16773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16773: --- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the reviews. > AccessController should access local region if possible > --- > > Key: HBASE-16773 > URL: https://issues.apache.org/jira/browse/HBASE-16773 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 2.0.0, 1.4.0 > > Attachments: 16773.branch-1.txt, 16773.v2.txt, 16773.v3.txt, > 16773.v4.txt, 16773.v5.txt, 16773.v6.txt, 16773.v7.txt > > > We observed the following in the stack trace of region server on a 1.1.2 > cluster: > {code} > "PriorityRpcServer.handler=19,queue=1,port=60200" #225 daemon prio=5 > os_prio=0 tid=0x7fb562296000 nid=0x81c0 runnable [0x7fb509a27000] >java.lang.Thread.State: RUNNABLE > at sun.nio.ch.EPollArrayWrapper.epollWait(Native Method) > at sun.nio.ch.EPollArrayWrapper.poll(EPollArrayWrapper.java:269) > at sun.nio.ch.EPollSelectorImpl.doSelect(EPollSelectorImpl.java:93) > at sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:86) > - locked <0x0003d4dfd770> (a sun.nio.ch.Util$2) > - locked <0x0003d4dfd760> (a java.util.Collections$UnmodifiableSet) > - locked <0x0003d4dfd648> (a sun.nio.ch.EPollSelectorImpl) > at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:97) > at > org.apache.hadoop.net.SocketIOWithTimeout$SelectorPool.select(SocketIOWithTimeout.java:335) > at > org.apache.hadoop.net.SocketIOWithTimeout.doIO(SocketIOWithTimeout.java:157) > at org.apache.hadoop.net.SocketInputStream.read(SocketInputStream.java:161) > at org.apache.hadoop.net.SocketInputStream.read(SocketInputStream.java:131) > at java.io.FilterInputStream.read(FilterInputStream.java:133) > at java.io.BufferedInputStream.fill(BufferedInputStream.java:246) > at java.io.BufferedInputStream.read(BufferedInputStream.java:265) > - locked <0x0003d7dae180> (a java.io.BufferedInputStream) > at java.io.DataInputStream.readInt(DataInputStream.java:387) > at > org.apache.hadoop.hbase.security.HBaseSaslRpcClient.readStatus(HBaseSaslRpcClient.java:151) > at > org.apache.hadoop.hbase.security.HBaseSaslRpcClient.saslConnect(HBaseSaslRpcClient.java:189) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.setupSaslConnection(RpcClientImpl.java:611) > - locked <0x0003d5c7edc0> (a > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.access$600(RpcClientImpl.java:156) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection$2.run(RpcClientImpl.java:737) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection$2.run(RpcClientImpl.java:734) > at java.security.AccessController.doPrivileged(Native Method) > at javax.security.auth.Subject.doAs(Subject.java:422) > at > org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1724) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.setupIOstreams(RpcClientImpl.java:734) > - locked <0x0003d5c7edc0> (a > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.writeRequest(RpcClientImpl.java:887) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.tracedWriteRequest(RpcClientImpl.java:856) > at org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1199) > at > org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:213) > at > org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:287) > at > org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$BlockingStub.get(ClientProtos.java:32627) > at org.apache.hadoop.hbase.client.HTable$3.call(HTable.java:854) > at org.apache.hadoop.hbase.client.HTable$3.call(HTable.java:845) > at > org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:126) > at org.apache.hadoop.hbase.client.HTable.get(HTable.java:862) > at org.apache.hadoop.hbase.client.HTable.get(HTable.java:828) > at > org.apache.hadoop.hbase.security.access.AccessControlLists.getPermissions(AccessControlLists.java:461) > at > org.apache.hadoop.hbase.security.access.AccessController.updateACL(AccessController.java:260) > at > org.apache.hadoop.hbase.security.access.AccessController.postPut(AccessController.java:1661) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$32.call(RegionCoprocessorHost.java:940) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionOperation.call(RegionCoprocessorHost.java:1673) > at > org.apache.h
[jira] [Commented] (HBASE-16793) Exclude shaded protobuf files from rat check
[ https://issues.apache.org/jira/browse/HBASE-16793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15559955#comment-15559955 ] Hadoop QA commented on HBASE-16793: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s {color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 15s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 30s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 10s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 46s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 57s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 29s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 29s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 10s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s {color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 26m 19s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 1m 25s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 47s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 87m 26s {color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 132m 56s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.security.token.TestZKSecretWatcher | | Timed out junit tests | org.apache.hadoop.hbase.mapred.TestTableInputFormat | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12832342/HBASE-16793.patch | | JIRA Issue | HBASE-16793 | | Optional Tests | asflicense javac javadoc unit xml compile | | uname | Linux 6b3d63f47660 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / e06c367 | | Default Java | 1.8.0_101 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/3900/artifact/patchprocess/patch-unit-root.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/3900/artifact/patchprocess/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/3900/testReport/ | | modules | C: . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/3900/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Exclude shaded protobuf files from rat check > > >
[jira] [Updated] (HBASE-16664) Timeout logic in AsyncProcess is broken
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Yang updated HBASE-16664: -- Attachment: HBASE-16664-branch-1-v1.patch > Timeout logic in AsyncProcess is broken > --- > > Key: HBASE-16664 > URL: https://issues.apache.org/jira/browse/HBASE-16664 > Project: HBase > Issue Type: Bug >Reporter: Phil Yang >Assignee: Phil Yang > Attachments: 1.patch, HBASE-16664-branch-1-v1.patch, > HBASE-16664-v1.patch, HBASE-16664-v2.patch, HBASE-16664-v3.patch, > HBASE-16664-v4.patch, testhcm.patch > > > Have not checked the root cause, but I think timeout of all operations in > AsyncProcess is broken -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16793) Exclude shaded protobuf files from rat check
[ https://issues.apache.org/jira/browse/HBASE-16793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15559777#comment-15559777 ] Duo Zhang commented on HBASE-16793: --- [~stack] FYI. > Exclude shaded protobuf files from rat check > > > Key: HBASE-16793 > URL: https://issues.apache.org/jira/browse/HBASE-16793 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-16793.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16793) Exclude shaded protobuf files from rat check
[ https://issues.apache.org/jira/browse/HBASE-16793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16793: -- Status: Patch Available (was: Open) > Exclude shaded protobuf files from rat check > > > Key: HBASE-16793 > URL: https://issues.apache.org/jira/browse/HBASE-16793 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-16793.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16793) Exclude shaded protobuf files from rat check
[ https://issues.apache.org/jira/browse/HBASE-16793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16793: -- Attachment: HBASE-16793.patch > Exclude shaded protobuf files from rat check > > > Key: HBASE-16793 > URL: https://issues.apache.org/jira/browse/HBASE-16793 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-16793.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-16793) Exclude shaded protobuf files from rat check
Duo Zhang created HBASE-16793: - Summary: Exclude shaded protobuf files from rat check Key: HBASE-16793 URL: https://issues.apache.org/jira/browse/HBASE-16793 Project: HBase Issue Type: Bug Components: build Affects Versions: 2.0.0 Reporter: Duo Zhang Assignee: Duo Zhang Fix For: 2.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15559755#comment-15559755 ] Duo Zhang commented on HBASE-15921: --- {noformat} Running unit tests cd /testptch/hbase/hbase-common mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-patch-1 -DHBasePatchProcess -PrunAllTests clean test -fae > /testptch/patchprocess/patch-unit-hbase-common.txt 2>&1 Elapsed: 1m 37s cd /testptch/hbase/hbase-client mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-patch-1 -DHBasePatchProcess -PrunAllTests clean test -fae > /testptch/patchprocess/patch-unit-hbase-client.txt 2>&1 Elapsed: 0m 53s cd /testptch/hbase/hbase-server mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-patch-1 -DHBasePatchProcess -PrunAllTests clean test -fae > /testptch/patchprocess/patch-unit-hbase-server.txt 2>&1 Elapsed: 93m 11s cd /testptch/hbase mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-patch-1 -DHBasePatchProcess -PrunAllTests clean test -fae > /testptch/patchprocess/patch-unit-root.txt 2>&1 Elapsed: 95m 44s Determining number of ASF License errors cd /testptch/hbase/hbase-common mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-patch-1 -DHBasePatchProcess -fn apache-rat:check > /testptch/patchprocess/patch-asflicense-hbase-common.txt 2>&1 Elapsed: 0m 13s cd /testptch/hbase/hbase-client mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-patch-1 -DHBasePatchProcess -fn apache-rat:check > /testptch/patchprocess/patch-asflicense-hbase-client.txt 2>&1 Elapsed: 0m 11s cd /testptch/hbase/hbase-server mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-patch-1 -DHBasePatchProcess -fn apache-rat:check > /testptch/patchprocess/patch-asflicense-hbase-server.txt 2>&1 Elapsed: 0m 12s cd /testptch/hbase mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-patch-1 -DHBasePatchProcess -fn apache-rat:check > /testptch/patchprocess/patch-asflicense-root.txt 2>&1 Elapsed: 0m 21s There appear to be 140 ASF License warnings after applying the patch. {noformat} [~busbey] I think yetus could do better here. As I changed the pom.xml, yetus will execute some checks at root. The problem is, if we decide to run command at root, I do not think we need to run command in other modules then? Thanks. > Add first AsyncTable impl and create TableImpl based on it > -- > > Key: HBASE-15921 > URL: https://issues.apache.org/jira/browse/HBASE-15921 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: Jurriaan Mous >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-15921-v2.patch, HBASE-15921-v3.patch, > HBASE-15921-v4.patch, HBASE-15921-v5.patch, HBASE-15921.demo.patch, > HBASE-15921.patch, HBASE-15921.v1.patch > > > First we create an AsyncTable interface with implementation without the Scan > functionality. Those will land in a separate patch since they need a refactor > of existing scans. > Also added is a new TableImpl to replace HTable. It uses the AsyncTableImpl > internally and should be a bit faster because it does jump through less hoops > to do ProtoBuf transportation. This way we can run all existing tests on the > AsyncTableImpl to guarantee its quality. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16773) AccessController should access local region if possible
[ https://issues.apache.org/jira/browse/HBASE-16773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15559736#comment-15559736 ] Hudson commented on HBASE-16773: FAILURE: Integrated in Jenkins build HBase-1.4 #454 (See [https://builds.apache.org/job/HBase-1.4/454/]) HBASE-16773 AccessController should access local region if possible (tedyu: rev 4b75614a2e5e2c78dc4ca9b14f285b52797f238c) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestTablePermissions.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java > AccessController should access local region if possible > --- > > Key: HBASE-16773 > URL: https://issues.apache.org/jira/browse/HBASE-16773 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 2.0.0, 1.4.0 > > Attachments: 16773.branch-1.txt, 16773.v2.txt, 16773.v3.txt, > 16773.v4.txt, 16773.v5.txt, 16773.v6.txt, 16773.v7.txt > > > We observed the following in the stack trace of region server on a 1.1.2 > cluster: > {code} > "PriorityRpcServer.handler=19,queue=1,port=60200" #225 daemon prio=5 > os_prio=0 tid=0x7fb562296000 nid=0x81c0 runnable [0x7fb509a27000] >java.lang.Thread.State: RUNNABLE > at sun.nio.ch.EPollArrayWrapper.epollWait(Native Method) > at sun.nio.ch.EPollArrayWrapper.poll(EPollArrayWrapper.java:269) > at sun.nio.ch.EPollSelectorImpl.doSelect(EPollSelectorImpl.java:93) > at sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:86) > - locked <0x0003d4dfd770> (a sun.nio.ch.Util$2) > - locked <0x0003d4dfd760> (a java.util.Collections$UnmodifiableSet) > - locked <0x0003d4dfd648> (a sun.nio.ch.EPollSelectorImpl) > at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:97) > at > org.apache.hadoop.net.SocketIOWithTimeout$SelectorPool.select(SocketIOWithTimeout.java:335) > at > org.apache.hadoop.net.SocketIOWithTimeout.doIO(SocketIOWithTimeout.java:157) > at org.apache.hadoop.net.SocketInputStream.read(SocketInputStream.java:161) > at org.apache.hadoop.net.SocketInputStream.read(SocketInputStream.java:131) > at java.io.FilterInputStream.read(FilterInputStream.java:133) > at java.io.BufferedInputStream.fill(BufferedInputStream.java:246) > at java.io.BufferedInputStream.read(BufferedInputStream.java:265) > - locked <0x0003d7dae180> (a java.io.BufferedInputStream) > at java.io.DataInputStream.readInt(DataInputStream.java:387) > at > org.apache.hadoop.hbase.security.HBaseSaslRpcClient.readStatus(HBaseSaslRpcClient.java:151) > at > org.apache.hadoop.hbase.security.HBaseSaslRpcClient.saslConnect(HBaseSaslRpcClient.java:189) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.setupSaslConnection(RpcClientImpl.java:611) > - locked <0x0003d5c7edc0> (a > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.access$600(RpcClientImpl.java:156) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection$2.run(RpcClientImpl.java:737) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection$2.run(RpcClientImpl.java:734) > at java.security.AccessController.doPrivileged(Native Method) > at javax.security.auth.Subject.doAs(Subject.java:422) > at > org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1724) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.setupIOstreams(RpcClientImpl.java:734) > - locked <0x0003d5c7edc0> (a > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.writeRequest(RpcClientImpl.java:887) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.tracedWriteRequest(RpcClientImpl.java:856) > at org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1199) > at > org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:213) > at > org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:287) > at > org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$BlockingStub.get(ClientProtos.java:32627) > at org.apache.hadoop.hbase.client.HTable$3.call(HTable.java:854) > at org.apache.hadoop.hbase.client.HTable$3.call(HTable.java:845) > at > org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:126) > at org.apache.hadoop.hbase.client.HTable.get(HTable.java:862) > at org.apache.hadoop.hbase.client.HTable.get(HTable.java:828) > at > org.apache.hadoop.hbase.security.access.AccessControlLists.getPermiss
[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15559708#comment-15559708 ] Hadoop QA commented on HBASE-15921: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 2 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 18s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 20s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 42s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 14s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 35s {color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s {color} | {color:blue} Skipped patched modules with no Java source: . {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 53s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 40s {color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 7s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 34s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 34s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 14s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 37s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 3s {color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 26m 20s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 1m 53s {color} | {color:green} the patch passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s {color} | {color:blue} Skipped patched modules with no Java source: . {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 18s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 40s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 37s {color} | {color:green} hbase-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 53s {color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 93m 11s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 95m 44s {color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 57s {color} | {color:red} The patch generated 140 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 254m 2s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Timed out junit tests | org.apache.hadoop.hbase.client.TestReplicasClient | | | org.apache.hadoop.hbase.client.TestFromClientSide | | | org.apache.hadoop.hbase.procedure.TestZKProcedureControllers | | | org.apache.hadoop.hbase.client.TestFromClientSide3 | | | org.apache.hadoop.hbase.client.TestTableSnapshotScanner | | | org.apache.hadoop.hbase.clien
[jira] [Updated] (HBASE-16792) Reuse KeyValue.KeyOnlyKeyValue in BufferedDataBlockEncoder.SeekerState
[ https://issues.apache.org/jira/browse/HBASE-16792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] binlijin updated HBASE-16792: - Assignee: binlijin Affects Version/s: 2.0.0 Priority: Minor (was: Major) > Reuse KeyValue.KeyOnlyKeyValue in BufferedDataBlockEncoder.SeekerState > -- > > Key: HBASE-16792 > URL: https://issues.apache.org/jira/browse/HBASE-16792 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: binlijin >Assignee: binlijin >Priority: Minor > Attachments: HBASE-16792_master.patch > > > When every SeekerState#invalidate will new a fresh KeyValue.KeyOnlyKeyValue, > we should reuse it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16792) Reuse KeyValue.KeyOnlyKeyValue in BufferedDataBlockEncoder.SeekerState
[ https://issues.apache.org/jira/browse/HBASE-16792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] binlijin updated HBASE-16792: - Attachment: HBASE-16792_master.patch > Reuse KeyValue.KeyOnlyKeyValue in BufferedDataBlockEncoder.SeekerState > -- > > Key: HBASE-16792 > URL: https://issues.apache.org/jira/browse/HBASE-16792 > Project: HBase > Issue Type: Improvement >Reporter: binlijin > Attachments: HBASE-16792_master.patch > > > When every SeekerState#invalidate will new a fresh KeyValue.KeyOnlyKeyValue, > we should reuse it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)