[jira] [Commented] (HBASE-18267) The result from the postAppend is ignored
[
https://issues.apache.org/jira/browse/HBASE-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079898#comment-16079898
]
Chia-Ping Tsai commented on HBASE-18267:
[~anoop.hbase] Thanks for the reviews. Will commit it tomorrow unless any
objection is raised.
> The result from the postAppend is ignored
> -
>
> Key: HBASE-18267
> URL: https://issues.apache.org/jira/browse/HBASE-18267
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.0, 1.3.1, 1.2.6, 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2
>
> Attachments: HBASE-18267.branch-1.2.v0.patch,
> HBASE-18267.branch-1.3.v0.patch, HBASE-18267.branch-1.v0.patch,
> HBASE-18267.v0.patch, HBASE-18267.v1.patch
>
>
> {code:title=RegionCoprocessorHost.java|borderStyle=solid}
> /**
>* @param append Append object
>* @param result the result returned by the append
>* @throws IOException if an error occurred on the coprocessor
>*/
> public void postAppend(final Append append, final Result result) throws
> IOException {
> execOperation(coprocessors.isEmpty() ? null : new RegionOperation() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> oserver.postAppend(ctx, append, result);
> }
> });
> }
> /**
>* @param increment increment object
>* @param result the result returned by postIncrement
>* @throws IOException if an error occurred on the coprocessor
>*/
> public Result postIncrement(final Increment increment, Result result)
> throws IOException {
> return execOperationWithResult(result,
> coprocessors.isEmpty() ? null : new
> RegionOperationWithResult() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> setResult(oserver.postIncrement(ctx, increment, getResult()));
> }
> });
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[
https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079876#comment-16079876
]
Anoop Sam John commented on HBASE-18295:
On the patch, now u put together 3 switch cases and within that if else
condition. That is done for sharing the new call to needToReturn(). But can
we do the old way of own switch case itself ? It is just 3 or 4 lines that u
can repeat. Than this way of case and within if else, that will be more easy
to read and understand.
{code}
if (nextKV != null) {
703 seekAsDirection(nextKV);
704 } else {
705 heap.next();
706 break;
707 }
{code}
What is that break?
> The result contains the cells across different rows
>
>
> Key: HBASE-18295
> URL: https://issues.apache.org/jira/browse/HBASE-18295
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.0, 1.3.1, 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Blocker
> Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2
>
> Attachments: HBASE-18295.branch-1.3.v0.patch,
> HBASE-18295.branch-1.3.v1.patch, HBASE-18295.branch-1.v0.patch,
> HBASE-18295.branch-1.v1.patch, HBASE-18295.branch-1.v1.patch,
> HBASE-18295.branch-1.v1.patch, HBASE-18295.v0.patch, HBASE-18295.v1.patch,
> HBASE-18295.v2.patch, HBASE-18295.v2.patch
>
>
> From the [flaky
> dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html]
> If we use the cell which won't be flushed into disk as the top cell to reopen
> the scanners, the new top cell will change. If the new top cell is in
> different row, the matcher will reset, and then matcher will accept the new
> top cell...
> The TestStore# testFlushBeforeCompletingScan reproduces the bug.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-17908) Upgrade guava
[ https://issues.apache.org/jira/browse/HBASE-17908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17908: -- Attachment: HBASE-17908.master.024.patch > Upgrade guava > - > > Key: HBASE-17908 > URL: https://issues.apache.org/jira/browse/HBASE-17908 > Project: HBase > Issue Type: Sub-task > Components: dependencies >Reporter: Balazs Meszaros >Assignee: stack >Priority: Critical > Fix For: 2.0.0 > > Attachments: 0001-HBASE-17908-Upgrade-guava.022.patch, > HBASE-17908.master.001.patch, HBASE-17908.master.002.patch, > HBASE-17908.master.003.patch, HBASE-17908.master.004.patch, > HBASE-17908.master.005.patch, HBASE-17908.master.006.patch, > HBASE-17908.master.007.patch, HBASE-17908.master.008.patch, > HBASE-17908.master.009.patch, HBASE-17908.master.010.patch, > HBASE-17908.master.011.patch, HBASE-17908.master.012.patch, > HBASE-17908.master.013.patch, HBASE-17908.master.013.patch, > HBASE-17908.master.014.patch, HBASE-17908.master.015.patch, > HBASE-17908.master.015.patch, HBASE-17908.master.016.patch, > HBASE-17908.master.017.patch, HBASE-17908.master.018.patch, > HBASE-17908.master.019.patch, HBASE-17908.master.020.patch, > HBASE-17908.master.021.patch, HBASE-17908.master.021.patch, > HBASE-17908.master.022.patch, HBASE-17908.master.023.patch, > HBASE-17908.master.024.patch > > > Currently we are using guava 12.0.1, but the latest version is 21.0. > Upgrading guava is always a hassle because it is not always backward > compatible with itself. > Currently I think there are to approaches: > 1. Upgrade guava to the newest version (21.0) and shade it. > 2. Upgrade guava to a version which does not break or builds (15.0). > If we can update it, some dependencies should be removed: > commons-collections, commons-codec, ... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18307) Share the same EventLoopGroup for NettyRpcServer, NettyRpcClient and AsyncFSWALProvider at RS side
[
https://issues.apache.org/jira/browse/HBASE-18307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079858#comment-16079858
]
Hadoop QA commented on HBASE-18307:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 6 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
29s{color} | {color:red} hbase-server in master has 10 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
26m 49s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}118m 23s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}158m 42s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:757bf37 |
| JIRA Issue | HBASE-18307 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12876352/HBASE-18307-v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux b0124b111c1a 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / c48bb67 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/7591/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/7591/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7591/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7591/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Share the same EventLoopGroup for NettyRpcServer, NettyRpcClient and
> AsyncFSWALProvider at RS side
>
[jira] [Commented] (HBASE-18307) Share the same EventLoopGroup for NettyRpcServer, NettyRpcClient and AsyncFSWALProvider at RS side
[
https://issues.apache.org/jira/browse/HBASE-18307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079840#comment-16079840
]
Duo Zhang commented on HBASE-18307:
---
{quote}
The default thread number is 0?
{quote}
'0' means use the default setting of netty, usually 2 * CPU core count.
{quote}
Why acceptor and client use one EventLoopGroup?
{quote}
See here
https://stackoverflow.com/questions/28331809/netty-bootstrap-with-boss-group-or-with-just-with-workers-eventloopgroup
Norman Maurer is one of the authors of netty. It is OK to use the same event
loop group. The name 'boss' and 'worker' are inherited from netty3. There are
two types of event loop group in netty3 for accept and read/write, and in netty
4 they are unified.
{quote}
How about add a helper class for passing config to NettyRpcServer, similar with
NettyRpcClientConfigHelper and NettyAsyncFSWALConfigHelper? Then we can remove
the cast code in NettyRpcServer.
{quote}
I think cast is simpler and shorter than introduce a new class... And I think
we will finally add a method to the interface, after the cleanup of
IA.LimitedPrivate interfaces in HBASE-18169.
Thanks.
> Share the same EventLoopGroup for NettyRpcServer, NettyRpcClient and
> AsyncFSWALProvider at RS side
> --
>
> Key: HBASE-18307
> URL: https://issues.apache.org/jira/browse/HBASE-18307
> Project: HBase
> Issue Type: Improvement
> Components: io, rpc, wal
>Affects Versions: 3.0.0, 2.0.0-alpha-1
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18307.patch, HBASE-18307-v1.patch
>
>
> Need a find a proper way to pass a EventLoopGroup instance through a
> Configuration object.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-16057) Regions never get online when the region server fails to handle the OpenRegionRequest before the rpc timeout
[
https://issues.apache.org/jira/browse/HBASE-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079844#comment-16079844
]
Allan Yang commented on HBASE-16057:
What HBase version are you using?
> Regions never get online when the region server fails to handle the
> OpenRegionRequest before the rpc timeout
>
>
> Key: HBASE-16057
> URL: https://issues.apache.org/jira/browse/HBASE-16057
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Shuai Lin
>
> (See the mailing list archive
> [here|http://mail-archives.apache.org/mod_mbox/hbase-user/201605.mbox/%3CCA+VO6itpGgRzOPBuEphSo5ROYumD9_x1=pa9n0wmv-c+oxh...@mail.gmail.com%3E]
> or [here with a better
> layout|http://search-hadoop.com/m/YGbb5BVXb164SIM=Some+regions+never+get+online+after+a+region+server+crashes])
> We have hbase cluster of 3 masters and 7 region servers. One of the region
> server crashed, but some regions never got
> online again on other RSes. I've gone through the logs, and here is the
> timeline about some of the events:
> * 13:03:50 on of the region server, rs-node7, died because of a disk
> failure. Master started to split rs-node7's WALs
> {code}
> 2016-04-30 13:03:50,953 INFO
> org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Splitting
> logs for rs-node7.example.com,60020,1458724695128 before assignment; region
> count=133
> 2016-04-30 13:03:50,966 DEBUG
> org.apache.hadoop.hbase.master.SplitLogManager: Scheduling batch of logs to
> split
> 2016-04-30 13:03:50,966 INFO
> org.apache.hadoop.hbase.master.SplitLogManager: started splitting 33 logs
> in
> [hdfs://nameservice1/hbase/WALs/rs-node7.example.com,60020,1458724695128-splitting]
> for [rs-node7.example.com,60020,1458724695128]
> * 13:10:47 WAL splits done, master began to re-assign regions
> 2016-04-30 13:10:47,655 INFO
> org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Reassigning
> 133 region(s) that rs-node7.example.com,60020,1458724695128 was carrying
> (and 0 regions(s) that were opening on this server)
> 2016-04-30 13:10:47,665 INFO
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 133
> region(s) across 6 server(s), round-robin=true
> 2016-04-30 13:10:47,667 INFO
> org.apache.hadoop.hbase.master.AssignmentManager: Assigning 22 region(s) to
> rs-node1.example.com,60020,1458720625688
> 2016-04-30 13:10:47,667 INFO
> org.apache.hadoop.hbase.master.AssignmentManager: Assigning 22 region(s) to
> rs-node2.example.com,60020,1458721110988
> 2016-04-30 13:10:47,667 INFO
> org.apache.hadoop.hbase.master.AssignmentManager: Assigning 22 region(s) to
> rs-node3.example.com,60020,1458721713906
> 2016-04-30 13:10:47,679 INFO
> org.apache.hadoop.hbase.master.AssignmentManager: Assigning 23 region(s) to
> rs-node4.example.com,60020,1458722335527
> 2016-04-30 13:10:47,691 INFO
> org.apache.hadoop.hbase.master.AssignmentManager: Assigning 22 region(s) to
> rs-node5.example.com,60020,1458722992296
> 2016-04-30 13:10:47,702 INFO
> org.apache.hadoop.hbase.master.AssignmentManager: Assigning 22 region(s) to
> rs-node6.example.com,60020,1458723856883
> {code}
> * 13:11:47 the opening regions rpc sent by master to region servers timed
> out after 1 minutes
> {code}
> 2016-04-30 13:11:47,780 INFO
> org.apache.hadoop.hbase.master.AssignmentManager: Unable to communicate
> with rs-node3.example.com,60020,1458721713906 in order to assign regions
> java.io.IOException: Call to rs-node3.example.com/172.16.6.3:60020 failed
> on local exception: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call
> id=4, waitTime=60001, operationTimeout=6 expired.
> 2016-04-30 13:11:47,782 INFO
> org.apache.hadoop.hbase.master.GeneralBulkAssigner: Failed assigning 22
> regions to server rs-node6.example.com,60020,1458723856883, reassigning them
> 2016-04-30 13:11:47,782 INFO
> org.apache.hadoop.hbase.master.GeneralBulkAssigner: Failed assigning 23
> regions to server rs-node4.example.com,60020,1458722335527, reassigning them
> 2016-04-30 13:11:47,782 INFO
> org.apache.hadoop.hbase.master.GeneralBulkAssigner: Failed assigning 22
> regions to server rs-node3.example.com,60020,1458721713906, reassigning them
> 2016-04-30 13:11:47,783 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Force region state
> offline {a65660e421f114e93862194f7cc35644 state=OPENING, ts=1462021907753,
> server=rs-node6.example.com,60020,1458723856883}
> {code}
> * After that, part of the regions (40 out of 130 regions) never got online,
> and the following lines were logged repeatly in master log:
> {code}
> 2016-04-30 13:12:37,188 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: update
> {d1c7f3f455f2529da82a2f713b5ee067 state=PENDING_OPEN, ts=1462021957087,
> server=rs-node6.example.com,60020,1458723856883} the
[jira] [Commented] (HBASE-18307) Share the same EventLoopGroup for NettyRpcServer, NettyRpcClient and AsyncFSWALProvider at RS side
[
https://issues.apache.org/jira/browse/HBASE-18307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079830#comment-16079830
]
Guanghao Zhang commented on HBASE-18307:
bq. int workerCount = conf.getInt("hbase.netty.worker.count", 0);
The default thread number is 0?
bq. ServerBootstrap bootstrap = new
ServerBootstrap().group(eventLoopGroup).channel(channelClass)
Why acceptor and client use one EventLoopGroup?
How about add a helper class for passing config to NettyRpcServer, similar with
NettyRpcClientConfigHelper and NettyAsyncFSWALConfigHelper? Then we can remove
the cast code in NettyRpcServer.
> Share the same EventLoopGroup for NettyRpcServer, NettyRpcClient and
> AsyncFSWALProvider at RS side
> --
>
> Key: HBASE-18307
> URL: https://issues.apache.org/jira/browse/HBASE-18307
> Project: HBase
> Issue Type: Improvement
> Components: io, rpc, wal
>Affects Versions: 3.0.0, 2.0.0-alpha-1
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18307.patch, HBASE-18307-v1.patch
>
>
> Need a find a proper way to pass a EventLoopGroup instance through a
> Configuration object.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17908) Upgrade guava
[ https://issues.apache.org/jira/browse/HBASE-17908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079802#comment-16079802 ] stack commented on HBASE-17908: --- Build seems to be settling again (thanks @appy for fixing flakies dashboard). .024 is rebase. Patch is half the size because I did not update the pb version from 3.2 => 3.3 (we are still using checked in pb w/ this patch). > Upgrade guava > - > > Key: HBASE-17908 > URL: https://issues.apache.org/jira/browse/HBASE-17908 > Project: HBase > Issue Type: Sub-task > Components: dependencies >Reporter: Balazs Meszaros >Assignee: stack >Priority: Critical > Fix For: 2.0.0 > > Attachments: 0001-HBASE-17908-Upgrade-guava.022.patch, > HBASE-17908.master.001.patch, HBASE-17908.master.002.patch, > HBASE-17908.master.003.patch, HBASE-17908.master.004.patch, > HBASE-17908.master.005.patch, HBASE-17908.master.006.patch, > HBASE-17908.master.007.patch, HBASE-17908.master.008.patch, > HBASE-17908.master.009.patch, HBASE-17908.master.010.patch, > HBASE-17908.master.011.patch, HBASE-17908.master.012.patch, > HBASE-17908.master.013.patch, HBASE-17908.master.013.patch, > HBASE-17908.master.014.patch, HBASE-17908.master.015.patch, > HBASE-17908.master.015.patch, HBASE-17908.master.016.patch, > HBASE-17908.master.017.patch, HBASE-17908.master.018.patch, > HBASE-17908.master.019.patch, HBASE-17908.master.020.patch, > HBASE-17908.master.021.patch, HBASE-17908.master.021.patch, > HBASE-17908.master.022.patch, HBASE-17908.master.023.patch, > HBASE-17908.master.024.patch > > > Currently we are using guava 12.0.1, but the latest version is 21.0. > Upgrading guava is always a hassle because it is not always backward > compatible with itself. > Currently I think there are to approaches: > 1. Upgrade guava to the newest version (21.0) and shade it. > 2. Upgrade guava to a version which does not break or builds (15.0). > If we can update it, some dependencies should be removed: > commons-collections, commons-codec, ... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18307) Share the same EventLoopGroup for NettyRpcServer, NettyRpcClient and AsyncFSWALProvider at RS side
[ https://issues.apache.org/jira/browse/HBASE-18307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-18307: -- Attachment: HBASE-18307-v1.patch Minor cleanup or imports. > Share the same EventLoopGroup for NettyRpcServer, NettyRpcClient and > AsyncFSWALProvider at RS side > -- > > Key: HBASE-18307 > URL: https://issues.apache.org/jira/browse/HBASE-18307 > Project: HBase > Issue Type: Improvement > Components: io, rpc, wal >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18307.patch, HBASE-18307-v1.patch > > > Need a find a proper way to pass a EventLoopGroup instance through a > Configuration object. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18318) Implement updateConfiguration/stopMaster/stopRegionServer/shutdown methods
[ https://issues.apache.org/jira/browse/HBASE-18318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079793#comment-16079793 ] Duo Zhang commented on HBASE-18318: --- +1. > Implement updateConfiguration/stopMaster/stopRegionServer/shutdown methods > -- > > Key: HBASE-18318 > URL: https://issues.apache.org/jira/browse/HBASE-18318 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18318.master.001.patch, > HBASE-18318.master.002.patch, HBASE-18318.master.003.patch, > HBASE-18318.master.004.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18307) Share the same EventLoopGroup for NettyRpcServer, NettyRpcClient and AsyncFSWALProvider at RS side
[ https://issues.apache.org/jira/browse/HBASE-18307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079788#comment-16079788 ] Duo Zhang commented on HBASE-18307: --- Any comments? Thanks. > Share the same EventLoopGroup for NettyRpcServer, NettyRpcClient and > AsyncFSWALProvider at RS side > -- > > Key: HBASE-18307 > URL: https://issues.apache.org/jira/browse/HBASE-18307 > Project: HBase > Issue Type: Improvement > Components: io, rpc, wal >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18307.patch > > > Need a find a proper way to pass a EventLoopGroup instance through a > Configuration object. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18318) Implement updateConfiguration/stopMaster/stopRegionServer/shutdown methods
[ https://issues.apache.org/jira/browse/HBASE-18318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079783#comment-16079783 ] Guanghao Zhang commented on HBASE-18318: The failed TestServerCrashProcedure not related. [~Apache9] Any more concerns? Thanks. > Implement updateConfiguration/stopMaster/stopRegionServer/shutdown methods > -- > > Key: HBASE-18318 > URL: https://issues.apache.org/jira/browse/HBASE-18318 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18318.master.001.patch, > HBASE-18318.master.002.patch, HBASE-18318.master.003.patch, > HBASE-18318.master.004.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18318) Implement updateConfiguration/stopMaster/stopRegionServer/shutdown methods
[
https://issues.apache.org/jira/browse/HBASE-18318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079689#comment-16079689
]
Hadoop QA commented on HBASE-18318:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
29s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
5s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
59s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
32s{color} | {color:red} hbase-client in master has 4 extant Findbugs warnings.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 8m
12s{color} | {color:red} hbase-server in master has 10 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
14s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
44s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
77m 35s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 11m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 5m
11s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}217m 12s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
43s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}354m 54s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.procedure.TestServerCrashProcedure |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:757bf37 |
| JIRA Issue | HBASE-18318 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12876320/HBASE-18318.master.004.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 728c68aeb883 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / c48bb67 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| findbugs |
[jira] [Commented] (HBASE-18267) The result from the postAppend is ignored
[
https://issues.apache.org/jira/browse/HBASE-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079677#comment-16079677
]
Hadoop QA commented on HBASE-18267:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
13s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
27s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
30s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
39s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
27s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
29s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
11m 0s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 73m
44s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 96m 50s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:2fc26cc |
| JIRA Issue | HBASE-18267 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12876325/HBASE-18267.branch-1.2.v0.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux b4417a924327 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/hbase.sh |
| git revision | branch-1.2 / 8a996e3 |
| Default Java | 1.7.0_131 |
| Multi-JDK versions |
[jira] [Comment Edited] (HBASE-18338) [C++] Implement RpcTestServer
[ https://issues.apache.org/jira/browse/HBASE-18338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078753#comment-16078753 ] Xiaobing Zhou edited comment on HBASE-18338 at 7/9/17 4:58 PM: --- Posted v0. # simplified the implementation a lot. # added RpcTestServerHandler and RpcTestServerPipelineFactory # added test.proto and test_rpc_service.proto from Java side in order to implement server stubs like echo/ping Will add implementation of server stubs by hooking protobuf engine into RpcTestServerHandler in next patch. was (Author: xiaobingo): Posted v0. # simplified the implementation a lot. # added RpcTestServerHandler and RpcTestServerPipelineFactory # added test.proto and test_rpc_service.proto from Java side in order to implement server stubs like echo/ping Will add implementation of server stubs to hook protobuf engine into RpcTestServerHandler in next patch. > [C++] Implement RpcTestServer > - > > Key: HBASE-18338 > URL: https://issues.apache.org/jira/browse/HBASE-18338 > Project: HBase > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HBASE-18338.000.patch > > > This is a spin-off from HBASE-18078. We need RpcTestServer to simulate > various communication scenarios, e.g. timeout, connection aborted, long > running services and so on. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18316) Implement async admin operations for draining region servers
[ https://issues.apache.org/jira/browse/HBASE-18316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079661#comment-16079661 ] Hudson commented on HBASE-18316: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #3344 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3344/]) HBASE-18316 Implement async admin operations for draining region servers (zghao: rev c48bb67123e7bd622c567393097d81665dc5fff8) * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncDrainAdminApi.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncHBaseAdmin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java > Implement async admin operations for draining region servers > > > Key: HBASE-18316 > URL: https://issues.apache.org/jira/browse/HBASE-18316 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18316.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18267) The result from the postAppend is ignored
[
https://issues.apache.org/jira/browse/HBASE-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18267:
---
Status: Open (was: Patch Available)
> The result from the postAppend is ignored
> -
>
> Key: HBASE-18267
> URL: https://issues.apache.org/jira/browse/HBASE-18267
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0-alpha-1, 1.2.6, 1.3.1, 1.3.0
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2
>
> Attachments: HBASE-18267.branch-1.2.v0.patch,
> HBASE-18267.branch-1.3.v0.patch, HBASE-18267.branch-1.v0.patch,
> HBASE-18267.v0.patch, HBASE-18267.v1.patch
>
>
> {code:title=RegionCoprocessorHost.java|borderStyle=solid}
> /**
>* @param append Append object
>* @param result the result returned by the append
>* @throws IOException if an error occurred on the coprocessor
>*/
> public void postAppend(final Append append, final Result result) throws
> IOException {
> execOperation(coprocessors.isEmpty() ? null : new RegionOperation() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> oserver.postAppend(ctx, append, result);
> }
> });
> }
> /**
>* @param increment increment object
>* @param result the result returned by postIncrement
>* @throws IOException if an error occurred on the coprocessor
>*/
> public Result postIncrement(final Increment increment, Result result)
> throws IOException {
> return execOperationWithResult(result,
> coprocessors.isEmpty() ? null : new
> RegionOperationWithResult() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> setResult(oserver.postIncrement(ctx, increment, getResult()));
> }
> });
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18267) The result from the postAppend is ignored
[
https://issues.apache.org/jira/browse/HBASE-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18267:
---
Attachment: HBASE-18267.branch-1.2.v0.patch
All failed tests pass on my machine.
> The result from the postAppend is ignored
> -
>
> Key: HBASE-18267
> URL: https://issues.apache.org/jira/browse/HBASE-18267
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.0, 1.3.1, 1.2.6, 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2
>
> Attachments: HBASE-18267.branch-1.2.v0.patch,
> HBASE-18267.branch-1.3.v0.patch, HBASE-18267.branch-1.v0.patch,
> HBASE-18267.v0.patch, HBASE-18267.v1.patch
>
>
> {code:title=RegionCoprocessorHost.java|borderStyle=solid}
> /**
>* @param append Append object
>* @param result the result returned by the append
>* @throws IOException if an error occurred on the coprocessor
>*/
> public void postAppend(final Append append, final Result result) throws
> IOException {
> execOperation(coprocessors.isEmpty() ? null : new RegionOperation() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> oserver.postAppend(ctx, append, result);
> }
> });
> }
> /**
>* @param increment increment object
>* @param result the result returned by postIncrement
>* @throws IOException if an error occurred on the coprocessor
>*/
> public Result postIncrement(final Increment increment, Result result)
> throws IOException {
> return execOperationWithResult(result,
> coprocessors.isEmpty() ? null : new
> RegionOperationWithResult() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> setResult(oserver.postIncrement(ctx, increment, getResult()));
> }
> });
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18267) The result from the postAppend is ignored
[
https://issues.apache.org/jira/browse/HBASE-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18267:
---
Status: Patch Available (was: Open)
> The result from the postAppend is ignored
> -
>
> Key: HBASE-18267
> URL: https://issues.apache.org/jira/browse/HBASE-18267
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0-alpha-1, 1.2.6, 1.3.1, 1.3.0
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2
>
> Attachments: HBASE-18267.branch-1.2.v0.patch,
> HBASE-18267.branch-1.3.v0.patch, HBASE-18267.branch-1.v0.patch,
> HBASE-18267.v0.patch, HBASE-18267.v1.patch
>
>
> {code:title=RegionCoprocessorHost.java|borderStyle=solid}
> /**
>* @param append Append object
>* @param result the result returned by the append
>* @throws IOException if an error occurred on the coprocessor
>*/
> public void postAppend(final Append append, final Result result) throws
> IOException {
> execOperation(coprocessors.isEmpty() ? null : new RegionOperation() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> oserver.postAppend(ctx, append, result);
> }
> });
> }
> /**
>* @param increment increment object
>* @param result the result returned by postIncrement
>* @throws IOException if an error occurred on the coprocessor
>*/
> public Result postIncrement(final Increment increment, Result result)
> throws IOException {
> return execOperationWithResult(result,
> coprocessors.isEmpty() ? null : new
> RegionOperationWithResult() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> setResult(oserver.postIncrement(ctx, increment, getResult()));
> }
> });
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18267) The result from the postAppend is ignored
[
https://issues.apache.org/jira/browse/HBASE-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079645#comment-16079645
]
Hadoop QA commented on HBASE-18267:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 33m
26s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
43s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
30s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s{color} | {color:green} branch-1.3 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m
27s{color} | {color:red} hbase-server in branch-1.3 has 17 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
1s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
33m 20s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}199m 46s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
27s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}287m 18s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestAdmin1 |
| | hadoop.hbase.regionserver.TestRegionReplicas |
| | hadoop.hbase.regionserver.TestPerColumnFamilyFlush |
| | hadoop.hbase.client.TestAdmin2 |
| | hadoop.hbase.TestPartialResultsFromClientSide |
| | hadoop.hbase.regionserver.TestRegionServerHostname |
| Timed out junit tests |
org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot |
| | org.apache.hadoop.hbase.snapshot.TestExportSnapshot |
| |
org.apache.hadoop.hbase.replication.regionserver.TestReplicationWALReaderManager
|
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:9ba21e3 |
| JIRA Issue | HBASE-18267 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12876290/HBASE-18267.branch-1.3.v0.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux bfdceaa2622b 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/hbase.sh |
| git revision | branch-1.3 / 29e0e73 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1 |
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/7588/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
|
| unit |
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079632#comment-16079632 ] Chia-Ping Tsai commented on HBASE-18295: [~tedyu] Thanks for the reviews. Will commit it tomorrow if no objections. > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.0, 1.3.1, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.3.v0.patch, > HBASE-18295.branch-1.3.v1.patch, HBASE-18295.branch-1.v0.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.v0.patch, HBASE-18295.v1.patch, > HBASE-18295.v2.patch, HBASE-18295.v2.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18197) import.java, job output is printing two times.
[
https://issues.apache.org/jira/browse/HBASE-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079626#comment-16079626
]
Ted Yu commented on HBASE-18197:
After job.waitForCompletion() is called, there may be some error log(s).
Should the exit value be changed to 1 in that case ?
> import.java, job output is printing two times.
> --
>
> Key: HBASE-18197
> URL: https://issues.apache.org/jira/browse/HBASE-18197
> Project: HBase
> Issue Type: Bug
> Components: hbase
>Affects Versions: 1.0.2, 1.2.0, 1.4.0
>Reporter: Chandra Sekhar
>Assignee: Jan Hentschel
>Priority: Trivial
> Attachments: HBASE-18197.branch-1.0.001.patch,
> HBASE-18197.branch-1.0.001.patch, HBASE-18197.branch-1.2.001.patch,
> HBASE-18197.branch-1.2.001.patch, HBASE-18197.branch-1.2.002.patch
>
>
> import.java, job output is printing two times.
> {quote}
> after job completed, job.waitForCompletion(true) is calling two times.
> {quote}
> {code}
> Job job = createSubmittableJob(conf, otherArgs);
> boolean isJobSuccessful = job.waitForCompletion(true);
> if(isJobSuccessful){
> // Flush all the regions of the table
> flushRegionsIfNecessary(conf);
> }
> long inputRecords =
> job.getCounters().findCounter(TaskCounter.MAP_INPUT_RECORDS).getValue();
> long outputRecords =
> job.getCounters().findCounter(TaskCounter.MAP_OUTPUT_RECORDS).getValue();
> if (outputRecords < inputRecords) {
> System.err.println("Warning, not all records were imported (maybe
> filtered out).");
> if (outputRecords == 0) {
> System.err.println("If the data was exported from HBase 0.94 "+
> "consider using -Dhbase.import.version=0.94.");
> }
> }
> System.exit(job.waitForCompletion(true) ? 0 : 1);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079614#comment-16079614 ] Ted Yu commented on HBASE-18295: +1 > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.0, 1.3.1, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.3.v0.patch, > HBASE-18295.branch-1.3.v1.patch, HBASE-18295.branch-1.v0.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.v0.patch, HBASE-18295.v1.patch, > HBASE-18295.v2.patch, HBASE-18295.v2.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18343) Track the remaining unimplemented methods
[ https://issues.apache.org/jira/browse/HBASE-18343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-18343: -- Assignee: Guanghao Zhang > Track the remaining unimplemented methods > - > > Key: HBASE-18343 > URL: https://issues.apache.org/jira/browse/HBASE-18343 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18318) Implement updateConfiguration/stopMaster/stopRegionServer/shutdown methods
[ https://issues.apache.org/jira/browse/HBASE-18318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18318: --- Attachment: HBASE-18318.master.004.patch Rebase master code. > Implement updateConfiguration/stopMaster/stopRegionServer/shutdown methods > -- > > Key: HBASE-18318 > URL: https://issues.apache.org/jira/browse/HBASE-18318 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18318.master.001.patch, > HBASE-18318.master.002.patch, HBASE-18318.master.003.patch, > HBASE-18318.master.004.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18197) import.java, job output is printing two times.
[
https://issues.apache.org/jira/browse/HBASE-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079601#comment-16079601
]
Hadoop QA commented on HBASE-18197:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
22s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
30s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
59s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
20s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
41s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
30s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
11m 13s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 72m
53s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}102m 46s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:2fc26cc |
| JIRA Issue | HBASE-18197 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12876315/HBASE-18197.branch-1.2.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 9aefc90ee5dc 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Updated] (HBASE-18316) Implement async admin operations for draining region servers
[ https://issues.apache.org/jira/browse/HBASE-18316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18316: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: (was: 2.0.0) 2.0.0-alpha-2 3.0.0 Status: Resolved (was: Patch Available) Pushed to master and branch-2. > Implement async admin operations for draining region servers > > > Key: HBASE-18316 > URL: https://issues.apache.org/jira/browse/HBASE-18316 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18316.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17994) Add async client test to Performance Evaluation tool
[ https://issues.apache.org/jira/browse/HBASE-17994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079578#comment-16079578 ] Guanghao Zhang commented on HBASE-17994: Yes, Let me attach a patch for master and branch-2. > Add async client test to Performance Evaluation tool > > > Key: HBASE-17994 > URL: https://issues.apache.org/jira/browse/HBASE-17994 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-1 >Reporter: Guanghao Zhang > Fix For: 2.0.0-alpha-2 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18347) Implement a BufferedMutator for async client
[ https://issues.apache.org/jira/browse/HBASE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079568#comment-16079568 ] Chia-Ping Tsai commented on HBASE-18347: bq. we will only share the interface of BufferedMutator or even introduce a new interface. Got it. Thanks. > Implement a BufferedMutator for async client > > > Key: HBASE-18347 > URL: https://issues.apache.org/jira/browse/HBASE-18347 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang > > Need this if we want to replace the old implementation for sync client with > async client. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18347) Implement a BufferedMutator for async client
[ https://issues.apache.org/jira/browse/HBASE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079562#comment-16079562 ] Duo Zhang commented on HBASE-18347: --- I think here we will only share the interface of BufferedMutator or even introduce a new interface. The implementation of BufferedMutatorImpl is another story. > Implement a BufferedMutator for async client > > > Key: HBASE-18347 > URL: https://issues.apache.org/jira/browse/HBASE-18347 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang > > Need this if we want to replace the old implementation for sync client with > async client. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18348) The implementation of AsyncTableRegionLocator does not follow the javadoc
[ https://issues.apache.org/jira/browse/HBASE-18348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-18348: -- Affects Version/s: 3.0.0 Fix Version/s: 3.0.0 > The implementation of AsyncTableRegionLocator does not follow the javadoc > - > > Key: HBASE-18348 > URL: https://issues.apache.org/jira/browse/HBASE-18348 > Project: HBase > Issue Type: Bug > Components: asyncclient, Client >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Duo Zhang >Assignee: Jan Hentschel >Priority: Critical > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18348.branch-2.001.patch > > > The reload parameter is just ignored. > Need to fix this before 2.0.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18348) The implementation of AsyncTableRegionLocator does not follow the javadoc
[ https://issues.apache.org/jira/browse/HBASE-18348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079551#comment-16079551 ] Duo Zhang commented on HBASE-18348: --- [~Jan Hentschel] The patch here is not enough, we need to implement the logic which bypass the cache and fetch the HRegionLocation directly from HBase cluster. Thanks. > The implementation of AsyncTableRegionLocator does not follow the javadoc > - > > Key: HBASE-18348 > URL: https://issues.apache.org/jira/browse/HBASE-18348 > Project: HBase > Issue Type: Bug > Components: asyncclient, Client >Affects Versions: 2.0.0-alpha-1 >Reporter: Duo Zhang >Assignee: Jan Hentschel >Priority: Critical > Fix For: 2.0.0-alpha-2 > > Attachments: HBASE-18348.branch-2.001.patch > > > The reload parameter is just ignored. > Need to fix this before 2.0.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079548#comment-16079548 ] Chia-Ping Tsai commented on HBASE-18295: [~anoop.hbase] [~tedyu] [~zghaobac] [~ram_krish] Can i get +1 from you ? > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.0, 1.3.1, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.3.v0.patch, > HBASE-18295.branch-1.3.v1.patch, HBASE-18295.branch-1.v0.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.v0.patch, HBASE-18295.v1.patch, > HBASE-18295.v2.patch, HBASE-18295.v2.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18267) The result from the postAppend is ignored
[
https://issues.apache.org/jira/browse/HBASE-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18267:
---
Status: Patch Available (was: Open)
> The result from the postAppend is ignored
> -
>
> Key: HBASE-18267
> URL: https://issues.apache.org/jira/browse/HBASE-18267
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0-alpha-1, 1.2.6, 1.3.1, 1.3.0
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2
>
> Attachments: HBASE-18267.branch-1.3.v0.patch,
> HBASE-18267.branch-1.v0.patch, HBASE-18267.v0.patch, HBASE-18267.v1.patch
>
>
> {code:title=RegionCoprocessorHost.java|borderStyle=solid}
> /**
>* @param append Append object
>* @param result the result returned by the append
>* @throws IOException if an error occurred on the coprocessor
>*/
> public void postAppend(final Append append, final Result result) throws
> IOException {
> execOperation(coprocessors.isEmpty() ? null : new RegionOperation() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> oserver.postAppend(ctx, append, result);
> }
> });
> }
> /**
>* @param increment increment object
>* @param result the result returned by postIncrement
>* @throws IOException if an error occurred on the coprocessor
>*/
> public Result postIncrement(final Increment increment, Result result)
> throws IOException {
> return execOperationWithResult(result,
> coprocessors.isEmpty() ? null : new
> RegionOperationWithResult() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> setResult(oserver.postIncrement(ctx, increment, getResult()));
> }
> });
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18197) import.java, job output is printing two times.
[
https://issues.apache.org/jira/browse/HBASE-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated HBASE-18197:
--
Attachment: HBASE-18197.branch-1.2.002.patch
> import.java, job output is printing two times.
> --
>
> Key: HBASE-18197
> URL: https://issues.apache.org/jira/browse/HBASE-18197
> Project: HBase
> Issue Type: Bug
> Components: hbase
>Affects Versions: 1.0.2, 1.2.0, 1.4.0
>Reporter: Chandra Sekhar
>Assignee: Jan Hentschel
>Priority: Trivial
> Attachments: HBASE-18197.branch-1.0.001.patch,
> HBASE-18197.branch-1.0.001.patch, HBASE-18197.branch-1.2.001.patch,
> HBASE-18197.branch-1.2.001.patch, HBASE-18197.branch-1.2.002.patch
>
>
> import.java, job output is printing two times.
> {quote}
> after job completed, job.waitForCompletion(true) is calling two times.
> {quote}
> {code}
> Job job = createSubmittableJob(conf, otherArgs);
> boolean isJobSuccessful = job.waitForCompletion(true);
> if(isJobSuccessful){
> // Flush all the regions of the table
> flushRegionsIfNecessary(conf);
> }
> long inputRecords =
> job.getCounters().findCounter(TaskCounter.MAP_INPUT_RECORDS).getValue();
> long outputRecords =
> job.getCounters().findCounter(TaskCounter.MAP_OUTPUT_RECORDS).getValue();
> if (outputRecords < inputRecords) {
> System.err.println("Warning, not all records were imported (maybe
> filtered out).");
> if (outputRecords == 0) {
> System.err.println("If the data was exported from HBase 0.94 "+
> "consider using -Dhbase.import.version=0.94.");
> }
> }
> System.exit(job.waitForCompletion(true) ? 0 : 1);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18197) import.java, job output is printing two times.
[
https://issues.apache.org/jira/browse/HBASE-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079545#comment-16079545
]
Chia-Ping Tsai commented on HBASE-18197:
If memory serves, we don't support the 1.0. Please retry the patch for 1.2.
Thanks.
> import.java, job output is printing two times.
> --
>
> Key: HBASE-18197
> URL: https://issues.apache.org/jira/browse/HBASE-18197
> Project: HBase
> Issue Type: Bug
> Components: hbase
>Affects Versions: 1.0.2, 1.2.0, 1.4.0
>Reporter: Chandra Sekhar
>Assignee: Jan Hentschel
>Priority: Trivial
> Attachments: HBASE-18197.branch-1.0.001.patch,
> HBASE-18197.branch-1.0.001.patch, HBASE-18197.branch-1.2.001.patch,
> HBASE-18197.branch-1.2.001.patch
>
>
> import.java, job output is printing two times.
> {quote}
> after job completed, job.waitForCompletion(true) is calling two times.
> {quote}
> {code}
> Job job = createSubmittableJob(conf, otherArgs);
> boolean isJobSuccessful = job.waitForCompletion(true);
> if(isJobSuccessful){
> // Flush all the regions of the table
> flushRegionsIfNecessary(conf);
> }
> long inputRecords =
> job.getCounters().findCounter(TaskCounter.MAP_INPUT_RECORDS).getValue();
> long outputRecords =
> job.getCounters().findCounter(TaskCounter.MAP_OUTPUT_RECORDS).getValue();
> if (outputRecords < inputRecords) {
> System.err.println("Warning, not all records were imported (maybe
> filtered out).");
> if (outputRecords == 0) {
> System.err.println("If the data was exported from HBase 0.94 "+
> "consider using -Dhbase.import.version=0.94.");
> }
> }
> System.exit(job.waitForCompletion(true) ? 0 : 1);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (HBASE-18348) The implementation of AsyncTableRegionLocator does not follow the javadoc
[ https://issues.apache.org/jira/browse/HBASE-18348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel reassigned HBASE-18348: - Assignee: Jan Hentschel > The implementation of AsyncTableRegionLocator does not follow the javadoc > - > > Key: HBASE-18348 > URL: https://issues.apache.org/jira/browse/HBASE-18348 > Project: HBase > Issue Type: Bug > Components: asyncclient, Client >Affects Versions: 2.0.0-alpha-1 >Reporter: Duo Zhang >Assignee: Jan Hentschel >Priority: Critical > Fix For: 2.0.0-alpha-2 > > Attachments: HBASE-18348.branch-2.001.patch > > > The reload parameter is just ignored. > Need to fix this before 2.0.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18348) The implementation of AsyncTableRegionLocator does not follow the javadoc
[ https://issues.apache.org/jira/browse/HBASE-18348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-18348: -- Attachment: HBASE-18348.branch-2.001.patch > The implementation of AsyncTableRegionLocator does not follow the javadoc > - > > Key: HBASE-18348 > URL: https://issues.apache.org/jira/browse/HBASE-18348 > Project: HBase > Issue Type: Bug > Components: asyncclient, Client >Affects Versions: 2.0.0-alpha-1 >Reporter: Duo Zhang >Priority: Critical > Fix For: 2.0.0-alpha-2 > > Attachments: HBASE-18348.branch-2.001.patch > > > The reload parameter is just ignored. > Need to fix this before 2.0.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18197) import.java, job output is printing two times.
[
https://issues.apache.org/jira/browse/HBASE-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079535#comment-16079535
]
Hadoop QA commented on HBASE-18197:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} docker {color} | {color:blue} 0m
4s{color} | {color:blue} Dockerfile
'/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/docker/Dockerfile'
not found, falling back to built-in. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red} 8m
3s{color} | {color:red} Docker failed to build yetus/hbase:date2017-07-09.
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-18197 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12876313/HBASE-18197.branch-1.0.001.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7586/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> import.java, job output is printing two times.
> --
>
> Key: HBASE-18197
> URL: https://issues.apache.org/jira/browse/HBASE-18197
> Project: HBase
> Issue Type: Bug
> Components: hbase
>Affects Versions: 1.0.2, 1.2.0, 1.4.0
>Reporter: Chandra Sekhar
>Assignee: Jan Hentschel
>Priority: Trivial
> Attachments: HBASE-18197.branch-1.0.001.patch,
> HBASE-18197.branch-1.0.001.patch, HBASE-18197.branch-1.2.001.patch,
> HBASE-18197.branch-1.2.001.patch
>
>
> import.java, job output is printing two times.
> {quote}
> after job completed, job.waitForCompletion(true) is calling two times.
> {quote}
> {code}
> Job job = createSubmittableJob(conf, otherArgs);
> boolean isJobSuccessful = job.waitForCompletion(true);
> if(isJobSuccessful){
> // Flush all the regions of the table
> flushRegionsIfNecessary(conf);
> }
> long inputRecords =
> job.getCounters().findCounter(TaskCounter.MAP_INPUT_RECORDS).getValue();
> long outputRecords =
> job.getCounters().findCounter(TaskCounter.MAP_OUTPUT_RECORDS).getValue();
> if (outputRecords < inputRecords) {
> System.err.println("Warning, not all records were imported (maybe
> filtered out).");
> if (outputRecords == 0) {
> System.err.println("If the data was exported from HBase 0.94 "+
> "consider using -Dhbase.import.version=0.94.");
> }
> }
> System.exit(job.waitForCompletion(true) ? 0 : 1);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18197) import.java, job output is printing two times.
[
https://issues.apache.org/jira/browse/HBASE-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated HBASE-18197:
--
Attachment: HBASE-18197.branch-1.0.001.patch
HBASE-18197.branch-1.2.001.patch
> import.java, job output is printing two times.
> --
>
> Key: HBASE-18197
> URL: https://issues.apache.org/jira/browse/HBASE-18197
> Project: HBase
> Issue Type: Bug
> Components: hbase
>Affects Versions: 1.0.2, 1.2.0, 1.4.0
>Reporter: Chandra Sekhar
>Assignee: Jan Hentschel
>Priority: Trivial
> Attachments: HBASE-18197.branch-1.0.001.patch,
> HBASE-18197.branch-1.0.001.patch, HBASE-18197.branch-1.2.001.patch,
> HBASE-18197.branch-1.2.001.patch
>
>
> import.java, job output is printing two times.
> {quote}
> after job completed, job.waitForCompletion(true) is calling two times.
> {quote}
> {code}
> Job job = createSubmittableJob(conf, otherArgs);
> boolean isJobSuccessful = job.waitForCompletion(true);
> if(isJobSuccessful){
> // Flush all the regions of the table
> flushRegionsIfNecessary(conf);
> }
> long inputRecords =
> job.getCounters().findCounter(TaskCounter.MAP_INPUT_RECORDS).getValue();
> long outputRecords =
> job.getCounters().findCounter(TaskCounter.MAP_OUTPUT_RECORDS).getValue();
> if (outputRecords < inputRecords) {
> System.err.println("Warning, not all records were imported (maybe
> filtered out).");
> if (outputRecords == 0) {
> System.err.println("If the data was exported from HBase 0.94 "+
> "consider using -Dhbase.import.version=0.94.");
> }
> }
> System.exit(job.waitForCompletion(true) ? 0 : 1);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18344) Replace Append#add(byte[], byte[], byte[]) by Append#addColumn
[ https://issues.apache.org/jira/browse/HBASE-18344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-18344: -- Attachment: HBASE-18344.master.001.patch > Replace Append#add(byte[], byte[], byte[]) by Append#addColumn > -- > > Key: HBASE-18344 > URL: https://issues.apache.org/jira/browse/HBASE-18344 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Jan Hentschel >Priority: Trivial > Labels: beginner > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18344.master.001.patch > > > We have Put#addColumn and Increment#addColumn but there is no > Append#addColumn. We should add Append#addColumn for consistency. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18318) Implement updateConfiguration/stopMaster/stopRegionServer/shutdown methods
[
https://issues.apache.org/jira/browse/HBASE-18318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079491#comment-16079491
]
Hadoop QA commented on HBASE-18318:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
22s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
44s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
55s{color} | {color:red} hbase-client in master has 4 extant Findbugs warnings.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 6m
22s{color} | {color:red} hbase-server in master has 10 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
32s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
60m 12s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
49s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}262m 35s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
48s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}366m 24s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestMobSnapshotCloneIndependence |
| | hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver |
| | hadoop.hbase.master.procedure.TestServerCrashProcedure |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:757bf37 |
| JIRA Issue | HBASE-18318 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12876280/HBASE-18318.master.003.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 42d4621a59dc 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / bc8ebc6 |
