[jira] [Commented] (HBASE-18461) Build broken If the username contains a backslash

2017-08-15 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126878#comment-16126878
 ] 

Hadoop QA commented on HBASE-18461:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
4s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red}  0m  
5s{color} | {color:red} The patch generated 1 new + 509 unchanged - 0 fixed = 
510 total (was 509) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
32m  2s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
11s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 32m 51s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18461 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12881878/HBASE-18461-master-v2.patch
 |
| Optional Tests |  asflicense  shellcheck  shelldocs  |
| uname | Linux f8ae403e8baa 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 0e32869 |
| shellcheck | v0.4.6 |
| shellcheck | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8084/artifact/patchprocess/diff-patch-shellcheck.txt
 |
| modules | C: hbase-common U: hbase-common |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8084/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Build broken If the username contains a backslash
> -
>
> Key: HBASE-18461
> URL: https://issues.apache.org/jira/browse/HBASE-18461
> Project: HBase
>  Issue Type: Bug
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Minor
> Attachments: HBASE-18461-master-v1.patch, HBASE-18461-master-v2.patch
>
>
> The character '\' is a special character and needs to be escaped when used as 
> part of a String.
> If the name contains '\', we need to escape it,otherwise the generated file 
> Version.java failed to compile.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (HBASE-18598) AsyncNonMetaRegionLocator use FIFO algorithm to get a candidate locate request

2017-08-15 Thread Guanghao Zhang (JIRA)
Guanghao Zhang created HBASE-18598:
--

 Summary: AsyncNonMetaRegionLocator use FIFO algorithm to get a 
candidate locate request
 Key: HBASE-18598
 URL: https://issues.apache.org/jira/browse/HBASE-18598
 Project: HBase
  Issue Type: Bug
  Components: asyncclient
Reporter: Guanghao Zhang
Assignee: Guanghao Zhang
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (HBASE-18599) Add missing @Deprecated annotations

2017-08-15 Thread Lars Francke (JIRA)
Lars Francke created HBASE-18599:


 Summary: Add missing @Deprecated annotations
 Key: HBASE-18599
 URL: https://issues.apache.org/jira/browse/HBASE-18599
 Project: HBase
  Issue Type: Bug
Reporter: Lars Francke
Assignee: Lars Francke
Priority: Minor


There are a couple of places where deprecations have only been added in the 
Javadoc but the annotation is missing.

I'll also change the Javadoc to be consistent with what I've done in 
HBASE-13462.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18599) Add missing @Deprecated annotations

2017-08-15 Thread Lars Francke (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Francke updated HBASE-18599:
-
Attachment: HBASE-18599.patch

> Add missing @Deprecated annotations
> ---
>
> Key: HBASE-18599
> URL: https://issues.apache.org/jira/browse/HBASE-18599
> Project: HBase
>  Issue Type: Bug
>Reporter: Lars Francke
>Assignee: Lars Francke
>Priority: Minor
> Attachments: HBASE-18599.patch
>
>
> There are a couple of places where deprecations have only been added in the 
> Javadoc but the annotation is missing.
> I'll also change the Javadoc to be consistent with what I've done in 
> HBASE-13462.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18599) Add missing @Deprecated annotations

2017-08-15 Thread Lars Francke (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Francke updated HBASE-18599:
-
Description: 
There are a couple of places where deprecations have only been added in the 
Javadoc but the annotation is missing.

I'll also change the Javadoc to be consistent with what I've done in 
HBASE-13462.

This is for master/2.0.0 only.

  was:
There are a couple of places where deprecations have only been added in the 
Javadoc but the annotation is missing.

I'll also change the Javadoc to be consistent with what I've done in 
HBASE-13462.


> Add missing @Deprecated annotations
> ---
>
> Key: HBASE-18599
> URL: https://issues.apache.org/jira/browse/HBASE-18599
> Project: HBase
>  Issue Type: Bug
>Reporter: Lars Francke
>Assignee: Lars Francke
>Priority: Minor
> Attachments: HBASE-18599.patch
>
>
> There are a couple of places where deprecations have only been added in the 
> Javadoc but the annotation is missing.
> I'll also change the Javadoc to be consistent with what I've done in 
> HBASE-13462.
> This is for master/2.0.0 only.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18599) Add missing @Deprecated annotations

2017-08-15 Thread Lars Francke (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Francke updated HBASE-18599:
-
Status: Patch Available  (was: Open)

> Add missing @Deprecated annotations
> ---
>
> Key: HBASE-18599
> URL: https://issues.apache.org/jira/browse/HBASE-18599
> Project: HBase
>  Issue Type: Bug
>Reporter: Lars Francke
>Assignee: Lars Francke
>Priority: Minor
> Attachments: HBASE-18599.patch
>
>
> There are a couple of places where deprecations have only been added in the 
> Javadoc but the annotation is missing.
> I'll also change the Javadoc to be consistent with what I've done in 
> HBASE-13462.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-17064) Add TaskMonitor#getTasks() variant which accepts type selection

2017-08-15 Thread Reid Chan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-17064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan updated HBASE-17064:
--
Attachment: HBASE-17064.master.001.patch

A small patch, i can put it on review board if required.

> Add TaskMonitor#getTasks() variant which accepts type selection
> ---
>
> Key: HBASE-17064
> URL: https://issues.apache.org/jira/browse/HBASE-17064
> Project: HBase
>  Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Reid Chan
>Priority: Minor
>  Labels: ui
> Attachments: HBASE-17064.master.001.patch
>
>
> In TaskMonitorTmpl.jamon :
> {code}
> List tasks = taskMonitor.getTasks();
> Iterator iter = tasks.iterator();
> // apply requested filter
> while (iter.hasNext()) {
>   MonitoredTask t = iter.next();
>   if (filter.equals("general")) {
> if (t instanceof MonitoredRPCHandler)
>   iter.remove();
> {code}
> This means when user refreshes rs-status page, regardless of the type of 
> filter, we always traverse and clone MonitoredTask's.
> getTasks() is synchronized :
> {code}
>   public synchronized List getTasks() {
> {code}
> A variant of getTasks() can be added which takes the type of filter so that 
> unnecessary cloning is avoided.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-17064) Add TaskMonitor#getTasks() variant which accepts type selection

2017-08-15 Thread Reid Chan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-17064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan updated HBASE-17064:
--
Status: Patch Available  (was: Open)

> Add TaskMonitor#getTasks() variant which accepts type selection
> ---
>
> Key: HBASE-17064
> URL: https://issues.apache.org/jira/browse/HBASE-17064
> Project: HBase
>  Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Reid Chan
>Priority: Minor
>  Labels: ui
> Attachments: HBASE-17064.master.001.patch
>
>
> In TaskMonitorTmpl.jamon :
> {code}
> List tasks = taskMonitor.getTasks();
> Iterator iter = tasks.iterator();
> // apply requested filter
> while (iter.hasNext()) {
>   MonitoredTask t = iter.next();
>   if (filter.equals("general")) {
> if (t instanceof MonitoredRPCHandler)
>   iter.remove();
> {code}
> This means when user refreshes rs-status page, regardless of the type of 
> filter, we always traverse and clone MonitoredTask's.
> getTasks() is synchronized :
> {code}
>   public synchronized List getTasks() {
> {code}
> A variant of getTasks() can be added which takes the type of filter so that 
> unnecessary cloning is avoided.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-17064) Add TaskMonitor#getTasks() variant which accepts type selection

2017-08-15 Thread Reid Chan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126915#comment-16126915
 ] 

Reid Chan commented on HBASE-17064:
---

Would you mind giving a review, if you have time. [~tedyu], though it is minor 
and set aside quite a long time...

> Add TaskMonitor#getTasks() variant which accepts type selection
> ---
>
> Key: HBASE-17064
> URL: https://issues.apache.org/jira/browse/HBASE-17064
> Project: HBase
>  Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Reid Chan
>Priority: Minor
>  Labels: ui
> Attachments: HBASE-17064.master.001.patch
>
>
> In TaskMonitorTmpl.jamon :
> {code}
> List tasks = taskMonitor.getTasks();
> Iterator iter = tasks.iterator();
> // apply requested filter
> while (iter.hasNext()) {
>   MonitoredTask t = iter.next();
>   if (filter.equals("general")) {
> if (t instanceof MonitoredRPCHandler)
>   iter.remove();
> {code}
> This means when user refreshes rs-status page, regardless of the type of 
> filter, we always traverse and clone MonitoredTask's.
> getTasks() is synchronized :
> {code}
>   public synchronized List getTasks() {
> {code}
> A variant of getTasks() can be added which takes the type of filter so that 
> unnecessary cloning is avoided.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (HBASE-17064) Add TaskMonitor#getTasks() variant which accepts type selection

2017-08-15 Thread Reid Chan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126915#comment-16126915
 ] 

Reid Chan edited comment on HBASE-17064 at 8/15/17 8:08 AM:


Would you mind giving a review, if you have time [~tedyu], though it is minor 
and set aside quite a long time...


was (Author: reidchan):
Would you mind giving a review, if you have time. [~tedyu], though it is minor 
and set aside quite a long time...

> Add TaskMonitor#getTasks() variant which accepts type selection
> ---
>
> Key: HBASE-17064
> URL: https://issues.apache.org/jira/browse/HBASE-17064
> Project: HBase
>  Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Reid Chan
>Priority: Minor
>  Labels: ui
> Attachments: HBASE-17064.master.001.patch
>
>
> In TaskMonitorTmpl.jamon :
> {code}
> List tasks = taskMonitor.getTasks();
> Iterator iter = tasks.iterator();
> // apply requested filter
> while (iter.hasNext()) {
>   MonitoredTask t = iter.next();
>   if (filter.equals("general")) {
> if (t instanceof MonitoredRPCHandler)
>   iter.remove();
> {code}
> This means when user refreshes rs-status page, regardless of the type of 
> filter, we always traverse and clone MonitoredTask's.
> getTasks() is synchronized :
> {code}
>   public synchronized List getTasks() {
> {code}
> A variant of getTasks() can be added which takes the type of filter so that 
> unnecessary cloning is avoided.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18504) Add documentation for WAL compression

2017-08-15 Thread Peter Somogyi (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126929#comment-16126929
 ] 

Peter Somogyi commented on HBASE-18504:
---

[~stack] could you take a look?

> Add documentation for WAL compression
> -
>
> Key: HBASE-18504
> URL: https://issues.apache.org/jira/browse/HBASE-18504
> Project: HBase
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.0.0, 2.0.0-alpha-2
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-18504.master.001.patch, 
> HBASE-18504.master.001.patch
>
>
> The Reference Guide does not have any documentation about WAL compression.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18598) AsyncNonMetaRegionLocator use FIFO algorithm to get a candidate locate request

2017-08-15 Thread Guanghao Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-18598:
---
Attachment: HBASE-18598-v1.patch

> AsyncNonMetaRegionLocator use FIFO algorithm to get a candidate locate request
> --
>
> Key: HBASE-18598
> URL: https://issues.apache.org/jira/browse/HBASE-18598
> Project: HBase
>  Issue Type: Bug
>  Components: asyncclient
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Minor
> Attachments: HBASE-18598-v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18598) AsyncNonMetaRegionLocator use FIFO algorithm to get a candidate locate request

2017-08-15 Thread Guanghao Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-18598:
---
Status: Patch Available  (was: Open)

> AsyncNonMetaRegionLocator use FIFO algorithm to get a candidate locate request
> --
>
> Key: HBASE-18598
> URL: https://issues.apache.org/jira/browse/HBASE-18598
> Project: HBase
>  Issue Type: Bug
>  Components: asyncclient
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Minor
> Attachments: HBASE-18598-v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (HBASE-18600) Provide a method to disable the Short-Circuit HTable in coprocessor

2017-08-15 Thread Guanghao Zhang (JIRA)
Guanghao Zhang created HBASE-18600:
--

 Summary: Provide a method to disable the Short-Circuit HTable in 
coprocessor
 Key: HBASE-18600
 URL: https://issues.apache.org/jira/browse/HBASE-18600
 Project: HBase
  Issue Type: Improvement
Reporter: Guanghao Zhang






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18600) Provide a method to disable the Short-Circuit HTable in coprocessor

2017-08-15 Thread Guanghao Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-18600:
---
Attachment: HBASE-18600.master.001.patch

> Provide a method to disable the Short-Circuit HTable in coprocessor
> ---
>
> Key: HBASE-18600
> URL: https://issues.apache.org/jira/browse/HBASE-18600
> Project: HBase
>  Issue Type: Improvement
>Reporter: Guanghao Zhang
> Attachments: HBASE-18600.master.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18600) Provide a method to disable the Short-Circuit HTable in coprocessor

2017-08-15 Thread Guanghao Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-18600:
---
Assignee: Guanghao Zhang
  Status: Patch Available  (was: Open)

> Provide a method to disable the Short-Circuit HTable in coprocessor
> ---
>
> Key: HBASE-18600
> URL: https://issues.apache.org/jira/browse/HBASE-18600
> Project: HBase
>  Issue Type: Improvement
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Attachments: HBASE-18600.master.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18600) Provide a method to disable the Short-Circuit HTable in coprocessor

2017-08-15 Thread Guanghao Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-18600:
---
Description: HBASE-9534: Allow coprocessors accessing an HTable to 
short-circuit access to the local HRegionServer, rather than requiring the 
usual RPC path. And it only worked for RegionCoprocessorEnvironment. This issue 
add a new method for RegionCoprocessorEnvironment.  getShortCircuitTable method 
is used to get a  short-circuit access HTable. And getTable method is used to 
get a normal table.

> Provide a method to disable the Short-Circuit HTable in coprocessor
> ---
>
> Key: HBASE-18600
> URL: https://issues.apache.org/jira/browse/HBASE-18600
> Project: HBase
>  Issue Type: Improvement
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Attachments: HBASE-18600.master.001.patch
>
>
> HBASE-9534: Allow coprocessors accessing an HTable to short-circuit access to 
> the local HRegionServer, rather than requiring the usual RPC path. And it 
> only worked for RegionCoprocessorEnvironment. This issue add a new method for 
> RegionCoprocessorEnvironment.  getShortCircuitTable method is used to get a  
> short-circuit access HTable. And getTable method is used to get a normal 
> table.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18600) Provide a method to disable the Short-Circuit HTable in coprocessor

2017-08-15 Thread Guanghao Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-18600:
---
Hadoop Flags: Incompatible change

> Provide a method to disable the Short-Circuit HTable in coprocessor
> ---
>
> Key: HBASE-18600
> URL: https://issues.apache.org/jira/browse/HBASE-18600
> Project: HBase
>  Issue Type: Improvement
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Attachments: HBASE-18600.master.001.patch
>
>
> HBASE-9534: Allow coprocessors accessing an HTable to short-circuit access to 
> the local HRegionServer, rather than requiring the usual RPC path. And it 
> only worked for RegionCoprocessorEnvironment. This issue add a new method for 
> RegionCoprocessorEnvironment.  getShortCircuitTable method is used to get a  
> short-circuit access HTable. And getTable method is used to get a normal 
> table.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18598) AsyncNonMetaRegionLocator use FIFO algorithm to get a candidate locate request

2017-08-15 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126969#comment-16126969
 ] 

Hadoop QA commented on HBASE-18598:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
31m  9s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
34s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 7s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 43m  1s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18598 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12881888/HBASE-18598-v1.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux 3b073dbadd5b 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 0e32869 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8087/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8087/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> AsyncNonMetaRegionLocator use FIFO algorithm to get a candidate locate request
> --
>
> Key: HBASE-18598
> URL: https://issues.apache.org/jira/browse/HBASE-18598
> Project: HBase
>  Issue Type: Bug
>  Compo

[jira] [Updated] (HBASE-18598) AsyncNonMetaRegionLocator use FIFO algorithm to get a candidate locate request

2017-08-15 Thread Guanghao Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-18598:
---
Attachment: HBASE-18598-v2.patch

Add one line change to trigger ut.

> AsyncNonMetaRegionLocator use FIFO algorithm to get a candidate locate request
> --
>
> Key: HBASE-18598
> URL: https://issues.apache.org/jira/browse/HBASE-18598
> Project: HBase
>  Issue Type: Bug
>  Components: asyncclient
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Minor
> Attachments: HBASE-18598-v1.patch, HBASE-18598-v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18553) Expose scan cursor for asynchronous scanner

2017-08-15 Thread Duo Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-18553:
--
Attachment: HBASE-18553-v1.patch

> Expose scan cursor for asynchronous scanner
> ---
>
> Key: HBASE-18553
> URL: https://issues.apache.org/jira/browse/HBASE-18553
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 3.0.0, 2.0.0-alpha-1
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-18553.patch, HBASE-18553-v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18546) Append/Increment a cell with custom timestamp

2017-08-15 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126991#comment-16126991
 ] 

Chia-Ping Tsai commented on HBASE-18546:


bq. Does we really need setting timestamp for append/increment at client?
Opening this issue is due to behavior inconsistency. I noticed that we will use 
the TS passed by client for Append (if we don't find any old cells), but we 
always ignore the TS for Increment. No documents discuss about such 
differences. After reading HBASE-17112, IMO, It is straightforward to regard 
Append/Increment as PUT if no previous cells are found. In contrast, we should 
use the max(now, old ts+1).

> Append/Increment a cell with custom timestamp
> -
>
> Key: HBASE-18546
> URL: https://issues.apache.org/jira/browse/HBASE-18546
> Project: HBase
>  Issue Type: New Feature
>  Components: API, Client
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Critical
>  Labels: incompatibleChange
> Fix For: 2.0.0
>
> Attachments: HBASE-18546.v0.patch, HBASE-18546.v1.patch
>
>
> We don't pass the custom timestamp for Increment, and the increment's 
> timestamp always be rewrite. Hence, user can't increment a cell with custom 
> timestamp.
> {code:title=ProtobufUtil.java}
>   if (values != null && values.size() > 0) {
> for (Cell cell: values) {
>   valueBuilder.clear();
>   valueBuilder.setQualifier(UnsafeByteOperations.unsafeWrap(
>   cell.getQualifierArray(), cell.getQualifierOffset(), 
> cell.getQualifierLength()));
>   valueBuilder.setValue(UnsafeByteOperations.unsafeWrap(
>   cell.getValueArray(), cell.getValueOffset(), 
> cell.getValueLength()));
>   if (cell.getTagsLength() > 0) {
> 
> valueBuilder.setTags(UnsafeByteOperations.unsafeWrap(cell.getTagsArray(),
> cell.getTagsOffset(), cell.getTagsLength()));
>   }
>   columnBuilder.addQualifierValue(valueBuilder.build());
> }
>   }
> {code}
> In contrast to Increment, user can append the cell with custom timestamp. It 
> would be better that make their behavior consistent. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (HBASE-18601) Remove Htrace 3.2

2017-08-15 Thread Tamas Penzes (JIRA)
Tamas Penzes created HBASE-18601:


 Summary: Remove Htrace 3.2
 Key: HBASE-18601
 URL: https://issues.apache.org/jira/browse/HBASE-18601
 Project: HBase
  Issue Type: Task
Affects Versions: 2.0.0-alpha-1
Reporter: Tamas Penzes
Assignee: Tamas Penzes
 Fix For: 2.0.0


HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, the 
upgrade to 4.x is not trivial and would take time. It might not worth to keep 
it in this state, so would be better to remove it.

Of course it doesn't mean tracing would be useless, just that in this form the 
use of HTrace 3.2 might not add any value to the project and fixing it would be 
far too much effort.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Work started] (HBASE-18601) Remove Htrace 3.2

2017-08-15 Thread Tamas Penzes (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-18601 started by Tamas Penzes.

> Remove Htrace 3.2
> -
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0-alpha-1
>Reporter: Tamas Penzes
>Assignee: Tamas Penzes
> Fix For: 2.0.0
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, 
> the upgrade to 4.x is not trivial and would take time. It might not worth to 
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form 
> the use of HTrace 3.2 might not add any value to the project and fixing it 
> would be far too much effort.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18601) Remove Htrace 3.2

2017-08-15 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127057#comment-16127057
 ] 

Sean Busbey commented on HBASE-18601:
-

Please start a DISCUSS thread on dev@hbase about this change. I don't disagree 
about the state of tracing in HBase, but we should ensure there isn't someone 
prepared to make it work in time for 2.0.

> Remove Htrace 3.2
> -
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0-alpha-1
>Reporter: Tamas Penzes
>Assignee: Tamas Penzes
> Fix For: 2.0.0
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, 
> the upgrade to 4.x is not trivial and would take time. It might not worth to 
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form 
> the use of HTrace 3.2 might not add any value to the project and fixing it 
> would be far too much effort.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18599) Add missing @Deprecated annotations

2017-08-15 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127060#comment-16127060
 ] 

Hadoop QA commented on HBASE-18599:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
28s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
47s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 1s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
30m 15s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
25s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}116m 
46s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
33s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}170m 36s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18599 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12881883/HBASE-18599.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux 05d8f6a2d744 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 0e32869 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8085/testReport/ |
| modules | C: hbase-client hbase-server U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8085/console |
| Powered by | A

[jira] [Updated] (HBASE-18511) Default no regions on master

2017-08-15 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-18511:

Release Note: 
Changes the configuration hbase.balancer.tablesOnMaster from list of table 
names that the can carry (with 'none' meaning no tables on the master) to 
instead be a boolean that is set to true if master carries tables/regions and 
false if it does not. If true, the master acts like any regionserver.

If false, then the master carries no tables. This is the default for 
hbase-2.0.0.

Another boolean configuration, hbase.balancer.tablesOnMaster.systemTablesOnly, 
when set to true, enables hbase.balancer.tablesOnMaster and makes it so the 
master hosts system tables exclusively (the long-time deploy mode of master 
branch and branch-2 up until this commit).

The change of hbase.balancer.tablesOnMaster from String list to boolean and
the addition of a simple boolean to enable system-tables on Master was done
to constrain what operators might ask for via this master configuration.
Stipulating what tables are bound to the Master server verges into
regionserver grouping territory, a more robust means of specifying table
and server combinations. Operators should use this latter if they want
layouts more exotic than those supplied by the provided booleans.

  was:
Changes the configuration hbase.balancer.tablesOnMaster from list of table 
names that the can carry (with 'none' meaning no tables on the master) to 
instead be a boolean that is set to true if master carries tables/regions and 
false if it does not. If true, the master acts like any regionserver.

If false, then the master carries no tables. This is the default for 
hbase-2.0.0.

Another boolean configuration, hbase.balancer.tablesOnMaster.systemTablesOnly, 
when set to true, enables hbase.balancer.tablesOnMaster and makes it so the 
master hosts system tables exclusively (the long-time deploy mode of master 
branch and branch-2 up until this commit). 


> Default no regions on master
> 
>
> Key: HBASE-18511
> URL: https://issues.apache.org/jira/browse/HBASE-18511
> Project: HBase
>  Issue Type: Task
>  Components: master
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-18511.master.001.patch, 
> HBASE-18511.master.002.patch, HBASE-18511.master.003.patch, 
> HBASE-18511.master.004.patch, HBASE-18511.master.005.patch, 
> HBASE-18511.master.006.patch, HBASE-18511.master.007.patch
>
>
> Let this be umbrella issue for no-regions-on-master as default deploy (as it 
> was in branch-1).
> Also need to make sure we can run WITH regions on master; in particular 
> system tables with RPC short-circuit as it is now in hbase master.
> Background is that master branch carried a change that allowed Master carry 
> regions. On top of this improvement on branch-1, Master defaulted to carry 
> system tables only. No release was made with this configuration. Now we are 
> going to cut the 2.0.0 release, the decision is that hbase-2 should have the 
> same layout as hbase-1 so this issue implements the undoing of Master 
> carrying system tables by default (though the capability remains).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18511) Default no regions on master

2017-08-15 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127067#comment-16127067
 ] 

Sean Busbey commented on HBASE-18511:
-

Added more to the release note based on stack's email to dev@. The additional 
context and pointing folks to the rsgroups feature helps.

> Default no regions on master
> 
>
> Key: HBASE-18511
> URL: https://issues.apache.org/jira/browse/HBASE-18511
> Project: HBase
>  Issue Type: Task
>  Components: master
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-18511.master.001.patch, 
> HBASE-18511.master.002.patch, HBASE-18511.master.003.patch, 
> HBASE-18511.master.004.patch, HBASE-18511.master.005.patch, 
> HBASE-18511.master.006.patch, HBASE-18511.master.007.patch
>
>
> Let this be umbrella issue for no-regions-on-master as default deploy (as it 
> was in branch-1).
> Also need to make sure we can run WITH regions on master; in particular 
> system tables with RPC short-circuit as it is now in hbase master.
> Background is that master branch carried a change that allowed Master carry 
> regions. On top of this improvement on branch-1, Master defaulted to carry 
> system tables only. No release was made with this configuration. Now we are 
> going to cut the 2.0.0 release, the decision is that hbase-2 should have the 
> same layout as hbase-1 so this issue implements the undoing of Master 
> carrying system tables by default (though the capability remains).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18599) Add missing @Deprecated annotations

2017-08-15 Thread Lars Francke (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127082#comment-16127082
 ] 

Lars Francke commented on HBASE-18599:
--

No tests because it's a documentation/annotation-only patch.

> Add missing @Deprecated annotations
> ---
>
> Key: HBASE-18599
> URL: https://issues.apache.org/jira/browse/HBASE-18599
> Project: HBase
>  Issue Type: Bug
>Reporter: Lars Francke
>Assignee: Lars Francke
>Priority: Minor
> Attachments: HBASE-18599.patch
>
>
> There are a couple of places where deprecations have only been added in the 
> Javadoc but the annotation is missing.
> I'll also change the Javadoc to be consistent with what I've done in 
> HBASE-13462.
> This is for master/2.0.0 only.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18600) Provide a method to disable the Short-Circuit HTable in coprocessor

2017-08-15 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127099#comment-16127099
 ] 

Hadoop QA commented on HBASE-18600:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m  
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
31m 37s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}109m 
14s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
17s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}159m 10s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18600 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12881891/HBASE-18600.master.001.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux 00736dde7ced 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / 0e32869 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8088/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8088/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Provide a method to disable the Short-Circuit HTable in coprocessor
> ---
>
> Key: HBASE-18600
> URL: https://issues.apache.org/jira/browse/HBASE-18600
> Project: HBase
>  Issue Type: Improvement
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Attachments: HBASE-18600.master.001.patch
>
>
> HBASE-9534:

[jira] [Commented] (HBASE-18598) AsyncNonMetaRegionLocator use FIFO algorithm to get a candidate locate request

2017-08-15 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127106#comment-16127106
 ] 

Hadoop QA commented on HBASE-18598:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
41s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
58s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
37m  9s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
41s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 69m 24s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  1m 
 5s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}135m 27s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | 
org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure |
|   | org.apache.hadoop.hbase.regionserver.TestRowTooBig |
|   | org.apache.hadoop.hbase.regionserver.wal.TestAsyncWALReplay |
|   | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy 
|
|   | org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence |
|   | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
|   | org.apache.hadoop.hbase.regionserver.wal.TestFSHLog |
|   | org.apache.hadoop.hbase.regionserver.TestCompaction |
|   | org.apache.hadoop.hbase.client.TestFromClientSide |
|   | org.apache.hadoop.hbase.trace.TestHTraceHooks |
|   | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
|   | org.apache.hadoop.hbase.regionserver.TestRemoveRegionMetrics |
|   | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries |
|   | org.apache.hadoop.hbase.backup.TestRemoteBackup |
|   | org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics |
|   | org.apache.hadoop.hbase.regionserver.Test

[jira] [Commented] (HBASE-18358) Backport HBASE-18099 'FlushSnapshotSubprocedure should wait for concurrent Region#flush() to finish' to branch-1.3

2017-08-15 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127115#comment-16127115
 ] 

Sean Busbey commented on HBASE-18358:
-

[~tedyu] please add a release note

> Backport HBASE-18099 'FlushSnapshotSubprocedure should wait for concurrent 
> Region#flush() to finish' to branch-1.3
> --
>
> Key: HBASE-18358
> URL: https://issues.apache.org/jira/browse/HBASE-18358
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2
>
> Attachments: 18358.branch-1.3.patch, 18358.v2.txt, 18358.v3.txt
>
>
> HBASE-18099 was only integrated to branch-1 and above in consideration of 
> backward compatibility.
> This issue is to backport the fix to branch-1.3 and branch-1.2.
> Quoting Gary's suggestion from the tail of HBASE-18099 :
> {quote}
> Sure, don't add the method to Region, just to HRegion, check for an instance 
> of HRegion in FlushSnapshotSubprocedure and cast the instance before calling 
> the method.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-17617) Backport HBASE-16731 (Inconsistent results from the Get/Scan if we use the empty FilterList) to branch-1

2017-08-15 Thread Pankaj Kumar (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-17617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pankaj Kumar updated HBASE-17617:
-
Fix Version/s: (was: 1.4.0)
   1.5.0

> Backport HBASE-16731 (Inconsistent results from the Get/Scan if we use the 
> empty FilterList) to branch-1
> 
>
> Key: HBASE-17617
> URL: https://issues.apache.org/jira/browse/HBASE-17617
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.0, 1.3.1
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 1.5.0
>
> Attachments: HBASE-17617-branch-1.patch
>
>
> HBASE-16731 fixed the inconsistent behavior of GET and Scan with EMPTY 
> FilterList, where Scan wasn't returning any data but Get was.
> We should apply this bug fix to branch-1 and other release branches.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-17617) Backport HBASE-16731 (Inconsistent results from the Get/Scan if we use the empty FilterList) to branch-1

2017-08-15 Thread Pankaj Kumar (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127130#comment-16127130
 ] 

Pankaj Kumar commented on HBASE-17617:
--

No problem :) 

> Backport HBASE-16731 (Inconsistent results from the Get/Scan if we use the 
> empty FilterList) to branch-1
> 
>
> Key: HBASE-17617
> URL: https://issues.apache.org/jira/browse/HBASE-17617
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.0, 1.3.1
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 1.5.0
>
> Attachments: HBASE-17617-branch-1.patch
>
>
> HBASE-16731 fixed the inconsistent behavior of GET and Scan with EMPTY 
> FilterList, where Scan wasn't returning any data but Get was.
> We should apply this bug fix to branch-1 and other release branches.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-15666) shaded dependencies for hbase-testing-util

2017-08-15 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127133#comment-16127133
 ] 

Sean Busbey commented on HBASE-15666:
-

if you make a downstream client that uses the shaded client (e.g. [YCSB's 
hbase12 
implementation|https://github.com/brianfrankcooper/YCSB/tree/master/hbase12]), 
you can't run any hbase minicluster based tests because the 
hbase-testing-utility artifact pulls in all of the third party dependencies 
that were removed by using the shaded client in the first place.

so either we need a new module, i.e. 
{{hbase-shaded/hbase-shaded-testing-util}}, that shades the 
{{hbase-testing-util}} module in the same way we shade the client, or we can 
convert {{hbase-testing-util}} into a shaded jar (right now it is an empty jar 
that pulls in the transitive dependencies needed to use our tesitng stuff). If 
we do the latter, we need to make sure it works when testing non-shaded client 
use (unless we also switch to using the shaded client by default)

now that I write this out, I'm not sure I've actually made things clearer. did 
that help?

> shaded dependencies for hbase-testing-util
> --
>
> Key: HBASE-15666
> URL: https://issues.apache.org/jira/browse/HBASE-15666
> Project: HBase
>  Issue Type: New Feature
>  Components: test
>Affects Versions: 1.1.0, 1.2.0
>Reporter: Sean Busbey
>Priority: Critical
> Fix For: 1.5.0, 2.0.0-alpha-2
>
>
> Folks that make use of our shaded client but then want to test things using 
> the hbase-testing-util end up getting all of our dependencies again in the 
> test scope.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18553) Expose scan cursor for asynchronous scanner

2017-08-15 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127155#comment-16127155
 ] 

Hadoop QA commented on HBASE-18553:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 5 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m 
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
2s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
38m 30s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
48s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}119m  
6s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
34s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}187m  8s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18553 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12881896/HBASE-18553-v1.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux c77ecea512b4 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / 0e32869 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8089/testReport/ |
| modules | C: hbase-client hbase-server U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8089/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Expose scan cursor for asy

[jira] [Created] (HBASE-18602) rsgroup cleanup unassign code

2017-08-15 Thread Wang, Xinglong (JIRA)
Wang, Xinglong created HBASE-18602:
--

 Summary: rsgroup cleanup unassign code
 Key: HBASE-18602
 URL: https://issues.apache.org/jira/browse/HBASE-18602
 Project: HBase
  Issue Type: Improvement
  Components: rsgroup
Affects Versions: 2.0.0-alpha-1
Reporter: Wang, Xinglong
Priority: Minor


While walking through rsgroup code, I found that variable misplacedRegions has 
never been added any element into. This makes the unassign region code is not 
functional. And according to my test, it is actually unnecessary to do that.

RSGroupBasedLoadBalancer.java
{code:java}
private Map> correctAssignments(
   Map> existingAssignments)
  throws HBaseIOException{
Map> correctAssignments = new TreeMap<>();
List misplacedRegions = new LinkedList<>();
correctAssignments.put(LoadBalancer.BOGUS_SERVER_NAME, new LinkedList<>());
for (Map.Entry> assignments : 
existingAssignments.entrySet()){
  ServerName sName = assignments.getKey();
  correctAssignments.put(sName, new LinkedList<>());
  List regions = assignments.getValue();
  for (HRegionInfo region : regions) {
RSGroupInfo info = null;
try {
  info = rsGroupInfoManager.getRSGroup(
  rsGroupInfoManager.getRSGroupOfTable(region.getTable()));
} catch (IOException exp) {
  LOG.debug("RSGroup information null for region of table " + 
region.getTable(),
  exp);
}
if ((info == null) || (!info.containsServer(sName.getAddress( {
  correctAssignments.get(LoadBalancer.BOGUS_SERVER_NAME).add(region);
} else {
  correctAssignments.get(sName).add(region);
}
  }
}

//TODO bulk unassign?
//unassign misplaced regions, so that they are assigned to correct groups.
for(HRegionInfo info: misplacedRegions) {
  try {
this.masterServices.getAssignmentManager().unassign(info);
  } catch (IOException e) {
throw new HBaseIOException(e);
  }
}
return correctAssignments;
  }
{code}




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18602) rsgroup cleanup unassign code

2017-08-15 Thread Wang, Xinglong (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wang, Xinglong updated HBASE-18602:
---
Attachment: HBASE-18602-master-v1.patch

> rsgroup cleanup unassign code
> -
>
> Key: HBASE-18602
> URL: https://issues.apache.org/jira/browse/HBASE-18602
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.0.0-alpha-1
>Reporter: Wang, Xinglong
>Priority: Minor
> Attachments: HBASE-18602-master-v1.patch
>
>
> While walking through rsgroup code, I found that variable misplacedRegions 
> has never been added any element into. This makes the unassign region code is 
> not functional. And according to my test, it is actually unnecessary to do 
> that.
> RSGroupBasedLoadBalancer.java
> {code:java}
> private Map> correctAssignments(
>Map> existingAssignments)
>   throws HBaseIOException{
> Map> correctAssignments = new TreeMap<>();
> List misplacedRegions = new LinkedList<>();
> correctAssignments.put(LoadBalancer.BOGUS_SERVER_NAME, new 
> LinkedList<>());
> for (Map.Entry> assignments : 
> existingAssignments.entrySet()){
>   ServerName sName = assignments.getKey();
>   correctAssignments.put(sName, new LinkedList<>());
>   List regions = assignments.getValue();
>   for (HRegionInfo region : regions) {
> RSGroupInfo info = null;
> try {
>   info = rsGroupInfoManager.getRSGroup(
>   rsGroupInfoManager.getRSGroupOfTable(region.getTable()));
> } catch (IOException exp) {
>   LOG.debug("RSGroup information null for region of table " + 
> region.getTable(),
>   exp);
> }
> if ((info == null) || (!info.containsServer(sName.getAddress( {
>   correctAssignments.get(LoadBalancer.BOGUS_SERVER_NAME).add(region);
> } else {
>   correctAssignments.get(sName).add(region);
> }
>   }
> }
> //TODO bulk unassign?
> //unassign misplaced regions, so that they are assigned to correct groups.
> for(HRegionInfo info: misplacedRegions) {
>   try {
> this.masterServices.getAssignmentManager().unassign(info);
>   } catch (IOException e) {
> throw new HBaseIOException(e);
>   }
> }
> return correctAssignments;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18602) rsgroup cleanup unassign code

2017-08-15 Thread Wang, Xinglong (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127163#comment-16127163
 ] 

Wang, Xinglong commented on HBASE-18602:


In this patch, I simply removed definition of variable misplacedRegions and the 
corresponding unassign part.

> rsgroup cleanup unassign code
> -
>
> Key: HBASE-18602
> URL: https://issues.apache.org/jira/browse/HBASE-18602
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.0.0-alpha-1
>Reporter: Wang, Xinglong
>Priority: Minor
> Attachments: HBASE-18602-master-v1.patch
>
>
> While walking through rsgroup code, I found that variable misplacedRegions 
> has never been added any element into. This makes the unassign region code is 
> not functional. And according to my test, it is actually unnecessary to do 
> that.
> RSGroupBasedLoadBalancer.java
> {code:java}
> private Map> correctAssignments(
>Map> existingAssignments)
>   throws HBaseIOException{
> Map> correctAssignments = new TreeMap<>();
> List misplacedRegions = new LinkedList<>();
> correctAssignments.put(LoadBalancer.BOGUS_SERVER_NAME, new 
> LinkedList<>());
> for (Map.Entry> assignments : 
> existingAssignments.entrySet()){
>   ServerName sName = assignments.getKey();
>   correctAssignments.put(sName, new LinkedList<>());
>   List regions = assignments.getValue();
>   for (HRegionInfo region : regions) {
> RSGroupInfo info = null;
> try {
>   info = rsGroupInfoManager.getRSGroup(
>   rsGroupInfoManager.getRSGroupOfTable(region.getTable()));
> } catch (IOException exp) {
>   LOG.debug("RSGroup information null for region of table " + 
> region.getTable(),
>   exp);
> }
> if ((info == null) || (!info.containsServer(sName.getAddress( {
>   correctAssignments.get(LoadBalancer.BOGUS_SERVER_NAME).add(region);
> } else {
>   correctAssignments.get(sName).add(region);
> }
>   }
> }
> //TODO bulk unassign?
> //unassign misplaced regions, so that they are assigned to correct groups.
> for(HRegionInfo info: misplacedRegions) {
>   try {
> this.masterServices.getAssignmentManager().unassign(info);
>   } catch (IOException e) {
> throw new HBaseIOException(e);
>   }
> }
> return correctAssignments;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18598) AsyncNonMetaRegionLocator use FIFO algorithm to get a candidate locate request

2017-08-15 Thread Guanghao Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-18598:
---
Attachment: HBASE-18598-v2.patch

Retry.

> AsyncNonMetaRegionLocator use FIFO algorithm to get a candidate locate request
> --
>
> Key: HBASE-18598
> URL: https://issues.apache.org/jira/browse/HBASE-18598
> Project: HBase
>  Issue Type: Bug
>  Components: asyncclient
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Minor
> Attachments: HBASE-18598-v1.patch, HBASE-18598-v2.patch, 
> HBASE-18598-v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18582) Correct the docs for Mutation#setCellVisibility

2017-08-15 Thread Chia-Ping Tsai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chia-Ping Tsai updated HBASE-18582:
---
  Resolution: Fixed
Hadoop Flags: Reviewed
  Status: Resolved  (was: Patch Available)

[~brandboat] Thanks for the patch.

> Correct the docs for Mutation#setCellVisibility
> ---
>
> Key: HBASE-18582
> URL: https://issues.apache.org/jira/browse/HBASE-18582
> Project: HBase
>  Issue Type: Task
>  Components: documentation
>Affects Versions: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>Reporter: Chia-Ping Tsai
>Assignee: Kuan-Po Tseng
>Priority: Minor
>  Labels: beginner
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18582.master.v0.patch
>
>
> {code}
>   /**
>* Sets the visibility expression associated with cells in this Mutation.
>* It is illegal to set CellVisibility on Delete 
> mutation.
>* @param expression
>*/
> {code}
> HBASE-10885 enable Delete to be specified with Cell Visibility, so we should 
> remove the comment " It is illegal to set..."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-2631) Decide between "InMB" and "MB" as suffix for field names in ClusterStatus objects

2017-08-15 Thread Chia-Ping Tsai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chia-Ping Tsai updated HBASE-2631:
--
Priority: Minor  (was: Major)

> Decide between "InMB" and "MB" as suffix for field names in ClusterStatus 
> objects
> -
>
> Key: HBASE-2631
> URL: https://issues.apache.org/jira/browse/HBASE-2631
> Project: HBase
>  Issue Type: Improvement
>Reporter: Jeff Hammerbacher
>Assignee: Deon Huang
>Priority: Minor
>  Labels: beginner
> Fix For: 2.0.0
>
> Attachments: HBASE-2631.branch-2.v0.patch, 
> HBASE-2631.branch-2.v1.patch, HBASE-2631.branch-2.v1.patch
>
>
> We vacillate between "InMB" (e.g. HServerLoad.getMemStoreSizeInMB(), 
> HServerLoad.getStorefileIndexSizeInMB()) and "MB" (e.g. 
> HServerLoad.getUsedHeapMB()) in the various ClusterStatus objects 
> (HServerInfo, HServerLoad, HServerLoad.RegionLoad). We should probably pick 
> one and stick to it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-2631) Decide between "InMB" and "MB" as suffix for field names in ClusterStatus objects

2017-08-15 Thread Chia-Ping Tsai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chia-Ping Tsai updated HBASE-2631:
--
  Resolution: Fixed
Hadoop Flags: Reviewed
  Status: Resolved  (was: Patch Available)

[~deonashh] Thanks for the contributions.

> Decide between "InMB" and "MB" as suffix for field names in ClusterStatus 
> objects
> -
>
> Key: HBASE-2631
> URL: https://issues.apache.org/jira/browse/HBASE-2631
> Project: HBase
>  Issue Type: Improvement
>Reporter: Jeff Hammerbacher
>Assignee: Deon Huang
>Priority: Minor
>  Labels: beginner
> Fix For: 2.0.0
>
> Attachments: HBASE-2631.branch-2.v0.patch, 
> HBASE-2631.branch-2.v1.patch, HBASE-2631.branch-2.v1.patch
>
>
> We vacillate between "InMB" (e.g. HServerLoad.getMemStoreSizeInMB(), 
> HServerLoad.getStorefileIndexSizeInMB()) and "MB" (e.g. 
> HServerLoad.getUsedHeapMB()) in the various ClusterStatus objects 
> (HServerInfo, HServerLoad, HServerLoad.RegionLoad). We should probably pick 
> one and stick to it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18546) Always overwrite the TS for Append/Increment unless no existing cells are found

2017-08-15 Thread Chia-Ping Tsai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chia-Ping Tsai updated HBASE-18546:
---
Summary: Always overwrite the TS for Append/Increment unless no existing 
cells are found  (was: Append/Increment a cell with custom timestamp)

> Always overwrite the TS for Append/Increment unless no existing cells are 
> found
> ---
>
> Key: HBASE-18546
> URL: https://issues.apache.org/jira/browse/HBASE-18546
> Project: HBase
>  Issue Type: New Feature
>  Components: API, Client
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Critical
>  Labels: incompatibleChange
> Fix For: 2.0.0
>
> Attachments: HBASE-18546.v0.patch, HBASE-18546.v1.patch
>
>
> We don't pass the custom timestamp for Increment, and the increment's 
> timestamp always be rewrite. Hence, user can't increment a cell with custom 
> timestamp.
> {code:title=ProtobufUtil.java}
>   if (values != null && values.size() > 0) {
> for (Cell cell: values) {
>   valueBuilder.clear();
>   valueBuilder.setQualifier(UnsafeByteOperations.unsafeWrap(
>   cell.getQualifierArray(), cell.getQualifierOffset(), 
> cell.getQualifierLength()));
>   valueBuilder.setValue(UnsafeByteOperations.unsafeWrap(
>   cell.getValueArray(), cell.getValueOffset(), 
> cell.getValueLength()));
>   if (cell.getTagsLength() > 0) {
> 
> valueBuilder.setTags(UnsafeByteOperations.unsafeWrap(cell.getTagsArray(),
> cell.getTagsOffset(), cell.getTagsLength()));
>   }
>   columnBuilder.addQualifierValue(valueBuilder.build());
> }
>   }
> {code}
> In contrast to Increment, user can append the cell with custom timestamp. It 
> would be better that make their behavior consistent. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-17064) Add TaskMonitor#getTasks() variant which accepts type selection

2017-08-15 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-17064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-17064:
---
Status: Open  (was: Patch Available)

> Add TaskMonitor#getTasks() variant which accepts type selection
> ---
>
> Key: HBASE-17064
> URL: https://issues.apache.org/jira/browse/HBASE-17064
> Project: HBase
>  Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Reid Chan
>Priority: Minor
>  Labels: ui
> Attachments: HBASE-17064.master.001.patch
>
>
> In TaskMonitorTmpl.jamon :
> {code}
> List tasks = taskMonitor.getTasks();
> Iterator iter = tasks.iterator();
> // apply requested filter
> while (iter.hasNext()) {
>   MonitoredTask t = iter.next();
>   if (filter.equals("general")) {
> if (t instanceof MonitoredRPCHandler)
>   iter.remove();
> {code}
> This means when user refreshes rs-status page, regardless of the type of 
> filter, we always traverse and clone MonitoredTask's.
> getTasks() is synchronized :
> {code}
>   public synchronized List getTasks() {
> {code}
> A variant of getTasks() can be added which takes the type of filter so that 
> unnecessary cloning is avoided.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-17064) Add TaskMonitor#getTasks() variant which accepts type selection

2017-08-15 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-17064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-17064:
---
Status: Patch Available  (was: Open)

> Add TaskMonitor#getTasks() variant which accepts type selection
> ---
>
> Key: HBASE-17064
> URL: https://issues.apache.org/jira/browse/HBASE-17064
> Project: HBase
>  Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Reid Chan
>Priority: Minor
>  Labels: ui
> Attachments: HBASE-17064.master.001.patch
>
>
> In TaskMonitorTmpl.jamon :
> {code}
> List tasks = taskMonitor.getTasks();
> Iterator iter = tasks.iterator();
> // apply requested filter
> while (iter.hasNext()) {
>   MonitoredTask t = iter.next();
>   if (filter.equals("general")) {
> if (t instanceof MonitoredRPCHandler)
>   iter.remove();
> {code}
> This means when user refreshes rs-status page, regardless of the type of 
> filter, we always traverse and clone MonitoredTask's.
> getTasks() is synchronized :
> {code}
>   public synchronized List getTasks() {
> {code}
> A variant of getTasks() can be added which takes the type of filter so that 
> unnecessary cloning is avoided.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18582) Correct the docs for Mutation#setCellVisibility

2017-08-15 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127250#comment-16127250
 ] 

Hudson commented on HBASE-18582:


FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #232 (See 
[https://builds.apache.org/job/HBase-1.3-JDK7/232/])
HBASE-18582 Correct the docs for Mutation#setCellVisibility (chia7712: rev 
8a9005486d10630761d7bd7947644f6461261acf)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java


> Correct the docs for Mutation#setCellVisibility
> ---
>
> Key: HBASE-18582
> URL: https://issues.apache.org/jira/browse/HBASE-18582
> Project: HBase
>  Issue Type: Task
>  Components: documentation
>Affects Versions: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>Reporter: Chia-Ping Tsai
>Assignee: Kuan-Po Tseng
>Priority: Minor
>  Labels: beginner
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18582.master.v0.patch
>
>
> {code}
>   /**
>* Sets the visibility expression associated with cells in this Mutation.
>* It is illegal to set CellVisibility on Delete 
> mutation.
>* @param expression
>*/
> {code}
> HBASE-10885 enable Delete to be specified with Cell Visibility, so we should 
> remove the comment " It is illegal to set..."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18582) Correct the docs for Mutation#setCellVisibility

2017-08-15 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127276#comment-16127276
 ] 

Hudson commented on HBASE-18582:


FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #194 (See 
[https://builds.apache.org/job/HBase-1.2-JDK7/194/])
HBASE-18582 Correct the docs for Mutation#setCellVisibility (chia7712: rev 
d61254b90884fa1c41ed112d9ecfc2489266b36f)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java


> Correct the docs for Mutation#setCellVisibility
> ---
>
> Key: HBASE-18582
> URL: https://issues.apache.org/jira/browse/HBASE-18582
> Project: HBase
>  Issue Type: Task
>  Components: documentation
>Affects Versions: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>Reporter: Chia-Ping Tsai
>Assignee: Kuan-Po Tseng
>Priority: Minor
>  Labels: beginner
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18582.master.v0.patch
>
>
> {code}
>   /**
>* Sets the visibility expression associated with cells in this Mutation.
>* It is illegal to set CellVisibility on Delete 
> mutation.
>* @param expression
>*/
> {code}
> HBASE-10885 enable Delete to be specified with Cell Visibility, so we should 
> remove the comment " It is illegal to set..."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18582) Correct the docs for Mutation#setCellVisibility

2017-08-15 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127278#comment-16127278
 ] 

Hudson commented on HBASE-18582:


SUCCESS: Integrated in Jenkins build HBase-1.3-IT #168 (See 
[https://builds.apache.org/job/HBase-1.3-IT/168/])
HBASE-18582 Correct the docs for Mutation#setCellVisibility (chia7712: rev 
8a9005486d10630761d7bd7947644f6461261acf)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java


> Correct the docs for Mutation#setCellVisibility
> ---
>
> Key: HBASE-18582
> URL: https://issues.apache.org/jira/browse/HBASE-18582
> Project: HBase
>  Issue Type: Task
>  Components: documentation
>Affects Versions: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>Reporter: Chia-Ping Tsai
>Assignee: Kuan-Po Tseng
>Priority: Minor
>  Labels: beginner
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18582.master.v0.patch
>
>
> {code}
>   /**
>* Sets the visibility expression associated with cells in this Mutation.
>* It is illegal to set CellVisibility on Delete 
> mutation.
>* @param expression
>*/
> {code}
> HBASE-10885 enable Delete to be specified with Cell Visibility, so we should 
> remove the comment " It is illegal to set..."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18582) Correct the docs for Mutation#setCellVisibility

2017-08-15 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127283#comment-16127283
 ] 

Hudson commented on HBASE-18582:


SUCCESS: Integrated in Jenkins build HBase-1.2-IT #929 (See 
[https://builds.apache.org/job/HBase-1.2-IT/929/])
HBASE-18582 Correct the docs for Mutation#setCellVisibility (chia7712: rev 
d61254b90884fa1c41ed112d9ecfc2489266b36f)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java


> Correct the docs for Mutation#setCellVisibility
> ---
>
> Key: HBASE-18582
> URL: https://issues.apache.org/jira/browse/HBASE-18582
> Project: HBase
>  Issue Type: Task
>  Components: documentation
>Affects Versions: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>Reporter: Chia-Ping Tsai
>Assignee: Kuan-Po Tseng
>Priority: Minor
>  Labels: beginner
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18582.master.v0.patch
>
>
> {code}
>   /**
>* Sets the visibility expression associated with cells in this Mutation.
>* It is illegal to set CellVisibility on Delete 
> mutation.
>* @param expression
>*/
> {code}
> HBASE-10885 enable Delete to be specified with Cell Visibility, so we should 
> remove the comment " It is illegal to set..."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-15666) shaded dependencies for hbase-testing-util

2017-08-15 Thread Mike Drob (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127310#comment-16127310
 ] 

Mike Drob commented on HBASE-15666:
---

I'm not sure. Let me try to repeat what you said in the context of a specific 
use case...

If I were to use the YCSB-hbase12 shaded client to attempt to run against a 
minicluster, then we would expect that to fail? That seems odd. I see that such 
[tests 
exist|https://github.com/brianfrankcooper/YCSB/blob/master/hbase12/src/test/java/com/yahoo/ycsb/db/hbase12/HBaseClient12Test.java]
 and I presume that they have been verified for YCSB releases (correct me if I 
have too much faith in the YCSB devs here)

Or do those tests not run the right tests to trigger the problem? I'm still 
struggling to understand how to reproduce this.

> shaded dependencies for hbase-testing-util
> --
>
> Key: HBASE-15666
> URL: https://issues.apache.org/jira/browse/HBASE-15666
> Project: HBase
>  Issue Type: New Feature
>  Components: test
>Affects Versions: 1.1.0, 1.2.0
>Reporter: Sean Busbey
>Priority: Critical
> Fix For: 1.5.0, 2.0.0-alpha-2
>
>
> Folks that make use of our shaded client but then want to test things using 
> the hbase-testing-util end up getting all of our dependencies again in the 
> test scope.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18602) rsgroup cleanup unassign code

2017-08-15 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127335#comment-16127335
 ] 

Chia-Ping Tsai commented on HBASE-18602:


Maybe we should add something to misplacedRegions? That is introduced by 
HBASE-6721.
{code}
if ((info == null) || (!info.containsServer(sName.getAddress( {
  correctAssignments.get(LoadBalancer.BOGUS_SERVER_NAME).add(region);
  // add the region to misplacedRegions? 
} else {
  correctAssignments.get(sName).add(region);
}
{code}

> rsgroup cleanup unassign code
> -
>
> Key: HBASE-18602
> URL: https://issues.apache.org/jira/browse/HBASE-18602
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.0.0-alpha-1
>Reporter: Wang, Xinglong
>Priority: Minor
> Attachments: HBASE-18602-master-v1.patch
>
>
> While walking through rsgroup code, I found that variable misplacedRegions 
> has never been added any element into. This makes the unassign region code is 
> not functional. And according to my test, it is actually unnecessary to do 
> that.
> RSGroupBasedLoadBalancer.java
> {code:java}
> private Map> correctAssignments(
>Map> existingAssignments)
>   throws HBaseIOException{
> Map> correctAssignments = new TreeMap<>();
> List misplacedRegions = new LinkedList<>();
> correctAssignments.put(LoadBalancer.BOGUS_SERVER_NAME, new 
> LinkedList<>());
> for (Map.Entry> assignments : 
> existingAssignments.entrySet()){
>   ServerName sName = assignments.getKey();
>   correctAssignments.put(sName, new LinkedList<>());
>   List regions = assignments.getValue();
>   for (HRegionInfo region : regions) {
> RSGroupInfo info = null;
> try {
>   info = rsGroupInfoManager.getRSGroup(
>   rsGroupInfoManager.getRSGroupOfTable(region.getTable()));
> } catch (IOException exp) {
>   LOG.debug("RSGroup information null for region of table " + 
> region.getTable(),
>   exp);
> }
> if ((info == null) || (!info.containsServer(sName.getAddress( {
>   correctAssignments.get(LoadBalancer.BOGUS_SERVER_NAME).add(region);
> } else {
>   correctAssignments.get(sName).add(region);
> }
>   }
> }
> //TODO bulk unassign?
> //unassign misplaced regions, so that they are assigned to correct groups.
> for(HRegionInfo info: misplacedRegions) {
>   try {
> this.masterServices.getAssignmentManager().unassign(info);
>   } catch (IOException e) {
> throw new HBaseIOException(e);
>   }
> }
> return correctAssignments;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-17064) Add TaskMonitor#getTasks() variant which accepts type selection

2017-08-15 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127344#comment-16127344
 ] 

Ted Yu commented on HBASE-17064:


Looks good, pending QA.


> Add TaskMonitor#getTasks() variant which accepts type selection
> ---
>
> Key: HBASE-17064
> URL: https://issues.apache.org/jira/browse/HBASE-17064
> Project: HBase
>  Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Reid Chan
>Priority: Minor
>  Labels: ui
> Attachments: HBASE-17064.master.001.patch
>
>
> In TaskMonitorTmpl.jamon :
> {code}
> List tasks = taskMonitor.getTasks();
> Iterator iter = tasks.iterator();
> // apply requested filter
> while (iter.hasNext()) {
>   MonitoredTask t = iter.next();
>   if (filter.equals("general")) {
> if (t instanceof MonitoredRPCHandler)
>   iter.remove();
> {code}
> This means when user refreshes rs-status page, regardless of the type of 
> filter, we always traverse and clone MonitoredTask's.
> getTasks() is synchronized :
> {code}
>   public synchronized List getTasks() {
> {code}
> A variant of getTasks() can be added which takes the type of filter so that 
> unnecessary cloning is avoided.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18598) AsyncNonMetaRegionLocator use FIFO algorithm to get a candidate locate request

2017-08-15 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127361#comment-16127361
 ] 

Ted Yu commented on HBASE-18598:


Can you fill out description, please ?

> AsyncNonMetaRegionLocator use FIFO algorithm to get a candidate locate request
> --
>
> Key: HBASE-18598
> URL: https://issues.apache.org/jira/browse/HBASE-18598
> Project: HBase
>  Issue Type: Bug
>  Components: asyncclient
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Minor
> Attachments: HBASE-18598-v1.patch, HBASE-18598-v2.patch, 
> HBASE-18598-v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18588) Verify we're using netty .so epolling on linux post HBASE-18271

2017-08-15 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127375#comment-16127375
 ] 

stack commented on HBASE-18588:
---

[~Apache9] Did you add the system property and then it started working? If so, 
I need to try and get that into eclipse runtime somehow.

On the failing UTs, [~zghaobac], for sure your failure is related, but it seems 
to work for me... the pom.xml should be providing the command-line arg.

I'm on ubuntu.

stack@ve0524:~/hbase.git$ more /etc/os-release
NAME="Ubuntu"
VERSION="14.04.4 LTS, Trusty Tahr"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 14.04.4 LTS"
VERSION_ID="14.04"
HOME_URL="http://www.ubuntu.com/";
SUPPORT_URL="http://help.ubuntu.com/";
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/";



And it seems to work...


---
 T E S T S
---
Running org.apache.hadoop.hbase.master.TestMasterNoCluster
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.198 sec - in 
org.apache.hadoop.hbase.master.TestMasterNoCluster

Results :

Tests run: 3, Failures: 0, Errors: 0, Skipped: 0

Let me try more combinations...

> Verify we're using netty .so epolling on linux post HBASE-18271
> ---
>
> Key: HBASE-18588
> URL: https://issues.apache.org/jira/browse/HBASE-18588
> Project: HBase
>  Issue Type: Task
>  Components: test
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0
>
>
> This is a task to verify that indeed we are using .so native epoll on linux. 
> This task is probably unnecessary since we'd fail on the linux build box if 
> this was not in place but verify that our relocation is indeed finding the 
> native code. Assigned myself.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18598) AsyncNonMetaRegionLocator use FIFO algorithm to get a candidate locate request

2017-08-15 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127404#comment-16127404
 ] 

Hadoop QA commented on HBASE-18598:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
15s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
47s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
31m 11s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
29s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}124m  
7s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
30s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}179m 29s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18598 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12881924/HBASE-18598-v2.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux 11a542da4bb8 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 0e32869 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8091/testReport/ |
| modules | C: hbase-client hbase-server U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8091/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> AsyncNonMetaRegionLocator use

[jira] [Commented] (HBASE-15666) shaded dependencies for hbase-testing-util

2017-08-15 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127409#comment-16127409
 ] 

Sean Busbey commented on HBASE-15666:
-

the YCSB-hbase12 shaded client will fail if the tests run.

they're currently disabled with a pointer to this issue: [ref current 
pom|https://github.com/brianfrankcooper/YCSB/blob/6c20ca60daa75fc6840e09eebf7ea8e6687e8d1d/hbase12/pom.xml#L34]

> shaded dependencies for hbase-testing-util
> --
>
> Key: HBASE-15666
> URL: https://issues.apache.org/jira/browse/HBASE-15666
> Project: HBase
>  Issue Type: New Feature
>  Components: test
>Affects Versions: 1.1.0, 1.2.0
>Reporter: Sean Busbey
>Priority: Critical
> Fix For: 1.5.0, 2.0.0-alpha-2
>
>
> Folks that make use of our shaded client but then want to test things using 
> the hbase-testing-util end up getting all of our dependencies again in the 
> test scope.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18582) Correct the docs for Mutation#setCellVisibility

2017-08-15 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127427#comment-16127427
 ] 

Hudson commented on HBASE-18582:


FAILURE: Integrated in Jenkins build HBase-1.4 #857 (See 
[https://builds.apache.org/job/HBase-1.4/857/])
HBASE-18582 Correct the docs for Mutation#setCellVisibility (chia7712: rev 
c84ca09595e642d2b52d24c10fb075c51f3d0af4)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java


> Correct the docs for Mutation#setCellVisibility
> ---
>
> Key: HBASE-18582
> URL: https://issues.apache.org/jira/browse/HBASE-18582
> Project: HBase
>  Issue Type: Task
>  Components: documentation
>Affects Versions: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>Reporter: Chia-Ping Tsai
>Assignee: Kuan-Po Tseng
>Priority: Minor
>  Labels: beginner
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18582.master.v0.patch
>
>
> {code}
>   /**
>* Sets the visibility expression associated with cells in this Mutation.
>* It is illegal to set CellVisibility on Delete 
> mutation.
>* @param expression
>*/
> {code}
> HBASE-10885 enable Delete to be specified with Cell Visibility, so we should 
> remove the comment " It is illegal to set..."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18582) Correct the docs for Mutation#setCellVisibility

2017-08-15 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127434#comment-16127434
 ] 

Hudson commented on HBASE-18582:


FAILURE: Integrated in Jenkins build HBase-1.5 #4 (See 
[https://builds.apache.org/job/HBase-1.5/4/])
HBASE-18582 Correct the docs for Mutation#setCellVisibility (chia7712: rev 
fd749ce66edefdf61e127641eb2370457142af0e)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java


> Correct the docs for Mutation#setCellVisibility
> ---
>
> Key: HBASE-18582
> URL: https://issues.apache.org/jira/browse/HBASE-18582
> Project: HBase
>  Issue Type: Task
>  Components: documentation
>Affects Versions: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>Reporter: Chia-Ping Tsai
>Assignee: Kuan-Po Tseng
>Priority: Minor
>  Labels: beginner
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18582.master.v0.patch
>
>
> {code}
>   /**
>* Sets the visibility expression associated with cells in this Mutation.
>* It is illegal to set CellVisibility on Delete 
> mutation.
>* @param expression
>*/
> {code}
> HBASE-10885 enable Delete to be specified with Cell Visibility, so we should 
> remove the comment " It is illegal to set..."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (HBASE-18082) Provide capability for backup / restore client to pace execution

2017-08-15 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu resolved HBASE-18082.

Resolution: Later

> Provide capability for backup / restore client to pace execution
> 
>
> Key: HBASE-18082
> URL: https://issues.apache.org/jira/browse/HBASE-18082
> Project: HBase
>  Issue Type: Improvement
>Reporter: Ted Yu
>  Labels: backup
>
> Currently the backup / restore is kind of monolithic in that once backup / 
> restore fails, the retry would start from the beginning of the operation.
> Backup / restore client can record the last successful substep of the current 
> operation (in backup table, e.g.) so that subsequent operation can resume 
> from this substep.
> This would allow shorter execution time for the retry operation and give 
> better user experience.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18588) Verify we're using netty .so epolling on linux post HBASE-18271

2017-08-15 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127453#comment-16127453
 ] 

stack commented on HBASE-18588:
---

I tried w/ same mvn and java 8 and seems fine for me [~zghaobac] Lets figure 
out the difference sir. You on master or branch-2? You updated?

Thanks lads. Keep speaking out. I'd like to fix all these issues that come of 
the relocations.

> Verify we're using netty .so epolling on linux post HBASE-18271
> ---
>
> Key: HBASE-18588
> URL: https://issues.apache.org/jira/browse/HBASE-18588
> Project: HBase
>  Issue Type: Task
>  Components: test
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0
>
>
> This is a task to verify that indeed we are using .so native epoll on linux. 
> This task is probably unnecessary since we'd fail on the linux build box if 
> this was not in place but verify that our relocation is indeed finding the 
> native code. Assigned myself.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18582) Correct the docs for Mutation#setCellVisibility

2017-08-15 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127461#comment-16127461
 ] 

Hudson commented on HBASE-18582:


SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #189 (See 
[https://builds.apache.org/job/HBase-1.2-JDK8/189/])
HBASE-18582 Correct the docs for Mutation#setCellVisibility (chia7712: rev 
d61254b90884fa1c41ed112d9ecfc2489266b36f)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java


> Correct the docs for Mutation#setCellVisibility
> ---
>
> Key: HBASE-18582
> URL: https://issues.apache.org/jira/browse/HBASE-18582
> Project: HBase
>  Issue Type: Task
>  Components: documentation
>Affects Versions: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>Reporter: Chia-Ping Tsai
>Assignee: Kuan-Po Tseng
>Priority: Minor
>  Labels: beginner
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18582.master.v0.patch
>
>
> {code}
>   /**
>* Sets the visibility expression associated with cells in this Mutation.
>* It is illegal to set CellVisibility on Delete 
> mutation.
>* @param expression
>*/
> {code}
> HBASE-10885 enable Delete to be specified with Cell Visibility, so we should 
> remove the comment " It is illegal to set..."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18511) Default no regions on master

2017-08-15 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-18511:
--
Attachment: HBASE-18511.master.008.patch

> Default no regions on master
> 
>
> Key: HBASE-18511
> URL: https://issues.apache.org/jira/browse/HBASE-18511
> Project: HBase
>  Issue Type: Task
>  Components: master
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-18511.master.001.patch, 
> HBASE-18511.master.002.patch, HBASE-18511.master.003.patch, 
> HBASE-18511.master.004.patch, HBASE-18511.master.005.patch, 
> HBASE-18511.master.006.patch, HBASE-18511.master.007.patch, 
> HBASE-18511.master.008.patch
>
>
> Let this be umbrella issue for no-regions-on-master as default deploy (as it 
> was in branch-1).
> Also need to make sure we can run WITH regions on master; in particular 
> system tables with RPC short-circuit as it is now in hbase master.
> Background is that master branch carried a change that allowed Master carry 
> regions. On top of this improvement on branch-1, Master defaulted to carry 
> system tables only. No release was made with this configuration. Now we are 
> going to cut the 2.0.0 release, the decision is that hbase-2 should have the 
> same layout as hbase-1 so this issue implements the undoing of Master 
> carrying system tables by default (though the capability remains).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18511) Default no regions on master

2017-08-15 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127476#comment-16127476
 ] 

stack commented on HBASE-18511:
---

.008 addresses nice review by [~zyork] up on rb.

> Default no regions on master
> 
>
> Key: HBASE-18511
> URL: https://issues.apache.org/jira/browse/HBASE-18511
> Project: HBase
>  Issue Type: Task
>  Components: master
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-18511.master.001.patch, 
> HBASE-18511.master.002.patch, HBASE-18511.master.003.patch, 
> HBASE-18511.master.004.patch, HBASE-18511.master.005.patch, 
> HBASE-18511.master.006.patch, HBASE-18511.master.007.patch, 
> HBASE-18511.master.008.patch
>
>
> Let this be umbrella issue for no-regions-on-master as default deploy (as it 
> was in branch-1).
> Also need to make sure we can run WITH regions on master; in particular 
> system tables with RPC short-circuit as it is now in hbase master.
> Background is that master branch carried a change that allowed Master carry 
> regions. On top of this improvement on branch-1, Master defaulted to carry 
> system tables only. No release was made with this configuration. Now we are 
> going to cut the 2.0.0 release, the decision is that hbase-2 should have the 
> same layout as hbase-1 so this issue implements the undoing of Master 
> carrying system tables by default (though the capability remains).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18511) Default no regions on master

2017-08-15 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127480#comment-16127480
 ] 

stack commented on HBASE-18511:
---

[~busbey] Thanks for the edit.

> Default no regions on master
> 
>
> Key: HBASE-18511
> URL: https://issues.apache.org/jira/browse/HBASE-18511
> Project: HBase
>  Issue Type: Task
>  Components: master
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-18511.master.001.patch, 
> HBASE-18511.master.002.patch, HBASE-18511.master.003.patch, 
> HBASE-18511.master.004.patch, HBASE-18511.master.005.patch, 
> HBASE-18511.master.006.patch, HBASE-18511.master.007.patch, 
> HBASE-18511.master.008.patch
>
>
> Let this be umbrella issue for no-regions-on-master as default deploy (as it 
> was in branch-1).
> Also need to make sure we can run WITH regions on master; in particular 
> system tables with RPC short-circuit as it is now in hbase master.
> Background is that master branch carried a change that allowed Master carry 
> regions. On top of this improvement on branch-1, Master defaulted to carry 
> system tables only. No release was made with this configuration. Now we are 
> going to cut the 2.0.0 release, the decision is that hbase-2 should have the 
> same layout as hbase-1 so this issue implements the undoing of Master 
> carrying system tables by default (though the capability remains).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18582) Correct the docs for Mutation#setCellVisibility

2017-08-15 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127484#comment-16127484
 ] 

Hudson commented on HBASE-18582:


SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #245 (See 
[https://builds.apache.org/job/HBase-1.3-JDK8/245/])
HBASE-18582 Correct the docs for Mutation#setCellVisibility (chia7712: rev 
8a9005486d10630761d7bd7947644f6461261acf)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java


> Correct the docs for Mutation#setCellVisibility
> ---
>
> Key: HBASE-18582
> URL: https://issues.apache.org/jira/browse/HBASE-18582
> Project: HBase
>  Issue Type: Task
>  Components: documentation
>Affects Versions: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>Reporter: Chia-Ping Tsai
>Assignee: Kuan-Po Tseng
>Priority: Minor
>  Labels: beginner
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18582.master.v0.patch
>
>
> {code}
>   /**
>* Sets the visibility expression associated with cells in this Mutation.
>* It is illegal to set CellVisibility on Delete 
> mutation.
>* @param expression
>*/
> {code}
> HBASE-10885 enable Delete to be specified with Cell Visibility, so we should 
> remove the comment " It is illegal to set..."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-17064) Add TaskMonitor#getTasks() variant which accepts type selection

2017-08-15 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127503#comment-16127503
 ] 

Hadoop QA commented on HBASE-17064:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m  
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git 
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply 
{color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
30m 25s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}111m  
2s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
22s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}161m 23s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-17064 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12881886/HBASE-17064.master.001.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux 46a660f09ca7 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 
18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / d37266f |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| whitespace | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8092/artifact/patchprocess/whitespace-eol.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8092/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8092/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Add TaskMonitor#getTasks() variant which accepts type selection
> ---
>
> Key: HBASE-17064
> URL: https://issues.apache.org/jira/browse/HBASE-17064
> Project

[jira] [Updated] (HBASE-17064) Add TaskMonitor#getTasks() variant which accepts type selection

2017-08-15 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-17064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-17064:
---
   Resolution: Fixed
 Hadoop Flags: Reviewed
Fix Version/s: 2.0.0-alpha-2
   3.0.0
   Status: Resolved  (was: Patch Available)

Thanks for the patch, Reid

> Add TaskMonitor#getTasks() variant which accepts type selection
> ---
>
> Key: HBASE-17064
> URL: https://issues.apache.org/jira/browse/HBASE-17064
> Project: HBase
>  Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Reid Chan
>Priority: Minor
>  Labels: ui
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-17064.master.001.patch
>
>
> In TaskMonitorTmpl.jamon :
> {code}
> List tasks = taskMonitor.getTasks();
> Iterator iter = tasks.iterator();
> // apply requested filter
> while (iter.hasNext()) {
>   MonitoredTask t = iter.next();
>   if (filter.equals("general")) {
> if (t instanceof MonitoredRPCHandler)
>   iter.remove();
> {code}
> This means when user refreshes rs-status page, regardless of the type of 
> filter, we always traverse and clone MonitoredTask's.
> getTasks() is synchronized :
> {code}
>   public synchronized List getTasks() {
> {code}
> A variant of getTasks() can be added which takes the type of filter so that 
> unnecessary cloning is avoided.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18600) Provide a method to disable the Short-Circuit HTable in coprocessor

2017-08-15 Thread Anoop Sam John (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127523#comment-16127523
 ] 

Anoop Sam John commented on HBASE-18600:


Why we need this?  What is the need to avoid the short circuit?  Whether short 
circuit or not should be abstracted out from the CP user. (IMO)

> Provide a method to disable the Short-Circuit HTable in coprocessor
> ---
>
> Key: HBASE-18600
> URL: https://issues.apache.org/jira/browse/HBASE-18600
> Project: HBase
>  Issue Type: Improvement
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Attachments: HBASE-18600.master.001.patch
>
>
> HBASE-9534: Allow coprocessors accessing an HTable to short-circuit access to 
> the local HRegionServer, rather than requiring the usual RPC path. And it 
> only worked for RegionCoprocessorEnvironment. This issue add a new method for 
> RegionCoprocessorEnvironment.  getShortCircuitTable method is used to get a  
> short-circuit access HTable. And getTable method is used to get a normal 
> table.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18572) Delete#addColumn can't remove the cell which has no visibility label

2017-08-15 Thread Anoop Sam John (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127541#comment-16127541
 ] 

Anoop Sam John commented on HBASE-18572:


Looks good.
VLS#matchVisibility() is used in VisibilityScanDeleteTracker#isDeleted() also.  
Do we need special check there also?  Did not check in detail. Just asking.

> Delete#addColumn can't remove the cell which has no visibility label
> 
>
> Key: HBASE-18572
> URL: https://issues.apache.org/jira/browse/HBASE-18572
> Project: HBase
>  Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Attachments: HBASE-18572.ut.patch, HBASE-18572.v0.patch, 
> HBASE-18572.v0.patch
>
>
> {code:title=DefaultVisibilityLabelServiceImpl.java}
>   @Override
>   public boolean matchVisibility(List putVisTags, Byte putTagsFormat, 
> List deleteVisTags,
>   Byte deleteTagsFormat) throws IOException {
> if ((deleteTagsFormat != null && deleteTagsFormat == 
> SORTED_ORDINAL_SERIALIZATION_FORMAT)
> && (putTagsFormat == null || putTagsFormat == 
> SORTED_ORDINAL_SERIALIZATION_FORMAT)) {
>   if (putVisTags.isEmpty()) {
> // Early out if there are no tags in the cell
> return false;
>   }
>   if (putTagsFormat == null) {
> return matchUnSortedVisibilityTags(putVisTags, deleteVisTags);
>   } else {
> return matchOrdinalSortedVisibilityTags(putVisTags, deleteVisTags);
>   }
> }
> throw new IOException("Unexpected tag format passed for comparison, 
> deleteTagsFormat : "
> + deleteTagsFormat + ", putTagsFormat : " + putTagsFormat);
>   }
> {code}
> If the putVisTags is empty, it will return the false directly. Hence, the 
> Delete#addColumn can't "see" the cell as well as deleting it. The 
> Delete#addColumns, by contrast, doesn't invoke the 
> cp#prePrepareTimeStampForDeleteVersion so it can remove the cell.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-15 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-18587:
--
Attachment: HBASE-18587.master.002.patch

Retry. The test failures seem unrelated (I tried 
org.apache.hadoop.hbase.client.TestClientScannerRPCTimeout locally and it 
passes).

[~zyork] Which branches do you want this applied to sir?

> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.branch-1.002.patch, HBASE-18587.master.001.patch, 
> HBASE-18587.master.001.patch, HBASE-18587.master.002.patch, 
> HBASE-18587.master.002.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine 
> failed. I investigated and noticed that there are two cases where this test 
> is flaky:
> len = 0 and offset 0; it will fail for 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
>  will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity 
> which is not allowed.
>  
> This patch fixes this test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18082) Provide capability for backup / restore client to pace execution

2017-08-15 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127585#comment-16127585
 ] 

stack commented on HBASE-18082:
---

Why resolution 'later'? This seems like a good idea, an assist to the user. Why 
is it resolved?

> Provide capability for backup / restore client to pace execution
> 
>
> Key: HBASE-18082
> URL: https://issues.apache.org/jira/browse/HBASE-18082
> Project: HBase
>  Issue Type: Improvement
>Reporter: Ted Yu
>  Labels: backup
>
> Currently the backup / restore is kind of monolithic in that once backup / 
> restore fails, the retry would start from the beginning of the operation.
> Backup / restore client can record the last successful substep of the current 
> operation (in backup table, e.g.) so that subsequent operation can resume 
> from this substep.
> This would allow shorter execution time for the retry operation and give 
> better user experience.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Reopened] (HBASE-18082) Provide capability for backup / restore client to pace execution

2017-08-15 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu reopened HBASE-18082:


> Provide capability for backup / restore client to pace execution
> 
>
> Key: HBASE-18082
> URL: https://issues.apache.org/jira/browse/HBASE-18082
> Project: HBase
>  Issue Type: Improvement
>Reporter: Ted Yu
>  Labels: backup
>
> Currently the backup / restore is kind of monolithic in that once backup / 
> restore fails, the retry would start from the beginning of the operation.
> Backup / restore client can record the last successful substep of the current 
> operation (in backup table, e.g.) so that subsequent operation can resume 
> from this substep.
> This would allow shorter execution time for the retry operation and give 
> better user experience.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18082) Provide capability for backup / restore client to pace execution

2017-08-15 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127593#comment-16127593
 ] 

Ted Yu commented on HBASE-18082:


It was resolved due to lack of resource.


> Provide capability for backup / restore client to pace execution
> 
>
> Key: HBASE-18082
> URL: https://issues.apache.org/jira/browse/HBASE-18082
> Project: HBase
>  Issue Type: Improvement
>Reporter: Ted Yu
>  Labels: backup
>
> Currently the backup / restore is kind of monolithic in that once backup / 
> restore fails, the retry would start from the beginning of the operation.
> Backup / restore client can record the last successful substep of the current 
> operation (in backup table, e.g.) so that subsequent operation can resume 
> from this substep.
> This would allow shorter execution time for the retry operation and give 
> better user experience.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18598) AsyncNonMetaRegionLocator use FIFO algorithm to get a candidate locate request

2017-08-15 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127596#comment-16127596
 ] 

stack commented on HBASE-18598:
---

+1 Release note the change in behavior please. Thanks [~zghaobac]

> AsyncNonMetaRegionLocator use FIFO algorithm to get a candidate locate request
> --
>
> Key: HBASE-18598
> URL: https://issues.apache.org/jira/browse/HBASE-18598
> Project: HBase
>  Issue Type: Bug
>  Components: asyncclient
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Minor
> Attachments: HBASE-18598-v1.patch, HBASE-18598-v2.patch, 
> HBASE-18598-v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18082) Provide capability for backup / restore client to pace execution

2017-08-15 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127601#comment-16127601
 ] 

stack commented on HBASE-18082:
---

It was assigned to no one. Seems like a usability problem that needs 
addressing. Does backup/restore lack resources? Will it not be completed?

> Provide capability for backup / restore client to pace execution
> 
>
> Key: HBASE-18082
> URL: https://issues.apache.org/jira/browse/HBASE-18082
> Project: HBase
>  Issue Type: Improvement
>Reporter: Ted Yu
>  Labels: backup
>
> Currently the backup / restore is kind of monolithic in that once backup / 
> restore fails, the retry would start from the beginning of the operation.
> Backup / restore client can record the last successful substep of the current 
> operation (in backup table, e.g.) so that subsequent operation can resume 
> from this substep.
> This would allow shorter execution time for the retry operation and give 
> better user experience.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18599) Add missing @Deprecated annotations

2017-08-15 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-18599:
--
   Resolution: Fixed
 Hadoop Flags: Reviewed
Fix Version/s: 2.0.0
   Status: Resolved  (was: Patch Available)

Excellent. Thanks [~lars_francke]  Pushed to master and branch-2. FYI, add JIRA 
to comment as prefix on future patches.  Good stuff.

> Add missing @Deprecated annotations
> ---
>
> Key: HBASE-18599
> URL: https://issues.apache.org/jira/browse/HBASE-18599
> Project: HBase
>  Issue Type: Bug
>Reporter: Lars Francke
>Assignee: Lars Francke
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-18599.patch
>
>
> There are a couple of places where deprecations have only been added in the 
> Javadoc but the annotation is missing.
> I'll also change the Javadoc to be consistent with what I've done in 
> HBASE-13462.
> This is for master/2.0.0 only.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18511) Default no regions on master

2017-08-15 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127622#comment-16127622
 ] 

Hadoop QA commented on HBASE-18511:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
27s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 22 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 40s{color} 
| {color:red} hbase-server generated 2 new + 6 unchanged - 0 fixed = 8 total 
(was 6) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
33m 17s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
28s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 25m 37s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
11s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 76m 37s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.TestCheckTestClasses |
|   | hadoop.hbase.client.TestClientClusterStatus |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18511 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12881964/HBASE-18511.master.008.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux 94fe1b65a9ea 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / d37266f |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| javac | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8093/artifact/patchprocess/diff-compile-javac-hbase-server.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8093/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8093/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8093/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Default no regions on ma

[jira] [Updated] (HBASE-18581) Remove dead code and some tidy up in BaseLoadBalancer

2017-08-15 Thread Umesh Agashe (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Umesh Agashe updated HBASE-18581:
-
Attachment: hbase-18581.master.002.patch

Changes per [~appy]'s review comments.

> Remove dead code and some tidy up in BaseLoadBalancer
> -
>
> Key: HBASE-18581
> URL: https://issues.apache.org/jira/browse/HBASE-18581
> Project: HBase
>  Issue Type: Improvement
>  Components: Balancer
>Reporter: Umesh Agashe
>Assignee: Umesh Agashe
>Priority: Minor
> Attachments: hbase-18581.master.001.patch, 
> hbase-18581.master.002.patch
>
>
> * calls to methods getLowestLocalityRegionServer() & 
> getLeastLoadedTopServerForRegion() got removed in HBASE-18164
> * call to calculateRegionServerLocalities() got removed in HBASE-15486
> * Some other minor improvements



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18526) FIFOCompactionPolicy pre-check uses wrong scope

2017-08-15 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-18526:
---
Attachment: 18526.branch-1.txt

> FIFOCompactionPolicy pre-check uses wrong scope
> ---
>
> Key: HBASE-18526
> URL: https://issues.apache.org/jira/browse/HBASE-18526
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 1.3.1
>Reporter: Lars George
>Assignee: Vladimir Rodionov
> Attachments: 18526.branch-1.txt, HBASE-18526-v1.patch
>
>
> See https://issues.apache.org/jira/browse/HBASE-14468
> It adds this check to {{HMaster.checkCompactionPolicy()}}:
> {code}
> // 1. Check TTL
> if (hcd.getTimeToLive() == HColumnDescriptor.DEFAULT_TTL) {
>   message = "Default TTL is not supported for FIFO compaction";
>   throw new IOException(message);
> }
> // 2. Check min versions
> if (hcd.getMinVersions() > 0) {
>   message = "MIN_VERSION > 0 is not supported for FIFO compaction";
>   throw new IOException(message);
> }
> // 3. blocking file count
> String sbfc = htd.getConfigurationValue(HStore.BLOCKING_STOREFILES_KEY);
> if (sbfc != null) {
>   blockingFileCount = Integer.parseInt(sbfc);
> }
> if (blockingFileCount < 1000) {
>   message =
>   "blocking file count '" + HStore.BLOCKING_STOREFILES_KEY + "' "
> + blockingFileCount
>   + " is below recommended minimum of 1000";
>   throw new IOException(message);
> }
> {code}
> Why does it only check the blocking file count on the HTD level, while
> others are check on the HCD level? Doing this for example fails
> because of it:
> {noformat}
> hbase(main):008:0> create 'ttltable', { NAME => 'cf1', TTL => 300,
> CONFIGURATION => { 'hbase.hstore.defaultengine.compactionpolicy.class'
> => 'org.apache.hadoop.hbase.regionserver.compactions.FIFOCompactionPolicy',
> 'hbase.hstore.blockingStoreFiles' => 2000 } }
> ERROR: org.apache.hadoop.hbase.DoNotRetryIOException: blocking file
> count 'hbase.hstore.blockingStoreFiles' 10 is below recommended
> minimum of 1000 Set hbase.table.sanity.checks to false at conf or
> table descriptor if you want to bypass sanity checks
> at 
> org.apache.hadoop.hbase.master.HMaster.warnOrThrowExceptionForFailure(HMaster.java:1782)
> at 
> org.apache.hadoop.hbase.master.HMaster.sanityCheckTableDescriptor(HMaster.java:1663)
> at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:1545)
> at 
> org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:469)
> at 
> org.apache.hadoop.hbase.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java:58549)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2339)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123)
> at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188)
> at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> Caused by: java.io.IOException: blocking file count
> 'hbase.hstore.blockingStoreFiles' 10 is below recommended minimum of
> 1000
> at 
> org.apache.hadoop.hbase.master.HMaster.checkCompactionPolicy(HMaster.java:1773)
> at 
> org.apache.hadoop.hbase.master.HMaster.sanityCheckTableDescriptor(HMaster.java:1661)
> ... 7 more
> {noformat}
> The check should be performed on the column family level instead.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18526) FIFOCompactionPolicy pre-check uses wrong scope

2017-08-15 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-18526:
---
   Resolution: Fixed
 Hadoop Flags: Reviewed
Fix Version/s: 2.0.0-alpha-2
   1.5.0
   1.4.0
   3.0.0
   Status: Resolved  (was: Patch Available)

> FIFOCompactionPolicy pre-check uses wrong scope
> ---
>
> Key: HBASE-18526
> URL: https://issues.apache.org/jira/browse/HBASE-18526
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 1.3.1
>Reporter: Lars George
>Assignee: Vladimir Rodionov
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-2
>
> Attachments: 18526.branch-1.txt, HBASE-18526-v1.patch
>
>
> See https://issues.apache.org/jira/browse/HBASE-14468
> It adds this check to {{HMaster.checkCompactionPolicy()}}:
> {code}
> // 1. Check TTL
> if (hcd.getTimeToLive() == HColumnDescriptor.DEFAULT_TTL) {
>   message = "Default TTL is not supported for FIFO compaction";
>   throw new IOException(message);
> }
> // 2. Check min versions
> if (hcd.getMinVersions() > 0) {
>   message = "MIN_VERSION > 0 is not supported for FIFO compaction";
>   throw new IOException(message);
> }
> // 3. blocking file count
> String sbfc = htd.getConfigurationValue(HStore.BLOCKING_STOREFILES_KEY);
> if (sbfc != null) {
>   blockingFileCount = Integer.parseInt(sbfc);
> }
> if (blockingFileCount < 1000) {
>   message =
>   "blocking file count '" + HStore.BLOCKING_STOREFILES_KEY + "' "
> + blockingFileCount
>   + " is below recommended minimum of 1000";
>   throw new IOException(message);
> }
> {code}
> Why does it only check the blocking file count on the HTD level, while
> others are check on the HCD level? Doing this for example fails
> because of it:
> {noformat}
> hbase(main):008:0> create 'ttltable', { NAME => 'cf1', TTL => 300,
> CONFIGURATION => { 'hbase.hstore.defaultengine.compactionpolicy.class'
> => 'org.apache.hadoop.hbase.regionserver.compactions.FIFOCompactionPolicy',
> 'hbase.hstore.blockingStoreFiles' => 2000 } }
> ERROR: org.apache.hadoop.hbase.DoNotRetryIOException: blocking file
> count 'hbase.hstore.blockingStoreFiles' 10 is below recommended
> minimum of 1000 Set hbase.table.sanity.checks to false at conf or
> table descriptor if you want to bypass sanity checks
> at 
> org.apache.hadoop.hbase.master.HMaster.warnOrThrowExceptionForFailure(HMaster.java:1782)
> at 
> org.apache.hadoop.hbase.master.HMaster.sanityCheckTableDescriptor(HMaster.java:1663)
> at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:1545)
> at 
> org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:469)
> at 
> org.apache.hadoop.hbase.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java:58549)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2339)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123)
> at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188)
> at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> Caused by: java.io.IOException: blocking file count
> 'hbase.hstore.blockingStoreFiles' 10 is below recommended minimum of
> 1000
> at 
> org.apache.hadoop.hbase.master.HMaster.checkCompactionPolicy(HMaster.java:1773)
> at 
> org.apache.hadoop.hbase.master.HMaster.sanityCheckTableDescriptor(HMaster.java:1661)
> ... 7 more
> {noformat}
> The check should be performed on the column family level instead.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (HBASE-18603) buck complains about Build target path containing double slash

2017-08-15 Thread Ted Yu (JIRA)
Ted Yu created HBASE-18603:
--

 Summary: buck complains about Build target path containing double 
slash
 Key: HBASE-18603
 URL: https://issues.apache.org/jira/browse/HBASE-18603
 Project: HBase
  Issue Type: Sub-task
Reporter: Ted Yu


When I use buck built from latest git repo, I get the following build error:
{code}
BUILD FAILED: Build target path cannot contain // other than at the start (or 
after a cell name) (found //connection//...)

This error happened while trying to get dependency '//exceptions:exceptions' of 
target '//connection:connection'
{code}
It was due to the following line from hbase-native-client/exceptions/BUCK
{code}
visibility=['//core/...', '//connection//...'],)
{code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18544) Move the HRegion#addRegionToMETA to TestDefaultMemStore

2017-08-15 Thread ChunHao (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ChunHao updated HBASE-18544:

Attachment: HBASE-18544.master.v0.patch

> Move the HRegion#addRegionToMETA to TestDefaultMemStore
> ---
>
> Key: HBASE-18544
> URL: https://issues.apache.org/jira/browse/HBASE-18544
> Project: HBase
>  Issue Type: Task
>  Components: regionserver
>Affects Versions: 3.0.0, 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>Assignee: ChunHao
>Priority: Minor
>  Labels: beginner
> Fix For: 2.0.0
>
> Attachments: HBASE-18544.master.v0.patch
>
>
> The usages of addRegionToMETA  are almost removed by HBASE-17470. 
> HRegion#addRegionToMETA is used only by TestDefaultMemStore now. Let us 
> reduce the file size of HRegion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18544) Move the HRegion#addRegionToMETA to TestDefaultMemStore

2017-08-15 Thread ChunHao (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ChunHao updated HBASE-18544:

Status: Patch Available  (was: Open)

> Move the HRegion#addRegionToMETA to TestDefaultMemStore
> ---
>
> Key: HBASE-18544
> URL: https://issues.apache.org/jira/browse/HBASE-18544
> Project: HBase
>  Issue Type: Task
>  Components: regionserver
>Affects Versions: 2.0.0-alpha-1, 3.0.0
>Reporter: Chia-Ping Tsai
>Assignee: ChunHao
>Priority: Minor
>  Labels: beginner
> Fix For: 2.0.0
>
> Attachments: HBASE-18544.master.v0.patch
>
>
> The usages of addRegionToMETA  are almost removed by HBASE-17470. 
> HRegion#addRegionToMETA is used only by TestDefaultMemStore now. Let us 
> reduce the file size of HRegion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (HBASE-18603) buck complains about Build target path containing double slash

2017-08-15 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu resolved HBASE-18603.

Resolution: Fixed

> buck complains about Build target path containing double slash
> --
>
> Key: HBASE-18603
> URL: https://issues.apache.org/jira/browse/HBASE-18603
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>
> When I use buck built from latest git repo, I get the following build error:
> {code}
> BUILD FAILED: Build target path cannot contain // other than at the start (or 
> after a cell name) (found //connection//...)
> This error happened while trying to get dependency '//exceptions:exceptions' 
> of target '//connection:connection'
> {code}
> It was due to the following line from hbase-native-client/exceptions/BUCK
> {code}
> visibility=['//core/...', '//connection//...'],)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18512) Region Server will abort with IllegalStateException if HDFS umask has limited scope

2017-08-15 Thread Yi Liang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127678#comment-16127678
 ] 

Yi Liang commented on HBASE-18512:
--

lgtm

> Region Server will abort with IllegalStateException if HDFS umask has limited 
> scope
> ---
>
> Key: HBASE-18512
> URL: https://issues.apache.org/jira/browse/HBASE-18512
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver, security
>Affects Versions: 1.4.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
> Fix For: 1.5.0
>
> Attachments: HBASE-18512-branch-1.patch
>
>
> If HDFS umask (fs.permissions.umask-mode) has limited scope say 077 then 
> file/dir permission will not be wider than 700. HDFS client has to set 
> permission explicitly if required.
> During SecureBulkLoadEndpoint CP start, RegionServer creates (if not exist) 
> the staging directory with the specified permission and later throws 
> IllegalStateException if staging directory permission is not set to 711.
> After HBASE-17861, we are setting staging dir permission explicitly only when 
> it exist. In case of fresh cluster startup staging dir permission wont be 711 
> when umask defined as 077 which cause RS to abort.
> {noformat}
> 2017-07-30 14:26:33,350 | ERROR | 
> B.defaultRpcServer.handler=12,queue=2,port=21300 | Region server 
> HOSTNAME,PORT,X reported a fatal error:
> ABORTING region server HOSTNAME,PORT,X: The coprocessor 
> org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint threw 
> java.lang.IllegalStateException: Staging directory of 
> /user/HBase/hbase-staging already exists but permissions aren't set to 
> '-rwx--x--x' 
> Cause:
> java.lang.IllegalStateException: Staging directory of 
> /user/root/hbase-staging already exists but permissions aren't set to 
> '-rwx--x--x' 
> {noformat}
> We should set permission explicitly to 711 after staging directory creation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (HBASE-18604) Use latest buck for building

2017-08-15 Thread Ted Yu (JIRA)
Ted Yu created HBASE-18604:
--

 Summary: Use latest buck for building
 Key: HBASE-18604
 URL: https://issues.apache.org/jira/browse/HBASE-18604
 Project: HBase
  Issue Type: Sub-task
Reporter: Ted Yu


The current buck in Docker image came from 2016 which is old.

Newer buck has stricter syntax check (see HBASE-18603).

We should pull latest buck in Dockerfile and build buck for docker VM.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (HBASE-18603) buck complains about Build target path containing double slash

2017-08-15 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu reassigned HBASE-18603:
--

Assignee: Ted Yu

> buck complains about Build target path containing double slash
> --
>
> Key: HBASE-18603
> URL: https://issues.apache.org/jira/browse/HBASE-18603
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
>
> When I use buck built from latest git repo, I get the following build error:
> {code}
> BUILD FAILED: Build target path cannot contain // other than at the start (or 
> after a cell name) (found //connection//...)
> This error happened while trying to get dependency '//exceptions:exceptions' 
> of target '//connection:connection'
> {code}
> It was due to the following line from hbase-native-client/exceptions/BUCK
> {code}
> visibility=['//core/...', '//connection//...'],)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18599) Add missing @Deprecated annotations

2017-08-15 Thread Lars Francke (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127686#comment-16127686
 ] 

Lars Francke commented on HBASE-18599:
--

Thank you @stack!

Can you elaborate what you mean with your comment though? I thought I've done 
it correct this time.

> Add missing @Deprecated annotations
> ---
>
> Key: HBASE-18599
> URL: https://issues.apache.org/jira/browse/HBASE-18599
> Project: HBase
>  Issue Type: Bug
>Reporter: Lars Francke
>Assignee: Lars Francke
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-18599.patch
>
>
> There are a couple of places where deprecations have only been added in the 
> Javadoc but the annotation is missing.
> I'll also change the Javadoc to be consistent with what I've done in 
> HBASE-13462.
> This is for master/2.0.0 only.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18599) Add missing @Deprecated annotations

2017-08-15 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127701#comment-16127701
 ] 

stack commented on HBASE-18599:
---

Hmm... 

When I did git am w/ the patch, here is what showed up as commit message:

{code}
commit abb83c89e1902e4f5203d87040de251498d1d2cf
Author: Lars Francke 
Date:   Tue Aug 15 09:36:51 2017 +0200

Add missing @Deprecated annotations
{code}

... there is no JIRA. I added it.

Looking at your patch, I see JIRA in the title.

If I remove the square brackets around the JIRA, then the git am works.



> Add missing @Deprecated annotations
> ---
>
> Key: HBASE-18599
> URL: https://issues.apache.org/jira/browse/HBASE-18599
> Project: HBase
>  Issue Type: Bug
>Reporter: Lars Francke
>Assignee: Lars Francke
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-18599.patch
>
>
> There are a couple of places where deprecations have only been added in the 
> Javadoc but the annotation is missing.
> I'll also change the Javadoc to be consistent with what I've done in 
> HBASE-13462.
> This is for master/2.0.0 only.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18532) Improve cache related stats rendered on RS UI

2017-08-15 Thread Biju Nair (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Biju Nair updated HBASE-18532:
--
Attachment: HBASE-18532.WIP

Updated WIP patch. Data block stats (count and size) are tracked in the 
BlockCache. The drawback is the added time to update the stats.

> Improve cache related stats rendered on RS UI
> -
>
> Key: HBASE-18532
> URL: https://issues.apache.org/jira/browse/HBASE-18532
> Project: HBase
>  Issue Type: Improvement
>  Components: regionserver, UI
>Affects Versions: 1.1.2
>Reporter: Biju Nair
>Assignee: Biju Nair
> Attachments: COMBINED-STATS.PNG, HBASE-18532.WIP, L1-STATS.PNG, 
> L2-STATS.PNG
>
>
> The stats currently rendered for L1 and L2 cache are incorrect. Refer to the 
> attached screenshots of stats from a cluster showing the combined cache 
> stats, L1 stats and L2 stats. For e.g. the combined stats shows 38 GB used 
> for cache while if we sum size of L1 and L2 cache the value is way less. One 
> way we can improve this is to use the same stats used to populate the 
> combined stats to render the values of L1 & L2 cache. Also for usability we 
> can remove the table with details with BucketCache buckets from the L2 cache 
> stats since this is going to be long for any installation using L2 cache. 
> This will help in understanding the cache usage better. Thoughts? If there 
> are no concerns will submit a patch. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18532) Improve cache related stats rendered on RS UI

2017-08-15 Thread Biju Nair (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Biju Nair updated HBASE-18532:
--
Attachment: (was: HBASE-18532.WIP)

> Improve cache related stats rendered on RS UI
> -
>
> Key: HBASE-18532
> URL: https://issues.apache.org/jira/browse/HBASE-18532
> Project: HBase
>  Issue Type: Improvement
>  Components: regionserver, UI
>Affects Versions: 1.1.2
>Reporter: Biju Nair
>Assignee: Biju Nair
> Attachments: COMBINED-STATS.PNG, HBASE-18532.WIP, L1-STATS.PNG, 
> L2-STATS.PNG
>
>
> The stats currently rendered for L1 and L2 cache are incorrect. Refer to the 
> attached screenshots of stats from a cluster showing the combined cache 
> stats, L1 stats and L2 stats. For e.g. the combined stats shows 38 GB used 
> for cache while if we sum size of L1 and L2 cache the value is way less. One 
> way we can improve this is to use the same stats used to populate the 
> combined stats to render the values of L1 & L2 cache. Also for usability we 
> can remove the table with details with BucketCache buckets from the L2 cache 
> stats since this is going to be long for any installation using L2 cache. 
> This will help in understanding the cache usage better. Thoughts? If there 
> are no concerns will submit a patch. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18511) Default no regions on master

2017-08-15 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-18511:
--
Attachment: HBASE-18511.master.009.patch

> Default no regions on master
> 
>
> Key: HBASE-18511
> URL: https://issues.apache.org/jira/browse/HBASE-18511
> Project: HBase
>  Issue Type: Task
>  Components: master
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-18511.master.001.patch, 
> HBASE-18511.master.002.patch, HBASE-18511.master.003.patch, 
> HBASE-18511.master.004.patch, HBASE-18511.master.005.patch, 
> HBASE-18511.master.006.patch, HBASE-18511.master.007.patch, 
> HBASE-18511.master.008.patch, HBASE-18511.master.009.patch
>
>
> Let this be umbrella issue for no-regions-on-master as default deploy (as it 
> was in branch-1).
> Also need to make sure we can run WITH regions on master; in particular 
> system tables with RPC short-circuit as it is now in hbase master.
> Background is that master branch carried a change that allowed Master carry 
> regions. On top of this improvement on branch-1, Master defaulted to carry 
> system tables only. No release was made with this configuration. Now we are 
> going to cut the 2.0.0 release, the decision is that hbase-2 should have the 
> same layout as hbase-1 so this issue implements the undoing of Master 
> carrying system tables by default (though the capability remains).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18511) Default no regions on master

2017-08-15 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127748#comment-16127748
 ] 

stack commented on HBASE-18511:
---

.009 Fix test failures.

> Default no regions on master
> 
>
> Key: HBASE-18511
> URL: https://issues.apache.org/jira/browse/HBASE-18511
> Project: HBase
>  Issue Type: Task
>  Components: master
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-18511.master.001.patch, 
> HBASE-18511.master.002.patch, HBASE-18511.master.003.patch, 
> HBASE-18511.master.004.patch, HBASE-18511.master.005.patch, 
> HBASE-18511.master.006.patch, HBASE-18511.master.007.patch, 
> HBASE-18511.master.008.patch, HBASE-18511.master.009.patch
>
>
> Let this be umbrella issue for no-regions-on-master as default deploy (as it 
> was in branch-1).
> Also need to make sure we can run WITH regions on master; in particular 
> system tables with RPC short-circuit as it is now in hbase master.
> Background is that master branch carried a change that allowed Master carry 
> regions. On top of this improvement on branch-1, Master defaulted to carry 
> system tables only. No release was made with this configuration. Now we are 
> going to cut the 2.0.0 release, the decision is that hbase-2 should have the 
> same layout as hbase-1 so this issue implements the undoing of Master 
> carrying system tables by default (though the capability remains).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18511) Default no regions on master

2017-08-15 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127749#comment-16127749
 ] 

stack commented on HBASE-18511:
---

Looking for a +1!

> Default no regions on master
> 
>
> Key: HBASE-18511
> URL: https://issues.apache.org/jira/browse/HBASE-18511
> Project: HBase
>  Issue Type: Task
>  Components: master
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-18511.master.001.patch, 
> HBASE-18511.master.002.patch, HBASE-18511.master.003.patch, 
> HBASE-18511.master.004.patch, HBASE-18511.master.005.patch, 
> HBASE-18511.master.006.patch, HBASE-18511.master.007.patch, 
> HBASE-18511.master.008.patch, HBASE-18511.master.009.patch
>
>
> Let this be umbrella issue for no-regions-on-master as default deploy (as it 
> was in branch-1).
> Also need to make sure we can run WITH regions on master; in particular 
> system tables with RPC short-circuit as it is now in hbase master.
> Background is that master branch carried a change that allowed Master carry 
> regions. On top of this improvement on branch-1, Master defaulted to carry 
> system tables only. No release was made with this configuration. Now we are 
> going to cut the 2.0.0 release, the decision is that hbase-2 should have the 
> same layout as hbase-1 so this issue implements the undoing of Master 
> carrying system tables by default (though the capability remains).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18544) Move the HRegion#addRegionToMETA to TestDefaultMemStore

2017-08-15 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127759#comment-16127759
 ] 

stack commented on HBASE-18544:
---

+1 Waiting on hadoopqa report before commit.

> Move the HRegion#addRegionToMETA to TestDefaultMemStore
> ---
>
> Key: HBASE-18544
> URL: https://issues.apache.org/jira/browse/HBASE-18544
> Project: HBase
>  Issue Type: Task
>  Components: regionserver
>Affects Versions: 3.0.0, 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>Assignee: ChunHao
>Priority: Minor
>  Labels: beginner
> Fix For: 2.0.0
>
> Attachments: HBASE-18544.master.v0.patch
>
>
> The usages of addRegionToMETA  are almost removed by HBASE-17470. 
> HRegion#addRegionToMETA is used only by TestDefaultMemStore now. Let us 
> reduce the file size of HRegion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18504) Add documentation for WAL compression

2017-08-15 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127767#comment-16127767
 ] 

stack commented on HBASE-18504:
---

Doc is excellent [~psomogyi]  Let me commit after adding a one-sentence on 
possible downside; i.e. could lose data from the last written block if new 
dictionary item in most recent writes... rare but worth note.

> Add documentation for WAL compression
> -
>
> Key: HBASE-18504
> URL: https://issues.apache.org/jira/browse/HBASE-18504
> Project: HBase
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.0.0, 2.0.0-alpha-2
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-18504.master.001.patch, 
> HBASE-18504.master.001.patch
>
>
> The Reference Guide does not have any documentation about WAL compression.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18504) Add documentation for WAL compression

2017-08-15 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-18504:
--
  Resolution: Fixed
Hadoop Flags: Reviewed
  Status: Resolved  (was: Patch Available)

Pushed to master. Nice addition [~psomogyi] Thank you.

> Add documentation for WAL compression
> -
>
> Key: HBASE-18504
> URL: https://issues.apache.org/jira/browse/HBASE-18504
> Project: HBase
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.0.0, 2.0.0-alpha-2
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-18504.master.001.patch, 
> HBASE-18504.master.001.patch
>
>
> The Reference Guide does not have any documentation about WAL compression.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18596) A hbase1 cluster should be able to replicate to a hbase2 cluster; verify

2017-08-15 Thread Esteban Gutierrez (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127785#comment-16127785
 ] 

Esteban Gutierrez commented on HBASE-18596:
---

Will work on this.

> A hbase1 cluster should be able to replicate to a hbase2 cluster; verify
> 
>
> Key: HBASE-18596
> URL: https://issues.apache.org/jira/browse/HBASE-18596
> Project: HBase
>  Issue Type: Task
>Reporter: stack
>Assignee: Esteban Gutierrez
>Priority: Blocker
> Fix For: 2.0.0
>
>
> From the mailing list thread "[DISCUSS] hbase-2.0.0 compatibility 
> expectations", [~esteban] asks:
> bq. Should we add additional details around replication as well? for 
> instance, shall we consider a hbase-1.x cluster as a client for a hbase-2.x 
> cluster?
> The latter should be a blocker. Verify it works.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (HBASE-18596) A hbase1 cluster should be able to replicate to a hbase2 cluster; verify

2017-08-15 Thread Esteban Gutierrez (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Esteban Gutierrez reassigned HBASE-18596:
-

Assignee: Esteban Gutierrez

> A hbase1 cluster should be able to replicate to a hbase2 cluster; verify
> 
>
> Key: HBASE-18596
> URL: https://issues.apache.org/jira/browse/HBASE-18596
> Project: HBase
>  Issue Type: Task
>Reporter: stack
>Assignee: Esteban Gutierrez
>Priority: Blocker
> Fix For: 2.0.0
>
>
> From the mailing list thread "[DISCUSS] hbase-2.0.0 compatibility 
> expectations", [~esteban] asks:
> bq. Should we add additional details around replication as well? for 
> instance, shall we consider a hbase-1.x cluster as a client for a hbase-2.x 
> cluster?
> The latter should be a blocker. Verify it works.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


  1   2   3   >