[jira] [Commented] (HBASE-18442) Speed up Memstore chunk pool ByteBuffer allocations
[
https://issues.apache.org/jira/browse/HBASE-18442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136398#comment-16136398
]
ramkrishna.s.vasudevan commented on HBASE-18442:
bq.throw new RuntimeException(e);
I just thought instead of throwing the checked exception then the caller also
needs to be changed - its better we throw a RTE. Anyway this is only during the
startup.
> Speed up Memstore chunk pool ByteBuffer allocations
> ---
>
> Key: HBASE-18442
> URL: https://issues.apache.org/jira/browse/HBASE-18442
> Project: HBase
> Issue Type: Improvement
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-18442_1.patch, HBASE-18442_2.patch,
> HBASE-18442_3.patch
>
>
> Like in HBASE-17738 we can speed up the allocation of memstore chunk pool's
> ByteBuffers. {code}
> 2017-07-24 17:51:09,726 INFO [regionserver/stobdtserver6/10.66.254.41:16020]
> regionserver.ChunkCreator: Allocating MemStoreChunkPool with chunk size 2 MB,
> max count 12288, initial count 12288
> 2017-07-24 17:51:19,642 INFO [regionserver/stobdtserver6/10.66.254.41:16020]
> regionserver.HRegionServer: Serving as stobdtserver6,16020,1500898858958,
> RpcServer on stobdtserver6/10.66.254.41:16020, sessionid=0x15d748a9ccc0002
> {code}
> Allocating 12288 buffers of 2MB size takes around 10 secs.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18442) Speed up Memstore chunk pool ByteBuffer allocations
[
https://issues.apache.org/jira/browse/HBASE-18442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136396#comment-16136396
]
ramkrishna.s.vasudevan commented on HBASE-18442:
Based on the sizes I got around 50% improvement.
For offheap memstore with ~21k ByteBuffers with patch it took 10 secs and
without patch it was taking ~21secs.
> Speed up Memstore chunk pool ByteBuffer allocations
> ---
>
> Key: HBASE-18442
> URL: https://issues.apache.org/jira/browse/HBASE-18442
> Project: HBase
> Issue Type: Improvement
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-18442_1.patch, HBASE-18442_2.patch,
> HBASE-18442_3.patch
>
>
> Like in HBASE-17738 we can speed up the allocation of memstore chunk pool's
> ByteBuffers. {code}
> 2017-07-24 17:51:09,726 INFO [regionserver/stobdtserver6/10.66.254.41:16020]
> regionserver.ChunkCreator: Allocating MemStoreChunkPool with chunk size 2 MB,
> max count 12288, initial count 12288
> 2017-07-24 17:51:19,642 INFO [regionserver/stobdtserver6/10.66.254.41:16020]
> regionserver.HRegionServer: Serving as stobdtserver6,16020,1500898858958,
> RpcServer on stobdtserver6/10.66.254.41:16020, sessionid=0x15d748a9ccc0002
> {code}
> Allocating 12288 buffers of 2MB size takes around 10 secs.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18628) ZKPermissionWatcher blocks all ZK notifications
[
https://issues.apache.org/jira/browse/HBASE-18628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136390#comment-16136390
]
Hadoop QA commented on HBASE-18628:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
35m 41s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 93m 2s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}147m 16s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence |
| | org.apache.hadoop.hbase.client.TestFromClientSide |
| | org.apache.hadoop.hbase.trace.TestHTraceHooks |
| | org.apache.hadoop.hbase.backup.TestRemoteBackup |
| | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries |
| | org.apache.hadoop.hbase.namespace.TestNamespaceAuditor |
| | org.apache.hadoop.hbase.TestHBaseTestingUtility |
| | org.apache.hadoop.hbase.client.TestAsyncNamespaceAdminApi |
| | org.apache.hadoop.hbase.coprocessor.TestCoprocessorMetrics |
| |
org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
|
| | org.apache.hadoop.hbase.wal.TestWALFiltering |
| | org.apache.hadoop.hbase.quotas.TestQuotaStatusRPCs |
| | org.apache.hadoop.hbase.backup.TestFullBackup |
| | org.apache.hadoop.hbase.TestMultiVersions |
| | org.apache.hadoop.hbase.client.TestAsyncNonMetaRegionLocator |
| | org.apache.hadoop.hbase.security.access.TestAccessController2 |
| | org.apache.hadoop.hbase.quotas.TestMasterSpaceQuotaObserver |
| | org.apache.hadoop.hbase.client.TestAsyncTableScanRenewLease |
| | org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream |
| | org.apache.hadoop.hbase.wal.TestWALSplitCompressed |
| | org.apache.hadoop.hbase.constraint.TestConstraint |
| | org.apache.hadoop.hbase.filter.TestFilterWithScanLimits |
| | org.apache.hadoop.hbase.client.TestScannersFromClientSide2 |
| |
[jira] [Commented] (HBASE-18313) [hbase-thirdparty] Produce src jars/tgz
[ https://issues.apache.org/jira/browse/HBASE-18313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136389#comment-16136389 ] Duo Zhang commented on HBASE-18313: --- Good. Wait for your good news sir. > [hbase-thirdparty] Produce src jars/tgz > --- > > Key: HBASE-18313 > URL: https://issues.apache.org/jira/browse/HBASE-18313 > Project: HBase > Issue Type: Bug > Components: hbase-thirdparty >Reporter: stack > > In IDEs when want to dig in on protobuf or guava, need src jars. Currently we > don't generate them. Generate them in next release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18313) [hbase-thirdparty] Produce src jars/tgz
[ https://issues.apache.org/jira/browse/HBASE-18313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136387#comment-16136387 ] stack commented on HBASE-18313: --- Let me do this in next day or so. > [hbase-thirdparty] Produce src jars/tgz > --- > > Key: HBASE-18313 > URL: https://issues.apache.org/jira/browse/HBASE-18313 > Project: HBase > Issue Type: Bug > Components: hbase-thirdparty >Reporter: stack > > In IDEs when want to dig in on protobuf or guava, need src jars. Currently we > don't generate them. Generate them in next release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18313) [hbase-thirdparty] Produce src jars/tgz
[ https://issues.apache.org/jira/browse/HBASE-18313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136369#comment-16136369 ] stack commented on HBASE-18313: --- I tried it. Works for me [~Apache9]. I see sources. I looked at a few. They look good. Want me to make a new release of hbase-thirdparty with sources in it? Could call it 1.1.0 or something? I'd do HBASE-18321 at same time? > [hbase-thirdparty] Produce src jars/tgz > --- > > Key: HBASE-18313 > URL: https://issues.apache.org/jira/browse/HBASE-18313 > Project: HBase > Issue Type: Bug > Components: hbase-thirdparty >Reporter: stack > > In IDEs when want to dig in on protobuf or guava, need src jars. Currently we > don't generate them. Generate them in next release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18630) Prune dependencies; as is branch-2 has duplicates
[ https://issues.apache.org/jira/browse/HBASE-18630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136373#comment-16136373 ] stack commented on HBASE-18630: --- +1 on committing this small fixup? Seems to not break anything. No hurry. > Prune dependencies; as is branch-2 has duplicates > - > > Key: HBASE-18630 > URL: https://issues.apache.org/jira/browse/HBASE-18630 > Project: HBase > Issue Type: Task > Components: dependencies >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18630.master.001.patch > > > Purge duplicate includes and try to prune back our dependencies (Suggestion > by [~elserj] up on the 2.0.0-alpha2 vote). Just looking at my current issue, > we have vestiges we include even though the root justification has passed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18313) [hbase-thirdparty] Produce src jars/tgz
[ https://issues.apache.org/jira/browse/HBASE-18313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136383#comment-16136383 ] Duo Zhang commented on HBASE-18313: --- Maybe 1.0.1 is enough? Make a new minor release after we introduce new shading modules? And for HBASE-18321 it is not a big problem for me, but if you already have a solution then let's also fix it. Thanks. > [hbase-thirdparty] Produce src jars/tgz > --- > > Key: HBASE-18313 > URL: https://issues.apache.org/jira/browse/HBASE-18313 > Project: HBase > Issue Type: Bug > Components: hbase-thirdparty >Reporter: stack > > In IDEs when want to dig in on protobuf or guava, need src jars. Currently we > don't generate them. Generate them in next release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15607) Remove PB references from Admin for 2.0
[ https://issues.apache.org/jira/browse/HBASE-15607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136376#comment-16136376 ] stack commented on HBASE-15607: --- I started the DISCUSS thread for stuff like this but I ran into some good questions; Am thinking of bringing up this issue as subtopic. I was thinking about it and I suppose we could do workarounds. They might work. It would take a bunch of effort. We'd have our pb3.2.x writing pb 2 types. If they haven't been changed internally, it could work. Rather I think we should just say hbase-1.x clients can't administer a hbase-2.x cluster. I was going to try it to see how fail and report back here. Thanks [~ram_krish] > Remove PB references from Admin for 2.0 > --- > > Key: HBASE-15607 > URL: https://issues.apache.org/jira/browse/HBASE-15607 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Blocker > Fix For: 2.0.0, 1.3.0, 2.0.0-alpha-3 > > Attachments: HBASE-15607_1.patch, HBASE-15607_2.patch, > HBASE-15607_3.patch, HBASE-15607_3.patch, HBASE-15607_4.patch, > HBASE-15607_4.patch, HBASE-15607_branch-1.patch, HBASE-15607.patch > > > This is a sub-task for HBASE-15174. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17442) Move most of the replication related classes to hbase-server package
[ https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17442: -- Attachment: HBASE-17442.master.002.patch Retry > Move most of the replication related classes to hbase-server package > > > Key: HBASE-17442 > URL: https://issues.apache.org/jira/browse/HBASE-17442 > Project: HBase > Issue Type: Sub-task > Components: build, Replication >Affects Versions: 2.0.0 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Critical > Fix For: 2.0.0-alpha-3 > > Attachments: 0001-hbase-replication-module.patch, > HBASE-17442.branch-2.001.patch, HBASE-17442.branch-2.001.patch, > HBASE-17442.master.001.patch, HBASE-17442.master.001.patch, > HBASE-17442.master.002.patch, HBASE-17442.master.002.patch, > HBASE-17442.master.002.patch, HBASE-17442.master.002.patch, > HBASE-17442.v1.patch, HBASE-17442.v2.patch, HBASE-17442.v2.patch, > HBASE-17442.v3.patch > > > After the replication requests are routed through master, replication > implementation details didn't need be exposed to client. We should move most > of the replication related classes to hbase-server package. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18630) Prune dependencies; as is branch-2 has duplicates
[
https://issues.apache.org/jira/browse/HBASE-18630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136365#comment-16136365
]
Hadoop QA commented on HBASE-18630:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
24s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
36m 21s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}192m
0s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}254m 29s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18630 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883020/HBASE-18630.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit xml compile |
| uname | Linux e4ae98068a2f 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 23ddf69 |
| Default Java | 1.8.0_144 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8216/testReport/ |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8216/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Prune dependencies; as is branch-2 has duplicates
> -
>
> Key: HBASE-18630
> URL: https://issues.apache.org/jira/browse/HBASE-18630
> Project: HBase
> Issue Type: Task
> Components: dependencies
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18630.master.001.patch
>
>
> Purge duplicate includes and try to prune back our dependencies (Suggestion
> by [~elserj] up on the 2.0.0-alpha2 vote). Just looking at my current issue,
> we have vestiges we include even though the root justification has passed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18313) [hbase-thirdparty] Produce src jars/tgz
[ https://issues.apache.org/jira/browse/HBASE-18313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136360#comment-16136360 ] Duo Zhang commented on HBASE-18313: --- [~stack] Sir I have tried to generate sources.jar for these modules, and it seems worked for me. https://github.com/Apache9/hbase-thirdparty/commit/aa90eb9ab7582b133e2fef7d8294eccc8d934e28 Could you please have a try also? And how do we process the patch for hbase-thirdparty? There is no pre commit check... Thanks. > [hbase-thirdparty] Produce src jars/tgz > --- > > Key: HBASE-18313 > URL: https://issues.apache.org/jira/browse/HBASE-18313 > Project: HBase > Issue Type: Bug > Components: hbase-thirdparty >Reporter: stack > > In IDEs when want to dig in on protobuf or guava, need src jars. Currently we > don't generate them. Generate them in next release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-14351) Procedure V2 Phase 3: Notification Bus
[ https://issues.apache.org/jira/browse/HBASE-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136358#comment-16136358 ] stack edited comment on HBASE-14351 at 8/22/17 6:05 AM: [~mdrob] This is not going to make 2.0.0. Will have to be later. Notification Bus will allow us an alternative to message-passing via ZK. It is incomplete. We'll have to do w/ current mechanisms in meantime (of which we have a few -- smile). was (Author: stack): [~mdrob] This is not going to make 2.0.0. Will have to be later. Notification Bus will allow us an alternative to message-passing via ZK. > Procedure V2 Phase 3: Notification Bus > -- > > Key: HBASE-14351 > URL: https://issues.apache.org/jira/browse/HBASE-14351 > Project: HBase > Issue Type: Task >Reporter: Stephen Yuan Jiang >Assignee: Matteo Bertozzi > > This is the third phase of Procedure V2 (HBASE-12439) feature. Built on top > of state machine from Phase 1 (HBASE-14336), the notification bus is just > an exchange of messages between the multiple machines (e.g. master and > regionservers). The notification bus allows master to send > notifications/procedures to the Region Servers. Two examples are snapshot for > OnePhaseProcedure and ACL update for TwoPhaseProcedure (check HBASE-12439 for > high-level design). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14351) Procedure V2 Phase 3: Notification Bus
[ https://issues.apache.org/jira/browse/HBASE-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136358#comment-16136358 ] stack commented on HBASE-14351: --- [~mdrob] This is not going to make 2.0.0. Will have to be later. Notification Bus will allow us an alternative to message-passing via ZK. > Procedure V2 Phase 3: Notification Bus > -- > > Key: HBASE-14351 > URL: https://issues.apache.org/jira/browse/HBASE-14351 > Project: HBase > Issue Type: Task >Reporter: Stephen Yuan Jiang >Assignee: Matteo Bertozzi > > This is the third phase of Procedure V2 (HBASE-12439) feature. Built on top > of state machine from Phase 1 (HBASE-14336), the notification bus is just > an exchange of messages between the multiple machines (e.g. master and > regionservers). The notification bus allows master to send > notifications/procedures to the Region Servers. Two examples are snapshot for > OnePhaseProcedure and ACL update for TwoPhaseProcedure (check HBASE-12439 for > high-level design). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18287) Remove log warning in PartitionedMobCompactor.java#getFileStatus
[ https://issues.apache.org/jira/browse/HBASE-18287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136356#comment-16136356 ] Jingcheng Du commented on HBASE-18287: -- Thanks [~huaxiang] for the patch. We should not remove the code of catching FileNotFoundException. We will do nothing when we catch the FNFE, but do not remove it. > Remove log warning in PartitionedMobCompactor.java#getFileStatus > - > > Key: HBASE-18287 > URL: https://issues.apache.org/jira/browse/HBASE-18287 > Project: HBase > Issue Type: Bug > Components: mob >Affects Versions: 2.0.0-alpha-1 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Attachments: HBASE-18287.master.001.patch > > > It is confusing as the FileNotFound is expected here. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18127) Enable state to be passed between the region observer coprocessor hook calls
[ https://issues.apache.org/jira/browse/HBASE-18127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136355#comment-16136355 ] Abhishek Singh Chouhan commented on HBASE-18127: Ping [~lhofhansl] [~apurtell] [~stack] for comments :) > Enable state to be passed between the region observer coprocessor hook calls > > > Key: HBASE-18127 > URL: https://issues.apache.org/jira/browse/HBASE-18127 > Project: HBase > Issue Type: New Feature >Reporter: Lars Hofhansl >Assignee: Abhishek Singh Chouhan > Attachments: HBASE-18127.master.001.patch, > HBASE-18127.master.002.patch, HBASE-18127.master.002.patch, > HBASE-18127.master.003.patch > > > Allow regionobserver to optionally skip postPut/postDelete when > postBatchMutate was called. > Right now a RegionObserver can only statically implement one or the other. In > scenarios where we need to work sometimes on the single postPut and > postDelete hooks and sometimes on the batchMutate hooks, there is currently > no place to convey this information to the single hooks. I.e. the work has > been done in the batch, skip the single hooks. > There are various solutions: > 1. Allow some state to be passed _per operation_. > 2. Remove the single hooks and always only call batch hooks (with a default > wrapper for the single hooks). > 3. more? > [~apurtell], what we had discussed a few days back. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18644) Duplicate "compactionQueueLength" metric in Region Server metrics
[
https://issues.apache.org/jira/browse/HBASE-18644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136351#comment-16136351
]
Hudson commented on HBASE-18644:
FAILURE: Integrated in Jenkins build HBase-1.4 #875 (See
[https://builds.apache.org/job/HBase-1.4/875/])
HBASE-18644 Duplicate compactionQueueLength metric in Region Server (apurtell:
rev f6fed318b455e39385c3b6ce49c349ad93b9cf1a)
* (edit)
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java
> Duplicate "compactionQueueLength" metric in Region Server metrics
> -
>
> Key: HBASE-18644
> URL: https://issues.apache.org/jira/browse/HBASE-18644
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 1.3.1
>Reporter: Maddineni Sukumar
>Assignee: Maddineni Sukumar
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0
>
> Attachments: HBASE-18644-branch-1.3.patch
>
>
> Region Server JMX response has duplicate entries for "compactionQueueLength"
> "compactionQueueLength" : 0,
> "smallCompactionQueueLength" : 0,
> "largeCompactionQueueLength" : 0,
> "compactionQueueLength" : 0,
> "flushQueueLength" : 0
> We added "compactionQueueLength" metric twice in
> MetricsRegionServerSourceImpl.java
> {code:title=MetricsRegionServerSourceImpl.java|borderStyle=solid}
> .addGauge(Interns.info(COMPACTION_QUEUE_LENGTH, COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getCompactionQueueSize())
> .addGauge(Interns.info(SMALL_COMPACTION_QUEUE_LENGTH,
> SMALL_COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getSmallCompactionQueueSize())
> .addGauge(Interns.info(LARGE_COMPACTION_QUEUE_LENGTH,
> LARGE_COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getLargeCompactionQueueSize())
> .addGauge(Interns.info(COMPACTION_QUEUE_LENGTH,
> COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getCompactionQueueSize())
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18644) Duplicate "compactionQueueLength" metric in Region Server metrics
[
https://issues.apache.org/jira/browse/HBASE-18644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136349#comment-16136349
]
Hudson commented on HBASE-18644:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3574 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/3574/])
HBASE-18644 Duplicate compactionQueueLength metric in Region Server (apurtell:
rev 23ddf69c00a90673184f803ce4d76266ed0d45c5)
* (edit)
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java
> Duplicate "compactionQueueLength" metric in Region Server metrics
> -
>
> Key: HBASE-18644
> URL: https://issues.apache.org/jira/browse/HBASE-18644
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 1.3.1
>Reporter: Maddineni Sukumar
>Assignee: Maddineni Sukumar
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0
>
> Attachments: HBASE-18644-branch-1.3.patch
>
>
> Region Server JMX response has duplicate entries for "compactionQueueLength"
> "compactionQueueLength" : 0,
> "smallCompactionQueueLength" : 0,
> "largeCompactionQueueLength" : 0,
> "compactionQueueLength" : 0,
> "flushQueueLength" : 0
> We added "compactionQueueLength" metric twice in
> MetricsRegionServerSourceImpl.java
> {code:title=MetricsRegionServerSourceImpl.java|borderStyle=solid}
> .addGauge(Interns.info(COMPACTION_QUEUE_LENGTH, COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getCompactionQueueSize())
> .addGauge(Interns.info(SMALL_COMPACTION_QUEUE_LENGTH,
> SMALL_COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getSmallCompactionQueueSize())
> .addGauge(Interns.info(LARGE_COMPACTION_QUEUE_LENGTH,
> LARGE_COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getLargeCompactionQueueSize())
> .addGauge(Interns.info(COMPACTION_QUEUE_LENGTH,
> COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getCompactionQueueSize())
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18627) Fix TestRegionServerReadRequestMetrics
[ https://issues.apache.org/jira/browse/HBASE-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136347#comment-16136347 ] Hudson commented on HBASE-18627: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3574 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3574/]) HBASE-18627 Fix TestRegionServerReadRequestMetrics (Chia-Ping Tsai) (stack: rev bf343da4a445cd9ed1da953e2b24861a5b869846) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReadRequestMetrics.java > Fix TestRegionServerReadRequestMetrics > -- > > Key: HBASE-18627 > URL: https://issues.apache.org/jira/browse/HBASE-18627 > Project: HBase > Issue Type: Bug > Components: test >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18627.v0.patch, HBASE-18627.v0.patch > > > HBASE-18511 enable no-regions-on-master as default. That feature mess up the > metrics in TestRegionServerReadRequestMetrics. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18103) [AMv2] If Master gives OPEN to another, if original eventually succeeds, Master will kill it
[ https://issues.apache.org/jira/browse/HBASE-18103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136348#comment-16136348 ] Hudson commented on HBASE-18103: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3574 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3574/]) HBASE-18103 [AMv2] Changed master to throw YouAreDeadException when it (stack: rev 5895538a32d6bd2d7153e38304523caf6ea7579c) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/MockMasterServices.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRogueRSAssignment.java > [AMv2] If Master gives OPEN to another, if original eventually succeeds, > Master will kill it > > > Key: HBASE-18103 > URL: https://issues.apache.org/jira/browse/HBASE-18103 > Project: HBase > Issue Type: Sub-task > Components: master, proc-v2 >Reporter: stack >Assignee: Umesh Agashe >Priority: Critical > Fix For: 2.0.0 > > Attachments: hbase-18103.master.001.patch, > hbase-18103.master.001.patch > > > If a RS is slow to open a Region, the Master will give the Region to another > to open it (In this case, was a massive set of edits to process and a load of > StoreFiles to open...). Should the original RS succeed with its open > eventually, on reporting the master the successful open, the Master currently > kills the RS because the region is supposed to be elsewhere. > This is an easy fix. > The RS does not fully open a Region until Master gives it the go so just > close the region if master rejects the open > See '6.1.1 If Master gives Region to another to Open, old RS will be kill > itself on reject by Master; easy fix!' in > https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.qtfojp9774h -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18634) Fix client.TestClientClusterStatus
[
https://issues.apache.org/jira/browse/HBASE-18634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136346#comment-16136346
]
Hudson commented on HBASE-18634:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3574 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/3574/])
HBASE-18634 HBASE-Fix client.TestClientClusterStatus (Chia-Ping Tsai) (stack:
rev 078a6be7d0ccd370016ba351090e21ea0e041e86)
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientClusterStatus.java
> Fix client.TestClientClusterStatus
> --
>
> Key: HBASE-18634
> URL: https://issues.apache.org/jira/browse/HBASE-18634
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0
>
> Attachments: HBASE-18634.v0.patch, HBASE-18634.v0.patch
>
>
> After HBASE-18511, the master doesn't carry any regions by default. Hence,
> The active master doesn't report its load because the report thread is
> sleeping in waitForMasterActive().
> {code}
> protected void waitForMasterActive(){
> boolean tablesOnMaster = LoadBalancer.isTablesOnMaster(conf);
> while (!(tablesOnMaster && activeMaster) && !isStopped() && !isAborted())
> {
> sleeper.sleep();
> }
> }
> {code}
> In conclusion, the ClusterStatue#getServers won't contain the master name.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18615) hbase-rest tests fail in hbase-2.0.0-alpha2
[ https://issues.apache.org/jira/browse/HBASE-18615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18615: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed on branch-2 only. Thanks for reviews [~apurtell] and [~asamir] > hbase-rest tests fail in hbase-2.0.0-alpha2 > --- > > Key: HBASE-18615 > URL: https://issues.apache.org/jira/browse/HBASE-18615 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-alpha-3 > > Attachments: 18615.2.txt, 18615.txt, 18615.v3.txt, > HBASE-18615.branch-2.001.patch, HBASE-18615.branch-2.002.patch > > > Pointed out by Andrew on VOTE mail for hbase-2.0.0-alpha2 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18644) Duplicate "compactionQueueLength" metric in Region Server metrics
[
https://issues.apache.org/jira/browse/HBASE-18644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136319#comment-16136319
]
Hudson commented on HBASE-18644:
FAILURE: Integrated in Jenkins build HBase-1.5 #22 (See
[https://builds.apache.org/job/HBase-1.5/22/])
HBASE-18644 Duplicate compactionQueueLength metric in Region Server (apurtell:
rev 679a4eb8a62e03869e55d54c274645ba24b6a0c3)
* (edit)
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java
> Duplicate "compactionQueueLength" metric in Region Server metrics
> -
>
> Key: HBASE-18644
> URL: https://issues.apache.org/jira/browse/HBASE-18644
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 1.3.1
>Reporter: Maddineni Sukumar
>Assignee: Maddineni Sukumar
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0
>
> Attachments: HBASE-18644-branch-1.3.patch
>
>
> Region Server JMX response has duplicate entries for "compactionQueueLength"
> "compactionQueueLength" : 0,
> "smallCompactionQueueLength" : 0,
> "largeCompactionQueueLength" : 0,
> "compactionQueueLength" : 0,
> "flushQueueLength" : 0
> We added "compactionQueueLength" metric twice in
> MetricsRegionServerSourceImpl.java
> {code:title=MetricsRegionServerSourceImpl.java|borderStyle=solid}
> .addGauge(Interns.info(COMPACTION_QUEUE_LENGTH, COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getCompactionQueueSize())
> .addGauge(Interns.info(SMALL_COMPACTION_QUEUE_LENGTH,
> SMALL_COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getSmallCompactionQueueSize())
> .addGauge(Interns.info(LARGE_COMPACTION_QUEUE_LENGTH,
> LARGE_COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getLargeCompactionQueueSize())
> .addGauge(Interns.info(COMPACTION_QUEUE_LENGTH,
> COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getCompactionQueueSize())
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18103) [AMv2] If Master gives OPEN to another, if original eventually succeeds, Master will kill it
[ https://issues.apache.org/jira/browse/HBASE-18103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136317#comment-16136317 ] Hudson commented on HBASE-18103: FAILURE: Integrated in Jenkins build HBase-2.0 #373 (See [https://builds.apache.org/job/HBase-2.0/373/]) HBASE-18103 [AMv2] Changed master to throw YouAreDeadException when it (stack: rev b059d8602d465e7722fcbf27bc775e1663e699c7) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/MockMasterServices.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRogueRSAssignment.java > [AMv2] If Master gives OPEN to another, if original eventually succeeds, > Master will kill it > > > Key: HBASE-18103 > URL: https://issues.apache.org/jira/browse/HBASE-18103 > Project: HBase > Issue Type: Sub-task > Components: master, proc-v2 >Reporter: stack >Assignee: Umesh Agashe >Priority: Critical > Fix For: 2.0.0 > > Attachments: hbase-18103.master.001.patch, > hbase-18103.master.001.patch > > > If a RS is slow to open a Region, the Master will give the Region to another > to open it (In this case, was a massive set of edits to process and a load of > StoreFiles to open...). Should the original RS succeed with its open > eventually, on reporting the master the successful open, the Master currently > kills the RS because the region is supposed to be elsewhere. > This is an easy fix. > The RS does not fully open a Region until Master gives it the go so just > close the region if master rejects the open > See '6.1.1 If Master gives Region to another to Open, old RS will be kill > itself on reject by Master; easy fix!' in > https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.qtfojp9774h -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18615) hbase-rest tests fail in hbase-2.0.0-alpha2
[ https://issues.apache.org/jira/browse/HBASE-18615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136316#comment-16136316 ] Hudson commented on HBASE-18615: FAILURE: Integrated in Jenkins build HBase-2.0 #373 (See [https://builds.apache.org/job/HBase-2.0/373/]) HBASE-18615 hbase-rest tests fail in hbase-2.0.0-alpha2 (stack: rev 0be04ab4a102430dd9a2259c9d98a1ae18a8693d) * (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/HBaseRESTTestingUtility.java * (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/RESTServer.java Revert "HBASE-18615 hbase-rest tests fail in hbase-2.0.0-alpha2" Pushed (stack: rev 62d2cd0d07794de01f1d7e7757fd8736da32faa1) * (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/RESTServer.java * (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/HBaseRESTTestingUtility.java > hbase-rest tests fail in hbase-2.0.0-alpha2 > --- > > Key: HBASE-18615 > URL: https://issues.apache.org/jira/browse/HBASE-18615 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-alpha-3 > > Attachments: 18615.2.txt, 18615.txt, 18615.v3.txt, > HBASE-18615.branch-2.001.patch, HBASE-18615.branch-2.002.patch > > > Pointed out by Andrew on VOTE mail for hbase-2.0.0-alpha2 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18634) Fix client.TestClientClusterStatus
[
https://issues.apache.org/jira/browse/HBASE-18634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136314#comment-16136314
]
Hudson commented on HBASE-18634:
FAILURE: Integrated in Jenkins build HBase-2.0 #373 (See
[https://builds.apache.org/job/HBase-2.0/373/])
HBASE-18634 HBASE-Fix client.TestClientClusterStatus (Chia-Ping Tsai) (stack:
rev 61b2508f29c051ca4ca33bd180190b1d5af2087a)
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientClusterStatus.java
> Fix client.TestClientClusterStatus
> --
>
> Key: HBASE-18634
> URL: https://issues.apache.org/jira/browse/HBASE-18634
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0
>
> Attachments: HBASE-18634.v0.patch, HBASE-18634.v0.patch
>
>
> After HBASE-18511, the master doesn't carry any regions by default. Hence,
> The active master doesn't report its load because the report thread is
> sleeping in waitForMasterActive().
> {code}
> protected void waitForMasterActive(){
> boolean tablesOnMaster = LoadBalancer.isTablesOnMaster(conf);
> while (!(tablesOnMaster && activeMaster) && !isStopped() && !isAborted())
> {
> sleeper.sleep();
> }
> }
> {code}
> In conclusion, the ClusterStatue#getServers won't contain the master name.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18627) Fix TestRegionServerReadRequestMetrics
[ https://issues.apache.org/jira/browse/HBASE-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136315#comment-16136315 ] Hudson commented on HBASE-18627: FAILURE: Integrated in Jenkins build HBase-2.0 #373 (See [https://builds.apache.org/job/HBase-2.0/373/]) HBASE-18627 Fix TestRegionServerReadRequestMetrics (Chia-Ping Tsai) (stack: rev 55ba5d070754a718709e482470f1d0aafca3bb7d) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReadRequestMetrics.java > Fix TestRegionServerReadRequestMetrics > -- > > Key: HBASE-18627 > URL: https://issues.apache.org/jira/browse/HBASE-18627 > Project: HBase > Issue Type: Bug > Components: test >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18627.v0.patch, HBASE-18627.v0.patch > > > HBASE-18511 enable no-regions-on-master as default. That feature mess up the > metrics in TestRegionServerReadRequestMetrics. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18644) Duplicate "compactionQueueLength" metric in Region Server metrics
[
https://issues.apache.org/jira/browse/HBASE-18644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136318#comment-16136318
]
Hudson commented on HBASE-18644:
FAILURE: Integrated in Jenkins build HBase-2.0 #373 (See
[https://builds.apache.org/job/HBase-2.0/373/])
HBASE-18644 Duplicate compactionQueueLength metric in Region Server (apurtell:
rev 27120e2d03ac04ac458a1c5fcf9053479727)
* (edit)
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java
> Duplicate "compactionQueueLength" metric in Region Server metrics
> -
>
> Key: HBASE-18644
> URL: https://issues.apache.org/jira/browse/HBASE-18644
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 1.3.1
>Reporter: Maddineni Sukumar
>Assignee: Maddineni Sukumar
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0
>
> Attachments: HBASE-18644-branch-1.3.patch
>
>
> Region Server JMX response has duplicate entries for "compactionQueueLength"
> "compactionQueueLength" : 0,
> "smallCompactionQueueLength" : 0,
> "largeCompactionQueueLength" : 0,
> "compactionQueueLength" : 0,
> "flushQueueLength" : 0
> We added "compactionQueueLength" metric twice in
> MetricsRegionServerSourceImpl.java
> {code:title=MetricsRegionServerSourceImpl.java|borderStyle=solid}
> .addGauge(Interns.info(COMPACTION_QUEUE_LENGTH, COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getCompactionQueueSize())
> .addGauge(Interns.info(SMALL_COMPACTION_QUEUE_LENGTH,
> SMALL_COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getSmallCompactionQueueSize())
> .addGauge(Interns.info(LARGE_COMPACTION_QUEUE_LENGTH,
> LARGE_COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getLargeCompactionQueueSize())
> .addGauge(Interns.info(COMPACTION_QUEUE_LENGTH,
> COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getCompactionQueueSize())
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18650) HBase replication Master-Master model issue
[ https://issues.apache.org/jira/browse/HBASE-18650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cuizhaohua updated HBASE-18650: --- Description: When I use HBase replication with Master-Master model, install like below: 1> with cluster 1 I create table "repliTest", and put some data on it . 2> after about 6 month, I have cluster 2 ,and install master-master model with two cluster. 3> I put cluster 1 some data and It replication to cluster 2, it's correct. 4> I put cluster 2 some data and it replication to cluster 1, It's correct also. 5> The issue is : when I run command "hbase org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication clusterID repliTest "on each cluster. the result is different : on cluster 1 the result is org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication$Verifier$Counters BADROWS=33 GOODROWS=20 ONLY_IN_PEER_TABLE_ROWS=4 ONLY_IN_SOURCE_TABLE_ROWS=29 on cluster 2 the result is: org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication$Verifier$Counters BADROWS=32 GOODROWS=20 ONLY_IN_PEER_TABLE_ROWS=28 ONLY_IN_SOURCE_TABLE_ROWS=4 It means one record is lost on cluster 2 verifierreplication . I check the table and get the recode is one recode I have put it 6 month ago. I delete this record like this: hbase(main):017:0> delete 'repliTest','3','score:english' and after that, when I run hbase verifyreplication is also correct on every cluster. environment : HBase 1.16 hdfs 2.7.1 ps: I am not good at english ,sorry about that. was: When I use HBase replication with Master-Master model, install like below: 1> with cluster 1 I create table "repliTest", and put some data on it . 2> after about 6 month, I have cluster 2 ,and install master-master model with two cluster. 3> I put cluster 1 some data and It replication to cluster 2, it's correct. 4> I put cluster 2 some data and it replication to cluster 1, It's correct also. 5> The issue is : when I run command "hbase org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication clusterID repliTest "on each cluster. the result is different : on cluster 1 the result is org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication$Verifier$Counters BADROWS=33 GOODROWS=20 ONLY_IN_PEER_TABLE_ROWS=4 ONLY_IN_SOURCE_TABLE_ROWS=29 on cluster 2 the result is: org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication$Verifier$Counters BADROWS=32 GOODROWS=20 ONLY_IN_PEER_TABLE_ROWS=28 ONLY_IN_SOURCE_TABLE_ROWS=4 It means one record is lost on cluster 2 verifierreplication . I check the table and get the recode is one recode I have put it 6 month ago. I delete this record like this: hbase(main):017:0> delete 'repliTest','3','score:english' and after that, when I run hbase verifyreplication is also correct on evey cluster. environment : HBase 1.16 hdfs 2.7.1 ps: I am not good at english ,sorry about that. > HBase replication Master-Master model issue > - > > Key: HBASE-18650 > URL: https://issues.apache.org/jira/browse/HBASE-18650 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 1.1.6 >Reporter: cuizhaohua >Priority: Minor > > When I use HBase replication with Master-Master model, install like below: > 1> with cluster 1 I create table "repliTest", and put some data on it . > 2> after about 6 month, I have cluster 2 ,and install master-master model > with two cluster. > 3> I put cluster 1 some data and It replication to cluster 2, it's correct. > 4> I put cluster 2 some data and it replication to cluster 1, It's correct > also. > 5> The issue is : when I run command > "hbase org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication > clusterID repliTest "on each cluster. > the result is different : > on cluster 1 the result is > > org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication$Verifier$Counters > BADROWS=33 > GOODROWS=20 > ONLY_IN_PEER_TABLE_ROWS=4 > ONLY_IN_SOURCE_TABLE_ROWS=29 > on cluster 2 the result is: > > org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication$Verifier$Counters > BADROWS=32 > GOODROWS=20 > ONLY_IN_PEER_TABLE_ROWS=28 > ONLY_IN_SOURCE_TABLE_ROWS=4 > It means one record is lost on cluster 2 verifierreplication . I check the > table and get the recode is one recode I have put it 6
[jira] [Commented] (HBASE-18615) hbase-rest tests fail in hbase-2.0.0-alpha2
[ https://issues.apache.org/jira/browse/HBASE-18615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136310#comment-16136310 ] stack commented on HBASE-18615: --- Thanks [~asamir] Yeah, lets try it. > hbase-rest tests fail in hbase-2.0.0-alpha2 > --- > > Key: HBASE-18615 > URL: https://issues.apache.org/jira/browse/HBASE-18615 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-alpha-3 > > Attachments: 18615.2.txt, 18615.txt, 18615.v3.txt, > HBASE-18615.branch-2.001.patch, HBASE-18615.branch-2.002.patch > > > Pointed out by Andrew on VOTE mail for hbase-2.0.0-alpha2 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18650) HBase replication Master-Master model issue
cuizhaohua created HBASE-18650: -- Summary: HBase replication Master-Master model issue Key: HBASE-18650 URL: https://issues.apache.org/jira/browse/HBASE-18650 Project: HBase Issue Type: Bug Components: Replication Affects Versions: 1.1.6 Reporter: cuizhaohua Priority: Minor When I use HBase replication with Master-Master model, install like below: 1> with cluster 1 I create table "repliTest", and put some data on it . 2> after about 6 month, I have cluster 2 ,and install master-master model with two cluster. 3> I put cluster 1 some data and It replication to cluster 2, it's correct. 4> I put cluster 2 some data and it replication to cluster 1, It's correct also. 5> The issue is : when I run command "hbase org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication clusterID repliTest "on each cluster. the result is different : on cluster 1 the result is org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication$Verifier$Counters BADROWS=33 GOODROWS=20 ONLY_IN_PEER_TABLE_ROWS=4 ONLY_IN_SOURCE_TABLE_ROWS=29 on cluster 2 the result is: org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication$Verifier$Counters BADROWS=32 GOODROWS=20 ONLY_IN_PEER_TABLE_ROWS=28 ONLY_IN_SOURCE_TABLE_ROWS=4 It means one record is lost on cluster 2 verifierreplication . I check the table and get the recode is one recode I have put it 6 month ago. I delete this record like this: hbase(main):017:0> delete 'repliTest','3','score:english' and after that, when I run hbase verifyreplication is also correct on evey cluster. environment : HBase 1.16 hdfs 2.7.1 ps: I am not good at english ,sorry about that. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18615) hbase-rest tests fail in hbase-2.0.0-alpha2
[ https://issues.apache.org/jira/browse/HBASE-18615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136303#comment-16136303 ] Samir Ahmic commented on HBASE-18615: - +1 lgtm. > hbase-rest tests fail in hbase-2.0.0-alpha2 > --- > > Key: HBASE-18615 > URL: https://issues.apache.org/jira/browse/HBASE-18615 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-alpha-3 > > Attachments: 18615.2.txt, 18615.txt, 18615.v3.txt, > HBASE-18615.branch-2.001.patch, HBASE-18615.branch-2.002.patch > > > Pointed out by Andrew on VOTE mail for hbase-2.0.0-alpha2 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18630) Prune dependencies; as is branch-2 has duplicates
[ https://issues.apache.org/jira/browse/HBASE-18630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18630: -- Priority: Major (was: Blocker) > Prune dependencies; as is branch-2 has duplicates > - > > Key: HBASE-18630 > URL: https://issues.apache.org/jira/browse/HBASE-18630 > Project: HBase > Issue Type: Task > Components: dependencies >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18630.master.001.patch > > > Purge duplicate includes and try to prune back our dependencies (Suggestion > by [~elserj] up on the 2.0.0-alpha2 vote). Just looking at my current issue, > we have vestiges we include even though the root justification has passed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18448) Added support for refreshing HFiles through API and shell
[
https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136293#comment-16136293
]
Hadoop QA commented on HBASE-18448:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
31s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
26s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
21s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
19s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
7s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
19s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
21s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
31s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
55s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
7s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
46s{color} | {color:green} hbase-server-jdk1.8.0_144 with JDK v1.8.0_144
generated 0 new + 5 unchanged - 5 fixed = 5 total (was 10) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
19s{color} | {color:green} hbase-examples in the patch passed with JDK
v1.8.0_144. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
45s{color} | {color:green} hbase-server-jdk1.7.0_131 with JDK v1.7.0_131
generated 0 new + 5 unchanged - 5 fixed = 5 total (was 10) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
20s{color} | {color:green} hbase-examples in the patch passed with JDK
v1.7.0_131. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
20m 3s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m
20s{color} | {color:red} Patch generated 4 new protoc errors in hbase-server.
{color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m
18s{color} | {color:red} Patch generated 4 new protoc errors in hbase-examples.
{color} |
| {co
[jira] [Updated] (HBASE-18446) Mark StoreFileScanner as IA.Private
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18446: -- Fix Version/s: (was: 2.0.0) > Mark StoreFileScanner as IA.Private > --- > > Key: HBASE-18446 > URL: https://issues.apache.org/jira/browse/HBASE-18446 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Priority: Critical > Fix For: 2.0.0-alpha-3 > > > Do not see any reason why it is marked as IA.LimitedPrivate. It is not > referenced in any CPs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18501) Use TableDescriptor and ColumnFamilyDescriptor as far as possible
[ https://issues.apache.org/jira/browse/HBASE-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18501: -- Fix Version/s: (was: 2.0.0) 2.0.0-alpha-3 > Use TableDescriptor and ColumnFamilyDescriptor as far as possible > - > > Key: HBASE-18501 > URL: https://issues.apache.org/jira/browse/HBASE-18501 > Project: HBase > Issue Type: Umbrella >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Critical > Fix For: 2.0.0-alpha-3 > > > We need to do some cleanup for the *public* class as much as possible. > Otherwise, the HTD and HCD may linger in the code base for a long time. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18446) Mark StoreFileScanner as IA.Private
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18446: -- Fix Version/s: 2.0.0-alpha-3 > Mark StoreFileScanner as IA.Private > --- > > Key: HBASE-18446 > URL: https://issues.apache.org/jira/browse/HBASE-18446 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Priority: Critical > Fix For: 2.0.0, 2.0.0-alpha-3 > > > Do not see any reason why it is marked as IA.LimitedPrivate. It is not > referenced in any CPs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18649) Deprecate KV Usage in MR to move to Cells in 3.0
[ https://issues.apache.org/jira/browse/HBASE-18649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-18649: --- Fix Version/s: 2.1.0 2.0.0 > Deprecate KV Usage in MR to move to Cells in 3.0 > > > Key: HBASE-18649 > URL: https://issues.apache.org/jira/browse/HBASE-18649 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Affects Versions: 2.0.0-alpha-2 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 3.0.0, 2.1.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18649) Deprecate KV Usage in MR to move to Cells in 3.0
ramkrishna.s.vasudevan created HBASE-18649: -- Summary: Deprecate KV Usage in MR to move to Cells in 3.0 Key: HBASE-18649 URL: https://issues.apache.org/jira/browse/HBASE-18649 Project: HBase Issue Type: Improvement Components: mapreduce Affects Versions: 2.0.0-alpha-2 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18647) Parameter cacheBlocks does not take effect in REST API for scan
[
https://issues.apache.org/jira/browse/HBASE-18647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136285#comment-16136285
]
Guangxu Cheng commented on HBASE-18647:
---
bq.Why is the above removed ?
uriInfo and contentType are not used in getScanResource().They are redundant
,so I removed them.
bq.Where does the removed code in getProtobuf() go ?
getProtobuf() get results from the variable results(ResultScanner) of the class
TableScanResource. These QueryParam for scan are not used. so I removed them
too.
> Parameter cacheBlocks does not take effect in REST API for scan
> ---
>
> Key: HBASE-18647
> URL: https://issues.apache.org/jira/browse/HBASE-18647
> Project: HBase
> Issue Type: Bug
> Components: REST
>Affects Versions: 2.0.0, 3.0.0, 1.4.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18647.patch
>
>
> Assign the parameter SCAN_BATCH_SIZE to the variable cacheBlocks incorrectly.
> And cacheBlocks has never been used.
> {code:title=TableResource.java|borderStyle=solid}
> @Path("{scanspec: .*[*]$}")
> public TableScanResource getScanResource(
> final @PathParam("scanspec") String scanSpec,
> @DefaultValue(Integer.MAX_VALUE + "")
> @QueryParam(Constants.SCAN_LIMIT) int userRequestedLimit,
> @DefaultValue("") @QueryParam(Constants.SCAN_START_ROW) String startRow,
> @DefaultValue("") @QueryParam(Constants.SCAN_END_ROW) String endRow,
> @DefaultValue("") @QueryParam(Constants.SCAN_COLUMN) List
> column,
> @DefaultValue("1") @QueryParam(Constants.SCAN_MAX_VERSIONS) int
> maxVersions,
> @DefaultValue("-1") @QueryParam(Constants.SCAN_BATCH_SIZE) int
> batchSize,
> @DefaultValue("0") @QueryParam(Constants.SCAN_START_TIME) long
> startTime,
> @DefaultValue(Long.MAX_VALUE + "") @QueryParam(Constants.SCAN_END_TIME)
> long endTime,
> @DefaultValue("true") @QueryParam(Constants.SCAN_BATCH_SIZE) boolean
> cacheBlocks,
> @DefaultValue("false") @QueryParam(Constants.SCAN_REVERSED) boolean
> reversed,
> @DefaultValue("") @QueryParam(Constants.SCAN_FILTER) String
> paramFilter) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-15607) Remove PB references from Admin for 2.0
[ https://issues.apache.org/jira/browse/HBASE-15607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-15607: -- Fix Version/s: 2.0.0-alpha-3 > Remove PB references from Admin for 2.0 > --- > > Key: HBASE-15607 > URL: https://issues.apache.org/jira/browse/HBASE-15607 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Blocker > Fix For: 2.0.0, 1.3.0, 2.0.0-alpha-3 > > Attachments: HBASE-15607_1.patch, HBASE-15607_2.patch, > HBASE-15607_3.patch, HBASE-15607_3.patch, HBASE-15607_4.patch, > HBASE-15607_4.patch, HBASE-15607_branch-1.patch, HBASE-15607.patch > > > This is a sub-task for HBASE-15174. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18645) Loads of tests timing out....
[ https://issues.apache.org/jira/browse/HBASE-18645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18645: -- Attachment: HBASE-18645.master.001.patch Try again. See if I get another clean run. > Loads of tests timing out > - > > Key: HBASE-18645 > URL: https://issues.apache.org/jira/browse/HBASE-18645 > Project: HBase > Issue Type: Bug >Reporter: stack > Attachments: HBASE-18645.master.001.patch, > HBASE-18645.master.001.patch > > > Whats up? Why are tests mostly timing out? When did it start? I can't seem to > make it happen locally so tough doing a bisect. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18645) Loads of tests timing out....
[
https://issues.apache.org/jira/browse/HBASE-18645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136261#comment-16136261
]
Hadoop QA commented on HBASE-18645:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
27s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
40s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
18s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
25s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
49m 9s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
29s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}203m
37s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}290m 14s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.13.1 Server=1.13.1 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18645 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883001/HBASE-18645.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 4685009acee4 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7
11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / bf343da |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8212/testReport/ |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8212/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Loads of tests timin
[jira] [Commented] (HBASE-18233) We shouldn't wait for readlock in doMiniBatchMutation in case of deadlock
[ https://issues.apache.org/jira/browse/HBASE-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136255#comment-16136255 ] stack commented on HBASE-18233: --- What [~carp84] says. I tried to cherry-pick this forward but fails at first hurdle, 1.3. And for the record, the affirmation from user has evaporated. They now think it was a change in their client app that was more responsible for speedup. I think this the way to go. User said it made things better if perhaps not as good as old mechanism. Lets get it in. Hopefully next complaint is more reproducible or works closer to upstream. Thanks. > We shouldn't wait for readlock in doMiniBatchMutation in case of deadlock > - > > Key: HBASE-18233 > URL: https://issues.apache.org/jira/browse/HBASE-18233 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.7 >Reporter: Allan Yang >Assignee: Allan Yang >Priority: Blocker > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.2.7 > > Attachments: HBASE-18233-branch-1.2.patch, > HBASE-18233-branch-1.2.v2.patch, HBASE-18233-branch-1.2.v3.patch, > HBASE-18233-branch-1.2.v4.patch > > > Please refer to the discuss in HBASE-18144 > https://issues.apache.org/jira/browse/HBASE-18144?focusedCommentId=16051701&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16051701 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18648) Update release checksum generation instructions
[
https://issues.apache.org/jira/browse/HBASE-18648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-18648:
-
Fix Version/s: 1.1.13
1.2.7
1.5.0
1.3.2
1.4.0
3.0.0
2.0.0
Adding some optimistic fix-for assignments.
> Update release checksum generation instructions
> ---
>
> Key: HBASE-18648
> URL: https://issues.apache.org/jira/browse/HBASE-18648
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Nick Dimiduk
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13
>
>
> [Apache policy on release
> checksums|http://www.apache.org/dev/release-distribution#sigs-and-sums] has
> been updated. Adapt our existing documentation and {{make_rc.sh}} script to
> conform to the new guidelines.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18647) Parameter cacheBlocks does not take effect in REST API for scan
[
https://issues.apache.org/jira/browse/HBASE-18647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136248#comment-16136248
]
Ted Yu commented on HBASE-18647:
{code}
124 final @Context UriInfo uriInfo,
{code}
Why is the above removed ?
Where does the removed code in getProtobuf() go ?
> Parameter cacheBlocks does not take effect in REST API for scan
> ---
>
> Key: HBASE-18647
> URL: https://issues.apache.org/jira/browse/HBASE-18647
> Project: HBase
> Issue Type: Bug
> Components: REST
>Affects Versions: 2.0.0, 3.0.0, 1.4.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18647.patch
>
>
> Assign the parameter SCAN_BATCH_SIZE to the variable cacheBlocks incorrectly.
> And cacheBlocks has never been used.
> {code:title=TableResource.java|borderStyle=solid}
> @Path("{scanspec: .*[*]$}")
> public TableScanResource getScanResource(
> final @PathParam("scanspec") String scanSpec,
> @DefaultValue(Integer.MAX_VALUE + "")
> @QueryParam(Constants.SCAN_LIMIT) int userRequestedLimit,
> @DefaultValue("") @QueryParam(Constants.SCAN_START_ROW) String startRow,
> @DefaultValue("") @QueryParam(Constants.SCAN_END_ROW) String endRow,
> @DefaultValue("") @QueryParam(Constants.SCAN_COLUMN) List
> column,
> @DefaultValue("1") @QueryParam(Constants.SCAN_MAX_VERSIONS) int
> maxVersions,
> @DefaultValue("-1") @QueryParam(Constants.SCAN_BATCH_SIZE) int
> batchSize,
> @DefaultValue("0") @QueryParam(Constants.SCAN_START_TIME) long
> startTime,
> @DefaultValue(Long.MAX_VALUE + "") @QueryParam(Constants.SCAN_END_TIME)
> long endTime,
> @DefaultValue("true") @QueryParam(Constants.SCAN_BATCH_SIZE) boolean
> cacheBlocks,
> @DefaultValue("false") @QueryParam(Constants.SCAN_REVERSED) boolean
> reversed,
> @DefaultValue("") @QueryParam(Constants.SCAN_FILTER) String
> paramFilter) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-18648) Update release checksum generation instructions
Nick Dimiduk created HBASE-18648:
Summary: Update release checksum generation instructions
Key: HBASE-18648
URL: https://issues.apache.org/jira/browse/HBASE-18648
Project: HBase
Issue Type: Task
Components: build
Reporter: Nick Dimiduk
Priority: Minor
[Apache policy on release
checksums|http://www.apache.org/dev/release-distribution#sigs-and-sums] has
been updated. Adapt our existing documentation and {{make_rc.sh}} script to
conform to the new guidelines.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18628) ZKPermissionWatcher blocks all ZK notifications
[
https://issues.apache.org/jira/browse/HBASE-18628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-18628:
--
Attachment: HBASE-18628.v5.patch
Retry to see if failures related.
> ZKPermissionWatcher blocks all ZK notifications
> ---
>
> Key: HBASE-18628
> URL: https://issues.apache.org/jira/browse/HBASE-18628
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18628.branch-1.v5.patch, HBASE-18628.patch,
> HBASE-18628.v2.patch, HBASE-18628.v3.patch, HBASE-18628.v4.patch,
> HBASE-18628.v5.patch, HBASE-18628.v5.patch, jstack
>
>
> Buckle up folks, we're going for a ride here. I've seeing this on a branch-2
> based build, but I think the problem will affect branch-1 as well. I'm not
> able to easily reproduce the issue, but it will usually come up within an
> hour on a given cluster that I have, at which point the problem persists
> until an RS restart. I've been seeing the problem and paying attention for
> maybe two months, but I suspect it's been happening much longer than that.
> h3. Problem
> When running in a secure cluster, sometimes the ZK EventThread will get stuck
> on a permissions update and not be able to process new notifications. This
> happens to also block flush and snapshot, which is how we found it.
> h3. Analysis
> The main smoking gun is seeing this in repeated jstacks:
> {noformat}
> "main-EventThread" #43 daemon prio=5 os_prio=0 tid=0x7f0b92644000
> nid=0x6e69 waiting on condition [0x7f0b6730f000]
>java.lang.Thread.State: TIMED_WAITING (sleeping)
> at java.lang.Thread.sleep(Native Method)
> at
> org.apache.hadoop.hbase.security.access.ZKPermissionWatcher.nodeChildrenChanged(ZKPermissionWatcher.java:191)
> at
> org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.process(ZooKeeperWatcher.java:503)
> at
> org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:522)
> at
> org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:498)
> {noformat}
> That sleep is a 20ms sleep in an {{AtomicReference.compareAndSet}} loop - but
> it never gets past the condition.
> {code}
> while (!nodes.compareAndSet(null, nodeList)) {
> try {
> Thread.sleep(20);
> } catch (InterruptedException e) {
> LOG.warn("Interrupted while setting node list", e);
> Thread.currentThread().interrupt();
> }
> }
> {code}
> The warning never shows up in the logs, it just keeps looping and looping.
> The last relevant line from the watcher in logs is:
> {noformat}
> 2017-08-17 21:25:12,379 DEBUG
> org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher:
> regionserver:22101-0x15df38884c80024, quorum=zk1:2181,zk2:2181,zk3:2181,
> baseZNode=/hbase Received ZooKeeper Event, type=NodeChildrenChanged,
> state=SyncConnected, path=/hbase/acl
> {noformat}
> Which makes sense, because the code snippet is from permission watcher's
> {{nodeChildrenChanged}} handler.
> The separate thread introduced in HBASE-14370 is present, but not doing
> anything. And this event hasn't gotten to the part where it splits off into a
> thread:
> {noformat}
> "zk-permission-watcher4-thread-1" #160 daemon prio=5 os_prio=0
> tid=0x01750800 nid=0x6fd9 waiting on condition [0x7f0b5dce5000]
>java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for <0x0007436ecea0> (a
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
> at
> java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
> at
> java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> h3. Solutions
> There's a few approaches we can take to fix this, I think they are all
> complimentary. It might be useful to file subtasks or new issues for some of
> the solutions if they are longer term.
> # Move flush and snapshot to ProcedureV2. This makes my proximate problem go
> away, but it's only relevant to branch-2 and master, and doesn't fix anything
> on branch-1. Also, Permissions updates would still get stuck, preventing
> future permissions upd
[jira] [Commented] (HBASE-16615) Fix flaky TestScannerHeartbeatMessages
[ https://issues.apache.org/jira/browse/HBASE-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136241#comment-16136241 ] Hudson commented on HBASE-16615: SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #259 (See [https://builds.apache.org/job/HBase-1.3-JDK8/259/]) HBASE-16615 Fix flaky TestScannerHeartbeatMessages (Duo Zhang) (stack: rev 65fda491fd64bd096944e42e182639049d558bb0) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScannerHeartbeatMessages.java > Fix flaky TestScannerHeartbeatMessages > -- > > Key: HBASE-16615 > URL: https://issues.apache.org/jira/browse/HBASE-16615 > Project: HBase > Issue Type: Bug > Components: Client, Scanners >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0, 1.4.0, 1.3.2 > > Attachments: HBASE-16615.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18267) The result from the postAppend is ignored
[
https://issues.apache.org/jira/browse/HBASE-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136240#comment-16136240
]
Hudson commented on HBASE-18267:
SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #259 (See
[https://builds.apache.org/job/HBase-1.3-JDK8/259/])
Revert "HBASE-18267 The result from the postAppend is ignored" It breaks
(chia7712: rev 6e5661c1febf30667467e42a542cddd0161aa305)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* (delete)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResultFromCoprocessor.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
> The result from the postAppend is ignored
> -
>
> Key: HBASE-18267
> URL: https://issues.apache.org/jira/browse/HBASE-18267
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
>Affects Versions: 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18267.branch-1.2.v0.patch,
> HBASE-18267.branch-1.3.v0.patch, HBASE-18267.branch-1.v0.patch,
> HBASE-18267.v0.patch, HBASE-18267.v1.patch
>
>
> {code:title=RegionCoprocessorHost.java|borderStyle=solid}
> /**
>* @param append Append object
>* @param result the result returned by the append
>* @throws IOException if an error occurred on the coprocessor
>*/
> public void postAppend(final Append append, final Result result) throws
> IOException {
> execOperation(coprocessors.isEmpty() ? null : new RegionOperation() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> oserver.postAppend(ctx, append, result);
> }
> });
> }
> /**
>* @param increment increment object
>* @param result the result returned by postIncrement
>* @throws IOException if an error occurred on the coprocessor
>*/
> public Result postIncrement(final Increment increment, Result result)
> throws IOException {
> return execOperationWithResult(result,
> coprocessors.isEmpty() ? null : new
> RegionOperationWithResult() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> setResult(oserver.postIncrement(ctx, increment, getResult()));
> }
> });
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
[
https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136238#comment-16136238
]
Hadoop QA commented on HBASE-18640:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
22s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 107 new or modified
test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
37s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 2m
7s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
0s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 42s{color}
| {color:red} hbase-server generated 1 new + 6 unchanged - 0 fixed = 7 total
(was 6) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 3m 18s{color}
| {color:red} root generated 1 new + 32 unchanged - 0 fixed = 33 total (was 32)
{color} |
| {color:green}+1{color} | {color:green} scalac {color} | {color:green} 6m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
16s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 130 line(s) that end in whitespace. Use
git apply --whitespace=fix <>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
8s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
32m 48s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
10s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
27s{color} | {color:red} hbase-server generated 1 new + 0 unchanged - 0 fixed =
1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 2m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
39s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
20s{color} | {color:green} hbase-mapreduce-util in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}109m
29s{color} | {color:green} hbase-server in the patch pa
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136235#comment-16136235
]
stack commented on HBASE-17614:
---
I downloaded the patch and tried running the tests locally to see if it was
just our infra. This is what I got when I tried to run them:
{code}
---
T E S T S
---
Running org.apache.hadoop.hbase.backup.TestBackupDeleteRestore
Running org.apache.hadoop.hbase.backup.TestBackupSystemTable
Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.485 sec -
in org.apache.hadoop.hbase.backup.TestBackupSystemTable
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 41.663 sec - in
org.apache.hadoop.hbase.backup.TestBackupDeleteRestore
Running org.apache.hadoop.hbase.backup.TestHFileArchiving
Tests run: 5, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 20.586 sec <<<
FAILURE! - in org.apache.hadoop.hbase.backup.TestHFileArchiving
testDeleteRegionWithNoStoreFiles(org.apache.hadoop.hbase.backup.TestHFileArchiving)
Time elapsed: 0.06 sec <<< ERROR!
org.apache.hadoop.hbase.DoNotRetryIOException:
org.apache.hadoop.hbase.DoNotRetryIOException: MEMSTORE_FLUSHSIZE for table
descriptor or "hbase.hregion.memstore.flush.size" (25000) is too small, which
might cause very frequent flushing. Set hbase.table.sanity.checks to false at
conf or table descriptor if you want to bypass sanity checks
at
org.apache.hadoop.hbase.master.HMaster.warnOrThrowExceptionForFailure(HMaster.java:1970)
at
org.apache.hadoop.hbase.master.HMaster.sanityCheckTableDescriptor(HMaster.java:1816)
at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:1725)
at
org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:446)
at
org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:278)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:258)
at
org.apache.hadoop.hbase.backup.TestHFileArchiving.testDeleteRegionWithNoStoreFiles(TestHFileArchiving.java:180)
Caused by: org.apache.hadoop.hbase.ipc.RemoteWithExtrasException:
org.apache.hadoop.hbase.DoNotRetryIOException: MEMSTORE_FLUSHSIZE for table
descriptor or "hbase.hregion.memstore.flush.size" (25000) is too small, which
might cause very frequent flushing. Set hbase.table.sanity.checks to false at
conf or table descriptor if you want to bypass sanity checks
at
org.apache.hadoop.hbase.master.HMaster.warnOrThrowExceptionForFailure(HMaster.java:1970)
at
org.apache.hadoop.hbase.master.HMaster.sanityCheckTableDescriptor(HMaster.java:1816)
at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:1725)
at
org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:446)
at
org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:278)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:258)
testRemovesRegionDirOnArchive(org.apache.hadoop.hbase.backup.TestHFileArchiving)
Time elapsed: 0.007 sec <<< ERROR!
org.apache.hadoop.hbase.DoNotRetryIOException:
org.apache.hadoop.hbase.DoNotRetryIOException: MEMSTORE_FLUSHSIZE for table
descriptor or "hbase.hregion.memstore.flush.size" (25000) is too small, which
might cause very frequent flushing. Set hbase.table.sanity.checks to false at
conf or table descriptor if you want to bypass sanity checks
at
org.apache.hadoop.hbase.master.HMaster.warnOrThrowExceptionForFailure(HMaster.java:1970)
at
org.apache.hadoop.hbase.master.HMaster.sanityCheckTableDescriptor(HMaster.java:1816)
at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:1725)
at
org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:446)
at
org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:278)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecut
[jira] [Updated] (HBASE-18647) Parameter cacheBlocks does not take effect in REST API for scan
[
https://issues.apache.org/jira/browse/HBASE-18647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guangxu Cheng updated HBASE-18647:
--
Attachment: HBASE-18647.patch
> Parameter cacheBlocks does not take effect in REST API for scan
> ---
>
> Key: HBASE-18647
> URL: https://issues.apache.org/jira/browse/HBASE-18647
> Project: HBase
> Issue Type: Bug
> Components: REST
>Affects Versions: 2.0.0, 3.0.0, 1.4.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18647.patch
>
>
> Assign the parameter SCAN_BATCH_SIZE to the variable cacheBlocks incorrectly.
> And cacheBlocks has never been used.
> {code:title=TableResource.java|borderStyle=solid}
> @Path("{scanspec: .*[*]$}")
> public TableScanResource getScanResource(
> final @PathParam("scanspec") String scanSpec,
> @DefaultValue(Integer.MAX_VALUE + "")
> @QueryParam(Constants.SCAN_LIMIT) int userRequestedLimit,
> @DefaultValue("") @QueryParam(Constants.SCAN_START_ROW) String startRow,
> @DefaultValue("") @QueryParam(Constants.SCAN_END_ROW) String endRow,
> @DefaultValue("") @QueryParam(Constants.SCAN_COLUMN) List
> column,
> @DefaultValue("1") @QueryParam(Constants.SCAN_MAX_VERSIONS) int
> maxVersions,
> @DefaultValue("-1") @QueryParam(Constants.SCAN_BATCH_SIZE) int
> batchSize,
> @DefaultValue("0") @QueryParam(Constants.SCAN_START_TIME) long
> startTime,
> @DefaultValue(Long.MAX_VALUE + "") @QueryParam(Constants.SCAN_END_TIME)
> long endTime,
> @DefaultValue("true") @QueryParam(Constants.SCAN_BATCH_SIZE) boolean
> cacheBlocks,
> @DefaultValue("false") @QueryParam(Constants.SCAN_REVERSED) boolean
> reversed,
> @DefaultValue("") @QueryParam(Constants.SCAN_FILTER) String
> paramFilter) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18647) Parameter cacheBlocks does not take effect in REST API for scan
[
https://issues.apache.org/jira/browse/HBASE-18647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136230#comment-16136230
]
Guangxu Cheng commented on HBASE-18647:
---
Upload the first patch for review.Thanks
> Parameter cacheBlocks does not take effect in REST API for scan
> ---
>
> Key: HBASE-18647
> URL: https://issues.apache.org/jira/browse/HBASE-18647
> Project: HBase
> Issue Type: Bug
> Components: REST
>Affects Versions: 2.0.0, 3.0.0, 1.4.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18647.patch
>
>
> Assign the parameter SCAN_BATCH_SIZE to the variable cacheBlocks incorrectly.
> And cacheBlocks has never been used.
> {code:title=TableResource.java|borderStyle=solid}
> @Path("{scanspec: .*[*]$}")
> public TableScanResource getScanResource(
> final @PathParam("scanspec") String scanSpec,
> @DefaultValue(Integer.MAX_VALUE + "")
> @QueryParam(Constants.SCAN_LIMIT) int userRequestedLimit,
> @DefaultValue("") @QueryParam(Constants.SCAN_START_ROW) String startRow,
> @DefaultValue("") @QueryParam(Constants.SCAN_END_ROW) String endRow,
> @DefaultValue("") @QueryParam(Constants.SCAN_COLUMN) List
> column,
> @DefaultValue("1") @QueryParam(Constants.SCAN_MAX_VERSIONS) int
> maxVersions,
> @DefaultValue("-1") @QueryParam(Constants.SCAN_BATCH_SIZE) int
> batchSize,
> @DefaultValue("0") @QueryParam(Constants.SCAN_START_TIME) long
> startTime,
> @DefaultValue(Long.MAX_VALUE + "") @QueryParam(Constants.SCAN_END_TIME)
> long endTime,
> @DefaultValue("true") @QueryParam(Constants.SCAN_BATCH_SIZE) boolean
> cacheBlocks,
> @DefaultValue("false") @QueryParam(Constants.SCAN_REVERSED) boolean
> reversed,
> @DefaultValue("") @QueryParam(Constants.SCAN_FILTER) String
> paramFilter) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-18647) Parameter cacheBlocks does not take effect in REST API for scan
Guangxu Cheng created HBASE-18647:
-
Summary: Parameter cacheBlocks does not take effect in REST API
for scan
Key: HBASE-18647
URL: https://issues.apache.org/jira/browse/HBASE-18647
Project: HBase
Issue Type: Bug
Components: REST
Affects Versions: 2.0.0, 3.0.0, 1.4.0
Reporter: Guangxu Cheng
Assignee: Guangxu Cheng
Assign the parameter SCAN_BATCH_SIZE to the variable cacheBlocks incorrectly.
And cacheBlocks has never been used.
{code:title=TableResource.java|borderStyle=solid}
@Path("{scanspec: .*[*]$}")
public TableScanResource getScanResource(
final @PathParam("scanspec") String scanSpec,
@DefaultValue(Integer.MAX_VALUE + "")
@QueryParam(Constants.SCAN_LIMIT) int userRequestedLimit,
@DefaultValue("") @QueryParam(Constants.SCAN_START_ROW) String startRow,
@DefaultValue("") @QueryParam(Constants.SCAN_END_ROW) String endRow,
@DefaultValue("") @QueryParam(Constants.SCAN_COLUMN) List column,
@DefaultValue("1") @QueryParam(Constants.SCAN_MAX_VERSIONS) int
maxVersions,
@DefaultValue("-1") @QueryParam(Constants.SCAN_BATCH_SIZE) int batchSize,
@DefaultValue("0") @QueryParam(Constants.SCAN_START_TIME) long startTime,
@DefaultValue(Long.MAX_VALUE + "") @QueryParam(Constants.SCAN_END_TIME)
long endTime,
@DefaultValue("true") @QueryParam(Constants.SCAN_BATCH_SIZE) boolean
cacheBlocks,
@DefaultValue("false") @QueryParam(Constants.SCAN_REVERSED) boolean
reversed,
@DefaultValue("") @QueryParam(Constants.SCAN_FILTER) String paramFilter) {
{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-16615) Fix flaky TestScannerHeartbeatMessages
[ https://issues.apache.org/jira/browse/HBASE-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136214#comment-16136214 ] Hudson commented on HBASE-16615: FAILURE: Integrated in Jenkins build HBase-1.4 #874 (See [https://builds.apache.org/job/HBase-1.4/874/]) HBASE-16615 Fix flaky TestScannerHeartbeatMessages (Duo Zhang) (stack: rev cf5e170bc7f099b95636e8656e1a5d1fd5d2019d) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScannerHeartbeatMessages.java > Fix flaky TestScannerHeartbeatMessages > -- > > Key: HBASE-16615 > URL: https://issues.apache.org/jira/browse/HBASE-16615 > Project: HBase > Issue Type: Bug > Components: Client, Scanners >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0, 1.4.0, 1.3.2 > > Attachments: HBASE-16615.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18542) [HLC] Performance microbenchmarks
[ https://issues.apache.org/jira/browse/HBASE-18542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136211#comment-16136211 ] Amit Patel edited comment on HBASE-18542 at 8/22/17 3:29 AM: - Added patch [^HBASE-18542.HBASE-14070.HLC.001.patch] that benchmarks performance of Clock#now and Clock#update under both single threaded and multi threaded cases. Below is a summary of the performance (where the number is the multiplicative factor of how much longer it took compared to the system clock). ||System clock||System monotonic||Hybrid logical clock|| |Clock#now single threaded|1.01|1.41| |Clock#update single threaded|1.01|1.36| |Clock#now multi threaded|1.23|1.76| |Clock#update multi threaded|2.28|2.20| was (Author: amit.patel): Added patch [^HBASE-18542.HBASE-14070.HLC.001.patch] that benchmarks performance of Clock#now and Clock#update under both single threaded and multi threaded cases. Below is a summary of the performance (where the number is the multiplicative factor of how much longer it took compared to the system clock). ||System clock||System monotonic|Hybrid logical clock|| |Clock#now single threaded|1.01|1.41| |Clock#update single threaded|1.01|1.36| |Clock#now multi threaded|1.23|1.76| |Clock#update multi threaded|2.28|2.20| > [HLC] Performance microbenchmarks > - > > Key: HBASE-18542 > URL: https://issues.apache.org/jira/browse/HBASE-18542 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Amit Patel > Attachments: HBASE-18542.HBASE-14070.HLC.001.patch > > > Need tests to benchmark performance of Clock#now() and update() functions > (for all types of clocks). > If update() is too costly, we can do optimizations in > ExecuteProceduresRemoteCall#call(), HRegion#replayRecoveredEdits() and other > places where we call update() in loop. Instead, it might be faster to > calculate max timestamp in loop and call update() just once. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17826) Backup: submitting M/R job to a particular Yarn queue
[
https://issues.apache.org/jira/browse/HBASE-17826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136212#comment-16136212
]
Hadoop QA commented on HBASE-17826:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 19s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}122m
56s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}175m 38s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-17826 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883006/HBASE-17826-v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 40aead6ff264 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26
18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 5895538 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8214/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8214/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Backup: submitting M/R job to a particular Yarn queue
> -
>
> Key: HBASE-17826
> URL: https://issues.apache.org/jira/browse/HBASE-17826
> Project: HBase
> Issue Type: Improvement
>Reporter: Vladimir Rodionov
>A
[jira] [Commented] (HBASE-18542) [HLC] Performance microbenchmarks
[ https://issues.apache.org/jira/browse/HBASE-18542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136211#comment-16136211 ] Amit Patel commented on HBASE-18542: Added patch [^HBASE-18542.HBASE-14070.HLC.001.patch] that benchmarks performance of Clock#now and Clock#update under both single threaded and multi threaded cases. Below is a summary of the performance (where the number is the multiplicative factor of how much longer it took compared to the system clock). ||System clock||System monotonic|Hybrid logical clock|| |Clock#now single threaded|1.01|1.41| |Clock#update single threaded|1.01|1.36| |Clock#now multi threaded|1.23|1.76| |Clock#update multi threaded|2.28|2.20| > [HLC] Performance microbenchmarks > - > > Key: HBASE-18542 > URL: https://issues.apache.org/jira/browse/HBASE-18542 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Amit Patel > Attachments: HBASE-18542.HBASE-14070.HLC.001.patch > > > Need tests to benchmark performance of Clock#now() and update() functions > (for all types of clocks). > If update() is too costly, we can do optimizations in > ExecuteProceduresRemoteCall#call(), HRegion#replayRecoveredEdits() and other > places where we call update() in loop. Instead, it might be faster to > calculate max timestamp in loop and call update() just once. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136205#comment-16136205
]
Hadoop QA commented on HBASE-17614:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 60 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
43s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
32s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-assembly . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
21s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
8s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
32m 49s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: .
hbase-assembly {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}111m
34s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 16m 36s{color}
| {color:red} hbase-backup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
30s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}162m
56s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
51s{color} | {color:green} hbase-assembly in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
37s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}375m 5s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-17614 |
| JIRA Patch URL |
https
[jira] [Updated] (HBASE-18542) [HLC] Performance microbenchmarks
[ https://issues.apache.org/jira/browse/HBASE-18542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Patel updated HBASE-18542: --- Attachment: HBASE-18542.HBASE-14070.HLC.001.patch > [HLC] Performance microbenchmarks > - > > Key: HBASE-18542 > URL: https://issues.apache.org/jira/browse/HBASE-18542 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Amit Patel > Attachments: HBASE-18542.HBASE-14070.HLC.001.patch > > > Need tests to benchmark performance of Clock#now() and update() functions > (for all types of clocks). > If update() is too costly, we can do optimizations in > ExecuteProceduresRemoteCall#call(), HRegion#replayRecoveredEdits() and other > places where we call update() in loop. Instead, it might be faster to > calculate max timestamp in loop and call update() just once. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16615) Fix flaky TestScannerHeartbeatMessages
[ https://issues.apache.org/jira/browse/HBASE-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136199#comment-16136199 ] Hudson commented on HBASE-16615: FAILURE: Integrated in Jenkins build HBase-1.5 #21 (See [https://builds.apache.org/job/HBase-1.5/21/]) HBASE-16615 Fix flaky TestScannerHeartbeatMessages (Duo Zhang) (stack: rev b8857b0a7bd4ce78de1d97b2ded140a053d9af2a) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScannerHeartbeatMessages.java > Fix flaky TestScannerHeartbeatMessages > -- > > Key: HBASE-16615 > URL: https://issues.apache.org/jira/browse/HBASE-16615 > Project: HBase > Issue Type: Bug > Components: Client, Scanners >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0, 1.4.0, 1.3.2 > > Attachments: HBASE-16615.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18644) Duplicate "compactionQueueLength" metric in Region Server metrics
[
https://issues.apache.org/jira/browse/HBASE-18644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136188#comment-16136188
]
Hudson commented on HBASE-18644:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #183 (See
[https://builds.apache.org/job/HBase-1.3-IT/183/])
HBASE-18644 Duplicate compactionQueueLength metric in Region Server (apurtell:
rev 1d1cdb72a5445a1fc7b6eced14fcf7111acbfaf6)
* (edit)
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java
> Duplicate "compactionQueueLength" metric in Region Server metrics
> -
>
> Key: HBASE-18644
> URL: https://issues.apache.org/jira/browse/HBASE-18644
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 1.3.1
>Reporter: Maddineni Sukumar
>Assignee: Maddineni Sukumar
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0
>
> Attachments: HBASE-18644-branch-1.3.patch
>
>
> Region Server JMX response has duplicate entries for "compactionQueueLength"
> "compactionQueueLength" : 0,
> "smallCompactionQueueLength" : 0,
> "largeCompactionQueueLength" : 0,
> "compactionQueueLength" : 0,
> "flushQueueLength" : 0
> We added "compactionQueueLength" metric twice in
> MetricsRegionServerSourceImpl.java
> {code:title=MetricsRegionServerSourceImpl.java|borderStyle=solid}
> .addGauge(Interns.info(COMPACTION_QUEUE_LENGTH, COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getCompactionQueueSize())
> .addGauge(Interns.info(SMALL_COMPACTION_QUEUE_LENGTH,
> SMALL_COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getSmallCompactionQueueSize())
> .addGauge(Interns.info(LARGE_COMPACTION_QUEUE_LENGTH,
> LARGE_COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getLargeCompactionQueueSize())
> .addGauge(Interns.info(COMPACTION_QUEUE_LENGTH,
> COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getCompactionQueueSize())
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18287) Remove log warning in PartitionedMobCompactor.java#getFileStatus
[
https://issues.apache.org/jira/browse/HBASE-18287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136183#comment-16136183
]
Hadoop QA commented on HBASE-18287:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 49s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}112m 27s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}165m 54s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.mob.compactions.TestMobCompactor |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18287 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12882999/HBASE-18287.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux dabe5f38a2d3 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / bf343da |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8213/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8213/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8213/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Remove log warning in PartitionedMobCompactor.java#getFileStatus
> --
[jira] [Commented] (HBASE-18644) Duplicate "compactionQueueLength" metric in Region Server metrics
[
https://issues.apache.org/jira/browse/HBASE-18644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136169#comment-16136169
]
Hudson commented on HBASE-18644:
FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #249 (See
[https://builds.apache.org/job/HBase-1.3-JDK7/249/])
HBASE-18644 Duplicate compactionQueueLength metric in Region Server (apurtell:
rev 1d1cdb72a5445a1fc7b6eced14fcf7111acbfaf6)
* (edit)
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java
> Duplicate "compactionQueueLength" metric in Region Server metrics
> -
>
> Key: HBASE-18644
> URL: https://issues.apache.org/jira/browse/HBASE-18644
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 1.3.1
>Reporter: Maddineni Sukumar
>Assignee: Maddineni Sukumar
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0
>
> Attachments: HBASE-18644-branch-1.3.patch
>
>
> Region Server JMX response has duplicate entries for "compactionQueueLength"
> "compactionQueueLength" : 0,
> "smallCompactionQueueLength" : 0,
> "largeCompactionQueueLength" : 0,
> "compactionQueueLength" : 0,
> "flushQueueLength" : 0
> We added "compactionQueueLength" metric twice in
> MetricsRegionServerSourceImpl.java
> {code:title=MetricsRegionServerSourceImpl.java|borderStyle=solid}
> .addGauge(Interns.info(COMPACTION_QUEUE_LENGTH, COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getCompactionQueueSize())
> .addGauge(Interns.info(SMALL_COMPACTION_QUEUE_LENGTH,
> SMALL_COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getSmallCompactionQueueSize())
> .addGauge(Interns.info(LARGE_COMPACTION_QUEUE_LENGTH,
> LARGE_COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getLargeCompactionQueueSize())
> .addGauge(Interns.info(COMPACTION_QUEUE_LENGTH,
> COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getCompactionQueueSize())
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18532) Improve cache related stats rendered on RS UI
[
https://issues.apache.org/jira/browse/HBASE-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136153#comment-16136153
]
Hadoop QA commented on HBASE-18532:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
48s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
3s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for
instructions. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
41m 56s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 86m 34s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
36s{color} | {color:green} hbase-external-blockcache in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
4s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}159m 52s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure |
| | org.apache.hadoop.hbase.regionserver.TestRowTooBig |
| | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy
|
| | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
| | org.apache.hadoop.hbase.master.procedure.TestSafemodeBringsDownMaster |
| | org.apache.hadoop.hbase.regionserver.wal.TestFSHLog |
| | org.apache.hadoop.hbase.regionserver.TestCompaction |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
| | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries |
| | org.apache.hadoop.hbase.backup.Te
[jira] [Commented] (HBASE-18267) The result from the postAppend is ignored
[
https://issues.apache.org/jira/browse/HBASE-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136149#comment-16136149
]
Hudson commented on HBASE-18267:
SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #196 (See
[https://builds.apache.org/job/HBase-1.2-JDK8/196/])
Revert "HBASE-18267 The result from the postAppend is ignored" It breaks
(chia7712: rev 26606b190ba61046718aea8a25bfb60f12dd7e3c)
* (delete)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResultFromCoprocessor.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
> The result from the postAppend is ignored
> -
>
> Key: HBASE-18267
> URL: https://issues.apache.org/jira/browse/HBASE-18267
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
>Affects Versions: 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18267.branch-1.2.v0.patch,
> HBASE-18267.branch-1.3.v0.patch, HBASE-18267.branch-1.v0.patch,
> HBASE-18267.v0.patch, HBASE-18267.v1.patch
>
>
> {code:title=RegionCoprocessorHost.java|borderStyle=solid}
> /**
>* @param append Append object
>* @param result the result returned by the append
>* @throws IOException if an error occurred on the coprocessor
>*/
> public void postAppend(final Append append, final Result result) throws
> IOException {
> execOperation(coprocessors.isEmpty() ? null : new RegionOperation() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> oserver.postAppend(ctx, append, result);
> }
> });
> }
> /**
>* @param increment increment object
>* @param result the result returned by postIncrement
>* @throws IOException if an error occurred on the coprocessor
>*/
> public Result postIncrement(final Increment increment, Result result)
> throws IOException {
> return execOperationWithResult(result,
> coprocessors.isEmpty() ? null : new
> RegionOperationWithResult() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> setResult(oserver.postIncrement(ctx, increment, getResult()));
> }
> });
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136144#comment-16136144 ] Mike Drob commented on HBASE-12349: --- org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 fails locally for me without the patch as well. > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob >Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch, HBASE-12349.v5.patch, > HBASE-12349.v6.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18628) ZKPermissionWatcher blocks all ZK notifications
[
https://issues.apache.org/jira/browse/HBASE-18628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136131#comment-16136131
]
Mike Drob commented on HBASE-18628:
---
bq. @apurtell - Yes I would like to see it. Do you need assistance?
I have a branch-1 patch up, I think it looks ok.
bq. We no longer need to use ZK for a notification bus for ACL permission
changes now that we have ProcedureV2.
Agree, but that code isn't there yet, hence we have this issue. Happy to see it
all gone when those are completed.
bq. [~huaxiang] - Curious about the root cause, I think that the task submit
did not succeed. Does the following diff achieve the goal?
I can try it and will let you know.
> ZKPermissionWatcher blocks all ZK notifications
> ---
>
> Key: HBASE-18628
> URL: https://issues.apache.org/jira/browse/HBASE-18628
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18628.branch-1.v5.patch, HBASE-18628.patch,
> HBASE-18628.v2.patch, HBASE-18628.v3.patch, HBASE-18628.v4.patch,
> HBASE-18628.v5.patch, jstack
>
>
> Buckle up folks, we're going for a ride here. I've seeing this on a branch-2
> based build, but I think the problem will affect branch-1 as well. I'm not
> able to easily reproduce the issue, but it will usually come up within an
> hour on a given cluster that I have, at which point the problem persists
> until an RS restart. I've been seeing the problem and paying attention for
> maybe two months, but I suspect it's been happening much longer than that.
> h3. Problem
> When running in a secure cluster, sometimes the ZK EventThread will get stuck
> on a permissions update and not be able to process new notifications. This
> happens to also block flush and snapshot, which is how we found it.
> h3. Analysis
> The main smoking gun is seeing this in repeated jstacks:
> {noformat}
> "main-EventThread" #43 daemon prio=5 os_prio=0 tid=0x7f0b92644000
> nid=0x6e69 waiting on condition [0x7f0b6730f000]
>java.lang.Thread.State: TIMED_WAITING (sleeping)
> at java.lang.Thread.sleep(Native Method)
> at
> org.apache.hadoop.hbase.security.access.ZKPermissionWatcher.nodeChildrenChanged(ZKPermissionWatcher.java:191)
> at
> org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.process(ZooKeeperWatcher.java:503)
> at
> org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:522)
> at
> org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:498)
> {noformat}
> That sleep is a 20ms sleep in an {{AtomicReference.compareAndSet}} loop - but
> it never gets past the condition.
> {code}
> while (!nodes.compareAndSet(null, nodeList)) {
> try {
> Thread.sleep(20);
> } catch (InterruptedException e) {
> LOG.warn("Interrupted while setting node list", e);
> Thread.currentThread().interrupt();
> }
> }
> {code}
> The warning never shows up in the logs, it just keeps looping and looping.
> The last relevant line from the watcher in logs is:
> {noformat}
> 2017-08-17 21:25:12,379 DEBUG
> org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher:
> regionserver:22101-0x15df38884c80024, quorum=zk1:2181,zk2:2181,zk3:2181,
> baseZNode=/hbase Received ZooKeeper Event, type=NodeChildrenChanged,
> state=SyncConnected, path=/hbase/acl
> {noformat}
> Which makes sense, because the code snippet is from permission watcher's
> {{nodeChildrenChanged}} handler.
> The separate thread introduced in HBASE-14370 is present, but not doing
> anything. And this event hasn't gotten to the part where it splits off into a
> thread:
> {noformat}
> "zk-permission-watcher4-thread-1" #160 daemon prio=5 os_prio=0
> tid=0x01750800 nid=0x6fd9 waiting on condition [0x7f0b5dce5000]
>java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for <0x0007436ecea0> (a
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
> at
> java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
> at
> java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.ja
[jira] [Comment Edited] (HBASE-18628) ZKPermissionWatcher blocks all ZK notifications
[
https://issues.apache.org/jira/browse/HBASE-18628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136131#comment-16136131
]
Mike Drob edited comment on HBASE-18628 at 8/22/17 1:34 AM:
bq. [~apurtell] - Yes I would like to see it. Do you need assistance?
I have a branch-1 patch up, I think it looks ok.
bq. We no longer need to use ZK for a notification bus for ACL permission
changes now that we have ProcedureV2.
Agree, but that code isn't there yet, hence we have this issue. Happy to see it
all gone when those are completed.
bq. [~huaxiang] - Curious about the root cause, I think that the task submit
did not succeed. Does the following diff achieve the goal?
I can try it and will let you know.
was (Author: mdrob):
bq. @apurtell - Yes I would like to see it. Do you need assistance?
I have a branch-1 patch up, I think it looks ok.
bq. We no longer need to use ZK for a notification bus for ACL permission
changes now that we have ProcedureV2.
Agree, but that code isn't there yet, hence we have this issue. Happy to see it
all gone when those are completed.
bq. [~huaxiang] - Curious about the root cause, I think that the task submit
did not succeed. Does the following diff achieve the goal?
I can try it and will let you know.
> ZKPermissionWatcher blocks all ZK notifications
> ---
>
> Key: HBASE-18628
> URL: https://issues.apache.org/jira/browse/HBASE-18628
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18628.branch-1.v5.patch, HBASE-18628.patch,
> HBASE-18628.v2.patch, HBASE-18628.v3.patch, HBASE-18628.v4.patch,
> HBASE-18628.v5.patch, jstack
>
>
> Buckle up folks, we're going for a ride here. I've seeing this on a branch-2
> based build, but I think the problem will affect branch-1 as well. I'm not
> able to easily reproduce the issue, but it will usually come up within an
> hour on a given cluster that I have, at which point the problem persists
> until an RS restart. I've been seeing the problem and paying attention for
> maybe two months, but I suspect it's been happening much longer than that.
> h3. Problem
> When running in a secure cluster, sometimes the ZK EventThread will get stuck
> on a permissions update and not be able to process new notifications. This
> happens to also block flush and snapshot, which is how we found it.
> h3. Analysis
> The main smoking gun is seeing this in repeated jstacks:
> {noformat}
> "main-EventThread" #43 daemon prio=5 os_prio=0 tid=0x7f0b92644000
> nid=0x6e69 waiting on condition [0x7f0b6730f000]
>java.lang.Thread.State: TIMED_WAITING (sleeping)
> at java.lang.Thread.sleep(Native Method)
> at
> org.apache.hadoop.hbase.security.access.ZKPermissionWatcher.nodeChildrenChanged(ZKPermissionWatcher.java:191)
> at
> org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.process(ZooKeeperWatcher.java:503)
> at
> org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:522)
> at
> org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:498)
> {noformat}
> That sleep is a 20ms sleep in an {{AtomicReference.compareAndSet}} loop - but
> it never gets past the condition.
> {code}
> while (!nodes.compareAndSet(null, nodeList)) {
> try {
> Thread.sleep(20);
> } catch (InterruptedException e) {
> LOG.warn("Interrupted while setting node list", e);
> Thread.currentThread().interrupt();
> }
> }
> {code}
> The warning never shows up in the logs, it just keeps looping and looping.
> The last relevant line from the watcher in logs is:
> {noformat}
> 2017-08-17 21:25:12,379 DEBUG
> org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher:
> regionserver:22101-0x15df38884c80024, quorum=zk1:2181,zk2:2181,zk3:2181,
> baseZNode=/hbase Received ZooKeeper Event, type=NodeChildrenChanged,
> state=SyncConnected, path=/hbase/acl
> {noformat}
> Which makes sense, because the code snippet is from permission watcher's
> {{nodeChildrenChanged}} handler.
> The separate thread introduced in HBASE-14370 is present, but not doing
> anything. And this event hasn't gotten to the part where it splits off into a
> thread:
> {noformat}
> "zk-permission-watcher4-thread-1" #160 daemon prio=5 os_prio=0
> tid=0x01750800 nid=0x6fd9 waiting on condition [0x7f0b5dce5000]
>java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for <0x0007436ecea0> (a
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> at java.util.concurrent.l
[jira] [Commented] (HBASE-17442) Move most of the replication related classes to hbase-server package
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136128#comment-16136128
]
Hadoop QA commented on HBASE-17442:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
32s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
10s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
25s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
30m 48s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
45s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
9s{color} | {color:green} hbase-replication in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}110m
6s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}126m 58s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
11s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}315m 44s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | org.apache.hadoop.hbase.mapreduce.TestWALPlayer |
| | org.apache.hadoop.hbase.mapreduce.TestHRegionPartitioner |
| | org.apache.hadoop.hbase.ma
[jira] [Commented] (HBASE-16615) Fix flaky TestScannerHeartbeatMessages
[ https://issues.apache.org/jira/browse/HBASE-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136126#comment-16136126 ] Hudson commented on HBASE-16615: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #182 (See [https://builds.apache.org/job/HBase-1.3-IT/182/]) HBASE-16615 Fix flaky TestScannerHeartbeatMessages (Duo Zhang) (stack: rev 65fda491fd64bd096944e42e182639049d558bb0) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScannerHeartbeatMessages.java > Fix flaky TestScannerHeartbeatMessages > -- > > Key: HBASE-16615 > URL: https://issues.apache.org/jira/browse/HBASE-16615 > Project: HBase > Issue Type: Bug > Components: Client, Scanners >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0, 1.4.0, 1.3.2 > > Attachments: HBASE-16615.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14351) Procedure V2 Phase 3: Notification Bus
[ https://issues.apache.org/jira/browse/HBASE-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136123#comment-16136123 ] Mike Drob commented on HBASE-14351: --- [~apurtell], [~stack] - There's some subtasks here that are still not done. Does this need to make 2.0? Or can it wait for 2.1? > Procedure V2 Phase 3: Notification Bus > -- > > Key: HBASE-14351 > URL: https://issues.apache.org/jira/browse/HBASE-14351 > Project: HBase > Issue Type: Task >Reporter: Stephen Yuan Jiang >Assignee: Matteo Bertozzi > > This is the third phase of Procedure V2 (HBASE-12439) feature. Built on top > of state machine from Phase 1 (HBASE-14336), the notification bus is just > an exchange of messages between the multiple machines (e.g. master and > regionservers). The notification bus allows master to send > notifications/procedures to the Region Servers. Two examples are snapshot for > OnePhaseProcedure and ACL update for TwoPhaseProcedure (check HBASE-12439 for > high-level design). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[
https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136121#comment-16136121
]
Hadoop QA commented on HBASE-12349:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 12m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 7m
25s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly
hbase-shaded hbase-archetypes . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 14m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m
53s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 14m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 14m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 14m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 10m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
58s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
39m 59s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-build-support hbase-build-configuration hbase-resource-bundle
hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes
. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 17m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
9s{color} | {color:green} hbase-build-support in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
9s{color} | {color:green} hbase-error-prone in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
7s{color} | {color:green} hbase-build-configuration in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
7s{color} | {color:green} hbase-resource-bundle in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
9s{color} | {color:green} hbase-annotations in the patch passed. {color} |
| {color:green}+1{color} |
[jira] [Updated] (HBASE-18578) [C++] Add pause for RPC test
[ https://issues.apache.org/jira/browse/HBASE-18578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-18578: -- Attachment: hbase-18578-v2.patch [~xiaobingo] you are getting broken promise, because if a promise is left unfulfilled at the time of the destruction, then the future throws broken promise, the code is here: https://github.com/facebook/folly/blob/master/folly/futures/detail/Core.h#L210. The problem is that in the test for the pause RPC, the test does and async RPC, but does not wait on the returned Future in v1 patch, and instead goes ahead and stops the server which then causes the RPC Client pipeline to the destructed. Since the RPC takes 500ms, it always fails because server and pipeline is destructed. The patch at HBASE-18204 solves the broken promise problem because at the time of pipeline destruction, we already fulfill the promises from the client-dispatcher. I've tested the patch with this patch, and it is doing the expected behavior. The fix to the test is calling Future.get() before stopping the server. Attaching v2. > [C++] Add pause for RPC test > > > Key: HBASE-18578 > URL: https://issues.apache.org/jira/browse/HBASE-18578 > Project: HBase > Issue Type: Sub-task >Reporter: Xiaobing Zhou > Attachments: HBASE-18578.000.patch, hbase-18578-v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18628) ZKPermissionWatcher blocks all ZK notifications
[
https://issues.apache.org/jira/browse/HBASE-18628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136118#comment-16136118
]
Hadoop QA commented on HBASE-18628:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
22s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
28s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
37s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
8s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
15s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
18m 26s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}113m 46s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
29s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}155m 9s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestClientScannerRPCTimeout |
| | hadoop.hbase.security.access.TestAccessControlFilter |
| | hadoop.hbase.security.access.TestTablePermissions |
| | hadoop.hbase.client.TestReplicasClient |
| | hadoop.hbase.master.TestMasterFailover |
| Timed out junit tests | org.apache.hadoop.hbase.regionserver.TestHRegion |
| | org.apache.hadoop.hbase.security.access.TestScanEarlyTermination |
| | org.apache.hadoop.hbase.mapreduce.TestTableSnapshotInputFormat |
\\
\\
|| Subsystem || Report/Notes ||
[jira] [Commented] (HBASE-18628) ZKPermissionWatcher blocks all ZK notifications
[
https://issues.apache.org/jira/browse/HBASE-18628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136115#comment-16136115
]
huaxiang sun commented on HBASE-18628:
--
Curious about the root cause, I think that the task submit did not succeed.
Does the following diff achieve the goal?
Thanks.
{code}
diff --git
a/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ZKPermissionWatcher.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ZKPermissionWatcher.java
index 3324b90..9c25879 100644
---
a/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ZKPermissionWatcher.java
+++
b/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ZKPermissionWatcher.java
@@ -215,6 +215,7 @@ public class ZKPermissionWatcher extends ZooKeeperListener
implements Closeable
if (!executor.isShutdown()) {
try {
executor.submit(runnable);
+return;
} catch (RejectedExecutionException e) {
if (executor.isShutdown()) {
LOG.warn("aclZNode changed after ZKPermissionWatcher was shutdown");
@@ -223,6 +224,8 @@ public class ZKPermissionWatcher extends ZooKeeperListener
implements Closeable
}
}
}
+// Something wrong with the task submit, reset the nodes's value to null
+nodes.set(null);
}
private void refreshNodes(List nodes, AtomicReference
ref) {
hsun-MBP:hbase hsun$
{code}
> ZKPermissionWatcher blocks all ZK notifications
> ---
>
> Key: HBASE-18628
> URL: https://issues.apache.org/jira/browse/HBASE-18628
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18628.branch-1.v5.patch, HBASE-18628.patch,
> HBASE-18628.v2.patch, HBASE-18628.v3.patch, HBASE-18628.v4.patch,
> HBASE-18628.v5.patch, jstack
>
>
> Buckle up folks, we're going for a ride here. I've seeing this on a branch-2
> based build, but I think the problem will affect branch-1 as well. I'm not
> able to easily reproduce the issue, but it will usually come up within an
> hour on a given cluster that I have, at which point the problem persists
> until an RS restart. I've been seeing the problem and paying attention for
> maybe two months, but I suspect it's been happening much longer than that.
> h3. Problem
> When running in a secure cluster, sometimes the ZK EventThread will get stuck
> on a permissions update and not be able to process new notifications. This
> happens to also block flush and snapshot, which is how we found it.
> h3. Analysis
> The main smoking gun is seeing this in repeated jstacks:
> {noformat}
> "main-EventThread" #43 daemon prio=5 os_prio=0 tid=0x7f0b92644000
> nid=0x6e69 waiting on condition [0x7f0b6730f000]
>java.lang.Thread.State: TIMED_WAITING (sleeping)
> at java.lang.Thread.sleep(Native Method)
> at
> org.apache.hadoop.hbase.security.access.ZKPermissionWatcher.nodeChildrenChanged(ZKPermissionWatcher.java:191)
> at
> org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.process(ZooKeeperWatcher.java:503)
> at
> org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:522)
> at
> org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:498)
> {noformat}
> That sleep is a 20ms sleep in an {{AtomicReference.compareAndSet}} loop - but
> it never gets past the condition.
> {code}
> while (!nodes.compareAndSet(null, nodeList)) {
> try {
> Thread.sleep(20);
> } catch (InterruptedException e) {
> LOG.warn("Interrupted while setting node list", e);
> Thread.currentThread().interrupt();
> }
> }
> {code}
> The warning never shows up in the logs, it just keeps looping and looping.
> The last relevant line from the watcher in logs is:
> {noformat}
> 2017-08-17 21:25:12,379 DEBUG
> org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher:
> regionserver:22101-0x15df38884c80024, quorum=zk1:2181,zk2:2181,zk3:2181,
> baseZNode=/hbase Received ZooKeeper Event, type=NodeChildrenChanged,
> state=SyncConnected, path=/hbase/acl
> {noformat}
> Which makes sense, because the code snippet is from permission watcher's
> {{nodeChildrenChanged}} handler.
> The separate thread introduced in HBASE-14370 is present, but not doing
> anything. And this event hasn't gotten to the part where it splits off into a
> thread:
> {noformat}
> "zk-permission-watcher4-thread-1" #160 daemon prio=5 os_prio=0
> tid=0x01750800 nid=0x6fd9 waiting on condition [0x7f0b5dce5000]
>java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - pa
[jira] [Commented] (HBASE-18628) ZKPermissionWatcher blocks all ZK notifications
[
https://issues.apache.org/jira/browse/HBASE-18628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136112#comment-16136112
]
Enis Soztutar commented on HBASE-18628:
---
Thanks for the clarifications. Makes sense.
bq. The original reason for preemption was performance - either you or Ted
claimed that updating permissions on a large cluster can take several minutes,
and if multiple updates come in close proximity then there is no reason to
process the stale data. I'm happy to see this code removed because I agree that
it is complicated and brittle, but I did manage to run this against the one
cluster I've seen the problem on and the issue went away (without other issues
appearing). No promises that my new code is foolproof, but I feel good about it.
Looking at the code again there should not be any reason that the nodes
reference stays non-null, but obviously since you have observed this in tests,
and this patch is fixing the problem let's go with it.
+1.
> ZKPermissionWatcher blocks all ZK notifications
> ---
>
> Key: HBASE-18628
> URL: https://issues.apache.org/jira/browse/HBASE-18628
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18628.branch-1.v5.patch, HBASE-18628.patch,
> HBASE-18628.v2.patch, HBASE-18628.v3.patch, HBASE-18628.v4.patch,
> HBASE-18628.v5.patch, jstack
>
>
> Buckle up folks, we're going for a ride here. I've seeing this on a branch-2
> based build, but I think the problem will affect branch-1 as well. I'm not
> able to easily reproduce the issue, but it will usually come up within an
> hour on a given cluster that I have, at which point the problem persists
> until an RS restart. I've been seeing the problem and paying attention for
> maybe two months, but I suspect it's been happening much longer than that.
> h3. Problem
> When running in a secure cluster, sometimes the ZK EventThread will get stuck
> on a permissions update and not be able to process new notifications. This
> happens to also block flush and snapshot, which is how we found it.
> h3. Analysis
> The main smoking gun is seeing this in repeated jstacks:
> {noformat}
> "main-EventThread" #43 daemon prio=5 os_prio=0 tid=0x7f0b92644000
> nid=0x6e69 waiting on condition [0x7f0b6730f000]
>java.lang.Thread.State: TIMED_WAITING (sleeping)
> at java.lang.Thread.sleep(Native Method)
> at
> org.apache.hadoop.hbase.security.access.ZKPermissionWatcher.nodeChildrenChanged(ZKPermissionWatcher.java:191)
> at
> org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.process(ZooKeeperWatcher.java:503)
> at
> org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:522)
> at
> org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:498)
> {noformat}
> That sleep is a 20ms sleep in an {{AtomicReference.compareAndSet}} loop - but
> it never gets past the condition.
> {code}
> while (!nodes.compareAndSet(null, nodeList)) {
> try {
> Thread.sleep(20);
> } catch (InterruptedException e) {
> LOG.warn("Interrupted while setting node list", e);
> Thread.currentThread().interrupt();
> }
> }
> {code}
> The warning never shows up in the logs, it just keeps looping and looping.
> The last relevant line from the watcher in logs is:
> {noformat}
> 2017-08-17 21:25:12,379 DEBUG
> org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher:
> regionserver:22101-0x15df38884c80024, quorum=zk1:2181,zk2:2181,zk3:2181,
> baseZNode=/hbase Received ZooKeeper Event, type=NodeChildrenChanged,
> state=SyncConnected, path=/hbase/acl
> {noformat}
> Which makes sense, because the code snippet is from permission watcher's
> {{nodeChildrenChanged}} handler.
> The separate thread introduced in HBASE-14370 is present, but not doing
> anything. And this event hasn't gotten to the part where it splits off into a
> thread:
> {noformat}
> "zk-permission-watcher4-thread-1" #160 daemon prio=5 os_prio=0
> tid=0x01750800 nid=0x6fd9 waiting on condition [0x7f0b5dce5000]
>java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for <0x0007436ecea0> (a
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
> at
> java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
> at
> java.util.concur
[jira] [Commented] (HBASE-16615) Fix flaky TestScannerHeartbeatMessages
[ https://issues.apache.org/jira/browse/HBASE-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136109#comment-16136109 ] Hudson commented on HBASE-16615: FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #248 (See [https://builds.apache.org/job/HBase-1.3-JDK7/248/]) HBASE-16615 Fix flaky TestScannerHeartbeatMessages (Duo Zhang) (stack: rev 65fda491fd64bd096944e42e182639049d558bb0) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScannerHeartbeatMessages.java > Fix flaky TestScannerHeartbeatMessages > -- > > Key: HBASE-16615 > URL: https://issues.apache.org/jira/browse/HBASE-16615 > Project: HBase > Issue Type: Bug > Components: Client, Scanners >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0, 1.4.0, 1.3.2 > > Attachments: HBASE-16615.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
[ https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18640: -- Attachment: HBASE-18640.master.004.patch > Move mapreduce out of hbase-server into separate hbase-mapreduce moduel > --- > > Key: HBASE-18640 > URL: https://issues.apache.org/jira/browse/HBASE-18640 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-18640.master.001.patch, > HBASE-18640.master.002.patch, HBASE-18640.master.003.patch, > HBASE-18640.master.003.patch, HBASE-18640.master.004.patch, > HBASE-18640.master.004.patch > > > (Couldn't find another dedicated jira, so creating new one). > Uploaded patch which is moving ~60 files to the new module. Few notes: > - The classes remaining in hbase-server are the ones which are intensively > coupled with visibility labels/wal/filesystem/hfile. These can not be > migrated to new module until corresponding subcomponents are untangled out of > hbase-server into their own separate modules. > - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to > hbase-mapreduce module. Given these dependency constraints, one way would be > having a separate module for tests: > hbase-mapreduce < hbase-server <--- hbase-mapreduce-tests > Imo, this makes sense and looks fine. > The only issue is - yetus' pre-commit. It won't run tests in > hbase-mapreduce-tests module if something changed in just hbase-mapreduce. > However, yetus' limitation shouldn't warrant against the idea. > So i'd say that we should go that way, unless there are better suggestions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18644) Duplicate "compactionQueueLength" metric in Region Server metrics
[
https://issues.apache.org/jira/browse/HBASE-18644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-18644:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 1.5.0
1.4.0
3.0.0
2.0.0
Status: Resolved (was: Patch Available)
Pushed to branch-1.3 and up
> Duplicate "compactionQueueLength" metric in Region Server metrics
> -
>
> Key: HBASE-18644
> URL: https://issues.apache.org/jira/browse/HBASE-18644
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 1.3.1
>Reporter: Maddineni Sukumar
>Assignee: Maddineni Sukumar
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0
>
> Attachments: HBASE-18644-branch-1.3.patch
>
>
> Region Server JMX response has duplicate entries for "compactionQueueLength"
> "compactionQueueLength" : 0,
> "smallCompactionQueueLength" : 0,
> "largeCompactionQueueLength" : 0,
> "compactionQueueLength" : 0,
> "flushQueueLength" : 0
> We added "compactionQueueLength" metric twice in
> MetricsRegionServerSourceImpl.java
> {code:title=MetricsRegionServerSourceImpl.java|borderStyle=solid}
> .addGauge(Interns.info(COMPACTION_QUEUE_LENGTH, COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getCompactionQueueSize())
> .addGauge(Interns.info(SMALL_COMPACTION_QUEUE_LENGTH,
> SMALL_COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getSmallCompactionQueueSize())
> .addGauge(Interns.info(LARGE_COMPACTION_QUEUE_LENGTH,
> LARGE_COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getLargeCompactionQueueSize())
> .addGauge(Interns.info(COMPACTION_QUEUE_LENGTH,
> COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getCompactionQueueSize())
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17826) Backup: submitting M/R job to a particular Yarn queue
[ https://issues.apache.org/jira/browse/HBASE-17826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136106#comment-16136106 ] Ted Yu commented on HBASE-17826: But the variable is called poolName > Backup: submitting M/R job to a particular Yarn queue > - > > Key: HBASE-17826 > URL: https://issues.apache.org/jira/browse/HBASE-17826 > Project: HBase > Issue Type: Improvement >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17826-v1.patch > > > We need this to be configurable. Currently, all M/R jobs are submitted to a > default queue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18448) Added support for refreshing HFiles through API and shell
[ https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136104#comment-16136104 ] Ajay Jadhav commented on HBASE-18448: - I ran the UTs locally and I still see the below ones still failing: TestClientScannerRPCTimeout.testScannerNextRPCTimesout:87 » TableExists testSc... TestRowProcessorEndpoint.testDoubleScan:157->prepareTestData:139 » RetriesExhausted TestRowProcessorEndpoint.testMultipleRows:244->prepareTestData:139 » RetriesExhausted TestRowProcessorEndpoint.testReadModifyWrite:179->prepareTestData:139 » RetriesExhausted TestRowProcessorEndpoint.testTimeout:289->prepareTestData:139 » RetriesExhausted TestMasterFailover.testMetaInTransitionWhenMasterFailover:1381 » IO Aborting f... They seem like valid failures and a fix might be needed for some of them. But these are not related to code change that was done as part of this patch. I'll try to spend some time to find the root cause and fix them in separate jira. Also, attached the patch for master branch (based on docs, it seems that the protos files are generated at runtime in 2.x) > Added support for refreshing HFiles through API and shell > - > > Key: HBASE-18448 > URL: https://issues.apache.org/jira/browse/HBASE-18448 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0, 1.3.1 >Reporter: Ajay Jadhav >Assignee: Ajay Jadhav >Priority: Minor > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-18448.branch-1.001.patch, > HBASE-18448.branch-1.002.patch, HBASE-18448.branch-1.003.patch, > HBASE-18448.branch-1.004.patch, HBASE-18448.branch-1.005.patch, > HBASE-18448.branch-1.006.patch, HBASE-18448.branch-1.007.patch, > HBASE-18448.master.001.patch > > > In the case where multiple HBase clusters are sharing a common rootDir, even > after flushing the data from > one cluster doesn't mean that other clusters (replicas) will automatically > pick the new HFile. Through this patch, > we are exposing the refresh HFiles API which when issued from a replica will > update the in-memory file handle list > with the newly added file. > This allows replicas to be consistent with the data written through the > primary cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18508) [HLC] Fix timing out tests in HBASE-14070.HLC branch
[ https://issues.apache.org/jira/browse/HBASE-18508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136105#comment-16136105 ] stack commented on HBASE-18508: --- Looks like its an issue w/ infrastructure, not w/ your patch if an empty patch produces the above? [~amit.patel] > [HLC] Fix timing out tests in HBASE-14070.HLC branch > > > Key: HBASE-18508 > URL: https://issues.apache.org/jira/browse/HBASE-18508 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Amit Patel > Attachments: > 0001-HBASE-18508-empty-patch-added-new-line-in-TestClockW.patch, > HBASE-18508.HBASE-14070.HLC.001.patch, HBASE-18508.HBASE-14070.HLC.002.patch, > HBASE-18508.HBASE-14070.HLC.003.patch, HBASE-18508.HBASE-14070.HLC.003.patch, > HBASE-18508.HBASE-14070.HLC.004.patch > > > Pre-commit runs for this branch output a huge list of timed out tests. Not > seeing those in master branch. > Needs to be fixed before merging. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18448) Added support for refreshing HFiles through API and shell
[ https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Jadhav updated HBASE-18448: Status: Open (was: Patch Available) > Added support for refreshing HFiles through API and shell > - > > Key: HBASE-18448 > URL: https://issues.apache.org/jira/browse/HBASE-18448 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.3.1, 2.0.0 >Reporter: Ajay Jadhav >Assignee: Ajay Jadhav >Priority: Minor > Fix For: 1.4.0 > > Attachments: HBASE-18448.branch-1.001.patch, > HBASE-18448.branch-1.002.patch, HBASE-18448.branch-1.003.patch, > HBASE-18448.branch-1.004.patch, HBASE-18448.branch-1.005.patch, > HBASE-18448.branch-1.006.patch, HBASE-18448.branch-1.007.patch, > HBASE-18448.master.001.patch > > > In the case where multiple HBase clusters are sharing a common rootDir, even > after flushing the data from > one cluster doesn't mean that other clusters (replicas) will automatically > pick the new HFile. Through this patch, > we are exposing the refresh HFiles API which when issued from a replica will > update the in-memory file handle list > with the newly added file. > This allows replicas to be consistent with the data written through the > primary cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18448) Added support for refreshing HFiles through API and shell
[ https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Jadhav updated HBASE-18448: Fix Version/s: 2.0.0 Status: Patch Available (was: Open) > Added support for refreshing HFiles through API and shell > - > > Key: HBASE-18448 > URL: https://issues.apache.org/jira/browse/HBASE-18448 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.3.1, 2.0.0 >Reporter: Ajay Jadhav >Assignee: Ajay Jadhav >Priority: Minor > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-18448.branch-1.001.patch, > HBASE-18448.branch-1.002.patch, HBASE-18448.branch-1.003.patch, > HBASE-18448.branch-1.004.patch, HBASE-18448.branch-1.005.patch, > HBASE-18448.branch-1.006.patch, HBASE-18448.branch-1.007.patch, > HBASE-18448.master.001.patch > > > In the case where multiple HBase clusters are sharing a common rootDir, even > after flushing the data from > one cluster doesn't mean that other clusters (replicas) will automatically > pick the new HFile. Through this patch, > we are exposing the refresh HFiles API which when issued from a replica will > update the in-memory file handle list > with the newly added file. > This allows replicas to be consistent with the data written through the > primary cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18448) Added support for refreshing HFiles through API and shell
[ https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Jadhav updated HBASE-18448: Attachment: HBASE-18448.branch-1.007.patch > Added support for refreshing HFiles through API and shell > - > > Key: HBASE-18448 > URL: https://issues.apache.org/jira/browse/HBASE-18448 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0, 1.3.1 >Reporter: Ajay Jadhav >Assignee: Ajay Jadhav >Priority: Minor > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-18448.branch-1.001.patch, > HBASE-18448.branch-1.002.patch, HBASE-18448.branch-1.003.patch, > HBASE-18448.branch-1.004.patch, HBASE-18448.branch-1.005.patch, > HBASE-18448.branch-1.006.patch, HBASE-18448.branch-1.007.patch, > HBASE-18448.master.001.patch > > > In the case where multiple HBase clusters are sharing a common rootDir, even > after flushing the data from > one cluster doesn't mean that other clusters (replicas) will automatically > pick the new HFile. Through this patch, > we are exposing the refresh HFiles API which when issued from a replica will > update the in-memory file handle list > with the newly added file. > This allows replicas to be consistent with the data written through the > primary cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18615) hbase-rest tests fail in hbase-2.0.0-alpha2
[ https://issues.apache.org/jira/browse/HBASE-18615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136102#comment-16136102 ] stack commented on HBASE-18615: --- +1 here? ([~apurtell] or [~asamir]? Thanks lads) > hbase-rest tests fail in hbase-2.0.0-alpha2 > --- > > Key: HBASE-18615 > URL: https://issues.apache.org/jira/browse/HBASE-18615 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-alpha-3 > > Attachments: 18615.2.txt, 18615.txt, 18615.v3.txt, > HBASE-18615.branch-2.001.patch, HBASE-18615.branch-2.002.patch > > > Pointed out by Andrew on VOTE mail for hbase-2.0.0-alpha2 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18448) Added support for refreshing HFiles through API and shell
[ https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Jadhav updated HBASE-18448: Attachment: HBASE-18448.master.001.patch > Added support for refreshing HFiles through API and shell > - > > Key: HBASE-18448 > URL: https://issues.apache.org/jira/browse/HBASE-18448 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0, 1.3.1 >Reporter: Ajay Jadhav >Assignee: Ajay Jadhav >Priority: Minor > Fix For: 1.4.0 > > Attachments: HBASE-18448.branch-1.001.patch, > HBASE-18448.branch-1.002.patch, HBASE-18448.branch-1.003.patch, > HBASE-18448.branch-1.004.patch, HBASE-18448.branch-1.005.patch, > HBASE-18448.branch-1.006.patch, HBASE-18448.master.001.patch > > > In the case where multiple HBase clusters are sharing a common rootDir, even > after flushing the data from > one cluster doesn't mean that other clusters (replicas) will automatically > pick the new HFile. Through this patch, > we are exposing the refresh HFiles API which when issued from a replica will > update the in-memory file handle list > with the newly added file. > This allows replicas to be consistent with the data written through the > primary cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16338) update jackson to 2.y
[ https://issues.apache.org/jira/browse/HBASE-16338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136098#comment-16136098 ] stack commented on HBASE-16338: --- Found out subsequently that 'register(Jackson1Feature.class);' means "Jersey should use jackson version 1 doing json serialization". Pulls in jersey v1 so is a problem if we want to go up to jersey 2. > update jackson to 2.y > - > > Key: HBASE-16338 > URL: https://issues.apache.org/jira/browse/HBASE-16338 > Project: HBase > Issue Type: Task > Components: dependencies >Reporter: Sean Busbey >Assignee: stack >Priority: Minor > Fix For: 2.0.0 > > Attachments: 16338.txt > > > Our jackson dependency is from ~3 years ago. Update to the jackson 2.y line, > using 2.7.0+. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17826) Backup: submitting M/R job to a particular Yarn queue
[
https://issues.apache.org/jira/browse/HBASE-17826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136092#comment-16136092
]
Vladimir Rodionov commented on HBASE-17826:
---
{quote}
Parameter 'q' should correspond to queueName.
{quote}
Yes, it does. We specify yarn queue name through *-q*
> Backup: submitting M/R job to a particular Yarn queue
> -
>
> Key: HBASE-17826
> URL: https://issues.apache.org/jira/browse/HBASE-17826
> Project: HBase
> Issue Type: Improvement
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-17826-v1.patch
>
>
> We need this to be configurable. Currently, all M/R jobs are submitted to a
> default queue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18508) [HLC] Fix timing out tests in HBASE-14070.HLC branch
[
https://issues.apache.org/jira/browse/HBASE-18508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136086#comment-16136086
]
Hadoop QA commented on HBASE-18508:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
31s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
23s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
44s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
33m 16s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 71m 3s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
39s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}126m 49s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure |
| | org.apache.hadoop.hbase.mapreduce.TestWALPlayer |
| | org.apache.hadoop.hbase.regionserver.TestRowTooBig |
| | org.apache.hadoop.hbase.regionserver.TestSplitLogWorker |
| | org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure |
| | org.apache.hadoop.hbase.mapreduce.TestTableInputFormat |
| | org.apache.hadoop.hbase.mapreduce.TestHRegionPartitioner |
| | org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence |
| | org.apache.hadoop.hbase.coprocessor.TestHTableWrapper |
| | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy
|
| | org.apache.hadoop.hbase.client.TestMultipleTimestamps |
| | org.apache.hadoop.hbase.client.TestAsyncReplicationAdminApi |
| | org.apache.hadoop.hbase.client.TestFromClientSide |
| | org.apache.hadoop.hbase.regionserver.wal.TestFSHLog |
| | org.apache.hadoop.hbase.regionserver.TestCompaction |
| | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
| | org.apache.hadoop.hbase.master.procedure.TestSafemodeBringsDownMaster |
[jira] [Updated] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
[ https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18640: -- Attachment: HBASE-18640.master.003.patch > Move mapreduce out of hbase-server into separate hbase-mapreduce moduel > --- > > Key: HBASE-18640 > URL: https://issues.apache.org/jira/browse/HBASE-18640 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-18640.master.001.patch, > HBASE-18640.master.002.patch, HBASE-18640.master.003.patch, > HBASE-18640.master.003.patch, HBASE-18640.master.004.patch > > > (Couldn't find another dedicated jira, so creating new one). > Uploaded patch which is moving ~60 files to the new module. Few notes: > - The classes remaining in hbase-server are the ones which are intensively > coupled with visibility labels/wal/filesystem/hfile. These can not be > migrated to new module until corresponding subcomponents are untangled out of > hbase-server into their own separate modules. > - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to > hbase-mapreduce module. Given these dependency constraints, one way would be > having a separate module for tests: > hbase-mapreduce < hbase-server <--- hbase-mapreduce-tests > Imo, this makes sense and looks fine. > The only issue is - yetus' pre-commit. It won't run tests in > hbase-mapreduce-tests module if something changed in just hbase-mapreduce. > However, yetus' limitation shouldn't warrant against the idea. > So i'd say that we should go that way, unless there are better suggestions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18103) [AMv2] If Master gives OPEN to another, if original eventually succeeds, Master will kill it
[ https://issues.apache.org/jira/browse/HBASE-18103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18103: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed to master and branch-2. Thanks for the patch [~uagashe] > [AMv2] If Master gives OPEN to another, if original eventually succeeds, > Master will kill it > > > Key: HBASE-18103 > URL: https://issues.apache.org/jira/browse/HBASE-18103 > Project: HBase > Issue Type: Sub-task > Components: master, proc-v2 >Reporter: stack >Assignee: Umesh Agashe >Priority: Critical > Fix For: 2.0.0 > > Attachments: hbase-18103.master.001.patch, > hbase-18103.master.001.patch > > > If a RS is slow to open a Region, the Master will give the Region to another > to open it (In this case, was a massive set of edits to process and a load of > StoreFiles to open...). Should the original RS succeed with its open > eventually, on reporting the master the successful open, the Master currently > kills the RS because the region is supposed to be elsewhere. > This is an easy fix. > The RS does not fully open a Region until Master gives it the go so just > close the region if master rejects the open > See '6.1.1 If Master gives Region to another to Open, old RS will be kill > itself on reject by Master; easy fix!' in > https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.qtfojp9774h -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18630) Prune dependencies; as is branch-2 has duplicates
[ https://issues.apache.org/jira/browse/HBASE-18630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18630: -- Status: Patch Available (was: Open) Purge doubled javax.inject and commons-beanutils that differ but slightly in their version numbers (other 'doubles' seem to be offset by different groupids so probably substantially different -- or the including artifact relys at the third-party at a particular position). > Prune dependencies; as is branch-2 has duplicates > - > > Key: HBASE-18630 > URL: https://issues.apache.org/jira/browse/HBASE-18630 > Project: HBase > Issue Type: Task > Components: dependencies >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18630.master.001.patch > > > Purge duplicate includes and try to prune back our dependencies (Suggestion > by [~elserj] up on the 2.0.0-alpha2 vote). Just looking at my current issue, > we have vestiges we include even though the root justification has passed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18630) Prune dependencies; as is branch-2 has duplicates
[ https://issues.apache.org/jira/browse/HBASE-18630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18630: -- Attachment: HBASE-18630.master.001.patch > Prune dependencies; as is branch-2 has duplicates > - > > Key: HBASE-18630 > URL: https://issues.apache.org/jira/browse/HBASE-18630 > Project: HBase > Issue Type: Task > Components: dependencies >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18630.master.001.patch > > > Purge duplicate includes and try to prune back our dependencies (Suggestion > by [~elserj] up on the 2.0.0-alpha2 vote). Just looking at my current issue, > we have vestiges we include even though the root justification has passed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18630) Prune dependencies; as is branch-2 has duplicates
[ https://issues.apache.org/jira/browse/HBASE-18630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136072#comment-16136072 ] stack commented on HBASE-18630: --- We have about 150 dependencies which is way too many! I went through them. Most come in via hadoop or spark. Hard to remove any of these transitive includes even old versions of jetty given we run unit tests that want YARN to work, etc. [~elserj] you said you saw duplicates? What were you thinking? I don't really see any. Attached patch gets rid of a few little ones but otherwise, i don't see them. > Prune dependencies; as is branch-2 has duplicates > - > > Key: HBASE-18630 > URL: https://issues.apache.org/jira/browse/HBASE-18630 > Project: HBase > Issue Type: Task > Components: dependencies >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-alpha-3 > > > Purge duplicate includes and try to prune back our dependencies (Suggestion > by [~elserj] up on the 2.0.0-alpha2 vote). Just looking at my current issue, > we have vestiges we include even though the root justification has passed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18103) [AMv2] If Master gives OPEN to another, if original eventually succeeds, Master will kill it
[
https://issues.apache.org/jira/browse/HBASE-18103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136055#comment-16136055
]
Hadoop QA commented on HBASE-18103:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
28m 40s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}110m
21s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}153m 32s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18103 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12882973/hbase-18103.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 9097bf787d73 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 7b3291f |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8207/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8207/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> [AMv2] If Master gives OPEN to another, if original eventually succeeds,
> Master will kill it
>
>
> Key: HBASE-18103
> URL: https://issues.apache.org/jira/browse/HBASE-18103
> Project: HBase
> Issue Type: Sub-task
> Components: master, proc-v2
>Reporter: stack
>Assignee:
[jira] [Commented] (HBASE-18644) Duplicate "compactionQueueLength" metric in Region Server metrics
[
https://issues.apache.org/jira/browse/HBASE-18644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136057#comment-16136057
]
Andrew Purtell commented on HBASE-18644:
+1
Thanks for the patch [~sukuna...@gmail.com]. I will commit this change shortly
to the relevant branches.
> Duplicate "compactionQueueLength" metric in Region Server metrics
> -
>
> Key: HBASE-18644
> URL: https://issues.apache.org/jira/browse/HBASE-18644
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 1.3.1
>Reporter: Maddineni Sukumar
>Assignee: Maddineni Sukumar
>Priority: Minor
> Fix For: 1.3.2
>
> Attachments: HBASE-18644-branch-1.3.patch
>
>
> Region Server JMX response has duplicate entries for "compactionQueueLength"
> "compactionQueueLength" : 0,
> "smallCompactionQueueLength" : 0,
> "largeCompactionQueueLength" : 0,
> "compactionQueueLength" : 0,
> "flushQueueLength" : 0
> We added "compactionQueueLength" metric twice in
> MetricsRegionServerSourceImpl.java
> {code:title=MetricsRegionServerSourceImpl.java|borderStyle=solid}
> .addGauge(Interns.info(COMPACTION_QUEUE_LENGTH, COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getCompactionQueueSize())
> .addGauge(Interns.info(SMALL_COMPACTION_QUEUE_LENGTH,
> SMALL_COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getSmallCompactionQueueSize())
> .addGauge(Interns.info(LARGE_COMPACTION_QUEUE_LENGTH,
> LARGE_COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getLargeCompactionQueueSize())
> .addGauge(Interns.info(COMPACTION_QUEUE_LENGTH,
> COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getCompactionQueueSize())
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18644) Duplicate "compactionQueueLength" metric in Region Server metrics
[
https://issues.apache.org/jira/browse/HBASE-18644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maddineni Sukumar updated HBASE-18644:
--
Fix Version/s: 1.3.2
> Duplicate "compactionQueueLength" metric in Region Server metrics
> -
>
> Key: HBASE-18644
> URL: https://issues.apache.org/jira/browse/HBASE-18644
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 1.3.1
>Reporter: Maddineni Sukumar
>Assignee: Maddineni Sukumar
>Priority: Minor
> Fix For: 1.3.2
>
> Attachments: HBASE-18644-branch-1.3.patch
>
>
> Region Server JMX response has duplicate entries for "compactionQueueLength"
> "compactionQueueLength" : 0,
> "smallCompactionQueueLength" : 0,
> "largeCompactionQueueLength" : 0,
> "compactionQueueLength" : 0,
> "flushQueueLength" : 0
> We added "compactionQueueLength" metric twice in
> MetricsRegionServerSourceImpl.java
> {code:title=MetricsRegionServerSourceImpl.java|borderStyle=solid}
> .addGauge(Interns.info(COMPACTION_QUEUE_LENGTH, COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getCompactionQueueSize())
> .addGauge(Interns.info(SMALL_COMPACTION_QUEUE_LENGTH,
> SMALL_COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getSmallCompactionQueueSize())
> .addGauge(Interns.info(LARGE_COMPACTION_QUEUE_LENGTH,
> LARGE_COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getLargeCompactionQueueSize())
> .addGauge(Interns.info(COMPACTION_QUEUE_LENGTH,
> COMPACTION_QUEUE_LENGTH_DESC),
> rsWrap.getCompactionQueueSize())
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
