[jira] [Commented] (HBASE-19227) Nightly jobs should archive JVM dumpstream files
[
https://issues.apache.org/jira/browse/HBASE-19227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247153#comment-16247153
]
Hudson commented on HBASE-19227:
SUCCESS: Integrated in Jenkins build HBase-1.1-JDK7 #1941 (See
[https://builds.apache.org/job/HBase-1.1-JDK7/1941/])
HBASE-19227 Nightly job should archive JVM dumpstream files. (busbey: rev
f1e97d38bff7fc778ce7a247e91e9f9fac29f6c5)
* (edit) dev-support/Jenkinsfile
> Nightly jobs should archive JVM dumpstream files
>
>
> Key: HBASE-19227
> URL: https://issues.apache.org/jira/browse/HBASE-19227
> Project: HBase
> Issue Type: Improvement
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 2.0.0, 3.0.0, 1.0.4, 1.2.7, 1.1.13
>
> Attachments: HBASE-19227.0.patch, HBASE-19227.1.patch
>
>
> came up on dev@ discussion about some of our current nightly test failures.
> when surefire fails to launch a test JVM instance, the details go into a file
> that we currently don't archive:
> {quote}
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> {quote}
> Add them to the default archive pattern.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19164) Avoid UUID.randomUUID in tests
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sahil Aggarwal updated HBASE-19164:
---
Status: Patch Available (was: Open)
> Avoid UUID.randomUUID in tests
> --
>
> Key: HBASE-19164
> URL: https://issues.apache.org/jira/browse/HBASE-19164
> Project: HBase
> Issue Type: Improvement
> Components: test
>Reporter: Mike Drob
>Assignee: Sahil Aggarwal
> Labels: beginner
> Attachments: HBASE-19164.master.001.patch,
> HBASE-19164.master.002.patch, HBASE-19164.master.003.patch
>
>
> We have a lot of places in our test code where we use {{UUID.randomUUID}} to
> generate table names or paths for uniqueness. Unfortunately, this uses up a
> good chunk of system entropy, since Sun chose that random UUID's should use
> the NativePRNGBlocking implementation.
> We don't need to block on entropy for random bits to pick a random table name
> in a test, so we can use something that doesn't strain the system too much -
> secure random can be a source of problems on some VM or containers.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19164) Avoid UUID.randomUUID in tests
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sahil Aggarwal updated HBASE-19164:
---
Status: Open (was: Patch Available)
> Avoid UUID.randomUUID in tests
> --
>
> Key: HBASE-19164
> URL: https://issues.apache.org/jira/browse/HBASE-19164
> Project: HBase
> Issue Type: Improvement
> Components: test
>Reporter: Mike Drob
>Assignee: Sahil Aggarwal
> Labels: beginner
> Attachments: HBASE-19164.master.001.patch,
> HBASE-19164.master.002.patch, HBASE-19164.master.003.patch
>
>
> We have a lot of places in our test code where we use {{UUID.randomUUID}} to
> generate table names or paths for uniqueness. Unfortunately, this uses up a
> good chunk of system entropy, since Sun chose that random UUID's should use
> the NativePRNGBlocking implementation.
> We don't need to block on entropy for random bits to pick a random table name
> in a test, so we can use something that doesn't strain the system too much -
> secure random can be a source of problems on some VM or containers.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-19146) Hbase3.0 protobuf-maven-plugin do not support Arm64(only for x86)
[
https://issues.apache.org/jira/browse/HBASE-19146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247024#comment-16247024
]
Yuqi Gu edited comment on HBASE-19146 at 11/10/17 8:17 AM:
---
stack- Yes, protoc 3.5.0 that we need is not released yet.
Could you please upgrade protoc version to 3.5.0 that is used for
hbase-protocol-shaded when google release it?
It is noted that protoc-2.5.0 is also used for external version in hbase.
But Google guys are not able to modify the already closed/published maven
repos.(https://github.com/google/protobuf/issues/3844#issuecomment-343355946).
So they can not published aarch64-linux protoc-2.5.0 to maven central.
They will make a 2.5.1 minor release for this issue.
How do you like to upgrade Protoc-2.5.0 to 2.5.1?
Thanks!
was (Author: yqgu):
stack- Yes, protoc 3.5.0 that we need is not released yet.
Could you please upgrade protoc version to 3.5.0 that is used for
hbase-protocol-shaded when google release it?
It is noted that protoc-2.5.0 is also used for external version in hbase.
But Google guys are not able to modify the already closed/published maven
repos.(https://github.com/google/protobuf/issues/3844#issuecomment-343355946).
So they can not published aarch64-linux protoc-2.5.0 to maven central.
Would you like to tell us why hbase do not upgrade Protoc-2.5.0 to 2.5.1?
Thanks!
> Hbase3.0 protobuf-maven-plugin do not support Arm64(only for x86)
> --
>
> Key: HBASE-19146
> URL: https://issues.apache.org/jira/browse/HBASE-19146
> Project: HBase
> Issue Type: Bug
> Components: build, pom
>Affects Versions: 3.0.0
> Environment: OS: Ubuntu 16.04.3
> OpenJDK Runtime Environment (build 1.8.0_131-8u131-b11-2ubuntu1.16.04.3-b11)
> Hw platform: AARCH64
>Reporter: Yuqi Gu
>
> We are building the HBase 3.0.0-SNAPSHOT on AARCH64.
> It is noted that 'protobuf-maven-plugin' only support x86 shown as follows:
> {code:java}
>
>org.xolstice.maven.plugins
>protobuf-maven-plugin
>${protobuf.plugin.version}
>
> com.google.protobuf:protoc:${external.protobuf.version}:
> exe:${os.detected.classifier}
>
> com.google.protobuf:protoc:${external.protobuf.version}:exe:${os.detected.classifier}
>
>false
>true
>
>
> {code}
> So the build is failed.
> {code:java}
> [INFO] --- protobuf-maven-plugin:0.5.0:compile (compile-protoc) @
> hbase-protocol-shaded ---
> [INFO] Compiling 32 proto file(s) to
> /root/hbase/hbase-protocol-shaded/target/generated-sources/protobuf/java
> Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.5.0:compile
> (compile-protoc) on project hbase-protocol-shaded: Missing:
> {code}
> Then I installed aarch64 protobuf 2.5.0 on the host and modify the pom:
> {code:java}
> - ${basedir}/src/main/protobuf/
> + /usr/local/bin/protoc
> {code}
> The build is also failed:
> {code:java}
> [INFO] Compiling 32 proto file(s) to
> /root/hbase/hbase-protocol-shaded/target/generated-sources/protobuf/java
> [ERROR] PROTOC FAILED: google/protobuf/any.proto:31:10: Unrecognized syntax
> identifier "proto3". This parser only recognizes "proto2".
> {code}
> It seems that "internal.protobuf.version" in "hbase-protocol-shaded" is 3.3.0.
> How to fix it? Thanks!
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19227) Nightly jobs should archive JVM dumpstream files
[
https://issues.apache.org/jira/browse/HBASE-19227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247179#comment-16247179
]
Hudson commented on HBASE-19227:
FAILURE: Integrated in Jenkins build HBase-1.4 #1009 (See
[https://builds.apache.org/job/HBase-1.4/1009/])
HBASE-19227 Nightly job should archive JVM dumpstream files. (busbey: rev
6650a3ef8b33c3ddb3ea41ed952143ac25505f91)
* (edit) dev-support/Jenkinsfile
> Nightly jobs should archive JVM dumpstream files
>
>
> Key: HBASE-19227
> URL: https://issues.apache.org/jira/browse/HBASE-19227
> Project: HBase
> Issue Type: Improvement
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 2.0.0, 3.0.0, 1.0.4, 1.2.7, 1.1.13
>
> Attachments: HBASE-19227.0.patch, HBASE-19227.1.patch
>
>
> came up on dev@ discussion about some of our current nightly test failures.
> when surefire fails to launch a test JVM instance, the details go into a file
> that we currently don't archive:
> {quote}
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> {quote}
> Add them to the default archive pattern.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs
[
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247182#comment-16247182
]
Hadoop QA commented on HBASE-19235:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
3s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
45s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
64m 20s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
8s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 84m 55s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19235 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897022/HBASE-19235.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 27240e75313d 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 35a1e43348 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9730/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9730/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> CoprocessorEnvironment should be exposed to CPs
[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs
[ https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247183#comment-16247183 ] Appy commented on HBASE-19235: -- CPHosts use CPEnv to load and manage CP instances. The functions startup(), shutdown(), loadSequence(), getPriority(), getInstance, etc are all related to management of a loaded Coprocessor. No observer needs them. Also we'll want to freely add/remove functions here. bq. Its sub interfaces are exposed with LimitedPrivate(HBaseInterfaceAudience.COPROC). So ideally all the functions in this are. Is this how our audience annotations are interpreted? To me, i always saw it like, IA.Foo on a class/interface is for that class/interface only, it doesn't translate to parent. In fact in this case, we have explicitly marked CPEnv as Private, so there shouldn't be any confusion? > CoprocessorEnvironment should be exposed to CPs > --- > > Key: HBASE-19235 > URL: https://issues.apache.org/jira/browse/HBASE-19235 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Affects Versions: 2.0.0-alpha-4 >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Minor > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19235.patch > > > Its sub interfaces are exposed with > LimitedPrivate(HBaseInterfaceAudience.COPROC). So ideally all the functions > in this are. Better we mark CoprocessorEnvironment also as CP exposed to > avoid confusion. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18978) Align the methods in Table and AsyncTable
[ https://issues.apache.org/jira/browse/HBASE-18978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247199#comment-16247199 ] Appy commented on HBASE-18978: -- Sorry for confusion. bq. So i guess this won't be happening anymore? (from the linked comment) There i was just saying that comment seems outdated because the two interfaces are quite different now. So let's delete it. Now am actually trying to understand what made us split into two interfaces. And if you think it's possible to merge them? And if we can't do that, then I want to at least understand the gist of it and add a few lines to those class comments, mainly so that anyone adding functions in future know how to choose the right place. :) > Align the methods in Table and AsyncTable > - > > Key: HBASE-18978 > URL: https://issues.apache.org/jira/browse/HBASE-18978 > Project: HBase > Issue Type: Task > Components: asyncclient, Client >Reporter: Duo Zhang >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0-beta-1 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18309) Support multi threads in CleanerChore
[ https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247212#comment-16247212 ] Yu Li commented on HBASE-18309: --- bq. New simulation first creates 10 dirs under oldWALs... Thanks for the additional testing, I think the screenshot I pasted could further explain why we need the sorting. bq. Do you think it is ok to borrow the idea of HFileCleaner? Or a general way would work? I think we don't need to separate large/small threads for wals since their rolling size is unified, a general multi-thread way would work. And good to know the progress, good job [~reidchan]. > Support multi threads in CleanerChore > - > > Key: HBASE-18309 > URL: https://issues.apache.org/jira/browse/HBASE-18309 > Project: HBase > Issue Type: Improvement > Components: wal >Reporter: binlijin >Assignee: Reid Chan > Attachments: HBASE-18309.master.001.patch, > HBASE-18309.master.002.patch, space_consumption_in_archive.png > > > There is only one thread in LogCleaner to clean oldWALs and in our big > cluster we find this is not enough. The number of files under oldWALs reach > the max-directory-items limit of HDFS and cause region server crash, so we > use multi threads for LogCleaner and the crash not happened any more. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19227) Nightly jobs should archive JVM dumpstream files
[
https://issues.apache.org/jira/browse/HBASE-19227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247203#comment-16247203
]
Hudson commented on HBASE-19227:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4029 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/4029/])
HBASE-19227 Nightly job should archive JVM dumpstream files. (busbey: rev
35a1e43348e93d48e60274397e38271df38a25c1)
* (edit) dev-support/Jenkinsfile
> Nightly jobs should archive JVM dumpstream files
>
>
> Key: HBASE-19227
> URL: https://issues.apache.org/jira/browse/HBASE-19227
> Project: HBase
> Issue Type: Improvement
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 2.0.0, 3.0.0, 1.0.4, 1.2.7, 1.1.13
>
> Attachments: HBASE-19227.0.patch, HBASE-19227.1.patch
>
>
> came up on dev@ discussion about some of our current nightly test failures.
> when surefire fails to launch a test JVM instance, the details go into a file
> that we currently don't archive:
> {quote}
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> {quote}
> Add them to the default archive pattern.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs
[ https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247230#comment-16247230 ] Anoop Sam John commented on HBASE-19235: >From ObserverContext the CP user get RegionCPEnv. This is marked LP for CP and >any functions available there can be used . That is what we say. So all >functions from super type is already exposed right? Checking other CP >exposed interfaces, I see we have their super type also as LP not private. We >should some way clean this. Discussed with Stack offline. We both felt its ok >to expose.. We have some getters which might not be really needed for CPs >but harmless to expose. Start and Shutdown are some thing which should not be >used by CP users. Start() even if called it is a noop in impl. Shutdown ya... Checking some old code base, we did not have these start and shutdown over in CoprocessorEnvironment. Seems some recent jira added this.. Why? We can even avoid. Ya I see this startup was there in CPHost . > CoprocessorEnvironment should be exposed to CPs > --- > > Key: HBASE-19235 > URL: https://issues.apache.org/jira/browse/HBASE-19235 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Affects Versions: 2.0.0-alpha-4 >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Minor > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19235.patch > > > Its sub interfaces are exposed with > LimitedPrivate(HBaseInterfaceAudience.COPROC). So ideally all the functions > in this are. Better we mark CoprocessorEnvironment also as CP exposed to > avoid confusion. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19226) Limit the reduce tasks number of incremental load
[ https://issues.apache.org/jira/browse/HBASE-19226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247267#comment-16247267 ] Reid Chan commented on HBASE-19226: --- I suppose it is a duplicate of HBASE-17130, do you have interest in providing a patch? [~Yun Zhao] > Limit the reduce tasks number of incremental load > - > > Key: HBASE-19226 > URL: https://issues.apache.org/jira/browse/HBASE-19226 > Project: HBase > Issue Type: Improvement >Reporter: Yun Zhao >Priority: Minor > > When using MapReduce job to perform an incremental load into a table,the > number of reduce tasks is the current number of regions. If there are too > many regions, will lead to network+disk I/O is too large, affecting the > real-time request. > Need to use a configuration to set a number or ratio? > Limit running reduce tasks since > [https://issues.apache.org/jira/browse/MAPREDUCE-5583], the old version can > only be set reduce number. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19164) Avoid UUID.randomUUID in tests
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247269#comment-16247269
]
Hadoop QA commented on HBASE-19164:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 4m
25s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 30 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
42s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 8m
39s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
55s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
50s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
29s{color} | {color:red} hbase-common: The patch generated 1 new + 14 unchanged
- 0 fixed = 15 total (was 14) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
12s{color} | {color:red} hbase-hadoop-compat: The patch generated 1 new + 0
unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
18s{color} | {color:red} hbase-server: The patch generated 12 new + 593
unchanged - 4 fixed = 605 total (was 597) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
20s{color} | {color:red} hbase-mapreduce: The patch generated 1 new + 61
unchanged - 0 fixed = 62 total (was 61) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 907 line(s) that end in whitespace. Use
git apply --whitespace=fix <>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
22s{color} | {color:red} The patch 768 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
15s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
62m 5s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
20s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
23s{color} | {color:green} hbase-hadoop-compat in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}127m 34s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 16m
54s{color} | {color:green} hbase
[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs
[
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247278#comment-16247278
]
Anoop Sam John commented on HBASE-19235:
I see now.. The startup and shutdown were there in Environment only(Now
BaseEnv) . All 4 types of CPEnv impls are sub types of BaseEnv. Previously
we were doing type casting and call these 2 methods.
{code}
if (env instanceof Environment) {
((Environment)env).startup();
}
if (e instanceof Environment) {
if (LOG.isDebugEnabled()) {
LOG.debug("Stop coprocessor " + e.getInstance().getClass().getName());
}
((Environment)e).shutdown();
}
{code}
I think we can continue this way. Its ok and so avoid these 2 APIs being
exposed to CPs
> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch
>
>
> Its sub interfaces are exposed with
> LimitedPrivate(HBaseInterfaceAudience.COPROC). So ideally all the functions
> in this are. Better we mark CoprocessorEnvironment also as CP exposed to
> avoid confusion.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19226) Limit the reduce tasks number of incremental load
[ https://issues.apache.org/jira/browse/HBASE-19226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247306#comment-16247306 ] Yun Zhao commented on HBASE-19226: -- [~reidchan] I am going to provide a patch later :D > Limit the reduce tasks number of incremental load > - > > Key: HBASE-19226 > URL: https://issues.apache.org/jira/browse/HBASE-19226 > Project: HBase > Issue Type: Improvement >Reporter: Yun Zhao >Priority: Minor > > When using MapReduce job to perform an incremental load into a table,the > number of reduce tasks is the current number of regions. If there are too > many regions, will lead to network+disk I/O is too large, affecting the > real-time request. > Need to use a configuration to set a number or ratio? > Limit running reduce tasks since > [https://issues.apache.org/jira/browse/MAPREDUCE-5583], the old version can > only be set reduce number. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19227) Nightly jobs should archive JVM dumpstream files
[
https://issues.apache.org/jira/browse/HBASE-19227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247331#comment-16247331
]
Hudson commented on HBASE-19227:
FAILURE: Integrated in Jenkins build HBase-2.0 #829 (See
[https://builds.apache.org/job/HBase-2.0/829/])
HBASE-19227 Nightly job should archive JVM dumpstream files. (busbey: rev
d757e651c98e0f23c020ebf8f319776a33ff1fdf)
* (edit) dev-support/Jenkinsfile
> Nightly jobs should archive JVM dumpstream files
>
>
> Key: HBASE-19227
> URL: https://issues.apache.org/jira/browse/HBASE-19227
> Project: HBase
> Issue Type: Improvement
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 2.0.0, 3.0.0, 1.0.4, 1.2.7, 1.1.13
>
> Attachments: HBASE-19227.0.patch, HBASE-19227.1.patch
>
>
> came up on dev@ discussion about some of our current nightly test failures.
> when surefire fails to launch a test JVM instance, the details go into a file
> that we currently don't archive:
> {quote}
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> {quote}
> Add them to the default archive pattern.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19009) implement modifyTable and enable/disableTableReplication for AsyncAdmin
[ https://issues.apache.org/jira/browse/HBASE-19009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19009: --- Attachment: HBASE-19009.master.008.patch > implement modifyTable and enable/disableTableReplication for AsyncAdmin > --- > > Key: HBASE-19009 > URL: https://issues.apache.org/jira/browse/HBASE-19009 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-19009.master.001.patch, > HBASE-19009.master.002.patch, HBASE-19009.master.003.patch, > HBASE-19009.master.004.patch, HBASE-19009.master.005.patch, > HBASE-19009.master.006.patch, HBASE-19009.master.007.patch, > HBASE-19009.master.008.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19200) make hbase-client only depend on ZKAsyncRegistry and ZNodePaths
[ https://issues.apache.org/jira/browse/HBASE-19200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247446#comment-16247446 ] Duo Zhang commented on HBASE-19200: --- Good. We finally have the failed UTs in the report. Let me check. > make hbase-client only depend on ZKAsyncRegistry and ZNodePaths > --- > > Key: HBASE-19200 > URL: https://issues.apache.org/jira/browse/HBASE-19200 > Project: HBase > Issue Type: Task > Components: Client, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19200-v1.patch, HBASE-19200-v2.patch, > HBASE-19200-v3.patch, HBASE-19200-v4.patch, HBASE-19200.patch > > > So that we can move most of the zookeeper related code out of hbase-client > module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16459) Remove unused hbase shell --format option
[
https://issues.apache.org/jira/browse/HBASE-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247486#comment-16247486
]
Hudson commented on HBASE-16459:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4030 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/4030/])
HBASE-16459 Remove unused hbase shell --format option (appy: rev
31234eb862fdd7ee4917a2f74001182565ffbfd9)
* (edit) bin/hirb.rb
> Remove unused hbase shell --format option
> -
>
> Key: HBASE-16459
> URL: https://issues.apache.org/jira/browse/HBASE-16459
> Project: HBase
> Issue Type: Task
> Components: shell
>Reporter: Dima Spivak
>Assignee: Dima Spivak
>Priority: Trivial
> Labels: beginner
> Attachments: HBASE-16459.master.001.patch, HBASE-16459.patch,
> HBASE-16459_v2.patch
>
>
> The usage information when running {{hbase shell}} refers to a formatter
> option that has yet to implemented in over 8 years and which will ostensibly
> never be implemented. As such, let's cleanup the [help
> message|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L57-L59] and
> remove some extraneous lines of code from
> {{[hirb.rb|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L74-L83]}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19223) Remove references to Date Tiered compaction from branch-1.2 and branch-1.1 ref guide
[ https://issues.apache.org/jira/browse/HBASE-19223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247503#comment-16247503 ] Sean Busbey commented on HBASE-19223: - how about I add a note in the upgrade section for folks coming from 0.98.19+ to 1.y releases? > Remove references to Date Tiered compaction from branch-1.2 and branch-1.1 > ref guide > > > Key: HBASE-19223 > URL: https://issues.apache.org/jira/browse/HBASE-19223 > Project: HBase > Issue Type: Bug > Components: Compaction, documentation >Affects Versions: 1.1.5, 1.2.2 >Reporter: chilianyi >Assignee: Sean Busbey >Priority: Critical > Fix For: 1.2.7, 1.1.13 > > Attachments: HBASE-19223-branch-1.2.v0.patch > > > I have download hbase 1.2.6 src package. But not found class > DateTieredStoreEngine, which is present in document: > https://hbase.apache.org/1.2/book.html. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19223) Remove references to Date Tiered compaction from branch-1.2 and branch-1.1 ref guide
[ https://issues.apache.org/jira/browse/HBASE-19223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247512#comment-16247512 ] Yu Li commented on HBASE-19223: --- bq. how about I add a note in the upgrade section for folks coming from 0.98.19+ to 1.y releases? Good idea, thanks. > Remove references to Date Tiered compaction from branch-1.2 and branch-1.1 > ref guide > > > Key: HBASE-19223 > URL: https://issues.apache.org/jira/browse/HBASE-19223 > Project: HBase > Issue Type: Bug > Components: Compaction, documentation >Affects Versions: 1.1.5, 1.2.2 >Reporter: chilianyi >Assignee: Sean Busbey >Priority: Critical > Fix For: 1.2.7, 1.1.13 > > Attachments: HBASE-19223-branch-1.2.v0.patch > > > I have download hbase 1.2.6 src package. But not found class > DateTieredStoreEngine, which is present in document: > https://hbase.apache.org/1.2/book.html. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19009) implement modifyTable and enable/disableTableReplication for AsyncAdmin
[ https://issues.apache.org/jira/browse/HBASE-19009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19009: --- Description: Add 3 methods to AsyncAdmin. modifyTable() enableTableReplication() disableTableReplication() > implement modifyTable and enable/disableTableReplication for AsyncAdmin > --- > > Key: HBASE-19009 > URL: https://issues.apache.org/jira/browse/HBASE-19009 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-19009.master.001.patch, > HBASE-19009.master.002.patch, HBASE-19009.master.003.patch, > HBASE-19009.master.004.patch, HBASE-19009.master.005.patch, > HBASE-19009.master.006.patch, HBASE-19009.master.007.patch, > HBASE-19009.master.008.patch > > > Add 3 methods to AsyncAdmin. > modifyTable() > enableTableReplication() > disableTableReplication() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19200) make hbase-client only depend on ZKAsyncRegistry and ZNodePaths
[ https://issues.apache.org/jira/browse/HBASE-19200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19200: -- Attachment: HBASE-19200-v5.patch Fix failing UTs. Curator have a default connection timeout at 15s, so we set the zk port to 1 in replication tests it will retry for a very long time and cause the tests timeout. > make hbase-client only depend on ZKAsyncRegistry and ZNodePaths > --- > > Key: HBASE-19200 > URL: https://issues.apache.org/jira/browse/HBASE-19200 > Project: HBase > Issue Type: Task > Components: Client, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19200-v1.patch, HBASE-19200-v2.patch, > HBASE-19200-v3.patch, HBASE-19200-v4.patch, HBASE-19200-v5.patch, > HBASE-19200.patch > > > So that we can move most of the zookeeper related code out of hbase-client > module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19009) implement modifyTable and enable/disableTableReplication for AsyncAdmin
[
https://issues.apache.org/jira/browse/HBASE-19009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247544#comment-16247544
]
Hadoop QA commented on HBASE-19009:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 6 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
26s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
41s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
27s{color} | {color:red} hbase-client: The patch generated 3 new + 468
unchanged - 5 fixed = 471 total (was 473) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
9s{color} | {color:red} hbase-replication: The patch generated 2 new + 11
unchanged - 2 fixed = 13 total (was 13) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
53s{color} | {color:red} hbase-server: The patch generated 5 new + 51 unchanged
- 7 fixed = 56 total (was 58) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
8s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
48m 35s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
51s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
13s{color} | {color:green} hbase-replication in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 99m 7s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
37s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}176m 41s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19009 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897061/HBASE-19009.master.008.patch
|
| Optional
[jira] [Updated] (HBASE-19226) Limit the reduce tasks number of incremental load
[ https://issues.apache.org/jira/browse/HBASE-19226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Zhao updated HBASE-19226: - Attachment: HBASE-19226.master.001.patch > Limit the reduce tasks number of incremental load > - > > Key: HBASE-19226 > URL: https://issues.apache.org/jira/browse/HBASE-19226 > Project: HBase > Issue Type: Improvement >Reporter: Yun Zhao >Priority: Minor > Attachments: HBASE-19226.master.001.patch > > > When using MapReduce job to perform an incremental load into a table,the > number of reduce tasks is the current number of regions. If there are too > many regions, will lead to network+disk I/O is too large, affecting the > real-time request. > Need to use a configuration to set a number or ratio? > Limit running reduce tasks since > [https://issues.apache.org/jira/browse/MAPREDUCE-5583], the old version can > only be set reduce number. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19226) Limit the reduce tasks number of incremental load
[ https://issues.apache.org/jira/browse/HBASE-19226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Zhao updated HBASE-19226: - Assignee: Yun Zhao Status: Patch Available (was: Open) > Limit the reduce tasks number of incremental load > - > > Key: HBASE-19226 > URL: https://issues.apache.org/jira/browse/HBASE-19226 > Project: HBase > Issue Type: Improvement >Reporter: Yun Zhao >Assignee: Yun Zhao >Priority: Minor > Attachments: HBASE-19226.master.001.patch > > > When using MapReduce job to perform an incremental load into a table,the > number of reduce tasks is the current number of regions. If there are too > many regions, will lead to network+disk I/O is too large, affecting the > real-time request. > Need to use a configuration to set a number or ratio? > Limit running reduce tasks since > [https://issues.apache.org/jira/browse/MAPREDUCE-5583], the old version can > only be set reduce number. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19226) Limit the reduce tasks number of incremental load
[
https://issues.apache.org/jira/browse/HBASE-19226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247739#comment-16247739
]
Ted Yu commented on HBASE-19226:
{code}
+ static final String OUTPUT_REDUCES_RATIO_CONF_KEY =
+ "hbase.mapreduce.hfileoutputformat.reduces.ratio";
{code}
Add javadoc for the purpose of the config key.
{code}
530 double ratio = conf.getDouble(OUTPUT_REDUCES_RATIO_CONF_KEY,
DEFAULT_OUTPUT_REDUCES_RATIO);
{code}
You can log WARN if the ratio is greater than 1.
> Limit the reduce tasks number of incremental load
> -
>
> Key: HBASE-19226
> URL: https://issues.apache.org/jira/browse/HBASE-19226
> Project: HBase
> Issue Type: Improvement
>Reporter: Yun Zhao
>Assignee: Yun Zhao
>Priority: Minor
> Attachments: HBASE-19226.master.001.patch
>
>
> When using MapReduce job to perform an incremental load into a table,the
> number of reduce tasks is the current number of regions. If there are too
> many regions, will lead to network+disk I/O is too large, affecting the
> real-time request.
> Need to use a configuration to set a number or ratio?
> Limit running reduce tasks since
> [https://issues.apache.org/jira/browse/MAPREDUCE-5583], the old version can
> only be set reduce number.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-12091) Optionally ignore edits for dropped tables for replication.
[ https://issues.apache.org/jira/browse/HBASE-12091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247773#comment-16247773 ] Lars Hofhansl commented on HBASE-12091: --- And thanks for the review [~apurtell]. I think with the change to control the throwing and contents of the TableNotFoundException in the sink, together with the tests, this is pretty solid. Will think on the timing for the tests a bit more and then commit on branch-1, branch-2, and master. > Optionally ignore edits for dropped tables for replication. > --- > > Key: HBASE-12091 > URL: https://issues.apache.org/jira/browse/HBASE-12091 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Fix For: 2.0.0, 3.0.0, 1.4.1, 1.5.0 > > Attachments: 12091-branch-2.patch, 12091-v2-branch-1.txt, > 12091-v3-branch-1.txt, 12091-v4-branch-1.txt, 12091-v5-branch-1.txt, > 12091-v6-branch-1.txt, 12091-v7-branch-1.txt, 12091-v7-master.txt, > 12091-v8-master.txt, 12091.txt > > > We just ran into a scenario where we dropped a table from both the source and > the sink, but the source still has outstanding edits that now it could not > get rid of. Now all replication is backed up behind these unreplicatable > edits. > We should have an option to ignore edits for tables dropped at the source. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19187) Remove option to create on heap bucket cache
[ https://issues.apache.org/jira/browse/HBASE-19187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247775#comment-16247775 ] Ted Yu commented on HBASE-19187: QA run didn't continue: https://builds.apache.org/job/PreCommit-HBASE-Build/9726/console Triggering another run. > Remove option to create on heap bucket cache > > > Key: HBASE-19187 > URL: https://issues.apache.org/jira/browse/HBASE-19187 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 2.0.0-alpha-3 >Reporter: Biju Nair >Assignee: Anoop Sam John >Priority: Minor > Fix For: 2.1.0 > > Attachments: HBASE-19187.patch, HBASE-19187_V2.patch > > > Since we are moving read and write paths to use direct memory, option to > configure on heap bucket cache is irrelevant. We should remove that option. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18963) Remove MultiRowMutationProcessor and implement mutateRows... methods using batchMutate()
[ https://issues.apache.org/jira/browse/HBASE-18963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Umesh Agashe updated HBASE-18963: - Status: Patch Available (was: In Progress) > Remove MultiRowMutationProcessor and implement mutateRows... methods using > batchMutate() > > > Key: HBASE-18963 > URL: https://issues.apache.org/jira/browse/HBASE-18963 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Affects Versions: 2.0.0-alpha-3 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0-beta-1 > > Attachments: hbase-18963.master.001.patch > > > Remove MultiRowMutationProcessor and implement mutateRows... methods using > batchMutate() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18963) Remove MultiRowMutationProcessor and implement mutateRows... methods using batchMutate()
[ https://issues.apache.org/jira/browse/HBASE-18963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Umesh Agashe updated HBASE-18963: - Attachment: hbase-18963.master.001.patch This unifies the 2 write paths batchMutate() and mutateRows(). > Remove MultiRowMutationProcessor and implement mutateRows... methods using > batchMutate() > > > Key: HBASE-18963 > URL: https://issues.apache.org/jira/browse/HBASE-18963 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Affects Versions: 2.0.0-alpha-3 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0-beta-1 > > Attachments: hbase-18963.master.001.patch > > > Remove MultiRowMutationProcessor and implement mutateRows... methods using > batchMutate() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Work started] (HBASE-18964) Deprecate RowProcessor and processRowsWithLocks() APIs that take RowProcessor as an argument
[ https://issues.apache.org/jira/browse/HBASE-18964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-18964 started by Umesh Agashe. > Deprecate RowProcessor and processRowsWithLocks() APIs that take RowProcessor > as an argument > > > Key: HBASE-18964 > URL: https://issues.apache.org/jira/browse/HBASE-18964 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Affects Versions: 2.0.0-alpha-3 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0-beta-1 > > > Deprecate RowProcessor and processRowsWithLocks() APIs that take RowProcessor > as an argument -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19200) make hbase-client only depend on ZKAsyncRegistry and ZNodePaths
[
https://issues.apache.org/jira/browse/HBASE-19200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247816#comment-16247816
]
Hadoop QA commented on HBASE-19200:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 23 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
7s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
13s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
25s{color} | {color:red} hbase-client: The patch generated 3 new + 339
unchanged - 30 fixed = 342 total (was 369) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
58s{color} | {color:red} hbase-server: The patch generated 1 new + 587
unchanged - 1 fixed = 588 total (was 588) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
5s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
44m 40s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
38s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
10s{color} | {color:green} hbase-replication in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}102m
26s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
4s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
26s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
57s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}175m 17s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19200 |
| JIRA Patch URL |
[jira] [Created] (HBASE-19237) TestMaster.testMasterOpsWhileSplitting fails
Ted Yu created HBASE-19237:
--
Summary: TestMaster.testMasterOpsWhileSplitting fails
Key: HBASE-19237
URL: https://issues.apache.org/jira/browse/HBASE-19237
Project: HBase
Issue Type: Test
Reporter: Ted Yu
This is the top flaky test:
{code}
java.lang.AssertionError: expected:<3> but was:<1>
at
org.apache.hadoop.hbase.master.TestMaster.testMasterOpsWhileSplitting(TestMaster.java:121)
{code}
After brief check, the test failure seems to be introduced by HBASE-19127
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-16459) Remove unused hbase shell --format option
[
https://issues.apache.org/jira/browse/HBASE-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Appy updated HBASE-16459:
-
Fix Version/s: 1.1.13
2.0.0-beta-1
1.2.7
1.5.0
1.3.2
1.4.0
> Remove unused hbase shell --format option
> -
>
> Key: HBASE-16459
> URL: https://issues.apache.org/jira/browse/HBASE-16459
> Project: HBase
> Issue Type: Task
> Components: shell
>Reporter: Dima Spivak
>Assignee: Dima Spivak
>Priority: Trivial
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-16459.master.001.patch, HBASE-16459.patch,
> HBASE-16459_v2.patch
>
>
> The usage information when running {{hbase shell}} refers to a formatter
> option that has yet to implemented in over 8 years and which will ostensibly
> never be implemented. As such, let's cleanup the [help
> message|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L57-L59] and
> remove some extraneous lines of code from
> {{[hirb.rb|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L74-L83]}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-16459) Remove unused hbase shell --format option
[
https://issues.apache.org/jira/browse/HBASE-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247848#comment-16247848
]
Appy commented on HBASE-16459:
--
Pushed all the way back to branch-1.1.
Thanks for reviews Stack and Dima.
> Remove unused hbase shell --format option
> -
>
> Key: HBASE-16459
> URL: https://issues.apache.org/jira/browse/HBASE-16459
> Project: HBase
> Issue Type: Task
> Components: shell
>Reporter: Dima Spivak
>Assignee: Dima Spivak
>Priority: Trivial
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-16459.master.001.patch, HBASE-16459.patch,
> HBASE-16459_v2.patch
>
>
> The usage information when running {{hbase shell}} refers to a formatter
> option that has yet to implemented in over 8 years and which will ostensibly
> never be implemented. As such, let's cleanup the [help
> message|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L57-L59] and
> remove some extraneous lines of code from
> {{[hirb.rb|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L74-L83]}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-16459) Remove unused hbase shell --format option
[
https://issues.apache.org/jira/browse/HBASE-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Appy updated HBASE-16459:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Remove unused hbase shell --format option
> -
>
> Key: HBASE-16459
> URL: https://issues.apache.org/jira/browse/HBASE-16459
> Project: HBase
> Issue Type: Task
> Components: shell
>Reporter: Dima Spivak
>Assignee: Dima Spivak
>Priority: Trivial
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-16459.master.001.patch, HBASE-16459.patch,
> HBASE-16459_v2.patch
>
>
> The usage information when running {{hbase shell}} refers to a formatter
> option that has yet to implemented in over 8 years and which will ostensibly
> never be implemented. As such, let's cleanup the [help
> message|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L57-L59] and
> remove some extraneous lines of code from
> {{[hirb.rb|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L74-L83]}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19200) make hbase-client only depend on ZKAsyncRegistry and ZNodePaths
[ https://issues.apache.org/jira/browse/HBASE-19200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247861#comment-16247861 ] Appy commented on HBASE-19200: -- It's 2am Duo's time. Let me commit it so that i can also start progressing HBASE-19114. I hope he won't mind. If he does - sorry, and you can have my desserts in next HBaseCon :) > make hbase-client only depend on ZKAsyncRegistry and ZNodePaths > --- > > Key: HBASE-19200 > URL: https://issues.apache.org/jira/browse/HBASE-19200 > Project: HBase > Issue Type: Task > Components: Client, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19200-v1.patch, HBASE-19200-v2.patch, > HBASE-19200-v3.patch, HBASE-19200-v4.patch, HBASE-19200-v5.patch, > HBASE-19200.patch > > > So that we can move most of the zookeeper related code out of hbase-client > module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19237) TestMaster.testMasterOpsWhileSplitting fails
[
https://issues.apache.org/jira/browse/HBASE-19237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-19237:
---
Attachment: 19237.v1.txt
> TestMaster.testMasterOpsWhileSplitting fails
>
>
> Key: HBASE-19237
> URL: https://issues.apache.org/jira/browse/HBASE-19237
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
> Attachments: 19237.v1.txt
>
>
> This is the top flaky test:
> {code}
> java.lang.AssertionError: expected:<3> but was:<1>
> at
> org.apache.hadoop.hbase.master.TestMaster.testMasterOpsWhileSplitting(TestMaster.java:121)
> {code}
> After brief check, the test failure seems to be introduced by HBASE-19127
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19200) make hbase-client only depend on ZKAsyncRegistry and ZNodePaths
[ https://issues.apache.org/jira/browse/HBASE-19200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247868#comment-16247868 ] Appy commented on HBASE-19200: -- Pushed to master and branch-2. Thanks for cleaning it up sooner just to unblock me [~Apache9]. > make hbase-client only depend on ZKAsyncRegistry and ZNodePaths > --- > > Key: HBASE-19200 > URL: https://issues.apache.org/jira/browse/HBASE-19200 > Project: HBase > Issue Type: Task > Components: Client, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19200-v1.patch, HBASE-19200-v2.patch, > HBASE-19200-v3.patch, HBASE-19200-v4.patch, HBASE-19200-v5.patch, > HBASE-19200.patch > > > So that we can move most of the zookeeper related code out of hbase-client > module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19237) TestMaster.testMasterOpsWhileSplitting fails
[
https://issues.apache.org/jira/browse/HBASE-19237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-19237:
---
Status: Patch Available (was: Open)
> TestMaster.testMasterOpsWhileSplitting fails
>
>
> Key: HBASE-19237
> URL: https://issues.apache.org/jira/browse/HBASE-19237
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
> Attachments: 19237.v1.txt
>
>
> This is the top flaky test:
> {code}
> java.lang.AssertionError: expected:<3> but was:<1>
> at
> org.apache.hadoop.hbase.master.TestMaster.testMasterOpsWhileSplitting(TestMaster.java:121)
> {code}
> After brief check, the test failure seems to be introduced by HBASE-19127
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19237) TestMaster.testMasterOpsWhileSplitting fails
[
https://issues.apache.org/jira/browse/HBASE-19237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247869#comment-16247869
]
Ted Yu commented on HBASE-19237:
[~easyliangjob]:
Can you take a look ?
> TestMaster.testMasterOpsWhileSplitting fails
>
>
> Key: HBASE-19237
> URL: https://issues.apache.org/jira/browse/HBASE-19237
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
> Attachments: 19237.v1.txt
>
>
> This is the top flaky test:
> {code}
> java.lang.AssertionError: expected:<3> but was:<1>
> at
> org.apache.hadoop.hbase.master.TestMaster.testMasterOpsWhileSplitting(TestMaster.java:121)
> {code}
> After brief check, the test failure seems to be introduced by HBASE-19127
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19200) make hbase-client only depend on ZKAsyncRegistry and ZNodePaths
[ https://issues.apache.org/jira/browse/HBASE-19200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19200: - Resolution: Fixed Status: Resolved (was: Patch Available) > make hbase-client only depend on ZKAsyncRegistry and ZNodePaths > --- > > Key: HBASE-19200 > URL: https://issues.apache.org/jira/browse/HBASE-19200 > Project: HBase > Issue Type: Task > Components: Client, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19200-v1.patch, HBASE-19200-v2.patch, > HBASE-19200-v3.patch, HBASE-19200-v4.patch, HBASE-19200-v5.patch, > HBASE-19200.patch > > > So that we can move most of the zookeeper related code out of hbase-client > module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19232) Fix shaded-check-invariants (check-jar-contents) failure on branch-1
[
https://issues.apache.org/jira/browse/HBASE-19232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247914#comment-16247914
]
Andrew Purtell commented on HBASE-19232:
bq. So I'd favor excluding the {{hadoop-mapreduce-client-core}} entirely.
Doing that should include a quick check on why it's pulled in in the first
place.
hadoop-mapreduce-client-core is a direct dependency of hbase-common. We specify
it as such in the POM in the hadoop-2.0 profile (active by default).
> Fix shaded-check-invariants (check-jar-contents) failure on branch-1
>
>
> Key: HBASE-19232
> URL: https://issues.apache.org/jira/browse/HBASE-19232
> Project: HBase
> Issue Type: Task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 1.4.0
>
> Attachments: HBASE-19232-branch-1.patch
>
>
> Jersey API and client jars shaded into client jar.
> {noformat}
> [ERROR] Found artifact with unexpected contents:
> '/Users/apurtell/src/hbase/hbase-shaded/hbase-shaded-client/target/hbase-shaded-client-1.5.0-SNAPSHOT.jar'
> Please check the following and either correct the build or update
> the allowed list with reasoning.
> com/
> com/sun/
> com/sun/jersey/
> com/sun/jersey/api/
> com/sun/jersey/api/client/
> com/sun/jersey/api/client/AbstractClientRequestAdapter.class
> com/sun/jersey/api/client/AsyncUniformInterface.class
> com/sun/jersey/api/client/AsyncViewResource$1.class
> com/sun/jersey/api/client/AsyncViewResource$2.class
> com/sun/jersey/api/client/AsyncViewResource$Builder.class
> com/sun/jersey/api/client/AsyncViewResource.class
> com/sun/jersey/api/client/AsyncViewUniformInterface.class
> com/sun/jersey/api/client/AsyncWebResource$1.class
> com/sun/jersey/api/client/AsyncWebResource$2.class
> com/sun/jersey/api/client/AsyncWebResource$3.class
> com/sun/jersey/api/client/AsyncWebResource$4.class
> com/sun/jersey/api/client/AsyncWebResource$5.class
> com/sun/jersey/api/client/AsyncWebResource$6.class
> com/sun/jersey/api/client/AsyncWebResource$Builder.class
> com/sun/jersey/api/client/AsyncWebResource.class
> com/sun/jersey/api/client/Client$1.class
> com/sun/jersey/api/client/Client$2.class
> com/sun/jersey/api/client/Client$3.class
> com/sun/jersey/api/client/Client$4$1.class
> com/sun/jersey/api/client/Client$4.class
> com/sun/jersey/api/client/Client$ComponentProcessorFactoryImpl$1.class
> com/sun/jersey/api/client/Client$ComponentProcessorFactoryImpl.class
> com/sun/jersey/api/client/Client$ContextInjectableProvider.class
> com/sun/jersey/api/client/Client.class
> com/sun/jersey/api/client/ClientHandler.class
> com/sun/jersey/api/client/ClientHandlerException.class
> com/sun/jersey/api/client/ClientRequest$Builder.class
> com/sun/jersey/api/client/ClientRequest.class
> com/sun/jersey/api/client/ClientRequestAdapter.class
> com/sun/jersey/api/client/ClientResponse$Status.class
> com/sun/jersey/api/client/ClientResponse.class
> com/sun/jersey/api/client/CommittingOutputStream.class
> com/sun/jersey/api/client/ComponentsClientConfig.class
> com/sun/jersey/api/client/GenericType.class
> com/sun/jersey/api/client/PartialRequestBuilder.class
> com/sun/jersey/api/client/RequestBuilder.class
> com/sun/jersey/api/client/RequestWriter$RequestEntityWriter.class
> com/sun/jersey/api/client/RequestWriter$RequestEntityWriterImpl.class
> com/sun/jersey/api/client/RequestWriter$RequestEntityWriterListener.class
> com/sun/jersey/api/client/RequestWriter.class
> com/sun/jersey/api/client/TerminatingClientHandler.class
> com/sun/jersey/api/client/UniformInterface.class
> com/sun/jersey/api/client/UniformInterfaceException.class
> com/sun/jersey/api/client/ViewResource$1.class
> com/sun/jersey/api/client/ViewResource$Builder.class
> com/sun/jersey/api/client/ViewResource.class
> com/sun/jersey/api/client/ViewUniformInterface.class
> com/sun/jersey/api/client/WebResource$1.class
> com/sun/jersey/api/client/WebResource$Builder.class
> com/sun/jersey/api/client/WebResource.class
> com/sun/jersey/api/client/WebResourceLinkHeaders.class
> com/sun/jersey/api/client/async/
> com/sun/jersey/api/client/async/AsyncClientHandler.class
> com/sun/jersey/api/client/async/FutureListener.class
> com/sun/jersey/api/client/async/ITypeListener.class
> com/sun/jersey/api/client/async/TypeListener.class
> com/sun/jersey/api/client/config/
> com/sun/jersey/api/client/config/ClientConfig.class
> com/sun/jersey/api/client/config/DefaultClientConfig.class
> com/sun/jersey/api/client/filter/
> com/sun/jersey/ap
[jira] [Updated] (HBASE-19181) LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog
[ https://issues.apache.org/jira/browse/HBASE-19181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19181: --- Status: Patch Available (was: Open) > LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog > -- > > Key: HBASE-19181 > URL: https://issues.apache.org/jira/browse/HBASE-19181 > Project: HBase > Issue Type: Bug > Components: backup&restore >Reporter: Duo Zhang >Assignee: Vladimir Rodionov > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19181-v1.patch > > > In the RSRollLogTask it will cast a WAL to FSHLog. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19232) Fix shaded-check-invariants (check-jar-contents) failure on branch-1
[
https://issues.apache.org/jira/browse/HBASE-19232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247917#comment-16247917
]
Andrew Purtell commented on HBASE-19232:
Likewise in hbase-client.
However, I see we are excluding a bunch of jersey packages already. Let me add
an exclusion for this artifact too. Patch coming shortly.
> Fix shaded-check-invariants (check-jar-contents) failure on branch-1
>
>
> Key: HBASE-19232
> URL: https://issues.apache.org/jira/browse/HBASE-19232
> Project: HBase
> Issue Type: Task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 1.4.0
>
>
> Jersey API and client jars shaded into client jar.
> {noformat}
> [ERROR] Found artifact with unexpected contents:
> '/Users/apurtell/src/hbase/hbase-shaded/hbase-shaded-client/target/hbase-shaded-client-1.5.0-SNAPSHOT.jar'
> Please check the following and either correct the build or update
> the allowed list with reasoning.
> com/
> com/sun/
> com/sun/jersey/
> com/sun/jersey/api/
> com/sun/jersey/api/client/
> com/sun/jersey/api/client/AbstractClientRequestAdapter.class
> com/sun/jersey/api/client/AsyncUniformInterface.class
> com/sun/jersey/api/client/AsyncViewResource$1.class
> com/sun/jersey/api/client/AsyncViewResource$2.class
> com/sun/jersey/api/client/AsyncViewResource$Builder.class
> com/sun/jersey/api/client/AsyncViewResource.class
> com/sun/jersey/api/client/AsyncViewUniformInterface.class
> com/sun/jersey/api/client/AsyncWebResource$1.class
> com/sun/jersey/api/client/AsyncWebResource$2.class
> com/sun/jersey/api/client/AsyncWebResource$3.class
> com/sun/jersey/api/client/AsyncWebResource$4.class
> com/sun/jersey/api/client/AsyncWebResource$5.class
> com/sun/jersey/api/client/AsyncWebResource$6.class
> com/sun/jersey/api/client/AsyncWebResource$Builder.class
> com/sun/jersey/api/client/AsyncWebResource.class
> com/sun/jersey/api/client/Client$1.class
> com/sun/jersey/api/client/Client$2.class
> com/sun/jersey/api/client/Client$3.class
> com/sun/jersey/api/client/Client$4$1.class
> com/sun/jersey/api/client/Client$4.class
> com/sun/jersey/api/client/Client$ComponentProcessorFactoryImpl$1.class
> com/sun/jersey/api/client/Client$ComponentProcessorFactoryImpl.class
> com/sun/jersey/api/client/Client$ContextInjectableProvider.class
> com/sun/jersey/api/client/Client.class
> com/sun/jersey/api/client/ClientHandler.class
> com/sun/jersey/api/client/ClientHandlerException.class
> com/sun/jersey/api/client/ClientRequest$Builder.class
> com/sun/jersey/api/client/ClientRequest.class
> com/sun/jersey/api/client/ClientRequestAdapter.class
> com/sun/jersey/api/client/ClientResponse$Status.class
> com/sun/jersey/api/client/ClientResponse.class
> com/sun/jersey/api/client/CommittingOutputStream.class
> com/sun/jersey/api/client/ComponentsClientConfig.class
> com/sun/jersey/api/client/GenericType.class
> com/sun/jersey/api/client/PartialRequestBuilder.class
> com/sun/jersey/api/client/RequestBuilder.class
> com/sun/jersey/api/client/RequestWriter$RequestEntityWriter.class
> com/sun/jersey/api/client/RequestWriter$RequestEntityWriterImpl.class
> com/sun/jersey/api/client/RequestWriter$RequestEntityWriterListener.class
> com/sun/jersey/api/client/RequestWriter.class
> com/sun/jersey/api/client/TerminatingClientHandler.class
> com/sun/jersey/api/client/UniformInterface.class
> com/sun/jersey/api/client/UniformInterfaceException.class
> com/sun/jersey/api/client/ViewResource$1.class
> com/sun/jersey/api/client/ViewResource$Builder.class
> com/sun/jersey/api/client/ViewResource.class
> com/sun/jersey/api/client/ViewUniformInterface.class
> com/sun/jersey/api/client/WebResource$1.class
> com/sun/jersey/api/client/WebResource$Builder.class
> com/sun/jersey/api/client/WebResource.class
> com/sun/jersey/api/client/WebResourceLinkHeaders.class
> com/sun/jersey/api/client/async/
> com/sun/jersey/api/client/async/AsyncClientHandler.class
> com/sun/jersey/api/client/async/FutureListener.class
> com/sun/jersey/api/client/async/ITypeListener.class
> com/sun/jersey/api/client/async/TypeListener.class
> com/sun/jersey/api/client/config/
> com/sun/jersey/api/client/config/ClientConfig.class
> com/sun/jersey/api/client/config/DefaultClientConfig.class
> com/sun/jersey/api/client/filter/
> com/sun/jersey/api/client/filter/ClientFilter.class
> com/sun/jersey/api/client/filter/ClientRequestContainer.class
> com/sun/jersey/api/client/filter/ConnectionListenerFilter$Adapter.class
> com/sun/jerse
[jira] [Updated] (HBASE-19232) Fix shaded-check-invariants (check-jar-contents) failure on branch-1
[
https://issues.apache.org/jira/browse/HBASE-19232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-19232:
---
Attachment: (was: HBASE-19232-branch-1.patch)
> Fix shaded-check-invariants (check-jar-contents) failure on branch-1
>
>
> Key: HBASE-19232
> URL: https://issues.apache.org/jira/browse/HBASE-19232
> Project: HBase
> Issue Type: Task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 1.4.0
>
>
> Jersey API and client jars shaded into client jar.
> {noformat}
> [ERROR] Found artifact with unexpected contents:
> '/Users/apurtell/src/hbase/hbase-shaded/hbase-shaded-client/target/hbase-shaded-client-1.5.0-SNAPSHOT.jar'
> Please check the following and either correct the build or update
> the allowed list with reasoning.
> com/
> com/sun/
> com/sun/jersey/
> com/sun/jersey/api/
> com/sun/jersey/api/client/
> com/sun/jersey/api/client/AbstractClientRequestAdapter.class
> com/sun/jersey/api/client/AsyncUniformInterface.class
> com/sun/jersey/api/client/AsyncViewResource$1.class
> com/sun/jersey/api/client/AsyncViewResource$2.class
> com/sun/jersey/api/client/AsyncViewResource$Builder.class
> com/sun/jersey/api/client/AsyncViewResource.class
> com/sun/jersey/api/client/AsyncViewUniformInterface.class
> com/sun/jersey/api/client/AsyncWebResource$1.class
> com/sun/jersey/api/client/AsyncWebResource$2.class
> com/sun/jersey/api/client/AsyncWebResource$3.class
> com/sun/jersey/api/client/AsyncWebResource$4.class
> com/sun/jersey/api/client/AsyncWebResource$5.class
> com/sun/jersey/api/client/AsyncWebResource$6.class
> com/sun/jersey/api/client/AsyncWebResource$Builder.class
> com/sun/jersey/api/client/AsyncWebResource.class
> com/sun/jersey/api/client/Client$1.class
> com/sun/jersey/api/client/Client$2.class
> com/sun/jersey/api/client/Client$3.class
> com/sun/jersey/api/client/Client$4$1.class
> com/sun/jersey/api/client/Client$4.class
> com/sun/jersey/api/client/Client$ComponentProcessorFactoryImpl$1.class
> com/sun/jersey/api/client/Client$ComponentProcessorFactoryImpl.class
> com/sun/jersey/api/client/Client$ContextInjectableProvider.class
> com/sun/jersey/api/client/Client.class
> com/sun/jersey/api/client/ClientHandler.class
> com/sun/jersey/api/client/ClientHandlerException.class
> com/sun/jersey/api/client/ClientRequest$Builder.class
> com/sun/jersey/api/client/ClientRequest.class
> com/sun/jersey/api/client/ClientRequestAdapter.class
> com/sun/jersey/api/client/ClientResponse$Status.class
> com/sun/jersey/api/client/ClientResponse.class
> com/sun/jersey/api/client/CommittingOutputStream.class
> com/sun/jersey/api/client/ComponentsClientConfig.class
> com/sun/jersey/api/client/GenericType.class
> com/sun/jersey/api/client/PartialRequestBuilder.class
> com/sun/jersey/api/client/RequestBuilder.class
> com/sun/jersey/api/client/RequestWriter$RequestEntityWriter.class
> com/sun/jersey/api/client/RequestWriter$RequestEntityWriterImpl.class
> com/sun/jersey/api/client/RequestWriter$RequestEntityWriterListener.class
> com/sun/jersey/api/client/RequestWriter.class
> com/sun/jersey/api/client/TerminatingClientHandler.class
> com/sun/jersey/api/client/UniformInterface.class
> com/sun/jersey/api/client/UniformInterfaceException.class
> com/sun/jersey/api/client/ViewResource$1.class
> com/sun/jersey/api/client/ViewResource$Builder.class
> com/sun/jersey/api/client/ViewResource.class
> com/sun/jersey/api/client/ViewUniformInterface.class
> com/sun/jersey/api/client/WebResource$1.class
> com/sun/jersey/api/client/WebResource$Builder.class
> com/sun/jersey/api/client/WebResource.class
> com/sun/jersey/api/client/WebResourceLinkHeaders.class
> com/sun/jersey/api/client/async/
> com/sun/jersey/api/client/async/AsyncClientHandler.class
> com/sun/jersey/api/client/async/FutureListener.class
> com/sun/jersey/api/client/async/ITypeListener.class
> com/sun/jersey/api/client/async/TypeListener.class
> com/sun/jersey/api/client/config/
> com/sun/jersey/api/client/config/ClientConfig.class
> com/sun/jersey/api/client/config/DefaultClientConfig.class
> com/sun/jersey/api/client/filter/
> com/sun/jersey/api/client/filter/ClientFilter.class
> com/sun/jersey/api/client/filter/ClientRequestContainer.class
> com/sun/jersey/api/client/filter/ConnectionListenerFilter$Adapter.class
> com/sun/jersey/api/client/filter/ConnectionListenerFilter.class
> com/sun/jersey/api/client/filter/ContainerListener.class
> com/sun/jersey/api/client/filter/CsrfProtectionFi
[jira] [Created] (HBASE-19238) Port Hadoop's new GcTimeMonitor
Andrew Purtell created HBASE-19238:
--
Summary: Port Hadoop's new GcTimeMonitor
Key: HBASE-19238
URL: https://issues.apache.org/jira/browse/HBASE-19238
Project: HBase
Issue Type: Improvement
Reporter: Andrew Purtell
Priority: Minor
We borrowed Hadoop's JvmPauseMonitor some time ago. On HADOOP-14960 (Add GC
time percentage monitor/alerter), Hadoop added a new GcTimeMonitor, which seems
useful:
{code}
/**
* This class monitors the percentage of time the JVM is paused in GC within
* the specified observation window, say 1 minute. The user can provide a
* hook which will be called whenever this percentage exceeds the specified
* threshold.
*/
{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19226) Limit the reduce tasks number of incremental load
[
https://issues.apache.org/jira/browse/HBASE-19226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247938#comment-16247938
]
Hadoop QA commented on HBASE-19226:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
5s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
52s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
14s{color} | {color:red} hbase-mapreduce: The patch generated 1 new + 59
unchanged - 0 fixed = 60 total (was 59) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
15s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
48m 59s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 20m 45s{color}
| {color:red} hbase-mapreduce in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 89m 1s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19226 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897108/HBASE-19226.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux e3270e26830b 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 31234eb862 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/9735/artifact/patchprocess/diff-checkstyle-hbase-mapreduce.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/9735/artifact/patchprocess/patch-unit-hbase-mapreduce.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9735/testReport/ |
| modules | C: hbase-mapreduce U: hbase-mapreduce |
| Console output |
https://builds.apac
[jira] [Updated] (HBASE-19232) Fix shaded-check-invariants (check-jar-contents) failure on branch-1
[
https://issues.apache.org/jira/browse/HBASE-19232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-19232:
---
Attachment: HBASE-19232-branch-1.patch
Exclude jersey-client where we bring in Hadoop common and mapreduce client
except where they are needed (server, testing util, Hadoop compat, etc.)
> Fix shaded-check-invariants (check-jar-contents) failure on branch-1
>
>
> Key: HBASE-19232
> URL: https://issues.apache.org/jira/browse/HBASE-19232
> Project: HBase
> Issue Type: Task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 1.4.0
>
> Attachments: HBASE-19232-branch-1.patch
>
>
> Jersey API and client jars shaded into client jar.
> {noformat}
> [ERROR] Found artifact with unexpected contents:
> '/Users/apurtell/src/hbase/hbase-shaded/hbase-shaded-client/target/hbase-shaded-client-1.5.0-SNAPSHOT.jar'
> Please check the following and either correct the build or update
> the allowed list with reasoning.
> com/
> com/sun/
> com/sun/jersey/
> com/sun/jersey/api/
> com/sun/jersey/api/client/
> com/sun/jersey/api/client/AbstractClientRequestAdapter.class
> com/sun/jersey/api/client/AsyncUniformInterface.class
> com/sun/jersey/api/client/AsyncViewResource$1.class
> com/sun/jersey/api/client/AsyncViewResource$2.class
> com/sun/jersey/api/client/AsyncViewResource$Builder.class
> com/sun/jersey/api/client/AsyncViewResource.class
> com/sun/jersey/api/client/AsyncViewUniformInterface.class
> com/sun/jersey/api/client/AsyncWebResource$1.class
> com/sun/jersey/api/client/AsyncWebResource$2.class
> com/sun/jersey/api/client/AsyncWebResource$3.class
> com/sun/jersey/api/client/AsyncWebResource$4.class
> com/sun/jersey/api/client/AsyncWebResource$5.class
> com/sun/jersey/api/client/AsyncWebResource$6.class
> com/sun/jersey/api/client/AsyncWebResource$Builder.class
> com/sun/jersey/api/client/AsyncWebResource.class
> com/sun/jersey/api/client/Client$1.class
> com/sun/jersey/api/client/Client$2.class
> com/sun/jersey/api/client/Client$3.class
> com/sun/jersey/api/client/Client$4$1.class
> com/sun/jersey/api/client/Client$4.class
> com/sun/jersey/api/client/Client$ComponentProcessorFactoryImpl$1.class
> com/sun/jersey/api/client/Client$ComponentProcessorFactoryImpl.class
> com/sun/jersey/api/client/Client$ContextInjectableProvider.class
> com/sun/jersey/api/client/Client.class
> com/sun/jersey/api/client/ClientHandler.class
> com/sun/jersey/api/client/ClientHandlerException.class
> com/sun/jersey/api/client/ClientRequest$Builder.class
> com/sun/jersey/api/client/ClientRequest.class
> com/sun/jersey/api/client/ClientRequestAdapter.class
> com/sun/jersey/api/client/ClientResponse$Status.class
> com/sun/jersey/api/client/ClientResponse.class
> com/sun/jersey/api/client/CommittingOutputStream.class
> com/sun/jersey/api/client/ComponentsClientConfig.class
> com/sun/jersey/api/client/GenericType.class
> com/sun/jersey/api/client/PartialRequestBuilder.class
> com/sun/jersey/api/client/RequestBuilder.class
> com/sun/jersey/api/client/RequestWriter$RequestEntityWriter.class
> com/sun/jersey/api/client/RequestWriter$RequestEntityWriterImpl.class
> com/sun/jersey/api/client/RequestWriter$RequestEntityWriterListener.class
> com/sun/jersey/api/client/RequestWriter.class
> com/sun/jersey/api/client/TerminatingClientHandler.class
> com/sun/jersey/api/client/UniformInterface.class
> com/sun/jersey/api/client/UniformInterfaceException.class
> com/sun/jersey/api/client/ViewResource$1.class
> com/sun/jersey/api/client/ViewResource$Builder.class
> com/sun/jersey/api/client/ViewResource.class
> com/sun/jersey/api/client/ViewUniformInterface.class
> com/sun/jersey/api/client/WebResource$1.class
> com/sun/jersey/api/client/WebResource$Builder.class
> com/sun/jersey/api/client/WebResource.class
> com/sun/jersey/api/client/WebResourceLinkHeaders.class
> com/sun/jersey/api/client/async/
> com/sun/jersey/api/client/async/AsyncClientHandler.class
> com/sun/jersey/api/client/async/FutureListener.class
> com/sun/jersey/api/client/async/ITypeListener.class
> com/sun/jersey/api/client/async/TypeListener.class
> com/sun/jersey/api/client/config/
> com/sun/jersey/api/client/config/ClientConfig.class
> com/sun/jersey/api/client/config/DefaultClientConfig.class
> com/sun/jersey/api/client/filter/
> com/sun/jersey/api/client/filter/ClientFilter.class
> com/sun/jersey/api/client/filter/ClientRequestContainer.class
> com/sun/jersey/api/client/filter/ConnectionListenerFilter$Adapter.cla
[jira] [Commented] (HBASE-19232) Fix shaded-check-invariants (check-jar-contents) failure on branch-1
[
https://issues.apache.org/jira/browse/HBASE-19232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247943#comment-16247943
]
Andrew Purtell commented on HBASE-19232:
Confirmed this patch fixes the build. It completes with -Prelease.
> Fix shaded-check-invariants (check-jar-contents) failure on branch-1
>
>
> Key: HBASE-19232
> URL: https://issues.apache.org/jira/browse/HBASE-19232
> Project: HBase
> Issue Type: Task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 1.4.0
>
> Attachments: HBASE-19232-branch-1.patch
>
>
> Jersey API and client jars shaded into client jar.
> {noformat}
> [ERROR] Found artifact with unexpected contents:
> '/Users/apurtell/src/hbase/hbase-shaded/hbase-shaded-client/target/hbase-shaded-client-1.5.0-SNAPSHOT.jar'
> Please check the following and either correct the build or update
> the allowed list with reasoning.
> com/
> com/sun/
> com/sun/jersey/
> com/sun/jersey/api/
> com/sun/jersey/api/client/
> com/sun/jersey/api/client/AbstractClientRequestAdapter.class
> com/sun/jersey/api/client/AsyncUniformInterface.class
> com/sun/jersey/api/client/AsyncViewResource$1.class
> com/sun/jersey/api/client/AsyncViewResource$2.class
> com/sun/jersey/api/client/AsyncViewResource$Builder.class
> com/sun/jersey/api/client/AsyncViewResource.class
> com/sun/jersey/api/client/AsyncViewUniformInterface.class
> com/sun/jersey/api/client/AsyncWebResource$1.class
> com/sun/jersey/api/client/AsyncWebResource$2.class
> com/sun/jersey/api/client/AsyncWebResource$3.class
> com/sun/jersey/api/client/AsyncWebResource$4.class
> com/sun/jersey/api/client/AsyncWebResource$5.class
> com/sun/jersey/api/client/AsyncWebResource$6.class
> com/sun/jersey/api/client/AsyncWebResource$Builder.class
> com/sun/jersey/api/client/AsyncWebResource.class
> com/sun/jersey/api/client/Client$1.class
> com/sun/jersey/api/client/Client$2.class
> com/sun/jersey/api/client/Client$3.class
> com/sun/jersey/api/client/Client$4$1.class
> com/sun/jersey/api/client/Client$4.class
> com/sun/jersey/api/client/Client$ComponentProcessorFactoryImpl$1.class
> com/sun/jersey/api/client/Client$ComponentProcessorFactoryImpl.class
> com/sun/jersey/api/client/Client$ContextInjectableProvider.class
> com/sun/jersey/api/client/Client.class
> com/sun/jersey/api/client/ClientHandler.class
> com/sun/jersey/api/client/ClientHandlerException.class
> com/sun/jersey/api/client/ClientRequest$Builder.class
> com/sun/jersey/api/client/ClientRequest.class
> com/sun/jersey/api/client/ClientRequestAdapter.class
> com/sun/jersey/api/client/ClientResponse$Status.class
> com/sun/jersey/api/client/ClientResponse.class
> com/sun/jersey/api/client/CommittingOutputStream.class
> com/sun/jersey/api/client/ComponentsClientConfig.class
> com/sun/jersey/api/client/GenericType.class
> com/sun/jersey/api/client/PartialRequestBuilder.class
> com/sun/jersey/api/client/RequestBuilder.class
> com/sun/jersey/api/client/RequestWriter$RequestEntityWriter.class
> com/sun/jersey/api/client/RequestWriter$RequestEntityWriterImpl.class
> com/sun/jersey/api/client/RequestWriter$RequestEntityWriterListener.class
> com/sun/jersey/api/client/RequestWriter.class
> com/sun/jersey/api/client/TerminatingClientHandler.class
> com/sun/jersey/api/client/UniformInterface.class
> com/sun/jersey/api/client/UniformInterfaceException.class
> com/sun/jersey/api/client/ViewResource$1.class
> com/sun/jersey/api/client/ViewResource$Builder.class
> com/sun/jersey/api/client/ViewResource.class
> com/sun/jersey/api/client/ViewUniformInterface.class
> com/sun/jersey/api/client/WebResource$1.class
> com/sun/jersey/api/client/WebResource$Builder.class
> com/sun/jersey/api/client/WebResource.class
> com/sun/jersey/api/client/WebResourceLinkHeaders.class
> com/sun/jersey/api/client/async/
> com/sun/jersey/api/client/async/AsyncClientHandler.class
> com/sun/jersey/api/client/async/FutureListener.class
> com/sun/jersey/api/client/async/ITypeListener.class
> com/sun/jersey/api/client/async/TypeListener.class
> com/sun/jersey/api/client/config/
> com/sun/jersey/api/client/config/ClientConfig.class
> com/sun/jersey/api/client/config/DefaultClientConfig.class
> com/sun/jersey/api/client/filter/
> com/sun/jersey/api/client/filter/ClientFilter.class
> com/sun/jersey/api/client/filter/ClientRequestContainer.class
> com/sun/jersey/api/client/filter/ConnectionListenerFilter$Adapter.class
> com/sun/jersey/api/client/filter/ConnectionListenerFilter.
[jira] [Created] (HBASE-19239) Fix important checkstyle and error-prone warnings
Andrew Purtell created HBASE-19239: -- Summary: Fix important checkstyle and error-prone warnings Key: HBASE-19239 URL: https://issues.apache.org/jira/browse/HBASE-19239 Project: HBase Issue Type: Improvement Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 3.0.0, 1.4.0, 2.0.0-beta-1 Fix important checkstyle and error-prone warnings on branch-1.4 / branch-1. Forward port as appropriate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19215) Incorrect exception handling on the client causes incorrect call timeouts and byte buffer allocations on the server
[
https://issues.apache.org/jira/browse/HBASE-19215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247965#comment-16247965
]
Andrew Purtell commented on HBASE-19215:
[~abhishek.chouhan] are you planning to fix this in the next day or two? If not
I will take it.
> Incorrect exception handling on the client causes incorrect call timeouts and
> byte buffer allocations on the server
> ---
>
> Key: HBASE-19215
> URL: https://issues.apache.org/jira/browse/HBASE-19215
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.1
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2
>
>
> Ran into the situation of oome on the client : java.lang.OutOfMemoryError:
> Direct buffer memory.
> When we encounter an unhandled exception during channel write at RpcClientImpl
> {noformat}
> checkIsOpen(); // Now we're checking that it didn't became idle in between.
> try {
> call.callStats.setRequestSizeBytes(IPCUtil.write(this.out, header,
> call.param,
> cellBlock));
> } catch (IOException e) {
> {noformat}
> we end up leaving the connection open. This becomes especially problematic
> when we get an unhandled exception between writing the length of our request
> on the channel and subsequently writing the params and cellblocks
> {noformat}
>*dos.write(Bytes.toBytes(totalSize));*
> // This allocates a buffer that is the size of the message internally.
> header.writeDelimitedTo(dos);
> if (param != null) param.writeDelimitedTo(dos);
> if (cellBlock != null) dos.write(cellBlock.array(), 0,
> cellBlock.remaining());
> dos.flush();
> return totalSize;
> {noformat}
> After reading the length rs allocates a bb and expects data to be filled.
> However when we encounter an exception during param write we release the
> writelock in rpcclientimpl and do not close the connection, the exception is
> handled at AbstractRpcClient.callBlockingMethod and retried. Now the next
> client request to the same rs writes to the channel however the server
> interprets this as part of the previous request and errors out during proto
> conversion when processing the request since its considered malformed(in the
> worst case this might be misinterpreted as wrong data?). Now the remaining
> data of the current request is read(the current request's size > prev
> request's allocated partially filled bytebuffer) and is misinterpreted as the
> size of new request, in my case this was in gbs. All the client requests time
> out since this bytebuffer is never completely filled. We should close the
> connection for any Throwable and not just ioexception.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-12091) Optionally ignore edits for dropped tables for replication.
[ https://issues.apache.org/jira/browse/HBASE-12091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247970#comment-16247970 ] Andrew Purtell edited comment on HBASE-12091 at 11/10/17 7:46 PM: -- This can still make 1.4.0 if committed in the next couple of days. It's taking more time than I thought it would. I spent one whole day working on JIRA fixversions. was (Author: apurtell): This can still make 1.4.0 if committed in the next couple of days. It's taking more time than I though. I spent one whole day working on JIRA fixversions. > Optionally ignore edits for dropped tables for replication. > --- > > Key: HBASE-12091 > URL: https://issues.apache.org/jira/browse/HBASE-12091 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Fix For: 2.0.0, 3.0.0, 1.4.1, 1.5.0 > > Attachments: 12091-branch-2.patch, 12091-v2-branch-1.txt, > 12091-v3-branch-1.txt, 12091-v4-branch-1.txt, 12091-v5-branch-1.txt, > 12091-v6-branch-1.txt, 12091-v7-branch-1.txt, 12091-v7-master.txt, > 12091-v8-master.txt, 12091.txt > > > We just ran into a scenario where we dropped a table from both the source and > the sink, but the source still has outstanding edits that now it could not > get rid of. Now all replication is backed up behind these unreplicatable > edits. > We should have an option to ignore edits for tables dropped at the source. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12091) Optionally ignore edits for dropped tables for replication.
[ https://issues.apache.org/jira/browse/HBASE-12091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247970#comment-16247970 ] Andrew Purtell commented on HBASE-12091: This can still make 1.4.0 if committed in the next couple of days. It's taking more time than I though. I spent one whole day working on JIRA fixversions. > Optionally ignore edits for dropped tables for replication. > --- > > Key: HBASE-12091 > URL: https://issues.apache.org/jira/browse/HBASE-12091 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Fix For: 2.0.0, 3.0.0, 1.4.1, 1.5.0 > > Attachments: 12091-branch-2.patch, 12091-v2-branch-1.txt, > 12091-v3-branch-1.txt, 12091-v4-branch-1.txt, 12091-v5-branch-1.txt, > 12091-v6-branch-1.txt, 12091-v7-branch-1.txt, 12091-v7-master.txt, > 12091-v8-master.txt, 12091.txt > > > We just ran into a scenario where we dropped a table from both the source and > the sink, but the source still has outstanding edits that now it could not > get rid of. Now all replication is backed up behind these unreplicatable > edits. > We should have an option to ignore edits for tables dropped at the source. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19239) Fix important checkstyle and error-prone warnings
[ https://issues.apache.org/jira/browse/HBASE-19239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19239: --- Attachment: error-prone-branch-1.4.txt > Fix important checkstyle and error-prone warnings > - > > Key: HBASE-19239 > URL: https://issues.apache.org/jira/browse/HBASE-19239 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 3.0.0, 1.4.0, 2.0.0-beta-1 > > Attachments: error-prone-branch-1.4.txt > > > Fix important checkstyle and error-prone warnings on branch-1.4 / branch-1. > Forward port as appropriate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19239) Fix important error-prone warnings
[ https://issues.apache.org/jira/browse/HBASE-19239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19239: --- Summary: Fix important error-prone warnings (was: Fix important checkstyle and error-prone warnings) > Fix important error-prone warnings > -- > > Key: HBASE-19239 > URL: https://issues.apache.org/jira/browse/HBASE-19239 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 3.0.0, 1.4.0, 2.0.0-beta-1 > > Attachments: error-prone-branch-1.4.txt > > > Fix important checkstyle and error-prone warnings on branch-1.4 / branch-1. > Forward port as appropriate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19239) Fix important error-prone warnings
[ https://issues.apache.org/jira/browse/HBASE-19239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19239: --- Description: Fix important error-prone warnings on branch-1.4 / branch-1. Forward port as appropriate. (was: Fix important checkstyle and error-prone warnings on branch-1.4 / branch-1. Forward port as appropriate. ) > Fix important error-prone warnings > -- > > Key: HBASE-19239 > URL: https://issues.apache.org/jira/browse/HBASE-19239 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 3.0.0, 1.4.0, 2.0.0-beta-1 > > Attachments: error-prone-branch-1.4.txt > > > Fix important error-prone warnings on branch-1.4 / branch-1. Forward port as > appropriate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19239) Fix important error-prone warnings
[ https://issues.apache.org/jira/browse/HBASE-19239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247999#comment-16247999 ] Andrew Purtell commented on HBASE-19239: Too many checkstyle results to even look through. > Fix important error-prone warnings > -- > > Key: HBASE-19239 > URL: https://issues.apache.org/jira/browse/HBASE-19239 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 3.0.0, 1.4.0, 2.0.0-beta-1 > > Attachments: error-prone-branch-1.4.txt > > > Fix important error-prone warnings on branch-1.4 / branch-1. Forward port as > appropriate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19239) Fix important findbugs and error-prone warnings
[ https://issues.apache.org/jira/browse/HBASE-19239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19239: --- Description: Fix important findbugs and error-prone warnings on branch-1.4 / branch-1. Forward port as appropriate. (was: Fix important error-prone warnings on branch-1.4 / branch-1. Forward port as appropriate. ) > Fix important findbugs and error-prone warnings > --- > > Key: HBASE-19239 > URL: https://issues.apache.org/jira/browse/HBASE-19239 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 3.0.0, 1.4.0, 2.0.0-beta-1 > > Attachments: error-prone-branch-1.4.txt > > > Fix important findbugs and error-prone warnings on branch-1.4 / branch-1. > Forward port as appropriate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19239) Fix important findbugs and error-prone warnings
[ https://issues.apache.org/jira/browse/HBASE-19239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19239: --- Summary: Fix important findbugs and error-prone warnings (was: Fix important error-prone warnings) > Fix important findbugs and error-prone warnings > --- > > Key: HBASE-19239 > URL: https://issues.apache.org/jira/browse/HBASE-19239 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 3.0.0, 1.4.0, 2.0.0-beta-1 > > Attachments: error-prone-branch-1.4.txt > > > Fix important error-prone warnings on branch-1.4 / branch-1. Forward port as > appropriate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16459) Remove unused hbase shell --format option
[
https://issues.apache.org/jira/browse/HBASE-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248018#comment-16248018
]
Hudson commented on HBASE-16459:
FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #343 (See
[https://builds.apache.org/job/HBase-1.3-JDK7/343/])
HBASE-16459 Remove unused hbase shell --format option (appy: rev
d4acc9b686c901f4b67a9b14966559ac12ab9f79)
* (edit) bin/hirb.rb
> Remove unused hbase shell --format option
> -
>
> Key: HBASE-16459
> URL: https://issues.apache.org/jira/browse/HBASE-16459
> Project: HBase
> Issue Type: Task
> Components: shell
>Reporter: Dima Spivak
>Assignee: Dima Spivak
>Priority: Trivial
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-16459.master.001.patch, HBASE-16459.patch,
> HBASE-16459_v2.patch
>
>
> The usage information when running {{hbase shell}} refers to a formatter
> option that has yet to implemented in over 8 years and which will ostensibly
> never be implemented. As such, let's cleanup the [help
> message|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L57-L59] and
> remove some extraneous lines of code from
> {{[hirb.rb|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L74-L83]}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-16459) Remove unused hbase shell --format option
[
https://issues.apache.org/jira/browse/HBASE-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248020#comment-16248020
]
Hudson commented on HBASE-16459:
FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #362 (See
[https://builds.apache.org/job/HBase-1.3-JDK8/362/])
HBASE-16459 Remove unused hbase shell --format option (appy: rev
d4acc9b686c901f4b67a9b14966559ac12ab9f79)
* (edit) bin/hirb.rb
> Remove unused hbase shell --format option
> -
>
> Key: HBASE-16459
> URL: https://issues.apache.org/jira/browse/HBASE-16459
> Project: HBase
> Issue Type: Task
> Components: shell
>Reporter: Dima Spivak
>Assignee: Dima Spivak
>Priority: Trivial
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-16459.master.001.patch, HBASE-16459.patch,
> HBASE-16459_v2.patch
>
>
> The usage information when running {{hbase shell}} refers to a formatter
> option that has yet to implemented in over 8 years and which will ostensibly
> never be implemented. As such, let's cleanup the [help
> message|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L57-L59] and
> remove some extraneous lines of code from
> {{[hirb.rb|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L74-L83]}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-16459) Remove unused hbase shell --format option
[
https://issues.apache.org/jira/browse/HBASE-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248037#comment-16248037
]
Hudson commented on HBASE-16459:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #282 (See
[https://builds.apache.org/job/HBase-1.3-IT/282/])
HBASE-16459 Remove unused hbase shell --format option (appy: rev
d4acc9b686c901f4b67a9b14966559ac12ab9f79)
* (edit) bin/hirb.rb
> Remove unused hbase shell --format option
> -
>
> Key: HBASE-16459
> URL: https://issues.apache.org/jira/browse/HBASE-16459
> Project: HBase
> Issue Type: Task
> Components: shell
>Reporter: Dima Spivak
>Assignee: Dima Spivak
>Priority: Trivial
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-16459.master.001.patch, HBASE-16459.patch,
> HBASE-16459_v2.patch
>
>
> The usage information when running {{hbase shell}} refers to a formatter
> option that has yet to implemented in over 8 years and which will ostensibly
> never be implemented. As such, let's cleanup the [help
> message|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L57-L59] and
> remove some extraneous lines of code from
> {{[hirb.rb|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L74-L83]}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-16459) Remove unused hbase shell --format option
[
https://issues.apache.org/jira/browse/HBASE-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248040#comment-16248040
]
Hudson commented on HBASE-16459:
FAILURE: Integrated in Jenkins build HBase-1.2-JDK8 #272 (See
[https://builds.apache.org/job/HBase-1.2-JDK8/272/])
HBASE-16459 Remove unused hbase shell --format option (appy: rev
c2d154ca652289608d91098da2a8fd541c8480c2)
* (edit) bin/hirb.rb
> Remove unused hbase shell --format option
> -
>
> Key: HBASE-16459
> URL: https://issues.apache.org/jira/browse/HBASE-16459
> Project: HBase
> Issue Type: Task
> Components: shell
>Reporter: Dima Spivak
>Assignee: Dima Spivak
>Priority: Trivial
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-16459.master.001.patch, HBASE-16459.patch,
> HBASE-16459_v2.patch
>
>
> The usage information when running {{hbase shell}} refers to a formatter
> option that has yet to implemented in over 8 years and which will ostensibly
> never be implemented. As such, let's cleanup the [help
> message|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L57-L59] and
> remove some extraneous lines of code from
> {{[hirb.rb|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L74-L83]}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-16459) Remove unused hbase shell --format option
[
https://issues.apache.org/jira/browse/HBASE-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248041#comment-16248041
]
Hudson commented on HBASE-16459:
FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #275 (See
[https://builds.apache.org/job/HBase-1.2-JDK7/275/])
HBASE-16459 Remove unused hbase shell --format option (appy: rev
c2d154ca652289608d91098da2a8fd541c8480c2)
* (edit) bin/hirb.rb
> Remove unused hbase shell --format option
> -
>
> Key: HBASE-16459
> URL: https://issues.apache.org/jira/browse/HBASE-16459
> Project: HBase
> Issue Type: Task
> Components: shell
>Reporter: Dima Spivak
>Assignee: Dima Spivak
>Priority: Trivial
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-16459.master.001.patch, HBASE-16459.patch,
> HBASE-16459_v2.patch
>
>
> The usage information when running {{hbase shell}} refers to a formatter
> option that has yet to implemented in over 8 years and which will ostensibly
> never be implemented. As such, let's cleanup the [help
> message|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L57-L59] and
> remove some extraneous lines of code from
> {{[hirb.rb|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L74-L83]}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18963) Remove MultiRowMutationProcessor and implement mutateRows... methods using batchMutate()
[
https://issues.apache.org/jira/browse/HBASE-18963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248043#comment-16248043
]
Hadoop QA commented on HBASE-18963:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
21s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
21s{color} | {color:green} hbase-server: The patch generated 0 new + 347
unchanged - 8 fixed = 347 total (was 355) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
8s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
60m 26s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
37s{color} | {color:red} hbase-server generated 2 new + 2 unchanged - 0 fixed =
4 total (was 2) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}113m 4s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}198m 44s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestFromClientSideWithCoprocessor |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18963 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897114/hbase-18963.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 19fcee3cf16c 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 31234eb862 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/9737/artifact/patchprocess/diff-javadoc-javadoc-hbase-server.txt
|
| unit |
https
[jira] [Assigned] (HBASE-11743) Add unit test for the fix that sorts custom value of BUCKET_CACHE_BUCKETS_KEY
[ https://issues.apache.org/jira/browse/HBASE-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reassigned HBASE-11743: -- Assignee: (was: Gustavo Anatoly) > Add unit test for the fix that sorts custom value of BUCKET_CACHE_BUCKETS_KEY > - > > Key: HBASE-11743 > URL: https://issues.apache.org/jira/browse/HBASE-11743 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Priority: Minor > > HBASE-11550 sorts the custom value of BUCKET_CACHE_BUCKETS_KEY such that > there is no wastage in bucket allocation. > This JIRA is to add unit test for the fix so that there is no regression in > the future. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16459) Remove unused hbase shell --format option
[
https://issues.apache.org/jira/browse/HBASE-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248048#comment-16248048
]
Hudson commented on HBASE-16459:
SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1015 (See
[https://builds.apache.org/job/HBase-1.2-IT/1015/])
HBASE-16459 Remove unused hbase shell --format option (appy: rev
c2d154ca652289608d91098da2a8fd541c8480c2)
* (edit) bin/hirb.rb
> Remove unused hbase shell --format option
> -
>
> Key: HBASE-16459
> URL: https://issues.apache.org/jira/browse/HBASE-16459
> Project: HBase
> Issue Type: Task
> Components: shell
>Reporter: Dima Spivak
>Assignee: Dima Spivak
>Priority: Trivial
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-16459.master.001.patch, HBASE-16459.patch,
> HBASE-16459_v2.patch
>
>
> The usage information when running {{hbase shell}} refers to a formatter
> option that has yet to implemented in over 8 years and which will ostensibly
> never be implemented. As such, let's cleanup the [help
> message|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L57-L59] and
> remove some extraneous lines of code from
> {{[hirb.rb|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L74-L83]}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19237) TestMaster.testMasterOpsWhileSplitting fails
[
https://issues.apache.org/jira/browse/HBASE-19237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248077#comment-16248077
]
Yi Liang commented on HBASE-19237:
--
ok, I will check the code.
> TestMaster.testMasterOpsWhileSplitting fails
>
>
> Key: HBASE-19237
> URL: https://issues.apache.org/jira/browse/HBASE-19237
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
> Attachments: 19237.v1.txt
>
>
> This is the top flaky test:
> {code}
> java.lang.AssertionError: expected:<3> but was:<1>
> at
> org.apache.hadoop.hbase.master.TestMaster.testMasterOpsWhileSplitting(TestMaster.java:121)
> {code}
> After brief check, the test failure seems to be introduced by HBASE-19127
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19239) Fix important findbugs and error-prone warnings
[ https://issues.apache.org/jira/browse/HBASE-19239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248099#comment-16248099 ] Mike Drob commented on HBASE-19239: --- Also, I'm still working through the errors on master and it's pretty slow going. Help is appreciated but I don't want to duplicate effort. > Fix important findbugs and error-prone warnings > --- > > Key: HBASE-19239 > URL: https://issues.apache.org/jira/browse/HBASE-19239 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 3.0.0, 1.4.0, 2.0.0-beta-1 > > Attachments: error-prone-branch-1.4.txt > > > Fix important findbugs and error-prone warnings on branch-1.4 / branch-1. > Forward port as appropriate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19239) Fix important findbugs and error-prone warnings
[ https://issues.apache.org/jira/browse/HBASE-19239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248096#comment-16248096 ] Mike Drob commented on HBASE-19239: --- I think we should run with MissingOverride and AssertEqualsArgumentOrderChecker disabled. There's far too many hits on both of those to have meaningful results. > Fix important findbugs and error-prone warnings > --- > > Key: HBASE-19239 > URL: https://issues.apache.org/jira/browse/HBASE-19239 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 3.0.0, 1.4.0, 2.0.0-beta-1 > > Attachments: error-prone-branch-1.4.txt > > > Fix important findbugs and error-prone warnings on branch-1.4 / branch-1. > Forward port as appropriate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19240) Fix error-prone errors, part four?
Mike Drob created HBASE-19240: - Summary: Fix error-prone errors, part four? Key: HBASE-19240 URL: https://issues.apache.org/jira/browse/HBASE-19240 Project: HBase Issue Type: Bug Reporter: Mike Drob -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19240) Fix error-prone errors, part four?
[ https://issues.apache.org/jira/browse/HBASE-19240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-19240: -- Assignee: Mike Drob Status: Patch Available (was: Open) > Fix error-prone errors, part four? > -- > > Key: HBASE-19240 > URL: https://issues.apache.org/jira/browse/HBASE-19240 > Project: HBase > Issue Type: Bug >Reporter: Mike Drob >Assignee: Mike Drob > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (HBASE-17133) Backup documentation update
[
https://issues.apache.org/jira/browse/HBASE-17133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Rodionov resolved HBASE-17133.
---
Resolution: Duplicate
Duplicate of HBASE-16574
> Backup documentation update
> ---
>
> Key: HBASE-17133
> URL: https://issues.apache.org/jira/browse/HBASE-17133
> Project: HBase
> Issue Type: Bug
>Reporter: Vladimir Rodionov
>Priority: Critical
> Labels: backup
> Fix For: 2.0.0
>
>
> We need to update backup doc to sync it with the current implementation and
> to add section for current limitations:
> {quote}
> - if you write to the table with Durability.SKIP_WALS your data will not
> be in the incremental-backup
> - if you bulkload files that data will not be in the incremental backup
> (HBASE-14417)
> - the incremental backup will not only contains the data of the table you
> specified but also the regions from other tables that are on the same set
> of RSs (HBASE-14141) ...maybe a note about security around this topic
> - the incremental backup will not contains just the "latest row" between
> backup A and B, but it will also contains all the updates occurred in
> between. but the restore does not allow you to restore up to a certain
> point in time, the restore will always be up to the "latest backup point".
> - you should limit the number of "incremental" up to N (or maybe SIZE), to
> avoid replay time becoming the bottleneck. (HBASE-14135)
> {quote}
> Update command line tool section
> Clarify restore backup section
> Add section on backup delete algorithm
> Add section on how backup image dependency chain works.
> Add section for configuration
> hbase.backup.enable=true
> hbase.master.logcleaner.plugins=YOUR_PUGINS,org.apache.hadoop.hbase.backup.master.BackupLogCleaner
> hbase.procedure.master.classes=YOUR_CLASSES,org.apache.hadoop.hbase.backup.master.LogRollMasterProcedureManager
> hbase.procedure.regionserver.classes=YOUR_CLASSES,org.apache.hadoop.hbase.backup.regionserver.LogRollRegionServerProcedureManager
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19240) Fix error-prone errors, part four?
[ https://issues.apache.org/jira/browse/HBASE-19240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-19240: -- Attachment: HBASE-19240.patch [~apurtell] - This is for master branch. I'm going to be otherwise occupied this weekend, so I'm not going to be around to commit this if you need it. Feel free to take the patch and iterate from it. [~chia7712] may be able to help also (he's done a lot of the findbugs dredge work in the past) > Fix error-prone errors, part four? > -- > > Key: HBASE-19240 > URL: https://issues.apache.org/jira/browse/HBASE-19240 > Project: HBase > Issue Type: Bug >Reporter: Mike Drob >Assignee: Mike Drob > Attachments: HBASE-19240.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17133) Backup documentation update
[
https://issues.apache.org/jira/browse/HBASE-17133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248104#comment-16248104
]
Vladimir Rodionov commented on HBASE-17133:
---
No, this is duplicate. I will close it, [~elserj]
> Backup documentation update
> ---
>
> Key: HBASE-17133
> URL: https://issues.apache.org/jira/browse/HBASE-17133
> Project: HBase
> Issue Type: Bug
>Reporter: Vladimir Rodionov
>Priority: Critical
> Labels: backup
> Fix For: 2.0.0
>
>
> We need to update backup doc to sync it with the current implementation and
> to add section for current limitations:
> {quote}
> - if you write to the table with Durability.SKIP_WALS your data will not
> be in the incremental-backup
> - if you bulkload files that data will not be in the incremental backup
> (HBASE-14417)
> - the incremental backup will not only contains the data of the table you
> specified but also the regions from other tables that are on the same set
> of RSs (HBASE-14141) ...maybe a note about security around this topic
> - the incremental backup will not contains just the "latest row" between
> backup A and B, but it will also contains all the updates occurred in
> between. but the restore does not allow you to restore up to a certain
> point in time, the restore will always be up to the "latest backup point".
> - you should limit the number of "incremental" up to N (or maybe SIZE), to
> avoid replay time becoming the bottleneck. (HBASE-14135)
> {quote}
> Update command line tool section
> Clarify restore backup section
> Add section on backup delete algorithm
> Add section on how backup image dependency chain works.
> Add section for configuration
> hbase.backup.enable=true
> hbase.master.logcleaner.plugins=YOUR_PUGINS,org.apache.hadoop.hbase.backup.master.BackupLogCleaner
> hbase.procedure.master.classes=YOUR_CLASSES,org.apache.hadoop.hbase.backup.master.LogRollMasterProcedureManager
> hbase.procedure.regionserver.classes=YOUR_CLASSES,org.apache.hadoop.hbase.backup.regionserver.LogRollRegionServerProcedureManager
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17133) Backup documentation update
[
https://issues.apache.org/jira/browse/HBASE-17133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248097#comment-16248097
]
Josh Elser commented on HBASE-17133:
[~vrodionov], is this meant to capture more than what we already have pending
in HBASE-16574?
> Backup documentation update
> ---
>
> Key: HBASE-17133
> URL: https://issues.apache.org/jira/browse/HBASE-17133
> Project: HBase
> Issue Type: Bug
>Reporter: Vladimir Rodionov
>Priority: Critical
> Labels: backup
> Fix For: 2.0.0
>
>
> We need to update backup doc to sync it with the current implementation and
> to add section for current limitations:
> {quote}
> - if you write to the table with Durability.SKIP_WALS your data will not
> be in the incremental-backup
> - if you bulkload files that data will not be in the incremental backup
> (HBASE-14417)
> - the incremental backup will not only contains the data of the table you
> specified but also the regions from other tables that are on the same set
> of RSs (HBASE-14141) ...maybe a note about security around this topic
> - the incremental backup will not contains just the "latest row" between
> backup A and B, but it will also contains all the updates occurred in
> between. but the restore does not allow you to restore up to a certain
> point in time, the restore will always be up to the "latest backup point".
> - you should limit the number of "incremental" up to N (or maybe SIZE), to
> avoid replay time becoming the bottleneck. (HBASE-14135)
> {quote}
> Update command line tool section
> Clarify restore backup section
> Add section on backup delete algorithm
> Add section on how backup image dependency chain works.
> Add section for configuration
> hbase.backup.enable=true
> hbase.master.logcleaner.plugins=YOUR_PUGINS,org.apache.hadoop.hbase.backup.master.BackupLogCleaner
> hbase.procedure.master.classes=YOUR_CLASSES,org.apache.hadoop.hbase.backup.master.LogRollMasterProcedureManager
> hbase.procedure.regionserver.classes=YOUR_CLASSES,org.apache.hadoop.hbase.backup.regionserver.LogRollRegionServerProcedureManager
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17825) Backup: further optimizations
[ https://issues.apache.org/jira/browse/HBASE-17825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248115#comment-16248115 ] Josh Elser commented on HBASE-17825: Is the "In progress" still accurate, [~vrodionov]? (something you're shooting for 2.0.0-beta-1) > Backup: further optimizations > - > > Key: HBASE-17825 > URL: https://issues.apache.org/jira/browse/HBASE-17825 > Project: HBase > Issue Type: Improvement >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Critical > Labels: backup > Fix For: 2.0.0 > > > Some phases of backup and restore can be optimized: > # WALPlayer support for multiple tables > # Run DistCp once per all tables during backup/restore > The eventual goal: > # 2 M/R jobs per backup/restore -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19237) TestMaster.testMasterOpsWhileSplitting fails
[
https://issues.apache.org/jira/browse/HBASE-19237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248117#comment-16248117
]
Yi Liang commented on HBASE-19237:
--
The reason why above test is fail is that we can not use number of
regionStateNode to decide whether the split is complete or not; i.e use
regionStates.getRegionsOfTable(TABLENAME).size().
We need to visit Meta to know if the split is completed or not.
> TestMaster.testMasterOpsWhileSplitting fails
>
>
> Key: HBASE-19237
> URL: https://issues.apache.org/jira/browse/HBASE-19237
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
> Attachments: 19237.v1.txt
>
>
> This is the top flaky test:
> {code}
> java.lang.AssertionError: expected:<3> but was:<1>
> at
> org.apache.hadoop.hbase.master.TestMaster.testMasterOpsWhileSplitting(TestMaster.java:121)
> {code}
> After brief check, the test failure seems to be introduced by HBASE-19127
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19237) TestMaster.testMasterOpsWhileSplitting fails
[
https://issues.apache.org/jira/browse/HBASE-19237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Liang updated HBASE-19237:
-
Attachment: HBASE-19237-master-v1.patch
> TestMaster.testMasterOpsWhileSplitting fails
>
>
> Key: HBASE-19237
> URL: https://issues.apache.org/jira/browse/HBASE-19237
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
> Attachments: 19237.v1.txt, HBASE-19237-master-v1.patch
>
>
> This is the top flaky test:
> {code}
> java.lang.AssertionError: expected:<3> but was:<1>
> at
> org.apache.hadoop.hbase.master.TestMaster.testMasterOpsWhileSplitting(TestMaster.java:121)
> {code}
> After brief check, the test failure seems to be introduced by HBASE-19127
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19237) TestMaster.testMasterOpsWhileSplitting fails
[
https://issues.apache.org/jira/browse/HBASE-19237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-19237:
---
Attachment: (was: 19237.v1.txt)
> TestMaster.testMasterOpsWhileSplitting fails
>
>
> Key: HBASE-19237
> URL: https://issues.apache.org/jira/browse/HBASE-19237
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
> Attachments: HBASE-19237-master-v1.patch
>
>
> This is the top flaky test:
> {code}
> java.lang.AssertionError: expected:<3> but was:<1>
> at
> org.apache.hadoop.hbase.master.TestMaster.testMasterOpsWhileSplitting(TestMaster.java:121)
> {code}
> After brief check, the test failure seems to be introduced by HBASE-19127
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19240) Fix error-prone errors, part four?
[ https://issues.apache.org/jira/browse/HBASE-19240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248122#comment-16248122 ] Andrew Purtell commented on HBASE-19240: Thanks [~mdrob] [~chia7712]. Over on HBASE-19239 I'm making a pass over important findbugs issues and most error-prone issues in branch-1 / branch-1.4. Done with hbase-common. Working on hbase-client. Will post the result to reviewboard, and a separate patch for each module to the JIRA. > Fix error-prone errors, part four? > -- > > Key: HBASE-19240 > URL: https://issues.apache.org/jira/browse/HBASE-19240 > Project: HBase > Issue Type: Bug >Reporter: Mike Drob >Assignee: Mike Drob > Attachments: HBASE-19240.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19187) Remove option to create on heap bucket cache
[
https://issues.apache.org/jira/browse/HBASE-19187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248123#comment-16248123
]
Hadoop QA commented on HBASE-19187:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
53s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 9 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
36s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 8m
21s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
23s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} The patch hbase-common passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
20s{color} | {color:green} hbase-server: The patch generated 0 new + 153
unchanged - 4 fixed = 153 total (was 157) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
55s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
79m 14s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
33s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}169m
4s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}288m 23s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19187 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12896996/HBASE-19187_V2.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile xml |
| uname | Linux b0aea6df56a0 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 GNU/Linux |
[jira] [Commented] (HBASE-19239) Fix important findbugs and error-prone warnings
[ https://issues.apache.org/jira/browse/HBASE-19239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248125#comment-16248125 ] Andrew Purtell commented on HBASE-19239: bq. I think we should run with MissingOverride and AssertEqualsArgumentOrderChecker disabled. There's far too many hits on both of those to have meaningful results. I've been fixing them. Easy enough. bq. I'm still working through the errors on master and it's pretty slow going. Help is appreciated but I don't want to duplicate effort. We should divide and conquer by branches. I'm working on branch-1 and branch-1.4. Someone else could work on branch-2 and master. > Fix important findbugs and error-prone warnings > --- > > Key: HBASE-19239 > URL: https://issues.apache.org/jira/browse/HBASE-19239 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 3.0.0, 1.4.0, 2.0.0-beta-1 > > Attachments: error-prone-branch-1.4.txt > > > Fix important findbugs and error-prone warnings on branch-1.4 / branch-1. > Forward port as appropriate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19187) Remove option to create on heap bucket cache
[ https://issues.apache.org/jira/browse/HBASE-19187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248127#comment-16248127 ] Ted Yu commented on HBASE-19187: lgtm > Remove option to create on heap bucket cache > > > Key: HBASE-19187 > URL: https://issues.apache.org/jira/browse/HBASE-19187 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 2.0.0-alpha-3 >Reporter: Biju Nair >Assignee: Anoop Sam John >Priority: Minor > Fix For: 2.1.0 > > Attachments: HBASE-19187.patch, HBASE-19187_V2.patch > > > Since we are moving read and write paths to use direct memory, option to > configure on heap bucket cache is irrelevant. We should remove that option. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19239) Fix important findbugs and error-prone warnings
[ https://issues.apache.org/jira/browse/HBASE-19239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248131#comment-16248131 ] Andrew Purtell commented on HBASE-19239: My goal is to tidy branch-1 and branch-1.4 for the 1.4.0 release. We should probably decouple the work done in the different branches and get fixes for branch-2 and master in separately, oriented to the 2.0.0 release schedule. After I'm done with branch-1 I'd be happy to help out on branch-2 and master. > Fix important findbugs and error-prone warnings > --- > > Key: HBASE-19239 > URL: https://issues.apache.org/jira/browse/HBASE-19239 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 3.0.0, 1.4.0, 2.0.0-beta-1 > > Attachments: error-prone-branch-1.4.txt > > > Fix important findbugs and error-prone warnings on branch-1.4 / branch-1. > Forward port as appropriate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19181) LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog
[
https://issues.apache.org/jira/browse/HBASE-19181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248132#comment-16248132
]
Hadoop QA commented on HBASE-19181:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
36s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} hbase-backup: The patch generated 0 new + 2
unchanged - 1 fixed = 2 total (was 3) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
23s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
49m 48s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 16m
16s{color} | {color:green} hbase-backup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 81m 22s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19181 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12896791/HBASE-19181-v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 1a372372360b 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 72270866cb |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9739/testReport/ |
| modules | C: hbase-backup U: hbase-backup |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9739/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automa
[jira] [Commented] (HBASE-19239) Fix important findbugs and error-prone warnings
[ https://issues.apache.org/jira/browse/HBASE-19239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248137#comment-16248137 ] Mike Drob commented on HBASE-19239: --- You may be able to save time by using http://errorprone.info/docs/patching the auto-patching. I was not able to get it to work and was fixing problems manually, but if you have more patience, then maybe it will be fine. > Fix important findbugs and error-prone warnings > --- > > Key: HBASE-19239 > URL: https://issues.apache.org/jira/browse/HBASE-19239 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 3.0.0, 1.4.0, 2.0.0-beta-1 > > Attachments: error-prone-branch-1.4.txt > > > Fix important findbugs and error-prone warnings on branch-1.4 / branch-1. > Forward port as appropriate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16574) Add backup / restore feature to refguide
[ https://issues.apache.org/jira/browse/HBASE-16574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-16574: --- Attachment: HBASE-16574.003.branch-2.patch hbase-book-16574.003.pdf .003 Doc update. Content update with the latest improvements which have landed since the 002 patch was here. Also has some formatting/grammatical changes that bugged me along the way. Will also attach a new PDF version for those who prefer reading the rendered text. > Add backup / restore feature to refguide > > > Key: HBASE-16574 > URL: https://issues.apache.org/jira/browse/HBASE-16574 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Vladimir Rodionov > Labels: backup > Fix For: 2.0.0-beta-1 > > Attachments: B&R command-line tools and configuration (updated).pdf, > Backup-and-Restore-Apache_19Sep2016.pdf, HBASE-16574.001.patch, > HBASE-16574.002.patch, HBASE-16574.003.branch-2.patch, > hbase-book-16574.003.pdf, hbase_reference_guide.v1.pdf > > > This issue is to add backup / restore feature description to hbase refguide. > The description should cover: > scenarios where backup / restore is used > backup / restore commands and sample usage > considerations in setup -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16574) Add backup / restore feature to refguide
[ https://issues.apache.org/jira/browse/HBASE-16574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-16574: --- Status: Patch Available (was: Reopened) > Add backup / restore feature to refguide > > > Key: HBASE-16574 > URL: https://issues.apache.org/jira/browse/HBASE-16574 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Vladimir Rodionov > Labels: backup > Fix For: 2.0.0-beta-1 > > Attachments: B&R command-line tools and configuration (updated).pdf, > Backup-and-Restore-Apache_19Sep2016.pdf, HBASE-16574.001.patch, > HBASE-16574.002.patch, HBASE-16574.003.branch-2.patch, > hbase-book-16574.003.pdf, hbase_reference_guide.v1.pdf > > > This issue is to add backup / restore feature description to hbase refguide. > The description should cover: > scenarios where backup / restore is used > backup / restore commands and sample usage > considerations in setup -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16459) Remove unused hbase shell --format option
[
https://issues.apache.org/jira/browse/HBASE-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248146#comment-16248146
]
Hudson commented on HBASE-16459:
FAILURE: Integrated in Jenkins build HBase-1.1-JDK7 #1942 (See
[https://builds.apache.org/job/HBase-1.1-JDK7/1942/])
HBASE-16459 Remove unused hbase shell --format option (appy: rev
c4e3ad07898b42bf97d560ca1d2213276a4b9f9e)
* (edit) bin/hirb.rb
> Remove unused hbase shell --format option
> -
>
> Key: HBASE-16459
> URL: https://issues.apache.org/jira/browse/HBASE-16459
> Project: HBase
> Issue Type: Task
> Components: shell
>Reporter: Dima Spivak
>Assignee: Dima Spivak
>Priority: Trivial
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-16459.master.001.patch, HBASE-16459.patch,
> HBASE-16459_v2.patch
>
>
> The usage information when running {{hbase shell}} refers to a formatter
> option that has yet to implemented in over 8 years and which will ostensibly
> never be implemented. As such, let's cleanup the [help
> message|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L57-L59] and
> remove some extraneous lines of code from
> {{[hirb.rb|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L74-L83]}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-16459) Remove unused hbase shell --format option
[
https://issues.apache.org/jira/browse/HBASE-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248150#comment-16248150
]
Hudson commented on HBASE-16459:
FAILURE: Integrated in Jenkins build HBase-1.4 #1010 (See
[https://builds.apache.org/job/HBase-1.4/1010/])
HBASE-16459 Remove unused hbase shell --format option (appy: rev
999cd0c3e8633312115fd568e2cdef0ff83e3f96)
* (edit) bin/hirb.rb
> Remove unused hbase shell --format option
> -
>
> Key: HBASE-16459
> URL: https://issues.apache.org/jira/browse/HBASE-16459
> Project: HBase
> Issue Type: Task
> Components: shell
>Reporter: Dima Spivak
>Assignee: Dima Spivak
>Priority: Trivial
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-16459.master.001.patch, HBASE-16459.patch,
> HBASE-16459_v2.patch
>
>
> The usage information when running {{hbase shell}} refers to a formatter
> option that has yet to implemented in over 8 years and which will ostensibly
> never be implemented. As such, let's cleanup the [help
> message|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L57-L59] and
> remove some extraneous lines of code from
> {{[hirb.rb|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L74-L83]}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19232) Fix shaded-check-invariants (check-jar-contents) failure on branch-1
[
https://issues.apache.org/jira/browse/HBASE-19232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248148#comment-16248148
]
Hadoop QA commented on HBASE-19232:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 16m
4s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
24s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
23s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} branch-1 passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 11m
44s{color} | {color:red} branch has 12 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} branch-1 passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} the patch passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 3 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
9s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
25m 44s{color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3
2.7.4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} the patch passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
1s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
33s{color} | {color:green} hbase-procedure in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
12s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
26s{color} | {color:green} hbase-prefix-tree in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
29s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color
[jira] [Commented] (HBASE-16459) Remove unused hbase shell --format option
[
https://issues.apache.org/jira/browse/HBASE-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248171#comment-16248171
]
Hudson commented on HBASE-16459:
FAILURE: Integrated in Jenkins build HBase-1.5 #149 (See
[https://builds.apache.org/job/HBase-1.5/149/])
HBASE-16459 Remove unused hbase shell --format option (appy: rev
090ded5686a07b72f5d986c62d3b38e9c331df73)
* (edit) bin/hirb.rb
> Remove unused hbase shell --format option
> -
>
> Key: HBASE-16459
> URL: https://issues.apache.org/jira/browse/HBASE-16459
> Project: HBase
> Issue Type: Task
> Components: shell
>Reporter: Dima Spivak
>Assignee: Dima Spivak
>Priority: Trivial
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-16459.master.001.patch, HBASE-16459.patch,
> HBASE-16459_v2.patch
>
>
> The usage information when running {{hbase shell}} refers to a formatter
> option that has yet to implemented in over 8 years and which will ostensibly
> never be implemented. As such, let's cleanup the [help
> message|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L57-L59] and
> remove some extraneous lines of code from
> {{[hirb.rb|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L74-L83]}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-16459) Remove unused hbase shell --format option
[
https://issues.apache.org/jira/browse/HBASE-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248177#comment-16248177
]
Hudson commented on HBASE-16459:
SUCCESS: Integrated in Jenkins build HBase-1.1-JDK8 #2027 (See
[https://builds.apache.org/job/HBase-1.1-JDK8/2027/])
HBASE-16459 Remove unused hbase shell --format option (appy: rev
c4e3ad07898b42bf97d560ca1d2213276a4b9f9e)
* (edit) bin/hirb.rb
> Remove unused hbase shell --format option
> -
>
> Key: HBASE-16459
> URL: https://issues.apache.org/jira/browse/HBASE-16459
> Project: HBase
> Issue Type: Task
> Components: shell
>Reporter: Dima Spivak
>Assignee: Dima Spivak
>Priority: Trivial
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-16459.master.001.patch, HBASE-16459.patch,
> HBASE-16459_v2.patch
>
>
> The usage information when running {{hbase shell}} refers to a formatter
> option that has yet to implemented in over 8 years and which will ostensibly
> never be implemented. As such, let's cleanup the [help
> message|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L57-L59] and
> remove some extraneous lines of code from
> {{[hirb.rb|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L74-L83]}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17825) Backup: further optimizations
[ https://issues.apache.org/jira/browse/HBASE-17825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248178#comment-16248178 ] Vladimir Rodionov commented on HBASE-17825: --- Yes, I think. I will return to this when we finish testing. > Backup: further optimizations > - > > Key: HBASE-17825 > URL: https://issues.apache.org/jira/browse/HBASE-17825 > Project: HBase > Issue Type: Improvement >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Critical > Labels: backup > Fix For: 2.0.0 > > > Some phases of backup and restore can be optimized: > # WALPlayer support for multiple tables > # Run DistCp once per all tables during backup/restore > The eventual goal: > # 2 M/R jobs per backup/restore -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16574) Add backup / restore feature to refguide
[ https://issues.apache.org/jira/browse/HBASE-16574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248181#comment-16248181 ] Vladimir Rodionov commented on HBASE-16574: --- I would like to thank both [~fwelsch] and [~elserj] for this very solid feature doc. > Add backup / restore feature to refguide > > > Key: HBASE-16574 > URL: https://issues.apache.org/jira/browse/HBASE-16574 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Vladimir Rodionov > Labels: backup > Fix For: 2.0.0-beta-1 > > Attachments: B&R command-line tools and configuration (updated).pdf, > Backup-and-Restore-Apache_19Sep2016.pdf, HBASE-16574.001.patch, > HBASE-16574.002.patch, HBASE-16574.003.branch-2.patch, > hbase-book-16574.003.pdf, hbase_reference_guide.v1.pdf > > > This issue is to add backup / restore feature description to hbase refguide. > The description should cover: > scenarios where backup / restore is used > backup / restore commands and sample usage > considerations in setup -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19200) make hbase-client only depend on ZKAsyncRegistry and ZNodePaths
[ https://issues.apache.org/jira/browse/HBASE-19200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248215#comment-16248215 ] Hudson commented on HBASE-19200: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4032 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4032/]) HBASE-19200 Make hbase-client only depend on ZKAsyncRegistry and (appy: rev 72270866cbacbcfd10f2ad2cce33362577eeef4d) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKMulti.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ZKPermissionWatcher.java * (edit) hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/example/ZKTableArchiveClient.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestZKSecretWatcherRefreshKeys.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZNodePaths.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperNodeTracker.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitLogWorker.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestMetaReplicas.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClusterConnection.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/SplitOrMergeTracker.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/example/HFileArchiveManager.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZKAsyncRegistry.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentListener.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java * (edit) hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/VerifyingRSGroupAdminClient.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationTrackerZKImpl.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestZKAndFSPermissions.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaCache.java * (delete) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZooKeeperKeepAliveConnection.java * (delete) hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegistryFactory.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZkAclReset.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStateHBaseImpl.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkSplitLogWorkerCoordination.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKSplitLog.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/ZKSecretWatcher.java * (delete) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZooKeeperRegistry.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKMetadata.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/ZKNamespaceManager.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperWatcher.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaWithReplicas.java * (add) hbase-client/src/test/java/org/apache/hadoop/hbase/client/DoNothingAsyncRegistry.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestMasterReplication.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java * (edit) hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesClientZKImpl.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ZKVisibilityLabelWatcher.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestBufferedMutator.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedure
[jira] [Commented] (HBASE-19237) TestMaster.testMasterOpsWhileSplitting fails
[
https://issues.apache.org/jira/browse/HBASE-19237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248225#comment-16248225
]
Hadoop QA commented on HBASE-19237:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
2s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
24s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
19s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
48m 58s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}112m
42s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}180m 1s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19237 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897122/19237.v1.txt |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 60241e5124f0 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 72270866cb |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9738/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9738/console |
| Powered by
