[jira] [Commented] (HBASE-19114) Split out o.a.h.h.zookeeper from hbase-server and hbase-client
[ https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254892#comment-16254892 ] stack commented on HBASE-19114: --- Go for it I'd say [~appy] commit after doing check of the root test failure... > Split out o.a.h.h.zookeeper from hbase-server and hbase-client > -- > > Key: HBASE-19114 > URL: https://issues.apache.org/jira/browse/HBASE-19114 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19114.master.001.patch, > HBASE-19114.master.002.patch, HBASE-19114.master.003.patch, > HBASE-19114.master.004.patch, HBASE-19114.master.005.patch, > HBASE-19114.master.006.patch, HBASE-19114.master.007.patch, > HBASE-19114.master.008.patch > > > Changes so far: > - Moved DrainingServerTracker and RegionServerTracker to > hbase-server:o.a.h.h.master. > - Moved SplitOrMergeTracker to oahh.master (because it depends on a PB) > - Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. After > [~Apache9]'s cleanup (HBASE-19200), hbase-client doesn't need them anymore > (except 3 classes). > - Renamed some classes to use a consistent naming for classes - ZK instead of > mix of ZK, Zk , ZooKeeper. Couldn't rename following public classes: > MiniZooKeeperCluster, ZooKeeperConnectionException. Left RecoverableZooKeeper > for lack of better name. (suggestions?) > - Sadly, can't move tests out because they depend on HBaseTestingUtility > (which defeats part of the purpose - trimming down hbase-server tests. We > need to promote more use of mocks in our tests) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18357) Enable disabled tests in TestHCM that were disabled by Proc-V2 AM in HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-18357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254889#comment-16254889 ] Hudson commented on HBASE-18357: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4060 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4060/]) HBASE-18357 Enable disabled tests in TestHCM that were disabled by (stack: rev 3a4655019dee68d4d0d18726f12b33fefbce078d) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MoveRegionProcedure.java * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestDropTimeoutRequest.java > Enable disabled tests in TestHCM that were disabled by Proc-V2 AM in > HBASE-14614 > > > Key: HBASE-18357 > URL: https://issues.apache.org/jira/browse/HBASE-18357 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-beta-1 >Reporter: Stephen Yuan Jiang >Assignee: stack > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18357-v1.patch, HBASE-18357.master.001.patch > > > The Core Proc-V2 AM change in HBASE-14614 disabled two tests inTestHCM: > testMulti and testRegionCaching > This JIRA tracks the work to enable them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18309) Support multi threads in CleanerChore
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254885#comment-16254885
]
Hadoop QA commented on HBASE-18309:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
58s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
13s{color} | {color:red} hbase-server: The patch generated 3 new + 5 unchanged
- 3 fixed = 8 total (was 8) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
55s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
52m 26s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 97m
1s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}170m 1s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18309 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897920/HBASE-18309.master.006.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 5a2c6f3c9619 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 3a4655019d |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/9850/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9850/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9850/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was
[jira] [Updated] (HBASE-19252) Move the transform logic of FilterList into transformCell() method to avoid extra ref to question cell
[
https://issues.apache.org/jira/browse/HBASE-19252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zheng Hu updated HBASE-19252:
-
Attachment: HBASE-19252.v4.patch
> Move the transform logic of FilterList into transformCell() method to avoid
> extra ref to question cell
> ---
>
> Key: HBASE-19252
> URL: https://issues.apache.org/jira/browse/HBASE-19252
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Minor
> Fix For: 2.0.0, 1.4.1
>
> Attachments: HBASE-19252.v1.patch, HBASE-19252.v2.patch,
> HBASE-19252.v3.patch, HBASE-19252.v4.patch
>
>
> As [~anoop.hbase] and I discussed, we can implement the filterKeyValue ()
> and transformCell() methods as following to avoid saving transformedCell &
> referenceCell state in FilterList, and we can avoid the costly cell clone.
> {code}
> ReturnCode filterKeyValue(Cell c){
> ReturnCode rc = null;
> for(Filter filter: sub-filters){
> // ...
> rc = mergeReturnCode(rc, filter.filterKeyValue(c));
> // ...
> }
> return rc;
> }
> Cell transformCell(Cell c) throws IOException {
> Cell transformed = c;
> for(Filter filter: sub-filters){
> if(filter.filterKeyValue(c) is INCLUDE*) { // > line#1
> transformed = filter.transformCell(transformed);
>
> }
> }
> return transformed;
> }
> {code}
> For line #1, we need to remember the return code of the sub-filter for its
> filterKeyValue(). because only INCLUDE* ReturnCode, we need to
> transformCell for sub-filter.
> A new boolean array will be introduced in FilterList. and the cost of
> maintaining the boolean array will be less than the cost of maintaining the
> two ref of question cell.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19009) implement modifyTable and enable/disableTableReplication for AsyncAdmin
[ https://issues.apache.org/jira/browse/HBASE-19009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19009: --- Attachment: HBASE-19009.master.addendum.patch > implement modifyTable and enable/disableTableReplication for AsyncAdmin > --- > > Key: HBASE-19009 > URL: https://issues.apache.org/jira/browse/HBASE-19009 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-19009.master.001.patch, > HBASE-19009.master.002.patch, HBASE-19009.master.003.patch, > HBASE-19009.master.004.patch, HBASE-19009.master.005.patch, > HBASE-19009.master.006.patch, HBASE-19009.master.007.patch, > HBASE-19009.master.008.patch, HBASE-19009.master.009.patch, > HBASE-19009.master.010.patch, HBASE-19009.master.011.patch, > HBASE-19009.master.012.patch, HBASE-19009.master.addendum.patch > > > Add 3 methods to AsyncAdmin. > modifyTable() > enableTableReplication() > disableTableReplication() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19009) implement modifyTable and enable/disableTableReplication for AsyncAdmin
[ https://issues.apache.org/jira/browse/HBASE-19009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19009: --- Status: Patch Available (was: Reopened) > implement modifyTable and enable/disableTableReplication for AsyncAdmin > --- > > Key: HBASE-19009 > URL: https://issues.apache.org/jira/browse/HBASE-19009 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-19009.master.001.patch, > HBASE-19009.master.002.patch, HBASE-19009.master.003.patch, > HBASE-19009.master.004.patch, HBASE-19009.master.005.patch, > HBASE-19009.master.006.patch, HBASE-19009.master.007.patch, > HBASE-19009.master.008.patch, HBASE-19009.master.009.patch, > HBASE-19009.master.010.patch, HBASE-19009.master.011.patch, > HBASE-19009.master.012.patch, HBASE-19009.master.addendum.patch > > > Add 3 methods to AsyncAdmin. > modifyTable() > enableTableReplication() > disableTableReplication() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19009) implement modifyTable and enable/disableTableReplication for AsyncAdmin
[ https://issues.apache.org/jira/browse/HBASE-19009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254880#comment-16254880 ] Guanghao Zhang commented on HBASE-19009: Attach a addendum to fix the hbase-shell problem. > implement modifyTable and enable/disableTableReplication for AsyncAdmin > --- > > Key: HBASE-19009 > URL: https://issues.apache.org/jira/browse/HBASE-19009 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-19009.master.001.patch, > HBASE-19009.master.002.patch, HBASE-19009.master.003.patch, > HBASE-19009.master.004.patch, HBASE-19009.master.005.patch, > HBASE-19009.master.006.patch, HBASE-19009.master.007.patch, > HBASE-19009.master.008.patch, HBASE-19009.master.009.patch, > HBASE-19009.master.010.patch, HBASE-19009.master.011.patch, > HBASE-19009.master.012.patch, HBASE-19009.master.addendum.patch > > > Add 3 methods to AsyncAdmin. > modifyTable() > enableTableReplication() > disableTableReplication() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (HBASE-19009) implement modifyTable and enable/disableTableReplication for AsyncAdmin
[ https://issues.apache.org/jira/browse/HBASE-19009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reopened HBASE-19009: > implement modifyTable and enable/disableTableReplication for AsyncAdmin > --- > > Key: HBASE-19009 > URL: https://issues.apache.org/jira/browse/HBASE-19009 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-19009.master.001.patch, > HBASE-19009.master.002.patch, HBASE-19009.master.003.patch, > HBASE-19009.master.004.patch, HBASE-19009.master.005.patch, > HBASE-19009.master.006.patch, HBASE-19009.master.007.patch, > HBASE-19009.master.008.patch, HBASE-19009.master.009.patch, > HBASE-19009.master.010.patch, HBASE-19009.master.011.patch, > HBASE-19009.master.012.patch, HBASE-19009.master.addendum.patch > > > Add 3 methods to AsyncAdmin. > modifyTable() > enableTableReplication() > disableTableReplication() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18964) Deprecate RowProcessor and processRowsWithLocks() APIs that take RowProcessor as an argument
[ https://issues.apache.org/jira/browse/HBASE-18964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18964: -- Resolution: Fixed Hadoop Flags: Reviewed Release Note: RowProcessor and Region#processRowsWithLocks() methods that take RowProcessor as an argument are deprecated. Use Coprocessors if you want to customize handling. (was: RowProcessor and Region#processRowsWithLocks() methods that take RowProcessor as an argument are deprecated.) Status: Resolved (was: Patch Available) Pushed to master and branch-2. [~uagashe] Thanks for the patch. You saw [~anoop.hbase] note up in rb that we should add pointer to example on deprecation message when we have one. Thanks. > Deprecate RowProcessor and processRowsWithLocks() APIs that take RowProcessor > as an argument > > > Key: HBASE-18964 > URL: https://issues.apache.org/jira/browse/HBASE-18964 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Affects Versions: 2.0.0-alpha-3 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0-beta-1 > > Attachments: hbase-18964.master.001.patch, > hbase-18964.master.002.patch, hbase-18964.master.002.patch > > > Deprecate RowProcessor and processRowsWithLocks() APIs that take RowProcessor > as an argument -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19270) Reenable TestRegionMergeTransactionOnCluster#testMergeWithReplicas disable by HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-19270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19270: -- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to master and branch-2. > Reenable TestRegionMergeTransactionOnCluster#testMergeWithReplicas disable by > HBASE-14614 > - > > Key: HBASE-19270 > URL: https://issues.apache.org/jira/browse/HBASE-19270 > Project: HBase > Issue Type: Sub-task > Components: Region Assignment >Reporter: stack >Assignee: stack > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19270.master.001.patch, > HBASE-19270.master.002.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18356) Enable TestFavoredStochasticBalancerPickers#testPickers that was disabled by Proc-V2 AM in HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18356: -- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to branch-2 and master. > Enable TestFavoredStochasticBalancerPickers#testPickers that was disabled by > Proc-V2 AM in HBASE-14614 > -- > > Key: HBASE-18356 > URL: https://issues.apache.org/jira/browse/HBASE-18356 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-1 >Reporter: Stephen Yuan Jiang >Assignee: Thiruvel Thirumoolan > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18356.master.001.patch, > HBASE-18356.master.002.patch > > > The testPickers in TestFavoredStochasticBalancerPickers hangs after applying > the change in Core Proc-V2 AM in HBASE-14614. It was disabled. > This JIRA tracks the work to enable it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19278) Reenable cleanup in test teardown in TestAccessController3 disabled by HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-19278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19278: -- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to branch-2 and to master. > Reenable cleanup in test teardown in TestAccessController3 disabled by > HBASE-14614 > -- > > Key: HBASE-19278 > URL: https://issues.apache.org/jira/browse/HBASE-19278 > Project: HBase > Issue Type: Sub-task > Components: Region Assignment >Reporter: stack >Assignee: stack > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19278.master.001.patch > > > We'd commented out cleanup in the test because test was stalling on it. This > issue is about restoring it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19276) RegionPlan should correctly implement equals and hashCode
[ https://issues.apache.org/jira/browse/HBASE-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254864#comment-16254864 ] stack commented on HBASE-19276: --- .001 Revamps compareTo. Feel free to by-pass my experient [~apurtell] and commit your patch. Just trying this overnight to see who might be relying on dodgy compareTo in RegionPlan. > RegionPlan should correctly implement equals and hashCode > - > > Key: HBASE-19276 > URL: https://issues.apache.org/jira/browse/HBASE-19276 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 2.0.0-beta-1 > > Attachments: HBASE-19276-branch-1.patch, > HBASE-19276.master.001.patch, HBASE-19276.patch > > > error-prone identified dodgy code in AssignmentManager where we are relying > on reference (object) equality to do the right thing, and are getting lucky, > because if we properly used equals() the result is wrong, because RegionPlan > does not correctly implement equals and hashCode according to the JDK > contracts for same. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19276) RegionPlan should correctly implement equals and hashCode
[ https://issues.apache.org/jira/browse/HBASE-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19276: -- Attachment: HBASE-19276.master.001.patch > RegionPlan should correctly implement equals and hashCode > - > > Key: HBASE-19276 > URL: https://issues.apache.org/jira/browse/HBASE-19276 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 2.0.0-beta-1 > > Attachments: HBASE-19276-branch-1.patch, > HBASE-19276.master.001.patch, HBASE-19276.patch > > > error-prone identified dodgy code in AssignmentManager where we are relying > on reference (object) equality to do the right thing, and are getting lucky, > because if we properly used equals() the result is wrong, because RegionPlan > does not correctly implement equals and hashCode according to the JDK > contracts for same. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19278) Reenable cleanup in test teardown in TestAccessController3 disabled by HBASE-14614
[
https://issues.apache.org/jira/browse/HBASE-19278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254855#comment-16254855
]
Hadoop QA commented on HBASE-19278:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
58s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
28s{color} | {color:green} hbase-server: The patch generated 0 new + 14
unchanged - 4 fixed = 14 total (was 18) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
51s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
71m 21s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}137m
45s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}238m 4s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19278 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897907/HBASE-19278.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 2ba694277fd7 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 3a4655019d |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9846/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9846/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Reenable cleanup in test teardown in TestAccessController3 disabled by
> HBASE-14614
> -
[jira] [Commented] (HBASE-19269) Reenable TestShellRSGroups
[ https://issues.apache.org/jira/browse/HBASE-19269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254852#comment-16254852 ] Guangxu Cheng commented on HBASE-19269: --- These failed tests are related to HBASE-19009. I will resubmit a new patch to fix ruby warning later. > Reenable TestShellRSGroups > -- > > Key: HBASE-19269 > URL: https://issues.apache.org/jira/browse/HBASE-19269 > Project: HBase > Issue Type: Sub-task > Components: test >Reporter: stack >Assignee: Guangxu Cheng > Fix For: 2.0.0 > > Attachments: HBASE-19269.master.001.patch > > > It was disabled by the parent issue because RSGroups was failing. RSGroups > now works but this test is still failling. Need to dig in (signal from these > jruby tests is murky). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19009) implement modifyTable and enable/disableTableReplication for AsyncAdmin
[ https://issues.apache.org/jira/browse/HBASE-19009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254848#comment-16254848 ] Guanghao Zhang commented on HBASE-19009: Sorry... Let me attach a addendum to fix it. > implement modifyTable and enable/disableTableReplication for AsyncAdmin > --- > > Key: HBASE-19009 > URL: https://issues.apache.org/jira/browse/HBASE-19009 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-19009.master.001.patch, > HBASE-19009.master.002.patch, HBASE-19009.master.003.patch, > HBASE-19009.master.004.patch, HBASE-19009.master.005.patch, > HBASE-19009.master.006.patch, HBASE-19009.master.007.patch, > HBASE-19009.master.008.patch, HBASE-19009.master.009.patch, > HBASE-19009.master.010.patch, HBASE-19009.master.011.patch, > HBASE-19009.master.012.patch > > > Add 3 methods to AsyncAdmin. > modifyTable() > enableTableReplication() > disableTableReplication() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18356) Enable TestFavoredStochasticBalancerPickers#testPickers that was disabled by Proc-V2 AM in HBASE-14614
[
https://issues.apache.org/jira/browse/HBASE-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254845#comment-16254845
]
Hadoop QA commented on HBASE-18356:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
2s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
11s{color} | {color:red} hbase-server: The patch generated 7 new + 9 unchanged
- 1 fixed = 16 total (was 10) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
5s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
56m 53s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 97m
54s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}175m 5s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18356 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897913/HBASE-18356.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux fd14fec5208c 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18
11:55:51 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 3a4655019d |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/9847/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9847/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9847/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was
[jira] [Commented] (HBASE-19009) implement modifyTable and enable/disableTableReplication for AsyncAdmin
[ https://issues.apache.org/jira/browse/HBASE-19009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254843#comment-16254843 ] Guangxu Cheng commented on HBASE-19009: --- [~zghaobac] the class ReplicationSerDeHelper was deleted. But ReplicationSerDeHelper is still used in replication_admin.rb. > implement modifyTable and enable/disableTableReplication for AsyncAdmin > --- > > Key: HBASE-19009 > URL: https://issues.apache.org/jira/browse/HBASE-19009 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-19009.master.001.patch, > HBASE-19009.master.002.patch, HBASE-19009.master.003.patch, > HBASE-19009.master.004.patch, HBASE-19009.master.005.patch, > HBASE-19009.master.006.patch, HBASE-19009.master.007.patch, > HBASE-19009.master.008.patch, HBASE-19009.master.009.patch, > HBASE-19009.master.010.patch, HBASE-19009.master.011.patch, > HBASE-19009.master.012.patch > > > Add 3 methods to AsyncAdmin. > modifyTable() > enableTableReplication() > disableTableReplication() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[ https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18911: --- Attachment: HBASE-18911.master.002.patch > Unify Admin and AsyncAdmin's methods name > - > > Key: HBASE-18911 > URL: https://issues.apache.org/jira/browse/HBASE-18911 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18911.master.001.patch, > HBASE-18911.master.002.patch > > > Different Methods > || AsyncAdmin || Admin || unified name || > | listTables | listTableDescriptors | listTableDescriptors | > | getOnlineRegions | getRegions | getRegions | > | getTableRegions | getRegions | getRegions | > | getTableDescriptor | getDescriptor | getDescriptor | > | getRegionLoads | getRegionLoad | getRegionLoads | > | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn | > | setNormalizerOn | normalizerSwitch | normalizerSwitch | > | isNormalizerOn | isNormalizerEnabled | isNormalizerEnabled | > | setBalancerOn | balancerSwitch | balancerSwitch | > | isBalancerOn | isBalancerEnabled | isBalancerEnabled | > | setCleanerChoreOn | cleanerChoreSwitch | cleanerChoreSwitch | > | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreEnabled | > | setCatalogJanitorOn | catalogJanitorSwitch | catalogJanitorSwitch | > | isCatalogJanitorOn | isCatalogJanitorEnabled | isCatalogJanitorEnabled | > | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | splitSwitch/mergeSwitch > | > | isSplitOn/isMergeOn| isSplitOrMergeEnabled | isSplitEnabled/isMergeEnabled | > Methods only in AsyncAdmin > || AsyncAdmin || > | majorCompactRegionServer | > | getMaster | > | getBackupMasters | > | getRegionServers | > Methods only in Admin > || Admin || > | listTableDescriptorsByNamespace | > | listTableNamesByNamespace | > | modifyTable | > | getMasterCoprocessors | -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19092) Make Tag IA.LimitedPrivate and expose for CPs
[ https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-19092: --- Status: Patch Available (was: Open) Test case failure was unrelated. TestHStore seems to pass. Other checkstyle comments seems to be new to me. The import changes happened due to IDE. I have tried to revert them to see what CheckStyle says now. Also the PrivatecellUtil extends CellUtil is a complaint from checkstyle since now we have default constructor for Util class. I have not changed that for now. will see what QA says. > Make Tag IA.LimitedPrivate and expose for CPs > - > > Key: HBASE-19092 > URL: https://issues.apache.org/jira/browse/HBASE-19092 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19092-branch-2.patch, > HBASE-19092-branch-2_5.patch, HBASE-19092-branch-2_5.patch, > HBASE-19092.branch-2.0.02.patch, HBASE-19092_001-branch-2.patch, > HBASE-19092_001.patch, HBASE-19092_002-branch-2.patch, HBASE-19092_002.patch > > > We need to make tags as LimitedPrivate as some use cases are trying to use > tags like timeline server. The same topic was discussed in dev@ and also in > HBASE-18995. > Shall we target this for beta1 - cc [~saint@gmail.com]. > So once we do this all related Util methods and APIs should also move to > LimitedPrivate Util classes. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19092) Make Tag IA.LimitedPrivate and expose for CPs
[ https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-19092: --- Attachment: HBASE-19092_002.patch Retry QA. > Make Tag IA.LimitedPrivate and expose for CPs > - > > Key: HBASE-19092 > URL: https://issues.apache.org/jira/browse/HBASE-19092 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19092-branch-2.patch, > HBASE-19092-branch-2_5.patch, HBASE-19092-branch-2_5.patch, > HBASE-19092.branch-2.0.02.patch, HBASE-19092_001-branch-2.patch, > HBASE-19092_001.patch, HBASE-19092_002-branch-2.patch, HBASE-19092_002.patch > > > We need to make tags as LimitedPrivate as some use cases are trying to use > tags like timeline server. The same topic was discussed in dev@ and also in > HBASE-18995. > Shall we target this for beta1 - cc [~saint@gmail.com]. > So once we do this all related Util methods and APIs should also move to > LimitedPrivate Util classes. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19092) Make Tag IA.LimitedPrivate and expose for CPs
[ https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-19092: --- Status: Open (was: Patch Available) > Make Tag IA.LimitedPrivate and expose for CPs > - > > Key: HBASE-19092 > URL: https://issues.apache.org/jira/browse/HBASE-19092 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19092-branch-2.patch, > HBASE-19092-branch-2_5.patch, HBASE-19092-branch-2_5.patch, > HBASE-19092.branch-2.0.02.patch, HBASE-19092_001-branch-2.patch, > HBASE-19092_001.patch, HBASE-19092_002-branch-2.patch > > > We need to make tags as LimitedPrivate as some use cases are trying to use > tags like timeline server. The same topic was discussed in dev@ and also in > HBASE-18995. > Shall we target this for beta1 - cc [~saint@gmail.com]. > So once we do this all related Util methods and APIs should also move to > LimitedPrivate Util classes. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19270) Reenable TestRegionMergeTransactionOnCluster#testMergeWithReplicas disable by HBASE-14614
[
https://issues.apache.org/jira/browse/HBASE-19270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254834#comment-16254834
]
Hadoop QA commented on HBASE-19270:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
26s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
4s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
56s{color} | {color:green} hbase-server: The patch generated 0 new + 2
unchanged - 1 fixed = 2 total (was 3) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
11s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
46m 39s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 98m
38s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}164m 42s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19270 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897914/HBASE-19270.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 9c22070d2246 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 3a4655019d |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9848/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9848/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Reenable TestRegionMergeTransactionOnCluster#testMergeWithReplicas disable by
> HBASE-14614
>
[jira] [Updated] (HBASE-19251) Merge RawAsyncTable and AsyncTable
[ https://issues.apache.org/jira/browse/HBASE-19251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19251: -- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to master and branch-2. Thanks [~appy] for reviewing. > Merge RawAsyncTable and AsyncTable > -- > > Key: HBASE-19251 > URL: https://issues.apache.org/jira/browse/HBASE-19251 > Project: HBase > Issue Type: Improvement > Components: asyncclient, Client >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19251-v1.patch, HBASE-19251-v2.patch, > HBASE-19251.patch > > > As discussed in HBASE-18978. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19251) Merge RawAsyncTable and AsyncTable
[ https://issues.apache.org/jira/browse/HBASE-19251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254824#comment-16254824 ] Duo Zhang commented on HBASE-19251: --- Will commit shortly after fixing the checkstyle warning. > Merge RawAsyncTable and AsyncTable > -- > > Key: HBASE-19251 > URL: https://issues.apache.org/jira/browse/HBASE-19251 > Project: HBase > Issue Type: Improvement > Components: asyncclient, Client >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19251-v1.patch, HBASE-19251-v2.patch, > HBASE-19251.patch > > > As discussed in HBASE-18978. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19139) Create Async Admin methods for Clear Block Cache
[ https://issues.apache.org/jira/browse/HBASE-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254823#comment-16254823 ] Guanghao Zhang commented on HBASE-19139: I am work for HBASE-18911. Then found this. Any progress here? [~zyork] > Create Async Admin methods for Clear Block Cache > > > Key: HBASE-19139 > URL: https://issues.apache.org/jira/browse/HBASE-19139 > Project: HBase > Issue Type: Improvement > Components: Admin >Reporter: Zach York >Assignee: Zach York > > As part of the review for HBASE-18624, reviewers suggested to add the > clear_block_cache to the AsyncAdmin as well. Since the issue was very large, > we decided to split this into a follow-up JIRA. The purpose of this JIRA will > be to finish the work on the AsyncAdmin. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19269) Reenable TestShellRSGroups
[
https://issues.apache.org/jira/browse/HBASE-19269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254818#comment-16254818
]
Hadoop QA commented on HBASE-19269:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
3s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
13s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
4s{color} | {color:red} The patch generated 3 new + 12 unchanged - 3 fixed = 15
total (was 15) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m
2s{color} | {color:red} The patch generated 6 new + 24 unchanged - 4 fixed = 30
total (was 28) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
38s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
79m 30s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 5m 42s{color}
| {color:red} hbase-shell in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}107m 34s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestShell |
| | hadoop.hbase.client.TestShellNoCluster |
| | hadoop.hbase.client.rsgroup.TestShellRSGroups |
| | hadoop.hbase.client.TestReplicationShell |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19269 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897917/HBASE-19269.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile rubocop ruby_lint |
| uname | Linux 53f6cd833501 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 3a4655019d |
| maven | version: Apac
[jira] [Commented] (HBASE-19260) Add lock back to avoid parallel accessing meta to locate region
[
https://issues.apache.org/jira/browse/HBASE-19260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254815#comment-16254815
]
Yu Li commented on HBASE-19260:
---
Thanks for review and note sir [~stack]. Will commit soon.
> Add lock back to avoid parallel accessing meta to locate region
> ---
>
> Key: HBASE-19260
> URL: https://issues.apache.org/jira/browse/HBASE-19260
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.1, 1.2.6, 2.0.0-alpha-3, 1.1.12
>Reporter: Yu Li
>Assignee: Yu Li
> Attachments: HBASE-19260.patch, HBASE-19260.v2.patch
>
>
> In branch-0.98 we have below codes to avoid accessing meta in parallel in
> {{HConnectionManager}}:
> {code}
> Result regionInfoRow;
> // This block guards against two threads trying to load the meta
> // region at the same time. The first will load the meta region and
> // the second will use the value that the first one found.
> if (useCache) {
> if (TableName.META_TABLE_NAME.equals(parentTable) && usePrefetch
> &&
> getRegionCachePrefetch(tableName)) {
> synchronized (regionLockObject) {
> // Check the cache again for a hit in case some other thread
> made the
> // same query while we were waiting on the lock.
> ...
> }
> }
> ...
> {code}
> while in HBASE-10018 we removed such logic along with
> region-location-prefetching.
> We regard this as an unexpected behavior change and observed below phenomenon
> in our product env:
> 1. Unnecessary connection setup to meta when multiple threads locating region
> in a client process
> 2. Priority handler of the RS holding meta region exhausted, application keep
> retrying and cause a vicious circle
> To resolve this problem, we propose to add the {{userRegionLock}} back and
> keep the behavior in accordance with 0.98
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19276) RegionPlan should correctly implement equals and hashCode
[ https://issues.apache.org/jira/browse/HBASE-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254814#comment-16254814 ] stack commented on HBASE-19276: --- Mind if I try changing the compare to to use your new equals [~apurtell]? (+1 on the patch but the compareTo that equates on region name though the destination servers might be completely different... or the source servers even seems wrong) > RegionPlan should correctly implement equals and hashCode > - > > Key: HBASE-19276 > URL: https://issues.apache.org/jira/browse/HBASE-19276 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 2.0.0-beta-1 > > Attachments: HBASE-19276-branch-1.patch, HBASE-19276.patch > > > error-prone identified dodgy code in AssignmentManager where we are relying > on reference (object) equality to do the right thing, and are getting lucky, > because if we properly used equals() the result is wrong, because RegionPlan > does not correctly implement equals and hashCode according to the JDK > contracts for same. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19279) Reenable TestMasterBalanceThrottling disabled by HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-19279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254810#comment-16254810 ] stack commented on HBASE-19279: --- Moved out of 2.0.0-beta-1 > Reenable TestMasterBalanceThrottling disabled by HBASE-14614 > > > Key: HBASE-19279 > URL: https://issues.apache.org/jira/browse/HBASE-19279 > Project: HBase > Issue Type: Sub-task > Components: Region Assignment >Reporter: stack > Fix For: 2.0.0 > > > See head of class for a comment. It depends on simpleloadbalancer which seems > broke. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19279) Reenable TestMasterBalanceThrottling disabled by HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-19279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19279: -- Fix Version/s: (was: 2.0.0-beta-1) 2.0.0 > Reenable TestMasterBalanceThrottling disabled by HBASE-14614 > > > Key: HBASE-19279 > URL: https://issues.apache.org/jira/browse/HBASE-19279 > Project: HBase > Issue Type: Sub-task > Components: Region Assignment >Reporter: stack > Fix For: 2.0.0 > > > See head of class for a comment. It depends on simpleloadbalancer which seems > broke. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18349) Enable disabled tests in TestFavoredStochasticLoadBalancer that were disabled by Proc-V2 AM in HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-18349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254808#comment-16254808 ] stack commented on HBASE-18349: --- Looks like an easy enough fix... Balancer is not providing the source for the RegionPlan generated... so NPEs... but not scheduling for 2.0.0-beta-1 unless a fix is forthcoming. > Enable disabled tests in TestFavoredStochasticLoadBalancer that were disabled > by Proc-V2 AM in HBASE-14614 > -- > > Key: HBASE-18349 > URL: https://issues.apache.org/jira/browse/HBASE-18349 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-1 >Reporter: Stephen Yuan Jiang >Assignee: Thiruvel Thirumoolan > > The following 3 tests in TestFavoredStochasticLoadBalancerwere disabled by > HBASE-14614 (Core Proc-V2 AM): > - testAllFavoredNodesDead > - testAllFavoredNodesDeadMasterRestarted > - testMisplacedRegions > This JIRA is tracking necessary work to re-able (or remove/change if not > applicable) these UTs -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19262) Revisit checkstyle rules
[ https://issues.apache.org/jira/browse/HBASE-19262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254796#comment-16254796 ] Hudson commented on HBASE-19262: FAILURE: Integrated in Jenkins build HBase-2.0 #859 (See [https://builds.apache.org/job/HBase-2.0/859/]) HBASE-19262 Revisit checkstyle rules (zhangduo: rev c5ad801754d877265ef184a19d7b619d637b06a3) * (edit) hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml * (edit) hbase-checkstyle/src/main/resources/hbase/checkstyle.xml > Revisit checkstyle rules > > > Key: HBASE-19262 > URL: https://issues.apache.org/jira/browse/HBASE-19262 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1 > > Attachments: HBASE-19262.patch, idea_import_layout.png > > > For the shaded imports, I prefer we put it at the bottom with a separated > block. And also, for UTs which use junit rule, we usually declare the field > as public but checkstyle will report a VisibilityModifier problem. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18357) Enable disabled tests in TestHCM that were disabled by Proc-V2 AM in HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-18357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254797#comment-16254797 ] Hudson commented on HBASE-18357: FAILURE: Integrated in Jenkins build HBase-2.0 #859 (See [https://builds.apache.org/job/HBase-2.0/859/]) HBASE-18357 Enable disabled tests in TestHCM that were disabled by (stack: rev e063b231da4f714f37dc3d3dfc2e10ca7652c894) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MoveRegionProcedure.java * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestDropTimeoutRequest.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java > Enable disabled tests in TestHCM that were disabled by Proc-V2 AM in > HBASE-14614 > > > Key: HBASE-18357 > URL: https://issues.apache.org/jira/browse/HBASE-18357 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-beta-1 >Reporter: Stephen Yuan Jiang >Assignee: stack > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18357-v1.patch, HBASE-18357.master.001.patch > > > The Core Proc-V2 AM change in HBASE-14614 disabled two tests inTestHCM: > testMulti and testRegionCaching > This JIRA tracks the work to enable them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19248) TestZooKeeper#testMultipleZK fails due to missing method getKeepAliveZooKeeperWatcher
[
https://issues.apache.org/jira/browse/HBASE-19248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254793#comment-16254793
]
Hudson commented on HBASE-19248:
FAILURE: Integrated in Jenkins build HBase-2.0 #859 (See
[https://builds.apache.org/job/HBase-2.0/859/])
HBASE-19248 Move tests that need to look at Connection internals to test
(busbey: rev 9c85d0017f1452f266253d64fde8d513eb571f75)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZKAsyncRegistry.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestZKAsyncRegistry.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
> TestZooKeeper#testMultipleZK fails due to missing method
> getKeepAliveZooKeeperWatcher
> -
>
> Key: HBASE-19248
> URL: https://issues.apache.org/jira/browse/HBASE-19248
> Project: HBase
> Issue Type: Test
> Components: Zookeeper
>Affects Versions: 3.0.0, 2.0.0-beta-1
>Reporter: Ted Yu
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-beta-1
>
> Attachments: HBASE-19248.0.patch, HBASE-19248.1.patch
>
>
> From
> https://builds.apache.org/job/HBASE-Flaky-Tests/23335/testReport/junit/org.apache.hadoop.hbase/TestZooKeeper/testMultipleZK/
> :
> {code}
> java.lang.NoSuchMethodException:
> org.apache.hadoop.hbase.client.ConnectionImplementation.getKeepAliveZooKeeperWatcher()
> at
> org.apache.hadoop.hbase.TestZooKeeper.getZooKeeperWatcher(TestZooKeeper.java:136)
> at
> org.apache.hadoop.hbase.TestZooKeeper.testMultipleZK(TestZooKeeper.java:291)
> {code}
> This is the top flaky test.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19223) Remove references to Date Tiered compaction from branch-1.2 and branch-1.1 ref guide
[ https://issues.apache.org/jira/browse/HBASE-19223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254794#comment-16254794 ] Hudson commented on HBASE-19223: FAILURE: Integrated in Jenkins build HBase-2.0 #859 (See [https://builds.apache.org/job/HBase-2.0/859/]) HBASE-19223 Note availability of Date Tiered Compaction in 1.y release (busbey: rev fb79e9d4a769334b2c3b4a0b26eda409ad0bcfd2) * (edit) src/main/asciidoc/_chapters/upgrading.adoc > Remove references to Date Tiered compaction from branch-1.2 and branch-1.1 > ref guide > > > Key: HBASE-19223 > URL: https://issues.apache.org/jira/browse/HBASE-19223 > Project: HBase > Issue Type: Bug > Components: Compaction, documentation >Affects Versions: 1.1.5, 1.2.2 >Reporter: chilianyi >Assignee: Sean Busbey >Priority: Critical > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13 > > Attachments: HBASE-19223-branch-1.2.v0.patch, > HBASE-19223-branch-1.2.v1.patch > > > I have download hbase 1.2.6 src package. But not found class > DateTieredStoreEngine, which is present in document: > https://hbase.apache.org/1.2/book.html. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19009) implement modifyTable and enable/disableTableReplication for AsyncAdmin
[ https://issues.apache.org/jira/browse/HBASE-19009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254795#comment-16254795 ] Hudson commented on HBASE-19009: FAILURE: Integrated in Jenkins build HBase-2.0 #859 (See [https://builds.apache.org/job/HBase-2.0/859/]) HBASE-19009 implement modifyTable and enable/disableTableReplication for (zghao: rev d885e2232df6ac4c65b3a87eb45780b8fff60b91) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/replication/TestReplicationAdmin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestPerTableCFReplication.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerConfig.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java * (edit) hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptor.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java * (delete) hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationSerDeHelper.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ColumnFamilyDescriptor.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncReplicationAdminApi.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/master/TestTableCFsUpdater.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/master/TableCFsUpdater.java * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncReplicationAdminApiWithClusters.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestMasterReplication.java * (edit) hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncHBaseAdmin.java > implement modifyTable and enable/disableTableReplication for AsyncAdmin > --- > > Key: HBASE-19009 > URL: https://issues.apache.org/jira/browse/HBASE-19009 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-19009.master.001.patch, > HBASE-19009.master.002.patch, HBASE-19009.master.003.patch, > HBASE-19009.master.004.patch, HBASE-19009.master.005.patch, > HBASE-19009.master.006.patch, HBASE-19009.master.007.patch, > HBASE-19009.master.008.patch, HBASE-19009.master.009.patch, > HBASE-19009.master.010.patch, HBASE-19009.master.011.patch, > HBASE-19009.master.012.patch > > > Add 3 methods to AsyncAdmin. > modifyTable() > enableTableReplication() > disableTableReplication() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19269) Reenable TestShellRSGroups
[ https://issues.apache.org/jira/browse/HBASE-19269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254784#comment-16254784 ] stack commented on HBASE-19269: --- Hurray! Thanks [~andrewcheng] > Reenable TestShellRSGroups > -- > > Key: HBASE-19269 > URL: https://issues.apache.org/jira/browse/HBASE-19269 > Project: HBase > Issue Type: Sub-task > Components: test >Reporter: stack >Assignee: Guangxu Cheng > Fix For: 2.0.0 > > Attachments: HBASE-19269.master.001.patch > > > It was disabled by the parent issue because RSGroups was failing. RSGroups > now works but this test is still failling. Need to dig in (signal from these > jruby tests is murky). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18786) FileNotFoundException should not be silently handled for primary region replicas
[ https://issues.apache.org/jira/browse/HBASE-18786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18786: -- Release Note: FileNotFoundException opening a StoreFile in a primary replica now causes a RegionServer to crash out where before it would be ignored (or optionally handled via close/reopen). > FileNotFoundException should not be silently handled for primary region > replicas > > > Key: HBASE-18786 > URL: https://issues.apache.org/jira/browse/HBASE-18786 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Scanners >Reporter: Ashu Pachauri >Assignee: Andrew Purtell > Fix For: 2.0.0, 3.0.0, 1.4.0 > > Attachments: HBASE-18786-branch-1.3.patch, > HBASE-18786-branch-1.patch, HBASE-18786-branch-1.patch, HBASE-18786.patch, > HBASE-18786.patch > > > This is a follow up for HBASE-18186. > FileNotFoundException while scanning from a primary region replica can be > indicative of a more severe problem. Handling them silently can cause many > underlying issues go undetected. We should either > 1. Hard fail the regionserver if there is a FNFE on a primary region replica, > OR > 2. Report these exceptions as some region / server level metric so that these > can be proactively investigated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19251) Merge RawAsyncTable and AsyncTable
[
https://issues.apache.org/jira/browse/HBASE-19251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254781#comment-16254781
]
Hadoop QA commented on HBASE-19251:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 24 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 7m
6s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
35s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
31s{color} | {color:green} hbase-client: The patch generated 0 new + 205
unchanged - 23 fixed = 205 total (was 228) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
7s{color} | {color:red} hbase-server: The patch generated 1 new + 37 unchanged
- 9 fixed = 38 total (was 46) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} hbase-mapreduce: The patch generated 0 new + 29
unchanged - 2 fixed = 29 total (was 31) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} The patch hbase-endpoint passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} hbase-examples: The patch generated 0 new + 0
unchanged - 1 fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
47s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
54m 16s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
51s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
54s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}106m
52s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 11m
29s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
23s{color} | {color:green} hbase-endpoint in the patch passed. {color} |
|
[jira] [Updated] (HBASE-18353) Enable TestCorruptedRegionStoreFile that were disabled by Proc-V2 AM in HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-18353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18353: -- Resolution: Won't Fix Status: Resolved (was: Patch Available) The test was removed by the first commit below because the behavior around missing StoreFile handling changed over in HBASE-18786. b145286f36 Amend HBASE-18786 FileNotFoundException should not be silently handled for primary region replicas b27f9b582a HBASE-18786 FileNotFoundException should not be silently handled for primary region replicas Resolving as 'Won't Fix'/No longer a problem. > Enable TestCorruptedRegionStoreFile that were disabled by Proc-V2 AM in > HBASE-14614 > --- > > Key: HBASE-18353 > URL: https://issues.apache.org/jira/browse/HBASE-18353 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-1 >Reporter: Stephen Yuan Jiang >Assignee: Vladimir Rodionov > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18353-v1.patch, HBASE-18353-v2.patch > > > HBASE-14614 disabled TestCorruptedRegionStoreFile, as it depends on a > half-implemented reopen of a region when a store file goes missing. > This JIRA tracks the work to fix/enable the test. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18353) Enable TestCorruptedRegionStoreFile that were disabled by Proc-V2 AM in HBASE-14614
[
https://issues.apache.org/jira/browse/HBASE-18353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254776#comment-16254776
]
Hadoop QA commented on HBASE-18353:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 3s{color}
| {color:red} HBASE-18353 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.6.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-18353 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12877417/HBASE-18353-v2.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9851/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Enable TestCorruptedRegionStoreFile that were disabled by Proc-V2 AM in
> HBASE-14614
> ---
>
> Key: HBASE-18353
> URL: https://issues.apache.org/jira/browse/HBASE-18353
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18353-v1.patch, HBASE-18353-v2.patch
>
>
> HBASE-14614 disabled TestCorruptedRegionStoreFile, as it depends on a
> half-implemented reopen of a region when a store file goes missing.
> This JIRA tracks the work to fix/enable the test.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18353) Enable TestCorruptedRegionStoreFile that were disabled by Proc-V2 AM in HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-18353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18353: -- Fix Version/s: 2.0.0-beta-1 > Enable TestCorruptedRegionStoreFile that were disabled by Proc-V2 AM in > HBASE-14614 > --- > > Key: HBASE-18353 > URL: https://issues.apache.org/jira/browse/HBASE-18353 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-1 >Reporter: Stephen Yuan Jiang >Assignee: Vladimir Rodionov > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18353-v1.patch, HBASE-18353-v2.patch > > > HBASE-14614 disabled TestCorruptedRegionStoreFile, as it depends on a > half-implemented reopen of a region when a store file goes missing. > This JIRA tracks the work to fix/enable the test. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19163) "Maximum lock count exceeded" from region server's batch processing
[
https://issues.apache.org/jira/browse/HBASE-19163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254763#comment-16254763
]
Hadoop QA commented on HBASE-19163:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
35s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
49s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
7s{color} | {color:red} hbase-server: The patch generated 1 new + 238 unchanged
- 0 fixed = 239 total (was 238) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
39s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
54m 36s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}125m
13s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}204m 41s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19163 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897888/HBASE-19163.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux d4cc21d1df65 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / d4babbf060 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/9844/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9844/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9844/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message
[jira] [Commented] (HBASE-19114) Split out o.a.h.h.zookeeper from hbase-server and hbase-client
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254764#comment-16254764
]
Hadoop QA commented on HBASE-19114:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
6s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 78 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
26s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 5m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
3s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
28s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s{color} | {color:green} hbase-client: The patch generated 0 new + 0
unchanged - 200 fixed = 0 total (was 200) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
12s{color} | {color:red} hbase-zookeeper: The patch generated 239 new + 0
unchanged - 0 fixed = 239 total (was 0) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m
17s{color} | {color:red} root: The patch generated 256 new + 1513 unchanged -
291 fixed = 1769 total (was 1804) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s{color} | {color:green} The patch hbase-client-project passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s{color} | {color:green} The patch hbase-shaded-client-project passed
checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s{color} | {color:green} The patch hbase-assembly passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} The patch hbase-it passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} The patch hbase-mapreduce passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
8s{color} | {color:red} hbase-replication: The patch generated 1 new + 23
unchanged - 10 fixed = 24 total (was 33) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} The patch hbase-rsgroup passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
15s{color} | {color:red} hbase-server: The patch generated 16 new + 1456
unchanged - 81 fixed = 1472 total (was 1537) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s{color} | {color:green} The patch hbase-shell passed checkstyle {color} |
| {color:green}+1{color} | {color
[jira] [Updated] (HBASE-18309) Support multi threads in CleanerChore
[ https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-18309: -- Status: Patch Available (was: Open) > Support multi threads in CleanerChore > - > > Key: HBASE-18309 > URL: https://issues.apache.org/jira/browse/HBASE-18309 > Project: HBase > Issue Type: Improvement > Components: wal >Reporter: binlijin >Assignee: Reid Chan > Attachments: HBASE-18309.master.001.patch, > HBASE-18309.master.002.patch, HBASE-18309.master.004.patch, > HBASE-18309.master.005.patch, HBASE-18309.master.006.patch, > space_consumption_in_archive.png > > > There is only one thread in LogCleaner to clean oldWALs and in our big > cluster we find this is not enough. The number of files under oldWALs reach > the max-directory-items limit of HDFS and cause region server crash, so we > use multi threads for LogCleaner and the crash not happened any more. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18309) Support multi threads in CleanerChore
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reid Chan updated HBASE-18309:
--
Attachment: HBASE-18309.master.006.patch
* override cleanup() in {{LogCleaner}}
* {{Wrong order for 'org.apache.hadoop.hbase.io.HFileLink' import.
[ImportOrder]}} fixed
* {{Wrong order for 'java.io.IOException' import. [ImportOrder]}} I couldn't
tell why it's wrong...
> Support multi threads in CleanerChore
> -
>
> Key: HBASE-18309
> URL: https://issues.apache.org/jira/browse/HBASE-18309
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Reporter: binlijin
>Assignee: Reid Chan
> Attachments: HBASE-18309.master.001.patch,
> HBASE-18309.master.002.patch, HBASE-18309.master.004.patch,
> HBASE-18309.master.005.patch, HBASE-18309.master.006.patch,
> space_consumption_in_archive.png
>
>
> There is only one thread in LogCleaner to clean oldWALs and in our big
> cluster we find this is not enough. The number of files under oldWALs reach
> the max-directory-items limit of HDFS and cause region server crash, so we
> use multi threads for LogCleaner and the crash not happened any more.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18309) Support multi threads in CleanerChore
[ https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-18309: -- Status: Open (was: Patch Available) > Support multi threads in CleanerChore > - > > Key: HBASE-18309 > URL: https://issues.apache.org/jira/browse/HBASE-18309 > Project: HBase > Issue Type: Improvement > Components: wal >Reporter: binlijin >Assignee: Reid Chan > Attachments: HBASE-18309.master.001.patch, > HBASE-18309.master.002.patch, HBASE-18309.master.004.patch, > HBASE-18309.master.005.patch, space_consumption_in_archive.png > > > There is only one thread in LogCleaner to clean oldWALs and in our big > cluster we find this is not enough. The number of files under oldWALs reach > the max-directory-items limit of HDFS and cause region server crash, so we > use multi threads for LogCleaner and the crash not happened any more. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19273) IntegrationTestBulkLoad#installSlowingCoproc() uses read-only HTableDescriptor
[
https://issues.apache.org/jira/browse/HBASE-19273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254753#comment-16254753
]
Chia-Ping Tsai commented on HBASE-19273:
+1 if you have verified the patch locally.
> IntegrationTestBulkLoad#installSlowingCoproc() uses read-only HTableDescriptor
> --
>
> Key: HBASE-19273
> URL: https://issues.apache.org/jira/browse/HBASE-19273
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19273.v1.txt
>
>
> [~romil.choksi] reported the following :
> {code}
> 2017-11-15 23:03:04,455 ERROR [main] util.AbstractHBaseTool: Error running
> command-line tool
> java.lang.UnsupportedOperationException: HTableDescriptor is read-only
> at
> org.apache.hadoop.hbase.client.ImmutableHTableDescriptor.getDelegateeForModification(ImmutableHTableDescriptor.java:59)
> at
> org.apache.hadoop.hbase.HTableDescriptor.addCoprocessor(HTableDescriptor.java:710)
> at
> org.apache.hadoop.hbase.mapreduce.IntegrationTestBulkLoad.installSlowingCoproc(IntegrationTestBulkLoad.java:215)
> at
> org.apache.hadoop.hbase.mapreduce.IntegrationTestBulkLoad.testBulkLoad(IntegrationTestBulkLoad.java:222)
> at
> org.apache.hadoop.hbase.mapreduce.IntegrationTestBulkLoad.runTestFromCommandLine(IntegrationTestBulkLoad.java:790)
> at
> org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:155)
> {code}
> This is due to read only descriptor being used.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18359) CoprocessorHConnection#getConnectionForEnvironment should read config from CoprocessorEnvironment
[
https://issues.apache.org/jira/browse/HBASE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254751#comment-16254751
]
stack commented on HBASE-18359:
---
We should make the Configuration returned out of the Env be read-only?
What you want to set on the Configuration [~samarth.j...@gmail.com] and
[~sergey.soldatov]?
Thanks.
> CoprocessorHConnection#getConnectionForEnvironment should read config from
> CoprocessorEnvironment
> -
>
> Key: HBASE-18359
> URL: https://issues.apache.org/jira/browse/HBASE-18359
> Project: HBase
> Issue Type: Bug
>Reporter: Samarth Jain
>
> It seems like the method getConnectionForEnvironment isn't doing the right
> thing when it is creating a CoprocessorHConnection by reading the config from
> HRegionServer and not from the env passed in.
> If coprocessors want to use a CoprocessorHConnection with some custom config
> settings, then they have no option but to configure it in the hbase-site.xml
> of the region servers. This isn't ideal as a lot of times these "global"
> level configs can have side effects. See PHOENIX-3974 as an example where
> configuring ServerRpcControllerFactory (a Phoenix implementation of
> RpcControllerFactory) could result in deadlocks. Or PHOENIX-3983 where
> presence of this global config causes our index rebuild code to incorrectly
> use handlers it shouldn't.
> If the CoprocessorHConnection created through getConnectionForEnvironment API
> used the CoprocessorEnvironment config, then it would allow co-processors to
> pass in their own config without needing to configure them in hbase-site.xml.
> The change would be simple. Basically change the below
> {code}
> if (services instanceof HRegionServer) {
> return new CoprocessorHConnection((HRegionServer) services);
> }
> {code}
> to
> {code}
> if (services instanceof HRegionServer) {
> return new CoprocessorHConnection(env.getConfiguration(),
> (HRegionServer) services);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19276) RegionPlan should correctly implement equals and hashCode
[
https://issues.apache.org/jira/browse/HBASE-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254747#comment-16254747
]
Hadoop QA commented on HBASE-19276:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
26s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
1s{color} | {color:red} hbase-server: The patch generated 9 new + 2 unchanged -
0 fixed = 11 total (was 2) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
34s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
53m 14s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}105m
39s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}179m 4s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19276 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897883/HBASE-19276.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux ba1fa4e3a96d 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 600fdee844 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/9841/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9841/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9841/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatica
[jira] [Commented] (HBASE-18359) CoprocessorHConnection#getConnectionForEnvironment should read config from CoprocessorEnvironment
[
https://issues.apache.org/jira/browse/HBASE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254736#comment-16254736
]
Anoop Sam John commented on HBASE-18359:
[~samarth.j...@gmail.com], [~sergey.soldatov]. Coming to this jira again.
In trunk, things are changed a lot and there is no CoprocessorHConnection any
more. We have CoprocessorEnvironment#getConnection(). This will give short
circuited connection. Means any calls, via this connection , on regions in same
RS will go a short circuited path.
On the old code u mentioned, we were passing CoprocessorEnvironment. This is
the object u r getting from HBase core and you can just GET config from that.
This is the same config that Region uses. So am not sure how u can create
custom conf. You can not really set any config in CoprocessorEnvironment
object. I guess what u were doing is just changing /setting some config
attributes on the config getting from CoprocessorEnvironment. That will be
wrong. Because the conf object is a shared one for every thing in this Region.
All CPs over this Region and Region, Store and level down will use this changed
config. What ideally should be done is clone the config and set the new
attributes. If we were having an API which takes Config, it would have been
possible. Also CoprocessorHConnection was a Private class.
So this is not the ideal path for what you want to do.
Checking the new trunk code also, seems you can not do what u really want.
Because all calls CoprocessorEnvironment#getConnection() will return a same
Cluster connection object which is created in HRS. So if u need to have
custom configs to be used for these connection, only way would be to have a
CoprocessorEnvironment#getConnection(Config) API and create new connection
(Short circuited) in the impl. Not good to create the connection on every
call. We have to decide who will do the caching of the connection and reuse.
cc [~Stack]
> CoprocessorHConnection#getConnectionForEnvironment should read config from
> CoprocessorEnvironment
> -
>
> Key: HBASE-18359
> URL: https://issues.apache.org/jira/browse/HBASE-18359
> Project: HBase
> Issue Type: Bug
>Reporter: Samarth Jain
>
> It seems like the method getConnectionForEnvironment isn't doing the right
> thing when it is creating a CoprocessorHConnection by reading the config from
> HRegionServer and not from the env passed in.
> If coprocessors want to use a CoprocessorHConnection with some custom config
> settings, then they have no option but to configure it in the hbase-site.xml
> of the region servers. This isn't ideal as a lot of times these "global"
> level configs can have side effects. See PHOENIX-3974 as an example where
> configuring ServerRpcControllerFactory (a Phoenix implementation of
> RpcControllerFactory) could result in deadlocks. Or PHOENIX-3983 where
> presence of this global config causes our index rebuild code to incorrectly
> use handlers it shouldn't.
> If the CoprocessorHConnection created through getConnectionForEnvironment API
> used the CoprocessorEnvironment config, then it would allow co-processors to
> pass in their own config without needing to configure them in hbase-site.xml.
> The change would be simple. Basically change the below
> {code}
> if (services instanceof HRegionServer) {
> return new CoprocessorHConnection((HRegionServer) services);
> }
> {code}
> to
> {code}
> if (services instanceof HRegionServer) {
> return new CoprocessorHConnection(env.getConfiguration(),
> (HRegionServer) services);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19262) Revisit checkstyle rules
[ https://issues.apache.org/jira/browse/HBASE-19262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254734#comment-16254734 ] Hudson commented on HBASE-19262: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4059 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4059/]) HBASE-19262 Revisit checkstyle rules (zhangduo: rev d4babbf060a99222c7ebe60ee1b0f4197411ea37) * (edit) hbase-checkstyle/src/main/resources/hbase/checkstyle.xml * (edit) hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml > Revisit checkstyle rules > > > Key: HBASE-19262 > URL: https://issues.apache.org/jira/browse/HBASE-19262 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1 > > Attachments: HBASE-19262.patch, idea_import_layout.png > > > For the shaded imports, I prefer we put it at the bottom with a separated > block. And also, for UTs which use junit rule, we usually declare the field > as public but checkstyle will report a VisibilityModifier problem. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19009) implement modifyTable and enable/disableTableReplication for AsyncAdmin
[ https://issues.apache.org/jira/browse/HBASE-19009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254733#comment-16254733 ] Hudson commented on HBASE-19009: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4059 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4059/]) HBASE-19009 implement modifyTable and enable/disableTableReplication for (zghao: rev 600fdee8449aa1de80c8a78d3bb5e8551d3a0261) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestPerTableCFReplication.java * (edit) hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestMasterReplication.java * (delete) hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationSerDeHelper.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/replication/TestReplicationAdmin.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/master/TableCFsUpdater.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncReplicationAdminApi.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptor.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerConfig.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/master/TestTableCFsUpdater.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ColumnFamilyDescriptor.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncHBaseAdmin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java * (edit) hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncReplicationAdminApiWithClusters.java > implement modifyTable and enable/disableTableReplication for AsyncAdmin > --- > > Key: HBASE-19009 > URL: https://issues.apache.org/jira/browse/HBASE-19009 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-19009.master.001.patch, > HBASE-19009.master.002.patch, HBASE-19009.master.003.patch, > HBASE-19009.master.004.patch, HBASE-19009.master.005.patch, > HBASE-19009.master.006.patch, HBASE-19009.master.007.patch, > HBASE-19009.master.008.patch, HBASE-19009.master.009.patch, > HBASE-19009.master.010.patch, HBASE-19009.master.011.patch, > HBASE-19009.master.012.patch > > > Add 3 methods to AsyncAdmin. > modifyTable() > enableTableReplication() > disableTableReplication() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19269) Reenable TestShellRSGroups
[ https://issues.apache.org/jira/browse/HBASE-19269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guangxu Cheng updated HBASE-19269: -- Status: Patch Available (was: Open) Attach a patch. Pending QA. > Reenable TestShellRSGroups > -- > > Key: HBASE-19269 > URL: https://issues.apache.org/jira/browse/HBASE-19269 > Project: HBase > Issue Type: Sub-task > Components: test >Reporter: stack >Assignee: Guangxu Cheng > Fix For: 2.0.0 > > Attachments: HBASE-19269.master.001.patch > > > It was disabled by the parent issue because RSGroups was failing. RSGroups > now works but this test is still failling. Need to dig in (signal from these > jruby tests is murky). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19269) Reenable TestShellRSGroups
[ https://issues.apache.org/jira/browse/HBASE-19269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guangxu Cheng updated HBASE-19269: -- Attachment: HBASE-19269.master.001.patch > Reenable TestShellRSGroups > -- > > Key: HBASE-19269 > URL: https://issues.apache.org/jira/browse/HBASE-19269 > Project: HBase > Issue Type: Sub-task > Components: test >Reporter: stack > Fix For: 2.0.0 > > Attachments: HBASE-19269.master.001.patch > > > It was disabled by the parent issue because RSGroups was failing. RSGroups > now works but this test is still failling. Need to dig in (signal from these > jruby tests is murky). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-19269) Reenable TestShellRSGroups
[ https://issues.apache.org/jira/browse/HBASE-19269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guangxu Cheng reassigned HBASE-19269: - Assignee: Guangxu Cheng > Reenable TestShellRSGroups > -- > > Key: HBASE-19269 > URL: https://issues.apache.org/jira/browse/HBASE-19269 > Project: HBase > Issue Type: Sub-task > Components: test >Reporter: stack >Assignee: Guangxu Cheng > Fix For: 2.0.0 > > Attachments: HBASE-19269.master.001.patch > > > It was disabled by the parent issue because RSGroups was failing. RSGroups > now works but this test is still failling. Need to dig in (signal from these > jruby tests is murky). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19269) Reenable TestShellRSGroups
[ https://issues.apache.org/jira/browse/HBASE-19269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254719#comment-16254719 ] Guangxu Cheng commented on HBASE-19269: --- I think I have how to fix this. > Reenable TestShellRSGroups > -- > > Key: HBASE-19269 > URL: https://issues.apache.org/jira/browse/HBASE-19269 > Project: HBase > Issue Type: Sub-task > Components: test >Reporter: stack > Fix For: 2.0.0 > > > It was disabled by the parent issue because RSGroups was failing. RSGroups > now works but this test is still failling. Need to dig in (signal from these > jruby tests is murky). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19270) Reenable TestRegionMergeTransactionOnCluster#testMergeWithReplicas disable by HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-19270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19270: -- Attachment: HBASE-19270.master.002.patch > Reenable TestRegionMergeTransactionOnCluster#testMergeWithReplicas disable by > HBASE-14614 > - > > Key: HBASE-19270 > URL: https://issues.apache.org/jira/browse/HBASE-19270 > Project: HBase > Issue Type: Sub-task > Components: Region Assignment >Reporter: stack >Assignee: stack > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19270.master.001.patch, > HBASE-19270.master.002.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19270) Reenable TestRegionMergeTransactionOnCluster#testMergeWithReplicas disable by HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-19270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254716#comment-16254716 ] stack commented on HBASE-19270: --- This machine is littered w/ hs_err_pid*.log files. Thats the whitespace complaint. Test run also exited. Retry after fixing checkstyle. > Reenable TestRegionMergeTransactionOnCluster#testMergeWithReplicas disable by > HBASE-14614 > - > > Key: HBASE-19270 > URL: https://issues.apache.org/jira/browse/HBASE-19270 > Project: HBase > Issue Type: Sub-task > Components: Region Assignment >Reporter: stack >Assignee: stack > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19270.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19273) IntegrationTestBulkLoad#installSlowingCoproc() uses read-only HTableDescriptor
[
https://issues.apache.org/jira/browse/HBASE-19273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254714#comment-16254714
]
Ted Yu commented on HBASE-19273:
HBASE-18440 has wider scope.
I think this can be integrated first.
> IntegrationTestBulkLoad#installSlowingCoproc() uses read-only HTableDescriptor
> --
>
> Key: HBASE-19273
> URL: https://issues.apache.org/jira/browse/HBASE-19273
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19273.v1.txt
>
>
> [~romil.choksi] reported the following :
> {code}
> 2017-11-15 23:03:04,455 ERROR [main] util.AbstractHBaseTool: Error running
> command-line tool
> java.lang.UnsupportedOperationException: HTableDescriptor is read-only
> at
> org.apache.hadoop.hbase.client.ImmutableHTableDescriptor.getDelegateeForModification(ImmutableHTableDescriptor.java:59)
> at
> org.apache.hadoop.hbase.HTableDescriptor.addCoprocessor(HTableDescriptor.java:710)
> at
> org.apache.hadoop.hbase.mapreduce.IntegrationTestBulkLoad.installSlowingCoproc(IntegrationTestBulkLoad.java:215)
> at
> org.apache.hadoop.hbase.mapreduce.IntegrationTestBulkLoad.testBulkLoad(IntegrationTestBulkLoad.java:222)
> at
> org.apache.hadoop.hbase.mapreduce.IntegrationTestBulkLoad.runTestFromCommandLine(IntegrationTestBulkLoad.java:790)
> at
> org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:155)
> {code}
> This is due to read only descriptor being used.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18356) Enable TestFavoredStochasticBalancerPickers#testPickers that was disabled by Proc-V2 AM in HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18356: -- Fix Version/s: 2.0.0-beta-1 > Enable TestFavoredStochasticBalancerPickers#testPickers that was disabled by > Proc-V2 AM in HBASE-14614 > -- > > Key: HBASE-18356 > URL: https://issues.apache.org/jira/browse/HBASE-18356 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-1 >Reporter: Stephen Yuan Jiang >Assignee: Thiruvel Thirumoolan > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18356.master.001.patch, > HBASE-18356.master.002.patch > > > The testPickers in TestFavoredStochasticBalancerPickers hangs after applying > the change in Core Proc-V2 AM in HBASE-14614. It was disabled. > This JIRA tracks the work to enable it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18356) Enable TestFavoredStochasticBalancerPickers#testPickers that was disabled by Proc-V2 AM in HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254711#comment-16254711 ] stack commented on HBASE-18356: --- .002 Rebase/Fixup of Thiru's patch. > Enable TestFavoredStochasticBalancerPickers#testPickers that was disabled by > Proc-V2 AM in HBASE-14614 > -- > > Key: HBASE-18356 > URL: https://issues.apache.org/jira/browse/HBASE-18356 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-1 >Reporter: Stephen Yuan Jiang >Assignee: Thiruvel Thirumoolan > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18356.master.001.patch, > HBASE-18356.master.002.patch > > > The testPickers in TestFavoredStochasticBalancerPickers hangs after applying > the change in Core Proc-V2 AM in HBASE-14614. It was disabled. > This JIRA tracks the work to enable it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18356) Enable TestFavoredStochasticBalancerPickers#testPickers that was disabled by Proc-V2 AM in HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18356: -- Attachment: HBASE-18356.master.002.patch > Enable TestFavoredStochasticBalancerPickers#testPickers that was disabled by > Proc-V2 AM in HBASE-14614 > -- > > Key: HBASE-18356 > URL: https://issues.apache.org/jira/browse/HBASE-18356 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-1 >Reporter: Stephen Yuan Jiang >Assignee: Thiruvel Thirumoolan > Attachments: HBASE-18356.master.001.patch, > HBASE-18356.master.002.patch > > > The testPickers in TestFavoredStochasticBalancerPickers hangs after applying > the change in Core Proc-V2 AM in HBASE-14614. It was disabled. > This JIRA tracks the work to enable it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19276) RegionPlan should correctly implement equals and hashCode
[ https://issues.apache.org/jira/browse/HBASE-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254703#comment-16254703 ] Andrew Purtell commented on HBASE-19276: The compareTo needs to stay the same I think, unless we implement the special comparison we need with a custom comparator. > RegionPlan should correctly implement equals and hashCode > - > > Key: HBASE-19276 > URL: https://issues.apache.org/jira/browse/HBASE-19276 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 2.0.0-beta-1 > > Attachments: HBASE-19276-branch-1.patch, HBASE-19276.patch > > > error-prone identified dodgy code in AssignmentManager where we are relying > on reference (object) equality to do the right thing, and are getting lucky, > because if we properly used equals() the result is wrong, because RegionPlan > does not correctly implement equals and hashCode according to the JDK > contracts for same. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19273) IntegrationTestBulkLoad#installSlowingCoproc() uses read-only HTableDescriptor
[
https://issues.apache.org/jira/browse/HBASE-19273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254690#comment-16254690
]
Chia-Ping Tsai commented on HBASE-19273:
Is it a duplicate of HBASE-18440? Ping [~mdrob]
> IntegrationTestBulkLoad#installSlowingCoproc() uses read-only HTableDescriptor
> --
>
> Key: HBASE-19273
> URL: https://issues.apache.org/jira/browse/HBASE-19273
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19273.v1.txt
>
>
> [~romil.choksi] reported the following :
> {code}
> 2017-11-15 23:03:04,455 ERROR [main] util.AbstractHBaseTool: Error running
> command-line tool
> java.lang.UnsupportedOperationException: HTableDescriptor is read-only
> at
> org.apache.hadoop.hbase.client.ImmutableHTableDescriptor.getDelegateeForModification(ImmutableHTableDescriptor.java:59)
> at
> org.apache.hadoop.hbase.HTableDescriptor.addCoprocessor(HTableDescriptor.java:710)
> at
> org.apache.hadoop.hbase.mapreduce.IntegrationTestBulkLoad.installSlowingCoproc(IntegrationTestBulkLoad.java:215)
> at
> org.apache.hadoop.hbase.mapreduce.IntegrationTestBulkLoad.testBulkLoad(IntegrationTestBulkLoad.java:222)
> at
> org.apache.hadoop.hbase.mapreduce.IntegrationTestBulkLoad.runTestFromCommandLine(IntegrationTestBulkLoad.java:790)
> at
> org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:155)
> {code}
> This is due to read only descriptor being used.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19231) Reenable TestMetaWithReplicas#testChangingReplicaCount; uses HBCK to validate
[ https://issues.apache.org/jira/browse/HBASE-19231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254689#comment-16254689 ] stack commented on HBASE-19231: --- Leaving this in 2.0.0-beta-1 for now. Replicas for hbase:meta seems important enough. The tests either need hbck fixed or they need to be rewritten to effect same validation but w/o depending on an hbck. > Reenable TestMetaWithReplicas#testChangingReplicaCount; uses HBCK to validate > - > > Key: HBASE-19231 > URL: https://issues.apache.org/jira/browse/HBASE-19231 > Project: HBase > Issue Type: Sub-task > Components: hbck >Reporter: stack > Fix For: 2.0.0-beta-1 > > > Also #testHBaseFsckWithFewerMetaReplicas, > #testHBaseFsckWithExcessMetaReplicas, and > #testHBaseFsckWithFewerMetaReplicaZnodes in TestMetaWithReplicas. Both depend > on HBCK for validation. Disabled for now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19231) Reenable TestMetaWithReplicas#testChangingReplicaCount; uses HBCK to validate
[ https://issues.apache.org/jira/browse/HBASE-19231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19231: -- Fix Version/s: 2.0.0 > Reenable TestMetaWithReplicas#testChangingReplicaCount; uses HBCK to validate > - > > Key: HBASE-19231 > URL: https://issues.apache.org/jira/browse/HBASE-19231 > Project: HBase > Issue Type: Sub-task > Components: hbck >Reporter: stack > Fix For: 2.0.0-beta-1 > > > Also #testHBaseFsckWithFewerMetaReplicas, > #testHBaseFsckWithExcessMetaReplicas, and > #testHBaseFsckWithFewerMetaReplicaZnodes in TestMetaWithReplicas. Both depend > on HBCK for validation. Disabled for now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19231) Reenable TestMetaWithReplicas#testChangingReplicaCount; uses HBCK to validate
[ https://issues.apache.org/jira/browse/HBASE-19231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19231: -- Fix Version/s: (was: 2.0.0) 2.0.0-beta-1 > Reenable TestMetaWithReplicas#testChangingReplicaCount; uses HBCK to validate > - > > Key: HBASE-19231 > URL: https://issues.apache.org/jira/browse/HBASE-19231 > Project: HBase > Issue Type: Sub-task > Components: hbck >Reporter: stack > Fix For: 2.0.0-beta-1 > > > Also #testHBaseFsckWithFewerMetaReplicas, > #testHBaseFsckWithExcessMetaReplicas, and > #testHBaseFsckWithFewerMetaReplicaZnodes in TestMetaWithReplicas. Both depend > on HBCK for validation. Disabled for now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19276) RegionPlan should correctly implement equals and hashCode
[
https://issues.apache.org/jira/browse/HBASE-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254686#comment-16254686
]
Chia-Ping Tsai commented on HBASE-19276:
The {{equal}} looks good to me. Should we also rewrite the {{compareTo}}? The
patch cause the evaluation of {{equal}} result differ from {{compareTo() == 0}}.
> RegionPlan should correctly implement equals and hashCode
> -
>
> Key: HBASE-19276
> URL: https://issues.apache.org/jira/browse/HBASE-19276
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-19276-branch-1.patch, HBASE-19276.patch
>
>
> error-prone identified dodgy code in AssignmentManager where we are relying
> on reference (object) equality to do the right thing, and are getting lucky,
> because if we properly used equals() the result is wrong, because RegionPlan
> does not correctly implement equals and hashCode according to the JDK
> contracts for same.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19231) Reenable TestMetaWithReplicas#testChangingReplicaCount; uses HBCK to validate
[ https://issues.apache.org/jira/browse/HBASE-19231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19231: -- Fix Version/s: (was: 2.0.0-beta-1) > Reenable TestMetaWithReplicas#testChangingReplicaCount; uses HBCK to validate > - > > Key: HBASE-19231 > URL: https://issues.apache.org/jira/browse/HBASE-19231 > Project: HBase > Issue Type: Sub-task > Components: hbck >Reporter: stack > > Also #testHBaseFsckWithFewerMetaReplicas, > #testHBaseFsckWithExcessMetaReplicas, and > #testHBaseFsckWithFewerMetaReplicaZnodes in TestMetaWithReplicas. Both depend > on HBCK for validation. Disabled for now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18110) [AMv2] Reenable tests temporarily disabled
[ https://issues.apache.org/jira/browse/HBASE-18110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18110: -- Fix Version/s: (was: 2.0.0-beta-1) 2.0.0 > [AMv2] Reenable tests temporarily disabled > -- > > Key: HBASE-18110 > URL: https://issues.apache.org/jira/browse/HBASE-18110 > Project: HBase > Issue Type: Bug > Components: Region Assignment >Affects Versions: 2.0.0 >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0 > > > We disabled tests that didn't make sense or relied on behavior not supported > by AMv2. Revisit and reenable after AMv2 gets committed. Here is the set > (from > https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.rsj53tx4vlwj) > testAllFavoredNodesDead and testAllFavoredNodesDeadMasterRestarted and > testMisplacedRegions in TestFavoredStochasticLoadBalancer … not sure what > this about. > testRegionNormalizationMergeOnCluster in TestSimpleRegionNormalizerOnCluster > disabled for now till we fix up Merge. > testMergeWithReplicas in TestRegionMergeTransactionOnCluster because don't > know how it is supposed to work. > Admin#close does not update Master. Causes > testHBaseFsckWithFewerMetaReplicaZnodes in TestMetaWithReplicas to fail > (Master gets report about server closing when it didn’t run the close -- gets > freaked out). > Disabled/Ignore TestRSGroupsOfflineMode#testOffline; need to dig in on what > offline is. > Disabled/Ignore TestRSGroups. > All tests that have to do w/ fsck:TestHBaseFsckTwoRS, > TestOfflineMetaRebuildBase TestHBaseFsckReplicas, > TestOfflineMetaRebuildOverlap, testChangingReplicaCount in > TestMetaWithReplicas (internally it is doing fscks which are killing RS)... > FSCK test testHBaseFsckWithExcessMetaReplicas in TestMetaWithReplicas. > So is testHBaseFsckWithFewerMetaReplicas in same class. > TestHBaseFsckOneRS is fsck. Disabled. > TestOfflineMetaRebuildHole is about rebuilding hole with fsck. > Master carries meta: > TestRegionRebalancing is disabled because doesn't consider the fact that > Master carries system tables only (fix of average in RegionStates brought out > the issue). > Disabled testMetaAddressChange in TestMetaWithReplicas because presumes can > move meta... you can't > TestAsyncTableGetMultiThreaded wants to move hbase:meta...Balancer does NPEs. > AMv2 won't let you move hbase:meta off Master. > Disabled parts of...testCreateTableWithMultipleReplicas in > TestMasterOperationsForRegionReplicas There is an issue w/ assigning more > replicas if number of replicas is changed on us. See '/* DISABLED! FOR > NOW'. > Disabled TestCorruptedRegionStoreFile. Depends on a half-implemented reopen > of a region when a store file goes missing; TODO. > testRetainAssignmentOnRestart in TestRestartCluster does not work. AMv2 does > retain semantic differently. Fix. TODO. > TestMasterFailover needs to be rewritten for AMv2. It uses tricks not > ordained when up on AMv2. The test is also hobbled by fact that we > religiously enforce that only master can carry meta, something we are lose > about in old AM. > Fix Ignores in TestServerCrashProcedure. Master is different now. > Offlining is done differently now: Because of this disabled testOfflineRegion > in TestAsyncRegionAdminApi > Skipping delete of table after test in TestAccessController3 because of > access issues w/ AMv2. AMv1 seems to crash servers on exit too for same lack > of auth perms but AMv2 gets hung up. TODO. See cleanUp method. > TestHCM#testMulti and TestHCM > Fix TestMasterMetrics. Stuff is different now around startup which messes up > this test. Disabled two of three tests. > I tried to fix TestMasterBalanceThrottling but it looks like > SimpleLoadBalancer is borked whether AMv2 or not. > Disabled testPickers in TestFavoredStochasticBalancerPickers. It hangs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18110) [AMv2] Reenable tests temporarily disabled
[ https://issues.apache.org/jira/browse/HBASE-18110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254684#comment-16254684 ] stack commented on HBASE-18110: --- I made a pass over this issue and those linked here making update to current state of tests. I converted text-only remarks in the above into issues where they were still failing. I fixed some. Others had been fixed elsewhere (e.g. the RSGroup set) so they did not get JIRAs linked here. I also linked any related, existing issues that I could find where tests had not been reenabled. Tests that depended on HBCK for validation hang off HBASE-19121, the fixup of HBCK, and that were disabled because of AMv2 HBASE-14614 are linked here. I've marked individual sub-jiras with whether they are beta-1 or not. Since not all associated issues are beta-1, I'm moving this issue OUT of beta-1. Tests that now pass noted above in text as not passing or disabled include: * TestSimpleRegionNormalizerOnCluster * TestRegionMergeTransactionOnCluster * TestRegionRebalancing * TestAsyncTableGetMultiThreaded * TestMasterFailover * TestServerCrashProcedure * TestAccessController3 * TestHCM * TestMasterMetrics Otherwise, look at linked JIRAs for state of mentioned test fixup/re-enablement. > [AMv2] Reenable tests temporarily disabled > -- > > Key: HBASE-18110 > URL: https://issues.apache.org/jira/browse/HBASE-18110 > Project: HBase > Issue Type: Bug > Components: Region Assignment >Affects Versions: 2.0.0 >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0 > > > We disabled tests that didn't make sense or relied on behavior not supported > by AMv2. Revisit and reenable after AMv2 gets committed. Here is the set > (from > https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.rsj53tx4vlwj) > testAllFavoredNodesDead and testAllFavoredNodesDeadMasterRestarted and > testMisplacedRegions in TestFavoredStochasticLoadBalancer … not sure what > this about. > testRegionNormalizationMergeOnCluster in TestSimpleRegionNormalizerOnCluster > disabled for now till we fix up Merge. > testMergeWithReplicas in TestRegionMergeTransactionOnCluster because don't > know how it is supposed to work. > Admin#close does not update Master. Causes > testHBaseFsckWithFewerMetaReplicaZnodes in TestMetaWithReplicas to fail > (Master gets report about server closing when it didn’t run the close -- gets > freaked out). > Disabled/Ignore TestRSGroupsOfflineMode#testOffline; need to dig in on what > offline is. > Disabled/Ignore TestRSGroups. > All tests that have to do w/ fsck:TestHBaseFsckTwoRS, > TestOfflineMetaRebuildBase TestHBaseFsckReplicas, > TestOfflineMetaRebuildOverlap, testChangingReplicaCount in > TestMetaWithReplicas (internally it is doing fscks which are killing RS)... > FSCK test testHBaseFsckWithExcessMetaReplicas in TestMetaWithReplicas. > So is testHBaseFsckWithFewerMetaReplicas in same class. > TestHBaseFsckOneRS is fsck. Disabled. > TestOfflineMetaRebuildHole is about rebuilding hole with fsck. > Master carries meta: > TestRegionRebalancing is disabled because doesn't consider the fact that > Master carries system tables only (fix of average in RegionStates brought out > the issue). > Disabled testMetaAddressChange in TestMetaWithReplicas because presumes can > move meta... you can't > TestAsyncTableGetMultiThreaded wants to move hbase:meta...Balancer does NPEs. > AMv2 won't let you move hbase:meta off Master. > Disabled parts of...testCreateTableWithMultipleReplicas in > TestMasterOperationsForRegionReplicas There is an issue w/ assigning more > replicas if number of replicas is changed on us. See '/* DISABLED! FOR > NOW'. > Disabled TestCorruptedRegionStoreFile. Depends on a half-implemented reopen > of a region when a store file goes missing; TODO. > testRetainAssignmentOnRestart in TestRestartCluster does not work. AMv2 does > retain semantic differently. Fix. TODO. > TestMasterFailover needs to be rewritten for AMv2. It uses tricks not > ordained when up on AMv2. The test is also hobbled by fact that we > religiously enforce that only master can carry meta, something we are lose > about in old AM. > Fix Ignores in TestServerCrashProcedure. Master is different now. > Offlining is done differently now: Because of this disabled testOfflineRegion > in TestAsyncRegionAdminApi > Skipping delete of table after test in TestAccessController3 because of > access issues w/ AMv2. AMv1 seems to crash servers on exit too for same lack > of auth perms but AMv2 gets hung up. TODO. See cleanUp method. > TestHCM#testMulti and TestHCM > Fix TestMasterMetrics. Stuff is different now around startup which messes up > this test. Disabled two of three te
[jira] [Created] (HBASE-19279) Reenable TestMasterBalanceThrottling disabled by HBASE-14614
stack created HBASE-19279: - Summary: Reenable TestMasterBalanceThrottling disabled by HBASE-14614 Key: HBASE-19279 URL: https://issues.apache.org/jira/browse/HBASE-19279 Project: HBase Issue Type: Sub-task Reporter: stack See head of class for a comment. It depends on simpleloadbalancer which seems broke. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19278) Reenable cleanup in test teardown in TestAccessController3 disabled by HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-19278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254679#comment-16254679 ] stack commented on HBASE-19278: --- .001 Uncomment the cleanup in teardown. it works now. Did minor cleanup removing a test that makes no sense anymore and unused imports. > Reenable cleanup in test teardown in TestAccessController3 disabled by > HBASE-14614 > -- > > Key: HBASE-19278 > URL: https://issues.apache.org/jira/browse/HBASE-19278 > Project: HBase > Issue Type: Sub-task > Components: Region Assignment >Reporter: stack > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19278.master.001.patch > > > We'd commented out cleanup in the test because test was stalling on it. This > issue is about restoring it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19278) Reenable cleanup in test teardown in TestAccessController3 disabled by HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-19278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19278: -- Assignee: stack Status: Patch Available (was: Open) > Reenable cleanup in test teardown in TestAccessController3 disabled by > HBASE-14614 > -- > > Key: HBASE-19278 > URL: https://issues.apache.org/jira/browse/HBASE-19278 > Project: HBase > Issue Type: Sub-task > Components: Region Assignment >Reporter: stack >Assignee: stack > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19278.master.001.patch > > > We'd commented out cleanup in the test because test was stalling on it. This > issue is about restoring it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19278) Reenable cleanup in test teardown in TestAccessController3 disabled by HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-19278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19278: -- Attachment: HBASE-19278.master.001.patch > Reenable cleanup in test teardown in TestAccessController3 disabled by > HBASE-14614 > -- > > Key: HBASE-19278 > URL: https://issues.apache.org/jira/browse/HBASE-19278 > Project: HBase > Issue Type: Sub-task > Components: Region Assignment >Reporter: stack > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19278.master.001.patch > > > We'd commented out cleanup in the test because test was stalling on it. This > issue is about restoring it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19278) Reenable cleanup in test teardown in TestAccessController3 disabled by HBASE-14614
stack created HBASE-19278: - Summary: Reenable cleanup in test teardown in TestAccessController3 disabled by HBASE-14614 Key: HBASE-19278 URL: https://issues.apache.org/jira/browse/HBASE-19278 Project: HBase Issue Type: Sub-task Reporter: stack We'd commented out cleanup in the test because test was stalling on it. This issue is about restoring it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19262) Revisit checkstyle rules
[
https://issues.apache.org/jira/browse/HBASE-19262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254674#comment-16254674
]
Chia-Ping Tsai commented on HBASE-19262:
+1
The layout rule in the {{hbase_eclipse_formatter.xml}} also need the fix.
> Revisit checkstyle rules
>
>
> Key: HBASE-19262
> URL: https://issues.apache.org/jira/browse/HBASE-19262
> Project: HBase
> Issue Type: Improvement
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1
>
> Attachments: HBASE-19262.patch, idea_import_layout.png
>
>
> For the shaded imports, I prefer we put it at the bottom with a separated
> block. And also, for UTs which use junit rule, we usually declare the field
> as public but checkstyle will report a VisibilityModifier problem.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19163) "Maximum lock count exceeded" from region server's batch processing
[
https://issues.apache.org/jira/browse/HBASE-19163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254672#comment-16254672
]
Hadoop QA commented on HBASE-19163:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
50s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
7s{color} | {color:red} hbase-server: The patch generated 1 new + 236 unchanged
- 0 fixed = 237 total (was 236) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
39s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
50m 8s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}100m
14s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}169m 55s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19163 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897874/HBASE-19163-master-v001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 5cdeb3a11afd 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18
11:55:51 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 600fdee844 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/9840/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9840/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9840/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This messag
[jira] [Commented] (HBASE-19239) Fix findbugs and error-prone warnings
[ https://issues.apache.org/jira/browse/HBASE-19239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254670#comment-16254670 ] Andrew Purtell commented on HBASE-19239: Still making progress. If you'd like to follow along, see https://github.com/apurtell/hbase/commits/HBASE-19239-branch-1 > Fix findbugs and error-prone warnings > - > > Key: HBASE-19239 > URL: https://issues.apache.org/jira/browse/HBASE-19239 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 3.0.0, 1.4.0, 2.0.0-beta-1 > > > Fix important findbugs and error-prone warnings on branch-1.4 / branch-1. > Forward port as appropriate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19270) Reenable TestRegionMergeTransactionOnCluster#testMergeWithReplicas disable by HBASE-14614
[
https://issues.apache.org/jira/browse/HBASE-19270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254668#comment-16254668
]
Hadoop QA commented on HBASE-19270:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
58s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
13s{color} | {color:red} hbase-server: The patch generated 1 new + 3 unchanged
- 1 fixed = 4 total (was 4) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 575 line(s) that end in whitespace. Use
git apply --whitespace=fix <>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
15s{color} | {color:red} The patch 384 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
38s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
64m 44s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}132m 27s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}222m 8s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19270 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897866/HBASE-19270.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 1ffe13be5ca8 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / d89682ea98 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/9837/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/9837/artifact/patc
[jira] [Commented] (HBASE-19251) Merge RawAsyncTable and AsyncTable
[ https://issues.apache.org/jira/browse/HBASE-19251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254664#comment-16254664 ] Appy commented on HBASE-19251: -- sg. +1 Nice cleanup [~Apache9]. > Merge RawAsyncTable and AsyncTable > -- > > Key: HBASE-19251 > URL: https://issues.apache.org/jira/browse/HBASE-19251 > Project: HBase > Issue Type: Improvement > Components: asyncclient, Client >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19251-v1.patch, HBASE-19251-v2.patch, > HBASE-19251.patch > > > As discussed in HBASE-18978. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18357) Enable disabled tests in TestHCM that were disabled by Proc-V2 AM in HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-18357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18357: -- Resolution: Fixed Fix Version/s: 2.0.0-beta-1 Status: Resolved (was: Patch Available) Pushed to branch-2 and master. > Enable disabled tests in TestHCM that were disabled by Proc-V2 AM in > HBASE-14614 > > > Key: HBASE-18357 > URL: https://issues.apache.org/jira/browse/HBASE-18357 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-beta-1 >Reporter: Stephen Yuan Jiang >Assignee: stack > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18357-v1.patch, HBASE-18357.master.001.patch > > > The Core Proc-V2 AM change in HBASE-14614 disabled two tests inTestHCM: > testMulti and testRegionCaching > This JIRA tracks the work to enable them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19262) Revisit checkstyle rules
[ https://issues.apache.org/jira/browse/HBASE-19262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19262: - Attachment: idea_import_layout.png > Revisit checkstyle rules > > > Key: HBASE-19262 > URL: https://issues.apache.org/jira/browse/HBASE-19262 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1 > > Attachments: HBASE-19262.patch, idea_import_layout.png > > > For the shaded imports, I prefer we put it at the bottom with a separated > block. And also, for UTs which use junit rule, we usually declare the field > as public but checkstyle will report a VisibilityModifier problem. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-19262) Revisit checkstyle rules
[ https://issues.apache.org/jira/browse/HBASE-19262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254650#comment-16254650 ] Appy edited comment on HBASE-19262 at 11/16/17 2:37 AM: Btw, the setting above IDEA import order is not working for me. My IDEA is still putting shaded ones in between all others. Is there any other way you guys know to make Intellij automatically layout imports in the order required by our new checkstyle? Does it work for you guys in Eclipse? Edit: Got it working now. Updated the screenshot above linked above. was (Author: appy): Btw, the setting above IDEA import order is not working for me. My IDEA is still putting shaded ones in between all others. Is there any other way you guys know to make Intellij automatically layout imports in the order required by our new checkstyle? Does it work for you guys in Eclipse? > Revisit checkstyle rules > > > Key: HBASE-19262 > URL: https://issues.apache.org/jira/browse/HBASE-19262 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1 > > Attachments: HBASE-19262.patch, idea_import_layout.png > > > For the shaded imports, I prefer we put it at the bottom with a separated > block. And also, for UTs which use junit rule, we usually declare the field > as public but checkstyle will report a VisibilityModifier problem. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19262) Revisit checkstyle rules
[ https://issues.apache.org/jira/browse/HBASE-19262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19262: - Attachment: (was: idea_import_layout.png) > Revisit checkstyle rules > > > Key: HBASE-19262 > URL: https://issues.apache.org/jira/browse/HBASE-19262 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1 > > Attachments: HBASE-19262.patch > > > For the shaded imports, I prefer we put it at the bottom with a separated > block. And also, for UTs which use junit rule, we usually declare the field > as public but checkstyle will report a VisibilityModifier problem. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19262) Revisit checkstyle rules
[ https://issues.apache.org/jira/browse/HBASE-19262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254650#comment-16254650 ] Appy commented on HBASE-19262: -- Btw, the setting above IDEA import order is not working for me. My IDEA is still putting shaded ones in between all others. Is there any other way you guys know to make Intellij automatically layout imports in the order required by our new checkstyle? Does it work for you guys in Eclipse? > Revisit checkstyle rules > > > Key: HBASE-19262 > URL: https://issues.apache.org/jira/browse/HBASE-19262 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1 > > Attachments: HBASE-19262.patch, idea_import_layout.png > > > For the shaded imports, I prefer we put it at the bottom with a separated > block. And also, for UTs which use junit rule, we usually declare the field > as public but checkstyle will report a VisibilityModifier problem. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19215) Incorrect exception handling on the client causes incorrect call timeouts and byte buffer allocations on the server
[
https://issues.apache.org/jira/browse/HBASE-19215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-19215:
Component/s: rpc
> Incorrect exception handling on the client causes incorrect call timeouts and
> byte buffer allocations on the server
> ---
>
> Key: HBASE-19215
> URL: https://issues.apache.org/jira/browse/HBASE-19215
> Project: HBase
> Issue Type: Bug
> Components: rpc
>Affects Versions: 1.3.1, 1.2.6
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
> Fix For: 1.4.0, 1.3.2, 1.2.7, 2.0.0-beta-1
>
> Attachments: HBASE-19215-branch-1.3.patch,
> HBASE-19215.branch-1.001.patch
>
>
> Ran into the situation of oome on the client : java.lang.OutOfMemoryError:
> Direct buffer memory.
> When we encounter an unhandled exception during channel write at RpcClientImpl
> {noformat}
> checkIsOpen(); // Now we're checking that it didn't became idle in between.
> try {
> call.callStats.setRequestSizeBytes(IPCUtil.write(this.out, header,
> call.param,
> cellBlock));
> } catch (IOException e) {
> {noformat}
> we end up leaving the connection open. This becomes especially problematic
> when we get an unhandled exception between writing the length of our request
> on the channel and subsequently writing the params and cellblocks
> {noformat}
>*dos.write(Bytes.toBytes(totalSize));*
> // This allocates a buffer that is the size of the message internally.
> header.writeDelimitedTo(dos);
> if (param != null) param.writeDelimitedTo(dos);
> if (cellBlock != null) dos.write(cellBlock.array(), 0,
> cellBlock.remaining());
> dos.flush();
> return totalSize;
> {noformat}
> After reading the length rs allocates a bb and expects data to be filled.
> However when we encounter an exception during param write we release the
> writelock in rpcclientimpl and do not close the connection, the exception is
> handled at AbstractRpcClient.callBlockingMethod and retried. Now the next
> client request to the same rs writes to the channel however the server
> interprets this as part of the previous request and errors out during proto
> conversion when processing the request since its considered malformed(in the
> worst case this might be misinterpreted as wrong data?). Now the remaining
> data of the current request is read(the current request's size > prev
> request's allocated partially filled bytebuffer) and is misinterpreted as the
> size of new request, in my case this was in gbs. All the client requests time
> out since this bytebuffer is never completely filled. We should close the
> connection for any Throwable and not just ioexception.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19215) Incorrect exception handling on the client causes incorrect call timeouts and byte buffer allocations on the server
[
https://issues.apache.org/jira/browse/HBASE-19215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254643#comment-16254643
]
Sean Busbey commented on HBASE-19215:
-
Thanks!
> Incorrect exception handling on the client causes incorrect call timeouts and
> byte buffer allocations on the server
> ---
>
> Key: HBASE-19215
> URL: https://issues.apache.org/jira/browse/HBASE-19215
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.1, 1.2.6
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
> Fix For: 1.4.0, 1.3.2, 1.2.7, 2.0.0-beta-1
>
> Attachments: HBASE-19215-branch-1.3.patch,
> HBASE-19215.branch-1.001.patch
>
>
> Ran into the situation of oome on the client : java.lang.OutOfMemoryError:
> Direct buffer memory.
> When we encounter an unhandled exception during channel write at RpcClientImpl
> {noformat}
> checkIsOpen(); // Now we're checking that it didn't became idle in between.
> try {
> call.callStats.setRequestSizeBytes(IPCUtil.write(this.out, header,
> call.param,
> cellBlock));
> } catch (IOException e) {
> {noformat}
> we end up leaving the connection open. This becomes especially problematic
> when we get an unhandled exception between writing the length of our request
> on the channel and subsequently writing the params and cellblocks
> {noformat}
>*dos.write(Bytes.toBytes(totalSize));*
> // This allocates a buffer that is the size of the message internally.
> header.writeDelimitedTo(dos);
> if (param != null) param.writeDelimitedTo(dos);
> if (cellBlock != null) dos.write(cellBlock.array(), 0,
> cellBlock.remaining());
> dos.flush();
> return totalSize;
> {noformat}
> After reading the length rs allocates a bb and expects data to be filled.
> However when we encounter an exception during param write we release the
> writelock in rpcclientimpl and do not close the connection, the exception is
> handled at AbstractRpcClient.callBlockingMethod and retried. Now the next
> client request to the same rs writes to the channel however the server
> interprets this as part of the previous request and errors out during proto
> conversion when processing the request since its considered malformed(in the
> worst case this might be misinterpreted as wrong data?). Now the remaining
> data of the current request is read(the current request's size > prev
> request's allocated partially filled bytebuffer) and is misinterpreted as the
> size of new request, in my case this was in gbs. All the client requests time
> out since this bytebuffer is never completely filled. We should close the
> connection for any Throwable and not just ioexception.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19251) Merge RawAsyncTable and AsyncTable
[ https://issues.apache.org/jira/browse/HBASE-19251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254640#comment-16254640 ] Duo Zhang commented on HBASE-19251: --- Wait for the pre commit result. If no problem will commit the v2 patch so that we will not block other tasks. > Merge RawAsyncTable and AsyncTable > -- > > Key: HBASE-19251 > URL: https://issues.apache.org/jira/browse/HBASE-19251 > Project: HBase > Issue Type: Improvement > Components: asyncclient, Client >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19251-v1.patch, HBASE-19251-v2.patch, > HBASE-19251.patch > > > As discussed in HBASE-18978. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19251) Merge RawAsyncTable and AsyncTable
[ https://issues.apache.org/jira/browse/HBASE-19251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19251: -- Hadoop Flags: Reviewed Fix Version/s: 2.0.0-beta-1 Release Note: Merge the RawAsyncTable and AsyncTable interfaces. Use generic to reflection the difference between the observer style scan API. For the implementation which does not have a user specified thread pool, the observer is AdvancedScanResultConsumer. For the implementation which needs a user specified thread pool, the observer is ScanResultConsumer. Component/s: Client asyncclient > Merge RawAsyncTable and AsyncTable > -- > > Key: HBASE-19251 > URL: https://issues.apache.org/jira/browse/HBASE-19251 > Project: HBase > Issue Type: Improvement > Components: asyncclient, Client >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19251-v1.patch, HBASE-19251-v2.patch, > HBASE-19251.patch > > > As discussed in HBASE-18978. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19251) Merge RawAsyncTable and AsyncTable
[ https://issues.apache.org/jira/browse/HBASE-19251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19251: -- Attachment: HBASE-19251-v2.patch > Merge RawAsyncTable and AsyncTable > -- > > Key: HBASE-19251 > URL: https://issues.apache.org/jira/browse/HBASE-19251 > Project: HBase > Issue Type: Improvement >Reporter: Duo Zhang >Assignee: Duo Zhang > Attachments: HBASE-19251-v1.patch, HBASE-19251-v2.patch, > HBASE-19251.patch > > > As discussed in HBASE-18978. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19262) Revisit checkstyle rules
[ https://issues.apache.org/jira/browse/HBASE-19262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254633#comment-16254633 ] Hudson commented on HBASE-19262: FAILURE: Integrated in Jenkins build HBase-1.3-IT #289 (See [https://builds.apache.org/job/HBase-1.3-IT/289/]) HBASE-19262 Revisit checkstyle rules (zhangduo: rev b84e26973f7a41509260e151c17e069789fd2ae0) * (edit) hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml * (edit) hbase-checkstyle/src/main/resources/hbase/checkstyle.xml > Revisit checkstyle rules > > > Key: HBASE-19262 > URL: https://issues.apache.org/jira/browse/HBASE-19262 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1 > > Attachments: HBASE-19262.patch, idea_import_layout.png > > > For the shaded imports, I prefer we put it at the bottom with a separated > block. And also, for UTs which use junit rule, we usually declare the field > as public but checkstyle will report a VisibilityModifier problem. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18964) Deprecate RowProcessor and processRowsWithLocks() APIs that take RowProcessor as an argument
[
https://issues.apache.org/jira/browse/HBASE-18964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254632#comment-16254632
]
Hadoop QA commented on HBASE-18964:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
28s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
16s{color} | {color:red} hbase-server: The patch generated 4 new + 250
unchanged - 0 fixed = 254 total (was 250) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
11s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
58m 29s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 97m
43s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}177m 44s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18964 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897867/hbase-18964.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 5ab1a08fd7a1 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / d89682ea98 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/9836/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9836/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.
[jira] [Commented] (HBASE-19262) Revisit checkstyle rules
[ https://issues.apache.org/jira/browse/HBASE-19262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254629#comment-16254629 ] Hudson commented on HBASE-19262: FAILURE: Integrated in Jenkins build HBase-1.2-IT #1020 (See [https://builds.apache.org/job/HBase-1.2-IT/1020/]) HBASE-19262 Revisit checkstyle rules (zhangduo: rev cb7e600716bd5807c77852b1cbc8d86513b7a698) * (edit) hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml * (edit) hbase-checkstyle/src/main/resources/hbase/checkstyle.xml > Revisit checkstyle rules > > > Key: HBASE-19262 > URL: https://issues.apache.org/jira/browse/HBASE-19262 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1 > > Attachments: HBASE-19262.patch, idea_import_layout.png > > > For the shaded imports, I prefer we put it at the bottom with a separated > block. And also, for UTs which use junit rule, we usually declare the field > as public but checkstyle will report a VisibilityModifier problem. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19262) Revisit checkstyle rules
[ https://issues.apache.org/jira/browse/HBASE-19262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254626#comment-16254626 ] Hudson commented on HBASE-19262: FAILURE: Integrated in Jenkins build HBase-1.2-JDK8 #277 (See [https://builds.apache.org/job/HBase-1.2-JDK8/277/]) HBASE-19262 Revisit checkstyle rules (zhangduo: rev cb7e600716bd5807c77852b1cbc8d86513b7a698) * (edit) hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml * (edit) hbase-checkstyle/src/main/resources/hbase/checkstyle.xml > Revisit checkstyle rules > > > Key: HBASE-19262 > URL: https://issues.apache.org/jira/browse/HBASE-19262 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1 > > Attachments: HBASE-19262.patch, idea_import_layout.png > > > For the shaded imports, I prefer we put it at the bottom with a separated > block. And also, for UTs which use junit rule, we usually declare the field > as public but checkstyle will report a VisibilityModifier problem. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19277) hbase sync between 0.9 and 1.2
SuperbDong created HBASE-19277: -- Summary: hbase sync between 0.9 and 1.2 Key: HBASE-19277 URL: https://issues.apache.org/jira/browse/HBASE-19277 Project: HBase Issue Type: Brainstorming Affects Versions: 1.2.6 Environment: hbase 0.9 hbase1.2 Reporter: SuperbDong I expect synchrodata between hbase 0.9 and hbase 1.2. What's more,I find several ways to do it. Follow : 1.replication (need modify) 2.sync hlog before delete to hdfs .oldlog (need modify) 3.client writes data to two hbase 4.client writes data to kafka and consume to two hbase But, I think the bigest question is one java client how to use two hbase-cliet jar,It must be conflict,How can I do? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19262) Revisit checkstyle rules
[ https://issues.apache.org/jira/browse/HBASE-19262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254623#comment-16254623 ] Hudson commented on HBASE-19262: FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #349 (See [https://builds.apache.org/job/HBase-1.3-JDK7/349/]) HBASE-19262 Revisit checkstyle rules (zhangduo: rev b84e26973f7a41509260e151c17e069789fd2ae0) * (edit) hbase-checkstyle/src/main/resources/hbase/checkstyle.xml * (edit) hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml > Revisit checkstyle rules > > > Key: HBASE-19262 > URL: https://issues.apache.org/jira/browse/HBASE-19262 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1 > > Attachments: HBASE-19262.patch, idea_import_layout.png > > > For the shaded imports, I prefer we put it at the bottom with a separated > block. And also, for UTs which use junit rule, we usually declare the field > as public but checkstyle will report a VisibilityModifier problem. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
