[jira] [Commented] (HBASE-19399) Purge curator dependency from hbase-client
[ https://issues.apache.org/jira/browse/HBASE-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275456#comment-16275456 ] Duo Zhang commented on HBASE-19399: --- Any other concerns [~mdrob]? And I've filed HBASE-19410 for further clean up on the zk stuffs like moving the UTs to hbase-zookeeper and also change the category to ZKTests. Thanks. > Purge curator dependency from hbase-client > -- > > Key: HBASE-19399 > URL: https://issues.apache.org/jira/browse/HBASE-19399 > Project: HBase > Issue Type: Sub-task > Components: Client, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19399-v1.patch, HBASE-19399-v2.patch, > HBASE-19399.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19399) Purge curator dependency from hbase-client
[ https://issues.apache.org/jira/browse/HBASE-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19399: -- Attachment: HBASE-19399-v2.patch Address the comments on rb. > Purge curator dependency from hbase-client > -- > > Key: HBASE-19399 > URL: https://issues.apache.org/jira/browse/HBASE-19399 > Project: HBase > Issue Type: Sub-task > Components: Client, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19399-v1.patch, HBASE-19399-v2.patch, > HBASE-19399.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
Duo Zhang created HBASE-19410: - Summary: Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests Key: HBASE-19410 URL: https://issues.apache.org/jira/browse/HBASE-19410 Project: HBase Issue Type: Task Components: test, Zookeeper Reporter: Duo Zhang Assignee: Duo Zhang Fix For: 2.0.0-beta-1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19406) Fix CompactionRequest equals and hashCode
[ https://issues.apache.org/jira/browse/HBASE-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275437#comment-16275437 ] Hudson commented on HBASE-19406: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4154 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4154/]) HBASE-19406 Fix CompactionRequest equals and hashCode (apurtell: rev c0da74f7c1fefe1df60c8a3e64534eeda97257ef) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequestImpl.java > Fix CompactionRequest equals and hashCode > - > > Key: HBASE-19406 > URL: https://issues.apache.org/jira/browse/HBASE-19406 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 2.0.0-beta-1 > > Attachments: HBASE-19406-branch-1.patch, HBASE-19406.patch > > > This is fallout from an attempt to fix an error prone or findbugs warning. > [ERROR] > loadTest[0](org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk) > Time elapsed: 19.632 s <<< ERROR! > java.io.IOException: > java.io.IOException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2410) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > Caused by: java.lang.StackOverflowError > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > (Repeats until the stack blows up) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19399) Purge curator dependency from hbase-client
[
https://issues.apache.org/jira/browse/HBASE-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275435#comment-16275435
]
Duo Zhang commented on HBASE-19399:
---
Let me try to explain more.
For hbase-shaded, we have 4 modules, and hbase-shaded-check-invariants is only
for checking some rules so we only have 3 modules which we want to deploy, they
are:
1. hbase-shaded-client
2. hbase-shaded-server
3. hbase-shaded-mapreduce
I believe they all do not need to depend on hbase-example, so once we purge the
curator dependency from hbase-client, then they will not depend on curator any
more so we do not need to shade curator and relocate it?
There is a relocation rule for curator in the pom of hbase-shaded
{code}
org.apache.curator
org.apache.hadoop.hbase.shaded.org.apache.curator
{code}
Or there are still transitive dependencies to curator? But I think that's the
duty of the one who depend on curator directly?
Thanks.
> Purge curator dependency from hbase-client
> --
>
> Key: HBASE-19399
> URL: https://issues.apache.org/jira/browse/HBASE-19399
> Project: HBase
> Issue Type: Sub-task
> Components: Client, Zookeeper
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19399-v1.patch, HBASE-19399.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18626) Handle the incompatible change about the replication TableCFs' config
[ https://issues.apache.org/jira/browse/HBASE-18626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275427#comment-16275427 ] Hudson commented on HBASE-18626: SUCCESS: Integrated in Jenkins build HBase-1.4 #1042 (See [https://builds.apache.org/job/HBase-1.4/1042/]) HBASE-18626 Handle the incompatible change about the replication (zghao: rev 0e930bdd516b69fb0b87be1c6082f8b5f365489a) * (edit) src/main/asciidoc/_chapters/upgrading.adoc > Handle the incompatible change about the replication TableCFs' config > - > > Key: HBASE-18626 > URL: https://issues.apache.org/jira/browse/HBASE-18626 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 1.4.0, 1.5.0 > > Attachments: HBASE-18626.branch-1.001.patch > > > About compatibility, there is one incompatible change about the replication > TableCFs' config. The old config is a string and it concatenate the list of > tables and column families in format "table1:cf1,cf2;table2:cfA,cfB" in > zookeeper for table-cf to replication peer mapping. When parse the config, it > use ":" to split the string. If table name includes namespace, it will be > wrong (See HBASE-11386). It is a problem since we support namespace (0.98). > So HBASE-11393 (and HBASE-16653) changed it to a PB object. When rolling > update cluster, you need rolling master first. And the master will try to > translate the string config to a PB object. But there are two problems. > 1. Permission problem. The replication client can write the zookeeper > directly. So the znode may have different owner. And master may don't have > the write permission for the znode. It maybe failed to translate old > table-cfs string to new PB Object. See HBASE-16938 > 2. We usually keep compatibility between old client and new server. But the > old replication client may write a string config to znode directly. Then the > new server can't parse them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19399) Purge curator dependency from hbase-client
[ https://issues.apache.org/jira/browse/HBASE-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275421#comment-16275421 ] stack commented on HBASE-19399: --- I'm not following [~Apache9] so can't help (On 'depend on hbase-example', I'd say no. hbase-example is for illustration only -- but perhaps I am not understanding). When you say 'we do not need to shade hbase-example' ... or 'shade hbase-example module', pardon me, I don't follow. Perhaps [~mdrob] know what is being referred to. Thanks. > Purge curator dependency from hbase-client > -- > > Key: HBASE-19399 > URL: https://issues.apache.org/jira/browse/HBASE-19399 > Project: HBase > Issue Type: Sub-task > Components: Client, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19399-v1.patch, HBASE-19399.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19336) Improve rsgroup to allow assign all tables within a specified namespace by only writing namespace
[
https://issues.apache.org/jira/browse/HBASE-19336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275410#comment-16275410
]
Hudson commented on HBASE-19336:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4153 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/4153/])
HBASE-19336 Improve rsgroup to allow assign all tables within a (zghao: rev
5e0d00f88493788cd78974b0c48efb36a10596fc)
* (add)
hbase-shell/src/main/ruby/shell/commands/move_servers_namespaces_rsgroup.rb
* (edit) hbase-shell/src/main/ruby/shell.rb
* (edit) hbase-shell/src/test/ruby/shell/rsgroup_shell_test.rb
* (edit) hbase-shell/src/main/ruby/hbase/rsgroup_admin.rb
* (add) hbase-shell/src/main/ruby/shell/commands/move_namespaces_rsgroup.rb
> Improve rsgroup to allow assign all tables within a specified namespace by
> only writing namespace
> -
>
> Key: HBASE-19336
> URL: https://issues.apache.org/jira/browse/HBASE-19336
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup
>Affects Versions: 2.0.0-alpha-4
>Reporter: xinxin fan
>Assignee: xinxin fan
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19336-master-V2.patch,
> HBASE-19336-master-V3.patch, HBASE-19336-master-V4.patch,
> HBASE-19336-master-V4.patch, HBASE-19336-master-V4.patch,
> HBASE-19336-master-V5.patch, HBASE-19336-master-V6.patch,
> HBASE-19336-master-V7.patch, HBASE-19336-master.patch
>
>
> Currently, use can only assign tables within a namespace from one group to
> another by writing all table names in move_tables_rsgroup command. Allowing
> to assign all tables within a specifed namespace by only wirting namespace
> name is useful.
> Usage as follows:
> {code:java}
> hbase(main):055:0> move_namespaces_rsgroup 'dest_rsgroup',['ns1']
> Took 2.2211 seconds
> {code}
> {code:java}
> hbase(main):051:0* move_servers_namespaces_rsgroup
> 'dest_rsgroup',['hbase39.lt.163.org:60020'],['ns1','ns2']
> Took 15.3710 seconds
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19285) Add per-table latency histograms
[ https://issues.apache.org/jira/browse/HBASE-19285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275409#comment-16275409 ] Hudson commented on HBASE-19285: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4153 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4153/]) HBASE-19285 Implements table-level latency histograms (elserj: rev 835d15bf9779698bd0b269c2008a496be79090d2) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * (add) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerTableMetrics.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java * (add) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableLatenciesImpl.java * (add) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableLatencies.java * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsTableLatencies.java * (edit) hbase-hadoop-compat/src/test/java/org/apache/hadoop/hbase/test/MetricsAssertHelper.java * (edit) hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/test/MetricsAssertHelperImpl.java * (add) hbase-hadoop2-compat/src/main/resources/META-INF/services/org.apache.hadoop.hbase.regionserver.MetricsTableLatencies * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java > Add per-table latency histograms > > > Key: HBASE-19285 > URL: https://issues.apache.org/jira/browse/HBASE-19285 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Clay B. >Assignee: Josh Elser >Priority: Critical > Fix For: 2.0.0, 1.4.0, 1.3.3 > > Attachments: HBASE-19285.001.branch-1.3.patch, > HBASE-19285.002.branch-1.3.patch, HBASE-19285.003.branch-1.3.patch, > HBaseTableLatencyMetrics.png > > > HBASE-17017 removed the per-region latency histograms (e.g. Get, Put, Scan at > p75, p85, etc) > HBASE-15518 added some per-table metrics, but not the latency histograms. > Given the previous conversations, it seems like it these per-table > aggregations weren't intentionally omitted, just never re-implemented after > the per-region removal. They're some really nice out-of-the-box metrics we > can provide to our users/admins as long as it's not detrimental. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19409) HBase client brings down YARN node manager when it tries to register JvmMetrics in the hadoop metrics system
[
https://issues.apache.org/jira/browse/HBASE-19409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275393#comment-16275393
]
Mike Drob commented on HBASE-19409:
---
That's actually the hadoop2 version, but the hadoop 3 version is very similar
https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java#L59-L64
> HBase client brings down YARN node manager when it tries to register
> JvmMetrics in the hadoop metrics system
>
>
> Key: HBASE-19409
> URL: https://issues.apache.org/jira/browse/HBASE-19409
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 2.0.0-alpha-4
>Reporter: Haibo Chen
>Priority: Critical
>
> YARN ATSv2 leverages HBase as its data store. When ATSv2 is enabled,
> YARN NM will act as HBase clients to write data into HBase cluster.
> Because YARN NM jvms already register jvmMetrics in the metrics system and
> no duplicate is allowed, when HBase client tries to register jvmMetrics
> again, NM will crash with the following exception.
> {code}
> ERROR org.apache.hadoop.yarn.server.nodemanager.NodeManager: Error starting
> NodeManager
> org.apache.hadoop.service.ServiceStateException: java.io.IOException:
> java.lang.reflect.InvocationTargetException
> at
> org.apache.hadoop.service.ServiceStateException.convert(ServiceStateException.java:105)
> at
> org.apache.hadoop.service.AbstractService.init(AbstractService.java:173)
> at
> org.apache.hadoop.yarn.server.timelineservice.collector.TimelineCollectorManager.serviceInit(TimelineCollectorManager.java:62)
> at
> org.apache.hadoop.yarn.server.timelineservice.collector.NodeTimelineCollectorManager.serviceInit(NodeTimelineCollectorManager.java:112)
> at
> org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
> at
> org.apache.hadoop.yarn.server.timelineservice.collector.PerNodeTimelineCollectorsAuxService.serviceInit(PerNodeTimelineCollectorsAuxService.java:87)
> at
> org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
> at
> org.apache.hadoop.yarn.server.nodemanager.containermanager.AuxServices.serviceInit(AuxServices.java:167)
> at
> org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
> at
> org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:108)
> at
> org.apache.hadoop.yarn.server.nodemanager.containermanager.ContainerManagerImpl.serviceInit(ContainerManagerImpl.java:315)
> at
> org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
> at
> org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:108)
> at
> org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManager.java:440)
> at
> org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
> at
> org.apache.hadoop.yarn.server.nodemanager.NodeManager.initAndStartNodeManager(NodeManager.java:833)
> at
> org.apache.hadoop.yarn.server.nodemanager.NodeManager.main(NodeManager.java:894)
> Caused by: java.io.IOException: java.lang.reflect.InvocationTargetException
> at
> org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:221)
> at
> org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:114)
> at
> org.apache.hadoop.yarn.server.timelineservice.storage.HBaseTimelineWriterImpl.serviceInit(HBaseTimelineWriterImpl.java:123)
> at
> org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
> ... 15 more
> Caused by: java.lang.reflect.InvocationTargetException
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:219)
> ... 18 more
> Caused by: java.lang.RuntimeException: Could not create interface
> org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSource Is the hadoop
> compatibility jar on the classpath?
> at
> org.apache.hadoop.hbase.CompatibilitySingletonFactory.getInstance(CompatibilitySingletonFactory.java:75)
> at
> org.apache.hadoop.hbase.zookeeper.MetricsZooKeeper.(MetricsZooKeeper.java:38)
> at
>
[jira] [Commented] (HBASE-19409) HBase client brings down YARN node manager when it tries to register JvmMetrics in the hadoop metrics system
[
https://issues.apache.org/jira/browse/HBASE-19409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275392#comment-16275392
]
Mike Drob commented on HBASE-19409:
---
The code around {{at
org.apache.hadoop.metrics2.source.JvmMetrics$Singleton.init(JvmMetrics.java:61)}}
is
{code}
synchronized JvmMetrics init(String processName, String sessionId) {
if (this.impl == null) {
this.impl = JvmMetrics.create(processName, sessionId,
DefaultMetricsSystem.instance());
}
return this.impl;
}
{code}
Why is impl null there in the singleton?
> HBase client brings down YARN node manager when it tries to register
> JvmMetrics in the hadoop metrics system
>
>
> Key: HBASE-19409
> URL: https://issues.apache.org/jira/browse/HBASE-19409
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 2.0.0-alpha-4
>Reporter: Haibo Chen
>Priority: Critical
>
> YARN ATSv2 leverages HBase as its data store. When ATSv2 is enabled,
> YARN NM will act as HBase clients to write data into HBase cluster.
> Because YARN NM jvms already register jvmMetrics in the metrics system and
> no duplicate is allowed, when HBase client tries to register jvmMetrics
> again, NM will crash with the following exception.
> {code}
> ERROR org.apache.hadoop.yarn.server.nodemanager.NodeManager: Error starting
> NodeManager
> org.apache.hadoop.service.ServiceStateException: java.io.IOException:
> java.lang.reflect.InvocationTargetException
> at
> org.apache.hadoop.service.ServiceStateException.convert(ServiceStateException.java:105)
> at
> org.apache.hadoop.service.AbstractService.init(AbstractService.java:173)
> at
> org.apache.hadoop.yarn.server.timelineservice.collector.TimelineCollectorManager.serviceInit(TimelineCollectorManager.java:62)
> at
> org.apache.hadoop.yarn.server.timelineservice.collector.NodeTimelineCollectorManager.serviceInit(NodeTimelineCollectorManager.java:112)
> at
> org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
> at
> org.apache.hadoop.yarn.server.timelineservice.collector.PerNodeTimelineCollectorsAuxService.serviceInit(PerNodeTimelineCollectorsAuxService.java:87)
> at
> org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
> at
> org.apache.hadoop.yarn.server.nodemanager.containermanager.AuxServices.serviceInit(AuxServices.java:167)
> at
> org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
> at
> org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:108)
> at
> org.apache.hadoop.yarn.server.nodemanager.containermanager.ContainerManagerImpl.serviceInit(ContainerManagerImpl.java:315)
> at
> org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
> at
> org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:108)
> at
> org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManager.java:440)
> at
> org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
> at
> org.apache.hadoop.yarn.server.nodemanager.NodeManager.initAndStartNodeManager(NodeManager.java:833)
> at
> org.apache.hadoop.yarn.server.nodemanager.NodeManager.main(NodeManager.java:894)
> Caused by: java.io.IOException: java.lang.reflect.InvocationTargetException
> at
> org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:221)
> at
> org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:114)
> at
> org.apache.hadoop.yarn.server.timelineservice.storage.HBaseTimelineWriterImpl.serviceInit(HBaseTimelineWriterImpl.java:123)
> at
> org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
> ... 15 more
> Caused by: java.lang.reflect.InvocationTargetException
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:219)
> ... 18 more
> Caused by: java.lang.RuntimeException: Could not create interface
> org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSource Is the hadoop
> compatibility jar on the classpath?
> at
>
[jira] [Updated] (HBASE-19406) Fix CompactionRequest equals and hashCode
[ https://issues.apache.org/jira/browse/HBASE-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19406: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) > Fix CompactionRequest equals and hashCode > - > > Key: HBASE-19406 > URL: https://issues.apache.org/jira/browse/HBASE-19406 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 2.0.0-beta-1 > > Attachments: HBASE-19406-branch-1.patch, HBASE-19406.patch > > > This is fallout from an attempt to fix an error prone or findbugs warning. > [ERROR] > loadTest[0](org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk) > Time elapsed: 19.632 s <<< ERROR! > java.io.IOException: > java.io.IOException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2410) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > Caused by: java.lang.StackOverflowError > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > (Repeats until the stack blows up) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19406) Fix CompactionRequest equals and hashCode
[ https://issues.apache.org/jira/browse/HBASE-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275390#comment-16275390 ] Andrew Purtell commented on HBASE-19406: Not all tests in branch-2 are passing but the failures don't look related. E.g. TestRegionServerReadRequestMetrics#testReadRequestsCountWithDeletedRow . All the compaction tests pass > Fix CompactionRequest equals and hashCode > - > > Key: HBASE-19406 > URL: https://issues.apache.org/jira/browse/HBASE-19406 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 2.0.0-beta-1 > > Attachments: HBASE-19406-branch-1.patch, HBASE-19406.patch > > > This is fallout from an attempt to fix an error prone or findbugs warning. > [ERROR] > loadTest[0](org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk) > Time elapsed: 19.632 s <<< ERROR! > java.io.IOException: > java.io.IOException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2410) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > Caused by: java.lang.StackOverflowError > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > (Repeats until the stack blows up) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19395) [branch-1] TestEndToEndSplitTransaction.testMasterOpsWhileSplitting fails with NPE
[ https://issues.apache.org/jira/browse/HBASE-19395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275387#comment-16275387 ] Hudson commented on HBASE-19395: FAILURE: Integrated in Jenkins build HBase-1.4 #1041 (See [https://builds.apache.org/job/HBase-1.4/1041/]) HBASE-19395 [branch-1] (apurtell: rev fd1f6207967b494219824461873a108a44ad106d) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java > [branch-1] TestEndToEndSplitTransaction.testMasterOpsWhileSplitting fails > with NPE > -- > > Key: HBASE-19395 > URL: https://issues.apache.org/jira/browse/HBASE-19395 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Andrew Purtell >Priority: Trivial > Fix For: 1.4.0 > > Attachments: HBASE-19395-branch-1.patch > > > [INFO] Running > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction > [ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 50.388 s <<< FAILURE! - in > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction > [ERROR] > testMasterOpsWhileSplitting(org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction) > Time elapsed: 8.903 s <<< ERROR! > java.lang.NullPointerException > at > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction.test(TestEndToEndSplitTransaction.java:239) > at > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction.testMasterOpsWhileSplitting(TestEndToEndSplitTransaction.java:148) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19399) Purge curator dependency from hbase-client
[ https://issues.apache.org/jira/browse/HBASE-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275372#comment-16275372 ] Duo Zhang commented on HBASE-19399: --- I know, the curator stuffs are added by me. IIRC we use watcher so curator receipts can greatly simplify the code. My question is do we want users to depend on hbase-example? If not then we do not need to shade hbase-example, nor to provide a shaded hbase-example module? Thanks. > Purge curator dependency from hbase-client > -- > > Key: HBASE-19399 > URL: https://issues.apache.org/jira/browse/HBASE-19399 > Project: HBase > Issue Type: Sub-task > Components: Client, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19399-v1.patch, HBASE-19399.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-19406) Fix CompactionRequest equals and hashCode
[ https://issues.apache.org/jira/browse/HBASE-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275368#comment-16275368 ] Andrew Purtell edited comment on HBASE-19406 at 12/2/17 2:02 AM: - The TestEndToEndSplitTransaction failure is HBASE-19395 The TestHTableMultiplexerFlushCache failure looks unrelated. Passes for me. was (Author: apurtell): The TestEndToEndSplitTransaction failure is HBASE-19237 The TestHTableMultiplexerFlushCache failure looks unrelated. Passes for me. > Fix CompactionRequest equals and hashCode > - > > Key: HBASE-19406 > URL: https://issues.apache.org/jira/browse/HBASE-19406 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 2.0.0-beta-1 > > Attachments: HBASE-19406-branch-1.patch, HBASE-19406.patch > > > This is fallout from an attempt to fix an error prone or findbugs warning. > [ERROR] > loadTest[0](org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk) > Time elapsed: 19.632 s <<< ERROR! > java.io.IOException: > java.io.IOException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2410) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > Caused by: java.lang.StackOverflowError > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > (Repeats until the stack blows up) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19406) Fix CompactionRequest equals and hashCode
[ https://issues.apache.org/jira/browse/HBASE-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275367#comment-16275367 ] stack commented on HBASE-19406: --- You pushed fix for one of the failures and @chia-ping is concurrently fixing the other > Fix CompactionRequest equals and hashCode > - > > Key: HBASE-19406 > URL: https://issues.apache.org/jira/browse/HBASE-19406 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 2.0.0-beta-1 > > Attachments: HBASE-19406-branch-1.patch, HBASE-19406.patch > > > This is fallout from an attempt to fix an error prone or findbugs warning. > [ERROR] > loadTest[0](org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk) > Time elapsed: 19.632 s <<< ERROR! > java.io.IOException: > java.io.IOException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2410) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > Caused by: java.lang.StackOverflowError > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > (Repeats until the stack blows up) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19406) Fix CompactionRequest equals and hashCode
[ https://issues.apache.org/jira/browse/HBASE-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275368#comment-16275368 ] Andrew Purtell commented on HBASE-19406: The TestEndToEndSplitTransaction failure is HBASE-19237 The TestHTableMultiplexerFlushCache failure looks unrelated. Passes for me. > Fix CompactionRequest equals and hashCode > - > > Key: HBASE-19406 > URL: https://issues.apache.org/jira/browse/HBASE-19406 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 2.0.0-beta-1 > > Attachments: HBASE-19406-branch-1.patch, HBASE-19406.patch > > > This is fallout from an attempt to fix an error prone or findbugs warning. > [ERROR] > loadTest[0](org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk) > Time elapsed: 19.632 s <<< ERROR! > java.io.IOException: > java.io.IOException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2410) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > Caused by: java.lang.StackOverflowError > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > (Repeats until the stack blows up) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19406) Fix CompactionRequest equals and hashCode
[
https://issues.apache.org/jira/browse/HBASE-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275365#comment-16275365
]
Hadoop QA commented on HBASE-19406:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
8s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
0s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
50s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
51m 16s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 88m
42s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}159m 20s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19406 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12900304/HBASE-19406.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux debaee197604 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 835d15bf97 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10190/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10190/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Fix CompactionRequest equals and hashCode
>
[jira] [Commented] (HBASE-19395) [branch-1] TestEndToEndSplitTransaction.testMasterOpsWhileSplitting fails with NPE
[
https://issues.apache.org/jira/browse/HBASE-19395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275364#comment-16275364
]
Hadoop QA commented on HBASE-19395:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
53s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} branch-1 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} branch-1 passed with JDK v1.7.0_161 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
17s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
54s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
19s{color} | {color:red} hbase-server in branch-1 has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} branch-1 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} branch-1 passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
37s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
38s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
29m 7s{color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3
2.7.4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 89m
14s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}137m 43s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:36a7029 |
| JIRA Issue | HBASE-19395 |
| JIRA Patch URL |
[jira] [Commented] (HBASE-19326) Remove decommissioned servers from rsgroup
[
https://issues.apache.org/jira/browse/HBASE-19326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275358#comment-16275358
]
Andrew Purtell commented on HBASE-19326:
Same here, there may be something going on with TestShell. Looks good when run
by itself but will run it on a system with load artificially raised to see if
anything shakes loose. Will be another JIRA
> Remove decommissioned servers from rsgroup
> --
>
> Key: HBASE-19326
> URL: https://issues.apache.org/jira/browse/HBASE-19326
> Project: HBase
> Issue Type: New Feature
> Components: rsgroup
>Affects Versions: 3.0.0, 2.0.0-beta-2
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-19326-branch-1.patch,
> HBASE-19326.branch-2.001.patch, HBASE-19326.master.001.patch,
> HBASE-19326.master.002.patch, HBASE-19326.master.003.patch,
> HBASE-19326.master.004.patch, HBASE-19326.master.005.patch
>
>
> In HBASE-18131, we add an hbase shell command {{clear_deadservers}} to clear
> deadserver list in ServerManager.
> But rsgroup still contains these dead servers, so we should also remove dead
> servers from the group information.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19396) Fix flaky test TestHTableMultiplexerFlushCache
[ https://issues.apache.org/jira/browse/HBASE-19396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275355#comment-16275355 ] stack commented on HBASE-19396: --- Andy pushed the fix for HBASE-19395 to branch-1 50 minutes ago so this build did not have the fix. Not sure about TestMasterReplication. Flakey? > Fix flaky test TestHTableMultiplexerFlushCache > -- > > Key: HBASE-19396 > URL: https://issues.apache.org/jira/browse/HBASE-19396 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 1.5.0 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Minor > Fix For: 2.0.0, 1.3.2, 1.4.1, 1.5.0, 1.2.7 > > Attachments: HBASE-19396.branch-1.001.patch, > HBASE-19396.branch-1.001.patch > > > [INFO] Running org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache > [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 36.67 > s <<< FAILURE! - in > org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache > [ERROR] > testOnRegionMove(org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache) > Time elapsed: 4.644 s <<< FAILURE! > java.lang.AssertionError: Did not find a new RegionServer to use > at > org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache.testOnRegionMove(TestHTableMultiplexerFlushCache.java:160) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19336) Improve rsgroup to allow assign all tables within a specified namespace by only writing namespace
[
https://issues.apache.org/jira/browse/HBASE-19336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang updated HBASE-19336:
---
Release Note:
Add two new shell cmd.
move_namespaces_rsgroup is used to reassign tables of specified namespaces from
one RegionServer group to another.
move_servers_namespaces_rsgroup is used to reassign regionServers and tables of
specified namespaces from one group to another.
> Improve rsgroup to allow assign all tables within a specified namespace by
> only writing namespace
> -
>
> Key: HBASE-19336
> URL: https://issues.apache.org/jira/browse/HBASE-19336
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup
>Affects Versions: 2.0.0-alpha-4
>Reporter: xinxin fan
>Assignee: xinxin fan
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19336-master-V2.patch,
> HBASE-19336-master-V3.patch, HBASE-19336-master-V4.patch,
> HBASE-19336-master-V4.patch, HBASE-19336-master-V4.patch,
> HBASE-19336-master-V5.patch, HBASE-19336-master-V6.patch,
> HBASE-19336-master-V7.patch, HBASE-19336-master.patch
>
>
> Currently, use can only assign tables within a namespace from one group to
> another by writing all table names in move_tables_rsgroup command. Allowing
> to assign all tables within a specifed namespace by only wirting namespace
> name is useful.
> Usage as follows:
> {code:java}
> hbase(main):055:0> move_namespaces_rsgroup 'dest_rsgroup',['ns1']
> Took 2.2211 seconds
> {code}
> {code:java}
> hbase(main):051:0* move_servers_namespaces_rsgroup
> 'dest_rsgroup',['hbase39.lt.163.org:60020'],['ns1','ns2']
> Took 15.3710 seconds
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19336) Improve rsgroup to allow assign all tables within a specified namespace by only writing namespace
[
https://issues.apache.org/jira/browse/HBASE-19336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang updated HBASE-19336:
---
Resolution: Fixed
Fix Version/s: 2.0.0-beta-1
Status: Resolved (was: Patch Available)
Pushed to master and branch-2. Thanks [~xinxin fan] for contributing.
> Improve rsgroup to allow assign all tables within a specified namespace by
> only writing namespace
> -
>
> Key: HBASE-19336
> URL: https://issues.apache.org/jira/browse/HBASE-19336
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup
>Affects Versions: 2.0.0-alpha-4
>Reporter: xinxin fan
>Assignee: xinxin fan
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19336-master-V2.patch,
> HBASE-19336-master-V3.patch, HBASE-19336-master-V4.patch,
> HBASE-19336-master-V4.patch, HBASE-19336-master-V4.patch,
> HBASE-19336-master-V5.patch, HBASE-19336-master-V6.patch,
> HBASE-19336-master-V7.patch, HBASE-19336-master.patch
>
>
> Currently, use can only assign tables within a namespace from one group to
> another by writing all table names in move_tables_rsgroup command. Allowing
> to assign all tables within a specifed namespace by only wirting namespace
> name is useful.
> Usage as follows:
> {code:java}
> hbase(main):055:0> move_namespaces_rsgroup 'dest_rsgroup',['ns1']
> Took 2.2211 seconds
> {code}
> {code:java}
> hbase(main):051:0* move_servers_namespaces_rsgroup
> 'dest_rsgroup',['hbase39.lt.163.org:60020'],['ns1','ns2']
> Took 15.3710 seconds
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-19409) HBase client brings down YARN node manager when it tries to register JvmMetrics in the hadoop metrics system
Haibo Chen created HBASE-19409:
--
Summary: HBase client brings down YARN node manager when it tries
to register JvmMetrics in the hadoop metrics system
Key: HBASE-19409
URL: https://issues.apache.org/jira/browse/HBASE-19409
Project: HBase
Issue Type: Bug
Components: Client
Affects Versions: 2.0.0-alpha-4
Reporter: Haibo Chen
Priority: Critical
YARN ATSv2 leverages HBase as its data store. When ATSv2 is enabled,
YARN NM will act as HBase clients to write data into HBase cluster.
Because YARN NM jvms already register jvmMetrics in the metrics system and
no duplicate is allowed, when HBase client tries to register jvmMetrics again,
NM will crash with the following exception.
{code}
ERROR org.apache.hadoop.yarn.server.nodemanager.NodeManager: Error starting
NodeManager
org.apache.hadoop.service.ServiceStateException: java.io.IOException:
java.lang.reflect.InvocationTargetException
at
org.apache.hadoop.service.ServiceStateException.convert(ServiceStateException.java:105)
at
org.apache.hadoop.service.AbstractService.init(AbstractService.java:173)
at
org.apache.hadoop.yarn.server.timelineservice.collector.TimelineCollectorManager.serviceInit(TimelineCollectorManager.java:62)
at
org.apache.hadoop.yarn.server.timelineservice.collector.NodeTimelineCollectorManager.serviceInit(NodeTimelineCollectorManager.java:112)
at
org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
at
org.apache.hadoop.yarn.server.timelineservice.collector.PerNodeTimelineCollectorsAuxService.serviceInit(PerNodeTimelineCollectorsAuxService.java:87)
at
org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
at
org.apache.hadoop.yarn.server.nodemanager.containermanager.AuxServices.serviceInit(AuxServices.java:167)
at
org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
at
org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:108)
at
org.apache.hadoop.yarn.server.nodemanager.containermanager.ContainerManagerImpl.serviceInit(ContainerManagerImpl.java:315)
at
org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
at
org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:108)
at
org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManager.java:440)
at
org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
at
org.apache.hadoop.yarn.server.nodemanager.NodeManager.initAndStartNodeManager(NodeManager.java:833)
at
org.apache.hadoop.yarn.server.nodemanager.NodeManager.main(NodeManager.java:894)
Caused by: java.io.IOException: java.lang.reflect.InvocationTargetException
at
org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:221)
at
org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:114)
at
org.apache.hadoop.yarn.server.timelineservice.storage.HBaseTimelineWriterImpl.serviceInit(HBaseTimelineWriterImpl.java:123)
at
org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
... 15 more
Caused by: java.lang.reflect.InvocationTargetException
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at
org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:219)
... 18 more
Caused by: java.lang.RuntimeException: Could not create interface
org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSource Is the hadoop
compatibility jar on the classpath?
at
org.apache.hadoop.hbase.CompatibilitySingletonFactory.getInstance(CompatibilitySingletonFactory.java:75)
at
org.apache.hadoop.hbase.zookeeper.MetricsZooKeeper.(MetricsZooKeeper.java:38)
at
org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.(RecoverableZooKeeper.java:130)
at org.apache.hadoop.hbase.zookeeper.ZKUtil.connect(ZKUtil.java:137)
at
org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.(ZooKeeperWatcher.java:134)
at
org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.(ZooKeeperWatcher.java:108)
at
org.apache.hadoop.hbase.client.ZooKeeperKeepAliveConnection.(ZooKeeperKeepAliveConnection.java:43)
at
org.apache.hadoop.hbase.client.ConnectionImplementation.getKeepAliveZooKeeperWatcher(ConnectionImplementation.java:1231)
at
[jira] [Updated] (HBASE-19407) [branch-2] Remove backup/restore
[ https://issues.apache.org/jira/browse/HBASE-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19407: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) > [branch-2] Remove backup/restore > > > Key: HBASE-19407 > URL: https://issues.apache.org/jira/browse/HBASE-19407 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19407.branch-2.001.patch > > > As per thread up on dev list [1], we won't be including the backup/restore in > hbase2. This issue purges it. > 1. > http://apache-hbase.679495.n3.nabble.com/DISCUSS-Plan-to-avoid-backup-restore-removal-from-2-0-td4091807.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19407) [branch-2] Remove backup/restore
[ https://issues.apache.org/jira/browse/HBASE-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275345#comment-16275345 ] stack commented on HBASE-19407: --- Pushed to branch-2. Lurking timeouts need to address in branch-2 but unrelated. [ERROR] Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 53.839 s <<< FAILURE! - in org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient [ERROR] testSkipFlushTableSnapshot(org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient) Time elapsed: 6.337 s <<< FAILURE! java.lang.AssertionError: Expected snapshot to contain family 'fam', but it does not. at org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient.testSkipFlushTableSnapshot(TestFlushSnapshotFromClient.java:201) [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 63.994 s <<< FAILURE! - in org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient [ERROR] testSkipFlushTableSnapshot(org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient) Time elapsed: 3.789 s <<< FAILURE! java.lang.AssertionError: Expected snapshot to contain family 'fam', but it does not. at org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient.testSkipFlushTableSnapshot(TestFlushSnapshotFromClient.java:201) [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 72.611 s - in org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient [INFO] [INFO] Results: [INFO] [WARNING] Flakes: [WARNING] org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy.testPurgeExpiredFiles(org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy) [ERROR] Run 1: TestFIFOCompactionPolicy.testPurgeExpiredFiles:129 Waiting timed out after [30,000] msec The store file count 2 is still greater than 1 [INFO] Run 2: PASS [INFO] [WARNING] org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient.testSkipFlushTableSnapshot(org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient) [ERROR] Run 1: TestFlushSnapshotFromClient.testSkipFlushTableSnapshot:201 Expected snapshot to contain family 'fam', but it does not. [ERROR] Run 2: TestFlushSnapshotFromClient.testSkipFlushTableSnapshot:201 Expected snapshot to contain family 'fam', but it does not. [INFO] Run 3: PASS [INFO] [INFO] [WARNING] Tests run: 3162, Failures: 0, Errors: 0, Skipped: 39, Flakes: 2 > [branch-2] Remove backup/restore > > > Key: HBASE-19407 > URL: https://issues.apache.org/jira/browse/HBASE-19407 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19407.branch-2.001.patch > > > As per thread up on dev list [1], we won't be including the backup/restore in > hbase2. This issue purges it. > 1. > http://apache-hbase.679495.n3.nabble.com/DISCUSS-Plan-to-avoid-backup-restore-removal-from-2-0-td4091807.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19406) Fix CompactionRequest equals and hashCode
[
https://issues.apache.org/jira/browse/HBASE-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275338#comment-16275338
]
Hadoop QA commented on HBASE-19406:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 8m
22s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
17s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} branch-1 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
39s{color} | {color:green} branch-1 passed with JDK v1.7.0_161 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
21s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
2s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
22s{color} | {color:red} hbase-server in branch-1 has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} branch-1 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} branch-1 passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
39s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
41s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
31m 8s{color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3
2.7.4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}120m 28s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}180m 30s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestEndToEndSplitTransaction |
| | hadoop.hbase.client.TestHTableMultiplexerFlushCache |
\\
\\
|| Subsystem || Report/Notes ||
|
[jira] [Commented] (HBASE-19326) Remove decommissioned servers from rsgroup
[
https://issues.apache.org/jira/browse/HBASE-19326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275337#comment-16275337
]
stack commented on HBASE-19326:
---
The TestShell test passes locally for me on branch-1.4...
> Remove decommissioned servers from rsgroup
> --
>
> Key: HBASE-19326
> URL: https://issues.apache.org/jira/browse/HBASE-19326
> Project: HBase
> Issue Type: New Feature
> Components: rsgroup
>Affects Versions: 3.0.0, 2.0.0-beta-2
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-19326-branch-1.patch,
> HBASE-19326.branch-2.001.patch, HBASE-19326.master.001.patch,
> HBASE-19326.master.002.patch, HBASE-19326.master.003.patch,
> HBASE-19326.master.004.patch, HBASE-19326.master.005.patch
>
>
> In HBASE-18131, we add an hbase shell command {{clear_deadservers}} to clear
> deadserver list in ServerManager.
> But rsgroup still contains these dead servers, so we should also remove dead
> servers from the group information.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19396) Fix flaky test TestHTableMultiplexerFlushCache
[
https://issues.apache.org/jira/browse/HBASE-19396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275339#comment-16275339
]
Hadoop QA commented on HBASE-19396:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 18m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
18s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} branch-1 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
39s{color} | {color:green} branch-1 passed with JDK v1.7.0_161 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
21s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
2s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
23s{color} | {color:red} hbase-server in branch-1 has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} branch-1 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} branch-1 passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
20s{color} | {color:red} hbase-server: The patch generated 1 new + 2 unchanged
- 3 fixed = 3 total (was 5) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
40s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
31m 13s{color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3
2.7.4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}120m 51s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}190m 54s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestEndToEndSplitTransaction |
| | hadoop.hbase.replication.TestMasterReplication |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:36a7029 |
|
[jira] [Commented] (HBASE-19239) Fix findbugs and error-prone warnings (branch-1)
[ https://issues.apache.org/jira/browse/HBASE-19239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275335#comment-16275335 ] Andrew Purtell commented on HBASE-19239: [~zghaobac] Sounds good > Fix findbugs and error-prone warnings (branch-1) > > > Key: HBASE-19239 > URL: https://issues.apache.org/jira/browse/HBASE-19239 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0 > > Attachments: HBASE-19239-branch-1.patch, HBASE-19239-branch-1.patch, > HBASE-19239-branch-1.patch > > > Fix important findbugs and error-prone warnings on branch-1.4 / branch-1. > Forward port as appropriate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19407) [branch-2] Remove backup/restore
[
https://issues.apache.org/jira/browse/HBASE-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275322#comment-16275322
]
Hadoop QA commented on HBASE-19407:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
39s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
8s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 31 new or modified test
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
35s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
23s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
56s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
40s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
53s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 3m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s{color} | {color:green} The patch hbase-protocol-shaded passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} hbase-it: The patch generated 0 new + 0 unchanged -
3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s{color} | {color:green} The patch hbase-assembly passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
50s{color} | {color:green} root: The patch generated 0 new + 0 unchanged - 265
fixed = 0 total (was 265) {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
5s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
44s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
37m 49s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
3m 53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}170m 40s{color}
| {color:red} root in the patch failed. {color} |
|
[jira] [Commented] (HBASE-19239) Fix findbugs and error-prone warnings (branch-1)
[ https://issues.apache.org/jira/browse/HBASE-19239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275320#comment-16275320 ] Guanghao Zhang commented on HBASE-19239: Ping [~apurtell]. Maybe a addendum to fix the findbugs warning? > Fix findbugs and error-prone warnings (branch-1) > > > Key: HBASE-19239 > URL: https://issues.apache.org/jira/browse/HBASE-19239 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0 > > Attachments: HBASE-19239-branch-1.patch, HBASE-19239-branch-1.patch, > HBASE-19239-branch-1.patch > > > Fix important findbugs and error-prone warnings on branch-1.4 / branch-1. > Forward port as appropriate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18626) Handle the incompatible change about the replication TableCFs' config
[ https://issues.apache.org/jira/browse/HBASE-18626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275317#comment-16275317 ] Guanghao Zhang commented on HBASE-18626: Pushed to branch-1 and branch-1.4. Thanks [~apurtell] for reviewing. I will attach a new patch for branch-2. > Handle the incompatible change about the replication TableCFs' config > - > > Key: HBASE-18626 > URL: https://issues.apache.org/jira/browse/HBASE-18626 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 1.4.0, 1.5.0 > > Attachments: HBASE-18626.branch-1.001.patch > > > About compatibility, there is one incompatible change about the replication > TableCFs' config. The old config is a string and it concatenate the list of > tables and column families in format "table1:cf1,cf2;table2:cfA,cfB" in > zookeeper for table-cf to replication peer mapping. When parse the config, it > use ":" to split the string. If table name includes namespace, it will be > wrong (See HBASE-11386). It is a problem since we support namespace (0.98). > So HBASE-11393 (and HBASE-16653) changed it to a PB object. When rolling > update cluster, you need rolling master first. And the master will try to > translate the string config to a PB object. But there are two problems. > 1. Permission problem. The replication client can write the zookeeper > directly. So the znode may have different owner. And master may don't have > the write permission for the znode. It maybe failed to translate old > table-cfs string to new PB Object. See HBASE-16938 > 2. We usually keep compatibility between old client and new server. But the > old replication client may write a string config to znode directly. Then the > new server can't parse them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18626) Handle the incompatible change about the replication TableCFs' config
[ https://issues.apache.org/jira/browse/HBASE-18626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18626: --- Fix Version/s: 1.5.0 1.4.0 > Handle the incompatible change about the replication TableCFs' config > - > > Key: HBASE-18626 > URL: https://issues.apache.org/jira/browse/HBASE-18626 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 1.4.0, 1.5.0 > > Attachments: HBASE-18626.branch-1.001.patch > > > About compatibility, there is one incompatible change about the replication > TableCFs' config. The old config is a string and it concatenate the list of > tables and column families in format "table1:cf1,cf2;table2:cfA,cfB" in > zookeeper for table-cf to replication peer mapping. When parse the config, it > use ":" to split the string. If table name includes namespace, it will be > wrong (See HBASE-11386). It is a problem since we support namespace (0.98). > So HBASE-11393 (and HBASE-16653) changed it to a PB object. When rolling > update cluster, you need rolling master first. And the master will try to > translate the string config to a PB object. But there are two problems. > 1. Permission problem. The replication client can write the zookeeper > directly. So the znode may have different owner. And master may don't have > the write permission for the znode. It maybe failed to translate old > table-cfs string to new PB Object. See HBASE-16938 > 2. We usually keep compatibility between old client and new server. But the > old replication client may write a string config to znode directly. Then the > new server can't parse them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19258) IntegrationTest for Backup and Restore
[ https://issues.apache.org/jira/browse/HBASE-19258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19258: -- Fix Version/s: (was: 2.0.0-beta-1) 3.0.0 > IntegrationTest for Backup and Restore > -- > > Key: HBASE-19258 > URL: https://issues.apache.org/jira/browse/HBASE-19258 > Project: HBase > Issue Type: Test > Components: integration tests >Reporter: Josh Elser >Assignee: Vladimir Rodionov >Priority: Blocker > Fix For: 3.0.0 > > > See chatter at https://docs.google.com/document/d/1xbPlLKjOcPq2LDqjbSkF6uND > AG0mzgOxek6P3POLeMc/edit?usp=sharing > We need to get an IntegrationTest in place for backup and restore. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19408) Remove WALActionsListener.Base
[
https://issues.apache.org/jira/browse/HBASE-19408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275311#comment-16275311
]
Hadoop QA commented on HBASE-19408:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 12 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
36s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
9s{color} | {color:green} hbase-server: The patch generated 0 new + 102
unchanged - 1 fixed = 102 total (was 103) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green} The patch hbase-mapreduce passed checkstyle {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
18s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
59m 11s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 92m
41s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m
36s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
36s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}185m 56s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19408 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12900286/HBASE-19408.v0.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux e3e74acd3e91 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision |
[jira] [Commented] (HBASE-19406) Fix CompactionRequest equals and hashCode
[ https://issues.apache.org/jira/browse/HBASE-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275310#comment-16275310 ] Andrew Purtell commented on HBASE-19406: It just passed the whole suite for branch-1. Checking branch-2 now. > Fix CompactionRequest equals and hashCode > - > > Key: HBASE-19406 > URL: https://issues.apache.org/jira/browse/HBASE-19406 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 2.0.0-beta-1 > > Attachments: HBASE-19406-branch-1.patch, HBASE-19406.patch > > > This is fallout from an attempt to fix an error prone or findbugs warning. > [ERROR] > loadTest[0](org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk) > Time elapsed: 19.632 s <<< ERROR! > java.io.IOException: > java.io.IOException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2410) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > Caused by: java.lang.StackOverflowError > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > (Repeats until the stack blows up) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19406) Fix CompactionRequest equals and hashCode
[ https://issues.apache.org/jira/browse/HBASE-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275308#comment-16275308 ] stack commented on HBASE-19406: --- Patch looks great. +1 if passes tests. +1 for everywhere from 1.4^ > Fix CompactionRequest equals and hashCode > - > > Key: HBASE-19406 > URL: https://issues.apache.org/jira/browse/HBASE-19406 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 2.0.0-beta-1 > > Attachments: HBASE-19406-branch-1.patch, HBASE-19406.patch > > > This is fallout from an attempt to fix an error prone or findbugs warning. > [ERROR] > loadTest[0](org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk) > Time elapsed: 19.632 s <<< ERROR! > java.io.IOException: > java.io.IOException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2410) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > Caused by: java.lang.StackOverflowError > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > (Repeats until the stack blows up) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19395) [branch-1] TestEndToEndSplitTransaction.testMasterOpsWhileSplitting fails with NPE
[ https://issues.apache.org/jira/browse/HBASE-19395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275307#comment-16275307 ] Andrew Purtell commented on HBASE-19395: Pushed to branch-1 and branch-1.4 > [branch-1] TestEndToEndSplitTransaction.testMasterOpsWhileSplitting fails > with NPE > -- > > Key: HBASE-19395 > URL: https://issues.apache.org/jira/browse/HBASE-19395 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Andrew Purtell >Priority: Trivial > Fix For: 1.4.0 > > Attachments: HBASE-19395-branch-1.patch > > > [INFO] Running > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction > [ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 50.388 s <<< FAILURE! - in > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction > [ERROR] > testMasterOpsWhileSplitting(org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction) > Time elapsed: 8.903 s <<< ERROR! > java.lang.NullPointerException > at > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction.test(TestEndToEndSplitTransaction.java:239) > at > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction.testMasterOpsWhileSplitting(TestEndToEndSplitTransaction.java:148) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19395) [branch-1] TestEndToEndSplitTransaction.testMasterOpsWhileSplitting fails with NPE
[ https://issues.apache.org/jira/browse/HBASE-19395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19395: --- Resolution: Fixed Status: Resolved (was: Patch Available) > [branch-1] TestEndToEndSplitTransaction.testMasterOpsWhileSplitting fails > with NPE > -- > > Key: HBASE-19395 > URL: https://issues.apache.org/jira/browse/HBASE-19395 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Andrew Purtell >Priority: Trivial > Fix For: 1.4.0 > > Attachments: HBASE-19395-branch-1.patch > > > [INFO] Running > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction > [ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 50.388 s <<< FAILURE! - in > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction > [ERROR] > testMasterOpsWhileSplitting(org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction) > Time elapsed: 8.903 s <<< ERROR! > java.lang.NullPointerException > at > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction.test(TestEndToEndSplitTransaction.java:239) > at > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction.testMasterOpsWhileSplitting(TestEndToEndSplitTransaction.java:148) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16239) Better logging for RPC related exceptions
[ https://issues.apache.org/jira/browse/HBASE-16239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275303#comment-16275303 ] stack commented on HBASE-16239: --- +1 Beautiful > Better logging for RPC related exceptions > - > > Key: HBASE-16239 > URL: https://issues.apache.org/jira/browse/HBASE-16239 > Project: HBase > Issue Type: Bug >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 2.0.0, 1.3.2, 1.4.1 > > Attachments: HBASE-16239.master.001.patch, > HBASE-16239.master.002.patch, hbase-16239_v1.patch, hbase-16239_v2.patch, > hbase-16239_v2.patch, hbase-16239_v2.patch > > > On many occasions, we have to debug RPC related issues, but it is hard in AP > + RetryingRpcCaller since we mask the stack traces until all retries have > been exhausted (which takes 10 minutes by default). > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19399) Purge curator dependency from hbase-client
[ https://issues.apache.org/jira/browse/HBASE-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275302#comment-16275302 ] stack commented on HBASE-19399: --- bq. Do we also shade hbase-example? I may be confusing you. examples does this w/ curator kalashnikov:hbase-examples stack$ grep -ri curator src/main/java/ src/main/java//org/apache/hadoop/hbase/coprocessor/example/ZooKeeperScanPolicyObserver.java:import org.apache.curator.framework.CuratorFramework; src/main/java//org/apache/hadoop/hbase/coprocessor/example/ZooKeeperScanPolicyObserver.java:import org.apache.curator.framework.CuratorFrameworkFactory; src/main/java//org/apache/hadoop/hbase/coprocessor/example/ZooKeeperScanPolicyObserver.java:import org.apache.curator.framework.recipes.cache.ChildData; src/main/java//org/apache/hadoop/hbase/coprocessor/example/ZooKeeperScanPolicyObserver.java:import org.apache.curator.framework.recipes.cache.NodeCache; src/main/java//org/apache/hadoop/hbase/coprocessor/example/ZooKeeperScanPolicyObserver.java:import org.apache.curator.retry.RetryForever; src/main/java//org/apache/hadoop/hbase/coprocessor/example/ZooKeeperScanPolicyObserver.java: private CuratorFramework client; src/main/java//org/apache/hadoop/hbase/coprocessor/example/ZooKeeperScanPolicyObserver.java: CuratorFrameworkFactory.builder().connectString(ensemble).sessionTimeoutMs(sessionTimeout) Just remove the example? Stale. > Purge curator dependency from hbase-client > -- > > Key: HBASE-19399 > URL: https://issues.apache.org/jira/browse/HBASE-19399 > Project: HBase > Issue Type: Sub-task > Components: Client, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19399-v1.patch, HBASE-19399.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19287) master hangs forever if RecoverMeta send assign meta region request to target server fail
[
https://issues.apache.org/jira/browse/HBASE-19287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275299#comment-16275299
]
stack commented on HBASE-19287:
---
Thank you for digging in here.
bq. The problem happens on step3, if the master does not receive response from
target server for any reason; That assign procedure will become a dead
procedure, no other mechanism will wake the procedure(i.e put it back into
procedure scheduler) any more.
Yes. This is how it works.
If in the scheduler, it will be rescheduled and then put the back of the queue
over and over again burning CPU, no, if it is not taken off the scheduler?
bq. So we need to come up with a idea to wake those suspend procedures.
Ok.
bq. My suggestion is that we can have a separate thread to check all those
suspend procedures periodically, if they are timeout or their target server is
crashed, we can do reassign.
Ok. Have to be careful though.
* Has to be more when it times out an assign. Perhaps the RS is just taking a
long time. We'd have to cancel any ongoing assign, confirm it cancelled, before
we'd reassign. We want to avoid AMv1 double-assignment, the case where two
different RS were trying to open a Region.
* If crash, SCP will run and do clean-up?
bq. (1) The target server crashed will only suspend meta's assign since master
is not up yet, other regions can be wake by ServerCrashProcedure.
I don't grok the above. Please say more please.
bq. (2) Timeout mechanism for all suspend procedure. If one procedure has been
suspended for too long, we mark it as timeout and redo the remain steps.
See above. We have to be careful here. We must avoid the mess we had in AMv1.
BTW, here where things were at at AMv2 commit time:
https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.y71bhu8smpqp
This timeout was something we were supposed to come back too.
Again, thank you [~easyliangjob] for digging in here in this important but dark
corner
> master hangs forever if RecoverMeta send assign meta region request to target
> server fail
> -
>
> Key: HBASE-19287
> URL: https://issues.apache.org/jira/browse/HBASE-19287
> Project: HBase
> Issue Type: Bug
>Reporter: Yi Liang
>Assignee: Yi Liang
>
> 2017-11-10 19:26:56,019 INFO [ProcExecWrkr-1]
> procedure.RecoverMetaProcedure: pid=138,
> state=RUNNABLE:RECOVER_META_ASSIGN_REGIONS; RecoverMetaProcedure
> failedMetaServer=null, splitWal=true; Retaining meta assignment to
> server=hadoop-slave1.hadoop,16020,1510341981454
> 2017-11-10 19:26:56,029 INFO [ProcExecWrkr-1] procedure2.ProcedureExecutor:
> Initialized subprocedures=[{pid=139, ppid=138,
> state=RUNNABLE:REGION_TRANSITION_QUEUE; AssignProcedure table=hbase:meta,
> region=1588230740, target=hadoop-slave1.hadoop,16020,1510341981454}]
> 2017-11-10 19:26:56,067 INFO [ProcExecWrkr-2]
> procedure.MasterProcedureScheduler: pid=139, ppid=138,
> state=RUNNABLE:REGION_TRANSITION_QUEUE; AssignProcedure table=hbase:meta,
> region=1588230740, target=hadoop-slave1.hadoop,16020,1510341981454 hbase:meta
> hbase:meta,,1.1588230740
> 2017-11-10 19:26:56,071 INFO [ProcExecWrkr-2] assignment.AssignProcedure:
> Start pid=139, ppid=138, state=RUNNABLE:REGION_TRANSITION_QUEUE;
> AssignProcedure table=hbase:meta, region=1588230740,
> target=hadoop-slave1.hadoop,16020,1510341981454; rit=OFFLINE,
> location=hadoop-slave1.hadoop,16020,1510341981454; forceNewPlan=false,
> retain=false
> 2017-11-10 19:26:56,224 INFO [ProcExecWrkr-4] zookeeper.MetaTableLocator:
> Setting hbase:meta (replicaId=0) location in ZooKeeper as
> hadoop-slave2.hadoop,16020,1510341988652
> 2017-11-10 19:26:56,230 INFO [ProcExecWrkr-4]
> assignment.RegionTransitionProcedure: Dispatch pid=139, ppid=138,
> state=RUNNABLE:REGION_TRANSITION_DISPATCH; AssignProcedure table=hbase:meta,
> region=1588230740, target=hadoop-slave1.hadoop,16020,1510341981454;
> rit=OPENING, location=hadoop-slave2.hadoop,16020,1510341988652
> 2017-11-10 19:26:56,382 INFO [ProcedureDispatcherTimeoutThread]
> procedure.RSProcedureDispatcher: Using procedure batch rpc execution for
> serverName=hadoop-slave2.hadoop,16020,1510341988652 version=2097152
> 2017-11-10 19:26:57,542 INFO [main-EventThread]
> zookeeper.RegionServerTracker: RegionServer ephemeral node deleted,
> processing expiration [hadoop-slave2.hadoop,16020,1510341988652]
> 2017-11-10 19:26:57,543 INFO [main-EventThread] master.ServerManager: Master
> doesn't enable ServerShutdownHandler during initialization, delay expiring
> server hadoop-slave2.hadoop,16020,1510341988652
> 2017-11-10 19:26:58,875 INFO
> [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=16000]
> master.ServerManager: Registering
>
[jira] [Commented] (HBASE-19390) Revert to older version of Jetty 9.3
[ https://issues.apache.org/jira/browse/HBASE-19390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275298#comment-16275298 ] Hudson commented on HBASE-19390: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4152 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4152/]) HBASE-19390 Temporary downgrade to Jetty 9.3 to match hadoop (mdrob: rev 680a534acd2fee1f50ddc3eb0d14c27d30f35679) * (edit) pom.xml > Revert to older version of Jetty 9.3 > - > > Key: HBASE-19390 > URL: https://issues.apache.org/jira/browse/HBASE-19390 > Project: HBase > Issue Type: Bug >Reporter: Esteban Gutierrez >Assignee: Mike Drob > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19390.patch, HBASE-19390.v2.patch > > > As discussed in HBASE-19256 we will have to temporarily revert to Jetty 9.3 > due existing issues with 9.4 and Hadoop3. Once HBASE-19256 is resolved we can > revert to 9.4. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19125) TestReplicator is flaky
[ https://issues.apache.org/jira/browse/HBASE-19125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275219#comment-16275219 ] Chia-Ping Tsai commented on HBASE-19125: bq. Hopefully this is fixed by HBASE-19385 It does. I looped the test 20 times for branch-1. All pass. > TestReplicator is flaky > --- > > Key: HBASE-19125 > URL: https://issues.apache.org/jira/browse/HBASE-19125 > Project: HBase > Issue Type: Bug >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 2.0.0, 3.0.0, 1.4.1, 1.5.0 > > > TestReplicator fails now and again. I had a look at the test. This is > something I contributed a while back but looking at it again it needs a > different approach. I'm going to disable it for now until this issue is > resolved. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16239) Better logging for RPC related exceptions
[
https://issues.apache.org/jira/browse/HBASE-16239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275216#comment-16275216
]
Hadoop QA commented on HBASE-16239:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
25s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
55s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
26s{color} | {color:red} hbase-client: The patch generated 17 new + 7 unchanged
- 0 fixed = 24 total (was 7) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 14 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
30s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
47m 7s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
45s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 67m 58s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-16239 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12900296/HBASE-16239.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 5792ca3f8517 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 680a534acd |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/10189/artifact/patchprocess/diff-checkstyle-hbase-client.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/10189/artifact/patchprocess/whitespace-tabs.txt
|
| Test Results |
[jira] [Comment Edited] (HBASE-17852) Add Fault tolerance to HBASE-14417 (Support bulk loaded files in incremental backup)
[
https://issues.apache.org/jira/browse/HBASE-17852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275203#comment-16275203
]
Vladimir Rodionov edited comment on HBASE-17852 at 12/1/17 11:53 PM:
-
[~appy],
# Only Admin user can run backups, therefore, there is no need to run multiple
backups in parallel. Admin can run them in a single backup command.
# Restore can be run in parallel with other commands. That is artificial
limitation and can be removed easily. It means Admin can run backups session
and multiple restore sessions in parallel. I personally, do not see or
anticipate strong request to allow multiple backup sessions in parallel. I
advise you to go through doc and you fill find and easy to work-around parallel
sessions by combining them into single one, [~appy]
# There is no issues with cross - RPC in backup case, because RPC call is a
single hop and, hence, deadlock - free
# Failure of BackupObserver to record bulk loaded file with result in bulk load
failure - yes. *But I do not see an alternative here*, do you? We need to
record *all bulk loaded file names and store them persistently before bulk load
operation completes*. Do you have an idea, how can this be achieved, w/o
failing bulk load itself and w/o touching hbase core code?
The only thing I agree here is support for parallel deletes, merges and if we
will introduce this support we can easily add multiple backup session support
for free.
I personally, was very impressed by you, guys, you spent so much time looking
for design and implementation flaws, when time was running out literally,
during this week. Good job. Why haven't you done this couple months before?
Some of the "problems" you described looks kind of artificial:
{quote}
4) During restore, backup table goes offline, cron job attempts backup and
fails.
{quote}
And what? Table goes offline? Why would not you or somebody else to spend time
and fix this offline regions/tables crap HBase is full of?
was (Author: vrodionov):
[~appy],
# Only Admin user can run backups, therefore, there is no need to run multiple
backups in parallel. Admin can run them in a single backup command.
# Restore can be run in parallel with other commands. That is artificial
limitation and can be removed easily. It means Admin can run backups session
and multiple restore sessions in parallel. I personally, do not see or
anticipate strong request to allow multiple backup sessions in parallel. I
advise you to go through doc and you fill find and easy to work-around parallel
sessions by combining them into single one, [~appy]
# There is no issues with cross - RPC in backup case, because RPC call is a
single hop and, hence, deadlock - free
# Failure of BackupObserver to record bulk loaded file with result in bulk load
failure - yes. *But I do not see an alternative here*, do you? We need to
record *all bulk loaded file names and store them persistently before bulk load
operation completes*. Do you have an idea, how can this be achieved, w/o
failing bulk load itself and w/o touching hbase core code?
The only thing I agree here is support for parallel deletes, merges and if we
will introduce this support we can easily add multiple backup session support
for free.
I personally, was very impressed by you, guys, you spent so much time looking
for design and implementation flaws, when time was running out literally,
during this week. Good job. Why haven't you done this couple months before?
> Add Fault tolerance to HBASE-14417 (Support bulk loaded files in incremental
> backup)
>
>
> Key: HBASE-17852
> URL: https://issues.apache.org/jira/browse/HBASE-17852
> Project: HBase
> Issue Type: Sub-task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
> Attachments: HBASE-17852-v1.patch, HBASE-17852-v2.patch,
> HBASE-17852-v3.patch, HBASE-17852-v4.patch, HBASE-17852-v5.patch,
> HBASE-17852-v6.patch, HBASE-17852-v7.patch, HBASE-17852-v8.patch,
> HBASE-17852-v9.patch
>
>
> Design approach rollback-via-snapshot implemented in this ticket:
> # Before backup create/delete/merge starts we take a snapshot of the backup
> meta-table (backup system table). This procedure is lightweight because meta
> table is small, usually should fit a single region.
> # When operation fails on a server side, we handle this failure by cleaning
> up partial data in backup destination, followed by restoring backup
> meta-table from a snapshot.
> # When operation fails on a client side (abnormal termination, for example),
> next time user will try create/merge/delete he(she) will see error message,
> that system is in inconsistent state and repair is required, he(she) will
> need to
[jira] [Commented] (HBASE-19326) Remove decommissioned servers from rsgroup
[
https://issues.apache.org/jira/browse/HBASE-19326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275207#comment-16275207
]
Hudson commented on HBASE-19326:
FAILURE: Integrated in Jenkins build HBase-1.4 #1040 (See
[https://builds.apache.org/job/HBase-1.4/1040/])
HBASE-19326 Remove decommissioned servers from rsgroup (apurtell: rev
5ac82136ebe28630962628ffc1ca15277734884a)
* (add) hbase-shell/src/main/ruby/shell/commands/remove_servers_rsgroup.rb
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminClient.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java
* (edit)
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroups.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdmin.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
* (edit) hbase-shell/src/main/ruby/shell.rb
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManager.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* (edit) hbase-shell/src/main/ruby/hbase/rsgroup_admin.rb
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterAndRegionObserver.java
* (edit)
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RSGroupAdminProtos.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
* (edit)
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java
* (edit) hbase-protocol/src/main/protobuf/RSGroupAdmin.proto
* (edit)
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/VerifyingRSGroupAdminClient.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
> Remove decommissioned servers from rsgroup
> --
>
> Key: HBASE-19326
> URL: https://issues.apache.org/jira/browse/HBASE-19326
> Project: HBase
> Issue Type: New Feature
> Components: rsgroup
>Affects Versions: 3.0.0, 2.0.0-beta-2
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-19326-branch-1.patch,
> HBASE-19326.branch-2.001.patch, HBASE-19326.master.001.patch,
> HBASE-19326.master.002.patch, HBASE-19326.master.003.patch,
> HBASE-19326.master.004.patch, HBASE-19326.master.005.patch
>
>
> In HBASE-18131, we add an hbase shell command {{clear_deadservers}} to clear
> deadserver list in ServerManager.
> But rsgroup still contains these dead servers, so we should also remove dead
> servers from the group information.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19385) [1.3] TestReplicator failed 1.3 nightly
[ https://issues.apache.org/jira/browse/HBASE-19385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275206#comment-16275206 ] Hudson commented on HBASE-19385: FAILURE: Integrated in Jenkins build HBase-1.4 #1040 (See [https://builds.apache.org/job/HBase-1.4/1040/]) Amend HBASE-19385 [1.3] TestReplicator failed 1.3 nightly (apurtell: rev 347980ca6f06a1da4f13aadd7240ae153c0968a8) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicator.java > [1.3] TestReplicator failed 1.3 nightly > --- > > Key: HBASE-19385 > URL: https://issues.apache.org/jira/browse/HBASE-19385 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: stack > Fix For: 2.0.0, 1.4.0, 1.3.2 > > Attachments: HBASE-19385.branch-1.3.001.patch > > > TestReplicator failed 1.3 nightly. Running it local, it fails sometimes. > Complaint is illegalmonitorstate and indeed, locking around latch is unsafe. > Fixing this, I can't get it to fail locally anymore. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17852) Add Fault tolerance to HBASE-14417 (Support bulk loaded files in incremental backup)
[ https://issues.apache.org/jira/browse/HBASE-17852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275203#comment-16275203 ] Vladimir Rodionov commented on HBASE-17852: --- [~appy], # Only Admin user can run backups, therefore, there is no need to run multiple backups in parallel. Admin can run them in a single backup command. # Restore can be run in parallel with other commands. That is artificial limitation and can be removed easily. It means Admin can run backups session and multiple restore sessions in parallel. I personally, do not see or anticipate strong request to allow multiple backup sessions in parallel. I advise you to go through doc and you fill find and easy to work-around parallel sessions by combining them into single one, [~appy] # There is no issues with cross - RPC in backup case, because RPC call is a single hop and, hence, deadlock - free # Failure of BackupObserver to record bulk loaded file with result in bulk load failure - yes. *But I do not see an alternative here*, do you? We need to record *all bulk loaded file names and store them persistently before bulk load operation completes*. Do you have an idea, how can this be achieved, w/o failing bulk load itself and w/o touching hbase core code? The only thing I agree here is support for parallel deletes, merges and if we will introduce this support we can easily add multiple backup session support for free. I personally, was very impressed by you, guys, you spent so much time looking for design and implementation flaws, when time was running out literally, during this week. Good job. Why haven't you done this couple months before? > Add Fault tolerance to HBASE-14417 (Support bulk loaded files in incremental > backup) > > > Key: HBASE-17852 > URL: https://issues.apache.org/jira/browse/HBASE-17852 > Project: HBase > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Fix For: 2.0.0 > > Attachments: HBASE-17852-v1.patch, HBASE-17852-v2.patch, > HBASE-17852-v3.patch, HBASE-17852-v4.patch, HBASE-17852-v5.patch, > HBASE-17852-v6.patch, HBASE-17852-v7.patch, HBASE-17852-v8.patch, > HBASE-17852-v9.patch > > > Design approach rollback-via-snapshot implemented in this ticket: > # Before backup create/delete/merge starts we take a snapshot of the backup > meta-table (backup system table). This procedure is lightweight because meta > table is small, usually should fit a single region. > # When operation fails on a server side, we handle this failure by cleaning > up partial data in backup destination, followed by restoring backup > meta-table from a snapshot. > # When operation fails on a client side (abnormal termination, for example), > next time user will try create/merge/delete he(she) will see error message, > that system is in inconsistent state and repair is required, he(she) will > need to run backup repair tool. > # To avoid multiple writers to the backup system table (backup client and > BackupObserver's) we introduce small table ONLY to keep listing of bulk > loaded files. All backup observers will work only with this new tables. The > reason: in case of a failure during backup create/delete/merge/restore, when > system performs automatic rollback, some data written by backup observers > during failed operation may be lost. This is what we try to avoid. > # Second table keeps only bulk load related references. We do not care about > consistency of this table, because bulk load is idempotent operation and can > be repeated after failure. Partially written data in second table does not > affect on BackupHFileCleaner plugin, because this data (list of bulk loaded > files) correspond to a files which have not been loaded yet successfully and, > hence - are not visible to the system -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17883) release 1.4.0
[ https://issues.apache.org/jira/browse/HBASE-17883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275201#comment-16275201 ] Andrew Purtell commented on HBASE-17883: A couple of straightforward issues remaining, found by tests: HBASE-19395, HBASE-19406 > release 1.4.0 > - > > Key: HBASE-17883 > URL: https://issues.apache.org/jira/browse/HBASE-17883 > Project: HBase > Issue Type: Task > Components: community >Affects Versions: 1.4.0 >Reporter: Sean Busbey >Assignee: Andrew Purtell >Priority: Critical > Fix For: 1.4.0 > > > Let's start working through doing the needful; it's been almost 3 months sine > 1.3.0. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19406) Fix CompactionRequest equals and hashCode
[ https://issues.apache.org/jira/browse/HBASE-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275199#comment-16275199 ] Andrew Purtell commented on HBASE-19406: Not sure where HadoopQA is but I'm running the test suite locally with this change applied. If it all looks good then I will use my prerogative as branch-1.4 RM to commit the minor (and necessary) change to branch-1.4 and branch-1 so I can continue toward getting the RC out. Will hold off on commits to branch-2 and up until I have a +1 (what do you think [~stack]?), or maybe I'll end up getting a review before any commit. > Fix CompactionRequest equals and hashCode > - > > Key: HBASE-19406 > URL: https://issues.apache.org/jira/browse/HBASE-19406 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 2.0.0-beta-1 > > Attachments: HBASE-19406-branch-1.patch, HBASE-19406.patch > > > This is fallout from an attempt to fix an error prone or findbugs warning. > [ERROR] > loadTest[0](org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk) > Time elapsed: 19.632 s <<< ERROR! > java.io.IOException: > java.io.IOException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2410) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > Caused by: java.lang.StackOverflowError > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > (Repeats until the stack blows up) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19395) [branch-1] TestEndToEndSplitTransaction.testMasterOpsWhileSplitting fails with NPE
[ https://issues.apache.org/jira/browse/HBASE-19395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19395: --- Priority: Trivial (was: Minor) > [branch-1] TestEndToEndSplitTransaction.testMasterOpsWhileSplitting fails > with NPE > -- > > Key: HBASE-19395 > URL: https://issues.apache.org/jira/browse/HBASE-19395 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Andrew Purtell >Priority: Trivial > Fix For: 1.4.0 > > Attachments: HBASE-19395-branch-1.patch > > > [INFO] Running > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction > [ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 50.388 s <<< FAILURE! - in > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction > [ERROR] > testMasterOpsWhileSplitting(org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction) > Time elapsed: 8.903 s <<< ERROR! > java.lang.NullPointerException > at > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction.test(TestEndToEndSplitTransaction.java:239) > at > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction.testMasterOpsWhileSplitting(TestEndToEndSplitTransaction.java:148) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19395) [branch-1] TestEndToEndSplitTransaction.testMasterOpsWhileSplitting fails with NPE
[ https://issues.apache.org/jira/browse/HBASE-19395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275189#comment-16275189 ] Andrew Purtell commented on HBASE-19395: Oh [~elserj] this problem came in with HBASE-19285 FYI Going to commit trivial fix shortly. > [branch-1] TestEndToEndSplitTransaction.testMasterOpsWhileSplitting fails > with NPE > -- > > Key: HBASE-19395 > URL: https://issues.apache.org/jira/browse/HBASE-19395 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Andrew Purtell >Priority: Minor > Fix For: 1.4.0 > > Attachments: HBASE-19395-branch-1.patch > > > [INFO] Running > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction > [ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 50.388 s <<< FAILURE! - in > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction > [ERROR] > testMasterOpsWhileSplitting(org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction) > Time elapsed: 8.903 s <<< ERROR! > java.lang.NullPointerException > at > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction.test(TestEndToEndSplitTransaction.java:239) > at > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction.testMasterOpsWhileSplitting(TestEndToEndSplitTransaction.java:148) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19407) [branch-2] Remove backup/restore
[ https://issues.apache.org/jira/browse/HBASE-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275185#comment-16275185 ] Andrew Purtell commented on HBASE-19407: +1 Sorry to see this didn't make 2.0 > [branch-2] Remove backup/restore > > > Key: HBASE-19407 > URL: https://issues.apache.org/jira/browse/HBASE-19407 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19407.branch-2.001.patch > > > As per thread up on dev list [1], we won't be including the backup/restore in > hbase2. This issue purges it. > 1. > http://apache-hbase.679495.n3.nabble.com/DISCUSS-Plan-to-avoid-backup-restore-removal-from-2-0-td4091807.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19395) [branch-1] TestEndToEndSplitTransaction.testMasterOpsWhileSplitting fails with NPE
[ https://issues.apache.org/jira/browse/HBASE-19395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19395: --- Attachment: HBASE-19395-branch-1.patch > [branch-1] TestEndToEndSplitTransaction.testMasterOpsWhileSplitting fails > with NPE > -- > > Key: HBASE-19395 > URL: https://issues.apache.org/jira/browse/HBASE-19395 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Andrew Purtell >Priority: Minor > Fix For: 1.4.0 > > Attachments: HBASE-19395-branch-1.patch > > > [INFO] Running > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction > [ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 50.388 s <<< FAILURE! - in > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction > [ERROR] > testMasterOpsWhileSplitting(org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction) > Time elapsed: 8.903 s <<< ERROR! > java.lang.NullPointerException > at > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction.test(TestEndToEndSplitTransaction.java:239) > at > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction.testMasterOpsWhileSplitting(TestEndToEndSplitTransaction.java:148) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19395) [branch-1] TestEndToEndSplitTransaction.testMasterOpsWhileSplitting fails with NPE
[ https://issues.apache.org/jira/browse/HBASE-19395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19395: --- Status: Patch Available (was: Open) > [branch-1] TestEndToEndSplitTransaction.testMasterOpsWhileSplitting fails > with NPE > -- > > Key: HBASE-19395 > URL: https://issues.apache.org/jira/browse/HBASE-19395 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Andrew Purtell >Priority: Minor > Fix For: 1.4.0 > > Attachments: HBASE-19395-branch-1.patch > > > [INFO] Running > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction > [ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 50.388 s <<< FAILURE! - in > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction > [ERROR] > testMasterOpsWhileSplitting(org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction) > Time elapsed: 8.903 s <<< ERROR! > java.lang.NullPointerException > at > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction.test(TestEndToEndSplitTransaction.java:239) > at > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction.testMasterOpsWhileSplitting(TestEndToEndSplitTransaction.java:148) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19395) [branch-1] TestEndToEndSplitTransaction.testMasterOpsWhileSplitting fails with NPE
[
https://issues.apache.org/jira/browse/HBASE-19395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-19395:
---
Affects Version/s: (was: 1.5.0)
Priority: Minor (was: Major)
Fix Version/s: 1.4.0
I would like to have more time to figure out what changed, but the reason for
the NPE and the fix for it both look very straightforward: In
RsRpcServices#get, in the finally block, if the region could not be located
then {{region}} can be null, and we need to check for it.
> [branch-1] TestEndToEndSplitTransaction.testMasterOpsWhileSplitting fails
> with NPE
> --
>
> Key: HBASE-19395
> URL: https://issues.apache.org/jira/browse/HBASE-19395
> Project: HBase
> Issue Type: Bug
>Reporter: Guanghao Zhang
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 1.4.0
>
>
> [INFO] Running
> org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
> [ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 50.388 s <<< FAILURE! - in
> org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
> [ERROR]
> testMasterOpsWhileSplitting(org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction)
> Time elapsed: 8.903 s <<< ERROR!
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction.test(TestEndToEndSplitTransaction.java:239)
> at
> org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction.testMasterOpsWhileSplitting(TestEndToEndSplitTransaction.java:148)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19326) Remove decommissioned servers from rsgroup
[
https://issues.apache.org/jira/browse/HBASE-19326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275177#comment-16275177
]
Hadoop QA commented on HBASE-19326:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 12m
31s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
49s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
18s{color} | {color:green} branch-1 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
29s{color} | {color:green} branch-1 passed with JDK v1.7.0_161 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
56s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
31s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
10s{color} | {color:red} hbase-server in branch-1 has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} branch-1 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} branch-1 passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
20s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
33s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
17s{color} | {color:red} hbase-server: The patch generated 2 new + 111
unchanged - 0 fixed = 113 total (was 111) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
12s{color} | {color:red} hbase-rsgroup: The patch generated 1 new + 22
unchanged - 2 fixed = 23 total (was 24) {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
8s{color} | {color:red} The patch generated 5 new + 122 unchanged - 1 fixed =
127 total (was 123) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m
3s{color} | {color:red} The patch generated 4 new + 16 unchanged - 0 fixed = 20
total (was 16) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 8 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
34s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
28m 44s{color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3
[jira] [Assigned] (HBASE-19395) [branch-1] TestEndToEndSplitTransaction.testMasterOpsWhileSplitting fails with NPE
[ https://issues.apache.org/jira/browse/HBASE-19395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell reassigned HBASE-19395: -- Assignee: Andrew Purtell I can reproduce it > [branch-1] TestEndToEndSplitTransaction.testMasterOpsWhileSplitting fails > with NPE > -- > > Key: HBASE-19395 > URL: https://issues.apache.org/jira/browse/HBASE-19395 > Project: HBase > Issue Type: Bug >Affects Versions: 1.5.0 >Reporter: Guanghao Zhang >Assignee: Andrew Purtell > > [INFO] Running > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction > [ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 50.388 s <<< FAILURE! - in > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction > [ERROR] > testMasterOpsWhileSplitting(org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction) > Time elapsed: 8.903 s <<< ERROR! > java.lang.NullPointerException > at > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction.test(TestEndToEndSplitTransaction.java:239) > at > org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction.testMasterOpsWhileSplitting(TestEndToEndSplitTransaction.java:148) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19399) Purge curator dependency from hbase-client
[ https://issues.apache.org/jira/browse/HBASE-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275166#comment-16275166 ] Duo Zhang commented on HBASE-19399: --- Do we also shade hbase-example? > Purge curator dependency from hbase-client > -- > > Key: HBASE-19399 > URL: https://issues.apache.org/jira/browse/HBASE-19399 > Project: HBase > Issue Type: Sub-task > Components: Client, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19399-v1.patch, HBASE-19399.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19406) Fix CompactionRequest equals and hashCode
[ https://issues.apache.org/jira/browse/HBASE-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19406: --- Attachment: HBASE-19406.patch > Fix CompactionRequest equals and hashCode > - > > Key: HBASE-19406 > URL: https://issues.apache.org/jira/browse/HBASE-19406 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 2.0.0-beta-1 > > Attachments: HBASE-19406-branch-1.patch, HBASE-19406.patch > > > This is fallout from an attempt to fix an error prone or findbugs warning. > [ERROR] > loadTest[0](org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk) > Time elapsed: 19.632 s <<< ERROR! > java.io.IOException: > java.io.IOException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2410) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > Caused by: java.lang.StackOverflowError > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > (Repeats until the stack blows up) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19285) Add per-table latency histograms
[ https://issues.apache.org/jira/browse/HBASE-19285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-19285: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Add per-table latency histograms > > > Key: HBASE-19285 > URL: https://issues.apache.org/jira/browse/HBASE-19285 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Clay B. >Assignee: Josh Elser >Priority: Critical > Fix For: 2.0.0, 1.4.0, 1.3.3 > > Attachments: HBASE-19285.001.branch-1.3.patch, > HBASE-19285.002.branch-1.3.patch, HBASE-19285.003.branch-1.3.patch, > HBaseTableLatencyMetrics.png > > > HBASE-17017 removed the per-region latency histograms (e.g. Get, Put, Scan at > p75, p85, etc) > HBASE-15518 added some per-table metrics, but not the latency histograms. > Given the previous conversations, it seems like it these per-table > aggregations weren't intentionally omitted, just never re-implemented after > the per-region removal. They're some really nice out-of-the-box metrics we > can provide to our users/admins as long as it's not detrimental. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19287) master hangs forever if RecoverMeta send assign meta region request to target server fail
[
https://issues.apache.org/jira/browse/HBASE-19287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275129#comment-16275129
]
Yi Liang commented on HBASE-19287:
--
[~stack] Spent some time digging into code. I found details of the assign
Procedure work flow is
{quote}
1. Master send assign request to target Regionserver, and this active
AssignProcedure will be remove from Procedure Scheduler(A queue that store all
the active procedure) and suspend this AssignProcedure.
2. Once target Server received request and open the region, it will send a
response to master
3. Once Master receive the response, it will wake this procedure and put the
AssignProcedure back to Procedure Scheduler. And worker threads in
ProcedureExecutor will poll this AssignProcedure and run the remain steps.
{quote}
The problem happens on step3, if the master does not receive response from
target server for any reason; That assign procedure will become a dead
procedure, no other mechanism will wake the procedure(i.e put it back into
procedure scheduler) any more. (Do not know why we need to remove this
procedure out of procedure scheduler in step1, maybe we can just mark it as
suspend and yield it?)
The thing here is that this suspend procedure will be only wake by the response
from target server, no other mechanism can wake it (ServerCrashProcedure may
wake it, but if the target server is not crashed, master just can not receive
the response for other reasons like network issue. this problem will still
happens; or if master is not up, SCP also does not work).
So this will be a general problem not only for meta, but for other normal
regions.
So we need to come up with a idea to wake those suspend procedures.
My suggestion is that we can have a separate thread to check all those suspend
procedures periodically, if they are timeout or their target server is crashed,
we can do reassign.
(1) The target server crashed will only suspend meta's assign since master is
not up yet, other regions can be wake by ServerCrashProcedure.
(2) Timeout mechanism for all suspend procedure. If one procedure has been
suspended for too long, we mark it as timeout and redo the remain steps.
We can do (1) first, but for (2), since we don't have timeout for procedure
yet. Not sure how to fix it properly.
> master hangs forever if RecoverMeta send assign meta region request to target
> server fail
> -
>
> Key: HBASE-19287
> URL: https://issues.apache.org/jira/browse/HBASE-19287
> Project: HBase
> Issue Type: Bug
>Reporter: Yi Liang
>Assignee: Yi Liang
>
> 2017-11-10 19:26:56,019 INFO [ProcExecWrkr-1]
> procedure.RecoverMetaProcedure: pid=138,
> state=RUNNABLE:RECOVER_META_ASSIGN_REGIONS; RecoverMetaProcedure
> failedMetaServer=null, splitWal=true; Retaining meta assignment to
> server=hadoop-slave1.hadoop,16020,1510341981454
> 2017-11-10 19:26:56,029 INFO [ProcExecWrkr-1] procedure2.ProcedureExecutor:
> Initialized subprocedures=[{pid=139, ppid=138,
> state=RUNNABLE:REGION_TRANSITION_QUEUE; AssignProcedure table=hbase:meta,
> region=1588230740, target=hadoop-slave1.hadoop,16020,1510341981454}]
> 2017-11-10 19:26:56,067 INFO [ProcExecWrkr-2]
> procedure.MasterProcedureScheduler: pid=139, ppid=138,
> state=RUNNABLE:REGION_TRANSITION_QUEUE; AssignProcedure table=hbase:meta,
> region=1588230740, target=hadoop-slave1.hadoop,16020,1510341981454 hbase:meta
> hbase:meta,,1.1588230740
> 2017-11-10 19:26:56,071 INFO [ProcExecWrkr-2] assignment.AssignProcedure:
> Start pid=139, ppid=138, state=RUNNABLE:REGION_TRANSITION_QUEUE;
> AssignProcedure table=hbase:meta, region=1588230740,
> target=hadoop-slave1.hadoop,16020,1510341981454; rit=OFFLINE,
> location=hadoop-slave1.hadoop,16020,1510341981454; forceNewPlan=false,
> retain=false
> 2017-11-10 19:26:56,224 INFO [ProcExecWrkr-4] zookeeper.MetaTableLocator:
> Setting hbase:meta (replicaId=0) location in ZooKeeper as
> hadoop-slave2.hadoop,16020,1510341988652
> 2017-11-10 19:26:56,230 INFO [ProcExecWrkr-4]
> assignment.RegionTransitionProcedure: Dispatch pid=139, ppid=138,
> state=RUNNABLE:REGION_TRANSITION_DISPATCH; AssignProcedure table=hbase:meta,
> region=1588230740, target=hadoop-slave1.hadoop,16020,1510341981454;
> rit=OPENING, location=hadoop-slave2.hadoop,16020,1510341988652
> 2017-11-10 19:26:56,382 INFO [ProcedureDispatcherTimeoutThread]
> procedure.RSProcedureDispatcher: Using procedure batch rpc execution for
> serverName=hadoop-slave2.hadoop,16020,1510341988652 version=2097152
> 2017-11-10 19:26:57,542 INFO [main-EventThread]
> zookeeper.RegionServerTracker: RegionServer ephemeral node deleted,
> processing expiration [hadoop-slave2.hadoop,16020,1510341988652]
> 2017-11-10 19:26:57,543 INFO [main-EventThread]
[jira] [Commented] (HBASE-19285) Add per-table latency histograms
[ https://issues.apache.org/jira/browse/HBASE-19285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275125#comment-16275125 ] Josh Elser commented on HBASE-19285: Thanks, Stack. Pushing to those imminently. > Add per-table latency histograms > > > Key: HBASE-19285 > URL: https://issues.apache.org/jira/browse/HBASE-19285 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Clay B. >Assignee: Josh Elser >Priority: Critical > Fix For: 2.0.0, 1.4.0, 1.3.3 > > Attachments: HBASE-19285.001.branch-1.3.patch, > HBASE-19285.002.branch-1.3.patch, HBASE-19285.003.branch-1.3.patch, > HBaseTableLatencyMetrics.png > > > HBASE-17017 removed the per-region latency histograms (e.g. Get, Put, Scan at > p75, p85, etc) > HBASE-15518 added some per-table metrics, but not the latency histograms. > Given the previous conversations, it seems like it these per-table > aggregations weren't intentionally omitted, just never re-implemented after > the per-region removal. They're some really nice out-of-the-box metrics we > can provide to our users/admins as long as it's not detrimental. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16239) Better logging for RPC related exceptions
[ https://issues.apache.org/jira/browse/HBASE-16239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-16239: --- Attachment: HBASE-16239.master.002.patch rebase > Better logging for RPC related exceptions > - > > Key: HBASE-16239 > URL: https://issues.apache.org/jira/browse/HBASE-16239 > Project: HBase > Issue Type: Bug >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 2.0.0, 1.3.2, 1.4.1 > > Attachments: HBASE-16239.master.001.patch, > HBASE-16239.master.002.patch, hbase-16239_v1.patch, hbase-16239_v2.patch, > hbase-16239_v2.patch, hbase-16239_v2.patch > > > On many occasions, we have to debug RPC related issues, but it is hard in AP > + RetryingRpcCaller since we mask the stack traces until all retries have > been exhausted (which takes 10 minutes by default). > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16239) Better logging for RPC related exceptions
[ https://issues.apache.org/jira/browse/HBASE-16239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-16239: --- Status: Patch Available (was: Open) > Better logging for RPC related exceptions > - > > Key: HBASE-16239 > URL: https://issues.apache.org/jira/browse/HBASE-16239 > Project: HBase > Issue Type: Bug >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 2.0.0, 1.3.2, 1.4.1 > > Attachments: HBASE-16239.master.001.patch, > HBASE-16239.master.002.patch, hbase-16239_v1.patch, hbase-16239_v2.patch, > hbase-16239_v2.patch, hbase-16239_v2.patch > > > On many occasions, we have to debug RPC related issues, but it is hard in AP > + RetryingRpcCaller since we mask the stack traces until all retries have > been exhausted (which takes 10 minutes by default). > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17852) Add Fault tolerance to HBASE-14417 (Support bulk loaded files in incremental backup)
[ https://issues.apache.org/jira/browse/HBASE-17852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275107#comment-16275107 ] Appy commented on HBASE-17852: -- bq. To try to move the conversation forward, I tend to agree with Vlad that I don't seen an inherent problem with the rollback-via-snapshot implementation The inherent problem with rollback-via-snapshot approach is - one operation is taking "exclusive lock" on the backup meta table, and that too in a very weird way. It's weird because: 1) It behaves like exclusive lock in certain cases. (We only restore on failure, i.e. exclusion kicks in only on failures. That leads to waterfall of issues mentioned below.) 2) Some other operations on that table are following "exclusion" semantics (via locking a row), while others not. As a result of which we see so many problems: 1) Different table for incremental backup data: The problem is not that there's a different table, that's fine, but the reason which led to it. 2) You can't run any other command in parallel! No restores (data loss, services are down, everything is on fire, oh but there's a cron job taking backup, so i can't do zilch!?), no merges, no deletes (prod cluster, running out of space, i have to wait for backup before i can free up space?). That's just absurd. 3) Other successful commands are rolled back silently. If an operator add/remove/delete sets, they are gone if a totally different thing fails! 4) During restore, backup table goes offline, cron job attempts backup and fails. Others: - And then the issues around cross RS RPC from observer during bulk load. Was the alternative suggested yesterday considered in the design? Was there any alternative that was considered? - (Ref: Bulk loads) Backups are very important. But more important is user being able to load their data and use it. Preventing user to work with their data by putting backup in load path and failing everything if backup doesn't work is plain wrong. Find a different way to backup bulk load data without affecting core read/write paths. So, I'd say, there are many things implicitly broken with current design. Strong -1 on shipping it unless they are fixed. > Add Fault tolerance to HBASE-14417 (Support bulk loaded files in incremental > backup) > > > Key: HBASE-17852 > URL: https://issues.apache.org/jira/browse/HBASE-17852 > Project: HBase > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Fix For: 2.0.0 > > Attachments: HBASE-17852-v1.patch, HBASE-17852-v2.patch, > HBASE-17852-v3.patch, HBASE-17852-v4.patch, HBASE-17852-v5.patch, > HBASE-17852-v6.patch, HBASE-17852-v7.patch, HBASE-17852-v8.patch, > HBASE-17852-v9.patch > > > Design approach rollback-via-snapshot implemented in this ticket: > # Before backup create/delete/merge starts we take a snapshot of the backup > meta-table (backup system table). This procedure is lightweight because meta > table is small, usually should fit a single region. > # When operation fails on a server side, we handle this failure by cleaning > up partial data in backup destination, followed by restoring backup > meta-table from a snapshot. > # When operation fails on a client side (abnormal termination, for example), > next time user will try create/merge/delete he(she) will see error message, > that system is in inconsistent state and repair is required, he(she) will > need to run backup repair tool. > # To avoid multiple writers to the backup system table (backup client and > BackupObserver's) we introduce small table ONLY to keep listing of bulk > loaded files. All backup observers will work only with this new tables. The > reason: in case of a failure during backup create/delete/merge/restore, when > system performs automatic rollback, some data written by backup observers > during failed operation may be lost. This is what we try to avoid. > # Second table keeps only bulk load related references. We do not care about > consistency of this table, because bulk load is idempotent operation and can > be repeated after failure. Partially written data in second table does not > affect on BackupHFileCleaner plugin, because this data (list of bulk loaded > files) correspond to a files which have not been loaded yet successfully and, > hence - are not visible to the system -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17123) Add postBulkLoadHFile variant that notifies the final paths for the hfiles
[
https://issues.apache.org/jira/browse/HBASE-17123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275097#comment-16275097
]
Appy commented on HBASE-17123:
--
Was going over something else when found this:
https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L2254
Isn't that overwriting return value of CP? Should the second if(map != null) be
inside previous else condition?
> Add postBulkLoadHFile variant that notifies the final paths for the hfiles
> --
>
> Key: HBASE-17123
> URL: https://issues.apache.org/jira/browse/HBASE-17123
> Project: HBase
> Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Ted Yu
> Labels: bulkloader
> Fix For: 2.0.0
>
> Attachments: 17123.addendum, 17123.v1.txt, 17123.v3.txt,
> 17123.v4.txt, 17123.v5.txt
>
>
> Currently the postBulkLoadHFile() hook passes the same familyPaths parameter
> which it receives as method parameter.
> See code in SecureBulkLoadManager :
> {code}
>loaded = region.getCoprocessorHost().postBulkLoadHFile(familyPaths,
> loaded);
> {code}
> Meaning, the paths are not final, moved paths of the loaded hfiles.
> This issue is to add a variant which notifies the final paths of the loaded
> hfiles.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19396) Fix flaky test TestHTableMultiplexerFlushCache
[ https://issues.apache.org/jira/browse/HBASE-19396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275083#comment-16275083 ] Chia-Ping Tsai commented on HBASE-19396: Looped the test with patch 20 times. All pass. I will commit it after seeing the QA. > Fix flaky test TestHTableMultiplexerFlushCache > -- > > Key: HBASE-19396 > URL: https://issues.apache.org/jira/browse/HBASE-19396 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 1.5.0 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Minor > Fix For: 2.0.0, 1.3.2, 1.4.1, 1.5.0, 1.2.7 > > Attachments: HBASE-19396.branch-1.001.patch, > HBASE-19396.branch-1.001.patch > > > [INFO] Running org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache > [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 36.67 > s <<< FAILURE! - in > org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache > [ERROR] > testOnRegionMove(org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache) > Time elapsed: 4.644 s <<< FAILURE! > java.lang.AssertionError: Did not find a new RegionServer to use > at > org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache.testOnRegionMove(TestHTableMultiplexerFlushCache.java:160) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19406) Fix CompactionRequest equals and hashCode
[ https://issues.apache.org/jira/browse/HBASE-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19406: --- Fix Version/s: 2.0.0-beta-1 Status: Patch Available (was: Open) > Fix CompactionRequest equals and hashCode > - > > Key: HBASE-19406 > URL: https://issues.apache.org/jira/browse/HBASE-19406 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 2.0.0-beta-1 > > Attachments: HBASE-19406-branch-1.patch > > > This is fallout from an attempt to fix an error prone or findbugs warning. > [ERROR] > loadTest[0](org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk) > Time elapsed: 19.632 s <<< ERROR! > java.io.IOException: > java.io.IOException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2410) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > Caused by: java.lang.StackOverflowError > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > (Repeats until the stack blows up) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19406) Fix CompactionRequest equals and hashCode
[ https://issues.apache.org/jira/browse/HBASE-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19406: --- Attachment: HBASE-19406-branch-1.patch > Fix CompactionRequest equals and hashCode > - > > Key: HBASE-19406 > URL: https://issues.apache.org/jira/browse/HBASE-19406 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0 > > Attachments: HBASE-19406-branch-1.patch > > > This is fallout from an attempt to fix an error prone or findbugs warning. > [ERROR] > loadTest[0](org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk) > Time elapsed: 19.632 s <<< ERROR! > java.io.IOException: > java.io.IOException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2410) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > Caused by: java.lang.StackOverflowError > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > (Repeats until the stack blows up) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19406) Fix CompactionRequest equals and hashCode
[ https://issues.apache.org/jira/browse/HBASE-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19406: --- Summary: Fix CompactionRequest equals and hashCode (was: TestLoadAndSwitchEncodeOnDisk occasionally fails) > Fix CompactionRequest equals and hashCode > - > > Key: HBASE-19406 > URL: https://issues.apache.org/jira/browse/HBASE-19406 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0 > > Attachments: HBASE-19406-branch-1.patch > > > This is fallout from an attempt to fix an error prone or findbugs warning. > [ERROR] > loadTest[0](org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk) > Time elapsed: 19.632 s <<< ERROR! > java.io.IOException: > java.io.IOException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2410) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > Caused by: java.lang.StackOverflowError > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > at java.util.Objects.equals(Objects.java:59) > at > org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.equals(CompactionRequest.java:150) > (Repeats until the stack blows up) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19408) Remove WALActionsListener.Base
[
https://issues.apache.org/jira/browse/HBASE-19408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275073#comment-16275073
]
Mike Drob commented on HBASE-19408:
---
+1, add a RN too
> Remove WALActionsListener.Base
> --
>
> Key: HBASE-19408
> URL: https://issues.apache.org/jira/browse/HBASE-19408
> Project: HBase
> Issue Type: Task
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Trivial
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19408.v0.patch
>
>
> Do the similar work as XXXObserver - add the default keyword to all methods
> in {{WALActionsListener}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19408) Remove WALActionsListener.Base
[
https://issues.apache.org/jira/browse/HBASE-19408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275069#comment-16275069
]
stack commented on HBASE-19408:
---
+1
> Remove WALActionsListener.Base
> --
>
> Key: HBASE-19408
> URL: https://issues.apache.org/jira/browse/HBASE-19408
> Project: HBase
> Issue Type: Task
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Trivial
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19408.v0.patch
>
>
> Do the similar work as XXXObserver - add the default keyword to all methods
> in {{WALActionsListener}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19396) Fix flaky test TestHTableMultiplexerFlushCache
[ https://issues.apache.org/jira/browse/HBASE-19396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275065#comment-16275065 ] stack commented on HBASE-19396: --- LGTM > Fix flaky test TestHTableMultiplexerFlushCache > -- > > Key: HBASE-19396 > URL: https://issues.apache.org/jira/browse/HBASE-19396 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 1.5.0 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Minor > Fix For: 2.0.0, 1.3.2, 1.4.1, 1.5.0, 1.2.7 > > Attachments: HBASE-19396.branch-1.001.patch, > HBASE-19396.branch-1.001.patch > > > [INFO] Running org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache > [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 36.67 > s <<< FAILURE! - in > org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache > [ERROR] > testOnRegionMove(org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache) > Time elapsed: 4.644 s <<< FAILURE! > java.lang.AssertionError: Did not find a new RegionServer to use > at > org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache.testOnRegionMove(TestHTableMultiplexerFlushCache.java:160) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19396) Fix flaky test TestHTableMultiplexerFlushCache
[ https://issues.apache.org/jira/browse/HBASE-19396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19396: --- Attachment: HBASE-19396.branch-1.001.patch retry > Fix flaky test TestHTableMultiplexerFlushCache > -- > > Key: HBASE-19396 > URL: https://issues.apache.org/jira/browse/HBASE-19396 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 1.5.0 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Minor > Fix For: 2.0.0, 1.3.2, 1.4.1, 1.5.0, 1.2.7 > > Attachments: HBASE-19396.branch-1.001.patch, > HBASE-19396.branch-1.001.patch > > > [INFO] Running org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache > [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 36.67 > s <<< FAILURE! - in > org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache > [ERROR] > testOnRegionMove(org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache) > Time elapsed: 4.644 s <<< FAILURE! > java.lang.AssertionError: Did not find a new RegionServer to use > at > org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache.testOnRegionMove(TestHTableMultiplexerFlushCache.java:160) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19357) Bucket cache no longer L2 for LRU cache
[
https://issues.apache.org/jira/browse/HBASE-19357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275045#comment-16275045
]
Chia-Ping Tsai commented on HBASE-19357:
The {{ColumnFamilyDescriptor}} is new class in 2.0 so the deprecation cycle may
be unnecessary. ditto for {{ColumnFamilyDescriptorBuilder}}.
Our docs has reference to {{hbase.bucketcache.combinedcache.enabled}}. Could we
add some comment to remind user about this change?
> Bucket cache no longer L2 for LRU cache
> ---
>
> Key: HBASE-19357
> URL: https://issues.apache.org/jira/browse/HBASE-19357
> Project: HBase
> Issue Type: Sub-task
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19357.patch, HBASE-19357.patch,
> HBASE-19357_V2.patch
>
>
> When Bucket cache is used, by default we dont configure it as an L2 cache
> alone. The default setting is combined mode ON where the data blocks to
> Bucket cache and index/bloom blocks go to LRU cache. But there is a way to
> turn this off and make LRU as L1 and Bucket cache as a victim handler for L1.
> It will be just L2.
> After the off heap read path optimization Bucket cache is no longer slower
> compared to L1. We have test results on data sizes from 12 GB. The Alibaba
> use case was also with 12 GB and they have observed a ~30% QPS improve over
> the LRU cache.
> This issue is to remove the option for combined mode = false. So when Bucket
> cache is in use, data blocks will go to it only and LRU will get only index
> /meta/bloom blocks. Bucket cache will no longer be configured as a victim
> handler for LRU.
> Note : WHen external cache is in use, there only the L1 L2 thing comes. LRU
> will be L1 and external cache act as its L2. That make full sense.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19408) Remove WALActionsListener.Base
[
https://issues.apache.org/jira/browse/HBASE-19408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-19408:
---
Status: Patch Available (was: Open)
> Remove WALActionsListener.Base
> --
>
> Key: HBASE-19408
> URL: https://issues.apache.org/jira/browse/HBASE-19408
> Project: HBase
> Issue Type: Task
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Trivial
> Attachments: HBASE-19408.v0.patch
>
>
> Do the similar work as XXXObserver - add the default keyword to all methods
> in {{WALActionsListener}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19408) Remove WALActionsListener.Base
[
https://issues.apache.org/jira/browse/HBASE-19408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-19408:
---
Fix Version/s: 2.0.0-beta-1
> Remove WALActionsListener.Base
> --
>
> Key: HBASE-19408
> URL: https://issues.apache.org/jira/browse/HBASE-19408
> Project: HBase
> Issue Type: Task
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Trivial
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19408.v0.patch
>
>
> Do the similar work as XXXObserver - add the default keyword to all methods
> in {{WALActionsListener}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19408) Remove WALActionsListener.Base
[
https://issues.apache.org/jira/browse/HBASE-19408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-19408:
---
Attachment: HBASE-19408.v0.patch
> Remove WALActionsListener.Base
> --
>
> Key: HBASE-19408
> URL: https://issues.apache.org/jira/browse/HBASE-19408
> Project: HBase
> Issue Type: Task
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Trivial
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19408.v0.patch
>
>
> Do the similar work as XXXObserver - add the default keyword to all methods
> in {{WALActionsListener}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19326) Remove decommissioned servers from rsgroup
[
https://issues.apache.org/jira/browse/HBASE-19326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-19326:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Pushed the branch-1 patch to to branch-1.4 and branch-1
> Remove decommissioned servers from rsgroup
> --
>
> Key: HBASE-19326
> URL: https://issues.apache.org/jira/browse/HBASE-19326
> Project: HBase
> Issue Type: New Feature
> Components: rsgroup
>Affects Versions: 3.0.0, 2.0.0-beta-2
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-19326-branch-1.patch,
> HBASE-19326.branch-2.001.patch, HBASE-19326.master.001.patch,
> HBASE-19326.master.002.patch, HBASE-19326.master.003.patch,
> HBASE-19326.master.004.patch, HBASE-19326.master.005.patch
>
>
> In HBASE-18131, we add an hbase shell command {{clear_deadservers}} to clear
> deadserver list in ServerManager.
> But rsgroup still contains these dead servers, so we should also remove dead
> servers from the group information.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19339) Eager policy results in the negative size of memstore
[ https://issues.apache.org/jira/browse/HBASE-19339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275022#comment-16275022 ] Ted Yu commented on HBASE-19339: +1 > Eager policy results in the negative size of memstore > - > > Key: HBASE-19339 > URL: https://issues.apache.org/jira/browse/HBASE-19339 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19339.v0.patch > > > It is a follow-up of HBASE-19266. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19352) Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags
[
https://issues.apache.org/jira/browse/HBASE-19352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275020#comment-16275020
]
Hadoop QA commented on HBASE-19352:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
13s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
13s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m
49s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
18s{color} | {color:red} hbase-http in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 18s{color}
| {color:red} hbase-http in the patch failed. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
13s{color} | {color:red} hbase-http: The patch generated 8 new + 47 unchanged -
0 fixed = 55 total (was 47) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 2m
41s{color} | {color:red} patch has 21 errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m
5s{color} | {color:red} The patch causes 21 errors with Hadoop v2.6.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m
30s{color} | {color:red} The patch causes 21 errors with Hadoop v2.6.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m
55s{color} | {color:red} The patch causes 21 errors with Hadoop v2.6.3. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 8m
21s{color} | {color:red} The patch causes 21 errors with Hadoop v2.6.4. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 9m
50s{color} | {color:red} The patch causes 21 errors with Hadoop v2.6.5. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 11m
17s{color} | {color:red} The patch causes 21 errors with Hadoop v2.7.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 12m
42s{color} | {color:red} The patch causes 21 errors with Hadoop v2.7.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 14m
8s{color} | {color:red} The patch causes 21 errors with Hadoop v2.7.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 15m
32s{color} | {color:red} The patch causes 21 errors with Hadoop v2.7.4. {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 16s{color}
| {color:red} hbase-http in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 34m 38s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce
[jira] [Commented] (HBASE-19352) Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags
[ https://issues.apache.org/jira/browse/HBASE-19352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275006#comment-16275006 ] Esteban Gutierrez commented on HBASE-19352: --- [~mdrob], yeah The same should go into branch-1 since the issue is about consistency of the security flags for the auth cookies. > Port HADOOP-10379: Protect authentication cookies with the HttpOnly and > Secure flags > > > Key: HBASE-19352 > URL: https://issues.apache.org/jira/browse/HBASE-19352 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Esteban Gutierrez >Assignee: Esteban Gutierrez > Attachments: HBASE-19352.master.v0.patch > > > This came via a security scanner, since we have a fork of HttpServer2 in > HBase we should include it too. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19339) Eager policy results in the negative size of memstore
[ https://issues.apache.org/jira/browse/HBASE-19339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274993#comment-16274993 ] Chia-Ping Tsai commented on HBASE-19339: Ping for reviews. I hope the all acid tests can be run as much as possible before we release 2.0. > Eager policy results in the negative size of memstore > - > > Key: HBASE-19339 > URL: https://issues.apache.org/jira/browse/HBASE-19339 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19339.v0.patch > > > It is a follow-up of HBASE-19266. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19352) Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags
[ https://issues.apache.org/jira/browse/HBASE-19352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-19352: -- Affects Version/s: 2.0.0 Is there similar work to do with Jetty v6 in branch-1? > Port HADOOP-10379: Protect authentication cookies with the HttpOnly and > Secure flags > > > Key: HBASE-19352 > URL: https://issues.apache.org/jira/browse/HBASE-19352 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Esteban Gutierrez >Assignee: Esteban Gutierrez > Attachments: HBASE-19352.master.v0.patch > > > This came via a security scanner, since we have a fork of HttpServer2 in > HBase we should include it too. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19408) Remove WALActionsListener.Base
Chia-Ping Tsai created HBASE-19408:
--
Summary: Remove WALActionsListener.Base
Key: HBASE-19408
URL: https://issues.apache.org/jira/browse/HBASE-19408
Project: HBase
Issue Type: Task
Reporter: Chia-Ping Tsai
Assignee: Chia-Ping Tsai
Priority: Trivial
Do the similar work as XXXObserver - add the default keyword to all methods in
{{WALActionsListener}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19352) Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags
[
https://issues.apache.org/jira/browse/HBASE-19352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274975#comment-16274975
]
Mike Drob commented on HBASE-19352:
---
Manually retriggered QA for you.
{code}
+ SessionManager sm = handler.getSessionManager();
+ if (sm instanceof AbstractSessionManager) {
+AbstractSessionManager asm = (AbstractSessionManager) sm;
+asm.setHttpOnly(true);
+asm.getSessionCookieConfig().setSecure(true);
+ }
{code}
Make a helper method that takes a handler and modifies the session manager on
it?
What does it mean if it's not an instance of AbstractSessionManager?
In the test:
{code}
+import javax.servlet.*;
{code}
nit: wildcard imports
{code}
+ private static final String BASEDIR = System.getProperty("test.build.dir",
+ "target/test-dir") + "/" +
org.apache.hadoop.hbase.http.TestHttpCookieFlag.class.getSimpleName();
+File base = new File(BASEDIR);
+FileUtil.fullyDelete(base);
+base.mkdirs();
{code}
Could use junit TemporaryFolder rule.
{code}
+sslConfDir = KeyStoreTestUtil.getClasspathDir(TestSSLHttpServer.class);
{code}
should this be TestHttpCookieFlag.class?
{code}
+//.excludeCiphers(
+//sslConf.get("ssl.server.exclude.cipher.list"))
{code}
Is this a hack for os-specific testing?
{code}
+Assert.assertTrue(header != null);
+Assert.assertTrue(!cookies.isEmpty());
+Assert.assertTrue(header.contains("; HttpOnly"));
+Assert.assertTrue("token".equals(cookies.get(0).getValue()));
{code}
nit: please use assertNull, assertFalse, and assertEquals as appropriate
(including error messages for the ones that aren't assertEquals)
> Port HADOOP-10379: Protect authentication cookies with the HttpOnly and
> Secure flags
>
>
> Key: HBASE-19352
> URL: https://issues.apache.org/jira/browse/HBASE-19352
> Project: HBase
> Issue Type: Bug
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Attachments: HBASE-19352.master.v0.patch
>
>
> This came via a security scanner, since we have a fork of HttpServer2 in
> HBase we should include it too.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19407) [branch-2] Remove backup/restore
[ https://issues.apache.org/jira/browse/HBASE-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19407: -- Status: Patch Available (was: Open) > [branch-2] Remove backup/restore > > > Key: HBASE-19407 > URL: https://issues.apache.org/jira/browse/HBASE-19407 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19407.branch-2.001.patch > > > As per thread up on dev list [1], we won't be including the backup/restore in > hbase2. This issue purges it. > 1. > http://apache-hbase.679495.n3.nabble.com/DISCUSS-Plan-to-avoid-backup-restore-removal-from-2-0-td4091807.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19407) [branch-2] Remove backup/restore
[ https://issues.apache.org/jira/browse/HBASE-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274959#comment-16274959 ] stack commented on HBASE-19407: --- .001 remove hbase-backup, it tests, backup/restore verbs from bin/hbase > [branch-2] Remove backup/restore > > > Key: HBASE-19407 > URL: https://issues.apache.org/jira/browse/HBASE-19407 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19407.branch-2.001.patch > > > As per thread up on dev list [1], we won't be including the backup/restore in > hbase2. This issue purges it. > 1. > http://apache-hbase.679495.n3.nabble.com/DISCUSS-Plan-to-avoid-backup-restore-removal-from-2-0-td4091807.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19407) [branch-2] Remove backup/restore
[ https://issues.apache.org/jira/browse/HBASE-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19407: -- Attachment: HBASE-19407.branch-2.001.patch > [branch-2] Remove backup/restore > > > Key: HBASE-19407 > URL: https://issues.apache.org/jira/browse/HBASE-19407 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19407.branch-2.001.patch > > > As per thread up on dev list [1], we won't be including the backup/restore in > hbase2. This issue purges it. > 1. > http://apache-hbase.679495.n3.nabble.com/DISCUSS-Plan-to-avoid-backup-restore-removal-from-2-0-td4091807.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (HBASE-18943) Cannot start mini dfs cluster using hadoop-3 in test due to NoSuchMethodError in jetty
[
https://issues.apache.org/jira/browse/HBASE-18943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved HBASE-18943.
---
Resolution: Duplicate
Fix Version/s: (was: 2.0.0-beta-1)
[~tedyu] - didn't realize that you had the same patch on here already when I
was working on HBASE-19390, I'll close this as a dupe.
> Cannot start mini dfs cluster using hadoop-3 in test due to NoSuchMethodError
> in jetty
> ---
>
> Key: HBASE-18943
> URL: https://issues.apache.org/jira/browse/HBASE-18943
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Priority: Blocker
> Attachments: 18943.v1.txt
>
>
> When starting mini dfs cluster against hadoop-3:
> {code}
> dfsCluster = startMiniDFSCluster(numDataNodes, dataNodeHosts);
> {code}
> The above call would end up with:
> {code}
> java.lang.NoSuchMethodError:
> org.eclipse.jetty.server.session.SessionHandler.getSessionManager()Lorg/eclipse/jetty/server/SessionManager;
> at org.apache.hadoop.hbase.client.TestHCM.setUpBeforeClass(TestHCM.java:251)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-19407) [branch-2] Remove backup/restore
stack created HBASE-19407: - Summary: [branch-2] Remove backup/restore Key: HBASE-19407 URL: https://issues.apache.org/jira/browse/HBASE-19407 Project: HBase Issue Type: Task Reporter: stack Assignee: stack Priority: Blocker Fix For: 2.0.0-beta-1 As per thread up on dev list [1], we won't be including the backup/restore in hbase2. This issue purges it. 1. http://apache-hbase.679495.n3.nabble.com/DISCUSS-Plan-to-avoid-backup-restore-removal-from-2-0-td4091807.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19390) Revert to older version of Jetty 9.3
[ https://issues.apache.org/jira/browse/HBASE-19390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-19390: -- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the reviews, [~elserj], [~tedyu], and [~balazs.meszaros]! Pushed to branch-2 and master. > Revert to older version of Jetty 9.3 > - > > Key: HBASE-19390 > URL: https://issues.apache.org/jira/browse/HBASE-19390 > Project: HBase > Issue Type: Bug >Reporter: Esteban Gutierrez >Assignee: Mike Drob > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19390.patch, HBASE-19390.v2.patch > > > As discussed in HBASE-19256 we will have to temporarily revert to Jetty 9.3 > due existing issues with 9.4 and Hadoop3. Once HBASE-19256 is resolved we can > revert to 9.4. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19326) Remove decommissioned servers from rsgroup
[
https://issues.apache.org/jira/browse/HBASE-19326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274926#comment-16274926
]
Andrew Purtell commented on HBASE-19326:
branch-1 test results
{noformat}
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroups
[INFO] Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 199.077
s - in org.apache.hadoop.hbase.rsgroup.TestRSGroups
[INFO] Running org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.535 s
- in org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups
{noformat}
> Remove decommissioned servers from rsgroup
> --
>
> Key: HBASE-19326
> URL: https://issues.apache.org/jira/browse/HBASE-19326
> Project: HBase
> Issue Type: New Feature
> Components: rsgroup
>Affects Versions: 3.0.0, 2.0.0-beta-2
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-19326-branch-1.patch,
> HBASE-19326.branch-2.001.patch, HBASE-19326.master.001.patch,
> HBASE-19326.master.002.patch, HBASE-19326.master.003.patch,
> HBASE-19326.master.004.patch, HBASE-19326.master.005.patch
>
>
> In HBASE-18131, we add an hbase shell command {{clear_deadservers}} to clear
> deadserver list in ServerManager.
> But rsgroup still contains these dead servers, so we should also remove dead
> servers from the group information.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19326) Remove decommissioned servers from rsgroup
[
https://issues.apache.org/jira/browse/HBASE-19326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-19326:
---
Attachment: HBASE-19326-branch-1.patch
Here's the branch-1 patch I'm about to commit.
> Remove decommissioned servers from rsgroup
> --
>
> Key: HBASE-19326
> URL: https://issues.apache.org/jira/browse/HBASE-19326
> Project: HBase
> Issue Type: New Feature
> Components: rsgroup
>Affects Versions: 3.0.0, 2.0.0-beta-2
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-19326-branch-1.patch,
> HBASE-19326.branch-2.001.patch, HBASE-19326.master.001.patch,
> HBASE-19326.master.002.patch, HBASE-19326.master.003.patch,
> HBASE-19326.master.004.patch, HBASE-19326.master.005.patch
>
>
> In HBASE-18131, we add an hbase shell command {{clear_deadservers}} to clear
> deadserver list in ServerManager.
> But rsgroup still contains these dead servers, so we should also remove dead
> servers from the group information.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19326) Remove decommissioned servers from rsgroup
[
https://issues.apache.org/jira/browse/HBASE-19326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274911#comment-16274911
]
Andrew Purtell commented on HBASE-19326:
Already committed to branch-2. Probably my commit is slightly different.
And I'm working on branch-1 now.
Sorry, if this is to get in I have to do this now. Or this can wait until 1.5.
> Remove decommissioned servers from rsgroup
> --
>
> Key: HBASE-19326
> URL: https://issues.apache.org/jira/browse/HBASE-19326
> Project: HBase
> Issue Type: New Feature
> Components: rsgroup
>Affects Versions: 3.0.0, 2.0.0-beta-2
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-19326.branch-2.001.patch,
> HBASE-19326.master.001.patch, HBASE-19326.master.002.patch,
> HBASE-19326.master.003.patch, HBASE-19326.master.004.patch,
> HBASE-19326.master.005.patch
>
>
> In HBASE-18131, we add an hbase shell command {{clear_deadservers}} to clear
> deadserver list in ServerManager.
> But rsgroup still contains these dead servers, so we should also remove dead
> servers from the group information.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19390) Revert to older version of Jetty 9.3
[
https://issues.apache.org/jira/browse/HBASE-19390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274902#comment-16274902
]
Hadoop QA commented on HBASE-19390:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 14m
0s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
54s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
1s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
54m 18s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
48s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}172m
44s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}256m 55s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19390 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12900082/HBASE-19390.v2.patch |
| Optional Tests | asflicense javac javadoc unit shadedjars hadoopcheck
xml compile |
| uname | Linux d5a5a2b8e63d 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 2e8bd0036d |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10180/testReport/ |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10180/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Revert to older version of Jetty 9.3
> -
>
> Key: HBASE-19390
> URL: https://issues.apache.org/jira/browse/HBASE-19390
> Project: HBase
> Issue Type: Bug
>Reporter: Esteban Gutierrez
>Assignee: Mike Drob
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19390.patch, HBASE-19390.v2.patch
>
>
> As discussed in HBASE-19256 we will have to temporarily revert to Jetty 9.3
> due existing issues with 9.4 and
