[jira] [Updated] (HBASE-19431) The tag array written by IndividualBytesFieldCell#write is out of bounds
[
https://issues.apache.org/jira/browse/HBASE-19431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-19431:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Push to branch-2 and master. Thanks for reviews. [~stack] [~ram_krish]
> The tag array written by IndividualBytesFieldCell#write is out of bounds
>
>
> Key: HBASE-19431
> URL: https://issues.apache.org/jira/browse/HBASE-19431
> Project: HBase
> Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19431.v0.patch
>
>
> {code:title=IndividualBytesFieldCell.java}
> @Override
> public int write(OutputStream out, boolean withTags) throws IOException {
> // Key length and then value length
> ByteBufferUtils.putInt(out, KeyValueUtil.keyLength(this));
> ByteBufferUtils.putInt(out, getValueLength());
> // Key
> PrivateCellUtil.writeFlatKey(this, out);
> // Value
> out.write(getValueArray());
> // Tags length and tags byte array
> if (withTags && getTagsLength() > 0) {
> // Tags length
> out.write((byte)(0xff & (getTagsLength() >> 8)));
> out.write((byte)(0xff & getTagsLength()));
> // Tags byte array
> out.write(tags); // here
> }
> return getSerializedSize(withTags);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19431) The tag array written by IndividualBytesFieldCell#write is out of bounds
[
https://issues.apache.org/jira/browse/HBASE-19431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278149#comment-16278149
]
Hadoop QA commented on HBASE-19431:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
8s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
13s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
50s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
51m 26s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
9s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 69m 55s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19431 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12900618/HBASE-19431.v0.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux f5e6a7fb67f2 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 6d69fd9c78 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10226/testReport/ |
| modules | C: hbase-common U: hbase-common |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10226/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> The tag array written by IndividualBytesFieldCell#write is out of bounds
>
>
> Key:
[jira] [Commented] (HBASE-19295) The Configuration returned by CPEnv should be read-only.
[
https://issues.apache.org/jira/browse/HBASE-19295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278147#comment-16278147
]
Chia-Ping Tsai commented on HBASE-19295:
{code}
+ @Override
+ public void readFields(DataInput in) throws IOException {
+conf.readFields(in);
+ }
{code}
Seems this method can modify the configuration. make it read-only also?
> The Configuration returned by CPEnv should be read-only.
>
>
> Key: HBASE-19295
> URL: https://issues.apache.org/jira/browse/HBASE-19295
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: stack
>Assignee: stack
> Labels: incompatible
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19295.master.001.patch,
> HBASE-19295.master.002.patch
>
>
> The Configuration a CP gets when it does a getConfiguration on the
> environment is that of the RegionServer. The CP should not be able to modify
> this config. We should throw exception if they try to write us.
> Ditto w/ the Connection they can get from the env. They should not be able to
> close it at min.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19295) The Configuration returned by CPEnv should be read-only.
[ https://issues.apache.org/jira/browse/HBASE-19295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278136#comment-16278136 ] Chia-Ping Tsai commented on HBASE-19295: nit: Configutation -> Configuration > The Configuration returned by CPEnv should be read-only. > > > Key: HBASE-19295 > URL: https://issues.apache.org/jira/browse/HBASE-19295 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: stack >Assignee: stack > Labels: incompatible > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19295.master.001.patch, > HBASE-19295.master.002.patch > > > The Configuration a CP gets when it does a getConfiguration on the > environment is that of the RegionServer. The CP should not be able to modify > this config. We should throw exception if they try to write us. > Ditto w/ the Connection they can get from the env. They should not be able to > close it at min. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19152) Update refguide 'how to build an RC' and the make_rc.sh script
[ https://issues.apache.org/jira/browse/HBASE-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278131#comment-16278131 ] Hudson commented on HBASE-19152: FAILURE: Integrated in Jenkins build HBase-1.4 #1051 (See [https://builds.apache.org/job/HBase-1.4/1051/]) HBASE-19420 Backport HBASE-19152 Update refguide 'how to build an RC' (apurtell: rev 1dba475da6dbba5c04ca34ba906732368bfa7090) * (delete) hbase-assembly/src/main/assembly/src.xml * (edit) src/main/asciidoc/_chapters/developer.adoc * (edit) dev-support/make_rc.sh > Update refguide 'how to build an RC' and the make_rc.sh script > -- > > Key: HBASE-19152 > URL: https://issues.apache.org/jira/browse/HBASE-19152 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: stack >Assignee: stack >Priority: Trivial > Fix For: 2.0.0-beta-1 > > Attachments: > 0001-HBASE-19152-Update-refguide-how-to-build-an-RC-and-t.patch, > 0001-HBASE-19152-Update-refguide-how-to-build-an-RC-and-t.patch, > HBASE-19152.master.001.patch, HBASE-19152.master.002.patch, > HBASE-19152.master.003.patch, HBASE-19152.master.004.patch, > HBASE-19152.master.005.patch, HBASE-19152.master.006.patch, > HBASE-19152.master.007.patch, HBASE-19152.master.008.patch > > > Update the section on how to build an RC. In particular, note that tags > should be signed and talk up the new way of building the src tgz (after a > Sean suggestion) including removal of old means src.xml from hbase-assembly. > Update the make_rc.sh script so it works for branch-2 builds. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19429) Release build fails in checkstyle phase of site target (branch-1)
[
https://issues.apache.org/jira/browse/HBASE-19429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278132#comment-16278132
]
Hudson commented on HBASE-19429:
FAILURE: Integrated in Jenkins build HBase-1.4 #1051 (See
[https://builds.apache.org/job/HBase-1.4/1051/])
HBASE-19429 Release build fails in checkstyle phase of site target (apurtell:
rev 6fcdc33df5ac40682599f642121842217e742f7c)
* (edit) pom.xml
> Release build fails in checkstyle phase of site target (branch-1)
> -
>
> Key: HBASE-19429
> URL: https://issues.apache.org/jira/browse/HBASE-19429
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0
>
> Attachments: HBASE-19429-branch-1.patch
>
>
> Running these commands:
> {noformat}
> export MAVEN_OPTS="-Xmx4g -XX:MaxPermSize=256m"
> mvn clean org.codehaus.mojo:versions-maven-plugin:2.5:set -DnewVersion=1.4.0
> git clean -xdf
> mvn clean install -DskipTests -Prelease
> mvn install -DskipTests site assembly:single -Prelease
> {noformat}
> fails on that last Maven invocation in the checkstyle phase of the site
> target with
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project
> hbase-annotations: Error generating maven-checkstyle-plugin:2.17:checkstyle:
> Failed during checkstyle execution: Unable to process suppressions file
> location: hbase/checkstyle-suppressions.xml: Cannot create file-based
> resource:invalid block type
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19420) Backport HBASE-19152 (Update refguide 'how to build an RC' and the make_rc.sh script) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-19420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278130#comment-16278130 ] Hudson commented on HBASE-19420: FAILURE: Integrated in Jenkins build HBase-1.4 #1051 (See [https://builds.apache.org/job/HBase-1.4/1051/]) HBASE-19420 Backport HBASE-19152 Update refguide 'how to build an RC' (apurtell: rev 1dba475da6dbba5c04ca34ba906732368bfa7090) * (delete) hbase-assembly/src/main/assembly/src.xml * (edit) src/main/asciidoc/_chapters/developer.adoc * (edit) dev-support/make_rc.sh > Backport HBASE-19152 (Update refguide 'how to build an RC' and the make_rc.sh > script) to branch-1 > - > > Key: HBASE-19420 > URL: https://issues.apache.org/jira/browse/HBASE-19420 > Project: HBase > Issue Type: Task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.1, 1.5.0 > > Attachments: HBASE-19420-branch-1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19384) Results returned by preAppend hook in a coprocessor are replaced with null from other coprocessor even on bypass
[ https://issues.apache.org/jira/browse/HBASE-19384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278123#comment-16278123 ] Anoop Sam John commented on HBASE-19384: +1 on patch > Results returned by preAppend hook in a coprocessor are replaced with null > from other coprocessor even on bypass > > > Key: HBASE-19384 > URL: https://issues.apache.org/jira/browse/HBASE-19384 > Project: HBase > Issue Type: Bug > Components: Coprocessors >Reporter: Rajeshbabu Chintaguntla >Assignee: stack >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19384.master.001.patch > > > Phoenix adding multiple coprocessors for a table and one of them has > preAppend and preIncrement implementation and bypass the operations by > returning the results. But the other coprocessors which doesn't have any > implementation returning null and the results returned by previous > coprocessor are override by null and always going with default implementation > of append and increment operations. But it's not the case with old versions > and works fine on bypass. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19123) Purge 'complete' support from Coprocesor Observers
[ https://issues.apache.org/jira/browse/HBASE-19123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278116#comment-16278116 ] Anoop Sam John commented on HBASE-19123: The new patch LGTM. But can we attach that to 19384 and fix as that issue ? > Purge 'complete' support from Coprocesor Observers > -- > > Key: HBASE-19123 > URL: https://issues.apache.org/jira/browse/HBASE-19123 > Project: HBase > Issue Type: Task > Components: Coprocessors >Reporter: stack >Assignee: stack > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19123.master.001.patch, > HBASE-19123.master.002.patch, HBASE-19123.master.003.patch, > HBASE-19123.master.004.patch, HBASE-19123.master.005.patch > > > Up on dev list under '[DISCUSSION] Removing the bypass semantic from the > Coprocessor APIs', we are discussing purge of 'complete'. Unless objection, > lets purge for beta-1. > [~andrew.purt...@gmail.com] says the following up on the dev list: > It would simplify the theory of operation for coprocessors if we can assume > either the entire chain will complete or one of the coprocessors in the chain > will throw an exception that not only terminates processing of the rest of > the chain but also the operation in progress. > Security coprocessors interrupt processing by throwing an exception, which is > meant to propagate all the way back to the user. > I think it's more than fair to ask the same question about 'complete' as we > did about 'bypass': Does anyone use it? Is it needed? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19295) The Configuration returned by CPEnv should be read-only.
[ https://issues.apache.org/jira/browse/HBASE-19295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278115#comment-16278115 ] stack commented on HBASE-19295: --- .002 Addresses sweet review by @appy and [~Apache9] up on rb. > The Configuration returned by CPEnv should be read-only. > > > Key: HBASE-19295 > URL: https://issues.apache.org/jira/browse/HBASE-19295 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: stack >Assignee: stack > Labels: incompatible > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19295.master.001.patch, > HBASE-19295.master.002.patch > > > The Configuration a CP gets when it does a getConfiguration on the > environment is that of the RegionServer. The CP should not be able to modify > this config. We should throw exception if they try to write us. > Ditto w/ the Connection they can get from the env. They should not be able to > close it at min. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19426) Move has() and setTimestamp() to Mutation
[
https://issues.apache.org/jira/browse/HBASE-19426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-19426:
---
Attachment: HBASE-19426.v0.test.patch
just trigger the QA for hbase-server module
> Move has() and setTimestamp() to Mutation
> -
>
> Key: HBASE-19426
> URL: https://issues.apache.org/jira/browse/HBASE-19426
> Project: HBase
> Issue Type: Sub-task
> Components: Client
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19426.v0.patch, HBASE-19426.v0.test.patch
>
>
> The {{Put}} has many helper methods to get the inner cell. These methods
> should be moved to {{Mutation}} so as to have user get the cell from other
> subclasses of {{Mutation}}. Ditto for {{setTimestamp}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19295) The Configuration returned by CPEnv should be read-only.
[ https://issues.apache.org/jira/browse/HBASE-19295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19295: -- Attachment: HBASE-19295.master.002.patch > The Configuration returned by CPEnv should be read-only. > > > Key: HBASE-19295 > URL: https://issues.apache.org/jira/browse/HBASE-19295 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: stack >Assignee: stack > Labels: incompatible > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19295.master.001.patch, > HBASE-19295.master.002.patch > > > The Configuration a CP gets when it does a getConfiguration on the > environment is that of the RegionServer. The CP should not be able to modify > this config. We should throw exception if they try to write us. > Ditto w/ the Connection they can get from the env. They should not be able to > close it at min. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19426) Move has() and setTimestamp() to Mutation
[
https://issues.apache.org/jira/browse/HBASE-19426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278109#comment-16278109
]
Hadoop QA commented on HBASE-19426:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
26s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
30s{color} | {color:red} hbase-client: The patch generated 6 new + 40 unchanged
- 16 fixed = 46 total (was 56) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
8s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
56m 17s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
56s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 76m 44s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19426 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12900614/HBASE-19426.v0.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux ffaabcad8169 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 6d69fd9c78 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/10224/artifact/patchprocess/diff-checkstyle-hbase-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10224/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output |
[jira] [Commented] (HBASE-19431) The tag array written by IndividualBytesFieldCell#write is out of bounds
[
https://issues.apache.org/jira/browse/HBASE-19431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278101#comment-16278101
]
ramkrishna.s.vasudevan commented on HBASE-19431:
+1
> The tag array written by IndividualBytesFieldCell#write is out of bounds
>
>
> Key: HBASE-19431
> URL: https://issues.apache.org/jira/browse/HBASE-19431
> Project: HBase
> Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19431.v0.patch
>
>
> {code:title=IndividualBytesFieldCell.java}
> @Override
> public int write(OutputStream out, boolean withTags) throws IOException {
> // Key length and then value length
> ByteBufferUtils.putInt(out, KeyValueUtil.keyLength(this));
> ByteBufferUtils.putInt(out, getValueLength());
> // Key
> PrivateCellUtil.writeFlatKey(this, out);
> // Value
> out.write(getValueArray());
> // Tags length and tags byte array
> if (withTags && getTagsLength() > 0) {
> // Tags length
> out.write((byte)(0xff & (getTagsLength() >> 8)));
> out.write((byte)(0xff & getTagsLength()));
> // Tags byte array
> out.write(tags); // here
> }
> return getSerializedSize(withTags);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19426) Move has() and setTimestamp() to Mutation
[
https://issues.apache.org/jira/browse/HBASE-19426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278099#comment-16278099
]
stack commented on HBASE-19426:
---
+1
> Move has() and setTimestamp() to Mutation
> -
>
> Key: HBASE-19426
> URL: https://issues.apache.org/jira/browse/HBASE-19426
> Project: HBase
> Issue Type: Sub-task
> Components: Client
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19426.v0.patch
>
>
> The {{Put}} has many helper methods to get the inner cell. These methods
> should be moved to {{Mutation}} so as to have user get the cell from other
> subclasses of {{Mutation}}. Ditto for {{setTimestamp}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19295) The Configuration returned by CPEnv should be read-only.
[ https://issues.apache.org/jira/browse/HBASE-19295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19295: -- Assignee: stack Release Note: CoprocessorEnvironment#getConfiguration returns a READ-ONLY Configuration. Attempts at altering the returned Configuration -- whether setting or adding resources -- will result in an IllegalStateException warning of the Read-only condition of the returned Configuration. Status: Patch Available (was: Open) > The Configuration returned by CPEnv should be read-only. > > > Key: HBASE-19295 > URL: https://issues.apache.org/jira/browse/HBASE-19295 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: stack >Assignee: stack > Labels: incompatible > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19295.master.001.patch > > > The Configuration a CP gets when it does a getConfiguration on the > environment is that of the RegionServer. The CP should not be able to modify > this config. We should throw exception if they try to write us. > Ditto w/ the Connection they can get from the env. They should not be able to > close it at min. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19431) The tag array written by IndividualBytesFieldCell#write is out of bounds
[
https://issues.apache.org/jira/browse/HBASE-19431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278097#comment-16278097
]
stack commented on HBASE-19431:
---
+1
> The tag array written by IndividualBytesFieldCell#write is out of bounds
>
>
> Key: HBASE-19431
> URL: https://issues.apache.org/jira/browse/HBASE-19431
> Project: HBase
> Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19431.v0.patch
>
>
> {code:title=IndividualBytesFieldCell.java}
> @Override
> public int write(OutputStream out, boolean withTags) throws IOException {
> // Key length and then value length
> ByteBufferUtils.putInt(out, KeyValueUtil.keyLength(this));
> ByteBufferUtils.putInt(out, getValueLength());
> // Key
> PrivateCellUtil.writeFlatKey(this, out);
> // Value
> out.write(getValueArray());
> // Tags length and tags byte array
> if (withTags && getTagsLength() > 0) {
> // Tags length
> out.write((byte)(0xff & (getTagsLength() >> 8)));
> out.write((byte)(0xff & getTagsLength()));
> // Tags byte array
> out.write(tags); // here
> }
> return getSerializedSize(withTags);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19384) Results returned by preAppend hook in a coprocessor are replaced with null from other coprocessor even on bypass
[ https://issues.apache.org/jira/browse/HBASE-19384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19384: -- Assignee: stack (was: Rajeshbabu Chintaguntla) Status: Patch Available (was: Open) Hopefully this will work for you [~rajeshbabu] > Results returned by preAppend hook in a coprocessor are replaced with null > from other coprocessor even on bypass > > > Key: HBASE-19384 > URL: https://issues.apache.org/jira/browse/HBASE-19384 > Project: HBase > Issue Type: Bug > Components: Coprocessors >Reporter: Rajeshbabu Chintaguntla >Assignee: stack >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19384.master.001.patch > > > Phoenix adding multiple coprocessors for a table and one of them has > preAppend and preIncrement implementation and bypass the operations by > returning the results. But the other coprocessors which doesn't have any > implementation returning null and the results returned by previous > coprocessor are override by null and always going with default implementation > of append and increment operations. But it's not the case with old versions > and works fine on bypass. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19384) Results returned by preAppend hook in a coprocessor are replaced with null from other coprocessor even on bypass
[ https://issues.apache.org/jira/browse/HBASE-19384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19384: -- Attachment: HBASE-19384.master.001.patch > Results returned by preAppend hook in a coprocessor are replaced with null > from other coprocessor even on bypass > > > Key: HBASE-19384 > URL: https://issues.apache.org/jira/browse/HBASE-19384 > Project: HBase > Issue Type: Bug > Components: Coprocessors >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19384.master.001.patch > > > Phoenix adding multiple coprocessors for a table and one of them has > preAppend and preIncrement implementation and bypass the operations by > returning the results. But the other coprocessors which doesn't have any > implementation returning null and the results returned by previous > coprocessor are override by null and always going with default implementation > of append and increment operations. But it's not the case with old versions > and works fine on bypass. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19123) Purge 'complete' support from Coprocesor Observers
[ https://issues.apache.org/jira/browse/HBASE-19123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19123: -- Attachment: HBASE-19123.master.005.patch > Purge 'complete' support from Coprocesor Observers > -- > > Key: HBASE-19123 > URL: https://issues.apache.org/jira/browse/HBASE-19123 > Project: HBase > Issue Type: Task > Components: Coprocessors >Reporter: stack >Assignee: stack > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19123.master.001.patch, > HBASE-19123.master.002.patch, HBASE-19123.master.003.patch, > HBASE-19123.master.004.patch, HBASE-19123.master.005.patch > > > Up on dev list under '[DISCUSSION] Removing the bypass semantic from the > Coprocessor APIs', we are discussing purge of 'complete'. Unless objection, > lets purge for beta-1. > [~andrew.purt...@gmail.com] says the following up on the dev list: > It would simplify the theory of operation for coprocessors if we can assume > either the entire chain will complete or one of the coprocessors in the chain > will throw an exception that not only terminates processing of the rest of > the chain but also the operation in progress. > Security coprocessors interrupt processing by throwing an exception, which is > meant to propagate all the way back to the user. > I think it's more than fair to ask the same question about 'complete' as we > did about 'bypass': Does anyone use it? Is it needed? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19431) The tag array written by IndividualBytesFieldCell#write is out of bounds
[
https://issues.apache.org/jira/browse/HBASE-19431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-19431:
---
Attachment: HBASE-19431.v0.patch
one line fix and a simple test case
> The tag array written by IndividualBytesFieldCell#write is out of bounds
>
>
> Key: HBASE-19431
> URL: https://issues.apache.org/jira/browse/HBASE-19431
> Project: HBase
> Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19431.v0.patch
>
>
> {code:title=IndividualBytesFieldCell.java}
> @Override
> public int write(OutputStream out, boolean withTags) throws IOException {
> // Key length and then value length
> ByteBufferUtils.putInt(out, KeyValueUtil.keyLength(this));
> ByteBufferUtils.putInt(out, getValueLength());
> // Key
> PrivateCellUtil.writeFlatKey(this, out);
> // Value
> out.write(getValueArray());
> // Tags length and tags byte array
> if (withTags && getTagsLength() > 0) {
> // Tags length
> out.write((byte)(0xff & (getTagsLength() >> 8)));
> out.write((byte)(0xff & getTagsLength()));
> // Tags byte array
> out.write(tags); // here
> }
> return getSerializedSize(withTags);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19431) The tag array written by IndividualBytesFieldCell#write is out of bounds
[
https://issues.apache.org/jira/browse/HBASE-19431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-19431:
---
Status: Patch Available (was: Open)
> The tag array written by IndividualBytesFieldCell#write is out of bounds
>
>
> Key: HBASE-19431
> URL: https://issues.apache.org/jira/browse/HBASE-19431
> Project: HBase
> Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19431.v0.patch
>
>
> {code:title=IndividualBytesFieldCell.java}
> @Override
> public int write(OutputStream out, boolean withTags) throws IOException {
> // Key length and then value length
> ByteBufferUtils.putInt(out, KeyValueUtil.keyLength(this));
> ByteBufferUtils.putInt(out, getValueLength());
> // Key
> PrivateCellUtil.writeFlatKey(this, out);
> // Value
> out.write(getValueArray());
> // Tags length and tags byte array
> if (withTags && getTagsLength() > 0) {
> // Tags length
> out.write((byte)(0xff & (getTagsLength() >> 8)));
> out.write((byte)(0xff & getTagsLength()));
> // Tags byte array
> out.write(tags); // here
> }
> return getSerializedSize(withTags);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-19417) Properly assign loaded flag in RSRpcServices#bulkLoadHFile()
[
https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278072#comment-16278072
]
Appy edited comment on HBASE-19417 at 12/5/17 6:17 AM:
---
(Review on v4)
"Value of false doesn't rollback or cancel the load"
Not needed anymore
Where are we calling the hook for secure bulk load case?
RCpHost#postBulkLoadHFile(boolean result)
nit: same variable name as hook please.
was (Author: appy):
"Value of false doesn't rollback or cancel the load"
Not needed anymore
Where are we calling the hook for secure bulk load case?
RCpHost#postBulkLoadHFile(boolean result)
nit: same variable name as hook please.
> Properly assign loaded flag in RSRpcServices#bulkLoadHFile()
>
>
> Key: HBASE-19417
> URL: https://issues.apache.org/jira/browse/HBASE-19417
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Ted Yu
> Attachments: 19417.v1.txt, 19417.v2.txt, 19417.v3.txt, 19417.v4.txt
>
>
> See the discussion at the tail of HBASE-17123 where Appy pointed out that the
> override of loaded should be placed inside else block:
> {code}
> } else {
> // secure bulk load
> map = regionServer.secureBulkLoadManager.secureBulkLoadHFiles(region,
> request);
> }
> BulkLoadHFileResponse.Builder builder =
> BulkLoadHFileResponse.newBuilder();
> if (map != null) {
> loaded = true;
> }
> {code}
> This issue is to address the review comment.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19417) Properly assign loaded flag in RSRpcServices#bulkLoadHFile()
[
https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278072#comment-16278072
]
Appy commented on HBASE-19417:
--
"Value of false doesn't rollback or cancel the load"
Not needed anymore
Where are we calling the hook for secure bulk load case?
RCpHost#postBulkLoadHFile(boolean result)
nit: same variable name as hook please.
> Properly assign loaded flag in RSRpcServices#bulkLoadHFile()
>
>
> Key: HBASE-19417
> URL: https://issues.apache.org/jira/browse/HBASE-19417
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Ted Yu
> Attachments: 19417.v1.txt, 19417.v2.txt, 19417.v3.txt, 19417.v4.txt
>
>
> See the discussion at the tail of HBASE-17123 where Appy pointed out that the
> override of loaded should be placed inside else block:
> {code}
> } else {
> // secure bulk load
> map = regionServer.secureBulkLoadManager.secureBulkLoadHFiles(region,
> request);
> }
> BulkLoadHFileResponse.Builder builder =
> BulkLoadHFileResponse.newBuilder();
> if (map != null) {
> loaded = true;
> }
> {code}
> This issue is to address the review comment.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-19431) The tag array written by IndividualBytesFieldCell#write is out of bounds
Chia-Ping Tsai created HBASE-19431:
--
Summary: The tag array written by IndividualBytesFieldCell#write
is out of bounds
Key: HBASE-19431
URL: https://issues.apache.org/jira/browse/HBASE-19431
Project: HBase
Issue Type: Bug
Reporter: Chia-Ping Tsai
Assignee: Chia-Ping Tsai
Priority: Critical
Fix For: 2.0.0-beta-1
{code:title=IndividualBytesFieldCell.java}
@Override
public int write(OutputStream out, boolean withTags) throws IOException {
// Key length and then value length
ByteBufferUtils.putInt(out, KeyValueUtil.keyLength(this));
ByteBufferUtils.putInt(out, getValueLength());
// Key
PrivateCellUtil.writeFlatKey(this, out);
// Value
out.write(getValueArray());
// Tags length and tags byte array
if (withTags && getTagsLength() > 0) {
// Tags length
out.write((byte)(0xff & (getTagsLength() >> 8)));
out.write((byte)(0xff & getTagsLength()));
// Tags byte array
out.write(tags); // here
}
return getSerializedSize(withTags);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19295) The Configuration returned by CPEnv should be read-only.
[ https://issues.apache.org/jira/browse/HBASE-19295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278068#comment-16278068 ] Appy commented on HBASE-19295: -- Add a release note too please. > The Configuration returned by CPEnv should be read-only. > > > Key: HBASE-19295 > URL: https://issues.apache.org/jira/browse/HBASE-19295 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: stack > Labels: incompatible > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19295.master.001.patch > > > The Configuration a CP gets when it does a getConfiguration on the > environment is that of the RegionServer. The CP should not be able to modify > this config. We should throw exception if they try to write us. > Ditto w/ the Connection they can get from the env. They should not be able to > close it at min. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19417) Properly assign loaded flag in RSRpcServices#bulkLoadHFile()
[
https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278066#comment-16278066
]
Appy commented on HBASE-19417:
--
Fine by me.
> Properly assign loaded flag in RSRpcServices#bulkLoadHFile()
>
>
> Key: HBASE-19417
> URL: https://issues.apache.org/jira/browse/HBASE-19417
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Ted Yu
> Attachments: 19417.v1.txt, 19417.v2.txt, 19417.v3.txt, 19417.v4.txt
>
>
> See the discussion at the tail of HBASE-17123 where Appy pointed out that the
> override of loaded should be placed inside else block:
> {code}
> } else {
> // secure bulk load
> map = regionServer.secureBulkLoadManager.secureBulkLoadHFiles(region,
> request);
> }
> BulkLoadHFileResponse.Builder builder =
> BulkLoadHFileResponse.newBuilder();
> if (map != null) {
> loaded = true;
> }
> {code}
> This issue is to address the review comment.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19417) Properly assign loaded flag in RSRpcServices#bulkLoadHFile()
[
https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-19417:
---
Attachment: 19417.v4.txt
> Properly assign loaded flag in RSRpcServices#bulkLoadHFile()
>
>
> Key: HBASE-19417
> URL: https://issues.apache.org/jira/browse/HBASE-19417
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Ted Yu
> Attachments: 19417.v1.txt, 19417.v2.txt, 19417.v3.txt, 19417.v4.txt
>
>
> See the discussion at the tail of HBASE-17123 where Appy pointed out that the
> override of loaded should be placed inside else block:
> {code}
> } else {
> // secure bulk load
> map = regionServer.secureBulkLoadManager.secureBulkLoadHFiles(region,
> request);
> }
> BulkLoadHFileResponse.Builder builder =
> BulkLoadHFileResponse.newBuilder();
> if (map != null) {
> loaded = true;
> }
> {code}
> This issue is to address the review comment.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19417) Properly assign loaded flag in RSRpcServices#bulkLoadHFile()
[
https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278054#comment-16278054
]
Hadoop QA commented on HBASE-19417:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
2s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
9s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 2m
7s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
43s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 43s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
10s{color} | {color:red} hbase-server: The patch generated 2 new + 236
unchanged - 0 fixed = 238 total (was 236) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 3m
24s{color} | {color:red} patch has 32 errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m
19s{color} | {color:red} The patch causes 32 errors with Hadoop v2.6.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 7m
4s{color} | {color:red} The patch causes 32 errors with Hadoop v2.6.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 8m
54s{color} | {color:red} The patch causes 32 errors with Hadoop v2.6.3. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 10m
42s{color} | {color:red} The patch causes 32 errors with Hadoop v2.6.4. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 12m
30s{color} | {color:red} The patch causes 32 errors with Hadoop v2.6.5. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 14m
17s{color} | {color:red} The patch causes 32 errors with Hadoop v2.7.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 16m
1s{color} | {color:red} The patch causes 32 errors with Hadoop v2.7.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 17m
50s{color} | {color:red} The patch causes 32 errors with Hadoop v2.7.3. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 19m
40s{color} | {color:red} The patch causes 32 errors with Hadoop v2.7.4. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 21m
31s{color} | {color:red} The patch causes 32 errors with Hadoop v3.0.0-alpha4.
{color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
[jira] [Updated] (HBASE-19295) The Configuration returned by CPEnv should be read-only.
[ https://issues.apache.org/jira/browse/HBASE-19295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19295: - Component/s: Coprocessors > The Configuration returned by CPEnv should be read-only. > > > Key: HBASE-19295 > URL: https://issues.apache.org/jira/browse/HBASE-19295 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: stack > Labels: incompatible > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19295.master.001.patch > > > The Configuration a CP gets when it does a getConfiguration on the > environment is that of the RegionServer. The CP should not be able to modify > this config. We should throw exception if they try to write us. > Ditto w/ the Connection they can get from the env. They should not be able to > close it at min. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19426) Move has() and setTimestamp() to Mutation
[
https://issues.apache.org/jira/browse/HBASE-19426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-19426:
---
Description: The {{Put}} has many helper methods to get the inner cell.
These methods should be moved to {{Mutation}} so as to have user get the cell
from other subclasses of {{Mutation}}. Ditto for {{setTimestamp}}.
> Move has() and setTimestamp() to Mutation
> -
>
> Key: HBASE-19426
> URL: https://issues.apache.org/jira/browse/HBASE-19426
> Project: HBase
> Issue Type: Sub-task
> Components: Client
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19426.v0.patch
>
>
> The {{Put}} has many helper methods to get the inner cell. These methods
> should be moved to {{Mutation}} so as to have user get the cell from other
> subclasses of {{Mutation}}. Ditto for {{setTimestamp}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19295) The Configuration returned by CPEnv should be read-only.
[ https://issues.apache.org/jira/browse/HBASE-19295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19295: - Labels: incompatible (was: ) > The Configuration returned by CPEnv should be read-only. > > > Key: HBASE-19295 > URL: https://issues.apache.org/jira/browse/HBASE-19295 > Project: HBase > Issue Type: Sub-task >Reporter: stack > Labels: incompatible > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19295.master.001.patch > > > The Configuration a CP gets when it does a getConfiguration on the > environment is that of the RegionServer. The CP should not be able to modify > this config. We should throw exception if they try to write us. > Ditto w/ the Connection they can get from the env. They should not be able to > close it at min. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19426) Move has() and setTimestamp() to Mutation
[ https://issues.apache.org/jira/browse/HBASE-19426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19426: --- Status: Patch Available (was: Open) > Move has() and setTimestamp() to Mutation > - > > Key: HBASE-19426 > URL: https://issues.apache.org/jira/browse/HBASE-19426 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19426.v0.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19426) Move has() and setTimestamp() to Mutation
[ https://issues.apache.org/jira/browse/HBASE-19426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19426: --- Attachment: HBASE-19426.v0.patch > Move has() and setTimestamp() to Mutation > - > > Key: HBASE-19426 > URL: https://issues.apache.org/jira/browse/HBASE-19426 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19426.v0.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[ https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19430: --- Fix Version/s: 2.0.0-beta-2 > Remove the SettableTimestamp and SettableSequenceId > --- > > Key: HBASE-19430 > URL: https://issues.apache.org/jira/browse/HBASE-19430 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-beta-2 > > > They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP > and denoted with deprecated. To my way of thinking, we should remove them > before 2.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[ https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278046#comment-16278046 ] Chia-Ping Tsai commented on HBASE-19430: Thanks for all comment. Let me do the cleanup. > Remove the SettableTimestamp and SettableSequenceId > --- > > Key: HBASE-19430 > URL: https://issues.apache.org/jira/browse/HBASE-19430 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-beta-2 > > > They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP > and denoted with deprecated. To my way of thinking, we should remove them > before 2.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[ https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned HBASE-19430: -- Assignee: Chia-Ping Tsai > Remove the SettableTimestamp and SettableSequenceId > --- > > Key: HBASE-19430 > URL: https://issues.apache.org/jira/browse/HBASE-19430 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > > They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP > and denoted with deprecated. To my way of thinking, we should remove them > before 2.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[
https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278038#comment-16278038
]
ramkrishna.s.vasudevan commented on HBASE-19430:
The SettableTimestamp API
{code}
setTimestamp(byte[] ts, int tsOffset)
{code}
is probably not needed. And just add setSequncedId(long seqId) and
setTimeStamp(ts) to Extendedcell. And no longer these methods will be exposed
to CP since ExtendedCell is private. If at all CP needs to create a cell with
TS it has to go with the cell builder way.
> Remove the SettableTimestamp and SettableSequenceId
> ---
>
> Key: HBASE-19430
> URL: https://issues.apache.org/jira/browse/HBASE-19430
> Project: HBase
> Issue Type: Task
>Reporter: Chia-Ping Tsai
>
> They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP
> and denoted with deprecated. To my way of thinking, we should remove them
> before 2.0 release.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19123) Purge 'complete' support from Coprocesor Observers
[ https://issues.apache.org/jira/browse/HBASE-19123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278025#comment-16278025 ] stack commented on HBASE-19123: --- This removal had repercussions addressed in the linked issue HBASE-19384 > Purge 'complete' support from Coprocesor Observers > -- > > Key: HBASE-19123 > URL: https://issues.apache.org/jira/browse/HBASE-19123 > Project: HBase > Issue Type: Task > Components: Coprocessors >Reporter: stack >Assignee: stack > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19123.master.001.patch, > HBASE-19123.master.002.patch, HBASE-19123.master.003.patch, > HBASE-19123.master.004.patch > > > Up on dev list under '[DISCUSSION] Removing the bypass semantic from the > Coprocessor APIs', we are discussing purge of 'complete'. Unless objection, > lets purge for beta-1. > [~andrew.purt...@gmail.com] says the following up on the dev list: > It would simplify the theory of operation for coprocessors if we can assume > either the entire chain will complete or one of the coprocessors in the chain > will throw an exception that not only terminates processing of the rest of > the chain but also the operation in progress. > Security coprocessors interrupt processing by throwing an exception, which is > meant to propagate all the way back to the user. > I think it's more than fair to ask the same question about 'complete' as we > did about 'bypass': Does anyone use it? Is it needed? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19417) Properly assign loaded flag in RSRpcServices#bulkLoadHFile()
[
https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-19417:
---
Attachment: 19417.v3.txt
> Properly assign loaded flag in RSRpcServices#bulkLoadHFile()
>
>
> Key: HBASE-19417
> URL: https://issues.apache.org/jira/browse/HBASE-19417
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Ted Yu
> Attachments: 19417.v1.txt, 19417.v2.txt, 19417.v3.txt
>
>
> See the discussion at the tail of HBASE-17123 where Appy pointed out that the
> override of loaded should be placed inside else block:
> {code}
> } else {
> // secure bulk load
> map = regionServer.secureBulkLoadManager.secureBulkLoadHFiles(region,
> request);
> }
> BulkLoadHFileResponse.Builder builder =
> BulkLoadHFileResponse.newBuilder();
> if (map != null) {
> loaded = true;
> }
> {code}
> This issue is to address the review comment.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19295) The Configuration returned by CPEnv should be read-only.
[ https://issues.apache.org/jira/browse/HBASE-19295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19295: -- Attachment: HBASE-19295.master.001.patch > The Configuration returned by CPEnv should be read-only. > > > Key: HBASE-19295 > URL: https://issues.apache.org/jira/browse/HBASE-19295 > Project: HBase > Issue Type: Sub-task >Reporter: stack > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19295.master.001.patch > > > The Configuration a CP gets when it does a getConfiguration on the > environment is that of the RegionServer. The CP should not be able to modify > this config. We should throw exception if they try to write us. > Ditto w/ the Connection they can get from the env. They should not be able to > close it at min. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19419) Remove hbase-native-client from branch-1
[ https://issues.apache.org/jira/browse/HBASE-19419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278018#comment-16278018 ] Nick Dimiduk commented on HBASE-19419: -- I think this is fine for branch-1.1. We've never supported the native client on that release line and indeed, it's not available in the src tarball. > Remove hbase-native-client from branch-1 > > > Key: HBASE-19419 > URL: https://issues.apache.org/jira/browse/HBASE-19419 > Project: HBase > Issue Type: Task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0 > > Attachments: HBASE-19419-branch-1.patch > > > We have an hbase-native-client subdirectory in the source tree that isn't > hooked up to the Maven build. It hasn't been updated in two years. (Last > update Fri Jul 31 11:22:50 2015 -0700.) I propose to remove it from our > source distribution. It can be moved to GitHub as a separate project. > Dropping it doesn't represent a compatibility problem as it isn't hooked up > to the build and seems unlikely anyone is depending on it given we haven't > had a single change nor issue reported against it for two years. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19112) Suspect methods on Cell to be deprecated
[
https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278014#comment-16278014
]
Anoop Sam John commented on HBASE-19112:
in 3.0 when the Cell#getTypeByte() is going to go away, we have to have a clear
other way. That has to be there in 2.0 itself. That is what the deprecation
mandate thing. Give the alternate now itself and that will have to continue in
3.0 also.
> Suspect methods on Cell to be deprecated
>
>
> Key: HBASE-19112
> URL: https://issues.apache.org/jira/browse/HBASE-19112
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: Josh Elser
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19112_branch-2.patch
>
>
> [~chia7712] suggested on the [mailing
> list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
> that we have some methods on Cell which should be deprecated for removal:
> * {{#getType()}}
> * {{#getTimestamp()}}
> * {{#getTag()}}
> * {{#getSequenceId()}}
> Let's make a pass over these (and maybe the rest) to make sure that there
> aren't others which are either implementation details or methods returning
> now-private-marked classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19417) Properly assign loaded flag in RSRpcServices#bulkLoadHFile()
[
https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278012#comment-16278012
]
Anoop Sam John commented on HBASE-19417:
Ted - I would suggest change the CP hook NOT to return a boolean. Pre hook we
changed that way already
> Properly assign loaded flag in RSRpcServices#bulkLoadHFile()
>
>
> Key: HBASE-19417
> URL: https://issues.apache.org/jira/browse/HBASE-19417
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Ted Yu
> Attachments: 19417.v1.txt, 19417.v2.txt
>
>
> See the discussion at the tail of HBASE-17123 where Appy pointed out that the
> override of loaded should be placed inside else block:
> {code}
> } else {
> // secure bulk load
> map = regionServer.secureBulkLoadManager.secureBulkLoadHFiles(region,
> request);
> }
> BulkLoadHFileResponse.Builder builder =
> BulkLoadHFileResponse.newBuilder();
> if (map != null) {
> loaded = true;
> }
> {code}
> This issue is to address the review comment.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[ https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278011#comment-16278011 ] stack commented on HBASE-19430: --- Wasn't it only server-side anyways? And CP. And we can make breaking changes on CPs for 2.0. I'd be +1 on removing them. > Remove the SettableTimestamp and SettableSequenceId > --- > > Key: HBASE-19430 > URL: https://issues.apache.org/jira/browse/HBASE-19430 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai > > They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP > and denoted with deprecated. To my way of thinking, we should remove them > before 2.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17123) Add postBulkLoadHFile variant that notifies the final paths for the hfiles
[
https://issues.apache.org/jira/browse/HBASE-17123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278009#comment-16278009
]
Anoop Sam John commented on HBASE-17123:
CPs backward compat we can break IMO. We broke it left and right already. I
believe even the pre hook had some return. We changed that to void. Post hook
also better we change to void return IMO. Ya in some other issue we can fix.
> Add postBulkLoadHFile variant that notifies the final paths for the hfiles
> --
>
> Key: HBASE-17123
> URL: https://issues.apache.org/jira/browse/HBASE-17123
> Project: HBase
> Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Ted Yu
> Labels: bulkloader
> Fix For: 2.0.0
>
> Attachments: 17123.addendum, 17123.v1.txt, 17123.v3.txt,
> 17123.v4.txt, 17123.v5.txt
>
>
> Currently the postBulkLoadHFile() hook passes the same familyPaths parameter
> which it receives as method parameter.
> See code in SecureBulkLoadManager :
> {code}
>loaded = region.getCoprocessorHost().postBulkLoadHFile(familyPaths,
> loaded);
> {code}
> Meaning, the paths are not final, moved paths of the loaded hfiles.
> This issue is to add a variant which notifies the final paths of the loaded
> hfiles.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19429) Release build fails in checkstyle phase of site target (branch-1)
[
https://issues.apache.org/jira/browse/HBASE-19429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278007#comment-16278007
]
stack commented on HBASE-19429:
---
Making a release you always find fun stuff
> Release build fails in checkstyle phase of site target (branch-1)
> -
>
> Key: HBASE-19429
> URL: https://issues.apache.org/jira/browse/HBASE-19429
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0
>
> Attachments: HBASE-19429-branch-1.patch
>
>
> Running these commands:
> {noformat}
> export MAVEN_OPTS="-Xmx4g -XX:MaxPermSize=256m"
> mvn clean org.codehaus.mojo:versions-maven-plugin:2.5:set -DnewVersion=1.4.0
> git clean -xdf
> mvn clean install -DskipTests -Prelease
> mvn install -DskipTests site assembly:single -Prelease
> {noformat}
> fails on that last Maven invocation in the checkstyle phase of the site
> target with
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project
> hbase-annotations: Error generating maven-checkstyle-plugin:2.17:checkstyle:
> Failed during checkstyle execution: Unable to process suppressions file
> location: hbase/checkstyle-suppressions.xml: Cannot create file-based
> resource:invalid block type
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19421) branch-1 does not compile against Hadoop 3.0.0
[
https://issues.apache.org/jira/browse/HBASE-19421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278008#comment-16278008
]
Hudson commented on HBASE-19421:
SUCCESS: Integrated in Jenkins build HBase-1.4 #1050 (See
[https://builds.apache.org/job/HBase-1.4/1050/])
HBASE-19421 branch-1 does not compile against Hadoop 3.0.0 (apurtell: rev
5f58e618c368ccd89fefc5aa4fa96c2b1a43649e)
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java
* (edit) hbase-examples/pom.xml
* (edit) hbase-procedure/pom.xml
* (add) hbase-server/src/main/java/org/apache/hadoop/hbase/util/MBeanUtil.java
* (edit) hbase-external-blockcache/pom.xml
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java
* (edit) hbase-testing-util/pom.xml
* (edit) hbase-prefix-tree/pom.xml
* (edit) hbase-shell/pom.xml
* (edit) hbase-common/pom.xml
* (edit) pom.xml
* (edit) hbase-resource-bundle/src/main/resources/supplemental-models.xml
* (edit) hbase-thrift/pom.xml
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* (edit) hbase-server/pom.xml
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/IncrementCoalescer.java
* (edit) hbase-client/pom.xml
* (edit) hbase-rest/pom.xml
* (edit) hbase-it/pom.xml
* (edit) hbase-rsgroup/pom.xml
> branch-1 does not compile against Hadoop 3.0.0
> --
>
> Key: HBASE-19421
> URL: https://issues.apache.org/jira/browse/HBASE-19421
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 1.4.0
>
> Attachments: HBASE-19421-branch-1.patch
>
>
> Tested with {{mvn clean install -Dhadoop.profile=3.0
> -Dhadoop-three.version=3.0.0-alpha4}}
> {noformat}
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[37,32]
> package org.apache.hadoop.mapred does not exist
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[38,35]
> package org.apache.hadoop.mapreduce does not exist
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[117,66]
> cannot find symbol
> [ERROR] symbol: class Job
> [ERROR] location: class org.apache.hadoop.hbase.security.User
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[129,46]
> cannot find symbol
> [ERROR] symbol: class JobConf
> [ERROR] location: class org.apache.hadoop.hbase.security.User
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[344,59]
> cannot find symbol
> [ERROR] symbol: class Job
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[369,39]
> cannot find symbol
> [ERROR] symbol: class JobConf
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[351,17]
> cannot find symbol
> [ERROR] symbol: class Job
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[375,25]
> cannot find symbol
> [ERROR] symbol: class JobConf
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19429) Release build fails in checkstyle phase of site target (branch-1)
[
https://issues.apache.org/jira/browse/HBASE-19429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278006#comment-16278006
]
stack commented on HBASE-19429:
---
Smile. +1
> Release build fails in checkstyle phase of site target (branch-1)
> -
>
> Key: HBASE-19429
> URL: https://issues.apache.org/jira/browse/HBASE-19429
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0
>
> Attachments: HBASE-19429-branch-1.patch
>
>
> Running these commands:
> {noformat}
> export MAVEN_OPTS="-Xmx4g -XX:MaxPermSize=256m"
> mvn clean org.codehaus.mojo:versions-maven-plugin:2.5:set -DnewVersion=1.4.0
> git clean -xdf
> mvn clean install -DskipTests -Prelease
> mvn install -DskipTests site assembly:single -Prelease
> {noformat}
> fails on that last Maven invocation in the checkstyle phase of the site
> target with
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project
> hbase-annotations: Error generating maven-checkstyle-plugin:2.17:checkstyle:
> Failed during checkstyle execution: Unable to process suppressions file
> location: hbase/checkstyle-suppressions.xml: Cannot create file-based
> resource:invalid block type
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[ https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278001#comment-16278001 ] ramkrishna.s.vasudevan commented on HBASE-19430: I think this was added in branch-1 and so it should be deprecated in 2.0 and removed in 3.0 right? But not sure if any one is really using it since setting sequence ID (for eg) is not advisable. > Remove the SettableTimestamp and SettableSequenceId > --- > > Key: HBASE-19430 > URL: https://issues.apache.org/jira/browse/HBASE-19430 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai > > They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP > and denoted with deprecated. To my way of thinking, we should remove them > before 2.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19112) Suspect methods on Cell to be deprecated
[
https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277999#comment-16277999
]
ramkrishna.s.vasudevan commented on HBASE-19112:
Yes. That is right. But my point was in 2.0 we will still have
Cell.getTypeByte() deprecated. If at all client wants the type we can always
provide some way for them to access the type byte (like converting the cell to
KV and then getting the type).
But in 3.0 there is going to be changes to the APIs with RawCell and people
will be able to migrate to it ?
If this is a concern still, then the simple way is to go with getType (a
readable one) in Cell.
> Suspect methods on Cell to be deprecated
>
>
> Key: HBASE-19112
> URL: https://issues.apache.org/jira/browse/HBASE-19112
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: Josh Elser
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19112_branch-2.patch
>
>
> [~chia7712] suggested on the [mailing
> list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
> that we have some methods on Cell which should be deprecated for removal:
> * {{#getType()}}
> * {{#getTimestamp()}}
> * {{#getTag()}}
> * {{#getSequenceId()}}
> Let's make a pass over these (and maybe the rest) to make sure that there
> aren't others which are either implementation details or methods returning
> now-private-marked classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18942) hbase-hadoop2-compat module ignores hadoop-3 profile
[
https://issues.apache.org/jira/browse/HBASE-18942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277988#comment-16277988
]
Hudson commented on HBASE-18942:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4170 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/4170/])
HBASE-18942 hbase-hadoop2-compat module ignores hadoop-3 profile (apurtell: rev
6d69fd9c7871ffc3878eefa307da0e49bb7205f5)
* (edit) hbase-hadoop2-compat/pom.xml
> hbase-hadoop2-compat module ignores hadoop-3 profile
>
>
> Key: HBASE-18942
> URL: https://issues.apache.org/jira/browse/HBASE-18942
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Appy
> Labels: build
> Fix For: 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-18942.master.001.patch
>
>
> In hbase-hadoop2-compat/pom.xml :
> {code}
>
> org.apache.hadoop
> hadoop-common
> ${hadoop-two.version}
>
> {code}
> The version for hadoop-common defaults to hadoop-two.
> This means that when hadoop-3.0 profile is used, hadoop-three.version would
> be ignored.
> The following error would be observed:
> {code}
> Caused by: java.util.ServiceConfigurationError:
> org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSource: Provider
> org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSourceImpl could not be
> instantiated
> at java.util.ServiceLoader.fail(ServiceLoader.java:232)
> at java.util.ServiceLoader.access$100(ServiceLoader.java:185)
> at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:384)
> at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404)
> at java.util.ServiceLoader$1.next(ServiceLoader.java:480)
> at
> org.apache.hadoop.hbase.CompatibilitySingletonFactory.getInstance(CompatibilitySingletonFactory.java:59)
> ... 34 more
> Caused by: java.lang.NoClassDefFoundError: Could not initialize class
> com.sun.proxy.$Proxy17
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at java.lang.reflect.Proxy.newProxyInstance(Proxy.java:739)
> at
> org.apache.commons.configuration2.builder.fluent.Parameters.createParametersProxy(Parameters.java:294)
> at
> org.apache.commons.configuration2.builder.fluent.Parameters.fileBased(Parameters.java:185)
> at
> org.apache.commons.configuration2.builder.fluent.Configurations.fileParams(Configurations.java:602)
> at
> org.apache.commons.configuration2.builder.fluent.Configurations.fileParams(Configurations.java:638)
> at
> org.apache.commons.configuration2.builder.fluent.Configurations.fileBasedBuilder(Configurations.java:164)
> at
> org.apache.commons.configuration2.builder.fluent.Configurations.propertiesBuilder(Configurations.java:264)
> at
> org.apache.hadoop.metrics2.impl.MetricsConfig.loadFirst(MetricsConfig.java:115)
> at
> org.apache.hadoop.metrics2.impl.MetricsConfig.create(MetricsConfig.java:98)
> at
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configure(MetricsSystemImpl.java:478)
> at
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:188)
> at
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.init(MetricsSystemImpl.java:163)
> at
> org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.init(DefaultMetricsSystem.java:62)
> at
> org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.initialize(DefaultMetricsSystem.java:58)
> at
> org.apache.hadoop.hbase.metrics.BaseSourceImpl$DefaultMetricsSystemInitializer.init(BaseSourceImpl.java:51)
> at
> org.apache.hadoop.hbase.metrics.BaseSourceImpl.(BaseSourceImpl.java:112)
> at
> org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSourceImpl.(MetricsZooKeeperSourceImpl.java:56)
> at
> org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSourceImpl.(MetricsZooKeeperSourceImpl.java:51)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (HBASE-19415) Backport HBASE-19056 to branch-1.x
[ https://issues.apache.org/jira/browse/HBASE-19415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-19415. --- Resolution: Duplicate Resolve as duplicated. > Backport HBASE-19056 to branch-1.x > -- > > Key: HBASE-19415 > URL: https://issues.apache.org/jira/browse/HBASE-19415 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 1.4.0, 1.5.0 >Reporter: Duo Zhang > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (HBASE-19415) Backport HBASE-19056 to branch-1.x
[ https://issues.apache.org/jira/browse/HBASE-19415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-19415: --- > Backport HBASE-19056 to branch-1.x > -- > > Key: HBASE-19415 > URL: https://issues.apache.org/jira/browse/HBASE-19415 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 1.4.0, 1.5.0 >Reporter: Duo Zhang > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277977#comment-16277977 ] Duo Zhang commented on HBASE-19410: --- Ping [~mdrob], our zk expert. And also [~appy], this is follow-on issue on your zk stuffs separation. Thanks. > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410-v2.patch, > HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19410: -- Attachment: HBASE-19410-v2.patch [~chia7712] Comments added for ZKTests. Also addressed the comments from RB by [~psomogyi]. > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410-v2.patch, > HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19421) branch-1 does not compile against Hadoop 3.0.0
[
https://issues.apache.org/jira/browse/HBASE-19421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277972#comment-16277972
]
Hadoop QA commented on HBASE-19421:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 13m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
56s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
32s{color} | {color:green} branch-1 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
48s{color} | {color:green} branch-1 passed with JDK v1.7.0_161 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 9m
29s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 12m
15s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-resource-bundle hbase-testing-util . {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
49s{color} | {color:red} hbase-common in branch-1 has 1 extant Findbugs
warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
9s{color} | {color:red} hbase-client in branch-1 has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
57s{color} | {color:green} branch-1 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
26s{color} | {color:green} branch-1 passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
18s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
57s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 39s{color}
| {color:red} hbase-server-jdk1.7.0_161 with JDK v1.7.0_161 generated 2 new + 4
unchanged - 2 fixed = 6 total (was 6) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 42s{color}
| {color:red} root-jdk1.7.0_161 with JDK v1.7.0_161 generated 2 new + 23
unchanged - 2 fixed = 25 total (was 25) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
22s{color} | {color:red} hbase-server: The patch generated 7 new + 172
unchanged - 1 fixed = 179 total (was 173) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 4m
36s{color} | {color:red} root: The patch generated 7 new + 184 unchanged - 1
fixed = 191 total (was 185) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 9 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 8 line(s) with tabs. {color} |
| {color:red}-1{color} | {color:red} xml {color} | {color:red} 0m 2s{color} |
{color:red} The patch has 15 ill-formed XML file(s). {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
38s{color} | {color:green}
[jira] [Updated] (HBASE-19416) Document dynamic configurations currently support
[ https://issues.apache.org/jira/browse/HBASE-19416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-19416: -- Attachment: HBASE-19416.master.003.patch Remove default value and jira link. > Document dynamic configurations currently support > - > > Key: HBASE-19416 > URL: https://issues.apache.org/jira/browse/HBASE-19416 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19416.master.001.patch, > HBASE-19416.master.002.patch, HBASE-19416.master.003.patch > > > More informative about dynamic configuration currently support -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19422) using hadoop-profile property leads to confusing failures
[
https://issues.apache.org/jira/browse/HBASE-19422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277937#comment-16277937
]
Hadoop QA commented on HBASE-19422:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
30s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 15m
58s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
35s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
33s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
47m 0s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
54s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}155m
5s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
31s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}234m 42s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19422 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12900575/HBASE-19422.patch |
| Optional Tests | asflicense javac javadoc unit shadedjars hadoopcheck
xml compile |
| uname | Linux d1510227b8f9 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 4c567b3c12 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10220/testReport/ |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10220/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> using hadoop-profile property leads to confusing failures
> -
>
> Key: HBASE-19422
> URL: https://issues.apache.org/jira/browse/HBASE-19422
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Mike Drob
> Attachments: 19422.v1.txt, HBASE-19422.patch
>
>
> When building master branch against hadoop 3 beta1,
> {code}
> mvn clean install -Dhadoop-profile=3.0 -Dhadoop-three.version=3.0.0-beta1
[jira] [Commented] (HBASE-17883) release 1.4.0
[ https://issues.apache.org/jira/browse/HBASE-17883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277935#comment-16277935 ] Andrew Purtell commented on HBASE-17883: I have tagged 1.4.0RC0 as 7123ddfadc. Feel free to continue to commit to branch-1 and branch-1.4 while I finish up with the RC. > release 1.4.0 > - > > Key: HBASE-17883 > URL: https://issues.apache.org/jira/browse/HBASE-17883 > Project: HBase > Issue Type: Task > Components: community >Affects Versions: 1.4.0 >Reporter: Sean Busbey >Assignee: Andrew Purtell >Priority: Critical > > Let's start working through doing the needful; it's been almost 3 months sine > 1.3.0. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17883) release 1.4.0
[ https://issues.apache.org/jira/browse/HBASE-17883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277929#comment-16277929 ] Andrew Purtell commented on HBASE-17883: I resolved HBASE-19429 by disabling checkstyle reporting in the site build, so, a workaround, not a fix. There's something off about Maven's behavior when executing the site target in general, but we do get a good binary build as a result. > release 1.4.0 > - > > Key: HBASE-17883 > URL: https://issues.apache.org/jira/browse/HBASE-17883 > Project: HBase > Issue Type: Task > Components: community >Affects Versions: 1.4.0 >Reporter: Sean Busbey >Assignee: Andrew Purtell >Priority: Critical > > Let's start working through doing the needful; it's been almost 3 months sine > 1.3.0. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (HBASE-19429) Release build fails in checkstyle phase of site target (branch-1)
[
https://issues.apache.org/jira/browse/HBASE-19429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell resolved HBASE-19429.
Resolution: Fixed
Pushed to branch-1.4 and branch-1
> Release build fails in checkstyle phase of site target (branch-1)
> -
>
> Key: HBASE-19429
> URL: https://issues.apache.org/jira/browse/HBASE-19429
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0
>
> Attachments: HBASE-19429-branch-1.patch
>
>
> Running these commands:
> {noformat}
> export MAVEN_OPTS="-Xmx4g -XX:MaxPermSize=256m"
> mvn clean org.codehaus.mojo:versions-maven-plugin:2.5:set -DnewVersion=1.4.0
> git clean -xdf
> mvn clean install -DskipTests -Prelease
> mvn install -DskipTests site assembly:single -Prelease
> {noformat}
> fails on that last Maven invocation in the checkstyle phase of the site
> target with
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project
> hbase-annotations: Error generating maven-checkstyle-plugin:2.17:checkstyle:
> Failed during checkstyle execution: Unable to process suppressions file
> location: hbase/checkstyle-suppressions.xml: Cannot create file-based
> resource:invalid block type
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
Chia-Ping Tsai created HBASE-19430: -- Summary: Remove the SettableTimestamp and SettableSequenceId Key: HBASE-19430 URL: https://issues.apache.org/jira/browse/HBASE-19430 Project: HBase Issue Type: Task Reporter: Chia-Ping Tsai They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP and denoted with deprecated. To my way of thinking, we should remove them before 2.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[ https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277923#comment-16277923 ] Chia-Ping Tsai commented on HBASE-19430: ping [~anoop.hbase] [~ram_krish] > Remove the SettableTimestamp and SettableSequenceId > --- > > Key: HBASE-19430 > URL: https://issues.apache.org/jira/browse/HBASE-19430 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai > > They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP > and denoted with deprecated. To my way of thinking, we should remove them > before 2.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19429) Release build fails in checkstyle phase of site target (branch-1)
[
https://issues.apache.org/jira/browse/HBASE-19429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277919#comment-16277919
]
Andrew Purtell commented on HBASE-19429:
Patch seems to work. Will commit to branch-1 and branch-1.4 if I get a
successful release build.
> Release build fails in checkstyle phase of site target (branch-1)
> -
>
> Key: HBASE-19429
> URL: https://issues.apache.org/jira/browse/HBASE-19429
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0
>
> Attachments: HBASE-19429-branch-1.patch
>
>
> Running these commands:
> {noformat}
> export MAVEN_OPTS="-Xmx4g -XX:MaxPermSize=256m"
> mvn clean org.codehaus.mojo:versions-maven-plugin:2.5:set -DnewVersion=1.4.0
> git clean -xdf
> mvn clean install -DskipTests -Prelease
> mvn install -DskipTests site assembly:single -Prelease
> {noformat}
> fails on that last Maven invocation in the checkstyle phase of the site
> target with
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project
> hbase-annotations: Error generating maven-checkstyle-plugin:2.17:checkstyle:
> Failed during checkstyle execution: Unable to process suppressions file
> location: hbase/checkstyle-suppressions.xml: Cannot create file-based
> resource:invalid block type
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (HBASE-19429) Release build fails in checkstyle phase of site target (branch-1)
[
https://issues.apache.org/jira/browse/HBASE-19429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell reassigned HBASE-19429:
--
Assignee: Andrew Purtell
> Release build fails in checkstyle phase of site target (branch-1)
> -
>
> Key: HBASE-19429
> URL: https://issues.apache.org/jira/browse/HBASE-19429
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0
>
> Attachments: HBASE-19429-branch-1.patch
>
>
> Running these commands:
> {noformat}
> export MAVEN_OPTS="-Xmx4g -XX:MaxPermSize=256m"
> mvn clean org.codehaus.mojo:versions-maven-plugin:2.5:set -DnewVersion=1.4.0
> git clean -xdf
> mvn clean install -DskipTests -Prelease
> mvn install -DskipTests site assembly:single -Prelease
> {noformat}
> fails on that last Maven invocation in the checkstyle phase of the site
> target with
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project
> hbase-annotations: Error generating maven-checkstyle-plugin:2.17:checkstyle:
> Failed during checkstyle execution: Unable to process suppressions file
> location: hbase/checkstyle-suppressions.xml: Cannot create file-based
> resource:invalid block type
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19429) Release build fails in checkstyle phase of site target (branch-1)
[
https://issues.apache.org/jira/browse/HBASE-19429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-19429:
---
Attachment: HBASE-19429-branch-1.patch
A patch I'm testing. Not sure it will work.
> Release build fails in checkstyle phase of site target (branch-1)
> -
>
> Key: HBASE-19429
> URL: https://issues.apache.org/jira/browse/HBASE-19429
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0
>
> Attachments: HBASE-19429-branch-1.patch
>
>
> Running these commands:
> {noformat}
> export MAVEN_OPTS="-Xmx4g -XX:MaxPermSize=256m"
> mvn clean org.codehaus.mojo:versions-maven-plugin:2.5:set -DnewVersion=1.4.0
> git clean -xdf
> mvn clean install -DskipTests -Prelease
> mvn install -DskipTests site assembly:single -Prelease
> {noformat}
> fails on that last Maven invocation in the checkstyle phase of the site
> target with
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project
> hbase-annotations: Error generating maven-checkstyle-plugin:2.17:checkstyle:
> Failed during checkstyle execution: Unable to process suppressions file
> location: hbase/checkstyle-suppressions.xml: Cannot create file-based
> resource:invalid block type
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19429) Release build fails in checkstyle phase of site target (branch-1)
[
https://issues.apache.org/jira/browse/HBASE-19429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277911#comment-16277911
]
Andrew Purtell commented on HBASE-19429:
That failure was on a MacOS dev box. I switched to Linux, and got this:
{noformat}
[INFO] <<< maven-javadoc-plugin:2.10.3:aggregate < generate-sources @
hbase-annotations <<<
[INFO] configuring report plugin
org.apache.maven.plugins:maven-checkstyle-plugin:2.17
[INFO] Parent project loaded from repository: org.apache:apache:pom:18
[INFO] Relativizing decoration links with respect to project URL:
http://hbase.apache.org/hbase-annotations
Downloading:
https://repository.apache.org/content/repositories/releases/org/apache/maven/skins/maven-default-skin/1.0/maven-default-skin-1.
Downloaded:
https://repository.apache.org/content/repositories/releases/org/apache/maven/skins/maven-default-skin/1.0/maven-default-skin-1.0
at 11.3 KB/sec)
[INFO] Rendering site with org.apache.maven.skins:maven-default-skin:jar:1.0
skin.
[INFO] Generating "Project Team" report ---
maven-project-info-reports-plugin:2.7:project-team
[INFO] Generating "Mailing Lists" report---
maven-project-info-reports-plugin:2.7:mailing-list
[INFO] Generating "Continuous Integration" report ---
maven-project-info-reports-plugin:2.7:cim
[INFO] Generating "Issue Tracking" report ---
maven-project-info-reports-plugin:2.7:issue-tracking
[INFO] Generating "Project License" report ---
maven-project-info-reports-plugin:2.7:license
[INFO] Generating "Source Repository" report---
maven-project-info-reports-plugin:2.7:scm
[INFO] Generating "About" report---
maven-project-info-reports-plugin:2.7:index
[INFO] Generating "Checkstyle" report ---
maven-checkstyle-plugin:2.17:checkstyle
#
# A fatal error has been detected by the Java Runtime Environment:
#
# SIGSEGV (0xb) at pc=0x7f2a3e51380b, pid=46318, tid=139819422721792
#
# JRE version: Java(TM) SE Runtime Environment (7.0_80-b15) (build 1.7.0_80-b15)
# Java VM: Java HotSpot(TM) 64-Bit Server VM (24.80-b11 mixed mode linux-amd64
compressed oops)
# Problematic frame:
# C [libc.so.6+0x8980b] memcpy+0x15b
#
# Failed to write core dump. Core dumps have been disabled. To enable core
dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /data/src/hbase/hs_err_pid46318.log
#
# If you would like to submit a bug report, please visit:
# http://bugreport.java.com/bugreport/crash.jsp
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#
Aborted
{noformat}
This is some kind of curse.
Let me put up a patch that turns off checkstyle reporting in the site build.
> Release build fails in checkstyle phase of site target (branch-1)
> -
>
> Key: HBASE-19429
> URL: https://issues.apache.org/jira/browse/HBASE-19429
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0
>
>
> Running these commands:
> {noformat}
> export MAVEN_OPTS="-Xmx4g -XX:MaxPermSize=256m"
> mvn clean org.codehaus.mojo:versions-maven-plugin:2.5:set -DnewVersion=1.4.0
> git clean -xdf
> mvn clean install -DskipTests -Prelease
> mvn install -DskipTests site assembly:single -Prelease
> {noformat}
> fails on that last Maven invocation in the checkstyle phase of the site
> target with
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project
> hbase-annotations: Error generating maven-checkstyle-plugin:2.17:checkstyle:
> Failed during checkstyle execution: Unable to process suppressions file
> location: hbase/checkstyle-suppressions.xml: Cannot create file-based
> resource:invalid block type
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19416) Document dynamic configurations currently support
[ https://issues.apache.org/jira/browse/HBASE-19416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277906#comment-16277906 ] Reid Chan commented on HBASE-19416: --- I will upload an addendum later. > Document dynamic configurations currently support > - > > Key: HBASE-19416 > URL: https://issues.apache.org/jira/browse/HBASE-19416 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19416.master.001.patch, > HBASE-19416.master.002.patch > > > More informative about dynamic configuration currently support -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-19420) Backport HBASE-19152 (Update refguide 'how to build an RC' and the make_rc.sh script) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-19420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277894#comment-16277894 ] Andrew Purtell edited comment on HBASE-19420 at 12/5/17 2:17 AM: - No, this is something else. Edit: See HBASE-19429 was (Author: apurtell): No, this is something else. > Backport HBASE-19152 (Update refguide 'how to build an RC' and the make_rc.sh > script) to branch-1 > - > > Key: HBASE-19420 > URL: https://issues.apache.org/jira/browse/HBASE-19420 > Project: HBase > Issue Type: Task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.1, 1.5.0 > > Attachments: HBASE-19420-branch-1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19429) Release build fails in checkstyle phase of site target (branch-1)
[
https://issues.apache.org/jira/browse/HBASE-19429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-19429:
---
Affects Version/s: 1.4.0
Priority: Blocker (was: Major)
Fix Version/s: 1.4.0
> Release build fails in checkstyle phase of site target (branch-1)
> -
>
> Key: HBASE-19429
> URL: https://issues.apache.org/jira/browse/HBASE-19429
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0
>
>
> Running these commands:
> {noformat}
> export MAVEN_OPTS="-Xmx4g -XX:MaxPermSize=256m"
> mvn clean org.codehaus.mojo:versions-maven-plugin:2.5:set -DnewVersion=1.4.0
> git clean -xdf
> mvn clean install -DskipTests -Prelease
> mvn install -DskipTests site assembly:single -Prelease
> {noformat}
> fails on that last Maven invocation in the checkstyle phase of the site
> target with
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project
> hbase-annotations: Error generating maven-checkstyle-plugin:2.17:checkstyle:
> Failed during checkstyle execution: Unable to process suppressions file
> location: hbase/checkstyle-suppressions.xml: Cannot create file-based
> resource:invalid block type
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19429) Release build fails in checkstyle phase of site target (branch-1)
[
https://issues.apache.org/jira/browse/HBASE-19429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277899#comment-16277899
]
Andrew Purtell commented on HBASE-19429:
Do we even need this? Can we turn this off? I've been sitting here watching a
release build in the checkstyle report phase of the site target chew on a
module for upwards of 5 minutes only to spit out a report with 20K warnings.
Later, this failure.
> Release build fails in checkstyle phase of site target (branch-1)
> -
>
> Key: HBASE-19429
> URL: https://issues.apache.org/jira/browse/HBASE-19429
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Andrew Purtell
> Fix For: 1.4.0
>
>
> Running these commands:
> {noformat}
> export MAVEN_OPTS="-Xmx4g -XX:MaxPermSize=256m"
> mvn clean org.codehaus.mojo:versions-maven-plugin:2.5:set -DnewVersion=1.4.0
> git clean -xdf
> mvn clean install -DskipTests -Prelease
> mvn install -DskipTests site assembly:single -Prelease
> {noformat}
> fails on that last Maven invocation in the checkstyle phase of the site
> target with
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project
> hbase-annotations: Error generating maven-checkstyle-plugin:2.17:checkstyle:
> Failed during checkstyle execution: Unable to process suppressions file
> location: hbase/checkstyle-suppressions.xml: Cannot create file-based
> resource:invalid block type
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17883) release 1.4.0
[ https://issues.apache.org/jira/browse/HBASE-17883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277900#comment-16277900 ] Andrew Purtell commented on HBASE-17883: Blocked on HBASE-19429 > release 1.4.0 > - > > Key: HBASE-17883 > URL: https://issues.apache.org/jira/browse/HBASE-17883 > Project: HBase > Issue Type: Task > Components: community >Affects Versions: 1.4.0 >Reporter: Sean Busbey >Assignee: Andrew Purtell >Priority: Critical > > Let's start working through doing the needful; it's been almost 3 months sine > 1.3.0. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19429) Release build fails in checkstyle phase of site target (branch-1)
Andrew Purtell created HBASE-19429:
--
Summary: Release build fails in checkstyle phase of site target
(branch-1)
Key: HBASE-19429
URL: https://issues.apache.org/jira/browse/HBASE-19429
Project: HBase
Issue Type: Bug
Reporter: Andrew Purtell
Running these commands:
{noformat}
export MAVEN_OPTS="-Xmx4g -XX:MaxPermSize=256m"
mvn clean org.codehaus.mojo:versions-maven-plugin:2.5:set -DnewVersion=1.4.0
git clean -xdf
mvn clean install -DskipTests -Prelease
mvn install -DskipTests site assembly:single -Prelease
{noformat}
fails on that last Maven invocation in the checkstyle phase of the site target
with
{noformat}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project
hbase-annotations: Error generating maven-checkstyle-plugin:2.17:checkstyle:
Failed during checkstyle execution: Unable to process suppressions file
location: hbase/checkstyle-suppressions.xml: Cannot create file-based
resource:invalid block type
{noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19421) branch-1 does not compile against Hadoop 3.0.0
[
https://issues.apache.org/jira/browse/HBASE-19421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-19421:
---
Resolution: Fixed
Fix Version/s: (was: 1.5.0)
(was: 1.4.1)
1.4.0
Status: Resolved (was: Patch Available)
Pushed to branch-1 and branch-1.4.
> branch-1 does not compile against Hadoop 3.0.0
> --
>
> Key: HBASE-19421
> URL: https://issues.apache.org/jira/browse/HBASE-19421
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 1.4.0
>
> Attachments: HBASE-19421-branch-1.patch
>
>
> Tested with {{mvn clean install -Dhadoop.profile=3.0
> -Dhadoop-three.version=3.0.0-alpha4}}
> {noformat}
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[37,32]
> package org.apache.hadoop.mapred does not exist
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[38,35]
> package org.apache.hadoop.mapreduce does not exist
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[117,66]
> cannot find symbol
> [ERROR] symbol: class Job
> [ERROR] location: class org.apache.hadoop.hbase.security.User
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[129,46]
> cannot find symbol
> [ERROR] symbol: class JobConf
> [ERROR] location: class org.apache.hadoop.hbase.security.User
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[344,59]
> cannot find symbol
> [ERROR] symbol: class Job
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[369,39]
> cannot find symbol
> [ERROR] symbol: class JobConf
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[351,17]
> cannot find symbol
> [ERROR] symbol: class Job
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[375,25]
> cannot find symbol
> [ERROR] symbol: class JobConf
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19426) Move has() and setTimestamp() to Mutation
[ https://issues.apache.org/jira/browse/HBASE-19426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19426: --- Component/s: Client > Move has() and setTimestamp() to Mutation > - > > Key: HBASE-19426 > URL: https://issues.apache.org/jira/browse/HBASE-19426 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-beta-1 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19420) Backport HBASE-19152 (Update refguide 'how to build an RC' and the make_rc.sh script) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-19420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277894#comment-16277894 ] Andrew Purtell commented on HBASE-19420: No, this is something else. > Backport HBASE-19152 (Update refguide 'how to build an RC' and the make_rc.sh > script) to branch-1 > - > > Key: HBASE-19420 > URL: https://issues.apache.org/jira/browse/HBASE-19420 > Project: HBase > Issue Type: Task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.1, 1.5.0 > > Attachments: HBASE-19420-branch-1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19428) Deprecate the compareTo(Row)
Chia-Ping Tsai created HBASE-19428: -- Summary: Deprecate the compareTo(Row) Key: HBASE-19428 URL: https://issues.apache.org/jira/browse/HBASE-19428 Project: HBase Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai Sorting the Put/Delete/Increment/Append by row is weird and not straightforward. We should explicitly have a Row sorter and deprecate the compareTo(Row) in Put/Delete/Increment/Append. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19420) Backport HBASE-19152 (Update refguide 'how to build an RC' and the make_rc.sh script) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-19420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19420: --- Fix Version/s: (was: 1.4.0) 1.5.0 1.4.1 > Backport HBASE-19152 (Update refguide 'how to build an RC' and the make_rc.sh > script) to branch-1 > - > > Key: HBASE-19420 > URL: https://issues.apache.org/jira/browse/HBASE-19420 > Project: HBase > Issue Type: Task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.1, 1.5.0 > > Attachments: HBASE-19420-branch-1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19419) Remove hbase-native-client from branch-1
[ https://issues.apache.org/jira/browse/HBASE-19419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277884#comment-16277884 ] Hudson commented on HBASE-19419: FAILURE: Integrated in Jenkins build HBase-1.4 #1049 (See [https://builds.apache.org/job/HBase-1.4/1049/]) HBASE-19419 Remove hbase-native-client from branch-1 (apurtell: rev cfa4cbe769663110cb23131ac530c44185911eef) * (delete) hbase-native-client/src/async/hbase_errno.h * (delete) hbase-native-client/CMakeLists.txt * (delete) hbase-native-client/src/sync/hbase_connection.cc * (delete) hbase-native-client/src/async/hbase_result.cc * (delete) hbase-native-client/src/async/hbase_client.cc * (delete) hbase-native-client/src/core/hbase_types.h * (delete) hbase-native-client/src/core/connection_attr.h * (delete) hbase-native-client/src/core/delete.h * (delete) hbase-native-client/src/sync/hbase_admin.cc * (delete) hbase-native-client/src/core/put.cc * (delete) hbase-native-client/src/core/put.h * (delete) hbase-native-client/src/core/mutation.cc * (delete) hbase-native-client/src/async/hbase_scanner.cc * (delete) hbase-native-client/src/async/hbase_get.h * (delete) hbase-native-client/src/core/client.h * (delete) hbase-native-client/src/sync/hbase_admin.h * (delete) hbase-native-client/src/core/admin.cc * (delete) hbase-native-client/src/core/connection.h * (delete) hbase-native-client/src/core/scanner.h * (delete) hbase-native-client/src/core/delete.cc * (delete) hbase-native-client/src/core/hbase_connection_attr.cc * (delete) hbase-native-client/src/core/get.h * (delete) hbase-native-client/bin/build-thirdparty.sh * (delete) hbase-native-client/src/async/mutations-test.cc * (delete) hbase-native-client/src/async/hbase_scanner.h * (delete) hbase-native-client/src/core/client.cc * (delete) hbase-native-client/src/core/mutation.h * (delete) hbase-native-client/src/core/hbase_connection_attr.h * (delete) hbase-native-client/src/core/scanner.cc * (delete) hbase-native-client/src/async/CMakeLists.txt * (delete) hbase-native-client/src/sync/CMakeLists.txt * (delete) hbase-native-client/src/async/hbase_mutations.h * (delete) hbase-native-client/src/async/get-test.cc * (delete) hbase-native-client/bin/download-thirdparty.sh * (delete) hbase-native-client/src/async/hbase_get.cc * (delete) hbase-native-client/src/async/hbase_admin.cc * (delete) hbase-native-client/bin/build-all.sh * (delete) hbase-native-client/src/core/connection.cc * (delete) hbase-native-client/src/core/get.cc * (delete) hbase-native-client/bin/hbase-client-env.sh * (delete) hbase-native-client/src/core/hbase_macros.h * (delete) hbase-native-client/src/async/hbase_admin.h * (delete) hbase-native-client/src/async/hbase_result.h * (delete) hbase-native-client/cmake_modules/FindGTest.cmake * (delete) hbase-native-client/src/core/CMakeLists.txt * (delete) hbase-native-client/.gitignore * (delete) hbase-native-client/README.md * (delete) hbase-native-client/src/async/hbase_connection.cc * (delete) hbase-native-client/src/async/hbase_connection.h * (delete) hbase-native-client/src/sync/hbase_connection.h * (delete) hbase-native-client/src/core/admin.h * (delete) hbase-native-client/src/async/hbase_client.h * (delete) hbase-native-client/src/async/hbase_mutations.cc * (delete) hbase-native-client/cmake_modules/FindLibEv.cmake * (delete) hbase-native-client/src/rpc/CMakeLists.txt > Remove hbase-native-client from branch-1 > > > Key: HBASE-19419 > URL: https://issues.apache.org/jira/browse/HBASE-19419 > Project: HBase > Issue Type: Task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0 > > Attachments: HBASE-19419-branch-1.patch > > > We have an hbase-native-client subdirectory in the source tree that isn't > hooked up to the Maven build. It hasn't been updated in two years. (Last > update Fri Jul 31 11:22:50 2015 -0700.) I propose to remove it from our > source distribution. It can be moved to GitHub as a separate project. > Dropping it doesn't represent a compatibility problem as it isn't hooked up > to the build and seems unlikely anyone is depending on it given we haven't > had a single change nor issue reported against it for two years. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18942) hbase-hadoop2-compat module ignores hadoop-3 profile
[
https://issues.apache.org/jira/browse/HBASE-18942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277882#comment-16277882
]
Hudson commented on HBASE-18942:
FAILURE: Integrated in Jenkins build HBase-1.4 #1049 (See
[https://builds.apache.org/job/HBase-1.4/1049/])
HBASE-18942 hbase-hadoop2-compat module ignores hadoop-3 profile (apurtell: rev
9c8c0e08a66ced7dffb232facc51079e1de8a722)
* (edit) hbase-hadoop2-compat/pom.xml
> hbase-hadoop2-compat module ignores hadoop-3 profile
>
>
> Key: HBASE-18942
> URL: https://issues.apache.org/jira/browse/HBASE-18942
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Appy
> Labels: build
> Fix For: 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-18942.master.001.patch
>
>
> In hbase-hadoop2-compat/pom.xml :
> {code}
>
> org.apache.hadoop
> hadoop-common
> ${hadoop-two.version}
>
> {code}
> The version for hadoop-common defaults to hadoop-two.
> This means that when hadoop-3.0 profile is used, hadoop-three.version would
> be ignored.
> The following error would be observed:
> {code}
> Caused by: java.util.ServiceConfigurationError:
> org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSource: Provider
> org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSourceImpl could not be
> instantiated
> at java.util.ServiceLoader.fail(ServiceLoader.java:232)
> at java.util.ServiceLoader.access$100(ServiceLoader.java:185)
> at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:384)
> at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404)
> at java.util.ServiceLoader$1.next(ServiceLoader.java:480)
> at
> org.apache.hadoop.hbase.CompatibilitySingletonFactory.getInstance(CompatibilitySingletonFactory.java:59)
> ... 34 more
> Caused by: java.lang.NoClassDefFoundError: Could not initialize class
> com.sun.proxy.$Proxy17
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at java.lang.reflect.Proxy.newProxyInstance(Proxy.java:739)
> at
> org.apache.commons.configuration2.builder.fluent.Parameters.createParametersProxy(Parameters.java:294)
> at
> org.apache.commons.configuration2.builder.fluent.Parameters.fileBased(Parameters.java:185)
> at
> org.apache.commons.configuration2.builder.fluent.Configurations.fileParams(Configurations.java:602)
> at
> org.apache.commons.configuration2.builder.fluent.Configurations.fileParams(Configurations.java:638)
> at
> org.apache.commons.configuration2.builder.fluent.Configurations.fileBasedBuilder(Configurations.java:164)
> at
> org.apache.commons.configuration2.builder.fluent.Configurations.propertiesBuilder(Configurations.java:264)
> at
> org.apache.hadoop.metrics2.impl.MetricsConfig.loadFirst(MetricsConfig.java:115)
> at
> org.apache.hadoop.metrics2.impl.MetricsConfig.create(MetricsConfig.java:98)
> at
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configure(MetricsSystemImpl.java:478)
> at
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:188)
> at
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.init(MetricsSystemImpl.java:163)
> at
> org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.init(DefaultMetricsSystem.java:62)
> at
> org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.initialize(DefaultMetricsSystem.java:58)
> at
> org.apache.hadoop.hbase.metrics.BaseSourceImpl$DefaultMetricsSystemInitializer.init(BaseSourceImpl.java:51)
> at
> org.apache.hadoop.hbase.metrics.BaseSourceImpl.(BaseSourceImpl.java:112)
> at
> org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSourceImpl.(MetricsZooKeeperSourceImpl.java:56)
> at
> org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSourceImpl.(MetricsZooKeeperSourceImpl.java:51)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19420) Backport HBASE-19152 (Update refguide 'how to build an RC' and the make_rc.sh script) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-19420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277881#comment-16277881 ] Andrew Purtell commented on HBASE-19420: [~mdrob] [~stack] > Backport HBASE-19152 (Update refguide 'how to build an RC' and the make_rc.sh > script) to branch-1 > - > > Key: HBASE-19420 > URL: https://issues.apache.org/jira/browse/HBASE-19420 > Project: HBase > Issue Type: Task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0 > > Attachments: HBASE-19420-branch-1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19420) Backport HBASE-19152 (Update refguide 'how to build an RC' and the make_rc.sh script) to branch-1
[
https://issues.apache.org/jira/browse/HBASE-19420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277880#comment-16277880
]
Andrew Purtell commented on HBASE-19420:
This doesn't work with branch-1, at least not on my build host:
{noformat}
[INFO] Apache HBase ... SUCCESS [06:46 min]
[INFO] Apache HBase - Checkstyle .. SUCCESS [ 1.312 s]
[INFO] Apache HBase - Resource Bundle . SUCCESS [ 0.944 s]
[INFO] Apache HBase - Annotations . FAILURE [ 42.043 s]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project
hbase-annotations: Error generating maven-checkstyle-plugin:2.17:checkstyle:
Failed during checkstyle execution: Unable to find configuration file at
location: hbase/checkstyle.xml: Could not find resource 'hbase/checkstyle.xml'.
{noformat}
I typically make releases by hand, so let me check if there's something wrong
generally or just with the exact incantations that make_rc.sh uses.
> Backport HBASE-19152 (Update refguide 'how to build an RC' and the make_rc.sh
> script) to branch-1
> -
>
> Key: HBASE-19420
> URL: https://issues.apache.org/jira/browse/HBASE-19420
> Project: HBase
> Issue Type: Task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 1.4.0
>
> Attachments: HBASE-19420-branch-1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-19427) Add TimeRange to Append
Chia-Ping Tsai created HBASE-19427: -- Summary: Add TimeRange to Append Key: HBASE-19427 URL: https://issues.apache.org/jira/browse/HBASE-19427 Project: HBase Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai The time range in Increment is used to optimize the Get operation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19426) Move has() and setTimestamp() to Mutation
Chia-Ping Tsai created HBASE-19426: -- Summary: Move has() and setTimestamp() to Mutation Key: HBASE-19426 URL: https://issues.apache.org/jira/browse/HBASE-19426 Project: HBase Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai Fix For: 2.0.0-beta-1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19425) Align the methods in Put/Delete/Increment/Append
Chia-Ping Tsai created HBASE-19425: -- Summary: Align the methods in Put/Delete/Increment/Append Key: HBASE-19425 URL: https://issues.apache.org/jira/browse/HBASE-19425 Project: HBase Issue Type: Umbrella Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai Fix For: 2.0.0 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-19424) Metrics servlet doesn't work
[
https://issues.apache.org/jira/browse/HBASE-19424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277843#comment-16277843
]
Appy edited comment on HBASE-19424 at 12/5/17 1:10 AM:
---
Digging around, we should probably set CONF_CONTEXT_ATTRIBUTE attribute in our
[HttpServer
here|https://github.com/apache/hbase/blob/master/hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java#L590]
like [hadoop
does|https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java#L620].
That's because, isInstrumentationAccessAllowed(...) looks for it, and when it
returns nothing, conf becomes null and throws NullPointerException.
{noformat}
Configuration conf =
(Configuration) servletContext.getAttribute(CONF_CONTEXT_ATTRIBUTE);
boolean access = true;
boolean adminAccess = conf.getBoolean(
CommonConfigurationKeys.HADOOP_SECURITY_INSTRUMENTATION_REQUIRES_ADMIN,
false);
if (adminAccess) {
access = hasAdministratorAccess(servletContext, request, response);
}
{noformat}
Edit: Oops, we are doing that already. Missed it.
was (Author: appy):
Digging around, we should probably set CONF_CONTEXT_ATTRIBUTE attribute in our
[HttpServer
here|https://github.com/apache/hbase/blob/master/hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java#L590]
like [hadoop
does|https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java#L620].
That's because, isInstrumentationAccessAllowed(...) looks for it, and when it
returns nothing, conf becomes null and throws NullPointerException.
{noformat}
Configuration conf =
(Configuration) servletContext.getAttribute(CONF_CONTEXT_ATTRIBUTE);
boolean access = true;
boolean adminAccess = conf.getBoolean(
CommonConfigurationKeys.HADOOP_SECURITY_INSTRUMENTATION_REQUIRES_ADMIN,
false);
if (adminAccess) {
access = hasAdministratorAccess(servletContext, request, response);
}
{noformat}
> Metrics servlet doesn't work
>
>
> Key: HBASE-19424
> URL: https://issues.apache.org/jira/browse/HBASE-19424
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Andrew Purtell
>Priority: Minor
> Fix For: 1.4.1, 1.5.0
>
>
> In branch-1 at least we put up a servlet on "/metrics" that is Hadoop's
> MetricsServlet. However HBase users are expected to pick up metrics via
> "/jmx". We don't mention "/metrics" or link to it on the UI. If you attempt
> to access "/metrics" with head of branch-1 it errors out due to a NPE
> {noformat}
> 2017-12-04 16:06:37,403 ERROR [1874557409@qtp-1910896157-3] mortbay.log:
> /metrics
> java.lang.NullPointerException
> at
> org.apache.hadoop.http.HttpServer2.isInstrumentationAccessAllowed(HttpServer2.java:1049)
> at
> org.apache.hadoop.metrics.MetricsServlet.doGet(MetricsServlet.java:109)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19424) Metrics servlet doesn't work
[
https://issues.apache.org/jira/browse/HBASE-19424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277843#comment-16277843
]
Appy commented on HBASE-19424:
--
Digging around, we should probably set CONF_CONTEXT_ATTRIBUTE attribute in our
[HttpServer
here|https://github.com/apache/hbase/blob/master/hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java#L590]
like [hadoop
does|https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java#L620].
That's because, isInstrumentationAccessAllowed(...) looks for it, and when it
returns nothing, conf becomes null and throws NullPointerException.
{noformat}
Configuration conf =
(Configuration) servletContext.getAttribute(CONF_CONTEXT_ATTRIBUTE);
boolean access = true;
boolean adminAccess = conf.getBoolean(
CommonConfigurationKeys.HADOOP_SECURITY_INSTRUMENTATION_REQUIRES_ADMIN,
false);
if (adminAccess) {
access = hasAdministratorAccess(servletContext, request, response);
}
{noformat}
> Metrics servlet doesn't work
>
>
> Key: HBASE-19424
> URL: https://issues.apache.org/jira/browse/HBASE-19424
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Andrew Purtell
>Priority: Minor
> Fix For: 1.4.1, 1.5.0
>
>
> In branch-1 at least we put up a servlet on "/metrics" that is Hadoop's
> MetricsServlet. However HBase users are expected to pick up metrics via
> "/jmx". We don't mention "/metrics" or link to it on the UI. If you attempt
> to access "/metrics" with head of branch-1 it errors out due to a NPE
> {noformat}
> 2017-12-04 16:06:37,403 ERROR [1874557409@qtp-1910896157-3] mortbay.log:
> /metrics
> java.lang.NullPointerException
> at
> org.apache.hadoop.http.HttpServer2.isInstrumentationAccessAllowed(HttpServer2.java:1049)
> at
> org.apache.hadoop.metrics.MetricsServlet.doGet(MetricsServlet.java:109)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18942) hbase-hadoop2-compat module ignores hadoop-3 profile
[
https://issues.apache.org/jira/browse/HBASE-18942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277816#comment-16277816
]
Hadoop QA commented on HBASE-18942:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 12m
27s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
59s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
70m 4s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
27s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 89m 48s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18942 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12900573/HBASE-18942.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit shadedjars hadoopcheck
xml compile |
| uname | Linux 49f03e702427 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 4c567b3c12 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10219/testReport/ |
| modules | C: hbase-hadoop2-compat U: hbase-hadoop2-compat |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10219/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> hbase-hadoop2-compat module ignores hadoop-3 profile
>
>
> Key: HBASE-18942
> URL: https://issues.apache.org/jira/browse/HBASE-18942
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Appy
> Labels: build
> Fix For: 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-18942.master.001.patch
>
>
> In
[jira] [Commented] (HBASE-19420) Backport HBASE-19152 (Update refguide 'how to build an RC' and the make_rc.sh script) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-19420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277809#comment-16277809 ] Andrew Purtell commented on HBASE-19420: Testing this now > Backport HBASE-19152 (Update refguide 'how to build an RC' and the make_rc.sh > script) to branch-1 > - > > Key: HBASE-19420 > URL: https://issues.apache.org/jira/browse/HBASE-19420 > Project: HBase > Issue Type: Task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0 > > Attachments: HBASE-19420-branch-1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19423) Replication entries are not filtered correctly when replication scope is set through WAL Co-processor
[
https://issues.apache.org/jira/browse/HBASE-19423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277804#comment-16277804
]
Hadoop QA commented on HBASE-19423:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1.3 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
56s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
34s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_161 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
44s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
58s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
32s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
17s{color} | {color:red} hbase-server: The patch generated 1 new + 6 unchanged
- 0 fixed = 7 total (was 6) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
25s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
27m 4s{color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3.
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 81m 56s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}127m 15s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestEndToEndSplitTransaction |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:dca6535 |
| JIRA Issue | HBASE-19423 |
| JIRA Patch URL |
[jira] [Comment Edited] (HBASE-19421) branch-1 does not compile against Hadoop 3.0.0
[
https://issues.apache.org/jira/browse/HBASE-19421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277794#comment-16277794
]
Andrew Purtell edited comment on HBASE-19421 at 12/5/17 12:12 AM:
--
I checked that we still put up a servlet at "/metrics" after this change. We
do. However I'll note we don't link to it or mention it. HBase users are
expected to pick up metrics via "/jmx". Access to "/metrics" also 500s with or
without this change. I will file another issue to follow up on that.
Edit: That is HBASE-19424
was (Author: apurtell):
I checked that we still put up a servlet at "/metrics" after this change. We
do. However I'll note we don't link to it or mention it. HBase users are
expected to pick up metrics via "/jmx". Access to "/metrics" also 500s with or
without this change. I will file another issue to follow up on that.
> branch-1 does not compile against Hadoop 3.0.0
> --
>
> Key: HBASE-19421
> URL: https://issues.apache.org/jira/browse/HBASE-19421
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 1.4.1, 1.5.0
>
> Attachments: HBASE-19421-branch-1.patch
>
>
> Tested with {{mvn clean install -Dhadoop.profile=3.0
> -Dhadoop-three.version=3.0.0-alpha4}}
> {noformat}
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[37,32]
> package org.apache.hadoop.mapred does not exist
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[38,35]
> package org.apache.hadoop.mapreduce does not exist
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[117,66]
> cannot find symbol
> [ERROR] symbol: class Job
> [ERROR] location: class org.apache.hadoop.hbase.security.User
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[129,46]
> cannot find symbol
> [ERROR] symbol: class JobConf
> [ERROR] location: class org.apache.hadoop.hbase.security.User
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[344,59]
> cannot find symbol
> [ERROR] symbol: class Job
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[369,39]
> cannot find symbol
> [ERROR] symbol: class JobConf
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[351,17]
> cannot find symbol
> [ERROR] symbol: class Job
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[375,25]
> cannot find symbol
> [ERROR] symbol: class JobConf
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19424) Metrics servlet doesn't work
[
https://issues.apache.org/jira/browse/HBASE-19424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-19424:
---
Description:
In branch-1 at least we put up a servlet on "/metrics" that is Hadoop's
MetricsServlet. However HBase users are expected to pick up metrics via "/jmx".
We don't mention "/metrics" or link to it on the UI. If you attempt to access
"/metrics" with head of branch-1 it errors out due to a NPE
{noformat}
2017-12-04 16:06:37,403 ERROR [1874557409@qtp-1910896157-3] mortbay.log:
/metrics
java.lang.NullPointerException
at
org.apache.hadoop.http.HttpServer2.isInstrumentationAccessAllowed(HttpServer2.java:1049)
at
org.apache.hadoop.metrics.MetricsServlet.doGet(MetricsServlet.java:109)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
{noformat}
was:
In branch-1 and least we put up a servlet on "/metrics" that is Hadoop's
MetricsServlet. However HBase users are expected to pick up metrics via "/jmx".
We don't mention "/metrics" or link to it on the UI. If you attempt to access
"/metrics" with head of branch-1 it errors out due to a NPE
{noformat}
2017-12-04 16:06:37,403 ERROR [1874557409@qtp-1910896157-3] mortbay.log:
/metrics
java.lang.NullPointerException
at
org.apache.hadoop.http.HttpServer2.isInstrumentationAccessAllowed(HttpServer2.java:1049)
at
org.apache.hadoop.metrics.MetricsServlet.doGet(MetricsServlet.java:109)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
{noformat}
> Metrics servlet doesn't work
>
>
> Key: HBASE-19424
> URL: https://issues.apache.org/jira/browse/HBASE-19424
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Andrew Purtell
>Priority: Minor
> Fix For: 1.4.1, 1.5.0
>
>
> In branch-1 at least we put up a servlet on "/metrics" that is Hadoop's
> MetricsServlet. However HBase users are expected to pick up metrics via
> "/jmx". We don't mention "/metrics" or link to it on the UI. If you attempt
> to access "/metrics" with head of branch-1 it errors out due to a NPE
> {noformat}
> 2017-12-04 16:06:37,403 ERROR [1874557409@qtp-1910896157-3] mortbay.log:
> /metrics
> java.lang.NullPointerException
> at
> org.apache.hadoop.http.HttpServer2.isInstrumentationAccessAllowed(HttpServer2.java:1049)
> at
> org.apache.hadoop.metrics.MetricsServlet.doGet(MetricsServlet.java:109)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-19424) Metrics servlet doesn't work
Andrew Purtell created HBASE-19424:
--
Summary: Metrics servlet doesn't work
Key: HBASE-19424
URL: https://issues.apache.org/jira/browse/HBASE-19424
Project: HBase
Issue Type: Bug
Affects Versions: 1.4.0
Reporter: Andrew Purtell
Priority: Minor
Fix For: 1.4.1, 1.5.0
In branch-1 and least we put up a servlet on "/metrics" that is Hadoop's
MetricsServlet. However HBase users are expected to pick up metrics via "/jmx".
We don't mention "/metrics" or link to it on the UI. If you attempt to access
"/metrics" with head of branch-1 it errors out due to a NPE
{noformat}
2017-12-04 16:06:37,403 ERROR [1874557409@qtp-1910896157-3] mortbay.log:
/metrics
java.lang.NullPointerException
at
org.apache.hadoop.http.HttpServer2.isInstrumentationAccessAllowed(HttpServer2.java:1049)
at
org.apache.hadoop.metrics.MetricsServlet.doGet(MetricsServlet.java:109)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
{noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19421) branch-1 does not compile against Hadoop 3.0.0
[
https://issues.apache.org/jira/browse/HBASE-19421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277794#comment-16277794
]
Andrew Purtell commented on HBASE-19421:
I checked that we still put up a servlet at "/metrics" after this change. We
do. However I'll note we don't link to it or mention it. HBase users are
expected to pick up metrics via "/jmx". Access to "/metrics" also 500s with or
without this change. I will file another issue to follow up on that.
> branch-1 does not compile against Hadoop 3.0.0
> --
>
> Key: HBASE-19421
> URL: https://issues.apache.org/jira/browse/HBASE-19421
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 1.4.1, 1.5.0
>
> Attachments: HBASE-19421-branch-1.patch
>
>
> Tested with {{mvn clean install -Dhadoop.profile=3.0
> -Dhadoop-three.version=3.0.0-alpha4}}
> {noformat}
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[37,32]
> package org.apache.hadoop.mapred does not exist
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[38,35]
> package org.apache.hadoop.mapreduce does not exist
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[117,66]
> cannot find symbol
> [ERROR] symbol: class Job
> [ERROR] location: class org.apache.hadoop.hbase.security.User
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[129,46]
> cannot find symbol
> [ERROR] symbol: class JobConf
> [ERROR] location: class org.apache.hadoop.hbase.security.User
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[344,59]
> cannot find symbol
> [ERROR] symbol: class Job
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[369,39]
> cannot find symbol
> [ERROR] symbol: class JobConf
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[351,17]
> cannot find symbol
> [ERROR] symbol: class Job
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[375,25]
> cannot find symbol
> [ERROR] symbol: class JobConf
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18942) hbase-hadoop2-compat module ignores hadoop-3 profile
[
https://issues.apache.org/jira/browse/HBASE-18942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277790#comment-16277790
]
Andrew Purtell commented on HBASE-18942:
Yep, struggling to get something out the door on time
> hbase-hadoop2-compat module ignores hadoop-3 profile
>
>
> Key: HBASE-18942
> URL: https://issues.apache.org/jira/browse/HBASE-18942
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Appy
> Labels: build
> Fix For: 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-18942.master.001.patch
>
>
> In hbase-hadoop2-compat/pom.xml :
> {code}
>
> org.apache.hadoop
> hadoop-common
> ${hadoop-two.version}
>
> {code}
> The version for hadoop-common defaults to hadoop-two.
> This means that when hadoop-3.0 profile is used, hadoop-three.version would
> be ignored.
> The following error would be observed:
> {code}
> Caused by: java.util.ServiceConfigurationError:
> org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSource: Provider
> org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSourceImpl could not be
> instantiated
> at java.util.ServiceLoader.fail(ServiceLoader.java:232)
> at java.util.ServiceLoader.access$100(ServiceLoader.java:185)
> at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:384)
> at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404)
> at java.util.ServiceLoader$1.next(ServiceLoader.java:480)
> at
> org.apache.hadoop.hbase.CompatibilitySingletonFactory.getInstance(CompatibilitySingletonFactory.java:59)
> ... 34 more
> Caused by: java.lang.NoClassDefFoundError: Could not initialize class
> com.sun.proxy.$Proxy17
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at java.lang.reflect.Proxy.newProxyInstance(Proxy.java:739)
> at
> org.apache.commons.configuration2.builder.fluent.Parameters.createParametersProxy(Parameters.java:294)
> at
> org.apache.commons.configuration2.builder.fluent.Parameters.fileBased(Parameters.java:185)
> at
> org.apache.commons.configuration2.builder.fluent.Configurations.fileParams(Configurations.java:602)
> at
> org.apache.commons.configuration2.builder.fluent.Configurations.fileParams(Configurations.java:638)
> at
> org.apache.commons.configuration2.builder.fluent.Configurations.fileBasedBuilder(Configurations.java:164)
> at
> org.apache.commons.configuration2.builder.fluent.Configurations.propertiesBuilder(Configurations.java:264)
> at
> org.apache.hadoop.metrics2.impl.MetricsConfig.loadFirst(MetricsConfig.java:115)
> at
> org.apache.hadoop.metrics2.impl.MetricsConfig.create(MetricsConfig.java:98)
> at
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configure(MetricsSystemImpl.java:478)
> at
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:188)
> at
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.init(MetricsSystemImpl.java:163)
> at
> org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.init(DefaultMetricsSystem.java:62)
> at
> org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.initialize(DefaultMetricsSystem.java:58)
> at
> org.apache.hadoop.hbase.metrics.BaseSourceImpl$DefaultMetricsSystemInitializer.init(BaseSourceImpl.java:51)
> at
> org.apache.hadoop.hbase.metrics.BaseSourceImpl.(BaseSourceImpl.java:112)
> at
> org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSourceImpl.(MetricsZooKeeperSourceImpl.java:56)
> at
> org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSourceImpl.(MetricsZooKeeperSourceImpl.java:51)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19420) Backport HBASE-19152 (Update refguide 'how to build an RC' and the make_rc.sh script) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-19420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277785#comment-16277785 ] Andrew Purtell commented on HBASE-19420: bq. Updated patch drops claim of build support for Hadoop 3. (See HBASE-19421) Removed the updated patch, leaving the original in place, because HBASE-19421 is fixed, at least in the sense that we can compile against Hadoop 3. > Backport HBASE-19152 (Update refguide 'how to build an RC' and the make_rc.sh > script) to branch-1 > - > > Key: HBASE-19420 > URL: https://issues.apache.org/jira/browse/HBASE-19420 > Project: HBase > Issue Type: Task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0 > > Attachments: HBASE-19420-branch-1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18942) hbase-hadoop2-compat module ignores hadoop-3 profile
[
https://issues.apache.org/jira/browse/HBASE-18942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277786#comment-16277786
]
Appy commented on HBASE-18942:
--
Oh, was waiting for https://builds.apache.org/job/PreCommit-HBASE-Build/10219
to complete, but i guess you needed it to make progress for 1.4 release.
Can verify hadoop3 compile check posthoc.
> hbase-hadoop2-compat module ignores hadoop-3 profile
>
>
> Key: HBASE-18942
> URL: https://issues.apache.org/jira/browse/HBASE-18942
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Appy
> Labels: build
> Fix For: 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-18942.master.001.patch
>
>
> In hbase-hadoop2-compat/pom.xml :
> {code}
>
> org.apache.hadoop
> hadoop-common
> ${hadoop-two.version}
>
> {code}
> The version for hadoop-common defaults to hadoop-two.
> This means that when hadoop-3.0 profile is used, hadoop-three.version would
> be ignored.
> The following error would be observed:
> {code}
> Caused by: java.util.ServiceConfigurationError:
> org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSource: Provider
> org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSourceImpl could not be
> instantiated
> at java.util.ServiceLoader.fail(ServiceLoader.java:232)
> at java.util.ServiceLoader.access$100(ServiceLoader.java:185)
> at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:384)
> at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404)
> at java.util.ServiceLoader$1.next(ServiceLoader.java:480)
> at
> org.apache.hadoop.hbase.CompatibilitySingletonFactory.getInstance(CompatibilitySingletonFactory.java:59)
> ... 34 more
> Caused by: java.lang.NoClassDefFoundError: Could not initialize class
> com.sun.proxy.$Proxy17
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at java.lang.reflect.Proxy.newProxyInstance(Proxy.java:739)
> at
> org.apache.commons.configuration2.builder.fluent.Parameters.createParametersProxy(Parameters.java:294)
> at
> org.apache.commons.configuration2.builder.fluent.Parameters.fileBased(Parameters.java:185)
> at
> org.apache.commons.configuration2.builder.fluent.Configurations.fileParams(Configurations.java:602)
> at
> org.apache.commons.configuration2.builder.fluent.Configurations.fileParams(Configurations.java:638)
> at
> org.apache.commons.configuration2.builder.fluent.Configurations.fileBasedBuilder(Configurations.java:164)
> at
> org.apache.commons.configuration2.builder.fluent.Configurations.propertiesBuilder(Configurations.java:264)
> at
> org.apache.hadoop.metrics2.impl.MetricsConfig.loadFirst(MetricsConfig.java:115)
> at
> org.apache.hadoop.metrics2.impl.MetricsConfig.create(MetricsConfig.java:98)
> at
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configure(MetricsSystemImpl.java:478)
> at
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:188)
> at
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.init(MetricsSystemImpl.java:163)
> at
> org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.init(DefaultMetricsSystem.java:62)
> at
> org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.initialize(DefaultMetricsSystem.java:58)
> at
> org.apache.hadoop.hbase.metrics.BaseSourceImpl$DefaultMetricsSystemInitializer.init(BaseSourceImpl.java:51)
> at
> org.apache.hadoop.hbase.metrics.BaseSourceImpl.(BaseSourceImpl.java:112)
> at
> org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSourceImpl.(MetricsZooKeeperSourceImpl.java:56)
> at
> org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSourceImpl.(MetricsZooKeeperSourceImpl.java:51)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19420) Backport HBASE-19152 (Update refguide 'how to build an RC' and the make_rc.sh script) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-19420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19420: --- Attachment: (was: HBASE-19420-branch-1.patch) > Backport HBASE-19152 (Update refguide 'how to build an RC' and the make_rc.sh > script) to branch-1 > - > > Key: HBASE-19420 > URL: https://issues.apache.org/jira/browse/HBASE-19420 > Project: HBase > Issue Type: Task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0 > > Attachments: HBASE-19420-branch-1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19421) branch-1 does not compile against Hadoop 3.0.0
[
https://issues.apache.org/jira/browse/HBASE-19421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1629#comment-1629
]
Andrew Purtell commented on HBASE-19421:
Unless objection I plan to commit this shortly with my RM hat on so I can get a
RC for 1.4.0 out today. We can always amend it or revert it (and vote down the
RC) if someone has a strong opinion about any of these changes. However I think
they are all trivial and will not be controversial.
> branch-1 does not compile against Hadoop 3.0.0
> --
>
> Key: HBASE-19421
> URL: https://issues.apache.org/jira/browse/HBASE-19421
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 1.4.1, 1.5.0
>
> Attachments: HBASE-19421-branch-1.patch
>
>
> Tested with {{mvn clean install -Dhadoop.profile=3.0
> -Dhadoop-three.version=3.0.0-alpha4}}
> {noformat}
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[37,32]
> package org.apache.hadoop.mapred does not exist
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[38,35]
> package org.apache.hadoop.mapreduce does not exist
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[117,66]
> cannot find symbol
> [ERROR] symbol: class Job
> [ERROR] location: class org.apache.hadoop.hbase.security.User
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[129,46]
> cannot find symbol
> [ERROR] symbol: class JobConf
> [ERROR] location: class org.apache.hadoop.hbase.security.User
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[344,59]
> cannot find symbol
> [ERROR] symbol: class Job
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[369,39]
> cannot find symbol
> [ERROR] symbol: class JobConf
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[351,17]
> cannot find symbol
> [ERROR] symbol: class Job
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> [ERROR]
> /Users/apurtell/src/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:[375,25]
> cannot find symbol
> [ERROR] symbol: class JobConf
> [ERROR] location: class
> org.apache.hadoop.hbase.security.User.SecureHadoopUser
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
