[jira] [Updated] (HBASE-19112) Suspect methods on Cell to be deprecated
[
https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-19112:
---
Attachment: HBASE-19112_master_4.patch
Final patch addressing review commetns from Stack and Chia.
[~chia7712]
Can I get a final +1 on this latest patch?
Can you raise sub-JIRAs for the gettypeByte() in RawCell and Put#add() API
changes or doc addition?
> Suspect methods on Cell to be deprecated
>
>
> Key: HBASE-19112
> URL: https://issues.apache.org/jira/browse/HBASE-19112
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: Josh Elser
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19112_branch-2.patch,
> HBASE-19112_branch-2_1.patch, HBASE-19112_master.patch,
> HBASE-19112_master_1.patch, HBASE-19112_master_1.patch,
> HBASE-19112_master_2.patch, HBASE-19112_master_3.patch,
> HBASE-19112_master_4.patch
>
>
> [~chia7712] suggested on the [mailing
> list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
> that we have some methods on Cell which should be deprecated for removal:
> * {{#getType()}}
> * {{#getTimestamp()}}
> * {{#getTag()}}
> * {{#getSequenceId()}}
> Let's make a pass over these (and maybe the rest) to make sure that there
> aren't others which are either implementation details or methods returning
> now-private-marked classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19112) Suspect methods on Cell to be deprecated
[
https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-19112:
---
Status: Patch Available (was: Open)
> Suspect methods on Cell to be deprecated
>
>
> Key: HBASE-19112
> URL: https://issues.apache.org/jira/browse/HBASE-19112
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: Josh Elser
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19112_branch-2.patch,
> HBASE-19112_branch-2_1.patch, HBASE-19112_master.patch,
> HBASE-19112_master_1.patch, HBASE-19112_master_1.patch,
> HBASE-19112_master_2.patch, HBASE-19112_master_3.patch,
> HBASE-19112_master_4.patch
>
>
> [~chia7712] suggested on the [mailing
> list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
> that we have some methods on Cell which should be deprecated for removal:
> * {{#getType()}}
> * {{#getTimestamp()}}
> * {{#getTag()}}
> * {{#getSequenceId()}}
> Let's make a pass over these (and maybe the rest) to make sure that there
> aren't others which are either implementation details or methods returning
> now-private-marked classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19112) Suspect methods on Cell to be deprecated
[
https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-19112:
---
Status: Open (was: Patch Available)
> Suspect methods on Cell to be deprecated
>
>
> Key: HBASE-19112
> URL: https://issues.apache.org/jira/browse/HBASE-19112
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: Josh Elser
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19112_branch-2.patch,
> HBASE-19112_branch-2_1.patch, HBASE-19112_master.patch,
> HBASE-19112_master_1.patch, HBASE-19112_master_1.patch,
> HBASE-19112_master_2.patch, HBASE-19112_master_3.patch
>
>
> [~chia7712] suggested on the [mailing
> list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
> that we have some methods on Cell which should be deprecated for removal:
> * {{#getType()}}
> * {{#getTimestamp()}}
> * {{#getTag()}}
> * {{#getSequenceId()}}
> Let's make a pass over these (and maybe the rest) to make sure that there
> aren't others which are either implementation details or methods returning
> now-private-marked classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-19545) Replace getBytes(StandardCharsets.UTF_8) to Bytes.toBytes
Peter Somogyi created HBASE-19545: - Summary: Replace getBytes(StandardCharsets.UTF_8) to Bytes.toBytes Key: HBASE-19545 URL: https://issues.apache.org/jira/browse/HBASE-19545 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0-beta-1 Reporter: Peter Somogyi Assignee: Peter Somogyi Priority: Minor Fix For: 2.0.0-beta-2 On HBASE-19498 [~stack] mentioned that Bytes.toBytes by default uses UTF_8 encoding so getBytes(StandardCharsets.UTF_8) can be simplified. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19524) Master side changes for moving peer modification from zk watcher to procedure
[
https://issues.apache.org/jira/browse/HBASE-19524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294612#comment-16294612
]
Hadoop QA commented on HBASE-19524:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
7s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} HBASE-19397 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
17s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
44s{color} | {color:green} HBASE-19397 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
36s{color} | {color:green} HBASE-19397 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
43s{color} | {color:green} HBASE-19397 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
12s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
4s{color} | {color:green} HBASE-19397 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} The patch hbase-protocol-shaded passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} The patch hbase-replication passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} The patch hbase-procedure passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
9s{color} | {color:green} hbase-server: The patch generated 0 new + 378
unchanged - 9 fixed = 378 total (was 387) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
24s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
18m 49s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
29s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
13s{color} | {color:green} hbase-replication in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
56s{color} | {color:green} hbase-procedure in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}102m 36s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green}
[jira] [Commented] (HBASE-18421) update hadoop prerequisites docs to call out 2.8.1
[ https://issues.apache.org/jira/browse/HBASE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294614#comment-16294614 ] Chia-Ping Tsai commented on HBASE-18421: bq. Maybe you weren't aware of the separate branch? My bad. I didn't push the doc fix to branch-2...:( bq. do you think there might be other jiras with similar issue I grep the commit log. Ya, many commits are not in branch-2. Which jira you encounter the merge issue? I will revisit all jira to push all missed commits for branch-2 > update hadoop prerequisites docs to call out 2.8.1 > -- > > Key: HBASE-18421 > URL: https://issues.apache.org/jira/browse/HBASE-18421 > Project: HBase > Issue Type: Task > Components: community, dependencies, documentation >Reporter: Sean Busbey >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18421.v0.patch, HBASE-18421.v1.patch > > > The Hadoop PMC has release 2.8.1 with the same "not ready for production" > caveat as 2.8.0 ([ref announce > email|https://lists.apache.org/thread.html/06609e491325c16debbdef4fbe8cecc6160b8909c06683c4805ad4af@%3Cgeneral.hadoop.apache.org%3E]) > We should update our docs proactively. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19524) Master side changes for moving peer modification from zk watcher to procedure
[ https://issues.apache.org/jira/browse/HBASE-19524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294605#comment-16294605 ] Zheng Hu commented on HBASE-19524: -- Got it , Thanks [~Apache9]. > Master side changes for moving peer modification from zk watcher to procedure > - > > Key: HBASE-19524 > URL: https://issues.apache.org/jira/browse/HBASE-19524 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: HBASE-19397 > > Attachments: HBASE-19524-HBASE-19397-v1.patch, > HBASE-19524-HBASE-19397.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19524) Master side changes for moving peer modification from zk watcher to procedure
[
https://issues.apache.org/jira/browse/HBASE-19524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294588#comment-16294588
]
Duo Zhang commented on HBASE-19524:
---
Lost connection to review board so reply here [~openinx].
{quote}
One question: What will happen if one RS failed while other RS succeeded ?
Seems like we'll fall into rollback process..
{quote}
The RefreshPeerProcedure will never fail. Unless the RS is dead then we will
retry forever.
{quote}
Seems like there's no UT ...
{quote}
There is a UT called TestDummyModifyPeerProcedure. We can remove these dummy
classes after your RS side work landed.
Let me address other problems.
> Master side changes for moving peer modification from zk watcher to procedure
> -
>
> Key: HBASE-19524
> URL: https://issues.apache.org/jira/browse/HBASE-19524
> Project: HBase
> Issue Type: Sub-task
> Components: proc-v2, Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: HBASE-19397
>
> Attachments: HBASE-19524-HBASE-19397-v1.patch,
> HBASE-19524-HBASE-19397.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19526) Update hadoop version to 3.0 GA
[ https://issues.apache.org/jira/browse/HBASE-19526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19526: - Resolution: Fixed Status: Resolved (was: Patch Available) > Update hadoop version to 3.0 GA > --- > > Key: HBASE-19526 > URL: https://issues.apache.org/jira/browse/HBASE-19526 > Project: HBase > Issue Type: Task > Components: build, dependencies >Reporter: Mike Drob >Assignee: Appy > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19526.master.001.patch, > HBASE-19526.master.001.patch, HBASE-19526.master.002.patch, > HBASE-19526.master.003.patch > > > We're still building against hadoop 3.0-beta1, while GA is recently released. > We should update, hopefully no surprises. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18421) update hadoop prerequisites docs to call out 2.8.1
[ https://issues.apache.org/jira/browse/HBASE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294565#comment-16294565 ] Appy edited comment on HBASE-18421 at 12/18/17 6:48 AM: Was backporting something when hit merge issue because of this was in master but not in branch-2. It's marked fix version 2.0.0-alpha3 but wasn't committed to branch-2. Maybe you weren't aware of the separate branch? Since branch-2 was created in june, do you think there might be other jiras with similar issue [~chia7712]? was (Author: appy): Was backporting something when hit merge issue with this. It's marked fix version 2.0.0-alpha3 but wasn't committed to branch-2. Maybe you weren't aware of the separate branch? Since branch-2 was created in june, do you think there might be other jiras with similar issue [~chia7712]? > update hadoop prerequisites docs to call out 2.8.1 > -- > > Key: HBASE-18421 > URL: https://issues.apache.org/jira/browse/HBASE-18421 > Project: HBase > Issue Type: Task > Components: community, dependencies, documentation >Reporter: Sean Busbey >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18421.v0.patch, HBASE-18421.v1.patch > > > The Hadoop PMC has release 2.8.1 with the same "not ready for production" > caveat as 2.8.0 ([ref announce > email|https://lists.apache.org/thread.html/06609e491325c16debbdef4fbe8cecc6160b8909c06683c4805ad4af@%3Cgeneral.hadoop.apache.org%3E]) > We should update our docs proactively. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18421) update hadoop prerequisites docs to call out 2.8.1
[ https://issues.apache.org/jira/browse/HBASE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294565#comment-16294565 ] Appy commented on HBASE-18421: -- Was backporting something when hit merge issue with this. It's marked fix version 2.0.0-alpha3 but wasn't committed to branch-2. Maybe you weren't aware of the separate branch? Since branch-2 was created in june, do you think there might be other jiras with similar issue [~chia7712]? > update hadoop prerequisites docs to call out 2.8.1 > -- > > Key: HBASE-18421 > URL: https://issues.apache.org/jira/browse/HBASE-18421 > Project: HBase > Issue Type: Task > Components: community, dependencies, documentation >Reporter: Sean Busbey >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18421.v0.patch, HBASE-18421.v1.patch > > > The Hadoop PMC has release 2.8.1 with the same "not ready for production" > caveat as 2.8.0 ([ref announce > email|https://lists.apache.org/thread.html/06609e491325c16debbdef4fbe8cecc6160b8909c06683c4805ad4af@%3Cgeneral.hadoop.apache.org%3E]) > We should update our docs proactively. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19521) HBase mob compaction need to check hfile version
[ https://issues.apache.org/jira/browse/HBASE-19521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qilin Cao updated HBASE-19521: -- Attachment: HBASE-19521-v3.patch Patch 3 to repair the checkstyle error! > HBase mob compaction need to check hfile version > > > Key: HBASE-19521 > URL: https://issues.apache.org/jira/browse/HBASE-19521 > Project: HBase > Issue Type: Improvement > Components: Compaction, mob >Affects Versions: 2.0.0, 3.0.0 >Reporter: Qilin Cao >Assignee: Qilin Cao >Priority: Critical > Attachments: HBASE-19521-v1.patch, HBASE-19521-v2.patch, > HBASE-19521-v3.patch > > > When HBase master configuration is not set hfile.format.version to 3, and > user already run compact mob, this operation will cause compactor write V2 > ref hfile, the result is that user can not scan the correct cell value since > the mob cell ref tags are not written. So it is necessary to check the hfile > version before to run mob compaction. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19526) Update hadoop version to 3.0 GA
[ https://issues.apache.org/jira/browse/HBASE-19526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294557#comment-16294557 ] Appy commented on HBASE-19526: -- Passes hadoopcheck. Pushing to master and branch-2. > Update hadoop version to 3.0 GA > --- > > Key: HBASE-19526 > URL: https://issues.apache.org/jira/browse/HBASE-19526 > Project: HBase > Issue Type: Task > Components: build, dependencies >Reporter: Mike Drob >Assignee: Appy > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19526.master.001.patch, > HBASE-19526.master.001.patch, HBASE-19526.master.002.patch, > HBASE-19526.master.003.patch > > > We're still building against hadoop 3.0-beta1, while GA is recently released. > We should update, hopefully no surprises. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19526) Update hadoop version to 3.0 GA
[
https://issues.apache.org/jira/browse/HBASE-19526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294554#comment-16294554
]
Hadoop QA commented on HBASE-19526:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
5s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
0s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
35s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
6s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
22m 3s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
8s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}116m 52s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}171m 46s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19526 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12902583/HBASE-19526.master.003.patch
|
| Optional Tests | asflicense shellcheck shelldocs javac javadoc unit
xml shadedjars hadoopcheck compile |
| uname | Linux 655183ff17b2 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 26b69dc45b |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| shellcheck | v0.4.4 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/10514/artifact/patchprocess/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10514/testReport/ |
| modules | C: . U: . |
| Console output |
[jira] [Updated] (HBASE-19358) Improve the stability of splitting log when do fail over
[ https://issues.apache.org/jira/browse/HBASE-19358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-19358: - Attachment: HBASE-19358-v1.patch > Improve the stability of splitting log when do fail over > > > Key: HBASE-19358 > URL: https://issues.apache.org/jira/browse/HBASE-19358 > Project: HBase > Issue Type: Improvement > Components: MTTR >Affects Versions: 0.98.24 >Reporter: Jingyun Tian >Assignee: Jingyun Tian > Attachments: HBASE-19358-v1.patch, HBASE-19358.patch > > > The way we splitting log now is like the following figure: > !https://issues.apache.org/jira/secure/attachment/12902234/split-logic-old.jpg! > The problem is the OutputSink will write the recovered edits during splitting > log, which means it will create one WriterAndPath for each region and retain > it until the end. If the cluster is small and the number of regions per rs is > large, it will create too many HDFS streams at the same time. Then it is > prone to failure since each datanode need to handle too many streams. > Thus I come up with a new way to split log. > !https://issues.apache.org/jira/secure/attachment/12902235/split-logic-new.jpg! > We try to cache all the recovered edits, but if it exceeds the MaxHeapUsage, > we will pick the largest EntryBuffer and write it to a file (close the writer > after finish). Then after we read all entries into memory, we will start a > writeAndCloseThreadPool, it starts a certain number of threads to write all > buffers to files. Thus it will not create HDFS streams more than > *_hbase.regionserver.hlog.splitlog.writer.threads_* we set. > The biggest benefit is we can control the number of streams we create during > splitting log, > it will not exceeds *_hbase.regionserver.wal.max.splitters * > hbase.regionserver.hlog.splitlog.writer.threads_*, but before it is > *_hbase.regionserver.wal.max.splitters * the number of region the hlog > contains_*. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-19543) Implement a replication peer storage for master use only
[ https://issues.apache.org/jira/browse/HBASE-19543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-19543: - Assignee: Duo Zhang > Implement a replication peer storage for master use only > > > Key: HBASE-19543 > URL: https://issues.apache.org/jira/browse/HBASE-19543 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication >Reporter: Duo Zhang >Assignee: Duo Zhang > > For now, we will do sanity checks at the same time when updating replication > peer. But this is not a safe way for procedure based replication peer > modification. > For the old zk watcher way, the only thing is updating the data on zk, so if > the data is updated and then we crashes, there is no problem. > For the new procedure way, we need to trigger refresh by ourselves after > updating zk. If we crashes after the updating and before we record the state > change of the procedure, we may fail with IllegalArgumentException when we > execute the procedure next time since the data on zk has already been updated. > So the current way is to do sanity checks in PRE_PEER_MODIFICATION state, and > in UPDATE_STORAGE state we will not do sanity checks any more, just > update(overwrite) the peer storage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19521) HBase mob compaction need to check hfile version
[
https://issues.apache.org/jira/browse/HBASE-19521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294538#comment-16294538
]
Hadoop QA commented on HBASE-19521:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
46s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
7s{color} | {color:red} hbase-server: The patch generated 1 new + 16 unchanged
- 0 fixed = 17 total (was 16) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
43s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 48s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}125m 9s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}164m 32s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.wal.TestLogRolling |
| | hadoop.hbase.master.balancer.TestRegionsOnMasterOptions |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19521 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12902581/HBASE-19521-v2.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 2ec7782fa5d1 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 26b69dc45b |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/10513/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| unit |
[jira] [Comment Edited] (HBASE-13153) Bulk Loaded HFile Replication
[ https://issues.apache.org/jira/browse/HBASE-13153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290715#comment-16290715 ] Akshay Gehi edited comment on HBASE-13153 at 12/18/17 5:42 AM: --- Understood. You are saying that the documentation should be updated since the limitation no longer applies to Bulk load but this section should not be removed. If someone uses an API such as Put.setDurability(SKIP_WAL), the limitation would still apply. My second question was related to the bulk load feature. Are there any other known problems using Bulk load feature on a regular basis on a production system. I have seen a lot of problems in various articles such as the following link but those articles seem to be dated and those limitations don't seem to apply any more. http://blog.cloudera.com/blog/2013/09/how-to-use-hbase-bulk-loading-and-why/ *Some snippets from the (perhaps outdated) article - Potential Issues* * Recently deleted data reappearing * Bulk-loaded data cannot be overwritten by another bulk load We intend to use bulk load on a production system on a daily basis since we expect to receive millions of insert/updates a day. was (Author: akshaygehi): Understood. You are saying that the documentation should be updated since the limitation no longer applies to Bulk load but this section should not be removed. If someone uses an API such as Put.setDurability(SKIP_WAL), the limitation would still apply. My second question was related to the bulk load feature. Are there any other known problems using Bulk load feature on a regular basis on a production system. I have seen a lot of problems in various articles such as the following link but those articles seem to be dated and those limitations don't seem to apply any more. http://blog.cloudera.com/blog/2013/09/how-to-use-hbase-bulk-loading-and-why/ Some snippets from the (perhaps outdated) article: *Potential Issues* * Recently deleted data reappearing * Bulk-loaded data cannot be overwritten by another bulk load We intend to use bulk load on a production system on a daily basis since we expect to receive millions of insert/updates a day. > Bulk Loaded HFile Replication > - > > Key: HBASE-13153 > URL: https://issues.apache.org/jira/browse/HBASE-13153 > Project: HBase > Issue Type: New Feature > Components: Replication >Reporter: sunhaitao >Assignee: Ashish Singhi > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-13153-branch-1-v20.patch, > HBASE-13153-branch-1-v21.patch, HBASE-13153-v1.patch, HBASE-13153-v10.patch, > HBASE-13153-v11.patch, HBASE-13153-v12.patch, HBASE-13153-v13.patch, > HBASE-13153-v14.patch, HBASE-13153-v15.patch, HBASE-13153-v16.patch, > HBASE-13153-v17.patch, HBASE-13153-v18.patch, HBASE-13153-v19.patch, > HBASE-13153-v2.patch, HBASE-13153-v20.patch, HBASE-13153-v21.patch, > HBASE-13153-v3.patch, HBASE-13153-v4.patch, HBASE-13153-v5.patch, > HBASE-13153-v6.patch, HBASE-13153-v7.patch, HBASE-13153-v8.patch, > HBASE-13153-v9.patch, HBASE-13153.patch, HBase Bulk Load > Replication-v1-1.pdf, HBase Bulk Load Replication-v2.pdf, HBase Bulk Load > Replication-v3.pdf, HBase Bulk Load Replication.pdf, HDFS_HA_Solution.PNG > > > Currently we plan to use HBase Replication feature to deal with disaster > tolerance scenario.But we encounter an issue that we will use bulkload very > frequently,because bulkload bypass write path, and will not generate WAL, so > the data will not be replicated to backup cluster. It's inappropriate to > bukload twice both on active cluster and backup cluster. So i advise do some > modification to bulkload feature to enable bukload to both active cluster and > backup cluster -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19358) Improve the stability of splitting log when do fail over
[
https://issues.apache.org/jira/browse/HBASE-19358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294533#comment-16294533
]
Hadoop QA commented on HBASE-19358:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 4m
29s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
35s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
6s{color} | {color:red} hbase-server: The patch generated 10 new + 48 unchanged
- 3 fixed = 58 total (was 51) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
50s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 59s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}124m 38s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
28s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}168m 5s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19358 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12902233/HBASE-19358.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux fc51d995f3f9 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 26b69dc45b |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/10512/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/10512/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10512/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console
[jira] [Commented] (HBASE-19358) Improve the stability of splitting log when do fail over
[
https://issues.apache.org/jira/browse/HBASE-19358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294524#comment-16294524
]
Hadoop QA commented on HBASE-19358:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
1s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
40s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
7s{color} | {color:red} hbase-server: The patch generated 10 new + 48 unchanged
- 3 fixed = 58 total (was 51) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
45s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 14s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}106m 37s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}145m 40s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.balancer.TestRegionsOnMasterOptions |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19358 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12902233/HBASE-19358.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux c9060a4c40a3 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 26b69dc45b |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/10511/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/10511/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10511/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console
[jira] [Updated] (HBASE-19524) Master side changes for moving peer modification from zk watcher to procedure
[ https://issues.apache.org/jira/browse/HBASE-19524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19524: -- Attachment: HBASE-19524-HBASE-19397-v1.patch > Master side changes for moving peer modification from zk watcher to procedure > - > > Key: HBASE-19524 > URL: https://issues.apache.org/jira/browse/HBASE-19524 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: HBASE-19397 > > Attachments: HBASE-19524-HBASE-19397-v1.patch, > HBASE-19524-HBASE-19397.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19524) Master side changes for moving peer modification from zk watcher to procedure
[ https://issues.apache.org/jira/browse/HBASE-19524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19524: -- Attachment: (was: HBASE-19524-HABSE-19397-v1.patch) > Master side changes for moving peer modification from zk watcher to procedure > - > > Key: HBASE-19524 > URL: https://issues.apache.org/jira/browse/HBASE-19524 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: HBASE-19397 > > Attachments: HBASE-19524-HBASE-19397.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18440) ITs and Actions modify immutable TableDescriptors
[
https://issues.apache.org/jira/browse/HBASE-18440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294512#comment-16294512
]
Hadoop QA commented on HBASE-18440:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
19s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
57s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
10s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} hbase-it: The patch generated 0 new + 1 unchanged -
1 fixed = 1 total (was 2) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
36s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 2s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
39s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 38m 9s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18440 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12902584/HBASE-18440.master.005.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 84a1ce2b1a53 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 26b69dc45b |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10515/testReport/ |
| modules | C: hbase-it U: hbase-it |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10515/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> ITs and Actions modify immutable TableDescriptors
> -
>
> Key: HBASE-18440
> URL:
[jira] [Commented] (HBASE-19524) Master side changes for moving peer modification from zk watcher to procedure
[
https://issues.apache.org/jira/browse/HBASE-19524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294510#comment-16294510
]
Hadoop QA commented on HBASE-19524:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HBASE-19524 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.6.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-19524 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12902586/HBASE-19524-HABSE-19397-v1.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10516/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Master side changes for moving peer modification from zk watcher to procedure
> -
>
> Key: HBASE-19524
> URL: https://issues.apache.org/jira/browse/HBASE-19524
> Project: HBase
> Issue Type: Sub-task
> Components: proc-v2, Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: HBASE-19397
>
> Attachments: HBASE-19524-HABSE-19397-v1.patch,
> HBASE-19524-HBASE-19397.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19544) Add UTs for testing concurrent modifications on replication peer
[ https://issues.apache.org/jira/browse/HBASE-19544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19544: -- Component/s: test proc-v2 > Add UTs for testing concurrent modifications on replication peer > > > Key: HBASE-19544 > URL: https://issues.apache.org/jira/browse/HBASE-19544 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication, test >Reporter: Duo Zhang > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19397) Design procedures for ReplicationManager to notify peer change event from master
[
https://issues.apache.org/jira/browse/HBASE-19397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-19397:
--
Component/s: proc-v2
> Design procedures for ReplicationManager to notify peer change event from
> master
> -
>
> Key: HBASE-19397
> URL: https://issues.apache.org/jira/browse/HBASE-19397
> Project: HBase
> Issue Type: New Feature
> Components: proc-v2, Replication
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>
> After we store peer states / peer queues information into hbase table, RS
> can not track peer config change by adding watcher znode.
> So we need design procedures for ReplicationManager to notify peer change
> event. the replication rpc interfaces which may be implemented by
> procedures are following:
> {code}
> 1. addReplicationPeer
> 2. removeReplicationPeer
> 3. enableReplicationPeer
> 4. disableReplicationPeer
> 5. updateReplicationPeerConfig
> {code}
> BTW, our RS states will still be store in zookeeper, so when RS crash, the
> tracker which will trigger to transfer queues of crashed RS will still be a
> Zookeeper Tracker. we need NOT implement that by procedures.
> As we will release 2.0 in next weeks, and the HBASE-15867 can not be
> resolved before the release, so I'd prefer to create a new feature branch
> for HBASE-15867.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-19544) Add UTs for testing concurrent modifications on replication peer
Duo Zhang created HBASE-19544: - Summary: Add UTs for testing concurrent modifications on replication peer Key: HBASE-19544 URL: https://issues.apache.org/jira/browse/HBASE-19544 Project: HBase Issue Type: Sub-task Components: Replication Reporter: Duo Zhang -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19524) Master side changes for moving peer modification from zk watcher to procedure
[ https://issues.apache.org/jira/browse/HBASE-19524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19524: -- Attachment: HBASE-19524-HABSE-19397-v1.patch Move releaseLatch to the end of the procedure execution can fix the problem of TestReplicationAdmin. But I'm afraid that there are concurrency issues in the implementation. Let me open a issue to add UTs for modifying peers concurrently. > Master side changes for moving peer modification from zk watcher to procedure > - > > Key: HBASE-19524 > URL: https://issues.apache.org/jira/browse/HBASE-19524 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: HBASE-19397 > > Attachments: HBASE-19524-HABSE-19397-v1.patch, > HBASE-19524-HBASE-19397.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18440) ITs and Actions modify immutable TableDescriptors
[
https://issues.apache.org/jira/browse/HBASE-18440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294493#comment-16294493
]
Guanghao Zhang commented on HBASE-18440:
Run the it with the config in
https://hbase.apache.org/book.html#_server_side_configuration_3
{code}
./hbase org.apache.hadoop.hbase.IntegrationTestIngestWithEncryption -m
slowDeterministic
{code}
The IT verification failed. But the error seems not related to this change.
Will try the test without this patch.
Ping [~chia7712] for reviewing.
> ITs and Actions modify immutable TableDescriptors
> -
>
> Key: HBASE-18440
> URL: https://issues.apache.org/jira/browse/HBASE-18440
> Project: HBase
> Issue Type: Sub-task
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18440.master.004.patch,
> HBASE-18440.master.005.patch, HBASE-18440.patch, HBASE-18440.v2.patch,
> HBASE-18440.v3.patch, HBASE-18440.v3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18440) ITs and Actions modify immutable TableDescriptors
[ https://issues.apache.org/jira/browse/HBASE-18440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18440: --- Attachment: HBASE-18440.master.005.patch > ITs and Actions modify immutable TableDescriptors > - > > Key: HBASE-18440 > URL: https://issues.apache.org/jira/browse/HBASE-18440 > Project: HBase > Issue Type: Sub-task > Components: integration tests >Reporter: Mike Drob >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18440.master.004.patch, > HBASE-18440.master.005.patch, HBASE-18440.patch, HBASE-18440.v2.patch, > HBASE-18440.v3.patch, HBASE-18440.v3.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19526) Update hadoop version to 3.0 GA
[ https://issues.apache.org/jira/browse/HBASE-19526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294491#comment-16294491 ] Hadoop QA commented on HBASE-19526: --- (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HBASE-Build/10514/console in case of problems. > Update hadoop version to 3.0 GA > --- > > Key: HBASE-19526 > URL: https://issues.apache.org/jira/browse/HBASE-19526 > Project: HBase > Issue Type: Task > Components: build, dependencies >Reporter: Mike Drob >Assignee: Appy > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19526.master.001.patch, > HBASE-19526.master.001.patch, HBASE-19526.master.002.patch, > HBASE-19526.master.003.patch > > > We're still building against hadoop 3.0-beta1, while GA is recently released. > We should update, hopefully no surprises. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19526) Update hadoop version to 3.0 GA
[ https://issues.apache.org/jira/browse/HBASE-19526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19526: - Attachment: HBASE-19526.master.003.patch > Update hadoop version to 3.0 GA > --- > > Key: HBASE-19526 > URL: https://issues.apache.org/jira/browse/HBASE-19526 > Project: HBase > Issue Type: Task > Components: build, dependencies >Reporter: Mike Drob >Assignee: Appy > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19526.master.001.patch, > HBASE-19526.master.001.patch, HBASE-19526.master.002.patch, > HBASE-19526.master.003.patch > > > We're still building against hadoop 3.0-beta1, while GA is recently released. > We should update, hopefully no surprises. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-19527) Make ExecutorService threads daemon=true.
[ https://issues.apache.org/jira/browse/HBASE-19527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294488#comment-16294488 ] Appy edited comment on HBASE-19527 at 12/18/17 3:32 AM: Other cases are (looking for things calling ExecutorService#submit()): CompactedHFilesDischarger (chore), RegionReplicaFlushHandler, CloseRegionHandler, OpenMetaHandler, OpenPriorityRegionHandler, OpenRegionHandler. Am good with the idea of trying it. The effects of this one line change are much profound and we should address them too. For eg. - The check of if(rs.isStopping) in these handlers will be confusing. They will suggest that those are the only exit point in the flow, but in fact they are not. We should either remove them, but maybe they make sense (to avoid starting new work), in which case there should at least be a comment in each place stating the same. bq. I needed to keep a thread running until the last moment and didn't want to check stopped or aborted flags because these were being set too early in the shutdown process. Thats how I arrrived here. The thread that messages master about region changed state was ending abruptly as soon as the RS set 'stop' which it does early when a cluster is going down. Even after 'stop' is set, we still have the close of all regions to be done. With the messaging thread killed, the notice does not get to Master that a region has been closed. This gives a nice example to think about. Is the messaging thread daemon or not? (seems to me it is not) Is there a separate jira what you tackling this problem? Add a comment somewhere on this dependency of closing regions and messaging and how daemon threads help it? In summary, making these threads daemon makes sense. Although might break current assumptions and maybe logic. Although one line change, it has deeper effects, and the very least should document new assumptions in relevant places. Edit: +1, but needs adding comments. was (Author: appy): Other cases are (looking for things calling ExecutorService#submit()): CompactedHFilesDischarger (chore), RegionReplicaFlushHandler, CloseRegionHandler, OpenMetaHandler, OpenPriorityRegionHandler, OpenRegionHandler. Am good with the idea of trying it. The effects of this one line change are much profound and we should address them too. For eg. - The check of if(rs.isStopping) in these handlers will be confusing. They will suggest that those are the only exit point in the flow, but in fact they are not. We should either remove them, but maybe they make sense (to avoid starting new work), in which case there should at least be a comment in each place stating the same. bq. I needed to keep a thread running until the last moment and didn't want to check stopped or aborted flags because these were being set too early in the shutdown process. Thats how I arrrived here. The thread that messages master about region changed state was ending abruptly as soon as the RS set 'stop' which it does early when a cluster is going down. Even after 'stop' is set, we still have the close of all regions to be done. With the messaging thread killed, the notice does not get to Master that a region has been closed. This gives a nice example to think about. Is the messaging thread daemon or not? (seems to me it is not) Is there a separate jira what you tackling this problem? Add a comment somewhere on this dependency of closing regions and messaging and how daemon threads help it? In summary, making these threads daemon makes sense. Although might break current assumptions and maybe logic. Although one line change, it has deeper effects, and the very least should document new assumptions in relevant places. > Make ExecutorService threads daemon=true. > - > > Key: HBASE-19527 > URL: https://issues.apache.org/jira/browse/HBASE-19527 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack > Attachments: HBASE-19527.master.001.patch, > HBASE-19527.master.001.patch, HBASE-19527.master.001.patch > > > Let me try this. ExecutorService runs OPENs, CLOSE, etc. If Server is going > down, no point in these threads sticking around (I think). Let me try this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19527) Make ExecutorService threads daemon=true.
[ https://issues.apache.org/jira/browse/HBASE-19527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294488#comment-16294488 ] Appy commented on HBASE-19527: -- Other cases are (looking for things calling ExecutorService#submit()): CompactedHFilesDischarger (chore), RegionReplicaFlushHandler, CloseRegionHandler, OpenMetaHandler, OpenPriorityRegionHandler, OpenRegionHandler. Am good with the idea of trying it. The effects of this one line change are much profound and we should address them too. For eg. - The check of if(rs.isStopping) in these handlers will be confusing. They will suggest that those are the only exit point in the flow, but in fact they are not. We should either remove them, but maybe they make sense (to avoid starting new work), in which case there should at least be a comment in each place stating the same. bq. I needed to keep a thread running until the last moment and didn't want to check stopped or aborted flags because these were being set too early in the shutdown process. Thats how I arrrived here. The thread that messages master about region changed state was ending abruptly as soon as the RS set 'stop' which it does early when a cluster is going down. Even after 'stop' is set, we still have the close of all regions to be done. With the messaging thread killed, the notice does not get to Master that a region has been closed. This gives a nice example to think about. Is the messaging thread daemon or not? (seems to me it is not) Is there a separate jira what you tackling this problem? Add a comment somewhere on this dependency of closing regions and messaging and how daemon threads help it? In summary, making these threads daemon makes sense. Although might break current assumptions and maybe logic. Although one line change, it has deeper effects, and the very least should document new assumptions in relevant places. > Make ExecutorService threads daemon=true. > - > > Key: HBASE-19527 > URL: https://issues.apache.org/jira/browse/HBASE-19527 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack > Attachments: HBASE-19527.master.001.patch, > HBASE-19527.master.001.patch, HBASE-19527.master.001.patch > > > Let me try this. ExecutorService runs OPENs, CLOSE, etc. If Server is going > down, no point in these threads sticking around (I think). Let me try this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18440) ITs and Actions modify immutable TableDescriptors
[
https://issues.apache.org/jira/browse/HBASE-18440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294483#comment-16294483
]
Hadoop QA commented on HBASE-18440:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
7s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
54s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
10s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
23s{color} | {color:red} hbase-it: The patch generated 3 new + 1 unchanged - 1
fixed = 4 total (was 2) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
43s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 51s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
39s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 36m 46s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18440 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12902579/HBASE-18440.master.004.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux abaa455a0da5 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 26b69dc45b |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/10510/artifact/patchprocess/diff-checkstyle-hbase-it.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10510/testReport/ |
| modules | C: hbase-it U: hbase-it |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10510/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> ITs and Actions modify immutable
[jira] [Updated] (HBASE-19521) HBase mob compaction need to check hfile version
[ https://issues.apache.org/jira/browse/HBASE-19521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qilin Cao updated HBASE-19521: -- Attachment: HBASE-19521-v2.patch > HBase mob compaction need to check hfile version > > > Key: HBASE-19521 > URL: https://issues.apache.org/jira/browse/HBASE-19521 > Project: HBase > Issue Type: Improvement > Components: Compaction, mob >Affects Versions: 2.0.0, 3.0.0 >Reporter: Qilin Cao >Assignee: Qilin Cao >Priority: Critical > Attachments: HBASE-19521-v1.patch, HBASE-19521-v2.patch > > > When HBase master configuration is not set hfile.format.version to 3, and > user already run compact mob, this operation will cause compactor write V2 > ref hfile, the result is that user can not scan the correct cell value since > the mob cell ref tags are not written. So it is necessary to check the hfile > version before to run mob compaction. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19521) HBase mob compaction need to check hfile version
[ https://issues.apache.org/jira/browse/HBASE-19521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qilin Cao updated HBASE-19521: -- Attachment: (was: HBASE-19521-v2.patch) > HBase mob compaction need to check hfile version > > > Key: HBASE-19521 > URL: https://issues.apache.org/jira/browse/HBASE-19521 > Project: HBase > Issue Type: Improvement > Components: Compaction, mob >Affects Versions: 2.0.0, 3.0.0 >Reporter: Qilin Cao >Assignee: Qilin Cao >Priority: Critical > Attachments: HBASE-19521-v1.patch, HBASE-19521-v2.patch > > > When HBase master configuration is not set hfile.format.version to 3, and > user already run compact mob, this operation will cause compactor write V2 > ref hfile, the result is that user can not scan the correct cell value since > the mob cell ref tags are not written. So it is necessary to check the hfile > version before to run mob compaction. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19521) HBase mob compaction need to check hfile version
[ https://issues.apache.org/jira/browse/HBASE-19521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294482#comment-16294482 ] Qilin Cao commented on HBASE-19521: --- [~tedyu]Sorry, It is available now. > HBase mob compaction need to check hfile version > > > Key: HBASE-19521 > URL: https://issues.apache.org/jira/browse/HBASE-19521 > Project: HBase > Issue Type: Improvement > Components: Compaction, mob >Affects Versions: 2.0.0, 3.0.0 >Reporter: Qilin Cao >Assignee: Qilin Cao >Priority: Critical > Attachments: HBASE-19521-v1.patch, HBASE-19521-v2.patch > > > When HBase master configuration is not set hfile.format.version to 3, and > user already run compact mob, this operation will cause compactor write V2 > ref hfile, the result is that user can not scan the correct cell value since > the mob cell ref tags are not written. So it is necessary to check the hfile > version before to run mob compaction. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19521) HBase mob compaction need to check hfile version
[ https://issues.apache.org/jira/browse/HBASE-19521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qilin Cao updated HBASE-19521: -- Status: Patch Available (was: In Progress) > HBase mob compaction need to check hfile version > > > Key: HBASE-19521 > URL: https://issues.apache.org/jira/browse/HBASE-19521 > Project: HBase > Issue Type: Improvement > Components: Compaction, mob >Affects Versions: 2.0.0, 3.0.0 >Reporter: Qilin Cao >Assignee: Qilin Cao >Priority: Critical > Attachments: HBASE-19521-v1.patch, HBASE-19521-v2.patch > > > When HBase master configuration is not set hfile.format.version to 3, and > user already run compact mob, this operation will cause compactor write V2 > ref hfile, the result is that user can not scan the correct cell value since > the mob cell ref tags are not written. So it is necessary to check the hfile > version before to run mob compaction. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19358) Improve the stability of splitting log when do fail over
[ https://issues.apache.org/jira/browse/HBASE-19358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294479#comment-16294479 ] Ted Yu commented on HBASE-19358: Triggered another QA run : https://builds.apache.org/job/PreCommit-HBASE-Build/10511/console You can re-attach the images once the QA run is in progress. > Improve the stability of splitting log when do fail over > > > Key: HBASE-19358 > URL: https://issues.apache.org/jira/browse/HBASE-19358 > Project: HBase > Issue Type: Improvement > Components: MTTR >Affects Versions: 0.98.24 >Reporter: Jingyun Tian >Assignee: Jingyun Tian > Attachments: HBASE-19358.patch > > > The way we splitting log now is like the following figure: > !https://issues.apache.org/jira/secure/attachment/12902234/split-logic-old.jpg! > The problem is the OutputSink will write the recovered edits during splitting > log, which means it will create one WriterAndPath for each region and retain > it until the end. If the cluster is small and the number of regions per rs is > large, it will create too many HDFS streams at the same time. Then it is > prone to failure since each datanode need to handle too many streams. > Thus I come up with a new way to split log. > !https://issues.apache.org/jira/secure/attachment/12902235/split-logic-new.jpg! > We try to cache all the recovered edits, but if it exceeds the MaxHeapUsage, > we will pick the largest EntryBuffer and write it to a file (close the writer > after finish). Then after we read all entries into memory, we will start a > writeAndCloseThreadPool, it starts a certain number of threads to write all > buffers to files. Thus it will not create HDFS streams more than > *_hbase.regionserver.hlog.splitlog.writer.threads_* we set. > The biggest benefit is we can control the number of streams we create during > splitting log, > it will not exceeds *_hbase.regionserver.wal.max.splitters * > hbase.regionserver.hlog.splitlog.writer.threads_*, but before it is > *_hbase.regionserver.wal.max.splitters * the number of region the hlog > contains_*. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19450) Add log about average execution time for ScheduledChore
[
https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294478#comment-16294478
]
Reid Chan commented on HBASE-19450:
---
This is a trivial patch, on purpose to provide a util to measure avg elapsed
time for a specific method. It can be used in DEBUG or INFO, depending on
cases. What's more, by providing elapsed time,
bq. will be more helpful to indicate potential issues.
Differences between MovingAverage are about,
# measuring last N or overall
# applying different weights to different data at different positions.
Usage is simple:
{code}
timeMeasurement.measure(() -> {
chore();
return null;
});
LOG.info(String.format("%s average execution time: %.2f ns.",
getName(),
timeMeasurement.getAverageTime()));
{code}
> Add log about average execution time for ScheduledChore
> ---
>
> Key: HBASE-19450
> URL: https://issues.apache.org/jira/browse/HBASE-19450
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Attachments: HBASE-19450.master.001.patch,
> HBASE-19450.master.002.patch, HBASE-19450.master.003.patch,
> HBASE-19450.master.004.patch
>
>
> So far, there is no information about the exact execution time for a chore,
> we can provide log information about it. It also brings other benefits, like
> discovering inefficient chores which show rooms for improvement.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19521) HBase mob compaction need to check hfile version
[ https://issues.apache.org/jira/browse/HBASE-19521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294476#comment-16294476 ] Ted Yu commented on HBASE-19521: QA wouldn't run the test suite unless you put the JIRA in "Patch Available". > HBase mob compaction need to check hfile version > > > Key: HBASE-19521 > URL: https://issues.apache.org/jira/browse/HBASE-19521 > Project: HBase > Issue Type: Improvement > Components: Compaction, mob >Affects Versions: 2.0.0, 3.0.0 >Reporter: Qilin Cao >Assignee: Qilin Cao >Priority: Critical > Attachments: HBASE-19521-v1.patch, HBASE-19521-v2.patch > > > When HBase master configuration is not set hfile.format.version to 3, and > user already run compact mob, this operation will cause compactor write V2 > ref hfile, the result is that user can not scan the correct cell value since > the mob cell ref tags are not written. So it is necessary to check the hfile > version before to run mob compaction. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19358) Improve the stability of splitting log when do fail over
[ https://issues.apache.org/jira/browse/HBASE-19358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294474#comment-16294474 ] Jingyun Tian commented on HBASE-19358: -- [~tedyu] It seems caused by the attached images? I just deleted them all. Pls try again. > Improve the stability of splitting log when do fail over > > > Key: HBASE-19358 > URL: https://issues.apache.org/jira/browse/HBASE-19358 > Project: HBase > Issue Type: Improvement > Components: MTTR >Affects Versions: 0.98.24 >Reporter: Jingyun Tian >Assignee: Jingyun Tian > Attachments: HBASE-19358.patch > > > The way we splitting log now is like the following figure: > !https://issues.apache.org/jira/secure/attachment/12902234/split-logic-old.jpg! > The problem is the OutputSink will write the recovered edits during splitting > log, which means it will create one WriterAndPath for each region and retain > it until the end. If the cluster is small and the number of regions per rs is > large, it will create too many HDFS streams at the same time. Then it is > prone to failure since each datanode need to handle too many streams. > Thus I come up with a new way to split log. > !https://issues.apache.org/jira/secure/attachment/12902235/split-logic-new.jpg! > We try to cache all the recovered edits, but if it exceeds the MaxHeapUsage, > we will pick the largest EntryBuffer and write it to a file (close the writer > after finish). Then after we read all entries into memory, we will start a > writeAndCloseThreadPool, it starts a certain number of threads to write all > buffers to files. Thus it will not create HDFS streams more than > *_hbase.regionserver.hlog.splitlog.writer.threads_* we set. > The biggest benefit is we can control the number of streams we create during > splitting log, > it will not exceeds *_hbase.regionserver.wal.max.splitters * > hbase.regionserver.hlog.splitlog.writer.threads_*, but before it is > *_hbase.regionserver.wal.max.splitters * the number of region the hlog > contains_*. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19358) Improve the stability of splitting log when do fail over
[ https://issues.apache.org/jira/browse/HBASE-19358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-19358: - Attachment: (was: split-table.png) > Improve the stability of splitting log when do fail over > > > Key: HBASE-19358 > URL: https://issues.apache.org/jira/browse/HBASE-19358 > Project: HBase > Issue Type: Improvement > Components: MTTR >Affects Versions: 0.98.24 >Reporter: Jingyun Tian >Assignee: Jingyun Tian > Attachments: HBASE-19358.patch > > > The way we splitting log now is like the following figure: > !https://issues.apache.org/jira/secure/attachment/12902234/split-logic-old.jpg! > The problem is the OutputSink will write the recovered edits during splitting > log, which means it will create one WriterAndPath for each region and retain > it until the end. If the cluster is small and the number of regions per rs is > large, it will create too many HDFS streams at the same time. Then it is > prone to failure since each datanode need to handle too many streams. > Thus I come up with a new way to split log. > !https://issues.apache.org/jira/secure/attachment/12902235/split-logic-new.jpg! > We try to cache all the recovered edits, but if it exceeds the MaxHeapUsage, > we will pick the largest EntryBuffer and write it to a file (close the writer > after finish). Then after we read all entries into memory, we will start a > writeAndCloseThreadPool, it starts a certain number of threads to write all > buffers to files. Thus it will not create HDFS streams more than > *_hbase.regionserver.hlog.splitlog.writer.threads_* we set. > The biggest benefit is we can control the number of streams we create during > splitting log, > it will not exceeds *_hbase.regionserver.wal.max.splitters * > hbase.regionserver.hlog.splitlog.writer.threads_*, but before it is > *_hbase.regionserver.wal.max.splitters * the number of region the hlog > contains_*. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19358) Improve the stability of splitting log when do fail over
[ https://issues.apache.org/jira/browse/HBASE-19358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-19358: - Attachment: (was: split_test_result.png) > Improve the stability of splitting log when do fail over > > > Key: HBASE-19358 > URL: https://issues.apache.org/jira/browse/HBASE-19358 > Project: HBase > Issue Type: Improvement > Components: MTTR >Affects Versions: 0.98.24 >Reporter: Jingyun Tian >Assignee: Jingyun Tian > Attachments: HBASE-19358.patch > > > The way we splitting log now is like the following figure: > !https://issues.apache.org/jira/secure/attachment/12902234/split-logic-old.jpg! > The problem is the OutputSink will write the recovered edits during splitting > log, which means it will create one WriterAndPath for each region and retain > it until the end. If the cluster is small and the number of regions per rs is > large, it will create too many HDFS streams at the same time. Then it is > prone to failure since each datanode need to handle too many streams. > Thus I come up with a new way to split log. > !https://issues.apache.org/jira/secure/attachment/12902235/split-logic-new.jpg! > We try to cache all the recovered edits, but if it exceeds the MaxHeapUsage, > we will pick the largest EntryBuffer and write it to a file (close the writer > after finish). Then after we read all entries into memory, we will start a > writeAndCloseThreadPool, it starts a certain number of threads to write all > buffers to files. Thus it will not create HDFS streams more than > *_hbase.regionserver.hlog.splitlog.writer.threads_* we set. > The biggest benefit is we can control the number of streams we create during > splitting log, > it will not exceeds *_hbase.regionserver.wal.max.splitters * > hbase.regionserver.hlog.splitlog.writer.threads_*, but before it is > *_hbase.regionserver.wal.max.splitters * the number of region the hlog > contains_*. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19358) Improve the stability of splitting log when do fail over
[ https://issues.apache.org/jira/browse/HBASE-19358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-19358: - Attachment: (was: split-logic-old.jpg) > Improve the stability of splitting log when do fail over > > > Key: HBASE-19358 > URL: https://issues.apache.org/jira/browse/HBASE-19358 > Project: HBase > Issue Type: Improvement > Components: MTTR >Affects Versions: 0.98.24 >Reporter: Jingyun Tian >Assignee: Jingyun Tian > Attachments: HBASE-19358.patch > > > The way we splitting log now is like the following figure: > !https://issues.apache.org/jira/secure/attachment/12902234/split-logic-old.jpg! > The problem is the OutputSink will write the recovered edits during splitting > log, which means it will create one WriterAndPath for each region and retain > it until the end. If the cluster is small and the number of regions per rs is > large, it will create too many HDFS streams at the same time. Then it is > prone to failure since each datanode need to handle too many streams. > Thus I come up with a new way to split log. > !https://issues.apache.org/jira/secure/attachment/12902235/split-logic-new.jpg! > We try to cache all the recovered edits, but if it exceeds the MaxHeapUsage, > we will pick the largest EntryBuffer and write it to a file (close the writer > after finish). Then after we read all entries into memory, we will start a > writeAndCloseThreadPool, it starts a certain number of threads to write all > buffers to files. Thus it will not create HDFS streams more than > *_hbase.regionserver.hlog.splitlog.writer.threads_* we set. > The biggest benefit is we can control the number of streams we create during > splitting log, > it will not exceeds *_hbase.regionserver.wal.max.splitters * > hbase.regionserver.hlog.splitlog.writer.threads_*, but before it is > *_hbase.regionserver.wal.max.splitters * the number of region the hlog > contains_*. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19358) Improve the stability of splitting log when do fail over
[ https://issues.apache.org/jira/browse/HBASE-19358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-19358: - Attachment: (was: split-logic-new.jpg) > Improve the stability of splitting log when do fail over > > > Key: HBASE-19358 > URL: https://issues.apache.org/jira/browse/HBASE-19358 > Project: HBase > Issue Type: Improvement > Components: MTTR >Affects Versions: 0.98.24 >Reporter: Jingyun Tian >Assignee: Jingyun Tian > Attachments: HBASE-19358.patch > > > The way we splitting log now is like the following figure: > !https://issues.apache.org/jira/secure/attachment/12902234/split-logic-old.jpg! > The problem is the OutputSink will write the recovered edits during splitting > log, which means it will create one WriterAndPath for each region and retain > it until the end. If the cluster is small and the number of regions per rs is > large, it will create too many HDFS streams at the same time. Then it is > prone to failure since each datanode need to handle too many streams. > Thus I come up with a new way to split log. > !https://issues.apache.org/jira/secure/attachment/12902235/split-logic-new.jpg! > We try to cache all the recovered edits, but if it exceeds the MaxHeapUsage, > we will pick the largest EntryBuffer and write it to a file (close the writer > after finish). Then after we read all entries into memory, we will start a > writeAndCloseThreadPool, it starts a certain number of threads to write all > buffers to files. Thus it will not create HDFS streams more than > *_hbase.regionserver.hlog.splitlog.writer.threads_* we set. > The biggest benefit is we can control the number of streams we create during > splitting log, > it will not exceeds *_hbase.regionserver.wal.max.splitters * > hbase.regionserver.hlog.splitlog.writer.threads_*, but before it is > *_hbase.regionserver.wal.max.splitters * the number of region the hlog > contains_*. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19358) Improve the stability of splitting log when do fail over
[ https://issues.apache.org/jira/browse/HBASE-19358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-19358: - Attachment: (was: split-1-log.png) > Improve the stability of splitting log when do fail over > > > Key: HBASE-19358 > URL: https://issues.apache.org/jira/browse/HBASE-19358 > Project: HBase > Issue Type: Improvement > Components: MTTR >Affects Versions: 0.98.24 >Reporter: Jingyun Tian >Assignee: Jingyun Tian > Attachments: HBASE-19358.patch > > > The way we splitting log now is like the following figure: > !https://issues.apache.org/jira/secure/attachment/12902234/split-logic-old.jpg! > The problem is the OutputSink will write the recovered edits during splitting > log, which means it will create one WriterAndPath for each region and retain > it until the end. If the cluster is small and the number of regions per rs is > large, it will create too many HDFS streams at the same time. Then it is > prone to failure since each datanode need to handle too many streams. > Thus I come up with a new way to split log. > !https://issues.apache.org/jira/secure/attachment/12902235/split-logic-new.jpg! > We try to cache all the recovered edits, but if it exceeds the MaxHeapUsage, > we will pick the largest EntryBuffer and write it to a file (close the writer > after finish). Then after we read all entries into memory, we will start a > writeAndCloseThreadPool, it starts a certain number of threads to write all > buffers to files. Thus it will not create HDFS streams more than > *_hbase.regionserver.hlog.splitlog.writer.threads_* we set. > The biggest benefit is we can control the number of streams we create during > splitting log, > it will not exceeds *_hbase.regionserver.wal.max.splitters * > hbase.regionserver.hlog.splitlog.writer.threads_*, but before it is > *_hbase.regionserver.wal.max.splitters * the number of region the hlog > contains_*. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19526) Update hadoop version to 3.0 GA
[ https://issues.apache.org/jira/browse/HBASE-19526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294471#comment-16294471 ] Appy commented on HBASE-19526: -- Looking at hadoop check -1. Addressing other questions above: - Since it's just working, i guess we don't need to add another repo - Test are run against 2.7 (default hadoop version) and not affected by this change Do people agree that it's good idea to have nightly test runs against hadoop3 too? If yes, i'll make that change by adding another step in Jenkinsfile for branch-2 & master. > Update hadoop version to 3.0 GA > --- > > Key: HBASE-19526 > URL: https://issues.apache.org/jira/browse/HBASE-19526 > Project: HBase > Issue Type: Task > Components: build, dependencies >Reporter: Mike Drob >Assignee: Appy > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19526.master.001.patch, > HBASE-19526.master.001.patch, HBASE-19526.master.002.patch > > > We're still building against hadoop 3.0-beta1, while GA is recently released. > We should update, hopefully no surprises. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18440) ITs and Actions modify immutable TableDescriptors
[ https://issues.apache.org/jira/browse/HBASE-18440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18440: --- Attachment: HBASE-18440.master.004.patch Rebase. > ITs and Actions modify immutable TableDescriptors > - > > Key: HBASE-18440 > URL: https://issues.apache.org/jira/browse/HBASE-18440 > Project: HBase > Issue Type: Sub-task > Components: integration tests >Reporter: Mike Drob > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18440.master.004.patch, HBASE-18440.patch, > HBASE-18440.v2.patch, HBASE-18440.v3.patch, HBASE-18440.v3.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18440) ITs and Actions modify immutable TableDescriptors
[ https://issues.apache.org/jira/browse/HBASE-18440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-18440: -- Assignee: Guanghao Zhang > ITs and Actions modify immutable TableDescriptors > - > > Key: HBASE-18440 > URL: https://issues.apache.org/jira/browse/HBASE-18440 > Project: HBase > Issue Type: Sub-task > Components: integration tests >Reporter: Mike Drob >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18440.master.004.patch, HBASE-18440.patch, > HBASE-18440.v2.patch, HBASE-18440.v3.patch, HBASE-18440.v3.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18440) ITs and Actions modify immutable TableDescriptors
[ https://issues.apache.org/jira/browse/HBASE-18440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18440: --- Status: Patch Available (was: Open) > ITs and Actions modify immutable TableDescriptors > - > > Key: HBASE-18440 > URL: https://issues.apache.org/jira/browse/HBASE-18440 > Project: HBase > Issue Type: Sub-task > Components: integration tests >Reporter: Mike Drob >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18440.master.004.patch, HBASE-18440.patch, > HBASE-18440.v2.patch, HBASE-18440.v3.patch, HBASE-18440.v3.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18429) ITs attempt to modify immutable table/column descriptors
[ https://issues.apache.org/jira/browse/HBASE-18429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-18429: -- Assignee: (was: Guanghao Zhang) > ITs attempt to modify immutable table/column descriptors > > > Key: HBASE-18429 > URL: https://issues.apache.org/jira/browse/HBASE-18429 > Project: HBase > Issue Type: Umbrella > Components: integration tests >Affects Versions: 2.0.0-alpha-1 >Reporter: Mike Drob >Priority: Critical > > ITs: > * IntegrationTestIngestWithMOB (HBASE-18419) > * IntegrationTestDDLMasterFailover (HBASE-18428) > * IntegrationTestIngestWithEncryption::setUp (HBASE-18440) > * IntegrationTestBulkLoad::installSlowingCoproc (HBASE-18440) > Other Related: > * ChangeBloomFilterAction (HBASE-18419) > * ChangeCompressionAction (HBASE-18419) > * ChangeEncodingAction (HBASE-18419) > * ChangeVersionsAction (HBASE-18419) > * RemoveColumnAction (HBASE-18419) > * AddColumnAction::perform (HBASE-18440) > * ChangeSplitPolicyAction::perform (HBASE-18440) > * DecreaseMaxHFileSizeAction::perform (HBASE-18440) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18429) ITs attempt to modify immutable table/column descriptors
[ https://issues.apache.org/jira/browse/HBASE-18429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-18429: -- Assignee: Guanghao Zhang > ITs attempt to modify immutable table/column descriptors > > > Key: HBASE-18429 > URL: https://issues.apache.org/jira/browse/HBASE-18429 > Project: HBase > Issue Type: Umbrella > Components: integration tests >Affects Versions: 2.0.0-alpha-1 >Reporter: Mike Drob >Assignee: Guanghao Zhang >Priority: Critical > > ITs: > * IntegrationTestIngestWithMOB (HBASE-18419) > * IntegrationTestDDLMasterFailover (HBASE-18428) > * IntegrationTestIngestWithEncryption::setUp (HBASE-18440) > * IntegrationTestBulkLoad::installSlowingCoproc (HBASE-18440) > Other Related: > * ChangeBloomFilterAction (HBASE-18419) > * ChangeCompressionAction (HBASE-18419) > * ChangeEncodingAction (HBASE-18419) > * ChangeVersionsAction (HBASE-18419) > * RemoveColumnAction (HBASE-18419) > * AddColumnAction::perform (HBASE-18440) > * ChangeSplitPolicyAction::perform (HBASE-18440) > * DecreaseMaxHFileSizeAction::perform (HBASE-18440) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19525) RS side changes for moving peer modification from zk watcher to procedure
[ https://issues.apache.org/jira/browse/HBASE-19525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294466#comment-16294466 ] Zheng Hu commented on HBASE-19525: -- Fine, [~Apache9], Thanks. > RS side changes for moving peer modification from zk watcher to procedure > - > > Key: HBASE-19525 > URL: https://issues.apache.org/jira/browse/HBASE-19525 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication >Reporter: Duo Zhang >Assignee: Zheng Hu > Fix For: HBASE-19397 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19216) Implement a general framework to execute remote procedure on RS
[ https://issues.apache.org/jira/browse/HBASE-19216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294465#comment-16294465 ] Zheng Hu commented on HBASE-19216: -- bq. That is why asked whether this can take some payload also (in ACL case the new ACL permission info). Did not see patch at all.. Just asking and saying the possible usage of the f/w. [~anoop.hbase], Was there any related jira to address this ? Currently, let's focus on Replication, after the replication on proc-v2 has been finished, we can have a try for ACL. > Implement a general framework to execute remote procedure on RS > --- > > Key: HBASE-19216 > URL: https://issues.apache.org/jira/browse/HBASE-19216 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: HBASE-19397 > > Attachments: HBASE-19216-v1.patch, HBASE-19216-v2.patch, > HBASE-19216.patch, HBASE-19216.patch, HBASE-19216.patch > > > When building the basic framework for HBASE-19064, I found that the > enable/disable peer is built upon the watcher of zk. > The problem of using watcher is that, you do not know the exact time when all > RSes in the cluster have done the change, it is a 'eventually done'. > And for synchronous replication, when changing the state of a replication > peer, we need to know the exact time as we can only enable read/write after > that time. So I think we'd better use procedure to do this. Change the flag > on zk, and then execute a procedure on all RSes to reload the flag from zk. > Another benefit is that, after the change, zk will be mainly used as a > storage, so it will be easy to implement another replication peer storage to > replace zk so that we can reduce the dependency on zk. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19543) Implement a replication peer storage for master use only
Duo Zhang created HBASE-19543: - Summary: Implement a replication peer storage for master use only Key: HBASE-19543 URL: https://issues.apache.org/jira/browse/HBASE-19543 Project: HBase Issue Type: Sub-task Components: proc-v2, Replication Reporter: Duo Zhang For now, we will do sanity checks at the same time when updating replication peer. But this is not a safe way for procedure based replication peer modification. For the old zk watcher way, the only thing is updating the data on zk, so if the data is updated and then we crashes, there is no problem. For the new procedure way, we need to trigger refresh by ourselves after updating zk. If we crashes after the updating and before we record the state change of the procedure, we may fail with IllegalArgumentException when we execute the procedure next time since the data on zk has already been updated. So the current way is to do sanity checks in PRE_PEER_MODIFICATION state, and in UPDATE_STORAGE state we will not do sanity checks any more, just update(overwrite) the peer storage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19536) Client side changes for moving peer modification from zk watcher to procedure
[ https://issues.apache.org/jira/browse/HBASE-19536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294433#comment-16294433 ] Guanghao Zhang commented on HBASE-19536: Assigned this issue to me. > Client side changes for moving peer modification from zk watcher to procedure > - > > Key: HBASE-19536 > URL: https://issues.apache.org/jira/browse/HBASE-19536 > Project: HBase > Issue Type: Sub-task > Components: Replication >Reporter: Duo Zhang > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-19536) Client side changes for moving peer modification from zk watcher to procedure
[ https://issues.apache.org/jira/browse/HBASE-19536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-19536: -- Assignee: Guanghao Zhang > Client side changes for moving peer modification from zk watcher to procedure > - > > Key: HBASE-19536 > URL: https://issues.apache.org/jira/browse/HBASE-19536 > Project: HBase > Issue Type: Sub-task > Components: Replication >Reporter: Duo Zhang >Assignee: Guanghao Zhang > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19524) Master side changes for moving peer modification from zk watcher to procedure
[ https://issues.apache.org/jira/browse/HBASE-19524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294432#comment-16294432 ] Duo Zhang commented on HBASE-19524: --- Oh, TestReplicationAdmin. It fails randomly for me locally, will always get connection loss for zk after some time... Let me dig. And since we are on a feature branch, I tend to commit the patch first if this is not easy to fix so others can start landing their work. Thanks. > Master side changes for moving peer modification from zk watcher to procedure > - > > Key: HBASE-19524 > URL: https://issues.apache.org/jira/browse/HBASE-19524 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: HBASE-19397 > > Attachments: HBASE-19524-HBASE-19397.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19521) HBase mob compaction need to check hfile version
[ https://issues.apache.org/jira/browse/HBASE-19521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qilin Cao updated HBASE-19521: -- Attachment: HBASE-19521-v2.patch update the patch log level! > HBase mob compaction need to check hfile version > > > Key: HBASE-19521 > URL: https://issues.apache.org/jira/browse/HBASE-19521 > Project: HBase > Issue Type: Improvement > Components: Compaction, mob >Affects Versions: 2.0.0, 3.0.0 >Reporter: Qilin Cao >Assignee: Qilin Cao >Priority: Critical > Attachments: HBASE-19521-v1.patch, HBASE-19521-v2.patch > > > When HBase master configuration is not set hfile.format.version to 3, and > user already run compact mob, this operation will cause compactor write V2 > ref hfile, the result is that user can not scan the correct cell value since > the mob cell ref tags are not written. So it is necessary to check the hfile > version before to run mob compaction. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-19521) HBase mob compaction need to check hfile version
[ https://issues.apache.org/jira/browse/HBASE-19521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294423#comment-16294423 ] Qilin Cao edited comment on HBASE-19521 at 12/18/17 1:02 AM: - [~yuzhih...@gmail.com]update the patch log level! was (Author: qilin cao): update the patch log level! > HBase mob compaction need to check hfile version > > > Key: HBASE-19521 > URL: https://issues.apache.org/jira/browse/HBASE-19521 > Project: HBase > Issue Type: Improvement > Components: Compaction, mob >Affects Versions: 2.0.0, 3.0.0 >Reporter: Qilin Cao >Assignee: Qilin Cao >Priority: Critical > Attachments: HBASE-19521-v1.patch, HBASE-19521-v2.patch > > > When HBase master configuration is not set hfile.format.version to 3, and > user already run compact mob, this operation will cause compactor write V2 > ref hfile, the result is that user can not scan the correct cell value since > the mob cell ref tags are not written. So it is necessary to check the hfile > version before to run mob compaction. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19542) fix TestSafemodeBringsDownMaster
[
https://issues.apache.org/jira/browse/HBASE-19542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294398#comment-16294398
]
Hadoop QA commented on HBASE-19542:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
7s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
39s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
3s{color} | {color:red} hbase-server: The patch generated 1 new + 65 unchanged
- 0 fixed = 66 total (was 65) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
36s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
18m 54s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}106m 3s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}143m 33s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19542 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12902569/HBASE-19542.v0.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 0dd1277e24fb 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 26b69dc45b |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/10509/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/10509/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10509/testReport/ |
| modules | C: hbase-server U:
[jira] [Commented] (HBASE-19542) fix TestSafemodeBringsDownMaster
[ https://issues.apache.org/jira/browse/HBASE-19542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294351#comment-16294351 ] Ted Yu commented on HBASE-19542: See MasterWalManager#checkFileSystem which toggles fsOk flag if file system is not available. Should the new method do the same ? > fix TestSafemodeBringsDownMaster > > > Key: HBASE-19542 > URL: https://issues.apache.org/jira/browse/HBASE-19542 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19542.v0.patch > > > We need to check the stability of underlay file system when closing async > wal. Otherwise, our hbase can't shutdown gracefully. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19541) Remove unnecessary semicolons in hbase-server
[
https://issues.apache.org/jira/browse/HBASE-19541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294345#comment-16294345
]
Hadoop QA commented on HBASE-19541:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 39 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
0s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
16s{color} | {color:green} hbase-server: The patch generated 0 new + 913
unchanged - 13 fixed = 913 total (was 926) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
38s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
20m 37s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}110m 3s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}150m 49s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19541 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12902566/HBASE-19541.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 2b01a62ed268 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 26b69dc45b |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/10507/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10507/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10507/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Remove unnecessary
[jira] [Commented] (HBASE-19496) Reusing the ByteBuffer in rpc layer corrupt the ServerLoad and RegionLoad
[
https://issues.apache.org/jira/browse/HBASE-19496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294336#comment-16294336
]
Hadoop QA commented on HBASE-19496:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
7s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 29 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 7m
17s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
35s{color} | {color:green} hbase-client: The patch generated 0 new + 590
unchanged - 15 fixed = 590 total (was 605) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
22s{color} | {color:green} hbase-server: The patch generated 0 new + 1310
unchanged - 31 fixed = 1310 total (was 1341) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} The patch hbase-rsgroup passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s{color} | {color:green} hbase-it: The patch generated 0 new + 43 unchanged -
1 fixed = 43 total (was 44) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s{color} | {color:green} hbase-rest: The patch generated 0 new + 2 unchanged
- 5 fixed = 2 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
30s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 7s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
45s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}110m 17s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
14s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
57s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
[jira] [Updated] (HBASE-19542) fix TestSafemodeBringsDownMaster
[ https://issues.apache.org/jira/browse/HBASE-19542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19542: --- Attachment: HBASE-19542.v0.patch looped the TestSafemodeBringsDownMaster 10 times. all pass > fix TestSafemodeBringsDownMaster > > > Key: HBASE-19542 > URL: https://issues.apache.org/jira/browse/HBASE-19542 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19542.v0.patch > > > We need to check the stability of underlay file system when closing async > wal. Otherwise, our hbase can't shutdown gracefully. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19542) fix TestSafemodeBringsDownMaster
[ https://issues.apache.org/jira/browse/HBASE-19542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19542: --- Status: Patch Available (was: Open) > fix TestSafemodeBringsDownMaster > > > Key: HBASE-19542 > URL: https://issues.apache.org/jira/browse/HBASE-19542 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19542.v0.patch > > > We need to check the stability of underlay file system when closing async > wal. Otherwise, our hbase can't shutdown gracefully. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19474) Bring down number of Checkstyle errors in hbase-zookeeper
[ https://issues.apache.org/jira/browse/HBASE-19474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294313#comment-16294313 ] Hudson commented on HBASE-19474: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4243 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4243/]) HBASE-19474 Brought down the number of Checkstyle errors in (jan.hentschel: rev 26b69dc45bf3c953905d5ed279e3f691ea802157) * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAclReset.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKMainServer.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionNormalizerTracker.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKClusterId.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/EmptyWatcher.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MetaTableLocator.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKNodeTracker.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterStatusTracker.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKLeaderManager.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/LoadBalancerTracker.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKSplitLog.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java > Bring down number of Checkstyle errors in hbase-zookeeper > - > > Key: HBASE-19474 > URL: https://issues.apache.org/jira/browse/HBASE-19474 > Project: HBase > Issue Type: Sub-task > Components: Zookeeper >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19474.master.001.patch > > > Currently the *hbase-zookeeper* module has a number of Checkstyle errors, > which should be reduced to a minimum. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19540) Reduce number of unnecessary semicolons
[
https://issues.apache.org/jira/browse/HBASE-19540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294311#comment-16294311
]
Hadoop QA commented on HBASE-19540:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
7s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 11 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
39s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
41s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch hbase-hadoop2-compat passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s{color} | {color:green} The patch hbase-procedure passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s{color} | {color:green} hbase-mapreduce: The patch generated 0 new + 82
unchanged - 26 fixed = 82 total (was 108) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} hbase-thrift: The patch generated 0 new + 34
unchanged - 1 fixed = 34 total (was 35) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} hbase-rsgroup: The patch generated 0 new + 3
unchanged - 1 fixed = 3 total (was 4) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} The patch hbase-it passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} The patch hbase-rest passed checkstyle {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
35s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
18m 51s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
40s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
27s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
56s{color} | {color:green} hbase-procedure in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} |
[jira] [Created] (HBASE-19542) fix TestSafemodeBringsDownMaster
Chia-Ping Tsai created HBASE-19542: -- Summary: fix TestSafemodeBringsDownMaster Key: HBASE-19542 URL: https://issues.apache.org/jira/browse/HBASE-19542 Project: HBase Issue Type: Bug Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai Fix For: 2.0.0-beta-1 We need to check the stability of underlay file system when closing async wal. Otherwise, our hbase can't shutdown gracefully. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19540) Reduce number of unnecessary semicolons
[ https://issues.apache.org/jira/browse/HBASE-19540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-19540: -- Attachment: HBASE-19540.master.002.patch > Reduce number of unnecessary semicolons > --- > > Key: HBASE-19540 > URL: https://issues.apache.org/jira/browse/HBASE-19540 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Attachments: HBASE-19540.master.001.patch, > HBASE-19540.master.002.patch > > > Some modules contain unnecessary semicolons, which should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19540) Reduce number of unnecessary semicolons
[ https://issues.apache.org/jira/browse/HBASE-19540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294273#comment-16294273 ] Jan Hentschel commented on HBASE-19540: --- Updated the patch to address the newly introduced Checkstyle errors. > Reduce number of unnecessary semicolons > --- > > Key: HBASE-19540 > URL: https://issues.apache.org/jira/browse/HBASE-19540 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Attachments: HBASE-19540.master.001.patch, > HBASE-19540.master.002.patch > > > Some modules contain unnecessary semicolons, which should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19541) Remove unnecessary semicolons in hbase-server
[ https://issues.apache.org/jira/browse/HBASE-19541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-19541: -- Status: Patch Available (was: In Progress) > Remove unnecessary semicolons in hbase-server > - > > Key: HBASE-19541 > URL: https://issues.apache.org/jira/browse/HBASE-19541 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Attachments: HBASE-19541.master.001.patch > > > Currently *hbase-server* has some places with unnecessary semicolons, which > should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19541) Remove unnecessary semicolons in hbase-server
[ https://issues.apache.org/jira/browse/HBASE-19541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-19541: -- Attachment: HBASE-19541.master.001.patch > Remove unnecessary semicolons in hbase-server > - > > Key: HBASE-19541 > URL: https://issues.apache.org/jira/browse/HBASE-19541 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Attachments: HBASE-19541.master.001.patch > > > Currently *hbase-server* has some places with unnecessary semicolons, which > should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Work started] (HBASE-19541) Remove unnecessary semicolons in hbase-server
[ https://issues.apache.org/jira/browse/HBASE-19541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-19541 started by Jan Hentschel. - > Remove unnecessary semicolons in hbase-server > - > > Key: HBASE-19541 > URL: https://issues.apache.org/jira/browse/HBASE-19541 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > > Currently *hbase-server* has some places with unnecessary semicolons, which > should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19541) Remove unnecessary semicolons in hbase-server
Jan Hentschel created HBASE-19541: - Summary: Remove unnecessary semicolons in hbase-server Key: HBASE-19541 URL: https://issues.apache.org/jira/browse/HBASE-19541 Project: HBase Issue Type: Sub-task Reporter: Jan Hentschel Assignee: Jan Hentschel Priority: Minor Currently *hbase-server* has some places with unnecessary semicolons, which should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19474) Bring down number of Checkstyle errors in hbase-zookeeper
[ https://issues.apache.org/jira/browse/HBASE-19474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-19474: -- Fix Version/s: (was: 3.0.0) > Bring down number of Checkstyle errors in hbase-zookeeper > - > > Key: HBASE-19474 > URL: https://issues.apache.org/jira/browse/HBASE-19474 > Project: HBase > Issue Type: Sub-task > Components: Zookeeper >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19474.master.001.patch > > > Currently the *hbase-zookeeper* module has a number of Checkstyle errors, > which should be reduced to a minimum. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19496) Reusing the ByteBuffer in rpc layer corrupt the ServerLoad and RegionLoad
[
https://issues.apache.org/jira/browse/HBASE-19496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-19496:
---
Attachment: HBASE-19496.v1.patch
v1
# fix checkstyle warnings
# fix findbugs warnings
# address ted's comment in RB
> Reusing the ByteBuffer in rpc layer corrupt the ServerLoad and RegionLoad
> -
>
> Key: HBASE-19496
> URL: https://issues.apache.org/jira/browse/HBASE-19496
> Project: HBase
> Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19496.v0.patch, HBASE-19496.v1.patch,
> HBASE-19496.wip.patch
>
>
> {{ServerLoad}} and {{RegionLoad}} store the pb object internally but the
> bytebuffer of pb object may be reused in rpc layer. Hence, the {{ServerLoad}}
> and {{RegionLoad}} which saved by {{HMaster}} will be corrupted if the
> bytebuffer backed is modified.
> This issue doesn't happen on branch-1.
> # netty server was introduced in 2.0 (see HBASE-17263)
> # reusing bytebuffer to read RPC requests was introduced in 2.0 (see
> HBASE-15788)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19133) Transfer big cells or upserted/appended cells into MSLAB upon flattening to CellChunkMap
[
https://issues.apache.org/jira/browse/HBASE-19133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294245#comment-16294245
]
Hadoop QA commented on HBASE-19133:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
1s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
45s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
4s{color} | {color:green} hbase-server: The patch generated 0 new + 57
unchanged - 4 fixed = 57 total (was 61) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
48s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 29s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}105m 56s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}145m 1s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.balancer.TestRegionsOnMasterOptions |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19133 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12902559/HBASE-19133.09.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux b95396d8f696 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 26b69dc45b |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/10504/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10504/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10504/console |
| Powered by | Apache Yetus 0.6.0
[jira] [Commented] (HBASE-19540) Reduce number of unnecessary semicolons
[
https://issues.apache.org/jira/browse/HBASE-19540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294242#comment-16294242
]
Hadoop QA commented on HBASE-19540:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
7s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 11 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
34s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
38s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch hbase-hadoop2-compat passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} The patch hbase-procedure passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
18s{color} | {color:red} hbase-mapreduce: The patch generated 2 new + 106
unchanged - 2 fixed = 108 total (was 108) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} hbase-thrift: The patch generated 0 new + 34
unchanged - 1 fixed = 34 total (was 35) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} hbase-rsgroup: The patch generated 0 new + 3
unchanged - 1 fixed = 3 total (was 4) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} The patch hbase-it passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} The patch hbase-rest passed checkstyle {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
34s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
18m 49s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
38s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
27s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
56s{color} | {color:green} hbase-procedure in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}
[jira] [Commented] (HBASE-19539) Remove unnecessary semicolons in hbase-common
[ https://issues.apache.org/jira/browse/HBASE-19539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294223#comment-16294223 ] Peter Somogyi commented on HBASE-19539: --- +1 > Remove unnecessary semicolons in hbase-common > - > > Key: HBASE-19539 > URL: https://issues.apache.org/jira/browse/HBASE-19539 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Attachments: HBASE-19539.master.001.patch > > > Currently *hbase-common* has some places with unnecessary semicolons, which > should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19540) Reduce number of unnecessary semicolons
[ https://issues.apache.org/jira/browse/HBASE-19540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294222#comment-16294222 ] Peter Somogyi commented on HBASE-19540: --- +1 > Reduce number of unnecessary semicolons > --- > > Key: HBASE-19540 > URL: https://issues.apache.org/jira/browse/HBASE-19540 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Attachments: HBASE-19540.master.001.patch > > > Some modules contain unnecessary semicolons, which should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19538) Remove unnecessary semicolons in hbase-client
[ https://issues.apache.org/jira/browse/HBASE-19538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294221#comment-16294221 ] Jan Hentschel commented on HBASE-19538: --- The new Checkstyle error seems to be a false positive. A local Checkstyle run doesn't complain about this line and the indentation looks correct. > Remove unnecessary semicolons in hbase-client > - > > Key: HBASE-19538 > URL: https://issues.apache.org/jira/browse/HBASE-19538 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Attachments: HBASE-19538.master.001.patch > > > Currently *hbase-client* has some places with unnecessary semicolons, which > should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19531) Remove needless volatile declaration
[
https://issues.apache.org/jira/browse/HBASE-19531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294220#comment-16294220
]
Chia-Ping Tsai commented on HBASE-19531:
bq. May u assign to me?
done
> Remove needless volatile declaration
>
>
> Key: HBASE-19531
> URL: https://issues.apache.org/jira/browse/HBASE-19531
> Project: HBase
> Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Yun-Chi Shih
>Priority: Trivial
> Labels: beginner
> Fix For: 2.0.0
>
>
> {code:title=ZKNamespaceManager.java}
> public class ZKNamespaceManager extends ZKListener {
> private static final Log LOG = LogFactory.getLog(ZKNamespaceManager.class);
> private final String nsZNode;
> private volatile NavigableMap cache; //here
> {code}
> {code:title=HBaseAdmin.java}
> public class HBaseAdmin implements Admin {
> private static final Log LOG = LogFactory.getLog(HBaseAdmin.class);
> private ClusterConnection connection;
> private volatile Configuration conf; //here
> {code}
> {code:title=BufferedMutatorImpl.java}
> public class BufferedMutatorImpl implements BufferedMutator {
> private static final Log LOG = LogFactory.getLog(BufferedMutatorImpl.class);
> private final ExceptionListener listener;
> private final TableName tableName;
> private final Configuration conf;
> private final ConcurrentLinkedQueue writeAsyncBuffer = new
> ConcurrentLinkedQueue<>();
> private final AtomicLong currentWriteBufferSize = new AtomicLong(0);
> /**
>* Count the size of {@link BufferedMutatorImpl#writeAsyncBuffer}.
>* The {@link ConcurrentLinkedQueue#size()} is NOT a constant-time
> operation.
>*/
> private final AtomicInteger undealtMutationCount = new AtomicInteger(0);
> private volatile long writeBufferSize; //here
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (HBASE-19531) Remove needless volatile declaration
[
https://issues.apache.org/jira/browse/HBASE-19531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned HBASE-19531:
--
Assignee: Yun-Chi Shih
> Remove needless volatile declaration
>
>
> Key: HBASE-19531
> URL: https://issues.apache.org/jira/browse/HBASE-19531
> Project: HBase
> Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Yun-Chi Shih
>Priority: Trivial
> Labels: beginner
> Fix For: 2.0.0
>
>
> {code:title=ZKNamespaceManager.java}
> public class ZKNamespaceManager extends ZKListener {
> private static final Log LOG = LogFactory.getLog(ZKNamespaceManager.class);
> private final String nsZNode;
> private volatile NavigableMap cache; //here
> {code}
> {code:title=HBaseAdmin.java}
> public class HBaseAdmin implements Admin {
> private static final Log LOG = LogFactory.getLog(HBaseAdmin.class);
> private ClusterConnection connection;
> private volatile Configuration conf; //here
> {code}
> {code:title=BufferedMutatorImpl.java}
> public class BufferedMutatorImpl implements BufferedMutator {
> private static final Log LOG = LogFactory.getLog(BufferedMutatorImpl.class);
> private final ExceptionListener listener;
> private final TableName tableName;
> private final Configuration conf;
> private final ConcurrentLinkedQueue writeAsyncBuffer = new
> ConcurrentLinkedQueue<>();
> private final AtomicLong currentWriteBufferSize = new AtomicLong(0);
> /**
>* Count the size of {@link BufferedMutatorImpl#writeAsyncBuffer}.
>* The {@link ConcurrentLinkedQueue#size()} is NOT a constant-time
> operation.
>*/
> private final AtomicInteger undealtMutationCount = new AtomicInteger(0);
> private volatile long writeBufferSize; //here
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19538) Remove unnecessary semicolons in hbase-client
[ https://issues.apache.org/jira/browse/HBASE-19538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294218#comment-16294218 ] Peter Somogyi commented on HBASE-19538: --- +1 > Remove unnecessary semicolons in hbase-client > - > > Key: HBASE-19538 > URL: https://issues.apache.org/jira/browse/HBASE-19538 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Attachments: HBASE-19538.master.001.patch > > > Currently *hbase-client* has some places with unnecessary semicolons, which > should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19540) Reduce number of unnecessary semicolons
[ https://issues.apache.org/jira/browse/HBASE-19540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-19540: -- Status: Patch Available (was: In Progress) > Reduce number of unnecessary semicolons > --- > > Key: HBASE-19540 > URL: https://issues.apache.org/jira/browse/HBASE-19540 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Attachments: HBASE-19540.master.001.patch > > > Some modules contain unnecessary semicolons, which should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19540) Reduce number of unnecessary semicolons
[ https://issues.apache.org/jira/browse/HBASE-19540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-19540: -- Attachment: HBASE-19540.master.001.patch > Reduce number of unnecessary semicolons > --- > > Key: HBASE-19540 > URL: https://issues.apache.org/jira/browse/HBASE-19540 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Attachments: HBASE-19540.master.001.patch > > > Some modules contain unnecessary semicolons, which should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Work started] (HBASE-19540) Reduce number of unnecessary semicolons
[ https://issues.apache.org/jira/browse/HBASE-19540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-19540 started by Jan Hentschel. - > Reduce number of unnecessary semicolons > --- > > Key: HBASE-19540 > URL: https://issues.apache.org/jira/browse/HBASE-19540 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > > Some modules contain unnecessary semicolons, which should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19540) Reduce number of unnecessary semicolons
Jan Hentschel created HBASE-19540: - Summary: Reduce number of unnecessary semicolons Key: HBASE-19540 URL: https://issues.apache.org/jira/browse/HBASE-19540 Project: HBase Issue Type: Sub-task Reporter: Jan Hentschel Assignee: Jan Hentschel Priority: Minor Some modules contain unnecessary semicolons, which should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19477) Move and align documentation in hbase-annotations
[ https://issues.apache.org/jira/browse/HBASE-19477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294216#comment-16294216 ] Hudson commented on HBASE-19477: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4242 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4242/]) HBASE-19477 Moved and aligned documentation in hbase-annotations (jan.hentschel: rev 2a468d5421f6406e597909d16ec59322020318f9) * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/SmallTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/RestTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/MasterTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/ClientTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/MapReduceTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/ReplicationTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/LargeTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/CoprocessorTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/MiscTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/IntegrationTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/SecurityTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/FlakeyTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/VerySlowMapReduceTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/RegionServerTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/VerySlowRegionServerTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/MetricsTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/ZKTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/MediumTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/FilterTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/IOTests.java * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/RPCTests.java > Move and align documentation in hbase-annotations > - > > Key: HBASE-19477 > URL: https://issues.apache.org/jira/browse/HBASE-19477 > Project: HBase > Issue Type: Task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-19477.master.001.patch > > > Currently some of the annotations provided in *hbase-annotations* have the > interface documentation above the package declaration. It should be moved > directly on top of the interface. Also, align the documentation to a common > style, especially the listing of characteristics of an annotation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19479) Fix Checkstyle error in hbase-shell
[ https://issues.apache.org/jira/browse/HBASE-19479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294215#comment-16294215 ] Hudson commented on HBASE-19479: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4242 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4242/]) HBASE-19479 Fixed Checkstyle error in hbase-shell (jan.hentschel: rev de6f0fbdaaf69ad6f92f43629cf515a49c9174e8) * (edit) hbase-shell/src/test/java/org/apache/hadoop/hbase/client/TestShellNoCluster.java > Fix Checkstyle error in hbase-shell > --- > > Key: HBASE-19479 > URL: https://issues.apache.org/jira/browse/HBASE-19479 > Project: HBase > Issue Type: Sub-task > Components: shell >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-19479.master.001.patch > > > *hbase-shell* has one Checkstyle error left, which should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19482) Fix Checkstyle errors in hbase-spark-it
[ https://issues.apache.org/jira/browse/HBASE-19482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294214#comment-16294214 ] Hudson commented on HBASE-19482: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4242 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4242/]) HBASE-19482 Fixed remaining Checkstyle errors in hbase-spark-it and (jan.hentschel: rev 16a851431c5a5974302c3b05c48f8ffdb280bfd0) * (edit) hbase-spark-it/pom.xml * (edit) hbase-spark-it/src/test/java/org/apache/hadoop/hbase/spark/IntegrationTestSparkBulkLoad.java > Fix Checkstyle errors in hbase-spark-it > --- > > Key: HBASE-19482 > URL: https://issues.apache.org/jira/browse/HBASE-19482 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-19482.master.001.patch, > HBASE-19482.master.002.patch > > > Fix the remaining Checkstyle errors in the *hbase-spark-it* module and enable > Checkstyle to fail on violations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18309) Support multi threads in CleanerChore
[ https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294213#comment-16294213 ] Hudson commented on HBASE-18309: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4242 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4242/]) HBASE-18309 (addendum) fix NPE in LogCleaner (chia7712: rev 988ea870ed1760976d1596a56a75216b2d9d2762) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/LogCleaner.java > Support multi threads in CleanerChore > - > > Key: HBASE-18309 > URL: https://issues.apache.org/jira/browse/HBASE-18309 > Project: HBase > Issue Type: Improvement >Reporter: binlijin >Assignee: Reid Chan > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-18309.addendum.patch, > HBASE-18309.master.001.patch, HBASE-18309.master.002.patch, > HBASE-18309.master.004.patch, HBASE-18309.master.005.patch, > HBASE-18309.master.006.patch, HBASE-18309.master.007.patch, > HBASE-18309.master.008.patch, HBASE-18309.master.009.patch, > HBASE-18309.master.010.patch, HBASE-18309.master.011.patch, > HBASE-18309.master.012.patch, space_consumption_in_archive.png > > > There is only one thread in LogCleaner to clean oldWALs and in our big > cluster we find this is not enough. The number of files under oldWALs reach > the max-directory-items limit of HDFS and cause region server crash, so we > use multi threads for LogCleaner and the crash not happened any more. > What's more, currently there's only one thread iterating the archive > directory, and we could use multiple threads cleaning sub directories in > parallel to speed it up. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19539) Remove unnecessary semicolons in hbase-common
[
https://issues.apache.org/jira/browse/HBASE-19539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294212#comment-16294212
]
Hadoop QA commented on HBASE-19539:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 5 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
54s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s{color} | {color:green} hbase-common: The patch generated 0 new + 9
unchanged - 3 fixed = 9 total (was 12) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
29s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
18m 40s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
9s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 36m 48s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19539 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12902560/HBASE-19539.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 56129575ef77 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 26b69dc45b |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10503/testReport/ |
| modules | C: hbase-common U: hbase-common |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10503/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Remove unnecessary semicolons in hbase-common
> -
>
> Key: HBASE-19539
>
[jira] [Commented] (HBASE-19538) Remove unnecessary semicolons in hbase-client
[
https://issues.apache.org/jira/browse/HBASE-19538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294211#comment-16294211
]
Hadoop QA commented on HBASE-19538:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
7s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
5s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
31s{color} | {color:red} hbase-client: The patch generated 1 new + 210
unchanged - 3 fixed = 211 total (was 213) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
40s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
20m 1s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
49s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 39m 47s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19538 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12902558/HBASE-19538.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 9527f8bc8138 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 26b69dc45b |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/10502/artifact/patchprocess/diff-checkstyle-hbase-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10502/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10502/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Remove unnecessary
[jira] [Commented] (HBASE-19537) Remove unnecessary semicolons in hbase-backup
[ https://issues.apache.org/jira/browse/HBASE-19537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294198#comment-16294198 ] Ted Yu commented on HBASE-19537: lgtm > Remove unnecessary semicolons in hbase-backup > - > > Key: HBASE-19537 > URL: https://issues.apache.org/jira/browse/HBASE-19537 > Project: HBase > Issue Type: Sub-task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Attachments: HBASE-19537.master.001.patch > > > Currently *hbase-backup* has some places with unnecessary semicolons, which > should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19537) Remove unnecessary semicolons in hbase-backup
[
https://issues.apache.org/jira/browse/HBASE-19537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294196#comment-16294196
]
Hadoop QA commented on HBASE-19537:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
24s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} hbase-backup: The patch generated 0 new + 157
unchanged - 2 fixed = 157 total (was 159) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
1s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
22m 22s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 11m
12s{color} | {color:green} hbase-backup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 51m 41s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19537 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12902557/HBASE-19537.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 6488f33603aa 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 26b69dc45b |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10501/testReport/ |
| modules | C: hbase-backup U: hbase-backup |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10501/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Remove unnecessary semicolons in hbase-backup
> -
>
> Key: HBASE-19537
>
[jira] [Comment Edited] (HBASE-18309) Support multi threads in CleanerChore
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294195#comment-16294195
]
Ted Yu edited comment on HBASE-18309 at 12/17/17 3:31 PM:
--
Thanks for keeping an eye on the exception, Chia-ping.
Current fix is good.
was (Author: yuzhih...@gmail.com):
Thanks for keeping an eye on the exception, Chia-ping.
Current fix is good.
{code}
context.setResult(succeed);
if (interrupted) {
// Restore interrupt status
{code}
It seems moving the setResult() call inside the existing if should be enough.
> Support multi threads in CleanerChore
> -
>
> Key: HBASE-18309
> URL: https://issues.apache.org/jira/browse/HBASE-18309
> Project: HBase
> Issue Type: Improvement
>Reporter: binlijin
>Assignee: Reid Chan
> Fix For: 3.0.0, 2.0.0-beta-1
>
> Attachments: HBASE-18309.addendum.patch,
> HBASE-18309.master.001.patch, HBASE-18309.master.002.patch,
> HBASE-18309.master.004.patch, HBASE-18309.master.005.patch,
> HBASE-18309.master.006.patch, HBASE-18309.master.007.patch,
> HBASE-18309.master.008.patch, HBASE-18309.master.009.patch,
> HBASE-18309.master.010.patch, HBASE-18309.master.011.patch,
> HBASE-18309.master.012.patch, space_consumption_in_archive.png
>
>
> There is only one thread in LogCleaner to clean oldWALs and in our big
> cluster we find this is not enough. The number of files under oldWALs reach
> the max-directory-items limit of HDFS and cause region server crash, so we
> use multi threads for LogCleaner and the crash not happened any more.
> What's more, currently there's only one thread iterating the archive
> directory, and we could use multiple threads cleaning sub directories in
> parallel to speed it up.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
