[jira] [Updated] (HBASE-19573) Rewrite ReplicationPeer with the new replication storage interface
[ https://issues.apache.org/jira/browse/HBASE-19573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19573: --- Status: Patch Available (was: Open) > Rewrite ReplicationPeer with the new replication storage interface > -- > > Key: HBASE-19573 > URL: https://issues.apache.org/jira/browse/HBASE-19573 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication >Reporter: Duo Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-19573.HBASE-19397.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19573) Rewrite ReplicationPeer with the new replication storage interface
[ https://issues.apache.org/jira/browse/HBASE-19573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19573: --- Fix Version/s: HBASE-19397 > Rewrite ReplicationPeer with the new replication storage interface > -- > > Key: HBASE-19573 > URL: https://issues.apache.org/jira/browse/HBASE-19573 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication >Reporter: Duo Zhang >Assignee: Guanghao Zhang > Fix For: HBASE-19397 > > Attachments: HBASE-19573.HBASE-19397.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19573) Rewrite ReplicationPeer with the new replication storage interface
[ https://issues.apache.org/jira/browse/HBASE-19573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19573: --- Attachment: HBASE-19573.HBASE-19397.001.patch > Rewrite ReplicationPeer with the new replication storage interface > -- > > Key: HBASE-19573 > URL: https://issues.apache.org/jira/browse/HBASE-19573 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication >Reporter: Duo Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-19573.HBASE-19397.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19608) Race in MasterRpcServices.getProcedureResult
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303114#comment-16303114 ] Hudson commented on HBASE-19608: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4282 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4282/]) HBASE-19608 Race in MasterRpcServices.getProcedureResult (zhangduo: rev 27c56860da637fec0954c0fc4456f42e577da6af) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java > Race in MasterRpcServices.getProcedureResult > > > Key: HBASE-19608 > URL: https://issues.apache.org/jira/browse/HBASE-19608 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19608-v1.patch, HBASE-19608-v2.patch, > HBASE-19608.patch > > > In ProcedureExecutor, we only consider a procedure to be finished when it is > removed from the procedures map. But in MasterRpcServices.getProcedureResult, > we will use the state of the procedure to determine whether it is finished. > If setFailure is called, the procedure may enter the FAILED state which > indicates it is finished before being removed from the procedure map, and > then causes an assertion when we calling ProcedureExecutor.removeResult in > MasterRpcServices.getProcedureResult. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19579) Add peer lock test for shell command list_locks
[ https://issues.apache.org/jira/browse/HBASE-19579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19579: --- Attachment: HBASE-19579.HBASE-19397.002.patch Retry for Hadoop QA. > Add peer lock test for shell command list_locks > --- > > Key: HBASE-19579 > URL: https://issues.apache.org/jira/browse/HBASE-19579 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication >Reporter: Duo Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-19579.HBASE-19397.001.patch, > HBASE-19579.HBASE-19397.002.patch, HBASE-19579.HBASE-19397.002.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19573) Rewrite ReplicationPeer with the new replication storage interface
[ https://issues.apache.org/jira/browse/HBASE-19573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303107#comment-16303107 ] Guanghao Zhang commented on HBASE-19573: Meanwhile, handle the ReplicationPeers in HBASE-19622. > Rewrite ReplicationPeer with the new replication storage interface > -- > > Key: HBASE-19573 > URL: https://issues.apache.org/jira/browse/HBASE-19573 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication >Reporter: Duo Zhang >Assignee: Guanghao Zhang > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19622) Reimplement ReplicationPeers with the new replication storage interface
[ https://issues.apache.org/jira/browse/HBASE-19622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19622: --- Issue Type: Sub-task (was: Bug) Parent: HBASE-19397 > Reimplement ReplicationPeers with the new replication storage interface > --- > > Key: HBASE-19622 > URL: https://issues.apache.org/jira/browse/HBASE-19622 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication >Reporter: Guanghao Zhang > Fix For: HBASE-19397 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19622) Reimplement ReplicationPeers with the new replication storage interface
Guanghao Zhang created HBASE-19622: -- Summary: Reimplement ReplicationPeers with the new replication storage interface Key: HBASE-19622 URL: https://issues.apache.org/jira/browse/HBASE-19622 Project: HBase Issue Type: Bug Components: proc-v2, Replication Reporter: Guanghao Zhang Fix For: HBASE-19397 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19573) Rewrite ReplicationPeer with the new replication storage interface
[ https://issues.apache.org/jira/browse/HBASE-19573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19573: --- Summary: Rewrite ReplicationPeer with the new replication storage interface (was: Rewrite ReplicationPeerwith the new replication storage interface) > Rewrite ReplicationPeer with the new replication storage interface > -- > > Key: HBASE-19573 > URL: https://issues.apache.org/jira/browse/HBASE-19573 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication >Reporter: Duo Zhang > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19621) Revisit the methods in ReplicationPeerConfigBuilder
[ https://issues.apache.org/jira/browse/HBASE-19621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19621: --- Status: Patch Available (was: Open) > Revisit the methods in ReplicationPeerConfigBuilder > --- > > Key: HBASE-19621 > URL: https://issues.apache.org/jira/browse/HBASE-19621 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Minor > Attachments: HBASE-19621.master.001.patch > > > Add 4 methods for ReplicationPeerConfigBuilder: > addConfiguration > addAllConfiguration > addPeerData > addAllPeerData > Meanwhile, remove setConfiuration and serPeerData from > ReplicationPeerConfigBuilder. > Because previous ReplicationPeerConfig didn't support setConfiuration and > serPeerData. And previous code used getConfiguration.put or putAll to add > configuration. So add methods to keep consistent with old usage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-19573) Rewrite ReplicationPeer with the new replication storage interface
[ https://issues.apache.org/jira/browse/HBASE-19573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-19573: -- Assignee: Guanghao Zhang > Rewrite ReplicationPeer with the new replication storage interface > -- > > Key: HBASE-19573 > URL: https://issues.apache.org/jira/browse/HBASE-19573 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication >Reporter: Duo Zhang >Assignee: Guanghao Zhang > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19573) Rewrite ReplicationPeer with the new replication storage interface
[ https://issues.apache.org/jira/browse/HBASE-19573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303097#comment-16303097 ] Guanghao Zhang commented on HBASE-19573: Changed the title to "Rewrite ReplicationPeer with the new replication storage interface". Assigned this to me. Let me take a try to rewrite ReplicationPeer with the new replication storage interface. > Rewrite ReplicationPeer with the new replication storage interface > -- > > Key: HBASE-19573 > URL: https://issues.apache.org/jira/browse/HBASE-19573 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication >Reporter: Duo Zhang >Assignee: Guanghao Zhang > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19573) Rewrite ReplicationPeerwith the new replication storage interface
[ https://issues.apache.org/jira/browse/HBASE-19573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19573: --- Summary: Rewrite ReplicationPeerwith the new replication storage interface (was: Rewrite ReplicationPeer/Queue related classes with the new replication storage interface) > Rewrite ReplicationPeerwith the new replication storage interface > - > > Key: HBASE-19573 > URL: https://issues.apache.org/jira/browse/HBASE-19573 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication >Reporter: Duo Zhang > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303091#comment-16303091
]
Guanghao Zhang commented on HBASE-19619:
[~tedyu] Open a issue HBASE-19621 for keep the methods consistent with the
previous ReplicationPeerConfig.
> Modify replication_admin.rb to use ReplicationPeerConfigBuilder
> ---
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: 19619.v1.txt, 19619.v2.txt, 19619.v3.txt, 19619.v4.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19621) Revisit the methods in ReplicationPeerConfigBuilder
[ https://issues.apache.org/jira/browse/HBASE-19621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19621: --- Attachment: HBASE-19621.master.001.patch > Revisit the methods in ReplicationPeerConfigBuilder > --- > > Key: HBASE-19621 > URL: https://issues.apache.org/jira/browse/HBASE-19621 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Minor > Attachments: HBASE-19621.master.001.patch > > > Add 4 methods for ReplicationPeerConfigBuilder: > addConfiguration > addAllConfiguration > addPeerData > addAllPeerData > Meanwhile, remove setConfiuration and serPeerData from > ReplicationPeerConfigBuilder. > Because previous ReplicationPeerConfig didn't support setConfiuration and > serPeerData. And previous code used getConfiguration.put or putAll to add > configuration. So add methods to keep consistent with old usage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19608) Race in MasterRpcServices.getProcedureResult
[
https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303077#comment-16303077
]
Hadoop QA commented on HBASE-19608:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
8s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
39s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
38s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 14s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}120m 52s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}168m 47s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19608 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12903600/HBASE-19608-v2.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 9fa49fc03392 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / c24cf2d55e |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/10696/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10696/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10696/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically
[jira] [Commented] (HBASE-19618) Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory
[ https://issues.apache.org/jira/browse/HBASE-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303076#comment-16303076 ] Guanghao Zhang commented on HBASE-19618: bq. Let's also remove the table based implementation We can do this when implement table based replication storage interface? > Remove replicationQueuesClient.class/replicationQueues.class config from > ReplicationFactory > --- > > Key: HBASE-19618 > URL: https://issues.apache.org/jira/browse/HBASE-19618 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-19618.master.001.patch > > > When implement the procedure of replication admin operations, we abstract a > replication storage interface in HBASE-19543. So > ReplicationQueues/ReplicationQueuesClient are not used anymore. These > interface are IA.private. So it is ok to remove them. But there are two > config: hbase.region.replica.replication.replicationQueues.class and > hbase.region.replica.replication.replicationQueuesClient.class in > ReplicationFactory. These configs were introduced by HBASE-15867, which only > in 2.0. And the feature development is not active now. In the future, we can > implement the table based replication to replication storage interface. So > let's remove them before release 2.0. > See more details in the discussion of HBASE-19573. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19621) Revisit the methods in ReplicationPeerConfigBuilder
[ https://issues.apache.org/jira/browse/HBASE-19621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19621: --- Priority: Minor (was: Major) Issue Type: Improvement (was: Bug) > Revisit the methods in ReplicationPeerConfigBuilder > --- > > Key: HBASE-19621 > URL: https://issues.apache.org/jira/browse/HBASE-19621 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Minor > > Add 4 methods for ReplicationPeerConfigBuilder: > addConfiguration > addAllConfiguration > addPeerData > addAllPeerData > Meanwhile, remove setConfiuration and serPeerData from > ReplicationPeerConfigBuilder. > Because previous ReplicationPeerConfig didn't support setConfiuration and > serPeerData. And previous code used getConfiguration.put or putAll to add > configuration. So add methods to keep consistent with old usage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19621) Revisit the methods in ReplicationPeerConfigBuilder
Guanghao Zhang created HBASE-19621: -- Summary: Revisit the methods in ReplicationPeerConfigBuilder Key: HBASE-19621 URL: https://issues.apache.org/jira/browse/HBASE-19621 Project: HBase Issue Type: Bug Reporter: Guanghao Zhang Assignee: Guanghao Zhang Add 4 methods for ReplicationPeerConfigBuilder: addConfiguration addAllConfiguration addPeerData addAllPeerData Meanwhile, remove setConfiuration and serPeerData from ReplicationPeerConfigBuilder. Because previous ReplicationPeerConfig didn't support setConfiuration and serPeerData. And previous code used getConfiguration.put or putAll to add configuration. So add methods to keep consistent with old usage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303069#comment-16303069
]
Ted Yu commented on HBASE-19619:
With patch v4, TestReplicationShell passes.
> Modify replication_admin.rb to use ReplicationPeerConfigBuilder
> ---
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: 19619.v1.txt, 19619.v2.txt, 19619.v3.txt, 19619.v4.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-19619:
---
Status: Patch Available (was: Open)
> Modify replication_admin.rb to use ReplicationPeerConfigBuilder
> ---
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Critical
> Attachments: 19619.v1.txt, 19619.v2.txt, 19619.v3.txt, 19619.v4.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-19619:
---
Attachment: 19619.v4.txt
> Modify replication_admin.rb to use ReplicationPeerConfigBuilder
> ---
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: 19619.v1.txt, 19619.v2.txt, 19619.v3.txt, 19619.v4.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-19619:
---
Fix Version/s: 2.0.0-beta-1
> Modify replication_admin.rb to use ReplicationPeerConfigBuilder
> ---
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: 19619.v1.txt, 19619.v2.txt, 19619.v3.txt, 19619.v4.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303061#comment-16303061
]
Ted Yu commented on HBASE-19619:
If I use the following for creating Map for merging the peer data:
{code}
data2 = java.util.TreeMap.new(peer_data)
{code}
I got:
{code}
Error:
^[[48;5;16;38;5;226;1mtest_update_peer_config:_can_update_peer_config_and_data(Hbase::ReplicationAdminTest)^[[0m:
Java::JavaLang::ClassCastException: [B cannot be cast to java.lang.Comparable
java.util.TreeMap.compare(java/util/TreeMap.java:1294)
java.util.TreeMap.put(java/util/TreeMap.java:538)
java.util.AbstractMap.putAll(java/util/AbstractMap.java:281)
java.util.TreeMap.putAll(java/util/TreeMap.java:327)
java.util.TreeMap.(java/util/TreeMap.java:185)
java.lang.reflect.Constructor.newInstance(java/lang/reflect/Constructor.java:423)
org.jruby.javasupport.JavaConstructor.newInstanceDirect(org/jruby/javasupport/JavaConstructor.java:278)
org.jruby.RubyClass.newInstance(org/jruby/RubyClass.java:1001)
org.jruby.RubyClass$INVOKER$i$newInstance.call(org/jruby/RubyClass$INVOKER$i$newInstance.gen)
RUBY.update_peer_config(/Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/replication_admin.rb:375)
{code}
> Modify replication_admin.rb to use ReplicationPeerConfigBuilder
> ---
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Critical
> Attachments: 19619.v1.txt, 19619.v2.txt, 19619.v3.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-19619:
---
Priority: Critical (was: Major)
> Modify replication_admin.rb to use ReplicationPeerConfigBuilder
> ---
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Critical
> Attachments: 19619.v1.txt, 19619.v2.txt, 19619.v3.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-19619:
---
Attachment: (was: 19619.v3.txt)
> Modify replication_admin.rb to use ReplicationPeerConfigBuilder
> ---
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19619.v1.txt, 19619.v2.txt, 19619.v3.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-19619:
---
Attachment: 19619.v3.txt
> Modify replication_admin.rb to use ReplicationPeerConfigBuilder
> ---
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19619.v1.txt, 19619.v2.txt, 19619.v3.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-19619:
---
Attachment: 19619.v3.txt
In patch v3, I use a new Map to merge two configs in update_peer_config
> Modify replication_admin.rb to use ReplicationPeerConfigBuilder
> ---
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19619.v1.txt, 19619.v2.txt, 19619.v3.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-19619:
---
Summary: Modify replication_admin.rb to use ReplicationPeerConfigBuilder
(was: TestReplicationShell fails due to calling
Collections$UnmodifiableCollection.add)
> Modify replication_admin.rb to use ReplicationPeerConfigBuilder
> ---
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19619.v1.txt, 19619.v2.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303054#comment-16303054
]
Duo Zhang commented on HBASE-19619:
---
{quote}
Wouldn't it be better if we add the following method to
ReplicationPeerConfigBuilder ?
{quote}
No. If you have already called setConfiguration then you must already have a
map, then please call putAll on that map and then call setConfiguration. If no,
just call setConfiguration.
Thanks.
> Modify replication_admin.rb to use ReplicationPeerConfigBuilder
> ---
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19619.v1.txt, 19619.v2.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19599) Remove ReplicationQueuesClient, use ReplicationQueueStorage directly
[
https://issues.apache.org/jira/browse/HBASE-19599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303053#comment-16303053
]
Hadoop QA commented on HBASE-19599:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 14 new or modified test
files. {color} |
|| || || || {color:brown} HBASE-19397 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
54s{color} | {color:green} HBASE-19397 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} HBASE-19397 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
20s{color} | {color:green} HBASE-19397 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
59s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} HBASE-19397 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} hbase-replication: The patch generated 0 new + 5
unchanged - 7 fixed = 5 total (was 12) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
8s{color} | {color:green} hbase-server: The patch generated 0 new + 39
unchanged - 45 fixed = 39 total (was 84) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
50s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 59s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
16s{color} | {color:green} hbase-replication in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}134m 41s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
38s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}177m 26s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19599 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12903589/HBASE-19599-HBASE-19397-v2.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux d31ea745afa6 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (HBASE-19618) Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory
[ https://issues.apache.org/jira/browse/HBASE-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303052#comment-16303052 ] Duo Zhang commented on HBASE-19618: --- Let's also remove the table based implementation? It is useless now. Can add back later I think. > Remove replicationQueuesClient.class/replicationQueues.class config from > ReplicationFactory > --- > > Key: HBASE-19618 > URL: https://issues.apache.org/jira/browse/HBASE-19618 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-19618.master.001.patch > > > When implement the procedure of replication admin operations, we abstract a > replication storage interface in HBASE-19543. So > ReplicationQueues/ReplicationQueuesClient are not used anymore. These > interface are IA.private. So it is ok to remove them. But there are two > config: hbase.region.replica.replication.replicationQueues.class and > hbase.region.replica.replication.replicationQueuesClient.class in > ReplicationFactory. These configs were introduced by HBASE-15867, which only > in 2.0. And the feature development is not active now. In the future, we can > implement the table based replication to replication storage interface. So > let's remove them before release 2.0. > See more details in the discussion of HBASE-19573. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19608) Race in MasterRpcServices.getProcedureResult
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19608: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed to master and branch-2. Thanks [~openinx] for reviewing. > Race in MasterRpcServices.getProcedureResult > > > Key: HBASE-19608 > URL: https://issues.apache.org/jira/browse/HBASE-19608 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19608-v1.patch, HBASE-19608-v2.patch, > HBASE-19608.patch > > > In ProcedureExecutor, we only consider a procedure to be finished when it is > removed from the procedures map. But in MasterRpcServices.getProcedureResult, > we will use the state of the procedure to determine whether it is finished. > If setFailure is called, the procedure may enter the FAILED state which > indicates it is finished before being removed from the procedure map, and > then causes an assertion when we calling ProcedureExecutor.removeResult in > MasterRpcServices.getProcedureResult. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303049#comment-16303049
]
Ted Yu commented on HBASE-19619:
Wouldn't it be better if we add the following method to
ReplicationPeerConfigBuilder ?
{code}
ReplicationPeerConfigBuilder putAll(Map configuration);
{code}
which iterates thru configuration and adds the key / value pairs to the config.
> TestReplicationShell fails due to calling
> Collections$UnmodifiableCollection.add
>
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19619.v1.txt, 19619.v2.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303048#comment-16303048
]
Guanghao Zhang commented on HBASE-19619:
bq. I looked at ReplicationPeerConfigBuilder but there is no equivalent.
Need a new Map and put the config to new map and call setConfiguration.
> TestReplicationShell fails due to calling
> Collections$UnmodifiableCollection.add
>
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19619.v1.txt, 19619.v2.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303041#comment-16303041
]
Ted Yu edited comment on HBASE-19619 at 12/25/17 3:55 AM:
--
What pattern should be used to replace the following in replication_admin.rb
[~zghaobac] ?
{code}
replication_peer_config.get_configuration.put_all(config)
{code}
I looked at ReplicationPeerConfigBuilder but there is no equivalent.
was (Author: yuzhih...@gmail.com):
I am a bit puzzled by the following seen in the test output:
{code}
Error:
^[[48;5;16;38;5;226;1mtest_add_peer:_multiple_zk_cluster_key(Hbase::ReplicationAdminTest)^[[0m:
NoMethodError: undefined method `getExcludeNamespaces' for
#
Did you mean? getNamespaces
/Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/replication_admin.rb:302:in
`show_peer_exclude_namespaces'
/Users/tyu/trunk/hbase-shell/src/main/ruby/shell/commands/list_peers.rb:49:in
`block in command'
/Users/tyu/trunk/hbase-shell/src/main/ruby/shell/commands/list_peers.rb:44:in
`command'
/Users/tyu/trunk/hbase-shell/src/main/ruby/shell/commands.rb:38:in `block in
command_safe'
/Users/tyu/trunk/hbase-shell/src/main/ruby/shell/commands.rb:108:in
`translate_hbase_exceptions'
/Users/tyu/trunk/hbase-shell/src/main/ruby/shell/commands.rb:38:in
`command_safe'
/Users/tyu/trunk/hbase-shell/src/main/ruby/shell.rb:155:in `internal_command'
/Users/tyu/trunk/hbase-shell/src/main/ruby/shell.rb:142:in `command'
{code}
getExcludeNamespaces is present in ReplicationPeerConfig
> TestReplicationShell fails due to calling
> Collections$UnmodifiableCollection.add
>
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19619.v1.txt, 19619.v2.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-19619:
---
Attachment: 19619.v2.txt
> TestReplicationShell fails due to calling
> Collections$UnmodifiableCollection.add
>
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19619.v1.txt, 19619.v2.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-19619:
---
Attachment: (was: 19619.v2.txt)
> TestReplicationShell fails due to calling
> Collections$UnmodifiableCollection.add
>
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19619.v1.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19618) Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory
[ https://issues.apache.org/jira/browse/HBASE-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303046#comment-16303046 ] Guanghao Zhang commented on HBASE-19618: Add a 001 patch. Ignore the table based replication test. We can add them back in the future. FYI [~openinx] > Remove replicationQueuesClient.class/replicationQueues.class config from > ReplicationFactory > --- > > Key: HBASE-19618 > URL: https://issues.apache.org/jira/browse/HBASE-19618 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-19618.master.001.patch > > > When implement the procedure of replication admin operations, we abstract a > replication storage interface in HBASE-19543. So > ReplicationQueues/ReplicationQueuesClient are not used anymore. These > interface are IA.private. So it is ok to remove them. But there are two > config: hbase.region.replica.replication.replicationQueues.class and > hbase.region.replica.replication.replicationQueuesClient.class in > ReplicationFactory. These configs were introduced by HBASE-15867, which only > in 2.0. And the feature development is not active now. In the future, we can > implement the table based replication to replication storage interface. So > let's remove them before release 2.0. > See more details in the discussion of HBASE-19573. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19618) Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory
[ https://issues.apache.org/jira/browse/HBASE-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19618: --- Assignee: Guanghao Zhang Status: Patch Available (was: Open) > Remove replicationQueuesClient.class/replicationQueues.class config from > ReplicationFactory > --- > > Key: HBASE-19618 > URL: https://issues.apache.org/jira/browse/HBASE-19618 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-19618.master.001.patch > > > When implement the procedure of replication admin operations, we abstract a > replication storage interface in HBASE-19543. So > ReplicationQueues/ReplicationQueuesClient are not used anymore. These > interface are IA.private. So it is ok to remove them. But there are two > config: hbase.region.replica.replication.replicationQueues.class and > hbase.region.replica.replication.replicationQueuesClient.class in > ReplicationFactory. These configs were introduced by HBASE-15867, which only > in 2.0. And the feature development is not active now. In the future, we can > implement the table based replication to replication storage interface. So > let's remove them before release 2.0. > See more details in the discussion of HBASE-19573. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19618) Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory
[ https://issues.apache.org/jira/browse/HBASE-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19618: --- Attachment: HBASE-19618.master.001.patch > Remove replicationQueuesClient.class/replicationQueues.class config from > ReplicationFactory > --- > > Key: HBASE-19618 > URL: https://issues.apache.org/jira/browse/HBASE-19618 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang > Attachments: HBASE-19618.master.001.patch > > > When implement the procedure of replication admin operations, we abstract a > replication storage interface in HBASE-19543. So > ReplicationQueues/ReplicationQueuesClient are not used anymore. These > interface are IA.private. So it is ok to remove them. But there are two > config: hbase.region.replica.replication.replicationQueues.class and > hbase.region.replica.replication.replicationQueuesClient.class in > ReplicationFactory. These configs were introduced by HBASE-15867, which only > in 2.0. And the feature development is not active now. In the future, we can > implement the table based replication to replication storage interface. So > let's remove them before release 2.0. > See more details in the discussion of HBASE-19573. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303041#comment-16303041
]
Ted Yu commented on HBASE-19619:
I am a bit puzzled by the following seen in the test output:
{code}
Error:
^[[48;5;16;38;5;226;1mtest_add_peer:_multiple_zk_cluster_key(Hbase::ReplicationAdminTest)^[[0m:
NoMethodError: undefined method `getExcludeNamespaces' for
#
Did you mean? getNamespaces
/Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/replication_admin.rb:302:in
`show_peer_exclude_namespaces'
/Users/tyu/trunk/hbase-shell/src/main/ruby/shell/commands/list_peers.rb:49:in
`block in command'
/Users/tyu/trunk/hbase-shell/src/main/ruby/shell/commands/list_peers.rb:44:in
`command'
/Users/tyu/trunk/hbase-shell/src/main/ruby/shell/commands.rb:38:in `block in
command_safe'
/Users/tyu/trunk/hbase-shell/src/main/ruby/shell/commands.rb:108:in
`translate_hbase_exceptions'
/Users/tyu/trunk/hbase-shell/src/main/ruby/shell/commands.rb:38:in
`command_safe'
/Users/tyu/trunk/hbase-shell/src/main/ruby/shell.rb:155:in `internal_command'
/Users/tyu/trunk/hbase-shell/src/main/ruby/shell.rb:142:in `command'
{code}
getExcludeNamespaces is present in ReplicationPeerConfig
> TestReplicationShell fails due to calling
> Collections$UnmodifiableCollection.add
>
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19619.v1.txt, 19619.v2.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19608) Race in MasterRpcServices.getProcedureResult
[
https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303039#comment-16303039
]
Hadoop QA commented on HBASE-19608:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
39s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
42s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
20m 9s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}110m
27s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}151m 4s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19608 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12903587/HBASE-19608-v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 451cca0076c4 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / c24cf2d55e |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10694/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10694/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Race in MasterRpcServices.getProcedureResult
>
>
>
[jira] [Commented] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303038#comment-16303038
]
Ted Yu commented on HBASE-19619:
Currently I am in Utah.
Expect delay in future patches.
> TestReplicationShell fails due to calling
> Collections$UnmodifiableCollection.add
>
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19619.v1.txt, 19619.v2.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-19619:
---
Attachment: 19619.v2.txt
> TestReplicationShell fails due to calling
> Collections$UnmodifiableCollection.add
>
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19619.v1.txt, 19619.v2.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303035#comment-16303035
]
Ted Yu commented on HBASE-19619:
In patch v2, I use ReplicationPeerConfigBuilder for the two methods fixed in v1.
> TestReplicationShell fails due to calling
> Collections$UnmodifiableCollection.add
>
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19619.v1.txt, 19619.v2.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19608) Race in MasterRpcServices.getProcedureResult
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303031#comment-16303031 ] Zheng Hu commented on HBASE-19608: -- OK, +1 for this patch. > Race in MasterRpcServices.getProcedureResult > > > Key: HBASE-19608 > URL: https://issues.apache.org/jira/browse/HBASE-19608 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19608-v1.patch, HBASE-19608-v2.patch, > HBASE-19608.patch > > > In ProcedureExecutor, we only consider a procedure to be finished when it is > removed from the procedures map. But in MasterRpcServices.getProcedureResult, > we will use the state of the procedure to determine whether it is finished. > If setFailure is called, the procedure may enter the FAILED state which > indicates it is finished before being removed from the procedure map, and > then causes an assertion when we calling ProcedureExecutor.removeResult in > MasterRpcServices.getProcedureResult. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303030#comment-16303030
]
Guanghao Zhang commented on HBASE-19619:
I prefer to resolve this by use ReplicationPeerConfigBuilder and don't use the
deprecated methods anymore.
> TestReplicationShell fails due to calling
> Collections$UnmodifiableCollection.add
>
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19619.v1.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19620) Add UT to confirm the race in MasterRpcServices.getProcedureResult
[ https://issues.apache.org/jira/browse/HBASE-19620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19620: -- Priority: Minor (was: Major) Issue Type: Task (was: Bug) > Add UT to confirm the race in MasterRpcServices.getProcedureResult > -- > > Key: HBASE-19620 > URL: https://issues.apache.org/jira/browse/HBASE-19620 > Project: HBase > Issue Type: Task > Components: proc-v2, test >Reporter: Duo Zhang >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19620) Add UT to confirm the race in MasterRpcServices.getProcedureResult
Duo Zhang created HBASE-19620: - Summary: Add UT to confirm the race in MasterRpcServices.getProcedureResult Key: HBASE-19620 URL: https://issues.apache.org/jira/browse/HBASE-19620 Project: HBase Issue Type: Bug Components: proc-v2, test Reporter: Duo Zhang -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19608) Race in MasterRpcServices.getProcedureResult
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19608: -- Attachment: HBASE-19608-v2.patch > Race in MasterRpcServices.getProcedureResult > > > Key: HBASE-19608 > URL: https://issues.apache.org/jira/browse/HBASE-19608 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19608-v1.patch, HBASE-19608-v2.patch, > HBASE-19608.patch > > > In ProcedureExecutor, we only consider a procedure to be finished when it is > removed from the procedures map. But in MasterRpcServices.getProcedureResult, > we will use the state of the procedure to determine whether it is finished. > If setFailure is called, the procedure may enter the FAILED state which > indicates it is finished before being removed from the procedure map, and > then causes an assertion when we calling ProcedureExecutor.removeResult in > MasterRpcServices.getProcedureResult. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19608) Race in MasterRpcServices.getProcedureResult
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303028#comment-16303028 ] Duo Zhang commented on HBASE-19608: --- We already have UTs can run into the problems otherwise I can not find the problem right? The only thing is that it will not cause failure as we will retry on client. This is a trivial change I think. We can add UT for it later as it is not easy to write a UT here since this is a method at rpc layer. We need to do some hack. Thanks. > Race in MasterRpcServices.getProcedureResult > > > Key: HBASE-19608 > URL: https://issues.apache.org/jira/browse/HBASE-19608 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19608-v1.patch, HBASE-19608.patch > > > In ProcedureExecutor, we only consider a procedure to be finished when it is > removed from the procedures map. But in MasterRpcServices.getProcedureResult, > we will use the state of the procedure to determine whether it is finished. > If setFailure is called, the procedure may enter the FAILED state which > indicates it is finished before being removed from the procedure map, and > then causes an assertion when we calling ProcedureExecutor.removeResult in > MasterRpcServices.getProcedureResult. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19358) Improve the stability of splitting log when do fail over
[ https://issues.apache.org/jira/browse/HBASE-19358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303027#comment-16303027 ] Yu Li commented on HBASE-19358: --- Please fix the checkstyle issues and check UT failures [~tianjingyun] > Improve the stability of splitting log when do fail over > > > Key: HBASE-19358 > URL: https://issues.apache.org/jira/browse/HBASE-19358 > Project: HBase > Issue Type: Improvement > Components: MTTR >Affects Versions: 0.98.24 >Reporter: Jingyun Tian >Assignee: Jingyun Tian > Attachments: HBASE-19358-v1.patch, HBASE-19358-v4.patch, > HBASE-19358-v5.patch, HBASE-19358.patch > > > The way we splitting log now is like the following figure: > !https://issues.apache.org/jira/secure/attachment/12902997/split-logic-old.jpg! > The problem is the OutputSink will write the recovered edits during splitting > log, which means it will create one WriterAndPath for each region and retain > it until the end. If the cluster is small and the number of regions per rs is > large, it will create too many HDFS streams at the same time. Then it is > prone to failure since each datanode need to handle too many streams. > Thus I come up with a new way to split log. > !https://issues.apache.org/jira/secure/attachment/12902998/split-logic-new.jpg! > We try to cache all the recovered edits, but if it exceeds the MaxHeapUsage, > we will pick the largest EntryBuffer and write it to a file (close the writer > after finish). Then after we read all entries into memory, we will start a > writeAndCloseThreadPool, it starts a certain number of threads to write all > buffers to files. Thus it will not create HDFS streams more than > *_hbase.regionserver.hlog.splitlog.writer.threads_* we set. > The biggest benefit is we can control the number of streams we create during > splitting log, > it will not exceeds *_hbase.regionserver.wal.max.splitters * > hbase.regionserver.hlog.splitlog.writer.threads_*, but before it is > *_hbase.regionserver.wal.max.splitters * the number of region the hlog > contains_*. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303026#comment-16303026
]
Guanghao Zhang commented on HBASE-19619:
My fault... This was introduced by HBASE-19576.
> TestReplicationShell fails due to calling
> Collections$UnmodifiableCollection.add
>
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19619.v1.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303025#comment-16303025
]
Ted Yu commented on HBASE-19619:
Need to plug in builder to get over:
{code}
Error:
^[[48;5;16;38;5;226;1mtest_update_peer_config:_can_update_peer_config_and_data(Hbase::ReplicationAdminTest)^[[0m:
Java::JavaLang::UnsupportedOperationException:
java.util.Collections$UnmodifiableMap.putAll(java/util/Collections.java:1463)
java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
RUBY.update_peer_config(/Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/replication_admin.rb:363)
RUBY.command(/Users/tyu/trunk/hbase-shell/src/main/ruby/shell/commands/update_peer_config.rb:43)
org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
{code}
> TestReplicationShell fails due to calling
> Collections$UnmodifiableCollection.add
>
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19619.v1.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19608) Race in MasterRpcServices.getProcedureResult
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303024#comment-16303024 ] Zheng Hu commented on HBASE-19608: -- Any existed UT for addressing this case ? If no, I think we can add a UT for it. > Race in MasterRpcServices.getProcedureResult > > > Key: HBASE-19608 > URL: https://issues.apache.org/jira/browse/HBASE-19608 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19608-v1.patch, HBASE-19608.patch > > > In ProcedureExecutor, we only consider a procedure to be finished when it is > removed from the procedures map. But in MasterRpcServices.getProcedureResult, > we will use the state of the procedure to determine whether it is finished. > If setFailure is called, the procedure may enter the FAILED state which > indicates it is finished before being removed from the procedure map, and > then causes an assertion when we calling ProcedureExecutor.removeResult in > MasterRpcServices.getProcedureResult. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add
[
https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-19619:
---
Attachment: 19619.v1.txt
Fix a few places in replication_admin.rb
Need to figure out how to align update_peer_config with Java API
> TestReplicationShell fails due to calling
> Collections$UnmodifiableCollection.add
>
>
> Key: HBASE-19619
> URL: https://issues.apache.org/jira/browse/HBASE-19619
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19619.v1.txt
>
>
> Here is the error:
> {code}
> Error:
> test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
> Java::JavaLang::UnsupportedOperationException:
> java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
> java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
> org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
> RUBY.block in
> add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
> org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
> org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
> RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
> RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
> org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
> {code}
> The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add
Ted Yu created HBASE-19619:
--
Summary: TestReplicationShell fails due to calling
Collections$UnmodifiableCollection.add
Key: HBASE-19619
URL: https://issues.apache.org/jira/browse/HBASE-19619
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Here is the error:
{code}
Error:
test_append_peer_namespaces:_works_with_namespaces_array(Hbase::ReplicationAdminTest):
Java::JavaLang::UnsupportedOperationException:
java.util.Collections$UnmodifiableCollection.add(java/util/Collections.java:1055)
java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:453)
org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:314)
RUBY.block in
add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:226)
org.jruby.RubyArray.each(org/jruby/RubyArray.java:1734)
org.jruby.RubyArray$INVOKER$i$0$0$each.call(org/jruby/RubyArray$INVOKER$i$0$0$each.gen)
RUBY.add_peer_namespaces(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/hbase/replication_admin.rb:225)
RUBY.command(/home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests/hbase-shell/src/main/ruby/shell/commands/append_peer_namespaces.rb:40)
org.jruby.RubyClass.finvoke(org/jruby/RubyClass.java:522)
{code}
The cause was due to adding to UnmodifiableCollection
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19618) Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory
[ https://issues.apache.org/jira/browse/HBASE-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303014#comment-16303014 ] Guanghao Zhang commented on HBASE-19618: Meanwhile, we can pick up "table based replication" feature after the replication procedure development finished. > Remove replicationQueuesClient.class/replicationQueues.class config from > ReplicationFactory > --- > > Key: HBASE-19618 > URL: https://issues.apache.org/jira/browse/HBASE-19618 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang > > When implement the procedure of replication admin operations, we abstract a > replication storage interface in HBASE-19543. So > ReplicationQueues/ReplicationQueuesClient are not used anymore. These > interface are IA.private. So it is ok to remove them. But there are two > config: hbase.region.replica.replication.replicationQueues.class and > hbase.region.replica.replication.replicationQueuesClient.class in > ReplicationFactory. These configs were introduced by HBASE-15867, which only > in 2.0. And the feature development is not active now. In the future, we can > implement the table based replication to replication storage interface. So > let's remove them before release 2.0. > See more details in the discussion of HBASE-19573. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19618) Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory
[ https://issues.apache.org/jira/browse/HBASE-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303013#comment-16303013 ] Duo Zhang commented on HBASE-19618: --- +1. > Remove replicationQueuesClient.class/replicationQueues.class config from > ReplicationFactory > --- > > Key: HBASE-19618 > URL: https://issues.apache.org/jira/browse/HBASE-19618 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang > > When implement the procedure of replication admin operations, we abstract a > replication storage interface in HBASE-19543. So > ReplicationQueues/ReplicationQueuesClient are not used anymore. These > interface are IA.private. So it is ok to remove them. But there are two > config: hbase.region.replica.replication.replicationQueues.class and > hbase.region.replica.replication.replicationQueuesClient.class in > ReplicationFactory. These configs were introduced by HBASE-15867, which only > in 2.0. And the feature development is not active now. In the future, we can > implement the table based replication to replication storage interface. So > let's remove them before release 2.0. > See more details in the discussion of HBASE-19573. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19483) Add proper privilege check for rsgroup commands
[ https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303011#comment-16303011 ] Appy commented on HBASE-19483: -- Thinking about it, i think it's great that this topic came up at this time because we are in a position where we can change the configs. And the best part i like about this change is, using ACL as core _library_ in CPs rather than using _CPs_ from other CPs > Add proper privilege check for rsgroup commands > --- > > Key: HBASE-19483 > URL: https://issues.apache.org/jira/browse/HBASE-19483 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Guangxu Cheng > Fix For: 1.4.1, 1.5.0, 2.0.0-beta-2 > > Attachments: HBASE-19483.master.001.patch, > HBASE-19483.master.002.patch, HBASE-19483.master.003.patch, > HBASE-19483.master.004.patch, HBASE-19483.master.005.patch, > HBASE-19483.master.006.patch, HBASE-19483.master.007.patch, > HBASE-19483.master.008.patch > > > Currently list_rsgroups command can be executed by any user. > This is inconsistent with other list commands such as list_peers and > list_peer_configs. > We should add proper privilege check for list_rsgroups command. > privilege check should be added for get_table_rsgroup / get_server_rsgroup / > get_rsgroup commands. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19618) Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory
[ https://issues.apache.org/jira/browse/HBASE-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19618: --- Description: When implement the procedure of replication admin operations, we abstract a replication storage interface in HBASE-19543. So ReplicationQueues/ReplicationQueuesClient are not used anymore. These interface are IA.private. So it is ok to remove them. But there are two config: hbase.region.replica.replication.replicationQueues.class and hbase.region.replica.replication.replicationQueuesClient.class in ReplicationFactory. These configs were introduced by HBASE-15867, which only in 2.0. And the feature development is not active now. In the future, we can implement the table based replication to replication storage interface. So let's remove them before release 2.0. See more details in the discussion of HBASE-19573. was:When implement the procedure of replication admin operations, we abstract a replication storage interface in HBASE-19543. So ReplicationQueues/ReplicationQueuesClient are not used anymore. These interface are IA.private. So it is ok to remove them. But there are two config: hbase.region.replica.replication.replicationQueues.class and hbase.region.replica.replication.replicationQueuesClient.class in ReplicationFactory. These configs were introduced by HBASE-15867, which only in 2.0. And the feature development is not active now. In the future, we can implement the table based replication to replication storage interface. So let's remove them before release 2.0. > Remove replicationQueuesClient.class/replicationQueues.class config from > ReplicationFactory > --- > > Key: HBASE-19618 > URL: https://issues.apache.org/jira/browse/HBASE-19618 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang > > When implement the procedure of replication admin operations, we abstract a > replication storage interface in HBASE-19543. So > ReplicationQueues/ReplicationQueuesClient are not used anymore. These > interface are IA.private. So it is ok to remove them. But there are two > config: hbase.region.replica.replication.replicationQueues.class and > hbase.region.replica.replication.replicationQueuesClient.class in > ReplicationFactory. These configs were introduced by HBASE-15867, which only > in 2.0. And the feature development is not active now. In the future, we can > implement the table based replication to replication storage interface. So > let's remove them before release 2.0. > See more details in the discussion of HBASE-19573. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19618) Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory
Guanghao Zhang created HBASE-19618: -- Summary: Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory Key: HBASE-19618 URL: https://issues.apache.org/jira/browse/HBASE-19618 Project: HBase Issue Type: Bug Reporter: Guanghao Zhang When implement the procedure of replication admin operations, we abstract a replication storage interface in HBASE-19543. So ReplicationQueues/ReplicationQueuesClient are not used anymore. These interface are IA.private. So it is ok to remove them. But there are two config: hbase.region.replica.replication.replicationQueues.class and hbase.region.replica.replication.replicationQueuesClient.class in ReplicationFactory. These configs were introduced by HBASE-15867, which only in 2.0. And the feature development is not active now. In the future, we can implement the table based replication to replication storage interface. So let's remove them before release 2.0. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19473) Review of ClientScanner Class
[
https://issues.apache.org/jira/browse/HBASE-19473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302999#comment-16302999
]
Appy commented on HBASE-19473:
--
Sure, added to list. (will start new reviews after holidays :) )
> Review of ClientScanner Class
> -
>
> Key: HBASE-19473
> URL: https://issues.apache.org/jira/browse/HBASE-19473
> Project: HBase
> Issue Type: Improvement
> Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Attachments: HBASE-19473.1.patch, HBASE-19473.2.patch,
> HBASE-19473.3.patch
>
>
> # Remove superfluous logging code guard
> # Simplify some of the code
> # Use ArrayDeque instead of LinkedList for queue implementation
> https://docs.oracle.com/javase/8/docs/api/index.html?java/util/ArrayDeque.html
> {quote}
> Resizable-array implementation of the Deque interface. Array deques have no
> capacity restrictions; they grow as necessary to support usage. They are not
> thread-safe; in the absence of external synchronization, they do not support
> concurrent access by multiple threads. Null elements are prohibited. This
> class is likely to be faster than Stack when used as a stack, and *faster
> than LinkedList when used as a queue.*
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19483) Add proper privilege check for rsgroup commands
[ https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302997#comment-16302997 ] Appy commented on HBASE-19483: -- Need to give another thorough review, holidays in US right now so getting delayed. For now, since we are changing default value of a very critical config which can screw up protected production cluster on upgrade, there are two things we need to do at minimum: - Update docs: there are many places where we have suggested configs with Access/Visibility Controller as cp but is missing this property. Those config suggestions need to be updated where ever any hbase.coprocessor.*.classes config has AccessController/VisibilityController as value. - Ping [~stack]. This is something that needs to be called out in big bold red in upgrade doc. "If you use AccessController/VisibilityController, please set hbase.security.authorization config to true before upgrading." > Add proper privilege check for rsgroup commands > --- > > Key: HBASE-19483 > URL: https://issues.apache.org/jira/browse/HBASE-19483 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Guangxu Cheng > Fix For: 1.4.1, 1.5.0, 2.0.0-beta-2 > > Attachments: HBASE-19483.master.001.patch, > HBASE-19483.master.002.patch, HBASE-19483.master.003.patch, > HBASE-19483.master.004.patch, HBASE-19483.master.005.patch, > HBASE-19483.master.006.patch, HBASE-19483.master.007.patch, > HBASE-19483.master.008.patch > > > Currently list_rsgroups command can be executed by any user. > This is inconsistent with other list commands such as list_peers and > list_peer_configs. > We should add proper privilege check for list_rsgroups command. > privilege check should be added for get_table_rsgroup / get_server_rsgroup / > get_rsgroup commands. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19594) [webui] HMaster webui should show splitting regions than split completed regions
[
https://issues.apache.org/jira/browse/HBASE-19594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daisuke Kobayashi updated HBASE-19594:
--
Labels: supportability (was: )
> [webui] HMaster webui should show splitting regions than split completed
> regions
>
>
> Key: HBASE-19594
> URL: https://issues.apache.org/jira/browse/HBASE-19594
> Project: HBase
> Issue Type: Bug
> Components: master, UI
>Reporter: Daisuke Kobayashi
>Assignee: Daisuke Kobayashi
>Priority: Minor
> Labels: supportability
> Attachments: Screen Shot 2017-12-22 at 20.05.59.png,
> improving-region-status-in-master.001.patch,
> improving-region-status-in-master.002.patch
>
>
> Although HBASE-7332 intended to show {{Split Regions (regions with split
> state)}}, it was picking up the number from {{RegionState.State.SPLIT}} which
> split was already done.
> This jira intends to use {{RegionState.State.SPLITTING}} +
> {{RegionState.State.SPLITTING_NEW}}, instead. Also adding {{Merging Regions}}
> in the web ui.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19594) [webui] HMaster webui should show splitting regions than split completed regions
[
https://issues.apache.org/jira/browse/HBASE-19594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daisuke Kobayashi updated HBASE-19594:
--
Attachment: improving-region-status-in-master.002.patch
Apologies for the delay. Yes it's showing both Splitting Regions and Merging
Regions columns in webui as attached as
{{Screen Shot 2017-12-22 at 20.05.59.png}} while it's showing 0 since the *ing
status is difficult to capture in normal case.
.002 updated to capture the status from {{RegionState.State.SPLITTING}},
removed SPLITTING_NEW.
> [webui] HMaster webui should show splitting regions than split completed
> regions
>
>
> Key: HBASE-19594
> URL: https://issues.apache.org/jira/browse/HBASE-19594
> Project: HBase
> Issue Type: Bug
> Components: master, UI
>Reporter: Daisuke Kobayashi
>Assignee: Daisuke Kobayashi
>Priority: Minor
> Attachments: Screen Shot 2017-12-22 at 20.05.59.png,
> improving-region-status-in-master.001.patch,
> improving-region-status-in-master.002.patch
>
>
> Although HBASE-7332 intended to show {{Split Regions (regions with split
> state)}}, it was picking up the number from {{RegionState.State.SPLIT}} which
> split was already done.
> This jira intends to use {{RegionState.State.SPLITTING}} +
> {{RegionState.State.SPLITTING_NEW}}, instead. Also adding {{Merging Regions}}
> in the web ui.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-19617) Remove ReplicationQueues, use ReplicationQueueStorage directly
Duo Zhang created HBASE-19617: - Summary: Remove ReplicationQueues, use ReplicationQueueStorage directly Key: HBASE-19617 URL: https://issues.apache.org/jira/browse/HBASE-19617 Project: HBase Issue Type: Sub-task Components: Replication Reporter: Duo Zhang -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19554) AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit
[
https://issues.apache.org/jira/browse/HBASE-19554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302983#comment-16302983
]
Duo Zhang commented on HBASE-19554:
---
Still failed in countRows. There may be a problem with the assignments?
> AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit
> --
>
> Key: HBASE-19554
> URL: https://issues.apache.org/jira/browse/HBASE-19554
> Project: HBase
> Issue Type: Bug
> Components: Recovery, wal
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Attachments: HBASE-19554.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/10554/artifact/patchprocess/patch-unit-hbase-server.txt
> The error message is a bit strange:
> {quote}
> [ERROR] testThreeRSAbort(org.apache.hadoop.hbase.master.TestDLSAsyncFSWAL)
> Time elapsed: 20.627 s <<< ERROR!
> org.apache.hadoop.hbase.TableNotFoundException: Region of
> 'hbase:namespace,,1513320505933.451650152885a3b41d0b1110deca513c.' is
> expected in the table of 'testThreeRSAbort', but hbase:meta says it is in the
> table of 'hbase:namespace'. hbase:meta might be damaged.
> {quote}
> It fails for both FSHLog and AsyncFSWAL. Need to dig more.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19554) AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit
[
https://issues.apache.org/jira/browse/HBASE-19554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302982#comment-16302982
]
Duo Zhang commented on HBASE-19554:
---
https://builds.apache.org/job/PreCommit-HBASE-Build/10676/artifact/patchprocess/patch-unit-hbase-server.txt
{noformat}
[ERROR] Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 406.921
s <<< FAILURE! - in org.apache.hadoop.hbase.master.TestDLSAsyncFSWAL
[ERROR] testThreeRSAbort(org.apache.hadoop.hbase.master.TestDLSAsyncFSWAL)
Time elapsed: 301.077 s <<< ERROR!
org.junit.runners.model.TestTimedOutException: test timed out after 30
milliseconds
[ERROR] Errors:
[ERROR]
TestDLSAsyncFSWAL>AbstractTestDLS.testThreeRSAbort:401->Object.wait:460->Object.wait:-2
» TestTimedOut
{noformat}
> AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit
> --
>
> Key: HBASE-19554
> URL: https://issues.apache.org/jira/browse/HBASE-19554
> Project: HBase
> Issue Type: Bug
> Components: Recovery, wal
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Attachments: HBASE-19554.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/10554/artifact/patchprocess/patch-unit-hbase-server.txt
> The error message is a bit strange:
> {quote}
> [ERROR] testThreeRSAbort(org.apache.hadoop.hbase.master.TestDLSAsyncFSWAL)
> Time elapsed: 20.627 s <<< ERROR!
> org.apache.hadoop.hbase.TableNotFoundException: Region of
> 'hbase:namespace,,1513320505933.451650152885a3b41d0b1110deca513c.' is
> expected in the table of 'testThreeRSAbort', but hbase:meta says it is in the
> table of 'hbase:namespace'. hbase:meta might be damaged.
> {quote}
> It fails for both FSHLog and AsyncFSWAL. Need to dig more.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19594) [webui] HMaster webui should show splitting regions than split completed regions
[
https://issues.apache.org/jira/browse/HBASE-19594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daisuke Kobayashi updated HBASE-19594:
--
Attachment: Screen Shot 2017-12-22 at 20.05.59.png
> [webui] HMaster webui should show splitting regions than split completed
> regions
>
>
> Key: HBASE-19594
> URL: https://issues.apache.org/jira/browse/HBASE-19594
> Project: HBase
> Issue Type: Bug
> Components: master, UI
>Reporter: Daisuke Kobayashi
>Assignee: Daisuke Kobayashi
>Priority: Minor
> Attachments: Screen Shot 2017-12-22 at 20.05.59.png,
> improving-region-status-in-master.001.patch
>
>
> Although HBASE-7332 intended to show {{Split Regions (regions with split
> state)}}, it was picking up the number from {{RegionState.State.SPLIT}} which
> split was already done.
> This jira intends to use {{RegionState.State.SPLITTING}} +
> {{RegionState.State.SPLITTING_NEW}}, instead. Also adding {{Merging Regions}}
> in the web ui.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19599) Remove ReplicationQueuesClient, use ReplicationQueueStorage directly
[ https://issues.apache.org/jira/browse/HBASE-19599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19599: -- Attachment: HBASE-19599-HBASE-19397-v2.patch Rename UT. > Remove ReplicationQueuesClient, use ReplicationQueueStorage directly > > > Key: HBASE-19599 > URL: https://issues.apache.org/jira/browse/HBASE-19599 > Project: HBase > Issue Type: Sub-task > Components: Replication >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: HBASE-19397 > > Attachments: HBASE-19599-HBASE-19397-v1.patch, > HBASE-19599-HBASE-19397-v2.patch, HBASE-19599-HBASE-19397.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19599) Remove ReplicationQueuesClient, use ReplicationQueueStorage directly
[ https://issues.apache.org/jira/browse/HBASE-19599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302980#comment-16302980 ] Duo Zhang commented on HBASE-19599: --- Will commit after HBASE-19608 is resolved. > Remove ReplicationQueuesClient, use ReplicationQueueStorage directly > > > Key: HBASE-19599 > URL: https://issues.apache.org/jira/browse/HBASE-19599 > Project: HBase > Issue Type: Sub-task > Components: Replication >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: HBASE-19397 > > Attachments: HBASE-19599-HBASE-19397-v1.patch, > HBASE-19599-HBASE-19397-v2.patch, HBASE-19599-HBASE-19397.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19608) Race in MasterRpcServices.getProcedureResult
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19608: -- Attachment: HBASE-19608-v1.patch > Race in MasterRpcServices.getProcedureResult > > > Key: HBASE-19608 > URL: https://issues.apache.org/jira/browse/HBASE-19608 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19608-v1.patch, HBASE-19608.patch > > > In ProcedureExecutor, we only consider a procedure to be finished when it is > removed from the procedures map. But in MasterRpcServices.getProcedureResult, > we will use the state of the procedure to determine whether it is finished. > If setFailure is called, the procedure may enter the FAILED state which > indicates it is finished before being removed from the procedure map, and > then causes an assertion when we calling ProcedureExecutor.removeResult in > MasterRpcServices.getProcedureResult. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19608) Race in MasterRpcServices.getProcedureResult
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302977#comment-16302977 ] Duo Zhang commented on HBASE-19608: --- Oh, there is a typo. Let me fix. > Race in MasterRpcServices.getProcedureResult > > > Key: HBASE-19608 > URL: https://issues.apache.org/jira/browse/HBASE-19608 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19608.patch > > > In ProcedureExecutor, we only consider a procedure to be finished when it is > removed from the procedures map. But in MasterRpcServices.getProcedureResult, > we will use the state of the procedure to determine whether it is finished. > If setFailure is called, the procedure may enter the FAILED state which > indicates it is finished before being removed from the procedure map, and > then causes an assertion when we calling ProcedureExecutor.removeResult in > MasterRpcServices.getProcedureResult. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19608) Race in MasterRpcServices.getProcedureResult
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302976#comment-16302976 ] Duo Zhang commented on HBASE-19608: --- Need a review [~zghaobac] [~openinx]. The american are offline for Christmas I think. > Race in MasterRpcServices.getProcedureResult > > > Key: HBASE-19608 > URL: https://issues.apache.org/jira/browse/HBASE-19608 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19608.patch > > > In ProcedureExecutor, we only consider a procedure to be finished when it is > removed from the procedures map. But in MasterRpcServices.getProcedureResult, > we will use the state of the procedure to determine whether it is finished. > If setFailure is called, the procedure may enter the FAILED state which > indicates it is finished before being removed from the procedure map, and > then causes an assertion when we calling ProcedureExecutor.removeResult in > MasterRpcServices.getProcedureResult. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19614) CompoundBloomFilterWriter Array Instead of LinkedList
[
https://issues.apache.org/jira/browse/HBASE-19614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302975#comment-16302975
]
Ted Yu commented on HBASE-19614:
Can you group changes of using ArrayDeque under one JIRA ?
Thanks
> CompoundBloomFilterWriter Array Instead of LinkedList
> -
>
> Key: HBASE-19614
> URL: https://issues.apache.org/jira/browse/HBASE-19614
> Project: HBase
> Issue Type: Improvement
> Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Attachments: HBASE-19614.1.patch
>
>
> {quote}
> ArrayDeque:
> Resizable-array implementation of the Deque interface. Array deques have no
> capacity restrictions; they grow as necessary to support usage. They are not
> thread-safe; in the absence of external synchronization, they do not support
> concurrent access by multiple threads. Null elements are prohibited. *This
> class is likely to be faster than* Stack when used as a stack, and faster
> than *LinkedList when used as a queue.*
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[
https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302870#comment-16302870
]
Xu Jiang edited comment on HBASE-19188 at 12/25/17 12:03 AM:
-
My Hbase version is 1.1.9/1.4.0/1.2.6, and I met the same problem when
I use maven 3.5.2, but I solved it by switching 3.5.2 to 3.0.5。 When I was
building by Hbase 1.1.9/1.4.0/1.3.2，I found out there shows HBASE-19188 have
been fixed, Is there any problem?
was (Author: xujiang):
My Hbase version is 1.1.9/1.4.0/1.3.2, and I met the same problem when
I use maven 3.5.2, but I solved it by switching 3.5.2 to 3.0.5。 When I was
building by Hbase 1.1.9/1.4.0/1.3.2，I found out there shows HBASE-19188 have
been fixed, Is there any problem?
> Build fails on branch-1 using maven-3.5.2
> -
>
> Key: HBASE-19188
> URL: https://issues.apache.org/jira/browse/HBASE-19188
> Project: HBase
> Issue Type: Bug
> Components: build
>Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Blocker
> Fix For: 1.4.0, 1.3.2, 1.2.7
>
> Attachments: HBASE-19188.branch-1.2.001.patch,
> HBASE-19188.branch-1.2.002.patch
>
>
> With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and
> branch-1. On branch-1.1, branch-2 and master the build succeeds. With older
> maven versions the build finishes.
> {code:title=Maven version}
> $ mvn -v
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m;
> support was removed in 8.0
> Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
> 2017-10-18T09:58:13+02:00)
> Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2
> Java version: 1.8.0_141, vendor: Oracle Corporation
> Java home:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
> {code}
> {code}
> $ mvn clean install -DskipTests
> ...
> [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server ---
> [INFO]
> [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server ---
> [INFO] Executing tasks
> main:
> log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC).
> log4j:WARN Please initialize the log4j system properly.
> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more
> info.
> [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via
> org.mortbay.log.Slf4jLog
> java.util.MissingResourceException: Can't find bundle for base name
> org.apache.jasper.resources.LocalStrings, locale en_US
> at
> java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564)
> at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387)
> at java.util.ResourceBundle.getBundle(ResourceBundle.java:773)
> at org.apache.jasper.compiler.Localizer.(Localizer.java:36)
> at
> org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:103)
> at org.apache.jasper.JspC.initServletContext(JspC.java:1242)
> at org.apache.jasper.JspC.execute(JspC.java:1103)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
> at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154)
> at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291)
> at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
> at org.apache.tools.ant.Task.perform(Task.java:348)
> at org.apache.tools.ant.Target.execute(Target.java:390)
> at org.apache.tools.ant.Target.performTasks(Target.java:411)
> at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397)
> at org.apache.tools.ant.Project.executeTarget(Project.java:1366)
> at
> org.apache.maven.plugin.antrun.AntRunMojo.execute(AntRunMojo.java:270)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> at
>
[jira] [Commented] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[
https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302966#comment-16302966
]
Xu Jiang commented on HBASE-19188:
--
@Pater Somogyi sorry,Is Hbase 1.1.9/1.4.0/1.2.6 building problem？
> Build fails on branch-1 using maven-3.5.2
> -
>
> Key: HBASE-19188
> URL: https://issues.apache.org/jira/browse/HBASE-19188
> Project: HBase
> Issue Type: Bug
> Components: build
>Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Blocker
> Fix For: 1.4.0, 1.3.2, 1.2.7
>
> Attachments: HBASE-19188.branch-1.2.001.patch,
> HBASE-19188.branch-1.2.002.patch
>
>
> With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and
> branch-1. On branch-1.1, branch-2 and master the build succeeds. With older
> maven versions the build finishes.
> {code:title=Maven version}
> $ mvn -v
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m;
> support was removed in 8.0
> Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
> 2017-10-18T09:58:13+02:00)
> Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2
> Java version: 1.8.0_141, vendor: Oracle Corporation
> Java home:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
> {code}
> {code}
> $ mvn clean install -DskipTests
> ...
> [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server ---
> [INFO]
> [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server ---
> [INFO] Executing tasks
> main:
> log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC).
> log4j:WARN Please initialize the log4j system properly.
> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more
> info.
> [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via
> org.mortbay.log.Slf4jLog
> java.util.MissingResourceException: Can't find bundle for base name
> org.apache.jasper.resources.LocalStrings, locale en_US
> at
> java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564)
> at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387)
> at java.util.ResourceBundle.getBundle(ResourceBundle.java:773)
> at org.apache.jasper.compiler.Localizer.(Localizer.java:36)
> at
> org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:103)
> at org.apache.jasper.JspC.initServletContext(JspC.java:1242)
> at org.apache.jasper.JspC.execute(JspC.java:1103)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
> at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154)
> at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291)
> at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
> at org.apache.tools.ant.Task.perform(Task.java:348)
> at org.apache.tools.ant.Target.execute(Target.java:390)
> at org.apache.tools.ant.Target.performTasks(Target.java:411)
> at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397)
> at org.apache.tools.ant.Project.executeTarget(Project.java:1366)
> at
> org.apache.maven.plugin.antrun.AntRunMojo.execute(AntRunMojo.java:270)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions(MojoExecutor.java:353)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:198)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
> at
>
[jira] [Comment Edited] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[
https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302870#comment-16302870
]
Xu Jiang edited comment on HBASE-19188 at 12/25/17 12:00 AM:
-
My Hbase version is 1.1.9/1.4.0/1.3.2, and I met the same problem when
I use maven 3.5.2, but I solved it by switching 3.5.2 to 3.0.5。 When I was
building by Hbase 1.1.9/1.4.0/1.3.2，I found out there shows HBASE-19188 have
been fixed, Is there any problem?
was (Author: xujiang):
My Hbase version is 1.9.2/1.4.0/1.3.2, and I met the same problem when
I use maven 3.6.2, but I solved it by switching 3.5.2 to 3.0.5。 When I was
building by Hbase 1.9.2/1.4.0/1.3.2，I found out there shows HBASE-19188 have
been fixed, Is there any problem?
> Build fails on branch-1 using maven-3.5.2
> -
>
> Key: HBASE-19188
> URL: https://issues.apache.org/jira/browse/HBASE-19188
> Project: HBase
> Issue Type: Bug
> Components: build
>Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Blocker
> Fix For: 1.4.0, 1.3.2, 1.2.7
>
> Attachments: HBASE-19188.branch-1.2.001.patch,
> HBASE-19188.branch-1.2.002.patch
>
>
> With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and
> branch-1. On branch-1.1, branch-2 and master the build succeeds. With older
> maven versions the build finishes.
> {code:title=Maven version}
> $ mvn -v
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m;
> support was removed in 8.0
> Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
> 2017-10-18T09:58:13+02:00)
> Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2
> Java version: 1.8.0_141, vendor: Oracle Corporation
> Java home:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
> {code}
> {code}
> $ mvn clean install -DskipTests
> ...
> [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server ---
> [INFO]
> [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server ---
> [INFO] Executing tasks
> main:
> log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC).
> log4j:WARN Please initialize the log4j system properly.
> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more
> info.
> [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via
> org.mortbay.log.Slf4jLog
> java.util.MissingResourceException: Can't find bundle for base name
> org.apache.jasper.resources.LocalStrings, locale en_US
> at
> java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564)
> at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387)
> at java.util.ResourceBundle.getBundle(ResourceBundle.java:773)
> at org.apache.jasper.compiler.Localizer.(Localizer.java:36)
> at
> org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:103)
> at org.apache.jasper.JspC.initServletContext(JspC.java:1242)
> at org.apache.jasper.JspC.execute(JspC.java:1103)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
> at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154)
> at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291)
> at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
> at org.apache.tools.ant.Task.perform(Task.java:348)
> at org.apache.tools.ant.Target.execute(Target.java:390)
> at org.apache.tools.ant.Target.performTasks(Target.java:411)
> at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397)
> at org.apache.tools.ant.Project.executeTarget(Project.java:1366)
> at
> org.apache.maven.plugin.antrun.AntRunMojo.execute(AntRunMojo.java:270)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> at
>
[jira] [Commented] (HBASE-19614) CompoundBloomFilterWriter Array Instead of LinkedList
[
https://issues.apache.org/jira/browse/HBASE-19614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302963#comment-16302963
]
Hadoop QA commented on HBASE-19614:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
1s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
48s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
49s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
20m 15s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}113m
48s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}153m 43s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19614 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12903583/HBASE-19614.1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux a09afbcf7f30 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / c24cf2d55e |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10691/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10691/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> CompoundBloomFilterWriter Array Instead of LinkedList
>
[jira] [Commented] (HBASE-19616) Review of LogCleaner Class
[
https://issues.apache.org/jira/browse/HBASE-19616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302962#comment-16302962
]
Hadoop QA commented on HBASE-19616:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
10s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
16s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
18m 22s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 98m
41s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}134m 42s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19616 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12903585/HBASE-19616.1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux a8e052d37a5b 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / c24cf2d55e |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10693/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10693/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Review of LogCleaner Class
> --
>
> Key: HBASE-19616
>
[jira] [Commented] (HBASE-19613) Review of WALSplitter Class
[
https://issues.apache.org/jira/browse/HBASE-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302961#comment-16302961
]
Hadoop QA commented on HBASE-19613:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
41s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
6s{color} | {color:green} hbase-server: The patch generated 0 new + 47
unchanged - 4 fixed = 47 total (was 51) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
39s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
20m 0s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}113m
45s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}153m 11s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19613 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12903580/HBASE-19613.1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux d495788f8df9 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / c24cf2d55e |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10690/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10690/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Review of WALSplitter Class
>
[jira] [Commented] (HBASE-19188) Build fails on branch-1 using maven-3.5.2
[
https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302960#comment-16302960
]
Peter Somogyi commented on HBASE-19188:
---
Hi [~xujiang], could you double check the versions you mentioned? HBase 1.9.2
and maven 3.6.2 do not exist. Thanks!
> Build fails on branch-1 using maven-3.5.2
> -
>
> Key: HBASE-19188
> URL: https://issues.apache.org/jira/browse/HBASE-19188
> Project: HBase
> Issue Type: Bug
> Components: build
>Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Blocker
> Fix For: 1.4.0, 1.3.2, 1.2.7
>
> Attachments: HBASE-19188.branch-1.2.001.patch,
> HBASE-19188.branch-1.2.002.patch
>
>
> With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and
> branch-1. On branch-1.1, branch-2 and master the build succeeds. With older
> maven versions the build finishes.
> {code:title=Maven version}
> $ mvn -v
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m;
> support was removed in 8.0
> Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
> 2017-10-18T09:58:13+02:00)
> Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2
> Java version: 1.8.0_141, vendor: Oracle Corporation
> Java home:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
> {code}
> {code}
> $ mvn clean install -DskipTests
> ...
> [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server ---
> [INFO]
> [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server ---
> [INFO] Executing tasks
> main:
> log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC).
> log4j:WARN Please initialize the log4j system properly.
> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more
> info.
> [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via
> org.mortbay.log.Slf4jLog
> java.util.MissingResourceException: Can't find bundle for base name
> org.apache.jasper.resources.LocalStrings, locale en_US
> at
> java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564)
> at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387)
> at java.util.ResourceBundle.getBundle(ResourceBundle.java:773)
> at org.apache.jasper.compiler.Localizer.(Localizer.java:36)
> at
> org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:103)
> at org.apache.jasper.JspC.initServletContext(JspC.java:1242)
> at org.apache.jasper.JspC.execute(JspC.java:1103)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
> at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154)
> at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291)
> at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
> at org.apache.tools.ant.Task.perform(Task.java:348)
> at org.apache.tools.ant.Target.execute(Target.java:390)
> at org.apache.tools.ant.Target.performTasks(Target.java:411)
> at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397)
> at org.apache.tools.ant.Project.executeTarget(Project.java:1366)
> at
> org.apache.maven.plugin.antrun.AntRunMojo.execute(AntRunMojo.java:270)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions(MojoExecutor.java:353)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:198)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
> at
>
[jira] [Commented] (HBASE-19615) CompositeImmutableSegment ArrayList Instead of LinkedList
[
https://issues.apache.org/jira/browse/HBASE-19615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302959#comment-16302959
]
Hadoop QA commented on HBASE-19615:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
8s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
32s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
38s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 3s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 96m
6s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}133m 45s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19615 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12903584/HBASE-19615.1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux f0460cae42b2 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / c24cf2d55e |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10692/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10692/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> CompositeImmutableSegment ArrayList Instead of LinkedList
>
[jira] [Commented] (HBASE-19612) Review of ZKUtil Class
[
https://issues.apache.org/jira/browse/HBASE-19612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302950#comment-16302950
]
Hadoop QA commented on HBASE-19612:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
8s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
49s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
32s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 28s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
35s{color} | {color:green} hbase-zookeeper in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 35m 39s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19612 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12903581/HBASE-19612.2.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux ef6971bdcb98 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / c24cf2d55e |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10689/testReport/ |
| modules | C: hbase-zookeeper U: hbase-zookeeper |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10689/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Review of ZKUtil Class
> --
>
> Key: HBASE-19612
>
[jira] [Updated] (HBASE-19616) Review of LogCleaner Class
[ https://issues.apache.org/jira/browse/HBASE-19616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-19616: Attachment: HBASE-19616.1.patch > Review of LogCleaner Class > -- > > Key: HBASE-19616 > URL: https://issues.apache.org/jira/browse/HBASE-19616 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Trivial > Attachments: HBASE-19616.1.patch > > > * Parameterize logging > * Remove compiler-reported dead code to re-enabling useful logging > * Use ArrayList instead of LinkedList -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19616) Review of LogCleaner Class
[ https://issues.apache.org/jira/browse/HBASE-19616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-19616: Status: Patch Available (was: Open) > Review of LogCleaner Class > -- > > Key: HBASE-19616 > URL: https://issues.apache.org/jira/browse/HBASE-19616 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Trivial > Attachments: HBASE-19616.1.patch > > > * Parameterize logging > * Remove compiler-reported dead code to re-enabling useful logging > * Use ArrayList instead of LinkedList -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19616) Review of LogCleaner Class
BELUGA BEHR created HBASE-19616: --- Summary: Review of LogCleaner Class Key: HBASE-19616 URL: https://issues.apache.org/jira/browse/HBASE-19616 Project: HBase Issue Type: Improvement Components: hbase Affects Versions: 3.0.0 Reporter: BELUGA BEHR Priority: Trivial * Parameterize logging * Remove compiler-reported dead code to re-enabling useful logging * Use ArrayList instead of LinkedList -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-19616) Review of LogCleaner Class
[ https://issues.apache.org/jira/browse/HBASE-19616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR reassigned HBASE-19616: --- Assignee: BELUGA BEHR > Review of LogCleaner Class > -- > > Key: HBASE-19616 > URL: https://issues.apache.org/jira/browse/HBASE-19616 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Trivial > > * Parameterize logging > * Remove compiler-reported dead code to re-enabling useful logging > * Use ArrayList instead of LinkedList -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19615) CompositeImmutableSegment ArrayList Instead of LinkedList
[ https://issues.apache.org/jira/browse/HBASE-19615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-19615: Attachment: HBASE-19615.1.patch > CompositeImmutableSegment ArrayList Instead of LinkedList > - > > Key: HBASE-19615 > URL: https://issues.apache.org/jira/browse/HBASE-19615 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Trivial > Attachments: HBASE-19615.1.patch > > > CompositeImmutableSegment ArrayList Instead of LinkedList > The code is essentially making a copy of an existing List object that doesn't > seem to be modified, it is only being iterated over. No need to build an > entire LinkedList structure for that. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19615) CompositeImmutableSegment ArrayList Instead of LinkedList
[ https://issues.apache.org/jira/browse/HBASE-19615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-19615: Status: Patch Available (was: Open) > CompositeImmutableSegment ArrayList Instead of LinkedList > - > > Key: HBASE-19615 > URL: https://issues.apache.org/jira/browse/HBASE-19615 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Trivial > Attachments: HBASE-19615.1.patch > > > CompositeImmutableSegment ArrayList Instead of LinkedList > The code is essentially making a copy of an existing List object that doesn't > seem to be modified, it is only being iterated over. No need to build an > entire LinkedList structure for that. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-19615) CompositeImmutableSegment ArrayList Instead of LinkedList
[ https://issues.apache.org/jira/browse/HBASE-19615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR reassigned HBASE-19615: --- Assignee: BELUGA BEHR > CompositeImmutableSegment ArrayList Instead of LinkedList > - > > Key: HBASE-19615 > URL: https://issues.apache.org/jira/browse/HBASE-19615 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Trivial > Attachments: HBASE-19615.1.patch > > > CompositeImmutableSegment ArrayList Instead of LinkedList > The code is essentially making a copy of an existing List object that doesn't > seem to be modified, it is only being iterated over. No need to build an > entire LinkedList structure for that. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19615) CompositeImmutableSegment ArrayList Instead of LinkedList
BELUGA BEHR created HBASE-19615: --- Summary: CompositeImmutableSegment ArrayList Instead of LinkedList Key: HBASE-19615 URL: https://issues.apache.org/jira/browse/HBASE-19615 Project: HBase Issue Type: Improvement Components: hbase Affects Versions: 3.0.0 Reporter: BELUGA BEHR Priority: Trivial CompositeImmutableSegment ArrayList Instead of LinkedList The code is essentially making a copy of an existing List object that doesn't seem to be modified, it is only being iterated over. No need to build an entire LinkedList structure for that. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19614) CompoundBloomFilterWriter Array Instead of LinkedList
[
https://issues.apache.org/jira/browse/HBASE-19614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated HBASE-19614:
Attachment: HBASE-19614.1.patch
> CompoundBloomFilterWriter Array Instead of LinkedList
> -
>
> Key: HBASE-19614
> URL: https://issues.apache.org/jira/browse/HBASE-19614
> Project: HBase
> Issue Type: Improvement
> Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Attachments: HBASE-19614.1.patch
>
>
> {quote}
> Resizable-array implementation of the Deque interface. Array deques have no
> capacity restrictions; they grow as necessary to support usage. They are not
> thread-safe; in the absence of external synchronization, they do not support
> concurrent access by multiple threads. Null elements are prohibited. This
> class *is likely to be faster than* Stack when used as a stack, and faster
> than *LinkedList when used as a queue.*
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19614) CompoundBloomFilterWriter Array Instead of LinkedList
[
https://issues.apache.org/jira/browse/HBASE-19614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated HBASE-19614:
Description:
{quote}
ArrayDeque:
Resizable-array implementation of the Deque interface. Array deques have no
capacity restrictions; they grow as necessary to support usage. They are not
thread-safe; in the absence of external synchronization, they do not support
concurrent access by multiple threads. Null elements are prohibited. *This
class is likely to be faster than* Stack when used as a stack, and faster than
*LinkedList when used as a queue.*
{quote}
was:
{quote}
Resizable-array implementation of the Deque interface. Array deques have no
capacity restrictions; they grow as necessary to support usage. They are not
thread-safe; in the absence of external synchronization, they do not support
concurrent access by multiple threads. Null elements are prohibited. This class
*is likely to be faster than* Stack when used as a stack, and faster than
*LinkedList when used as a queue.*
{quote}
> CompoundBloomFilterWriter Array Instead of LinkedList
> -
>
> Key: HBASE-19614
> URL: https://issues.apache.org/jira/browse/HBASE-19614
> Project: HBase
> Issue Type: Improvement
> Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Attachments: HBASE-19614.1.patch
>
>
> {quote}
> ArrayDeque:
> Resizable-array implementation of the Deque interface. Array deques have no
> capacity restrictions; they grow as necessary to support usage. They are not
> thread-safe; in the absence of external synchronization, they do not support
> concurrent access by multiple threads. Null elements are prohibited. *This
> class is likely to be faster than* Stack when used as a stack, and faster
> than *LinkedList when used as a queue.*
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19614) CompoundBloomFilterWriter Array Instead of LinkedList
[
https://issues.apache.org/jira/browse/HBASE-19614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated HBASE-19614:
Status: Patch Available (was: Open)
> CompoundBloomFilterWriter Array Instead of LinkedList
> -
>
> Key: HBASE-19614
> URL: https://issues.apache.org/jira/browse/HBASE-19614
> Project: HBase
> Issue Type: Improvement
> Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Attachments: HBASE-19614.1.patch
>
>
> {quote}
> Resizable-array implementation of the Deque interface. Array deques have no
> capacity restrictions; they grow as necessary to support usage. They are not
> thread-safe; in the absence of external synchronization, they do not support
> concurrent access by multiple threads. Null elements are prohibited. This
> class *is likely to be faster than* Stack when used as a stack, and faster
> than *LinkedList when used as a queue.*
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (HBASE-19614) CompoundBloomFilterWriter Array Instead of LinkedList
[
https://issues.apache.org/jira/browse/HBASE-19614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR reassigned HBASE-19614:
---
Assignee: BELUGA BEHR
> CompoundBloomFilterWriter Array Instead of LinkedList
> -
>
> Key: HBASE-19614
> URL: https://issues.apache.org/jira/browse/HBASE-19614
> Project: HBase
> Issue Type: Improvement
> Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
>
> {quote}
> Resizable-array implementation of the Deque interface. Array deques have no
> capacity restrictions; they grow as necessary to support usage. They are not
> thread-safe; in the absence of external synchronization, they do not support
> concurrent access by multiple threads. Null elements are prohibited. This
> class *is likely to be faster than* Stack when used as a stack, and faster
> than *LinkedList when used as a queue.*
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-19614) CompoundBloomFilterWriter Array Instead of LinkedList
BELUGA BEHR created HBASE-19614:
---
Summary: CompoundBloomFilterWriter Array Instead of LinkedList
Key: HBASE-19614
URL: https://issues.apache.org/jira/browse/HBASE-19614
Project: HBase
Issue Type: Improvement
Components: hbase
Affects Versions: 3.0.0
Reporter: BELUGA BEHR
Priority: Trivial
{quote}
Resizable-array implementation of the Deque interface. Array deques have no
capacity restrictions; they grow as necessary to support usage. They are not
thread-safe; in the absence of external synchronization, they do not support
concurrent access by multiple threads. Null elements are prohibited. This class
*is likely to be faster than* Stack when used as a stack, and faster than
*LinkedList when used as a queue.*
{quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19612) Review of ZKUtil Class
[ https://issues.apache.org/jira/browse/HBASE-19612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-19612: Status: Open (was: Patch Available) > Review of ZKUtil Class > -- > > Key: HBASE-19612 > URL: https://issues.apache.org/jira/browse/HBASE-19612 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Trivial > Attachments: HBASE-19612.1.patch, HBASE-19612.2.patch > > > * Use Apache Commons where appropriate > * Use parameterized logging of SLF4J > * Fix Typos in comment > * Use Arrays Instead of LinkedLists for performance sake -- This message was sent by Atlassian JIRA (v6.4.14#64029)
