[jira] [Commented] (HBASE-19784) stop-hbase gives unfriendly message when local hbase isn't running
[ https://issues.apache.org/jira/browse/HBASE-19784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325021#comment-16325021 ] Chia-Ping Tsai commented on HBASE-19784: +1 > stop-hbase gives unfriendly message when local hbase isn't running > -- > > Key: HBASE-19784 > URL: https://issues.apache.org/jira/browse/HBASE-19784 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Minor > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19784.patch > > > {noformat} > $ bin/stop-hbase.sh > stopping hbasecat: /tmp/hbase-mdrob-master.pid: No such file or directory > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19404) Fix DisabledWALProvider
[ https://issues.apache.org/jira/browse/HBASE-19404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19404: --- Attachment: HBASE-19404.v1.patch v1 # fix the checkstyle warnings > Fix DisabledWALProvider > --- > > Key: HBASE-19404 > URL: https://issues.apache.org/jira/browse/HBASE-19404 > Project: HBase > Issue Type: Task > Components: wal >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-19404.v0.patch, HBASE-19404.v1.patch > > > {{TestFromClientSide3}} fails with {{DisabledWALProvider}}. If no use case > exists for {{DisabledWALProvider}}, we can just remove it. > Any suggestions? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19779) The chunk encountering the OOM will store in ChunkCreator forever
[ https://issues.apache.org/jira/browse/HBASE-19779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325001#comment-16325001 ] Chia-Ping Tsai commented on HBASE-19779: [~anastas] Would you please take a look? > The chunk encountering the OOM will store in ChunkCreator forever > - > > Key: HBASE-19779 > URL: https://issues.apache.org/jira/browse/HBASE-19779 > Project: HBase > Issue Type: Sub-task > Components: test >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19779.v0.patch, HBASE-19779.v1.patch > > > If Chunk#init fail on OOM, the MSLABimpl won't store the id of chunk. We have > no chance to remove the chunk from {{ChunkCreator}} since MSLABimpl have > missed the id. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19715) Fix timing out test TestMultiRespectsLimits
[ https://issues.apache.org/jira/browse/HBASE-19715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325000#comment-16325000 ] Chia-Ping Tsai commented on HBASE-19715: bq. Would making our batches smaller help? The story is about the cost of handling the exception is directly proportional to the batch size. Ya, we can add some suggestion to user about the side effect of large batch. But I think what [~appy] are trying is to reduce the cost - make it not proportional to the batch size at least. > Fix timing out test TestMultiRespectsLimits > --- > > Key: HBASE-19715 > URL: https://issues.apache.org/jira/browse/HBASE-19715 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-19715.test.patch, HBASE-19715.test.v2.patch, > failued.txt, passed.txt, screenshot-1.png, screenshot-2.png, > screenshot-3.png, screenshot-4.png, screenshot-5.png, screenshot-6.png > > > !screenshot-1.png|width=800px! > Attached logs for both cases, when it passes and fails. > Link (temporary) to logs: > passed: > http://104.198.223.121:8080/job/HBase-Flaky-Tests/33449/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.client.TestMultiRespectsLimits-output.txt/*view*/ > failed: > http://104.198.223.121:8080/job/HBase-Flaky-Tests/33455/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.client.TestMultiRespectsLimits-output.txt/*view*/ > Correlating across more runs, whenever the tests passes, it does so within > 10-30sec of 3min deadline for medium tests. > So i think we can make it pass by just increasing the timeout. > But I'm a bit skeptical after seeing all those long GC pauses (10sec +) in > the log. Test code doesn't seem to be doing anything that intensive. Are we > mismanaging the memory somewhere? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19772) Do not close connection to zk when there are still pending request in ReadOnlyZKClient
[ https://issues.apache.org/jira/browse/HBASE-19772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324979#comment-16324979 ] stack commented on HBASE-19772: --- [~Apache9] no sir. They would have been before the patch. You want those? (With your help), I no longer trust this set of hosts. They are too erratic. They've helped figure a few places where we could be more defensive around zk setups but here where we have these unexplained hangs, not only running tests of this patch, but hangs building RCs, I need to spend time figuring whats up w/ these machines. Have been using rented resources. Let me test your patch there. Will be back. > Do not close connection to zk when there are still pending request in > ReadOnlyZKClient > -- > > Key: HBASE-19772 > URL: https://issues.apache.org/jira/browse/HBASE-19772 > Project: HBase > Issue Type: Sub-task > Components: Zookeeper >Reporter: stack >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19772-v2.patch, HBASE-19772.master.001.patch > > > Here is [~Apache9] 's patch from the parent so it applies on top of what was > committed in the parent. > Patch makes it so we we don't close out zk if available Tasks to run and > nicer logging. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19196) Release hbase-2.0.0-beta-1; the "Finish-line" release
[ https://issues.apache.org/jira/browse/HBASE-19196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324976#comment-16324976 ] stack commented on HBASE-19196: --- I think hanging builds are bad machine. Building local again. Takes forever but succeeds. No hang. Put up RC2 this morning but then realized (Appy posted dashboard for branch-2 and I ran a GCE build over night which showed failing tests) how many tests failed so squashed it. Put up RC3 just now after fixing a load of tests. Build takes two and a half hours (seems way longer). Used dev-support/make_rc.sh. If anything is off, e.g. machine reboots because it OOMEs, have to start over. Here is where time is spent: 05:00 min clean, ratcheck... 12:00 min building and downloading dependencies 54 min archetype bullshit? 48:21 min uploading to mvn repo > Release hbase-2.0.0-beta-1; the "Finish-line" release > - > > Key: HBASE-19196 > URL: https://issues.apache.org/jira/browse/HBASE-19196 > Project: HBase > Issue Type: Bug >Reporter: stack >Priority: Blocker > Fix For: 2.0.0-beta-1 > > > APIs done, but external facing and Coprocessors. Done w/ features. Bug fixes > only from here on out. There'll be a beta-2 but that is about rolling upgrade > and bug fixes only. Then our first 2.0.0 Release Candidate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19787) Fix or disable tests broken in branch-2 so can cut beta-1
[ https://issues.apache.org/jira/browse/HBASE-19787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324959#comment-16324959 ] Hudson commented on HBASE-19787: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4391 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4391/]) HBASE-19787 Fix or disable tests broken in branch-2 so can cut beta-1 (stack: rev 4ddfecac563384de6f087fc7fc8bc62c0362877d) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestJMXConnectorServer.java * (edit) dev-support/make_rc.sh * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestRegionsOnMasterOptions.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestFavoredStochasticLoadBalancer.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDLSFSHLog.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReadRequestMetrics.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestTableStateManager.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDLSAsyncFSWAL.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestZKAsyncRegistry.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java > Fix or disable tests broken in branch-2 so can cut beta-1 > - > > Key: HBASE-19787 > URL: https://issues.apache.org/jira/browse/HBASE-19787 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19787.branch-2.001.patch > > > Appy's dashboard for 2.0 > https://builds.apache.org/job/HBase-Find-Flaky-Tests-branch2.0/lastSuccessfulBuild/artifact/dashboard.html > and a GCE run last night showed how bad of a state our unit tests are in on > tip of branch-2. This issue does triage fixing and disabling so I can push > out the beta-1. Its done as a subtask of HBASE-19694 because a few of the > tests were broke by this commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19780) Change execution phase of checkstyle plugin back to default 'verify'
[ https://issues.apache.org/jira/browse/HBASE-19780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324942#comment-16324942 ] Hadoop QA commented on HBASE-19780: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 10s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} branch-2 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 35s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 21s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 10m 49s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 40s{color} | {color:green} branch-2 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 5s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 1 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 9s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 48s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 14m 10s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 17s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green}137m 5s{color} | {color:green} root in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 2m 29s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}179m 25s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db | | JIRA Issue | HBASE-19780 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12905964/HBASE-19780.branch-2.001.patch | | Optional Tests | asflicense javac javadoc unit shadedjars hadoopcheck xml compile | | uname | Linux 2997e285f016 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | branch-2 / f91589d305 | | maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) | | Default Java | 1.8.0_151 | | whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/11056/artifact/patchprocess/whitespace-tabs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11056/testReport/ | | modules | C: hbase-build-support/hbase-error-prone hbase-annotations hbase-protocol-shaded hbase-metrics-api hbase-metrics hbase-external-blockcache hbase-archetypes . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11056/console | | Powered by | Apache Yetus 0.6.0 http://yetus.apache.org | This message was automatically generated. > Change execution
[jira] [Commented] (HBASE-19789) Exclude flaky tests from nightly branch-2 runs
[ https://issues.apache.org/jira/browse/HBASE-19789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324939#comment-16324939 ] stack commented on HBASE-19789: --- On second thoughts, excluding flakies from hadoopqa makes sense but not from these nightly builds. We need the dashboard for figuring if transient or permanent failures but better to have the nightly keep failing till flakies, etc., so know what is to be fixed. What you reckon [~appy] > Exclude flaky tests from nightly branch-2 runs > -- > > Key: HBASE-19789 > URL: https://issues.apache.org/jira/browse/HBASE-19789 > Project: HBase > Issue Type: Improvement >Reporter: Appy >Assignee: Appy > Attachments: HBASE-19789.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19790) Fix compatibility break in 1.3.2-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-19790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324932#comment-16324932 ] Hadoop QA commented on HBASE-19790: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} branch-1.3 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 15s{color} | {color:green} branch-1.3 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_152 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_161 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 24s{color} | {color:green} branch-1.3 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 53s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 57s{color} | {color:green} branch-1.3 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_152 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 34s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_161 {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 34s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 34s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 18s{color} | {color:green} hbase-server: The patch generated 0 new + 378 unchanged - 1 fixed = 378 total (was 379) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m 24s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 9m 52s{color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.4. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 74m 35s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 19s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}107m 36s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.regionserver.TestEndToEndSplitTransaction | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce
[jira] [Commented] (HBASE-19784) stop-hbase gives unfriendly message when local hbase isn't running
[ https://issues.apache.org/jira/browse/HBASE-19784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324913#comment-16324913 ] stack commented on HBASE-19784: --- +1 Nice > stop-hbase gives unfriendly message when local hbase isn't running > -- > > Key: HBASE-19784 > URL: https://issues.apache.org/jira/browse/HBASE-19784 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Minor > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19784.patch > > > {noformat} > $ bin/stop-hbase.sh > stopping hbasecat: /tmp/hbase-mdrob-master.pid: No such file or directory > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19663) site build fails complaining "javadoc: error - class file for javax.annotation.meta.TypeQualifierNickname not found"
[ https://issues.apache.org/jira/browse/HBASE-19663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324910#comment-16324910 ] stack commented on HBASE-19663: --- [~zyork] I think [~appy] and [~Jan Hentschel] have figured it over in HBASE-19780 > site build fails complaining "javadoc: error - class file for > javax.annotation.meta.TypeQualifierNickname not found" > > > Key: HBASE-19663 > URL: https://issues.apache.org/jira/browse/HBASE-19663 > Project: HBase > Issue Type: Bug > Components: site >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-beta-2 > > Attachments: script.sh > > > Cryptic failure trying to build beta-1 RC. Fails like this: > {code} > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 03:54 min > [INFO] Finished at: 2017-12-29T01:13:15-08:00 > [INFO] Final Memory: 381M/9165M > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project > hbase: Error generating maven-javadoc-plugin:2.10.3:aggregate: > [ERROR] Exit code: 1 - warning: unknown enum constant When.ALWAYS > [ERROR] reason: class file for javax.annotation.meta.When not found > [ERROR] warning: unknown enum constant When.UNKNOWN > [ERROR] warning: unknown enum constant When.MAYBE > [ERROR] > /home/stack/hbase.git/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:762: > warning - Tag @link: malformed: "#matchingRows(Cell, byte[]))" > [ERROR] > /home/stack/hbase.git/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:762: > warning - Tag @link: reference not found: #matchingRows(Cell, byte[])) > [ERROR] > /home/stack/hbase.git/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:762: > warning - Tag @link: reference not found: #matchingRows(Cell, byte[])) > [ERROR] javadoc: warning - Class javax.annotation.Nonnull not found. > [ERROR] javadoc: error - class file for > javax.annotation.meta.TypeQualifierNickname not found > [ERROR] > [ERROR] Command line was: /home/stack/bin/jdk1.8.0_151/jre/../bin/javadoc > -J-Xmx2G @options @packages > [ERROR] > [ERROR] Refer to the generated Javadoc files in > '/home/stack/hbase.git/target/site/apidocs' dir. > [ERROR] -> [Help 1] > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the -e > switch. > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > [ERROR] > [ERROR] For more information about the errors and possible solutions, please > read the following articles: > [ERROR] [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException > {code} > javax.annotation.meta.TypeQualifierNickname is out of jsr305 but we don't > include this anywhere according to mvn dependency. > Happens building the User API both test and main. > Excluding these lines gets us passing again: > {code} > 3511 > 3512 > org.apache.yetus.audience.tools.IncludePublicAnnotationsStandardDoclet > 3513 > 3514 > 3515 org.apache.yetus > 3516 audience-annotations > 3517 ${audience-annotations.version} > 3518 > + 3519 true > {code} > Tried upgrading to newer mvn site (ours is three years old) but that a > different set of problems. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19790) Fix compatibility break in 1.3.2-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-19790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324909#comment-16324909 ] Hudson commented on HBASE-19790: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #335 (See [https://builds.apache.org/job/HBase-1.3-IT/335/]) HBASE-19790 Fix compatibility break in 1.3.2-SNAPSHOT (apurtell: rev b6f4f511a6ab4491df526efd70ef7736812eb924) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/snapshot/FlushSnapshotSubprocedure.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java > Fix compatibility break in 1.3.2-SNAPSHOT > - > > Key: HBASE-19790 > URL: https://issues.apache.org/jira/browse/HBASE-19790 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.2 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Blocker > Fix For: 1.3.2 > > Attachments: HBASE-19790-branch-1.3.patch > > > This change is disallowed in a patch release: > {code} > package org.apache.hadoop.hbase.regionserver > interface Region > Abstract method closeRegionOperation ( Region.Operation ) has been added to > this interface. > Recompilation of a client program may be terminated with the message: a > client class C is not abstract and does not override abstract method > closeRegionOperation ( Region.Operation ) in Region. > {code} > Region is a LimitedPrivate(COPROC) interface. > See https://hbase.apache.org/book.html#hbase.versioning > {quote} > New APIs introduced in a patch version will only be added in a source > compatible way [1]: i.e. code that implements public APIs will continue to > compile. > {quote} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19789) Exclude flaky tests from nightly branch-2 runs
[ https://issues.apache.org/jira/browse/HBASE-19789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324908#comment-16324908 ] stack commented on HBASE-19789: --- I see excludes per branch but not includes? Otherwise, this is great. > Exclude flaky tests from nightly branch-2 runs > -- > > Key: HBASE-19789 > URL: https://issues.apache.org/jira/browse/HBASE-19789 > Project: HBase > Issue Type: Improvement >Reporter: Appy >Assignee: Appy > Attachments: HBASE-19789.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19790) Fix compatibility break in 1.3.2-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-19790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19790: --- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to branch-1.3. > Fix compatibility break in 1.3.2-SNAPSHOT > - > > Key: HBASE-19790 > URL: https://issues.apache.org/jira/browse/HBASE-19790 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.2 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Blocker > Fix For: 1.3.2 > > Attachments: HBASE-19790-branch-1.3.patch > > > This change is disallowed in a patch release: > {code} > package org.apache.hadoop.hbase.regionserver > interface Region > Abstract method closeRegionOperation ( Region.Operation ) has been added to > this interface. > Recompilation of a client program may be terminated with the message: a > client class C is not abstract and does not override abstract method > closeRegionOperation ( Region.Operation ) in Region. > {code} > Region is a LimitedPrivate(COPROC) interface. > See https://hbase.apache.org/book.html#hbase.versioning > {quote} > New APIs introduced in a patch version will only be added in a source > compatible way [1]: i.e. code that implements public APIs will continue to > compile. > {quote} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19757) System table gets stuck after enabling region server group feature in secure cluster
[ https://issues.apache.org/jira/browse/HBASE-19757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324901#comment-16324901 ] Hadoop QA commented on HBASE-19757: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s{color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 2s{color} | {color:blue} The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for instructions. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 35s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 49s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 41s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 20m 49s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 17s{color} | {color:green} hbase-rsgroup in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 9s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 40m 30s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 | | JIRA Issue | HBASE-19757 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12905970/19757.v3.txt | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 070e95c25397 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 4ddfecac56 | | maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) | | Default Java | 1.8.0_151 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11058/testReport/ | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11058/console | | Powered by | Apache Yetus 0.6.0 http://yetus.apache.org | This
[jira] [Commented] (HBASE-19769) IllegalAccessError on package-private Hadoop metrics2 classes in MapReduce jobs
[ https://issues.apache.org/jira/browse/HBASE-19769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324902#comment-16324902 ] stack commented on HBASE-19769: --- [~elserj] RN? And this incompat change given it shipped in 1.4? Might want to note it. Good on you Josh. > IllegalAccessError on package-private Hadoop metrics2 classes in MapReduce > jobs > --- > > Key: HBASE-19769 > URL: https://issues.apache.org/jira/browse/HBASE-19769 > Project: HBase > Issue Type: Bug > Components: mapreduce, metrics >Affects Versions: 2.0.0-beta-1 >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19769.001.branch-2.patch > > > issues for context: HBASE-17170, HBASE-17448, TEZ-3299, HADOOP-10893 > Since Hadoop 2.6.0, the {{yarn jar}} entry point to submit a YARN job has > been using a custom classloader to separate Hadoop dependencies from the > user's JAR being run. A separate classloader is created for the user-provided > jar, and then this classloader is set as the contextClassLoader before the > Tool is executed by Hadoop's RunJar class. This has been (mostly?) fine for > us to date because we don't try to access any Hadoop internal classes > client-side. > However, with the ZK metrics, clients are pushing ZK metrics to metrics2. The > problem is that Hadoop metrics2 implementations which we reference from the > same package are loaded by a different classloader than our HBase code is > loaded from. This makes the expected package-private access of these Metrics2 > classes (e.g. MetricsInfoImpl) fail with an IllegalAccessError. > {noformat} > java.lang.RuntimeException: Could not create interface > org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSource Is the hadoop > compatibility jar on the classpath? > at > org.apache.hadoop.hbase.CompatibilitySingletonFactory.getInstance(CompatibilitySingletonFactory.java:75) > at > org.apache.hadoop.hbase.zookeeper.ZKMetrics.(ZKMetrics.java:36) > at > org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.(RecoverableZooKeeper.java:115) > at org.apache.hadoop.hbase.zookeeper.ZKUtil.connect(ZKUtil.java:139) > at > org.apache.hadoop.hbase.zookeeper.ZKWatcher.(ZKWatcher.java:128) > at > org.apache.hadoop.hbase.zookeeper.ZKWatcher.(ZKWatcher.java:102) > at > org.apache.hadoop.hbase.security.token.TokenUtil.getAuthToken(TokenUtil.java:293) > at > org.apache.hadoop.hbase.security.token.TokenUtil.addTokenForJob(TokenUtil.java:259) > at > org.apache.hadoop.hbase.mapreduce.TableMapReduceUtil.initCredentials(TableMapReduceUtil.java:535) > at > org.apache.phoenix.mapreduce.MultiHfileOutputFormat.configureIncrementalLoad(MultiHfileOutputFormat.java:712) > at > org.apache.phoenix.mapreduce.AbstractBulkLoadTool.submitJob(AbstractBulkLoadTool.java:300) > at > org.apache.phoenix.mapreduce.AbstractBulkLoadTool.loadData(AbstractBulkLoadTool.java:267) > at > org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(AbstractBulkLoadTool.java:180) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90) > at > org.apache.phoenix.mapreduce.CsvBulkLoadTool.main(CsvBulkLoadTool.java:109) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:239) > at org.apache.hadoop.util.RunJar.main(RunJar.java:153) > Caused by: java.util.ServiceConfigurationError: > org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSource: Provider > org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSourceImpl could not be > instantiated > at java.util.ServiceLoader.fail(ServiceLoader.java:232) > at java.util.ServiceLoader.access$100(ServiceLoader.java:185) > at > java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:384) > at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404) > at java.util.ServiceLoader$1.next(ServiceLoader.java:480) > at > org.apache.hadoop.hbase.CompatibilitySingletonFactory.getInstance(CompatibilitySingletonFactory.java:59) > ... 21 more > Caused by: java.lang.IllegalAccessError: tried to access class > org.apache.hadoop.metrics2.lib.MetricsInfoImpl from class > org.apache.hadoop.metrics2.lib.DynamicMetricsRegistry > at >
[jira] [Commented] (HBASE-19757) System table gets stuck after enabling region server group feature in secure cluster
[ https://issues.apache.org/jira/browse/HBASE-19757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324870#comment-16324870 ] Ted Yu commented on HBASE-19757: TestRSGroupsWithACL passes on master branch with patch. Without patch, it times out due to acl table stuck in transition. > System table gets stuck after enabling region server group feature in secure > cluster > > > Key: HBASE-19757 > URL: https://issues.apache.org/jira/browse/HBASE-19757 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 19757.v1.txt, 19757.v2.txt, 19757.v3.txt > > > I was testing on an hbase-2 secure cluster against hadoop 3 where some tables > were created without region server group feature. > After adding the RSGroupAdminEndpoint and RSGroupBasedLoadBalancer to > hbase-site, I restarted the whole cluster. > After the restart, hbase:meta region got stuck in transition (forever). > {code} > 2018-01-10 21:20:16,696 INFO > [org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker-ctr-e137-1514896590304-8706-01-02.hwx.site,2,1515619212617] > zookeeper.MetaTableLocator: Failed verification of hbase:meta,,1 at > address=ctr-e137-1514896590304-8706-01-04.hwx.site,16020,1515618538016, > exception=org.apache.hadoop.hbase.NotServingRegionException: > hbase:meta,,1 is not online on > ctr-e137-1514896590304-8706-01-04.hwx.site,16020,1515619181453 > at > org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3314) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3291) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1355) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegionInfo(RSRpcServices.java:1667) > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19790) Fix compatibility break in 1.3.2-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-19790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324871#comment-16324871 ] Andrew Purtell commented on HBASE-19790: I'm going to commit this trivial patch that fixes a compat break soon so I can get a snapshot of 1.3.2 out. We can revert it later if someone would like to do this differently. > Fix compatibility break in 1.3.2-SNAPSHOT > - > > Key: HBASE-19790 > URL: https://issues.apache.org/jira/browse/HBASE-19790 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.2 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Blocker > Fix For: 1.3.2 > > Attachments: HBASE-19790-branch-1.3.patch > > > This change is disallowed in a patch release: > {code} > package org.apache.hadoop.hbase.regionserver > interface Region > Abstract method closeRegionOperation ( Region.Operation ) has been added to > this interface. > Recompilation of a client program may be terminated with the message: a > client class C is not abstract and does not override abstract method > closeRegionOperation ( Region.Operation ) in Region. > {code} > Region is a LimitedPrivate(COPROC) interface. > See https://hbase.apache.org/book.html#hbase.versioning > {quote} > New APIs introduced in a patch version will only be added in a source > compatible way [1]: i.e. code that implements public APIs will continue to > compile. > {quote} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19790) Fix compatibility break in 1.3.2-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-19790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19790: --- Status: Patch Available (was: Open) > Fix compatibility break in 1.3.2-SNAPSHOT > - > > Key: HBASE-19790 > URL: https://issues.apache.org/jira/browse/HBASE-19790 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.2 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Blocker > Fix For: 1.3.2 > > Attachments: HBASE-19790-branch-1.3.patch > > > This change is disallowed in a patch release: > {code} > package org.apache.hadoop.hbase.regionserver > interface Region > Abstract method closeRegionOperation ( Region.Operation ) has been added to > this interface. > Recompilation of a client program may be terminated with the message: a > client class C is not abstract and does not override abstract method > closeRegionOperation ( Region.Operation ) in Region. > {code} > Region is a LimitedPrivate(COPROC) interface. > See https://hbase.apache.org/book.html#hbase.versioning > {quote} > New APIs introduced in a patch version will only be added in a source > compatible way [1]: i.e. code that implements public APIs will continue to > compile. > {quote} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19790) Fix compatibility break in 1.3.2-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-19790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19790: --- Attachment: HBASE-19790-branch-1.3.patch Very easy fix. Leave the bug fix in place, just drop the change from the interface. > Fix compatibility break in 1.3.2-SNAPSHOT > - > > Key: HBASE-19790 > URL: https://issues.apache.org/jira/browse/HBASE-19790 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.2 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Blocker > Fix For: 1.3.2 > > Attachments: HBASE-19790-branch-1.3.patch > > > This change is disallowed in a patch release: > {code} > package org.apache.hadoop.hbase.regionserver > interface Region > Abstract method closeRegionOperation ( Region.Operation ) has been added to > this interface. > Recompilation of a client program may be terminated with the message: a > client class C is not abstract and does not override abstract method > closeRegionOperation ( Region.Operation ) in Region. > {code} > Region is a LimitedPrivate(COPROC) interface. > See https://hbase.apache.org/book.html#hbase.versioning > {quote} > New APIs introduced in a patch version will only be added in a source > compatible way [1]: i.e. code that implements public APIs will continue to > compile. > {quote} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19757) System table gets stuck after enabling region server group feature in secure cluster
[ https://issues.apache.org/jira/browse/HBASE-19757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19757: --- Summary: System table gets stuck after enabling region server group feature in secure cluster (was: hbase:meta table gets stuck after enabling region server group feature) > System table gets stuck after enabling region server group feature in secure > cluster > > > Key: HBASE-19757 > URL: https://issues.apache.org/jira/browse/HBASE-19757 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 19757.v1.txt, 19757.v2.txt, 19757.v3.txt > > > I was testing on an hbase-2 secure cluster against hadoop 3 where some tables > were created without region server group feature. > After adding the RSGroupAdminEndpoint and RSGroupBasedLoadBalancer to > hbase-site, I restarted the whole cluster. > After the restart, hbase:meta region got stuck in transition (forever). > {code} > 2018-01-10 21:20:16,696 INFO > [org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker-ctr-e137-1514896590304-8706-01-02.hwx.site,2,1515619212617] > zookeeper.MetaTableLocator: Failed verification of hbase:meta,,1 at > address=ctr-e137-1514896590304-8706-01-04.hwx.site,16020,1515618538016, > exception=org.apache.hadoop.hbase.NotServingRegionException: > hbase:meta,,1 is not online on > ctr-e137-1514896590304-8706-01-04.hwx.site,16020,1515619181453 > at > org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3314) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3291) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1355) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegionInfo(RSRpcServices.java:1667) > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19757) hbase:meta table gets stuck after enabling region server group feature
[ https://issues.apache.org/jira/browse/HBASE-19757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19757: --- Status: Patch Available (was: Open) > hbase:meta table gets stuck after enabling region server group feature > -- > > Key: HBASE-19757 > URL: https://issues.apache.org/jira/browse/HBASE-19757 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 19757.v1.txt, 19757.v2.txt, 19757.v3.txt > > > I was testing on an hbase-2 secure cluster against hadoop 3 where some tables > were created without region server group feature. > After adding the RSGroupAdminEndpoint and RSGroupBasedLoadBalancer to > hbase-site, I restarted the whole cluster. > After the restart, hbase:meta region got stuck in transition (forever). > {code} > 2018-01-10 21:20:16,696 INFO > [org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker-ctr-e137-1514896590304-8706-01-02.hwx.site,2,1515619212617] > zookeeper.MetaTableLocator: Failed verification of hbase:meta,,1 at > address=ctr-e137-1514896590304-8706-01-04.hwx.site,16020,1515618538016, > exception=org.apache.hadoop.hbase.NotServingRegionException: > hbase:meta,,1 is not online on > ctr-e137-1514896590304-8706-01-04.hwx.site,16020,1515619181453 > at > org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3314) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3291) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1355) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegionInfo(RSRpcServices.java:1667) > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19757) hbase:meta table gets stuck after enabling region server group feature
[ https://issues.apache.org/jira/browse/HBASE-19757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19757: --- Attachment: 19757.v3.txt > hbase:meta table gets stuck after enabling region server group feature > -- > > Key: HBASE-19757 > URL: https://issues.apache.org/jira/browse/HBASE-19757 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 19757.v1.txt, 19757.v2.txt, 19757.v3.txt > > > I was testing on an hbase-2 secure cluster against hadoop 3 where some tables > were created without region server group feature. > After adding the RSGroupAdminEndpoint and RSGroupBasedLoadBalancer to > hbase-site, I restarted the whole cluster. > After the restart, hbase:meta region got stuck in transition (forever). > {code} > 2018-01-10 21:20:16,696 INFO > [org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker-ctr-e137-1514896590304-8706-01-02.hwx.site,2,1515619212617] > zookeeper.MetaTableLocator: Failed verification of hbase:meta,,1 at > address=ctr-e137-1514896590304-8706-01-04.hwx.site,16020,1515618538016, > exception=org.apache.hadoop.hbase.NotServingRegionException: > hbase:meta,,1 is not online on > ctr-e137-1514896590304-8706-01-04.hwx.site,16020,1515619181453 > at > org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3314) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3291) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1355) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegionInfo(RSRpcServices.java:1667) > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19780) Change execution phase of checkstyle plugin back to default 'verify'
[ https://issues.apache.org/jira/browse/HBASE-19780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324846#comment-16324846 ] Hadoop QA commented on HBASE-19780: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 22s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 31s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 39s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 14m 11s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m 20s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 5s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 5s{color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 5s{color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 5s{color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 1 line(s) with tabs. {color} | | {color:red}-1{color} | {color:red} xml {color} | {color:red} 0m 17s{color} | {color:red} The patch has 1 ill-formed XML file(s). {color} | | {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 0m 22s{color} | {color:red} patch has 12 errors when building our shaded downstream artifacts. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m 27s{color} | {color:red} The patch causes 12 errors with Hadoop v2.6.5. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m 32s{color} | {color:red} The patch causes 12 errors with Hadoop v2.7.4. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m 37s{color} | {color:red} The patch causes 12 errors with Hadoop v3.0.0. {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 5s{color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 4s{color} | {color:red} hbase-hadoop-compat in the patch failed. {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 6s{color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 26s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 26m 52s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 | | JIRA Issue | HBASE-19780 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12905966/HBASE-19780.master.002.patch | | Optional Tests | asflicense javac javadoc unit shadedjars hadoopcheck xml compile | | uname | Linux 0b52db431bea 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 4ddfecac56 | | maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) | | Default Java | 1.8.0_151 | | mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/11057/artifact/patchprocess/patch-mvninstall-root.txt | | compile |
[jira] [Updated] (HBASE-19790) Fix compatibility break in 1.3.2-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-19790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19790: --- Description: This change is disallowed in a patch release: {code} package org.apache.hadoop.hbase.regionserver interface Region Abstract method closeRegionOperation ( Region.Operation ) has been added to this interface. Recompilation of a client program may be terminated with the message: a client class C is not abstract and does not override abstract method closeRegionOperation ( Region.Operation ) in Region. {code} Region is a LimitedPrivate(COPROC) interface. See https://hbase.apache.org/book.html#hbase.versioning {quote} New APIs introduced in a patch version will only be added in a source compatible way [1]: i.e. code that implements public APIs will continue to compile. {quote} was: This change is disallowed in a patch release: {code} package org.apache.hadoop.hbase.regionserver interface Region Abstract method closeRegionOperation ( Region.Operation ) has been added to this interface. Recompilation of a client program may be terminated with the message: a client class C is not abstract and does not override abstract method closeRegionOperation ( Region.Operation ) in Region. {code} Table is a Public interface. See https://hbase.apache.org/book.html#hbase.versioning {quote} New APIs introduced in a patch version will only be added in a source compatible way [1]: i.e. code that implements public APIs will continue to compile. {quote} > Fix compatibility break in 1.3.2-SNAPSHOT > - > > Key: HBASE-19790 > URL: https://issues.apache.org/jira/browse/HBASE-19790 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.2 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Blocker > Fix For: 1.3.2 > > > This change is disallowed in a patch release: > {code} > package org.apache.hadoop.hbase.regionserver > interface Region > Abstract method closeRegionOperation ( Region.Operation ) has been added to > this interface. > Recompilation of a client program may be terminated with the message: a > client class C is not abstract and does not override abstract method > closeRegionOperation ( Region.Operation ) in Region. > {code} > Region is a LimitedPrivate(COPROC) interface. > See https://hbase.apache.org/book.html#hbase.versioning > {quote} > New APIs introduced in a patch version will only be added in a source > compatible way [1]: i.e. code that implements public APIs will continue to > compile. > {quote} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19790) Fix compatibility break in 1.3.2-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-19790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324832#comment-16324832 ] Andrew Purtell commented on HBASE-19790: The commit which brought this in is commit 52c2dcbaa321705df143e1dc9dca28c849f8f9bb Author: Ashu PachauriDate: Mon Aug 7 18:10:33 2017 -0700 HBASE-18398: Snapshot operation fails with FileNotFoundException > Fix compatibility break in 1.3.2-SNAPSHOT > - > > Key: HBASE-19790 > URL: https://issues.apache.org/jira/browse/HBASE-19790 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.2 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Blocker > Fix For: 1.3.2 > > > This change is disallowed in a patch release: > {code} > package org.apache.hadoop.hbase.regionserver > interface Region > Abstract method closeRegionOperation ( Region.Operation ) has been added to > this interface. > Recompilation of a client program may be terminated with the message: a > client class C is not abstract and does not override abstract method > closeRegionOperation ( Region.Operation ) in Region. > {code} > Table is a Public interface. > See https://hbase.apache.org/book.html#hbase.versioning > {quote} > New APIs introduced in a patch version will only be added in a source > compatible way [1]: i.e. code that implements public APIs will continue to > compile. > {quote} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19790) Fix compatibility break in 1.3.2-SNAPSHOT
Andrew Purtell created HBASE-19790: -- Summary: Fix compatibility break in 1.3.2-SNAPSHOT Key: HBASE-19790 URL: https://issues.apache.org/jira/browse/HBASE-19790 Project: HBase Issue Type: Bug Affects Versions: 1.3.2 Reporter: Andrew Purtell Assignee: Andrew Purtell Priority: Blocker Fix For: 1.3.2 This change is disallowed in a patch release: {code} package org.apache.hadoop.hbase.regionserver interface Region Abstract method closeRegionOperation ( Region.Operation ) has been added to this interface. Recompilation of a client program may be terminated with the message: a client class C is not abstract and does not override abstract method closeRegionOperation ( Region.Operation ) in Region. {code} Table is a Public interface. See https://hbase.apache.org/book.html#hbase.versioning {quote} New APIs introduced in a patch version will only be added in a source compatible way [1]: i.e. code that implements public APIs will continue to compile. {quote} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19694) The initialization order for a fresh cluster is incorrect
[ https://issues.apache.org/jira/browse/HBASE-19694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324811#comment-16324811 ] Hudson commented on HBASE-19694: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4390 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4390/]) HBASE-19694 The initialization order for a fresh cluster is incorrect (stack: rev c799b0e69bed5f0e894a703bcfbd208f44c980e7) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java > The initialization order for a fresh cluster is incorrect > - > > Key: HBASE-19694 > URL: https://issues.apache.org/jira/browse/HBASE-19694 > Project: HBase > Issue Type: Bug >Reporter: Duo Zhang >Assignee: stack >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: 0001-HBASE-19694.addendum.branch-2.patch, > HBASE-19694.branch-2.001.patch, HBASE-19694.branch-2.002.patch, > HBASE-19694.branch-2.003.patch, HBASE-19694.branch-2.004.patch, > HBASE-19694.branch-2.005.patch, HBASE-19694.branch-2.006.patch, > HBASE-19694.branch-2.007.patch, HBASE-19694.branch-2.008.patch, > HBASE-19694.branch-2.009.patch, HBASE-19694.branch-2.010.patch, > HBASE-19694.branch-2.011.patch, HBASE-19694.branch-2.012.patch > > > The cluster id will set once we become the active master in > finishActiveMasterInitialization, but the blockUntilBecomingActiveMaster and > finishActiveMasterInitialization are both called in a thread to make the > constructor of HMaster return without blocking. And since HMaster itself is > also a HRegionServer, it will create a Connection and then start calling > reportForDuty. And when creating the ConnectionImplementation, we will read > the cluster id from zk, but the cluster id may have not been set yet since it > is set in another thread, we will get an exception and use the default > cluster id instead. > I always get this when running UTs which will start a mini cluster > {noformat} > 2018-01-03 15:16:37,916 WARN [M:0;zhangduo-ubuntu:32848] > client.ConnectionImplementation(528): Retrieve cluster id failed > java.util.concurrent.ExecutionException: > org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = > NoNode for /hbase/hbaseid > at > java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357) > at > java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1895) > at > org.apache.hadoop.hbase.client.ConnectionImplementation.retrieveClusterId(ConnectionImplementation.java:526) > at > org.apache.hadoop.hbase.client.ConnectionImplementation.(ConnectionImplementation.java:286) > at > org.apache.hadoop.hbase.client.ConnectionUtils$ShortCircuitingClusterConnection.(ConnectionUtils.java:141) > at > org.apache.hadoop.hbase.client.ConnectionUtils$ShortCircuitingClusterConnection.(ConnectionUtils.java:137) > at > org.apache.hadoop.hbase.client.ConnectionUtils.createShortCircuitConnection(ConnectionUtils.java:185) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.createClusterConnection(HRegionServer.java:781) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.setupClusterConnection(HRegionServer.java:812) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:827) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:938) > at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:550) > at java.lang.Thread.run(Thread.java:748) > Caused by: org.apache.zookeeper.KeeperException$NoNodeException: > KeeperErrorCode = NoNode for /hbase/hbaseid > at org.apache.zookeeper.KeeperException.create(KeeperException.java:111) > at org.apache.zookeeper.KeeperException.create(KeeperException.java:51) > at > org.apache.hadoop.hbase.zookeeper.ReadOnlyZKClient$ZKTask$1.exec(ReadOnlyZKClient.java:163) > at > org.apache.hadoop.hbase.zookeeper.ReadOnlyZKClient.run(ReadOnlyZKClient.java:311) > ... 1 more > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324810#comment-16324810 ] Hudson commented on HBASE-19752: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4390 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4390/]) HBASE-19752 RSGroupBasedLoadBalancer#getMisplacedRegions() should handle (tedyu: rev f0ba7922f3963276304aee1d354413bcf966e563) * (edit) hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/master/balancer/TestRSGroupBasedLoadBalancer.java * (edit) hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java > RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where > rs group cannot be determined > - > > Key: HBASE-19752 > URL: https://issues.apache.org/jira/browse/HBASE-19752 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.1, 1.5.0, 2.0.0-beta-1 > > Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt, > 19752.v5.txt, 19752.v6.txt, 19752.v7.branch-1.txt, 19752.v7.txt > > > Observed the following in rs group test output: > {code} > 2018-01-10 14:17:23,006 DEBUG [AssignmentThread] > rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region: > hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server: > localhost,1,1 found in group: null outside of group: UNKNOWN > {code} > Here is corresponding code: > {code} > if (assignedServer != null && > (info == null || > !info.containsServer(assignedServer.getAddress( { > RSGroupInfo otherInfo = null; > otherInfo = > rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress()); > LOG.debug("Found misplaced region: " + > regionInfo.getRegionNameAsString() + > {code} > As you can see, both info and otherInfo were null. > In this case, the region should not be placed in misplacedRegions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19568) Restore of HBase table using incremental backup doesn't restore rows from an earlier incremental backup
[ https://issues.apache.org/jira/browse/HBASE-19568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324809#comment-16324809 ] Hudson commented on HBASE-19568: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4390 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4390/]) HBASE-19568: Restore of HBase table using incremental backup doesn't (elserj: rev a5601c8eac6bfcac7d869574547f505d44e49065) * (edit) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/TableBackupClient.java * (edit) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalTableBackupClient.java * (edit) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackupWithBulkLoad.java * (edit) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java * (edit) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java * (edit) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/RestoreTablesClient.java * (edit) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java * (edit) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupBase.java > Restore of HBase table using incremental backup doesn't restore rows from an > earlier incremental backup > --- > > Key: HBASE-19568 > URL: https://issues.apache.org/jira/browse/HBASE-19568 > Project: HBase > Issue Type: Bug >Reporter: Romil Choksi >Assignee: Vladimir Rodionov > Fix For: 3.0.0 > > Attachments: HBASE-19568-v1.patch, HBASE-19568-v2.patch, > HBASE-19568-v3.patch, HBASE-19568-v4.patch > > > Credits to [~romil.choksi] > Restore of bulk-loaded HBase table doesn't restore deleted rows > Steps: > Create usertable and insert a few rows in it > Create full backup > Bulk load into usertable, and create first incremental backup > Bulk load into usertable again, and create second incremental backup > Delete row each from initial insert, first bulk load and second bulk load > Restore usertable using second incremental backup > Verify if each of the deleted rows has been restored > On restore using second incremental backup id, the test failed as all of the > rows from first bulk load were not available. Data from initial insertion > (full backup) and second bulk load were only available. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19769) IllegalAccessError on package-private Hadoop metrics2 classes in MapReduce jobs
[ https://issues.apache.org/jira/browse/HBASE-19769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324808#comment-16324808 ] Hudson commented on HBASE-19769: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4390 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4390/]) HBASE-19769 Remove ZK metrics because of classloader issues (elserj: rev 057e80c1639412b25c2b3462851729a33cac39c7) * (delete) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKMetrics.java * (delete) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKMetricsListener.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java * (delete) hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKMetrics.java > IllegalAccessError on package-private Hadoop metrics2 classes in MapReduce > jobs > --- > > Key: HBASE-19769 > URL: https://issues.apache.org/jira/browse/HBASE-19769 > Project: HBase > Issue Type: Bug > Components: mapreduce, metrics >Affects Versions: 2.0.0-beta-1 >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19769.001.branch-2.patch > > > issues for context: HBASE-17170, HBASE-17448, TEZ-3299, HADOOP-10893 > Since Hadoop 2.6.0, the {{yarn jar}} entry point to submit a YARN job has > been using a custom classloader to separate Hadoop dependencies from the > user's JAR being run. A separate classloader is created for the user-provided > jar, and then this classloader is set as the contextClassLoader before the > Tool is executed by Hadoop's RunJar class. This has been (mostly?) fine for > us to date because we don't try to access any Hadoop internal classes > client-side. > However, with the ZK metrics, clients are pushing ZK metrics to metrics2. The > problem is that Hadoop metrics2 implementations which we reference from the > same package are loaded by a different classloader than our HBase code is > loaded from. This makes the expected package-private access of these Metrics2 > classes (e.g. MetricsInfoImpl) fail with an IllegalAccessError. > {noformat} > java.lang.RuntimeException: Could not create interface > org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSource Is the hadoop > compatibility jar on the classpath? > at > org.apache.hadoop.hbase.CompatibilitySingletonFactory.getInstance(CompatibilitySingletonFactory.java:75) > at > org.apache.hadoop.hbase.zookeeper.ZKMetrics.(ZKMetrics.java:36) > at > org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.(RecoverableZooKeeper.java:115) > at org.apache.hadoop.hbase.zookeeper.ZKUtil.connect(ZKUtil.java:139) > at > org.apache.hadoop.hbase.zookeeper.ZKWatcher.(ZKWatcher.java:128) > at > org.apache.hadoop.hbase.zookeeper.ZKWatcher.(ZKWatcher.java:102) > at > org.apache.hadoop.hbase.security.token.TokenUtil.getAuthToken(TokenUtil.java:293) > at > org.apache.hadoop.hbase.security.token.TokenUtil.addTokenForJob(TokenUtil.java:259) > at > org.apache.hadoop.hbase.mapreduce.TableMapReduceUtil.initCredentials(TableMapReduceUtil.java:535) > at > org.apache.phoenix.mapreduce.MultiHfileOutputFormat.configureIncrementalLoad(MultiHfileOutputFormat.java:712) > at > org.apache.phoenix.mapreduce.AbstractBulkLoadTool.submitJob(AbstractBulkLoadTool.java:300) > at > org.apache.phoenix.mapreduce.AbstractBulkLoadTool.loadData(AbstractBulkLoadTool.java:267) > at > org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(AbstractBulkLoadTool.java:180) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90) > at > org.apache.phoenix.mapreduce.CsvBulkLoadTool.main(CsvBulkLoadTool.java:109) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:239) > at org.apache.hadoop.util.RunJar.main(RunJar.java:153) > Caused by: java.util.ServiceConfigurationError: > org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSource: Provider > org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSourceImpl could not be > instantiated > at java.util.ServiceLoader.fail(ServiceLoader.java:232) > at java.util.ServiceLoader.access$100(ServiceLoader.java:185) > at >
[jira] [Commented] (HBASE-19775) hbase shell doesn't handle the exceptions that are wrapped in java.io.UncheckedIOException
[ https://issues.apache.org/jira/browse/HBASE-19775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324807#comment-16324807 ] Hudson commented on HBASE-19775: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4390 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4390/]) HBASE-19775 hbase shell doesn't handle the exceptions that are wrapped (elserj: rev 6bacb643bc66b994c386b7fd175664802047eef7) * (edit) hbase-shell/src/main/ruby/shell/commands.rb > hbase shell doesn't handle the exceptions that are wrapped in > java.io.UncheckedIOException > -- > > Key: HBASE-19775 > URL: https://issues.apache.org/jira/browse/HBASE-19775 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 2.0.0-beta-1 >Reporter: Sergey Soldatov >Assignee: Sergey Soldatov > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19775-2-branch-2.patch, HBASE-19775-branch-2.patch > > > HBase shell doesn't have a notion of UncheckedIOException, so it may not > handle it correctly. For an example, if we scan not existing table the error > look weird: > {noformat} > hbase(main):001:0> scan 'a' > ROW > COLUMN+CELL > ERROR: a > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19780) Change execution phase of checkstyle plugin back to default 'verify'
[ https://issues.apache.org/jira/browse/HBASE-19780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19780: - Summary: Change execution phase of checkstyle plugin back to default 'verify' (was: Fix build in branch-2 - change execution phase of checkstyle plugin back to default 'verify') > Change execution phase of checkstyle plugin back to default 'verify' > > > Key: HBASE-19780 > URL: https://issues.apache.org/jira/browse/HBASE-19780 > Project: HBase > Issue Type: Bug >Reporter: Appy > Attachments: HBASE-19780.master.001.patch, > HBASE-19780.master.002.patch > > > Not able to run following command successfully: > {{mvn -DskipTests install site > -Dmaven.repo.local=/Users/appy/Desktop/temp_repo}} > Use a clean separate repo so that existing packages don't pollute the build. > Error is following. > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project > hbase: failed to get report for > org.apache.maven.plugins:maven-javadoc-plugin: Failed to execute goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) on > project hbase-error-prone: Execution checkstyle of goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed: Plugin > org.apache.maven.plugins:maven-checkstyle-plugin:2.17 or one of its > dependencies could not be resolved: Failure to find > org.apache.hbase:hbase-checkstyle:jar:2.0.0-beta-1 in > http://repository.apache.org/snapshots/ was cached in the local repository, > resolution will not be reattempted until the update interval of > apache.snapshots has elapsed or updates are forced -> [Help 1] > {noformat} > Note that master build goes pass this point. > Need to figure out what's the difference and fix the overall build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19780) Fix build in branch-2 - change execution phase of checkstyle plugin back to default 'verify'
[ https://issues.apache.org/jira/browse/HBASE-19780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19780: - Attachment: (was: HBASE-19780.branch-2.001.patch) > Fix build in branch-2 - change execution phase of checkstyle plugin back to > default 'verify' > > > Key: HBASE-19780 > URL: https://issues.apache.org/jira/browse/HBASE-19780 > Project: HBase > Issue Type: Bug >Reporter: Appy > Attachments: HBASE-19780.master.001.patch, > HBASE-19780.master.002.patch > > > Not able to run following command successfully: > {{mvn -DskipTests install site > -Dmaven.repo.local=/Users/appy/Desktop/temp_repo}} > Use a clean separate repo so that existing packages don't pollute the build. > Error is following. > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project > hbase: failed to get report for > org.apache.maven.plugins:maven-javadoc-plugin: Failed to execute goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) on > project hbase-error-prone: Execution checkstyle of goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed: Plugin > org.apache.maven.plugins:maven-checkstyle-plugin:2.17 or one of its > dependencies could not be resolved: Failure to find > org.apache.hbase:hbase-checkstyle:jar:2.0.0-beta-1 in > http://repository.apache.org/snapshots/ was cached in the local repository, > resolution will not be reattempted until the update interval of > apache.snapshots has elapsed or updates are forced -> [Help 1] > {noformat} > Note that master build goes pass this point. > Need to figure out what's the difference and fix the overall build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19780) Fix build in branch-2 - change execution phase of checkstyle plugin back to default 'verify'
[ https://issues.apache.org/jira/browse/HBASE-19780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19780: - Attachment: HBASE-19780.master.002.patch > Fix build in branch-2 - change execution phase of checkstyle plugin back to > default 'verify' > > > Key: HBASE-19780 > URL: https://issues.apache.org/jira/browse/HBASE-19780 > Project: HBase > Issue Type: Bug >Reporter: Appy > Attachments: HBASE-19780.master.001.patch, > HBASE-19780.master.002.patch > > > Not able to run following command successfully: > {{mvn -DskipTests install site > -Dmaven.repo.local=/Users/appy/Desktop/temp_repo}} > Use a clean separate repo so that existing packages don't pollute the build. > Error is following. > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project > hbase: failed to get report for > org.apache.maven.plugins:maven-javadoc-plugin: Failed to execute goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) on > project hbase-error-prone: Execution checkstyle of goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed: Plugin > org.apache.maven.plugins:maven-checkstyle-plugin:2.17 or one of its > dependencies could not be resolved: Failure to find > org.apache.hbase:hbase-checkstyle:jar:2.0.0-beta-1 in > http://repository.apache.org/snapshots/ was cached in the local repository, > resolution will not be reattempted until the update interval of > apache.snapshots has elapsed or updates are forced -> [Help 1] > {noformat} > Note that master build goes pass this point. > Need to figure out what's the difference and fix the overall build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19770) `list` shell command does not return an array of table names
[ https://issues.apache.org/jira/browse/HBASE-19770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324803#comment-16324803 ] Hadoop QA commented on HBASE-19770: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | || || || || {color:brown} branch-2 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 39s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 40s{color} | {color:green} branch-2 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 44s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m 12s{color} | {color:red} The patch generated 5 new + 84 unchanged - 2 fixed = 89 total (was 86) {color} | | {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m 4s{color} | {color:red} The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 30s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green}137m 47s{color} | {color:green} root in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 37s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}153m 7s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db | | JIRA Issue | HBASE-19770 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12905941/HBASE-19770.002.branch-2.patch | | Optional Tests | asflicense rubocop ruby_lint javac javadoc unit | | uname | Linux 3b4539555c2d 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | branch-2 / 026f535a77 | | maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) | | Default Java | 1.8.0_151 | | rubocop | v0.52.1 | | rubocop | https://builds.apache.org/job/PreCommit-HBASE-Build/11055/artifact/patchprocess/diff-patch-rubocop.txt | | ruby-lint | v2.3.1 | | ruby-lint | https://builds.apache.org/job/PreCommit-HBASE-Build/11055/artifact/patchprocess/diff-patch-ruby-lint.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11055/testReport/ | | modules | C: hbase-shell . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11055/console | | Powered by | Apache Yetus 0.6.0 http://yetus.apache.org | This message was automatically generated. > `list` shell command does not return an array of table names > > > Key: HBASE-19770 > URL: https://issues.apache.org/jira/browse/HBASE-19770 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: Romil Choksi >Assignee: Josh Elser >Priority: Critical > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19770.001.branch-2.patch, > HBASE-19770.002.branch-2.patch > > > Another good find by our Romil. > {code} > hbase(main):001:0> list > TABLE > a > 1 row(s) > Took 0.8385 seconds > hbase(main):002:0> tables=list > TABLE > a > 1 row(s) > Took 0.0267 seconds > hbase(main):003:0> puts tables > hbase(main):004:0> p tables > nil > {code} > The {{list}} command should be returning
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324797#comment-16324797 ] Andrew Purtell commented on HBASE-19752: bq. Somehow I used a partial branch-1 patch on branch-1.4 ... and didn't check if it even compiled. Never mind if the test passed. > RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where > rs group cannot be determined > - > > Key: HBASE-19752 > URL: https://issues.apache.org/jira/browse/HBASE-19752 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.1, 1.5.0, 2.0.0-beta-1 > > Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt, > 19752.v5.txt, 19752.v6.txt, 19752.v7.branch-1.txt, 19752.v7.txt > > > Observed the following in rs group test output: > {code} > 2018-01-10 14:17:23,006 DEBUG [AssignmentThread] > rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region: > hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server: > localhost,1,1 found in group: null outside of group: UNKNOWN > {code} > Here is corresponding code: > {code} > if (assignedServer != null && > (info == null || > !info.containsServer(assignedServer.getAddress( { > RSGroupInfo otherInfo = null; > otherInfo = > rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress()); > LOG.debug("Found misplaced region: " + > regionInfo.getRegionNameAsString() + > {code} > As you can see, both info and otherInfo were null. > In this case, the region should not be placed in misplacedRegions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19780) Fix build in branch-2 - change execution phase of checkstyle plugin back to default 'verify'
[ https://issues.apache.org/jira/browse/HBASE-19780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19780: - Attachment: HBASE-19780.branch-2.001.patch > Fix build in branch-2 - change execution phase of checkstyle plugin back to > default 'verify' > > > Key: HBASE-19780 > URL: https://issues.apache.org/jira/browse/HBASE-19780 > Project: HBase > Issue Type: Bug >Reporter: Appy > Attachments: HBASE-19780.branch-2.001.patch, > HBASE-19780.master.001.patch > > > Not able to run following command successfully: > {{mvn -DskipTests install site > -Dmaven.repo.local=/Users/appy/Desktop/temp_repo}} > Use a clean separate repo so that existing packages don't pollute the build. > Error is following. > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project > hbase: failed to get report for > org.apache.maven.plugins:maven-javadoc-plugin: Failed to execute goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) on > project hbase-error-prone: Execution checkstyle of goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed: Plugin > org.apache.maven.plugins:maven-checkstyle-plugin:2.17 or one of its > dependencies could not be resolved: Failure to find > org.apache.hbase:hbase-checkstyle:jar:2.0.0-beta-1 in > http://repository.apache.org/snapshots/ was cached in the local repository, > resolution will not be reattempted until the update interval of > apache.snapshots has elapsed or updates are forced -> [Help 1] > {noformat} > Note that master build goes pass this point. > Need to figure out what's the difference and fix the overall build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19780) Fix build in branch-2 - change execution phase of checkstyle plugin back to default 'verify'
[ https://issues.apache.org/jira/browse/HBASE-19780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324790#comment-16324790 ] Appy commented on HBASE-19780: -- bq. Regarding point 2: I would like to stick with using a dedicated module. This provides the advantage that the path to the Checkstyle files only needs to be set once in the parent POM instead of setting it in every module to the appropriate path. But if it fixes things we can change it according to dev-support. I hoped i could do it by setting a fixed path reference in root pom once and not having to repeat it in every module. But looks like no straightforward way to do it. Keeping current approach and adding comments to help people who look at it in future. > Fix build in branch-2 - change execution phase of checkstyle plugin back to > default 'verify' > > > Key: HBASE-19780 > URL: https://issues.apache.org/jira/browse/HBASE-19780 > Project: HBase > Issue Type: Bug >Reporter: Appy > Attachments: HBASE-19780.master.001.patch > > > Not able to run following command successfully: > {{mvn -DskipTests install site > -Dmaven.repo.local=/Users/appy/Desktop/temp_repo}} > Use a clean separate repo so that existing packages don't pollute the build. > Error is following. > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project > hbase: failed to get report for > org.apache.maven.plugins:maven-javadoc-plugin: Failed to execute goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) on > project hbase-error-prone: Execution checkstyle of goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed: Plugin > org.apache.maven.plugins:maven-checkstyle-plugin:2.17 or one of its > dependencies could not be resolved: Failure to find > org.apache.hbase:hbase-checkstyle:jar:2.0.0-beta-1 in > http://repository.apache.org/snapshots/ was cached in the local repository, > resolution will not be reattempted until the update interval of > apache.snapshots has elapsed or updates are forced -> [Help 1] > {noformat} > Note that master build goes pass this point. > Need to figure out what's the difference and fix the overall build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-19528) Major Compaction Tool
[ https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324769#comment-16324769 ] Ted Yu edited comment on HBASE-19528 at 1/13/18 12:31 AM: -- If there is exception thrown (client side) when MajorCompactor is running, how is cleanup done (closing connection, etc) ? was (Author: yuzhih...@gmail.com): If user presses Ctrl+C when MajorCompactor is running, how is cleanup done (closing connection, etc) ? > Major Compaction Tool > -- > > Key: HBASE-19528 > URL: https://issues.apache.org/jira/browse/HBASE-19528 > Project: HBase > Issue Type: New Feature >Reporter: churro morales >Assignee: churro morales > Fix For: 2.0.0, 3.0.0 > > Attachments: HBASE-19528.patch, HBASE-19528.v1.patch > > > The basic overview of how this tool works is: > Parameters: > Table > Stores > ClusterConcurrency > Timestamp > So you input a table, desired concurrency and the list of stores you wish to > major compact. The tool first checks the filesystem to see which stores need > compaction based on the timestamp you provide (default is current time). It > takes that list of stores that require compaction and executes those requests > concurrently with at most N distinct RegionServers compacting at a given > time. Each thread waits for the compaction to complete before moving to the > next queue. If a region split, merge or move happens this tool ensures those > regions get major compacted as well. > This helps us in two ways, we can limit how much I/O bandwidth we are using > for major compaction cluster wide and we are guaranteed after the tool > completes that all requested compactions complete regardless of moves, merges > and splits. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19780) Fix build in branch-2 - change execution phase of checkstyle plugin back to default 'verify'
[ https://issues.apache.org/jira/browse/HBASE-19780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19780: - Summary: Fix build in branch-2 - change execution phase of checkstyle plugin back to default 'verify' (was: Fix build in branch-2) > Fix build in branch-2 - change execution phase of checkstyle plugin back to > default 'verify' > > > Key: HBASE-19780 > URL: https://issues.apache.org/jira/browse/HBASE-19780 > Project: HBase > Issue Type: Bug >Reporter: Appy > Attachments: HBASE-19780.master.001.patch > > > Not able to run following command successfully: > {{mvn -DskipTests install site > -Dmaven.repo.local=/Users/appy/Desktop/temp_repo}} > Use a clean separate repo so that existing packages don't pollute the build. > Error is following. > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project > hbase: failed to get report for > org.apache.maven.plugins:maven-javadoc-plugin: Failed to execute goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) on > project hbase-error-prone: Execution checkstyle of goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed: Plugin > org.apache.maven.plugins:maven-checkstyle-plugin:2.17 or one of its > dependencies could not be resolved: Failure to find > org.apache.hbase:hbase-checkstyle:jar:2.0.0-beta-1 in > http://repository.apache.org/snapshots/ was cached in the local repository, > resolution will not be reattempted until the update interval of > apache.snapshots has elapsed or updates are forced -> [Help 1] > {noformat} > Note that master build goes pass this point. > Need to figure out what's the difference and fix the overall build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19789) Exclude flaky tests from nightly branch-2 runs
[ https://issues.apache.org/jira/browse/HBASE-19789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324787#comment-16324787 ] Appy commented on HBASE-19789: -- Ping [~stack]. > Exclude flaky tests from nightly branch-2 runs > -- > > Key: HBASE-19789 > URL: https://issues.apache.org/jira/browse/HBASE-19789 > Project: HBase > Issue Type: Improvement >Reporter: Appy >Assignee: Appy > Attachments: HBASE-19789.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Work started] (HBASE-19789) Exclude flaky tests from nightly branch-2 runs
[ https://issues.apache.org/jira/browse/HBASE-19789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-19789 started by Appy. > Exclude flaky tests from nightly branch-2 runs > -- > > Key: HBASE-19789 > URL: https://issues.apache.org/jira/browse/HBASE-19789 > Project: HBase > Issue Type: Improvement >Reporter: Appy >Assignee: Appy > Attachments: HBASE-19789.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19789) Exclude flaky tests from nightly branch-2 runs
[ https://issues.apache.org/jira/browse/HBASE-19789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324783#comment-16324783 ] Appy commented on HBASE-19789: -- Precommit is useless on this change related to nightly runs. Pushing to branch-2 to test it. > Exclude flaky tests from nightly branch-2 runs > -- > > Key: HBASE-19789 > URL: https://issues.apache.org/jira/browse/HBASE-19789 > Project: HBase > Issue Type: Improvement >Reporter: Appy >Assignee: Appy > Attachments: HBASE-19789.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19789) Exclude flaky tests from nightly branch-2 runs
[ https://issues.apache.org/jira/browse/HBASE-19789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19789: - Attachment: HBASE-19789.master.001.patch > Exclude flaky tests from nightly branch-2 runs > -- > > Key: HBASE-19789 > URL: https://issues.apache.org/jira/browse/HBASE-19789 > Project: HBase > Issue Type: Improvement >Reporter: Appy >Assignee: Appy > Attachments: HBASE-19789.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19528) Major Compaction Tool
[ https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324769#comment-16324769 ] Ted Yu commented on HBASE-19528: If user presses Ctrl+C when MajorCompactor is running, how is cleanup done (closing connection, etc) ? > Major Compaction Tool > -- > > Key: HBASE-19528 > URL: https://issues.apache.org/jira/browse/HBASE-19528 > Project: HBase > Issue Type: New Feature >Reporter: churro morales >Assignee: churro morales > Fix For: 2.0.0, 3.0.0 > > Attachments: HBASE-19528.patch, HBASE-19528.v1.patch > > > The basic overview of how this tool works is: > Parameters: > Table > Stores > ClusterConcurrency > Timestamp > So you input a table, desired concurrency and the list of stores you wish to > major compact. The tool first checks the filesystem to see which stores need > compaction based on the timestamp you provide (default is current time). It > takes that list of stores that require compaction and executes those requests > concurrently with at most N distinct RegionServers compacting at a given > time. Each thread waits for the compaction to complete before moving to the > next queue. If a region split, merge or move happens this tool ensures those > regions get major compacted as well. > This helps us in two ways, we can limit how much I/O bandwidth we are using > for major compaction cluster wide and we are guaranteed after the tool > completes that all requested compactions complete regardless of moves, merges > and splits. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19752: --- Attachment: 19752.v7.branch-1.txt > RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where > rs group cannot be determined > - > > Key: HBASE-19752 > URL: https://issues.apache.org/jira/browse/HBASE-19752 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.1, 1.5.0, 2.0.0-beta-1 > > Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt, > 19752.v5.txt, 19752.v6.txt, 19752.v7.branch-1.txt, 19752.v7.txt > > > Observed the following in rs group test output: > {code} > 2018-01-10 14:17:23,006 DEBUG [AssignmentThread] > rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region: > hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server: > localhost,1,1 found in group: null outside of group: UNKNOWN > {code} > Here is corresponding code: > {code} > if (assignedServer != null && > (info == null || > !info.containsServer(assignedServer.getAddress( { > RSGroupInfo otherInfo = null; > otherInfo = > rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress()); > LOG.debug("Found misplaced region: " + > regionInfo.getRegionNameAsString() + > {code} > As you can see, both info and otherInfo were null. > In this case, the region should not be placed in misplacedRegions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19752: --- Attachment: (was: 19752.v7.branch-1.txt) > RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where > rs group cannot be determined > - > > Key: HBASE-19752 > URL: https://issues.apache.org/jira/browse/HBASE-19752 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.1, 1.5.0, 2.0.0-beta-1 > > Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt, > 19752.v5.txt, 19752.v6.txt, 19752.v7.branch-1.txt, 19752.v7.txt > > > Observed the following in rs group test output: > {code} > 2018-01-10 14:17:23,006 DEBUG [AssignmentThread] > rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region: > hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server: > localhost,1,1 found in group: null outside of group: UNKNOWN > {code} > Here is corresponding code: > {code} > if (assignedServer != null && > (info == null || > !info.containsServer(assignedServer.getAddress( { > RSGroupInfo otherInfo = null; > otherInfo = > rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress()); > LOG.debug("Found misplaced region: " + > regionInfo.getRegionNameAsString() + > {code} > As you can see, both info and otherInfo were null. > In this case, the region should not be placed in misplacedRegions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved HBASE-19752. Resolution: Fixed > RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where > rs group cannot be determined > - > > Key: HBASE-19752 > URL: https://issues.apache.org/jira/browse/HBASE-19752 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.1, 1.5.0, 2.0.0-beta-1 > > Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt, > 19752.v5.txt, 19752.v6.txt, 19752.v7.branch-1.txt, 19752.v7.txt > > > Observed the following in rs group test output: > {code} > 2018-01-10 14:17:23,006 DEBUG [AssignmentThread] > rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region: > hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server: > localhost,1,1 found in group: null outside of group: UNKNOWN > {code} > Here is corresponding code: > {code} > if (assignedServer != null && > (info == null || > !info.containsServer(assignedServer.getAddress( { > RSGroupInfo otherInfo = null; > otherInfo = > rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress()); > LOG.debug("Found misplaced region: " + > regionInfo.getRegionNameAsString() + > {code} > As you can see, both info and otherInfo were null. > In this case, the region should not be placed in misplacedRegions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324746#comment-16324746 ] Ted Yu commented on HBASE-19752: Commit to branch-1 was correct. Somehow I used a partial branch-1 patch on branch-1.4 > RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where > rs group cannot be determined > - > > Key: HBASE-19752 > URL: https://issues.apache.org/jira/browse/HBASE-19752 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.1, 1.5.0, 2.0.0-beta-1 > > Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt, > 19752.v5.txt, 19752.v6.txt, 19752.v7.branch-1.txt, 19752.v7.txt > > > Observed the following in rs group test output: > {code} > 2018-01-10 14:17:23,006 DEBUG [AssignmentThread] > rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region: > hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server: > localhost,1,1 found in group: null outside of group: UNKNOWN > {code} > Here is corresponding code: > {code} > if (assignedServer != null && > (info == null || > !info.containsServer(assignedServer.getAddress( { > RSGroupInfo otherInfo = null; > otherInfo = > rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress()); > LOG.debug("Found misplaced region: " + > regionInfo.getRegionNameAsString() + > {code} > As you can see, both info and otherInfo were null. > In this case, the region should not be placed in misplacedRegions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-11409) Add more flexibility for input directory structure to LoadIncrementalHFiles
[ https://issues.apache.org/jira/browse/HBASE-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-11409: --- Fix Version/s: 1.4.1 > Add more flexibility for input directory structure to LoadIncrementalHFiles > --- > > Key: HBASE-11409 > URL: https://issues.apache.org/jira/browse/HBASE-11409 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: churro morales >Assignee: churro morales > Fix For: 3.0.0, 1.4.1, 1.5.0, 2.0.0-beta-1 > > Attachments: HBASE-11409.v1.patch, HBASE-11409.v2.patch, > HBASE-11409.v3.patch, HBASE-11409.v4.patch, HBASE-11409.v5.patch, > HBASE-11409.v6.branch-1.patch > > > Use case: > We were trying to combine two very large tables into a single table. Thus we > ran jobs in one datacenter that populated certain column families and another > datacenter which populated other column families. Took a snapshot and > exported them to their respective datacenters. Wanted to simply take the > hdfs restored snapshot and use LoadIncremental to merge the data. > It would be nice to add support where we could run LoadIncremental on a > directory where the depth of store files is something other than two (current > behavior). > With snapshots it would be nice if you could pass a restored hdfs snapshot's > directory and have the tool run. > I am attaching a patch where I parameterize the bulkLoad timeout as well as > the default store file depth. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19789) Exclude flaky tests from nightly branch-2 runs
Appy created HBASE-19789: Summary: Exclude flaky tests from nightly branch-2 runs Key: HBASE-19789 URL: https://issues.apache.org/jira/browse/HBASE-19789 Project: HBase Issue Type: Improvement Reporter: Appy Assignee: Appy -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19663) site build fails complaining "javadoc: error - class file for javax.annotation.meta.TypeQualifierNickname not found"
[ https://issues.apache.org/jira/browse/HBASE-19663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324738#comment-16324738 ] Zach York commented on HBASE-19663: --- I'll try to track down the commit for 1.4.0 > site build fails complaining "javadoc: error - class file for > javax.annotation.meta.TypeQualifierNickname not found" > > > Key: HBASE-19663 > URL: https://issues.apache.org/jira/browse/HBASE-19663 > Project: HBase > Issue Type: Bug > Components: site >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-beta-2 > > Attachments: script.sh > > > Cryptic failure trying to build beta-1 RC. Fails like this: > {code} > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 03:54 min > [INFO] Finished at: 2017-12-29T01:13:15-08:00 > [INFO] Final Memory: 381M/9165M > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project > hbase: Error generating maven-javadoc-plugin:2.10.3:aggregate: > [ERROR] Exit code: 1 - warning: unknown enum constant When.ALWAYS > [ERROR] reason: class file for javax.annotation.meta.When not found > [ERROR] warning: unknown enum constant When.UNKNOWN > [ERROR] warning: unknown enum constant When.MAYBE > [ERROR] > /home/stack/hbase.git/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:762: > warning - Tag @link: malformed: "#matchingRows(Cell, byte[]))" > [ERROR] > /home/stack/hbase.git/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:762: > warning - Tag @link: reference not found: #matchingRows(Cell, byte[])) > [ERROR] > /home/stack/hbase.git/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:762: > warning - Tag @link: reference not found: #matchingRows(Cell, byte[])) > [ERROR] javadoc: warning - Class javax.annotation.Nonnull not found. > [ERROR] javadoc: error - class file for > javax.annotation.meta.TypeQualifierNickname not found > [ERROR] > [ERROR] Command line was: /home/stack/bin/jdk1.8.0_151/jre/../bin/javadoc > -J-Xmx2G @options @packages > [ERROR] > [ERROR] Refer to the generated Javadoc files in > '/home/stack/hbase.git/target/site/apidocs' dir. > [ERROR] -> [Help 1] > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the -e > switch. > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > [ERROR] > [ERROR] For more information about the errors and possible solutions, please > read the following articles: > [ERROR] [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException > {code} > javax.annotation.meta.TypeQualifierNickname is out of jsr305 but we don't > include this anywhere according to mvn dependency. > Happens building the User API both test and main. > Excluding these lines gets us passing again: > {code} > 3511 > 3512 > org.apache.yetus.audience.tools.IncludePublicAnnotationsStandardDoclet > 3513 > 3514 > 3515 org.apache.yetus > 3516 audience-annotations > 3517 ${audience-annotations.version} > 3518 > + 3519 true > {code} > Tried upgrading to newer mvn site (ours is three years old) but that a > different set of problems. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell reopened HBASE-19752: Reverted from branch-1.4 due to compilation failure. Please fix and reapply. > RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where > rs group cannot be determined > - > > Key: HBASE-19752 > URL: https://issues.apache.org/jira/browse/HBASE-19752 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.1, 1.5.0, 2.0.0-beta-1 > > Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt, > 19752.v5.txt, 19752.v6.txt, 19752.v7.branch-1.txt, 19752.v7.txt > > > Observed the following in rs group test output: > {code} > 2018-01-10 14:17:23,006 DEBUG [AssignmentThread] > rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region: > hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server: > localhost,1,1 found in group: null outside of group: UNKNOWN > {code} > Here is corresponding code: > {code} > if (assignedServer != null && > (info == null || > !info.containsServer(assignedServer.getAddress( { > RSGroupInfo otherInfo = null; > otherInfo = > rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress()); > LOG.debug("Found misplaced region: " + > regionInfo.getRegionNameAsString() + > {code} > As you can see, both info and otherInfo were null. > In this case, the region should not be placed in misplacedRegions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19663) site build fails complaining "javadoc: error - class file for javax.annotation.meta.TypeQualifierNickname not found"
[ https://issues.apache.org/jira/browse/HBASE-19663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324690#comment-16324690 ] Zach York commented on HBASE-19663: --- [~mdrob] We are seeing this 'error - class file for javax.annotation.concurrent.Immutable not found' when building 1.4.0 as well. Perhaps it is not just related to branch-2. > site build fails complaining "javadoc: error - class file for > javax.annotation.meta.TypeQualifierNickname not found" > > > Key: HBASE-19663 > URL: https://issues.apache.org/jira/browse/HBASE-19663 > Project: HBase > Issue Type: Bug > Components: site >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-beta-2 > > Attachments: script.sh > > > Cryptic failure trying to build beta-1 RC. Fails like this: > {code} > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 03:54 min > [INFO] Finished at: 2017-12-29T01:13:15-08:00 > [INFO] Final Memory: 381M/9165M > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project > hbase: Error generating maven-javadoc-plugin:2.10.3:aggregate: > [ERROR] Exit code: 1 - warning: unknown enum constant When.ALWAYS > [ERROR] reason: class file for javax.annotation.meta.When not found > [ERROR] warning: unknown enum constant When.UNKNOWN > [ERROR] warning: unknown enum constant When.MAYBE > [ERROR] > /home/stack/hbase.git/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:762: > warning - Tag @link: malformed: "#matchingRows(Cell, byte[]))" > [ERROR] > /home/stack/hbase.git/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:762: > warning - Tag @link: reference not found: #matchingRows(Cell, byte[])) > [ERROR] > /home/stack/hbase.git/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:762: > warning - Tag @link: reference not found: #matchingRows(Cell, byte[])) > [ERROR] javadoc: warning - Class javax.annotation.Nonnull not found. > [ERROR] javadoc: error - class file for > javax.annotation.meta.TypeQualifierNickname not found > [ERROR] > [ERROR] Command line was: /home/stack/bin/jdk1.8.0_151/jre/../bin/javadoc > -J-Xmx2G @options @packages > [ERROR] > [ERROR] Refer to the generated Javadoc files in > '/home/stack/hbase.git/target/site/apidocs' dir. > [ERROR] -> [Help 1] > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the -e > switch. > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > [ERROR] > [ERROR] For more information about the errors and possible solutions, please > read the following articles: > [ERROR] [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException > {code} > javax.annotation.meta.TypeQualifierNickname is out of jsr305 but we don't > include this anywhere according to mvn dependency. > Happens building the User API both test and main. > Excluding these lines gets us passing again: > {code} > 3511 > 3512 > org.apache.yetus.audience.tools.IncludePublicAnnotationsStandardDoclet > 3513 > 3514 > 3515 org.apache.yetus > 3516 audience-annotations > 3517 ${audience-annotations.version} > 3518 > + 3519 true > {code} > Tried upgrading to newer mvn site (ours is three years old) but that a > different set of problems. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19528) Major Compaction Tool
[ https://issues.apache.org/jira/browse/HBASE-19528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324628#comment-16324628 ] churro morales commented on HBASE-19528: [~tedyu] [~carp84] did you guys get a chance to review? > Major Compaction Tool > -- > > Key: HBASE-19528 > URL: https://issues.apache.org/jira/browse/HBASE-19528 > Project: HBase > Issue Type: New Feature >Reporter: churro morales >Assignee: churro morales > Fix For: 2.0.0, 3.0.0 > > Attachments: HBASE-19528.patch, HBASE-19528.v1.patch > > > The basic overview of how this tool works is: > Parameters: > Table > Stores > ClusterConcurrency > Timestamp > So you input a table, desired concurrency and the list of stores you wish to > major compact. The tool first checks the filesystem to see which stores need > compaction based on the timestamp you provide (default is current time). It > takes that list of stores that require compaction and executes those requests > concurrently with at most N distinct RegionServers compacting at a given > time. Each thread waits for the compaction to complete before moving to the > next queue. If a region split, merge or move happens this tool ensures those > regions get major compacted as well. > This helps us in two ways, we can limit how much I/O bandwidth we are using > for major compaction cluster wide and we are guaranteed after the tool > completes that all requested compactions complete regardless of moves, merges > and splits. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (HBASE-19787) Fix or disable tests broken in branch-2 so can cut beta-1
[ https://issues.apache.org/jira/browse/HBASE-19787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-19787. --- Resolution: Fixed Pushed to master and branch-2. > Fix or disable tests broken in branch-2 so can cut beta-1 > - > > Key: HBASE-19787 > URL: https://issues.apache.org/jira/browse/HBASE-19787 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19787.branch-2.001.patch > > > Appy's dashboard for 2.0 > https://builds.apache.org/job/HBase-Find-Flaky-Tests-branch2.0/lastSuccessfulBuild/artifact/dashboard.html > and a GCE run last night showed how bad of a state our unit tests are in on > tip of branch-2. This issue does triage fixing and disabling so I can push > out the beta-1. Its done as a subtask of HBASE-19694 because a few of the > tests were broke by this commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19787) Fix or disable tests broken in branch-2 so can cut beta-1
[ https://issues.apache.org/jira/browse/HBASE-19787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324618#comment-16324618 ] stack commented on HBASE-19787: --- Added note over on HBASE-19554 that I disabled the WAL tests for now. Added issue HBASE-19788 to reenable TestFavoredNodesStochasticBalancer. > Fix or disable tests broken in branch-2 so can cut beta-1 > - > > Key: HBASE-19787 > URL: https://issues.apache.org/jira/browse/HBASE-19787 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19787.branch-2.001.patch > > > Appy's dashboard for 2.0 > https://builds.apache.org/job/HBase-Find-Flaky-Tests-branch2.0/lastSuccessfulBuild/artifact/dashboard.html > and a GCE run last night showed how bad of a state our unit tests are in on > tip of branch-2. This issue does triage fixing and disabling so I can push > out the beta-1. Its done as a subtask of HBASE-19694 because a few of the > tests were broke by this commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19788) Reenable TestFavoredStochasticLoadBalancer; disabled by HBASE-19787
stack created HBASE-19788: - Summary: Reenable TestFavoredStochasticLoadBalancer; disabled by HBASE-19787 Key: HBASE-19788 URL: https://issues.apache.org/jira/browse/HBASE-19788 Project: HBase Issue Type: Bug Reporter: stack I disabled this test in HBASE-19787 because it for a feature we are not shipping in branch-2 and it fails on occasion. I disabled it in both master and branch-2 so when fix it does to both places. Did this because want to cut the beta-1. Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19770) `list` shell command does not return an array of table names
[ https://issues.apache.org/jira/browse/HBASE-19770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-19770: --- Attachment: HBASE-19770.002.branch-2.patch .002 Fix ruby "style" issues. Make sure {{return_values=true}} for the ruby tests too (root-cause of test failures from .001) > `list` shell command does not return an array of table names > > > Key: HBASE-19770 > URL: https://issues.apache.org/jira/browse/HBASE-19770 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: Romil Choksi >Assignee: Josh Elser >Priority: Critical > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19770.001.branch-2.patch, > HBASE-19770.002.branch-2.patch > > > Another good find by our Romil. > {code} > hbase(main):001:0> list > TABLE > a > 1 row(s) > Took 0.8385 seconds > hbase(main):002:0> tables=list > TABLE > a > 1 row(s) > Took 0.0267 seconds > hbase(main):003:0> puts tables > hbase(main):004:0> p tables > nil > {code} > The {{list}} command should be returning {{\['a'\]}} but is not. > The command class itself appears to be doing the right thing -- maybe the > retval is getting lost somewhere else? > FYI [~stack]. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19554) AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit
[ https://issues.apache.org/jira/browse/HBASE-19554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324612#comment-16324612 ] stack commented on HBASE-19554: --- I disabled TestDLSAsyncFSWAL and TestDLSFSHLog so I can cut the beta-1. They fail 40% and 33% respectively on branch-2. Disabled them in master too... since once fixed, we can add it in both places. Will be back to help out. Just disabling so can push out the beta. Thanks. > AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit > -- > > Key: HBASE-19554 > URL: https://issues.apache.org/jira/browse/HBASE-19554 > Project: HBase > Issue Type: Bug > Components: Recovery, wal >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19554.patch > > > https://builds.apache.org/job/PreCommit-HBASE-Build/10554/artifact/patchprocess/patch-unit-hbase-server.txt > The error message is a bit strange: > {quote} > [ERROR] testThreeRSAbort(org.apache.hadoop.hbase.master.TestDLSAsyncFSWAL) > Time elapsed: 20.627 s <<< ERROR! > org.apache.hadoop.hbase.TableNotFoundException: Region of > 'hbase:namespace,,1513320505933.451650152885a3b41d0b1110deca513c.' is > expected in the table of 'testThreeRSAbort', but hbase:meta says it is in the > table of 'hbase:namespace'. hbase:meta might be damaged. > {quote} > It fails for both FSHLog and AsyncFSWAL. Need to dig more. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19554) AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit
[ https://issues.apache.org/jira/browse/HBASE-19554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19554: -- Fix Version/s: 2.0.0-beta-2 > AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit > -- > > Key: HBASE-19554 > URL: https://issues.apache.org/jira/browse/HBASE-19554 > Project: HBase > Issue Type: Bug > Components: Recovery, wal >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19554.patch > > > https://builds.apache.org/job/PreCommit-HBASE-Build/10554/artifact/patchprocess/patch-unit-hbase-server.txt > The error message is a bit strange: > {quote} > [ERROR] testThreeRSAbort(org.apache.hadoop.hbase.master.TestDLSAsyncFSWAL) > Time elapsed: 20.627 s <<< ERROR! > org.apache.hadoop.hbase.TableNotFoundException: Region of > 'hbase:namespace,,1513320505933.451650152885a3b41d0b1110deca513c.' is > expected in the table of 'testThreeRSAbort', but hbase:meta says it is in the > table of 'hbase:namespace'. hbase:meta might be damaged. > {quote} > It fails for both FSHLog and AsyncFSWAL. Need to dig more. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19756) Master NPE during completed failed proc eviction
[ https://issues.apache.org/jira/browse/HBASE-19756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324603#comment-16324603 ] Hadoop QA commented on HBASE-19756: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 10s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 47s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 57s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 22s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m 7s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 44s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 9s{color} | {color:red} hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 46s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 21m 18s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 40s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 6s{color} | {color:green} hbase-procedure in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 99m 31s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 33s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}145m 45s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 | | JIRA Issue | HBASE-19756 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12905910/HBASE-19756.master.001.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux ab05668b18d2 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / a5601c8eac | | maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) | | Default Java | 1.8.0_151 | | checkstyle |
[jira] [Commented] (HBASE-19787) Fix or disable tests broken in branch-2 so can cut beta-1
[ https://issues.apache.org/jira/browse/HBASE-19787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324602#comment-16324602 ] stack commented on HBASE-19787: --- Here is changeset note: HBASE-19787 Fix or disable tests broken in branch-2 so can cut beta-1 M dev-support/make_rc.sh Disable checkstyle building site. Its an issue being fixed over in HBASE-19780 M hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java The clusterid was being set into the process only after the regionserver registers with the Master. That can be too late for some test clients in particular. e.g. TestZKAsyncRegistry needs it as soon as it goes to run which could be before Master had called its run method which is regionserver run method which then calls back to the master to register itself... and only then do we set the clusterid. HBASE-19694 changed start order which made it so this test failed. Setting the clusterid right after we set it in zk makes the test pass. Another change was that backup masters were not going down on stop. Backup masters were sleeping for the default zk period which is 90 seconds. They were not being woken up to check for stop. On stop master now tells active master manager. M hbase-server/src/test/java/org/apache/hadoop/hbase/TestJMXConnectorServer.java Prevent creation of acl table. Messes up our being able to go down promptly. M hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestRegionsOnMasterOptions.java M hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReadRequestMetrics.java Disabled for now because it wants to run with regions on the Master... currently broke! M hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestZKAsyncRegistry.java Add a bit of debugging. M hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDLSAsyncFSWAL.java Disabled. Fails 40% of the time. M hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDLSFSHLog.java Disabled. Fails 33% of the time. Disabled stochastic load balancer for favored nodes because it fails on occasion and we are not doing favored nodes in branch-2. Filing follow-on issues. > Fix or disable tests broken in branch-2 so can cut beta-1 > - > > Key: HBASE-19787 > URL: https://issues.apache.org/jira/browse/HBASE-19787 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19787.branch-2.001.patch > > > Appy's dashboard for 2.0 > https://builds.apache.org/job/HBase-Find-Flaky-Tests-branch2.0/lastSuccessfulBuild/artifact/dashboard.html > and a GCE run last night showed how bad of a state our unit tests are in on > tip of branch-2. This issue does triage fixing and disabling so I can push > out the beta-1. Its done as a subtask of HBASE-19694 because a few of the > tests were broke by this commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19787) Fix or disable tests broken in branch-2 so can cut beta-1
[ https://issues.apache.org/jira/browse/HBASE-19787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19787: -- Attachment: HBASE-19787.branch-2.001.patch > Fix or disable tests broken in branch-2 so can cut beta-1 > - > > Key: HBASE-19787 > URL: https://issues.apache.org/jira/browse/HBASE-19787 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19787.branch-2.001.patch > > > Appy's dashboard for 2.0 > https://builds.apache.org/job/HBase-Find-Flaky-Tests-branch2.0/lastSuccessfulBuild/artifact/dashboard.html > and a GCE run last night showed how bad of a state our unit tests are in on > tip of branch-2. This issue does triage fixing and disabling so I can push > out the beta-1. Its done as a subtask of HBASE-19694 because a few of the > tests were broke by this commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19757) hbase:meta table gets stuck after enabling region server group feature
[ https://issues.apache.org/jira/browse/HBASE-19757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324600#comment-16324600 ] Ted Yu commented on HBASE-19757: The above log corresponds to the following actions in generateGroupMaps(): {code} regionMap.put(null, region); ... serverMap.put(null, LoadBalancer.BOGUS_SERVER_NAME); {code} The region is hbase:acl > hbase:meta table gets stuck after enabling region server group feature > -- > > Key: HBASE-19757 > URL: https://issues.apache.org/jira/browse/HBASE-19757 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 19757.v1.txt, 19757.v2.txt > > > I was testing on an hbase-2 secure cluster against hadoop 3 where some tables > were created without region server group feature. > After adding the RSGroupAdminEndpoint and RSGroupBasedLoadBalancer to > hbase-site, I restarted the whole cluster. > After the restart, hbase:meta region got stuck in transition (forever). > {code} > 2018-01-10 21:20:16,696 INFO > [org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker-ctr-e137-1514896590304-8706-01-02.hwx.site,2,1515619212617] > zookeeper.MetaTableLocator: Failed verification of hbase:meta,,1 at > address=ctr-e137-1514896590304-8706-01-04.hwx.site,16020,1515618538016, > exception=org.apache.hadoop.hbase.NotServingRegionException: > hbase:meta,,1 is not online on > ctr-e137-1514896590304-8706-01-04.hwx.site,16020,1515619181453 > at > org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3314) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3291) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1355) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegionInfo(RSRpcServices.java:1667) > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19757) hbase:meta table gets stuck after enabling region server group feature
[ https://issues.apache.org/jira/browse/HBASE-19757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324592#comment-16324592 ] Ted Yu commented on HBASE-19757: With a bit more logging in generateGroupMaps(), I saw: {code} 2018-01-12 21:26:21,695 WARN [ProcExecWrkr-19] rsgroup.RSGroupBasedLoadBalancer(257): Group for table hbase:acl is null 2018-01-12 21:26:21,695 WARN [ProcExecWrkr-19] rsgroup.RSGroupBasedLoadBalancer(279): RSGroup Information found to be null. Some regions might be unassigned. 2018-01-12 21:26:21,695 DEBUG [ProcExecWrkr-19] rsgroup.RSGroupBasedLoadBalancer(265): assigning bogus to null groupKey {code} > hbase:meta table gets stuck after enabling region server group feature > -- > > Key: HBASE-19757 > URL: https://issues.apache.org/jira/browse/HBASE-19757 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 19757.v1.txt, 19757.v2.txt > > > I was testing on an hbase-2 secure cluster against hadoop 3 where some tables > were created without region server group feature. > After adding the RSGroupAdminEndpoint and RSGroupBasedLoadBalancer to > hbase-site, I restarted the whole cluster. > After the restart, hbase:meta region got stuck in transition (forever). > {code} > 2018-01-10 21:20:16,696 INFO > [org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker-ctr-e137-1514896590304-8706-01-02.hwx.site,2,1515619212617] > zookeeper.MetaTableLocator: Failed verification of hbase:meta,,1 at > address=ctr-e137-1514896590304-8706-01-04.hwx.site,16020,1515618538016, > exception=org.apache.hadoop.hbase.NotServingRegionException: > hbase:meta,,1 is not online on > ctr-e137-1514896590304-8706-01-04.hwx.site,16020,1515619181453 > at > org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3314) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3291) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1355) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegionInfo(RSRpcServices.java:1667) > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19780) Fix build in branch-2
[ https://issues.apache.org/jira/browse/HBASE-19780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324588#comment-16324588 ] Hadoop QA commented on HBASE-19780: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m 27s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 27s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 55s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 56s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 16m 21s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 56s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 19s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m 14s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 37m 39s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 51s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 9s{color} | {color:green} hbase-error-prone in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 9s{color} | {color:green} hbase-annotations in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 29s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 12s{color} | {color:green} hbase-metrics-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 24s{color} | {color:green} hbase-hadoop-compat in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 18s{color} | {color:green} hbase-metrics in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 20s{color} | {color:green} hbase-protocol in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 16s{color} | {color:green} hbase-replication in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 23s{color} | {color:green} hbase-thrift in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 35s{color} | {color:green} hbase-rsgroup in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 15s{color} | {color:green} hbase-external-blockcache in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 5m 21s{color} | {color:green} hbase-spark in the patch passed.
[jira] [Created] (HBASE-19787) Fix or disable tests broken in branch-2 so can cut beta-1
stack created HBASE-19787: - Summary: Fix or disable tests broken in branch-2 so can cut beta-1 Key: HBASE-19787 URL: https://issues.apache.org/jira/browse/HBASE-19787 Project: HBase Issue Type: Sub-task Reporter: stack Assignee: stack Priority: Critical Fix For: 2.0.0-beta-1 Appy's dashboard for 2.0 https://builds.apache.org/job/HBase-Find-Flaky-Tests-branch2.0/lastSuccessfulBuild/artifact/dashboard.html and a GCE run last night showed how bad of a state our unit tests are in on tip of branch-2. This issue does triage fixing and disabling so I can push out the beta-1. Its done as a subtask of HBASE-19694 because a few of the tests were broke by this commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-11409) Add more flexibility for input directory structure to LoadIncrementalHFiles
[ https://issues.apache.org/jira/browse/HBASE-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] churro morales updated HBASE-11409: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Add more flexibility for input directory structure to LoadIncrementalHFiles > --- > > Key: HBASE-11409 > URL: https://issues.apache.org/jira/browse/HBASE-11409 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: churro morales >Assignee: churro morales > Fix For: 3.0.0, 1.5.0, 2.0.0-beta-1 > > Attachments: HBASE-11409.v1.patch, HBASE-11409.v2.patch, > HBASE-11409.v3.patch, HBASE-11409.v4.patch, HBASE-11409.v5.patch, > HBASE-11409.v6.branch-1.patch > > > Use case: > We were trying to combine two very large tables into a single table. Thus we > ran jobs in one datacenter that populated certain column families and another > datacenter which populated other column families. Took a snapshot and > exported them to their respective datacenters. Wanted to simply take the > hdfs restored snapshot and use LoadIncremental to merge the data. > It would be nice to add support where we could run LoadIncremental on a > directory where the depth of store files is something other than two (current > behavior). > With snapshots it would be nice if you could pass a restored hdfs snapshot's > directory and have the tool run. > I am attaching a patch where I parameterize the bulkLoad timeout as well as > the default store file depth. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-11409) Add more flexibility for input directory structure to LoadIncrementalHFiles
[ https://issues.apache.org/jira/browse/HBASE-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324579#comment-16324579 ] churro morales commented on HBASE-11409: pushed to branch-1, branch-2 and master. Closing this one out. Thanks for the review guys. > Add more flexibility for input directory structure to LoadIncrementalHFiles > --- > > Key: HBASE-11409 > URL: https://issues.apache.org/jira/browse/HBASE-11409 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: churro morales >Assignee: churro morales > Fix For: 3.0.0, 1.5.0, 2.0.0-beta-1 > > Attachments: HBASE-11409.v1.patch, HBASE-11409.v2.patch, > HBASE-11409.v3.patch, HBASE-11409.v4.patch, HBASE-11409.v5.patch, > HBASE-11409.v6.branch-1.patch > > > Use case: > We were trying to combine two very large tables into a single table. Thus we > ran jobs in one datacenter that populated certain column families and another > datacenter which populated other column families. Took a snapshot and > exported them to their respective datacenters. Wanted to simply take the > hdfs restored snapshot and use LoadIncremental to merge the data. > It would be nice to add support where we could run LoadIncremental on a > directory where the depth of store files is something other than two (current > behavior). > With snapshots it would be nice if you could pass a restored hdfs snapshot's > directory and have the tool run. > I am attaching a patch where I parameterize the bulkLoad timeout as well as > the default store file depth. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-11409) Add more flexibility for input directory structure to LoadIncrementalHFiles
[ https://issues.apache.org/jira/browse/HBASE-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] churro morales updated HBASE-11409: --- Fix Version/s: 1.5.0 3.0.0 > Add more flexibility for input directory structure to LoadIncrementalHFiles > --- > > Key: HBASE-11409 > URL: https://issues.apache.org/jira/browse/HBASE-11409 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: churro morales >Assignee: churro morales > Fix For: 3.0.0, 1.5.0, 2.0.0-beta-1 > > Attachments: HBASE-11409.v1.patch, HBASE-11409.v2.patch, > HBASE-11409.v3.patch, HBASE-11409.v4.patch, HBASE-11409.v5.patch, > HBASE-11409.v6.branch-1.patch > > > Use case: > We were trying to combine two very large tables into a single table. Thus we > ran jobs in one datacenter that populated certain column families and another > datacenter which populated other column families. Took a snapshot and > exported them to their respective datacenters. Wanted to simply take the > hdfs restored snapshot and use LoadIncremental to merge the data. > It would be nice to add support where we could run LoadIncremental on a > directory where the depth of store files is something other than two (current > behavior). > With snapshots it would be nice if you could pass a restored hdfs snapshot's > directory and have the tool run. > I am attaching a patch where I parameterize the bulkLoad timeout as well as > the default store file depth. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19786) acl table is created by coprocessor inside Master start procedure; broke TestJMXConnectorServer
stack created HBASE-19786: - Summary: acl table is created by coprocessor inside Master start procedure; broke TestJMXConnectorServer Key: HBASE-19786 URL: https://issues.apache.org/jira/browse/HBASE-19786 Project: HBase Issue Type: Sub-task Reporter: stack Assignee: stack Fix For: 2.0.0-beta-2 Parent reordering of startup broke TestJMXConnectorServer. Its failing because we start cluster then near immediately go down. Meantime, the acl table is trying to get created but the servers have been pulled out from under it so it can't complete Test gets stuck. Creating tables inside the Master startup process is a bit dodgy. Fix. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19785) System Regions on the Master is broken by parent HBASE-19694
stack created HBASE-19785: - Summary: System Regions on the Master is broken by parent HBASE-19694 Key: HBASE-19785 URL: https://issues.apache.org/jira/browse/HBASE-19785 Project: HBase Issue Type: Sub-task Reporter: stack Assignee: stack Fix For: 2.0.0-beta-2 The parent issue broke our being able to host system regions only on the Master. This broke a few tests that depend on this ability. Two of the below actually enable system regions on the Master for the test run. The remainder is the test that make sure this works. TestMultiParallel TestRegionsOnMasterOptions TestRegionServerReadRequestMetrics Parent changed the startup order. System regions and Master-as-a-RegionServer are having issues because we wait for regionservers to check in before completing Master startup which gets interesting when Master is supposed to act like a RegionServer. Previously, Master startup was off in a background thread. Needs more thought but not required for beta-1. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19694) The initialization order for a fresh cluster is incorrect
[ https://issues.apache.org/jira/browse/HBASE-19694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19694: -- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed the addendum that will help if a hang. > The initialization order for a fresh cluster is incorrect > - > > Key: HBASE-19694 > URL: https://issues.apache.org/jira/browse/HBASE-19694 > Project: HBase > Issue Type: Bug >Reporter: Duo Zhang >Assignee: stack >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: 0001-HBASE-19694.addendum.branch-2.patch, > HBASE-19694.branch-2.001.patch, HBASE-19694.branch-2.002.patch, > HBASE-19694.branch-2.003.patch, HBASE-19694.branch-2.004.patch, > HBASE-19694.branch-2.005.patch, HBASE-19694.branch-2.006.patch, > HBASE-19694.branch-2.007.patch, HBASE-19694.branch-2.008.patch, > HBASE-19694.branch-2.009.patch, HBASE-19694.branch-2.010.patch, > HBASE-19694.branch-2.011.patch, HBASE-19694.branch-2.012.patch > > > The cluster id will set once we become the active master in > finishActiveMasterInitialization, but the blockUntilBecomingActiveMaster and > finishActiveMasterInitialization are both called in a thread to make the > constructor of HMaster return without blocking. And since HMaster itself is > also a HRegionServer, it will create a Connection and then start calling > reportForDuty. And when creating the ConnectionImplementation, we will read > the cluster id from zk, but the cluster id may have not been set yet since it > is set in another thread, we will get an exception and use the default > cluster id instead. > I always get this when running UTs which will start a mini cluster > {noformat} > 2018-01-03 15:16:37,916 WARN [M:0;zhangduo-ubuntu:32848] > client.ConnectionImplementation(528): Retrieve cluster id failed > java.util.concurrent.ExecutionException: > org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = > NoNode for /hbase/hbaseid > at > java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357) > at > java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1895) > at > org.apache.hadoop.hbase.client.ConnectionImplementation.retrieveClusterId(ConnectionImplementation.java:526) > at > org.apache.hadoop.hbase.client.ConnectionImplementation.(ConnectionImplementation.java:286) > at > org.apache.hadoop.hbase.client.ConnectionUtils$ShortCircuitingClusterConnection.(ConnectionUtils.java:141) > at > org.apache.hadoop.hbase.client.ConnectionUtils$ShortCircuitingClusterConnection.(ConnectionUtils.java:137) > at > org.apache.hadoop.hbase.client.ConnectionUtils.createShortCircuitConnection(ConnectionUtils.java:185) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.createClusterConnection(HRegionServer.java:781) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.setupClusterConnection(HRegionServer.java:812) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:827) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:938) > at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:550) > at java.lang.Thread.run(Thread.java:748) > Caused by: org.apache.zookeeper.KeeperException$NoNodeException: > KeeperErrorCode = NoNode for /hbase/hbaseid > at org.apache.zookeeper.KeeperException.create(KeeperException.java:111) > at org.apache.zookeeper.KeeperException.create(KeeperException.java:51) > at > org.apache.hadoop.hbase.zookeeper.ReadOnlyZKClient$ZKTask$1.exec(ReadOnlyZKClient.java:163) > at > org.apache.hadoop.hbase.zookeeper.ReadOnlyZKClient.run(ReadOnlyZKClient.java:311) > ... 1 more > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15321) Ability to open a HRegion from hdfs snapshot.
[ https://issues.apache.org/jira/browse/HBASE-15321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324552#comment-16324552 ] Hadoop QA commented on HBASE-15321: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 15m 23s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} branch-1 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 53s{color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 35s{color} | {color:green} branch-1 passed with JDK v1.8.0_152 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s{color} | {color:green} branch-1 passed with JDK v1.7.0_161 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 21s{color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 54s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 14s{color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s{color} | {color:green} branch-1 passed with JDK v1.8.0_152 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s{color} | {color:green} branch-1 passed with JDK v1.7.0_161 {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 38s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 22s{color} | {color:red} hbase-server: The patch generated 4 new + 357 unchanged - 3 fixed = 361 total (was 360) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 52s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 16m 51s{color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.4. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 12s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 91m 7s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}145m 9s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.replication.TestSerialReplication | | | hadoop.hbase.master.TestCatalogJanitorInMemoryStates | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:36a7029 | | JIRA Issue | HBASE-15321 | | JIRA Patch URL |
[jira] [Updated] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19752: --- Attachment: 19752.v7.branch-1.txt > RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where > rs group cannot be determined > - > > Key: HBASE-19752 > URL: https://issues.apache.org/jira/browse/HBASE-19752 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.1, 1.5.0, 2.0.0-beta-1 > > Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt, > 19752.v5.txt, 19752.v6.txt, 19752.v7.branch-1.txt, 19752.v7.txt > > > Observed the following in rs group test output: > {code} > 2018-01-10 14:17:23,006 DEBUG [AssignmentThread] > rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region: > hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server: > localhost,1,1 found in group: null outside of group: UNKNOWN > {code} > Here is corresponding code: > {code} > if (assignedServer != null && > (info == null || > !info.containsServer(assignedServer.getAddress( { > RSGroupInfo otherInfo = null; > otherInfo = > rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress()); > LOG.debug("Found misplaced region: " + > regionInfo.getRegionNameAsString() + > {code} > As you can see, both info and otherInfo were null. > In this case, the region should not be placed in misplacedRegions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19752: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: (was: 2.0.0) 2.0.0-beta-1 Status: Resolved (was: Patch Available) Thanks all for the reviews. > RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where > rs group cannot be determined > - > > Key: HBASE-19752 > URL: https://issues.apache.org/jira/browse/HBASE-19752 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 1.4.1, 1.5.0, 2.0.0-beta-1 > > Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt, > 19752.v5.txt, 19752.v6.txt, 19752.v7.branch-1.txt, 19752.v7.txt > > > Observed the following in rs group test output: > {code} > 2018-01-10 14:17:23,006 DEBUG [AssignmentThread] > rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region: > hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server: > localhost,1,1 found in group: null outside of group: UNKNOWN > {code} > Here is corresponding code: > {code} > if (assignedServer != null && > (info == null || > !info.containsServer(assignedServer.getAddress( { > RSGroupInfo otherInfo = null; > otherInfo = > rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress()); > LOG.debug("Found misplaced region: " + > regionInfo.getRegionNameAsString() + > {code} > As you can see, both info and otherInfo were null. > In this case, the region should not be placed in misplacedRegions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19164) Avoid UUID.randomUUID in tests
[ https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324537#comment-16324537 ] Mike Drob commented on HBASE-19164: --- Attempted to rerun the precommit, patch probably needs a rebase... > Avoid UUID.randomUUID in tests > -- > > Key: HBASE-19164 > URL: https://issues.apache.org/jira/browse/HBASE-19164 > Project: HBase > Issue Type: Improvement > Components: test >Reporter: Mike Drob >Assignee: Sahil Aggarwal > Labels: beginner > Attachments: HBASE-19164.master.001.patch, > HBASE-19164.master.002.patch, HBASE-19164.master.003.patch > > > We have a lot of places in our test code where we use {{UUID.randomUUID}} to > generate table names or paths for uniqueness. Unfortunately, this uses up a > good chunk of system entropy, since Sun chose that random UUID's should use > the NativePRNGBlocking implementation. > We don't need to block on entropy for random bits to pick a random table name > in a test, so we can use something that doesn't strain the system too much - > secure random can be a source of problems on some VM or containers. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19164) Avoid UUID.randomUUID in tests
[ https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324535#comment-16324535 ] Hadoop QA commented on HBASE-19164: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color} | {color:red} HBASE-19164 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | HBASE-19164 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12897011/HBASE-19164.master.003.patch | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11054/console | | Powered by | Apache Yetus 0.6.0 http://yetus.apache.org | This message was automatically generated. > Avoid UUID.randomUUID in tests > -- > > Key: HBASE-19164 > URL: https://issues.apache.org/jira/browse/HBASE-19164 > Project: HBase > Issue Type: Improvement > Components: test >Reporter: Mike Drob >Assignee: Sahil Aggarwal > Labels: beginner > Attachments: HBASE-19164.master.001.patch, > HBASE-19164.master.002.patch, HBASE-19164.master.003.patch > > > We have a lot of places in our test code where we use {{UUID.randomUUID}} to > generate table names or paths for uniqueness. Unfortunately, this uses up a > good chunk of system entropy, since Sun chose that random UUID's should use > the NativePRNGBlocking implementation. > We don't need to block on entropy for random bits to pick a random table name > in a test, so we can use something that doesn't strain the system too much - > secure random can be a source of problems on some VM or containers. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324532#comment-16324532 ] Hadoop QA commented on HBASE-19752: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 53s{color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 11s{color} | {color:blue} The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for instructions. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 31s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 23s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 46s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 50s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 20m 58s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 6s{color} | {color:green} hbase-rsgroup in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 8s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 42m 4s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 | | JIRA Issue | HBASE-19752 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12905917/19752.v7.txt | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 34996b0b42fc 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / a5601c8eac | | maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) | | Default Java | 1.8.0_151 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11052/testReport/ | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11052/console | | Powered by | Apache Yetus 0.6.0 http://yetus.apache.org | This
[jira] [Commented] (HBASE-19757) hbase:meta table gets stuck after enabling region server group feature
[ https://issues.apache.org/jira/browse/HBASE-19757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324521#comment-16324521 ] Andrew Purtell commented on HBASE-19757: "localhost,1,1" is the bogus server name (LoadBalancer.BOGUS_SERVER_NAME). Seen over on HBASE-19752. RSgroup info for the bogus server is going to be null. That is correct. There are conditionals which prevent the bogus server from entering any groups. What seems wrong is that the system table is assigned to a bogus server. Chase this down and I bet you have the fix. > hbase:meta table gets stuck after enabling region server group feature > -- > > Key: HBASE-19757 > URL: https://issues.apache.org/jira/browse/HBASE-19757 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 19757.v1.txt, 19757.v2.txt > > > I was testing on an hbase-2 secure cluster against hadoop 3 where some tables > were created without region server group feature. > After adding the RSGroupAdminEndpoint and RSGroupBasedLoadBalancer to > hbase-site, I restarted the whole cluster. > After the restart, hbase:meta region got stuck in transition (forever). > {code} > 2018-01-10 21:20:16,696 INFO > [org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker-ctr-e137-1514896590304-8706-01-02.hwx.site,2,1515619212617] > zookeeper.MetaTableLocator: Failed verification of hbase:meta,,1 at > address=ctr-e137-1514896590304-8706-01-04.hwx.site,16020,1515618538016, > exception=org.apache.hadoop.hbase.NotServingRegionException: > hbase:meta,,1 is not online on > ctr-e137-1514896590304-8706-01-04.hwx.site,16020,1515619181453 > at > org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3314) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3291) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1355) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegionInfo(RSRpcServices.java:1667) > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19783) Change replication peer cluster key/endpoint from a not-null value to null is not allowed
[ https://issues.apache.org/jira/browse/HBASE-19783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324518#comment-16324518 ] Hudson commented on HBASE-19783: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4389 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4389/]) HBASE-19783 Change replication peer cluster key/endpoint from a not-null (zhangduo: rev 20ccaef8418a34b909256c2a0b68f55b390c9dfb) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/replication/TestReplicationAdmin.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java > Change replication peer cluster key/endpoint from a not-null value to null is > not allowed > - > > Key: HBASE-19783 > URL: https://issues.apache.org/jira/browse/HBASE-19783 > Project: HBase > Issue Type: Bug > Components: Replication >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Minor > Fix For: 3.0.0, 2.0.0-beta-2 > > Attachments: HBASE-19783.branch-2.001.patch, > HBASE-19783.branch-2.002.patch, HBASE-19783.master.001.patch, > HBASE-19783.master.002.patch, HBASE-19783.master.003.patch, > HBASE-19783.master.004.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19771) restore_snapshot shell command gives wrong namespace if the namespace doesn't exist
[ https://issues.apache.org/jira/browse/HBASE-19771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324519#comment-16324519 ] Hudson commented on HBASE-19771: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4389 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4389/]) HBASE-19771 restore_snapshot shell command gives wrong namespace if the (tedyu: rev 8bbfcdda46aeec23ebcdc1713cf636081a1c96d0) * (edit) hbase-shell/src/main/ruby/shell/commands.rb > restore_snapshot shell command gives wrong namespace if the namespace doesn't > exist > --- > > Key: HBASE-19771 > URL: https://issues.apache.org/jira/browse/HBASE-19771 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-beta-1 >Reporter: Ted Yu >Assignee: Janos Gub >Priority: Minor > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19771.master.001.patch > > > For the following snapshot: > {code} > snapshot_table_tav6mrq397 > NS592088:table_tav6mrq397 (2018-01-10 16:20:39 UTC) > {code} > namespace NS592088 is dropped. > restore_snapshot on the snapshot gave the following : > {code} > hbase(main):003:0> restore_snapshot 'snapshot_table_tav6mrq397' > ERROR: Unknown namespace snapshot_table_tav6mrq397! > {code} > The namespace in the message was incorrect. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324516#comment-16324516 ] Andrew Purtell commented on HBASE-19752: +1 > RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where > rs group cannot be determined > - > > Key: HBASE-19752 > URL: https://issues.apache.org/jira/browse/HBASE-19752 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 2.0.0, 1.4.1, 1.5.0 > > Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt, > 19752.v5.txt, 19752.v6.txt, 19752.v7.txt > > > Observed the following in rs group test output: > {code} > 2018-01-10 14:17:23,006 DEBUG [AssignmentThread] > rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region: > hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server: > localhost,1,1 found in group: null outside of group: UNKNOWN > {code} > Here is corresponding code: > {code} > if (assignedServer != null && > (info == null || > !info.containsServer(assignedServer.getAddress( { > RSGroupInfo otherInfo = null; > otherInfo = > rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress()); > LOG.debug("Found misplaced region: " + > regionInfo.getRegionNameAsString() + > {code} > As you can see, both info and otherInfo were null. > In this case, the region should not be placed in misplacedRegions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19780) Fix build in branch-2
[ https://issues.apache.org/jira/browse/HBASE-19780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-19780: -- Status: Patch Available (was: Open) I ran into this error too, but I don't understand the issue. Attempting v1 - is this what y'all meant? > Fix build in branch-2 > - > > Key: HBASE-19780 > URL: https://issues.apache.org/jira/browse/HBASE-19780 > Project: HBase > Issue Type: Bug >Reporter: Appy > Attachments: HBASE-19780.master.001.patch > > > Not able to run following command successfully: > {{mvn -DskipTests install site > -Dmaven.repo.local=/Users/appy/Desktop/temp_repo}} > Use a clean separate repo so that existing packages don't pollute the build. > Error is following. > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project > hbase: failed to get report for > org.apache.maven.plugins:maven-javadoc-plugin: Failed to execute goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) on > project hbase-error-prone: Execution checkstyle of goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed: Plugin > org.apache.maven.plugins:maven-checkstyle-plugin:2.17 or one of its > dependencies could not be resolved: Failure to find > org.apache.hbase:hbase-checkstyle:jar:2.0.0-beta-1 in > http://repository.apache.org/snapshots/ was cached in the local repository, > resolution will not be reattempted until the update interval of > apache.snapshots has elapsed or updates are forced -> [Help 1] > {noformat} > Note that master build goes pass this point. > Need to figure out what's the difference and fix the overall build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324497#comment-16324497 ] Ted Yu commented on HBASE-19752: >From HBASE-19757 : bq. For HBASE-19752, change the log level to WARN for the second case as described on the JIRA and you have my +1 > RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where > rs group cannot be determined > - > > Key: HBASE-19752 > URL: https://issues.apache.org/jira/browse/HBASE-19752 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 2.0.0, 1.4.1, 1.5.0 > > Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt, > 19752.v5.txt, 19752.v6.txt, 19752.v7.txt > > > Observed the following in rs group test output: > {code} > 2018-01-10 14:17:23,006 DEBUG [AssignmentThread] > rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region: > hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server: > localhost,1,1 found in group: null outside of group: UNKNOWN > {code} > Here is corresponding code: > {code} > if (assignedServer != null && > (info == null || > !info.containsServer(assignedServer.getAddress( { > RSGroupInfo otherInfo = null; > otherInfo = > rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress()); > LOG.debug("Found misplaced region: " + > regionInfo.getRegionNameAsString() + > {code} > As you can see, both info and otherInfo were null. > In this case, the region should not be placed in misplacedRegions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19780) Fix build in branch-2
[ https://issues.apache.org/jira/browse/HBASE-19780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-19780: -- Attachment: HBASE-19780.master.001.patch > Fix build in branch-2 > - > > Key: HBASE-19780 > URL: https://issues.apache.org/jira/browse/HBASE-19780 > Project: HBase > Issue Type: Bug >Reporter: Appy > Attachments: HBASE-19780.master.001.patch > > > Not able to run following command successfully: > {{mvn -DskipTests install site > -Dmaven.repo.local=/Users/appy/Desktop/temp_repo}} > Use a clean separate repo so that existing packages don't pollute the build. > Error is following. > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project > hbase: failed to get report for > org.apache.maven.plugins:maven-javadoc-plugin: Failed to execute goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) on > project hbase-error-prone: Execution checkstyle of goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed: Plugin > org.apache.maven.plugins:maven-checkstyle-plugin:2.17 or one of its > dependencies could not be resolved: Failure to find > org.apache.hbase:hbase-checkstyle:jar:2.0.0-beta-1 in > http://repository.apache.org/snapshots/ was cached in the local repository, > resolution will not be reattempted until the update interval of > apache.snapshots has elapsed or updates are forced -> [Help 1] > {noformat} > Note that master build goes pass this point. > Need to figure out what's the difference and fix the overall build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19757) hbase:meta table gets stuck after enabling region server group feature
[ https://issues.apache.org/jira/browse/HBASE-19757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324481#comment-16324481 ] Andrew Purtell commented on HBASE-19757: For HBASE-19752, change the log level to WARN for the second case as described on the JIRA and you have my +1. As for this patch, {code} // need to assign system table even if its group is null {code} I think the question is why is the RSGroup for the system table is null. Fix that and we don't need this special case, which doesn't look quite right. > hbase:meta table gets stuck after enabling region server group feature > -- > > Key: HBASE-19757 > URL: https://issues.apache.org/jira/browse/HBASE-19757 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 19757.v1.txt, 19757.v2.txt > > > I was testing on an hbase-2 secure cluster against hadoop 3 where some tables > were created without region server group feature. > After adding the RSGroupAdminEndpoint and RSGroupBasedLoadBalancer to > hbase-site, I restarted the whole cluster. > After the restart, hbase:meta region got stuck in transition (forever). > {code} > 2018-01-10 21:20:16,696 INFO > [org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker-ctr-e137-1514896590304-8706-01-02.hwx.site,2,1515619212617] > zookeeper.MetaTableLocator: Failed verification of hbase:meta,,1 at > address=ctr-e137-1514896590304-8706-01-04.hwx.site,16020,1515618538016, > exception=org.apache.hadoop.hbase.NotServingRegionException: > hbase:meta,,1 is not online on > ctr-e137-1514896590304-8706-01-04.hwx.site,16020,1515619181453 > at > org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3314) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3291) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1355) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegionInfo(RSRpcServices.java:1667) > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19752: --- Attachment: 19752.v7.txt Changed the second log to WARN level. > RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where > rs group cannot be determined > - > > Key: HBASE-19752 > URL: https://issues.apache.org/jira/browse/HBASE-19752 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 2.0.0, 1.4.1, 1.5.0 > > Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt, > 19752.v5.txt, 19752.v6.txt, 19752.v7.txt > > > Observed the following in rs group test output: > {code} > 2018-01-10 14:17:23,006 DEBUG [AssignmentThread] > rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region: > hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server: > localhost,1,1 found in group: null outside of group: UNKNOWN > {code} > Here is corresponding code: > {code} > if (assignedServer != null && > (info == null || > !info.containsServer(assignedServer.getAddress( { > RSGroupInfo otherInfo = null; > otherInfo = > rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress()); > LOG.debug("Found misplaced region: " + > regionInfo.getRegionNameAsString() + > {code} > As you can see, both info and otherInfo were null. > In this case, the region should not be placed in misplacedRegions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17825) Backup: further optimizations
[ https://issues.apache.org/jira/browse/HBASE-17825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-17825: --- Fix Version/s: (was: 2.1.0) 3.0.0 > Backup: further optimizations > - > > Key: HBASE-17825 > URL: https://issues.apache.org/jira/browse/HBASE-17825 > Project: HBase > Issue Type: Improvement >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Critical > Labels: backup > Fix For: 3.0.0 > > > Some phases of backup and restore can be optimized: > # WALPlayer support for multiple tables > # Run DistCp once per all tables during backup/restore > The eventual goal: > # 2 M/R jobs per backup/restore -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19756) Master NPE during completed failed proc eviction
[ https://issues.apache.org/jira/browse/HBASE-19756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324477#comment-16324477 ] Ted Yu commented on HBASE-19756: lgtm > Master NPE during completed failed proc eviction > > > Key: HBASE-19756 > URL: https://issues.apache.org/jira/browse/HBASE-19756 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.0, 1.3.1 >Reporter: Thiruvel Thirumoolan >Assignee: Thiruvel Thirumoolan > Fix For: 1.3.2, 1.4.1 > > Attachments: HBASE-19756.branch-1.4.001.patch, > HBASE-19756.branch-1.4.002.patch, HBASE-19756.branch-1.4.003.patch, > HBASE-19756.master.001.patch > > > When procedures like Create table fails due to say AccessDeniedException, > then a rollback procedure is created. When the rollback is being cleaned up, > it results in an NPE because those nonce procs aren't persisted > Stack trace when this happens: > {noformat} > java.lang.NullPointerException > at > org.apache.hadoop.hbase.procedure2.store.ProcedureStoreTracker.delete(ProcedureStoreTracker.java:385) > at > org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.updateStoreTracker(WALProcedureStore.java:547) > at > org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.pushData(WALProcedureStore.java:504) > at > org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.delete(WALProcedureStore.java:453) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor$CompletedProcedureCleaner.periodicExecute(ProcedureExecutor.java:184) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.timeoutLoop(ProcedureExecutor.java:995) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$500(ProcedureExecutor.java:78) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor$3.run(ProcedureExecutor.java:507) > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[ https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324458#comment-16324458 ] Andrew Purtell commented on HBASE-19752: The first new conditional in v8 patch in getMisplacedRegions looks good. The second is ok but I don't really understand why we are unable to obtain RSGroup information for the server. I agree it's not a misplaced region as such, but I think something else is not right. The log level here should be WARN. > RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where > rs group cannot be determined > - > > Key: HBASE-19752 > URL: https://issues.apache.org/jira/browse/HBASE-19752 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 2.0.0, 1.4.1, 1.5.0 > > Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt, > 19752.v5.txt, 19752.v6.txt > > > Observed the following in rs group test output: > {code} > 2018-01-10 14:17:23,006 DEBUG [AssignmentThread] > rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region: > hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server: > localhost,1,1 found in group: null outside of group: UNKNOWN > {code} > Here is corresponding code: > {code} > if (assignedServer != null && > (info == null || > !info.containsServer(assignedServer.getAddress( { > RSGroupInfo otherInfo = null; > otherInfo = > rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress()); > LOG.debug("Found misplaced region: " + > regionInfo.getRegionNameAsString() + > {code} > As you can see, both info and otherInfo were null. > In this case, the region should not be placed in misplacedRegions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17852) Add Fault tolerance to HBASE-14417 (Support bulk loaded files in incremental backup)
[ https://issues.apache.org/jira/browse/HBASE-17852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324439#comment-16324439 ] Josh Elser commented on HBASE-17852: bq. I'd prefer to see this land in master, then we take the concept back to the drawing board and, with all of your help, we revisit this and come up with a design and implementation that works for concurrent backup sessions (as Vlad has this on the Phase4 roadmap already). Ping [~appy]. > Add Fault tolerance to HBASE-14417 (Support bulk loaded files in incremental > backup) > > > Key: HBASE-17852 > URL: https://issues.apache.org/jira/browse/HBASE-17852 > Project: HBase > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Fix For: 2.0.0 > > Attachments: HBASE-17852-v1.patch, HBASE-17852-v2.patch, > HBASE-17852-v3.patch, HBASE-17852-v4.patch, HBASE-17852-v5.patch, > HBASE-17852-v6.patch, HBASE-17852-v7.patch, HBASE-17852-v8.patch, > HBASE-17852-v9.patch > > > Design approach rollback-via-snapshot implemented in this ticket: > # Before backup create/delete/merge starts we take a snapshot of the backup > meta-table (backup system table). This procedure is lightweight because meta > table is small, usually should fit a single region. > # When operation fails on a server side, we handle this failure by cleaning > up partial data in backup destination, followed by restoring backup > meta-table from a snapshot. > # When operation fails on a client side (abnormal termination, for example), > next time user will try create/merge/delete he(she) will see error message, > that system is in inconsistent state and repair is required, he(she) will > need to run backup repair tool. > # To avoid multiple writers to the backup system table (backup client and > BackupObserver's) we introduce small table ONLY to keep listing of bulk > loaded files. All backup observers will work only with this new tables. The > reason: in case of a failure during backup create/delete/merge/restore, when > system performs automatic rollback, some data written by backup observers > during failed operation may be lost. This is what we try to avoid. > # Second table keeps only bulk load related references. We do not care about > consistency of this table, because bulk load is idempotent operation and can > be repeated after failure. Partially written data in second table does not > affect on BackupHFileCleaner plugin, because this data (list of bulk loaded > files) correspond to a files which have not been loaded yet successfully and, > hence - are not visible to the system -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19756) Master NPE during completed failed proc eviction
[ https://issues.apache.org/jira/browse/HBASE-19756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324438#comment-16324438 ] Thiruvel Thirumoolan commented on HBASE-19756: -- Thanks for the review [~tedyu] 1. Latest patch precommit passed for 1.4 2. For master, the problem exists, but exception signature is different. The patch also is slightly different. Uploaded patch, lemme know how it looks. I am guessing my assumption that failed nonce procs don't have to be persisted is correct. > Master NPE during completed failed proc eviction > > > Key: HBASE-19756 > URL: https://issues.apache.org/jira/browse/HBASE-19756 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.0, 1.3.1 >Reporter: Thiruvel Thirumoolan >Assignee: Thiruvel Thirumoolan > Fix For: 1.3.2, 1.4.1 > > Attachments: HBASE-19756.branch-1.4.001.patch, > HBASE-19756.branch-1.4.002.patch, HBASE-19756.branch-1.4.003.patch, > HBASE-19756.master.001.patch > > > When procedures like Create table fails due to say AccessDeniedException, > then a rollback procedure is created. When the rollback is being cleaned up, > it results in an NPE because those nonce procs aren't persisted > Stack trace when this happens: > {noformat} > java.lang.NullPointerException > at > org.apache.hadoop.hbase.procedure2.store.ProcedureStoreTracker.delete(ProcedureStoreTracker.java:385) > at > org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.updateStoreTracker(WALProcedureStore.java:547) > at > org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.pushData(WALProcedureStore.java:504) > at > org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.delete(WALProcedureStore.java:453) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor$CompletedProcedureCleaner.periodicExecute(ProcedureExecutor.java:184) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.timeoutLoop(ProcedureExecutor.java:995) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$500(ProcedureExecutor.java:78) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor$3.run(ProcedureExecutor.java:507) > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19756) Master NPE during completed failed proc eviction
[ https://issues.apache.org/jira/browse/HBASE-19756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvel Thirumoolan updated HBASE-19756: - Attachment: HBASE-19756.master.001.patch > Master NPE during completed failed proc eviction > > > Key: HBASE-19756 > URL: https://issues.apache.org/jira/browse/HBASE-19756 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.0, 1.3.1 >Reporter: Thiruvel Thirumoolan >Assignee: Thiruvel Thirumoolan > Fix For: 1.3.2, 1.4.1 > > Attachments: HBASE-19756.branch-1.4.001.patch, > HBASE-19756.branch-1.4.002.patch, HBASE-19756.branch-1.4.003.patch, > HBASE-19756.master.001.patch > > > When procedures like Create table fails due to say AccessDeniedException, > then a rollback procedure is created. When the rollback is being cleaned up, > it results in an NPE because those nonce procs aren't persisted > Stack trace when this happens: > {noformat} > java.lang.NullPointerException > at > org.apache.hadoop.hbase.procedure2.store.ProcedureStoreTracker.delete(ProcedureStoreTracker.java:385) > at > org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.updateStoreTracker(WALProcedureStore.java:547) > at > org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.pushData(WALProcedureStore.java:504) > at > org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.delete(WALProcedureStore.java:453) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor$CompletedProcedureCleaner.periodicExecute(ProcedureExecutor.java:184) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.timeoutLoop(ProcedureExecutor.java:995) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$500(ProcedureExecutor.java:78) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor$3.run(ProcedureExecutor.java:507) > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19568) Restore of HBase table using incremental backup doesn't restore rows from an earlier incremental backup
[ https://issues.apache.org/jira/browse/HBASE-19568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-19568: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0 Status: Resolved (was: Patch Available) Pushed. Thanks for the patch, Vlad! > Restore of HBase table using incremental backup doesn't restore rows from an > earlier incremental backup > --- > > Key: HBASE-19568 > URL: https://issues.apache.org/jira/browse/HBASE-19568 > Project: HBase > Issue Type: Bug >Reporter: Romil Choksi >Assignee: Vladimir Rodionov > Fix For: 3.0.0 > > Attachments: HBASE-19568-v1.patch, HBASE-19568-v2.patch, > HBASE-19568-v3.patch, HBASE-19568-v4.patch > > > Credits to [~romil.choksi] > Restore of bulk-loaded HBase table doesn't restore deleted rows > Steps: > Create usertable and insert a few rows in it > Create full backup > Bulk load into usertable, and create first incremental backup > Bulk load into usertable again, and create second incremental backup > Delete row each from initial insert, first bulk load and second bulk load > Restore usertable using second incremental backup > Verify if each of the deleted rows has been restored > On restore using second incremental backup id, the test failed as all of the > rows from first bulk load were not available. Data from initial insertion > (full backup) and second bulk load were only available. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19694) The initialization order for a fresh cluster is incorrect
[ https://issues.apache.org/jira/browse/HBASE-19694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324391#comment-16324391 ] Hadoop QA commented on HBASE-19694: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 59s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} branch-2 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 35s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 43s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 4s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m 10s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s{color} | {color:green} branch-2 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 5s{color} | {color:green} hbase-server: The patch generated 0 new + 11 unchanged - 1 fixed = 11 total (was 12) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 59s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 15m 45s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green}105m 18s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}139m 26s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db | | JIRA Issue | HBASE-19694 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12905783/0001-HBASE-19694.addendum.branch-2.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c9b5b1d5d21f 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh | | git revision | branch-2 / f7fbc168a1 | | maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) | | Default Java | 1.8.0_151 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11049/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11049/console | | Powered by | Apache Yetus 0.6.0 http://yetus.apache.org | This message was automatically generated. >
[jira] [Commented] (HBASE-19778) Add the jira search-query link (for test's name) to the flaky dashboard
[ https://issues.apache.org/jira/browse/HBASE-19778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324380#comment-16324380 ] Zach York commented on HBASE-19778: --- Great idea! Thanks [~chia7712] > Add the jira search-query link (for test's name) to the flaky dashboard > --- > > Key: HBASE-19778 > URL: https://issues.apache.org/jira/browse/HBASE-19778 > Project: HBase > Issue Type: Brainstorming >Reporter: Chia-Ping Tsai >Priority: Minor > > Adding the jira link to do the text search can make life easier. -- This message was sent by Atlassian JIRA (v6.4.14#64029)