[jira] [Commented] (HBASE-20061) HStore synchronized member variable filesCompacting should be private

2018-02-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375393#comment-16375393
 ] 

Hadoop QA commented on HBASE-20061:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
30s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
 0s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 
50s{color} | {color:red} hbase-server in master has 24 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
11s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  6m  
7s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.5. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  8m  
3s{color} | {color:red} The patch causes 10 errors with Hadoop v2.7.4. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 10m 
10s{color} | {color:red} The patch causes 10 errors with Hadoop v3.0.0. {color} 
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m  
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
25s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}100m 
38s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
16s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}133m 16s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-20061 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12911874/HBASE-20061.0.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 5aee2e6052f4 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / bbbfeae25e |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.

[jira] [Commented] (HBASE-20047) AuthenticationTokenIdentifier should provide a toString

2018-02-24 Thread Reid Chan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375408#comment-16375408
 ] 

Reid Chan commented on HBASE-20047:
---

LGTM

> AuthenticationTokenIdentifier should provide a toString
> ---
>
> Key: HBASE-20047
> URL: https://issues.apache.org/jira/browse/HBASE-20047
> Project: HBase
>  Issue Type: Improvement
>  Components: Usability
>Reporter: Sean Busbey
>Priority: Minor
>  Labels: beginner
> Attachments: HBASE-20047.master.v0.patch
>
>
> It'd be easier to debug things like MapReduce and Spark jobs if our 
> AuthenticationTokenIdentifier provided a toString method.
> For comparison, here's an example of a MapReduce job that has both an HDFS 
> delegation token and our delegation token:
> {code:java}
> 18/02/21 20:40:06 INFO mapreduce.JobSubmitter: Kind: HBASE_AUTH_TOKEN, 
> Service: 92a63bd8-9e00-4c04-ab61-da8e606068e1, Ident: 
> (org.apache.hadoop.hbase.security.token.AuthenticationTokenIdentifier@17)
> 18/02/21 20:40:06 INFO mapreduce.JobSubmitter: Kind: HDFS_DELEGATION_TOKEN, 
> Service: 172.31.118.118:8020, Ident: (token for some_user: 
> HDFS_DELEGATION_TOKEN owner=some_u...@example.com, renewer=yarn, realUser=, 
> issueDate=1519274405003, maxDate=1519879205003, sequenceNumber=23, 
> masterKeyId=9)
> {code}
> Stuff in TokenIdentifier is supposed to be public, so we should be fine to 
> dump everything, similar to Hadoop's AbstractDelegationTokenIdentifier.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20047) AuthenticationTokenIdentifier should provide a toString

2018-02-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375410#comment-16375410
 ] 

Hadoop QA commented on HBASE-20047:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  6m 
19s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
25s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
45s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
22m 51s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
23s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m 
11s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
12s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 49m 25s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-20047 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12911880/HBASE-20047.master.v0.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux ed4712b1995f 3.13.0-137-generic #186-Ubuntu SMP Mon Dec 4 
19:09:19 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / bbbfeae25e |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11655/testReport/ |
| Max. process+thread count | 277 (vs. ulimit of 1) |
| modules | C: hbase-client U: hbase-client |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11655/cons

[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-24 Thread Zheng Hu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375411#comment-16375411
 ] 

Zheng Hu commented on HBASE-20065:
--

#1 

{code}
   /**
* @param t Table to use (will be closed when done).
* @param p put to make
-   * @throws IOException
*/
-  private static void put(final Table t, final Put p) throws IOException {
-try {
-  debugLogMutation(p);
-  t.put(p);
-} finally {
-  t.close();
-}
+  private static void put(Table t, Put p) throws IOException {
+debugLogMutation(p);
+t.put(p);
   }
{code}

The javadoc mismatched the implementation ? 

#2   
Why we use Long.MAX_VALUE as the ts in HBaseFsck.java ?  IMHO,  should use 
current timestamp (or a future timestamp slight large than the current ts to 
make sure the region info from HBCK to be the latest) ? 





> Revisit the timestamp usage in MetaTableAccessor
> 
>
> Key: HBASE-20065
> URL: https://issues.apache.org/jira/browse/HBASE-20065
> Project: HBase
>  Issue Type: Improvement
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-20065.patch
>
>
> It is totally a mess and makes me confusing when reimplementing the serial 
> replication feature. Let me do a clean up first.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20043) ITBLL fails against hadoop3

2018-02-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375413#comment-16375413
 ] 

Hadoop QA commented on HBASE-20043:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  2m 
27s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 6 new or modified test 
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
27s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
30s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 
10s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  4m 
25s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  8m 
29s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color} 
|
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
39s{color} | {color:red} hbase-common in branch-2 has 2 extant Findbugs 
warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
25s{color} | {color:red} hbase-procedure in branch-2 has 2 extant Findbugs 
warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  2m  
7s{color} | {color:red} hbase-server in branch-2 has 22 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  3m 
41s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  3m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
23s{color} | {color:green} The patch hbase-common passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} The patch hbase-procedure passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 9s{color} | {color:green} hbase-server: The patch generated 0 new + 596 
unchanged - 4 fixed = 596 total (was 600) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
21s{color} | {color:green} The patch hbase-it passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
17s{color} | {color:green} root: The patch generated 0 new + 610 unchanged - 4 
fixed = 610 total (was 614) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 6s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
15m  0s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color} 
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
43s{colo

[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-24 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375418#comment-16375418
 ] 

Duo Zhang commented on HBASE-20065:
---

Use HConstants.LATEST_TIMESTAMP is almost the same with current time, it will 
be replaced at RS side. It is OK to change it to current time. Any other 
problems?

Thanks.

> Revisit the timestamp usage in MetaTableAccessor
> 
>
> Key: HBASE-20065
> URL: https://issues.apache.org/jira/browse/HBASE-20065
> Project: HBase
>  Issue Type: Improvement
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-20065.patch
>
>
> It is totally a mess and makes me confusing when reimplementing the serial 
> replication feature. Let me do a clean up first.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20061) HStore synchronized member variable filesCompacting should be private

2018-02-24 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375420#comment-16375420
 ] 

Chia-Ping Tsai commented on HBASE-20061:


+1

> HStore synchronized member variable filesCompacting should be private
> -
>
> Key: HBASE-20061
> URL: https://issues.apache.org/jira/browse/HBASE-20061
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 1.2.0, 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0-alpha-1
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.5.0, 1.2.7, 1.4.3
>
> Attachments: HBASE-20061.0.patch
>
>
> follow up to HBASE-19728 (which is in an RC for 1.4.2 currently, so no 
> addendums):
> the filesCompacting member is currently package private, which allows folks 
> outside of HStore to modify it without ensuring we have hte needed locking in 
> place. it looks like we don't actually use it anywhere outside of HStore, so 
> we should just make it private.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-24 Thread Zheng Hu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375423#comment-16375423
 ] 

Zheng Hu commented on HBASE-20065:
--

No other concerns except the above two.  

> Revisit the timestamp usage in MetaTableAccessor
> 
>
> Key: HBASE-20065
> URL: https://issues.apache.org/jira/browse/HBASE-20065
> Project: HBase
>  Issue Type: Improvement
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-20065.patch
>
>
> It is totally a mess and makes me confusing when reimplementing the serial 
> replication feature. Let me do a clean up first.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20003) WALLess HBase on Persistent Memory

2018-02-24 Thread Chance Li (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375425#comment-16375425
 ] 

Chance Li commented on HBASE-20003:
---

Cool. But it's maybe difficult for pipeline model to provide the strong 
consistency guarantee, may need something like Paxos-based replication.

> WALLess HBase on Persistent Memory
> --
>
> Key: HBASE-20003
> URL: https://issues.apache.org/jira/browse/HBASE-20003
> Project: HBase
>  Issue Type: New Feature
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Major
>
> This JIRA aims to make use of persistent memory (pmem) technologies in HBase. 
> One such usage is to make the Memstore to reside on pmem. Making a persistent 
> memstore would remove the need for WAL and paves way for a WALLess HBase. 
> The existing region replica feature could be used here and ensure the data 
> written to memstores are synchronously replicated to the replicas and ensure 
> strong consistency of the data. (pipeline model)
> Advantages :
> - Data Availability : Since the data across replicas are consistent 
> (synchronously written) our data is always 100 % available.
> - Lower MTTR : It becomes easier/faster to switch over to the replicas on a 
> primary region failure as there is no WAL replay involved. Building the 
> memstore map data also is much faster than reading the WAL and replaying the 
> WAL.
> - Possibility of bigger memstores : These pmems are designed to have more 
> memory than DRAMs so it would also enable us to have bigger sized memstores 
> which leads to lesser flushes/compaction IO. 
> - Removes the dependency of HDFS on the write path
> Initial PoC has been designed and developed. Testing is underway and we would 
> publish the PoC results along with the design doc sooner. The PoC doc will 
> talk about the design decisions, the libraries considered to work with these 
> pmem devices, pros and cons of those libraries and the performance results.
> Note : Next gen memory technologies using 3DXPoint gives persistent memory 
> feature. Such memory DIMMs are soon to appear in the market. The PoC is done 
> around Intel's ApachePass (AEP)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-20066) Region sequence id may go backward after split or merge

2018-02-24 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-20066:
-

 Summary: Region sequence id may go backward after split or merge
 Key: HBASE-20066
 URL: https://issues.apache.org/jira/browse/HBASE-20066
 Project: HBase
  Issue Type: Bug
Reporter: Duo Zhang


The problem is that, now we have markers which will be written to WAL but not 
in store file. For a normal region close, we will write a sequence id file 
under the region directory, and when opening we will use this as the open 
sequence id. But for split and merge, we do not copy the sequence id file to 
the newly generated regions so the sequence id may go backwards since when 
closing the region we will write flush marker and close marker into WAL...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375452#comment-16375452
 ] 

Hadoop QA commented on HBASE-20065:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
15s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  7m 
17s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  2m 
30s{color} | {color:red} hbase-server in master has 24 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
59s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
20s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
37s{color} | {color:red} hbase-client: The patch generated 1 new + 91 unchanged 
- 18 fixed = 92 total (was 109) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
19s{color} | {color:green} hbase-server: The patch generated 0 new + 170 
unchanged - 53 fixed = 170 total (was 223) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
37s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
22m 10s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
50s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 
26s{color} | {color:red} hbase-client generated 1 new + 2 unchanged - 0 fixed = 
3 total (was 2) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m 
25s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}115m 41s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
41s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}174m 57s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestHdfsSnapshotHRegion |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-20065 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12911879/HBASE-20065.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  co

[jira] [Commented] (HBASE-20058) improper quoting in presplitting command docs

2018-02-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375454#comment-16375454
 ] 

Hadoop QA commented on HBASE-20058:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
41s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}191m 
46s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
35s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}207m 46s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-20058 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12911866/HBASE-20058-master-v0.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  |
| uname | Linux 66b97d7c9c77 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / bbbfeae25e |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11650/testReport/ |
| Max. process+thread count | 5150 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11650/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> improper quoting in presplitting command docs
> -
>
> Key: HBASE-20058
> URL: https://issues.apache.org/jira/browse/HBASE-20058
> Project: HBase
>  Issue Type: Bug
>  Components: documentation
>Reporter: Mike Drob
>Assignee: maoling
>Priority: Minor
>  Labels: beginner
> Attachments: HBASE-20058-master-v0.patch
>
>
> http://hbase.apache.org/book.html#tricks.pre-split
> {code}
> hbase>create 't1','f',SPLITS => ['10','20',30']
> {code}
> Missing a quote before the 30./



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20066) Region sequence id may go backward after split or merge

2018-02-24 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375458#comment-16375458
 ] 

Duo Zhang commented on HBASE-20066:
---

And also, we need to keep all the region event in the recovered edits, 
otherwise it is still possible that our sequence id will go backward...

> Region sequence id may go backward after split or merge
> ---
>
> Key: HBASE-20066
> URL: https://issues.apache.org/jira/browse/HBASE-20066
> Project: HBase
>  Issue Type: Bug
>Reporter: Duo Zhang
>Priority: Critical
>
> The problem is that, now we have markers which will be written to WAL but not 
> in store file. For a normal region close, we will write a sequence id file 
> under the region directory, and when opening we will use this as the open 
> sequence id. But for split and merge, we do not copy the sequence id file to 
> the newly generated regions so the sequence id may go backwards since when 
> closing the region we will write flush marker and close marker into WAL...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20067) Clean up findbugs warnings

2018-02-24 Thread Duo Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-20067:
--
Fix Version/s: 2.0.0

> Clean up findbugs warnings
> --
>
> Key: HBASE-20067
> URL: https://issues.apache.org/jira/browse/HBASE-20067
> Project: HBase
>  Issue Type: Task
>Reporter: Duo Zhang
>Priority: Critical
> Fix For: 2.0.0
>
>
> It seems that our pre commit build fails to execute findbugs for a while and 
> now it is back. Need to do a cleanup otherwise we can not get a green result 
> at all.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-20067) Clean up findbugs warnings

2018-02-24 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-20067:
-

 Summary: Clean up findbugs warnings
 Key: HBASE-20067
 URL: https://issues.apache.org/jira/browse/HBASE-20067
 Project: HBase
  Issue Type: Task
Reporter: Duo Zhang


It seems that our pre commit build fails to execute findbugs for a while and 
now it is back. Need to do a cleanup otherwise we can not get a green result at 
all.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20019) Document the ColumnValueFilter

2018-02-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375463#comment-16375463
 ] 

Hadoop QA commented on HBASE-20019:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
33s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
32s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}212m  
6s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
26s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}227m  5s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-20019 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12911875/HBASE-20019.master.001.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  |
| uname | Linux 2c4f51f3ed9d 3.13.0-137-generic #186-Ubuntu SMP Mon Dec 4 
19:09:19 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / bbbfeae25e |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11652/testReport/ |
| Max. process+thread count | 5444 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11652/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Document the ColumnValueFilter
> --
>
> Key: HBASE-20019
> URL: https://issues.apache.org/jira/browse/HBASE-20019
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Chia-Ping Tsai
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-20019.master.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-24 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375462#comment-16375462
 ] 

Duo Zhang commented on HBASE-20065:
---

Filed HBASE-20067 for the findbugs warnings.

> Revisit the timestamp usage in MetaTableAccessor
> 
>
> Key: HBASE-20065
> URL: https://issues.apache.org/jira/browse/HBASE-20065
> Project: HBase
>  Issue Type: Improvement
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-20065.patch
>
>
> It is totally a mess and makes me confusing when reimplementing the serial 
> replication feature. Let me do a clean up first.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19343) Restore snapshot makes parent split region online

2018-02-24 Thread Pankaj Kumar (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375466#comment-16375466
 ] 

Pankaj Kumar commented on HBASE-19343:
--

TestZKPermissionWatcher pass locally.

> Restore snapshot makes parent split region online 
> --
>
> Key: HBASE-19343
> URL: https://issues.apache.org/jira/browse/HBASE-19343
> Project: HBase
>  Issue Type: Bug
>  Components: snapshots
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-19343-branch-1.patch, Snapshot.jpg
>
>
> Restore snapshot makes parent split region online as shown in the attached 
> snapshot.
> Steps to reproduce
> =
> 1. Create table
> 2. Insert few records into the table
> 3. flush the table
> 4. Split the table
> 5. Create snapshot before catalog janitor clears the parent region entry from 
> meta.
> 6. Restore snapshot
> We can see the problem in meta entries,
> Meta content before restore snapshot:
> {noformat}
> t1,,1511537529449.077a12b0b3c91b053fa95223635f9543. 
> column=info:regioninfo, timestamp=1511537565964, value={ENCODED => 
> 077a12b0b3c91b053fa95223635f9543, NAME => 
> 't1,,1511537529449.077a12b0b3c91b053fa95223635f9543.', STARTKEY =>
>   '', ENDKEY => 
> '', OFFLINE => true, SPLIT => true}
>  t1,,1511537529449.077a12b0b3c91b053fa95223635f9543. 
> column=info:seqnumDuringOpen, timestamp=1511537530107, 
> value=\x00\x00\x00\x00\x00\x00\x00\x02
>  t1,,1511537529449.077a12b0b3c91b053fa95223635f9543. 
> column=info:server, timestamp=1511537530107, value=host-xx:16020
>  t1,,1511537529449.077a12b0b3c91b053fa95223635f9543. 
> column=info:serverstartcode, timestamp=1511537530107, value=1511537511523
>  t1,,1511537529449.077a12b0b3c91b053fa95223635f9543. 
> column=info:splitA, timestamp=1511537565964, value={ENCODED => 
> 3c7c866d4df370c586131a4cbe0ef6a8, NAME => 
> 't1,,1511537565718.3c7c866d4df370c586131a4cbe0ef6a8.', STARTKEY => '',
>   ENDKEY => 'm'}
>  t1,,1511537529449.077a12b0b3c91b053fa95223635f9543. 
> column=info:splitB, timestamp=1511537565964, value={ENCODED => 
> dc7facd824c85b94e5bf6a2e6b5f5efc, NAME => 
> 't1,m,1511537565718.dc7facd824c85b94e5bf6a2e6b5f5efc.', STARTKEY => 'm
>  ', ENDKEY => ''}
>  t1,,1511537565718.3c7c866d4df370c586131a4cbe0ef6a8. 
> column=info:regioninfo, timestamp=1511537566075, value={ENCODED => 
> 3c7c866d4df370c586131a4cbe0ef6a8, NAME => 
> 't1,,1511537565718.3c7c866d4df370c586131a4cbe0ef6a8.', STARTKEY =>
>   '', ENDKEY => 
> 'm'}
>  t1,,1511537565718.3c7c866d4df370c586131a4cbe0ef6a8. 
> column=info:seqnumDuringOpen, timestamp=1511537566075, 
> value=\x00\x00\x00\x00\x00\x00\x00\x02
>  t1,,1511537565718.3c7c866d4df370c586131a4cbe0ef6a8. 
> column=info:server, timestamp=1511537566075, value=host-xx:16020
>  t1,,1511537565718.3c7c866d4df370c586131a4cbe0ef6a8. 
> column=info:serverstartcode, timestamp=1511537566075, value=1511537511523
>  t1,m,1511537565718.dc7facd824c85b94e5bf6a2e6b5f5efc.
> column=info:regioninfo, timestamp=1511537566069, value={ENCODED => 
> dc7facd824c85b94e5bf6a2e6b5f5efc, NAME => 
> 't1,m,1511537565718.dc7facd824c85b94e5bf6a2e6b5f5efc.', STARTKEY =
>  > 'm', ENDKEY => 
> ''}
>  t1,m,1511537565718.dc7facd824c85b94e5bf6a2e6b5f5efc.
> column=info:seqnumDuringOpen, timestamp=1511537566069, 
> value=\x00\x00\x00\x00\x00\x00\x00\x08
>  t1,m,1511537565718.dc7facd824c85b94e5bf6a2e6b5f5efc.
> column=info:server, timestamp=1511537566069, value=host-xx:16020
>  t1,m,1511537565718.dc7facd824c85b94e5bf6a2e6b5f5efc.
> column=info:serverstartcode, timestamp=1511537566069, value=1511537511523
> {noformat}
> Meta content after restore snapshot:
> {noformat}
>  t1,,1511537529449.077a12b0b3c91b053fa95223635f9543. 
> column=info:regioninfo, timestamp=1511537667635, value={ENCODED => 
> 077a12b0b3c91b053fa95223635f9543, NAME => 
> 't1,,1511537529449.077a12b0b3c91b053fa95223635f9543.', STARTKEY =>
>   '', ENDKEY => 
> ''}
>  t1,,1511537529449.077a12b0b3c91b053fa95223635f9543. 
> column=info:seqnumDuringOpen, timestamp=1511537667635, 
> value=\x00\x00\x00\x00\x00\x00\x00\x0A
>  t1,,1511537529449.077a12b0b3c91b053fa95223635f9543. 
> column=info:server, timestamp=1511537667635, value=host-xx:16020
>  t1,,1511537529449.077a12b0b3c91b053fa95223635f9543. 
> column=info:

[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-24 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375469#comment-16375469
 ] 

Duo Zhang commented on HBASE-20065:
---

Address the review comments, and also the failed UTs.

> Revisit the timestamp usage in MetaTableAccessor
> 
>
> Key: HBASE-20065
> URL: https://issues.apache.org/jira/browse/HBASE-20065
> Project: HBase
>  Issue Type: Improvement
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-20065-v1.patch, HBASE-20065.patch
>
>
> It is totally a mess and makes me confusing when reimplementing the serial 
> replication feature. Let me do a clean up first.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (HBASE-19343) Restore snapshot makes parent split region online

2018-02-24 Thread Pankaj Kumar (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375466#comment-16375466
 ] 

Pankaj Kumar edited comment on HBASE-19343 at 2/24/18 10:17 AM:


TestZKPermissionWatcher pass locally. Findbug warning is not relevant.


was (Author: pankaj2461):
TestZKPermissionWatcher pass locally.

> Restore snapshot makes parent split region online 
> --
>
> Key: HBASE-19343
> URL: https://issues.apache.org/jira/browse/HBASE-19343
> Project: HBase
>  Issue Type: Bug
>  Components: snapshots
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-19343-branch-1.patch, Snapshot.jpg
>
>
> Restore snapshot makes parent split region online as shown in the attached 
> snapshot.
> Steps to reproduce
> =
> 1. Create table
> 2. Insert few records into the table
> 3. flush the table
> 4. Split the table
> 5. Create snapshot before catalog janitor clears the parent region entry from 
> meta.
> 6. Restore snapshot
> We can see the problem in meta entries,
> Meta content before restore snapshot:
> {noformat}
> t1,,1511537529449.077a12b0b3c91b053fa95223635f9543. 
> column=info:regioninfo, timestamp=1511537565964, value={ENCODED => 
> 077a12b0b3c91b053fa95223635f9543, NAME => 
> 't1,,1511537529449.077a12b0b3c91b053fa95223635f9543.', STARTKEY =>
>   '', ENDKEY => 
> '', OFFLINE => true, SPLIT => true}
>  t1,,1511537529449.077a12b0b3c91b053fa95223635f9543. 
> column=info:seqnumDuringOpen, timestamp=1511537530107, 
> value=\x00\x00\x00\x00\x00\x00\x00\x02
>  t1,,1511537529449.077a12b0b3c91b053fa95223635f9543. 
> column=info:server, timestamp=1511537530107, value=host-xx:16020
>  t1,,1511537529449.077a12b0b3c91b053fa95223635f9543. 
> column=info:serverstartcode, timestamp=1511537530107, value=1511537511523
>  t1,,1511537529449.077a12b0b3c91b053fa95223635f9543. 
> column=info:splitA, timestamp=1511537565964, value={ENCODED => 
> 3c7c866d4df370c586131a4cbe0ef6a8, NAME => 
> 't1,,1511537565718.3c7c866d4df370c586131a4cbe0ef6a8.', STARTKEY => '',
>   ENDKEY => 'm'}
>  t1,,1511537529449.077a12b0b3c91b053fa95223635f9543. 
> column=info:splitB, timestamp=1511537565964, value={ENCODED => 
> dc7facd824c85b94e5bf6a2e6b5f5efc, NAME => 
> 't1,m,1511537565718.dc7facd824c85b94e5bf6a2e6b5f5efc.', STARTKEY => 'm
>  ', ENDKEY => ''}
>  t1,,1511537565718.3c7c866d4df370c586131a4cbe0ef6a8. 
> column=info:regioninfo, timestamp=1511537566075, value={ENCODED => 
> 3c7c866d4df370c586131a4cbe0ef6a8, NAME => 
> 't1,,1511537565718.3c7c866d4df370c586131a4cbe0ef6a8.', STARTKEY =>
>   '', ENDKEY => 
> 'm'}
>  t1,,1511537565718.3c7c866d4df370c586131a4cbe0ef6a8. 
> column=info:seqnumDuringOpen, timestamp=1511537566075, 
> value=\x00\x00\x00\x00\x00\x00\x00\x02
>  t1,,1511537565718.3c7c866d4df370c586131a4cbe0ef6a8. 
> column=info:server, timestamp=1511537566075, value=host-xx:16020
>  t1,,1511537565718.3c7c866d4df370c586131a4cbe0ef6a8. 
> column=info:serverstartcode, timestamp=1511537566075, value=1511537511523
>  t1,m,1511537565718.dc7facd824c85b94e5bf6a2e6b5f5efc.
> column=info:regioninfo, timestamp=1511537566069, value={ENCODED => 
> dc7facd824c85b94e5bf6a2e6b5f5efc, NAME => 
> 't1,m,1511537565718.dc7facd824c85b94e5bf6a2e6b5f5efc.', STARTKEY =
>  > 'm', ENDKEY => 
> ''}
>  t1,m,1511537565718.dc7facd824c85b94e5bf6a2e6b5f5efc.
> column=info:seqnumDuringOpen, timestamp=1511537566069, 
> value=\x00\x00\x00\x00\x00\x00\x00\x08
>  t1,m,1511537565718.dc7facd824c85b94e5bf6a2e6b5f5efc.
> column=info:server, timestamp=1511537566069, value=host-xx:16020
>  t1,m,1511537565718.dc7facd824c85b94e5bf6a2e6b5f5efc.
> column=info:serverstartcode, timestamp=1511537566069, value=1511537511523
> {noformat}
> Meta content after restore snapshot:
> {noformat}
>  t1,,1511537529449.077a12b0b3c91b053fa95223635f9543. 
> column=info:regioninfo, timestamp=1511537667635, value={ENCODED => 
> 077a12b0b3c91b053fa95223635f9543, NAME => 
> 't1,,1511537529449.077a12b0b3c91b053fa95223635f9543.', STARTKEY =>
>   '', ENDKEY => 
> ''}
>  t1,,1511537529449.077a12b0b3c91b053fa95223635f9543. 
> column=info:seqnumDuringOpen, timestamp=1511537667635, 
> value=\x00\x00\x00\x00\x00\x00\x00\x0A
>  t1,,1511537529449.077a12b0b3c91b053fa95223635f9543. 

[jira] [Updated] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-24 Thread Duo Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-20065:
--
Attachment: HBASE-20065-v1.patch

> Revisit the timestamp usage in MetaTableAccessor
> 
>
> Key: HBASE-20065
> URL: https://issues.apache.org/jira/browse/HBASE-20065
> Project: HBase
>  Issue Type: Improvement
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-20065-v1.patch, HBASE-20065.patch
>
>
> It is totally a mess and makes me confusing when reimplementing the serial 
> replication feature. Let me do a clean up first.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-18282) ReplicationLogCleaner can delete WALs not yet replicated in case of a KeeperException

2018-02-24 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375499#comment-16375499
 ] 

Hudson commented on HBASE-18282:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4640 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/4640/])
HBASE-20054 Forward port HBASE-18282 ReplicationLogCleaner can delete (tedyu: 
rev 9a7645360bad99cc0dc42ae73f6dc779cbbdf490)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestLogsCleaner.java


> ReplicationLogCleaner can delete WALs not yet replicated in case of a 
> KeeperException
> -
>
> Key: HBASE-18282
> URL: https://issues.apache.org/jira/browse/HBASE-18282
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 1.3.1, 1.2.6, 1.1.11, 2.0.0-alpha-1
>Reporter: Ashu Pachauri
>Assignee: Ben Lau
>Priority: Critical
> Fix For: 2.0.0, 1.3.2, 1.5.0, 1.2.7, 1.4.2
>
> Attachments: HBASE-18282-branch-1-v2.patch, 
> HBASE-18282-branch-1.patch, HBASE-18282-branch-2-v2.patch, 
> HBASE-18282-branch-2.patch
>
>
> ReplicationStateZKBase#getListOfReplicators does not rethrow a 
> KeeperException and returns null in such a case. ReplicationLogCleaner just 
> assumes that there are no replicators and deletes everything.
> ReplicationStateZKBase:
> {code:java}
> public List getListOfReplicators() {
> List result = null;
> try {
>   result = ZKUtil.listChildrenNoWatch(this.zookeeper, this.queuesZNode);
> } catch (KeeperException e) {
>   this.abortable.abort("Failed to get list of replicators", e);
> }
> return result;
>   }
> {code}
> ReplicationLogCleaner:
> {code:java}
> private Set loadWALsFromQueues() throws KeeperException {
> for (int retry = 0; ; retry++) {
>   int v0 = replicationQueues.getQueuesZNodeCversion();
>   List rss = replicationQueues.getListOfReplicators();
>   if (rss == null) {
> LOG.debug("Didn't find any region server that replicates, won't 
> prevent any deletions.");
> return ImmutableSet.of();
>   }
>   ...
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19157) IntegrationTestBackupRestore should warn about missing config

2018-02-24 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375500#comment-16375500
 ] 

Hudson commented on HBASE-19157:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4640 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/4640/])
HBASE-19157 IntegrationTestBackupRestore should warn about missing (tedyu: rev 
bbbfeae25e9e2a8d91168ea19b09da40ed069c01)
* (edit) 
hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestBackupRestore.java


> IntegrationTestBackupRestore should warn about missing config
> -
>
> Key: HBASE-19157
> URL: https://issues.apache.org/jira/browse/HBASE-19157
> Project: HBase
>  Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Artem Ervits
>Priority: Minor
>  Labels: backup, integration-test
> Fix For: 3.0.0
>
> Attachments: HBASE-19157.v01.patch, HBASE-19157.v02.patch, 
> HBASE-19157.v03.patch, HBASE-19157.v05.patch
>
>
> I was running IntegrationTestBackupRestore on a newly created cluster running 
> hbase-2.
> It failed with:
> {code}
> Caused by: 
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(org.apache.hadoop.hbase.DoNotRetryIOException):
>  org.apache.hadoop.hbase.DoNotRetryIOException: The procedure is not 
> registered: rolllog-proc
>   at 
> org.apache.hadoop.hbase.master.MasterRpcServices.execProcedure(MasterRpcServices.java:817)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:134)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:325)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:305)
> {code}
> {{hbase backup}} command warns about missing config up-front.
> IntegrationTestBackupRestore should do the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20054) Forward port HBASE-18282 ReplicationLogCleaner can delete WALs not yet replicated in case of KeeperException

2018-02-24 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375498#comment-16375498
 ] 

Hudson commented on HBASE-20054:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4640 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/4640/])
HBASE-20054 Forward port HBASE-18282 ReplicationLogCleaner can delete (tedyu: 
rev 9a7645360bad99cc0dc42ae73f6dc779cbbdf490)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestLogsCleaner.java


> Forward port HBASE-18282 ReplicationLogCleaner can delete WALs not yet 
> replicated in case of KeeperException
> 
>
> Key: HBASE-20054
> URL: https://issues.apache.org/jira/browse/HBASE-20054
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: 20054.branch-2.v2.txt, 20054.v1.txt, 20054.v2.txt, 
> 20054.v3.txt
>
>
> Some changes from HBASE-18282 were missing in master branch:
> * The retry in ReplicationSourceManager#adoptAbandonedQueues
> *  new tests in TestLogsCleaner
> This issue is to forward port the new test to master branch.
> After discussion, the retry from #1 above is going to be dropped - we abort 
> directly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375557#comment-16375557
 ] 

Hadoop QA commented on HBASE-20065:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  6m 
21s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  2m  
6s{color} | {color:red} hbase-server in master has 24 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
48s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
3s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  2m 
24s{color} | {color:red} hbase-client: The patch generated 1 new + 66 unchanged 
- 43 fixed = 67 total (was 109) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m 
26s{color} | {color:red} hbase-server: The patch generated 1 new + 380 
unchanged - 53 fixed = 381 total (was 433) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  6m 
 8s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
24m 43s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
58s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}116m 
55s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
35s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}175m 17s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-20065 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12911895/HBASE-20065-v1.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 387f18008728 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| 

[jira] [Commented] (HBASE-20066) Region sequence id may go backward after split or merge

2018-02-24 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375566#comment-16375566
 ] 

Duo Zhang commented on HBASE-20066:
---

After some digging, I found it is really hard to always keep the sequence id 
increasing for failover. We can fail at any place, and then we need to inject 
the write sequence id logic at many places, but it is still not perfect. It is 
OK to write a sequence id after write the close region marker, if it fails, the 
RS will abort and the marker will be replayed so we can get the correct max 
sequence id. But for a region open, if we fails after write the open region 
marker, then we are dead... Because the region has not been opened on this RS 
yet, so even if we abort the RS, we will not replay the log so we can not know 
that there is a open region marker...

So, I think we could try to do it better for split and merge, where we can 
write a max sequence id file for the newly generated regions. But for failover, 
let's keep it as is, since we can not solve all the problem but will make the 
code much complicated.

[~stack] What do you think sir?

Thanks.

> Region sequence id may go backward after split or merge
> ---
>
> Key: HBASE-20066
> URL: https://issues.apache.org/jira/browse/HBASE-20066
> Project: HBase
>  Issue Type: Bug
>Reporter: Duo Zhang
>Priority: Critical
>
> The problem is that, now we have markers which will be written to WAL but not 
> in store file. For a normal region close, we will write a sequence id file 
> under the region directory, and when opening we will use this as the open 
> sequence id. But for split and merge, we do not copy the sequence id file to 
> the newly generated regions so the sequence id may go backwards since when 
> closing the region we will write flush marker and close marker into WAL...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (HBASE-20062) findbugs is not running on precommit checks

2018-02-24 Thread Mike Drob (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Drob resolved HBASE-20062.
---
Resolution: Fixed

I've seen findbugs running now. Closing.

> findbugs is not running on precommit checks
> ---
>
> Key: HBASE-20062
> URL: https://issues.apache.org/jira/browse/HBASE-20062
> Project: HBase
>  Issue Type: Bug
>  Components: community, test
>Reporter: Sean Busbey
>Assignee: Mike Drob
>Priority: Blocker
> Fix For: 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-2, 1.4.3
>
>
> as of build #11638 ~3 hours ago precommit isn't using findbugs:
> {quote}
> 0 findbugs0m 0s   Findbugs executables are not available.
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19735) Create a minimal "client" tarball installation

2018-02-24 Thread Mike Drob (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375624#comment-16375624
 ] 

Mike Drob commented on HBASE-19735:
---

bq. Should this just be something that can be a part of the standard Maven 
build or something standalone we run with Jenkins? Thoughts?

Probably Maven, unless that proves tremendously difficult? Precommit is 
probably fine too. Standalone is likely to get ignored.

> Create a minimal "client" tarball installation
> --
>
> Key: HBASE-19735
> URL: https://issues.apache.org/jira/browse/HBASE-19735
> Project: HBase
>  Issue Type: New Feature
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-19735.000.patch, HBASE-19735.001.branch-2.patch, 
> HBASE-19735.002.branch-2.patch, HBASE-19735.003.patch, HBASE-19735.004.patch
>
>
> We're moving ourselves towards more controlled dependencies. A logical next 
> step is to try to do the same for our "binary" artifacts that we create 
> during releases.
> There is code (our's and our dependency's) which the HMaster and RegionServer 
> require which, obviously, clients do not need.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20068) Hadoopcheck project health check uses default maven repo instead of yetus managed ones

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-20068:

Component/s: community

> Hadoopcheck project health check uses default maven repo instead of yetus 
> managed ones
> --
>
> Key: HBASE-20068
> URL: https://issues.apache.org/jira/browse/HBASE-20068
> Project: HBase
>  Issue Type: Bug
>  Components: community, test
>Reporter: Sean Busbey
>Priority: Major
>
> Recently had a precommit run fail hadoop check for all 3 versions with 
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-install-plugin:2.5.2:install (default-install) 
> on project hbase-thrift: Failed to install metadata 
> org.apache.hbase:hbase-thrift:3.0.0-SNAPSHOT/maven-metadata.xml: Could not 
> parse metadata 
> /home/jenkins/.m2/repository/org/apache/hbase/hbase-thrift/3.0.0-SNAPSHOT/maven-metadata-local.xml:
>  in epilog non whitespace content is not allowed but got / (position: END_TAG 
> seen ...\n/... @25:2)  -> [Help 1]
> {code}
> Looks like maven repo corruption.
> Also the path {{/home/jenkins/.m2/repository}} means that those invocations 
> are using the jenkins user repo, which isn't safe since there are multiple 
> executors. either the plugin isn't using the yetus provided maven repo path 
> or our yetus invocation isn't telling yetus to provide its own maven repo 
> path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-20068) Hadoopcheck project health check uses default maven repo instead of yetus managed ones

2018-02-24 Thread Sean Busbey (JIRA)
Sean Busbey created HBASE-20068:
---

 Summary: Hadoopcheck project health check uses default maven repo 
instead of yetus managed ones
 Key: HBASE-20068
 URL: https://issues.apache.org/jira/browse/HBASE-20068
 Project: HBase
  Issue Type: Bug
  Components: test
Reporter: Sean Busbey


Recently had a precommit run fail hadoop check for all 3 versions with 

{code}

[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-install-plugin:2.5.2:install (default-install) 
on project hbase-thrift: Failed to install metadata 
org.apache.hbase:hbase-thrift:3.0.0-SNAPSHOT/maven-metadata.xml: Could not 
parse metadata 
/home/jenkins/.m2/repository/org/apache/hbase/hbase-thrift/3.0.0-SNAPSHOT/maven-metadata-local.xml:
 in epilog non whitespace content is not allowed but got / (position: END_TAG 
seen ...\n/... @25:2)  -> [Help 1]
{code}

Looks like maven repo corruption.

Also the path {{/home/jenkins/.m2/repository}} means that those invocations are 
using the jenkins user repo, which isn't safe since there are multiple 
executors. either the plugin isn't using the yetus provided maven repo path or 
our yetus invocation isn't telling yetus to provide its own maven repo path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20069) fix existing findbugs errors in hbase-server

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-20069:

Attachment: FindBugs Report.htm

> fix existing findbugs errors in hbase-server
> 
>
> Key: HBASE-20069
> URL: https://issues.apache.org/jira/browse/HBASE-20069
> Project: HBase
>  Issue Type: Bug
>  Components: findbugs
>Reporter: Sean Busbey
>Priority: Critical
> Attachments: FindBugs Report.htm
>
>
> now that findbugs is running on precommit we have some cleanup to do.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-20069) fix existing findbugs errors in hbase-server

2018-02-24 Thread Sean Busbey (JIRA)
Sean Busbey created HBASE-20069:
---

 Summary: fix existing findbugs errors in hbase-server
 Key: HBASE-20069
 URL: https://issues.apache.org/jira/browse/HBASE-20069
 Project: HBase
  Issue Type: Bug
  Components: findbugs
Reporter: Sean Busbey
 Attachments: FindBugs Report.htm

now that findbugs is running on precommit we have some cleanup to do.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20069) fix existing findbugs errors in hbase-server

2018-02-24 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375639#comment-16375639
 ] 

Sean Busbey commented on HBASE-20069:
-

attached report for the hbase-server module from recent precommit run.

> fix existing findbugs errors in hbase-server
> 
>
> Key: HBASE-20069
> URL: https://issues.apache.org/jira/browse/HBASE-20069
> Project: HBase
>  Issue Type: Bug
>  Components: findbugs
>Reporter: Sean Busbey
>Priority: Critical
> Attachments: FindBugs Report.htm
>
>
> now that findbugs is running on precommit we have some cleanup to do.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20061) HStore synchronized member variable filesCompacting should be private

2018-02-24 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375642#comment-16375642
 ] 

Sean Busbey commented on HBASE-20061:
-

{code}
-1  hadoopcheck 6m 7s   The patch causes 10 errors with Hadoop v2.6.5.
-1  hadoopcheck 8m 3s   The patch causes 10 errors with Hadoop v2.7.4.
-1  hadoopcheck 10m 10s The patch causes 10 errors with Hadoop v3.0.0.
{code}

they're all:

{code}
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-install-plugin:2.5.2:install (default-install) 
on project hbase-thrift: Failed to install metadata 
org.apache.hbase:hbase-thrift:3.0.0-SNAPSHOT/maven-metadata.xml: Could not 
parse metadata 
/home/jenkins/.m2/repository/org/apache/hbase/hbase-thrift/3.0.0-SNAPSHOT/maven-metadata-local.xml:
 in epilog non whitespace content is not allowed but got / (position: END_TAG 
seen ...\n/... @25:2)  -> [Help 1]
{code}

output looks like local maven repo corruption. and that maven repo looks like 
the jenkins user repo instead of the per-build repo that we should be using for 
precommit. filed HBASE-20068.

{code}
-1  findbugs1m 50s  hbase-server in master has 24 extant Findbugs 
warnings.
{code}

This is the problem caused by us running blind for awhile. either HBASE-15151 
or HBASE-20069 will fix this. the warnings aren't in the part of the code this 
patch is already dealing with.

{code}
-1  test4tests  0m 0s   The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch.
{code}

Any test for "is this member variable private" is going to be overkill, IMHO.

[~chia7712] you okay with my reasoning for the above?

> HStore synchronized member variable filesCompacting should be private
> -
>
> Key: HBASE-20061
> URL: https://issues.apache.org/jira/browse/HBASE-20061
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 1.2.0, 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0-alpha-1
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.5.0, 1.2.7, 1.4.3
>
> Attachments: HBASE-20061.0.patch
>
>
> follow up to HBASE-19728 (which is in an RC for 1.4.2 currently, so no 
> addendums):
> the filesCompacting member is currently package private, which allows folks 
> outside of HStore to modify it without ensuring we have hte needed locking in 
> place. it looks like we don't actually use it anywhere outside of HStore, so 
> we should just make it private.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-15151) turn off strict findbugs in precommit tests

2018-02-24 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375645#comment-16375645
 ] 

Sean Busbey commented on HBASE-15151:
-

now that we have nightly tests, I want to confirm they're running findbugs 
before turning precommit to non-strict.

> turn off strict findbugs in precommit tests
> ---
>
> Key: HBASE-15151
> URL: https://issues.apache.org/jira/browse/HBASE-15151
> Project: HBase
>  Issue Type: Task
>  Components: build, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
>
> the "-1" for extant findbugs warnings has confused interpretation of our 
> precommit checks enough that we should switch to non-strict mode.
> It will still record the number of findbugs warnings present before the 
> patch, but it'll vote "0" rather than calling attention to things via a -1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-15151) turn off strict findbugs in precommit tests

2018-02-24 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375646#comment-16375646
 ] 

Sean Busbey commented on HBASE-15151:
-

looks like we're not running findbugs in the nightly run for any branch

> turn off strict findbugs in precommit tests
> ---
>
> Key: HBASE-15151
> URL: https://issues.apache.org/jira/browse/HBASE-15151
> Project: HBase
>  Issue Type: Task
>  Components: build, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
>
> the "-1" for extant findbugs warnings has confused interpretation of our 
> precommit checks enough that we should switch to non-strict mode.
> It will still record the number of findbugs warnings present before the 
> patch, but it'll vote "0" rather than calling attention to things via a -1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20061) HStore synchronized member variable filesCompacting should be private

2018-02-24 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375661#comment-16375661
 ] 

Chia-Ping Tsai commented on HBASE-20061:


+1,  absolutely. Thank you to point out the precommit bug. 

> HStore synchronized member variable filesCompacting should be private
> -
>
> Key: HBASE-20061
> URL: https://issues.apache.org/jira/browse/HBASE-20061
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 1.2.0, 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0-alpha-1
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.5.0, 1.2.7, 1.4.3
>
> Attachments: HBASE-20061.0.patch
>
>
> follow up to HBASE-19728 (which is in an RC for 1.4.2 currently, so no 
> addendums):
> the filesCompacting member is currently package private, which allows folks 
> outside of HStore to modify it without ensuring we have hte needed locking in 
> place. it looks like we don't actually use it anywhere outside of HStore, so 
> we should just make it private.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-20070) website generation is failing

2018-02-24 Thread Sean Busbey (JIRA)
Sean Busbey created HBASE-20070:
---

 Summary: website generation is failing
 Key: HBASE-20070
 URL: https://issues.apache.org/jira/browse/HBASE-20070
 Project: HBase
  Issue Type: Bug
  Components: website
Reporter: Sean Busbey


website generation has been failing since Feb 20th

{code}
Checking out files: 100% (68971/68971), done.
Usage: grep [OPTION]... PATTERN [FILE]...
Try 'grep --help' for more information.
PUSHED is 2
 is not yet mentioned in the hbase-site commit log. Assuming we don't have it 
yet. 2
Building HBase
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; 
support was removed in 8.0
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; 
support was removed in 8.0
Failure: mvn clean site
Build step 'Execute shell' marked build as failure
{code}

The status email says

{code}
Build status: Still Failing

The HBase website has not been updated to incorporate HBase commit 
${CURRENT_HBASE_COMMIT}.
{code}

Looking at the code where that grep happens, it looks like the env variable 
CURRENT_HBASE_COMMIT isn't getting set. That comes from some git command. I'm 
guessing the version of git changed on the build hosts and upended our 
assumptions.

we should fix this to 1) rely on git's porcelain interface, and 2) fail as soon 
as that git command fails



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20069) fix existing findbugs errors in hbase-server

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-20069:

Issue Type: Sub-task  (was: Bug)
Parent: HBASE-20067

> fix existing findbugs errors in hbase-server
> 
>
> Key: HBASE-20069
> URL: https://issues.apache.org/jira/browse/HBASE-20069
> Project: HBase
>  Issue Type: Sub-task
>  Components: findbugs
>Reporter: Sean Busbey
>Priority: Critical
> Attachments: FindBugs Report.htm
>
>
> now that findbugs is running on precommit we have some cleanup to do.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (HBASE-19728) Add lock to filesCompacting in all place.

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey resolved HBASE-19728.
-
Resolution: Fixed

> Add lock to filesCompacting in all place.
> -
>
> Key: HBASE-19728
> URL: https://issues.apache.org/jira/browse/HBASE-19728
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 2.0.0, 3.0.0, 1.5.0
>Reporter: binlijin
>Assignee: binlijin
>Priority: Major
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.5.0, 1.2.7, 1.4.2
>
> Attachments: HBASE-19728.branch-1.001.patch, 
> HBASE-19728.master.001.patch, HBASE-19728.master.002.patch, 
> HBASE-19728.master.002.patch
>
>
> We find regionserver abort with the following exception:
> 2017-05-09 17:40:06,369 FATAL 
> [regionserver/hadoop0349.et2.tbsite.net/11.251.152.199:16020-shortCompactions-1493026663275]
>  regionserver.HRegionServer: ABORTING region server 
> hadoop0349.et2.tbsite.net,16020,1493026637177: 
> Thread[regionserver/hadoop0349.et2.tbsite.net/11.251.152.199:16020-shortCompactions-1493026663275,5,main]
>  throw uncaught exception
> java.lang.ArrayIndexOutOfBoundsException
>         at java.lang.System.arraycopy(Native Method)
>         at java.util.ArrayList.batchRemove(ArrayList.java:726)
>         at java.util.ArrayList.removeAll(ArrayList.java:690)
>         at 
> org.apache.hadoop.hbase.regionserver.HStore.finishCompactionRequest(HStore.java:1666)
>         at 
> org.apache.hadoop.hbase.regionserver.HStore.cancelRequestedCompaction(HStore.java:1656)
>         at 
> org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.run(CompactSplitThread.java:504)
>         at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1147)
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
>         at java.lang.Thread.run(Thread.java:834)
> 2017-05-08 21:15:31,979 FATAL 
> [regionserver/hadoop1191.et2.tbsite.net/11.251.159.40:16020-longCompactions-1494249331978]
>  regionserver.HRegionServer: ABORTING region server 
> hadoop1191.et2.tbsite.net,16020,1493196567798: 
> Thread[regionserver/hadoop1191.et2.tbsite.net/11.251.159.40:16020-longCompactions-1494249331978,5,main]
>  throw uncaught exception
> java.lang.IllegalArgumentException
>         at 
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:76)
>         at 
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy.getCurrentEligibleFiles(RatioBasedCompactionPolicy.java:64)
>         at 
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy.preSelectCompactionForCoprocessor(RatioBasedCompactionPolicy.java:72)
>         at 
> org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.preSelect(DefaultStoreEngine.java:117)
>         at 
> org.apache.hadoop.hbase.regionserver.HStore.requestCompaction(HStore.java:1542)
>         at 
> org.apache.hadoop.hbase.regionserver.CompactSplitThread.selectCompaction(CompactSplitThread.java:362)
>         at 
> org.apache.hadoop.hbase.regionserver.CompactSplitThread.access$200(CompactSplitThread.java:58)
>         at 
> org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.run(CompactSplitThread.java:491)
>         at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1147)
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
>         at java.lang.Thread.run(Thread.java:834)
> HStore#finishCompactionRequest do not require any HStore#lock's lock so 
> HStore.replaceStoreFiles need to synchronized on filesCompacting.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20061) HStore synchronized member variable filesCompacting should be private

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-20061:

Resolution: Fixed
Status: Resolved  (was: Patch Available)

> HStore synchronized member variable filesCompacting should be private
> -
>
> Key: HBASE-20061
> URL: https://issues.apache.org/jira/browse/HBASE-20061
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 1.2.0, 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0-alpha-1
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.5.0, 1.2.7, 1.4.3
>
> Attachments: HBASE-20061.0.patch
>
>
> follow up to HBASE-19728 (which is in an RC for 1.4.2 currently, so no 
> addendums):
> the filesCompacting member is currently package private, which allows folks 
> outside of HStore to modify it without ensuring we have hte needed locking in 
> place. it looks like we don't actually use it anywhere outside of HStore, so 
> we should just make it private.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20061) HStore synchronized member variable filesCompacting should be private

2018-02-24 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375684#comment-16375684
 ] 

Hudson commented on HBASE-20061:


SUCCESS: Integrated in Jenkins build HBase-1.3-IT #357 (See 
[https://builds.apache.org/job/HBase-1.3-IT/357/])
HBASE-20061 HStore synchronized member variable filesCompacting should (busbey: 
rev 1a36db1463b41fefb8688cb5b54083ce4745feb7)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java


> HStore synchronized member variable filesCompacting should be private
> -
>
> Key: HBASE-20061
> URL: https://issues.apache.org/jira/browse/HBASE-20061
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 1.2.0, 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0-alpha-1
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.5.0, 1.2.7, 1.4.3
>
> Attachments: HBASE-20061.0.patch
>
>
> follow up to HBASE-19728 (which is in an RC for 1.4.2 currently, so no 
> addendums):
> the filesCompacting member is currently package private, which allows folks 
> outside of HStore to modify it without ensuring we have hte needed locking in 
> place. it looks like we don't actually use it anywhere outside of HStore, so 
> we should just make it private.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19728) Add lock to filesCompacting in all place.

2018-02-24 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375683#comment-16375683
 ] 

Hudson commented on HBASE-19728:


SUCCESS: Integrated in Jenkins build HBase-1.3-IT #357 (See 
[https://builds.apache.org/job/HBase-1.3-IT/357/])
HBASE-19728 Add lock to filesCompacting in all place. (busbey: rev 
4d6d4c32489666ff452418993a044f6874e23dfd)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java


> Add lock to filesCompacting in all place.
> -
>
> Key: HBASE-19728
> URL: https://issues.apache.org/jira/browse/HBASE-19728
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 2.0.0, 3.0.0, 1.5.0
>Reporter: binlijin
>Assignee: binlijin
>Priority: Major
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.5.0, 1.2.7, 1.4.2
>
> Attachments: HBASE-19728.branch-1.001.patch, 
> HBASE-19728.master.001.patch, HBASE-19728.master.002.patch, 
> HBASE-19728.master.002.patch
>
>
> We find regionserver abort with the following exception:
> 2017-05-09 17:40:06,369 FATAL 
> [regionserver/hadoop0349.et2.tbsite.net/11.251.152.199:16020-shortCompactions-1493026663275]
>  regionserver.HRegionServer: ABORTING region server 
> hadoop0349.et2.tbsite.net,16020,1493026637177: 
> Thread[regionserver/hadoop0349.et2.tbsite.net/11.251.152.199:16020-shortCompactions-1493026663275,5,main]
>  throw uncaught exception
> java.lang.ArrayIndexOutOfBoundsException
>         at java.lang.System.arraycopy(Native Method)
>         at java.util.ArrayList.batchRemove(ArrayList.java:726)
>         at java.util.ArrayList.removeAll(ArrayList.java:690)
>         at 
> org.apache.hadoop.hbase.regionserver.HStore.finishCompactionRequest(HStore.java:1666)
>         at 
> org.apache.hadoop.hbase.regionserver.HStore.cancelRequestedCompaction(HStore.java:1656)
>         at 
> org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.run(CompactSplitThread.java:504)
>         at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1147)
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
>         at java.lang.Thread.run(Thread.java:834)
> 2017-05-08 21:15:31,979 FATAL 
> [regionserver/hadoop1191.et2.tbsite.net/11.251.159.40:16020-longCompactions-1494249331978]
>  regionserver.HRegionServer: ABORTING region server 
> hadoop1191.et2.tbsite.net,16020,1493196567798: 
> Thread[regionserver/hadoop1191.et2.tbsite.net/11.251.159.40:16020-longCompactions-1494249331978,5,main]
>  throw uncaught exception
> java.lang.IllegalArgumentException
>         at 
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:76)
>         at 
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy.getCurrentEligibleFiles(RatioBasedCompactionPolicy.java:64)
>         at 
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy.preSelectCompactionForCoprocessor(RatioBasedCompactionPolicy.java:72)
>         at 
> org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.preSelect(DefaultStoreEngine.java:117)
>         at 
> org.apache.hadoop.hbase.regionserver.HStore.requestCompaction(HStore.java:1542)
>         at 
> org.apache.hadoop.hbase.regionserver.CompactSplitThread.selectCompaction(CompactSplitThread.java:362)
>         at 
> org.apache.hadoop.hbase.regionserver.CompactSplitThread.access$200(CompactSplitThread.java:58)
>         at 
> org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.run(CompactSplitThread.java:491)
>         at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1147)
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
>         at java.lang.Thread.run(Thread.java:834)
> HStore#finishCompactionRequest do not require any HStore#lock's lock so 
> HStore.replaceStoreFiles need to synchronized on filesCompacting.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19728) Add lock to filesCompacting in all place.

2018-02-24 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375685#comment-16375685
 ] 

Hudson commented on HBASE-19728:


SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1073 (See 
[https://builds.apache.org/job/HBase-1.2-IT/1073/])
HBASE-19728 Add lock to filesCompacting in all place. (busbey: rev 
14ad07199c514976ec3b9e9bd994f66a27d7a331)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java


> Add lock to filesCompacting in all place.
> -
>
> Key: HBASE-19728
> URL: https://issues.apache.org/jira/browse/HBASE-19728
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 2.0.0, 3.0.0, 1.5.0
>Reporter: binlijin
>Assignee: binlijin
>Priority: Major
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.5.0, 1.2.7, 1.4.2
>
> Attachments: HBASE-19728.branch-1.001.patch, 
> HBASE-19728.master.001.patch, HBASE-19728.master.002.patch, 
> HBASE-19728.master.002.patch
>
>
> We find regionserver abort with the following exception:
> 2017-05-09 17:40:06,369 FATAL 
> [regionserver/hadoop0349.et2.tbsite.net/11.251.152.199:16020-shortCompactions-1493026663275]
>  regionserver.HRegionServer: ABORTING region server 
> hadoop0349.et2.tbsite.net,16020,1493026637177: 
> Thread[regionserver/hadoop0349.et2.tbsite.net/11.251.152.199:16020-shortCompactions-1493026663275,5,main]
>  throw uncaught exception
> java.lang.ArrayIndexOutOfBoundsException
>         at java.lang.System.arraycopy(Native Method)
>         at java.util.ArrayList.batchRemove(ArrayList.java:726)
>         at java.util.ArrayList.removeAll(ArrayList.java:690)
>         at 
> org.apache.hadoop.hbase.regionserver.HStore.finishCompactionRequest(HStore.java:1666)
>         at 
> org.apache.hadoop.hbase.regionserver.HStore.cancelRequestedCompaction(HStore.java:1656)
>         at 
> org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.run(CompactSplitThread.java:504)
>         at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1147)
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
>         at java.lang.Thread.run(Thread.java:834)
> 2017-05-08 21:15:31,979 FATAL 
> [regionserver/hadoop1191.et2.tbsite.net/11.251.159.40:16020-longCompactions-1494249331978]
>  regionserver.HRegionServer: ABORTING region server 
> hadoop1191.et2.tbsite.net,16020,1493196567798: 
> Thread[regionserver/hadoop1191.et2.tbsite.net/11.251.159.40:16020-longCompactions-1494249331978,5,main]
>  throw uncaught exception
> java.lang.IllegalArgumentException
>         at 
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:76)
>         at 
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy.getCurrentEligibleFiles(RatioBasedCompactionPolicy.java:64)
>         at 
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy.preSelectCompactionForCoprocessor(RatioBasedCompactionPolicy.java:72)
>         at 
> org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.preSelect(DefaultStoreEngine.java:117)
>         at 
> org.apache.hadoop.hbase.regionserver.HStore.requestCompaction(HStore.java:1542)
>         at 
> org.apache.hadoop.hbase.regionserver.CompactSplitThread.selectCompaction(CompactSplitThread.java:362)
>         at 
> org.apache.hadoop.hbase.regionserver.CompactSplitThread.access$200(CompactSplitThread.java:58)
>         at 
> org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.run(CompactSplitThread.java:491)
>         at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1147)
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
>         at java.lang.Thread.run(Thread.java:834)
> HStore#finishCompactionRequest do not require any HStore#lock's lock so 
> HStore.replaceStoreFiles need to synchronized on filesCompacting.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20061) HStore synchronized member variable filesCompacting should be private

2018-02-24 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375686#comment-16375686
 ] 

Hudson commented on HBASE-20061:


SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1073 (See 
[https://builds.apache.org/job/HBase-1.2-IT/1073/])
HBASE-20061 HStore synchronized member variable filesCompacting should (busbey: 
rev d2fe2a5a98a64b944390ca7381abf4dae41b6191)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java


> HStore synchronized member variable filesCompacting should be private
> -
>
> Key: HBASE-20061
> URL: https://issues.apache.org/jira/browse/HBASE-20061
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 1.2.0, 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0-alpha-1
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.5.0, 1.2.7, 1.4.3
>
> Attachments: HBASE-20061.0.patch
>
>
> follow up to HBASE-19728 (which is in an RC for 1.4.2 currently, so no 
> addendums):
> the filesCompacting member is currently package private, which allows folks 
> outside of HStore to modify it without ensuring we have hte needed locking in 
> place. it looks like we don't actually use it anywhere outside of HStore, so 
> we should just make it private.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20043) ITBLL fails against hadoop3

2018-02-24 Thread Mike Drob (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375692#comment-16375692
 ] 

Mike Drob commented on HBASE-20043:
---

findbugs issues look unrelated

TestBlockEvictionFromClient is not in the flaky list - haven't checked to see 
if that failure would be related.

> ITBLL fails against hadoop3
> ---
>
> Key: HBASE-20043
> URL: https://issues.apache.org/jira/browse/HBASE-20043
> Project: HBase
>  Issue Type: Bug
>  Components: integration tests
>Reporter: Mike Drob
>Assignee: stack
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20043.branch-2.001.patch, 
> HBASE-20043.branch-2.002.patch, HBASE-20043.branch-2.003.patch, 
> HBASE-20043.branch-2.004.patch, HBASE-20043.branch-2.005.patch, 
> HBASE-20043.branch-2.006.patch
>
>
> This has been failing for a while, I haven't tried to bisec but it was before 
> my changes for HBASE-19991 at least.
> {code}
> mvn clean verify -pl hbase-it -Dhadoop.profile=3.0 
> -Dit.test=IntegrationTestBigLinkedList -Dtest=none -am
> {code}
> {code}
> 2018-02-21 16:43:13,265 ERROR 
> [RpcServer.default.FPBQ.Fifo.handler=3,queue=0,port=60450] 
> ipc.RpcServer(464): Unexpected throwable object 
> java.lang.AssertionError: 
> hri=IntegrationTestBigLinkedList,\x8E8\xE3\x8E8\xE3\x8E5,1519252895022.236bbedde32e4549691c108a1a7005a8.,
>  source=, destination=mdrob-mbp.hsd1.tx.comcast.net,60456,1519252856027
>   at org.apache.hadoop.hbase.master.HMaster.move(HMaster.java:1691)
>   at 
> org.apache.hadoop.hbase.master.MasterRpcServices.moveRegion(MasterRpcServices.java:1348)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> 2018-02-21 16:43:13,276 DEBUG 
> [RpcServer.default.FPBQ.Fifo.handler=3,queue=0,port=60450] 
> ipc.CallRunner(141): callId: 49 service: MasterService methodName: MoveRegion 
> size: 106 connection: 192.168.1.134:60743 deadline: 1519253053263
> java.io.IOException: 
> hri=IntegrationTestBigLinkedList,\x8E8\xE3\x8E8\xE3\x8E5,1519252895022.236bbedde32e4549691c108a1a7005a8.,
>  source=, destination=mdrob-mbp.hsd1.tx.comcast.net,60456,1519252856027
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:465)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> Caused by: java.lang.AssertionError: 
> hri=IntegrationTestBigLinkedList,\x8E8\xE3\x8E8\xE3\x8E5,1519252895022.236bbedde32e4549691c108a1a7005a8.,
>  source=, destination=mdrob-mbp.hsd1.tx.comcast.net,60456,1519252856027
>   at org.apache.hadoop.hbase.master.HMaster.move(HMaster.java:1691)
>   at 
> org.apache.hadoop.hbase.master.MasterRpcServices.moveRegion(MasterRpcServices.java:1348)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
>   ... 3 more
> {code}
> The assertion that it trips is:
> {code}
> // Now we can do the move
> RegionPlan rp = new RegionPlan(hri, regionState.getServerName(), dest);
> assert rp.getDestination() != null: rp.toString() + " " + dest;
> assert rp.getSource() != null: rp.toString();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-15151) Rely on nightly tests for findbugs compliance on existing branch

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-15151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-15151:

Fix Version/s: 1.2.7

> Rely on nightly tests for findbugs compliance on existing branch
> 
>
> Key: HBASE-15151
> URL: https://issues.apache.org/jira/browse/HBASE-15151
> Project: HBase
>  Issue Type: Task
>  Components: build, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 1.2.7
>
>
> the "-1" for extant findbugs warnings has confused interpretation of our 
> precommit checks enough that we should switch to non-strict mode.
> It will still record the number of findbugs warnings present before the 
> patch, but it'll vote "0" rather than calling attention to things via a -1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-15151) Rely on nightly tests for findbugs compliance on existing branch

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-15151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-15151:

Summary: Rely on nightly tests for findbugs compliance on existing branch  
(was: turn off strict findbugs in precommit tests)

> Rely on nightly tests for findbugs compliance on existing branch
> 
>
> Key: HBASE-15151
> URL: https://issues.apache.org/jira/browse/HBASE-15151
> Project: HBase
>  Issue Type: Task
>  Components: build, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 1.2.7
>
>
> the "-1" for extant findbugs warnings has confused interpretation of our 
> precommit checks enough that we should switch to non-strict mode.
> It will still record the number of findbugs warnings present before the 
> patch, but it'll vote "0" rather than calling attention to things via a -1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-15151) Rely on nightly tests for findbugs compliance on existing branch

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-15151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-15151:

Priority: Blocker  (was: Critical)

> Rely on nightly tests for findbugs compliance on existing branch
> 
>
> Key: HBASE-15151
> URL: https://issues.apache.org/jira/browse/HBASE-15151
> Project: HBase
>  Issue Type: Task
>  Components: build, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.2.7
>
>
> the "-1" for extant findbugs warnings has confused interpretation of our 
> precommit checks enough that we should switch to non-strict mode.
> It will still record the number of findbugs warnings present before the 
> patch, but it'll vote "0" rather than calling attention to things via a -1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19859) Update download page header for 1.1 EOL

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-19859:

Component/s: community

> Update download page header for 1.1 EOL
> ---
>
> Key: HBASE-19859
> URL: https://issues.apache.org/jira/browse/HBASE-19859
> Project: HBase
>  Issue Type: Task
>  Components: community
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Major
> Attachments: HBASE-19583.patch
>
>
> See example mirror: http://mirrors.ocf.berkeley.edu/apache/hbase/
> They still claim that 1.1 is under active development.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20043) ITBLL fails against hadoop3

2018-02-24 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375733#comment-16375733
 ] 

stack commented on HBASE-20043:
---

All these tests pass locally. Let me retry. Will fix the findbugs in a new 
issue since this one a mess already and the findbugs are making it so we can't 
have a successful hbase2 nightly.

> ITBLL fails against hadoop3
> ---
>
> Key: HBASE-20043
> URL: https://issues.apache.org/jira/browse/HBASE-20043
> Project: HBase
>  Issue Type: Bug
>  Components: integration tests
>Reporter: Mike Drob
>Assignee: stack
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20043.branch-2.001.patch, 
> HBASE-20043.branch-2.002.patch, HBASE-20043.branch-2.003.patch, 
> HBASE-20043.branch-2.004.patch, HBASE-20043.branch-2.005.patch, 
> HBASE-20043.branch-2.006.patch
>
>
> This has been failing for a while, I haven't tried to bisec but it was before 
> my changes for HBASE-19991 at least.
> {code}
> mvn clean verify -pl hbase-it -Dhadoop.profile=3.0 
> -Dit.test=IntegrationTestBigLinkedList -Dtest=none -am
> {code}
> {code}
> 2018-02-21 16:43:13,265 ERROR 
> [RpcServer.default.FPBQ.Fifo.handler=3,queue=0,port=60450] 
> ipc.RpcServer(464): Unexpected throwable object 
> java.lang.AssertionError: 
> hri=IntegrationTestBigLinkedList,\x8E8\xE3\x8E8\xE3\x8E5,1519252895022.236bbedde32e4549691c108a1a7005a8.,
>  source=, destination=mdrob-mbp.hsd1.tx.comcast.net,60456,1519252856027
>   at org.apache.hadoop.hbase.master.HMaster.move(HMaster.java:1691)
>   at 
> org.apache.hadoop.hbase.master.MasterRpcServices.moveRegion(MasterRpcServices.java:1348)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> 2018-02-21 16:43:13,276 DEBUG 
> [RpcServer.default.FPBQ.Fifo.handler=3,queue=0,port=60450] 
> ipc.CallRunner(141): callId: 49 service: MasterService methodName: MoveRegion 
> size: 106 connection: 192.168.1.134:60743 deadline: 1519253053263
> java.io.IOException: 
> hri=IntegrationTestBigLinkedList,\x8E8\xE3\x8E8\xE3\x8E5,1519252895022.236bbedde32e4549691c108a1a7005a8.,
>  source=, destination=mdrob-mbp.hsd1.tx.comcast.net,60456,1519252856027
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:465)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> Caused by: java.lang.AssertionError: 
> hri=IntegrationTestBigLinkedList,\x8E8\xE3\x8E8\xE3\x8E5,1519252895022.236bbedde32e4549691c108a1a7005a8.,
>  source=, destination=mdrob-mbp.hsd1.tx.comcast.net,60456,1519252856027
>   at org.apache.hadoop.hbase.master.HMaster.move(HMaster.java:1691)
>   at 
> org.apache.hadoop.hbase.master.MasterRpcServices.moveRegion(MasterRpcServices.java:1348)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
>   ... 3 more
> {code}
> The assertion that it trips is:
> {code}
> // Now we can do the move
> RegionPlan rp = new RegionPlan(hri, regionState.getServerName(), dest);
> assert rp.getDestination() != null: rp.toString() + " " + dest;
> assert rp.getSource() != null: rp.toString();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (HBASE-19859) Update download page header for 1.1 EOL

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey resolved HBASE-19859.
-
  Resolution: Fixed
Release Note: HBase downloads page now reflects the EOM of the 1.1 release 
line that took place in December 2017.

> Update download page header for 1.1 EOL
> ---
>
> Key: HBASE-19859
> URL: https://issues.apache.org/jira/browse/HBASE-19859
> Project: HBase
>  Issue Type: Task
>  Components: community
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Major
> Attachments: HBASE-19583.patch
>
>
> See example mirror: http://mirrors.ocf.berkeley.edu/apache/hbase/
> They still claim that 1.1 is under active development.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20043) ITBLL fails against hadoop3

2018-02-24 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-20043:
--
Attachment: HBASE-20043.branch-2.006.patch

> ITBLL fails against hadoop3
> ---
>
> Key: HBASE-20043
> URL: https://issues.apache.org/jira/browse/HBASE-20043
> Project: HBase
>  Issue Type: Bug
>  Components: integration tests
>Reporter: Mike Drob
>Assignee: stack
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20043.branch-2.001.patch, 
> HBASE-20043.branch-2.002.patch, HBASE-20043.branch-2.003.patch, 
> HBASE-20043.branch-2.004.patch, HBASE-20043.branch-2.005.patch, 
> HBASE-20043.branch-2.006.patch, HBASE-20043.branch-2.006.patch
>
>
> This has been failing for a while, I haven't tried to bisec but it was before 
> my changes for HBASE-19991 at least.
> {code}
> mvn clean verify -pl hbase-it -Dhadoop.profile=3.0 
> -Dit.test=IntegrationTestBigLinkedList -Dtest=none -am
> {code}
> {code}
> 2018-02-21 16:43:13,265 ERROR 
> [RpcServer.default.FPBQ.Fifo.handler=3,queue=0,port=60450] 
> ipc.RpcServer(464): Unexpected throwable object 
> java.lang.AssertionError: 
> hri=IntegrationTestBigLinkedList,\x8E8\xE3\x8E8\xE3\x8E5,1519252895022.236bbedde32e4549691c108a1a7005a8.,
>  source=, destination=mdrob-mbp.hsd1.tx.comcast.net,60456,1519252856027
>   at org.apache.hadoop.hbase.master.HMaster.move(HMaster.java:1691)
>   at 
> org.apache.hadoop.hbase.master.MasterRpcServices.moveRegion(MasterRpcServices.java:1348)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> 2018-02-21 16:43:13,276 DEBUG 
> [RpcServer.default.FPBQ.Fifo.handler=3,queue=0,port=60450] 
> ipc.CallRunner(141): callId: 49 service: MasterService methodName: MoveRegion 
> size: 106 connection: 192.168.1.134:60743 deadline: 1519253053263
> java.io.IOException: 
> hri=IntegrationTestBigLinkedList,\x8E8\xE3\x8E8\xE3\x8E5,1519252895022.236bbedde32e4549691c108a1a7005a8.,
>  source=, destination=mdrob-mbp.hsd1.tx.comcast.net,60456,1519252856027
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:465)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> Caused by: java.lang.AssertionError: 
> hri=IntegrationTestBigLinkedList,\x8E8\xE3\x8E8\xE3\x8E5,1519252895022.236bbedde32e4549691c108a1a7005a8.,
>  source=, destination=mdrob-mbp.hsd1.tx.comcast.net,60456,1519252856027
>   at org.apache.hadoop.hbase.master.HMaster.move(HMaster.java:1691)
>   at 
> org.apache.hadoop.hbase.master.MasterRpcServices.moveRegion(MasterRpcServices.java:1348)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
>   ... 3 more
> {code}
> The assertion that it trips is:
> {code}
> // Now we can do the move
> RegionPlan rp = new RegionPlan(hri, regionState.getServerName(), dest);
> assert rp.getDestination() != null: rp.toString() + " " + dest;
> assert rp.getSource() != null: rp.toString();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-13696) cleanup references to EOM releases across the reference guide

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-13696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-13696:

Status: Open  (was: Patch Available)

updated title to reflect the larger scope that's in the patches.

moved out of patch available pending update from reviews.

> cleanup references to EOM releases across the reference guide
> -
>
> Key: HBASE-13696
> URL: https://issues.apache.org/jira/browse/HBASE-13696
> Project: HBase
>  Issue Type: Task
>Reporter: Sean Busbey
>Assignee: Chia-Ping Tsai
>Priority: Major
>  Labels: beginner
> Attachments: HBASE-13696.1.patch, HBASE-13696.2.patch, 
> HBASE-13696.v3.patch
>
>
> the java table still contains HBase 0.96, and the Hadoop table still has 
> HBase 0.92 and 0.96. We should remove these. Their details can still be found 
> in their last release.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-13696) cleanup references to EOM releases across the reference guide

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-13696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-13696:

Summary: cleanup references to EOM releases across the reference guide  
(was: Prune retired hbase versions from ref guide prereq support tables)

> cleanup references to EOM releases across the reference guide
> -
>
> Key: HBASE-13696
> URL: https://issues.apache.org/jira/browse/HBASE-13696
> Project: HBase
>  Issue Type: Task
>Reporter: Sean Busbey
>Assignee: Chia-Ping Tsai
>Priority: Major
>  Labels: beginner
> Attachments: HBASE-13696.1.patch, HBASE-13696.2.patch, 
> HBASE-13696.v3.patch
>
>
> the java table still contains HBase 0.96, and the Hadoop table still has 
> HBase 0.92 and 0.96. We should remove these. Their details can still be found 
> in their last release.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19583) update RM list to remove EOM versions

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-19583:

Summary: update RM list to remove EOM versions  (was: Delete EOL branches - 
branch-1.0 and branch-1.1)

> update RM list to remove EOM versions
> -
>
> Key: HBASE-19583
> URL: https://issues.apache.org/jira/browse/HBASE-19583
> Project: HBase
>  Issue Type: Bug
>Reporter: Appy
>Priority: Minor
>
> wdys [~enis] [~ndimiduk]?
> This needs updating too - http://hbase.apache.org/book.html#_release_managers.
> I think we should mention RMs for all branches, even eols, if only in other 
> table. Good way to recognize past efforts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (HBASE-19583) update RM list to remove EOM versions

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey reassigned HBASE-19583:
---

Assignee: Sean Busbey

> update RM list to remove EOM versions
> -
>
> Key: HBASE-19583
> URL: https://issues.apache.org/jira/browse/HBASE-19583
> Project: HBase
>  Issue Type: Bug
>Reporter: Appy
>Assignee: Sean Busbey
>Priority: Minor
>
> wdys [~enis] [~ndimiduk]?
> This needs updating too - http://hbase.apache.org/book.html#_release_managers.
> I think we should mention RMs for all branches, even eols, if only in other 
> table. Good way to recognize past efforts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-20071) Remove last 1.1 release from mirror system

2018-02-24 Thread Sean Busbey (JIRA)
Sean Busbey created HBASE-20071:
---

 Summary: Remove last 1.1 release from mirror system
 Key: HBASE-20071
 URL: https://issues.apache.org/jira/browse/HBASE-20071
 Project: HBase
  Issue Type: Task
  Components: community
Affects Versions: 1.1.13
Reporter: Sean Busbey
Assignee: Sean Busbey


now that 1.1 is EOM and the download page reflects that, we should remove 
1.1.13 from the ASF mirror system.

It will still be available afterwards on archive.apache:

http://archive.apache.org/dist/hbase/1.1.13/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (HBASE-20071) Remove last 1.1 release from mirror system

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey resolved HBASE-20071.
-
Resolution: Fixed

> Remove last 1.1 release from mirror system
> --
>
> Key: HBASE-20071
> URL: https://issues.apache.org/jira/browse/HBASE-20071
> Project: HBase
>  Issue Type: Task
>  Components: community
>Affects Versions: 1.1.13
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
>
> now that 1.1 is EOM and the download page reflects that, we should remove 
> 1.1.13 from the ASF mirror system.
> It will still be available afterwards on archive.apache:
> http://archive.apache.org/dist/hbase/1.1.13/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work started] (HBASE-19583) update RM list to remove EOM versions

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-19583 started by Sean Busbey.
---
> update RM list to remove EOM versions
> -
>
> Key: HBASE-19583
> URL: https://issues.apache.org/jira/browse/HBASE-19583
> Project: HBase
>  Issue Type: Bug
>Reporter: Appy
>Assignee: Sean Busbey
>Priority: Minor
>
> wdys [~enis] [~ndimiduk]?
> This needs updating too - http://hbase.apache.org/book.html#_release_managers.
> I think we should mention RMs for all branches, even eols, if only in other 
> table. Good way to recognize past efforts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19583) update RM list to remove EOM versions

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-19583:

Status: Patch Available  (was: In Progress)

> update RM list to remove EOM versions
> -
>
> Key: HBASE-19583
> URL: https://issues.apache.org/jira/browse/HBASE-19583
> Project: HBase
>  Issue Type: Bug
>Reporter: Appy
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HBASE-19583.patch
>
>
> wdys [~enis] [~ndimiduk]?
> This needs updating too - http://hbase.apache.org/book.html#_release_managers.
> I think we should mention RMs for all branches, even eols, if only in other 
> table. Good way to recognize past efforts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19583) update RM list to remove EOM versions

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-19583:

Attachment: HBASE-19583.patch

> update RM list to remove EOM versions
> -
>
> Key: HBASE-19583
> URL: https://issues.apache.org/jira/browse/HBASE-19583
> Project: HBase
>  Issue Type: Bug
>Reporter: Appy
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HBASE-19583.patch
>
>
> wdys [~enis] [~ndimiduk]?
> This needs updating too - http://hbase.apache.org/book.html#_release_managers.
> I think we should mention RMs for all branches, even eols, if only in other 
> table. Good way to recognize past efforts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-20072) remove 1.1 release line from the prerequisite tables

2018-02-24 Thread Sean Busbey (JIRA)
Sean Busbey created HBASE-20072:
---

 Summary: remove 1.1 release line from the prerequisite tables
 Key: HBASE-20072
 URL: https://issues.apache.org/jira/browse/HBASE-20072
 Project: HBase
  Issue Type: Task
  Components: community, documentation
Affects Versions: 1.1.13
Reporter: Sean Busbey
Assignee: Sean Busbey
 Fix For: 3.0.0


remove references to branch-1.1 releases from the prerequisite table for JDK 
and Hadoop versions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work started] (HBASE-20072) remove 1.1 release line from the prerequisite tables

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-20072 started by Sean Busbey.
---
> remove 1.1 release line from the prerequisite tables
> 
>
> Key: HBASE-20072
> URL: https://issues.apache.org/jira/browse/HBASE-20072
> Project: HBase
>  Issue Type: Task
>  Components: community, documentation
>Affects Versions: 1.1.13
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0
>
>
> remove references to branch-1.1 releases from the prerequisite table for JDK 
> and Hadoop versions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19583) update RM list to remove EOM versions

2018-02-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375741#comment-16375741
 ] 

Hadoop QA commented on HBASE-19583:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  5s{color} 
| {color:red} HBASE-19583 does not apply to master. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.7.0/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-19583 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12911920/HBASE-19583.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11658/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> update RM list to remove EOM versions
> -
>
> Key: HBASE-19583
> URL: https://issues.apache.org/jira/browse/HBASE-19583
> Project: HBase
>  Issue Type: Bug
>Reporter: Appy
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HBASE-19583.patch
>
>
> wdys [~enis] [~ndimiduk]?
> This needs updating too - http://hbase.apache.org/book.html#_release_managers.
> I think we should mention RMs for all branches, even eols, if only in other 
> table. Good way to recognize past efforts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-20073) remove 1.1 references from website landing pages

2018-02-24 Thread Sean Busbey (JIRA)
Sean Busbey created HBASE-20073:
---

 Summary: remove 1.1 references from website landing pages
 Key: HBASE-20073
 URL: https://issues.apache.org/jira/browse/HBASE-20073
 Project: HBase
  Issue Type: Task
  Components: website
Affects Versions: 1.1.13
Reporter: Sean Busbey
Assignee: Sean Busbey


As with our previous EOM versions, we should remove links to release-specific 
docs from our landing pages.

For 1.1 it looks like that means:

* Remove the "1.1 Documentation" menu item from the "Documentation and API" menu

Note that the actual docs for the release should remain in place to avoid 
breaking inbound links.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20070) website generation is failing

2018-02-24 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375759#comment-16375759
 ] 

Sean Busbey commented on HBASE-20070:
-

the git porcelain command for "tell me the full commit hash for the current 
working directory and error out if something goes wrong" is {{git rev-parse 
--verify HEAD}}.

alternatively we could expressly make this {{git rev-parse --verify 
origin/master}} if we wanted to guard against there being a local commit, or 
{{git rev-parse --verify origin/HEAD}} if we wanted to future proof against us 
deciding that our "place new stuff and docs lands first" should be something 
other than master. 

> website generation is failing
> -
>
> Key: HBASE-20070
> URL: https://issues.apache.org/jira/browse/HBASE-20070
> Project: HBase
>  Issue Type: Bug
>  Components: website
>Reporter: Sean Busbey
>Priority: Blocker
>
> website generation has been failing since Feb 20th
> {code}
> Checking out files: 100% (68971/68971), done.
> Usage: grep [OPTION]... PATTERN [FILE]...
> Try 'grep --help' for more information.
> PUSHED is 2
>  is not yet mentioned in the hbase-site commit log. Assuming we don't have it 
> yet. 2
> Building HBase
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; 
> support was removed in 8.0
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; 
> support was removed in 8.0
> Failure: mvn clean site
> Build step 'Execute shell' marked build as failure
> {code}
> The status email says
> {code}
> Build status: Still Failing
> The HBase website has not been updated to incorporate HBase commit 
> ${CURRENT_HBASE_COMMIT}.
> {code}
> Looking at the code where that grep happens, it looks like the env variable 
> CURRENT_HBASE_COMMIT isn't getting set. That comes from some git command. I'm 
> guessing the version of git changed on the build hosts and upended our 
> assumptions.
> we should fix this to 1) rely on git's porcelain interface, and 2) fail as 
> soon as that git command fails



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-20074) [FindBugs] Same code on both branches in CompactingMemStore#initMemStoreCompactor

2018-02-24 Thread stack (JIRA)
stack created HBASE-20074:
-

 Summary: [FindBugs] Same code on both branches in 
CompactingMemStore#initMemStoreCompactor
 Key: HBASE-20074
 URL: https://issues.apache.org/jira/browse/HBASE-20074
 Project: HBase
  Issue Type: Bug
  Components: findbugs
Reporter: stack
Assignee: Gali Sheffi


[~galish] Our findbugs checking was disabled for a few weeks and we just turned 
it on again. It found a good one. Mind fixing it please? Meantime I've undone 
the if class to get a factor dependent on index type. Thanks.


CodeWarning
DB  
org.apache.hadoop.hbase.regionserver.CompactingMemStore.initInmemoryFlushSize(Configuration)
 uses the same code for two branches
Bug type DB_DUPLICATE_BRANCHES (click for details) 
In class org.apache.hadoop.hbase.regionserver.CompactingMemStore
In method 
org.apache.hadoop.hbase.regionserver.CompactingMemStore.initInmemoryFlushSize(Configuration)
At CompactingMemStore.java:[line 140]
At CompactingMemStore.java:[line 143]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20072) remove 1.1 release line from the prerequisite tables

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-20072:

Attachment: HBASE-20072.0.patch

> remove 1.1 release line from the prerequisite tables
> 
>
> Key: HBASE-20072
> URL: https://issues.apache.org/jira/browse/HBASE-20072
> Project: HBase
>  Issue Type: Task
>  Components: community, documentation
>Affects Versions: 1.1.13
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20072.0.patch
>
>
> remove references to branch-1.1 releases from the prerequisite table for JDK 
> and Hadoop versions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20072) remove 1.1 release line from the prerequisite tables

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-20072:

Status: Patch Available  (was: In Progress)

> remove 1.1 release line from the prerequisite tables
> 
>
> Key: HBASE-20072
> URL: https://issues.apache.org/jira/browse/HBASE-20072
> Project: HBase
>  Issue Type: Task
>  Components: community, documentation
>Affects Versions: 1.1.13
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20072.0.patch
>
>
> remove references to branch-1.1 releases from the prerequisite table for JDK 
> and Hadoop versions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work started] (HBASE-20073) remove 1.1 references from website landing pages

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-20073 started by Sean Busbey.
---
> remove 1.1 references from website landing pages
> 
>
> Key: HBASE-20073
> URL: https://issues.apache.org/jira/browse/HBASE-20073
> Project: HBase
>  Issue Type: Task
>  Components: website
>Affects Versions: 1.1.13
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
>
> As with our previous EOM versions, we should remove links to release-specific 
> docs from our landing pages.
> For 1.1 it looks like that means:
> * Remove the "1.1 Documentation" menu item from the "Documentation and API" 
> menu
> Note that the actual docs for the release should remain in place to avoid 
> breaking inbound links.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20073) remove 1.1 references from website landing pages

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-20073:

Status: Patch Available  (was: In Progress)

> remove 1.1 references from website landing pages
> 
>
> Key: HBASE-20073
> URL: https://issues.apache.org/jira/browse/HBASE-20073
> Project: HBase
>  Issue Type: Task
>  Components: website
>Affects Versions: 1.1.13
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-20073.0.patch
>
>
> As with our previous EOM versions, we should remove links to release-specific 
> docs from our landing pages.
> For 1.1 it looks like that means:
> * Remove the "1.1 Documentation" menu item from the "Documentation and API" 
> menu
> Note that the actual docs for the release should remain in place to avoid 
> breaking inbound links.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20073) remove 1.1 references from website landing pages

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-20073:

Attachment: HBASE-20073.0.patch

> remove 1.1 references from website landing pages
> 
>
> Key: HBASE-20073
> URL: https://issues.apache.org/jira/browse/HBASE-20073
> Project: HBase
>  Issue Type: Task
>  Components: website
>Affects Versions: 1.1.13
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-20073.0.patch
>
>
> As with our previous EOM versions, we should remove links to release-specific 
> docs from our landing pages.
> For 1.1 it looks like that means:
> * Remove the "1.1 Documentation" menu item from the "Documentation and API" 
> menu
> Note that the actual docs for the release should remain in place to avoid 
> breaking inbound links.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (HBASE-20069) fix existing findbugs errors in hbase-server

2018-02-24 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack reassigned HBASE-20069:
-

Assignee: stack

> fix existing findbugs errors in hbase-server
> 
>
> Key: HBASE-20069
> URL: https://issues.apache.org/jira/browse/HBASE-20069
> Project: HBase
>  Issue Type: Sub-task
>  Components: findbugs
>Reporter: Sean Busbey
>Assignee: stack
>Priority: Critical
> Attachments: FindBugs Report.htm
>
>
> now that findbugs is running on precommit we have some cleanup to do.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20069) fix existing findbugs errors in hbase-server

2018-02-24 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-20069:
--
Attachment: HBASE-20069.branch-2.001.patch

> fix existing findbugs errors in hbase-server
> 
>
> Key: HBASE-20069
> URL: https://issues.apache.org/jira/browse/HBASE-20069
> Project: HBase
>  Issue Type: Sub-task
>  Components: findbugs
>Reporter: Sean Busbey
>Assignee: stack
>Priority: Critical
> Attachments: FindBugs Report.htm, HBASE-20069.branch-2.001.patch
>
>
> now that findbugs is running on precommit we have some cleanup to do.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20069) fix existing findbugs errors in hbase-server

2018-02-24 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-20069:
--
Status: Patch Available  (was: Open)

Try precommit.

> fix existing findbugs errors in hbase-server
> 
>
> Key: HBASE-20069
> URL: https://issues.apache.org/jira/browse/HBASE-20069
> Project: HBase
>  Issue Type: Sub-task
>  Components: findbugs
>Reporter: Sean Busbey
>Assignee: stack
>Priority: Critical
> Attachments: FindBugs Report.htm, HBASE-20069.branch-2.001.patch
>
>
> now that findbugs is running on precommit we have some cleanup to do.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20069) fix existing findbugs errors in hbase-server

2018-02-24 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375773#comment-16375773
 ] 

stack commented on HBASE-20069:
---

.001 Try to fix all findbugs extant. Looks like findbugs has been off for a 
good few weeks. HBASE-20074 is related. It is for in-memory compaction. An if 
had same clause on both sides. Need expert intercession so assigned [~galish].

> fix existing findbugs errors in hbase-server
> 
>
> Key: HBASE-20069
> URL: https://issues.apache.org/jira/browse/HBASE-20069
> Project: HBase
>  Issue Type: Sub-task
>  Components: findbugs
>Reporter: Sean Busbey
>Assignee: stack
>Priority: Critical
> Attachments: FindBugs Report.htm, HBASE-20069.branch-2.001.patch
>
>
> now that findbugs is running on precommit we have some cleanup to do.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-15151) Rely on nightly tests for findbugs compliance on existing branch

2018-02-24 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375779#comment-16375779
 ] 

stack commented on HBASE-15151:
---

Is this so? branch-2 failed because of findbugs on build #237 (If I have the 
number right).

> Rely on nightly tests for findbugs compliance on existing branch
> 
>
> Key: HBASE-15151
> URL: https://issues.apache.org/jira/browse/HBASE-15151
> Project: HBase
>  Issue Type: Task
>  Components: build, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.2.7
>
>
> the "-1" for extant findbugs warnings has confused interpretation of our 
> precommit checks enough that we should switch to non-strict mode.
> It will still record the number of findbugs warnings present before the 
> patch, but it'll vote "0" rather than calling attention to things via a -1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20066) Region sequence id may go backward after split or merge

2018-02-24 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375781#comment-16375781
 ] 

stack commented on HBASE-20066:
---

Thanks for digging in. Split and Merge are Pv2 so can add the writing of max 
sequenceid as a distinct step.  Was wondering if we had to write the sequence 
id file to the FS. Could we write it into the split/merge procedure persisted 
to the Pv2 WAL log but that won't work I suppose since replay of Procedure 
is AFTER replay of recovery... 

On writing the OPEN event to the WAL, we write it before successful OPEN?

> Region sequence id may go backward after split or merge
> ---
>
> Key: HBASE-20066
> URL: https://issues.apache.org/jira/browse/HBASE-20066
> Project: HBase
>  Issue Type: Bug
>Reporter: Duo Zhang
>Priority: Critical
>
> The problem is that, now we have markers which will be written to WAL but not 
> in store file. For a normal region close, we will write a sequence id file 
> under the region directory, and when opening we will use this as the open 
> sequence id. But for split and merge, we do not copy the sequence id file to 
> the newly generated regions so the sequence id may go backwards since when 
> closing the region we will write flush marker and close marker into WAL...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-15151) Rely on nightly tests for findbugs compliance on existing branch

2018-02-24 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375783#comment-16375783
 ] 

Sean Busbey commented on HBASE-15151:
-

here's the last complete run on branch-2 
[#378|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/378/]: 
[General 
Report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/378/General_Nightly_Build_Report/]
 and [JDK8 - hadoop 2 specific 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/378/JDK8_Nightly_Build_Report_(Hadoop2)/].
 Neither shows the findbugs module reporting.

> Rely on nightly tests for findbugs compliance on existing branch
> 
>
> Key: HBASE-15151
> URL: https://issues.apache.org/jira/browse/HBASE-15151
> Project: HBase
>  Issue Type: Task
>  Components: build, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.2.7
>
>
> the "-1" for extant findbugs warnings has confused interpretation of our 
> precommit checks enough that we should switch to non-strict mode.
> It will still record the number of findbugs warnings present before the 
> patch, but it'll vote "0" rather than calling attention to things via a -1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work started] (HBASE-20075) remove logic for branch-1.1 nightly testing

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-20075 started by Sean Busbey.
---
> remove logic for branch-1.1 nightly testing
> ---
>
> Key: HBASE-20075
> URL: https://issues.apache.org/jira/browse/HBASE-20075
> Project: HBase
>  Issue Type: Task
>  Components: test
>Affects Versions: 1.1.13
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.5.0, 1.2.7, 1.4.3
>
>
> since branch-1.1 is EOM, remove the branch-1.1 specific logic from our 
> Jenkinsfile and delete the Jenkinsfile in branch-1.1 so we'll stop running 
> nightlies for it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-20075) remove logic for branch-1.1 nightly testing

2018-02-24 Thread Sean Busbey (JIRA)
Sean Busbey created HBASE-20075:
---

 Summary: remove logic for branch-1.1 nightly testing
 Key: HBASE-20075
 URL: https://issues.apache.org/jira/browse/HBASE-20075
 Project: HBase
  Issue Type: Task
  Components: test
Affects Versions: 1.1.13
Reporter: Sean Busbey
Assignee: Sean Busbey
 Fix For: 2.0.0, 3.0.0, 1.3.2, 1.5.0, 1.2.7, 1.4.3


since branch-1.1 is EOM, remove the branch-1.1 specific logic from our 
Jenkinsfile and delete the Jenkinsfile in branch-1.1 so we'll stop running 
nightlies for it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-15151) Rely on nightly tests for findbugs compliance on existing branch

2018-02-24 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375784#comment-16375784
 ] 

Sean Busbey commented on HBASE-15151:
-

oh I see. the findbugs test is set to only run on the hadoop 3 profile.

that's no good, since it means we won't run it on any branch-1. I'll just move 
it to the hadoop 2 one.

> Rely on nightly tests for findbugs compliance on existing branch
> 
>
> Key: HBASE-15151
> URL: https://issues.apache.org/jira/browse/HBASE-15151
> Project: HBase
>  Issue Type: Task
>  Components: build, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.2.7
>
>
> the "-1" for extant findbugs warnings has confused interpretation of our 
> precommit checks enough that we should switch to non-strict mode.
> It will still record the number of findbugs warnings present before the 
> patch, but it'll vote "0" rather than calling attention to things via a -1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20073) remove 1.1 references from website landing pages

2018-02-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375785#comment-16375785
 ] 

Hadoop QA commented on HBASE-20073:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 1s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 24m 
32s{color} | {color:red} root in master failed. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 28m  
9s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
18s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 58m 32s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-20073 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12911925/HBASE-20073.0.patch |
| Optional Tests |  asflicense  mvnsite  xml  |
| uname | Linux d9d7ef2050c7 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / f90b47e3b0 |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| mvnsite | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11660/artifact/patchprocess/branch-mvnsite-root.txt
 |
| mvnsite | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11660/artifact/patchprocess/patch-mvnsite-root.txt
 |
| Max. process+thread count | 84 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11660/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> remove 1.1 references from website landing pages
> 
>
> Key: HBASE-20073
> URL: https://issues.apache.org/jira/browse/HBASE-20073
> Project: HBase
>  Issue Type: Task
>  Components: website
>Affects Versions: 1.1.13
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-20073.0.patch
>
>
> As with our previous EOM versions, we should remove links to release-specific 
> docs from our landing pages.
> For 1.1 it looks like that means:
> * Remove the "1.1 Documentation" menu item from the "Documentation and API" 
> menu
> Note that the actual docs for the release should remain in place to avoid 
> breaking inbound links.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20075) remove logic for branch-1.1 nightly testing

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-20075:

Status: Patch Available  (was: In Progress)

> remove logic for branch-1.1 nightly testing
> ---
>
> Key: HBASE-20075
> URL: https://issues.apache.org/jira/browse/HBASE-20075
> Project: HBase
>  Issue Type: Task
>  Components: test
>Affects Versions: 1.1.13
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.5.0, 1.2.7, 1.4.3
>
> Attachments: HBASE-20075.0.patch
>
>
> since branch-1.1 is EOM, remove the branch-1.1 specific logic from our 
> Jenkinsfile and delete the Jenkinsfile in branch-1.1 so we'll stop running 
> nightlies for it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20075) remove logic for branch-1.1 nightly testing

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-20075:

Attachment: HBASE-20075.0.patch

> remove logic for branch-1.1 nightly testing
> ---
>
> Key: HBASE-20075
> URL: https://issues.apache.org/jira/browse/HBASE-20075
> Project: HBase
>  Issue Type: Task
>  Components: test
>Affects Versions: 1.1.13
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.5.0, 1.2.7, 1.4.3
>
> Attachments: HBASE-20075.0.patch
>
>
> since branch-1.1 is EOM, remove the branch-1.1 specific logic from our 
> Jenkinsfile and delete the Jenkinsfile in branch-1.1 so we'll stop running 
> nightlies for it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-20076) Maven site generation fails

2018-02-24 Thread Sean Busbey (JIRA)
Sean Busbey created HBASE-20076:
---

 Summary: Maven site generation fails
 Key: HBASE-20076
 URL: https://issues.apache.org/jira/browse/HBASE-20076
 Project: HBase
  Issue Type: Bug
  Components: website
Affects Versions: 3.0.0
Reporter: Sean Busbey


precommit attempts at mvnsite fail with odd looking results:

{code}

[INFO] 
[INFO] --- maven-compiler-plugin:3.6.1:testCompile (default-testCompile) @ 
hbase-it ---
[INFO] Compiling 101 source files to 
/testptch/hbase/hbase-it/target/test-classes
[INFO] 
/testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java:
 Some input files use or override a deprecated API.
[INFO] 
/testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java:
 Recompile with -Xlint:deprecation for details.
[INFO] 
/testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java:
 Some input files use unchecked or unsafe operations.
[INFO] 
/testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java:
 Recompile with -Xlint:unchecked for details.
[INFO] -
[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] 
/testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java:[250,48]
 cannot find symbol
  symbol:   method readEntity(java.lang.Class)
  location: variable response of type javax.ws.rs.core.Response
[INFO] 1 error
{code}

{code}

[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project 
hbase-spark: failed to get report for 
org.apache.maven.plugins:maven-javadoc-plugin: Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile 
(default-testCompile) on project hbase-it: Compilation failure
[ERROR] 
/testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java:[250,48]
 cannot find symbol
[ERROR]   symbol:   method readEntity(java.lang.Class)
[ERROR]   location: variable response of type javax.ws.rs.core.Response
[ERROR] 
{code}

this is at least true on master. haven't checked other branches



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20076) Maven site generation fails

2018-02-24 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375788#comment-16375788
 ] 

Sean Busbey commented on HBASE-20076:
-

attached the complete log

> Maven site generation fails
> ---
>
> Key: HBASE-20076
> URL: https://issues.apache.org/jira/browse/HBASE-20076
> Project: HBase
>  Issue Type: Bug
>  Components: website
>Affects Versions: 3.0.0
>Reporter: Sean Busbey
>Priority: Major
> Attachments: branch-mvnsite-root.txt
>
>
> precommit attempts at mvnsite fail with odd looking results:
> {code}
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.6.1:testCompile (default-testCompile) @ 
> hbase-it ---
> [INFO] Compiling 101 source files to 
> /testptch/hbase/hbase-it/target/test-classes
> [INFO] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java:
>  Some input files use or override a deprecated API.
> [INFO] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java:
>  Recompile with -Xlint:deprecation for details.
> [INFO] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java:
>  Some input files use unchecked or unsafe operations.
> [INFO] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java:
>  Recompile with -Xlint:unchecked for details.
> [INFO] -
> [ERROR] COMPILATION ERROR : 
> [INFO] -
> [ERROR] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java:[250,48]
>  cannot find symbol
>   symbol:   method readEntity(java.lang.Class)
>   location: variable response of type javax.ws.rs.core.Response
> [INFO] 1 error
> {code}
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project 
> hbase-spark: failed to get report for 
> org.apache.maven.plugins:maven-javadoc-plugin: Failed to execute goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile 
> (default-testCompile) on project hbase-it: Compilation failure
> [ERROR] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java:[250,48]
>  cannot find symbol
> [ERROR]   symbol:   method readEntity(java.lang.Class)
> [ERROR]   location: variable response of type javax.ws.rs.core.Response
> [ERROR] 
> {code}
> this is at least true on master. haven't checked other branches



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20076) Maven site generation fails

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-20076:

Attachment: branch-mvnsite-root.txt

> Maven site generation fails
> ---
>
> Key: HBASE-20076
> URL: https://issues.apache.org/jira/browse/HBASE-20076
> Project: HBase
>  Issue Type: Bug
>  Components: website
>Affects Versions: 3.0.0
>Reporter: Sean Busbey
>Priority: Major
> Attachments: branch-mvnsite-root.txt
>
>
> precommit attempts at mvnsite fail with odd looking results:
> {code}
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.6.1:testCompile (default-testCompile) @ 
> hbase-it ---
> [INFO] Compiling 101 source files to 
> /testptch/hbase/hbase-it/target/test-classes
> [INFO] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java:
>  Some input files use or override a deprecated API.
> [INFO] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java:
>  Recompile with -Xlint:deprecation for details.
> [INFO] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java:
>  Some input files use unchecked or unsafe operations.
> [INFO] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java:
>  Recompile with -Xlint:unchecked for details.
> [INFO] -
> [ERROR] COMPILATION ERROR : 
> [INFO] -
> [ERROR] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java:[250,48]
>  cannot find symbol
>   symbol:   method readEntity(java.lang.Class)
>   location: variable response of type javax.ws.rs.core.Response
> [INFO] 1 error
> {code}
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project 
> hbase-spark: failed to get report for 
> org.apache.maven.plugins:maven-javadoc-plugin: Failed to execute goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile 
> (default-testCompile) on project hbase-it: Compilation failure
> [ERROR] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java:[250,48]
>  cannot find symbol
> [ERROR]   symbol:   method readEntity(java.lang.Class)
> [ERROR]   location: variable response of type javax.ws.rs.core.Response
> [ERROR] 
> {code}
> this is at least true on master. haven't checked other branches



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20075) remove logic for branch-1.1 nightly testing

2018-02-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375790#comment-16375790
 ] 

Hadoop QA commented on HBASE-20075:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
3s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
11s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  0m 38s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-20075 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12911933/HBASE-20075.0.patch |
| Optional Tests |  asflicense  shellcheck  shelldocs  |
| uname | Linux 33ed7c4c2809 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / f90b47e3b0 |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| shellcheck | v0.4.4 |
| Max. process+thread count | 43 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11662/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> remove logic for branch-1.1 nightly testing
> ---
>
> Key: HBASE-20075
> URL: https://issues.apache.org/jira/browse/HBASE-20075
> Project: HBase
>  Issue Type: Task
>  Components: test
>Affects Versions: 1.1.13
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.5.0, 1.2.7, 1.4.3
>
> Attachments: HBASE-20075.0.patch
>
>
> since branch-1.1 is EOM, remove the branch-1.1 specific logic from our 
> Jenkinsfile and delete the Jenkinsfile in branch-1.1 so we'll stop running 
> nightlies for it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20076) Maven site generation fails

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-20076:

Component/s: documentation

> Maven site generation fails
> ---
>
> Key: HBASE-20076
> URL: https://issues.apache.org/jira/browse/HBASE-20076
> Project: HBase
>  Issue Type: Bug
>  Components: documentation, website
>Affects Versions: 3.0.0
>Reporter: Sean Busbey
>Priority: Major
> Attachments: branch-mvnsite-root.txt
>
>
> precommit attempts at mvnsite fail with odd looking results:
> {code}
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.6.1:testCompile (default-testCompile) @ 
> hbase-it ---
> [INFO] Compiling 101 source files to 
> /testptch/hbase/hbase-it/target/test-classes
> [INFO] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java:
>  Some input files use or override a deprecated API.
> [INFO] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java:
>  Recompile with -Xlint:deprecation for details.
> [INFO] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java:
>  Some input files use unchecked or unsafe operations.
> [INFO] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java:
>  Recompile with -Xlint:unchecked for details.
> [INFO] -
> [ERROR] COMPILATION ERROR : 
> [INFO] -
> [ERROR] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java:[250,48]
>  cannot find symbol
>   symbol:   method readEntity(java.lang.Class)
>   location: variable response of type javax.ws.rs.core.Response
> [INFO] 1 error
> {code}
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project 
> hbase-spark: failed to get report for 
> org.apache.maven.plugins:maven-javadoc-plugin: Failed to execute goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile 
> (default-testCompile) on project hbase-it: Compilation failure
> [ERROR] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java:[250,48]
>  cannot find symbol
> [ERROR]   symbol:   method readEntity(java.lang.Class)
> [ERROR]   location: variable response of type javax.ws.rs.core.Response
> [ERROR] 
> {code}
> this is at least true on master. haven't checked other branches



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20073) remove 1.1 references from website landing pages

2018-02-24 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375789#comment-16375789
 ] 

Sean Busbey commented on HBASE-20073:
-

looks like maven site generation is busted in master. filed HBASE-20076.

meantime, here's how you can check locally:

{code}
mvn -pl . clean site --batch-mode -Dmaven.javadoc.skip=true -DskipTests
{code}

then open {{target/site/index.html}}

> remove 1.1 references from website landing pages
> 
>
> Key: HBASE-20073
> URL: https://issues.apache.org/jira/browse/HBASE-20073
> Project: HBase
>  Issue Type: Task
>  Components: website
>Affects Versions: 1.1.13
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-20073.0.patch
>
>
> As with our previous EOM versions, we should remove links to release-specific 
> docs from our landing pages.
> For 1.1 it looks like that means:
> * Remove the "1.1 Documentation" menu item from the "Documentation and API" 
> menu
> Note that the actual docs for the release should remain in place to avoid 
> breaking inbound links.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20076) Maven site generation fails

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-20076:

Priority: Critical  (was: Major)

> Maven site generation fails
> ---
>
> Key: HBASE-20076
> URL: https://issues.apache.org/jira/browse/HBASE-20076
> Project: HBase
>  Issue Type: Bug
>  Components: documentation, website
>Affects Versions: 3.0.0
>Reporter: Sean Busbey
>Priority: Critical
> Attachments: branch-mvnsite-root.txt
>
>
> precommit attempts at mvnsite fail with odd looking results:
> {code}
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.6.1:testCompile (default-testCompile) @ 
> hbase-it ---
> [INFO] Compiling 101 source files to 
> /testptch/hbase/hbase-it/target/test-classes
> [INFO] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java:
>  Some input files use or override a deprecated API.
> [INFO] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java:
>  Recompile with -Xlint:deprecation for details.
> [INFO] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java:
>  Some input files use unchecked or unsafe operations.
> [INFO] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java:
>  Recompile with -Xlint:unchecked for details.
> [INFO] -
> [ERROR] COMPILATION ERROR : 
> [INFO] -
> [ERROR] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java:[250,48]
>  cannot find symbol
>   symbol:   method readEntity(java.lang.Class)
>   location: variable response of type javax.ws.rs.core.Response
> [INFO] 1 error
> {code}
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project 
> hbase-spark: failed to get report for 
> org.apache.maven.plugins:maven-javadoc-plugin: Failed to execute goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile 
> (default-testCompile) on project hbase-it: Compilation failure
> [ERROR] 
> /testptch/hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/RESTApiClusterManager.java:[250,48]
>  cannot find symbol
> [ERROR]   symbol:   method readEntity(java.lang.Class)
> [ERROR]   location: variable response of type javax.ws.rs.core.Response
> [ERROR] 
> {code}
> this is at least true on master. haven't checked other branches



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (HBASE-18919) branch-1.1 nightly timing out in hbase-server

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey resolved HBASE-18919.
-
Resolution: Won't Fix

branch-1.1 is EOM, so no more fixing nightlies for it.

> branch-1.1 nightly timing out in hbase-server
> -
>
> Key: HBASE-18919
> URL: https://issues.apache.org/jira/browse/HBASE-18919
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.1.13
>Reporter: Sean Busbey
>Priority: Critical
>
> branch-1.1 nightly builds have been timing out in hbase-server on jdk7:
> https://builds.apache.org/job/HBase%20Nightly/job/branch-1.1/
> all recent runs look the same to me. yetus doesn't detect any hanging tests, 
> so I'm not sure what's hanging exactly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-18467) nightly job needs to run all stages and then comment on jira

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-18467:

Summary: nightly job needs to run all stages and then comment on jira  
(was: nightly job needs to comment on jira)

> nightly job needs to run all stages and then comment on jira
> 
>
> Key: HBASE-18467
> URL: https://issues.apache.org/jira/browse/HBASE-18467
> Project: HBase
>  Issue Type: Improvement
>  Components: community, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: HBASE-18467.0.WIP.patch, HBASE-18467.0.patch, 
> HBASE-18467.1.patch, HBASE-18467.1.patch
>
>
> follow on from HBASE-18147, need a post action that pings all newly-committed 
> jiras with result of the branch build



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (HBASE-18467) nightly job needs to comment on jira

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey reassigned HBASE-18467:
---

Assignee: Sean Busbey

> nightly job needs to comment on jira
> 
>
> Key: HBASE-18467
> URL: https://issues.apache.org/jira/browse/HBASE-18467
> Project: HBase
>  Issue Type: Improvement
>  Components: community, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: HBASE-18467.0.WIP.patch, HBASE-18467.0.patch, 
> HBASE-18467.1.patch, HBASE-18467.1.patch
>
>
> follow on from HBASE-18147, need a post action that pings all newly-committed 
> jiras with result of the branch build



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-18467) nightly job needs to run all stages and then comment on jira

2018-02-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375795#comment-16375795
 ] 

Hadoop QA commented on HBASE-18467:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
1s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  4s{color} 
| {color:red} HBASE-18467 does not apply to master. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.7.0/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-18467 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12900154/HBASE-18467.1.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11663/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> nightly job needs to run all stages and then comment on jira
> 
>
> Key: HBASE-18467
> URL: https://issues.apache.org/jira/browse/HBASE-18467
> Project: HBase
>  Issue Type: Improvement
>  Components: community, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: HBASE-18467.0.WIP.patch, HBASE-18467.0.patch, 
> HBASE-18467.1.patch, HBASE-18467.1.patch
>
>
> follow on from HBASE-18147, need a post action that pings all newly-committed 
> jiras with result of the branch build



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-18467) nightly job needs to run all stages and then comment on jira

2018-02-24 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-18467:

Status: In Progress  (was: Patch Available)

in progress. need to update for current master.

> nightly job needs to run all stages and then comment on jira
> 
>
> Key: HBASE-18467
> URL: https://issues.apache.org/jira/browse/HBASE-18467
> Project: HBase
>  Issue Type: Improvement
>  Components: community, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: HBASE-18467.0.WIP.patch, HBASE-18467.0.patch, 
> HBASE-18467.1.patch, HBASE-18467.1.patch
>
>
> follow on from HBASE-18147, need a post action that pings all newly-committed 
> jiras with result of the branch build



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20073) remove 1.1 references from website landing pages

2018-02-24 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375799#comment-16375799
 ] 

stack commented on HBASE-20073:
---

+1 on committing the patch removing the 1.1. from site menu.

> remove 1.1 references from website landing pages
> 
>
> Key: HBASE-20073
> URL: https://issues.apache.org/jira/browse/HBASE-20073
> Project: HBase
>  Issue Type: Task
>  Components: website
>Affects Versions: 1.1.13
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-20073.0.patch
>
>
> As with our previous EOM versions, we should remove links to release-specific 
> docs from our landing pages.
> For 1.1 it looks like that means:
> * Remove the "1.1 Documentation" menu item from the "Documentation and API" 
> menu
> Note that the actual docs for the release should remain in place to avoid 
> breaking inbound links.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-15151) Rely on nightly tests for findbugs compliance on existing branch

2018-02-24 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375800#comment-16375800
 ] 

stack commented on HBASE-15151:
---

Yeah, only happens after hadoop3 unit tests. Yeah, better on hadoop2. Thanks.

> Rely on nightly tests for findbugs compliance on existing branch
> 
>
> Key: HBASE-15151
> URL: https://issues.apache.org/jira/browse/HBASE-15151
> Project: HBase
>  Issue Type: Task
>  Components: build, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.2.7
>
>
> the "-1" for extant findbugs warnings has confused interpretation of our 
> precommit checks enough that we should switch to non-strict mode.
> It will still record the number of findbugs warnings present before the 
> patch, but it'll vote "0" rather than calling attention to things via a -1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


  1   2   >