date:20181029

[jira] [Updated] (HBASE-21406) "status 'replication'" should not show SINK if the cluster does not act as sink

2018-10-29 Thread Daisuke Kobayashi (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daisuke Kobayashi updated HBASE-21406:
--
Description: 
When replicating in 1 way, from source to target, {{status 'replication'}} on 
source always dumps SINK with meaningless metrics. It only makes sense when 
running the command on target cluster.

{{status 'replication'}} on source, for example. {{AgeOfLastAppliedOp}} is 
always zero and {{TimeStampsOfLastAppliedOp}} does not get updated from the 
time the RS started since it's not acting as sink.
{noformat}
source-1.com
   SOURCE: PeerID=1, AgeOfLastShippedOp=0, SizeOfLogQueue=0, 
TimeStampsOfLastShippedOp=Mon Oct 29 23:44:14 PDT 2018, Replication Lag=0
   SINK  : AgeOfLastAppliedOp=0, TimeStampsOfLastAppliedOp=Thu Oct 25 
23:56:53 PDT 2018
{noformat}

{{status 'replication'}} on target works as expected. SOURCE is empty as it's 
not acting as source:
{noformat}
target-1.com
   SOURCE:
   SINK  : AgeOfLastAppliedOp=70, TimeStampsOfLastAppliedOp=Mon Oct 29 
23:44:08 PDT 2018
{noformat}

This is because {{getReplicationLoadSink}}, called in {{admin.rb}}, always 
returns a value (not null).

1.X
https://github.com/apache/hbase/blob/rel/1.4.0/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java#L194-L204

2.X
https://github.com/apache/hbase/blob/rel/2.0.0/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java#L392-L399

> "status 'replication'" should not show SINK if the cluster does not act as 
> sink
> ---
>
> Key: HBASE-21406
> URL: https://issues.apache.org/jira/browse/HBASE-21406
> Project: HBase
>  Issue Type: Improvement
>Reporter: Daisuke Kobayashi
>Priority: Minor
>
> When replicating in 1 way, from source to target, {{status 'replication'}} on 
> source always dumps SINK with meaningless metrics. It only makes sense when 
> running the command on target cluster.
> {{status 'replication'}} on source, for example. {{AgeOfLastAppliedOp}} is 
> always zero and {{TimeStampsOfLastAppliedOp}} does not get updated from the 
> time the RS started since it's not acting as sink.
> {noformat}
> source-1.com
>SOURCE: PeerID=1, AgeOfLastShippedOp=0, SizeOfLogQueue=0, 
> TimeStampsOfLastShippedOp=Mon Oct 29 23:44:14 PDT 2018, Replication Lag=0
>SINK  : AgeOfLastAppliedOp=0, TimeStampsOfLastAppliedOp=Thu Oct 25 
> 23:56:53 PDT 2018
> {noformat}
> {{status 'replication'}} on target works as expected. SOURCE is empty as it's 
> not acting as source:
> {noformat}
> target-1.com
>SOURCE:
>SINK  : AgeOfLastAppliedOp=70, TimeStampsOfLastAppliedOp=Mon Oct 29 
> 23:44:08 PDT 2018
> {noformat}
> This is because {{getReplicationLoadSink}}, called in {{admin.rb}}, always 
> returns a value (not null).
> 1.X
> https://github.com/apache/hbase/blob/rel/1.4.0/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java#L194-L204
> 2.X
> https://github.com/apache/hbase/blob/rel/2.0.0/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java#L392-L399



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table

2018-10-29 Thread Hadoop QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668252#comment-16668252
 ] 

Hadoop QA commented on HBASE-21388:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
29s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
22s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m  
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
51s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
11m  3s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}221m  
3s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
24s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}265m  8s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21388 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12946144/HBASE-21388.master.003.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 4e18b93b3c6d 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 
10:45:36 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 4b86dd248a |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/14897/testReport/ |
| Max. process+thread count | 4892 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/14897/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> No n

[jira] [Commented] (HBASE-21393) Add an API ScheduleSCP() to HBCK2

2018-10-29 Thread Jingyun Tian (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668250#comment-16668250
 ] 

Jingyun Tian commented on HBASE-21393:
--

[~stack] I got this. So how do we deal with this? Revert the commit and made 
the api accept string again? If so guava is no more a problem too. 

> Add an API  ScheduleSCP() to HBCK2
> --
>
> Key: HBASE-21393
> URL: https://issues.apache.org/jira/browse/HBASE-21393
> Project: HBase
>  Issue Type: Sub-task
>  Components: hbase-operator-tools, hbck2
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: 0001-HBASE-21393-Add-an-API-ScheduleSCP-to-HBCK2.patch
>
>
> Add the API of ScheduleSCP() to hbase-operator-tools so that operators can 
> schedule ServerCrashProcedures of specified regionservers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21237) Use CompatRemoteProcedureResolver to dispatch open/close region requests to RS

2018-10-29 Thread Hadoop QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668236#comment-16668236
 ] 

Hadoop QA commented on HBASE-21237:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
27s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} branch-2.1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
17s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
47s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
13s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
39s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m  
6s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} branch-2.1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
52s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  1m 52s{color} 
| {color:red} hbase-server generated 1 new + 187 unchanged - 1 fixed = 188 
total (was 188) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
45s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
8m 57s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}176m  
3s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
23s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}214m 44s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:42ca976 |
| JIRA Issue | HBASE-21237 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12946151/HBASE-21237-branch-2.1-v1.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux a851a7b6f8e6 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 
08:52:28 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | branch-2.1 / 644ac13850 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
| javac | 
https://builds.apache.org/job/PreCommit-HBASE-Build/14898/artifact/patchprocess/diff-compile-javac-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/14898/testReport/ |
| Max. process+thread count | 4455 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-

[jira] [Updated] (HBASE-21406) "status 'replication'" should not show SINK if the cluster does not act as sink

2018-10-29 Thread Daisuke Kobayashi (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daisuke Kobayashi updated HBASE-21406:
--
Priority: Minor  (was: Major)

> "status 'replication'" should not show SINK if the cluster does not act as 
> sink
> ---
>
> Key: HBASE-21406
> URL: https://issues.apache.org/jira/browse/HBASE-21406
> Project: HBase
>  Issue Type: Improvement
>Reporter: Daisuke Kobayashi
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21406) "status 'replication'" should not show SINK if the cluster does not act as sink

2018-10-29 Thread Daisuke Kobayashi (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daisuke Kobayashi updated HBASE-21406:
--
Summary: "status 'replication'" should not show SINK if the cluster does 
not act as sink  (was: "status 'replication')

> "status 'replication'" should not show SINK if the cluster does not act as 
> sink
> ---
>
> Key: HBASE-21406
> URL: https://issues.apache.org/jira/browse/HBASE-21406
> Project: HBase
>  Issue Type: Improvement
>Reporter: Daisuke Kobayashi
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HBASE-21406) "status 'replication'

2018-10-29 Thread Daisuke Kobayashi (JIRA)

Daisuke Kobayashi created HBASE-21406:
-

 Summary: "status 'replication'
 Key: HBASE-21406
 URL: https://issues.apache.org/jira/browse/HBASE-21406
 Project: HBase
  Issue Type: Improvement
Reporter: Daisuke Kobayashi






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HBASE-21405) [DOC] Add Details about Output of "status 'replication'"

2018-10-29 Thread Daisuke Kobayashi (JIRA)

Daisuke Kobayashi created HBASE-21405:
-

 Summary: [DOC] Add Details about Output of "status 'replication'"
 Key: HBASE-21405
 URL: https://issues.apache.org/jira/browse/HBASE-21405
 Project: HBase
  Issue Type: Improvement
  Components: documentation
Affects Versions: 2.0.0, 1.4.0, 1.2.0
Reporter: Daisuke Kobayashi


Add more information about the meaning of each metric on to 
[http://hbase.apache.org/book.html#_monitoring_replication_status].

{noformat}
SOURCE:
 PeerID
 AgeOfLastShippedOp
 SizeOfLogQueue
 TimeStampsOfLastShippedOp
 Replication Lag
SINK
 AgeOfLastAppliedOp
 TimeStampsOfLastAppliedOp
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21371) Hbase unable to compile against Hadoop trunk (3.3.0-SNAPSHOT) due to license error

2018-10-29 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668221#comment-16668221
 ] 

Hudson commented on HBASE-21371:


Results for branch branch-2.1
[build #555 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/555/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/555//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/555//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/555//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Hbase unable to compile against Hadoop trunk (3.3.0-SNAPSHOT) due to license 
> error
> --
>
> Key: HBASE-21371
> URL: https://issues.apache.org/jira/browse/HBASE-21371
> Project: HBase
>  Issue Type: Bug
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21371.master.001.patch
>
>
> Hadoop 3.3.0 (trunk) updated various dependencies, which adds additional 
> licenses that break HBase's license check plugin.
> CDDL/GPLv2+CE license
> {quote}This product includes JavaBeans Activation Framework API jar licensed 
> under the CDDL/GPLv2+CE.
> CDDL or GPL version 2 plus the Classpath Exception
>  ERROR: Please check  this License for acceptability here:
> [https://www.apache.org/legal/resolved]
> If it is okay, then update the list named 'non_aggregate_fine' in the 
> LICENSE.vm file.
>  If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> javax.activation
>  javax.activation-api
>  1.2.0
> maven central search
>  g:javax.activation AND a:javax.activation-api AND v:1.2.0
> project website
>  [http://java.net/all/javax.activation-api/]
>  project source
>  [https://github.com/javaee/activation/javax.activation-api]
> {quote}
> Bouncy Castle License 
> {quote}–
>  This product includes Bouncy Castle PKIX, CMS, EAC, TSP, PKCS, OCSP, CMP, 
> and CRMF APIs licensed under the Bouncy Castle Licence.
> ERROR: Please check  this License for acceptability here:
> [https://www.apache.org/legal/resolved]
> If it is okay, then update the list named 'non_aggregate_fine' in the 
> LICENSE.vm file.
>  If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> org.bouncycastle
>  bcpkix-jdk15on
>  1.60
> maven central search
>  g:org.bouncycastle AND a:bcpkix-jdk15on AND v:1.60
> project website
>  [http://www.bouncycastle.org/java.html]
>  project source
>  [https://github.com/bcgit/bc-java]
>  –
> {quote}
>  
> And a long list of "Apache Software License - Version 2.0" licensed Jetty 
> dependencies like this:
> {quote}
> This product includes Jetty :: Servlet Annotations licensed under the Apache 
> Software License - Version 2.0.
> ERROR: Please check  this License for acceptability here:
> [https://www.apache.org/legal/resolved]
> If it is okay, then update the list named 'non_aggregate_fine' in the 
> LICENSE.vm file.
>  If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> org.eclipse.jetty
>  jetty-annotations
>  9.3.19.v20170502
> maven central search
>  g:org.eclipse.jetty AND a:jetty-annotations AND v:9.3.19.v20170502
> project website
>  [http://www.eclipse.org/jetty]
>  project source
>  [https://github.com/eclipse/jetty.project/jetty-annotations]
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21403) Give sort arrows on Master UI some attention...

2018-10-29 Thread stack (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668206#comment-16668206
 ] 

stack commented on HBASE-21403:
---

[~archana.katiyar] Maybe the arrows are fine. Sometimes they crowd the text a 
little in the table section. But they look fine too...  Maybe just leave this 
issue open and wait to see if we get more commentary?

Let me add a picture

 !Screen Shot 2018-10-29 at 11.10.52 PM.png! 

> Give sort arrows on Master UI some attention...
> ---
>
> Key: HBASE-21403
> URL: https://issues.apache.org/jira/browse/HBASE-21403
> Project: HBase
>  Issue Type: Sub-task
>  Components: UI
>Reporter: stack
>Priority: Trivial
> Attachments: Screen Shot 2018-10-29 at 11.10.52 PM.png
>
>
> Parent issue added some helpful sort functionality to the Master UI. The 
> arrows though are a bit small and can crowd the text in the table section in 
> the RIT rows. On the revent vote thread, 
> http://mail-archives.apache.org/mod_mbox/hbase-dev/201810.mbox/browser, 
> fellas were a little confused as to what they were for. This issue is about 
> given them a little attention to see if can be made more plain what they are 
> about.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21403) Give sort arrows on Master UI some attention...

2018-10-29 Thread stack (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-21403:
--
Attachment: Screen Shot 2018-10-29 at 11.10.52 PM.png

> Give sort arrows on Master UI some attention...
> ---
>
> Key: HBASE-21403
> URL: https://issues.apache.org/jira/browse/HBASE-21403
> Project: HBase
>  Issue Type: Sub-task
>  Components: UI
>Reporter: stack
>Priority: Trivial
> Attachments: Screen Shot 2018-10-29 at 11.10.52 PM.png
>
>
> Parent issue added some helpful sort functionality to the Master UI. The 
> arrows though are a bit small and can crowd the text in the table section in 
> the RIT rows. On the revent vote thread, 
> http://mail-archives.apache.org/mod_mbox/hbase-dev/201810.mbox/browser, 
> fellas were a little confused as to what they were for. This issue is about 
> given them a little attention to see if can be made more plain what they are 
> about.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21393) Add an API ScheduleSCP() to HBCK2

2018-10-29 Thread stack (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668204#comment-16668204
 ] 

stack commented on HBASE-21393:
---

Oh. You want to import protobuf? Its to make the ServerName as pb? Dang. I told 
you do that. I think I made a mistake.

The below protos are for hbase internals only:

import org.apache.hadoop.hbase.shaded.protobuf.generated.HBaseProtos;

If the server-side was String instead of ServerName, you wouldn't have to have 
the hbase internals on the client-side? That might be better? Loose-coupling.

Using guava is probably not so bad only you don't say what version of guava we 
are to use here in hbck2. We seem to be transitively depending on what is on 
the CLASSPATH? When hbck2 is on same classpath as hbase and hadoop, it  might 
cause pain. Have to have the hbck dependencies come first.



> Add an API  ScheduleSCP() to HBCK2
> --
>
> Key: HBASE-21393
> URL: https://issues.apache.org/jira/browse/HBASE-21393
> Project: HBase
>  Issue Type: Sub-task
>  Components: hbase-operator-tools, hbck2
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: 0001-HBASE-21393-Add-an-API-ScheduleSCP-to-HBCK2.patch
>
>
> Add the API of ScheduleSCP() to hbase-operator-tools so that operators can 
> schedule ServerCrashProcedures of specified regionservers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21403) Give sort arrows on Master UI some attention...

2018-10-29 Thread Archana Katiyar (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668164#comment-16668164
 ] 

Archana Katiyar commented on HBASE-21403:
-

Thanks for filing this issue [~stack]. The arrows are basically two gif files 
(one for upward arrow and other for downward arrow). Current gifs are the 
standard ones which are used with jquery sorting functionality.

We can increase size of the arrow gifs, if that helps. Alternatively, we can 
display help text somewhere that click on these arrows to sort the table.

> Give sort arrows on Master UI some attention...
> ---
>
> Key: HBASE-21403
> URL: https://issues.apache.org/jira/browse/HBASE-21403
> Project: HBase
>  Issue Type: Sub-task
>  Components: UI
>Reporter: stack
>Priority: Trivial
>
> Parent issue added some helpful sort functionality to the Master UI. The 
> arrows though are a bit small and can crowd the text in the table section in 
> the RIT rows. On the revent vote thread, 
> http://mail-archives.apache.org/mod_mbox/hbase-dev/201810.mbox/browser, 
> fellas were a little confused as to what they were for. This issue is about 
> given them a little attention to see if can be made more plain what they are 
> about.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21371) Hbase unable to compile against Hadoop trunk (3.3.0-SNAPSHOT) due to license error

2018-10-29 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668160#comment-16668160
 ] 

Hudson commented on HBASE-21371:


Results for branch branch-2
[build #1464 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1464/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1464//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1464//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1464//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Hbase unable to compile against Hadoop trunk (3.3.0-SNAPSHOT) due to license 
> error
> --
>
> Key: HBASE-21371
> URL: https://issues.apache.org/jira/browse/HBASE-21371
> Project: HBase
>  Issue Type: Bug
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21371.master.001.patch
>
>
> Hadoop 3.3.0 (trunk) updated various dependencies, which adds additional 
> licenses that break HBase's license check plugin.
> CDDL/GPLv2+CE license
> {quote}This product includes JavaBeans Activation Framework API jar licensed 
> under the CDDL/GPLv2+CE.
> CDDL or GPL version 2 plus the Classpath Exception
>  ERROR: Please check  this License for acceptability here:
> [https://www.apache.org/legal/resolved]
> If it is okay, then update the list named 'non_aggregate_fine' in the 
> LICENSE.vm file.
>  If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> javax.activation
>  javax.activation-api
>  1.2.0
> maven central search
>  g:javax.activation AND a:javax.activation-api AND v:1.2.0
> project website
>  [http://java.net/all/javax.activation-api/]
>  project source
>  [https://github.com/javaee/activation/javax.activation-api]
> {quote}
> Bouncy Castle License 
> {quote}–
>  This product includes Bouncy Castle PKIX, CMS, EAC, TSP, PKCS, OCSP, CMP, 
> and CRMF APIs licensed under the Bouncy Castle Licence.
> ERROR: Please check  this License for acceptability here:
> [https://www.apache.org/legal/resolved]
> If it is okay, then update the list named 'non_aggregate_fine' in the 
> LICENSE.vm file.
>  If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> org.bouncycastle
>  bcpkix-jdk15on
>  1.60
> maven central search
>  g:org.bouncycastle AND a:bcpkix-jdk15on AND v:1.60
> project website
>  [http://www.bouncycastle.org/java.html]
>  project source
>  [https://github.com/bcgit/bc-java]
>  –
> {quote}
>  
> And a long list of "Apache Software License - Version 2.0" licensed Jetty 
> dependencies like this:
> {quote}
> This product includes Jetty :: Servlet Annotations licensed under the Apache 
> Software License - Version 2.0.
> ERROR: Please check  this License for acceptability here:
> [https://www.apache.org/legal/resolved]
> If it is okay, then update the list named 'non_aggregate_fine' in the 
> LICENSE.vm file.
>  If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> org.eclipse.jetty
>  jetty-annotations
>  9.3.19.v20170502
> maven central search
>  g:org.eclipse.jetty AND a:jetty-annotations AND v:9.3.19.v20170502
> project website
>  [http://www.eclipse.org/jetty]
>  project source
>  [https://github.com/eclipse/jetty.project/jetty-annotations]
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21237) Use CompatRemoteProcedureResolver to dispatch open/close region requests to RS

2018-10-29 Thread stack (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668159#comment-16668159
 ] 

stack commented on HBASE-21237:
---

duh. Is that all it took. Good one [~Apache9] +1.

> Use CompatRemoteProcedureResolver to dispatch open/close region requests to RS
> --
>
> Key: HBASE-21237
> URL: https://issues.apache.org/jira/browse/HBASE-21237
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.1.0, 2.0.2
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Blocker
> Fix For: 2.0.3, 2.1.2
>
> Attachments: HBASE-21237-branch-2.1-v1.patch, 
> HBASE-21237-branch-2.1.patch, HBASE-21237.branch-2.0.001.patch
>
>
> As discussed in HBASE-21217, in branch-2.0 and branch-2.1, we should use  
> CompatRemoteProcedureResolver  instead of ExecuteProceduresRemoteCall to 
> dispatch region open/close requests to RS. Since ExecuteProceduresRemoteCall  
> will group all the open/close operations in one call and execute them 
> sequentially on the target RS. If one operation fails, all the operation will 
> be marked as failure. Actually, some of the operations(like open region) is 
> already executing in the open region handler thread. But master thinks these 
> operations fails and reassign the regions to another RS. So when the previous 
> RS report to the master that the region is online, master will kill the RS 
> since it already assign the region to another RS.
> For branch-2.2+, HBASE-21217 will fix this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21322) Add a scheduleServerCrashProcedure() API to HbckService

2018-10-29 Thread Jingyun Tian (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668158#comment-16668158
 ] 

Jingyun Tian commented on HBASE-21322:
--

[~stack] yeah, already upload a patch at HBASE-21393, please check it out.

> Add a scheduleServerCrashProcedure() API to HbckService
> ---
>
> Key: HBASE-21322
> URL: https://issues.apache.org/jira/browse/HBASE-21322
> Project: HBase
>  Issue Type: Sub-task
>  Components: hbck2
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21322.branch-2.1.001.patch, 
> HBASE-21322.master.001.patch, HBASE-21322.master.002.patch, 
> HBASE-21322.master.003.patch, HBASE-21322.master.004.patch, 
> HBASE-21322.master.005.patch, HBASE-21322.master.006.patch, Screenshot from 
> 2018-10-17 13-35-58.png, Screenshot from 2018-10-17 13-38-41.png, Screenshot 
> from 2018-10-17 13-47-06.png
>
>
> According to my test, if one RS is down, then all procedure logs are deleted, 
> it will lead to that no ServerCrashProcedure is scheduled. And restarting 
> master cannot help. Thus we need to schedule a ServerCrashProcedure manually 
> to solve the problem. I plan to add a scheduleServerCrashProcedure() API to 
> HbckService, then add this API to HBCK2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21371) Hbase unable to compile against Hadoop trunk (3.3.0-SNAPSHOT) due to license error

2018-10-29 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668127#comment-16668127
 ] 

Hudson commented on HBASE-21371:


Results for branch branch-2.0
[build #1035 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1035/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1035//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1035//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1035//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Hbase unable to compile against Hadoop trunk (3.3.0-SNAPSHOT) due to license 
> error
> --
>
> Key: HBASE-21371
> URL: https://issues.apache.org/jira/browse/HBASE-21371
> Project: HBase
>  Issue Type: Bug
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21371.master.001.patch
>
>
> Hadoop 3.3.0 (trunk) updated various dependencies, which adds additional 
> licenses that break HBase's license check plugin.
> CDDL/GPLv2+CE license
> {quote}This product includes JavaBeans Activation Framework API jar licensed 
> under the CDDL/GPLv2+CE.
> CDDL or GPL version 2 plus the Classpath Exception
>  ERROR: Please check  this License for acceptability here:
> [https://www.apache.org/legal/resolved]
> If it is okay, then update the list named 'non_aggregate_fine' in the 
> LICENSE.vm file.
>  If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> javax.activation
>  javax.activation-api
>  1.2.0
> maven central search
>  g:javax.activation AND a:javax.activation-api AND v:1.2.0
> project website
>  [http://java.net/all/javax.activation-api/]
>  project source
>  [https://github.com/javaee/activation/javax.activation-api]
> {quote}
> Bouncy Castle License 
> {quote}–
>  This product includes Bouncy Castle PKIX, CMS, EAC, TSP, PKCS, OCSP, CMP, 
> and CRMF APIs licensed under the Bouncy Castle Licence.
> ERROR: Please check  this License for acceptability here:
> [https://www.apache.org/legal/resolved]
> If it is okay, then update the list named 'non_aggregate_fine' in the 
> LICENSE.vm file.
>  If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> org.bouncycastle
>  bcpkix-jdk15on
>  1.60
> maven central search
>  g:org.bouncycastle AND a:bcpkix-jdk15on AND v:1.60
> project website
>  [http://www.bouncycastle.org/java.html]
>  project source
>  [https://github.com/bcgit/bc-java]
>  –
> {quote}
>  
> And a long list of "Apache Software License - Version 2.0" licensed Jetty 
> dependencies like this:
> {quote}
> This product includes Jetty :: Servlet Annotations licensed under the Apache 
> Software License - Version 2.0.
> ERROR: Please check  this License for acceptability here:
> [https://www.apache.org/legal/resolved]
> If it is okay, then update the list named 'non_aggregate_fine' in the 
> LICENSE.vm file.
>  If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> org.eclipse.jetty
>  jetty-annotations
>  9.3.19.v20170502
> maven central search
>  g:org.eclipse.jetty AND a:jetty-annotations AND v:9.3.19.v20170502
> project website
>  [http://www.eclipse.org/jetty]
>  project source
>  [https://github.com/eclipse/jetty.project/jetty-annotations]
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21322) Add a scheduleServerCrashProcedure() API to HbckService

2018-10-29 Thread stack (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-21322:
--
  Resolution: Fixed
Release Note: Adds scheduleServerCrashProcedure to the HbckService.
  Status: Resolved  (was: Patch Available)

Pushed to branch-2.0+. Thanks for the patch [~tianjingyun].

You up for adding on hbck2 side ? Thanks.

> Add a scheduleServerCrashProcedure() API to HbckService
> ---
>
> Key: HBASE-21322
> URL: https://issues.apache.org/jira/browse/HBASE-21322
> Project: HBase
>  Issue Type: Sub-task
>  Components: hbck2
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21322.branch-2.1.001.patch, 
> HBASE-21322.master.001.patch, HBASE-21322.master.002.patch, 
> HBASE-21322.master.003.patch, HBASE-21322.master.004.patch, 
> HBASE-21322.master.005.patch, HBASE-21322.master.006.patch, Screenshot from 
> 2018-10-17 13-35-58.png, Screenshot from 2018-10-17 13-38-41.png, Screenshot 
> from 2018-10-17 13-47-06.png
>
>
> According to my test, if one RS is down, then all procedure logs are deleted, 
> it will lead to that no ServerCrashProcedure is scheduled. And restarting 
> master cannot help. Thus we need to schedule a ServerCrashProcedure manually 
> to solve the problem. I plan to add a scheduleServerCrashProcedure() API to 
> HbckService, then add this API to HBCK2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21393) Add an API ScheduleSCP() to HBCK2

2018-10-29 Thread Jingyun Tian (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jingyun Tian updated HBASE-21393:
-
Attachment: 0001-HBASE-21393-Add-an-API-ScheduleSCP-to-HBCK2.patch

> Add an API  ScheduleSCP() to HBCK2
> --
>
> Key: HBASE-21393
> URL: https://issues.apache.org/jira/browse/HBASE-21393
> Project: HBase
>  Issue Type: Sub-task
>  Components: hbase-operator-tools, hbck2
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: 0001-HBASE-21393-Add-an-API-ScheduleSCP-to-HBCK2.patch
>
>
> Add the API of ScheduleSCP() to hbase-operator-tools so that operators can 
> schedule ServerCrashProcedures of specified regionservers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21328) why HBASE_DISABLE_HADOOP_CLASSPATH_LOOKUP set to false by default?

2018-10-29 Thread Hadoop QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668072#comment-16668072
 ] 

Hadoop QA commented on HBASE-21328:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
26s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  1m  4s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21328 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12946153/HBASE-21328.master.002.patch
 |
| Optional Tests |  dupname  asflicense  shellcheck  shelldocs  |
| uname | Linux 9396b4c1dc16 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 
08:52:28 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 4b86dd248a |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| shellcheck | v0.4.4 |
| Max. process+thread count | 43 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/14899/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> why HBASE_DISABLE_HADOOP_CLASSPATH_LOOKUP set to false by default?
> --
>
> Key: HBASE-21328
> URL: https://issues.apache.org/jira/browse/HBASE-21328
> Project: HBase
>  Issue Type: Improvement
>  Components: documentation, Operability
>Reporter: Nick.han
>Assignee: Nick.han
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.0
>
> Attachments: HBASE-21328.master.001.patch, 
> HBASE-21328.master.002.patch
>
>
> hi,all
>       I got a problem while I using hbase3.0.0-snapshot and hadoop 2.7.5 to 
> build a hbase cluster,the problem is  hbase using javax.servlet-api-3.1.0-jar 
> witch is conflict by servlet-api-2.5.jar that in
> hadoop lib path, I run into hbase file and got config 
> HBASE_DISABLE_HADOOP_CLASSPATH_LOOKUP set to false by default, this config 
> decide whether or not include Hadoop lib to hbase class path，so the question 
> is why we set this config to false?can we set it to true and exclude the 
> Hadoop lib by default?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-29 Thread Reid Chan (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan updated HBASE-21255:
--
Summary: [acl] Refactor TablePermission into three classes (Global, 
Namespace, Table)  (was: Refactor TablePermission into three classes (Global, 
Namespace, Table))

> [acl] Refactor TablePermission into three classes (Global, Namespace, Table)
> 
>
> Key: HBASE-21255
> URL: https://issues.apache.org/jira/browse/HBASE-21255
> Project: HBase
>  Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Attachments: HBASE-21225.master.001.patch, 
> HBASE-21225.master.002.patch
>
>
> A TODO in {{TablePermission.java}}
> {code}
>   //TODO refactor this class
>   //we need to refacting this into three classes (Global, Table, Namespace)
> {code}
> Change Note:
> * Divide origin TablePermission into three classes GlobalPermission, 
> NamespacePermission, TablePermission
> * New UserPermission consists of a user name and a permission in one of 
> [Global, Namespace, Table]Permission.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21322) Add a scheduleServerCrashProcedure() API to HbckService

2018-10-29 Thread Jingyun Tian (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668038#comment-16668038
 ] 

Jingyun Tian commented on HBASE-21322:
--

[~stack] Could you help commit this patch? Or I need to rebase recently commits?

> Add a scheduleServerCrashProcedure() API to HbckService
> ---
>
> Key: HBASE-21322
> URL: https://issues.apache.org/jira/browse/HBASE-21322
> Project: HBase
>  Issue Type: Sub-task
>  Components: hbck2
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21322.branch-2.1.001.patch, 
> HBASE-21322.master.001.patch, HBASE-21322.master.002.patch, 
> HBASE-21322.master.003.patch, HBASE-21322.master.004.patch, 
> HBASE-21322.master.005.patch, HBASE-21322.master.006.patch, Screenshot from 
> 2018-10-17 13-35-58.png, Screenshot from 2018-10-17 13-38-41.png, Screenshot 
> from 2018-10-17 13-47-06.png
>
>
> According to my test, if one RS is down, then all procedure logs are deleted, 
> it will lead to that no ServerCrashProcedure is scheduled. And restarting 
> master cannot help. Thus we need to schedule a ServerCrashProcedure manually 
> to solve the problem. I plan to add a scheduleServerCrashProcedure() API to 
> HbckService, then add this API to HBCK2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21328) why HBASE_DISABLE_HADOOP_CLASSPATH_LOOKUP set to false by default?

2018-10-29 Thread Nick.han (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick.han updated HBASE-21328:
-
Attachment: (was: HBASE-21328.master.002.patch)

> why HBASE_DISABLE_HADOOP_CLASSPATH_LOOKUP set to false by default?
> --
>
> Key: HBASE-21328
> URL: https://issues.apache.org/jira/browse/HBASE-21328
> Project: HBase
>  Issue Type: Improvement
>  Components: documentation, Operability
>Reporter: Nick.han
>Assignee: Nick.han
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.0
>
> Attachments: HBASE-21328.master.001.patch, 
> HBASE-21328.master.002.patch
>
>
> hi,all
>       I got a problem while I using hbase3.0.0-snapshot and hadoop 2.7.5 to 
> build a hbase cluster,the problem is  hbase using javax.servlet-api-3.1.0-jar 
> witch is conflict by servlet-api-2.5.jar that in
> hadoop lib path, I run into hbase file and got config 
> HBASE_DISABLE_HADOOP_CLASSPATH_LOOKUP set to false by default, this config 
> decide whether or not include Hadoop lib to hbase class path，so the question 
> is why we set this config to false?can we set it to true and exclude the 
> Hadoop lib by default?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21328) why HBASE_DISABLE_HADOOP_CLASSPATH_LOOKUP set to false by default?

2018-10-29 Thread Nick.han (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick.han updated HBASE-21328:
-
Attachment: HBASE-21328.master.002.patch
Status: Patch Available  (was: Open)

> why HBASE_DISABLE_HADOOP_CLASSPATH_LOOKUP set to false by default?
> --
>
> Key: HBASE-21328
> URL: https://issues.apache.org/jira/browse/HBASE-21328
> Project: HBase
>  Issue Type: Improvement
>  Components: documentation, Operability
>Reporter: Nick.han
>Assignee: Nick.han
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.0
>
> Attachments: HBASE-21328.master.001.patch, 
> HBASE-21328.master.002.patch, HBASE-21328.master.002.patch
>
>
> hi,all
>       I got a problem while I using hbase3.0.0-snapshot and hadoop 2.7.5 to 
> build a hbase cluster,the problem is  hbase using javax.servlet-api-3.1.0-jar 
> witch is conflict by servlet-api-2.5.jar that in
> hadoop lib path, I run into hbase file and got config 
> HBASE_DISABLE_HADOOP_CLASSPATH_LOOKUP set to false by default, this config 
> decide whether or not include Hadoop lib to hbase class path，so the question 
> is why we set this config to false?can we set it to true and exclude the 
> Hadoop lib by default?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21237) Use CompatRemoteProcedureResolver to dispatch open/close region requests to RS

2018-10-29 Thread Duo Zhang (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-21237:
--
Attachment: HBASE-21237-branch-2.1-v1.patch

> Use CompatRemoteProcedureResolver to dispatch open/close region requests to RS
> --
>
> Key: HBASE-21237
> URL: https://issues.apache.org/jira/browse/HBASE-21237
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.1.0, 2.0.2
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Blocker
> Fix For: 2.0.3, 2.1.2
>
> Attachments: HBASE-21237-branch-2.1-v1.patch, 
> HBASE-21237-branch-2.1.patch, HBASE-21237.branch-2.0.001.patch
>
>
> As discussed in HBASE-21217, in branch-2.0 and branch-2.1, we should use  
> CompatRemoteProcedureResolver  instead of ExecuteProceduresRemoteCall to 
> dispatch region open/close requests to RS. Since ExecuteProceduresRemoteCall  
> will group all the open/close operations in one call and execute them 
> sequentially on the target RS. If one operation fails, all the operation will 
> be marked as failure. Actually, some of the operations(like open region) is 
> already executing in the open region handler thread. But master thinks these 
> operations fails and reassign the regions to another RS. So when the previous 
> RS report to the master that the region is online, master will kill the RS 
> since it already assign the region to another RS.
> For branch-2.2+, HBASE-21217 will fix this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table

2018-10-29 Thread Guanghao Zhang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667960#comment-16667960
 ] 

Guanghao Zhang commented on HBASE-21388:


Rebase master and add a new 003 patch for Hadoop QA.

> No need to instantiate MemStoreLAB for master which not carry table
> ---
>
> Key: HBASE-21388
> URL: https://issues.apache.org/jira/browse/HBASE-21388
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-21388.master.001.patch, 
> HBASE-21388.master.002.patch, HBASE-21388.master.003.patch
>
>
> We found this log in our master.
> 2018-10-26,10:00:00,449 INFO 
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] 
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data 
> MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0
> 2018-10-26,10:00:00,452 INFO 
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] 
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index 
> MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0
>  
> Same with HBASE-21290, we don't need to instantiate MemStore for master which 
> not carry table.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table

2018-10-29 Thread Guanghao Zhang (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-21388:
---
Attachment: HBASE-21388.master.003.patch

> No need to instantiate MemStoreLAB for master which not carry table
> ---
>
> Key: HBASE-21388
> URL: https://issues.apache.org/jira/browse/HBASE-21388
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-21388.master.001.patch, 
> HBASE-21388.master.002.patch, HBASE-21388.master.003.patch
>
>
> We found this log in our master.
> 2018-10-26,10:00:00,449 INFO 
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] 
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data 
> MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0
> 2018-10-26,10:00:00,452 INFO 
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] 
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index 
> MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0
>  
> Same with HBASE-21290, we don't need to instantiate MemStore for master which 
> not carry table.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table

2018-10-29 Thread Guanghao Zhang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667957#comment-16667957
 ] 

Guanghao Zhang commented on HBASE-21388:


We don't config a special hbase.hregion.memstore.chunkpool.initialsize and the 
default initial count percentage is 0. So the initial count is 0 in the log. 
But this jira's point is not to create any memstore chunk when master not carry 
table. It is useful when master only has a small heap/offheap. We may config 
hbase.hregion.memstore.chunkpool.initialsize for regionserver but we don't want 
master to create memstore chunk, too. Thanks. [~anoop.hbase]

> No need to instantiate MemStoreLAB for master which not carry table
> ---
>
> Key: HBASE-21388
> URL: https://issues.apache.org/jira/browse/HBASE-21388
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-21388.master.001.patch, 
> HBASE-21388.master.002.patch
>
>
> We found this log in our master.
> 2018-10-26,10:00:00,449 INFO 
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] 
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data 
> MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0
> 2018-10-26,10:00:00,452 INFO 
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] 
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index 
> MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0
>  
> Same with HBASE-21290, we don't need to instantiate MemStore for master which 
> not carry table.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table

2018-10-29 Thread Guanghao Zhang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667950#comment-16667950
 ] 

Guanghao Zhang commented on HBASE-21388:


{quote}bq. If initial count comes as >0, those many chunks (Each 2 MB) will be 
created on server starts up itself. But here it is 0. So no worries much.
{quote}
Thanks. Let me check the code. 

> No need to instantiate MemStoreLAB for master which not carry table
> ---
>
> Key: HBASE-21388
> URL: https://issues.apache.org/jira/browse/HBASE-21388
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-21388.master.001.patch, 
> HBASE-21388.master.002.patch
>
>
> We found this log in our master.
> 2018-10-26,10:00:00,449 INFO 
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] 
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data 
> MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0
> 2018-10-26,10:00:00,452 INFO 
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] 
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index 
> MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0
>  
> Same with HBASE-21290, we don't need to instantiate MemStore for master which 
> not carry table.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface

2018-10-29 Thread Josh Elser (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667936#comment-16667936
 ] 

Josh Elser commented on HBASE-21246:


My take overall: seems like the changes are largely equivalent to 
s/Path/WALIdentity/ which is good. I'm not yet convinced that there still isn't 
more unwinding of {{Path}} to be done. I feel like I'm missing a critical piece 
of the picture, but I just need to look more closely.

Consolidating all of the "dirt" on implementations of WALProvider is really 
nice (separate HDFS code out of the guts of everything else), but we have lots 
of code like {{provider.createWALIdentity(p.toString())}} now. I wonder if 
there's something to be had for asking for WALIdentities from {{WALProvider}} 
via {{ServerName}} or {{RegionInfo}} rather than creating them by hand? Need to 
find the time to look more closely...

Another over-arching is theme is that I'd like WALFactory to move away from the 
static methods and just use the non-static equivalents on WALProvider. I 
understand that's probably a WIP (not the immediate goal here).

{code}
@@ -4699,7 +4708,8 @@ public class HRegion implements HeapSize, 
PropagatingConfigurationObserver, Regi
 status.setStatus("Opening recovered edits");
 WAL.Reader reader = null;
 try {
-  reader = WALFactory.createReader(fs, edits, conf);
+  reader = 
walProvider.createReader(walProvider.createWALIdentity(edits.toString()), null,
+  true);
{code}

Is this fully thought out: how does HRegion get the {{Path}} in the first 
place? This still banks on the assumption that recovered.edits are always on 
the storefile FS? (see below caveat on this one too).

{{hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java}},
 why not pass in WALProvider instead of WALFactory? Doesn't look like 
WALFactory is used by SplitLogWorker in any other fashion than to obtain a 
WALProvider instance.

{code}
-  public static class LogsComparator implements Comparator {
-
+  public static class LogsComparator implements Comparator {
+private static final Pattern WAL_FILE_NAME_PATTERN =
+Pattern.compile("(.+)\\.(\\d+)(\\.[0-9A-Za-z]+)?");
 @Override
-public int compare(Path o1, Path o2) {
+public int compare(WALIdentity o1, WALIdentity o2) {
   return Long.compare(getTS(o1), getTS(o2));
 }
 
+private long getTS(WALIdentity id) {
+  Matcher matcher = WAL_FILE_NAME_PATTERN.matcher(id.getName());
+  if (matcher.matches()) {
+return Long.parseLong(matcher.group(2), 2);
+  } else {
+throw new IllegalArgumentException(id.getName() + " is not a valid wal 
file name");
+  }
+}
{code}

This depends on the WALs having a specific name which is a smell. This is 
extracting the creation time, right? I would think a method on WALProvider to 
get this information would be better than relying on a specific naming.

{code}
--- 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceFactory.java
+++ 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceFactory.java
@@ -47,7 +47,7 @@ public class ReplicationSourceFactory {
   LOG.warn("Passed replication source implementation throws errors, "
   + "defaulting to ReplicationSource",
 e);
-  src = isQueueRecovered ? new RecoveredReplicationSource() : new 
ReplicationSource();
+  src = isQueueRecovered ? new FSRecoveredReplicationSource() : new 
ReplicationSource();
{code}

IIRC, the plan was to have recovered edits on the filesystem (even if the WALs 
are elsewhere). Two thoughts: first, we will have to look at Stephen Wu's 
latest changes around here to make sure we aren't breaking what he and Zach are 
doing; second, I could see a day where we need indirection around 
recovered.edits. I don't think we have to tackle that now, but something to 
keep in mind...

{code}
@@ -485,7 +492,8 @@ public class ReplicationSourceManager implements 
ReplicationListener {
 toRemove.terminate(terminateMessage);
   }
   for (NavigableSet walsByGroup : walsById.get(peerId).values()) {
-walsByGroup.forEach(wal -> src.enqueueLog(new Path(this.logDir, wal)));
+walsByGroup.forEach(wal -> src.enqueueLog(
+
((SyncReplicationWALProvider)this.walProvider).getFullPath(serverName, wal)));
   }
{code}
{code}
-  src.enqueueLog(new Path(oldLogDir, wal));
+  WALIdentity archivedWal = 
((SyncReplicationWALProvider)walProvider)
+  .getWalFromArchivePath(wal);
+  if (archivedWal != null) {
+src.enqueueLog(archivedWal);
+  }
{code}

Is this somethign that needs to be addressed? You couldn't possibly know that 
this is a {{SyncReplicationWALProvider}}? (could you?)

{code}
+  @Override
+  public WALIdentity

[jira] [Commented] (HBASE-21375) Revisit the lock and queue implementation in MasterProcedureScheduler

2018-10-29 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667922#comment-16667922
 ] 

Hudson commented on HBASE-21375:


Results for branch branch-2
[build #1463 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1463/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1463//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1463//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1463//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Revisit the lock and queue implementation in MasterProcedureScheduler
> -
>
> Key: HBASE-21375
> URL: https://issues.apache.org/jira/browse/HBASE-21375
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21375-UT.patch, HBASE-21375-UT2.patch, 
> HBASE-21375-v1.patch, HBASE-21375-v2.patch, HBASE-21375.patch
>
>
> The problem for the old implementation is that we will only check the first 
> procedure in a queue to see if it could run, if it can not, we will remove 
> the queue from run queue. So when adding procedure to the scheduler, we have 
> to try hard to put the procedure which can be executed in front of the queue, 
> if there are corner cases where we fail to do so, it will likely lead to a 
> dead lock, that's why we have the tricky code when loading procedures and try 
> to add them into the scheduler, and also lots of 'if' in the doAdd method of 
> MasterProcedureScheduler. But this is still not enough to make things right, 
> so finally [~allan163] and I decided to change the logic in doPoll method, 
> where we use a loop to find whether there is a procedure can be executed, not 
> only the first one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21375) Revisit the lock and queue implementation in MasterProcedureScheduler

2018-10-29 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667916#comment-16667916
 ] 

Hudson commented on HBASE-21375:


Results for branch branch-2.1
[build #554 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/554/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/554//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/554//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/554//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Revisit the lock and queue implementation in MasterProcedureScheduler
> -
>
> Key: HBASE-21375
> URL: https://issues.apache.org/jira/browse/HBASE-21375
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21375-UT.patch, HBASE-21375-UT2.patch, 
> HBASE-21375-v1.patch, HBASE-21375-v2.patch, HBASE-21375.patch
>
>
> The problem for the old implementation is that we will only check the first 
> procedure in a queue to see if it could run, if it can not, we will remove 
> the queue from run queue. So when adding procedure to the scheduler, we have 
> to try hard to put the procedure which can be executed in front of the queue, 
> if there are corner cases where we fail to do so, it will likely lead to a 
> dead lock, that's why we have the tricky code when loading procedures and try 
> to add them into the scheduler, and also lots of 'if' in the doAdd method of 
> MasterProcedureScheduler. But this is still not enough to make things right, 
> so finally [~allan163] and I decided to change the logic in doPoll method, 
> where we use a loop to find whether there is a procedure can be executed, not 
> only the first one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21375) Revisit the lock and queue implementation in MasterProcedureScheduler

2018-10-29 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667867#comment-16667867
 ] 

Hudson commented on HBASE-21375:


Results for branch branch-2.0
[build #1034 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1034/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1034//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1034//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1034//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Revisit the lock and queue implementation in MasterProcedureScheduler
> -
>
> Key: HBASE-21375
> URL: https://issues.apache.org/jira/browse/HBASE-21375
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21375-UT.patch, HBASE-21375-UT2.patch, 
> HBASE-21375-v1.patch, HBASE-21375-v2.patch, HBASE-21375.patch
>
>
> The problem for the old implementation is that we will only check the first 
> procedure in a queue to see if it could run, if it can not, we will remove 
> the queue from run queue. So when adding procedure to the scheduler, we have 
> to try hard to put the procedure which can be executed in front of the queue, 
> if there are corner cases where we fail to do so, it will likely lead to a 
> dead lock, that's why we have the tricky code when loading procedures and try 
> to add them into the scheduler, and also lots of 'if' in the doAdd method of 
> MasterProcedureScheduler. But this is still not enough to make things right, 
> so finally [~allan163] and I decided to change the logic in doPoll method, 
> where we use a loop to find whether there is a procedure can be executed, not 
> only the first one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21404) Master/RS navbar active state does not work

2018-10-29 Thread Hadoop QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667838#comment-16667838
 ] 

Hadoop QA commented on HBASE-21404:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  4s{color} 
| {color:red} HBASE-21404 does not apply to master. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.8.0/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-21404 |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/14896/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Affects Versions: 3.0.0, 2.0.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-21404.master.001.patch, master_after_patch.png, 
> master_before.png, rs_after_patch.png, rs_before.png
>
>
> In master/rs web UI, the current active tab is not updated when user switches 
> to any tab other than "Home" tab.
> For example: even though say if we are on "tabledetailed.jsp", the navbar 
> does not update the active state of that tab. See master_before.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21371) Hbase unable to compile against Hadoop trunk (3.3.0-SNAPSHOT) due to license error

2018-10-29 Thread stack (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-21371:
--
   Resolution: Fixed
 Hadoop Flags: Reviewed
Fix Version/s: 2.1.2
   2.0.3
   2.2.0
   3.0.0
   Status: Resolved  (was: Patch Available)

Pushed to branch-2.0+

FYI [~busbey] Shout when back if I got this wrong.

> Hbase unable to compile against Hadoop trunk (3.3.0-SNAPSHOT) due to license 
> error
> --
>
> Key: HBASE-21371
> URL: https://issues.apache.org/jira/browse/HBASE-21371
> Project: HBase
>  Issue Type: Bug
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21371.master.001.patch
>
>
> Hadoop 3.3.0 (trunk) updated various dependencies, which adds additional 
> licenses that break HBase's license check plugin.
> CDDL/GPLv2+CE license
> {quote}This product includes JavaBeans Activation Framework API jar licensed 
> under the CDDL/GPLv2+CE.
> CDDL or GPL version 2 plus the Classpath Exception
>  ERROR: Please check  this License for acceptability here:
> [https://www.apache.org/legal/resolved]
> If it is okay, then update the list named 'non_aggregate_fine' in the 
> LICENSE.vm file.
>  If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> javax.activation
>  javax.activation-api
>  1.2.0
> maven central search
>  g:javax.activation AND a:javax.activation-api AND v:1.2.0
> project website
>  [http://java.net/all/javax.activation-api/]
>  project source
>  [https://github.com/javaee/activation/javax.activation-api]
> {quote}
> Bouncy Castle License 
> {quote}–
>  This product includes Bouncy Castle PKIX, CMS, EAC, TSP, PKCS, OCSP, CMP, 
> and CRMF APIs licensed under the Bouncy Castle Licence.
> ERROR: Please check  this License for acceptability here:
> [https://www.apache.org/legal/resolved]
> If it is okay, then update the list named 'non_aggregate_fine' in the 
> LICENSE.vm file.
>  If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> org.bouncycastle
>  bcpkix-jdk15on
>  1.60
> maven central search
>  g:org.bouncycastle AND a:bcpkix-jdk15on AND v:1.60
> project website
>  [http://www.bouncycastle.org/java.html]
>  project source
>  [https://github.com/bcgit/bc-java]
>  –
> {quote}
>  
> And a long list of "Apache Software License - Version 2.0" licensed Jetty 
> dependencies like this:
> {quote}
> This product includes Jetty :: Servlet Annotations licensed under the Apache 
> Software License - Version 2.0.
> ERROR: Please check  this License for acceptability here:
> [https://www.apache.org/legal/resolved]
> If it is okay, then update the list named 'non_aggregate_fine' in the 
> LICENSE.vm file.
>  If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> org.eclipse.jetty
>  jetty-annotations
>  9.3.19.v20170502
> maven central search
>  g:org.eclipse.jetty AND a:jetty-annotations AND v:9.3.19.v20170502
> project website
>  [http://www.eclipse.org/jetty]
>  project source
>  [https://github.com/eclipse/jetty.project/jetty-annotations]
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21404) Master/RS navbar active state does not work

2018-10-29 Thread Nihal Jain (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667750#comment-16667750
 ] 

Nihal Jain commented on HBASE-21404:


Submitted a patch with the fix: Now the active state of tab is updated as 
expected. Please review.

> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Affects Versions: 3.0.0, 2.0.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-21404.master.001.patch, master_after_patch.png, 
> master_before.png, rs_after_patch.png, rs_before.png
>
>
> In master/rs web UI, the current active tab is not updated when user switches 
> to any tab other than "Home" tab.
> For example: even though say if we are on "tabledetailed.jsp", the navbar 
> does not update the active state of that tab. See master_before.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21404) Master/RS navbar active state does not work

2018-10-29 Thread Nihal Jain (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nihal Jain updated HBASE-21404:
---
Fix Version/s: 3.0.0
Affects Version/s: 3.0.0
   2.0.0
   Status: Patch Available  (was: In Progress)

> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-21404.master.001.patch, master_after_patch.png, 
> master_before.png, rs_after_patch.png, rs_before.png
>
>
> In master/rs web UI, the current active tab is not updated when user switches 
> to any tab other than "Home" tab.
> For example: even though say if we are on "tabledetailed.jsp", the navbar 
> does not update the active state of that tab. See master_before.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21247) Custom WAL Provider cannot be specified by configuration whose value is outside the enums in Providers

2018-10-29 Thread Ted Yu (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667748#comment-16667748
 ] 

Ted Yu commented on HBASE-21247:


Gentle ping [~busbey]

> Custom WAL Provider cannot be specified by configuration whose value is 
> outside the enums in Providers
> --
>
> Key: HBASE-21247
> URL: https://issues.apache.org/jira/browse/HBASE-21247
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: 21247.v1.txt, 21247.v10.txt, 21247.v11.txt, 
> 21247.v2.txt, 21247.v3.txt, 21247.v4.tst, 21247.v4.txt, 21247.v5.txt, 
> 21247.v6.txt, 21247.v7.txt, 21247.v8.txt, 21247.v9.txt
>
>
> Currently all the WAL Providers acceptable to hbase are specified in 
> Providers enum of WALFactory.
> This restricts the ability for additional WAL Providers to be supplied - by 
> class name.
> This issue fixes the bug by allowing the specification of new WAL Provider 
> class name using the config "hbase.wal.provider".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21404) Master/RS navbar active state does not work

2018-10-29 Thread Nihal Jain (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nihal Jain updated HBASE-21404:
---
Attachment: master_after_patch.png

> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Attachments: HBASE-21404.master.001.patch, master_after_patch.png, 
> master_before.png, rs_after_patch.png, rs_before.png
>
>
> In master/rs web UI, the current active tab is not updated when user switches 
> to any tab other than "Home" tab.
> For example: even though say if we are on "tabledetailed.jsp", the navbar 
> does not update the active state of that tab. See master_before.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21404) Master/RS navbar active state does not work

2018-10-29 Thread Nihal Jain (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nihal Jain updated HBASE-21404:
---
Attachment: rs_after_patch.png

> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Attachments: HBASE-21404.master.001.patch, master_after_patch.png, 
> master_before.png, rs_after_patch.png, rs_before.png
>
>
> In master/rs web UI, the current active tab is not updated when user switches 
> to any tab other than "Home" tab.
> For example: even though say if we are on "tabledetailed.jsp", the navbar 
> does not update the active state of that tab. See master_before.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21404) Master/RS navbar active state does not work

2018-10-29 Thread Nihal Jain (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nihal Jain updated HBASE-21404:
---
Attachment: HBASE-21404.master.001.patch

> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Attachments: HBASE-21404.master.001.patch, master_before.png, 
> rs_before.png
>
>
> In master/rs web UI, the current active tab is not updated when user switches 
> to any tab other than "Home" tab.
> For example: even though say if we are on "tabledetailed.jsp", the navbar 
> does not update the active state of that tab. See master_before.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21404) Master/RS navbar active state does not work

2018-10-29 Thread Nihal Jain (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nihal Jain updated HBASE-21404:
---
Attachment: rs_before.png

> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Attachments: master_before.png, rs_before.png
>
>
> In master/rs web UI, the current active tab is not updated when user switches 
> to any tab other than "Home" tab.
> For example: even though say if we are on "tabledetailed.jsp", the navbar 
> does not update the active state of that tab. See master_before.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21404) Master/RS navbar active state does not work

2018-10-29 Thread Nihal Jain (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nihal Jain updated HBASE-21404:
---
Attachment: (was: master_after.png)

> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Attachments: master_before.png
>
>
> In master/rs web UI, the current active tab is not updated when user switches 
> to any tab other than "Home" tab.
> For example: even though say if we are on "tabledetailed.jsp", the navbar 
> does not update the active state of that tab. See master_before.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21404) Master/RS navbar active state does not work

2018-10-29 Thread Nihal Jain (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nihal Jain updated HBASE-21404:
---
Description: 
In master/rs web UI, the current active tab is not updated when user switches 
to any tab other than "Home" tab.

For example: even though say if we are on "tabledetailed.jsp", the navbar does 
not update the active state of that tab. See  !master_before.png!

> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Reporter: Nihal Jain
>Priority: Minor
> Attachments: master_after.png, master_before.png
>
>
> In master/rs web UI, the current active tab is not updated when user switches 
> to any tab other than "Home" tab.
> For example: even though say if we are on "tabledetailed.jsp", the navbar 
> does not update the active state of that tab. See  !master_before.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work started] (HBASE-21404) Master/RS navbar active state does not work

2018-10-29 Thread Nihal Jain (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-21404 started by Nihal Jain.
--
> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Attachments: master_after.png, master_before.png
>
>
> In master/rs web UI, the current active tab is not updated when user switches 
> to any tab other than "Home" tab.
> For example: even though say if we are on "tabledetailed.jsp", the navbar 
> does not update the active state of that tab. See master_before.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21404) Master/RS navbar active state does not work

2018-10-29 Thread Nihal Jain (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nihal Jain updated HBASE-21404:
---
Description: 
In master/rs web UI, the current active tab is not updated when user switches 
to any tab other than "Home" tab.

For example: even though say if we are on "tabledetailed.jsp", the navbar does 
not update the active state of that tab. See master_before.png

  was:
In master/rs web UI, the current active tab is not updated when user switches 
to any tab other than "Home" tab.

For example: even though say if we are on "tabledetailed.jsp", the navbar does 
not update the active state of that tab. See  !master_before.png!


> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Reporter: Nihal Jain
>Priority: Minor
> Attachments: master_after.png, master_before.png
>
>
> In master/rs web UI, the current active tab is not updated when user switches 
> to any tab other than "Home" tab.
> For example: even though say if we are on "tabledetailed.jsp", the navbar 
> does not update the active state of that tab. See master_before.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (HBASE-21404) Master/RS navbar active state does not work

2018-10-29 Thread Nihal Jain (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nihal Jain reassigned HBASE-21404:
--

Assignee: Nihal Jain

> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Attachments: master_after.png, master_before.png
>
>
> In master/rs web UI, the current active tab is not updated when user switches 
> to any tab other than "Home" tab.
> For example: even though say if we are on "tabledetailed.jsp", the navbar 
> does not update the active state of that tab. See master_before.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21404) Master/RS navbar active state does not work

2018-10-29 Thread Nihal Jain (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nihal Jain updated HBASE-21404:
---
Attachment: master_after.png

> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Reporter: Nihal Jain
>Priority: Minor
> Attachments: master_after.png, master_before.png
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HBASE-21404) Master/RS navbar active state does not work

2018-10-29 Thread Nihal Jain (JIRA)

Nihal Jain created HBASE-21404:
--

 Summary: Master/RS navbar active state does not work
 Key: HBASE-21404
 URL: https://issues.apache.org/jira/browse/HBASE-21404
 Project: HBase
  Issue Type: Bug
  Components: UI
Reporter: Nihal Jain
 Attachments: master_after.png, master_before.png





--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21404) Master/RS navbar active state does not work

2018-10-29 Thread Nihal Jain (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nihal Jain updated HBASE-21404:
---
Attachment: master_before.png

> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Reporter: Nihal Jain
>Priority: Minor
> Attachments: master_after.png, master_before.png
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (HBASE-21180) findbugs incurs DataflowAnalysisException for hbase-server module

2018-10-29 Thread Ted Yu (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu resolved HBASE-21180.

Resolution: Cannot Reproduce

> findbugs incurs DataflowAnalysisException for hbase-server module
> -
>
> Key: HBASE-21180
> URL: https://issues.apache.org/jira/browse/HBASE-21180
> Project: HBase
>  Issue Type: Task
>Reporter: Ted Yu
>Priority: Minor
>
> Running findbugs, I noticed the following in hbase-server module:
> {code}
> [INFO] --- findbugs-maven-plugin:3.0.4:findbugs (default-cli) @ hbase-server 
> ---
> [INFO] Fork Value is true
>  [java] The following errors occurred during analysis:
>  [java]   Error generating derefs for 
> org.apache.hadoop.hbase.generated.master.table_jsp._jspService(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V
>  [java] edu.umd.cs.findbugs.ba.DataflowAnalysisException: can't get 
> position -1 of stack
>  [java]   At 
> edu.umd.cs.findbugs.ba.Frame.getStackValue(Frame.java:250)
>  [java]   At 
> edu.umd.cs.findbugs.ba.Hierarchy.resolveMethodCallTargets(Hierarchy.java:743)
>  [java]   At 
> edu.umd.cs.findbugs.ba.npe.DerefFinder.getAnalysis(DerefFinder.java:141)
>  [java]   At 
> edu.umd.cs.findbugs.classfile.engine.bcel.UsagesRequiringNonNullValuesFactory.analyze(UsagesRequiringNonNullValuesFactory.java:50)
>  [java]   At 
> edu.umd.cs.findbugs.classfile.engine.bcel.UsagesRequiringNonNullValuesFactory.analyze(UsagesRequiringNonNullValuesFactory.java:31)
>  [java]   At 
> edu.umd.cs.findbugs.classfile.impl.AnalysisCache.analyzeMethod(AnalysisCache.java:369)
>  [java]   At 
> edu.umd.cs.findbugs.classfile.impl.AnalysisCache.getMethodAnalysis(AnalysisCache.java:322)
>  [java]   At 
> edu.umd.cs.findbugs.ba.ClassContext.getMethodAnalysis(ClassContext.java:1005)
>  [java]   At 
> edu.umd.cs.findbugs.ba.ClassContext.getUsagesRequiringNonNullValues(ClassContext.java:325)
>  [java]   At 
> edu.umd.cs.findbugs.detect.FindNullDeref.foundGuaranteedNullDeref(FindNullDeref.java:1510)
>  [java]   At 
> edu.umd.cs.findbugs.ba.npe.NullDerefAndRedundantComparisonFinder.reportBugs(NullDerefAndRedundantComparisonFinder.java:361)
>  [java]   At 
> edu.umd.cs.findbugs.ba.npe.NullDerefAndRedundantComparisonFinder.examineNullValues(NullDerefAndRedundantComparisonFinder.java:266)
>  [java]   At 
> edu.umd.cs.findbugs.ba.npe.NullDerefAndRedundantComparisonFinder.execute(NullDerefAndRedundantComparisonFinder.java:164)
>  [java]   At 
> edu.umd.cs.findbugs.detect.FindNullDeref.analyzeMethod(FindNullDeref.java:278)
>  [java]   At 
> edu.umd.cs.findbugs.detect.FindNullDeref.visitClassContext(FindNullDeref.java:209)
>  [java]   At 
> edu.umd.cs.findbugs.DetectorToDetector2Adapter.visitClass(DetectorToDetector2Adapter.java:76)
>  [java]   At 
> edu.umd.cs.findbugs.FindBugs2.analyzeApplication(FindBugs2.java:1089)
>  [java]   At edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:283)
>  [java]   At edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:393)
>  [java]   At edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1200)
>  [java] The following classes needed for analysis were missing:
>  [java]   accept
>  [java]   apply
>  [java]   run
>  [java]   test
>  [java]   call
>  [java]   exec
>  [java]   getAsInt
>  [java]   applyAsLong
>  [java]   storeFile
>  [java]   get
>  [java]   visit
>  [java]   compare
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21396) Create 2.1.1 release

2018-10-29 Thread stack (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667664#comment-16667664
 ] 

stack commented on HBASE-21396:
---

 * Tagged b60a92d6864ef27295027f5961cb46f9162d7637 as 2.1.1RC0 (Will push 
later).
 * Ran the make_rc.sh script.
 * Tried out the product; made sure I could build from src tarball and checked 
out bin tarball layout, ran it, loaded it, checked data loaded.
 * Signed it
 * Generated compat report: ./dev-support/checkcompatibility.py --annotation 
org.apache.hadoop.hbase.classification.InterfaceAudience.Public rel/2.1.0 
2.1.1RC0
 * Checked out release up on repository.apache.org in staging.. then closed the 
repo.
 * Pushed 2.1.1RC0 to remote
 * Sent out VOTE email.

> Create 2.1.1 release
> 
>
> Key: HBASE-21396
> URL: https://issues.apache.org/jira/browse/HBASE-21396
> Project: HBase
>  Issue Type: Task
>  Components: rm
>Reporter: stack
>Assignee: stack
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21378) [hbck2] add --skip version check to hbck2 tool (checkHBCKSupport blocks assigning hbase:meta or hbase:namespace when master is not initialized)

2018-10-29 Thread stack (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-21378:
--
Release Note: 
Adds a general -s,--skip option to hbck2 so you can run the command it first 
checking it is version compatible.

Should not be needed going forward but in the spirt of our not knowing all the 
conditions under which we'll be trying to run hbck2, adding it.

> [hbck2] add --skip version check to hbck2 tool (checkHBCKSupport blocks 
> assigning hbase:meta or hbase:namespace when master is not initialized)
> ---
>
> Key: HBASE-21378
> URL: https://issues.apache.org/jira/browse/HBASE-21378
> Project: HBase
>  Issue Type: Bug
>  Components: hbase-operator-tools, hbck2
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Fix For: hbck2-1.0.0
>
> Attachments: 
> 0001-HBASE-21378-hbck2-checkHBCKSupport-blocks-assigning-.patch
>
>
> When I encounter the scenario that hbase:namespace is not online.
> {code}
> 2018-10-24,14:38:16,910 WARN org.apache.hadoop.hbase.master.HMaster: 
> hbase:namespace,,1529933109115.7e0801c8232b2dc15face54532056076. is NOT 
> online; state={7e0801c8232b2dc15face54532056076 state=OPEN, ts=1540363033384, 
> server=c4-hadoop-tst-st30.bj,29100,1540348649479}; 
> ServerCrashProcedures=false. Master startup cannot progress, in 
> holding-pattern until region onlined.
> {code}
> Then I tried to assign it manually, but it throws PleaseHoldException.
> {code}
> Wed Oct 24 15:26:52 CST 2018, 
> RpcRetryingCaller{globalStartTime=1540365754487, pause=200, maxAttempts=16}, 
> org.apache.hadoop.hbase.PleaseHoldException: 
> org.apache.hadoop.hbase.PleaseHoldException: Master is initializing
>   at 
> org.apache.hadoop.hbase.master.HMaster.checkInitialized(HMaster.java:3064)
>   at 
> org.apache.hadoop.hbase.master.MasterRpcServices.getClusterStatus(MasterRpcServices.java:934)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
>   at 
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:144)
>   at 
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3133)
>   at 
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3125)
>   at 
> org.apache.hadoop.hbase.client.HBaseAdmin.getClusterMetrics(HBaseAdmin.java:2161)
>   at org.apache.hbase.HBCK2.checkHBCKSupport(HBCK2.java:98)
>   at org.apache.hbase.HBCK2.run(HBCK2.java:364)
>   at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
>   at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
>   at org.apache.hbase.HBCK2.main(HBCK2.java:447)
> Caused by: org.apache.hadoop.hbase.PleaseHoldException: 
> org.apache.hadoop.hbase.PleaseHoldException: Master is initializing
>   at 
> org.apache.hadoop.hbase.master.HMaster.checkInitialized(HMaster.java:3064)
>   at 
> org.apache.hadoop.hbase.master.MasterRpcServices.getClusterStatus(MasterRpcServices.java:934)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>   at 
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.instantiateException(RemoteWithExtrasException.java:100)
>   at 
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.unwrapRemoteException(RemoteWithExtrasException.java:90)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.makeIOExceptionOfException(ProtobufUtil.java:361)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.handleRemoteException(ProtobufUtil.java:349)
>

[jira] [Updated] (HBASE-21378) [hbck2] add --skip version check to hbck2 tool (checkHBCKSupport blocks assigning hbase:meta or hbase:namespace when master is not initialized)

2018-10-29 Thread stack (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-21378:
--
Summary: [hbck2] add --skip version check to hbck2 tool (checkHBCKSupport 
blocks assigning hbase:meta or hbase:namespace when master is not initialized)  
(was: [hbck2] checkHBCKSupport blocks assigning hbase:meta or hbase:namespace 
when master is not initialized)

> [hbck2] add --skip version check to hbck2 tool (checkHBCKSupport blocks 
> assigning hbase:meta or hbase:namespace when master is not initialized)
> ---
>
> Key: HBASE-21378
> URL: https://issues.apache.org/jira/browse/HBASE-21378
> Project: HBase
>  Issue Type: Bug
>  Components: hbase-operator-tools, hbck2
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Fix For: hbck2-1.0.0
>
> Attachments: 
> 0001-HBASE-21378-hbck2-checkHBCKSupport-blocks-assigning-.patch
>
>
> When I encounter the scenario that hbase:namespace is not online.
> {code}
> 2018-10-24,14:38:16,910 WARN org.apache.hadoop.hbase.master.HMaster: 
> hbase:namespace,,1529933109115.7e0801c8232b2dc15face54532056076. is NOT 
> online; state={7e0801c8232b2dc15face54532056076 state=OPEN, ts=1540363033384, 
> server=c4-hadoop-tst-st30.bj,29100,1540348649479}; 
> ServerCrashProcedures=false. Master startup cannot progress, in 
> holding-pattern until region onlined.
> {code}
> Then I tried to assign it manually, but it throws PleaseHoldException.
> {code}
> Wed Oct 24 15:26:52 CST 2018, 
> RpcRetryingCaller{globalStartTime=1540365754487, pause=200, maxAttempts=16}, 
> org.apache.hadoop.hbase.PleaseHoldException: 
> org.apache.hadoop.hbase.PleaseHoldException: Master is initializing
>   at 
> org.apache.hadoop.hbase.master.HMaster.checkInitialized(HMaster.java:3064)
>   at 
> org.apache.hadoop.hbase.master.MasterRpcServices.getClusterStatus(MasterRpcServices.java:934)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
>   at 
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:144)
>   at 
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3133)
>   at 
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3125)
>   at 
> org.apache.hadoop.hbase.client.HBaseAdmin.getClusterMetrics(HBaseAdmin.java:2161)
>   at org.apache.hbase.HBCK2.checkHBCKSupport(HBCK2.java:98)
>   at org.apache.hbase.HBCK2.run(HBCK2.java:364)
>   at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
>   at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
>   at org.apache.hbase.HBCK2.main(HBCK2.java:447)
> Caused by: org.apache.hadoop.hbase.PleaseHoldException: 
> org.apache.hadoop.hbase.PleaseHoldException: Master is initializing
>   at 
> org.apache.hadoop.hbase.master.HMaster.checkInitialized(HMaster.java:3064)
>   at 
> org.apache.hadoop.hbase.master.MasterRpcServices.getClusterStatus(MasterRpcServices.java:934)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>   at 
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.instantiateException(RemoteWithExtrasException.java:100)
>   at 
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.unwrapRemoteException(RemoteWithExtrasException.java:90)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.makeIOExceptionOfException(ProtobufUtil.java:361)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.handleRemoteException(ProtobufUtil.java:349)
>

[jira] [Updated] (HBASE-21246) Introduce WALIdentity interface

2018-10-29 Thread Ted Yu (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-21246:
---
Attachment: 21246.20.txt

> Introduce WALIdentity interface
> ---
>
> Key: HBASE-21246
> URL: https://issues.apache.org/jira/browse/HBASE-21246
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Major
> Fix For: HBASE-20952
>
> Attachments: 21246.003.patch, 21246.20.txt, 
> 21246.HBASE-20952.001.patch, 21246.HBASE-20952.002.patch, 
> 21246.HBASE-20952.004.patch, 21246.HBASE-20952.005.patch, 
> 21246.HBASE-20952.007.patch, 21246.HBASE-20952.008.patch
>
>
> We are introducing WALIdentity interface so that the WAL representation can 
> be decoupled from distributed filesystem.
> The interface provides getName method whose return value can represent 
> filename in distributed filesystem environment or, the name of the stream 
> when the WAL is backed by log stream.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21246) Introduce WALIdentity interface

2018-10-29 Thread Ted Yu (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-21246:
---
Attachment: (was: 21246.20.txt)

> Introduce WALIdentity interface
> ---
>
> Key: HBASE-21246
> URL: https://issues.apache.org/jira/browse/HBASE-21246
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Major
> Fix For: HBASE-20952
>
> Attachments: 21246.003.patch, 21246.20.txt, 
> 21246.HBASE-20952.001.patch, 21246.HBASE-20952.002.patch, 
> 21246.HBASE-20952.004.patch, 21246.HBASE-20952.005.patch, 
> 21246.HBASE-20952.007.patch, 21246.HBASE-20952.008.patch
>
>
> We are introducing WALIdentity interface so that the WAL representation can 
> be decoupled from distributed filesystem.
> The interface provides getName method whose return value can represent 
> filename in distributed filesystem environment or, the name of the stream 
> when the WAL is backed by log stream.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21371) Hbase unable to compile against Hadoop trunk (3.3.0-SNAPSHOT) due to license error

2018-10-29 Thread stack (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667561#comment-16667561
 ] 

stack commented on HBASE-21371:
---

Patch looks great to me. I'm not the expert here though. Our Sean is out for a 
few days. I could commit it tomorrow or we could wait till he's back or I could 
commit and he could shout at me when he's back too. Anyone else have an opinon 
here? [~elserj] ? [~apurt...@yahoo.com]? Thanks.

> Hbase unable to compile against Hadoop trunk (3.3.0-SNAPSHOT) due to license 
> error
> --
>
> Key: HBASE-21371
> URL: https://issues.apache.org/jira/browse/HBASE-21371
> Project: HBase
>  Issue Type: Bug
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Attachments: HBASE-21371.master.001.patch
>
>
> Hadoop 3.3.0 (trunk) updated various dependencies, which adds additional 
> licenses that break HBase's license check plugin.
> CDDL/GPLv2+CE license
> {quote}This product includes JavaBeans Activation Framework API jar licensed 
> under the CDDL/GPLv2+CE.
> CDDL or GPL version 2 plus the Classpath Exception
>  ERROR: Please check  this License for acceptability here:
> [https://www.apache.org/legal/resolved]
> If it is okay, then update the list named 'non_aggregate_fine' in the 
> LICENSE.vm file.
>  If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> javax.activation
>  javax.activation-api
>  1.2.0
> maven central search
>  g:javax.activation AND a:javax.activation-api AND v:1.2.0
> project website
>  [http://java.net/all/javax.activation-api/]
>  project source
>  [https://github.com/javaee/activation/javax.activation-api]
> {quote}
> Bouncy Castle License 
> {quote}–
>  This product includes Bouncy Castle PKIX, CMS, EAC, TSP, PKCS, OCSP, CMP, 
> and CRMF APIs licensed under the Bouncy Castle Licence.
> ERROR: Please check  this License for acceptability here:
> [https://www.apache.org/legal/resolved]
> If it is okay, then update the list named 'non_aggregate_fine' in the 
> LICENSE.vm file.
>  If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> org.bouncycastle
>  bcpkix-jdk15on
>  1.60
> maven central search
>  g:org.bouncycastle AND a:bcpkix-jdk15on AND v:1.60
> project website
>  [http://www.bouncycastle.org/java.html]
>  project source
>  [https://github.com/bcgit/bc-java]
>  –
> {quote}
>  
> And a long list of "Apache Software License - Version 2.0" licensed Jetty 
> dependencies like this:
> {quote}
> This product includes Jetty :: Servlet Annotations licensed under the Apache 
> Software License - Version 2.0.
> ERROR: Please check  this License for acceptability here:
> [https://www.apache.org/legal/resolved]
> If it is okay, then update the list named 'non_aggregate_fine' in the 
> LICENSE.vm file.
>  If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> org.eclipse.jetty
>  jetty-annotations
>  9.3.19.v20170502
> maven central search
>  g:org.eclipse.jetty AND a:jetty-annotations AND v:9.3.19.v20170502
> project website
>  [http://www.eclipse.org/jetty]
>  project source
>  [https://github.com/eclipse/jetty.project/jetty-annotations]
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HBASE-21403) Give sort arrows on Master UI some attention...

2018-10-29 Thread stack (JIRA)

stack created HBASE-21403:
-

 Summary: Give sort arrows on Master UI some attention...
 Key: HBASE-21403
 URL: https://issues.apache.org/jira/browse/HBASE-21403
 Project: HBase
  Issue Type: Sub-task
  Components: UI
Reporter: stack


Parent issue added some helpful sort functionality to the Master UI. The arrows 
though are a bit small and can crowd the text in the table section in the RIT 
rows. On the revent vote thread, 
http://mail-archives.apache.org/mod_mbox/hbase-dev/201810.mbox/browser, fellas 
were a little confused as to what they were for. This issue is about given them 
a little attention to see if can be made more plain what they are about.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21207) Add client side sorting functionality in master web UI for table and region server details.

2018-10-29 Thread stack (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667488#comment-16667488
 ] 

stack commented on HBASE-21207:
---

Thanks for the nice feature [~archana.katiyar].  I filed a trivial subtask. You 
might have a moment to look at it. The arrows are a little small and may 
confuse. Perhaps you have ideas on how to improve.  Nice addition though.

> Add client side sorting functionality in master web UI for table and region 
> server details.
> ---
>
> Key: HBASE-21207
> URL: https://issues.apache.org/jira/browse/HBASE-21207
> Project: HBase
>  Issue Type: Improvement
>  Components: master, monitoring, UI, Usability
>Reporter: Archana Katiyar
>Assignee: Archana Katiyar
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.8
>
> Attachments: 14926e82-b929-11e8-8bdd-4ce4621f1118.png, 
> 21207.branch-1.addendum.patch, 2724afd8-b929-11e8-8171-8b5b2ba3084e.png, 
> HBASE-21207-branch-1.patch, HBASE-21207-branch-1.v1.patch, 
> HBASE-21207-branch-2.v1.patch, HBASE-21207.patch, HBASE-21207.patch, 
> HBASE-21207.v1.patch, edc5c812-b928-11e8-87e2-ce6396629bbc.png
>
>
> In Master UI, we can see region server details like requests per seconds and 
> number of regions etc. Similarly, for tables also we can see online regions , 
> offline regions.
> It will help ops people in determining hot spotting if we can provide sort 
> functionality in the UI.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-19121) HBCK for AMv2 (A.K.A HBCK2)

2018-10-29 Thread stack (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-19121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667472#comment-16667472
 ] 

stack commented on HBASE-19121:
---

Thank you [~tianjingyun]

> HBCK for AMv2 (A.K.A HBCK2)
> ---
>
> Key: HBASE-19121
> URL: https://issues.apache.org/jira/browse/HBASE-19121
> Project: HBase
>  Issue Type: Umbrella
>  Components: hbck, hbck2
>Reporter: stack
>Assignee: Umesh Agashe
>Priority: Major
> Fix For: hbck2-1.0.0
>
> Attachments: hbase-19121.master.001.patch
>
>
> We don't have an hbck for the new AM. Old hbck may actually do damage going 
> against AMv2.
> Fix.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21395) Abort split/merge procedure if there is a table procedure of the same table going on

2018-10-29 Thread stack (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667469#comment-16667469
 ] 

stack commented on HBASE-21395:
---

+1

Perhaps on commit, add to comment that his is a fix for branch-2.1/branch-2.0 
only? For the folks comparing branches down the road?

> Abort split/merge procedure if there is a table procedure of the same table 
> going on
> 
>
> Key: HBASE-21395
> URL: https://issues.apache.org/jira/browse/HBASE-21395
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.1.0, 2.0.2
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Fix For: 2.0.3, 2.1.2
>
> Attachments: HBASE-21395.branch-2.0.001.patch, 
> HBASE-21395.branch-2.0.002.patch, HBASE-21395.branch-2.0.003.patch, 
> HBASE-21395.branch-2.0.004.patch
>
>
> In my ITBLL, I often see that if split/merge procedure and table 
> procedure(like ModifyTableProcedure) happen at the same time, and since there 
> some race conditions between these two kind of procedures,  causing some 
> serious problems. e.g. the split/merged parent is bought on line by the table 
> procedure or the split merged region making the whole table procedure 
> rollback.
> Talked with [~Apache9] offline today, this kind of problem was solved in 
> branch-2+ since There is a fence that only one RTSP can agianst a single 
> region at the same time.
> To keep out of the mess in branch-2.0 and branch-2.1, I added a simple safe 
> fence in the split/merge procedure: If there is a table procedure going on 
> against the same table, then abort the split/merge procedure. Aborting the 
> split/merge procedure at the beginning of the execution is no big deal, 
> compared with the mess it will cause...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21395) Abort split/merge procedure if there is a table procedure of the same table going on

2018-10-29 Thread stack (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-21395:
--
Fix Version/s: 2.0.3

> Abort split/merge procedure if there is a table procedure of the same table 
> going on
> 
>
> Key: HBASE-21395
> URL: https://issues.apache.org/jira/browse/HBASE-21395
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.1.0, 2.0.2
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Fix For: 2.0.3, 2.1.2
>
> Attachments: HBASE-21395.branch-2.0.001.patch, 
> HBASE-21395.branch-2.0.002.patch, HBASE-21395.branch-2.0.003.patch, 
> HBASE-21395.branch-2.0.004.patch
>
>
> In my ITBLL, I often see that if split/merge procedure and table 
> procedure(like ModifyTableProcedure) happen at the same time, and since there 
> some race conditions between these two kind of procedures,  causing some 
> serious problems. e.g. the split/merged parent is bought on line by the table 
> procedure or the split merged region making the whole table procedure 
> rollback.
> Talked with [~Apache9] offline today, this kind of problem was solved in 
> branch-2+ since There is a fence that only one RTSP can agianst a single 
> region at the same time.
> To keep out of the mess in branch-2.0 and branch-2.1, I added a simple safe 
> fence in the split/merge procedure: If there is a table procedure going on 
> against the same table, then abort the split/merge procedure. Aborting the 
> split/merge procedure at the beginning of the execution is no big deal, 
> compared with the mess it will cause...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21322) Add a scheduleServerCrashProcedure() API to HbckService

2018-10-29 Thread stack (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-21322:
--
Fix Version/s: 2.1.2
   2.0.3
   2.2.0
   3.0.0

> Add a scheduleServerCrashProcedure() API to HbckService
> ---
>
> Key: HBASE-21322
> URL: https://issues.apache.org/jira/browse/HBASE-21322
> Project: HBase
>  Issue Type: Sub-task
>  Components: hbck2
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21322.branch-2.1.001.patch, 
> HBASE-21322.master.001.patch, HBASE-21322.master.002.patch, 
> HBASE-21322.master.003.patch, HBASE-21322.master.004.patch, 
> HBASE-21322.master.005.patch, HBASE-21322.master.006.patch, Screenshot from 
> 2018-10-17 13-35-58.png, Screenshot from 2018-10-17 13-38-41.png, Screenshot 
> from 2018-10-17 13-47-06.png
>
>
> According to my test, if one RS is down, then all procedure logs are deleted, 
> it will lead to that no ServerCrashProcedure is scheduled. And restarting 
> master cannot help. Thus we need to schedule a ServerCrashProcedure manually 
> to solve the problem. I plan to add a scheduleServerCrashProcedure() API to 
> HbckService, then add this API to HBCK2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21322) Add a scheduleServerCrashProcedure() API to HbckService

2018-10-29 Thread stack (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-21322:
--
Component/s: hbck2

> Add a scheduleServerCrashProcedure() API to HbckService
> ---
>
> Key: HBASE-21322
> URL: https://issues.apache.org/jira/browse/HBASE-21322
> Project: HBase
>  Issue Type: Sub-task
>  Components: hbck2
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21322.branch-2.1.001.patch, 
> HBASE-21322.master.001.patch, HBASE-21322.master.002.patch, 
> HBASE-21322.master.003.patch, HBASE-21322.master.004.patch, 
> HBASE-21322.master.005.patch, HBASE-21322.master.006.patch, Screenshot from 
> 2018-10-17 13-35-58.png, Screenshot from 2018-10-17 13-38-41.png, Screenshot 
> from 2018-10-17 13-47-06.png
>
>
> According to my test, if one RS is down, then all procedure logs are deleted, 
> it will lead to that no ServerCrashProcedure is scheduled. And restarting 
> master cannot help. Thus we need to schedule a ServerCrashProcedure manually 
> to solve the problem. I plan to add a scheduleServerCrashProcedure() API to 
> HbckService, then add this API to HBCK2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (HBASE-21378) [hbck2] checkHBCKSupport blocks assigning hbase:meta or hbase:namespace when master is not initialized

2018-10-29 Thread stack (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack resolved HBASE-21378.
---
   Resolution: Fixed
Fix Version/s: hbck2-1.0.0

Pushed on the hbase-operator-tools/hbase-hbck repo. Thanks for the nice patch 
[~tianjingyun]

> [hbck2] checkHBCKSupport blocks assigning hbase:meta or hbase:namespace when 
> master is not initialized
> --
>
> Key: HBASE-21378
> URL: https://issues.apache.org/jira/browse/HBASE-21378
> Project: HBase
>  Issue Type: Bug
>  Components: hbase-operator-tools, hbck2
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Fix For: hbck2-1.0.0
>
> Attachments: 
> 0001-HBASE-21378-hbck2-checkHBCKSupport-blocks-assigning-.patch
>
>
> When I encounter the scenario that hbase:namespace is not online.
> {code}
> 2018-10-24,14:38:16,910 WARN org.apache.hadoop.hbase.master.HMaster: 
> hbase:namespace,,1529933109115.7e0801c8232b2dc15face54532056076. is NOT 
> online; state={7e0801c8232b2dc15face54532056076 state=OPEN, ts=1540363033384, 
> server=c4-hadoop-tst-st30.bj,29100,1540348649479}; 
> ServerCrashProcedures=false. Master startup cannot progress, in 
> holding-pattern until region onlined.
> {code}
> Then I tried to assign it manually, but it throws PleaseHoldException.
> {code}
> Wed Oct 24 15:26:52 CST 2018, 
> RpcRetryingCaller{globalStartTime=1540365754487, pause=200, maxAttempts=16}, 
> org.apache.hadoop.hbase.PleaseHoldException: 
> org.apache.hadoop.hbase.PleaseHoldException: Master is initializing
>   at 
> org.apache.hadoop.hbase.master.HMaster.checkInitialized(HMaster.java:3064)
>   at 
> org.apache.hadoop.hbase.master.MasterRpcServices.getClusterStatus(MasterRpcServices.java:934)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
>   at 
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:144)
>   at 
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3133)
>   at 
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3125)
>   at 
> org.apache.hadoop.hbase.client.HBaseAdmin.getClusterMetrics(HBaseAdmin.java:2161)
>   at org.apache.hbase.HBCK2.checkHBCKSupport(HBCK2.java:98)
>   at org.apache.hbase.HBCK2.run(HBCK2.java:364)
>   at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
>   at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
>   at org.apache.hbase.HBCK2.main(HBCK2.java:447)
> Caused by: org.apache.hadoop.hbase.PleaseHoldException: 
> org.apache.hadoop.hbase.PleaseHoldException: Master is initializing
>   at 
> org.apache.hadoop.hbase.master.HMaster.checkInitialized(HMaster.java:3064)
>   at 
> org.apache.hadoop.hbase.master.MasterRpcServices.getClusterStatus(MasterRpcServices.java:934)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>   at 
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.instantiateException(RemoteWithExtrasException.java:100)
>   at 
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.unwrapRemoteException(RemoteWithExtrasException.java:90)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.makeIOExceptionOfException(ProtobufUtil.java:361)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.handleRemoteException(ProtobufUtil.java:349)
>   at 
> org.apache.hadoop.hbase.client.MasterCallable.call(MasterCallable.java:101)
>   at 
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:107)
>

[jira] [Created] (HBASE-21402) Backport parent "HBASE-21325 Force to terminate regionserver when abort hang in somewhere"

2018-10-29 Thread stack (JIRA)

stack created HBASE-21402:
-

 Summary: Backport parent "HBASE-21325 Force to terminate 
regionserver when abort hang in somewhere"
 Key: HBASE-21402
 URL: https://issues.apache.org/jira/browse/HBASE-21402
 Project: HBase
  Issue Type: Sub-task
Affects Versions: 2.0.3, 2.1.2
Reporter: stack


Backport parent. Looks like good idea for fixing long-standing problem. I can 
do the backport [~zghaobac].  Just FYI.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface

2018-10-29 Thread Ted Yu (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667447#comment-16667447
 ] 

Ted Yu commented on HBASE-21246:


Patch v20 is intended to show how WALIdentity is used in various WAL related 
classes for both read and write path.
Changes to test code were not included so that it is easier for reviewers to 
review.

Note: in WALFactory, there is no longer import of FileSystem or Path.

I can put v20 on reviewboard if needed.

> Introduce WALIdentity interface
> ---
>
> Key: HBASE-21246
> URL: https://issues.apache.org/jira/browse/HBASE-21246
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Major
> Fix For: HBASE-20952
>
> Attachments: 21246.003.patch, 21246.20.txt, 
> 21246.HBASE-20952.001.patch, 21246.HBASE-20952.002.patch, 
> 21246.HBASE-20952.004.patch, 21246.HBASE-20952.005.patch, 
> 21246.HBASE-20952.007.patch, 21246.HBASE-20952.008.patch
>
>
> We are introducing WALIdentity interface so that the WAL representation can 
> be decoupled from distributed filesystem.
> The interface provides getName method whose return value can represent 
> filename in distributed filesystem environment or, the name of the stream 
> when the WAL is backed by log stream.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21246) Introduce WALIdentity interface

2018-10-29 Thread Ted Yu (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-21246:
---
Status: Open  (was: Patch Available)

> Introduce WALIdentity interface
> ---
>
> Key: HBASE-21246
> URL: https://issues.apache.org/jira/browse/HBASE-21246
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Major
> Fix For: HBASE-20952
>
> Attachments: 21246.003.patch, 21246.20.txt, 
> 21246.HBASE-20952.001.patch, 21246.HBASE-20952.002.patch, 
> 21246.HBASE-20952.004.patch, 21246.HBASE-20952.005.patch, 
> 21246.HBASE-20952.007.patch, 21246.HBASE-20952.008.patch
>
>
> We are introducing WALIdentity interface so that the WAL representation can 
> be decoupled from distributed filesystem.
> The interface provides getName method whose return value can represent 
> filename in distributed filesystem environment or, the name of the stream 
> when the WAL is backed by log stream.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21246) Introduce WALIdentity interface

2018-10-29 Thread Ted Yu (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-21246:
---
Attachment: 21246.20.txt

> Introduce WALIdentity interface
> ---
>
> Key: HBASE-21246
> URL: https://issues.apache.org/jira/browse/HBASE-21246
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Major
> Fix For: HBASE-20952
>
> Attachments: 21246.003.patch, 21246.20.txt, 
> 21246.HBASE-20952.001.patch, 21246.HBASE-20952.002.patch, 
> 21246.HBASE-20952.004.patch, 21246.HBASE-20952.005.patch, 
> 21246.HBASE-20952.007.patch, 21246.HBASE-20952.008.patch
>
>
> We are introducing WALIdentity interface so that the WAL representation can 
> be decoupled from distributed filesystem.
> The interface provides getName method whose return value can represent 
> filename in distributed filesystem environment or, the name of the stream 
> when the WAL is backed by log stream.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21379) RegionServer Stop by ArrayIndexOutOfBoundsException of WAL when replication enabled

2018-10-29 Thread Zheng Hu (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667310#comment-16667310
 ] 

Zheng Hu commented on HBASE-21379:
--

Confirmed with [~justice_103],  their table is quite simple，No ROW_INDEX_V1 and 
other attribution... 
{code}
{NAME => 'f', VERSIONS => '3', COMPRESSION => 'SNAPPY'}
{code}

> RegionServer Stop by ArrayIndexOutOfBoundsException of WAL when replication 
> enabled
> ---
>
> Key: HBASE-21379
> URL: https://issues.apache.org/jira/browse/HBASE-21379
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 2.0.0
>Reporter: justice
>Assignee: Zheng Hu
>Priority: Major
> Attachments: hbase-wal-p.tgz, log.tgz, wal-20181026.tgz, wal.tgz
>
>
>  log as follow:
> {code:java}
> //代码占位符
> 2018-10-24 09:22:42,381 INFO  [regionserver/11-3-19-10:16020] 
> wal.AbstractFSWAL: New WAL 
> /hbase/WALs/11-3-19-10.jd.local,16020,1540344155469/11-3-19-10.jd.local%2C16020%2C1540344155469.1540344162124
>          │
> 2018-10-24 09:23:05,151 ERROR 
> [regionserver/11-3-19-10:16020.replicationSource.11-3-19-10.jd.local%2C16020%2C1540344155469,2.replicationSource.wal-reader.11-3-19-10.jd.local%2C16020%2C1540344155469,2]
>  region│
> server.ReplicationSource: Unexpected exception in 
> regionserver/11-3-19-10:16020.replicationSource.11-3-19-10.jd.local%2C16020%2C1540344155469,2.replicationSource.wal-reader.11-3-19-10.jd.local%2C16020%2C1540│
> 344155469,2 
> currentPath=hdfs://11-3-18-67.JD.LOCAL:9000/hbase/WALs/11-3-19-10.jd.local,16020,1540344155469/11-3-19-10.jd.local%2C16020%2C1540344155469.1540344162124
>  │
> java.lang.ArrayIndexOutOfBoundsException: 8830 │
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365) │
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358) ┤
> at org.apache.hadoop.hbase.CellUtil.cloneFamily(CellUtil.java:114) │
> at 
> org.apache.hadoop.hbase.replication.ScopeWALEntryFilter.filterCell(ScopeWALEntryFilter.java:54)
>  │
> at 
> org.apache.hadoop.hbase.replication.ChainWALEntryFilter.filterCells(ChainWALEntryFilter.java:90)
>  │
> at 
> org.apache.hadoop.hbase.replication.ChainWALEntryFilter.filter(ChainWALEntryFilter.java:77)
>  │
> at 
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.filterEntry(ReplicationSourceWALReader.java:234)
>  │
> at 
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.readWALEntries(ReplicationSourceWALReader.java:170)
>  │ at 
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:133)
>  │
> 2018-10-24 09:23:05,153 INFO 
> [regionserver/11-3-19-10:16020.replicationSource.11-3-19-10.jd.local%2C16020%2C1540344155469,2.replicationSource.wal-reader.11-3-19-10.jd.local%2C16020%2C1540344155469,2]
>  region│
> server.HRegionServer: * STOPPING region server 
> '11-3-19-10.jd.local,16020,1540344155469' *
> {code}
> hbase wal -p output
> {code:java}
> //代码占位符
> writer Classes: ProtobufLogWriter AsyncProtobufLogWriter
> Cell Codec Class: org.apache.hadoop.hbase.regionserver.wal.WALCellCodec
> Sequence=15 , region=fee7a9465ced6ce9e319d37e9d71c63c at write timestamp=Wed 
> Oct 24 09:22:49 CST 2018
> row=8000, column=METAFAMILY:HBASE::REGION_EVENT
> value: \x08\x00\x12\x1Cmlaas:ump_host_second_181029\x1A 
> fee7a9465ced6ce9e319d37e9d71c63c 
> \x0E*\x06\x0A\x01f\x12\x01f2\x1F\x0A\x1311-3-19-10.JD.LOCAL\x10\x94}\x18\xCD\x9A\xAA\x9D\xEA,:Umlaas:ump_host_second_181029,8000,1540271129253.fee7a9465ced6ce9e319d37e9d71c63c.
> Sequence=9 , region=ba6684888d826328a6373435124dc1cd at write timestamp=Wed 
> Oct 24 09:22:49 CST 2018
> row=9100, column=METAFAMILY:HBASE::REGION_EVENT
> ...
> row=34975#00, column=f:\x09,
> value: 
> {"tp50":1,"avg":2,"min":0,"tp90":1,"max":3,"count":13,"tp99":2,"tp999":2,"error":0}
> row=349824#00, column=f:\x08\xFA
> value: 
> {"tp50":2,"avg":2,"min":0,"tp90":2,"max":98,"count":957,"tp99":3,"tp999":34,"error":0}
> row=349824#00, column=f:\x08\xD2
> value: 
> {"tp50":2,"avg":2,"min":0,"tp90":2,"max":43,"count":1842,"tp99":2,"tp999":31,"error":0}
> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 8830
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365)
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358)
> at 
> org.apache.hadoop.hbase.wal.WALPrettyPrinter.toStringMap(WALPrettyPrinter.java:336)
> at 
> org.apache.hadoop.hbase.wal.WALPrettyPrinter.processFile(WALPrettyPrinter.java:290)
> at org.apache.hadoop.hbase.wal.WALPrettyPrinter.run(WALPrettyPrinter.java:421)
> at 
> org.apache.hadoop.hbase.wal.WALPrettyPrinter.main(WALPrettyPrinter.java:356)
> {code}
>  



--
This message was sent by A

[jira] [Commented] (HBASE-21379) RegionServer Stop by ArrayIndexOutOfBoundsException of WAL when replication enabled

2018-10-29 Thread Ted Yu (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667300#comment-16667300
 ] 

Ted Yu commented on HBASE-21379:


Was ROW_INDEX_V1 used in any of the related table(s) ?

Thanks

> RegionServer Stop by ArrayIndexOutOfBoundsException of WAL when replication 
> enabled
> ---
>
> Key: HBASE-21379
> URL: https://issues.apache.org/jira/browse/HBASE-21379
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 2.0.0
>Reporter: justice
>Assignee: Zheng Hu
>Priority: Major
> Attachments: hbase-wal-p.tgz, log.tgz, wal-20181026.tgz, wal.tgz
>
>
>  log as follow:
> {code:java}
> //代码占位符
> 2018-10-24 09:22:42,381 INFO  [regionserver/11-3-19-10:16020] 
> wal.AbstractFSWAL: New WAL 
> /hbase/WALs/11-3-19-10.jd.local,16020,1540344155469/11-3-19-10.jd.local%2C16020%2C1540344155469.1540344162124
>          │
> 2018-10-24 09:23:05,151 ERROR 
> [regionserver/11-3-19-10:16020.replicationSource.11-3-19-10.jd.local%2C16020%2C1540344155469,2.replicationSource.wal-reader.11-3-19-10.jd.local%2C16020%2C1540344155469,2]
>  region│
> server.ReplicationSource: Unexpected exception in 
> regionserver/11-3-19-10:16020.replicationSource.11-3-19-10.jd.local%2C16020%2C1540344155469,2.replicationSource.wal-reader.11-3-19-10.jd.local%2C16020%2C1540│
> 344155469,2 
> currentPath=hdfs://11-3-18-67.JD.LOCAL:9000/hbase/WALs/11-3-19-10.jd.local,16020,1540344155469/11-3-19-10.jd.local%2C16020%2C1540344155469.1540344162124
>  │
> java.lang.ArrayIndexOutOfBoundsException: 8830 │
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365) │
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358) ┤
> at org.apache.hadoop.hbase.CellUtil.cloneFamily(CellUtil.java:114) │
> at 
> org.apache.hadoop.hbase.replication.ScopeWALEntryFilter.filterCell(ScopeWALEntryFilter.java:54)
>  │
> at 
> org.apache.hadoop.hbase.replication.ChainWALEntryFilter.filterCells(ChainWALEntryFilter.java:90)
>  │
> at 
> org.apache.hadoop.hbase.replication.ChainWALEntryFilter.filter(ChainWALEntryFilter.java:77)
>  │
> at 
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.filterEntry(ReplicationSourceWALReader.java:234)
>  │
> at 
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.readWALEntries(ReplicationSourceWALReader.java:170)
>  │ at 
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:133)
>  │
> 2018-10-24 09:23:05,153 INFO 
> [regionserver/11-3-19-10:16020.replicationSource.11-3-19-10.jd.local%2C16020%2C1540344155469,2.replicationSource.wal-reader.11-3-19-10.jd.local%2C16020%2C1540344155469,2]
>  region│
> server.HRegionServer: * STOPPING region server 
> '11-3-19-10.jd.local,16020,1540344155469' *
> {code}
> hbase wal -p output
> {code:java}
> //代码占位符
> writer Classes: ProtobufLogWriter AsyncProtobufLogWriter
> Cell Codec Class: org.apache.hadoop.hbase.regionserver.wal.WALCellCodec
> Sequence=15 , region=fee7a9465ced6ce9e319d37e9d71c63c at write timestamp=Wed 
> Oct 24 09:22:49 CST 2018
> row=8000, column=METAFAMILY:HBASE::REGION_EVENT
> value: \x08\x00\x12\x1Cmlaas:ump_host_second_181029\x1A 
> fee7a9465ced6ce9e319d37e9d71c63c 
> \x0E*\x06\x0A\x01f\x12\x01f2\x1F\x0A\x1311-3-19-10.JD.LOCAL\x10\x94}\x18\xCD\x9A\xAA\x9D\xEA,:Umlaas:ump_host_second_181029,8000,1540271129253.fee7a9465ced6ce9e319d37e9d71c63c.
> Sequence=9 , region=ba6684888d826328a6373435124dc1cd at write timestamp=Wed 
> Oct 24 09:22:49 CST 2018
> row=9100, column=METAFAMILY:HBASE::REGION_EVENT
> ...
> row=34975#00, column=f:\x09,
> value: 
> {"tp50":1,"avg":2,"min":0,"tp90":1,"max":3,"count":13,"tp99":2,"tp999":2,"error":0}
> row=349824#00, column=f:\x08\xFA
> value: 
> {"tp50":2,"avg":2,"min":0,"tp90":2,"max":98,"count":957,"tp99":3,"tp999":34,"error":0}
> row=349824#00, column=f:\x08\xD2
> value: 
> {"tp50":2,"avg":2,"min":0,"tp90":2,"max":43,"count":1842,"tp99":2,"tp999":31,"error":0}
> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 8830
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365)
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358)
> at 
> org.apache.hadoop.hbase.wal.WALPrettyPrinter.toStringMap(WALPrettyPrinter.java:336)
> at 
> org.apache.hadoop.hbase.wal.WALPrettyPrinter.processFile(WALPrettyPrinter.java:290)
> at org.apache.hadoop.hbase.wal.WALPrettyPrinter.run(WALPrettyPrinter.java:421)
> at 
> org.apache.hadoop.hbase.wal.WALPrettyPrinter.main(WALPrettyPrinter.java:356)
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21401) Sanity check in BaseDecoder#parseCell

2018-10-29 Thread Zheng Hu (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667284#comment-16667284
 ] 

Zheng Hu commented on HBASE-21401:
--

Seems it's related to SizeCachedNoTagsKeyValue.. 

> Sanity check in BaseDecoder#parseCell
> -
>
> Key: HBASE-21401
> URL: https://issues.apache.org/jira/browse/HBASE-21401
> Project: HBase
>  Issue Type: Sub-task
>  Components: regionserver
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21401.v1.patch, HBASE-21401.v2.patch
>
>
> In KeyValueDecoder & ByteBuffKeyValueDecoder,  we pass a byte buffer to 
> initialize the Cell without a sanity check (check each field's offset&len 
> exceed the byte buffer or not), so ArrayIndexOutOfBoundsException may happen 
> when read the cell's fields, such as HBASE-21379,  it's hard to debug this 
> kind of bug. 
> An earlier check will help to find such kind of bugs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table

2018-10-29 Thread Anoop Sam John (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667245#comment-16667245
 ] 

Anoop Sam John commented on HBASE-21388:


bq.So the chunk is lazy created? Only create chunk when need?
Yes. If initial count comes as >0, those many chunks (Each 2 MB) will be 
created on server starts up itself.  But here it is 0. So no worries much.

> No need to instantiate MemStoreLAB for master which not carry table
> ---
>
> Key: HBASE-21388
> URL: https://issues.apache.org/jira/browse/HBASE-21388
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-21388.master.001.patch, 
> HBASE-21388.master.002.patch
>
>
> We found this log in our master.
> 2018-10-26,10:00:00,449 INFO 
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] 
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data 
> MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0
> 2018-10-26,10:00:00,452 INFO 
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] 
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index 
> MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0
>  
> Same with HBASE-21290, we don't need to instantiate MemStore for master which 
> not carry table.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21389) Revisit the procedure lock for sync replication

2018-10-29 Thread Guanghao Zhang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667207#comment-16667207
 ] 

Guanghao Zhang commented on HBASE-21389:


Got it. +1

> Revisit the procedure lock for sync replication
> ---
>
> Key: HBASE-21389
> URL: https://issues.apache.org/jira/browse/HBASE-21389
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2, Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-21389-v1.patch, HBASE-21389-v1.patch, 
> HBASE-21389.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (HBASE-21401) Sanity check in BaseDecoder#parseCell

2018-10-29 Thread Zheng Hu (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667201#comment-16667201
 ] 

Zheng Hu edited comment on HBASE-21401 at 10/29/18 1:31 PM:


TestTags#testFlushAndCompactionwithCombinations  failed because of ROW_INDEX_V1 
too. I believe there's a bug in ROW_INDEX_V1.


was (Author: openinx):
TestTags#testFlushAndCompactionwithCombinations  failed because of ROW_INDEX_V1 
too. I belive there's a bug in ROW_INDEX_V1.

> Sanity check in BaseDecoder#parseCell
> -
>
> Key: HBASE-21401
> URL: https://issues.apache.org/jira/browse/HBASE-21401
> Project: HBase
>  Issue Type: Sub-task
>  Components: regionserver
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21401.v1.patch, HBASE-21401.v2.patch
>
>
> In KeyValueDecoder & ByteBuffKeyValueDecoder,  we pass a byte buffer to 
> initialize the Cell without a sanity check (check each field's offset&len 
> exceed the byte buffer or not), so ArrayIndexOutOfBoundsException may happen 
> when read the cell's fields, such as HBASE-21379,  it's hard to debug this 
> kind of bug. 
> An earlier check will help to find such kind of bugs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21401) Sanity check in BaseDecoder#parseCell

2018-10-29 Thread Zheng Hu (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667201#comment-16667201
 ] 

Zheng Hu commented on HBASE-21401:
--

TestTags#testFlushAndCompactionwithCombinations  failed because of ROW_INDEX_V1 
too. I belive there's a bug in ROW_INDEX_V1.

> Sanity check in BaseDecoder#parseCell
> -
>
> Key: HBASE-21401
> URL: https://issues.apache.org/jira/browse/HBASE-21401
> Project: HBase
>  Issue Type: Sub-task
>  Components: regionserver
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21401.v1.patch, HBASE-21401.v2.patch
>
>
> In KeyValueDecoder & ByteBuffKeyValueDecoder,  we pass a byte buffer to 
> initialize the Cell without a sanity check (check each field's offset&len 
> exceed the byte buffer or not), so ArrayIndexOutOfBoundsException may happen 
> when read the cell's fields, such as HBASE-21379,  it's hard to debug this 
> kind of bug. 
> An earlier check will help to find such kind of bugs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21237) Use CompatRemoteProcedureResolver to dispatch open/close region requests to RS

2018-10-29 Thread Duo Zhang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667194#comment-16667194
 ] 

Duo Zhang commented on HBASE-21237:
---

The mock needs a bit modification, and we can not copy from master as on master 
we will use sendRequest, while on 2.1 and 2.0 we plan to use openRegion and 
closeRegion...

> Use CompatRemoteProcedureResolver to dispatch open/close region requests to RS
> --
>
> Key: HBASE-21237
> URL: https://issues.apache.org/jira/browse/HBASE-21237
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.1.0, 2.0.2
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Blocker
> Fix For: 2.0.3, 2.1.2
>
> Attachments: HBASE-21237-branch-2.1.patch, 
> HBASE-21237.branch-2.0.001.patch
>
>
> As discussed in HBASE-21217, in branch-2.0 and branch-2.1, we should use  
> CompatRemoteProcedureResolver  instead of ExecuteProceduresRemoteCall to 
> dispatch region open/close requests to RS. Since ExecuteProceduresRemoteCall  
> will group all the open/close operations in one call and execute them 
> sequentially on the target RS. If one operation fails, all the operation will 
> be marked as failure. Actually, some of the operations(like open region) is 
> already executing in the open region handler thread. But master thinks these 
> operations fails and reassign the regions to another RS. So when the previous 
> RS report to the master that the region is online, master will kill the RS 
> since it already assign the region to another RS.
> For branch-2.2+, HBASE-21217 will fix this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21389) Revisit the procedure lock for sync replication

2018-10-29 Thread Duo Zhang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667181#comment-16667181
 ] 

Duo Zhang commented on HBASE-21389:
---

They can only be used as sub procedures so no lock. Other sub procedures are 
RefreshPeerProcedure and SyncReplicationReplayWALRemoteProcedure, they extend 
Procedure directly as they are also RemoteProcedures. For other procedures they 
are all top level procedures, which need to hold the exclusive lock.

> Revisit the procedure lock for sync replication
> ---
>
> Key: HBASE-21389
> URL: https://issues.apache.org/jira/browse/HBASE-21389
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2, Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-21389-v1.patch, HBASE-21389-v1.patch, 
> HBASE-21389.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21325) Force to terminate regionserver when abort hang in somewhere

2018-10-29 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667172#comment-16667172
 ] 

Hudson commented on HBASE-21325:


Results for branch master
[build #574 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/574/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/574//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/574//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/574//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Force to terminate regionserver when abort hang in somewhere
> 
>
> Key: HBASE-21325
> URL: https://issues.apache.org/jira/browse/HBASE-21325
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Duo Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21325.master.001.patch, 
> HBASE-21325.master.001.patch, HBASE-21325.master.002.patch, 
> HBASE-21325.master.003.patch, HBASE-21325.master.004.patch, 
> HBASE-21325.master.005.patch
>
>
> When testing sync replication, I found that, if I transit the remote cluster 
> to DA, while the local cluster is still in A, the region server will hang 
> when shutdown. As the fsOk flag only test the local cluster(which is 
> reasonable), we will enter the waitOnAllRegionsToClose, and since the WAL is 
> broken(the remote wal directory is gone)  so we will never succeed. And this 
> lead to an infinite wait inside waitOnAllRegionsToClose.
> So I think here we should have an upper bound for the wait time in 
> waitOnAllRegionsToClose method.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21301) Heatmap for key access patterns

2018-10-29 Thread Archana Katiyar (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667160#comment-16667160
 ] 

Archana Katiyar commented on HBASE-21301:
-

Uploaded patch which has server side implementation along with unit tests. 
Still working on the UI part, will upload that soon.

> Heatmap for key access patterns
> ---
>
> Key: HBASE-21301
> URL: https://issues.apache.org/jira/browse/HBASE-21301
> Project: HBase
>  Issue Type: Improvement
>Reporter: Archana Katiyar
>Assignee: Archana Katiyar
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0
>
> Attachments: HBASE-21301.v1.patch
>
>
> Google recently released a beta feature for Cloud Bigtable which presents a 
> heat map of the keyspace. *Given how hotspotting comes up now and again here, 
> this is a good idea for giving HBase ops a tool to be proactive about it.* 
> >>>
> Additionally, we are announcing the beta version of Key Visualizer, a 
> visualization tool for Cloud Bigtable key access patterns. Key Visualizer 
> helps debug performance issues due to unbalanced access patterns across the 
> key space, or single rows that are too large or receiving too much read or 
> write activity. With Key Visualizer, you get a heat map visualization of 
> access patterns over time, along with the ability to zoom into specific key 
> or time ranges, or select a specific row to find the full row key ID that's 
> responsible for a hotspot. Key Visualizer is automatically enabled for Cloud 
> Bigtable clusters with sufficient data or activity, and does not affect Cloud 
> Bigtable cluster performance. 
> <<<
> From 
> [https://cloudplatform.googleblog.com/2018/07/on-gcp-your-database-your-way.html]
> (Copied this description from the write-up by [~apurtell], thanks Andrew.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21301) Heatmap for key access patterns

2018-10-29 Thread Archana Katiyar (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archana Katiyar updated HBASE-21301:

Attachment: HBASE-21301.v1.patch

> Heatmap for key access patterns
> ---
>
> Key: HBASE-21301
> URL: https://issues.apache.org/jira/browse/HBASE-21301
> Project: HBase
>  Issue Type: Improvement
>Reporter: Archana Katiyar
>Assignee: Archana Katiyar
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0
>
> Attachments: HBASE-21301.v1.patch
>
>
> Google recently released a beta feature for Cloud Bigtable which presents a 
> heat map of the keyspace. *Given how hotspotting comes up now and again here, 
> this is a good idea for giving HBase ops a tool to be proactive about it.* 
> >>>
> Additionally, we are announcing the beta version of Key Visualizer, a 
> visualization tool for Cloud Bigtable key access patterns. Key Visualizer 
> helps debug performance issues due to unbalanced access patterns across the 
> key space, or single rows that are too large or receiving too much read or 
> write activity. With Key Visualizer, you get a heat map visualization of 
> access patterns over time, along with the ability to zoom into specific key 
> or time ranges, or select a specific row to find the full row key ID that's 
> responsible for a hotspot. Key Visualizer is automatically enabled for Cloud 
> Bigtable clusters with sufficient data or activity, and does not affect Cloud 
> Bigtable cluster performance. 
> <<<
> From 
> [https://cloudplatform.googleblog.com/2018/07/on-gcp-your-database-your-way.html]
> (Copied this description from the write-up by [~apurtell], thanks Andrew.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21389) Revisit the procedure lock for sync replication

2018-10-29 Thread Guanghao Zhang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667146#comment-16667146
 ] 

Guanghao Zhang commented on HBASE-21389:


Why only RecoverStandbyProcedure and SyncReplicationReplayWALProcedure extends 
AbstractPeerNoLockProcedure? and other replication procedure extends 
AbstractPeerProcedure?

> Revisit the procedure lock for sync replication
> ---
>
> Key: HBASE-21389
> URL: https://issues.apache.org/jira/browse/HBASE-21389
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2, Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-21389-v1.patch, HBASE-21389-v1.patch, 
> HBASE-21389.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-21375) Revisit the lock and queue implementation in MasterProcedureScheduler

2018-10-29 Thread Duo Zhang (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-21375:
--
  Resolution: Fixed
Hadoop Flags: Reviewed
  Status: Resolved  (was: Patch Available)

Pushed to branch-2.0+. Thanks all for reviewing.

> Revisit the lock and queue implementation in MasterProcedureScheduler
> -
>
> Key: HBASE-21375
> URL: https://issues.apache.org/jira/browse/HBASE-21375
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21375-UT.patch, HBASE-21375-UT2.patch, 
> HBASE-21375-v1.patch, HBASE-21375-v2.patch, HBASE-21375.patch
>
>
> The problem for the old implementation is that we will only check the first 
> procedure in a queue to see if it could run, if it can not, we will remove 
> the queue from run queue. So when adding procedure to the scheduler, we have 
> to try hard to put the procedure which can be executed in front of the queue, 
> if there are corner cases where we fail to do so, it will likely lead to a 
> dead lock, that's why we have the tricky code when loading procedures and try 
> to add them into the scheduler, and also lots of 'if' in the doAdd method of 
> MasterProcedureScheduler. But this is still not enough to make things right, 
> so finally [~allan163] and I decided to change the logic in doPoll method, 
> where we use a loop to find whether there is a procedure can be executed, not 
> only the first one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21325) Force to terminate regionserver when abort hang in somewhere

2018-10-29 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667125#comment-16667125
 ] 

Hudson commented on HBASE-21325:


Results for branch branch-2
[build #1460 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1460/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1460//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1460//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1460//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Force to terminate regionserver when abort hang in somewhere
> 
>
> Key: HBASE-21325
> URL: https://issues.apache.org/jira/browse/HBASE-21325
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Duo Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21325.master.001.patch, 
> HBASE-21325.master.001.patch, HBASE-21325.master.002.patch, 
> HBASE-21325.master.003.patch, HBASE-21325.master.004.patch, 
> HBASE-21325.master.005.patch
>
>
> When testing sync replication, I found that, if I transit the remote cluster 
> to DA, while the local cluster is still in A, the region server will hang 
> when shutdown. As the fsOk flag only test the local cluster(which is 
> reasonable), we will enter the waitOnAllRegionsToClose, and since the WAL is 
> broken(the remote wal directory is gone)  so we will never succeed. And this 
> lead to an infinite wait inside waitOnAllRegionsToClose.
> So I think here we should have an upper bound for the wait time in 
> waitOnAllRegionsToClose method.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table

2018-10-29 Thread Guanghao Zhang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667116#comment-16667116
 ] 

Guanghao Zhang commented on HBASE-21388:


{quote}So there is no space reserved for these chunks.
{quote}
So the chunk is created lazied? Only create chunk when need?

> No need to instantiate MemStoreLAB for master which not carry table
> ---
>
> Key: HBASE-21388
> URL: https://issues.apache.org/jira/browse/HBASE-21388
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-21388.master.001.patch, 
> HBASE-21388.master.002.patch
>
>
> We found this log in our master.
> 2018-10-26,10:00:00,449 INFO 
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] 
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data 
> MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0
> 2018-10-26,10:00:00,452 INFO 
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] 
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index 
> MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0
>  
> Same with HBASE-21290, we don't need to instantiate MemStore for master which 
> not carry table.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table

2018-10-29 Thread Guanghao Zhang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667116#comment-16667116
 ] 

Guanghao Zhang edited comment on HBASE-21388 at 10/29/18 12:22 PM:
---

{quote}So there is no space reserved for these chunks.
{quote}
So the chunk is lazy created? Only create chunk when need?


was (Author: zghaobac):
{quote}So there is no space reserved for these chunks.
{quote}
So the chunk is created lazied? Only create chunk when need?

> No need to instantiate MemStoreLAB for master which not carry table
> ---
>
> Key: HBASE-21388
> URL: https://issues.apache.org/jira/browse/HBASE-21388
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-21388.master.001.patch, 
> HBASE-21388.master.002.patch
>
>
> We found this log in our master.
> 2018-10-26,10:00:00,449 INFO 
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] 
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data 
> MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0
> 2018-10-26,10:00:00,452 INFO 
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] 
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index 
> MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0
>  
> Same with HBASE-21290, we don't need to instantiate MemStore for master which 
> not carry table.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table

2018-10-29 Thread Guanghao Zhang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667112#comment-16667112
 ] 

Guanghao Zhang commented on HBASE-21388:


{quote}bq.But ya when HM do not carry any region better not to have any MSLAB 
chunks and Block cache there
{quote}
The block cache is finished in HBASE-21290.

> No need to instantiate MemStoreLAB for master which not carry table
> ---
>
> Key: HBASE-21388
> URL: https://issues.apache.org/jira/browse/HBASE-21388
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-21388.master.001.patch, 
> HBASE-21388.master.002.patch
>
>
> We found this log in our master.
> 2018-10-26,10:00:00,449 INFO 
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] 
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data 
> MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0
> 2018-10-26,10:00:00,452 INFO 
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] 
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index 
> MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0
>  
> Same with HBASE-21290, we don't need to instantiate MemStore for master which 
> not carry table.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table

2018-10-29 Thread Anoop Sam John (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667031#comment-16667031
 ] 

Anoop Sam John commented on HBASE-21388:


bq.initial count 0
So there is no space reserved for these chunks.  But ya when HM do not carry 
any region better not to have any MSLAB chunks and Block cache there



> No need to instantiate MemStoreLAB for master which not carry table
> ---
>
> Key: HBASE-21388
> URL: https://issues.apache.org/jira/browse/HBASE-21388
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-21388.master.001.patch, 
> HBASE-21388.master.002.patch
>
>
> We found this log in our master.
> 2018-10-26,10:00:00,449 INFO 
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] 
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data 
> MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0
> 2018-10-26,10:00:00,452 INFO 
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] 
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index 
> MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0
>  
> Same with HBASE-21290, we don't need to instantiate MemStore for master which 
> not carry table.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table

2018-10-29 Thread Hadoop QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1985#comment-1985
 ] 

Hadoop QA commented on HBASE-21388:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
17s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
 3s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
11m 26s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}240m 50s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
35s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}286m 42s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21388 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12945984/HBASE-21388.master.002.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux d3e72d93c211 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 
08:52:28 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / c0b994b0c6 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/14894/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/14894/testReport/ |
| Max. process+thread count | 4920 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/14894/console |
| Po

[jira] [Updated] (HBASE-21401) Sanity check in BaseDecoder#parseCell

2018-10-29 Thread Anoop Sam John (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anoop Sam John updated HBASE-21401:
---
Description: 
In KeyValueDecoder & ByteBuffKeyValueDecoder,  we pass a byte buffer to 
initialize the Cell without a sanity check (check each field's offset&len 
exceed the byte buffer or not), so ArrayIndexOutOfBoundsException may happen 
when read the cell's fields, such as HBASE-21379,  it's hard to debug this kind 
of bug. 

An earlier check will help to find such kind of bugs.

  was:
In KeyValueDecoder & ByteBuffKeyValueDecoder,  we pass a byte buffer to 
initialize the Cell without a sanity check (check each field's offset&len 
exceed the byte buffer or not), so ArrayIndexOutOfBoundsException may happen 
when read the cell's fields, such as HBASE-213,  it's hard to debug this kind 
of bug. 

An earlier check will help to find such kind of bugs.


> Sanity check in BaseDecoder#parseCell
> -
>
> Key: HBASE-21401
> URL: https://issues.apache.org/jira/browse/HBASE-21401
> Project: HBase
>  Issue Type: Sub-task
>  Components: regionserver
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21401.v1.patch, HBASE-21401.v2.patch
>
>
> In KeyValueDecoder & ByteBuffKeyValueDecoder,  we pass a byte buffer to 
> initialize the Cell without a sanity check (check each field's offset&len 
> exceed the byte buffer or not), so ArrayIndexOutOfBoundsException may happen 
> when read the cell's fields, such as HBASE-21379,  it's hard to debug this 
> kind of bug. 
> An earlier check will help to find such kind of bugs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21378) [hbck2] checkHBCKSupport blocks assigning hbase:meta or hbase:namespace when master is not initialized

2018-10-29 Thread Jingyun Tian (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1975#comment-1975
 ] 

Jingyun Tian commented on HBASE-21378:
--

[~stack] The skip option is added as a general option now.

> [hbck2] checkHBCKSupport blocks assigning hbase:meta or hbase:namespace when 
> master is not initialized
> --
>
> Key: HBASE-21378
> URL: https://issues.apache.org/jira/browse/HBASE-21378
> Project: HBase
>  Issue Type: Bug
>  Components: hbase-operator-tools, hbck2
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: 
> 0001-HBASE-21378-hbck2-checkHBCKSupport-blocks-assigning-.patch
>
>
> When I encounter the scenario that hbase:namespace is not online.
> {code}
> 2018-10-24,14:38:16,910 WARN org.apache.hadoop.hbase.master.HMaster: 
> hbase:namespace,,1529933109115.7e0801c8232b2dc15face54532056076. is NOT 
> online; state={7e0801c8232b2dc15face54532056076 state=OPEN, ts=1540363033384, 
> server=c4-hadoop-tst-st30.bj,29100,1540348649479}; 
> ServerCrashProcedures=false. Master startup cannot progress, in 
> holding-pattern until region onlined.
> {code}
> Then I tried to assign it manually, but it throws PleaseHoldException.
> {code}
> Wed Oct 24 15:26:52 CST 2018, 
> RpcRetryingCaller{globalStartTime=1540365754487, pause=200, maxAttempts=16}, 
> org.apache.hadoop.hbase.PleaseHoldException: 
> org.apache.hadoop.hbase.PleaseHoldException: Master is initializing
>   at 
> org.apache.hadoop.hbase.master.HMaster.checkInitialized(HMaster.java:3064)
>   at 
> org.apache.hadoop.hbase.master.MasterRpcServices.getClusterStatus(MasterRpcServices.java:934)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
>   at 
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:144)
>   at 
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3133)
>   at 
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3125)
>   at 
> org.apache.hadoop.hbase.client.HBaseAdmin.getClusterMetrics(HBaseAdmin.java:2161)
>   at org.apache.hbase.HBCK2.checkHBCKSupport(HBCK2.java:98)
>   at org.apache.hbase.HBCK2.run(HBCK2.java:364)
>   at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
>   at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
>   at org.apache.hbase.HBCK2.main(HBCK2.java:447)
> Caused by: org.apache.hadoop.hbase.PleaseHoldException: 
> org.apache.hadoop.hbase.PleaseHoldException: Master is initializing
>   at 
> org.apache.hadoop.hbase.master.HMaster.checkInitialized(HMaster.java:3064)
>   at 
> org.apache.hadoop.hbase.master.MasterRpcServices.getClusterStatus(MasterRpcServices.java:934)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>   at 
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.instantiateException(RemoteWithExtrasException.java:100)
>   at 
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.unwrapRemoteException(RemoteWithExtrasException.java:90)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.makeIOExceptionOfException(ProtobufUtil.java:361)
>   at 
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.handleRemoteException(ProtobufUtil.java:349)
>   at 
> org.apache.hadoop.hbase.client.MasterCallable.call(MasterCallable.java:101)
>   at 
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:107)
> {code}
> Then I check the code and found it is because of c

[jira] [Commented] (HBASE-21322) Add a scheduleServerCrashProcedure() API to HbckService

2018-10-29 Thread Jingyun Tian (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1973#comment-1973
 ] 

Jingyun Tian commented on HBASE-21322:
--

[~stack] patch for branch-2.1 is uploaded.

> Add a scheduleServerCrashProcedure() API to HbckService
> ---
>
> Key: HBASE-21322
> URL: https://issues.apache.org/jira/browse/HBASE-21322
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-21322.branch-2.1.001.patch, 
> HBASE-21322.master.001.patch, HBASE-21322.master.002.patch, 
> HBASE-21322.master.003.patch, HBASE-21322.master.004.patch, 
> HBASE-21322.master.005.patch, HBASE-21322.master.006.patch, Screenshot from 
> 2018-10-17 13-35-58.png, Screenshot from 2018-10-17 13-38-41.png, Screenshot 
> from 2018-10-17 13-47-06.png
>
>
> According to my test, if one RS is down, then all procedure logs are deleted, 
> it will lead to that no ServerCrashProcedure is scheduled. And restarting 
> master cannot help. Thus we need to schedule a ServerCrashProcedure manually 
> to solve the problem. I plan to add a scheduleServerCrashProcedure() API to 
> HbckService, then add this API to HBCK2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21374) Backport HBASE-21342 to branch-1

2018-10-29 Thread Hadoop QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1882#comment-1882
 ] 

Hadoop QA commented on HBASE-21374:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
23s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
46s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
36s{color} | {color:green} branch-1 passed with JDK v1.8.0_181 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
38s{color} | {color:green} branch-1 passed with JDK v1.7.0_191 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
18s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
45s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} branch-1 passed with JDK v1.8.0_181 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
36s{color} | {color:green} branch-1 passed with JDK v1.7.0_191 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed with JDK v1.8.0_181 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed with JDK v1.7.0_191 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
40s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
1m 39s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.7.4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
28s{color} | {color:green} the patch passed with JDK v1.8.0_181 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed with JDK v1.7.0_191 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}131m 16s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
22s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}150m 19s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.coprocessor.TestMetaTableMetrics |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:61288f8 |
| JIRA Issue | HBASE-21374 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12945993/HBASE-21374.branch-1.003.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 074ae290a7cc 3.13.0-144-generic #193-Ubuntu SM

[jira] [Updated] (HBASE-21375) Revisit the lock and queue implementation in MasterProcedureScheduler

2018-10-29 Thread Duo Zhang (JIRA)



 [ 
https://issues.apache.org/jira/browse/HBASE-21375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-21375:
--
Fix Version/s: 2.1.2
   2.0.3

> Revisit the lock and queue implementation in MasterProcedureScheduler
> -
>
> Key: HBASE-21375
> URL: https://issues.apache.org/jira/browse/HBASE-21375
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21375-UT.patch, HBASE-21375-UT2.patch, 
> HBASE-21375-v1.patch, HBASE-21375-v2.patch, HBASE-21375.patch
>
>
> The problem for the old implementation is that we will only check the first 
> procedure in a queue to see if it could run, if it can not, we will remove 
> the queue from run queue. So when adding procedure to the scheduler, we have 
> to try hard to put the procedure which can be executed in front of the queue, 
> if there are corner cases where we fail to do so, it will likely lead to a 
> dead lock, that's why we have the tricky code when loading procedures and try 
> to add them into the scheduler, and also lots of 'if' in the doAdd method of 
> MasterProcedureScheduler. But this is still not enough to make things right, 
> so finally [~allan163] and I decided to change the logic in doPoll method, 
> where we use a loop to find whether there is a procedure can be executed, not 
> only the first one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21395) Abort split/merge procedure if there is a table procedure of the same table going on

2018-10-29 Thread Hadoop QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1825#comment-1825
 ] 

Hadoop QA commented on HBASE-21395:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2.0 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
10s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
51s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
15s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
56s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
26s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
39s{color} | {color:green} branch-2.0 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 0s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
9m 26s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}135m 
10s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
31s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}174m  7s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:6f01af0 |
| JIRA Issue | HBASE-21395 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12945981/HBASE-21395.branch-2.0.004.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux d569e642071d 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 
08:52:28 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | branch-2.0 / a3b2686114 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/14893/testReport/ |
| Max. process+thread count | 4069 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https

[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table

2018-10-29 Thread Hadoop QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1821#comment-1821
 ] 

Hadoop QA commented on HBASE-21388:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
14s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m  
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
49s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m 
16s{color} | {color:red} hbase-server: The patch generated 2 new + 158 
unchanged - 0 fixed = 160 total (was 158) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
16s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
10m 45s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}131m 15s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
23s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}173m 39s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.TestMasterNotCarryTable |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21388 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12945980/HBASE-21388.master.001.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 605ed17e46b7 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / c0b994b0c6 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HBASE-Build/14892/artifact/patchprocess/diff-checkstyle-hbase-server.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/14892/artifact/patchprocess/patch-unit-hbase-server.txt

96 matches

Mail list logo