[jira] [Commented] (HBASE-21404) Master/RS navbar active state does not work

2019-01-27 Thread Jingyun Tian (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753753#comment-16753753
 ] 

Jingyun Tian commented on HBASE-21404:
--

+1 LGTM

> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Affects Versions: 3.0.0, 2.0.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-21404.master.001.patch, 
> HBASE-21404.master.001.patch, HBASE-21404.master.002.patch, 
> master_after_patch.png, master_before.png, rs_after_patch.png, rs_before.png
>
>
> In master/rs web UI, the current active tab is not updated when user switches 
> to any tab other than "Home" tab.
> For example: even though say if we are on "tabledetailed.jsp", the navbar 
> does not update the active state of that tab. See master_before.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21792) Introduce an interface to replace the HTableMultiplexer which is marked as IA.Public

2019-01-27 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753736#comment-16753736
 ] 

stack commented on HBASE-21792:
---

that’s a better idea imo. It’s not complete w odd behavior. 

> Introduce an interface to replace the HTableMultiplexer which is marked as 
> IA.Public
> 
>
> Key: HBASE-21792
> URL: https://issues.apache.org/jira/browse/HBASE-21792
> Project: HBase
>  Issue Type: Task
>  Components: Client
>Reporter: Duo Zhang
>Priority: Major
>
> And add a method in the Connection interface to get a multiplexer, instead of 
> letting the user create a new instance through the constructor.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21057) upgrade to latest spotbugs

2019-01-27 Thread kevin su (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753712#comment-16753712
 ] 

kevin su commented on HBASE-21057:
--

[~busbey] would you help me commit the code.

I am glad to contribute to hbase

> upgrade to latest spotbugs
> --
>
> Key: HBASE-21057
> URL: https://issues.apache.org/jira/browse/HBASE-21057
> Project: HBase
>  Issue Type: Task
>  Components: community, test
>Affects Versions: 3.0.0
>Reporter: Sean Busbey
>Assignee: kevin su
>Priority: Minor
>  Labels: beginner
> Fix For: 3.0.0
>
> Attachments: HBASE-21057.v0.patch, HBASE-21057.v1.patch, 
> HBASE-21057.v1.patch
>
>
> we currently rely on [spotbugs definitions from 
> 3.1.0-RC3|https://github.com/spotbugs/spotbugs/releases/tag/3.1.0_RC3], which 
> was a pre-release candidate from Jun 2017.
> [spotbugs version 
> 3.1.6|https://github.com/spotbugs/spotbugs/releases/tag/3.1.6] came out about 
> a month ago. We should update to the latest.
> they also have their own maven plugin now. as a stretch goal we could switch 
> over to that, if it works with yetus.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21404) Master/RS navbar active state does not work

2019-01-27 Thread Nihal Jain (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753711#comment-16753711
 ] 

Nihal Jain commented on HBASE-21404:


{quote}in header.jsp supposed to cover this problem?
{quote}
Bootstrap expects the application to take care of page switching. Since we have 
a common header, this is not taken care of by our application. 
 The code changes are taken from [StackOverflow: Bootstrap navbar Active State 
not 
working|https://stackoverflow.com/questions/24514717/bootstrap-navbar-active-state-not-working]

> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Affects Versions: 3.0.0, 2.0.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-21404.master.001.patch, 
> HBASE-21404.master.001.patch, HBASE-21404.master.002.patch, 
> master_after_patch.png, master_before.png, rs_after_patch.png, rs_before.png
>
>
> In master/rs web UI, the current active tab is not updated when user switches 
> to any tab other than "Home" tab.
> For example: even though say if we are on "tabledetailed.jsp", the navbar 
> does not update the active state of that tab. See master_before.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21057) upgrade to latest spotbugs

2019-01-27 Thread kevin su (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

kevin su updated HBASE-21057:
-
Resolution: Fixed
Status: Resolved  (was: Patch Available)

upgrade to latest spotbugs

> upgrade to latest spotbugs
> --
>
> Key: HBASE-21057
> URL: https://issues.apache.org/jira/browse/HBASE-21057
> Project: HBase
>  Issue Type: Task
>  Components: community, test
>Affects Versions: 3.0.0
>Reporter: Sean Busbey
>Assignee: kevin su
>Priority: Minor
>  Labels: beginner
> Fix For: 3.0.0
>
> Attachments: HBASE-21057.v0.patch, HBASE-21057.v1.patch, 
> HBASE-21057.v1.patch
>
>
> we currently rely on [spotbugs definitions from 
> 3.1.0-RC3|https://github.com/spotbugs/spotbugs/releases/tag/3.1.0_RC3], which 
> was a pre-release candidate from Jun 2017.
> [spotbugs version 
> 3.1.6|https://github.com/spotbugs/spotbugs/releases/tag/3.1.6] came out about 
> a month ago. We should update to the latest.
> they also have their own maven plugin now. as a stretch goal we could switch 
> over to that, if it works with yetus.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21792) Introduce an interface to replace the HTableMultiplexer which is marked as IA.Public

2019-01-27 Thread Duo Zhang (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753707#comment-16753707
 ] 

Duo Zhang commented on HBASE-21792:
---

Yes, it is a bit weird. And the usage is also a bit broken, we just ignore the 
failed puts...

And there are advantages, comparing to buffered mutator, we can send puts from 
different tables together to a rs at once.

Maybe we could just deprecated it without replacement, and let user use 
buffered mutator for now, since the API is broken?

> Introduce an interface to replace the HTableMultiplexer which is marked as 
> IA.Public
> 
>
> Key: HBASE-21792
> URL: https://issues.apache.org/jira/browse/HBASE-21792
> Project: HBase
>  Issue Type: Task
>  Components: Client
>Reporter: Duo Zhang
>Priority: Major
>
> And add a method in the Connection interface to get a multiplexer, instead of 
> letting the user create a new instance through the constructor.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (HBASE-21792) Introduce an interface to replace the HTableMultiplexer which is marked as IA.Public

2019-01-27 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753706#comment-16753706
 ] 

stack edited comment on HBASE-21792 at 1/28/19 5:22 AM:


HTM came in with "HBASE-5776 HTableMultiplexer (Liyin, binlijin and Ted Yu)". 
Its weird. It is incomplete too only doing Puts. Should we be encouraging its 
use or deprecating it? Having users use the async client they could achieve 
some of what HTM supposedly does (non-blocking client?).


was (Author: stack):
HTM came in with "HBASE-5776 HTableMultiplexer (Liyin, binlijin and Ted Yu)". 
Its weird. It is incomplete too. Should we be encouraging its use or 
deprecating it?

> Introduce an interface to replace the HTableMultiplexer which is marked as 
> IA.Public
> 
>
> Key: HBASE-21792
> URL: https://issues.apache.org/jira/browse/HBASE-21792
> Project: HBase
>  Issue Type: Task
>  Components: Client
>Reporter: Duo Zhang
>Priority: Major
>
> And add a method in the Connection interface to get a multiplexer, instead of 
> letting the user create a new instance through the constructor.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21792) Introduce an interface to replace the HTableMultiplexer which is marked as IA.Public

2019-01-27 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753706#comment-16753706
 ] 

stack commented on HBASE-21792:
---

HTM came in with "HBASE-5776 HTableMultiplexer (Liyin, binlijin and Ted Yu)". 
Its weird. It is incomplete too. Should we be encouraging its use or 
deprecating it?

> Introduce an interface to replace the HTableMultiplexer which is marked as 
> IA.Public
> 
>
> Key: HBASE-21792
> URL: https://issues.apache.org/jira/browse/HBASE-21792
> Project: HBase
>  Issue Type: Task
>  Components: Client
>Reporter: Duo Zhang
>Priority: Major
>
> And add a method in the Connection interface to get a multiplexer, instead of 
> letting the user create a new instance through the constructor.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21764) Size of in-memory compaction thread pool shoud be configurable

2019-01-27 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753704#comment-16753704
 ] 

stack commented on HBASE-21764:
---

+1 [~openinx]. Add RN on new config please. Thanks.

> Size of in-memory compaction thread pool shoud be configurable
> --
>
> Key: HBASE-21764
> URL: https://issues.apache.org/jira/browse/HBASE-21764
> Project: HBase
>  Issue Type: Sub-task
>  Components: in-memory-compaction
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.1.3, 2.0.5
>
> Attachments: HBASE-21764.v1.patch, HBASE-21764.v2.patch, 
> HBASE-21764.v3.patch
>
>
> In RegionServicesForStores,  we can see : 
> {code}
>   private static final int POOL_SIZE = 10;
>   private static final ThreadPoolExecutor INMEMORY_COMPACTION_POOL =
>   new ThreadPoolExecutor(POOL_SIZE, POOL_SIZE, 60, TimeUnit.SECONDS,
>   new LinkedBlockingQueue<>(),
>   new ThreadFactory() {
> @Override
> public Thread newThread(Runnable r) {
>   String name = Thread.currentThread().getName() + 
> "-inmemoryCompactions-" +
>   System.currentTimeMillis();
>   return new Thread(r, name);
> }
>   });
> {code}
> The pool size should be configurable, because if many regions on a rs,  the 
> default 10 threads will be not enough.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21638) Remove dead links from hbase.apache.org

2019-01-27 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753701#comment-16753701
 ] 

stack commented on HBASE-21638:
---

+1 from me on removing 0.94. This release is from the time when giants roamed 
the earth.

> Remove dead links from hbase.apache.org
> ---
>
> Key: HBASE-21638
> URL: https://issues.apache.org/jira/browse/HBASE-21638
> Project: HBase
>  Issue Type: Sub-task
>  Components: website
>Reporter: Peter Somogyi
>Assignee: Sakthi
>Priority: Minor
>
> The HBase Website Link Checker report contains many dead links. Fix these:
> {noformat}
> Index of Linklint results 
> Sat, 22-Dec-2018 05:03:16 (local)
> Linklint version: 2.3.5_ingo_020
>   summary.txt: summary of results
>   log.txt: log of progress
> file.html: found 51118 files
>fileX.html: found 51118 files (cross referenced)
>fileF.html: found 50982 files with forward links
>   remote.html: found 3414 other links
>  remoteX.html: found 3414 other links (cross referenced)
>   anchor.html: found 21516049 named anchors
>  anchorX.html: found 21516049 named anchors (cross referenced)
>   action.html: -   1 action skipped
>  actionX.html: -   1 action skipped (cross referenced)
>  skipped.html: -   2 files skipped
>skipX.html: -   2 files skipped (cross referenced)
> warn.html: warn  696 warnings
>warnX.html: warn  696 warnings (cross referenced)
>warnF.html: warn  253 files with warnings
>error.html: ERROR 1458 missing files
>   errorX.html: ERROR 1458 missing files (cross referenced)
>   errorF.html: ERROR 1417 files had broken links
>   errorA.html: ERROR 7143 missing named anchors
>  errorAX.html: ERROR 7143 missing named anchors (cross referenced)
> httpfail.html: - 1458 links: failed via http
>   httpok.html: - 51118 links: ok via http
>   mapped.html: -   4 links were mapped
> urlindex.html: results for remote urls
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21402) Backport parent "HBASE-21325 Force to terminate regionserver when abort hang in somewhere"

2019-01-27 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753699#comment-16753699
 ] 

stack commented on HBASE-21402:
---

+1 from me. Will commit in a day or so. Good by you [~zghaobac]

> Backport parent "HBASE-21325 Force to terminate regionserver when abort hang 
> in somewhere"
> --
>
> Key: HBASE-21402
> URL: https://issues.apache.org/jira/browse/HBASE-21402
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.0.3, 2.1.2
>Reporter: stack
>Assignee: Pankaj Kumar
>Priority: Major
> Fix For: 2.1.3, 2.0.5
>
> Attachments: HBASE-21402.branch-2.0.patch, 
> HBASE-21402.branch-2.1.patch
>
>
> Backport parent. Looks like good idea for fixing long-standing problem. I can 
> do the backport [~zghaobac].  Just FYI.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21790) Detail docs on ref guide for CompactionTool

2019-01-27 Thread stack (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-21790:
--
   Resolution: Fixed
 Hadoop Flags: Reviewed
Fix Version/s: 3.0.0
   Status: Resolved  (was: Patch Available)

Pushed to master branch (will be included in other branches by RM when they 
copy docs). Nice doc [~wchevreuil].

> Detail docs on ref guide for CompactionTool
> ---
>
> Key: HBASE-21790
> URL: https://issues.apache.org/jira/browse/HBASE-21790
> Project: HBase
>  Issue Type: Improvement
>  Components: documentation
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-21790-master.001.patch
>
>
> Describe CompactionTool in more details on the ref guide, explaining better 
> each options and giving a high level overview of how it works.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21404) Master/RS navbar active state does not work

2019-01-27 Thread Jingyun Tian (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753655#comment-16753655
 ] 

Jingyun Tian commented on HBASE-21404:
--

Sorry, I'm not familiar with the JQuery Code. But the code 
{code}
  
{code}
in header.jsp supposed to cover this problem? Maybe we should check why it 
doesn't work?

> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Affects Versions: 3.0.0, 2.0.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-21404.master.001.patch, 
> HBASE-21404.master.001.patch, HBASE-21404.master.002.patch, 
> master_after_patch.png, master_before.png, rs_after_patch.png, rs_before.png
>
>
> In master/rs web UI, the current active tab is not updated when user switches 
> to any tab other than "Home" tab.
> For example: even though say if we are on "tabledetailed.jsp", the navbar 
> does not update the active state of that tab. See master_before.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21739) Move grant/revoke from regionserver to master

2019-01-27 Thread Guanghao Zhang (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-21739:
---
Attachment: HBASE-21739.master.003.patch

> Move grant/revoke from regionserver to master
> -
>
> Key: HBASE-21739
> URL: https://issues.apache.org/jira/browse/HBASE-21739
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Yi Mei
>Assignee: Yi Mei
>Priority: Major
> Attachments: HBASE-21739.master.001.patch, 
> HBASE-21739.master.002.patch, HBASE-21739.master.003.patch, 
> HBASE-21739.master.003.patch
>
>
> Create a sub-task to move grant/revoke from regionserver to master. Other 
> access control operations(getUserPermissions/ checkPermissions/ 
> hasPermission) will be moved in another sub-task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21739) Move grant/revoke from regionserver to master

2019-01-27 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753643#comment-16753643
 ] 

Hadoop QA commented on HBASE-21739:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
12s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  4s{color} 
| {color:red} HBASE-21739 does not apply to master. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.8.0/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21739 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12956522/HBASE-21739.master.003.patch
 |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/15752/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> Move grant/revoke from regionserver to master
> -
>
> Key: HBASE-21739
> URL: https://issues.apache.org/jira/browse/HBASE-21739
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Yi Mei
>Assignee: Yi Mei
>Priority: Major
> Attachments: HBASE-21739.master.001.patch, 
> HBASE-21739.master.002.patch, HBASE-21739.master.003.patch, 
> HBASE-21739.master.003.patch
>
>
> Create a sub-task to move grant/revoke from regionserver to master. Other 
> access control operations(getUserPermissions/ checkPermissions/ 
> hasPermission) will be moved in another sub-task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work started] (HBASE-21794) Update the Coprocessor observer example given in section 111.1 of the ref guide.

2019-01-27 Thread Sakthi (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-21794 started by Sakthi.
--
> Update the Coprocessor observer example given in section 111.1 of the ref 
> guide.
> 
>
> Key: HBASE-21794
> URL: https://issues.apache.org/jira/browse/HBASE-21794
> Project: HBase
>  Issue Type: Bug
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
>
> The given example should be changed after the CP changes (HBASE-17732)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-21794) Update the Coprocessor observer example given in section 111.1 of the ref guide.

2019-01-27 Thread Sakthi (JIRA)
Sakthi created HBASE-21794:
--

 Summary: Update the Coprocessor observer example given in section 
111.1 of the ref guide.
 Key: HBASE-21794
 URL: https://issues.apache.org/jira/browse/HBASE-21794
 Project: HBase
  Issue Type: Bug
Reporter: Sakthi
Assignee: Sakthi


The given example should be changed after the CP changes (HBASE-17732)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21464) Splitting blocked with meta NSRE during split transaction

2019-01-27 Thread Andrew Purtell (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753508#comment-16753508
 ] 

Andrew Purtell commented on HBASE-21464:


I wonder after commit of HBASE-21775 if this can be reverted.

> Splitting blocked with meta NSRE during split transaction
> -
>
> Key: HBASE-21464
> URL: https://issues.apache.org/jira/browse/HBASE-21464
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.5.0, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.8, 1.4.7
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 1.5.0, 1.4.9
>
> Attachments: HBASE-21464-branch-1.patch, HBASE-21464-branch-1.patch, 
> HBASE-21464-branch-1.patch, HBASE-21464-branch-1.patch
>
>
> Splitting is blocked during split transaction. The split worker is trying to 
> update meta but isn't able to relocate it after NSRE:
> {noformat}
> 2018-11-09 17:50:45,277 INFO  
> [regionserver/ip-172-31-5-92.us-west-2.compute.internal/172.31.5.92:8120-splits-1541785709434]
>  client.RpcRetryingCaller: Call exception, tries=13, retries=350, 
> started=88590 ms ago, cancelled=false, 
> msg=org.apache.hadoop.hbase.NotServingRegionException: Region hbase:meta,,1 
> is not online on ip-172-31-13-83.us-west-2.compute.internal,8120,1541785618832
>      at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3088)
>         at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1271)
>         at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.execService(RSRpcServices.java:2198)
>         at 
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:36617)
>         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2396)
>         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)
>         at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297)
>         at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277)row 
> 'test,,1541785709452.5ba6596f0050c2dab969d152829227c6.44' on table 
> 'hbase:meta' at region=hbase:meta,1.1588230740, 
> hostname=ip-172-31-15-225.us-west-2.compute.internal,8120,1541785640586, 
> seqNum=0{noformat}
> Clients, in this case YCSB, are hung with part of the keyspace missing:
> {noformat}
> 2018-11-09 17:51:06,033 DEBUG [hconnection-0x5739e567-shared--pool1-t165] 
> client.ConnectionManager$HConnectionImplementation: locateRegionInMeta 
> parentTable=hbase:meta, metaLocation=, attempt=14 of 35 failed; retrying 
> after sleep of 20158 because: No server address listed in hbase:meta for 
> region 
> test,user307326104267982763,1541785754600.ef90030b05cb02305b75e9bfbc3ee081. 
> containing row user3301635648728421323{noformat}
> Balancing cannot run indefinitely because the split transaction is stuck
> {noformat}
> 2018-11-09 17:49:55,478 DEBUG 
> [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=8100] master.HMaster: 
> Not running balancer because 3 region(s) in transition: 
> [{ef90030b05cb02305b75e9bfbc3ee081 state=SPLITTING_NEW, ts=1541785754606, 
> server=ip-172-31-5-92.us-west-2.compute.internal,8120,1541785626417}, 
> {5ba6596f0050c2dab969d152829227c6 state=SPLITTING, ts=1541785754606, 
> server=ip-172-31-5-92.us-west-2.compute{noformat}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21402) Backport parent "HBASE-21325 Force to terminate regionserver when abort hang in somewhere"

2019-01-27 Thread Pankaj Kumar (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753454#comment-16753454
 ] 

Pankaj Kumar commented on HBASE-21402:
--

[~stack] [~zghaobac] .. Kindly review and commit this.

> Backport parent "HBASE-21325 Force to terminate regionserver when abort hang 
> in somewhere"
> --
>
> Key: HBASE-21402
> URL: https://issues.apache.org/jira/browse/HBASE-21402
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.0.3, 2.1.2
>Reporter: stack
>Assignee: Pankaj Kumar
>Priority: Major
> Fix For: 2.1.3, 2.0.5
>
> Attachments: HBASE-21402.branch-2.0.patch, 
> HBASE-21402.branch-2.1.patch
>
>
> Backport parent. Looks like good idea for fixing long-standing problem. I can 
> do the backport [~zghaobac].  Just FYI.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21404) Master/RS navbar active state does not work

2019-01-27 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753433#comment-16753433
 ] 

Hadoop QA commented on HBASE-21404:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
38s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}225m  6s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
26s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}237m 40s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.TestSplitWALManager |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21404 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12956493/HBASE-21404.master.002.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  |
| uname | Linux 572282152ea7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 274e4ccea8 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/15751/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/15751/testReport/ |
| Max. process+thread count | 5014 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/15751/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Affects Versions: 3.0.0, 2.0.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-21404.master.001.patch, 
> HBASE-21404.master.001.patch, HBASE-21404.master.002.patch, 
> master_after_patch.png, master_before.png, rs_after_patch.png, rs_before.png
>
>
> In master/rs web UI, the current active tab is not updated when user switches 
> to any tab other than "Home" tab.
> For example: even though say if we are on "tabledetailed.jsp", the navbar 
> does not update the active state of that tab. See master_before.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21512) Introduce an AsyncClusterConnection and replace the usage of ClusterConnection

2019-01-27 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753409#comment-16753409
 ] 

Hudson commented on HBASE-21512:


Results for branch HBASE-21512
[build #74 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/74/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/74//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/74//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/74//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Introduce an AsyncClusterConnection and replace the usage of ClusterConnection
> --
>
> Key: HBASE-21512
> URL: https://issues.apache.org/jira/browse/HBASE-21512
> Project: HBase
>  Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> At least for the RSProcedureDispatcher, with CompletableFuture we do not need 
> to set a delay and use a thread pool any more, which could reduce the 
> resource usage and also the latency.
> Once this is done, I think we can remove the ClusterConnection completely, 
> and start to rewrite the old sync client based on the async client, which 
> could reduce the code base a lot for our client.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21782) LoadIncrementalHFiles should not be IA.Public

2019-01-27 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753403#comment-16753403
 ] 

Hudson commented on HBASE-21782:


Results for branch branch-2
[build #1640 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1640/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1640//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1640//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1640//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> LoadIncrementalHFiles should not be IA.Public
> -
>
> Key: HBASE-21782
> URL: https://issues.apache.org/jira/browse/HBASE-21782
> Project: HBase
>  Issue Type: Task
>  Components: mapreduce
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21782-v1.patch, HBASE-21782.patch
>
>
> It is an implementation class, so some of the methods which are only supposed 
> to be used by replication sink are also public to users. And it exposes 
> methods which take Table and Connection as parameter and inside the 
> implementation we assume that they are HTable and ConnectionImplementation, 
> which will be a pain when we want to replace the sync client implementation 
> with async client.
> Here I think we should make the implementation class as 
> IA.LimitPrivate(TOOL), and introduce an interface for bulking hfiles 
> programmatically.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-17942) Disable region splits and merges per table

2019-01-27 Thread Nihal Jain (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-17942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753406#comment-16753406
 ] 

Nihal Jain commented on HBASE-17942:


I discovered a strange behavior while writing tests in the above patch.

It is easily reproducible: Just add following statement at the end of testcase: 
{{TestSplitTableRegionProcedure.testSplitTableRegionEmptyDaughter()}}
{code:java}
UTIL.getAdmin().modifyTable(UTIL.getAdmin().getDescriptor(tableName));
{code}
 The modify procedure succeeds but the future never returns and the test-case 
keeps running.

See the tail of the log:
{noformat}
2019-01-27 20:23:25,302 DEBUG [PEWorker-1] procedure2.RootProcedureState(153): 
Add procedure pid=14, state=SUCCESS, hasLock=true; ModifyTableProcedure 
table=testSplitTableRegionDeletedRowsDaughter as the 27th rollback step
2019-01-27 20:23:25,319 DEBUG [PEWorker-1] 
procedure.MasterProcedureScheduler(351): Add 
TableQueue(testSplitTableRegionDeletedRowsDaughter, xlock=false sharedLock=0 
size=0) to run queue because: pid=14, state=SUCCESS, hasLock=false; 
ModifyTableProcedure table=testSplitTableRegionDeletedRowsDaughter released the 
exclusive lock
2019-01-27 20:23:25,320 INFO  [PEWorker-1] procedure2.ProcedureExecutor(1410): 
Finished pid=14, state=SUCCESS, hasLock=false; ModifyTableProcedure 
table=testSplitTableRegionDeletedRowsDaughter in 1.0010sec
2019-01-27 20:23:25,328 DEBUG 
[RpcServer.default.FPBQ.Fifo.handler=3,queue=0,port=40235] 
master.MasterRpcServices(1182): Checking to see if procedure is done pid=14
2019-01-27 20:23:27,168 WARN  [HBase-Metrics2-1] impl.MetricsConfig(125): 
Cannot locate configuration: tried 
hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
2019-01-27 20:23:27,503 INFO  
[org.apache.hadoop.hdfs.server.blockmanagement.BlockManager$ReplicationMonitor@4e87e6e6]
 blockmanagement.BlockManager(3480): BLOCK* BlockManager: ask 127.0.0.1:36701 
to delete [blk_1073741834_1010]
2019-01-27 20:23:30,504 INFO  
[org.apache.hadoop.hdfs.server.blockmanagement.BlockManager$ReplicationMonitor@4e87e6e6]
 blockmanagement.BlockManager(3480): BLOCK* BlockManager: ask 127.0.0.1:37975 
to delete [blk_1073741834_1010]
{noformat}

> Disable region splits and merges per table
> --
>
> Key: HBASE-17942
> URL: https://issues.apache.org/jira/browse/HBASE-17942
> Project: HBase
>  Issue Type: New Feature
>Reporter: Vladimir Rodionov
>Assignee: Nihal Jain
>Priority: Major
> Attachments: HBASE-17942.master.001.patch
>
>
> Snapshot of a large tables usually fails when region split/merge happens 
> during snapshot. HBASE-15128 has introduced enable/disable switch for split 
> /merges, but only cluster - wide which is not always good in a large 
> deployments. The new feature will improve snapshot stability ands performance 
> for a single table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-17942) Disable region splits and merges per table

2019-01-27 Thread Nihal Jain (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-17942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753408#comment-16753408
 ] 

Nihal Jain commented on HBASE-17942:


FYI [~Apache9]

> Disable region splits and merges per table
> --
>
> Key: HBASE-17942
> URL: https://issues.apache.org/jira/browse/HBASE-17942
> Project: HBase
>  Issue Type: New Feature
>Reporter: Vladimir Rodionov
>Assignee: Nihal Jain
>Priority: Major
> Attachments: HBASE-17942.master.001.patch
>
>
> Snapshot of a large tables usually fails when region split/merge happens 
> during snapshot. HBASE-15128 has introduced enable/disable switch for split 
> /merges, but only cluster - wide which is not always good in a large 
> deployments. The new feature will improve snapshot stability ands performance 
> for a single table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21789) Rewrite MetaTableAccessor.multiMutate with Table.coprocessorService

2019-01-27 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753404#comment-16753404
 ] 

Hudson commented on HBASE-21789:


Results for branch branch-2
[build #1640 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1640/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1640//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1640//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1640//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Rewrite MetaTableAccessor.multiMutate with Table.coprocessorService
> ---
>
> Key: HBASE-21789
> URL: https://issues.apache.org/jira/browse/HBASE-21789
> Project: HBase
>  Issue Type: Improvement
>  Components: Client, Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21789-v1.patch, HBASE-21789.patch
>
>
> Now it implements a special RegionServerCallable, which is not necessary. It 
> is just a coprocessor call to MultiRowMutationEndpoint, we should use the 
> coprocessor related method to do this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-17942) Disable region splits and merges per table

2019-01-27 Thread Nihal Jain (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-17942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753401#comment-16753401
 ] 

Nihal Jain commented on HBASE-17942:


Submitted an initial patch. If the approach looks good will try to add tests 
for shell too.

Could you please review: [~vrodionov], [~stack]

> Disable region splits and merges per table
> --
>
> Key: HBASE-17942
> URL: https://issues.apache.org/jira/browse/HBASE-17942
> Project: HBase
>  Issue Type: New Feature
>Reporter: Vladimir Rodionov
>Assignee: Nihal Jain
>Priority: Major
> Attachments: HBASE-17942.master.001.patch
>
>
> Snapshot of a large tables usually fails when region split/merge happens 
> during snapshot. HBASE-15128 has introduced enable/disable switch for split 
> /merges, but only cluster - wide which is not always good in a large 
> deployments. The new feature will improve snapshot stability ands performance 
> for a single table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-17942) Disable region splits and merges per table

2019-01-27 Thread Nihal Jain (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-17942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nihal Jain updated HBASE-17942:
---
Attachment: HBASE-17942.master.001.patch

> Disable region splits and merges per table
> --
>
> Key: HBASE-17942
> URL: https://issues.apache.org/jira/browse/HBASE-17942
> Project: HBase
>  Issue Type: New Feature
>Reporter: Vladimir Rodionov
>Assignee: Nihal Jain
>Priority: Major
> Attachments: HBASE-17942.master.001.patch
>
>
> Snapshot of a large tables usually fails when region split/merge happens 
> during snapshot. HBASE-15128 has introduced enable/disable switch for split 
> /merges, but only cluster - wide which is not always good in a large 
> deployments. The new feature will improve snapshot stability ands performance 
> for a single table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21512) Introduce an AsyncClusterConnection and replace the usage of ClusterConnection

2019-01-27 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753395#comment-16753395
 ] 

Hudson commented on HBASE-21512:


Results for branch HBASE-21512
[build #73 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/73/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/73//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/73//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/73//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Introduce an AsyncClusterConnection and replace the usage of ClusterConnection
> --
>
> Key: HBASE-21512
> URL: https://issues.apache.org/jira/browse/HBASE-21512
> Project: HBase
>  Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> At least for the RSProcedureDispatcher, with CompletableFuture we do not need 
> to set a delay and use a thread pool any more, which could reduce the 
> resource usage and also the latency.
> Once this is done, I think we can remove the ClusterConnection completely, 
> and start to rewrite the old sync client based on the async client, which 
> could reduce the code base a lot for our client.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21789) Rewrite MetaTableAccessor.multiMutate with Table.coprocessorService

2019-01-27 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753384#comment-16753384
 ] 

Hudson commented on HBASE-21789:


Results for branch master
[build #750 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/750/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/750//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/750//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/750//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Rewrite MetaTableAccessor.multiMutate with Table.coprocessorService
> ---
>
> Key: HBASE-21789
> URL: https://issues.apache.org/jira/browse/HBASE-21789
> Project: HBase
>  Issue Type: Improvement
>  Components: Client, Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21789-v1.patch, HBASE-21789.patch
>
>
> Now it implements a special RegionServerCallable, which is not necessary. It 
> is just a coprocessor call to MultiRowMutationEndpoint, we should use the 
> coprocessor related method to do this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21782) LoadIncrementalHFiles should not be IA.Public

2019-01-27 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753383#comment-16753383
 ] 

Hudson commented on HBASE-21782:


Results for branch master
[build #750 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/750/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/750//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/750//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/750//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> LoadIncrementalHFiles should not be IA.Public
> -
>
> Key: HBASE-21782
> URL: https://issues.apache.org/jira/browse/HBASE-21782
> Project: HBase
>  Issue Type: Task
>  Components: mapreduce
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21782-v1.patch, HBASE-21782.patch
>
>
> It is an implementation class, so some of the methods which are only supposed 
> to be used by replication sink are also public to users. And it exposes 
> methods which take Table and Connection as parameter and inside the 
> implementation we assume that they are HTable and ConnectionImplementation, 
> which will be a pain when we want to replace the sync client implementation 
> with async client.
> Here I think we should make the implementation class as 
> IA.LimitPrivate(TOOL), and introduce an interface for bulking hfiles 
> programmatically.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21778) Remove the usage of the locateRegion related methods in ClusterConnection

2019-01-27 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753376#comment-16753376
 ] 

Hadoop QA commented on HBASE-21778:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 23 new or modified test 
files. {color} |
|| || || || {color:brown} HBASE-21512 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
25s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
15s{color} | {color:green} HBASE-21512 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
58s{color} | {color:green} HBASE-21512 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
58s{color} | {color:green} HBASE-21512 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
10s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m  
3s{color} | {color:green} HBASE-21512 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
3s{color} | {color:green} HBASE-21512 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m  
1s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 38s{color} 
| {color:red} hbase-client generated 2 new + 98 unchanged - 2 fixed = 100 total 
(was 100) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
35s{color} | {color:green} hbase-client: The patch generated 0 new + 237 
unchanged - 7 fixed = 237 total (was 244) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m 
11s{color} | {color:red} hbase-server: The patch generated 1 new + 163 
unchanged - 28 fixed = 164 total (was 191) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
15s{color} | {color:green} hbase-it: The patch generated 0 new + 5 unchanged - 
1 fixed = 5 total (was 6) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 7s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
8m 40s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m 
15s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}125m 
28s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m  
1s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  1m 
18s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}176m 55s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | 

[jira] [Work started] (HBASE-17942) Disable region splits and merges per table

2019-01-27 Thread Nihal Jain (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-17942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-17942 started by Nihal Jain.
--
> Disable region splits and merges per table
> --
>
> Key: HBASE-17942
> URL: https://issues.apache.org/jira/browse/HBASE-17942
> Project: HBase
>  Issue Type: New Feature
>Reporter: Vladimir Rodionov
>Assignee: Nihal Jain
>Priority: Major
>
> Snapshot of a large tables usually fails when region split/merge happens 
> during snapshot. HBASE-15128 has introduced enable/disable switch for split 
> /merges, but only cluster - wide which is not always good in a large 
> deployments. The new feature will improve snapshot stability ands performance 
> for a single table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-21793) AsyncBatchRpcRetryingCaller should have the ability to deal with action from different tables

2019-01-27 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-21793:
-

 Summary: AsyncBatchRpcRetryingCaller should have the ability to 
deal with action from different tables
 Key: HBASE-21793
 URL: https://issues.apache.org/jira/browse/HBASE-21793
 Project: HBase
  Issue Type: Sub-task
  Components: asyncclient, Client
Reporter: Duo Zhang


We need this to implement HTableMultiPlexer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (HBASE-17942) Disable region splits and merges per table

2019-01-27 Thread Nihal Jain (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-17942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nihal Jain reassigned HBASE-17942:
--

Assignee: Nihal Jain  (was: Vladimir Rodionov)

> Disable region splits and merges per table
> --
>
> Key: HBASE-17942
> URL: https://issues.apache.org/jira/browse/HBASE-17942
> Project: HBase
>  Issue Type: New Feature
>Reporter: Vladimir Rodionov
>Assignee: Nihal Jain
>Priority: Major
>
> Snapshot of a large tables usually fails when region split/merge happens 
> during snapshot. HBASE-15128 has introduced enable/disable switch for split 
> /merges, but only cluster - wide which is not always good in a large 
> deployments. The new feature will improve snapshot stability ands performance 
> for a single table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-17942) Disable region splits and merges per table

2019-01-27 Thread Nihal Jain (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-17942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753363#comment-16753363
 ] 

Nihal Jain commented on HBASE-17942:


Thanks [~vrodionov]

> Disable region splits and merges per table
> --
>
> Key: HBASE-17942
> URL: https://issues.apache.org/jira/browse/HBASE-17942
> Project: HBase
>  Issue Type: New Feature
>Reporter: Vladimir Rodionov
>Assignee: Nihal Jain
>Priority: Major
>
> Snapshot of a large tables usually fails when region split/merge happens 
> during snapshot. HBASE-15128 has introduced enable/disable switch for split 
> /merges, but only cluster - wide which is not always good in a large 
> deployments. The new feature will improve snapshot stability ands performance 
> for a single table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21404) Master/RS navbar active state does not work

2019-01-27 Thread Nihal Jain (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753359#comment-16753359
 ] 

Nihal Jain commented on HBASE-21404:


Submitted [^HBASE-21404.master.002.patch] after removing trailing white-space. 

Could you please review [~tianjingyun], [~zghaobac]?

> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Affects Versions: 3.0.0, 2.0.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-21404.master.001.patch, 
> HBASE-21404.master.001.patch, HBASE-21404.master.002.patch, 
> master_after_patch.png, master_before.png, rs_after_patch.png, rs_before.png
>
>
> In master/rs web UI, the current active tab is not updated when user switches 
> to any tab other than "Home" tab.
> For example: even though say if we are on "tabledetailed.jsp", the navbar 
> does not update the active state of that tab. See master_before.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21404) Master/RS navbar active state does not work

2019-01-27 Thread Nihal Jain (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nihal Jain updated HBASE-21404:
---
Attachment: HBASE-21404.master.002.patch

> Master/RS navbar active state does not work
> ---
>
> Key: HBASE-21404
> URL: https://issues.apache.org/jira/browse/HBASE-21404
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Affects Versions: 3.0.0, 2.0.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-21404.master.001.patch, 
> HBASE-21404.master.001.patch, HBASE-21404.master.002.patch, 
> master_after_patch.png, master_before.png, rs_after_patch.png, rs_before.png
>
>
> In master/rs web UI, the current active tab is not updated when user switches 
> to any tab other than "Home" tab.
> For example: even though say if we are on "tabledetailed.jsp", the navbar 
> does not update the active state of that tab. See master_before.png



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21791) Upgrade thrift dependency to 0.12.0

2019-01-27 Thread Duo Zhang (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753342#comment-16753342
 ] 

Duo Zhang commented on HBASE-21791:
---

All green, good. The way to generate the patch is:

1. Change the thrift.version to 0.12.0 in the root pom.xml.
2. Use the thrift compiler to generate the java code both thrift1 and thrift2. 
The command is
{noformat}
thrift --gen java thrift/Hbase.thrift
thrift --gen java thrift2/hbase.thrift 
{noformat}
The generated java code files will be placed under the gen-java directory, 
please move them to the src/main/java directory. Haven't tried to set output 
directory directly when running thrift command, maybe also fine.

Try 'mvn clean install -DskipTests' to see if there are compile errors, if not, 
we are done.

> Upgrade thrift dependency to 0.12.0
> ---
>
> Key: HBASE-21791
> URL: https://issues.apache.org/jira/browse/HBASE-21791
> Project: HBase
>  Issue Type: Task
>  Components: Thrift
>Affects Versions: 3.0.0, 1.5.0, 1.3.3, 2.2.0, 1.4.9, 2.1.2, 1.2.10, 2.0.4
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Blocker
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.1.3, 2.0.5
>
> Attachments: HBASE-21791.patch
>
>
> As somebody have already known, that there is a CVE for thrift from 0.5.0 to 
> 0.11.0.
> https://nvd.nist.gov/vuln/detail/CVE-2018-1320
> As the CVE is already public, let's upgrade our thrift dependency and release 
> new versions ASAP.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21778) Remove the usage of the locateRegion related methods in ClusterConnection

2019-01-27 Thread Duo Zhang (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-21778:
--
Attachment: HBASE-21778-HBASE-21512-v1.patch

> Remove the usage of the locateRegion related methods in ClusterConnection
> -
>
> Key: HBASE-21778
> URL: https://issues.apache.org/jira/browse/HBASE-21778
> Project: HBase
>  Issue Type: Sub-task
>  Components: Client
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-21778-HBASE-21512-v1.patch, 
> HBASE-21778-HBASE-21512.patch
>
>
> As now RegionLocator can give you everything. So later we could remove the 
> ClusterConnection completely.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21057) upgrade to latest spotbugs

2019-01-27 Thread kevin su (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753328#comment-16753328
 ] 

kevin su commented on HBASE-21057:
--

[~busbey] it works,could I mark it as resolved.

> upgrade to latest spotbugs
> --
>
> Key: HBASE-21057
> URL: https://issues.apache.org/jira/browse/HBASE-21057
> Project: HBase
>  Issue Type: Task
>  Components: community, test
>Affects Versions: 3.0.0
>Reporter: Sean Busbey
>Assignee: kevin su
>Priority: Minor
>  Labels: beginner
> Fix For: 3.0.0
>
> Attachments: HBASE-21057.v0.patch, HBASE-21057.v1.patch, 
> HBASE-21057.v1.patch
>
>
> we currently rely on [spotbugs definitions from 
> 3.1.0-RC3|https://github.com/spotbugs/spotbugs/releases/tag/3.1.0_RC3], which 
> was a pre-release candidate from Jun 2017.
> [spotbugs version 
> 3.1.6|https://github.com/spotbugs/spotbugs/releases/tag/3.1.6] came out about 
> a month ago. We should update to the latest.
> they also have their own maven plugin now. as a stretch goal we could switch 
> over to that, if it works with yetus.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (HBASE-20754) quickstart guide should instruct folks to set JAVA_HOME to a JDK installation.

2019-01-27 Thread kevin su (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-20754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

kevin su reassigned HBASE-20754:


Assignee: kevin su

> quickstart guide should instruct folks to set JAVA_HOME to a JDK installation.
> --
>
> Key: HBASE-20754
> URL: https://issues.apache.org/jira/browse/HBASE-20754
> Project: HBase
>  Issue Type: Bug
>  Components: documentation
>Reporter: Sean Busbey
>Assignee: kevin su
>Priority: Major
>  Labels: beginner
>
> The quickstart guide currently instructs folks to set JAVA_HOME, but to the 
> wrong place
> {code}
> The JAVA_HOME variable should be set to a directory which contains the 
> executable file bin/java. Most modern Linux operating systems provide a 
> mechanism, such as /usr/bin/alternatives on RHEL or CentOS, for transparently 
> switching between versions of executables such as Java. In this case, you can 
> set JAVA_HOME to the directory containing the symbolic link to bin/java, 
> which is usually /usr.
> JAVA_HOME=/usr
> {code}
> instead, it should tell folks to point it to a jdk installation and help them 
> on how to find that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21778) Remove the usage of the locateRegion related methods in ClusterConnection

2019-01-27 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753322#comment-16753322
 ] 

Hadoop QA commented on HBASE-21778:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 23 new or modified test 
files. {color} |
|| || || || {color:brown} HBASE-21512 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
25s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
17s{color} | {color:green} HBASE-21512 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m  
1s{color} | {color:green} HBASE-21512 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
 0s{color} | {color:green} HBASE-21512 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 8s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m  
8s{color} | {color:green} HBASE-21512 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
3s{color} | {color:green} HBASE-21512 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m  
3s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 40s{color} 
| {color:red} hbase-client generated 2 new + 98 unchanged - 2 fixed = 100 total 
(was 100) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
34s{color} | {color:green} hbase-client: The patch generated 0 new + 242 
unchanged - 2 fixed = 242 total (was 244) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m  
9s{color} | {color:red} hbase-server: The patch generated 16 new + 165 
unchanged - 26 fixed = 181 total (was 191) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
15s{color} | {color:green} hbase-it: The patch generated 0 new + 5 unchanged - 
1 fixed = 5 total (was 6) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 1s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 8s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
8m 50s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 
or 3.0.0. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m  
7s{color} | {color:red} hbase-client generated 2 new + 0 unchanged - 0 fixed = 
2 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m 
18s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}126m 
58s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
12s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  1m 
16s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}178m 58s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-client |
|  |  instanceof 

[jira] [Commented] (HBASE-21791) Upgrade thrift dependency to 0.12.0

2019-01-27 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753319#comment-16753319
 ] 

Hadoop QA commented on HBASE-21791:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
26s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  5m 
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
31s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color} 
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
52s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  5m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  5m 
57s{color} | {color:green} root generated 0 new + 1136 unchanged - 15 fixed = 
1136 total (was 1151) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
30s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
9m 46s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 
or 3.0.0. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color} 
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  3m  
1s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}191m 
36s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
56s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}250m 47s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21791 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12956476/HBASE-21791.patch |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs