[GitHub] [hbase] Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo
Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo URL: https://github.com/apache/hbase/pull/392#issuecomment-516293220 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 279 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 28 | master passed | | +1 | shadedjars | 255 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 21 | master passed | | 0 | spotbugs | 65 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 63 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 285 | the patch passed | | +1 | compile | 25 | the patch passed | | +1 | javac | 25 | the patch passed | | +1 | checkstyle | 30 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 262 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 872 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 20 | hbase-client generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) | | +1 | findbugs | 71 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 102 | hbase-client in the patch passed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 2718 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/34/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/392 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 37b8d148f163 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-392/out/precommit/personality/provided.sh | | git revision | master / c286a31590 | | Default Java | 1.8.0_181 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/34/artifact/out/diff-javadoc-javadoc-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/34/testReport/ | | Max. process+thread count | 288 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/34/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-516294663 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 288 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 14 | master passed | | +1 | shadedjars | 267 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 17 | master passed | | 0 | spotbugs | 45 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 43 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 290 | the patch passed | | +1 | compile | 23 | the patch passed | | +1 | javac | 23 | the patch passed | | +1 | checkstyle | 11 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 266 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 896 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 21 | the patch passed | | +1 | findbugs | 53 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 389 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 3017 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/31/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3ee0d370f069 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / c286a31590 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/31/testReport/ | | Max. process+thread count | 4401 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/31/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #431: HBASE-22764 Fixed remaining Checkstyle issues in the hbase-rsgroup module
Apache-HBase commented on issue #431: HBASE-22764 Fixed remaining Checkstyle issues in the hbase-rsgroup module URL: https://github.com/apache/hbase/pull/431#issuecomment-516294899 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 297 | master passed | | +1 | compile | 25 | master passed | | +1 | checkstyle | 13 | master passed | | +1 | shadedjars | 268 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 20 | master passed | | 0 | spotbugs | 45 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 43 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 296 | the patch passed | | +1 | compile | 23 | the patch passed | | +1 | javac | 23 | the patch passed | | +1 | checkstyle | 13 | hbase-rsgroup: The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 268 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 950 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 20 | the patch passed | | +1 | findbugs | 49 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 351 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 24 | The patch does not generate ASF License warnings. | | | | 3098 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-431/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/431 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d650bdc97ef5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-431/out/precommit/personality/provided.sh | | git revision | master / c286a31590 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-431/4/testReport/ | | Max. process+thread count | 4578 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-431/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895847#comment-16895847
]
Viraj Jasani commented on HBASE-22735:
--
Sure, I will look into rubocop cleanup.
In the meanwhile, a sample output for reference:
{code:java}
hbase(main):001:0> list_regions 'TEST_TABLE3'
Can not find region:
TEST_TABLE3,,1556742682042.c01915e746f27516c1b37b9278fcd010. , it may be
disabled or in transition
Can not find region:
TEST_TABLE3,\x02\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00,1556742682042.1bb308132822e5ff3ca87048caaf50b9.
, it may be disabled or in transition
SERVER_NAME | REGION_NAME | START_KEY | END_KEY | SIZE | REQ | LOCALITY |
-- |
--
|
|
| - | - | -- |
testserver123.rsserv1.abc.def.lpzk.xyz,60020,1564332024546 |
TEST_TABLE3,,1556742682042.c01915e746f27516c1b37b9278fcd010. | |
\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
| | | |
testserver123.rsserv2.abc.def.lpzk.xyz,60020,1564332491127 |
TEST_TABLE3,\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00,1556742682042.54c6996f01462ef483bb48421f4625f7.
|
\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
|
\x02\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
| 0 | 15 | 0.0 |
testserver123.rsserv1.abc.def.lpzk.xyz,60020,1564332024546 |
TEST_TABLE3,\x02\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00,1556742682042.1bb308132822e5ff3ca87048caaf50b9.
|
\x02\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
|
\x03\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
| | | |
testserver123.rsserv2.abc.def.lpzk.xyz,60020,1564332491127 |
TEST_TABLE3,\x03\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00,1556742682042.613b90d5fae73ad37d0a14970a457df4.
|
\x03\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
|
\x04\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
| 0 | 15 | 0.0 |
testserver123.rsserv2.abc.def.lpzk.xyz,60020,1564332491127 |
TEST_TABLE3,\x04\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00,1556742682042.049037c3b9a28d07562c255c28b5b7f0.
|
\x04\x00\x00\x00\x00\x
[jira] [Updated] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani updated HBASE-22735:
-
Attachment: list_regions.out
> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch,
> HBASE-22735.master.01.patch, list_regions.out
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895847#comment-16895847
]
Viraj Jasani edited comment on HBASE-22735 at 7/30/19 7:14 AM:
---
Sure, I will look into rubocop cleanup.
In the meanwhile, attaching a sample output for reference: list_regions.out
was (Author: vjasani):
Sure, I will look into rubocop cleanup.
In the meanwhile, a sample output for reference:
{code:java}
hbase(main):001:0> list_regions 'TEST_TABLE3'
Can not find region:
TEST_TABLE3,,1556742682042.c01915e746f27516c1b37b9278fcd010. , it may be
disabled or in transition
Can not find region:
TEST_TABLE3,\x02\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00,1556742682042.1bb308132822e5ff3ca87048caaf50b9.
, it may be disabled or in transition
SERVER_NAME | REGION_NAME | START_KEY | END_KEY | SIZE | REQ | LOCALITY |
-- |
--
|
|
| - | - | -- |
testserver123.rsserv1.abc.def.lpzk.xyz,60020,1564332024546 |
TEST_TABLE3,,1556742682042.c01915e746f27516c1b37b9278fcd010. | |
\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
| | | |
testserver123.rsserv2.abc.def.lpzk.xyz,60020,1564332491127 |
TEST_TABLE3,\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00,1556742682042.54c6996f01462ef483bb48421f4625f7.
|
\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
|
\x02\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
| 0 | 15 | 0.0 |
testserver123.rsserv1.abc.def.lpzk.xyz,60020,1564332024546 |
TEST_TABLE3,\x02\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00,1556742682042.1bb308132822e5ff3ca87048caaf50b9.
|
\x02\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
|
\x03\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
| | | |
testserver123.rsserv2.abc.def.lpzk.xyz,60020,1564332491127 |
TEST_TABLE3,\x03\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00,1556742682042.613b90d5fae73ad37d0a14970a457df4.
|
\x03\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
|
\x04\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
| 0 | 15 | 0.0 |
testserver123.rsserv2.abc.def.lpzk.xyz,60020,1564332491127 |
TEST_TABLE3,\x04\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
[GitHub] [hbase] Apache-HBase commented on issue #403: HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentMan
Apache-HBase commented on issue #403: HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentManager RegionsStateStore URL: https://github.com/apache/hbase/pull/403#issuecomment-516296477 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for branch | | +1 | mvninstall | 272 | master passed | | +1 | compile | 73 | master passed | | +1 | checkstyle | 99 | master passed | | +1 | shadedjars | 261 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 50 | master passed | | 0 | spotbugs | 234 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 294 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 276 | the patch passed | | -1 | compile | 37 | hbase-server in the patch failed. | | -1 | javac | 37 | hbase-server in the patch failed. | | -1 | checkstyle | 69 | hbase-server: The patch generated 3 new + 39 unchanged - 0 fixed = 42 total (was 39) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 253 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 869 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 56 | the patch passed | | -1 | findbugs | 38 | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 | unit | 114 | hbase-client in the patch passed. | | -1 | unit | 57 | hbase-server in the patch failed. | | +1 | asflicense | 20 | The patch does not generate ASF License warnings. | | | | 3407 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/28/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/403 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3ae8331cdb7b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-403/out/precommit/personality/provided.sh | | git revision | master / c286a31590 | | Default Java | 1.8.0_181 | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/28/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/28/artifact/out/patch-compile-hbase-server.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/28/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/28/artifact/out/patch-findbugs-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/28/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/28/testReport/ | | Max. process+thread count | 292 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/28/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #430: HBASE-22763 Fixed remaining Checkstyle issue in hbase-procedure
Apache-HBase commented on issue #430: HBASE-22763 Fixed remaining Checkstyle issue in hbase-procedure URL: https://github.com/apache/hbase/pull/430#issuecomment-516299023 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 41 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 310 | master passed | | +1 | compile | 19 | master passed | | +1 | checkstyle | 13 | master passed | | +1 | shadedjars | 282 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 16 | master passed | | 0 | spotbugs | 35 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 33 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 310 | the patch passed | | +1 | compile | 17 | the patch passed | | +1 | javac | 17 | the patch passed | | +1 | checkstyle | 13 | hbase-procedure: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 287 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1364 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 60 | the patch passed | | +1 | findbugs | 142 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 398 | hbase-procedure in the patch passed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 3922 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-430/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/430 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f2cf0c9edd03 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-430/out/precommit/personality/provided.sh | | git revision | master / c286a31590 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-430/4/testReport/ | | Max. process+thread count | 311 (vs. ulimit of 1) | | modules | C: hbase-procedure U: hbase-procedure | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-430/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr…
Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr… URL: https://github.com/apache/hbase/pull/429#issuecomment-516300115 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 277 | master passed | | +1 | javadoc | 11 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 290 | the patch passed | | -1 | rubocop | 5 | The patch generated 12 new + 13 unchanged - 8 fixed = 25 total (was 21) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | javadoc | 12 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 412 | hbase-shell in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 1127 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/429 | | Optional Tests | dupname asflicense javac javadoc unit rubocop | | uname | Linux 21bb00f6b400 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-429/out/precommit/personality/provided.sh | | git revision | master / 124fa3488a | | Default Java | 1.8.0_181 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/5/artifact/out/diff-patch-rubocop.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/5/testReport/ | | Max. process+thread count | 2626 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #420: HBASE-22753 Removed deprecated ImmutableHRegionInfo
Apache-HBase commented on issue #420: HBASE-22753 Removed deprecated ImmutableHRegionInfo URL: https://github.com/apache/hbase/pull/420#issuecomment-516304551 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 89 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 25 | Maven dependency ordering for branch | | -1 | mvninstall | 105 | root in master failed. | | -1 | compile | 31 | hbase-server in master failed. | | +1 | checkstyle | 99 | master passed | | +1 | shadedjars | 256 | branch has no errors when building our shaded downstream artifacts. | | -1 | javadoc | 28 | hbase-server in master failed. | | 0 | spotbugs | 64 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 33 | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | -1 | mvninstall | 84 | root in the patch failed. | | -1 | compile | 35 | hbase-server in the patch failed. | | -1 | javac | 35 | hbase-server in the patch failed. | | +1 | checkstyle | 26 | hbase-client: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 | checkstyle | 71 | hbase-server: The patch generated 0 new + 215 unchanged - 4 fixed = 215 total (was 219) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 253 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 71 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 145 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 222 | The patch causes 10 errors with Hadoop v3.1.2. | | -1 | javadoc | 29 | hbase-server in the patch failed. | | -1 | findbugs | 35 | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 | unit | 104 | hbase-client in the patch passed. | | -1 | unit | 36 | hbase-server in the patch failed. | | +1 | asflicense | 19 | The patch does not generate ASF License warnings. | | | | 1899 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/11/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/420 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux dc38982bdf83 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-420/out/precommit/personality/provided.sh | | git revision | master / 124fa3488a | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/11/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/11/artifact/out/branch-compile-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/11/artifact/out/branch-javadoc-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/11/artifact/out/branch-findbugs-hbase-server.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/11/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/11/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/11/artifact/out/patch-compile-hbase-server.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/11/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/11/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/11/artifact/out/patch-javac-3.1.2.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/11/artifact/out/patch-javadoc-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/11/artifact/out/patch-findbugs-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/11/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://bui
[jira] [Reopened] (HBASE-22751) table.jsp fails if ugly regions in table
[ https://issues.apache.org/jira/browse/HBASE-22751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi reopened HBASE-22751: --- Reopening. Commit caused compile errors on branch-2.0, branch-2.1 and branch-2.2. > table.jsp fails if ugly regions in table > > > Key: HBASE-22751 > URL: https://issues.apache.org/jira/browse/HBASE-22751 > Project: HBase > Issue Type: Bug > Components: UI >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22751.master.001.patch, > HBASE-22751.master.001.patch > > > I'm playing w/ messing up hbase:meta as part of hbck2 messings. Noticed that > a bad server or an unknown region makes it so the table.jsp fails. > I noticed that Admin trying to get the compaction stats for the table will > get stuck trying to contact an unknown region and that when it does complete > eventually (tens of minutes...), it will spew an exception in the compaction > state location. > The listing of servers has an issue where if unknown server, then we'll try > to use a null address which does another spew of jsp complaint instead of > just logging an unknown > I tried messing around with Admin trying to set its Operation Timeout... but > Operation Timeout is not really settable unless you get a new Configuration > for a new Connection -- which is madness -- so instead just used the new > AsyncAdminBuilder where I can set operation timeout > It times out too quick but thats another issue the UI at least draws with > a messy hbase;meta. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #403: HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentMan
Apache-HBase commented on issue #403: HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentManager RegionsStateStore URL: https://github.com/apache/hbase/pull/403#issuecomment-516304995 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 60 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 11 | Maven dependency ordering for branch | | -1 | mvninstall | 88 | root in master failed. | | -1 | compile | 36 | hbase-server in master failed. | | +1 | checkstyle | 95 | master passed | | +1 | shadedjars | 254 | branch has no errors when building our shaded downstream artifacts. | | -1 | javadoc | 28 | hbase-server in master failed. | | 0 | spotbugs | 64 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 27 | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for patch | | -1 | mvninstall | 83 | root in the patch failed. | | -1 | compile | 33 | hbase-server in the patch failed. | | -1 | javac | 33 | hbase-server in the patch failed. | | -1 | checkstyle | 69 | hbase-server: The patch generated 3 new + 39 unchanged - 0 fixed = 42 total (was 39) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 258 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 74 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 145 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 222 | The patch causes 10 errors with Hadoop v3.1.2. | | -1 | javadoc | 28 | hbase-server in the patch failed. | | -1 | findbugs | 36 | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 | unit | 107 | hbase-client in the patch passed. | | -1 | unit | 35 | hbase-server in the patch failed. | | +1 | asflicense | 17 | The patch does not generate ASF License warnings. | | | | 1828 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/29/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/403 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7a60b5916922 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-403/out/precommit/personality/provided.sh | | git revision | master / 124fa3488a | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/29/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/29/artifact/out/branch-compile-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/29/artifact/out/branch-javadoc-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/29/artifact/out/branch-findbugs-hbase-server.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/29/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/29/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/29/artifact/out/patch-compile-hbase-server.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/29/artifact/out/diff-checkstyle-hbase-server.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/29/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/29/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/29/artifact/out/patch-javac-3.1.2.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/29/artifact/out/patch-javadoc-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/29/artifact/out/patch-findbugs-hbase-server.txt | | unit | https://b
[jira] [Reopened] (HBASE-22723) Have CatalogJanitor report holes and overlaps; i.e. problems it sees when doing its regular scan of hbase:meta
[ https://issues.apache.org/jira/browse/HBASE-22723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi reopened HBASE-22723: --- Reopening. Commit caused compile errors on branch-2.0, branch-2.1 and branch-2.2. > Have CatalogJanitor report holes and overlaps; i.e. problems it sees when > doing its regular scan of hbase:meta > -- > > Key: HBASE-22723 > URL: https://issues.apache.org/jira/browse/HBASE-22723 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22723.branch-2.001.patch, > HBASE-22723.branch-2.002.patch, HBASE-22723.branch-2.003.patch, > HBASE-22723.branch-2.004.patch, HBASE-22723.branch-2.005.patch, > HBASE-22723.branch-2.006.patch, HBASE-22723.branch-2.007.patch > > > CatalogJanitor scans hbase:meta on a configurable period. Currently it just > looks for splits and merges to gc. Might as well generate a report on stuff > like holds, overlaps, empty regioninfos, and unknown servers while it is at > it. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #420: HBASE-22753 Removed deprecated ImmutableHRegionInfo
Apache-HBase commented on issue #420: HBASE-22753 Removed deprecated ImmutableHRegionInfo URL: https://github.com/apache/hbase/pull/420#issuecomment-516308029 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 74 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 24 | Maven dependency ordering for branch | | +1 | mvninstall | 307 | master passed | | +1 | compile | 77 | master passed | | +1 | checkstyle | 118 | master passed | | +1 | shadedjars | 278 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 55 | master passed | | 0 | spotbugs | 261 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 327 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 304 | the patch passed | | +1 | compile | 89 | the patch passed | | +1 | javac | 89 | the patch passed | | +1 | checkstyle | 39 | hbase-client: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 | checkstyle | 85 | hbase-server: The patch generated 0 new + 215 unchanged - 4 fixed = 215 total (was 219) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 280 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 944 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 63 | the patch passed | | +1 | findbugs | 367 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 115 | hbase-client in the patch passed. | | -1 | unit | 1620 | hbase-server in the patch failed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 5600 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.util.compaction.TestMajorCompactionRequest | | | hadoop.hbase.regionserver.TestRegionInfoBuilder | | | hadoop.hbase.util.compaction.TestMajorCompactionTTLRequest | | | hadoop.hbase.master.cleaner.TestReplicationHFileCleaner | | | hadoop.hbase.regionserver.TestBlocksScanned | | | hadoop.hbase.util.TestJSONMetricUtil | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/420 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 5efc29951c80 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-420/out/precommit/personality/provided.sh | | git revision | master / c286a31590 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/10/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/10/testReport/ | | Max. process+thread count | 629 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/10/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet merged pull request #430: HBASE-22763 Fixed remaining Checkstyle issue in hbase-procedure
HorizonNet merged pull request #430: HBASE-22763 Fixed remaining Checkstyle issue in hbase-procedure URL: https://github.com/apache/hbase/pull/430 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-516309465 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 75 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for branch | | -1 | mvninstall | 74 | root in master failed. | | -1 | compile | 19 | hbase-client in master failed. | | -1 | compile | 33 | hbase-server in master failed. | | +1 | checkstyle | 99 | master passed | | +1 | shadedjars | 264 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 51 | master passed | | 0 | spotbugs | 373 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 21 | hbase-client in master failed. | | -1 | findbugs | 35 | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for patch | | -1 | mvninstall | 75 | root in the patch failed. | | -1 | compile | 19 | hbase-client in the patch failed. | | -1 | compile | 36 | hbase-server in the patch failed. | | -1 | javac | 19 | hbase-client in the patch failed. | | -1 | javac | 36 | hbase-server in the patch failed. | | +1 | checkstyle | 101 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 262 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 51 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 103 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 163 | The patch causes 10 errors with Hadoop v3.1.2. | | -1 | javadoc | 34 | hbase-server generated 28 new + 7 unchanged - 0 fixed = 35 total (was 7) | | -1 | findbugs | 20 | hbase-client in the patch failed. | | -1 | findbugs | 36 | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 18 | hbase-client in the patch failed. | | -1 | unit | 37 | hbase-server in the patch failed. | | +1 | asflicense | 20 | The patch does not generate ASF License warnings. | | | | 1609 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/43/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3459b4b13d21 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / 124fa3488a | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/43/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/43/artifact/out/branch-compile-hbase-client.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/43/artifact/out/branch-compile-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/43/artifact/out/branch-findbugs-hbase-client.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/43/artifact/out/branch-findbugs-hbase-server.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/43/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/43/artifact/out/patch-compile-hbase-client.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/43/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/43/artifact/out/patch-compile-hbase-client.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/43/artifact/out/patch-compile-hbase-server.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/43/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/43/artifact/out/patch-javac-2.9.2.txt |
[GitHub] [hbase] Apache-HBase commented on issue #430: HBASE-22763 Fixed remaining Checkstyle issue in hbase-procedure
Apache-HBase commented on issue #430: HBASE-22763 Fixed remaining Checkstyle issue in hbase-procedure URL: https://github.com/apache/hbase/pull/430#issuecomment-516310591 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 81 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 305 | master passed | | +1 | compile | 20 | master passed | | +1 | checkstyle | 14 | master passed | | +1 | shadedjars | 307 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 17 | master passed | | 0 | spotbugs | 42 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 39 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 319 | the patch passed | | +1 | compile | 18 | the patch passed | | +1 | javac | 18 | the patch passed | | +1 | checkstyle | 15 | hbase-procedure: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 283 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 963 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 16 | the patch passed | | +1 | findbugs | 46 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 216 | hbase-procedure in the patch passed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 3069 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-430/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/430 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d197a08b7c31 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-430/out/precommit/personality/provided.sh | | git revision | master / 124fa3488a | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-430/5/testReport/ | | Max. process+thread count | 277 (vs. ulimit of 1) | | modules | C: hbase-procedure U: hbase-procedure | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-430/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #414: HBASE-22744 Removed deprecated status and load classes in client module
Apache-HBase commented on issue #414: HBASE-22744 Removed deprecated status and load classes in client module URL: https://github.com/apache/hbase/pull/414#issuecomment-516310739 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 6 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for branch | | +1 | mvninstall | 297 | master passed | | +1 | compile | 122 | master passed | | +1 | checkstyle | 130 | master passed | | +1 | shadedjars | 270 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 88 | master passed | | 0 | spotbugs | 55 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 385 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 315 | the patch passed | | +1 | compile | 124 | the patch passed | | +1 | javac | 124 | the patch passed | | +1 | checkstyle | 36 | hbase-client: The patch generated 0 new + 180 unchanged - 3 fixed = 180 total (was 183) | | +1 | checkstyle | 12 | The patch passed checkstyle in hbase-zookeeper | | +1 | checkstyle | 75 | The patch passed checkstyle in hbase-server | | +1 | checkstyle | 16 | The patch passed checkstyle in hbase-rest | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 266 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 899 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 86 | the patch passed | | +1 | findbugs | 416 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 109 | hbase-client in the patch passed. | | +1 | unit | 48 | hbase-zookeeper in the patch passed. | | -1 | unit | 1774 | hbase-server in the patch failed. | | -1 | unit | 103 | hbase-rest in the patch failed. | | +1 | asflicense | 46 | The patch does not generate ASF License warnings. | | | | 6086 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.rest.model.TestStorageClusterStatusModel | | | hadoop.hbase.rest.TestSecureRESTServer | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-414/13/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/414 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 87b27b24a14d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-414/out/precommit/personality/provided.sh | | git revision | master / c286a31590 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-414/13/artifact/out/patch-unit-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-414/13/artifact/out/patch-unit-hbase-rest.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-414/13/testReport/ | | Max. process+thread count | 700 (vs. ulimit of 1) | | modules | C: hbase-client hbase-zookeeper hbase-server hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-414/13/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo
Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo URL: https://github.com/apache/hbase/pull/392#issuecomment-516311614 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 60 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 311 | master passed | | +1 | compile | 23 | master passed | | +1 | checkstyle | 28 | master passed | | +1 | shadedjars | 259 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 20 | master passed | | 0 | spotbugs | 68 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 66 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 286 | the patch passed | | +1 | compile | 22 | the patch passed | | +1 | javac | 22 | the patch passed | | +1 | checkstyle | 27 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 259 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 873 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 19 | hbase-client generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) | | +1 | findbugs | 70 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 89 | hbase-client in the patch failed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 2775 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestMetricsConnection | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/35/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/392 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9156c85fc77d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-392/out/precommit/personality/provided.sh | | git revision | master / 124fa3488a | | Default Java | 1.8.0_181 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/35/artifact/out/diff-javadoc-javadoc-hbase-client.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/35/artifact/out/patch-unit-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/35/testReport/ | | Max. process+thread count | 104 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/35/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22741) Show catalogjanitor consistency complaints in new 'HBCK Report' page
[
https://issues.apache.org/jira/browse/HBASE-22741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895895#comment-16895895
]
HBase QA commented on HBASE-22741:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
0s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
5s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
29s{color} | {color:red} hbase-server: The patch generated 11 new + 7 unchanged
- 0 fixed = 18 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
59s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
20m 3s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
40s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
44s{color} | {color:red} hbase-server generated 5 new + 0 unchanged - 0 fixed =
5 total (was 0) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}294m 6s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}366m 48s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestFromClientSideWithCoprocessor |
| | hadoop.hbase.client.TestFromClientSide3 |
| | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
| | hadoop.hbase.replication.TestReplicationSmallTestsSync |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/689/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22741 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976155/HBASE-22741.master.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 89cfd5995977 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25
05:29:03 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 0c80d5b42b |
| maven | version: Apache Maven
[jira] [Commented] (HBASE-22751) table.jsp fails if ugly regions in table
[ https://issues.apache.org/jira/browse/HBASE-22751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895900#comment-16895900 ] Peter Somogyi commented on HBASE-22751: --- Cherry-pick to these branches was incorrect. For branch-2 the change was merged with 2 commits and only 1 was cherry-picked to these branches. I'm reverting the commit and cherry-picking the 2 commits together. > table.jsp fails if ugly regions in table > > > Key: HBASE-22751 > URL: https://issues.apache.org/jira/browse/HBASE-22751 > Project: HBase > Issue Type: Bug > Components: UI >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22751.master.001.patch, > HBASE-22751.master.001.patch > > > I'm playing w/ messing up hbase:meta as part of hbck2 messings. Noticed that > a bad server or an unknown region makes it so the table.jsp fails. > I noticed that Admin trying to get the compaction stats for the table will > get stuck trying to contact an unknown region and that when it does complete > eventually (tens of minutes...), it will spew an exception in the compaction > state location. > The listing of servers has an issue where if unknown server, then we'll try > to use a null address which does another spew of jsp complaint instead of > just logging an unknown > I tried messing around with Admin trying to set its Operation Timeout... but > Operation Timeout is not really settable unless you get a new Configuration > for a new Connection -- which is madness -- so instead just used the new > AsyncAdminBuilder where I can set operation timeout > It times out too quick but thats another issue the UI at least draws with > a messy hbase;meta. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes
Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes URL: https://github.com/apache/hbase/pull/374#issuecomment-516316498 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 369 | master passed | | +1 | compile | 40 | master passed | | +1 | checkstyle | 47 | master passed | | +1 | shadedjars | 302 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 19 | master passed | | 0 | spotbugs | 46 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 43 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 287 | the patch passed | | +1 | compile | 21 | the patch passed | | +1 | javac | 21 | the patch passed | | -1 | checkstyle | 23 | hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 260 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 888 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 18 | the patch passed | | +1 | findbugs | 52 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 170 | hbase-common in the patch passed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 2936 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/34/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/374 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 4633d40d0377 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh | | git revision | master / 124fa3488a | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/34/artifact/out/diff-checkstyle-hbase-common.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/34/testReport/ | | Max. process+thread count | 292 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/34/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22723) Have CatalogJanitor report holes and overlaps; i.e. problems it sees when doing its regular scan of hbase:meta
[ https://issues.apache.org/jira/browse/HBASE-22723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895902#comment-16895902 ] Peter Somogyi commented on HBASE-22723: --- I'm reverting the change for now on branch-2.0, branch-2.1 and branch-2.2. The commits on master and branch-2 depend on HBASE-22408 which was committed to master and branch-2 only. [~stack], could you provide an updated patch for branch-2.0, branch-2.1 and branch-2.2? > Have CatalogJanitor report holes and overlaps; i.e. problems it sees when > doing its regular scan of hbase:meta > -- > > Key: HBASE-22723 > URL: https://issues.apache.org/jira/browse/HBASE-22723 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22723.branch-2.001.patch, > HBASE-22723.branch-2.002.patch, HBASE-22723.branch-2.003.patch, > HBASE-22723.branch-2.004.patch, HBASE-22723.branch-2.005.patch, > HBASE-22723.branch-2.006.patch, HBASE-22723.branch-2.007.patch > > > CatalogJanitor scans hbase:meta on a configurable period. Currently it just > looks for splits and merges to gc. Might as well generate a report on stuff > like holds, overlaps, empty regioninfos, and unknown servers while it is at > it. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] infraio commented on a change in pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration
infraio commented on a change in pull request #426: HBASE-22695 Store the
rsgroup of a table in table configuration
URL: https://github.com/apache/hbase/pull/426#discussion_r308592391
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminClient.java
##
@@ -76,7 +82,6 @@ public RSGroupInfo getRSGroupInfo(String groupName) throws
IOException {
}
}
- @Override
public RSGroupInfo getRSGroupInfoOfTable(TableName tableName) throws
IOException {
Review comment:
This method can be removed?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] infraio commented on a change in pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration
infraio commented on a change in pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration URL: https://github.com/apache/hbase/pull/426#discussion_r308592474 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java ## @@ -1,19 +1,12 @@ /** - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license Review comment: Wrong format here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration
Apache9 commented on a change in pull request #426: HBASE-22695 Store the
rsgroup of a table in table configuration
URL: https://github.com/apache/hbase/pull/426#discussion_r308595037
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminClient.java
##
@@ -76,7 +82,6 @@ public RSGroupInfo getRSGroupInfo(String groupName) throws
IOException {
}
}
- @Override
public RSGroupInfo getRSGroupInfoOfTable(TableName tableName) throws
IOException {
Review comment:
I think we will reference this method in hbase shell so do not want to
change it in this patch...
Let's do it in another issue. And in general, if we do not want to
completely remove the shell command, we'd better keep this method for a least a
whole major version?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] infraio commented on a change in pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration
infraio commented on a change in pull request #426: HBASE-22695 Store the
rsgroup of a table in table configuration
URL: https://github.com/apache/hbase/pull/426#discussion_r308595173
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
##
@@ -110,117 +95,91 @@ RSGroupAdminServiceImpl getGroupAdminService() {
return groupAdminService;
}
- private void assignTableToGroup(TableDescriptor desc) throws IOException {
-String groupName =
-
master.getClusterSchema().getNamespace(desc.getTableName().getNamespaceAsString())
-.getConfigurationValue(RSGroupInfo.NAMESPACE_DESC_PROP_GROUP);
-if (groupName == null) {
- groupName = RSGroupInfo.DEFAULT_GROUP;
-}
-RSGroupInfo rsGroupInfo = groupAdminServer.getRSGroupInfo(groupName);
-if (rsGroupInfo == null) {
- throw new ConstraintException(
- "Default RSGroup (" + groupName + ") for this table's namespace does
not exist.");
-}
-if (!rsGroupInfo.containsTable(desc.getTableName())) {
- LOG.debug("Pre-moving table " + desc.getTableName() + " to RSGroup " +
groupName);
- groupAdminServer.moveTables(Sets.newHashSet(desc.getTableName()),
groupName);
-}
- }
-
/
// MasterObserver overrides
/
- private boolean rsgroupHasServersOnline(TableDescriptor desc) throws
IOException {
-String groupName;
-try {
- groupName =
master.getClusterSchema().getNamespace(desc.getTableName().getNamespaceAsString())
- .getConfigurationValue(RSGroupInfo.NAMESPACE_DESC_PROP_GROUP);
- if (groupName == null) {
-groupName = RSGroupInfo.DEFAULT_GROUP;
- }
-} catch (MasterNotRunningException | PleaseHoldException e) {
- LOG.info("Master has not initialized yet; temporarily using default
RSGroup '" +
- RSGroupInfo.DEFAULT_GROUP + "' for deploy of system table");
- groupName = RSGroupInfo.DEFAULT_GROUP;
+ @Override
+ public void
postClearDeadServers(ObserverContext ctx,
+ List servers, List notClearedServers) throws
IOException {
+Set clearedServer =
+servers.stream().filter(server -> !notClearedServers.contains(server))
+.map(ServerName::getAddress).collect(Collectors.toSet());
+if (!clearedServer.isEmpty()) {
+ groupAdminServer.removeServers(clearedServer);
}
+ }
-RSGroupInfo rsGroupInfo = groupAdminServer.getRSGroupInfo(groupName);
-if (rsGroupInfo == null) {
- throw new ConstraintException(
- "Default RSGroup (" + groupName + ") for this table's " + "namespace
does not exist.");
+ private void checkGroupExists(Optional optGroupName) throws
IOException {
+if (optGroupName.isPresent()) {
+ String groupName = optGroupName.get();
+ if (groupAdminServer.getRSGroupInfo(groupName) == null) {
+throw new ConstraintException("Region server group " + groupName + "
does not exit");
+ }
}
+ }
-for (ServerName onlineServer :
master.getServerManager().createDestinationServersList()) {
- if (rsGroupInfo.getServers().contains(onlineServer.getAddress())) {
+ private boolean rsgroupHasServersOnline(TableDescriptor desc) throws
IOException {
+RSGroupInfo rsGroupInfo;
+Optional optGroupName = desc.getRegionServerGroup();
+if (optGroupName.isPresent()) {
+ String groupName = optGroupName.get();
+ if (groupName.equals(RSGroupInfo.DEFAULT_GROUP)) {
+// do not check for default group
+return true;
+ }
+ rsGroupInfo = groupAdminServer.getRSGroupInfo(groupName);
+ if (rsGroupInfo == null) {
+throw new ConstraintException(
+"RSGroup " + groupName + " for table " + desc.getTableName() + "
does not exist");
+ }
+} else {
+ NamespaceDescriptor nd =
+
master.getClusterSchema().getNamespace(desc.getTableName().getNamespaceAsString());
+ String groupNameOfNs =
nd.getConfigurationValue(RSGroupInfo.NAMESPACE_DESC_PROP_GROUP);
+ if (groupNameOfNs == null ||
groupNameOfNs.equals(RSGroupInfo.DEFAULT_GROUP)) {
+// do not check for default group
return true;
}
+ rsGroupInfo = groupAdminServer.getRSGroupInfo(groupNameOfNs);
+ if (rsGroupInfo == null) {
+throw new ConstraintException("RSGroup " + groupNameOfNs + " for table
" +
+desc.getTableName() + "(inherit from namespace) does not exist");
+ }
}
-return false;
+return master.getServerManager().createDestinationServersList().stream()
+.anyMatch(onlineServer ->
rsGroupInfo.containsServer(onlineServer.getAddress()));
}
@Override
- public void preCreateTableAction(final
ObserverContext ctx,
- final TableDescriptor desc, final RegionInfo[] regions) throws
IOException {
+ public vo
[jira] [Commented] (HBASE-22539) Potential WAL corruption due to early DBBs re-use.
[ https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895914#comment-16895914 ] binlijin commented on HBASE-22539: -- Does it use ASYNC_WAL ? > Potential WAL corruption due to early DBBs re-use. > --- > > Key: HBASE-22539 > URL: https://issues.apache.org/jira/browse/HBASE-22539 > Project: HBase > Issue Type: Bug > Components: rpc, wal >Affects Versions: 2.1.1 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Blocker > > Summary > We had been chasing a WAL corruption issue reported on one of our customers > deployments running release 2.1.1 (CDH 6.1.0). After providing a custom > modified jar with the extra sanity checks implemented by HBASE-21401 applied > on some code points, plus additional debugging messages, we believe it is > related to DirectByteBuffer usage, and Unsafe copy from offheap memory to > on-heap array triggered > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157], > such as when writing into a non ByteBufferWriter type, as done > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84]. > More details on the following comment. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-516321908 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 81 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | -1 | mvninstall | 351 | root in master failed. | | +1 | compile | 24 | master passed | | +1 | checkstyle | 13 | master passed | | +1 | shadedjars | 292 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 19 | master passed | | 0 | spotbugs | 48 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 45 | master passed | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 365 | root in the patch failed. | | +1 | compile | 31 | the patch passed | | +1 | javac | 31 | the patch passed | | +1 | checkstyle | 16 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 299 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 343 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 695 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 1078 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 20 | the patch passed | | +1 | findbugs | 56 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 1161 | hbase-rsgroup in the patch failed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 3933 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.rsgroup.TestRSGroupsAdmin1 | | | hadoop.hbase.rsgroup.TestRSGroupsWithACL | | | hadoop.hbase.rsgroup.TestRSGroupsAdmin2 | | | hadoop.hbase.rsgroup.TestRSGroupMajorCompactionTTL | | | hadoop.hbase.rsgroup.TestEnableRSGroups | | | hadoop.hbase.rsgroup.TestRSGroupsBalance | | | hadoop.hbase.rsgroup.TestRSGroupsOfflineMode | | | hadoop.hbase.rsgroup.TestRSGroupsBasics | | | hadoop.hbase.rsgroup.TestRSGroupsKillRS | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/32/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c8c91b74dfad 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / 124fa3488a | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/32/artifact/out/branch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/32/artifact/out/patch-mvninstall-root.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/32/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/32/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/32/artifact/out/patch-javac-3.1.2.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/32/artifact/out/patch-unit-hbase-rsgroup.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/32/testReport/ | | Max. process+thread count | 2805 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/32/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr…
Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr… URL: https://github.com/apache/hbase/pull/429#issuecomment-516321982 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 281 | master passed | | +1 | javadoc | 13 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 287 | the patch passed | | -1 | rubocop | 4 | The patch generated 12 new + 13 unchanged - 8 fixed = 25 total (was 21) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | javadoc | 13 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 863 | hbase-shell in the patch failed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 1580 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAdminShell2 | | | hadoop.hbase.client.TestAdminShell | | | hadoop.hbase.client.TestShell | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/429 | | Optional Tests | dupname asflicense javac javadoc unit rubocop | | uname | Linux b1a284eb8b54 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-429/out/precommit/personality/provided.sh | | git revision | master / e3a54e7035 | | Default Java | 1.8.0_181 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/6/artifact/out/diff-patch-rubocop.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/6/artifact/out/patch-unit-hbase-shell.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/6/testReport/ | | Max. process+thread count | 2624 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master)
Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master) URL: https://github.com/apache/hbase/pull/428#issuecomment-516321987 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | -1 | mvninstall | 85 | root in master failed. | | -1 | compile | 25 | hbase-server in master failed. | | +1 | checkstyle | 70 | master passed | | +1 | shadedjars | 256 | branch has no errors when building our shaded downstream artifacts. | | -1 | javadoc | 28 | hbase-server in master failed. | | 0 | spotbugs | 322 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 36 | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 82 | root in the patch failed. | | -1 | compile | 34 | hbase-server in the patch failed. | | -1 | javac | 34 | hbase-server in the patch failed. | | +1 | checkstyle | 70 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 263 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 73 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 144 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 215 | The patch causes 10 errors with Hadoop v3.1.2. | | -1 | javadoc | 29 | hbase-server in the patch failed. | | -1 | findbugs | 34 | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 29 | hbase-server in the patch failed. | | +1 | asflicense | 9 | The patch does not generate ASF License warnings. | | | | 1379 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/428 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 0fd9448bb96f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh | | git revision | master / e3a54e7035 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/branch-compile-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/branch-javadoc-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/branch-findbugs-hbase-server.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/patch-compile-hbase-server.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/patch-javac-3.1.2.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/patch-javadoc-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/patch-findbugs-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/testReport/ | | Max. process+thread count | 87 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds
[jira] [Resolved] (HBASE-22751) table.jsp fails if ugly regions in table
[ https://issues.apache.org/jira/browse/HBASE-22751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-22751. --- Resolution: Fixed Reverted the offending commits from branch-2.0, branch-2.1 and branch-2.2 and reapplied a squshed commit of 8b1952a42a and d23236a452. > table.jsp fails if ugly regions in table > > > Key: HBASE-22751 > URL: https://issues.apache.org/jira/browse/HBASE-22751 > Project: HBase > Issue Type: Bug > Components: UI >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22751.master.001.patch, > HBASE-22751.master.001.patch > > > I'm playing w/ messing up hbase:meta as part of hbck2 messings. Noticed that > a bad server or an unknown region makes it so the table.jsp fails. > I noticed that Admin trying to get the compaction stats for the table will > get stuck trying to contact an unknown region and that when it does complete > eventually (tens of minutes...), it will spew an exception in the compaction > state location. > The listing of servers has an issue where if unknown server, then we'll try > to use a null address which does another spew of jsp complaint instead of > just logging an unknown > I tried messing around with Admin trying to set its Operation Timeout... but > Operation Timeout is not really settable unless you get a new Configuration > for a new Connection -- which is madness -- so instead just used the new > AsyncAdminBuilder where I can set operation timeout > It times out too quick but thats another issue the UI at least draws with > a messy hbase;meta. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master)
Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master) URL: https://github.com/apache/hbase/pull/428#issuecomment-516324931 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 69 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 328 | master passed | | +1 | compile | 58 | master passed | | +1 | checkstyle | 88 | master passed | | +1 | shadedjars | 290 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 35 | master passed | | 0 | spotbugs | 287 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 284 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 329 | the patch passed | | +1 | compile | 64 | the patch passed | | +1 | javac | 64 | the patch passed | | +1 | checkstyle | 91 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 299 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1030 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 40 | the patch passed | | +1 | findbugs | 294 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 1737 | hbase-server in the patch failed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 5470 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestDateTieredCompactionPolicyOverflow | | | TEST-null | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/428 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 5b0c1f3ba72c 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh | | git revision | master / 124fa3488a | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/5/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/5/testReport/ | | Max. process+thread count | 672 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #420: HBASE-22753 Removed deprecated ImmutableHRegionInfo
Apache-HBase commented on issue #420: HBASE-22753 Removed deprecated ImmutableHRegionInfo URL: https://github.com/apache/hbase/pull/420#issuecomment-516325087 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for branch | | -1 | mvninstall | 82 | root in master failed. | | -1 | compile | 34 | hbase-server in master failed. | | +1 | checkstyle | 96 | master passed | | +1 | shadedjars | 271 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 51 | master passed | | 0 | spotbugs | 65 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 35 | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for patch | | -1 | mvninstall | 86 | root in the patch failed. | | -1 | compile | 34 | hbase-server in the patch failed. | | -1 | javac | 34 | hbase-server in the patch failed. | | +1 | checkstyle | 26 | hbase-client: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 | checkstyle | 69 | hbase-server: The patch generated 0 new + 215 unchanged - 4 fixed = 215 total (was 219) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 259 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 70 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 151 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 229 | The patch causes 10 errors with Hadoop v3.1.2. | | -1 | javadoc | 30 | hbase-server in the patch failed. | | -1 | findbugs | 35 | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 | unit | 103 | hbase-client in the patch passed. | | -1 | unit | 35 | hbase-server in the patch failed. | | +1 | asflicense | 18 | The patch does not generate ASF License warnings. | | | | 1833 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/12/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/420 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 5d7d1d0ba0fb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-420/out/precommit/personality/provided.sh | | git revision | master / e3a54e7035 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/12/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/12/artifact/out/branch-compile-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/12/artifact/out/branch-findbugs-hbase-server.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/12/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/12/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/12/artifact/out/patch-compile-hbase-server.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/12/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/12/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/12/artifact/out/patch-javac-3.1.2.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/12/artifact/out/patch-javadoc-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/12/artifact/out/patch-findbugs-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/12/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/12/testReport/ | | Max. process+thread count | 289 (vs. ulimit of 1) | | modules | C:
[GitHub] [hbase] infraio commented on a change in pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration
infraio commented on a change in pull request #426: HBASE-22695 Store the
rsgroup of a table in table configuration
URL: https://github.com/apache/hbase/pull/426#discussion_r308601930
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminClient.java
##
@@ -76,7 +82,6 @@ public RSGroupInfo getRSGroupInfo(String groupName) throws
IOException {
}
}
- @Override
public RSGroupInfo getRSGroupInfoOfTable(TableName tableName) throws
IOException {
Review comment:
We can change the impl of "get_table_rsgroup" cmd? Then there will no
internal usage for this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-516329632 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | -1 | mvninstall | 86 | root in master failed. | | -1 | compile | 22 | hbase-rsgroup in master failed. | | +1 | checkstyle | 10 | master passed | | +1 | shadedjars | 264 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 19 | master passed | | 0 | spotbugs | 306 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 22 | hbase-rsgroup in master failed. | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 87 | root in the patch failed. | | -1 | compile | 20 | hbase-rsgroup in the patch failed. | | -1 | javac | 20 | hbase-rsgroup in the patch failed. | | +1 | checkstyle | 10 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 274 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 79 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 156 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 235 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 18 | the patch passed | | -1 | findbugs | 21 | hbase-rsgroup in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 22 | hbase-rsgroup in the patch failed. | | +1 | asflicense | 9 | The patch does not generate ASF License warnings. | | | | 1220 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/33/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 59d292b9c226 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / e3a54e7035 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/33/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/33/artifact/out/branch-compile-hbase-rsgroup.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/33/artifact/out/branch-findbugs-hbase-rsgroup.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/33/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/33/artifact/out/patch-compile-hbase-rsgroup.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/33/artifact/out/patch-compile-hbase-rsgroup.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/33/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/33/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/33/artifact/out/patch-javac-3.1.2.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/33/artifact/out/patch-findbugs-hbase-rsgroup.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/33/artifact/out/patch-unit-hbase-rsgroup.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/33/testReport/ | | Max. process+thread count | 88 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/33/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t
[GitHub] [hbase] Apache-HBase commented on issue #425: HBASE-22737 Add a new admin method and shell cmd to trigger the hbck …
Apache-HBase commented on issue #425: HBASE-22737 Add a new admin method and shell cmd to trigger the hbck … URL: https://github.com/apache/hbase/pull/425#issuecomment-516330139 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 4 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for branch | | +1 | mvninstall | 330 | master passed | | +1 | compile | 158 | master passed | | +1 | checkstyle | 128 | master passed | | +1 | shadedjars | 265 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 76 | master passed | | 0 | spotbugs | 72 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 138 | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for patch | | +1 | mvninstall | 280 | the patch passed | | +1 | compile | 130 | the patch passed | | +1 | cc | 130 | the patch passed | | +1 | javac | 130 | the patch passed | | +1 | checkstyle | 9 | The patch passed checkstyle in hbase-protocol-shaded | | -1 | checkstyle | 27 | hbase-client: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5) | | +1 | checkstyle | 71 | hbase-server: The patch generated 0 new + 136 unchanged - 7 fixed = 136 total (was 143) | | +1 | checkstyle | 9 | The patch passed checkstyle in hbase-shell | | -1 | rubocop | 14 | The patch generated 4 new + 436 unchanged - 1 fixed = 440 total (was 437) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 258 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 879 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | hbaseprotoc | 134 | the patch passed | | +1 | javadoc | 83 | the patch passed | | +1 | findbugs | 471 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 36 | hbase-protocol-shaded in the patch passed. | | +1 | unit | 106 | hbase-client in the patch passed. | | -1 | unit | 1596 | hbase-server in the patch failed. | | -1 | unit | 416 | hbase-shell in the patch failed. | | +1 | asflicense | 47 | The patch does not generate ASF License warnings. | | | | 6346 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.normalizer.TestSimpleRegionNormalizer | | | hadoop.hbase.master.TestMasterCoprocessorServices | | | hadoop.hbase.master.TestMasterQosFunction | | | hadoop.hbase.client.TestAsyncAccessControlAdminApi | | | hadoop.hbase.client.TestMultiActionMetricsFromClient | | | hadoop.hbase.client.TestAdminShell2 | | | hadoop.hbase.client.TestShell | | | hadoop.hbase.client.TestAdminShell | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/425 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc rubocop | | uname | Linux 50a8a1a22685 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-425/out/precommit/personality/provided.sh | | git revision | master / 124fa3488a | | Default Java | 1.8.0_181 | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/7/artifact/out/branch-findbugs-hbase-server.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/7/artifact/out/diff-checkstyle-hbase-client.txt | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/7/artifact/out/diff-patch-rubocop.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/7/artifact/out/patch-unit-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/7/artifact/out/patch-unit-hbase-shell.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/7/testReport/ | | Max. process+thread count | 2748 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: . | | Console output | https://builds.apache.org/job/HBase-PreCom
[jira] [Updated] (HBASE-22766) Create Unit Tests for ResultStatsUtil
[ https://issues.apache.org/jira/browse/HBASE-22766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtaza Hassan updated HBASE-22766: --- Affects Version/s: 3.0.0 > Create Unit Tests for ResultStatsUtil > -- > > Key: HBASE-22766 > URL: https://issues.apache.org/jira/browse/HBASE-22766 > Project: HBase > Issue Type: Test > Components: test >Affects Versions: 3.0.0 >Reporter: Murtaza Hassan >Assignee: Murtaza Hassan >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (HBASE-22766) Create Unit Tests for ResultStatsUtil
Murtaza Hassan created HBASE-22766: -- Summary: Create Unit Tests for ResultStatsUtil Key: HBASE-22766 URL: https://issues.apache.org/jira/browse/HBASE-22766 Project: HBase Issue Type: Test Components: test Reporter: Murtaza Hassan Assignee: Murtaza Hassan -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22766) Code Coverage Improvement: Create Unit Tests for ResultStatsUtil
[ https://issues.apache.org/jira/browse/HBASE-22766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtaza Hassan updated HBASE-22766: --- Summary: Code Coverage Improvement: Create Unit Tests for ResultStatsUtil (was: Create Unit Tests for ResultStatsUtil ) > Code Coverage Improvement: Create Unit Tests for ResultStatsUtil > - > > Key: HBASE-22766 > URL: https://issues.apache.org/jira/browse/HBASE-22766 > Project: HBase > Issue Type: Test > Components: test >Affects Versions: 3.0.0 >Reporter: Murtaza Hassan >Assignee: Murtaza Hassan >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22539) Potential WAL corruption due to early DBBs re-use.
[
https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895943#comment-16895943
]
Duo Zhang commented on HBASE-22539:
---
{quote}
Does it use ASYNC_WAL ?
{quote}
It does not matter whether we use AsyncFSWAL or FSHLog, it only happens when
using NettyRpcServer.
> Potential WAL corruption due to early DBBs re-use.
> ---
>
> Key: HBASE-22539
> URL: https://issues.apache.org/jira/browse/HBASE-22539
> Project: HBase
> Issue Type: Bug
> Components: rpc, wal
>Affects Versions: 2.1.1
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
>
> Summary
> We had been chasing a WAL corruption issue reported on one of our customers
> deployments running release 2.1.1 (CDH 6.1.0). After providing a custom
> modified jar with the extra sanity checks implemented by HBASE-21401 applied
> on some code points, plus additional debugging messages, we believe it is
> related to DirectByteBuffer usage, and Unsafe copy from offheap memory to
> on-heap array triggered
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157],
> such as when writing into a non ByteBufferWriter type, as done
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84].
> More details on the following comment.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22761) Caught ArrayIndexOutOfBoundsException while processing event RS_LOG_REPLAY
[
https://issues.apache.org/jira/browse/HBASE-22761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
casuallc updated HBASE-22761:
-
Attachment: tmp
> Caught ArrayIndexOutOfBoundsException while processing event RS_LOG_REPLAY
> --
>
> Key: HBASE-22761
> URL: https://issues.apache.org/jira/browse/HBASE-22761
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.1.1
>Reporter: casuallc
>Priority: Major
> Attachments: tmp
>
>
> RegionServer exists when error happen
> {code:java}
> 2019-07-29 20:51:09,726 INFO [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> wal.WALSplitter: Processed 0 edits across 0 regions; edits skipped=0; log
> file=hdfs://cluster1/hbase/WALs/h2,16020,1564216856546-splitting/h2%2C16020%2C1564216856546.1564398538121,
> length=615233, corrupted=false, progress failed=false
> 2019-07-29 20:51:09,726 INFO [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> handler.WALSplitterHandler: Worker h1,16020,1564404572589 done with task
> org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@577da0d3
> in 84892ms. Status = null
> 2019-07-29 20:51:09,726 ERROR [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> executor.EventHandler: Caught throwable while processing event RS_LOG_REPLAY
> java.lang.ArrayIndexOutOfBoundsException: 16403
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365)
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358)
> at
> org.apache.hadoop.hbase.PrivateCellUtil.matchingFamily(PrivateCellUtil.java:735)
> at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:816)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEditFamily(WALEdit.java:143)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEdit(WALEdit.java:148)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:297)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:195)
> at
> org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:100)
> at
> org.apache.hadoop.hbase.regionserver.handler.WALSplitterHandler.process(WALSplitterHandler.java:70)
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> 2019-07-29 20:51:09,730 ERROR [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> regionserver.HRegionServer: * ABORTING region server
> h1,16020,1564404572589: Caught throwable while processing event RS_LOG_REPLAY
> *
> java.lang.ArrayIndexOutOfBoundsException: 16403
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365)
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358)
> at
> org.apache.hadoop.hbase.PrivateCellUtil.matchingFamily(PrivateCellUtil.java:735)
> at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:816)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEditFamily(WALEdit.java:143)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEdit(WALEdit.java:148)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:297)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:195)
> at
> org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:100)
> at
> org.apache.hadoop.hbase.regionserver.handler.WALSplitterHandler.process(WALSplitterHandler.java:70)
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22539) Potential WAL corruption due to early DBBs re-use.
[ https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895947#comment-16895947 ] binlijin commented on HBASE-22539: -- [~Apache9] What i say it is Durability.ASYNC_WAL, which Write the Mutation to the WAL asynchronously. > Potential WAL corruption due to early DBBs re-use. > --- > > Key: HBASE-22539 > URL: https://issues.apache.org/jira/browse/HBASE-22539 > Project: HBase > Issue Type: Bug > Components: rpc, wal >Affects Versions: 2.1.1 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Blocker > > Summary > We had been chasing a WAL corruption issue reported on one of our customers > deployments running release 2.1.1 (CDH 6.1.0). After providing a custom > modified jar with the extra sanity checks implemented by HBASE-21401 applied > on some code points, plus additional debugging messages, we believe it is > related to DirectByteBuffer usage, and Unsafe copy from offheap memory to > on-heap array triggered > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157], > such as when writing into a non ByteBufferWriter type, as done > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84]. > More details on the following comment. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo
Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo URL: https://github.com/apache/hbase/pull/392#issuecomment-516340043 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 101 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | -1 | mvninstall | 346 | root in master failed. | | +1 | compile | 24 | master passed | | +1 | checkstyle | 32 | master passed | | +1 | shadedjars | 294 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 23 | master passed | | 0 | spotbugs | 77 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 75 | master passed | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 357 | root in the patch failed. | | +1 | compile | 25 | the patch passed | | +1 | javac | 25 | the patch passed | | +1 | checkstyle | 30 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 295 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 351 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 712 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 1086 | The patch causes 10 errors with Hadoop v3.1.2. | | -1 | javadoc | 25 | hbase-client generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) | | +1 | findbugs | 76 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 110 | hbase-client in the patch passed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 2986 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/36/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/392 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 85a14b293319 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-392/out/precommit/personality/provided.sh | | git revision | master / e3a54e7035 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/36/artifact/out/branch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/36/artifact/out/patch-mvninstall-root.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/36/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/36/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/36/artifact/out/patch-javac-3.1.2.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/36/artifact/out/diff-javadoc-javadoc-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/36/testReport/ | | Max. process+thread count | 290 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/36/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22539) Potential WAL corruption due to early DBBs re-use.
[
https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895950#comment-16895950
]
Duo Zhang commented on HBASE-22539:
---
{quote}
Hum, the stack trace suggests we are probably on a separate thread from
ringbuffer. Maybe the rpc thread has reached its endpoint where the DBB is then
released?
{quote}
This is something like SEDA. We have a special thread for writing WAL, and the
rpc handler will wait on it when calling sync, so theoretically there should be
no problem. That's why I ask if you see the WAL system stuck log message, as
only in this way, the rpc hander will return without waiting for the ringbuffer
thread to finish its work.
> Potential WAL corruption due to early DBBs re-use.
> ---
>
> Key: HBASE-22539
> URL: https://issues.apache.org/jira/browse/HBASE-22539
> Project: HBase
> Issue Type: Bug
> Components: rpc, wal
>Affects Versions: 2.1.1
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
>
> Summary
> We had been chasing a WAL corruption issue reported on one of our customers
> deployments running release 2.1.1 (CDH 6.1.0). After providing a custom
> modified jar with the extra sanity checks implemented by HBASE-21401 applied
> on some code points, plus additional debugging messages, we believe it is
> related to DirectByteBuffer usage, and Unsafe copy from offheap memory to
> on-heap array triggered
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157],
> such as when writing into a non ByteBufferWriter type, as done
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84].
> More details on the following comment.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22761) Caught ArrayIndexOutOfBoundsException while processing event RS_LOG_REPLAY
[
https://issues.apache.org/jira/browse/HBASE-22761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895952#comment-16895952
]
casuallc commented on HBASE-22761:
--
[~Apache9] no 'WAL system stuck', i have attach log file.
i delete /hbase/WALs/* in hdfs and /hbase/splitWAL in zk，problem seems to be
resolved.
[~wchevreuil] i'm not allowed to attch WAL files
> Caught ArrayIndexOutOfBoundsException while processing event RS_LOG_REPLAY
> --
>
> Key: HBASE-22761
> URL: https://issues.apache.org/jira/browse/HBASE-22761
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.1.1
>Reporter: casuallc
>Priority: Major
> Attachments: tmp
>
>
> RegionServer exists when error happen
> {code:java}
> 2019-07-29 20:51:09,726 INFO [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> wal.WALSplitter: Processed 0 edits across 0 regions; edits skipped=0; log
> file=hdfs://cluster1/hbase/WALs/h2,16020,1564216856546-splitting/h2%2C16020%2C1564216856546.1564398538121,
> length=615233, corrupted=false, progress failed=false
> 2019-07-29 20:51:09,726 INFO [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> handler.WALSplitterHandler: Worker h1,16020,1564404572589 done with task
> org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@577da0d3
> in 84892ms. Status = null
> 2019-07-29 20:51:09,726 ERROR [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> executor.EventHandler: Caught throwable while processing event RS_LOG_REPLAY
> java.lang.ArrayIndexOutOfBoundsException: 16403
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365)
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358)
> at
> org.apache.hadoop.hbase.PrivateCellUtil.matchingFamily(PrivateCellUtil.java:735)
> at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:816)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEditFamily(WALEdit.java:143)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEdit(WALEdit.java:148)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:297)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:195)
> at
> org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:100)
> at
> org.apache.hadoop.hbase.regionserver.handler.WALSplitterHandler.process(WALSplitterHandler.java:70)
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> 2019-07-29 20:51:09,730 ERROR [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> regionserver.HRegionServer: * ABORTING region server
> h1,16020,1564404572589: Caught throwable while processing event RS_LOG_REPLAY
> *
> java.lang.ArrayIndexOutOfBoundsException: 16403
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365)
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358)
> at
> org.apache.hadoop.hbase.PrivateCellUtil.matchingFamily(PrivateCellUtil.java:735)
> at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:816)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEditFamily(WALEdit.java:143)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEdit(WALEdit.java:148)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:297)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:195)
> at
> org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:100)
> at
> org.apache.hadoop.hbase.regionserver.handler.WALSplitterHandler.process(WALSplitterHandler.java:70)
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] johnhomsea opened a new pull request #432: add move server & move table command in shell
johnhomsea opened a new pull request #432: add move server & move table command in shell URL: https://github.com/apache/hbase/pull/432 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22539) Potential WAL corruption due to early DBBs re-use.
[ https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895954#comment-16895954 ] binlijin commented on HBASE-22539: -- Durability.ASYNC_WAL write the Mutation to the WAL asynchronously, and the rpc call will not wait the wal sync and return response to client and release the ByteBuf. > Potential WAL corruption due to early DBBs re-use. > --- > > Key: HBASE-22539 > URL: https://issues.apache.org/jira/browse/HBASE-22539 > Project: HBase > Issue Type: Bug > Components: rpc, wal >Affects Versions: 2.1.1 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Blocker > > Summary > We had been chasing a WAL corruption issue reported on one of our customers > deployments running release 2.1.1 (CDH 6.1.0). After providing a custom > modified jar with the extra sanity checks implemented by HBASE-21401 applied > on some code points, plus additional debugging messages, we believe it is > related to DirectByteBuffer usage, and Unsafe copy from offheap memory to > on-heap array triggered > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157], > such as when writing into a non ByteBufferWriter type, as done > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84]. > More details on the following comment. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22539) Potential WAL corruption due to early DBBs re-use.
[
https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895955#comment-16895955
]
Duo Zhang commented on HBASE-22539:
---
{quote}
What i say it is Durability.ASYNC_WAL, which Write the Mutation to the WAL
asynchronously.
{quote}
OK, got it. Yes this should be a problem, as if we use ASYNC_WAL, we will not
call WAL.sync and the rpc will return immediately, and release the ByteBuf...
> Potential WAL corruption due to early DBBs re-use.
> ---
>
> Key: HBASE-22539
> URL: https://issues.apache.org/jira/browse/HBASE-22539
> Project: HBase
> Issue Type: Bug
> Components: rpc, wal
>Affects Versions: 2.1.1
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
>
> Summary
> We had been chasing a WAL corruption issue reported on one of our customers
> deployments running release 2.1.1 (CDH 6.1.0). After providing a custom
> modified jar with the extra sanity checks implemented by HBASE-21401 applied
> on some code points, plus additional debugging messages, we believe it is
> related to DirectByteBuffer usage, and Unsafe copy from offheap memory to
> on-heap array triggered
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157],
> such as when writing into a non ByteBufferWriter type, as done
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84].
> More details on the following comment.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #403: HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentMan
Apache-HBase commented on issue #403: HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentManager RegionsStateStore URL: https://github.com/apache/hbase/pull/403#issuecomment-516343518 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 78 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for branch | | +1 | mvninstall | 332 | master passed | | +1 | compile | 89 | master passed | | +1 | checkstyle | 125 | master passed | | +1 | shadedjars | 307 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 61 | master passed | | 0 | spotbugs | 268 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 340 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 331 | the patch passed | | +1 | compile | 85 | the patch passed | | +1 | javac | 85 | the patch passed | | -1 | checkstyle | 92 | hbase-server: The patch generated 3 new + 39 unchanged - 0 fixed = 42 total (was 39) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 316 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1028 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 57 | the patch passed | | -1 | findbugs | 43 | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 23 | hbase-client in the patch failed. | | -1 | unit | 41 | hbase-server in the patch failed. | | +1 | asflicense | 23 | The patch does not generate ASF License warnings. | | | | 3927 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/30/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/403 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 045a41bc243a 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-403/out/precommit/personality/provided.sh | | git revision | master / e3a54e7035 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/30/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/30/artifact/out/patch-findbugs-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/30/artifact/out/patch-unit-hbase-client.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/30/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/30/testReport/ | | Max. process+thread count | 86 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/30/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22761) Caught ArrayIndexOutOfBoundsException while processing event RS_LOG_REPLAY
[
https://issues.apache.org/jira/browse/HBASE-22761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895957#comment-16895957
]
binlijin commented on HBASE-22761:
--
Do the put use Durability.ASYNC_WAL?
> Caught ArrayIndexOutOfBoundsException while processing event RS_LOG_REPLAY
> --
>
> Key: HBASE-22761
> URL: https://issues.apache.org/jira/browse/HBASE-22761
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.1.1
>Reporter: casuallc
>Priority: Major
> Attachments: tmp
>
>
> RegionServer exists when error happen
> {code:java}
> 2019-07-29 20:51:09,726 INFO [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> wal.WALSplitter: Processed 0 edits across 0 regions; edits skipped=0; log
> file=hdfs://cluster1/hbase/WALs/h2,16020,1564216856546-splitting/h2%2C16020%2C1564216856546.1564398538121,
> length=615233, corrupted=false, progress failed=false
> 2019-07-29 20:51:09,726 INFO [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> handler.WALSplitterHandler: Worker h1,16020,1564404572589 done with task
> org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@577da0d3
> in 84892ms. Status = null
> 2019-07-29 20:51:09,726 ERROR [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> executor.EventHandler: Caught throwable while processing event RS_LOG_REPLAY
> java.lang.ArrayIndexOutOfBoundsException: 16403
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365)
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358)
> at
> org.apache.hadoop.hbase.PrivateCellUtil.matchingFamily(PrivateCellUtil.java:735)
> at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:816)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEditFamily(WALEdit.java:143)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEdit(WALEdit.java:148)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:297)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:195)
> at
> org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:100)
> at
> org.apache.hadoop.hbase.regionserver.handler.WALSplitterHandler.process(WALSplitterHandler.java:70)
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> 2019-07-29 20:51:09,730 ERROR [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> regionserver.HRegionServer: * ABORTING region server
> h1,16020,1564404572589: Caught throwable while processing event RS_LOG_REPLAY
> *
> java.lang.ArrayIndexOutOfBoundsException: 16403
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365)
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358)
> at
> org.apache.hadoop.hbase.PrivateCellUtil.matchingFamily(PrivateCellUtil.java:735)
> at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:816)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEditFamily(WALEdit.java:143)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEdit(WALEdit.java:148)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:297)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:195)
> at
> org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:100)
> at
> org.apache.hadoop.hbase.regionserver.handler.WALSplitterHandler.process(WALSplitterHandler.java:70)
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache9 commented on a change in pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration
Apache9 commented on a change in pull request #426: HBASE-22695 Store the
rsgroup of a table in table configuration
URL: https://github.com/apache/hbase/pull/426#discussion_r308626014
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
##
@@ -110,117 +95,91 @@ RSGroupAdminServiceImpl getGroupAdminService() {
return groupAdminService;
}
- private void assignTableToGroup(TableDescriptor desc) throws IOException {
-String groupName =
-
master.getClusterSchema().getNamespace(desc.getTableName().getNamespaceAsString())
-.getConfigurationValue(RSGroupInfo.NAMESPACE_DESC_PROP_GROUP);
-if (groupName == null) {
- groupName = RSGroupInfo.DEFAULT_GROUP;
-}
-RSGroupInfo rsGroupInfo = groupAdminServer.getRSGroupInfo(groupName);
-if (rsGroupInfo == null) {
- throw new ConstraintException(
- "Default RSGroup (" + groupName + ") for this table's namespace does
not exist.");
-}
-if (!rsGroupInfo.containsTable(desc.getTableName())) {
- LOG.debug("Pre-moving table " + desc.getTableName() + " to RSGroup " +
groupName);
- groupAdminServer.moveTables(Sets.newHashSet(desc.getTableName()),
groupName);
-}
- }
-
/
// MasterObserver overrides
/
- private boolean rsgroupHasServersOnline(TableDescriptor desc) throws
IOException {
-String groupName;
-try {
- groupName =
master.getClusterSchema().getNamespace(desc.getTableName().getNamespaceAsString())
- .getConfigurationValue(RSGroupInfo.NAMESPACE_DESC_PROP_GROUP);
- if (groupName == null) {
-groupName = RSGroupInfo.DEFAULT_GROUP;
- }
-} catch (MasterNotRunningException | PleaseHoldException e) {
- LOG.info("Master has not initialized yet; temporarily using default
RSGroup '" +
- RSGroupInfo.DEFAULT_GROUP + "' for deploy of system table");
- groupName = RSGroupInfo.DEFAULT_GROUP;
+ @Override
+ public void
postClearDeadServers(ObserverContext ctx,
+ List servers, List notClearedServers) throws
IOException {
+Set clearedServer =
+servers.stream().filter(server -> !notClearedServers.contains(server))
+.map(ServerName::getAddress).collect(Collectors.toSet());
+if (!clearedServer.isEmpty()) {
+ groupAdminServer.removeServers(clearedServer);
}
+ }
-RSGroupInfo rsGroupInfo = groupAdminServer.getRSGroupInfo(groupName);
-if (rsGroupInfo == null) {
- throw new ConstraintException(
- "Default RSGroup (" + groupName + ") for this table's " + "namespace
does not exist.");
+ private void checkGroupExists(Optional optGroupName) throws
IOException {
+if (optGroupName.isPresent()) {
+ String groupName = optGroupName.get();
+ if (groupAdminServer.getRSGroupInfo(groupName) == null) {
+throw new ConstraintException("Region server group " + groupName + "
does not exit");
+ }
}
+ }
-for (ServerName onlineServer :
master.getServerManager().createDestinationServersList()) {
- if (rsGroupInfo.getServers().contains(onlineServer.getAddress())) {
+ private boolean rsgroupHasServersOnline(TableDescriptor desc) throws
IOException {
+RSGroupInfo rsGroupInfo;
+Optional optGroupName = desc.getRegionServerGroup();
+if (optGroupName.isPresent()) {
+ String groupName = optGroupName.get();
+ if (groupName.equals(RSGroupInfo.DEFAULT_GROUP)) {
+// do not check for default group
+return true;
+ }
+ rsGroupInfo = groupAdminServer.getRSGroupInfo(groupName);
+ if (rsGroupInfo == null) {
+throw new ConstraintException(
+"RSGroup " + groupName + " for table " + desc.getTableName() + "
does not exist");
+ }
+} else {
+ NamespaceDescriptor nd =
+
master.getClusterSchema().getNamespace(desc.getTableName().getNamespaceAsString());
+ String groupNameOfNs =
nd.getConfigurationValue(RSGroupInfo.NAMESPACE_DESC_PROP_GROUP);
+ if (groupNameOfNs == null ||
groupNameOfNs.equals(RSGroupInfo.DEFAULT_GROUP)) {
+// do not check for default group
return true;
}
+ rsGroupInfo = groupAdminServer.getRSGroupInfo(groupNameOfNs);
+ if (rsGroupInfo == null) {
+throw new ConstraintException("RSGroup " + groupNameOfNs + " for table
" +
+desc.getTableName() + "(inherit from namespace) does not exist");
+ }
}
-return false;
+return master.getServerManager().createDestinationServersList().stream()
+.anyMatch(onlineServer ->
rsGroupInfo.containsServer(onlineServer.getAddress()));
}
@Override
- public void preCreateTableAction(final
ObserverContext ctx,
- final TableDescriptor desc, final RegionInfo[] regions) throws
IOException {
+ public vo
[GitHub] [hbase] Apache-HBase commented on issue #419: HBASE-22752 Removed the deprecated ImmutableHColumnDescriptor and ImmutableHTableDescriptor
Apache-HBase commented on issue #419: HBASE-22752 Removed the deprecated ImmutableHColumnDescriptor and ImmutableHTableDescriptor URL: https://github.com/apache/hbase/pull/419#issuecomment-516348772 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 38 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for branch | | +1 | mvninstall | 286 | master passed | | +1 | compile | 75 | master passed | | +1 | checkstyle | 104 | master passed | | +1 | shadedjars | 261 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 53 | master passed | | 0 | spotbugs | 240 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 302 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 291 | the patch passed | | +1 | compile | 77 | the patch passed | | +1 | javac | 77 | the patch passed | | +1 | checkstyle | 28 | hbase-client: The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) | | +1 | checkstyle | 73 | The patch passed checkstyle in hbase-server | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 258 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 871 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 56 | the patch passed | | +1 | findbugs | 334 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 102 | hbase-client in the patch passed. | | -1 | unit | 8781 | hbase-server in the patch failed. | | +1 | asflicense | 49 | The patch does not generate ASF License warnings. | | | | 12439 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.replication.TestTransitPeerSyncReplicationStateProcedureRetry | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/419 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9708a7ee7bee 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-419/out/precommit/personality/provided.sh | | git revision | master / c286a31590 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/10/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/10/testReport/ | | Max. process+thread count | 4691 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/10/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-516348853 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for branch | | +1 | mvninstall | 281 | master passed | | +1 | compile | 75 | master passed | | +1 | checkstyle | 98 | master passed | | +1 | shadedjars | 262 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 52 | master passed | | 0 | spotbugs | 236 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 299 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 287 | the patch passed | | +1 | compile | 76 | the patch passed | | +1 | javac | 76 | the patch passed | | +1 | checkstyle | 96 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 259 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 864 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 54 | the patch passed | | +1 | findbugs | 337 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 108 | hbase-client in the patch passed. | | -1 | unit | 8744 | hbase-server in the patch failed. | | +1 | asflicense | 44 | The patch does not generate ASF License warnings. | | | | 12362 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestReplicationDroppedTables | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/42/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a21af8b7a7cc 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / c286a31590 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/42/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/42/testReport/ | | Max. process+thread count | 4726 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/42/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes
Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes URL: https://github.com/apache/hbase/pull/374#issuecomment-516349810 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 144 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 480 | master passed | | +1 | compile | 27 | master passed | | +1 | checkstyle | 35 | master passed | | +1 | shadedjars | 365 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 29 | master passed | | 0 | spotbugs | 67 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 65 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 452 | the patch passed | | +1 | compile | 27 | the patch passed | | +1 | javac | 27 | the patch passed | | -1 | checkstyle | 31 | hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 362 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1360 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 28 | the patch passed | | +1 | findbugs | 80 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 205 | hbase-common in the patch passed. | | +1 | asflicense | 14 | The patch does not generate ASF License warnings. | | | | 4210 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/35/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/374 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 297684cbdafd 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh | | git revision | master / e3a54e7035 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/35/artifact/out/diff-checkstyle-hbase-common.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/35/testReport/ | | Max. process+thread count | 258 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/35/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-22763) Fix remaining Checkstyle issue in hbase-procedure
[
https://issues.apache.org/jira/browse/HBASE-22763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel resolved HBASE-22763.
---
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 2.1.6
2.2.1
2.0.6
2.3.0
3.0.0
> Fix remaining Checkstyle issue in hbase-procedure
> -
>
> Key: HBASE-22763
> URL: https://issues.apache.org/jira/browse/HBASE-22763
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> There's a single Checkstyle issue left in the {{hbase-procedure}} module,
> which should be resolved.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895990#comment-16895990
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #36 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/36/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/36//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/36//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/36//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (HBASE-22767) System table RIT STUCK if their RSGroup has no highest version RSes
Xiaolin Ha created HBASE-22767: -- Summary: System table RIT STUCK if their RSGroup has no highest version RSes Key: HBASE-22767 URL: https://issues.apache.org/jira/browse/HBASE-22767 Project: HBase Issue Type: Bug Components: rsgroup Reporter: Xiaolin Ha Assignee: Xiaolin Ha AM chooses highest version region servers as participants for system tables, including META table. If system table group has no highest version region servers, then the reassignment of their regions will be always the BOGUS server defined in RSGroup. In our test environment using branch-2.2, we isolate system tables in a rsgroup containing only one server. And when upgrading RSs, we have met the problem that META is always assigned to the BOGUS server while the group server has already been online for a while. META RIT is stuck and can not be recovered by hbck2. I made a UT reproduce this problem, steps are: 1. add a group, move 1 server to it; 2. move meta table to the group; 3. restart the group server and downgrade its version; 4. meta rit stuck. ROOT cause is AM filters highest version RSs for system tables. So if we do not change the versions of system table group servers, but upgrade the versions of other group servers, then if there is reassignment for any system tables, such as balancer moving their regions, RIT STUCK!! -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani updated HBASE-22735:
-
Attachment: HBASE-22735.branch-1.02.patch
> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch,
> HBASE-22735.branch-1.02.patch, HBASE-22735.master.01.patch, list_regions.out
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #419: HBASE-22752 Removed the deprecated ImmutableHColumnDescriptor and ImmutableHTableDescriptor
Apache-HBase commented on issue #419: HBASE-22752 Removed the deprecated ImmutableHColumnDescriptor and ImmutableHTableDescriptor URL: https://github.com/apache/hbase/pull/419#issuecomment-516361340 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for branch | | +1 | mvninstall | 286 | master passed | | +1 | compile | 78 | master passed | | +1 | checkstyle | 127 | master passed | | +1 | shadedjars | 266 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 55 | master passed | | 0 | spotbugs | 235 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 299 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 292 | the patch passed | | +1 | compile | 74 | the patch passed | | +1 | javac | 74 | the patch passed | | +1 | checkstyle | 28 | hbase-client: The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) | | +1 | checkstyle | 74 | The patch passed checkstyle in hbase-server | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 266 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 888 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 54 | the patch passed | | +1 | findbugs | 304 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 104 | hbase-client in the patch passed. | | +1 | unit | 7992 | hbase-server in the patch passed. | | +1 | asflicense | 43 | The patch does not generate ASF License warnings. | | | | 11677 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/11/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/419 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux ecc8622e771c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-419/out/precommit/personality/provided.sh | | git revision | master / 124fa3488a | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/11/testReport/ | | Max. process+thread count | 4308 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/11/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22741) Show catalogjanitor consistency complaints in new 'HBCK Report' page
[
https://issues.apache.org/jira/browse/HBASE-22741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895993#comment-16895993
]
HBase QA commented on HBASE-22741:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
49s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
22s{color} | {color:red} hbase-server: The patch generated 11 new + 7 unchanged
- 0 fixed = 18 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
57s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
21m 0s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
52s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
34s{color} | {color:red} hbase-server generated 5 new + 0 unchanged - 0 fixed =
5 total (was 0) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}261m 13s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}332m 53s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.replication.TestReplicationSmallTests |
| | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController |
| | hadoop.hbase.replication.TestMasterReplication |
| | hadoop.hbase.client.TestAsyncTableAdminApi |
| | hadoop.hbase.master.assignment.TestAssignmentOnRSCrash |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/690/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22741 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976163/HBASE-22741.master.002.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux c719dc6cf8eb 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4
22:49:08 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | mast
[GitHub] [hbase] petersomogyi merged pull request #419: HBASE-22752 Removed the deprecated ImmutableHColumnDescriptor and ImmutableHTableDescriptor
petersomogyi merged pull request #419: HBASE-22752 Removed the deprecated ImmutableHColumnDescriptor and ImmutableHTableDescriptor URL: https://github.com/apache/hbase/pull/419 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-22752) Remove deprecated ImmutableHColumnDescriptor & ImmutableHTableDescriptor
[
https://issues.apache.org/jira/browse/HBASE-22752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi resolved HBASE-22752.
---
Resolution: Fixed
Fix Version/s: 3.0.0
> Remove deprecated ImmutableHColumnDescriptor & ImmutableHTableDescriptor
>
>
> Key: HBASE-22752
> URL: https://issues.apache.org/jira/browse/HBASE-22752
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0
>
>
> {{ImmutableHColumnDescriptor}} and {{ImmutableHTableDescriptor}} are
> deprecated and should be removed in 3.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #414: HBASE-22744 Removed deprecated status and load classes in client module
Apache-HBase commented on issue #414: HBASE-22744 Removed deprecated status and load classes in client module URL: https://github.com/apache/hbase/pull/414#issuecomment-516365040 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 48 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 6 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for branch | | +1 | mvninstall | 308 | master passed | | +1 | compile | 125 | master passed | | +1 | checkstyle | 136 | master passed | | +1 | shadedjars | 272 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 93 | master passed | | 0 | spotbugs | 53 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 383 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 288 | the patch passed | | +1 | compile | 127 | the patch passed | | +1 | javac | 127 | the patch passed | | +1 | checkstyle | 31 | hbase-client: The patch generated 0 new + 180 unchanged - 3 fixed = 180 total (was 183) | | +1 | checkstyle | 13 | The patch passed checkstyle in hbase-zookeeper | | +1 | checkstyle | 73 | The patch passed checkstyle in hbase-server | | +1 | checkstyle | 15 | The patch passed checkstyle in hbase-rest | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 256 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 887 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 92 | the patch passed | | +1 | findbugs | 405 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 102 | hbase-client in the patch passed. | | +1 | unit | 47 | hbase-zookeeper in the patch passed. | | +1 | unit | 7882 | hbase-server in the patch passed. | | +1 | unit | 250 | hbase-rest in the patch passed. | | +1 | asflicense | 81 | The patch does not generate ASF License warnings. | | | | 12340 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-414/14/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/414 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 62b238603054 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-414/out/precommit/personality/provided.sh | | git revision | master / 124fa3488a | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-414/14/testReport/ | | Max. process+thread count | 5014 (vs. ulimit of 1) | | modules | C: hbase-client hbase-zookeeper hbase-server hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-414/14/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-516365477 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 45 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 302 | branch-2.1 passed | | +1 | compile | 26 | branch-2.1 passed | | +1 | checkstyle | 35 | branch-2.1 passed | | +1 | shadedjars | 240 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 22 | branch-2.1 passed | | 0 | spotbugs | 71 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 68 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 289 | the patch passed | | +1 | compile | 24 | the patch passed | | +1 | javac | 24 | the patch passed | | +1 | checkstyle | 32 | hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 229 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1128 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 21 | the patch passed | | +1 | findbugs | 77 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 209 | hbase-client in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 3096 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/21/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/343 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2e932f275bbf 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh | | git revision | branch-2.1 / 11b647be23 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/21/testReport/ | | Max. process+thread count | 300 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/21/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet merged pull request #414: HBASE-22744 Removed deprecated status and load classes in client module
HorizonNet merged pull request #414: HBASE-22744 Removed deprecated status and load classes in client module URL: https://github.com/apache/hbase/pull/414 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-22744) Remove deprecated classes around status and load
[
https://issues.apache.org/jira/browse/HBASE-22744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel resolved HBASE-22744.
---
Resolution: Fixed
Hadoop Flags: Incompatible change,Reviewed (was: Incompatible change)
Fix Version/s: 3.0.0
> Remove deprecated classes around status and load
>
>
> Key: HBASE-22744
> URL: https://issues.apache.org/jira/browse/HBASE-22744
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
> Fix For: 3.0.0
>
>
> The client module has three deprecated classes around metrics,
> {{ClusterStatus}}, {{RegionLoad}} and {{ServerLoad}}, which should be removed.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22539) Potential WAL corruption due to early DBBs re-use.
[ https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895997#comment-16895997 ] Wellington Chevreuil commented on HBASE-22539: -- [~aoxiang], it happens with both Async and FSHLog providers (the stack trace above is for FSHLogProvider). We did suspect on Async Wal at some point before I opened this jira, but after comparing both implementations, we couldn't identify any issues that would be specific for Async. Nevertheless, we gave it a go and tried switching from Async (the default in hbase 2) to filesystem (FSHLog), and still these corruptions were consistently manifesting. > Potential WAL corruption due to early DBBs re-use. > --- > > Key: HBASE-22539 > URL: https://issues.apache.org/jira/browse/HBASE-22539 > Project: HBase > Issue Type: Bug > Components: rpc, wal >Affects Versions: 2.1.1 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Blocker > > Summary > We had been chasing a WAL corruption issue reported on one of our customers > deployments running release 2.1.1 (CDH 6.1.0). After providing a custom > modified jar with the extra sanity checks implemented by HBASE-21401 applied > on some code points, plus additional debugging messages, we believe it is > related to DirectByteBuffer usage, and Unsafe copy from offheap memory to > on-heap array triggered > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157], > such as when writing into a non ByteBufferWriter type, as done > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84]. > More details on the following comment. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-516367541 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 83 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 364 | master passed | | +1 | compile | 55 | master passed | | +1 | checkstyle | 83 | master passed | | +1 | shadedjars | 275 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 35 | master passed | | 0 | spotbugs | 241 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 238 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 299 | the patch passed | | +1 | compile | 54 | the patch passed | | +1 | javac | 54 | the patch passed | | -1 | checkstyle | 77 | hbase-server: The patch generated 12 new + 345 unchanged - 0 fixed = 357 total (was 345) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 283 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 932 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 32 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | findbugs | 257 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 8550 | hbase-server in the patch failed. | | +1 | asflicense | 24 | The patch does not generate ASF License warnings. | | | | 12052 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 5951da8cb959 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390/out/precommit/personality/provided.sh | | git revision | master / 124fa3488a | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/8/artifact/out/diff-checkstyle-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/8/artifact/out/diff-javadoc-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/8/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/8/testReport/ | | Max. process+thread count | 4445 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/8/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] petersomogyi commented on issue #420: HBASE-22753 Removed deprecated ImmutableHRegionInfo
petersomogyi commented on issue #420: HBASE-22753 Removed deprecated ImmutableHRegionInfo URL: https://github.com/apache/hbase/pull/420#issuecomment-516367755 @HorizonNet can you rebase the commit? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22539) Potential WAL corruption due to early DBBs re-use.
[ https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896000#comment-16896000 ] Duo Zhang commented on HBASE-22539: --- I'm currently working on a UT to reproduce the problem when using Durability.ASYNC_WAL. Will be back soon. > Potential WAL corruption due to early DBBs re-use. > --- > > Key: HBASE-22539 > URL: https://issues.apache.org/jira/browse/HBASE-22539 > Project: HBase > Issue Type: Bug > Components: rpc, wal >Affects Versions: 2.1.1 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Blocker > > Summary > We had been chasing a WAL corruption issue reported on one of our customers > deployments running release 2.1.1 (CDH 6.1.0). After providing a custom > modified jar with the extra sanity checks implemented by HBASE-21401 applied > on some code points, plus additional debugging messages, we believe it is > related to DirectByteBuffer usage, and Unsafe copy from offheap memory to > on-heap array triggered > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157], > such as when writing into a non ByteBufferWriter type, as done > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84]. > More details on the following comment. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22761) Caught ArrayIndexOutOfBoundsException while processing event RS_LOG_REPLAY
[
https://issues.apache.org/jira/browse/HBASE-22761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896001#comment-16896001
]
Wellington Chevreuil commented on HBASE-22761:
--
Thanks for the updates, [~casuallc].
{quote}i delete /hbase/WALs/* in hdfs and /hbase/splitWAL in zk，problem seems
to be resolved.{quote}
Yeah, by doing this you had removed the corrupt wals from the way. That might
had led to data loss, though.
{quote}Wellington Chevreuil i'm not allowed to attch WAL files{quote}
I understand. If you still have those files, can you run WalPP tool on each of
those and let us know if it crashes/throws any errors?
{noformat}
$ bin/hbase wal PATH_TO_WAL_FILE_IN_HDFS
{noformat}
> Caught ArrayIndexOutOfBoundsException while processing event RS_LOG_REPLAY
> --
>
> Key: HBASE-22761
> URL: https://issues.apache.org/jira/browse/HBASE-22761
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.1.1
>Reporter: casuallc
>Priority: Major
> Attachments: tmp
>
>
> RegionServer exists when error happen
> {code:java}
> 2019-07-29 20:51:09,726 INFO [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> wal.WALSplitter: Processed 0 edits across 0 regions; edits skipped=0; log
> file=hdfs://cluster1/hbase/WALs/h2,16020,1564216856546-splitting/h2%2C16020%2C1564216856546.1564398538121,
> length=615233, corrupted=false, progress failed=false
> 2019-07-29 20:51:09,726 INFO [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> handler.WALSplitterHandler: Worker h1,16020,1564404572589 done with task
> org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@577da0d3
> in 84892ms. Status = null
> 2019-07-29 20:51:09,726 ERROR [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> executor.EventHandler: Caught throwable while processing event RS_LOG_REPLAY
> java.lang.ArrayIndexOutOfBoundsException: 16403
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365)
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358)
> at
> org.apache.hadoop.hbase.PrivateCellUtil.matchingFamily(PrivateCellUtil.java:735)
> at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:816)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEditFamily(WALEdit.java:143)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEdit(WALEdit.java:148)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:297)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:195)
> at
> org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:100)
> at
> org.apache.hadoop.hbase.regionserver.handler.WALSplitterHandler.process(WALSplitterHandler.java:70)
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> 2019-07-29 20:51:09,730 ERROR [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> regionserver.HRegionServer: * ABORTING region server
> h1,16020,1564404572589: Caught throwable while processing event RS_LOG_REPLAY
> *
> java.lang.ArrayIndexOutOfBoundsException: 16403
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365)
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358)
> at
> org.apache.hadoop.hbase.PrivateCellUtil.matchingFamily(PrivateCellUtil.java:735)
> at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:816)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEditFamily(WALEdit.java:143)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEdit(WALEdit.java:148)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:297)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:195)
> at
> org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:100)
> at
> org.apache.hadoop.hbase.regionserver.handler.WALSplitterHandler.process(WALSplitterHandler.java:70)
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] petersomogyi merged pull request #427: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (2.1)
petersomogyi merged pull request #427: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (2.1) URL: https://github.com/apache/hbase/pull/427 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22761) Caught ArrayIndexOutOfBoundsException while processing event RS_LOG_REPLAY
[
https://issues.apache.org/jira/browse/HBASE-22761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896006#comment-16896006
]
casuallc commented on HBASE-22761:
--
[~wchevreuil] I will run WalPP tool next time, thx.
> Caught ArrayIndexOutOfBoundsException while processing event RS_LOG_REPLAY
> --
>
> Key: HBASE-22761
> URL: https://issues.apache.org/jira/browse/HBASE-22761
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.1.1
>Reporter: casuallc
>Priority: Major
> Attachments: tmp
>
>
> RegionServer exists when error happen
> {code:java}
> 2019-07-29 20:51:09,726 INFO [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> wal.WALSplitter: Processed 0 edits across 0 regions; edits skipped=0; log
> file=hdfs://cluster1/hbase/WALs/h2,16020,1564216856546-splitting/h2%2C16020%2C1564216856546.1564398538121,
> length=615233, corrupted=false, progress failed=false
> 2019-07-29 20:51:09,726 INFO [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> handler.WALSplitterHandler: Worker h1,16020,1564404572589 done with task
> org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@577da0d3
> in 84892ms. Status = null
> 2019-07-29 20:51:09,726 ERROR [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> executor.EventHandler: Caught throwable while processing event RS_LOG_REPLAY
> java.lang.ArrayIndexOutOfBoundsException: 16403
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365)
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358)
> at
> org.apache.hadoop.hbase.PrivateCellUtil.matchingFamily(PrivateCellUtil.java:735)
> at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:816)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEditFamily(WALEdit.java:143)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEdit(WALEdit.java:148)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:297)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:195)
> at
> org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:100)
> at
> org.apache.hadoop.hbase.regionserver.handler.WALSplitterHandler.process(WALSplitterHandler.java:70)
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> 2019-07-29 20:51:09,730 ERROR [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> regionserver.HRegionServer: * ABORTING region server
> h1,16020,1564404572589: Caught throwable while processing event RS_LOG_REPLAY
> *
> java.lang.ArrayIndexOutOfBoundsException: 16403
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365)
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358)
> at
> org.apache.hadoop.hbase.PrivateCellUtil.matchingFamily(PrivateCellUtil.java:735)
> at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:816)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEditFamily(WALEdit.java:143)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEdit(WALEdit.java:148)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:297)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:195)
> at
> org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:100)
> at
> org.apache.hadoop.hbase.regionserver.handler.WALSplitterHandler.process(WALSplitterHandler.java:70)
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Resolved] (HBASE-22764) Fix remaining Checkstyle issues in hbase-rsgroup
[
https://issues.apache.org/jira/browse/HBASE-22764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel resolved HBASE-22764.
---
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 2.1.6
2.2.1
2.0.6
2.3.0
3.0.0
> Fix remaining Checkstyle issues in hbase-rsgroup
>
>
> Key: HBASE-22764
> URL: https://issues.apache.org/jira/browse/HBASE-22764
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> There are two Checkstyle issues left in the {{hbase-rsgroup}} module, which
> need to be resolved.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22731) ReplicationSource and HBaseInterClusterReplicationEndpoint log messages should include a target Peer identifier
[ https://issues.apache.org/jira/browse/HBASE-22731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896032#comment-16896032 ] Peter Somogyi commented on HBASE-22731: --- Please use parameterized logging instead of string concatenation. [https://www.slf4j.org/faq.html#logging_performance] > ReplicationSource and HBaseInterClusterReplicationEndpoint log messages > should include a target Peer identifier > --- > > Key: HBASE-22731 > URL: https://issues.apache.org/jira/browse/HBASE-22731 > Project: HBase > Issue Type: Improvement > Components: Replication >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Minor > Attachments: HBASE-22731.master.001.patch > > > _ReplicationSource_ and _HBaseInterClusterReplicationEndpoint_ already > include a good number of helpful DEBUG and TRACE log messages to help us > troubleshooting typical replication problems, such as lags or mysteriously > missing edits on target peer. > However, for each configured peer, there will be an individual > _ReplicationSource_/_HBaseInterClusterReplicationEndpoint_ pair running in > parallel, in scenarios where we need to investigate issues within a source to > an specific peer, we can't distinguish from which peer specific > _ReplicationSource_/_HBaseInterClusterReplicationEndpoint._ For such cases it > would be nice to have an identifier for specific peer the given > _ReplicationSource_/_HBaseInterClusterReplicationEndpoint_ is related to. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22363) Remove hardcoded number of read cache block buckets
[
https://issues.apache.org/jira/browse/HBASE-22363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896040#comment-16896040
]
Peter Somogyi commented on HBASE-22363:
---
Reattached patch.
> Remove hardcoded number of read cache block buckets
>
>
> Key: HBASE-22363
> URL: https://issues.apache.org/jira/browse/HBASE-22363
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache, BucketCache
>Reporter: Biju Nair
>Assignee: Biju Nair
>Priority: Trivial
> Attachments: HBASE-22363.patch, HBASE-22363.patch
>
>
> The number of cache block buckets is hardcoded in the code to 3 since
> currently it supports {{single, multi, memory}} block buckets. Will be good
> to make it dynamic.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22363) Remove hardcoded number of read cache block buckets
[
https://issues.apache.org/jira/browse/HBASE-22363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi updated HBASE-22363:
--
Attachment: HBASE-22363.patch
> Remove hardcoded number of read cache block buckets
>
>
> Key: HBASE-22363
> URL: https://issues.apache.org/jira/browse/HBASE-22363
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache, BucketCache
>Reporter: Biju Nair
>Assignee: Biju Nair
>Priority: Trivial
> Attachments: HBASE-22363.patch, HBASE-22363.patch
>
>
> The number of cache block buckets is hardcoded in the code to 3 since
> currently it supports {{single, multi, memory}} block buckets. Will be good
> to make it dynamic.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #419: HBASE-22752 Removed the deprecated ImmutableHColumnDescriptor and ImmutableHTableDescriptor
Apache-HBase commented on issue #419: HBASE-22752 Removed the deprecated ImmutableHColumnDescriptor and ImmutableHTableDescriptor URL: https://github.com/apache/hbase/pull/419#issuecomment-516381117 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 38 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for branch | | +1 | mvninstall | 313 | master passed | | +1 | compile | 77 | master passed | | +1 | checkstyle | 109 | master passed | | +1 | shadedjars | 267 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 53 | master passed | | 0 | spotbugs | 65 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 48 | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 280 | the patch passed | | +1 | compile | 74 | the patch passed | | +1 | javac | 74 | the patch passed | | +1 | checkstyle | 27 | hbase-client: The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) | | +1 | checkstyle | 69 | The patch passed checkstyle in hbase-server | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 261 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 868 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 54 | the patch passed | | -1 | findbugs | 23 | hbase-client in the patch failed. | | -1 | findbugs | 33 | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 | unit | 98 | hbase-client in the patch passed. | | -1 | unit | 8548 | hbase-server in the patch failed. | | +1 | asflicense | 41 | The patch does not generate ASF License warnings. | | | | 11731 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAsyncTableGetMultiThreaded | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/12/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/419 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e84eb7b274d1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-419/out/precommit/personality/provided.sh | | git revision | master / e3a54e7035 | | Default Java | 1.8.0_181 | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/12/artifact/out/branch-findbugs-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/12/artifact/out/patch-findbugs-hbase-client.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/12/artifact/out/patch-findbugs-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/12/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/12/testReport/ | | Max. process+thread count | 4377 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/12/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-22539) Potential WAL corruption due to early DBBs re-use.
[
https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896046#comment-16896046
]
binlijin edited comment on HBASE-22539 at 7/30/19 11:37 AM:
[~wchevreuil] what i am say about Durability.ASYNC_WAL, it do not related to
AsyncFSWALProvider/FSHLogProvider.
User can set DURABILITY on HTableDescriptor {TABLE_ATTRIBUTES => {DURABILITY =>
'ASYNC_WAL'} or when write can set Put.setDurability(Durability.ASYNC_WAL) to
use it.
{code}
/**
* Enum describing the durability guarantees for tables and {@link Mutation}s
* Note that the items must be sorted in order of increasing durability
*/
@InterfaceAudience.Public
public enum Durability {
/* Developer note: Do not rename the enum field names. They are serialized in
HTableDescriptor */
/**
* If this is for tables durability, use HBase's global default value
(SYNC_WAL).
* Otherwise, if this is for mutation, use the table's default setting to
determine durability.
* This must remain the first option.
*/
USE_DEFAULT,
/**
* Do not write the Mutation to the WAL
*/
SKIP_WAL,
/**
* Write the Mutation to the WAL asynchronously
*/
ASYNC_WAL,
/**
* Write the Mutation to the WAL synchronously.
* The data is flushed to the filesystem implementation, but not necessarily
to disk.
* For HDFS this will flush the data to the designated number of DataNodes.
* See https://issues.apache.org/jira/browse/HADOOP-6313";>HADOOP-6313
*/
SYNC_WAL,
/**
* Write the Mutation to the WAL synchronously and force the entries to disk.
* See https://issues.apache.org/jira/browse/HADOOP-6313";>HADOOP-6313
*/
FSYNC_WAL
}
{code}
was (Author: aoxiang):
[~wchevreuil] what i am say about Durability.ASYNC_WAL, it do not related to
AsyncFSWALProvider/FSHLogProvider.
User can set DURABILITY on HTableDescriptor {TABLE_ATTRIBUTES => {DURABILITY =>
'ASYNC_WAL'} or when write can set Put.setDurability(Durability.ASYNC_WAL) to
use it.
/**
* Enum describing the durability guarantees for tables and {@link Mutation}s
* Note that the items must be sorted in order of increasing durability
*/
@InterfaceAudience.Public
public enum Durability {
/* Developer note: Do not rename the enum field names. They are serialized in
HTableDescriptor */
/**
* If this is for tables durability, use HBase's global default value
(SYNC_WAL).
* Otherwise, if this is for mutation, use the table's default setting to
determine durability.
* This must remain the first option.
*/
USE_DEFAULT,
/**
* Do not write the Mutation to the WAL
*/
SKIP_WAL,
/**
* Write the Mutation to the WAL asynchronously
*/
ASYNC_WAL,
/**
* Write the Mutation to the WAL synchronously.
* The data is flushed to the filesystem implementation, but not necessarily
to disk.
* For HDFS this will flush the data to the designated number of DataNodes.
* See https://issues.apache.org/jira/browse/HADOOP-6313";>HADOOP-6313
*/
SYNC_WAL,
/**
* Write the Mutation to the WAL synchronously and force the entries to disk.
* See https://issues.apache.org/jira/browse/HADOOP-6313";>HADOOP-6313
*/
FSYNC_WAL
}
> Potential WAL corruption due to early DBBs re-use.
> ---
>
> Key: HBASE-22539
> URL: https://issues.apache.org/jira/browse/HBASE-22539
> Project: HBase
> Issue Type: Bug
> Components: rpc, wal
>Affects Versions: 2.1.1
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
>
> Summary
> We had been chasing a WAL corruption issue reported on one of our customers
> deployments running release 2.1.1 (CDH 6.1.0). After providing a custom
> modified jar with the extra sanity checks implemented by HBASE-21401 applied
> on some code points, plus additional debugging messages, we believe it is
> related to DirectByteBuffer usage, and Unsafe copy from offheap memory to
> on-heap array triggered
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157],
> such as when writing into a non ByteBufferWriter type, as done
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84].
> More details on the following comment.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22539) Potential WAL corruption due to early DBBs re-use.
[
https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896046#comment-16896046
]
binlijin commented on HBASE-22539:
--
[~wchevreuil] what i am say about Durability.ASYNC_WAL, it do not related to
AsyncFSWALProvider/FSHLogProvider.
User can set DURABILITY on HTableDescriptor {TABLE_ATTRIBUTES => {DURABILITY =>
'ASYNC_WAL'} or when write can set Put.setDurability(Durability.ASYNC_WAL) to
use it.
/**
* Enum describing the durability guarantees for tables and {@link Mutation}s
* Note that the items must be sorted in order of increasing durability
*/
@InterfaceAudience.Public
public enum Durability {
/* Developer note: Do not rename the enum field names. They are serialized in
HTableDescriptor */
/**
* If this is for tables durability, use HBase's global default value
(SYNC_WAL).
* Otherwise, if this is for mutation, use the table's default setting to
determine durability.
* This must remain the first option.
*/
USE_DEFAULT,
/**
* Do not write the Mutation to the WAL
*/
SKIP_WAL,
/**
* Write the Mutation to the WAL asynchronously
*/
ASYNC_WAL,
/**
* Write the Mutation to the WAL synchronously.
* The data is flushed to the filesystem implementation, but not necessarily
to disk.
* For HDFS this will flush the data to the designated number of DataNodes.
* See https://issues.apache.org/jira/browse/HADOOP-6313";>HADOOP-6313
*/
SYNC_WAL,
/**
* Write the Mutation to the WAL synchronously and force the entries to disk.
* See https://issues.apache.org/jira/browse/HADOOP-6313";>HADOOP-6313
*/
FSYNC_WAL
}
> Potential WAL corruption due to early DBBs re-use.
> ---
>
> Key: HBASE-22539
> URL: https://issues.apache.org/jira/browse/HBASE-22539
> Project: HBase
> Issue Type: Bug
> Components: rpc, wal
>Affects Versions: 2.1.1
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
>
> Summary
> We had been chasing a WAL corruption issue reported on one of our customers
> deployments running release 2.1.1 (CDH 6.1.0). After providing a custom
> modified jar with the extra sanity checks implemented by HBASE-21401 applied
> on some code points, plus additional debugging messages, we believe it is
> related to DirectByteBuffer usage, and Unsafe copy from offheap memory to
> on-heap array triggered
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157],
> such as when writing into a non ByteBufferWriter type, as done
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84].
> More details on the following comment.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-516382620 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 121 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 418 | master passed | | +1 | compile | 71 | master passed | | +1 | checkstyle | 105 | master passed | | +1 | shadedjars | 350 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 48 | master passed | | 0 | spotbugs | 306 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 303 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 443 | the patch passed | | +1 | compile | 76 | the patch passed | | +1 | javac | 76 | the patch passed | | -1 | checkstyle | 112 | hbase-server: The patch generated 12 new + 345 unchanged - 0 fixed = 357 total (was 345) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 372 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1363 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 46 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | findbugs | 308 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 14421 | hbase-server in the patch failed. | | +1 | asflicense | 30 | The patch does not generate ASF License warnings. | | | | 19161 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.master.TestMasterShutdown | | | hadoop.hbase.regionserver.TestHRegion | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 4fc969060b3b 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390/out/precommit/personality/provided.sh | | git revision | master / c286a31590 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/7/artifact/out/diff-checkstyle-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/7/artifact/out/diff-javadoc-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/7/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/7/testReport/ | | Max. process+thread count | 4702 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/7/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-22539) Potential WAL corruption due to early DBBs re-use.
[
https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896046#comment-16896046
]
binlijin edited comment on HBASE-22539 at 7/30/19 11:42 AM:
[~wchevreuil] what i am say about Durability.ASYNC_WAL, it do not related to
AsyncFSWALProvider/FSHLogProvider.
User can set DURABILITY on HTableDescriptor
alter 'table', METHOD=>'table_att', DURABILITY => 'ASYNC_WAL'
{TABLE_ATTRIBUTES => {DURABILITY => 'ASYNC_WAL'} or when write can set
Put.setDurability(Durability.ASYNC_WAL) to use it.
{code}
/**
* Enum describing the durability guarantees for tables and {@link Mutation}s
* Note that the items must be sorted in order of increasing durability
*/
@InterfaceAudience.Public
public enum Durability {
/* Developer note: Do not rename the enum field names. They are serialized in
HTableDescriptor */
/**
* If this is for tables durability, use HBase's global default value
(SYNC_WAL).
* Otherwise, if this is for mutation, use the table's default setting to
determine durability.
* This must remain the first option.
*/
USE_DEFAULT,
/**
* Do not write the Mutation to the WAL
*/
SKIP_WAL,
/**
* Write the Mutation to the WAL asynchronously
*/
ASYNC_WAL,
/**
* Write the Mutation to the WAL synchronously.
* The data is flushed to the filesystem implementation, but not necessarily
to disk.
* For HDFS this will flush the data to the designated number of DataNodes.
* See https://issues.apache.org/jira/browse/HADOOP-6313";>HADOOP-6313
*/
SYNC_WAL,
/**
* Write the Mutation to the WAL synchronously and force the entries to disk.
* See https://issues.apache.org/jira/browse/HADOOP-6313";>HADOOP-6313
*/
FSYNC_WAL
}
{code}
was (Author: aoxiang):
[~wchevreuil] what i am say about Durability.ASYNC_WAL, it do not related to
AsyncFSWALProvider/FSHLogProvider.
User can set DURABILITY on HTableDescriptor {TABLE_ATTRIBUTES => {DURABILITY =>
'ASYNC_WAL'} or when write can set Put.setDurability(Durability.ASYNC_WAL) to
use it.
{code}
/**
* Enum describing the durability guarantees for tables and {@link Mutation}s
* Note that the items must be sorted in order of increasing durability
*/
@InterfaceAudience.Public
public enum Durability {
/* Developer note: Do not rename the enum field names. They are serialized in
HTableDescriptor */
/**
* If this is for tables durability, use HBase's global default value
(SYNC_WAL).
* Otherwise, if this is for mutation, use the table's default setting to
determine durability.
* This must remain the first option.
*/
USE_DEFAULT,
/**
* Do not write the Mutation to the WAL
*/
SKIP_WAL,
/**
* Write the Mutation to the WAL asynchronously
*/
ASYNC_WAL,
/**
* Write the Mutation to the WAL synchronously.
* The data is flushed to the filesystem implementation, but not necessarily
to disk.
* For HDFS this will flush the data to the designated number of DataNodes.
* See https://issues.apache.org/jira/browse/HADOOP-6313";>HADOOP-6313
*/
SYNC_WAL,
/**
* Write the Mutation to the WAL synchronously and force the entries to disk.
* See https://issues.apache.org/jira/browse/HADOOP-6313";>HADOOP-6313
*/
FSYNC_WAL
}
{code}
> Potential WAL corruption due to early DBBs re-use.
> ---
>
> Key: HBASE-22539
> URL: https://issues.apache.org/jira/browse/HBASE-22539
> Project: HBase
> Issue Type: Bug
> Components: rpc, wal
>Affects Versions: 2.1.1
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
>
> Summary
> We had been chasing a WAL corruption issue reported on one of our customers
> deployments running release 2.1.1 (CDH 6.1.0). After providing a custom
> modified jar with the extra sanity checks implemented by HBASE-21401 applied
> on some code points, plus additional debugging messages, we believe it is
> related to DirectByteBuffer usage, and Unsafe copy from offheap memory to
> on-heap array triggered
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157],
> such as when writing into a non ByteBufferWriter type, as done
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84].
> More details on the following comment.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-516384417 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 42 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 284 | master passed | | -1 | compile | 48 | hbase-server in master failed. | | +1 | checkstyle | 75 | master passed | | +1 | shadedjars | 252 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 33 | master passed | | 0 | spotbugs | 334 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 48 | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 285 | the patch passed | | -1 | compile | 48 | hbase-server in the patch failed. | | -1 | javac | 48 | hbase-server in the patch failed. | | -1 | checkstyle | 70 | hbase-server: The patch generated 12 new + 345 unchanged - 0 fixed = 357 total (was 345) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 248 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 878 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 33 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | findbugs | 236 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 8539 | hbase-server in the patch failed. | | +1 | asflicense | 24 | The patch does not generate ASF License warnings. | | | | 11490 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.regionserver.TestHRegion | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3bceffba1830 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390/out/precommit/personality/provided.sh | | git revision | master / e3a54e7035 | | Default Java | 1.8.0_181 | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/9/artifact/out/branch-compile-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/9/artifact/out/branch-findbugs-hbase-server.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/9/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/9/artifact/out/patch-compile-hbase-server.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/9/artifact/out/diff-checkstyle-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/9/artifact/out/diff-javadoc-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/9/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/9/testReport/ | | Max. process+thread count | 4414 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/9/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on issue #420: HBASE-22753 Removed deprecated ImmutableHRegionInfo
HorizonNet commented on issue #420: HBASE-22753 Removed deprecated ImmutableHRegionInfo URL: https://github.com/apache/hbase/pull/420#issuecomment-516384936 @petersomogyi Done. Let's wait for QA. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-516385655 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 91 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 325 | branch-2.1 passed | | +1 | compile | 25 | branch-2.1 passed | | +1 | checkstyle | 38 | branch-2.1 passed | | +1 | shadedjars | 259 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 22 | branch-2.1 passed | | 0 | spotbugs | 74 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 72 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 315 | the patch passed | | +1 | compile | 28 | the patch passed | | +1 | javac | 28 | the patch passed | | +1 | checkstyle | 42 | hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 277 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1333 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 23 | the patch passed | | +1 | findbugs | 78 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 197 | hbase-client in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 3516 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/22/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/343 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f7099ffcc97e 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh | | git revision | branch-2.1 / 29f8e195ef | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/22/testReport/ | | Max. process+thread count | 259 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/22/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #414: HBASE-22744 Removed deprecated status and load classes in client module
Apache-HBase commented on issue #414: HBASE-22744 Removed deprecated status and load classes in client module URL: https://github.com/apache/hbase/pull/414#issuecomment-516387015 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 6 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for branch | | +1 | mvninstall | 284 | master passed | | +1 | compile | 120 | master passed | | +1 | checkstyle | 129 | master passed | | +1 | shadedjars | 260 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 86 | master passed | | 0 | spotbugs | 51 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 375 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 294 | the patch passed | | +1 | compile | 123 | the patch passed | | +1 | javac | 123 | the patch passed | | +1 | checkstyle | 32 | hbase-client: The patch generated 0 new + 180 unchanged - 3 fixed = 180 total (was 183) | | +1 | checkstyle | 11 | The patch passed checkstyle in hbase-zookeeper | | +1 | checkstyle | 74 | The patch passed checkstyle in hbase-server | | +1 | checkstyle | 16 | The patch passed checkstyle in hbase-rest | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 272 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 921 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 92 | the patch passed | | +1 | findbugs | 419 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 112 | hbase-client in the patch passed. | | +1 | unit | 50 | hbase-zookeeper in the patch passed. | | +1 | unit | 8328 | hbase-server in the patch passed. | | +1 | unit | 274 | hbase-rest in the patch passed. | | +1 | asflicense | 79 | The patch does not generate ASF License warnings. | | | | 12831 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-414/15/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/414 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d51432cef307 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-414/out/precommit/personality/provided.sh | | git revision | master / e3a54e7035 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-414/15/testReport/ | | Max. process+thread count | 5241 (vs. ulimit of 1) | | modules | C: hbase-client hbase-zookeeper hbase-server hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-414/15/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22758) Remove the unneccesary info cf deletion in DeleteTableProcedure#deleteFromMeta
[
https://issues.apache.org/jira/browse/HBASE-22758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896061#comment-16896061
]
Hudson commented on HBASE-22758:
Results for branch master
[build #1290 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1290/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1290//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1290//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1290//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove the unneccesary info cf deletion in DeleteTableProcedure#deleteFromMeta
> --
>
> Key: HBASE-22758
> URL: https://issues.apache.org/jira/browse/HBASE-22758
> Project: HBase
> Issue Type: Bug
>Reporter: Zheng Hu
>Priority: Major
>
> I saw the deleteFromMeta() method in DeleteTableProcedure &
> TruncateTableProcedure:
> {code}
> protected static void deleteFromMeta(final MasterProcedureEnv env,
> final TableName tableName, List regions) throws IOException {
> MetaTableAccessor.deleteRegions(env.getMasterServices().getConnection(),
> regions);
> // Clean any remaining rows for this table.
> cleanAnyRemainingRows(env, tableName);
> // clean region references from the server manager
> env.getMasterServices().getServerManager().removeRegions(regions);
> // Clear Favored Nodes for this table
> FavoredNodesManager fnm = env.getMasterServices().getFavoredNodesManager();
> if (fnm != null) {
> fnm.deleteFavoredNodesForRegions(regions);
> }
> }
> {code}
> 1. deleteRegions : delete the info column family first;
> 2. cleanAnyRemainingRows : delete the whole row for regions then.
> In fact, we can only change to delete the whole row, no need the extra info
> cf deletion any more.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #432: add move server & move table command in shell
Apache-HBase commented on issue #432: add move server & move table command in shell URL: https://github.com/apache/hbase/pull/432#issuecomment-516392162 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 74 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 394 | master passed | | +1 | javadoc | 16 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 369 | the patch passed | | -1 | rubocop | 15 | The patch generated 49 new + 18 unchanged - 276 fixed = 67 total (was 294) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | javadoc | 14 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 147 | hbase-shell in the patch failed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 1117 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestReplicationShell | | | hadoop.hbase.client.rsgroup.TestShellRSGroups | | | hadoop.hbase.client.TestAdminShell2 | | | hadoop.hbase.client.TestShell | | | hadoop.hbase.client.TestQuotasShell | | | hadoop.hbase.client.TestAdminShell | | | hadoop.hbase.client.TestShellNoCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/432 | | Optional Tests | dupname asflicense javac javadoc unit rubocop | | uname | Linux b3944ecdadf7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-432/out/precommit/personality/provided.sh | | git revision | master / 4a61c8b10a | | Default Java | 1.8.0_181 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/1/artifact/out/diff-patch-rubocop.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/1/artifact/out/patch-unit-hbase-shell.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/1/testReport/ | | Max. process+thread count | 2465 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr…
Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr… URL: https://github.com/apache/hbase/pull/429#issuecomment-516395505 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 99 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 315 | master passed | | +1 | javadoc | 12 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 286 | the patch passed | | -1 | rubocop | 5 | The patch generated 11 new + 13 unchanged - 8 fixed = 24 total (was 21) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | javadoc | 11 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 819 | hbase-shell in the patch failed. | | +1 | asflicense | 9 | The patch does not generate ASF License warnings. | | | | 1631 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestShell | | | hadoop.hbase.client.TestAdminShell | | | hadoop.hbase.client.TestAdminShell2 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/429 | | Optional Tests | dupname asflicense javac javadoc unit rubocop | | uname | Linux c12373b43350 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-429/out/precommit/personality/provided.sh | | git revision | master / 4a61c8b10a | | Default Java | 1.8.0_181 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/8/artifact/out/diff-patch-rubocop.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/8/artifact/out/patch-unit-hbase-shell.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/8/testReport/ | | Max. process+thread count | 2502 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/8/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #432: add move server & move table command in shell
Apache-HBase commented on issue #432: add move server & move table command in shell URL: https://github.com/apache/hbase/pull/432#issuecomment-516400318 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 183 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 449 | master passed | | +1 | javadoc | 23 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 303 | the patch passed | | -1 | rubocop | 27 | The patch generated 49 new + 18 unchanged - 276 fixed = 67 total (was 294) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | javadoc | 13 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 168 | hbase-shell in the patch failed. | | +1 | asflicense | 16 | The patch does not generate ASF License warnings. | | | | 1270 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestQuotasShell | | | hadoop.hbase.client.TestShell | | | hadoop.hbase.client.TestAdminShell2 | | | hadoop.hbase.client.TestShellNoCluster | | | hadoop.hbase.client.TestReplicationShell | | | hadoop.hbase.client.TestAdminShell | | | hadoop.hbase.client.rsgroup.TestShellRSGroups | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/432 | | Optional Tests | dupname asflicense javac javadoc unit rubocop | | uname | Linux 15a2396aec74 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-432/out/precommit/personality/provided.sh | | git revision | master / 4a61c8b10a | | Default Java | 1.8.0_181 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/2/artifact/out/diff-patch-rubocop.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/2/artifact/out/patch-unit-hbase-shell.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/2/testReport/ | | Max. process+thread count | 2533 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr…
Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr… URL: https://github.com/apache/hbase/pull/429#issuecomment-516403083 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 73 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 336 | master passed | | +1 | javadoc | 12 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 327 | the patch passed | | -1 | rubocop | 7 | The patch generated 11 new + 13 unchanged - 8 fixed = 24 total (was 21) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | javadoc | 12 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 785 | hbase-shell in the patch failed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 1638 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestShell | | | hadoop.hbase.client.TestAdminShell2 | | | hadoop.hbase.client.TestAdminShell | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/429 | | Optional Tests | dupname asflicense javac javadoc unit rubocop | | uname | Linux d1073daa8c50 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-429/out/precommit/personality/provided.sh | | git revision | master / 4a61c8b10a | | Default Java | 1.8.0_181 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/9/artifact/out/diff-patch-rubocop.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/9/artifact/out/patch-unit-hbase-shell.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/9/testReport/ | | Max. process+thread count | 2510 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/9/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani updated HBASE-22735:
-
Attachment: (was: HBASE-22735.branch-1.02.patch)
> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch,
> HBASE-22735.branch-1.02.patch, HBASE-22735.master.01.patch, list_regions.out
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani updated HBASE-22735:
-
Attachment: HBASE-22735.branch-1.02.patch
> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch,
> HBASE-22735.branch-1.02.patch, HBASE-22735.master.01.patch, list_regions.out
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes
Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes URL: https://github.com/apache/hbase/pull/374#issuecomment-516406497 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 71 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | -1 | mvninstall | 19 | root in master failed. | | +1 | compile | 27 | master passed | | +1 | checkstyle | 22 | master passed | | +1 | shadedjars | 284 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 21 | master passed | | 0 | spotbugs | 49 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 46 | master passed | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 15 | root in the patch failed. | | +1 | compile | 21 | the patch passed | | +1 | javac | 21 | the patch passed | | -1 | checkstyle | 23 | hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 274 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 11 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 24 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 35 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 20 | the patch passed | | +1 | findbugs | 53 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 187 | hbase-common in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 1207 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/36/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/374 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d8c5f9273d3b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh | | git revision | master / 4a61c8b10a | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/36/artifact/out/branch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/36/artifact/out/patch-mvninstall-root.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/36/artifact/out/diff-checkstyle-hbase-common.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/36/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/36/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/36/artifact/out/patch-javac-3.1.2.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/36/testReport/ | | Max. process+thread count | 291 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/36/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #432: add move server & move table command in shell
Apache-HBase commented on issue #432: add move server & move table command in shell URL: https://github.com/apache/hbase/pull/432#issuecomment-516406745 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 50 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 310 | master passed | | +1 | javadoc | 14 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 287 | the patch passed | | -1 | rubocop | 13 | The patch generated 49 new + 18 unchanged - 276 fixed = 67 total (was 294) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | javadoc | 14 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 121 | hbase-shell in the patch failed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 893 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestShell | | | hadoop.hbase.client.TestReplicationShell | | | hadoop.hbase.client.TestAdminShell2 | | | hadoop.hbase.client.TestQuotasShell | | | hadoop.hbase.client.TestShellNoCluster | | | hadoop.hbase.client.rsgroup.TestShellRSGroups | | | hadoop.hbase.client.TestAdminShell | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/432 | | Optional Tests | dupname asflicense javac javadoc unit rubocop | | uname | Linux 41bf671d6a12 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-432/out/precommit/personality/provided.sh | | git revision | master / 4a61c8b10a | | Default Java | 1.8.0_181 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/3/artifact/out/diff-patch-rubocop.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/3/artifact/out/patch-unit-hbase-shell.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/3/testReport/ | | Max. process+thread count | 2253 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #411: HBASE-22739 check bound where removeRegion
Apache-HBase commented on issue #411: HBASE-22739 check bound where removeRegion URL: https://github.com/apache/hbase/pull/411#issuecomment-516407581 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 272 | branch-2.1 passed | | +1 | compile | 49 | branch-2.1 passed | | +1 | checkstyle | 74 | branch-2.1 passed | | +1 | shadedjars | 233 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 31 | branch-2.1 passed | | 0 | spotbugs | 158 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 155 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 271 | the patch passed | | +1 | compile | 51 | the patch passed | | +1 | javac | 51 | the patch passed | | -1 | checkstyle | 74 | hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 228 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1134 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 36 | the patch passed | | +1 | findbugs | 182 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8339 | hbase-server in the patch passed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 11536 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/411 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 6a99de151a68 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh | | git revision | branch-2.1 / 11b647be23 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/9/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/9/testReport/ | | Max. process+thread count | 4423 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/9/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-516408830 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 116 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 328 | branch-2.1 passed | | +1 | compile | 26 | branch-2.1 passed | | +1 | checkstyle | 37 | branch-2.1 passed | | +1 | shadedjars | 239 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 21 | branch-2.1 passed | | 0 | spotbugs | 74 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 71 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 271 | the patch passed | | +1 | compile | 23 | the patch passed | | +1 | javac | 23 | the patch passed | | +1 | checkstyle | 33 | hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 229 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1150 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 20 | the patch passed | | +1 | findbugs | 80 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 186 | hbase-client in the patch passed. | | +1 | asflicense | 9 | The patch does not generate ASF License warnings. | | | | 3179 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/23/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/343 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b67b650cbe77 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh | | git revision | branch-2.1 / 29f8e195ef | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/23/testReport/ | | Max. process+thread count | 298 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/23/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr…
Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr… URL: https://github.com/apache/hbase/pull/429#issuecomment-516412460 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 63 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 281 | master passed | | +1 | javadoc | 13 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 289 | the patch passed | | -1 | rubocop | 5 | The patch generated 11 new + 13 unchanged - 8 fixed = 24 total (was 21) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | javadoc | 11 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 815 | hbase-shell in the patch failed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 1557 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestShell | | | hadoop.hbase.client.TestAdminShell2 | | | hadoop.hbase.client.TestAdminShell | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/429 | | Optional Tests | dupname asflicense javac javadoc unit rubocop | | uname | Linux de83192689e5 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-429/out/precommit/personality/provided.sh | | git revision | master / 4a61c8b10a | | Default Java | 1.8.0_181 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/10/artifact/out/diff-patch-rubocop.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/10/artifact/out/patch-unit-hbase-shell.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/10/testReport/ | | Max. process+thread count | 2504 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/10/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-14857) add region server groups in master UI
[ https://issues.apache.org/jira/browse/HBASE-14857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-14857. --- Resolution: Implemented Region server group UI was added by HBASE-19799. > add region server groups in master UI > - > > Key: HBASE-14857 > URL: https://issues.apache.org/jira/browse/HBASE-14857 > Project: HBase > Issue Type: New Feature >Reporter: Francis Liu >Priority: Major > Labels: hbase-6721 > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
