[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop
Apache-HBase commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-521894484 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 42 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 1 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 22 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 313 | master passed | | +1 | compile | 167 | master passed | | +1 | checkstyle | 146 | master passed | | +1 | shadedjars | 276 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 177 | master passed | | 0 | spotbugs | 28 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 28 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 294 | the patch passed | | +1 | compile | 170 | the patch passed | | +1 | javac | 170 | the patch passed | | +1 | checkstyle | 141 | the patch passed | | +1 | shellcheck | 1 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 4 | The patch has no ill-formed XML file. | | +1 | shadedjars | 273 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 936 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 194 | the patch passed | | 0 | findbugs | 27 | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | -1 | unit | 9535 | root in the patch failed. | | +1 | asflicense | 72 | The patch does not generate ASF License warnings. | | | | 15075 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/17/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/476 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux 31954dd059c9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476/out/precommit/personality/provided.sh | | git revision | master / 60971bee66 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/17/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/17/testReport/ | | Max. process+thread count | 4804 (vs. ulimit of 1) | | modules | C: hbase-hbtop . hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/17/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-521890192 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 363 | master passed | | +1 | compile | 52 | master passed | | +1 | checkstyle | 73 | master passed | | +1 | shadedjars | 271 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 34 | master passed | | 0 | spotbugs | 258 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 257 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 291 | the patch passed | | +1 | compile | 54 | the patch passed | | +1 | javac | 54 | the patch passed | | +1 | checkstyle | 75 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 274 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 912 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 252 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 8496 | hbase-server in the patch failed. | | +1 | asflicense | 24 | The patch does not generate ASF License warnings. | | | | 11857 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/24/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/468 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7e9ca1ba72b2 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh | | git revision | master / 78f5d8ebb2 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/24/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/24/testReport/ | | Max. process+thread count | 4621 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/24/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-20821) Re-creating a dropped namespace and contained table inherits previously set space quota settings
[
https://issues.apache.org/jira/browse/HBASE-20821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908728#comment-16908728
]
Sakthi commented on HBASE-20821:
Sure!
> Re-creating a dropped namespace and contained table inherits previously set
> space quota settings
>
>
> Key: HBASE-20821
> URL: https://issues.apache.org/jira/browse/HBASE-20821
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.1.0
>Reporter: Nihal Jain
>Assignee: Shardul Singh
>Priority: Major
> Labels: Quota, Space
> Fix For: 3.0.0, 2.1.0
>
> Attachments: HBASE-20821.master.001.patch,
> HBASE-20821.master.002.patch, HBASE-20821.master.003.patch
>
>
> As demonstarted in
> [HBASE-20662.master.002.patch|https://issues.apache.org/jira/secure/attachment/12927187/HBASE-20662.master.002.patch]
> re-creating a dropped namespace and contained table inherits previously set
> space quota settings.
> *Steps:*
> * Create a namespace and a table in it
> * Set space quota on namespace
> * Violate namespace quota
> * Drop table and then namespace
> * Re create same namespace and same table
> * Put data into the table (more than the previosuly set namespace quota
> limit)
> {code:java}
> private void setQuotaAndThenDropNamespace(final String namespace,
> SpaceViolationPolicy policy)
> throws Exception {
> Put put = new Put(Bytes.toBytes("to_reject"));
> put.addColumn(Bytes.toBytes(SpaceQuotaHelperForTests.F1),
> Bytes.toBytes("to"),
> Bytes.toBytes("reject"));
> createNamespaceIfNotExist(TEST_UTIL.getAdmin(), namespace);
> // Do puts until we violate space policy
> final TableName tn =
> writeUntilNSSpaceViolationAndVerifyViolation(namespace, policy, put);
> // Now, drop the table
> TEST_UTIL.deleteTable(tn);
> LOG.debug("Successfully deleted table ", tn);
> // Now, drop the namespace
> TEST_UTIL.getAdmin().deleteNamespace(namespace);
> LOG.debug("Successfully deleted the namespace ", namespace);
> // Now re-create the namespace
> createNamespaceIfNotExist(TEST_UTIL.getAdmin(), namespace);
> LOG.debug("Successfully re-created the namespace ", namespace);
> TEST_UTIL.createTable(tn, Bytes.toBytes(SpaceQuotaHelperForTests.F1));
> LOG.debug("Successfully re-created table ", tn);
> // Put some rows now: should not violate as namespace/quota was dropped
> verifyNoViolation(policy, tn, put);
> }
> {code}
> *Expected*: SpaceQuota settings should not exist on the newly re-created
> table and we should be able to put limit less data into the table
> *Actual:* We fail to put data into newly created table as SpaceQuota settings
> (systematically created due to previously added namespace space quota) exist
> on table
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-20821) Re-creating a dropped namespace and contained table inherits previously set space quota settings
[
https://issues.apache.org/jira/browse/HBASE-20821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shardul Singh updated HBASE-20821:
--
Attachment: (was: HBASE-20821.master.v003.patch)
> Re-creating a dropped namespace and contained table inherits previously set
> space quota settings
>
>
> Key: HBASE-20821
> URL: https://issues.apache.org/jira/browse/HBASE-20821
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.1.0
>Reporter: Nihal Jain
>Assignee: Shardul Singh
>Priority: Major
> Labels: Quota, Space
> Fix For: 3.0.0, 2.1.0
>
>
> As demonstarted in
> [HBASE-20662.master.002.patch|https://issues.apache.org/jira/secure/attachment/12927187/HBASE-20662.master.002.patch]
> re-creating a dropped namespace and contained table inherits previously set
> space quota settings.
> *Steps:*
> * Create a namespace and a table in it
> * Set space quota on namespace
> * Violate namespace quota
> * Drop table and then namespace
> * Re create same namespace and same table
> * Put data into the table (more than the previosuly set namespace quota
> limit)
> {code:java}
> private void setQuotaAndThenDropNamespace(final String namespace,
> SpaceViolationPolicy policy)
> throws Exception {
> Put put = new Put(Bytes.toBytes("to_reject"));
> put.addColumn(Bytes.toBytes(SpaceQuotaHelperForTests.F1),
> Bytes.toBytes("to"),
> Bytes.toBytes("reject"));
> createNamespaceIfNotExist(TEST_UTIL.getAdmin(), namespace);
> // Do puts until we violate space policy
> final TableName tn =
> writeUntilNSSpaceViolationAndVerifyViolation(namespace, policy, put);
> // Now, drop the table
> TEST_UTIL.deleteTable(tn);
> LOG.debug("Successfully deleted table ", tn);
> // Now, drop the namespace
> TEST_UTIL.getAdmin().deleteNamespace(namespace);
> LOG.debug("Successfully deleted the namespace ", namespace);
> // Now re-create the namespace
> createNamespaceIfNotExist(TEST_UTIL.getAdmin(), namespace);
> LOG.debug("Successfully re-created the namespace ", namespace);
> TEST_UTIL.createTable(tn, Bytes.toBytes(SpaceQuotaHelperForTests.F1));
> LOG.debug("Successfully re-created table ", tn);
> // Put some rows now: should not violate as namespace/quota was dropped
> verifyNoViolation(policy, tn, put);
> }
> {code}
> *Expected*: SpaceQuota settings should not exist on the newly re-created
> table and we should be able to put limit less data into the table
> *Actual:* We fail to put data into newly created table as SpaceQuota settings
> (systematically created due to previously added namespace space quota) exist
> on table
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-20821) Re-creating a dropped namespace and contained table inherits previously set space quota settings
[
https://issues.apache.org/jira/browse/HBASE-20821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shardul Singh updated HBASE-20821:
--
Attachment: HBASE-20821.master.001.patch
HBASE-20821.master.002.patch
HBASE-20821.master.003.patch
> Re-creating a dropped namespace and contained table inherits previously set
> space quota settings
>
>
> Key: HBASE-20821
> URL: https://issues.apache.org/jira/browse/HBASE-20821
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.1.0
>Reporter: Nihal Jain
>Assignee: Shardul Singh
>Priority: Major
> Labels: Quota, Space
> Fix For: 3.0.0, 2.1.0
>
> Attachments: HBASE-20821.master.001.patch,
> HBASE-20821.master.002.patch, HBASE-20821.master.003.patch
>
>
> As demonstarted in
> [HBASE-20662.master.002.patch|https://issues.apache.org/jira/secure/attachment/12927187/HBASE-20662.master.002.patch]
> re-creating a dropped namespace and contained table inherits previously set
> space quota settings.
> *Steps:*
> * Create a namespace and a table in it
> * Set space quota on namespace
> * Violate namespace quota
> * Drop table and then namespace
> * Re create same namespace and same table
> * Put data into the table (more than the previosuly set namespace quota
> limit)
> {code:java}
> private void setQuotaAndThenDropNamespace(final String namespace,
> SpaceViolationPolicy policy)
> throws Exception {
> Put put = new Put(Bytes.toBytes("to_reject"));
> put.addColumn(Bytes.toBytes(SpaceQuotaHelperForTests.F1),
> Bytes.toBytes("to"),
> Bytes.toBytes("reject"));
> createNamespaceIfNotExist(TEST_UTIL.getAdmin(), namespace);
> // Do puts until we violate space policy
> final TableName tn =
> writeUntilNSSpaceViolationAndVerifyViolation(namespace, policy, put);
> // Now, drop the table
> TEST_UTIL.deleteTable(tn);
> LOG.debug("Successfully deleted table ", tn);
> // Now, drop the namespace
> TEST_UTIL.getAdmin().deleteNamespace(namespace);
> LOG.debug("Successfully deleted the namespace ", namespace);
> // Now re-create the namespace
> createNamespaceIfNotExist(TEST_UTIL.getAdmin(), namespace);
> LOG.debug("Successfully re-created the namespace ", namespace);
> TEST_UTIL.createTable(tn, Bytes.toBytes(SpaceQuotaHelperForTests.F1));
> LOG.debug("Successfully re-created table ", tn);
> // Put some rows now: should not violate as namespace/quota was dropped
> verifyNoViolation(policy, tn, put);
> }
> {code}
> *Expected*: SpaceQuota settings should not exist on the newly re-created
> table and we should be able to put limit less data into the table
> *Actual:* We fail to put data into newly created table as SpaceQuota settings
> (systematically created due to previously added namespace space quota) exist
> on table
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-20821) Re-creating a dropped namespace and contained table inherits previously set space quota settings
[
https://issues.apache.org/jira/browse/HBASE-20821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908720#comment-16908720
]
Shardul Singh commented on HBASE-20821:
---
hi [~jatsakthi], can you review this patch?
> Re-creating a dropped namespace and contained table inherits previously set
> space quota settings
>
>
> Key: HBASE-20821
> URL: https://issues.apache.org/jira/browse/HBASE-20821
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.1.0
>Reporter: Nihal Jain
>Assignee: Shardul Singh
>Priority: Major
> Labels: Quota, Space
> Fix For: 3.0.0, 2.1.0
>
> Attachments: HBASE-20821.master.001.patch,
> HBASE-20821.master.002.patch, HBASE-20821.master.003.patch
>
>
> As demonstarted in
> [HBASE-20662.master.002.patch|https://issues.apache.org/jira/secure/attachment/12927187/HBASE-20662.master.002.patch]
> re-creating a dropped namespace and contained table inherits previously set
> space quota settings.
> *Steps:*
> * Create a namespace and a table in it
> * Set space quota on namespace
> * Violate namespace quota
> * Drop table and then namespace
> * Re create same namespace and same table
> * Put data into the table (more than the previosuly set namespace quota
> limit)
> {code:java}
> private void setQuotaAndThenDropNamespace(final String namespace,
> SpaceViolationPolicy policy)
> throws Exception {
> Put put = new Put(Bytes.toBytes("to_reject"));
> put.addColumn(Bytes.toBytes(SpaceQuotaHelperForTests.F1),
> Bytes.toBytes("to"),
> Bytes.toBytes("reject"));
> createNamespaceIfNotExist(TEST_UTIL.getAdmin(), namespace);
> // Do puts until we violate space policy
> final TableName tn =
> writeUntilNSSpaceViolationAndVerifyViolation(namespace, policy, put);
> // Now, drop the table
> TEST_UTIL.deleteTable(tn);
> LOG.debug("Successfully deleted table ", tn);
> // Now, drop the namespace
> TEST_UTIL.getAdmin().deleteNamespace(namespace);
> LOG.debug("Successfully deleted the namespace ", namespace);
> // Now re-create the namespace
> createNamespaceIfNotExist(TEST_UTIL.getAdmin(), namespace);
> LOG.debug("Successfully re-created the namespace ", namespace);
> TEST_UTIL.createTable(tn, Bytes.toBytes(SpaceQuotaHelperForTests.F1));
> LOG.debug("Successfully re-created table ", tn);
> // Put some rows now: should not violate as namespace/quota was dropped
> verifyNoViolation(policy, tn, put);
> }
> {code}
> *Expected*: SpaceQuota settings should not exist on the newly re-created
> table and we should be able to put limit less data into the table
> *Actual:* We fail to put data into newly created table as SpaceQuota settings
> (systematically created due to previously added namespace space quota) exist
> on table
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-20821) Re-creating a dropped namespace and contained table inherits previously set space quota settings
[
https://issues.apache.org/jira/browse/HBASE-20821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shardul Singh updated HBASE-20821:
--
Attachment: (was: HBASE-20821.master.v002.patch)
> Re-creating a dropped namespace and contained table inherits previously set
> space quota settings
>
>
> Key: HBASE-20821
> URL: https://issues.apache.org/jira/browse/HBASE-20821
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.1.0
>Reporter: Nihal Jain
>Assignee: Shardul Singh
>Priority: Major
> Labels: Quota, Space
> Fix For: 3.0.0, 2.1.0
>
>
> As demonstarted in
> [HBASE-20662.master.002.patch|https://issues.apache.org/jira/secure/attachment/12927187/HBASE-20662.master.002.patch]
> re-creating a dropped namespace and contained table inherits previously set
> space quota settings.
> *Steps:*
> * Create a namespace and a table in it
> * Set space quota on namespace
> * Violate namespace quota
> * Drop table and then namespace
> * Re create same namespace and same table
> * Put data into the table (more than the previosuly set namespace quota
> limit)
> {code:java}
> private void setQuotaAndThenDropNamespace(final String namespace,
> SpaceViolationPolicy policy)
> throws Exception {
> Put put = new Put(Bytes.toBytes("to_reject"));
> put.addColumn(Bytes.toBytes(SpaceQuotaHelperForTests.F1),
> Bytes.toBytes("to"),
> Bytes.toBytes("reject"));
> createNamespaceIfNotExist(TEST_UTIL.getAdmin(), namespace);
> // Do puts until we violate space policy
> final TableName tn =
> writeUntilNSSpaceViolationAndVerifyViolation(namespace, policy, put);
> // Now, drop the table
> TEST_UTIL.deleteTable(tn);
> LOG.debug("Successfully deleted table ", tn);
> // Now, drop the namespace
> TEST_UTIL.getAdmin().deleteNamespace(namespace);
> LOG.debug("Successfully deleted the namespace ", namespace);
> // Now re-create the namespace
> createNamespaceIfNotExist(TEST_UTIL.getAdmin(), namespace);
> LOG.debug("Successfully re-created the namespace ", namespace);
> TEST_UTIL.createTable(tn, Bytes.toBytes(SpaceQuotaHelperForTests.F1));
> LOG.debug("Successfully re-created table ", tn);
> // Put some rows now: should not violate as namespace/quota was dropped
> verifyNoViolation(policy, tn, put);
> }
> {code}
> *Expected*: SpaceQuota settings should not exist on the newly re-created
> table and we should be able to put limit less data into the table
> *Actual:* We fail to put data into newly created table as SpaceQuota settings
> (systematically created due to previously added namespace space quota) exist
> on table
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-20821) Re-creating a dropped namespace and contained table inherits previously set space quota settings
[
https://issues.apache.org/jira/browse/HBASE-20821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shardul Singh updated HBASE-20821:
--
Attachment: (was: HBASE-20821.master.v001patch)
> Re-creating a dropped namespace and contained table inherits previously set
> space quota settings
>
>
> Key: HBASE-20821
> URL: https://issues.apache.org/jira/browse/HBASE-20821
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.1.0
>Reporter: Nihal Jain
>Assignee: Shardul Singh
>Priority: Major
> Labels: Quota, Space
> Fix For: 3.0.0, 2.1.0
>
>
> As demonstarted in
> [HBASE-20662.master.002.patch|https://issues.apache.org/jira/secure/attachment/12927187/HBASE-20662.master.002.patch]
> re-creating a dropped namespace and contained table inherits previously set
> space quota settings.
> *Steps:*
> * Create a namespace and a table in it
> * Set space quota on namespace
> * Violate namespace quota
> * Drop table and then namespace
> * Re create same namespace and same table
> * Put data into the table (more than the previosuly set namespace quota
> limit)
> {code:java}
> private void setQuotaAndThenDropNamespace(final String namespace,
> SpaceViolationPolicy policy)
> throws Exception {
> Put put = new Put(Bytes.toBytes("to_reject"));
> put.addColumn(Bytes.toBytes(SpaceQuotaHelperForTests.F1),
> Bytes.toBytes("to"),
> Bytes.toBytes("reject"));
> createNamespaceIfNotExist(TEST_UTIL.getAdmin(), namespace);
> // Do puts until we violate space policy
> final TableName tn =
> writeUntilNSSpaceViolationAndVerifyViolation(namespace, policy, put);
> // Now, drop the table
> TEST_UTIL.deleteTable(tn);
> LOG.debug("Successfully deleted table ", tn);
> // Now, drop the namespace
> TEST_UTIL.getAdmin().deleteNamespace(namespace);
> LOG.debug("Successfully deleted the namespace ", namespace);
> // Now re-create the namespace
> createNamespaceIfNotExist(TEST_UTIL.getAdmin(), namespace);
> LOG.debug("Successfully re-created the namespace ", namespace);
> TEST_UTIL.createTable(tn, Bytes.toBytes(SpaceQuotaHelperForTests.F1));
> LOG.debug("Successfully re-created table ", tn);
> // Put some rows now: should not violate as namespace/quota was dropped
> verifyNoViolation(policy, tn, put);
> }
> {code}
> *Expected*: SpaceQuota settings should not exist on the newly re-created
> table and we should be able to put limit less data into the table
> *Actual:* We fail to put data into newly created table as SpaceQuota settings
> (systematically created due to previously added namespace space quota) exist
> on table
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] eomiks edited a comment on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…
eomiks edited a comment on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f… URL: https://github.com/apache/hbase/pull/484#issuecomment-521884603 @Reidd at first, I thought backporting HBASE-19863 make the problem go away and I wrote that description. but through some tests and new patches, I realized there's more (bugs & patches for 1.4) there. So, yeah. My first description was not updated property. this is not simple backport of HBASE-19863. It's the backport of HBASE-19863 and a part of **HBASE-17958** related to storeScanner SEEK/SKIP This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] eomiks edited a comment on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…
eomiks edited a comment on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f… URL: https://github.com/apache/hbase/pull/484#issuecomment-521884603 @Reidd at first, I thought backporting HBASE-19863 make the problem go away and I wrote that description. but through some tests and new patches, I realized there's more (bugs & patches for 1.4) there. So, yeah. My first description was not updated property. this is not simple backport of HBASE-19863. It's the backport of HBASE-19863 **and a part of HBASE-17958** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload
Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/494#issuecomment-521886784 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 158 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2 Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for branch | | +1 | mvninstall | 452 | branch-2 passed | | +1 | compile | 145 | branch-2 passed | | +1 | checkstyle | 152 | branch-2 passed | | +1 | shadedjars | 320 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 79 | branch-2 passed | | 0 | spotbugs | 260 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 531 | branch-2 passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 429 | the patch passed | | +1 | compile | 142 | the patch passed | | +1 | cc | 142 | the patch passed | | +1 | javac | 142 | the patch passed | | -1 | checkstyle | 111 | hbase-server: The patch generated 2 new + 302 unchanged - 0 fixed = 304 total (was 302) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 354 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1370 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | hbaseprotoc | 160 | the patch passed | | +1 | javadoc | 106 | the patch passed | | -1 | findbugs | 268 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 48 | hbase-protocol-shaded in the patch passed. | | +1 | unit | 228 | hbase-client in the patch passed. | | -1 | unit | 2350 | hbase-server in the patch failed. | | +1 | asflicense | 181 | The patch does not generate ASF License warnings. | | | | 8675 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256] | | Failed junit tests | hadoop.hbase.regionserver.TestBulkLoad | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/494 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc | | uname | Linux 6d6ebd73ce0c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh | | git revision | branch-2 / 3ff39386f4 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/6/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/6/artifact/out/new-findbugs-hbase-server.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/6/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/6/testReport/ | | Max. process+thread count | 699 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at:
[jira] [Commented] (HBASE-22013) SpaceQuota utilization issue with region replicas enabled
[ https://issues.apache.org/jira/browse/HBASE-22013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908718#comment-16908718 ] Shardul Singh commented on HBASE-22013: --- Thanks [~jatsakthi] for reviewing the patch and sorry for the naming convention mistake. As told, I have handled the review comments given by you and have uploaded a new patch. > SpaceQuota utilization issue with region replicas enabled > - > > Key: HBASE-22013 > URL: https://issues.apache.org/jira/browse/HBASE-22013 > Project: HBase > Issue Type: Bug >Reporter: Ajeet Rai >Assignee: Shardul Singh >Priority: Major > Labels: Quota, Space > Fix For: 2.1.0 > > Attachments: HBASE-22013.master.001.patch, > HBASE-22013.master.002.patch > > > Space Quota: Space Quota Issue: If a table is created with region replica > then quota calculation is not happening > Steps: > 1: Create a table with 100 regions with region replica 3 > 2: Observe that 'hbase:quota' table doesn't have entry of usage for this > table So In UI only policy Limit and Policy is shown but not Usage and State. > Reason: > It looks like File system utilization core is sending data of 100 reasons > but not the size of region replicas. > But in quota observer chore, it is considering total region(actual regions+ > replica reasons) > So the ratio of reported regions is less then configured > percentRegionsReportedThreshold. > SO quota calculation is not happening -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22013) SpaceQuota utilization issue with region replicas enabled
[ https://issues.apache.org/jira/browse/HBASE-22013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shardul Singh updated HBASE-22013: -- Attachment: HBASE-22013.master.002.patch HBASE-22013.master.001.patch > SpaceQuota utilization issue with region replicas enabled > - > > Key: HBASE-22013 > URL: https://issues.apache.org/jira/browse/HBASE-22013 > Project: HBase > Issue Type: Bug >Reporter: Ajeet Rai >Assignee: Shardul Singh >Priority: Major > Labels: Quota, Space > Fix For: 2.1.0 > > Attachments: HBASE-22013.master.001.patch, > HBASE-22013.master.002.patch > > > Space Quota: Space Quota Issue: If a table is created with region replica > then quota calculation is not happening > Steps: > 1: Create a table with 100 regions with region replica 3 > 2: Observe that 'hbase:quota' table doesn't have entry of usage for this > table So In UI only policy Limit and Policy is shown but not Usage and State. > Reason: > It looks like File system utilization core is sending data of 100 reasons > but not the size of region replicas. > But in quota observer chore, it is considering total region(actual regions+ > replica reasons) > So the ratio of reported regions is less then configured > percentRegionsReportedThreshold. > SO quota calculation is not happening -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22013) SpaceQuota utilization issue with region replicas enabled
[ https://issues.apache.org/jira/browse/HBASE-22013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shardul Singh updated HBASE-22013: -- Attachment: (was: HBASE-22013.master.v001.patch) > SpaceQuota utilization issue with region replicas enabled > - > > Key: HBASE-22013 > URL: https://issues.apache.org/jira/browse/HBASE-22013 > Project: HBase > Issue Type: Bug >Reporter: Ajeet Rai >Assignee: Shardul Singh >Priority: Major > Labels: Quota, Space > Fix For: 2.1.0 > > > Space Quota: Space Quota Issue: If a table is created with region replica > then quota calculation is not happening > Steps: > 1: Create a table with 100 regions with region replica 3 > 2: Observe that 'hbase:quota' table doesn't have entry of usage for this > table So In UI only policy Limit and Policy is shown but not Usage and State. > Reason: > It looks like File system utilization core is sending data of 100 reasons > but not the size of region replicas. > But in quota observer chore, it is considering total region(actual regions+ > replica reasons) > So the ratio of reported regions is less then configured > percentRegionsReportedThreshold. > SO quota calculation is not happening -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] eomiks edited a comment on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…
eomiks edited a comment on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f… URL: https://github.com/apache/hbase/pull/484#issuecomment-521884603 @Reidd at first, I thought backporting HBASE-19863 make the problem go away and I wrote that description. but through some tests and new patches, I realized there's more (bugs & patches for 1.4) there. So, yeah. My first description had wrong information. this is not simple backport of HBASE-19863. It's the backport of HBASE-19863 **and a part of HBASE-17958** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-521885561 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 99 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 381 | master passed | | +1 | compile | 52 | master passed | | +1 | checkstyle | 75 | master passed | | +1 | shadedjars | 276 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 35 | master passed | | 0 | spotbugs | 245 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 243 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 299 | the patch passed | | +1 | compile | 54 | the patch passed | | +1 | javac | 54 | the patch passed | | +1 | checkstyle | 77 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 279 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 940 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 257 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8679 | hbase-server in the patch passed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 12192 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/23/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/468 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2b312e233019 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh | | git revision | master / 60971bee66 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/23/testReport/ | | Max. process+thread count | 4693 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/23/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] eomiks edited a comment on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…
eomiks edited a comment on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f… URL: https://github.com/apache/hbase/pull/484#issuecomment-521884603 @Reidd at first, I thought backporting HBASE-19863 make the problem go away and I wrote that description. but through some tests and new patches, I realized there's more bugs (& patches for 1.4) there. So, yeah. My first description had wrong information. this is not simple backport of HBASE-19863. It's the backport of HBASE-19863 **and a part of HBASE-17958** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Description:
Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
AssertionError of scan order check.
which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
A same bug exists in branch 1.3 and older, and also my cluster suffered from
the same problem.
When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
actual hfs offset can be behind, in this case heap.next() is not enough. it
requires reseek to find right next cell.
{code:java}
java.lang.AssertionError: Key
key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller key
key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
at
org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
at
org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
at
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
at
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
at
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
at
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168) {code}
I created a backport patch of -HBASE-19863 and *HBASE-17958*-.
Exact same testcase included. And changed StoreScanner due to the difference of
codes.
was:
Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
AssertionError of scan order check.
which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
A same bug exists in branch 1.3 and older, and also my cluster suffered from
the same problem.
When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
actual hfs offset can be behind, in this case heap.next() is not enough. it
requires reseek to find right next cell.
{code:java}
java.lang.AssertionError: Key
key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller key
key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
at
org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
at
org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
at
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
at
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
at
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
at
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168) {code}
I created a backport patch of HBASE-19863.
Exact same testcase included. And changed StoreScanner due to the difference of
codes.
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch,
> HBASE-22835.v2.branch-1.3.patch, HBASE-22835.v3.branch-1.3.patch,
> HBASE-22835.v4.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3
[GitHub] [hbase] eomiks edited a comment on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…
eomiks edited a comment on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f… URL: https://github.com/apache/hbase/pull/484#issuecomment-521884603 @Reidd at first, I thought backporting HBASE-19863 make the problem go away and I wrote that description. but through some tests and new patches, I realized there's more bugs (& patches for 1.4) there. So, yeah. My first description had wrong information. this is not simple backport of HBASE-19863. It's the backport of HBASE-19863 **and HBASE-17958** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] eomiks commented on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…
eomiks commented on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f… URL: https://github.com/apache/hbase/pull/484#issuecomment-521884603 @Reidd at first, I thought backporting HBASE-19863 make the problem go away and I wrote that description. but through some tests and new patches, I realized there's more bugs (& patches for 1.4) there. So, yeah. My first description had wrong information. this is not simple backport of HBASE-19863. It's backport of HBASE-19863 **and HBASE-17958** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #497: HBASE-22858 Add HBCK Report to master's header.jsp
Apache-HBase commented on issue #497: HBASE-22858 Add HBCK Report to master's header.jsp URL: https://github.com/apache/hbase/pull/497#issuecomment-521884350 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 33 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 365 | master passed | | +1 | javadoc | 42 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 329 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | javadoc | 38 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 9641 | hbase-server in the patch failed. | | +1 | asflicense | 32 | The patch does not generate ASF License warnings. | | | | 10539 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-497/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/497 | | Optional Tests | dupname asflicense javac javadoc unit | | uname | Linux b02673121024 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-497/out/precommit/personality/provided.sh | | git revision | master / 78f5d8ebb2 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-497/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-497/4/testReport/ | | Max. process+thread count | 4516 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-497/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22823) Mark Canary as Public/Evolving
[
https://issues.apache.org/jira/browse/HBASE-22823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908701#comment-16908701
]
Hudson commented on HBASE-22823:
Results for branch branch-1.4
[build #961 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/961/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/961//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/961//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/961//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Mark Canary as Public/Evolving
> --
>
> Key: HBASE-22823
> URL: https://issues.apache.org/jira/browse/HBASE-22823
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Caroline
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22823.branch-1.000.patch,
> HBASE-22823.branch-2.000.patch, HBASE-22823.master.000.patch
>
>
> Canary is marked as a Private class. Its interfaces could change at any time.
> Should we change the annotation on Canary to Public/Evolving? Or add
> annotations on some of these subtypes? I think it depends on how we think
> Canary results should be consumed.
> In our production we find that scraping logs and parsing them is brittle and
> not scalable. Although the scalability issue is more to do with the totality
> of logs from a Hadoopish stack, if you run HBase then you have this problem,
> and you wouldn't be using the canary if you didn't run HBase. We have a tool
> that embeds the Canary and calls various methods and takes actions without
> needing a round trip to the logs and whatever aggregates them.
> I propose we promote Canary to Public/Evolving.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22862) Region Server crash with: Added a key not lexically larger than previous
[
https://issues.apache.org/jira/browse/HBASE-22862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zheng Hu updated HBASE-22862:
-
Priority: Critical (was: Major)
> Region Server crash with: Added a key not lexically larger than previous
>
>
> Key: HBASE-22862
> URL: https://issues.apache.org/jira/browse/HBASE-22862
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 1.4.10
> Environment: {code}
> openjdk version "1.8.0_181"
> OpenJDK Runtime Environment (Zulu 8.31.0.1-linux64) (build 1.8.0_181-b02)
> OpenJDK 64-Bit Server VM (Zulu 8.31.0.1-linux64) (build 25.181-b02, mixed
> mode)
> {code}
>Reporter: Alex Batyrshin
>Priority: Critical
>
> We observer error "Added a key not lexically larger than previous” that cause
> most of our region-servers to crash in our cluster.
> {code}
> 2019-08-15 18:02:10,554 INFO [MemStoreFlusher.0] regionserver.HRegion:
> Flushing 1/1 column families, memstore=56.08 MB
> 2019-08-15 18:02:10,727 WARN [MemStoreFlusher.0] regionserver.HStore: Failed
> flushing store file, retrying num=0
> java.io.IOException: Added a key not lexically larger than previous. Current
> cell =
> \x0901820448218>wGavb'/d:elr/1565881054828/DeleteColumn/vlen=0/seqid=44456567,
> lastCell =
> \x0901820448218>wGavb'/d:elr/1565881054828/Put/vlen=1/seqid=44457770
>at
> org.apache.hadoop.hbase.io.hfile.AbstractHFileWriter.checkKey(AbstractHFileWriter.java:204)
>at
> org.apache.hadoop.hbase.io.hfile.HFileWriterV2.append(HFileWriterV2.java:279)
>at
> org.apache.hadoop.hbase.io.hfile.HFileWriterV3.append(HFileWriterV3.java:87)
>at
> org.apache.hadoop.hbase.regionserver.StoreFile$Writer.append(StoreFile.java:1127)
>at
> org.apache.hadoop.hbase.regionserver.StoreFlusher.performFlush(StoreFlusher.java:139)
>at
> org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:75)
>at
> org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:1003)
>at
> org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.flushCache(HStore.java:2523)
>at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2622)
>at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2352)
>at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2314)
>at
> org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2200)
>at
> org.apache.hadoop.hbase.regionserver.HRegion.flush(HRegion.java:2125)
>at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:512)
>at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:482)
>at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$900(MemStoreFlusher.java:76)
>at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:264)
>at java.lang.Thread.run(Thread.java:748)
> 2019-08-15 18:02:21,776 WARN [MemStoreFlusher.0] regionserver.HStore: Failed
> flushing store file, retrying num=9
> java.io.IOException: Added a key not lexically larger than previous. Current
> cell =
> \x0901820448218>wGavb'/d:elr/1565881054828/DeleteColumn/vlen=0/seqid=44456567,
> lastCell =
> \x0901820448218>wGavb'/d:elr/1565881054828/Put/vlen=1/seqid=44457770
>at
> org.apache.hadoop.hbase.io.hfile.AbstractHFileWriter.checkKey(AbstractHFileWriter.java:204)
>at
> org.apache.hadoop.hbase.io.hfile.HFileWriterV2.append(HFileWriterV2.java:279)
>at
> org.apache.hadoop.hbase.io.hfile.HFileWriterV3.append(HFileWriterV3.java:87)
>at
> org.apache.hadoop.hbase.regionserver.StoreFile$Writer.append(StoreFile.java:1127)
>at
> org.apache.hadoop.hbase.regionserver.StoreFlusher.performFlush(StoreFlusher.java:139)
>at
> org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:75)
>at
> org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:1003)
>at
> org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.flushCache(HStore.java:2523)
>at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2622)
>at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2352)
>at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2314)
>at
> org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2200)
>at
> org.apache.hadoop.hbase.regionserver.HRegion.flush(HRegion.java:2125)
>at
>
[jira] [Commented] (HBASE-22862) Region Server crash with: Added a key not lexically larger than previous
[
https://issues.apache.org/jira/browse/HBASE-22862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908699#comment-16908699
]
Zheng Hu commented on HBASE-22862:
--
Which HBase version are you using ? I think it should be a critical bug ...
> Region Server crash with: Added a key not lexically larger than previous
>
>
> Key: HBASE-22862
> URL: https://issues.apache.org/jira/browse/HBASE-22862
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 1.4.10
> Environment: {code}
> openjdk version "1.8.0_181"
> OpenJDK Runtime Environment (Zulu 8.31.0.1-linux64) (build 1.8.0_181-b02)
> OpenJDK 64-Bit Server VM (Zulu 8.31.0.1-linux64) (build 25.181-b02, mixed
> mode)
> {code}
>Reporter: Alex Batyrshin
>Priority: Major
>
> We observer error "Added a key not lexically larger than previous” that cause
> most of our region-servers to crash in our cluster.
> {code}
> 2019-08-15 18:02:10,554 INFO [MemStoreFlusher.0] regionserver.HRegion:
> Flushing 1/1 column families, memstore=56.08 MB
> 2019-08-15 18:02:10,727 WARN [MemStoreFlusher.0] regionserver.HStore: Failed
> flushing store file, retrying num=0
> java.io.IOException: Added a key not lexically larger than previous. Current
> cell =
> \x0901820448218>wGavb'/d:elr/1565881054828/DeleteColumn/vlen=0/seqid=44456567,
> lastCell =
> \x0901820448218>wGavb'/d:elr/1565881054828/Put/vlen=1/seqid=44457770
>at
> org.apache.hadoop.hbase.io.hfile.AbstractHFileWriter.checkKey(AbstractHFileWriter.java:204)
>at
> org.apache.hadoop.hbase.io.hfile.HFileWriterV2.append(HFileWriterV2.java:279)
>at
> org.apache.hadoop.hbase.io.hfile.HFileWriterV3.append(HFileWriterV3.java:87)
>at
> org.apache.hadoop.hbase.regionserver.StoreFile$Writer.append(StoreFile.java:1127)
>at
> org.apache.hadoop.hbase.regionserver.StoreFlusher.performFlush(StoreFlusher.java:139)
>at
> org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:75)
>at
> org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:1003)
>at
> org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.flushCache(HStore.java:2523)
>at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2622)
>at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2352)
>at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2314)
>at
> org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2200)
>at
> org.apache.hadoop.hbase.regionserver.HRegion.flush(HRegion.java:2125)
>at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:512)
>at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:482)
>at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$900(MemStoreFlusher.java:76)
>at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:264)
>at java.lang.Thread.run(Thread.java:748)
> 2019-08-15 18:02:21,776 WARN [MemStoreFlusher.0] regionserver.HStore: Failed
> flushing store file, retrying num=9
> java.io.IOException: Added a key not lexically larger than previous. Current
> cell =
> \x0901820448218>wGavb'/d:elr/1565881054828/DeleteColumn/vlen=0/seqid=44456567,
> lastCell =
> \x0901820448218>wGavb'/d:elr/1565881054828/Put/vlen=1/seqid=44457770
>at
> org.apache.hadoop.hbase.io.hfile.AbstractHFileWriter.checkKey(AbstractHFileWriter.java:204)
>at
> org.apache.hadoop.hbase.io.hfile.HFileWriterV2.append(HFileWriterV2.java:279)
>at
> org.apache.hadoop.hbase.io.hfile.HFileWriterV3.append(HFileWriterV3.java:87)
>at
> org.apache.hadoop.hbase.regionserver.StoreFile$Writer.append(StoreFile.java:1127)
>at
> org.apache.hadoop.hbase.regionserver.StoreFlusher.performFlush(StoreFlusher.java:139)
>at
> org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:75)
>at
> org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:1003)
>at
> org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.flushCache(HStore.java:2523)
>at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2622)
>at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2352)
>at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2314)
>at
> org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2200)
>at
>
[jira] [Commented] (HBASE-22823) Mark Canary as Public/Evolving
[
https://issues.apache.org/jira/browse/HBASE-22823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908691#comment-16908691
]
Hudson commented on HBASE-22823:
Results for branch branch-2.1
[build #1488 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1488/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1488//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1488//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1488//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Mark Canary as Public/Evolving
> --
>
> Key: HBASE-22823
> URL: https://issues.apache.org/jira/browse/HBASE-22823
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Caroline
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22823.branch-1.000.patch,
> HBASE-22823.branch-2.000.patch, HBASE-22823.master.000.patch
>
>
> Canary is marked as a Private class. Its interfaces could change at any time.
> Should we change the annotation on Canary to Public/Evolving? Or add
> annotations on some of these subtypes? I think it depends on how we think
> Canary results should be consumed.
> In our production we find that scraping logs and parsing them is brittle and
> not scalable. Although the scalability issue is more to do with the totality
> of logs from a Hadoopish stack, if you run HBase then you have this problem,
> and you wouldn't be using the canary if you didn't run HBase. We have a tool
> that embeds the Canary and calls various methods and takes actions without
> needing a round trip to the logs and whatever aggregates them.
> I propose we promote Canary to Public/Evolving.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Resolved] (HBASE-22833) MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters
[
https://issues.apache.org/jira/browse/HBASE-22833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zheng Hu resolved HBASE-22833.
--
Resolution: Fixed
Hadoop Flags: Reviewed
Release Note:
Provide a public method in MultiRowRangeFilter class to speed the requirement
of filtering with multiple row prefixes, it will expand the row prefixes as
multiple rowkey ranges by MultiRowRangeFilter, it's more efficient.
{code}
public MultiRowRangeFilter(byte[][] rowKeyPrefixes);
{code}
> MultiRowRangeFilter should provide a method for creating a filter which is
> functionally equivalent to multiple prefix filters
> -
>
> Key: HBASE-22833
> URL: https://issues.apache.org/jira/browse/HBASE-22833
> Project: HBase
> Issue Type: Wish
> Components: Client
>Affects Versions: 3.0.0
>Reporter: Itsuki Toyota
>Assignee: Itsuki Toyota
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.4.11
>
>
> HI,
> I think current formal way to make multiple prefix filters is to create a
> _FilterList_ and add _PrefixFilter_ instances to the list:
> {code:java}
> FilterList allFilters = new FilterList(FilterList.Operator.MUST_PASS_ONE);
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("123")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("456")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("678")));
> scan.setFilter(allFilters);
> {code}
> (c.f.,
> https://stackoverflow.com/questions/41074213/hbase-how-to-specify-multiple-prefix-filters-in-a-single-scan-operation
> )
> However, in the case of creating a single prefix filter, HBase provides
> _scan.setRowPrefixFilter_ method.
> This method creates a range filter by setting a start row and a stop row.
> The value of a stop row is decided by calling
> _calculateTheClosestNextRowKeyForPrefix_ ( c.f.,
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java#L574-L597
> )
> _MultiRowRangeFilter_ could leverage a list of start row and stop row pairs
> and _calculateTheClosestNextRowKeyForPrefix_ could compute the stop row value
> corresponding to given start row (i.e., a prefix).
> I think this kind of filter (a filter which is functionally equivalent to
> multiple prefix filters) should be creatable by _MultiRowRangeFilter_ and
> it's better than the current formal way.
> Cheers,
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22833) MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters
[
https://issues.apache.org/jira/browse/HBASE-22833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908688#comment-16908688
]
Zheng Hu commented on HBASE-22833:
--
[~titsuki] Granted you with the JIRA contributor permission , and assigned this
JIRA to you. I've pushed the patch to all branch-1.4 / branch-1.5 & branch-2.x
& master (I don't think we need this in branch-1.3, almost EOL and this seems
to be a minior improvement). Thanks for your contribution.
> MultiRowRangeFilter should provide a method for creating a filter which is
> functionally equivalent to multiple prefix filters
> -
>
> Key: HBASE-22833
> URL: https://issues.apache.org/jira/browse/HBASE-22833
> Project: HBase
> Issue Type: Wish
> Components: Client
>Affects Versions: 3.0.0
>Reporter: Itsuki Toyota
>Assignee: Itsuki Toyota
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.4.11
>
>
> HI,
> I think current formal way to make multiple prefix filters is to create a
> _FilterList_ and add _PrefixFilter_ instances to the list:
> {code:java}
> FilterList allFilters = new FilterList(FilterList.Operator.MUST_PASS_ONE);
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("123")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("456")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("678")));
> scan.setFilter(allFilters);
> {code}
> (c.f.,
> https://stackoverflow.com/questions/41074213/hbase-how-to-specify-multiple-prefix-filters-in-a-single-scan-operation
> )
> However, in the case of creating a single prefix filter, HBase provides
> _scan.setRowPrefixFilter_ method.
> This method creates a range filter by setting a start row and a stop row.
> The value of a stop row is decided by calling
> _calculateTheClosestNextRowKeyForPrefix_ ( c.f.,
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java#L574-L597
> )
> _MultiRowRangeFilter_ could leverage a list of start row and stop row pairs
> and _calculateTheClosestNextRowKeyForPrefix_ could compute the stop row value
> corresponding to given start row (i.e., a prefix).
> I think this kind of filter (a filter which is functionally equivalent to
> multiple prefix filters) should be creatable by _MultiRowRangeFilter_ and
> it's better than the current formal way.
> Cheers,
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Assigned] (HBASE-22833) MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters
[
https://issues.apache.org/jira/browse/HBASE-22833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zheng Hu reassigned HBASE-22833:
Assignee: Itsuki Toyota
> MultiRowRangeFilter should provide a method for creating a filter which is
> functionally equivalent to multiple prefix filters
> -
>
> Key: HBASE-22833
> URL: https://issues.apache.org/jira/browse/HBASE-22833
> Project: HBase
> Issue Type: Wish
> Components: Client
>Affects Versions: 3.0.0
>Reporter: Itsuki Toyota
>Assignee: Itsuki Toyota
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.4.11
>
>
> HI,
> I think current formal way to make multiple prefix filters is to create a
> _FilterList_ and add _PrefixFilter_ instances to the list:
> {code:java}
> FilterList allFilters = new FilterList(FilterList.Operator.MUST_PASS_ONE);
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("123")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("456")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("678")));
> scan.setFilter(allFilters);
> {code}
> (c.f.,
> https://stackoverflow.com/questions/41074213/hbase-how-to-specify-multiple-prefix-filters-in-a-single-scan-operation
> )
> However, in the case of creating a single prefix filter, HBase provides
> _scan.setRowPrefixFilter_ method.
> This method creates a range filter by setting a start row and a stop row.
> The value of a stop row is decided by calling
> _calculateTheClosestNextRowKeyForPrefix_ ( c.f.,
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java#L574-L597
> )
> _MultiRowRangeFilter_ could leverage a list of start row and stop row pairs
> and _calculateTheClosestNextRowKeyForPrefix_ could compute the stop row value
> corresponding to given start row (i.e., a prefix).
> I think this kind of filter (a filter which is functionally equivalent to
> multiple prefix filters) should be creatable by _MultiRowRangeFilter_ and
> it's better than the current formal way.
> Cheers,
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22833) MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters
[
https://issues.apache.org/jira/browse/HBASE-22833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zheng Hu updated HBASE-22833:
-
Fix Version/s: 1.4.11
2.1.6
2.2.1
2.0.6
2.3.0
1.5.0
3.0.0
> MultiRowRangeFilter should provide a method for creating a filter which is
> functionally equivalent to multiple prefix filters
> -
>
> Key: HBASE-22833
> URL: https://issues.apache.org/jira/browse/HBASE-22833
> Project: HBase
> Issue Type: Wish
> Components: Client
>Affects Versions: 3.0.0
>Reporter: Itsuki Toyota
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.4.11
>
>
> HI,
> I think current formal way to make multiple prefix filters is to create a
> _FilterList_ and add _PrefixFilter_ instances to the list:
> {code:java}
> FilterList allFilters = new FilterList(FilterList.Operator.MUST_PASS_ONE);
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("123")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("456")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("678")));
> scan.setFilter(allFilters);
> {code}
> (c.f.,
> https://stackoverflow.com/questions/41074213/hbase-how-to-specify-multiple-prefix-filters-in-a-single-scan-operation
> )
> However, in the case of creating a single prefix filter, HBase provides
> _scan.setRowPrefixFilter_ method.
> This method creates a range filter by setting a start row and a stop row.
> The value of a stop row is decided by calling
> _calculateTheClosestNextRowKeyForPrefix_ ( c.f.,
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java#L574-L597
> )
> _MultiRowRangeFilter_ could leverage a list of start row and stop row pairs
> and _calculateTheClosestNextRowKeyForPrefix_ could compute the stop row value
> corresponding to given start row (i.e., a prefix).
> I think this kind of filter (a filter which is functionally equivalent to
> multiple prefix filters) should be creatable by _MultiRowRangeFilter_ and
> it's better than the current formal way.
> Cheers,
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[ https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caroline updated HBASE-22804: - Attachment: HBASE-22804.master.006.patch > Provide an API to get list of successful regions and total expected regions > in Canary > - > > Key: HBASE-22804 > URL: https://issues.apache.org/jira/browse/HBASE-22804 > Project: HBase > Issue Type: Improvement > Components: canary >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1 >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Labels: Canary > Attachments: HBASE-22804.branch-1.001.patch, > HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, > HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, > HBASE-22804.branch-2.001.patch, HBASE-22804.branch-2.002.patch, > HBASE-22804.branch-2.003.patch, HBASE-22804.branch-2.004.patch, > HBASE-22804.branch-2.005.patch, HBASE-22804.master.001.patch, > HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, > HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, > HBASE-22804.master.006.patch > > > At present HBase Canary tool only prints the successes as part of logs. > Providing an API to get the list of successes, as well as total number of > expected regions, will make it easier to get a more accurate availability > estimate. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908683#comment-16908683
]
HBase QA commented on HBASE-22835:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 16m
0s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} branch-1.3 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
16s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
36s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
27s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
32s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_232 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} the patch passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
37s{color} | {color:green} the patch passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} hbase-server: The patch generated 0 new + 372
unchanged - 23 fixed = 372 total (was 395) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
23s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 38s{color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.5 2.7.7. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} the patch passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} the patch passed with JDK v1.7.0_232 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 89m
9s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}135m 32s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/782/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22835 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12977735/HBASE-22835.v4.branch-1.3.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile
[jira] [Commented] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908681#comment-16908681
]
HBase QA commented on HBASE-22804:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
56s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
32s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
34s{color} | {color:red} hbase-server: The patch generated 2 new + 23 unchanged
- 0 fixed = 25 total (was 23) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
50s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
23m 7s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}243m 49s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}318m 48s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.TestMasterShutdown |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/779/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22804 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12977731/HBASE-22804.master.005.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 1738f048aff4 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / edf6f68cb2 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/779/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/779/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-521871360 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 32 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 362 | master passed | | +1 | compile | 25 | master passed | | +1 | checkstyle | 14 | master passed | | +1 | shadedjars | 309 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 22 | master passed | | 0 | spotbugs | 59 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 57 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 338 | the patch passed | | +1 | compile | 26 | the patch passed | | +1 | javac | 26 | the patch passed | | +1 | checkstyle | 12 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 345 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1219 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 22 | the patch passed | | +1 | findbugs | 66 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 463 | hbase-rsgroup in the patch failed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 3808 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.rsgroup.TestRSGroupsAdmin2 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/93/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 414c1971f32f 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / 78f5d8ebb2 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/93/artifact/out/patch-unit-hbase-rsgroup.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/93/testReport/ | | Max. process+thread count | 4555 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/93/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd edited a comment on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…
Reidd edited a comment on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f… URL: https://github.com/apache/hbase/pull/484#issuecomment-521864990 Backport HBASE-19863? First skimmed(not in detailed), looks like they are quite different? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908676#comment-16908676
]
Reid Chan commented on HBASE-22835:
---
I left a comment in github pr.
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch,
> HBASE-22835.v2.branch-1.3.patch, HBASE-22835.v3.branch-1.3.patch,
> HBASE-22835.v4.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908672#comment-16908672
]
HBase QA commented on HBASE-22835:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
37s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} branch-1.3 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
10s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
32s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
34s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
28s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_232 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} the patch passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} the patch passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
15s{color} | {color:green} hbase-server: The patch generated 0 new + 372
unchanged - 23 fixed = 372 total (was 395) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
23s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 43s{color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.5 2.7.7. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
25s{color} | {color:green} the patch passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed with JDK v1.7.0_232 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 98m 40s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}129m 19s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestEncryptionKeyRotation |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/781/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22835 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12977735/HBASE-22835.v4.branch-1.3.patch
|
| Optional Tests | dupname
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-521869309 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 104 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 334 | master passed | | +1 | compile | 86 | master passed | | +1 | checkstyle | 105 | master passed | | +1 | shadedjars | 284 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 57 | master passed | | 0 | spotbugs | 246 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 314 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 317 | the patch passed | | +1 | compile | 79 | the patch passed | | +1 | javac | 79 | the patch passed | | +1 | checkstyle | 103 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 284 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1001 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 55 | the patch passed | | +1 | findbugs | 310 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 106 | hbase-client in the patch passed. | | -1 | unit | 16955 | hbase-server in the patch failed. | | +1 | asflicense | 47 | The patch does not generate ASF License warnings. | | | | 20996 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/101/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f5953b528200 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / edf6f68cb2 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/101/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/101/testReport/ | | Max. process+thread count | 5099 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/101/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #483: HBASE-22841 Add more factory functions to TimeRange
Apache-HBase commented on issue #483: HBASE-22841 Add more factory functions to TimeRange URL: https://github.com/apache/hbase/pull/483#issuecomment-521869475 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 104 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 327 | master passed | | +1 | compile | 83 | master passed | | +1 | checkstyle | 111 | master passed | | +1 | shadedjars | 284 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 63 | master passed | | 0 | spotbugs | 306 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 362 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 309 | the patch passed | | +1 | compile | 83 | the patch passed | | +1 | javac | 83 | the patch passed | | +1 | checkstyle | 110 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 286 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 988 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 68 | the patch passed | | +1 | findbugs | 346 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 175 | hbase-common in the patch passed. | | -1 | unit | 17779 | hbase-server in the patch failed. | | +1 | asflicense | 47 | The patch does not generate ASF License warnings. | | | | 21982 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.client.TestFromClientSide3 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/483 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux cd96b381c3ed 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-483/out/precommit/personality/provided.sh | | git revision | master / edf6f68cb2 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/10/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/10/testReport/ | | Max. process+thread count | 4725 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/10/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-521868634 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 99 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 348 | master passed | | +1 | compile | 62 | master passed | | +1 | checkstyle | 91 | master passed | | +1 | shadedjars | 288 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | master passed | | 0 | spotbugs | 300 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 298 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 330 | the patch passed | | +1 | compile | 58 | the patch passed | | +1 | javac | 58 | the patch passed | | +1 | checkstyle | 84 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 290 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 965 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 36 | the patch passed | | +1 | findbugs | 290 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 17933 | hbase-server in the patch failed. | | +1 | asflicense | 30 | The patch does not generate ASF License warnings. | | | | 21627 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.client.TestAsyncTableAdminApi3 | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.client.TestFromClientSide | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/22/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/468 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 5b8aa48532ab 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh | | git revision | master / edf6f68cb2 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/22/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/22/testReport/ | | Max. process+thread count | 4692 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/22/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility
Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/477#issuecomment-521868301 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 76 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 46 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 353 | master passed | | +1 | compile | 55 | master passed | | +1 | checkstyle | 83 | master passed | | +1 | shadedjars | 278 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 34 | master passed | | 0 | spotbugs | 246 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 243 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 290 | the patch passed | | +1 | compile | 52 | the patch passed | | +1 | javac | 52 | the patch passed | | +1 | checkstyle | 77 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 285 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 949 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 30 | the patch passed | | +1 | findbugs | 245 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 18031 | hbase-server in the patch failed. | | -1 | asflicense | 24 | The patch generated 20 ASF License warnings. | | | | 21479 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.TestNamespace | | | hadoop.hbase.filter.TestScanRowPrefix | | | hadoop.hbase.master.assignment.TestRegionReplicaSplit | | | hadoop.hbase.master.procedure.TestSplitWALProcedure | | | hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService | | | hadoop.hbase.quotas.TestMasterQuotasObserver | | | hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths | | | hadoop.hbase.quotas.TestLowLatencySpaceQuotas | | | hadoop.hbase.client.TestMobCloneSnapshotFromClientAfterSplittingRegion | | | hadoop.hbase.client.TestCIGetRpcTimeout | | | hadoop.hbase.client.TestMobCloneSnapshotFromClientNormal | | | hadoop.hbase.ipc.TestNettyRpcServer | | | hadoop.hbase.TestIOFencing | | | hadoop.hbase.replication.TestSerialReplicationFailover | | | hadoop.hbase.client.TestAdmin | | | hadoop.hbase.master.TestShutdownBackupMaster | | | hadoop.hbase.TestSequenceIdMonotonicallyIncreasing | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.coprocessor.TestCoprocessorStop | | | hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalCopyToRemote | | | hadoop.hbase.master.assignment.TestRegionAssignedToMultipleRegionServers | | | hadoop.hbase.replication.TestPerTableCFReplication | | | hadoop.hbase.client.TestMobCloneSnapshotFromClientError | | | hadoop.hbase.client.TestAsyncTableScanner | | | hadoop.hbase.client.TestAsyncTableLocatePrefetch | | | hadoop.hbase.client.TestServerBusyException | | | hadoop.hbase.replication.TestSyncReplicationStandbyKillRS | | | hadoop.hbase.master.assignment.TestModifyTableWhileMerging | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.TestMetaTableAccessor | | | hadoop.hbase.security.access.TestAccessController2 | | | hadoop.hbase.master.assignment.TestTransitRegionStateProcedure | | | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.master.procedure.TestDisableTableProcedure | | | hadoop.hbase.quotas.TestQuotaTableUtil | | | hadoop.hbase.client.TestAsyncTableScanMetrics | | | hadoop.hbase.TestLocalHBaseCluster | | | hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.regionserver.TestScannerWithCorruptHFile | | | hadoop.hbase.TestAcidGuaranteesWithBasicPolicy | | | hadoop.hbase.master.assignment.TestAssignmentManager | | | hadoop.hbase.client.TestRestoreSnapshotFromClientGetCompactionState | | | hadoop.hbase.client.TestAsyncClusterAdminApi | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientClone | | | hadoop.hbase.client.TestRestoreSnapshotFromClientSchemaChange | | |
[GitHub] [hbase] Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations in client snapshot exceptions
Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations in client snapshot exceptions URL: https://github.com/apache/hbase/pull/487#issuecomment-521866737 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 332 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 30 | master passed | | +1 | shadedjars | 270 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 22 | master passed | | 0 | spotbugs | 73 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 70 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 301 | the patch passed | | +1 | compile | 25 | the patch passed | | +1 | javac | 25 | the patch passed | | +1 | checkstyle | 32 | hbase-client: The patch generated 0 new + 0 unchanged - 13 fixed = 0 total (was 13) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 281 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1018 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 22 | hbase-client generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) | | +1 | findbugs | 79 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 119 | hbase-client in the patch passed. | | +1 | asflicense | 15 | The patch does not generate ASF License warnings. | | | | 3060 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/487 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux ce5160f75741 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-487/out/precommit/personality/provided.sh | | git revision | master / 78f5d8ebb2 | | Default Java | 1.8.0_181 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/9/artifact/out/diff-javadoc-javadoc-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/9/testReport/ | | Max. process+thread count | 292 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/9/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (HBASE-22842) Tmp directory should not be deleted when master restart used for user scan snapshot feature
[
https://issues.apache.org/jira/browse/HBASE-22842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Mei reassigned HBASE-22842:
--
Assignee: Yi Mei
Fix Version/s: 2.3.0
3.0.0
> Tmp directory should not be deleted when master restart used for user scan
> snapshot feature
> ---
>
> Key: HBASE-22842
> URL: https://issues.apache.org/jira/browse/HBASE-22842
> Project: HBase
> Issue Type: Sub-task
>Reporter: Yi Mei
>Assignee: Yi Mei
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> When create table, table directories are firstly created in tmp directory and
> then move to data directory. So HDFS ACLs are set at the following tmp
> directories used for ACLs inherited:
> {code:java}
> {hbase-rootdir}/.tmp/data
> {hbase-rootdir}/.tmp/data/{namespace}
> {hbase-rootdir}/.tmp/data/{namespace}/{table}
> {code}
> When master restart, it will delete tmp directory and this will break this
> feature.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22842) Tmp directory should not be deleted when master restart used for user scan snapshot feature
[
https://issues.apache.org/jira/browse/HBASE-22842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908662#comment-16908662
]
Yi Mei commented on HBASE-22842:
Thanks [~openinx] for reviewing. Pushed to master and branch-2.
> Tmp directory should not be deleted when master restart used for user scan
> snapshot feature
> ---
>
> Key: HBASE-22842
> URL: https://issues.apache.org/jira/browse/HBASE-22842
> Project: HBase
> Issue Type: Sub-task
>Reporter: Yi Mei
>Priority: Major
>
> When create table, table directories are firstly created in tmp directory and
> then move to data directory. So HDFS ACLs are set at the following tmp
> directories used for ACLs inherited:
> {code:java}
> {hbase-rootdir}/.tmp/data
> {hbase-rootdir}/.tmp/data/{namespace}
> {hbase-rootdir}/.tmp/data/{namespace}/{table}
> {code}
> When master restart, it will delete tmp directory and this will break this
> feature.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Resolved] (HBASE-22842) Tmp directory should not be deleted when master restart used for user scan snapshot feature
[
https://issues.apache.org/jira/browse/HBASE-22842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Mei resolved HBASE-22842.
Resolution: Fixed
> Tmp directory should not be deleted when master restart used for user scan
> snapshot feature
> ---
>
> Key: HBASE-22842
> URL: https://issues.apache.org/jira/browse/HBASE-22842
> Project: HBase
> Issue Type: Sub-task
>Reporter: Yi Mei
>Assignee: Yi Mei
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> When create table, table directories are firstly created in tmp directory and
> then move to data directory. So HDFS ACLs are set at the following tmp
> directories used for ACLs inherited:
> {code:java}
> {hbase-rootdir}/.tmp/data
> {hbase-rootdir}/.tmp/data/{namespace}
> {hbase-rootdir}/.tmp/data/{namespace}/{table}
> {code}
> When master restart, it will delete tmp directory and this will break this
> feature.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908659#comment-16908659 ] Reid Chan commented on HBASE-22728: --- (y) [~vjasani] > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5, 1.3.6 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.4.11 > > Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch, > HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch, > HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch, > HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch, > HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch, > HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch, > HBASE-22728.branch-1.18.patch, HBASE-22728.branch-1.19.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #493: HBASE-22833 MultiRowRangeFilter should provide a method for creating…
Apache-HBase commented on issue #493: HBASE-22833 MultiRowRangeFilter should provide a method for creating… URL: https://github.com/apache/hbase/pull/493#issuecomment-521865744 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 97 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 375 | master passed | | +1 | compile | 85 | master passed | | +1 | checkstyle | 126 | master passed | | +1 | shadedjars | 308 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 68 | master passed | | 0 | spotbugs | 287 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 376 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 340 | the patch passed | | +1 | compile | 89 | the patch passed | | +1 | javac | 89 | the patch passed | | +1 | checkstyle | 36 | hbase-client: The patch generated 0 new + 13 unchanged - 3 fixed = 13 total (was 16) | | +1 | checkstyle | 90 | The patch passed checkstyle in hbase-server | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 308 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1184 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 72 | the patch passed | | +1 | findbugs | 458 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 118 | hbase-client in the patch passed. | | -1 | unit | 15814 | hbase-server in the patch failed. | | +1 | asflicense | 45 | The patch does not generate ASF License warnings. | | | | 20553 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/493 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2b55029992d0 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-493/out/precommit/personality/provided.sh | | git revision | master / edf6f68cb2 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/8/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/8/testReport/ | | Max. process+thread count | 4706 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/8/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations in client snapshot exceptions
Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations in client snapshot exceptions URL: https://github.com/apache/hbase/pull/487#issuecomment-521865573 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 67 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 432 | master passed | | +1 | compile | 33 | master passed | | +1 | checkstyle | 42 | master passed | | +1 | shadedjars | 357 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 31 | master passed | | 0 | spotbugs | 94 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 91 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 402 | the patch passed | | +1 | compile | 31 | the patch passed | | +1 | javac | 31 | the patch passed | | +1 | checkstyle | 40 | hbase-client: The patch generated 0 new + 0 unchanged - 13 fixed = 0 total (was 13) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 372 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1277 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 27 | hbase-client generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) | | +1 | findbugs | 101 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 126 | hbase-client in the patch passed. | | +1 | asflicense | 14 | The patch does not generate ASF License warnings. | | | | 3972 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/487 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8b08c886c723 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-487/out/precommit/personality/provided.sh | | git revision | master / 60971bee66 | | Default Java | 1.8.0_181 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/8/artifact/out/diff-javadoc-javadoc-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/8/testReport/ | | Max. process+thread count | 292 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/8/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-521865530 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 94 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 395 | master passed | | +1 | compile | 27 | master passed | | +1 | checkstyle | 15 | master passed | | +1 | shadedjars | 328 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 26 | master passed | | 0 | spotbugs | 56 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 53 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 365 | the patch passed | | +1 | compile | 27 | the patch passed | | +1 | javac | 27 | the patch passed | | +1 | checkstyle | 14 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 333 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1134 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 20 | the patch passed | | +1 | findbugs | 51 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 613 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 3930 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/92/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 38207c23cd4a 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / 60971bee66 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/92/testReport/ | | Max. process+thread count | 4403 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/92/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…
Reidd commented on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f… URL: https://github.com/apache/hbase/pull/484#issuecomment-521864990 Backport HBASE-19863? First skimmed, looks like they are quite different? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes… URL: https://github.com/apache/hbase/pull/446#issuecomment-521863660 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 272 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 395 | master passed | | +1 | compile | 61 | master passed | | +1 | checkstyle | 93 | master passed | | +1 | shadedjars | 322 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 42 | master passed | | 0 | spotbugs | 252 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 249 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 383 | the patch passed | | +1 | compile | 70 | the patch passed | | +1 | javac | 70 | the patch passed | | +1 | checkstyle | 97 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 313 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1086 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 40 | the patch passed | | +1 | findbugs | 276 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 15503 | hbase-server in the patch failed. | | +1 | asflicense | 29 | The patch does not generate ASF License warnings. | | | | 19672 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/45/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/446 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 0ad708159463 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-446/out/precommit/personality/provided.sh | | git revision | master / edf6f68cb2 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/45/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/45/testReport/ | | Max. process+thread count | 4908 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/45/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot feature
Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#issuecomment-521861982 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 63 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | @author | 0 | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 | mvninstall | 328 | master passed | | 0 | refguide | 319 | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 320 | the patch passed | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | 0 | refguide | 319 | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 | asflicense | 18 | The patch does not generate ASF License warnings. | | | | 1423 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/496 | | Optional Tests | dupname asflicense shellcheck shelldocs refguide | | uname | Linux 5cdf7c802c89 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-496/out/precommit/personality/provided.sh | | git revision | master / 78f5d8ebb2 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/4/artifact/out/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/4/artifact/out/patch-site/book.html | | Max. process+thread count | 78 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22863) Avoid Jackson versions and dependencies with known CVEs
[
https://issues.apache.org/jira/browse/HBASE-22863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908632#comment-16908632
]
Duo Zhang commented on HBASE-22863:
---
IIRC we use it as the json/xml serializer in hbase-rest, not only in tests.
> Avoid Jackson versions and dependencies with known CVEs
> ---
>
> Key: HBASE-22863
> URL: https://issues.apache.org/jira/browse/HBASE-22863
> Project: HBase
> Issue Type: Bug
> Components: dependencies
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
>
> Partly forwardport from branch-1 Jira: HBASE-22728
> Even though master and branch-2 have moved away from Jackson1 some time back,
> HBase is still pulling in vulnerable jackson-mapper-asl:1.9.13 dependency
> from Hadoop:
>
> {code:java}
> [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-mapreduce
> ---
> [INFO] org.apache.hbase:hbase-mapreduce:jar:3.0.0-SNAPSHOT
> [INFO] +- org.apache.hbase:hbase-server:jar:3.0.0-SNAPSHOT:compile
> [INFO] | \- org.apache.hbase:hbase-http:jar:3.0.0-SNAPSHOT:compile
> [INFO] | \- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile
> [INFO] +-
> org.apache.hadoop:hadoop-mapreduce-client-jobclient:test-jar:tests:2.8.5:test
> [INFO] | \- org.apache.avro:avro:jar:1.7.7:compile
> [INFO] | \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:compile
> [INFO] \- org.apache.hadoop:hadoop-mapreduce-client-core:jar:2.8.5:compile
> [INFO]\- org.apache.hadoop:hadoop-yarn-common:jar:2.8.5:compile
> [INFO] +- org.codehaus.jackson:jackson-jaxrs:jar:1.9.13:compile
> [INFO] \- org.codehaus.jackson:jackson-xc:jar:1.9.13:compile{code}
> {code:java}
> [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @
> hbase-shaded-testing-util ---
> [INFO] org.apache.hbase:hbase-shaded-testing-util:jar:3.0.0-SNAPSHOT
> [INFO] \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:compile
> [INFO]+- com.sun.jersey:jersey-json:jar:1.9:compile
> [INFO]| +- org.codehaus.jackson:jackson-jaxrs:jar:1.8.3:compile
> [INFO]| \- org.codehaus.jackson:jackson-xc:jar:1.8.3:compile
> [INFO]+- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile
> [INFO]\- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:compile{code}
> {code:java}
> [INFO] org.apache.hbase:hbase-shaded-testing-util-tester:jar:3.0.0-SNAPSHOT
> [INFO] \- org.apache.hbase:hbase-shaded-testing-util:jar:3.0.0-SNAPSHOT:test
> [INFO]\- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test
> [INFO] +- com.sun.jersey:jersey-json:jar:1.9:test
> [INFO] | +- org.codehaus.jackson:jackson-jaxrs:jar:1.8.3:test
> [INFO] | \- org.codehaus.jackson:jackson-xc:jar:1.8.3:test
> [INFO] +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile
> [INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:compile
> {code}
> jackson-mapper-asl is not being used in HBase code anymore and hence, we
> should include it at test scope if required but definitely exclude it from
> corresponding Hadoop dependencies.
> Moreover, fasterxml.jackson mapper is used only in hbase-rest tests but we
> pull it in with 'compile' scope. May be we can include it as 'test' scope
> only and cleanup Jackson dependencies.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22810) Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
[
https://issues.apache.org/jira/browse/HBASE-22810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908631#comment-16908631
]
Duo Zhang commented on HBASE-22810:
---
It also breaks the test on master.
> Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
>
>
> Key: HBASE-22810
> URL: https://issues.apache.org/jira/browse/HBASE-22810
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> In EventType class, we have the following definition, means taking snapshot
> & restoring snapshot are use the MASTER_TABLE_OPERATIONS Executor now.
> {code}
> /**
>* Messages originating from Client to Master.
>* C_M_SNAPSHOT_TABLE
>* Client asking Master to snapshot an offline table.
>*/
> C_M_SNAPSHOT_TABLE(48, ExecutorType.MASTER_TABLE_OPERATIONS),
> /**
>* Messages originating from Client to Master.
>* C_M_RESTORE_SNAPSHOT
>* Client asking Master to restore a snapshot.
>*/
> C_M_RESTORE_SNAPSHOT (49, ExecutorType.MASTER_TABLE_OPERATIONS),
> {code}
> But when I checked the MASTER_TABLE_OPERATIONS thread pool initialization, I
> see :
> {code}
> private void startServiceThreads() throws IOException{
>// ... some other code initializing
>// We depend on there being only one instance of this executor running
>// at a time. To do concurrency, would need fencing of enable/disable of
>// tables.
>// Any time changing this maxThreads to > 1, pls see the comment at
>// AccessController#postCompletedCreateTableAction
>
> this.executorService.startExecutorService(ExecutorType.MASTER_TABLE_OPERATIONS,
> 1);
>startProcedureExecutor();
> {code}
> That's to say, for CPs enable or disable table sequencely, we will create
> a ThreadPoolExecutor with threadPoolSize=1. Then we actually cann't
> accomplish the snapshoting concurrence even if they are total difference
> tables, says if there are two table snapshoting request, and the Table A cost
> 5min for snapshoting, then the Table B need to wait 5min and once Table A
> finish its snapshot , then Table B will start the snapshot.
> While we've setting the snapshot timeout, so it will be easy to timeout for
> table B snapshoting . Actually, we can create a separate thead pool for
> snapshot operations only.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot feature
Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#issuecomment-521858947 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 162 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | @author | 0 | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 | mvninstall | 368 | master passed | | 0 | refguide | 353 | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 334 | the patch passed | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | 0 | refguide | 313 | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 | asflicense | 20 | The patch does not generate ASF License warnings. | | | | 1608 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/496 | | Optional Tests | dupname asflicense shellcheck shelldocs refguide | | uname | Linux 6474f994645f 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-496/out/precommit/personality/provided.sh | | git revision | master / 60971bee66 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/3/artifact/out/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/3/artifact/out/patch-site/book.html | | Max. process+thread count | 96 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22810) Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
[
https://issues.apache.org/jira/browse/HBASE-22810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908626#comment-16908626
]
Zheng Hu commented on HBASE-22810:
--
OK, Thanks [~apurtell], Let me take a look, will provide the addendum soon if
necessary.
> Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
>
>
> Key: HBASE-22810
> URL: https://issues.apache.org/jira/browse/HBASE-22810
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> In EventType class, we have the following definition, means taking snapshot
> & restoring snapshot are use the MASTER_TABLE_OPERATIONS Executor now.
> {code}
> /**
>* Messages originating from Client to Master.
>* C_M_SNAPSHOT_TABLE
>* Client asking Master to snapshot an offline table.
>*/
> C_M_SNAPSHOT_TABLE(48, ExecutorType.MASTER_TABLE_OPERATIONS),
> /**
>* Messages originating from Client to Master.
>* C_M_RESTORE_SNAPSHOT
>* Client asking Master to restore a snapshot.
>*/
> C_M_RESTORE_SNAPSHOT (49, ExecutorType.MASTER_TABLE_OPERATIONS),
> {code}
> But when I checked the MASTER_TABLE_OPERATIONS thread pool initialization, I
> see :
> {code}
> private void startServiceThreads() throws IOException{
>// ... some other code initializing
>// We depend on there being only one instance of this executor running
>// at a time. To do concurrency, would need fencing of enable/disable of
>// tables.
>// Any time changing this maxThreads to > 1, pls see the comment at
>// AccessController#postCompletedCreateTableAction
>
> this.executorService.startExecutorService(ExecutorType.MASTER_TABLE_OPERATIONS,
> 1);
>startProcedureExecutor();
> {code}
> That's to say, for CPs enable or disable table sequencely, we will create
> a ThreadPoolExecutor with threadPoolSize=1. Then we actually cann't
> accomplish the snapshoting concurrence even if they are total difference
> tables, says if there are two table snapshoting request, and the Table A cost
> 5min for snapshoting, then the Table B need to wait 5min and once Table A
> finish its snapshot , then Table B will start the snapshot.
> While we've setting the snapshot timeout, so it will be easy to timeout for
> table B snapshoting . Actually, we can create a separate thead pool for
> snapshot operations only.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908624#comment-16908624 ] Andrew Purtell commented on HBASE-22728: Please add a release note. > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5, 1.3.6 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.4.11 > > Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch, > HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch, > HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch, > HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch, > HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch, > HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch, > HBASE-22728.branch-1.18.patch, HBASE-22728.branch-1.19.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-22728: --- Affects Version/s: 1.3.6 > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5, 1.3.6 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.4.11 > > Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch, > HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch, > HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch, > HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch, > HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch, > HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch, > HBASE-22728.branch-1.18.patch, HBASE-22728.branch-1.19.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-22728: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Thanks for the heavy lift [~vjasani]. Committed to branch-1. Pick to branch-1.4 had one easy reject, committed there too. Pick to branch-1.3 had a lot of conflicts, not going to attempt a commit there. This could be a problem if we want to make another 1.3 release. I set affects version to indicate that. > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.4.11 > > Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch, > HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch, > HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch, > HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch, > HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch, > HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch, > HBASE-22728.branch-1.18.patch, HBASE-22728.branch-1.19.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-22728: --- Fix Version/s: (was: 1.3.6) > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.4.11 > > Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch, > HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch, > HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch, > HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch, > HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch, > HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch, > HBASE-22728.branch-1.18.patch, HBASE-22728.branch-1.19.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #497: HBASE-22858 Add HBCK Report to master's header.jsp
Apache-HBase commented on issue #497: HBASE-22858 Add HBCK Report to master's header.jsp URL: https://github.com/apache/hbase/pull/497#issuecomment-521857530 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 71 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 389 | master passed | | +1 | javadoc | 37 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 351 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | javadoc | 41 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 16591 | hbase-server in the patch failed. | | +1 | asflicense | 30 | The patch does not generate ASF License warnings. | | | | 17570 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-497/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/497 | | Optional Tests | dupname asflicense javac javadoc unit | | uname | Linux bb0b05e224ad 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-497/out/precommit/personality/provided.sh | | git revision | master / edf6f68cb2 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-497/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-497/2/testReport/ | | Max. process+thread count | 4830 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-497/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-14614) Procedure v2: Core Assignment Manager
[ https://issues.apache.org/jira/browse/HBASE-14614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908619#comment-16908619 ] Duo Zhang commented on HBASE-14614: --- I deleted the HBASE-14614 branch from our gitbox since this one has already been commit to master. > Procedure v2: Core Assignment Manager > - > > Key: HBASE-14614 > URL: https://issues.apache.org/jira/browse/HBASE-14614 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.0.0 >Reporter: Stephen Yuan Jiang >Assignee: Matteo Bertozzi >Priority: Major > Fix For: 2.0.0 > > Attachments: HBASE-14614.master.003.patch, > HBASE-14614.master.004.patch, HBASE-14614.master.005.patch, > HBASE-14614.master.006.patch, HBASE-14614.master.007.patch, > HBASE-14614.master.008.patch, HBASE-14614.master.009.patch, > HBASE-14614.master.010.patch, HBASE-14614.master.014.patch, > HBASE-14614.master.015.patch, HBASE-14614.master.017.patch, > HBASE-14614.master.018.patch, HBASE-14614.master.019.patch, > HBASE-14614.master.020.patch, HBASE-14614.master.022.patch, > HBASE-14614.master.023.patch, HBASE-14614.master.024.patch, > HBASE-14614.master.025.patch, HBASE-14614.master.026.patch, > HBASE-14614.master.027.patch, HBASE-14614.master.028.patch, > HBASE-14614.master.029.patch, HBASE-14614.master.030.patch, > HBASE-14614.master.033.patch, HBASE-14614.master.038.patch, > HBASE-14614.master.039.patch, HBASE-14614.master.040.patch, > HBASE-14614.master.041.patch, HBASE-14614.master.042.patch, > HBASE-14614.master.043.patch, HBASE-14614.master.044.patch, > HBASE-14614.master.045.patch, HBASE-14614.master.045.patch, > HBASE-14614.master.046.patch, HBASE-14614.master.047.patch, > HBASE-14614.master.048.patch, HBASE-14614.master.049.patch, > HBASE-14614.master.050.patch, HBASE-14614.master.051.patch > > > New AssignmentManager implemented using proc-v2. > - AssignProcedure handle assignment operation > - UnassignProcedure handle unassign operation > - MoveRegionProcedure handle move/balance operation > Concurrent Assign operations are batched together and sent to the balancer > Concurrent Assign and Unassign operation ready to be sent to the RS are > batched together > This patch is an intermediate state where we add the new AM as > AssignmentManager2() to the master, to be reached by tests. but the new AM > will not be integrated with the rest of the system. Only new am unit-tests > will exercise the new assigment manager. The integration with the master code > is part of HBASE-14616 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] sunhelly commented on a change in pull request #482: HBASE-22820 Do not need to persist default rs group now
sunhelly commented on a change in pull request #482: HBASE-22820 Do not need to
persist default rs group now
URL: https://github.com/apache/hbase/pull/482#discussion_r314560749
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##
@@ -456,7 +458,12 @@ private synchronized void flushConfig(Map newGroupMap) thro
// Make changes visible after having been persisted to the source of truth
resetRSGroupMap(newGroupMap);
+saveRSGroupMapToZK(newGroupMap);
+updateCacheOfRSGroups(newGroupMap.keySet());
+ }
+
+ public void saveRSGroupMapToZK(Map newGroupMap) throws
IOException {
Review comment:
Changed to private.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Comment Edited] (HBASE-22810) Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
[
https://issues.apache.org/jira/browse/HBASE-22810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908616#comment-16908616
]
Andrew Purtell edited comment on HBASE-22810 at 8/16/19 1:59 AM:
-
Bisect fingers this as breaking TestFlushSnapshotFromClient on branch-1
{noformat}
eb6b617d92998b887c8d811769c6a9d80b653432 is the first bad commit
commit eb6b617d92998b887c8d811769c6a9d80b653432
Author: openinx
Date: Thu Aug 15 10:57:42 2019 +0800
HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring
snapshot (#486)
.../apache/hadoop/hbase/executor/EventType.java| 4 +--
.../apache/hadoop/hbase/executor/ExecutorType.java | 1 +
.../java/org/apache/hadoop/hbase/HConstants.java | 27
.../org/apache/hadoop/hbase/master/HMaster.java| 29 +
.../hadoop/hbase/executor/TestExecutorService.java | 36 ++
5 files changed, 83 insertions(+), 14 deletions(-)
{noformat}
Perhaps we need an addendum?
was (Author: apurtell):
Bisect fingers this as breaking TestFlushSnapshotFromClient on branch-1
{noformat}
eb6b617d92998b887c8d811769c6a9d80b653432 is the first bad commit
commit eb6b617d92998b887c8d811769c6a9d80b653432
Author: openinx
Date: Thu Aug 15 10:57:42 2019 +0800
HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring
snapshot (#486)
.../apache/hadoop/hbase/executor/EventType.java| 4 +--
.../apache/hadoop/hbase/executor/ExecutorType.java | 1 +
.../java/org/apache/hadoop/hbase/HConstants.java | 27
.../org/apache/hadoop/hbase/master/HMaster.java| 29 +
.../hadoop/hbase/executor/TestExecutorService.java | 36 ++
5 files changed, 83 insertions(+), 14 deletions(-)
{noformat}
> Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
>
>
> Key: HBASE-22810
> URL: https://issues.apache.org/jira/browse/HBASE-22810
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> In EventType class, we have the following definition, means taking snapshot
> & restoring snapshot are use the MASTER_TABLE_OPERATIONS Executor now.
> {code}
> /**
>* Messages originating from Client to Master.
>* C_M_SNAPSHOT_TABLE
>* Client asking Master to snapshot an offline table.
>*/
> C_M_SNAPSHOT_TABLE(48, ExecutorType.MASTER_TABLE_OPERATIONS),
> /**
>* Messages originating from Client to Master.
>* C_M_RESTORE_SNAPSHOT
>* Client asking Master to restore a snapshot.
>*/
> C_M_RESTORE_SNAPSHOT (49, ExecutorType.MASTER_TABLE_OPERATIONS),
> {code}
> But when I checked the MASTER_TABLE_OPERATIONS thread pool initialization, I
> see :
> {code}
> private void startServiceThreads() throws IOException{
>// ... some other code initializing
>// We depend on there being only one instance of this executor running
>// at a time. To do concurrency, would need fencing of enable/disable of
>// tables.
>// Any time changing this maxThreads to > 1, pls see the comment at
>// AccessController#postCompletedCreateTableAction
>
> this.executorService.startExecutorService(ExecutorType.MASTER_TABLE_OPERATIONS,
> 1);
>startProcedureExecutor();
> {code}
> That's to say, for CPs enable or disable table sequencely, we will create
> a ThreadPoolExecutor with threadPoolSize=1. Then we actually cann't
> accomplish the snapshoting concurrence even if they are total difference
> tables, says if there are two table snapshoting request, and the Table A cost
> 5min for snapshoting, then the Table B need to wait 5min and once Table A
> finish its snapshot , then Table B will start the snapshot.
> While we've setting the snapshot timeout, so it will be easy to timeout for
> table B snapshoting . Actually, we can create a separate thead pool for
> snapshot operations only.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Reopened] (HBASE-22810) Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
[
https://issues.apache.org/jira/browse/HBASE-22810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell reopened HBASE-22810:
Bisect fingers this as breaking TestFlushSnapshotFromClient on branch-1
{noformat}
eb6b617d92998b887c8d811769c6a9d80b653432 is the first bad commit
commit eb6b617d92998b887c8d811769c6a9d80b653432
Author: openinx
Date: Thu Aug 15 10:57:42 2019 +0800
HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring
snapshot (#486)
.../apache/hadoop/hbase/executor/EventType.java| 4 +--
.../apache/hadoop/hbase/executor/ExecutorType.java | 1 +
.../java/org/apache/hadoop/hbase/HConstants.java | 27
.../org/apache/hadoop/hbase/master/HMaster.java| 29 +
.../hadoop/hbase/executor/TestExecutorService.java | 36 ++
5 files changed, 83 insertions(+), 14 deletions(-)
{noformat}
> Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
>
>
> Key: HBASE-22810
> URL: https://issues.apache.org/jira/browse/HBASE-22810
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> In EventType class, we have the following definition, means taking snapshot
> & restoring snapshot are use the MASTER_TABLE_OPERATIONS Executor now.
> {code}
> /**
>* Messages originating from Client to Master.
>* C_M_SNAPSHOT_TABLE
>* Client asking Master to snapshot an offline table.
>*/
> C_M_SNAPSHOT_TABLE(48, ExecutorType.MASTER_TABLE_OPERATIONS),
> /**
>* Messages originating from Client to Master.
>* C_M_RESTORE_SNAPSHOT
>* Client asking Master to restore a snapshot.
>*/
> C_M_RESTORE_SNAPSHOT (49, ExecutorType.MASTER_TABLE_OPERATIONS),
> {code}
> But when I checked the MASTER_TABLE_OPERATIONS thread pool initialization, I
> see :
> {code}
> private void startServiceThreads() throws IOException{
>// ... some other code initializing
>// We depend on there being only one instance of this executor running
>// at a time. To do concurrency, would need fencing of enable/disable of
>// tables.
>// Any time changing this maxThreads to > 1, pls see the comment at
>// AccessController#postCompletedCreateTableAction
>
> this.executorService.startExecutorService(ExecutorType.MASTER_TABLE_OPERATIONS,
> 1);
>startProcedureExecutor();
> {code}
> That's to say, for CPs enable or disable table sequencely, we will create
> a ThreadPoolExecutor with threadPoolSize=1. Then we actually cann't
> accomplish the snapshoting concurrence even if they are total difference
> tables, says if there are two table snapshoting request, and the Table A cost
> 5min for snapshoting, then the Table B need to wait 5min and once Table A
> finish its snapshot , then Table B will start the snapshot.
> While we've setting the snapshot timeout, so it will be easy to timeout for
> table B snapshoting . Actually, we can create a separate thead pool for
> snapshot operations only.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908617#comment-16908617 ] Andrew Purtell commented on HBASE-22728: TestFlushSnapshotFromClient failure is due to HBASE-22810. > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch, > HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch, > HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch, > HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch, > HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch, > HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch, > HBASE-22728.branch-1.18.patch, HBASE-22728.branch-1.19.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] openinx merged pull request #493: HBASE-22833 MultiRowRangeFilter should provide a method for creating…
openinx merged pull request #493: HBASE-22833 MultiRowRangeFilter should provide a method for creating… URL: https://github.com/apache/hbase/pull/493 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-7912) HBase Backup/Restore Based on HBase Snapshot
[ https://issues.apache.org/jira/browse/HBASE-7912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908613#comment-16908613 ] Duo Zhang commented on HBASE-7912: -- I deleted the branch HBASE-7912 from our gitbox as I think this one has already been merged back to master. > HBase Backup/Restore Based on HBase Snapshot > > > Key: HBASE-7912 > URL: https://issues.apache.org/jira/browse/HBASE-7912 > Project: HBase > Issue Type: Sub-task >Reporter: Richard Ding >Assignee: Vladimir Rodionov >Priority: Major > Labels: backup > Attachments: Backup-and-Restore-Apache_19Sep2016.pdf, > Backup-and-Restore-Apache_9Sep2016.pdf, HBaseBackupAndRestore - v0.8.pdf, > HBaseBackupAndRestore -0.91.pdf, HBaseBackupAndRestore-v0.9.pdf, > HBaseBackupAndRestore.pdf, HBaseBackupRestore-Jira-7912-DesignDoc-v1.pdf, > HBaseBackupRestore-Jira-7912-DesignDoc-v2.pdf, > HBaseBackupRestore-Jira-7912-v4.pdf, HBaseBackupRestore-Jira-7912-v5 .pdf, > HBaseBackupRestore-Jira-7912-v6.pdf, HBase_BackupRestore-Jira-7912-CLI-v1.pdf > > > MFinally, we completed the implementation of our backup/restore solution, and > would like to share with community through this jira. > We are leveraging existing hbase snapshot feature, and provide a general > solution to common users. Our full backup is using snapshot to capture > metadata locally and using exportsnapshot to move data to another cluster; > the incremental backup is using offline-WALplayer to backup HLogs; we also > leverage global distribution rolllog and flush to improve performance; other > added-on values such as convert, merge, progress report, and CLI commands. So > that a common user can backup hbase data without in-depth knowledge of hbase. > Our solution also contains some usability features for enterprise users. > The detail design document and CLI command will be attached in this jira. We > plan to use 10~12 subtasks to share each of the following features, and > document the detail implement in the subtasks: > * *Full Backup* : provide local and remote back/restore for a list of tables > * *offline-WALPlayer* to convert HLog to HFiles offline (for incremental > backup) > * *distributed* Logroll and distributed flush > * Backup *Manifest* and history > * *Incremental* backup: to build on top of full backup as daily/weekly backup > * *Convert* incremental backup WAL files into hfiles > * *Merge* several backup images into one(like merge weekly into monthly) > * *add and remove* table to and from Backup image > * *Cancel* a backup process > * backup progress *status* > * full backup based on *existing snapshot* > *-* > *Below is the original description, to keep here as the history for the > design and discussion back in 2013* > There have been attempts in the past to come up with a viable HBase > backup/restore solution (e.g., HBASE-4618). Recently, there are many > advancements and new features in HBase, for example, FileLink, Snapshot, and > Distributed Barrier Procedure. This is a proposal for a backup/restore > solution that utilizes these new features to achieve better performance and > consistency. > > A common practice of backup and restore in database is to first take full > baseline backup, and then periodically take incremental backup that capture > the changes since the full baseline backup. HBase cluster can store massive > amount data. Combination of full backups with incremental backups has > tremendous benefit for HBase as well. The following is a typical scenario > for full and incremental backup. > # The user takes a full backup of a table or a set of tables in HBase. > # The user schedules periodical incremental backups to capture the changes > from the full backup, or from last incremental backup. > # The user needs to restore table data to a past point of time. > # The full backup is restored to the table(s) or to different table name(s). > Then the incremental backups that are up to the desired point in time are > applied on top of the full backup. > We would support the following key features and capabilities. > * Full backup uses HBase snapshot to capture HFiles. > * Use HBase WALs to capture incremental changes, but we use bulk load of > HFiles for fast incremental restore. > * Support single table or a set of tables, and column family level backup and > restore. > * Restore to different table names. > * Support adding additional tables or CF to backup set without interruption > of incremental backup schedule. > * Support rollup/combining of incremental backups into longer period and > bigger incremental backups. > * Unified command line interface for all the above. > The solution will
[GitHub] [hbase] openinx commented on issue #493: HBASE-22833 MultiRowRangeFilter should provide a method for creating…
openinx commented on issue #493: HBASE-22833 MultiRowRangeFilter should provide a method for creating… URL: https://github.com/apache/hbase/pull/493#issuecomment-521855899 The timeout snapshot related UT are irrelevant here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908610#comment-16908610 ] Andrew Purtell commented on HBASE-22728: Chasing down TestFlushSnapshotFromClient failure just to make sure this isn't related. > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch, > HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch, > HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch, > HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch, > HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch, > HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch, > HBASE-22728.branch-1.18.patch, HBASE-22728.branch-1.19.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22728) Upgrade jackson dependencies in branch-1
[
https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908609#comment-16908609
]
Andrew Purtell edited comment on HBASE-22728 at 8/16/19 1:46 AM:
-
Spot checks of {{mvn dependency:tree}} for hbase-annotations, hbase-common,
hbase-protocol, and hbase-client look good.
REST unit tests look good.
REST gateway test launched in tree looks good.
REST gateway test launched from binary tarball looks good.
Visual inspection of binary assembly looks good (except unrelated HBASE-22866).
Committing.
was (Author: apurtell):
Spot checks of {{mvn dependency:tree}} for hbase-annotations, hbase-common,
hbase-protocol, and hbase-client look good.
Unit tests look good.
REST gateway test launched in tree looks good.
REST gateway test launched from binary tarball looks good.
Visual inspection of binary assembly looks good (except unrelated HBASE-22866).
Committing.
> Upgrade jackson dependencies in branch-1
>
>
> Key: HBASE-22728
> URL: https://issues.apache.org/jira/browse/HBASE-22728
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 1.4.10, 1.3.5
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch,
> HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch,
> HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch,
> HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch,
> HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch,
> HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch,
> HBASE-22728.branch-1.18.patch, HBASE-22728.branch-1.19.patch
>
>
> Avoid Jackson versions and dependencies with known CVEs
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.
[
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908611#comment-16908611
]
Hadoop QA commented on HBASE-22601:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
53s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
59s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
31s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
10s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
58s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
55s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
34s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 24s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
13s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}254m 18s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
35s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}316m 2s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.replication.TestReplicationProcedureRetry |
| | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient |
| | hadoop.hbase.master.TestSplitWALManager |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/500 |
| JIRA Issue | HBASE-22601 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 0b5e0d9c0fe3 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[GitHub] [hbase] Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/500#issuecomment-521854763 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 78 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2 Compile Tests _ | | +1 | mvninstall | 353 | branch-2 passed | | +1 | compile | 59 | branch-2 passed | | +1 | checkstyle | 91 | branch-2 passed | | +1 | shadedjars | 310 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 47 | branch-2 passed | | 0 | spotbugs | 238 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 235 | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 327 | the patch passed | | +1 | compile | 56 | the patch passed | | +1 | javac | 56 | the patch passed | | +1 | checkstyle | 86 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 274 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1044 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 37 | the patch passed | | +1 | findbugs | 253 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 15258 | hbase-server in the patch failed. | | +1 | asflicense | 35 | The patch does not generate ASF License warnings. | | | | 18962 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestReplicationProcedureRetry | | | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | | hadoop.hbase.master.TestSplitWALManager | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/500 | | JIRA Issue | HBASE-22601 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 0b5e0d9c0fe3 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-500/out/precommit/personality/provided.sh | | git revision | branch-2 / 76a68bd27c | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/2/testReport/ | | Max. process+thread count | 4242 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[
https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908609#comment-16908609
]
Andrew Purtell commented on HBASE-22728:
Spot checks of {{mvn dependency:tree}} for hbase-annotations, hbase-common,
hbase-protocol, and hbase-client look good.
Unit tests look good.
REST gateway test launched in tree looks good.
REST gateway test launched from binary tarball looks good.
Visual inspection of binary assembly looks good (except unrelated HBASE-22866).
Committing.
> Upgrade jackson dependencies in branch-1
>
>
> Key: HBASE-22728
> URL: https://issues.apache.org/jira/browse/HBASE-22728
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 1.4.10, 1.3.5
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch,
> HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch,
> HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch,
> HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch,
> HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch,
> HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch,
> HBASE-22728.branch-1.18.patch, HBASE-22728.branch-1.19.patch
>
>
> Avoid Jackson versions and dependencies with known CVEs
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (HBASE-22866) Multiple slf4j-log4j provider versions included in binary package (branch-1)
Andrew Purtell created HBASE-22866:
--
Summary: Multiple slf4j-log4j provider versions included in binary
package (branch-1)
Key: HBASE-22866
URL: https://issues.apache.org/jira/browse/HBASE-22866
Project: HBase
Issue Type: Bug
Affects Versions: 1.5.0
Reporter: Andrew Purtell
Fix For: 1.5.0
Examining binary assembly results there are multiple versions of slf4j-log4j in
lib/
{noformat}
slf4j-api-1.7.7.jar
slf4j-log4j12-1.6.1.jar
slf4j-log4j12-1.7.10.jar
slf4j-log4j12-1.7.7.jar
{noformat}
We aren't managing slf4j-log4j12 dependency versions correctly, somehow.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] mymeiyi merged pull request #485: HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature
mymeiyi merged pull request #485: HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature URL: https://github.com/apache/hbase/pull/485 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22142) Space quota: If table inside namespace having space quota is dropped, data size usage is still considered for the drop table.
[
https://issues.apache.org/jira/browse/HBASE-22142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908604#comment-16908604
]
HBase QA commented on HBASE-22142:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
39s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-2.1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
59s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
8s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
53s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
11s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} branch-2.1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
6s{color} | {color:red} hbase-server: The patch generated 4 new + 4 unchanged -
0 fixed = 8 total (was 4) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
49s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
20m 23s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.7 2.8.5 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}139m 14s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}192m 51s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.snapshot.TestFlushSnapshotFromClient |
| | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/780/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22142 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12965440/HBASE-22142.branch-2.1.v001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 8c11033e13cd 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24
10:58:50 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.1 / 0481b04ca3 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/780/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| unit |
[jira] [Resolved] (HBASE-22856) HBASE-Find-Flaky-Tests fails with pip error
[
https://issues.apache.org/jira/browse/HBASE-22856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-22856.
---
Resolution: Fixed
Hadoop Flags: Reviewed
Release Note: Update the base docker image to ubuntu 18.04 for the find
flaky tests jenkins job.
Pushed to all active branches.
Thanks [~psomogyi] for reviewing.
> HBASE-Find-Flaky-Tests fails with pip error
> ---
>
> Key: HBASE-22856
> URL: https://issues.apache.org/jira/browse/HBASE-22856
> Project: HBase
> Issue Type: Bug
> Components: build, test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2, 2.0.7
>
> Attachments: HBASE-22856.patch
>
>
> {noformat}
> 09:59:16 Downloading/unpacking future (from -r
> /hbase/dev-support/python-requirements.txt (line 19))
> 09:59:16Running setup.py (path:/tmp/pip_build_root/future/setup.py)
> egg_info for package future
> 09:59:16 /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown
> distribution option: 'python_requires'
> 09:59:16warnings.warn(msg)
> 09:59:16
> 09:59:16 warning: no files found matching '*.au' under directory 'tests'
> 09:59:16 warning: no files found matching '*.gif' under directory 'tests'
> 09:59:16 warning: no files found matching '*.txt' under directory 'tests'
> 09:59:16 Downloading/unpacking gitpython (from -r
> /hbase/dev-support/python-requirements.txt (line 20))
> 09:59:16Running setup.py (path:/tmp/pip_build_root/gitpython/setup.py)
> egg_info for package gitpython
> 09:59:16 /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown
> distribution option: 'python_requires'
> 09:59:16warnings.warn(msg)
> 09:59:16 error in GitPython setup command: 'install_requires' must be a
> string or list of strings containing valid project/version requirement
> specifiers
> 09:59:16 Complete output from command python setup.py egg_info:
> 09:59:16 /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown
> distribution option: 'python_requires'
> 09:59:16
> 09:59:16warnings.warn(msg)
> 09:59:16
> 09:59:16 error in GitPython setup command: 'install_requires' must be a
> string or list of strings containing valid project/version requirement
> specifiers
> 09:59:16
> 09:59:16
> 09:59:16 Cleaning up...
> 09:59:16 Command python setup.py egg_info failed with error code 1 in
> /tmp/pip_build_root/gitpython
> 09:59:16 Storing debug log for failure in /root/.pip/pip.log
> 09:59:17 The command '/bin/sh -c apt-get -y update && apt-get -y install
> curl python-pip && pip install -r
> /hbase/dev-support/python-requirements.txt' returned a non-zero code: 1
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22856) HBASE-Find-Flaky-Tests fails with pip error
[
https://issues.apache.org/jira/browse/HBASE-22856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-22856:
--
Fix Version/s: 2.0.7
2.2.2
2.1.7
1.4.11
1.3.6
2.3.0
1.5.0
3.0.0
> HBASE-Find-Flaky-Tests fails with pip error
> ---
>
> Key: HBASE-22856
> URL: https://issues.apache.org/jira/browse/HBASE-22856
> Project: HBase
> Issue Type: Bug
> Components: build, test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2, 2.0.7
>
> Attachments: HBASE-22856.patch
>
>
> {noformat}
> 09:59:16 Downloading/unpacking future (from -r
> /hbase/dev-support/python-requirements.txt (line 19))
> 09:59:16Running setup.py (path:/tmp/pip_build_root/future/setup.py)
> egg_info for package future
> 09:59:16 /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown
> distribution option: 'python_requires'
> 09:59:16warnings.warn(msg)
> 09:59:16
> 09:59:16 warning: no files found matching '*.au' under directory 'tests'
> 09:59:16 warning: no files found matching '*.gif' under directory 'tests'
> 09:59:16 warning: no files found matching '*.txt' under directory 'tests'
> 09:59:16 Downloading/unpacking gitpython (from -r
> /hbase/dev-support/python-requirements.txt (line 20))
> 09:59:16Running setup.py (path:/tmp/pip_build_root/gitpython/setup.py)
> egg_info for package gitpython
> 09:59:16 /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown
> distribution option: 'python_requires'
> 09:59:16warnings.warn(msg)
> 09:59:16 error in GitPython setup command: 'install_requires' must be a
> string or list of strings containing valid project/version requirement
> specifiers
> 09:59:16 Complete output from command python setup.py egg_info:
> 09:59:16 /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown
> distribution option: 'python_requires'
> 09:59:16
> 09:59:16warnings.warn(msg)
> 09:59:16
> 09:59:16 error in GitPython setup command: 'install_requires' must be a
> string or list of strings containing valid project/version requirement
> specifiers
> 09:59:16
> 09:59:16
> 09:59:16 Cleaning up...
> 09:59:16 Command python setup.py egg_info failed with error code 1 in
> /tmp/pip_build_root/gitpython
> 09:59:16 Storing debug log for failure in /root/.pip/pip.log
> 09:59:17 The command '/bin/sh -c apt-get -y update && apt-get -y install
> curl python-pip && pip install -r
> /hbase/dev-support/python-requirements.txt' returned a non-zero code: 1
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.
[
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908599#comment-16908599
]
Hadoop QA commented on HBASE-22601:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
44s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
10s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
17s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
2s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
0s{color} | {color:blue} Used deprecated FindBugs config; considering switching
to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
57s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
7s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 30s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
33s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}142m 36s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
28s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}195m 38s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.replication.TestReplicationProcedureRetry |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/500 |
| JIRA Issue | HBASE-22601 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 9f6caece0c2e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-500/out/precommit/personality/provided.sh
|
| git revision
[GitHub] [hbase] Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/500#issuecomment-521850749 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 44 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2 Compile Tests _ | | +1 | mvninstall | 310 | branch-2 passed | | +1 | compile | 54 | branch-2 passed | | +1 | checkstyle | 77 | branch-2 passed | | +1 | shadedjars | 242 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 33 | branch-2 passed | | 0 | spotbugs | 180 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 177 | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 286 | the patch passed | | +1 | compile | 51 | the patch passed | | +1 | javac | 51 | the patch passed | | +1 | checkstyle | 72 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 247 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 930 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 213 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 8556 | hbase-server in the patch failed. | | +1 | asflicense | 28 | The patch does not generate ASF License warnings. | | | | 11738 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestReplicationProcedureRetry | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/500 | | JIRA Issue | HBASE-22601 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9f6caece0c2e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-500/out/precommit/personality/provided.sh | | git revision | branch-2 / 4b60eaca17 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/3/testReport/ | | Max. process+thread count | 4587 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Attachment: HBASE-22835.v4.branch-1.3.patch
Status: Patch Available (was: Open)
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch,
> HBASE-22835.v2.branch-1.3.patch, HBASE-22835.v3.branch-1.3.patch,
> HBASE-22835.v4.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Status: Open (was: Patch Available)
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch,
> HBASE-22835.v2.branch-1.3.patch, HBASE-22835.v3.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Attachment: HBASE-22835.v4.branch-1.3.txt
Status: Patch Available (was: Open)
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch,
> HBASE-22835.v2.branch-1.3.patch, HBASE-22835.v3.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Attachment: (was: HBASE-22835.v4.branch-1.3.txt)
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch,
> HBASE-22835.v2.branch-1.3.patch, HBASE-22835.v3.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
[
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeongmin Kim updated HBASE-22835:
-
Status: Open (was: Patch Available)
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError (backport of HBASE-19863)
>
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch,
> HBASE-22835.v2.branch-1.3.patch, HBASE-22835.v3.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from
> the same problem.
>
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
> actual hfs offset can be behind, in this case heap.next() is not enough. it
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551)
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)
> {code}
> I created a backport patch of HBASE-19863.
> Exact same testcase included. And changed StoreScanner due to the difference
> of codes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment
Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439#issuecomment-521845496 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 362 | master passed | | +1 | compile | 62 | master passed | | +1 | checkstyle | 82 | master passed | | +1 | shadedjars | 292 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 38 | master passed | | 0 | spotbugs | 273 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 270 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 335 | the patch passed | | +1 | compile | 61 | the patch passed | | +1 | javac | 61 | the patch passed | | +1 | checkstyle | 82 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 292 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1032 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 41 | the patch passed | | +1 | findbugs | 281 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 8744 | hbase-server in the patch failed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 12438 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/53/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/439 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 922d9cb3d562 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-439/out/precommit/personality/provided.sh | | git revision | master / edf6f68cb2 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/53/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/53/testReport/ | | Max. process+thread count | 5021 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/53/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation
Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation URL: https://github.com/apache/hbase/pull/478#issuecomment-521845054 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 38 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 62 | Maven dependency ordering for branch | | +1 | mvninstall | 302 | master passed | | +1 | compile | 74 | master passed | | +1 | checkstyle | 102 | master passed | | +1 | shadedjars | 270 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 53 | master passed | | 0 | spotbugs | 271 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 343 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 330 | the patch passed | | +1 | compile | 84 | the patch passed | | +1 | javac | 84 | the patch passed | | +1 | checkstyle | 107 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 288 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1009 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 57 | the patch passed | | +1 | findbugs | 366 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 106 | hbase-client in the patch passed. | | +1 | unit | 8837 | hbase-server in the patch passed. | | +1 | asflicense | 50 | The patch does not generate ASF License warnings. | | | | 12889 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/13/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/478 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3b6af97ad255 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-478/out/precommit/personality/provided.sh | | git revision | master / edf6f68cb2 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/13/testReport/ | | Max. process+thread count | 4699 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/13/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#issuecomment-521844641 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 41 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 50 | Maven dependency ordering for branch | | +1 | mvninstall | 321 | master passed | | +1 | compile | 74 | master passed | | +1 | checkstyle | 95 | master passed | | +1 | shadedjars | 272 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 51 | master passed | | 0 | spotbugs | 243 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 289 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 290 | the patch passed | | +1 | compile | 74 | the patch passed | | +1 | javac | 74 | the patch passed | | -1 | checkstyle | 23 | hbase-common: The patch generated 2 new + 48 unchanged - 2 fixed = 50 total (was 50) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 264 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 888 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 52 | the patch passed | | +1 | findbugs | 307 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 178 | hbase-common in the patch passed. | | -1 | unit | 8964 | hbase-server in the patch failed. | | +1 | asflicense | 44 | The patch does not generate ASF License warnings. | | | | 12754 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/14/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/479 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux fe4f7ca9e17f 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-479/out/precommit/personality/provided.sh | | git revision | master / edf6f68cb2 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/14/artifact/out/diff-checkstyle-hbase-common.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/14/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/14/testReport/ | | Max. process+thread count | 4615 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/14/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #485: HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature
Apache-HBase commented on issue #485: HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature URL: https://github.com/apache/hbase/pull/485#issuecomment-521844473 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 357 | master passed | | +1 | compile | 55 | master passed | | +1 | checkstyle | 73 | master passed | | +1 | shadedjars | 264 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | master passed | | 0 | spotbugs | 266 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 264 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 279 | the patch passed | | +1 | compile | 54 | the patch passed | | +1 | javac | 54 | the patch passed | | +1 | checkstyle | 70 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 264 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 912 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 271 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 9343 | hbase-server in the patch failed. | | +1 | asflicense | 28 | The patch does not generate ASF License warnings. | | | | 12702 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/11/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/485 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 851b8d201dc9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-485/out/precommit/personality/provided.sh | | git revision | master / edf6f68cb2 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/11/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/11/testReport/ | | Max. process+thread count | 4636 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/11/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.
[
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908581#comment-16908581
]
Hadoop QA commented on HBASE-22601:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
40s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
1s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
28s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
23s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
21s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
22s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 3s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
40s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}152m
18s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
25s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}208m 24s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/499 |
| JIRA Issue | HBASE-22601 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 3a4d9b2a0b41 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-499/out/precommit/personality/provided.sh
|
| git revision | master / edf6f68cb2 |
| Default Java | 1.8.0_181 |
| Test Results |
[GitHub] [hbase] Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/499#issuecomment-521843946 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 1 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 339 | master passed | | +1 | compile | 55 | master passed | | +1 | checkstyle | 72 | master passed | | +1 | shadedjars | 268 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 34 | master passed | | 0 | spotbugs | 263 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 261 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 292 | the patch passed | | +1 | compile | 55 | the patch passed | | +1 | javac | 55 | the patch passed | | +1 | checkstyle | 72 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 262 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 903 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 280 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 9138 | hbase-server in the patch passed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 12504 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/499 | | JIRA Issue | HBASE-22601 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3a4d9b2a0b41 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-499/out/precommit/personality/provided.sh | | git revision | master / edf6f68cb2 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/2/testReport/ | | Max. process+thread count | 4533 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.
[
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908577#comment-16908577
]
Hadoop QA commented on HBASE-22601:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 21m
36s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1.3 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
37s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
34s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
37s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
28s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
30s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_232 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 2m
30s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
27s{color} | {color:green} branch-1.3 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
36s{color} | {color:green} the patch passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} the patch passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
20s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 34s{color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.5 2.7.7. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} the patch passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 89m 11s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} |
[GitHub] [hbase] Apache-HBase commented on issue #490: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache-HBase commented on issue #490: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/490#issuecomment-521842327 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 1296 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1.3 Compile Tests _ | | +1 | mvninstall | 457 | branch-1.3 passed | | +1 | compile | 34 | branch-1.3 passed with JDK v1.8.0_222 | | +1 | compile | 37 | branch-1.3 passed with JDK v1.7.0_232 | | +1 | checkstyle | 88 | branch-1.3 passed | | +1 | shadedjars | 150 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 35 | branch-1.3 passed with JDK v1.8.0_222 | | +1 | javadoc | 35 | branch-1.3 passed with JDK v1.7.0_232 | | 0 | spotbugs | 150 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 147 | branch-1.3 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 94 | the patch passed | | +1 | compile | 36 | the patch passed with JDK v1.8.0_222 | | +1 | javac | 36 | the patch passed | | +1 | compile | 38 | the patch passed with JDK v1.7.0_232 | | +1 | javac | 38 | the patch passed | | +1 | checkstyle | 84 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 140 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 514 | Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7. | | +1 | javadoc | 27 | the patch passed with JDK v1.8.0_222 | | +1 | javadoc | 35 | the patch passed with JDK v1.7.0_232 | | +1 | findbugs | 150 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 5351 | hbase-server in the patch failed. | | +1 | asflicense | 20 | The patch does not generate ASF License warnings. | | | | 8848 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestScannerHeartbeatMessages | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-490/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/490 | | JIRA Issue | HBASE-22601 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1ff30f202727 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-490/out/precommit/personality/provided.sh | | git revision | branch-1.3 / f8695bb | | Default Java | 1.7.0_232 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-490/6/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-490/6/testReport/ | | Max. process+thread count | 3782 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-490/6/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] asf-ci commented on issue #15: HBASE-22865 [HBCK2] shows the whole help/usage message after the error message
asf-ci commented on issue #15: HBASE-22865 [HBCK2] shows the whole help/usage message after the error message URL: https://github.com/apache/hbase-operator-tools/pull/15#issuecomment-521841913 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/62/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22865) [HBCK2] shows the whole help/usage message after the error message
[
https://issues.apache.org/jira/browse/HBASE-22865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sakthi updated HBASE-22865:
---
Status: Patch Available (was: In Progress)
> [HBCK2] shows the whole help/usage message after the error message
> --
>
> Key: HBASE-22865
> URL: https://issues.apache.org/jira/browse/HBASE-22865
> Project: HBase
> Issue Type: Sub-task
> Components: hbck2
>Affects Versions: hbase-operator-tools-1.0.0
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
>
> hbck2 shows the whole help/usage message after the error message.
> Operators/users need to scroll all the way up to find the error message. With
> the increasing client side support from hbck2 side, I reckon the usage
> message is only going to get bigger & bigger.
> See an example here:
> {code:java}
> $
> HBASE_CLASSPATH_PREFIX=~/dev/hbase-operator-tools/hbase-hbck2/target/hbase-hbck2-1.0.0-SNAPSHOT.jar
> ./bin/hbase org.apache.hbase.HBCK2 scheduleRecoveries
> ERROR: scheduleRecoveries takes one or more serverNames
> usage: HBCK2 [OPTIONS] COMMAND
> Options:
> -d,--debug run with debug output
> -h,--helpoutput this help message
> -p,--hbase.zookeeper.property.clientPortport of hbase ensemble
> -q,--hbase.zookeeper.quorum hbase ensemble
> -s,--skipskip hbase version check
> (PleaseHoldException)
> -v,--version this hbck2 version
> -z,--zookeeper.znode.parent parent znode of hbase
> ensemble
> Command:
> assigns [OPTIONS] ...
>Options:
> -o,--override override ownership by another procedure
>A 'raw' assign that can be used even during Master initialization (if
>the -skip flag is specified). Skirts Coprocessors. Pass one or more
>encoded region names. 1588230740 is the hard-coded name for the
>hbase:meta region and de00010733901a05f5a2a3a382e27dd4 is an example of
>what a user-space encoded region name looks like. For example:
> $ HBCK2 assign 1588230740 de00010733901a05f5a2a3a382e27dd4
>Returns the pid(s) of the created AssignProcedure(s) or -1 if none.
> bypass [OPTIONS] ...
>Options:
> -o,--override override if procedure is running/stuck
> -r,--recursive bypass parent and its children. SLOW! EXPENSIVE!
> -w,--lockWait milliseconds to wait before giving up; default=1
>Pass one (or more) procedure 'pid's to skip to procedure finish. Parent
>of bypassed procedure will also be skipped to the finish. Entities will
>be left in an inconsistent state and will require manual fixup. May
>need Master restart to clear locks still held. Bypass fails if
>procedure has children. Add 'recursive' if all you have is a parent pid
>to finish parent and children. This is SLOW, and dangerous so use
>selectively. Does not always work.
> filesystem [OPTIONS] [...]
>Options:
> -f, --fixsideline corrupt hfiles, bad links, and references.
>Report on corrupt hfiles, references, broken links, and integrity.
>Pass '--fix' to sideline corrupt files and links. '--fix' does NOT
>fix integrity issues; i.e. 'holes' or 'orphan' regions. Pass one or
>more tablenames to narrow checkup. Default checks all tables and
>restores 'hbase.version' if missing. Interacts with the filesystem
> only!
>Modified regions need to be reopened to pick-up changes.
> replication [OPTIONS] [...]
>Options:
> -f, --fixfix any replication issues found.
>Looks for undeleted replication queues and deletes them if passed the
>'--fix' option. Pass a table name to check for replication barrier and
>purge if '--fix'.
> setRegionState
>Possible region states:
> OFFLINE, OPENING, OPEN, CLOSING, CLOSED, SPLITTING, SPLIT,
> FAILED_OPEN, FAILED_CLOSE, MERGING, MERGED, SPLITTING_NEW,
> MERGING_NEW, ABNORMALLY_CLOSED
>WARNING: This is a very risky option intended for use as last resort.
>Example scenarios include unassigns/assigns that can't move forward
>because region is in an inconsistent state in 'hbase:meta'. For
>example, the 'unassigns' command can only proceed if passed a region
>in one of the following states: SPLITTING|SPLIT|MERGING|OPEN|CLOSING
>Before manually setting a region state with this command, please
>certify that this region is not being handled by a running procedure,
>such as 'assign' or 'split'. You can get a view of running procedures
>in the hbase shell using the 'list_procedures' command. An example
>setting region
[jira] [Work started] (HBASE-22865) [HBCK2] shows the whole help/usage message after the error message
[
https://issues.apache.org/jira/browse/HBASE-22865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-22865 started by Sakthi.
--
> [HBCK2] shows the whole help/usage message after the error message
> --
>
> Key: HBASE-22865
> URL: https://issues.apache.org/jira/browse/HBASE-22865
> Project: HBase
> Issue Type: Sub-task
> Components: hbck2
>Affects Versions: hbase-operator-tools-1.0.0
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
>
> hbck2 shows the whole help/usage message after the error message.
> Operators/users need to scroll all the way up to find the error message. With
> the increasing client side support from hbck2 side, I reckon the usage
> message is only going to get bigger & bigger.
> See an example here:
> {code:java}
> $
> HBASE_CLASSPATH_PREFIX=~/dev/hbase-operator-tools/hbase-hbck2/target/hbase-hbck2-1.0.0-SNAPSHOT.jar
> ./bin/hbase org.apache.hbase.HBCK2 scheduleRecoveries
> ERROR: scheduleRecoveries takes one or more serverNames
> usage: HBCK2 [OPTIONS] COMMAND
> Options:
> -d,--debug run with debug output
> -h,--helpoutput this help message
> -p,--hbase.zookeeper.property.clientPortport of hbase ensemble
> -q,--hbase.zookeeper.quorum hbase ensemble
> -s,--skipskip hbase version check
> (PleaseHoldException)
> -v,--version this hbck2 version
> -z,--zookeeper.znode.parent parent znode of hbase
> ensemble
> Command:
> assigns [OPTIONS] ...
>Options:
> -o,--override override ownership by another procedure
>A 'raw' assign that can be used even during Master initialization (if
>the -skip flag is specified). Skirts Coprocessors. Pass one or more
>encoded region names. 1588230740 is the hard-coded name for the
>hbase:meta region and de00010733901a05f5a2a3a382e27dd4 is an example of
>what a user-space encoded region name looks like. For example:
> $ HBCK2 assign 1588230740 de00010733901a05f5a2a3a382e27dd4
>Returns the pid(s) of the created AssignProcedure(s) or -1 if none.
> bypass [OPTIONS] ...
>Options:
> -o,--override override if procedure is running/stuck
> -r,--recursive bypass parent and its children. SLOW! EXPENSIVE!
> -w,--lockWait milliseconds to wait before giving up; default=1
>Pass one (or more) procedure 'pid's to skip to procedure finish. Parent
>of bypassed procedure will also be skipped to the finish. Entities will
>be left in an inconsistent state and will require manual fixup. May
>need Master restart to clear locks still held. Bypass fails if
>procedure has children. Add 'recursive' if all you have is a parent pid
>to finish parent and children. This is SLOW, and dangerous so use
>selectively. Does not always work.
> filesystem [OPTIONS] [...]
>Options:
> -f, --fixsideline corrupt hfiles, bad links, and references.
>Report on corrupt hfiles, references, broken links, and integrity.
>Pass '--fix' to sideline corrupt files and links. '--fix' does NOT
>fix integrity issues; i.e. 'holes' or 'orphan' regions. Pass one or
>more tablenames to narrow checkup. Default checks all tables and
>restores 'hbase.version' if missing. Interacts with the filesystem
> only!
>Modified regions need to be reopened to pick-up changes.
> replication [OPTIONS] [...]
>Options:
> -f, --fixfix any replication issues found.
>Looks for undeleted replication queues and deletes them if passed the
>'--fix' option. Pass a table name to check for replication barrier and
>purge if '--fix'.
> setRegionState
>Possible region states:
> OFFLINE, OPENING, OPEN, CLOSING, CLOSED, SPLITTING, SPLIT,
> FAILED_OPEN, FAILED_CLOSE, MERGING, MERGED, SPLITTING_NEW,
> MERGING_NEW, ABNORMALLY_CLOSED
>WARNING: This is a very risky option intended for use as last resort.
>Example scenarios include unassigns/assigns that can't move forward
>because region is in an inconsistent state in 'hbase:meta'. For
>example, the 'unassigns' command can only proceed if passed a region
>in one of the following states: SPLITTING|SPLIT|MERGING|OPEN|CLOSING
>Before manually setting a region state with this command, please
>certify that this region is not being handled by a running procedure,
>such as 'assign' or 'split'. You can get a view of running procedures
>in the hbase shell using the 'list_procedures' command. An example
>setting region 'de00010733901a05f5a2a3a382e27dd4' to CLOSING:
> $
[GitHub] [hbase-operator-tools] jatsakthi opened a new pull request #15: HBASE-22865 [HBCK2] shows the whole help/usage message after the error message
jatsakthi opened a new pull request #15: HBASE-22865 [HBCK2] shows the whole help/usage message after the error message URL: https://github.com/apache/hbase-operator-tools/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22865) [HBCK2] shows the whole help/usage message after the error message
[
https://issues.apache.org/jira/browse/HBASE-22865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sakthi updated HBASE-22865:
---
Issue Type: Sub-task (was: Improvement)
Parent: HBASE-21745
> [HBCK2] shows the whole help/usage message after the error message
> --
>
> Key: HBASE-22865
> URL: https://issues.apache.org/jira/browse/HBASE-22865
> Project: HBase
> Issue Type: Sub-task
> Components: hbck2
>Affects Versions: hbase-operator-tools-1.0.0
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
>
> hbck2 shows the whole help/usage message after the error message.
> Operators/users need to scroll all the way up to find the error message. With
> the increasing client side support from hbck2 side, I reckon the usage
> message is only going to get bigger & bigger.
> See an example here:
> {code:java}
> $
> HBASE_CLASSPATH_PREFIX=~/dev/hbase-operator-tools/hbase-hbck2/target/hbase-hbck2-1.0.0-SNAPSHOT.jar
> ./bin/hbase org.apache.hbase.HBCK2 scheduleRecoveries
> ERROR: scheduleRecoveries takes one or more serverNames
> usage: HBCK2 [OPTIONS] COMMAND
> Options:
> -d,--debug run with debug output
> -h,--helpoutput this help message
> -p,--hbase.zookeeper.property.clientPortport of hbase ensemble
> -q,--hbase.zookeeper.quorum hbase ensemble
> -s,--skipskip hbase version check
> (PleaseHoldException)
> -v,--version this hbck2 version
> -z,--zookeeper.znode.parent parent znode of hbase
> ensemble
> Command:
> assigns [OPTIONS] ...
>Options:
> -o,--override override ownership by another procedure
>A 'raw' assign that can be used even during Master initialization (if
>the -skip flag is specified). Skirts Coprocessors. Pass one or more
>encoded region names. 1588230740 is the hard-coded name for the
>hbase:meta region and de00010733901a05f5a2a3a382e27dd4 is an example of
>what a user-space encoded region name looks like. For example:
> $ HBCK2 assign 1588230740 de00010733901a05f5a2a3a382e27dd4
>Returns the pid(s) of the created AssignProcedure(s) or -1 if none.
> bypass [OPTIONS] ...
>Options:
> -o,--override override if procedure is running/stuck
> -r,--recursive bypass parent and its children. SLOW! EXPENSIVE!
> -w,--lockWait milliseconds to wait before giving up; default=1
>Pass one (or more) procedure 'pid's to skip to procedure finish. Parent
>of bypassed procedure will also be skipped to the finish. Entities will
>be left in an inconsistent state and will require manual fixup. May
>need Master restart to clear locks still held. Bypass fails if
>procedure has children. Add 'recursive' if all you have is a parent pid
>to finish parent and children. This is SLOW, and dangerous so use
>selectively. Does not always work.
> filesystem [OPTIONS] [...]
>Options:
> -f, --fixsideline corrupt hfiles, bad links, and references.
>Report on corrupt hfiles, references, broken links, and integrity.
>Pass '--fix' to sideline corrupt files and links. '--fix' does NOT
>fix integrity issues; i.e. 'holes' or 'orphan' regions. Pass one or
>more tablenames to narrow checkup. Default checks all tables and
>restores 'hbase.version' if missing. Interacts with the filesystem
> only!
>Modified regions need to be reopened to pick-up changes.
> replication [OPTIONS] [...]
>Options:
> -f, --fixfix any replication issues found.
>Looks for undeleted replication queues and deletes them if passed the
>'--fix' option. Pass a table name to check for replication barrier and
>purge if '--fix'.
> setRegionState
>Possible region states:
> OFFLINE, OPENING, OPEN, CLOSING, CLOSED, SPLITTING, SPLIT,
> FAILED_OPEN, FAILED_CLOSE, MERGING, MERGED, SPLITTING_NEW,
> MERGING_NEW, ABNORMALLY_CLOSED
>WARNING: This is a very risky option intended for use as last resort.
>Example scenarios include unassigns/assigns that can't move forward
>because region is in an inconsistent state in 'hbase:meta'. For
>example, the 'unassigns' command can only proceed if passed a region
>in one of the following states: SPLITTING|SPLIT|MERGING|OPEN|CLOSING
>Before manually setting a region state with this command, please
>certify that this region is not being handled by a running procedure,
>such as 'assign' or 'split'. You can get a view of running procedures
>in the hbase shell using the 'list_procedures' command. An example
>setting region
[jira] [Created] (HBASE-22865) [HBCK2] shows the whole help/usage message after the error message
Sakthi created HBASE-22865:
--
Summary: [HBCK2] shows the whole help/usage message after the
error message
Key: HBASE-22865
URL: https://issues.apache.org/jira/browse/HBASE-22865
Project: HBase
Issue Type: Improvement
Components: hbck2
Affects Versions: hbase-operator-tools-1.0.0
Reporter: Sakthi
Assignee: Sakthi
hbck2 shows the whole help/usage message after the error message.
Operators/users need to scroll all the way up to find the error message. With
the increasing client side support from hbck2 side, I reckon the usage message
is only going to get bigger & bigger.
See an example here:
{code:java}
$
HBASE_CLASSPATH_PREFIX=~/dev/hbase-operator-tools/hbase-hbck2/target/hbase-hbck2-1.0.0-SNAPSHOT.jar
./bin/hbase org.apache.hbase.HBCK2 scheduleRecoveries
ERROR: scheduleRecoveries takes one or more serverNames
usage: HBCK2 [OPTIONS] COMMAND
Options:
-d,--debug run with debug output
-h,--helpoutput this help message
-p,--hbase.zookeeper.property.clientPortport of hbase ensemble
-q,--hbase.zookeeper.quorum hbase ensemble
-s,--skipskip hbase version check
(PleaseHoldException)
-v,--version this hbck2 version
-z,--zookeeper.znode.parent parent znode of hbase
ensemble
Command:
assigns [OPTIONS] ...
Options:
-o,--override override ownership by another procedure
A 'raw' assign that can be used even during Master initialization (if
the -skip flag is specified). Skirts Coprocessors. Pass one or more
encoded region names. 1588230740 is the hard-coded name for the
hbase:meta region and de00010733901a05f5a2a3a382e27dd4 is an example of
what a user-space encoded region name looks like. For example:
$ HBCK2 assign 1588230740 de00010733901a05f5a2a3a382e27dd4
Returns the pid(s) of the created AssignProcedure(s) or -1 if none.
bypass [OPTIONS] ...
Options:
-o,--override override if procedure is running/stuck
-r,--recursive bypass parent and its children. SLOW! EXPENSIVE!
-w,--lockWait milliseconds to wait before giving up; default=1
Pass one (or more) procedure 'pid's to skip to procedure finish. Parent
of bypassed procedure will also be skipped to the finish. Entities will
be left in an inconsistent state and will require manual fixup. May
need Master restart to clear locks still held. Bypass fails if
procedure has children. Add 'recursive' if all you have is a parent pid
to finish parent and children. This is SLOW, and dangerous so use
selectively. Does not always work.
filesystem [OPTIONS] [...]
Options:
-f, --fixsideline corrupt hfiles, bad links, and references.
Report on corrupt hfiles, references, broken links, and integrity.
Pass '--fix' to sideline corrupt files and links. '--fix' does NOT
fix integrity issues; i.e. 'holes' or 'orphan' regions. Pass one or
more tablenames to narrow checkup. Default checks all tables and
restores 'hbase.version' if missing. Interacts with the filesystem
only!
Modified regions need to be reopened to pick-up changes.
replication [OPTIONS] [...]
Options:
-f, --fixfix any replication issues found.
Looks for undeleted replication queues and deletes them if passed the
'--fix' option. Pass a table name to check for replication barrier and
purge if '--fix'.
setRegionState
Possible region states:
OFFLINE, OPENING, OPEN, CLOSING, CLOSED, SPLITTING, SPLIT,
FAILED_OPEN, FAILED_CLOSE, MERGING, MERGED, SPLITTING_NEW,
MERGING_NEW, ABNORMALLY_CLOSED
WARNING: This is a very risky option intended for use as last resort.
Example scenarios include unassigns/assigns that can't move forward
because region is in an inconsistent state in 'hbase:meta'. For
example, the 'unassigns' command can only proceed if passed a region
in one of the following states: SPLITTING|SPLIT|MERGING|OPEN|CLOSING
Before manually setting a region state with this command, please
certify that this region is not being handled by a running procedure,
such as 'assign' or 'split'. You can get a view of running procedures
in the hbase shell using the 'list_procedures' command. An example
setting region 'de00010733901a05f5a2a3a382e27dd4' to CLOSING:
$ HBCK2 setRegionState de00010733901a05f5a2a3a382e27dd4 CLOSING
Returns "0" if region state changed and "1" otherwise.
setTableState
Possible table states: ENABLED, DISABLED, DISABLING, ENABLING
To read current table state, in the hbase shell run:
hbase> get 'hbase:meta', '', 'table:state'
A value of \x08\x00 == ENABLED, \x08\x01 == DISABLED, etc.
Can
[GitHub] [hbase] Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload
Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/494#issuecomment-521835769 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 41 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2 Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for branch | | +1 | mvninstall | 301 | branch-2 passed | | +1 | compile | 104 | branch-2 passed | | +1 | checkstyle | 117 | branch-2 passed | | +1 | shadedjars | 248 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 68 | branch-2 passed | | 0 | spotbugs | 192 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 402 | branch-2 passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 287 | the patch passed | | +1 | compile | 106 | the patch passed | | +1 | cc | 106 | the patch passed | | +1 | javac | 106 | the patch passed | | -1 | checkstyle | 72 | hbase-server: The patch generated 2 new + 302 unchanged - 0 fixed = 304 total (was 302) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 240 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 879 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | hbaseprotoc | 101 | the patch passed | | +1 | javadoc | 65 | the patch passed | | -1 | findbugs | 208 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 34 | hbase-protocol-shaded in the patch passed. | | +1 | unit | 203 | hbase-client in the patch passed. | | -1 | unit | 1678 | hbase-server in the patch failed. | | +1 | asflicense | 37 | The patch does not generate ASF License warnings. | | | | 5874 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256] | | Failed junit tests | hadoop.hbase.regionserver.TestBulkLoad | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/494 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc | | uname | Linux fd793bca1f83 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh | | git revision | branch-2 / 4b60eaca17 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/5/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/5/artifact/out/new-findbugs-hbase-server.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/5/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/5/testReport/ | | Max. process+thread count | 701 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at:
