[jira] [Commented] (HBASE-22871) Move the DirScanPool out and do not use static field
[
https://issues.apache.org/jira/browse/HBASE-22871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909899#comment-16909899
]
Hudson commented on HBASE-22871:
Results for branch branch-2.1
[build #1495 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1495/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1495//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1495//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1495//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move the DirScanPool out and do not use static field
>
>
> Key: HBASE-22871
> URL: https://issues.apache.org/jira/browse/HBASE-22871
> Project: HBase
> Issue Type: Improvement
> Components: master
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> The current implementation is a bit ugly, the onConfigurationChange is an
> instance method but it writes to a static field and cause a findbugs warning.
> I think we can just put the DirScanPool in HMaster and pass it when
> constructing Cleaners...
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22872) Don't create normalization plan unnecesarily when split and merge both are disabled
[ https://issues.apache.org/jira/browse/HBASE-22872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Poonia updated HBASE-22872: Status: Patch Available (was: Open) > Don't create normalization plan unnecesarily when split and merge both are > disabled > --- > > Key: HBASE-22872 > URL: https://issues.apache.org/jira/browse/HBASE-22872 > Project: HBase > Issue Type: Improvement >Affects Versions: 1.4.10 >Reporter: Aman Poonia >Assignee: Aman Poonia >Priority: Minor > Attachments: HBASE-22872.branch-1.4.001.patch > > > We should not proceed futher in normalization plan creation if split and > merge both are disabled on a table. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.
[
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909897#comment-16909897
]
Hadoop QA commented on HBASE-22601:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
42s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
22s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
17s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
26s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
22s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
12s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 9s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}130m 1s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
33s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}183m 43s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestIllegalTableDescriptor |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/11/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/500 |
| JIRA Issue | HBASE-22601 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 90ec4a5dbede 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-500/out/precommit/personality/provided.sh
|
| git revision |
[jira] [Updated] (HBASE-22760) Stop/Resume Snapshot Auto-Cleanup activity with shell command
[ https://issues.apache.org/jira/browse/HBASE-22760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22760: - Attachment: HBASE-22760.master.003.patch > Stop/Resume Snapshot Auto-Cleanup activity with shell command > - > > Key: HBASE-22760 > URL: https://issues.apache.org/jira/browse/HBASE-22760 > Project: HBase > Issue Type: Improvement > Components: Admin, shell, snapshots >Affects Versions: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.4.11 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.4.11 > > Attachments: HBASE-22760.master.003.patch > > > For any scheduled snapshot backup activity, we would like to disable > auto-cleaner for snapshot based on TTL. However, as per HBASE-22648 we have a > config to disable snapshot auto-cleaner: > hbase.master.cleaner.snapshot.disable, which would take effect only upon > HMaster restart just similar to any other hbase-site configs. > For any running cluster, we should be able to stop/resume auto-cleanup > activity for snapshot based on shell command. Something similar to below > command should be able to stop/start cleanup chore: > hbase(main):001:0> auto_snapshot_cleaner false (disable auto-cleaner) > hbase(main):001:0> auto_snapshot_cleaner true (enable auto-cleaner) -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/500#issuecomment-522293124 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 42 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2 Compile Tests _ | | +1 | mvninstall | 322 | branch-2 passed | | +1 | compile | 53 | branch-2 passed | | +1 | checkstyle | 78 | branch-2 passed | | +1 | shadedjars | 257 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 35 | branch-2 passed | | 0 | spotbugs | 206 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 202 | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 298 | the patch passed | | +1 | compile | 51 | the patch passed | | +1 | javac | 51 | the patch passed | | +1 | checkstyle | 75 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 252 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 909 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 31 | the patch passed | | +1 | findbugs | 190 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 7801 | hbase-server in the patch failed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 11023 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestIllegalTableDescriptor | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/11/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/500 | | JIRA Issue | HBASE-22601 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 90ec4a5dbede 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-500/out/precommit/personality/provided.sh | | git revision | branch-2 / 29ed4157b3 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/11/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/11/testReport/ | | Max. process+thread count | 4446 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/11/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22760) Stop/Resume Snapshot Auto-Cleanup activity with shell command
[ https://issues.apache.org/jira/browse/HBASE-22760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22760: - Fix Version/s: 1.4.11 2.2.1 2.3.0 1.5.0 3.0.0 Status: Patch Available (was: In Progress) > Stop/Resume Snapshot Auto-Cleanup activity with shell command > - > > Key: HBASE-22760 > URL: https://issues.apache.org/jira/browse/HBASE-22760 > Project: HBase > Issue Type: Improvement > Components: Admin, shell, snapshots >Affects Versions: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.4.11 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.4.11 > > > For any scheduled snapshot backup activity, we would like to disable > auto-cleaner for snapshot based on TTL. However, as per HBASE-22648 we have a > config to disable snapshot auto-cleaner: > hbase.master.cleaner.snapshot.disable, which would take effect only upon > HMaster restart just similar to any other hbase-site configs. > For any running cluster, we should be able to stop/resume auto-cleanup > activity for snapshot based on shell command. Something similar to below > command should be able to stop/start cleanup chore: > hbase(main):001:0> auto_snapshot_cleaner false (disable auto-cleaner) > hbase(main):001:0> auto_snapshot_cleaner true (enable auto-cleaner) -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work started] (HBASE-22760) Stop/Resume Snapshot Auto-Cleanup activity with shell command
[ https://issues.apache.org/jira/browse/HBASE-22760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-22760 started by Viraj Jasani. > Stop/Resume Snapshot Auto-Cleanup activity with shell command > - > > Key: HBASE-22760 > URL: https://issues.apache.org/jira/browse/HBASE-22760 > Project: HBase > Issue Type: Improvement > Components: Admin, shell, snapshots >Affects Versions: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.4.11 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > > For any scheduled snapshot backup activity, we would like to disable > auto-cleaner for snapshot based on TTL. However, as per HBASE-22648 we have a > config to disable snapshot auto-cleaner: > hbase.master.cleaner.snapshot.disable, which would take effect only upon > HMaster restart just similar to any other hbase-site configs. > For any running cluster, we should be able to stop/resume auto-cleanup > activity for snapshot based on shell command. Something similar to below > command should be able to stop/start cleanup chore: > hbase(main):001:0> auto_snapshot_cleaner false (disable auto-cleaner) > hbase(main):001:0> auto_snapshot_cleaner true (enable auto-cleaner) -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)
virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#discussion_r314968185 ## File path: hbase-zookeeper/pom.xml ## @@ -274,6 +284,16 @@ org.apache.hadoop hadoop-common + Review comment: @Apache9 this doesn't work as expected. For instance, if downstream app has hbase-client dependency and if we have just excluded from parent pom, downstream would still get vulnerable Jackson1 dependencies from hbase-client. In fact, the same is done for branch-1: https://github.com/apache/hbase/commit/4b34d24f7a12510f69cf4d2e190359dc0b271ead (removal in individual modules so that downstreamer won't pull in from HBase) Another reason why we shouldn't rely on just parent is because at some places, we might be using provided/test scopes for Jackson1 that we might not want to remove: e.g. ``` [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-shaded-client-byo-hadoop --- [INFO] org.apache.hbase:hbase-shaded-client-byo-hadoop:jar:3.0.0-SNAPSHOT [INFO] \- org.apache.hadoop:hadoop-common:jar:2.8.5:provided [INFO]\- com.sun.jersey:jersey-json:jar:1.9:provided [INFO] +- org.codehaus.jackson:jackson-jaxrs:jar:1.8.3:provided [INFO] \- org.codehaus.jackson:jackson-xc:jar:1.8.3:provided ``` If we keep the above as provided, there is no harm but if we exclude from parent pom, even this would be removed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)
virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#discussion_r314968185 ## File path: hbase-zookeeper/pom.xml ## @@ -274,6 +284,16 @@ org.apache.hadoop hadoop-common + Review comment: @Apache9 this doesn't work as expected. For instance, if downstream app has hbase-client dependency and if we have just excluded from parent pom, downstream would still get vulnerable Jackson1 dependencies from hbase-client. In fact, the same is done for branch-1: https://github.com/apache/hbase/commit/4b34d24f7a12510f69cf4d2e190359dc0b271ead (removal in individual modules so that downstreamer won't pull in from HBase) Another reason why we shouldn't rely on just parent is because at some places, we might be using provided/test scopes for Jackson1 that we might not want to remove: e.g. ``` [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-shaded-client-byo-hadoop --- [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-shaded-client-byo-hadoop --- [INFO] org.apache.hbase:hbase-shaded-client-byo-hadoop:jar:3.0.0-SNAPSHOT [INFO] \- org.apache.hadoop:hadoop-common:jar:2.8.5:provided [INFO]\- com.sun.jersey:jersey-json:jar:1.9:provided [INFO] +- org.codehaus.jackson:jackson-jaxrs:jar:1.8.3:provided [INFO] \- org.codehaus.jackson:jackson-xc:jar:1.8.3:provided ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22870) reflection fails to access a private nested class
[
https://issues.apache.org/jira/browse/HBASE-22870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reid Chan updated HBASE-22870:
--
Fix Version/s: (was: 2.2.2)
2.2.1
> reflection fails to access a private nested class
> -
>
> Key: HBASE-22870
> URL: https://issues.apache.org/jira/browse/HBASE-22870
> Project: HBase
> Issue Type: Bug
> Components: master
>Affects Versions: 2.1.5
>Reporter: ranpanfeng
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> HMaster crashes at
> org/apache/hadoop/hbase/regionserver/HRegionServer.java:1044
> *A private static nested class can not be instantiated via reflection.*
> *code snippet*
>
> {code:java}
>
> try {
> abortTimeoutTask =
> Class.forName(conf.get(ABORT_TIMEOUT_TASK,
> SystemExitWhenAbortTimeout.class.getName()))
> .asSubclass(TimerTask.class).getDeclaredConstructor().newInstance();
> } catch (Exception e) {
> LOG.warn("Initialize abort timeout task failed", e);
> }{code}
>
>
> *log in product environtment*
> {code:java}
> 2019-08-16 18:01:40,737 [WARN ] HRegionServer:1046 Initialize abort timeout
> task failed
> java.lang.IllegalAccessException: Class
> org.apache.hadoop.hbase.regionserver.HRegionServer can not access a member of
> class org.apache.hadoop.hbase.regionss
> erver.HRegionServer$SystemExitWhenAbortTimeout with modifiers "private"
> at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:102)
> at
> java.lang.reflect.AccessibleObject.slowCheckMemberAccess(AccessibleObject.java:296)
> at java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:288)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:413)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1044)
> at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:598){code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Resolved] (HBASE-22870) reflection fails to access a private nested class
[
https://issues.apache.org/jira/browse/HBASE-22870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reid Chan resolved HBASE-22870.
---
Resolution: Fixed
Fix Version/s: (was: 2.1.5)
2.2.2
2.1.7
2.3.0
3.0.0
> reflection fails to access a private nested class
> -
>
> Key: HBASE-22870
> URL: https://issues.apache.org/jira/browse/HBASE-22870
> Project: HBase
> Issue Type: Bug
> Components: master
>Affects Versions: 2.1.5
>Reporter: ranpanfeng
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> HMaster crashes at
> org/apache/hadoop/hbase/regionserver/HRegionServer.java:1044
> *A private static nested class can not be instantiated via reflection.*
> *code snippet*
>
> {code:java}
>
> try {
> abortTimeoutTask =
> Class.forName(conf.get(ABORT_TIMEOUT_TASK,
> SystemExitWhenAbortTimeout.class.getName()))
> .asSubclass(TimerTask.class).getDeclaredConstructor().newInstance();
> } catch (Exception e) {
> LOG.warn("Initialize abort timeout task failed", e);
> }{code}
>
>
> *log in product environtment*
> {code:java}
> 2019-08-16 18:01:40,737 [WARN ] HRegionServer:1046 Initialize abort timeout
> task failed
> java.lang.IllegalAccessException: Class
> org.apache.hadoop.hbase.regionserver.HRegionServer can not access a member of
> class org.apache.hadoop.hbase.regionss
> erver.HRegionServer$SystemExitWhenAbortTimeout with modifiers "private"
> at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:102)
> at
> java.lang.reflect.AccessibleObject.slowCheckMemberAccess(AccessibleObject.java:296)
> at java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:288)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:413)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1044)
> at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:598){code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22870) reflection fails to access a private nested class
[
https://issues.apache.org/jira/browse/HBASE-22870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909895#comment-16909895
]
Reid Chan commented on HBASE-22870:
---
Pushed to master, branch-2, branch-2.1, branch-2.2
> reflection fails to access a private nested class
> -
>
> Key: HBASE-22870
> URL: https://issues.apache.org/jira/browse/HBASE-22870
> Project: HBase
> Issue Type: Bug
> Components: master
>Affects Versions: 2.1.5
>Reporter: ranpanfeng
>Priority: Major
> Fix For: 2.1.5
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> HMaster crashes at
> org/apache/hadoop/hbase/regionserver/HRegionServer.java:1044
> *A private static nested class can not be instantiated via reflection.*
> *code snippet*
>
> {code:java}
>
> try {
> abortTimeoutTask =
> Class.forName(conf.get(ABORT_TIMEOUT_TASK,
> SystemExitWhenAbortTimeout.class.getName()))
> .asSubclass(TimerTask.class).getDeclaredConstructor().newInstance();
> } catch (Exception e) {
> LOG.warn("Initialize abort timeout task failed", e);
> }{code}
>
>
> *log in product environtment*
> {code:java}
> 2019-08-16 18:01:40,737 [WARN ] HRegionServer:1046 Initialize abort timeout
> task failed
> java.lang.IllegalAccessException: Class
> org.apache.hadoop.hbase.regionserver.HRegionServer can not access a member of
> class org.apache.hadoop.hbase.regionss
> erver.HRegionServer$SystemExitWhenAbortTimeout with modifiers "private"
> at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:102)
> at
> java.lang.reflect.AccessibleObject.slowCheckMemberAccess(AccessibleObject.java:296)
> at java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:288)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:413)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1044)
> at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:598){code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] virajjasani commented on a change in pull request #501: HBASE-22699 refactor isMetaClearingException
virajjasani commented on a change in pull request #501: HBASE-22699 refactor
isMetaClearingException
URL: https://github.com/apache/hbase/pull/501#discussion_r314968514
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java
##
@@ -87,15 +90,15 @@ public static Throwable findException(Object exception) {
}
Throwable cur = (Throwable) exception;
while (cur != null) {
- if (isSpecialException(cur)) {
+ if (matchExceptionWeCare(cur)) {
Review comment:
nit: although not imp, can you keep the name same as before?
`matchExceptionWeCare` doesn't seem much vocal or may be we don't need that
one liner function.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.
[
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909894#comment-16909894
]
Hadoop QA commented on HBASE-22601:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
43s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
51s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
26s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
24s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
54s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 34s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
14s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}138m
28s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}200m 9s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/12/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/499 |
| JIRA Issue | HBASE-22601 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 40c71a5aaee0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-499@2/out/precommit/personality/provided.sh
|
| git revision | master / 7697d48cd7 |
| Default Java | 1.8.0_181 |
| Test Results |
[GitHub] [hbase] Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/499#issuecomment-522291957 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 368 | master passed | | +1 | compile | 66 | master passed | | +1 | checkstyle | 82 | master passed | | +1 | shadedjars | 291 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 39 | master passed | | 0 | spotbugs | 266 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 264 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 348 | the patch passed | | +1 | compile | 59 | the patch passed | | +1 | javac | 59 | the patch passed | | +1 | checkstyle | 78 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 294 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1054 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 254 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8308 | hbase-server in the patch passed. | | +1 | asflicense | 23 | The patch does not generate ASF License warnings. | | | | 12009 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/12/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/499 | | JIRA Issue | HBASE-22601 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 40c71a5aaee0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-499@2/out/precommit/personality/provided.sh | | git revision | master / 7697d48cd7 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/12/testReport/ | | Max. process+thread count | 4712 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/12/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)
virajjasani commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#issuecomment-522291730 Let me provide the full dependency tree for Jackson1 with this patch: ``` [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-http --- [INFO] org.apache.hbase:hbase-http:jar:3.0.0-SNAPSHOT [INFO] +- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test [INFO] | +- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test [INFO] | | \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test [INFO] | \- org.apache.hadoop:hadoop-yarn-server-tests:test-jar:tests:2.8.5:test [INFO] | \- org.apache.hadoop:hadoop-yarn-common:jar:2.8.5:test [INFO] |+- org.codehaus.jackson:jackson-jaxrs:jar:1.9.13:test [INFO] |\- org.codehaus.jackson:jackson-xc:jar:1.9.13:test [INFO] \- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile ``` ``` [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-server --- [INFO] org.apache.hbase:hbase-server:jar:3.0.0-SNAPSHOT [INFO] +- org.apache.hbase:hbase-http:test-jar:tests:3.0.0-SNAPSHOT:test [INFO] | \- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test [INFO] \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test [INFO]\- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test [INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test [INFO] ``` ``` [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-mapreduce --- [INFO] org.apache.hbase:hbase-mapreduce:jar:3.0.0-SNAPSHOT [INFO] \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test [INFO]\- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test [INFO] +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test [INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test ``` ``` [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-testing-util --- [INFO] org.apache.hbase:hbase-testing-util:jar:3.0.0-SNAPSHOT [INFO] \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:compile [INFO]\- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test [INFO] +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test [INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test ``` ``` [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-thrift --- [INFO] org.apache.hbase:hbase-thrift:jar:3.0.0-SNAPSHOT [INFO] \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test [INFO]\- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test [INFO] +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test [INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test ``` ``` [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-rsgroup --- [INFO] org.apache.hbase:hbase-rsgroup:jar:3.0.0-SNAPSHOT [INFO] \- org.apache.hbase:hbase-testing-util:jar:3.0.0-SNAPSHOT:test [INFO]\- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test [INFO] \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test [INFO] +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test [INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test ``` ``` [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-shell --- [INFO] org.apache.hbase:hbase-shell:jar:3.0.0-SNAPSHOT [INFO] \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test [INFO]\- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test [INFO] +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test [INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test ``` ``` [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-endpoint --- [INFO] org.apache.hbase:hbase-endpoint:jar:3.0.0-SNAPSHOT [INFO] +- org.apache.hbase:hbase-http:test-jar:tests:3.0.0-SNAPSHOT:test [INFO] | \- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test [INFO] \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test [INFO]\- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test [INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test ``` ``` [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-backup --- [INFO] org.apache.hbase:hbase-backup:jar:3.0.0-SNAPSHOT [INFO] \- org.apache.hbase:hbase-testing-util:jar:3.0.0-SNAPSHOT:test [INFO]\- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test [INFO] \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test [INFO] +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test [INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test ``` ``` [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-it ---
[GitHub] [hbase] virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)
virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#discussion_r314968185 ## File path: hbase-zookeeper/pom.xml ## @@ -274,6 +284,16 @@ org.apache.hadoop hadoop-common + Review comment: @Apache9 this doesn't work as expected. For instance, if downstream app has hbase-client dependency and if we have just excluded from parent pom, downstream would still get vulnerable Jackson1 dependencies from hbase-client. In fact, the same is done for branch-1: https://github.com/apache/hbase/commit/4b34d24f7a12510f69cf4d2e190359dc0b271ead (removal in individual modules so that downstreamer won't pull in from HBase) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)
virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#discussion_r314968185 ## File path: hbase-zookeeper/pom.xml ## @@ -274,6 +284,16 @@ org.apache.hadoop hadoop-common + Review comment: @Apache9 this doesn't work as expected. For instance, if downstream app has hbase-client dependency and if we have just excluded from parent pom, downstream would still get vulnerable Jackson1 dependencies from hbase-client. In fact, the same is done for branch-1: https://github.com/apache/hbase/commit/4b34d24f7a12510f69cf4d2e190359dc0b271ead This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] shahrs87 commented on a change in pull request #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
shahrs87 commented on a change in pull request #499: [HBASE-22601]
Misconfigured addition of peers leads to cluster shutdown.
URL: https://github.com/apache/hbase/pull/499#discussion_r314968060
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##
@@ -504,6 +504,15 @@ private void initialize() {
}
}
+if (peerClusterId == null) {
Review comment:
Actually this makes more sense. Thanks for the idea.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.
[
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909887#comment-16909887
]
Hadoop QA commented on HBASE-22601:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
22s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
17s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
50s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
20s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
18s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
16s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 48s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}236m 46s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
36s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}294m 44s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/10/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/500 |
| JIRA Issue | HBASE-22601 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 1594f9a12c0e 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24
13:14:43 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-500/out/precommit/personality/provided.sh
[GitHub] [hbase] Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/500#issuecomment-522290267 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 70 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2 Compile Tests _ | | +1 | mvninstall | 322 | branch-2 passed | | +1 | compile | 55 | branch-2 passed | | +1 | checkstyle | 77 | branch-2 passed | | +1 | shadedjars | 290 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | branch-2 passed | | 0 | spotbugs | 200 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 198 | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 334 | the patch passed | | +1 | compile | 54 | the patch passed | | +1 | javac | 54 | the patch passed | | +1 | checkstyle | 76 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 256 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1008 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 32 | the patch passed | | +1 | findbugs | 199 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 14206 | hbase-server in the patch failed. | | +1 | asflicense | 36 | The patch does not generate ASF License warnings. | | | | 17684 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/500 | | JIRA Issue | HBASE-22601 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1594f9a12c0e 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-500/out/precommit/personality/provided.sh | | git revision | branch-2 / c295fd7c6a | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/10/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/10/testReport/ | | Max. process+thread count | 4137 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/10/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)
virajjasani commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#issuecomment-522290007 That is already included from hadoop-minicluster only, but at test scop: ``` [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-server --- [INFO] org.apache.hbase:hbase-server:jar:3.0.0-SNAPSHOT [INFO] +- org.apache.hbase:hbase-http:test-jar:tests:3.0.0-SNAPSHOT:test [INFO] | \- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test [INFO] \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test [INFO]\- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test [INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)
Apache9 commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#issuecomment-522289943 So what about our own UTs? How do we include the jackson1 dependencies for hbase-server test module for example? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)
virajjasani commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#issuecomment-522289864 > So we need to add the jackson dependency explicitly as a test dependency in our own pom as we exclude them from the hadoop-common? Correct. Just did it here: https://github.com/apache/hbase/pull/505/files#diff-659d55cb388d174df96d2c372cfc982fR138 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)
Apache9 commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#issuecomment-522289721 So we need to add the jackson dependency explicitly as a test dependency in our own pom as we exclude them from the hadoop-common? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)
Apache9 commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#discussion_r314967542 ## File path: hbase-zookeeper/pom.xml ## @@ -274,6 +284,16 @@ org.apache.hadoop hadoop-common + Review comment: Yes, that's what I mean, excluding in the parent pom so the sub modules just inherit the exclusions automatically. But I'm not a maven expert so please confirm whether it actually works... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)
virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#discussion_r314967499 ## File path: hbase-zookeeper/pom.xml ## @@ -274,6 +284,16 @@ org.apache.hadoop hadoop-common + Review comment: Oh you mean just exclude from parent pom and we don't need to exclude from individual modules right? Sure let me do that for jackson-jaxrs and jackson-xc since they are common across all modules This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache9 commented on a change in pull request #499: [HBASE-22601] Misconfigured
addition of peers leads to cluster shutdown.
URL: https://github.com/apache/hbase/pull/499#discussion_r314967330
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
##
@@ -484,8 +484,10 @@ public void refreshSources(String peerId) throws
IOException {
LOG.info("Terminate replication source for " + toRemove.getPeerId());
toRemove.terminate(terminateMessage);
}
- for (NavigableSet walsByGroup : walsById.get(peerId).values()) {
-walsByGroup.forEach(wal -> src.enqueueLog(new Path(this.logDir, wal)));
+ if (walsById.get(peerId) != null) {
Review comment:
And is this possible? In the addSource method, we will always put a Map into
the walsByGroup for the corresponding peerId. Notice that the code for branch-2
have been changed a lot from branch-1 so...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache9 commented on a change in pull request #499: [HBASE-22601] Misconfigured
addition of peers leads to cluster shutdown.
URL: https://github.com/apache/hbase/pull/499#discussion_r314967196
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##
@@ -504,6 +504,15 @@ private void initialize() {
}
}
+if (peerClusterId == null) {
Review comment:
I think here we just need to add the same check like above?
```
if (!this.isSourceActive()) {
return;
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)
virajjasani commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#issuecomment-522288323 > Is it safe to just exclude these transitive dependencies? At least hadoop adds them as dependencies... @Apache9 Since we have moved to Jackson2, we can safely exclude these dependencies. At some places, we require jackson-mapper-asl:1.9.13(CVE exposed) at test scope to run tests like HBaseTestUtility.startMiniCluster(). But definitely not required at compile scope as we would exposed these to downstreamers. This is partly forwardport from [HBASE-22728](https://issues.apache.org/jira/browse/HBASE-22728) to master and branch-2. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache9 commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/500#issuecomment-522288040 Seems `TestReplicationProcedureRetry` fails consistently? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)
virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#discussion_r314966956 ## File path: hbase-zookeeper/pom.xml ## @@ -274,6 +284,16 @@ org.apache.hadoop hadoop-common + Review comment: Unfortunately, that doesn't work This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)
Apache9 commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#discussion_r314966824 ## File path: hbase-zookeeper/pom.xml ## @@ -274,6 +284,16 @@ org.apache.hadoop hadoop-common + Review comment: Can we add these exclusions in the parent pom? No? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #501: HBASE-22699 refactor isMetaClearingException
Apache9 commented on a change in pull request #501: HBASE-22699 refactor
isMetaClearingException
URL: https://github.com/apache/hbase/pull/501#discussion_r314966430
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java
##
@@ -59,18 +58,22 @@ public static boolean isMetaClearingException(Throwable
cur) {
if (cur == null) {
return true;
}
-return !isSpecialException(cur) || (cur instanceof RegionMovedException)
-|| cur instanceof NotServingRegionException;
+return !regionDefinitelyOnTheRegionServerException(cur);
}
- public static boolean isSpecialException(Throwable cur) {
-return (cur instanceof RegionMovedException || cur instanceof
RegionOpeningException
-|| cur instanceof RegionTooBusyException || cur instanceof
RpcThrottlingException
-|| cur instanceof MultiActionResultTooLarge || cur instanceof
RetryImmediatelyException
-|| cur instanceof CallQueueTooBigException || cur instanceof
CallDroppedException
-|| cur instanceof NotServingRegionException || cur instanceof
RequestTooBigException);
+ private static boolean regionDefinitelyOnTheRegionServerException(Throwable
t) {
+return (t instanceof RegionTooBusyException || t instanceof
RpcThrottlingException
+|| t instanceof RetryImmediatelyException || t instanceof
CallQueueTooBigException
Review comment:
And for CallQueueTooBigException, CallDroppedException,
RequestTooBigExcetion, it does not mean that the region is on the region
server? We just do not want to push too much pressure on meta so we do not want
to retry on these exceptions everytime, but the method name here is a bit
confusing...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #501: HBASE-22699 refactor isMetaClearingException
Apache9 commented on a change in pull request #501: HBASE-22699 refactor
isMetaClearingException
URL: https://github.com/apache/hbase/pull/501#discussion_r314966368
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java
##
@@ -59,18 +58,22 @@ public static boolean isMetaClearingException(Throwable
cur) {
if (cur == null) {
return true;
}
-return !isSpecialException(cur) || (cur instanceof RegionMovedException)
-|| cur instanceof NotServingRegionException;
+return !regionDefinitelyOnTheRegionServerException(cur);
}
- public static boolean isSpecialException(Throwable cur) {
-return (cur instanceof RegionMovedException || cur instanceof
RegionOpeningException
-|| cur instanceof RegionTooBusyException || cur instanceof
RpcThrottlingException
-|| cur instanceof MultiActionResultTooLarge || cur instanceof
RetryImmediatelyException
-|| cur instanceof CallQueueTooBigException || cur instanceof
CallDroppedException
-|| cur instanceof NotServingRegionException || cur instanceof
RequestTooBigException);
+ private static boolean regionDefinitelyOnTheRegionServerException(Throwable
t) {
+return (t instanceof RegionTooBusyException || t instanceof
RpcThrottlingException
Review comment:
I think RegionOpeningException means the region is on the region server so
we do not need to go to meta?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #501: HBASE-22699 refactor isMetaClearingException
Apache9 commented on a change in pull request #501: HBASE-22699 refactor
isMetaClearingException
URL: https://github.com/apache/hbase/pull/501#discussion_r314966450
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java
##
@@ -59,18 +58,22 @@ public static boolean isMetaClearingException(Throwable
cur) {
if (cur == null) {
return true;
}
-return !isSpecialException(cur) || (cur instanceof RegionMovedException)
-|| cur instanceof NotServingRegionException;
+return !regionDefinitelyOnTheRegionServerException(cur);
}
- public static boolean isSpecialException(Throwable cur) {
-return (cur instanceof RegionMovedException || cur instanceof
RegionOpeningException
-|| cur instanceof RegionTooBusyException || cur instanceof
RpcThrottlingException
-|| cur instanceof MultiActionResultTooLarge || cur instanceof
RetryImmediatelyException
-|| cur instanceof CallQueueTooBigException || cur instanceof
CallDroppedException
-|| cur instanceof NotServingRegionException || cur instanceof
RequestTooBigException);
+ private static boolean regionDefinitelyOnTheRegionServerException(Throwable
t) {
+return (t instanceof RegionTooBusyException || t instanceof
RpcThrottlingException
+|| t instanceof RetryImmediatelyException || t instanceof
CallQueueTooBigException
+|| t instanceof CallDroppedException || t instanceof
RequestTooBigException);
Review comment:
And for RequestTooBigException, it is a DoNotRetryIOException so it is fine
to not clear meta, but for CallQueueTooBigException and CallDroppedException,
what if the region is not on the region server, and the region server can not
recover for a very long time? The client will stuck there?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.
[
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909875#comment-16909875
]
Hadoop QA commented on HBASE-22601:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
37s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
33s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
8s{color} | {color:blue} Used deprecated FindBugs config; considering switching
to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
7s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
39s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 31s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
13s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}140m
35s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}196m 50s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/11/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/499 |
| JIRA Issue | HBASE-22601 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux f0b379d4242c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-499/out/precommit/personality/provided.sh
|
| git revision | master / 836f26976e |
| Default Java | 1.8.0_181 |
| Test Results |
[GitHub] [hbase] Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/499#issuecomment-522286296 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 335 | master passed | | +1 | compile | 52 | master passed | | +1 | checkstyle | 75 | master passed | | +1 | shadedjars | 273 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 35 | master passed | | 0 | spotbugs | 248 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 247 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 300 | the patch passed | | +1 | compile | 53 | the patch passed | | +1 | javac | 53 | the patch passed | | +1 | checkstyle | 73 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 279 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 931 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 253 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8435 | hbase-server in the patch passed. | | +1 | asflicense | 24 | The patch does not generate ASF License warnings. | | | | 11810 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/11/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/499 | | JIRA Issue | HBASE-22601 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f0b379d4242c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-499/out/precommit/personality/provided.sh | | git revision | master / 836f26976e | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/11/testReport/ | | Max. process+thread count | 4656 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/11/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations in client snapshot exceptions
Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations in client snapshot exceptions URL: https://github.com/apache/hbase/pull/487#issuecomment-522286273 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 69 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 408 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 35 | master passed | | +1 | shadedjars | 313 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 24 | master passed | | 0 | spotbugs | 75 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 73 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 344 | the patch passed | | +1 | compile | 29 | the patch passed | | +1 | javac | 29 | the patch passed | | +1 | checkstyle | 35 | hbase-client: The patch generated 0 new + 0 unchanged - 13 fixed = 0 total (was 13) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 318 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1067 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 22 | hbase-client generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) | | +1 | findbugs | 81 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 105 | hbase-client in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 3367 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/16/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/487 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a37538ddb9a2 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-487/out/precommit/personality/provided.sh | | git revision | master / 7697d48cd7 | | Default Java | 1.8.0_181 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/16/artifact/out/diff-javadoc-javadoc-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/16/testReport/ | | Max. process+thread count | 266 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/16/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-522286105 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 41 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 328 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 14 | master passed | | +1 | shadedjars | 276 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 21 | master passed | | 0 | spotbugs | 46 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 43 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 301 | the patch passed | | +1 | compile | 24 | the patch passed | | +1 | javac | 24 | the patch passed | | +1 | checkstyle | 11 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 277 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 939 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 18 | the patch passed | | +1 | findbugs | 48 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 357 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 3098 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/100/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 56552fbcc42a 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / 7697d48cd7 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/100/testReport/ | | Max. process+thread count | 4125 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/100/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException
Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/501#issuecomment-522286059 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 337 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 31 | master passed | | +1 | shadedjars | 285 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 23 | master passed | | 0 | spotbugs | 72 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 69 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 306 | the patch passed | | +1 | compile | 23 | the patch passed | | +1 | javac | 23 | the patch passed | | +1 | checkstyle | 29 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 274 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1034 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 21 | the patch passed | | +1 | findbugs | 77 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 107 | hbase-client in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 3065 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/501 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 72aae3648d24 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-501/out/precommit/personality/provided.sh | | git revision | master / 7697d48cd7 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/7/testReport/ | | Max. process+thread count | 287 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/7/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot feature
Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#issuecomment-522284964 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 45 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | @author | 0 | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 | mvninstall | 331 | master passed | | 0 | refguide | 319 | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 300 | the patch passed | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | 0 | refguide | 315 | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 | asflicense | 17 | The patch does not generate ASF License warnings. | | | | 1389 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/11/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/496 | | Optional Tests | dupname asflicense shellcheck shelldocs refguide | | uname | Linux 4466cdc1c85e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-496/out/precommit/personality/provided.sh | | git revision | master / 7697d48cd7 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/11/artifact/out/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/11/artifact/out/patch-site/book.html | | Max. process+thread count | 96 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/11/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature
openinx commented on a change in pull request #496: HBASE-22625 documet use
scan snapshot feature
URL: https://github.com/apache/hbase/pull/496#discussion_r314965467
##
File path: src/main/asciidoc/_chapters/snapshot_scanner.adoc
##
@@ -0,0 +1,138 @@
+
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+[[snapshot_scanner]]
+== Scan over snapshot
+:doctype: book
+:numbered:
+:toc: left
+:icons: font
+:experimental:
+:toc: left
+:source-language: java
+
+In HBase, scan a table costs many CPU, memory... resources. Luckily, HBase
provides a TableSnapshotScanner and TableSnapshotInputFormat (introduced by
link:https://issues.apache.org/jira/browse/HBASE-8369[HBASE-8369]), which
performs a scan over snapshot files.
+By this way, we can bypasse HBase servers, and access the underlying files
directly to provide maximum performance. And can also be used with offline
HBase with in-place or exported snapshot files.
+
+To read from snapshot files directly from the file system, the user must have
sufficient permissions to access snapshot and reference data files.
+
+=== TableSnapshotScanner
+
+TableSnapshotScanner provide a way to do single client side scan over snapshot
files.
+When use TableSnapshotScanner, we must specify a temporary directory to copy
the snapshot files into. Current user should have write permissions to this
directory, and this should not be a subdirectory of rootdir. The scanner
deletes the contents of the directory once the scanner is closed.
+
+.Use TableSnapshotScanner
+
+[source,java]
+
+Path restoreDir = new Path("XX"); // restore dir should not be a subdirectory
HBase rootdir
+Scan scan = new Scan();
+try (TableSnapshotScanner scanner = new TableSnapshotScanner(conf, restoreDir,
snapshotName, scan)) {
+Result result = scanner.next();
+while (result != null) {
+...
+result = scanner.next();
+}
+}
+
+
+
+=== TableSnapshotInputFormat
+TableSnapshotInputFormat provide a way to scan over snapshot files in a
MapReduce job.
+
+.Use TableSnapshotInputFormat
+
+[source,java]
+
+Job job = new Job(conf);
+Path restoreDir = new Path("XX"); // restore dir should not be a subdirectory
HBase rootdir
+Scan scan = new Scan();
+TableMapReduceUtil.initTableSnapshotMapperJob(snapshotName, scan,
MyTableMapper.class, MyMapKeyOutput.class, MyMapOutputValueWritable.class, job,
true, restoreDir);
+
+
+
+=== Permission to access snapshot and data files
+Generally, only the HBase owner or the HDFS admin have the permission to
access hfiles.
+
+link:https://issues.apache.org/jira/browse/HBASE-18659[HBASE-18659] use HDFS
ACLs to make HBase granted user have the permission to access the snapshot
files.
+
+ HDFS ACLs
+
+HDFS ACLs supports an "access ACL", which defines the rules to enforce during
permission checks, and a "default ACL", which defines the ACL entries that new
child files or sub-directories receive automatically during creation.
Review comment:
Provide a link referring to the document of HDFS ACL ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature
openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#discussion_r314965225 ## File path: src/main/asciidoc/_chapters/snapshot_scanner.adoc ## @@ -0,0 +1,138 @@ + +/** + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + + +[[snapshot_scanner]] +== Scan over snapshot +:doctype: book +:numbered: +:toc: left +:icons: font +:experimental: +:toc: left +:source-language: java + +In HBase, scan a table costs many CPU, memory... resources. Luckily, HBase provides a TableSnapshotScanner and TableSnapshotInputFormat (introduced by link:https://issues.apache.org/jira/browse/HBASE-8369[HBASE-8369]), which performs a scan over snapshot files. +By this way, we can bypasse HBase servers, and access the underlying files directly to provide maximum performance. And can also be used with offline HBase with in-place or exported snapshot files. + +To read from snapshot files directly from the file system, the user must have sufficient permissions to access snapshot and reference data files. + +=== TableSnapshotScanner + +TableSnapshotScanner provide a way to do single client side scan over snapshot files. +When use TableSnapshotScanner, we must specify a temporary directory to copy the snapshot files into. Current user should have write permissions to this directory, and this should not be a subdirectory of rootdir. The scanner deletes the contents of the directory once the scanner is closed. Review comment: copy the snapshot files into. -> restore the snapshot This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature
openinx commented on a change in pull request #496: HBASE-22625 documet use
scan snapshot feature
URL: https://github.com/apache/hbase/pull/496#discussion_r314965517
##
File path: src/main/asciidoc/_chapters/snapshot_scanner.adoc
##
@@ -0,0 +1,138 @@
+
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+[[snapshot_scanner]]
+== Scan over snapshot
+:doctype: book
+:numbered:
+:toc: left
+:icons: font
+:experimental:
+:toc: left
+:source-language: java
+
+In HBase, scan a table costs many CPU, memory... resources. Luckily, HBase
provides a TableSnapshotScanner and TableSnapshotInputFormat (introduced by
link:https://issues.apache.org/jira/browse/HBASE-8369[HBASE-8369]), which
performs a scan over snapshot files.
+By this way, we can bypasse HBase servers, and access the underlying files
directly to provide maximum performance. And can also be used with offline
HBase with in-place or exported snapshot files.
+
+To read from snapshot files directly from the file system, the user must have
sufficient permissions to access snapshot and reference data files.
+
+=== TableSnapshotScanner
+
+TableSnapshotScanner provide a way to do single client side scan over snapshot
files.
+When use TableSnapshotScanner, we must specify a temporary directory to copy
the snapshot files into. Current user should have write permissions to this
directory, and this should not be a subdirectory of rootdir. The scanner
deletes the contents of the directory once the scanner is closed.
+
+.Use TableSnapshotScanner
+
+[source,java]
+
+Path restoreDir = new Path("XX"); // restore dir should not be a subdirectory
HBase rootdir
+Scan scan = new Scan();
+try (TableSnapshotScanner scanner = new TableSnapshotScanner(conf, restoreDir,
snapshotName, scan)) {
+Result result = scanner.next();
+while (result != null) {
+...
+result = scanner.next();
+}
+}
+
+
+
+=== TableSnapshotInputFormat
+TableSnapshotInputFormat provide a way to scan over snapshot files in a
MapReduce job.
+
+.Use TableSnapshotInputFormat
+
+[source,java]
+
+Job job = new Job(conf);
+Path restoreDir = new Path("XX"); // restore dir should not be a subdirectory
HBase rootdir
+Scan scan = new Scan();
+TableMapReduceUtil.initTableSnapshotMapperJob(snapshotName, scan,
MyTableMapper.class, MyMapKeyOutput.class, MyMapOutputValueWritable.class, job,
true, restoreDir);
+
+
+
+=== Permission to access snapshot and data files
+Generally, only the HBase owner or the HDFS admin have the permission to
access hfiles.
+
+link:https://issues.apache.org/jira/browse/HBASE-18659[HBASE-18659] use HDFS
ACLs to make HBase granted user have the permission to access the snapshot
files.
+
+ HDFS ACLs
+
+HDFS ACLs supports an "access ACL", which defines the rules to enforce during
permission checks, and a "default ACL", which defines the ACL entries that new
child files or sub-directories receive automatically during creation.
+By HDFS ACLs, HBase sync granted users with read permission to files.
+
+ Basic idea
+
+The HBase files are orginazed as the following ways:
+
+ * {hbase-rootdir}/.tmp/data/{namespace}/{table}
+ * {hbase-rootdir}/data/{namespace}/{table}
+ * {hbase-rootdir}/archive/data/{namespace}/{table}
+ * {hbase-rootdir}/.hbase-snapshot/{snapshotName}
+
+So the basic idea is to add or remove HDFS ACLs to files of
global/namespace/table directory when grant or revoke permission to
global/namespace/table.
+
+See the design doc in
link:https://issues.apache.org/jira/browse/HBASE-18659[HBASE-18659] for more
details.
+
+ Configuration to use this feature
+
+ * Firstly, make sure that HDFS ACLs is enabled and umask is set to 027
+
+dfs.namenode.acls.enabled = true
+fs.permissions.umask-mode = 027
+
+
+ * Add master coprocessor, please make sure the
SnapshotScannerHDFSAclController is configured after AccessController
+
+hbase.coprocessor.master.classes =
"org.apache.hadoop.hbase.security.access.AccessController
+,org.apache.hadoop.hbase.security.access.SnapshotScannerHDFSAclController"
+
+
+ * Enable this feature
+
+hbase.acl.sync.to.hdfs.enable=true
+
+
+ * Modify table scheme
[GitHub] [hbase] openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature
openinx commented on a change in pull request #496: HBASE-22625 documet use
scan snapshot feature
URL: https://github.com/apache/hbase/pull/496#discussion_r314965370
##
File path: src/main/asciidoc/_chapters/snapshot_scanner.adoc
##
@@ -0,0 +1,138 @@
+
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+[[snapshot_scanner]]
+== Scan over snapshot
+:doctype: book
+:numbered:
+:toc: left
+:icons: font
+:experimental:
+:toc: left
+:source-language: java
+
+In HBase, scan a table costs many CPU, memory... resources. Luckily, HBase
provides a TableSnapshotScanner and TableSnapshotInputFormat (introduced by
link:https://issues.apache.org/jira/browse/HBASE-8369[HBASE-8369]), which
performs a scan over snapshot files.
+By this way, we can bypasse HBase servers, and access the underlying files
directly to provide maximum performance. And can also be used with offline
HBase with in-place or exported snapshot files.
+
+To read from snapshot files directly from the file system, the user must have
sufficient permissions to access snapshot and reference data files.
+
+=== TableSnapshotScanner
+
+TableSnapshotScanner provide a way to do single client side scan over snapshot
files.
+When use TableSnapshotScanner, we must specify a temporary directory to copy
the snapshot files into. Current user should have write permissions to this
directory, and this should not be a subdirectory of rootdir. The scanner
deletes the contents of the directory once the scanner is closed.
+
+.Use TableSnapshotScanner
+
+[source,java]
+
+Path restoreDir = new Path("XX"); // restore dir should not be a subdirectory
HBase rootdir
+Scan scan = new Scan();
+try (TableSnapshotScanner scanner = new TableSnapshotScanner(conf, restoreDir,
snapshotName, scan)) {
+Result result = scanner.next();
+while (result != null) {
+...
+result = scanner.next();
+}
+}
+
+
+
+=== TableSnapshotInputFormat
+TableSnapshotInputFormat provide a way to scan over snapshot files in a
MapReduce job.
+
+.Use TableSnapshotInputFormat
+
+[source,java]
+
+Job job = new Job(conf);
+Path restoreDir = new Path("XX"); // restore dir should not be a subdirectory
HBase rootdir
Review comment:
a subdirectory of hbase.rootdir
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature
openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#discussion_r314965340 ## File path: src/main/asciidoc/_chapters/snapshot_scanner.adoc ## @@ -0,0 +1,138 @@ + +/** + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + + +[[snapshot_scanner]] +== Scan over snapshot +:doctype: book +:numbered: +:toc: left +:icons: font +:experimental: +:toc: left +:source-language: java + +In HBase, scan a table costs many CPU, memory... resources. Luckily, HBase provides a TableSnapshotScanner and TableSnapshotInputFormat (introduced by link:https://issues.apache.org/jira/browse/HBASE-8369[HBASE-8369]), which performs a scan over snapshot files. Review comment: scan a table costs many CPU, memory... resources -> scanning a big table will put tremendous pressure on the cluster. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature
openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#discussion_r314965238 ## File path: src/main/asciidoc/_chapters/snapshot_scanner.adoc ## @@ -0,0 +1,138 @@ + +/** + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + + +[[snapshot_scanner]] +== Scan over snapshot +:doctype: book +:numbered: +:toc: left +:icons: font +:experimental: +:toc: left +:source-language: java + +In HBase, scan a table costs many CPU, memory... resources. Luckily, HBase provides a TableSnapshotScanner and TableSnapshotInputFormat (introduced by link:https://issues.apache.org/jira/browse/HBASE-8369[HBASE-8369]), which performs a scan over snapshot files. +By this way, we can bypasse HBase servers, and access the underlying files directly to provide maximum performance. And can also be used with offline HBase with in-place or exported snapshot files. + +To read from snapshot files directly from the file system, the user must have sufficient permissions to access snapshot and reference data files. + +=== TableSnapshotScanner + +TableSnapshotScanner provide a way to do single client side scan over snapshot files. +When use TableSnapshotScanner, we must specify a temporary directory to copy the snapshot files into. Current user should have write permissions to this directory, and this should not be a subdirectory of rootdir. The scanner deletes the contents of the directory once the scanner is closed. Review comment: rootdir -> hbase.rootdir This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature
openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#discussion_r314965269 ## File path: src/main/asciidoc/_chapters/snapshot_scanner.adoc ## @@ -0,0 +1,138 @@ + +/** + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + + +[[snapshot_scanner]] +== Scan over snapshot +:doctype: book +:numbered: +:toc: left +:icons: font +:experimental: +:toc: left +:source-language: java + +In HBase, scan a table costs many CPU, memory... resources. Luckily, HBase provides a TableSnapshotScanner and TableSnapshotInputFormat (introduced by link:https://issues.apache.org/jira/browse/HBASE-8369[HBASE-8369]), which performs a scan over snapshot files. +By this way, we can bypasse HBase servers, and access the underlying files directly to provide maximum performance. And can also be used with offline HBase with in-place or exported snapshot files. Review comment: bypasse -> bypass This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature
openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#discussion_r314965281 ## File path: src/main/asciidoc/_chapters/snapshot_scanner.adoc ## @@ -0,0 +1,138 @@ + +/** + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + + +[[snapshot_scanner]] +== Scan over snapshot +:doctype: book +:numbered: +:toc: left +:icons: font +:experimental: +:toc: left +:source-language: java + +In HBase, scan a table costs many CPU, memory... resources. Luckily, HBase provides a TableSnapshotScanner and TableSnapshotInputFormat (introduced by link:https://issues.apache.org/jira/browse/HBASE-8369[HBASE-8369]), which performs a scan over snapshot files. +By this way, we can bypasse HBase servers, and access the underlying files directly to provide maximum performance. And can also be used with offline HBase with in-place or exported snapshot files. Review comment: files -> HFiles This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd merged pull request #503: HBASE-22870 reflection fails to access a private nested class
Reidd merged pull request #503: HBASE-22870 reflection fails to access a private nested class URL: https://github.com/apache/hbase/pull/503 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] openinx commented on issue #494: HBASE-22380 break circle replication when doing bulkload
openinx commented on issue #494: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/494#issuecomment-522283367 OK, we have added the UT... Will take a look This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
openinx commented on a change in pull request #479: HBASE-22802 Avoid temp
ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/479#discussion_r314965000
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/nio/CompositeRefCnt.java
##
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.nio;
+
+import java.util.Optional;
+import org.apache.hadoop.hbase.io.ByteBuffAllocator.Recycler;
+import org.apache.yetus.audience.InterfaceAudience;
+import
org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;
+import org.apache.hbase.thirdparty.io.netty.util.ReferenceCounted;
+
+/**
+ * Exclusive HFileBlock use this to summarize RPC refcount, see HBASE-22802
+ */
+@InterfaceAudience.Private
+public class CompositeRefCnt extends RefCnt {
+
+ private Optional innerRefCnt;
+
+ public CompositeRefCnt(Recycler recycler) {
+super(recycler);
+ }
+
+ public CompositeRefCnt(RefCnt orignal, RefCnt inner) {
+super(orignal.getRecycler());
+this.innerRefCnt = Optional.ofNullable(inner);
+ }
+
+ @VisibleForTesting
+ public Optional getInnerRefCnt() {
+return this.innerRefCnt;
+ }
+
+ @Override
+ public boolean release() {
+boolean innerRes = true;
+if (innerRefCnt.isPresent()) {
+ innerRes = innerRefCnt.get().release();
+}
+return super.release() && innerRes;
+ }
+
+ @Override
+ public ReferenceCounted retain() {
+if (innerRefCnt.isPresent()) {
Review comment:
```
innerRefCnt.map(innerRefCnt::retain).orElse(super.retain);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
openinx commented on a change in pull request #479: HBASE-22802 Avoid temp
ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/479#discussion_r314965005
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/nio/MultiByteBuff.java
##
@@ -53,6 +55,22 @@
private int markedItemIndex = -1;
private final int[] itemBeginPos;
+ private Iterator buffsIterator = new Iterator() {
+@Override
+public boolean hasNext() {
+ return curItemIndex < limitedItemIndex ||
+ (curItemIndex == limitedItemIndex &&
items[curItemIndex].hasRemaining());
Review comment:
Seems good now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
openinx commented on a change in pull request #479: HBASE-22802 Avoid temp
ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/479#discussion_r314964870
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/nio/ByteBuff.java
##
@@ -78,6 +79,14 @@ public boolean release() {
return refCnt.release();
}
+ public RefCnt getRefCnt() {
+return this.refCnt;
+ }
+
+ public void setRefCnt(RefCnt refCnt) {
Review comment:
I think setRefCnt for a given ByteBuff is dangerous ? because its previous
recycler will be lost, so better not to expose this method as public ? We have
one similar issue before, see:
```
/**
* In theory, the upstream should never construct an ByteBuff by passing
an given refCnt, so
* please don't use this public method in other place. Make the method
public here because the
* BucketEntry#wrapAsCacheable in hbase-server module will use its own
refCnt and ByteBuffers from
* IOEngine to composite an HFileBlock's ByteBuff, we didn't find a better
way so keep the public
* way here.
*/
public static ByteBuff wrap(ByteBuffer[] buffers, RefCnt refCnt) {
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#discussion_r314965110 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/nio/CompositeRefCnt.java ## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.nio; + +import java.util.Optional; +import org.apache.hadoop.hbase.io.ByteBuffAllocator.Recycler; +import org.apache.yetus.audience.InterfaceAudience; +import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting; +import org.apache.hbase.thirdparty.io.netty.util.ReferenceCounted; + +/** + * Exclusive HFileBlock use this to summarize RPC refcount, see HBASE-22802 + */ Review comment: BTW, seems we needn't consider the atomic for two refCnt#release or refCnt#retain This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
openinx commented on a change in pull request #479: HBASE-22802 Avoid temp
ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/479#discussion_r314964982
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/nio/CompositeRefCnt.java
##
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.nio;
+
+import java.util.Optional;
+import org.apache.hadoop.hbase.io.ByteBuffAllocator.Recycler;
+import org.apache.yetus.audience.InterfaceAudience;
+import
org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;
+import org.apache.hbase.thirdparty.io.netty.util.ReferenceCounted;
+
+/**
+ * Exclusive HFileBlock use this to summarize RPC refcount, see HBASE-22802
+ */
+@InterfaceAudience.Private
+public class CompositeRefCnt extends RefCnt {
+
+ private Optional innerRefCnt;
+
+ public CompositeRefCnt(Recycler recycler) {
+super(recycler);
+ }
+
+ public CompositeRefCnt(RefCnt orignal, RefCnt inner) {
+super(orignal.getRecycler());
+this.innerRefCnt = Optional.ofNullable(inner);
+ }
+
+ @VisibleForTesting
+ public Optional getInnerRefCnt() {
+return this.innerRefCnt;
+ }
+
+ @Override
+ public boolean release() {
+boolean innerRes = true;
Review comment:
Just the following (not compile, should be similar):
```
return super.release() && innerRefCnt.map(innerRefCnt::release).orElse(true);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#discussion_r314964906 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/nio/CompositeRefCnt.java ## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.nio; + +import java.util.Optional; +import org.apache.hadoop.hbase.io.ByteBuffAllocator.Recycler; +import org.apache.yetus.audience.InterfaceAudience; +import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting; +import org.apache.hbase.thirdparty.io.netty.util.ReferenceCounted; + +/** + * Exclusive HFileBlock use this to summarize RPC refcount, see HBASE-22802 + */ Review comment: The javadoc need more detail to explain while we need the CompositeRefCnt I think, please explain the relationship between BucketEntry & HFIleBlock This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
openinx commented on a change in pull request #479: HBASE-22802 Avoid temp
ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/479#discussion_r314965031
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/nio/MultiByteBuff.java
##
@@ -53,6 +55,22 @@
private int markedItemIndex = -1;
private final int[] itemBeginPos;
+ private Iterator buffsIterator = new Iterator() {
+@Override
+public boolean hasNext() {
+ return curItemIndex < limitedItemIndex ||
+ (curItemIndex == limitedItemIndex &&
items[curItemIndex].hasRemaining());
+}
+
+@Override
+
@edu.umd.cs.findbugs.annotations.SuppressWarnings(value="IT_NO_SUCH_ELEMENT",
Review comment:
I think here can throw the NoSuchElementException if curItemIndex exceed ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop
Apache-HBase commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-522282837 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 72 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 2 | No case conflicting files found. | | 0 | shelldocs | 2 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 1 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 22 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 37 | Maven dependency ordering for branch | | +1 | mvninstall | 367 | master passed | | +1 | compile | 176 | master passed | | +1 | checkstyle | 154 | master passed | | +1 | shadedjars | 275 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 187 | master passed | | 0 | spotbugs | 27 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 27 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 306 | the patch passed | | +1 | compile | 200 | the patch passed | | +1 | javac | 200 | the patch passed | | +1 | checkstyle | 151 | the patch passed | | +1 | shellcheck | 1 | There were no new shellcheck issues. | | +1 | whitespace | 1 | The patch has no whitespace issues. | | +1 | xml | 4 | The patch has no ill-formed XML file. | | +1 | shadedjars | 309 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 991 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 346 | the patch passed | | 0 | findbugs | 28 | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | -1 | unit | 17916 | root in the patch failed. | | +1 | asflicense | 330 | The patch does not generate ASF License warnings. | | | | 24633 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/24/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/476 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux b4729af36153 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476/out/precommit/personality/provided.sh | | git revision | master / 836f26976e | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/24/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/24/testReport/ | | Max. process+thread count | 5041 (vs. ulimit of 1) | | modules | C: hbase-hbtop . hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/24/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-522282693 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 69 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 33 | Maven dependency ordering for branch | | +1 | mvninstall | 361 | master passed | | +1 | compile | 103 | master passed | | +1 | checkstyle | 109 | master passed | | +1 | shadedjars | 272 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 82 | master passed | | 0 | spotbugs | 261 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 376 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 350 | the patch passed | | +1 | compile | 103 | the patch passed | | +1 | javac | 103 | the patch passed | | -1 | checkstyle | 77 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 321 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1050 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 74 | the patch passed | | -1 | findbugs | 61 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 174 | hbase-common in the patch passed. | | -1 | unit | 19307 | hbase-server in the patch failed. | | +1 | unit | 541 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 68 | The patch does not generate ASF License warnings. | | | | 24378 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.client.TestAsyncTableBatch | | | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/55/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3c59e50ae1a7 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / 836f26976e | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/55/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/55/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/55/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/55/testReport/ | | Max. process+thread count | 4633 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/55/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To
[GitHub] [hbase] Apache-HBase commented on issue #503: HBASE-22870 reflection fails to access a private nested class
Apache-HBase commented on issue #503: HBASE-22870 reflection fails to access a private nested class URL: https://github.com/apache/hbase/pull/503#issuecomment-522281842 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 78 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 331 | master passed | | +1 | compile | 56 | master passed | | +1 | checkstyle | 76 | master passed | | +1 | shadedjars | 313 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | master passed | | 0 | spotbugs | 289 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 286 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 314 | the patch passed | | +1 | compile | 58 | the patch passed | | +1 | javac | 58 | the patch passed | | +1 | checkstyle | 78 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 325 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1008 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 53 | the patch passed | | +1 | findbugs | 280 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 19217 | hbase-server in the patch failed. | | +1 | asflicense | 147 | The patch does not generate ASF License warnings. | | | | 23212 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.tool.TestBulkLoadHFiles | | | hadoop.hbase.client.TestRestoreSnapshotFromClientClone | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | | hadoop.hbase.client.TestAsyncTableAdminApi | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/503 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 50e298ed5712 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-503/out/precommit/personality/provided.sh | | git revision | master / 836f26976e | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/7/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/7/testReport/ | | Max. process+thread count | 4701 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/7/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#issuecomment-522281000 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 103 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 41 | Maven dependency ordering for branch | | +1 | mvninstall | 434 | master passed | | +1 | compile | 103 | master passed | | +1 | checkstyle | 134 | master passed | | +1 | shadedjars | 373 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 71 | master passed | | 0 | spotbugs | 331 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 395 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 19 | Maven dependency ordering for patch | | +1 | mvninstall | 405 | the patch passed | | +1 | compile | 96 | the patch passed | | +1 | javac | 96 | the patch passed | | +1 | checkstyle | 32 | hbase-common: The patch generated 0 new + 48 unchanged - 2 fixed = 48 total (was 50) | | -1 | checkstyle | 101 | hbase-server: The patch generated 1 new + 48 unchanged - 0 fixed = 49 total (was 48) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 372 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1228 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 67 | the patch passed | | +1 | findbugs | 418 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 210 | hbase-common in the patch passed. | | -1 | unit | 16694 | hbase-server in the patch failed. | | +1 | asflicense | 58 | The patch does not generate ASF License warnings. | | | | 21857 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.client.TestFromClientSide | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/23/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/479 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 6f607b6ef315 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-479/out/precommit/personality/provided.sh | | git revision | master / 836f26976e | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/23/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/23/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/23/testReport/ | | Max. process+thread count | 4899 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/23/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes… URL: https://github.com/apache/hbase/pull/446#issuecomment-522280406 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 292 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 445 | master passed | | +1 | compile | 72 | master passed | | +1 | checkstyle | 103 | master passed | | +1 | shadedjars | 367 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 45 | master passed | | 0 | spotbugs | 307 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 305 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 381 | the patch passed | | +1 | compile | 67 | the patch passed | | +1 | javac | 67 | the patch passed | | +1 | checkstyle | 95 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 356 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1256 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 40 | the patch passed | | +1 | findbugs | 310 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 16576 | hbase-server in the patch failed. | | +1 | asflicense | 34 | The patch does not generate ASF License warnings. | | | | 21233 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/53/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/446 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9dda8446572b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-446/out/precommit/personality/provided.sh | | git revision | master / 836f26976e | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/53/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/53/testReport/ | | Max. process+thread count | 4563 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/53/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility
Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/477#issuecomment-522280250 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 46 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 319 | master passed | | +1 | compile | 54 | master passed | | +1 | checkstyle | 82 | master passed | | +1 | shadedjars | 282 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | master passed | | 0 | spotbugs | 243 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 241 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 309 | the patch passed | | +1 | compile | 52 | the patch passed | | +1 | javac | 52 | the patch passed | | +1 | checkstyle | 81 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 274 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 934 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 238 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 17607 | hbase-server in the patch failed. | | -1 | asflicense | 23 | The patch generated 22 ASF License warnings. | | | | 20974 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotFromClientWithRegionReplicas | | | hadoop.hbase.regionserver.TestRegionServerAbortTimeout | | | hadoop.hbase.client.TestAsyncTable | | | hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService | | | hadoop.hbase.quotas.TestMasterQuotasObserver | | | hadoop.hbase.quotas.TestLowLatencySpaceQuotas | | | hadoop.hbase.coprocessor.TestCoprocessorMetrics | | | hadoop.hbase.client.TestCIGetRpcTimeout | | | hadoop.hbase.ipc.TestNettyRpcServer | | | hadoop.hbase.TestIOFencing | | | hadoop.hbase.regionserver.TestRegionServerHostname | | | hadoop.hbase.replication.TestSerialReplicationFailover | | | hadoop.hbase.client.TestAsyncRegionLocator | | | hadoop.hbase.client.TestAdmin | | | hadoop.hbase.client.TestCloneSnapshotFromClientError | | | hadoop.hbase.master.TestShutdownBackupMaster | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.coprocessor.TestCoprocessorStop | | | hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalCopyToRemote | | | hadoop.hbase.coprocessor.TestOpenTableInCoprocessor | | | hadoop.hbase.client.TestAsyncTableScanner | | | hadoop.hbase.client.TestAsyncTableLocatePrefetch | | | hadoop.hbase.replication.TestSyncReplicationRemoveRemoteWAL | | | hadoop.hbase.TestFullLogReconstruction | | | hadoop.hbase.replication.TestSyncReplicationStandbyKillRS | | | hadoop.hbase.client.TestAppendFromClientSide | | | hadoop.hbase.coprocessor.TestRegionObserverForAddingMutationsFromCoprocessors | | | hadoop.hbase.master.assignment.TestModifyTableWhileMerging | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.TestMetaTableAccessor | | | hadoop.hbase.security.access.TestAccessController2 | | | hadoop.hbase.master.procedure.TestDisableTableProcedure | | | hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL | | | hadoop.hbase.regionserver.TestOpenSeqNumUnexpectedIncrease | | | hadoop.hbase.TestMovedRegionsCleaner | | | hadoop.hbase.client.TestAsyncReplicationAdminApi | | | hadoop.hbase.TestAcidGuaranteesWithBasicPolicy | | | hadoop.hbase.client.TestRestoreSnapshotFromClientGetCompactionState | | | hadoop.hbase.ipc.TestRpcClientLeaks | | | hadoop.hbase.replication.regionserver.TestSerialReplicationChecker | | | hadoop.hbase.replication.TestNamespaceReplication | | | hadoop.hbase.client.TestRestoreSnapshotFromClientSchemaChange | | | hadoop.hbase.coprocessor.TestRegionObserverInterface | | | hadoop.hbase.regionserver.TestClearRegionBlockCache | | | hadoop.hbase.client.TestResultFromCoprocessor | | | hadoop.hbase.master.TestGetInfoPort | | | hadoop.hbase.replication.TestReplicationWithTags | | | hadoop.hbase.io.encoding.TestChangingEncoding | | |
[GitHub] [hbase] Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-522279295 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 57 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 434 | master passed | | +1 | compile | 77 | master passed | | +1 | checkstyle | 107 | master passed | | +1 | shadedjars | 381 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 45 | master passed | | 0 | spotbugs | 340 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 336 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 415 | the patch passed | | +1 | compile | 67 | the patch passed | | +1 | javac | 67 | the patch passed | | +1 | checkstyle | 97 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 353 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1190 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 42 | the patch passed | | +1 | findbugs | 337 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 15149 | hbase-server in the patch failed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 19578 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAsyncTableAdminApi3 | | | hadoop.hbase.client.TestMobSnapshotCloneIndependence | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/30/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/468 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 03170b6897ec 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh | | git revision | master / 836f26976e | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/30/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/30/testReport/ | | Max. process+thread count | 4915 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/30/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation
Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation URL: https://github.com/apache/hbase/pull/478#issuecomment-522279090 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 68 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 334 | master passed | | +1 | compile | 79 | master passed | | +1 | checkstyle | 108 | master passed | | +1 | shadedjars | 304 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 60 | master passed | | 0 | spotbugs | 259 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 327 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 340 | the patch passed | | +1 | compile | 79 | the patch passed | | +1 | javac | 79 | the patch passed | | +1 | checkstyle | 107 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 289 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1067 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 54 | the patch passed | | +1 | findbugs | 328 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 99 | hbase-client in the patch passed. | | -1 | unit | 15159 | hbase-server in the patch failed. | | +1 | asflicense | 48 | The patch does not generate ASF License warnings. | | | | 19331 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.client.TestFromClientSide | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/21/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/478 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b77b41203ef7 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-478/out/precommit/personality/provided.sh | | git revision | master / 836f26976e | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/21/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/21/testReport/ | | Max. process+thread count | 5195 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/21/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-522278730 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 62 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 68 | Maven dependency ordering for branch | | +1 | mvninstall | 313 | master passed | | +1 | compile | 76 | master passed | | +1 | checkstyle | 104 | master passed | | +1 | shadedjars | 277 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 56 | master passed | | 0 | spotbugs | 240 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 304 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 296 | the patch passed | | +1 | compile | 75 | the patch passed | | +1 | javac | 75 | the patch passed | | +1 | checkstyle | 100 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 271 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 922 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 54 | the patch passed | | +1 | findbugs | 328 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 112 | hbase-client in the patch passed. | | -1 | unit | 14852 | hbase-server in the patch failed. | | +1 | asflicense | 49 | The patch does not generate ASF License warnings. | | | | 18720 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotCloneIndependence | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/109/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c74f60cd080c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / 836f26976e | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/109/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/109/testReport/ | | Max. process+thread count | 4818 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/109/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22871) Move the DirScanPool out and do not use static field
[
https://issues.apache.org/jira/browse/HBASE-22871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909852#comment-16909852
]
Hudson commented on HBASE-22871:
Results for branch branch-2
[build #2175 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2175/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2175//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2175//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2175//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move the DirScanPool out and do not use static field
>
>
> Key: HBASE-22871
> URL: https://issues.apache.org/jira/browse/HBASE-22871
> Project: HBase
> Issue Type: Improvement
> Components: master
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> The current implementation is a bit ugly, the onConfigurationChange is an
> instance method but it writes to a static field and cause a findbugs warning.
> I think we can just put the DirScanPool in HMaster and pass it when
> constructing Cleaners...
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22871) Move the DirScanPool out and do not use static field
[
https://issues.apache.org/jira/browse/HBASE-22871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909850#comment-16909850
]
Hudson commented on HBASE-22871:
Results for branch branch-2.2
[build #523 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/523/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/523//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/523//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/523//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move the DirScanPool out and do not use static field
>
>
> Key: HBASE-22871
> URL: https://issues.apache.org/jira/browse/HBASE-22871
> Project: HBase
> Issue Type: Improvement
> Components: master
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> The current implementation is a bit ugly, the onConfigurationChange is an
> instance method but it writes to a static field and cause a findbugs warning.
> I think we can just put the DirScanPool in HMaster and pass it when
> constructing Cleaners...
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)
Apache-HBase commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#issuecomment-522277530 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | 0 | mvndep | 37 | Maven dependency ordering for branch | | +1 | mvninstall | 352 | master passed | | +1 | compile | 431 | master passed | | +1 | shadedjars | 288 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 303 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 327 | the patch passed | | +1 | compile | 458 | the patch passed | | +1 | javac | 458 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 20 | The patch has no ill-formed XML file. | | +1 | shadedjars | 296 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 992 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 286 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 173 | hbase-common in the patch passed. | | +1 | unit | 33 | hbase-hadoop2-compat in the patch passed. | | +1 | unit | 48 | hbase-zookeeper in the patch passed. | | +1 | unit | 63 | hbase-http in the patch passed. | | +1 | unit | 216 | hbase-procedure in the patch passed. | | +1 | unit | 8202 | hbase-server in the patch passed. | | +1 | unit | 994 | hbase-mapreduce in the patch passed. | | +1 | unit | 55 | hbase-testing-util in the patch passed. | | +1 | unit | 221 | hbase-thrift in the patch passed. | | +1 | unit | 434 | hbase-shell in the patch passed. | | +1 | unit | 228 | hbase-endpoint in the patch passed. | | +1 | unit | 888 | hbase-backup in the patch passed. | | +1 | unit | 66 | hbase-it in the patch passed. | | +1 | unit | 281 | hbase-rest in the patch passed. | | +1 | unit | 106 | hbase-examples in the patch passed. | | +1 | unit | 35 | hbase-external-blockcache in the patch passed. | | +1 | unit | 39 | hbase-shaded-testing-util in the patch passed. | | +1 | asflicense | 489 | The patch does not generate ASF License warnings. | | | | 16936 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/505 | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile | | uname | Linux 6db552f95121 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh | | git revision | master / 836f26976e | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/4/testReport/ | | Max. process+thread count | 5410 (vs. ulimit of 1) | | modules | C: hbase-common hbase-hadoop2-compat hbase-zookeeper hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload
Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/494#issuecomment-522276581 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 56 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ branch-2 Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for branch | | +1 | mvninstall | 347 | branch-2 passed | | +1 | compile | 110 | branch-2 passed | | +1 | checkstyle | 123 | branch-2 passed | | +1 | shadedjars | 250 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 69 | branch-2 passed | | 0 | spotbugs | 207 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 429 | branch-2 passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 292 | the patch passed | | +1 | compile | 110 | the patch passed | | +1 | cc | 110 | the patch passed | | +1 | javac | 110 | the patch passed | | -1 | checkstyle | 79 | hbase-server: The patch generated 1 new + 302 unchanged - 0 fixed = 303 total (was 302) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 275 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1020 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | hbaseprotoc | 100 | the patch passed | | +1 | javadoc | 63 | the patch passed | | -1 | findbugs | 209 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 36 | hbase-protocol-shaded in the patch passed. | | +1 | unit | 212 | hbase-client in the patch passed. | | -1 | unit | 13020 | hbase-server in the patch failed. | | +1 | asflicense | 66 | The patch does not generate ASF License warnings. | | | | 17587 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 257] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/13/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/494 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc | | uname | Linux 7a88b9d02740 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh | | git revision | branch-2 / c295fd7c6a | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/13/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/13/artifact/out/new-findbugs-hbase-server.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/13/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/13/testReport/ | | Max. process+thread count | 4448 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/13/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #503: HBASE-22870 reflection fails to access a private nested class
Apache-HBase commented on issue #503: HBASE-22870 reflection fails to access a private nested class URL: https://github.com/apache/hbase/pull/503#issuecomment-522273240 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 67 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 318 | master passed | | +1 | compile | 53 | master passed | | +1 | checkstyle | 72 | master passed | | +1 | shadedjars | 266 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 34 | master passed | | 0 | spotbugs | 260 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 257 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 306 | the patch passed | | +1 | compile | 57 | the patch passed | | +1 | javac | 57 | the patch passed | | +1 | checkstyle | 75 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 267 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 900 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 273 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 18654 | hbase-server in the patch failed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 22040 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalCopyToRemote | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.tool.TestBulkLoadHFiles | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/503 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b525c8d8ef6b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-503/out/precommit/personality/provided.sh | | git revision | master / 8cb531f207 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/6/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/6/testReport/ | | Max. process+thread count | 5067 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop
Apache-HBase commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-522273261 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 157 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 2 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 22 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 36 | Maven dependency ordering for branch | | +1 | mvninstall | 373 | master passed | | +1 | compile | 173 | master passed | | +1 | checkstyle | 165 | master passed | | +1 | shadedjars | 301 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 217 | master passed | | 0 | spotbugs | 30 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 30 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 377 | the patch passed | | +1 | compile | 215 | the patch passed | | +1 | javac | 215 | the patch passed | | +1 | checkstyle | 176 | the patch passed | | +1 | shellcheck | 1 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 4 | The patch has no ill-formed XML file. | | +1 | shadedjars | 323 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1225 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 213 | the patch passed | | 0 | findbugs | 28 | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | -1 | unit | 15458 | root in the patch failed. | | +1 | asflicense | 116 | The patch does not generate ASF License warnings. | | | | 22027 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.client.TestFromClientSide | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/23/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/476 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux ff1f5bc497d4 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476/out/precommit/personality/provided.sh | | git revision | master / 8cb531f207 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/23/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/23/testReport/ | | Max. process+thread count | 4712 (vs. ulimit of 1) | | modules | C: hbase-hbtop . hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/23/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-522273212 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 77 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 36 | Maven dependency ordering for branch | | +1 | mvninstall | 301 | master passed | | +1 | compile | 101 | master passed | | +1 | checkstyle | 109 | master passed | | +1 | shadedjars | 295 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 77 | master passed | | 0 | spotbugs | 258 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 351 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 370 | the patch passed | | +1 | compile | 101 | the patch passed | | +1 | javac | 101 | the patch passed | | -1 | checkstyle | 70 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 266 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1048 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 80 | the patch passed | | -1 | findbugs | 66 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 173 | hbase-common in the patch passed. | | -1 | unit | 17121 | hbase-server in the patch failed. | | +1 | unit | 494 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 79 | The patch does not generate ASF License warnings. | | | | 21978 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Failed junit tests | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.tool.TestBulkLoadHFiles | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/54/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 166f241928a0 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / 8cb531f207 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/54/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/54/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/54/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/54/testReport/ | | Max. process+thread count | 4986 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/54/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,
[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes… URL: https://github.com/apache/hbase/pull/446#issuecomment-522273203 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 67 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 317 | master passed | | +1 | compile | 54 | master passed | | +1 | checkstyle | 72 | master passed | | +1 | shadedjars | 264 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 35 | master passed | | 0 | spotbugs | 261 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 260 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 299 | the patch passed | | +1 | compile | 58 | the patch passed | | +1 | javac | 58 | the patch passed | | +1 | checkstyle | 73 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 264 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 897 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 35 | the patch passed | | +1 | findbugs | 276 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 18618 | hbase-server in the patch failed. | | +1 | asflicense | 30 | The patch does not generate ASF License warnings. | | | | 21968 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.tool.TestBulkLoadHFiles | | | hadoop.hbase.replication.TestReplicationDroppedTables | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.replication.TestReplicationSyncUpTool | | | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/52/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/446 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 277ff54e9c04 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-446/out/precommit/personality/provided.sh | | git revision | master / 8cb531f207 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/52/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/52/testReport/ | | Max. process+thread count | 4966 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/52/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/499#issuecomment-522272907 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 1 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 335 | master passed | | +1 | compile | 51 | master passed | | +1 | checkstyle | 78 | master passed | | +1 | shadedjars | 273 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 35 | master passed | | 0 | spotbugs | 245 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 243 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 300 | the patch passed | | +1 | compile | 52 | the patch passed | | +1 | javac | 52 | the patch passed | | +1 | checkstyle | 73 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 282 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 921 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 255 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8137 | hbase-server in the patch passed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 11505 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/499 | | JIRA Issue | HBASE-22601 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d7eb0524403d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-499/out/precommit/personality/provided.sh | | git revision | master / 836f26976e | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/10/testReport/ | | Max. process+thread count | 4806 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/10/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.
[
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909833#comment-16909833
]
Hadoop QA commented on HBASE-22601:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
40s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 1s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
33s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
5s{color} | {color:blue} Used deprecated FindBugs config; considering switching
to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
42s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 21s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
15s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}135m
37s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}191m 45s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/10/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/499 |
| JIRA Issue | HBASE-22601 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux d7eb0524403d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-499/out/precommit/personality/provided.sh
|
| git revision | master / 836f26976e |
| Default Java | 1.8.0_181 |
| Test Results |
[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#issuecomment-522272704 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 97 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 36 | Maven dependency ordering for branch | | +1 | mvninstall | 306 | master passed | | +1 | compile | 79 | master passed | | +1 | checkstyle | 99 | master passed | | +1 | shadedjars | 298 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 59 | master passed | | 0 | spotbugs | 250 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 300 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 326 | the patch passed | | +1 | compile | 82 | the patch passed | | +1 | javac | 82 | the patch passed | | +1 | checkstyle | 24 | hbase-common: The patch generated 0 new + 48 unchanged - 2 fixed = 48 total (was 50) | | -1 | checkstyle | 70 | hbase-server: The patch generated 1 new + 48 unchanged - 0 fixed = 49 total (was 48) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 268 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1056 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 51 | the patch passed | | +1 | findbugs | 304 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 186 | hbase-common in the patch passed. | | -1 | unit | 17391 | hbase-server in the patch failed. | | +1 | asflicense | 61 | The patch does not generate ASF License warnings. | | | | 21486 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.client.TestAsyncTableGetMultiThreaded | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/22/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/479 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f43a542a536d 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-479/out/precommit/personality/provided.sh | | git revision | master / 8cb531f207 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/22/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/22/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/22/testReport/ | | Max. process+thread count | 4996 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/22/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation
Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation URL: https://github.com/apache/hbase/pull/478#issuecomment-522272383 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 102 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 72 | Maven dependency ordering for branch | | +1 | mvninstall | 395 | master passed | | +1 | compile | 91 | master passed | | +1 | checkstyle | 114 | master passed | | +1 | shadedjars | 327 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 66 | master passed | | 0 | spotbugs | 286 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 364 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 372 | the patch passed | | +1 | compile | 106 | the patch passed | | +1 | javac | 106 | the patch passed | | +1 | checkstyle | 134 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 306 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1023 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 59 | the patch passed | | +1 | findbugs | 370 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 111 | hbase-client in the patch passed. | | -1 | unit | 16624 | hbase-server in the patch failed. | | +1 | asflicense | 47 | The patch does not generate ASF License warnings. | | | | 21128 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.io.asyncfs.TestSaslFanOutOneBlockAsyncDFSOutput | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.replication.TestReplicationSmallTests | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/20/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/478 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 907c43220ce1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-478/out/precommit/personality/provided.sh | | git revision | master / 8cb531f207 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/20/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/20/testReport/ | | Max. process+thread count | 4885 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/20/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility
Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/477#issuecomment-522272297 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 41 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 46 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 323 | master passed | | +1 | compile | 53 | master passed | | +1 | checkstyle | 82 | master passed | | +1 | shadedjars | 284 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 35 | master passed | | 0 | spotbugs | 243 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 241 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 297 | the patch passed | | +1 | compile | 54 | the patch passed | | +1 | javac | 54 | the patch passed | | +1 | checkstyle | 78 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 273 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 957 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 253 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 17618 | hbase-server in the patch failed. | | -1 | asflicense | 25 | The patch generated 19 ASF License warnings. | | | | 21029 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestReplicationStatusSourceStartedTargetStoppedNewOp | | | hadoop.hbase.regionserver.TestRegionReplicasWithRestartScenarios | | | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.fs.TestBlockReorderMultiBlocks | | | hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint | | | hadoop.hbase.TestSplitMerge | | | hadoop.hbase.replication.TestReplicationWithTags | | | hadoop.hbase.client.TestAsyncSingleRequestRpcRetryingCaller | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientSchemaChange | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.master.assignment.TestTransitRegionStateProcedure | | | hadoop.hbase.regionserver.wal.TestLogRollPeriod | | | hadoop.hbase.regionserver.wal.TestAsyncFSWAL | | | hadoop.hbase.tool.TestSecureBulkLoadHFilesSplitRecovery | | | hadoop.hbase.regionserver.TestEncryptionRandomKeying | | | hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithAbort | | | hadoop.hbase.master.procedure.TestCreateTableProcedure | | | hadoop.hbase.procedure.TestProcedureManager | | | hadoop.hbase.master.procedure.TestModifyTableProcedure | | | hadoop.hbase.master.TestMasterFailoverBalancerPersistence | | | hadoop.hbase.security.access.TestAccessController | | | hadoop.hbase.coprocessor.TestPostIncrementAndAppendBeforeWAL | | | hadoop.hbase.client.TestCIBadHostname | | | hadoop.hbase.snapshot.TestRestoreSnapshotHelper | | | hadoop.hbase.fs.TestBlockReorderBlockLocation | | | hadoop.hbase.coprocessor.TestCoprocessorStop | | | hadoop.hbase.security.visibility.TestVisibilityLabelsReplication | | | hadoop.hbase.client.TestScannerTimeout | | | hadoop.hbase.regionserver.TestClearRegionBlockCache | | | hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster | | | hadoop.hbase.coprocessor.TestPassCustomCellViaRegionObserver | | | hadoop.hbase.client.TestAsyncTableScannerCloseWhileSuspending | | | hadoop.hbase.regionserver.wal.TestAsyncLogRollPeriod | | | hadoop.hbase.security.token.TestGenerateDelegationToken | | | hadoop.hbase.client.TestRawAsyncScanCursor | | | hadoop.hbase.client.TestIncrementFromClientSideWithCoprocessor | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes | | | hadoop.hbase.client.TestGetScanPartialResult | | | hadoop.hbase.TestJMXConnectorServer | | | hadoop.hbase.replication.TestAddToSerialReplicationPeer | | | hadoop.hbase.client.TestSnapshotCloneIndependence | | | hadoop.hbase.client.TestAsyncNonMetaRegionLocator | | | hadoop.hbase.client.TestAsyncSnapshotAdminApi | | | hadoop.hbase.replication.TestSerialSyncReplication | | | hadoop.hbase.TestMetaTableAccessor | | | hadoop.hbase.master.TestSplitRegionWhileRSCrash | | | hadoop.hbase.replication.regionserver.TestSerialReplicationChecker | | |
[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.
[
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909828#comment-16909828
]
Hadoop QA commented on HBASE-22601:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
33s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
12s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
19s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
39s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
34s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
4s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 40s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
39s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}256m 9s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
49s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}311m 30s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.replication.TestReplicationProcedureRetry |
| | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
| | hadoop.hbase.client.TestAsyncTableBatch |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/9/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/500 |
| JIRA Issue | HBASE-22601 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux e02c39df67b9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[GitHub] [hbase] Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/500#issuecomment-522271158 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 72 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2 Compile Tests _ | | +1 | mvninstall | 333 | branch-2 passed | | +1 | compile | 53 | branch-2 passed | | +1 | checkstyle | 72 | branch-2 passed | | +1 | shadedjars | 259 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 33 | branch-2 passed | | 0 | spotbugs | 219 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 214 | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 290 | the patch passed | | +1 | compile | 54 | the patch passed | | +1 | javac | 54 | the patch passed | | +1 | checkstyle | 76 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 244 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 940 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 31 | the patch passed | | +1 | findbugs | 219 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 15369 | hbase-server in the patch failed. | | +1 | asflicense | 49 | The patch does not generate ASF License warnings. | | | | 18690 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestReplicationProcedureRetry | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.client.TestAsyncTableBatch | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/500 | | JIRA Issue | HBASE-22601 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e02c39df67b9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-500/out/precommit/personality/provided.sh | | git revision | branch-2 / c295fd7c6a | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/9/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/9/testReport/ | | Max. process+thread count | 4078 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/9/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-522269493 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 227 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 355 | master passed | | +1 | compile | 93 | master passed | | +1 | checkstyle | 126 | master passed | | +1 | shadedjars | 305 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 60 | master passed | | 0 | spotbugs | 277 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 352 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 348 | the patch passed | | +1 | compile | 88 | the patch passed | | +1 | javac | 88 | the patch passed | | +1 | checkstyle | 120 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 315 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1236 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 58 | the patch passed | | +1 | findbugs | 343 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 104 | hbase-client in the patch passed. | | +1 | unit | 13429 | hbase-server in the patch passed. | | +1 | asflicense | 52 | The patch does not generate ASF License warnings. | | | | 18107 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/108/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 26855b7be6fd 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / 8cb531f207 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/108/testReport/ | | Max. process+thread count | 4827 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/108/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.
[
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909826#comment-16909826
]
Hadoop QA commented on HBASE-22601:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
6s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
3s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
24s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
0s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 4s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
27s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}230m
37s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
28s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}292m 4s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=18.09.7 Server=18.09.7 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/9/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/499 |
| JIRA Issue | HBASE-22601 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 1f552b123b6a 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4
22:49:08 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-499/out/precommit/personality/provided.sh
|
| git revision | master / 8cb531f207 |
| Default Java | 1.8.0_181 |
| Test Results |
[GitHub] [hbase] Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/499#issuecomment-522268848 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 66 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 355 | master passed | | +1 | compile | 58 | master passed | | +1 | checkstyle | 90 | master passed | | +1 | shadedjars | 303 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | master passed | | 0 | spotbugs | 264 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 262 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 327 | the patch passed | | +1 | compile | 57 | the patch passed | | +1 | javac | 57 | the patch passed | | +1 | checkstyle | 86 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 300 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1024 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 267 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 13837 | hbase-server in the patch passed. | | +1 | asflicense | 28 | The patch does not generate ASF License warnings. | | | | 17524 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/499 | | JIRA Issue | HBASE-22601 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1f552b123b6a 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-499/out/precommit/personality/provided.sh | | git revision | master / 8cb531f207 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/9/testReport/ | | Max. process+thread count | 4824 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/9/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload
Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/494#issuecomment-522264687 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 49 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ branch-2 Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for branch | | +1 | mvninstall | 345 | branch-2 passed | | +1 | compile | 119 | branch-2 passed | | +1 | checkstyle | 128 | branch-2 passed | | +1 | shadedjars | 255 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 68 | branch-2 passed | | 0 | spotbugs | 206 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 438 | branch-2 passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 332 | the patch passed | | +1 | compile | 123 | the patch passed | | +1 | cc | 123 | the patch passed | | +1 | javac | 123 | the patch passed | | -1 | checkstyle | 83 | hbase-server: The patch generated 4 new + 302 unchanged - 0 fixed = 306 total (was 302) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 276 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 980 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | hbaseprotoc | 112 | the patch passed | | +1 | javadoc | 66 | the patch passed | | -1 | findbugs | 192 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 42 | hbase-protocol-shaded in the patch passed. | | +1 | unit | 200 | hbase-client in the patch passed. | | +1 | unit | 7921 | hbase-server in the patch passed. | | +1 | asflicense | 57 | The patch does not generate ASF License warnings. | | | | 12545 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/12/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/494 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc | | uname | Linux 961410b955e3 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh | | git revision | branch-2 / c295fd7c6a | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/12/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/12/artifact/out/new-findbugs-hbase-server.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/12/testReport/ | | Max. process+thread count | 4921 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/12/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations in client snapshot exceptions
Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations in client snapshot exceptions URL: https://github.com/apache/hbase/pull/487#issuecomment-522264386 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 78 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 369 | master passed | | +1 | compile | 26 | master passed | | +1 | checkstyle | 38 | master passed | | +1 | shadedjars | 319 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 26 | master passed | | 0 | spotbugs | 78 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 76 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 330 | the patch passed | | +1 | compile | 27 | the patch passed | | +1 | javac | 27 | the patch passed | | +1 | checkstyle | 36 | hbase-client: The patch generated 0 new + 0 unchanged - 13 fixed = 0 total (was 13) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 307 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1040 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 22 | hbase-client generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) | | +1 | findbugs | 76 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 106 | hbase-client in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 3295 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/15/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/487 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8c99a0638bfe 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-487/out/precommit/personality/provided.sh | | git revision | master / 836f26976e | | Default Java | 1.8.0_181 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/15/artifact/out/diff-javadoc-javadoc-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/15/testReport/ | | Max. process+thread count | 264 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/15/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-522264222 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 38 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 324 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 13 | master passed | | +1 | shadedjars | 278 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 21 | master passed | | 0 | spotbugs | 46 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 45 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 303 | the patch passed | | +1 | compile | 24 | the patch passed | | +1 | javac | 24 | the patch passed | | +1 | checkstyle | 12 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 279 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 925 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 19 | the patch passed | | +1 | findbugs | 49 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 391 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 3118 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/99/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 913ce545c378 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / 836f26976e | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/99/testReport/ | | Max. process+thread count | 4349 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/99/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException
Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/501#issuecomment-522264112 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 36 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 344 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 33 | master passed | | +1 | shadedjars | 289 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 23 | master passed | | 0 | spotbugs | 69 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 67 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 314 | the patch passed | | +1 | compile | 24 | the patch passed | | +1 | javac | 24 | the patch passed | | +1 | checkstyle | 31 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 287 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 993 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 23 | the patch passed | | +1 | findbugs | 75 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 109 | hbase-client in the patch passed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 3068 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/501 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 86a7c45dc950 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-501/out/precommit/personality/provided.sh | | git revision | master / 836f26976e | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/6/testReport/ | | Max. process+thread count | 273 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot feature
Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#issuecomment-522262288 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | @author | 1 | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 | mvninstall | 327 | master passed | | 0 | refguide | 324 | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 295 | the patch passed | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | 0 | refguide | 298 | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 | asflicense | 19 | The patch does not generate ASF License warnings. | | | | 1360 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/496 | | Optional Tests | dupname asflicense shellcheck shelldocs refguide | | uname | Linux e571ef3e09de 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-496/out/precommit/personality/provided.sh | | git revision | master / 836f26976e | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/10/artifact/out/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/10/artifact/out/patch-site/book.html | | Max. process+thread count | 96 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/10/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22873) Typo in block caching docs
[
https://issues.apache.org/jira/browse/HBASE-22873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909796#comment-16909796
]
Hudson commented on HBASE-22873:
Results for branch master
[build #1342 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1342/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1342//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1342//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1342//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Typo in block caching docs
> --
>
> Key: HBASE-22873
> URL: https://issues.apache.org/jira/browse/HBASE-22873
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Shuai Lin
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: hbase-22873.patch
>
>
> To turn off block cache for a scan, setCacheBlocks should be used, but the
> hbase book says "setCaching", which is not relevant.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22618) Provide a way to have Heterogeneous deployment
[
https://issues.apache.org/jira/browse/HBASE-22618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909792#comment-16909792
]
Wellington Chevreuil commented on HBASE-22618:
--
Latest test failures are unrelated. Had pushed it to master, but current patch
does not apply on branch-2. [~PierreZ], can you attach a branch-2 compatible
patch?
> Provide a way to have Heterogeneous deployment
> --
>
> Key: HBASE-22618
> URL: https://issues.apache.org/jira/browse/HBASE-22618
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.2.1, 2.1.6, 1.4.11, 2.1.7
>Reporter: Pierre Zemb
>Assignee: Pierre Zemb
>Priority: Major
> Attachments: HBASE-22618.master.001.patch
>
>
> Hi,
> We wouls like to open the discussion about bringing the possibility to have
> regions deployed on {color:#22}Heterogeneous deployment{color}, i.e Hbase
> cluster running different kind of hardware.
> h2. Why?
> * Cloud deployments means that we may not be able to have the same hardware
> throughout the years
> * Some tables may need special requirements such as SSD whereas others
> should be using hard-drives
> * {color:#22} {color}*in our usecase*{color:#22}(single table,
> dedicated HBase and Hadoop tuned for our usecase, good key
> distribution){color}*, the number of regions per RS was the real limit for
> us*{color:#22}.{color}
> h2. Our usecase
> We found out that *in our usecase*(single table, dedicated HBase and Hadoop
> tuned for our usecase, good key distribution)*, the number of regions per RS
> was the real limit for us*.
> Over the years, due to historical reasons and also the need to benchmark new
> machines, we ended-up with differents groups of hardware: some servers can
> handle only 180 regions, whereas the biggest can handle more than 900.
> Because of such a difference, we had to disable the LoadBalancing to avoid
> the {{roundRobinAssigmnent}}. We developed some internal tooling which are
> responsible for load balancing regions across RegionServers. That was 1.5
> year ago.
> h2. Our Proof-of-concept
> We did work on a Proof-of-concept
> [here|https://github.com/PierreZ/hbase/blob/dev/hbase14/balancer/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/HeterogeneousBalancer.java],
> and some early tests
> [here|https://github.com/PierreZ/hbase/blob/dev/hbase14/balancer/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/HeterogeneousBalancer.java],
>
> [here|https://github.com/PierreZ/hbase/blob/dev/hbase14/balancer/hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestHeterogeneousBalancerBalance.java],
> and
> [here|https://github.com/PierreZ/hbase/blob/dev/hbase14/balancer/hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestHeterogeneousBalancerRules.java].
> We wrote the balancer for our use-case, which means that:
> * there is one table
> * there is no region-replica
> * good key dispersion
> * there is no regions on master
> A rule file is loaded before balancing. It contains lines of rules. A rule is
> composed of a regexp for hostname, and a limit. For example, we could have:
>
> {quote}rs[0-9] 200
> rs1[0-9] 50
> {quote}
>
> RegionServers with hostname matching the first rules will have a limit of
> 200, and the others 50. If there's no match, a default is set.
> Thanks to the rule, we have two informations: the max number of regions for
> this cluster, and the rules for each servers. {{HeterogeneousBalancer}} will
> try to balance regions according to their capacity.
> Let's take an example. Let's say that we have 20 RS:
> * 10 RS, named through {{rs0}} to {{rs9}} loaded with 60 regions each, and
> each can handle 200 regions.
> * 10 RS, named through {{rs10}} to {{rs19}} loaded with 60 regions each, and
> each can support 50 regions.
> Based on the following rules:
>
> {quote}rs[0-9] 200
> rs1[0-9] 50
> {quote}
>
> The second group is overloaded, whereas the first group has plenty of space.
> We know that we can handle at maximum *2500 regions* (200*10 + 50*10) and we
> have currently *1200 regions* (60*20). {{HeterogeneousBalancer}} will
> understand that the cluster is *full at 48.0%* (1200/2500). Based on this
> information, we will then *try to put all the RegionServers to ~48% of load
> according to the rules.* In this case, it will move regions from the second
> group to the first.
> The balancer will:
> * compute how many regions needs to be moved. In our example, by moving 36
> regions on rs10, we could go from 120.0% to 46.0%
> * select regions with lowest data-locality
> * try to find an appropriate RS for the region. We will take the lowest
> available RS.
> h2. Other implementations and ideas
> Clay Baenziger proposed this
[GitHub] [hbase] satanson commented on issue #503: HBASE-22870 reflection fails to access a private nested class
satanson commented on issue #503: HBASE-22870 reflection fails to access a private nested class URL: https://github.com/apache/hbase/pull/503#issuecomment-522259837 commit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-522258867 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 280 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 36 | Maven dependency ordering for branch | | +1 | mvninstall | 381 | master passed | | +1 | compile | 109 | master passed | | +1 | checkstyle | 118 | master passed | | +1 | shadedjars | 304 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 82 | master passed | | 0 | spotbugs | 274 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 394 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 317 | the patch passed | | +1 | compile | 104 | the patch passed | | +1 | javac | 104 | the patch passed | | -1 | checkstyle | 76 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 311 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1008 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 72 | the patch passed | | -1 | findbugs | 58 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 174 | hbase-common in the patch passed. | | -1 | unit | 19159 | hbase-server in the patch failed. | | +1 | unit | 552 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 77 | The patch does not generate ASF License warnings. | | | | 24467 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Failed junit tests | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.tool.TestBulkLoadHFiles | | | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | | hadoop.hbase.client.TestAsyncTableAdminApi | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/53/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 002a2e0858a7 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / 7903f55c18 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/53/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/53/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/53/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/53/testReport/ | | Max. process+thread count | 5067 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output |
[GitHub] [hbase] Apache-HBase commented on issue #503: HBASE-22870 reflection fails to access a private nested class
Apache-HBase commented on issue #503: HBASE-22870 reflection fails to access a private nested class URL: https://github.com/apache/hbase/pull/503#issuecomment-522257563 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 309 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 364 | master passed | | +1 | compile | 63 | master passed | | +1 | checkstyle | 81 | master passed | | +1 | shadedjars | 326 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | master passed | | 0 | spotbugs | 286 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 284 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 321 | the patch passed | | +1 | compile | 56 | the patch passed | | +1 | javac | 56 | the patch passed | | +1 | checkstyle | 76 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 278 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1070 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 35 | the patch passed | | +1 | findbugs | 267 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 19329 | hbase-server in the patch failed. | | +1 | asflicense | 109 | The patch does not generate ASF License warnings. | | | | 23442 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.replication.TestMasterReplication | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.tool.TestBulkLoadHFiles | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | | hadoop.hbase.client.TestAsyncTableAdminApi | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/503 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 0c60b7ca88bc 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-503/out/precommit/personality/provided.sh | | git revision | master / 7903f55c18 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/5/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/5/testReport/ | | Max. process+thread count | 4602 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-503/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility
Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/477#issuecomment-522256950 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 46 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 325 | master passed | | +1 | compile | 51 | master passed | | +1 | checkstyle | 81 | master passed | | +1 | shadedjars | 281 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 35 | master passed | | 0 | spotbugs | 244 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 243 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 300 | the patch passed | | +1 | compile | 52 | the patch passed | | +1 | javac | 52 | the patch passed | | +1 | checkstyle | 80 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 273 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 928 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 249 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 19543 | hbase-server in the patch failed. | | -1 | asflicense | 25 | The patch generated 19 ASF License warnings. | | | | 22912 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.TestSplitRegionWhileRSCrash | | | hadoop.hbase.client.TestSnapshotFromClientWithRegionReplicas | | | hadoop.hbase.master.assignment.TestRegionReplicaSplit | | | hadoop.hbase.client.TestAsyncTable | | | hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver | | | hadoop.hbase.quotas.TestMasterQuotasObserver | | | hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths | | | hadoop.hbase.quotas.TestLowLatencySpaceQuotas | | | hadoop.hbase.coprocessor.TestCoprocessorMetrics | | | hadoop.hbase.client.TestTimestampsFilter | | | hadoop.hbase.client.TestCIGetRpcTimeout | | | hadoop.hbase.regionserver.TestRegionReplicasWithModifyTable | | | hadoop.hbase.client.TestMobCloneSnapshotFromClientNormal | | | hadoop.hbase.ipc.TestNettyRpcServer | | | hadoop.hbase.master.TestDeadServer | | | hadoop.hbase.TestIOFencing | | | hadoop.hbase.regionserver.TestRegionServerHostname | | | hadoop.hbase.client.TestAsyncRegionLocator | | | hadoop.hbase.client.TestSeparateClientZKCluster | | | hadoop.hbase.client.TestAdmin | | | hadoop.hbase.client.TestCloneSnapshotFromClientError | | | hadoop.hbase.TestSequenceIdMonotonicallyIncreasing | | | hadoop.hbase.regionserver.TestRegionReplicasWithRestartScenarios | | | hadoop.hbase.coprocessor.TestPassCustomCellViaRegionObserver | | | hadoop.hbase.regionserver.TestMultiLogThreshold | | | hadoop.hbase.replication.TestPerTableCFReplication | | | hadoop.hbase.client.TestScannerTimeout | | | hadoop.hbase.filter.TestFilterListOnMini | | | hadoop.hbase.replication.TestSyncReplicationRemoveRemoteWAL | | | hadoop.hbase.TestFullLogReconstruction | | | hadoop.hbase.replication.TestSyncReplicationStandbyKillRS | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.coprocessor.TestIncrementAndAppendWithNullResult | | | hadoop.hbase.TestMetaTableAccessor | | | hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithRemove | | | hadoop.hbase.security.access.TestAccessController2 | | | hadoop.hbase.master.assignment.TestTransitRegionStateProcedure | | | hadoop.hbase.regionserver.wal.TestAsyncFSWAL | | | hadoop.hbase.master.procedure.TestDisableTableProcedure | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed | | | hadoop.hbase.master.TestClusterRestartFailover | | | hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL | | | hadoop.hbase.client.TestAsyncReplicationAdminApi | | | hadoop.hbase.TestAcidGuaranteesWithBasicPolicy | | | hadoop.hbase.client.TestRestoreSnapshotFromClientGetCompactionState | | | hadoop.hbase.ipc.TestRpcClientLeaks | | | hadoop.hbase.replication.regionserver.TestSerialReplicationChecker | | | hadoop.hbase.replication.TestNamespaceReplication | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientClone | | |
[GitHub] [hbase] Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-522255010 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 71 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 459 | master passed | | +1 | compile | 70 | master passed | | +1 | checkstyle | 108 | master passed | | +1 | shadedjars | 360 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 44 | master passed | | 0 | spotbugs | 308 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 305 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 415 | the patch passed | | +1 | compile | 74 | the patch passed | | +1 | javac | 74 | the patch passed | | +1 | checkstyle | 125 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 361 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1267 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 41 | the patch passed | | +1 | findbugs | 325 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 17273 | hbase-server in the patch failed. | | +1 | asflicense | 34 | The patch does not generate ASF License warnings. | | | | 21806 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/28/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/468 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b3df9d8d9dad 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh | | git revision | master / 7903f55c18 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/28/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/28/testReport/ | | Max. process+thread count | 5095 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/28/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-22862) Region Server crash with: Added a key not lexically larger than previous
[
https://issues.apache.org/jira/browse/HBASE-22862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909770#comment-16909770
]
Alex Batyrshin edited comment on HBASE-22862 at 8/17/19 5:15 PM:
-
Error occurs on MemStore flush.
Looks like replay from WAL has no error.
Latest log dump with crash and WAL replays:
{code}
2019-08-16 09:36:40,926 FATAL [MemStoreFlusher.1] regionserver.HRegionServer:
ABORTING region server prod004,60020,1565928847135: Replay of WAL required.
Forcing server shutdown
org.apache.hadoop.hbase.DroppedSnapshotException: region:
TBL_TABLE_CODE,\x110090011599kySHLF;,1561791629538.ec69674133ba425f63cedfc686b70823.
at
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2675)
at
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2352)
at
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2314)
at
org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2200)
at org.apache.hadoop.hbase.regionserver.HRegion.flush(HRegion.java:2125)
at
org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:512)
at
org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:482)
at
org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$900(MemStoreFlusher.java:76)
at
org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:264)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.io.IOException: Added a key not lexically larger than previous.
Current cell =
\x110090013098!>ct94a/d:apd/1565936313172/DeleteColumn/vlen=0/seqid=38334251,
lastCell =
\x110090013098!>ct94a/d:apd/1565936313172/Put/vlen=12/seqid=38338239
at
org.apache.hadoop.hbase.io.hfile.AbstractHFileWriter.checkKey(AbstractHFileWriter.java:204)
at
org.apache.hadoop.hbase.io.hfile.HFileWriterV2.append(HFileWriterV2.java:279)
at
org.apache.hadoop.hbase.io.hfile.HFileWriterV3.append(HFileWriterV3.java:87)
at
org.apache.hadoop.hbase.regionserver.StoreFile$Writer.append(StoreFile.java:1127)
at
org.apache.hadoop.hbase.regionserver.StoreFlusher.performFlush(StoreFlusher.java:139)
at
org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:75)
at
org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:1003)
at
org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.flushCache(HStore.java:2523)
at
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2622)
... 9 more
2019-08-16 09:36:41,516 INFO [RS_CLOSE_REGION-prod004:60020-1]
regionserver.HRegion: Closed
TBL_TABLE_CODE,\x110090011599kySHLF;,1561791629538.ec69674133ba425f63cedfc686b70823.
2019-08-16 09:36:54,944 INFO
[RpcServer.priority.FPBQ.Fifo.handler=19,queue=1,port=60020]
regionserver.RSRpcServices: Open
TBL_TABLE_CODE,\x110090011599kySHLF;,1561791629538.ec69674133ba425f63cedfc686b70823.
2019-08-16 09:37:39,164 INFO [RS_OPEN_REGION-prod004:60020-2]
regionserver.HRegion: Replaying edits from
hdfs://motp02/hbase/default/TBL_TABLE_CODE/ec69674133ba425f63cedfc686b70823/recovered.edits/00038324857
...
2019-08-16 09:38:24,017 INFO [RS_OPEN_REGION-prod004:60020-2]
regionserver.HRegion: Replaying edits from
hdfs://motp02/hbase/default/TBL_TABLE_CODE/ec69674133ba425f63cedfc686b70823/recovered.edits/00038340778
2019-08-16 09:38:27,185 INFO [RS_OPEN_REGION-prod004:60020-2]
regionserver.HRegion: Flushing 1/1 column families, memstore=53.96 MB; WAL is
null, using passed sequenceid=38340778
2019-08-16 09:38:29,203 INFO [RS_OPEN_REGION-prod004:60020-2]
regionserver.DefaultStoreFlusher: Flushed, sequenceid=38340778, memsize=54.0 M,
hasBloomFilter=false, into tmp file
hdfs://motp02/hbase/data/default/TBL_TABLE_CODE/ec69674133ba425f63cedfc686b70823/.tmp/b8d1e9859cab41e9900b326ce5f65ab2
2019-08-16 09:38:29,258 INFO [RS_OPEN_REGION-prod004:60020-2]
regionserver.HStore: Added
hdfs://motp02/hbase/data/default/TBL_TABLE_CODE/ec69674133ba425f63cedfc686b70823/d/b8d1e9859cab41e9900b326ce5f65ab2,
entries=457848, sequenceid=38340778, filesize=6.6 M
2019-08-16 09:38:29,259 INFO [RS_OPEN_REGION-prod004:60020-2]
regionserver.HRegion: Finished memstore flush of ~53.96 MB/56580048,
currentsize=0 B/0 for region
TBL_TABLE_CODE,\x110090011599kySHLF;,1561791629538.ec69674133ba425f63cedfc686b70823.
in 2074ms, sequenceid=38340778, compaction requested=true; wal=null
2019-08-16 09:38:29,328 INFO [RS_OPEN_REGION-prod004:60020-2]
regionserver.HRegion: Onlined ec69674133ba425f63cedfc686b70823; next
sequenceid=38340779
2019-08-16 09:38:29,353 INFO
[PostOpenDeployTasks:ec69674133ba425f63cedfc686b70823]
[jira] [Commented] (HBASE-22862) Region Server crash with: Added a key not lexically larger than previous
[
https://issues.apache.org/jira/browse/HBASE-22862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909770#comment-16909770
]
Alex Batyrshin commented on HBASE-22862:
Error occurs on MemStore flush.
Looks like replay from WAL has no error.
Latest log dump with crush and replays:
{code}
2019-08-16 09:36:40,926 FATAL [MemStoreFlusher.1] regionserver.HRegionServer:
ABORTING region server prod004,60020,1565928847135: Replay of WAL required.
Forcing server shutdown
org.apache.hadoop.hbase.DroppedSnapshotException: region:
TBL_TABLE_CODE,\x110090011599kySHLF;,1561791629538.ec69674133ba425f63cedfc686b70823.
at
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2675)
at
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2352)
at
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2314)
at
org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2200)
at org.apache.hadoop.hbase.regionserver.HRegion.flush(HRegion.java:2125)
at
org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:512)
at
org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:482)
at
org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$900(MemStoreFlusher.java:76)
at
org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:264)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.io.IOException: Added a key not lexically larger than previous.
Current cell =
\x110090013098!>ct94a/d:apd/1565936313172/DeleteColumn/vlen=0/seqid=38334251,
lastCell =
\x110090013098!>ct94a/d:apd/1565936313172/Put/vlen=12/seqid=38338239
at
org.apache.hadoop.hbase.io.hfile.AbstractHFileWriter.checkKey(AbstractHFileWriter.java:204)
at
org.apache.hadoop.hbase.io.hfile.HFileWriterV2.append(HFileWriterV2.java:279)
at
org.apache.hadoop.hbase.io.hfile.HFileWriterV3.append(HFileWriterV3.java:87)
at
org.apache.hadoop.hbase.regionserver.StoreFile$Writer.append(StoreFile.java:1127)
at
org.apache.hadoop.hbase.regionserver.StoreFlusher.performFlush(StoreFlusher.java:139)
at
org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:75)
at
org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:1003)
at
org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.flushCache(HStore.java:2523)
at
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2622)
... 9 more
2019-08-16 09:36:41,516 INFO [RS_CLOSE_REGION-prod004:60020-1]
regionserver.HRegion: Closed
TBL_TABLE_CODE,\x110090011599kySHLF;,1561791629538.ec69674133ba425f63cedfc686b70823.
2019-08-16 09:36:54,944 INFO
[RpcServer.priority.FPBQ.Fifo.handler=19,queue=1,port=60020]
regionserver.RSRpcServices: Open
TBL_TABLE_CODE,\x110090011599kySHLF;,1561791629538.ec69674133ba425f63cedfc686b70823.
2019-08-16 09:37:39,164 INFO [RS_OPEN_REGION-prod004:60020-2]
regionserver.HRegion: Replaying edits from
hdfs://motp02/hbase/default/TBL_TABLE_CODE/ec69674133ba425f63cedfc686b70823/recovered.edits/00038324857
...
2019-08-16 09:38:24,017 INFO [RS_OPEN_REGION-prod004:60020-2]
regionserver.HRegion: Replaying edits from
hdfs://motp02/hbase/default/TBL_TABLE_CODE/ec69674133ba425f63cedfc686b70823/recovered.edits/00038340778
2019-08-16 09:38:27,185 INFO [RS_OPEN_REGION-prod004:60020-2]
regionserver.HRegion: Flushing 1/1 column families, memstore=53.96 MB; WAL is
null, using passed sequenceid=38340778
2019-08-16 09:38:29,203 INFO [RS_OPEN_REGION-prod004:60020-2]
regionserver.DefaultStoreFlusher: Flushed, sequenceid=38340778, memsize=54.0 M,
hasBloomFilter=false, into tmp file
hdfs://motp02/hbase/data/default/TBL_TABLE_CODE/ec69674133ba425f63cedfc686b70823/.tmp/b8d1e9859cab41e9900b326ce5f65ab2
2019-08-16 09:38:29,258 INFO [RS_OPEN_REGION-prod004:60020-2]
regionserver.HStore: Added
hdfs://motp02/hbase/data/default/TBL_TABLE_CODE/ec69674133ba425f63cedfc686b70823/d/b8d1e9859cab41e9900b326ce5f65ab2,
entries=457848, sequenceid=38340778, filesize=6.6 M
2019-08-16 09:38:29,259 INFO [RS_OPEN_REGION-prod004:60020-2]
regionserver.HRegion: Finished memstore flush of ~53.96 MB/56580048,
currentsize=0 B/0 for region
TBL_TABLE_CODE,\x110090011599kySHLF;,1561791629538.ec69674133ba425f63cedfc686b70823.
in 2074ms, sequenceid=38340778, compaction requested=true; wal=null
2019-08-16 09:38:29,328 INFO [RS_OPEN_REGION-prod004:60020-2]
regionserver.HRegion: Onlined ec69674133ba425f63cedfc686b70823; next
sequenceid=38340779
2019-08-16 09:38:29,353 INFO
[PostOpenDeployTasks:ec69674133ba425f63cedfc686b70823]
regionserver.HRegionServer: Post open deploy tasks for
